----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/399/#review684 -----------------------------------------------------------
I'm not sure this change does what you think it does. those flags only mean that the packet has data storage allocated, it doesn't say anything about the validity of that data. I can't think of a good reason why someone external would need to know that the packet has data allocated. If that is what you're going for, then it should have a name that makes it clear that this just means storage, nothing about the protocol and a good doxygen comment. - Ali On 2011-01-06 16:13:49, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/399/ > ----------------------------------------------------------- > > (Updated 2011-01-06 16:13:49) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > packet: Added public method to identify valid data > > > Diffs > ----- > > src/mem/packet.hh 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/399/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
