----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/399/#review653 -----------------------------------------------------------
src/mem/packet.hh <http://reviews.m5sim.org/r/399/#comment891> Review board seems to be flagging some whitespace you have at the end of this line. The idea of this function seems fine but its name is a little awkward. How about hasData()? - Gabe On 2011-01-06 16:13:49, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/399/ > ----------------------------------------------------------- > > (Updated 2011-01-06 16:13:49) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > packet: Added public method to identify valid data > > > Diffs > ----- > > src/mem/packet.hh 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/399/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
