Re: [IP CLEARANCE] Apache Celix - Websocket pubsub admin
Thanks for your input as well Matt! Next time we'll discuss upfront whether IP clearance is necessary or not. Consider this case as a "better safe than sorry" one. With that said, 72 hours have passed so the vote is closed with the following results: +1: Furkan Kamaci Matt Sicker Roy Lenferink (hereby adding my +1) No -1 votes have been cast. Thanks all for your input, Roy Op wo 21 aug. 2019 om 20:21 schreef Matt Sicker : > I would think that if the person who submits the PR has the rights to > make that contribution, then their ICLA should cover that. See > https://www.apache.org/licenses/contributor-agreements.html for more > info. > > On Wed, 21 Aug 2019 at 11:49, Roy Lenferink > wrote: > > > > > Given it was already had a ASF license header and from a ASF project > why > > was IP clearance even needed? I assume the person involved has signed a > > ICLA? > > > > The individual contributors all submitted an ICLA and a CCLA for the > > company is already present. We were following IP clearance > > because the written software was developed outside of the ASF version > > control system (company internal VCS). After that, we squashed everything > > into a single commit and submitted it as a PR to Celix. > > > > Would IP clearance be necessary in this case (duplication of an already > > existing component)? Would IP clearance be necessary for new components > > which already have ASF headers in place? > > > > -- > Matt Sicker > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [IP CLEARANCE] Apache Celix - Websocket pubsub admin
I would think that if the person who submits the PR has the rights to make that contribution, then their ICLA should cover that. See https://www.apache.org/licenses/contributor-agreements.html for more info. On Wed, 21 Aug 2019 at 11:49, Roy Lenferink wrote: > > > Given it was already had a ASF license header and from a ASF project why > was IP clearance even needed? I assume the person involved has signed a > ICLA? > > The individual contributors all submitted an ICLA and a CCLA for the > company is already present. We were following IP clearance > because the written software was developed outside of the ASF version > control system (company internal VCS). After that, we squashed everything > into a single commit and submitted it as a PR to Celix. > > Would IP clearance be necessary in this case (duplication of an already > existing component)? Would IP clearance be necessary for new components > which already have ASF headers in place? -- Matt Sicker - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [IP CLEARANCE] Apache Celix - Websocket pubsub admin
> Given it was already had a ASF license header and from a ASF project why was IP clearance even needed? I assume the person involved has signed a ICLA? The individual contributors all submitted an ICLA and a CCLA for the company is already present. We were following IP clearance because the written software was developed outside of the ASF version control system (company internal VCS). After that, we squashed everything into a single commit and submitted it as a PR to Celix. Would IP clearance be necessary in this case (duplication of an already existing component)? Would IP clearance be necessary for new components which already have ASF headers in place?
Re: [IP CLEARANCE] Apache Celix - Websocket pubsub admin
> Thales has been sending SGAs for all their Celix PRs lately. Thales indeed sent 3 SGAs already. 1 definitely required: a complete new component (HTTP admin). This websocket pubsub admin and a tcp pubsub admin. All those were approached the same. -- Roy
Re: [IP CLEARANCE] Apache Celix - Websocket pubsub admin
Thales has been sending SGAs for all their Celix PRs lately. On Wed, 21 Aug 2019 at 05:35, Justin Mclean wrote: > > Hi, > > > The donation was developed by duplicating an existing Celix component > > (pubsub_admin_zmq)[1] to a new component (pubsub_admin_websocket)[2]. > > Then the contents of the files has been changed to use websockets instead > > of ZeroMQ. All this time the ASF header was kept in place. > > > Given it was already had a ASF license header and from a ASF project why was > IP clearance even needed? I assume the person involved has signed a ICLA? > > Thanks, > Justin > > 1. https://github.com/apache/celix/blob/master/NOTICE > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > -- Matt Sicker - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [IP CLEARANCE] Apache Celix - Websocket pubsub admin
Hi, > The donation was developed by duplicating an existing Celix component > (pubsub_admin_zmq)[1] to a new component (pubsub_admin_websocket)[2]. > Then the contents of the files has been changed to use websockets instead > of ZeroMQ. All this time the ASF header was kept in place. Given it was already had a ASF license header and from a ASF project why was IP clearance even needed? I assume the person involved has signed a ICLA? Thanks, Justin 1. https://github.com/apache/celix/blob/master/NOTICE - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [IP CLEARANCE] Apache Celix - Websocket pubsub admin
The donation was developed by duplicating an existing Celix component (pubsub_admin_zmq)[1] to a new component (pubsub_admin_websocket)[2]. Then the contents of the files has been changed to use websockets instead of ZeroMQ. All this time the ASF header was kept in place. [1] https://github.com/apache/celix/tree/develop/bundles/pubsub/pubsub_admin_zmq/src [2] https://github.com/dhbfischer/celix/tree/feature/websocket_pubsub_admin/bundles/pubsub/pubsub_admin_websocket/src Op wo 21 aug. 2019 om 08:57 schreef Justin Mclean : > Hi, > > > For Celix is it okay to continue if we update the NOTICE file and add the > > following statement?: > > > > This product includes software developed at > > Thales Nederland B.V. (https://www.thalesgroup.com/nl). > > That sounds fine to me, but it depends on the original headers of on those > files or if the original source had it own NOTICE file, with a PR like this > missing that information I cannot really answer that question. > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [IP CLEARANCE] Apache Celix - Websocket pubsub admin
Hi, > For Celix is it okay to continue if we update the NOTICE file and add the > following statement?: > > This product includes software developed at > Thales Nederland B.V. (https://www.thalesgroup.com/nl). That sounds fine to me, but it depends on the original headers of on those files or if the original source had it own NOTICE file, with a PR like this missing that information I cannot really answer that question. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [IP CLEARANCE] Apache Celix - Websocket pubsub admin
Hi, > Thanks for reviewing. Isn't this actually part of the IP clearance form > which describes the following: >> Check and make sure that the files that have been donated have been > updated to reflect the new ASF copyright. I believe the intention is that you fill in the date when it is done, not do it before ether donation. [1] Otherwise is hard to work out from a PR what was actually donated and if any of it belonged to the ASF before hand. changing i after the donation gives a clear commit you can point to which may be useful if the IP history ever needs to be looked at. Thanks, Justin 1. https://incubator.apache.org/ip-clearance/ip-clearance-template.html - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [IP CLEARANCE] Apache Celix - Websocket pubsub admin
Hi Justin, Thanks for reviewing. Isn't this actually part of the IP clearance form which describes the following: > Check and make sure that the files that have been donated have been updated to reflect the new ASF copyright. Having a look at other IP clearances they are more or less doing the same (just picked 2 random ones): For Apache Arrow: http://incubator.apache.org/ip-clearance/arrow-gandiva.html which matches with pull request: https://github.com/apache/arrow/pull/2558 For Apache Beam: http://incubator.apache.org/ip-clearance/beam-zetasql-translator.html which matches with pull request: https://github.com/apache/beam/pull/9210 I noticed that Beam its NOTICE file already contained the statement that the project includes source code developed by Google. For Celix is it okay to continue if we update the NOTICE file and add the following statement?: This product includes software developed at Thales Nederland B.V. (https://www.thalesgroup.com/nl). Thanks, Roy Op wo 21 aug. 2019 om 06:06 schreef Justin Mclean : > Hi, > > > The pull request containing the donation can be found at: > > https://github.com/apache/celix/pull/39 > > I can see that the copyright owner / headers have been replaces by ASF > ones. This is best done after accepting the donation and then adding that > copyright to NOTICE. > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [IP CLEARANCE] Apache Celix - Websocket pubsub admin
Hi, > The pull request containing the donation can be found at: > https://github.com/apache/celix/pull/39 I can see that the copyright owner / headers have been replaces by ASF ones. This is best done after accepting the donation and then adding that copyright to NOTICE. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [IP CLEARANCE] Apache Celix - Websocket pubsub admin
+1 On Tue, 20 Aug 2019 at 00:39, Furkan KAMACI wrote: > > Hi, > > +1 > > Kind Regards, > Furkan KAMACI > > 20 Ağu 2019 Sal, saat 08:04 tarihinde Roy Lenferink > şunu yazdı: > > > Hi all, > > > > Apache Celix received a donation which adds an additional pubsub admin > > to Celix. This pubsub admin uses websockets as communication technique > > and can be used next to the existing ZeroMQ, TCP or UDP multicast pubsub > > admins. No new third party dependencies are added. > > > > The IP clearance form can be found at: > > http://incubator.apache.org/ip-clearance/celix-pubsub-admin-websocket.html > > > > The pull request containing the donation can be found at: > > https://github.com/apache/celix/pull/39 > > > > Please vote to approve this contribution. Lazy consensus applies: > > if no -1 votes are being cast within the next 72 hours, the vote passes. > > > > Greetings, > > Roy > > -- Matt Sicker - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [IP CLEARANCE] Apache Celix - Websocket pubsub admin
Hi, +1 Kind Regards, Furkan KAMACI 20 Ağu 2019 Sal, saat 08:04 tarihinde Roy Lenferink şunu yazdı: > Hi all, > > Apache Celix received a donation which adds an additional pubsub admin > to Celix. This pubsub admin uses websockets as communication technique > and can be used next to the existing ZeroMQ, TCP or UDP multicast pubsub > admins. No new third party dependencies are added. > > The IP clearance form can be found at: > http://incubator.apache.org/ip-clearance/celix-pubsub-admin-websocket.html > > The pull request containing the donation can be found at: > https://github.com/apache/celix/pull/39 > > Please vote to approve this contribution. Lazy consensus applies: > if no -1 votes are being cast within the next 72 hours, the vote passes. > > Greetings, > Roy >
