Re: [gentoo-dev] Trivial commit reviews

2007-09-24 Thread Matti Bickel
Mike Doty [EMAIL PROTECTED] wrote:
 Donnie Berkholz wrote:
 Over time, the number of these simple reviews should go dramatically down 
 so it no longer bothers anyone to see them. If it doesn't, that means some 
 of our developers aren't learning or paying attention, and we should take 
 a closer look at whether they should remain developers.

 My concern is that if we flood -dev with trivial commit problems then 
 more people will stop watching -dev and/or resort to killfiles or other 
 filtering.  While I do agree with Donnies assessment, my concern is that 
 over a longer time period, it might have a negative effect.

I totally agree with Donnie here. Please keep up the work, everybody
should be encouraged to fix these (trivial) problems. I sincerly hope
that these message will not have to continue for long. But as long as
they do, they serve as a big reminder in your inbox of what is wrong.

Just my 0.02$
-- 
Regards, Matti Bickel
Signed/Encrypted email preferred (key 4849EC6C)


pgpSepMsMY6j8.pgp
Description: PGP signature


[gentoo-dev] Ebuild QA (was Re: Trivial commit reviews)

2007-09-24 Thread Steve Long
Donnie Berkholz wrote:
 On 06:22 Mon 24 Sep , Thilo Bangert wrote:
 also, perhaps the more common ones should additionally be converted to
 repoman tests, if that is feasable.
 
 That might be reasonable for some cases, but it won't be perfect, and
 won't even be possible for many.

Which are the cases you (and others ofc) think it would be reasonable for?
 
 So far, the only one I've seen that might work well for is quoting
 around specific variables. You could do something like a grep for words
 containing '${+D[^[:alnum:]-_]' (haven't tested that, just beginnings of
 an idea) and the same for S and WORKDIR.
 
marienz mentioned something similar a few months ago, wrt allowing unquoted
expansions for specific vars that are used in eg for loops (like A or
SRC_URI) and not for any others.

ed(1) really is the tool to use for that -- g/RegEx/p does exactly what grep
does, and there's no compatibility issue for FreeBSD vs Linux. (It's also a
lot more capable than sed, and there really is no need for awk in this
instance.)

1) http://bash-hackers.org/wiki/doku.php?id=howto:edit-ed


-- 
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] Ebuild QA (was Re: Trivial commit reviews)

2007-09-24 Thread Donnie Berkholz
On 09:55 Mon 24 Sep , Steve Long wrote:
 Donnie Berkholz wrote:
  On 06:22 Mon 24 Sep , Thilo Bangert wrote:
  also, perhaps the more common ones should additionally be converted to
  repoman tests, if that is feasable.
  
  That might be reasonable for some cases, but it won't be perfect, and
  won't even be possible for many.
 
 Which are the cases you (and others ofc) think it would be reasonable for?

I don't think we've yet discovered what all the common cases are. As the 
current top issues drop because people check for them, these reviews 
will likely begin to reveal new top issues, as the quoting is now.

 ed(1) really is the tool to use for that -- g/RegEx/p does exactly what grep
 does, and there's no compatibility issue for FreeBSD vs Linux. (It's also a
 lot more capable than sed, and there really is no need for awk in this
 instance.)

The problem with using ed in Gentoo is that nobody (figuratively) knows 
how to use it. This means nobody can spot problems with others' use of 
it. Our standard set of ebuild tools is pretty much:

bash
grep
sed
awk

Even if it's not the most elegant solution technically, it's the one 
that works best when you consider the bigger picture of our developers' 
skills.

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list



[gentoo-dev] New developer : Timo Gurr (tgurr)

2007-09-24 Thread Denis Dupeyron
It's my pleasure to introduce Timo Gurr (tgurr) who will join us as a
new developer. He will work primarily on KDE and printing.

Timo lives in Neckarsulm, Germany, and works as an IT technician in a
local city administration near his home. He finds his job very
interesting and loves it, and even runs some Gentoo machines there.
His interests are very wide-ranging and he likes to play a good game
from time to time. This makes him believe he is a pretty normal guy.
Well, let me tell you something, Timo. You've just entered
Gentoo-land, so please leave all normality at the gate. Thanks for
your understanding.

Let's all give him a very warm welcome.

Denis.
-- 
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?

2007-09-24 Thread Lars Weiler
* Robin H. Johnson [EMAIL PROTECTED] [07/09/18 17:23 -0700]:
 Reply-To on gentoo-commits is already set to [EMAIL PROTECTED]

I guess this is set by the mailing-list-software?  That
collides with https://bugs.gentoo.org/193376.

Regards, Lars

-- 
Lars Weiler  [EMAIL PROTECTED]  +49-171-1963258
Instant Messaging : [EMAIL PROTECTED]
Gentoo Linux PowerPC  : Developer
Gentoo Infrastructure : CVS/SVN Administrator


pgpaRxLT7zb2x.pgp
Description: PGP signature


[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-lang/ruby: ChangeLog ruby-1.8.6_p110.ebuild

2007-09-24 Thread Donnie Berkholz
On 09:38 Mon 24 Sep , Richard Brown (rbrown) wrote:
 rbrown  07/09/24 09:38:33
 
   Modified: ChangeLog
   Added:ruby-1.8.6_p110.ebuild
   Log:
   Version bump
   (Portage version: 2.1.3.9)

 1.1  dev-lang/ruby/ruby-1.8.6_p110.ebuild
 
 file : 
 http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-lang/ruby/ruby-1.8.6_p110.ebuild?rev=1.1view=markup
 plain: 
 http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-lang/ruby/ruby-1.8.6_p110.ebuild?rev=1.1content-type=text/plain

 SRC_URI=ftp://ftp.ruby-lang.org/pub/ruby/1.8/${MY_P}.tar.gz

 SLOT=1.8

   !=dev-lang/ruby-cvs-1.8*

Would be nice to see all instances of 1.8 use hacked-up PV instead, for 
easier bumps to 1.9 etc.

   econf --with-rubydir=${S} || die econf failed

   LD_LIBRARY_PATH=${D}/usr/$(get_libdir)
   RUBYLIB=${S}:${D}/usr/$(get_libdir)/ruby/${SLOT}
   for d in $(find ${S}/ext -type d) ; do

   cp -pPR sample ${D}/usr/share/doc/${PF}

   cp -pPR test ${D}/usr/share/${PN}-${SLOT}

Quotes ...

   make DESTDIR=${D} install-doc || die make install-doc failed

Why not emake?

   if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
   ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}

   if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
   ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
   fi

ROOT can have spaces in it too.

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list



[gentoo-dev] Automated Package Removal and Addition Tracker, for the week ending 2007-09-23 23h59 UTC

2007-09-24 Thread Robin H. Johnson
The attached list notes all of the packages that were added or removed
from the tree, for the week ending 2007-09-23 23h59 UTC.

Removals:
net-im/micq 2007-09-17 10:51:07 jokey
media-plugins/vdr-weatherng-images  2007-09-19 16:10:54 hd_brummy
games-arcade/smclone2007-09-21 15:28:33 nyhm

Additions:
net-im/climm2007-09-17 10:48:41 jokey
dev-libs/libx86 2007-09-17 13:03:55 alonbl
sys-power/suspend   2007-09-17 13:15:55 alonbl
media-sound/jokosher2007-09-17 16:19:02 drac
app-crypt/gifshuffle2007-09-18 15:18:23 drizzt
app-pda/jpilot-Mail 2007-09-18 17:11:15 philantrop
games-arcade/smc2007-09-21 15:26:34 nyhm
dev-ruby/png2007-09-21 23:03:01 agorf
net-misc/s3cmd  2007-09-23 00:07:05 jmglov
app-emacs/fff   2007-09-23 21:17:21 ulm
app-emacs/mic-paren 2007-09-23 21:17:57 ulm

--
Robin Hugh Johnson
Gentoo Linux Developer
E-Mail : [EMAIL PROTECTED]
GnuPG FP   : 11AC BA4F 4778 E3F6 E4ED  F38E B27B 944E 3488 4E85
Removed Packages:
net-im/micq,removed,jokey,2007-09-17 10:51:07
media-plugins/vdr-weatherng-images,removed,hd_brummy,2007-09-19 16:10:54
games-arcade/smclone,removed,nyhm,2007-09-21 15:28:33
Added Packages:
net-im/climm,added,jokey,2007-09-17 10:48:41
dev-libs/libx86,added,alonbl,2007-09-17 13:03:55
sys-power/suspend,added,alonbl,2007-09-17 13:15:55
media-sound/jokosher,added,drac,2007-09-17 16:19:02
app-crypt/gifshuffle,added,drizzt,2007-09-18 15:18:23
app-pda/jpilot-Mail,added,philantrop,2007-09-18 17:11:15
games-arcade/smc,added,nyhm,2007-09-21 15:26:34
dev-ruby/png,added,agorf,2007-09-21 23:03:01
net-misc/s3cmd,added,jmglov,2007-09-23 00:07:05
app-emacs/fff,added,ulm,2007-09-23 21:17:21
app-emacs/mic-paren,added,ulm,2007-09-23 21:17:57

Done.

[gentoo-dev] Re: New developer : Timo Gurr (tgurr)

2007-09-24 Thread Christian Faulhammer
Denis Dupeyron [EMAIL PROTECTED]:

 Let's all give him a very warm welcome.

 Wanna have some cake and coffee?  Or do you prefer Spätzle?

V-Li

-- 
Christian Faulhammer, Gentoo Lisp project
URL:http://www.gentoo.org/proj/en/lisp/, #gentoo-lisp on FreeNode

URL:http://www.faulhammer.org/


signature.asc
Description: PGP signature


Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-lang/ruby: ChangeLog ruby-1.8.6_p110.ebuild

2007-09-24 Thread Mike Frysinger
On Monday 24 September 2007, Donnie Berkholz wrote:
 On 09:38 Mon 24 Sep , Richard Brown (rbrown) wrote:
  if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
  ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
 
  if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
  ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
  fi

 ROOT can have spaces in it too.

this is why the form:
[[ -n $(readlink ${ROOT}usr/bin/ruby) ]]
is preferred ... much easier to read and no nested quotes
-mike


signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] turn the local xattr useflags into a global one ?

2007-09-24 Thread Mike Frysinger
On Sunday 23 September 2007, Rémi Cardona wrote:
 Gnome Herd is about to add a fifth package (gedit-2.20.0) that will use
 the xattr useflag. Are there any objections to making it a global
 useflag?

sounds like a good idea to me as xattr is about the same class as acl
-mike


signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] Why isn't /root/.bash_profile in the stage tarballs?

2007-09-24 Thread Mike Frysinger
On Sunday 23 September 2007, John R. Graham wrote:
 On Thursday 20 September 2007, Mike Frysinger wrote:
  no, this cannot live in baselayout (the package that creates /root/),
  because it cannot be run everytime a user upgrades the baselayout
  package.  no, it cannot be tied to USE=build (used to make stage1) or
  USE=bootstrap (use to make stage2) as the only time the /etc/skel/ -
  /root/ sync can sanely happen is in the final steps of creating a stage3
  ... and there is nothing to differentiate the creation of a stage3 from a
  normal build, nor is there a sane way to make sure baselayout is the very
  last package in the stage3 build step

 Mike, for my own education (well, mostly), could you clarify why putting
 the copy of the appropriate files from /etc/skel - /root into the
 ebuild that creates them but tying that special action to USE=build
 isn't an acceptable solution?  You've said that it would mean a special
 case for each ebuild that puts things into /etc/skel, but I believe
 we're talking about one or two ebuilds here, and, besides, isn't the
 ebuild the appropriate place for that sort of expertise to reside, or at
 least, not an inappropriate place?

the /etc/skel - /root sync needs to happen at the very end of stage3 as that 
is the only place where you can state all packages relevant to a default 
install have been merged

USE=build is for building a stage1 and generally speaking, there is no reason 
why baselayout cant be merged before any other package ... pretty much any 
depend listed in the baselayout ebuild are there to force a specific minimal 
version of a package and over time get dropped
-mike


signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-lang/ruby: ChangeLog ruby-1.8.6_p110.ebuild

2007-09-24 Thread René 'Necoro' Neumann
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Mike Frysinger schrieb:
 On Monday 24 September 2007, Donnie Berkholz wrote:
 On 09:38 Mon 24 Sep , Richard Brown (rbrown) wrote:
 if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
 ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}

 if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
 ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
 fi
 ROOT can have spaces in it too.
 
 this is why the form:
 [[ -n $(readlink ${ROOT}usr/bin/ruby) ]]
 is preferred ... much easier to read and no nested quotes
 -mike

And: [[ ! -n ... ]] transforms to [[ -z ... ]]

Or am I wrong?

Regards,
- -- Necoro
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG+A/04UOg/zhYFuARAg/dAJ9I5m/p7crLGG9JkIMu2vigtXlXVQCeLJwj
/zofTwO9Vtf+mu6EBYT8XiE=
=NIoO
-END PGP SIGNATURE-
-- 
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] Re: Re: Why isn't /root/.bash_profile in the stage tarballs?

2007-09-24 Thread Mike Frysinger
On Saturday 22 September 2007, Andrew Gaffney wrote:
 Steve Long wrote:
  Great. What exactly? How does fulfilling the user requirement with
  vapier's solution mess up catalyst?

 This is the the first time I've heard of a user requesting this change. It
 seems to me that many people prefer to *not* have a .bash{rc,_profile} in
 /root

sure, people with irrational (from the point of Gentoo) fears

actually read the default files and you'll see they're pretty much helpful 
explanatory comments ... except for the logout file where it runs `clear` and 
no one wants *that* for root

 which is the way it's always been.

on Gentoo, yes, it's been this way *so far*, but not for other distros

 Why not just add the ability to  
 copy these files with 'emerge --config' to certain ebuilds, and then add a
 note to the handbook telling users to run the command if they want to?

running commands to get a sane default is not user friendly

 Even better, just tell the users to run 'cp -a /etc/skel/* /root/' if they
 really want the stuff, and not modify any ebuilds at all?

since it wont work at all ... i dont think ive ever seen /etc/skel/ have 
something which didnt start with a .
-mike


signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] Why isn't /root/.bash_profile in the stage tarballs?

2007-09-24 Thread Mike Frysinger
On Friday 21 September 2007, Chris Gianelloni wrote:
 On Fri, 2007-09-21 at 17:45 -0400, Mike Frysinger wrote:
  the compromise is simple: catalyst runs --config at the end of stage3 for
  appropriate packages, but as to what those things actually do is left in
  the ebuilds.

 I've already stated my preference for not doing *anything* outside of
 merging packages in the stages.  Were this stage3, I wouldn't care.
 Anyway, I'd much rather leave everything as it is now than add the
 emerge --config stuff.  You're free to add it to the ebuilds, of course,
 which would satisfy the people that want it, but I would prefer not add
 it to the stages, even if it is documented in the Handbook, as it isn't
 required.  Basically, I'd rather we either throw it into the earlier
 stages, or not do it at all.  You've given good reason on why, while
 technically feasible since we're only caring about bash at this time, it
 is still a bad idea as it opens us up to yet another slippery slope.  I
 completely see your point, which is why I'm taking the stance that
 things are best left as they are now.

defaults are never a requirement, but they provide a nice initial/sane 
environment

we should really rename build to stage1, bootstrap to stage2, and then 
have catalyst add USE=stage3 during the stage3 step ... that would allow 
packages to automatically key off of the environment
-mike


signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-lang/ruby: ChangeLog ruby-1.8.6_p110.ebuild

2007-09-24 Thread Mike Frysinger
On Monday 24 September 2007, René 'Necoro' Neumann wrote:
 Mike Frysinger schrieb:
  On Monday 24 September 2007, Donnie Berkholz wrote:
  On 09:38 Mon 24 Sep , Richard Brown (rbrown) wrote:
if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
 
if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
fi
 
  ROOT can have spaces in it too.
 
  this is why the form:
  [[ -n $(readlink ${ROOT}usr/bin/ruby) ]]
  is preferred ... much easier to read and no nested quotes

 And: [[ ! -n ... ]] transforms to [[ -z ... ]]

! -n and -z are equivalent but there are no standards from the point of view 
of Gentoo ... this is purely whatever logic happens to spew out of the head 
of the developer as he composes the ebuild
-mike


signature.asc
Description: This is a digitally signed message part.


[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-emacs/chess: ChangeLog chess-2.0_beta5-r4.ebuild chess-2.0_beta6.ebuild chess-2.0_beta5-r3.ebuild

2007-09-24 Thread Christian Faulhammer
Ulrich Mueller (ulm) [EMAIL PROTECTED]:

   Added:chess-2.0_beta5-r4.ebuild
 chess-2.0_beta6.ebuild
   epatch ${FILESDIR}/${PV}-byte-compiling-files-gentoo.patch \
   || die epatch failed

 epatch dies on its own.

V-Li

-- 
Christian Faulhammer, Gentoo Lisp project
URL:http://www.gentoo.org/proj/en/lisp/, #gentoo-lisp on FreeNode

URL:http://www.faulhammer.org/


signature.asc
Description: PGP signature


Re: [gentoo-dev] New developer : Timo Gurr (tgurr)

2007-09-24 Thread Wulf C. Krueger

Well, let me tell you something, Timo. You've just entered
Gentoo-land, so please leave all normality at the gate. Thanks for
your understanding.


Well, I've been working long enough with him to know that his  
definitely not normal - I leave it to the reader to figure out if  
that's good or bad... ;-)


Welcome amongst our rank, Timo, and don't break poor KDE. ;-)

--
Best regards, Wulf


pgp9uoRCtcOzl.pgp
Description: PGP Digital Signature


Re: [gentoo-dev] Re: Gentoo vmware/virtualbox/qemu images

2007-09-24 Thread Ramon van Alteren

Chris,

Chris Gianelloni wrote:

Currently, Release Engineering is quite understaffed.  We have lost a
few release coordinators between the last release and now.  The arch
teams are picking up the slack and getting people to fill the roles, but
they have to be trained, which means more time spent training and less
time spent working, which delays a release fairly significantly.  


Are you still looking for staff ? What roles/positions/work needs doing 
most ?


Are you aware that http://www.gentoo.org/proj/en/devrel/staffing-needs/ 
lists no staffing needs for release engineering ?


Where do I volunteer and what amount of time-investment can I expect ?

Ramon



--
[EMAIL PROTECTED] mailing list



[gentoo-dev] Re: Why isn't /root/.bash_profile in the stage tarballs?

2007-09-24 Thread Steve Long
Mike Frysinger wrote:
 we should really rename build to stage1, bootstrap to stage2, and
 then have catalyst add USE=stage3 during the stage3 step ... that would
 allow packages to automatically key off of the environment

That sounds clean too. You could use install to make the transition
painless (unless someone just added that USE flag, or it's not
politically-correct ofc.)


-- 
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] Why isn't /root/.bash_profile in the stage tarballs?

2007-09-24 Thread Andrew Gaffney

Mike Frysinger wrote:
we should really rename build to stage1, bootstrap to stage2, and then 
have catalyst add USE=stage3 during the stage3 step ... that would allow 
packages to automatically key off of the environment


I like this idea (hurray clarity!), but it would add an extra possibly 
undocumented step for a user to build a system from stage1 (since we don't 
support stage[12]-stage3 anymore). It would also cause whichever packages that 
use the 'stage3' flag to be needlessly rebuilt with the first 'emerge -uDN world'.


Personally, I don't see either of these relatively minor issues as show 
stoppers.

--
Andrew Gaffney http://dev.gentoo.org/~agaffney/
Gentoo Linux Developer Catalyst/Installer + x86 release coordinator
--
[EMAIL PROTECTED] mailing list



[gentoo-dev] Re: New developer : Timo Gurr (tgurr)

2007-09-24 Thread Steve Long
Denis Dupeyron wrote:

 Timo lives in Neckarsulm, Germany, and works as an IT technician in a
 local city administration near his home. He finds his job very
 interesting and loves it, and even runs some Gentoo machines there.
m00!
 His interests are very wide-ranging and he likes to play a good game
 from time to time.
/me sets larryTheClan.com on tgurr. What's that, Pooh?

 This makes him believe he is a pretty normal guy. 
 Well, let me tell you something, Timo. You've just entered
 Gentoo-land, so please leave all normality at the gate.
Er, :oops:.
 Thanks for your understanding.
 
 Let's all give him a very warm welcome.
 
/me watches fragalot launch a few cluster-bombs. Looks warm enough to me? ;)

Willkommen, Timo.


-- 
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?

2007-09-24 Thread Jeffrey Gardner
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Lars Weiler wrote:
 * Robin H. Johnson [EMAIL PROTECTED] [07/09/18 17:23 -0700]:
 Reply-To on gentoo-commits is already set to [EMAIL PROTECTED]
 
 I guess this is set by the mailing-list-software?  That
 collides with https://bugs.gentoo.org/193376.
 
 Regards, Lars
 

Please keep the commit reviews coming on gentoo-dev.

- --
Jeffrey Gardner
Gentoo Developer
Public PGP Key ID: 4A5D8F23
hkp://pgpkeys.mit.edu
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG99PSiR2KxEpdjyMRAmEPAKDUame55tLUcfBmlHZzLw2B8v06hACgjQgN
vOWNCpSbLXI89ROatHwgOwM=
=zQ7Z
-END PGP SIGNATURE-
-- 
[EMAIL PROTECTED] mailing list



[gentoo-dev] Re: gentoo-x86 commit in dev-db/firebird: ChangeLog metadata.xml firebird-2.0.3.12981.0-r1.ebuild firebird-2.0.1.12855.0-r4.ebuild firebird-2.0.1.12855.0-r5.ebuild

2007-09-24 Thread Torsten Veller
* William L. Thomson Jr. [EMAIL PROTECTED]:
 On Sat, 2007-09-22 at 10:29 +0200, Torsten Veller wrote:
  * William Thomson (wltjr) [EMAIL PROTECTED]:
  
 mkdir -p ${WORKDIR}/../etc \
^^
  What is this?
  
 ${WORKDIR}/usr \
 ${WORKDIR}/var/log/firebird \
 ${WORKDIR}/var/run/firebird
 cd ${WORKDIR}/usr; ln -s ${WORKDIR}/${MY_P}/gen/firebird/bin
 cd ${WORKDIR}/../etc; ln -s ${WORKDIR}/${MY_P}/gen/firebird firebird
  
  
 
 It's symlinks so the runtime changes as to Firebirds don't prevent the
 build system from completing. Since the build system and normal Firebird
 installs expect everything to be under one directory. Not split into
 many. Nothing gets placed there, and they only act as links.

Well, I don't understand why you have to work outside of WORKDIR.
(${WORKDIR}/../)

-- 
.:   Torsten Veller   |  :.
-- 
[EMAIL PROTECTED] mailing list



[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/wxglade: ChangeLog wxglade-0.6.ebuild

2007-09-24 Thread Torsten Veller
* Donnie Berkholz [EMAIL PROTECTED]:
 On 01:35 Mon 24 Sep , Ryan Hill (dirtyepic) wrote:
  dirtyepic07/09/24 01:35:38
  
Modified: ChangeLog
Added:wxglade-0.6.ebuild
Log:
Version bump.
(Portage version: 2.1.3.9)
 
  pkg_postinst() {
  python_mod_optimize 
  ${ROOT}usr/$(get_libdir)/python*/site-packages/wxglade
  }
  
  pkg_postrm() {
  python_mod_cleanup 
  ${ROOT}usr/$(get_libdir)/python*/site-packages/wxglade
  }

What do we expect using an eclass function?

python_mod_optimize needs the optional argument prefixed with ROOT while
python_mod_cleanup adds ROOT for the optional argument itself.
So python_mod_cleanup above tries to do some cleaning in ${ROOT}/${ROOT}/...

Both functions should be used in pkg_{pre,post}install only? I
think the eclass should adjust the arguments itself then.
What are the conditions for python_mod_optimize for a ROOT!=/
build?
-- 
.:Torsten |  :.
-- 
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?

2007-09-24 Thread Lars Weiler
* Jeffrey Gardner [EMAIL PROTECTED] [07/09/24 10:12 -0500]:
 Please keep the commit reviews coming on gentoo-dev.

I will not change that.  The bug requests to send the
commit review to the original author as well.  That
decreases manual work for our main-reviewers as they
currently have to add the author into Cc manually.

Regards, Lars

-- 
Lars Weiler  [EMAIL PROTECTED]  +49-171-1963258
Instant Messaging : [EMAIL PROTECTED]
Gentoo Linux PowerPC  : Developer
Gentoo Infrastructure : CVS/SVN Administrator


pgphb2kMdpwr3.pgp
Description: PGP signature


Re: [gentoo-dev] New developer : Timo Gurr (tgurr)

2007-09-24 Thread Tobias Scherbaum
Denis Dupeyron wrote:
 It's my pleasure to introduce Timo Gurr (tgurr) who will join us as a
 new developer. He will work primarily on KDE and printing.
 
 Timo lives in Neckarsulm, Germany, and works as an IT technician in a
 local city administration near his home. He finds his job very
 interesting and loves it, and even runs some Gentoo machines there.
 His interests are very wide-ranging and he likes to play a good game
 from time to time. This makes him believe he is a pretty normal guy.
 Well, let me tell you something, Timo. You've just entered
 Gentoo-land, so please leave all normality at the gate. Thanks for
 your understanding.
 
 Let's all give him a very warm welcome.

Welcome Timo!

Seeing that you're working in the local city administration ...
gentoo-devs-working-in-public-services++ :P

/me mumbles something about not replying to the dev-announce-list ...

  Tobias

-- 
Gentoo Linux - Die Metadistribution
http://www.mitp.de/1769


signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil


Re: [gentoo-dev] Re: gentoo-x86 commit in dev-db/firebird: ChangeLog metadata.xml firebird-2.0.3.12981.0-r1.ebuild firebird-2.0.1.12855.0-r4.ebuild firebird-2.0.1.12855.0-r5.ebuild

2007-09-24 Thread William L. Thomson Jr.
On Mon, 2007-09-24 at 14:22 +0200, Torsten Veller wrote:
 * William L. Thomson Jr. [EMAIL PROTECTED]:
  On Sat, 2007-09-22 at 10:29 +0200, Torsten Veller wrote:
   * William Thomson (wltjr) [EMAIL PROTECTED]:
   
mkdir -p ${WORKDIR}/../etc \
 ^^
   What is this?
   
${WORKDIR}/usr \
${WORKDIR}/var/log/firebird \
${WORKDIR}/var/run/firebird
cd ${WORKDIR}/usr; ln -s ${WORKDIR}/${MY_P}/gen/firebird/bin
cd ${WORKDIR}/../etc; ln -s ${WORKDIR}/${MY_P}/gen/firebird 
firebird
   
   
  
  It's symlinks so the runtime changes as to Firebirds don't prevent the
  build system from completing. Since the build system and normal Firebird
  installs expect everything to be under one directory. Not split into
  many. Nothing gets placed there, and they only act as links.
 
 Well, I don't understand why you have to work outside of WORKDIR.
 (${WORKDIR}/../)

Because Firebird expects everything in one dir.
Currently /usr/share/firebird. All paths are relative to that. I had to
modified relative paths by adding ../../../ to all paths. So
that ../../../ = / ideally. Although I think it's going to break in some
cases like chroots or etc. That way when it's base
in /usr/share/firebird, it can find stuff
in /etc/firebird, /usr/bin, /var/run/firebird, /var/log/firebird, etc.

So what happens is during build, those relative paths have the build
system looking outside of the workdir. I create dirs and symlinks so the
build system can find stuff inside the workdir, despite paths being
outside of it.

It's not pretty, maybe not ideal. But was the only way I could think of
to get things building, and allow for splitting up Firebird during
install per FHS. Without breaking runtime either.

Totally open for other suggestions and ideas of how to accomplish this.
I will provide feedback and info to upstream. So hopefully over time
this can be changed, and the hack of symlinks won't be needed during
build.


-- 
William L. Thomson Jr.
Gentoo/Java


signature.asc
Description: This is a digitally signed message part


Re: [gentoo-dev] meaning of sqlite/sqlite3 use flag

2007-09-24 Thread Alin Năstac
Mike Frysinger wrote:
 how about 'sqlite' means you want sqlite irregardless of version ... then 
 sqlite-2 either gets punted from apr-util or it gets a local USE 
 flag 'sqlite-old' for older cruft
   
Wouldn't be better to determine what version of sqlite should be used
based on the version of sqlite currently installed on the system?
Something like:
   sqlite_atom=$(best_version dev-db/sqlite)
   sqlite_major_version=${sqlite_atom#*/*-} #reduce it to $PV-$PR
   sqlite_major_version=${sqlite_major_version%%.*} # major version

   ... ebuild stuff...
   econf  \
 $(use_enable sqlite sqlite${sqlite_major_version})

Better yet, why not make an sqlite.eclass that would contain at least
get_sqlite_major_version()?



signature.asc
Description: OpenPGP digital signature


[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-office/magicpoint: ChangeLog magicpoint-1.12a.ebuild

2007-09-24 Thread Donnie Berkholz
On 09:58 Mon 24 Sep , Christian Faulhammer (opfer) wrote:
 opfer   07/09/24 09:58:29
 
   Modified: ChangeLog
   Added:magicpoint-1.12a.ebuild
   Log:
   version bump, a lot of bugfixes; on Gentoo side we have better Emacs 
 support; in total fixing bugs 150312, 83313 and 186754
   (Portage version: 2.1.3.9)

   # no parallel make possible!
   make -j1 Makefiles || die emake failed
   make clean || die emake clean failed
   make BINDIR=/usr/bin LIBDIR=/etc/X11 || die emake failed
   use emacs  cp contrib/*.el ${S}  \
   elisp-compile *.el || die elisp-compile failed
 }
 
 src_install() {
   make \
   DESTDIR=${D} \
   BINDIR=/usr/bin \
   LIBDIR=/etc/X11 \
   install || die make install
 
   make \
   DESTDIR=${D} \
   DOCHTMLDIR=/usr/share/doc/${PF} \
   MANPATH=/usr/share/man \
   MANSUFFIX=1 \
   install.man || die emake install.man failed

Why not emake for all of these?

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list



[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-gfx/splashutils: ChangeLog splashutils-1.5.2.1.ebuild

2007-09-24 Thread Michal Januszewski
On Sun, Sep 23, 2007 at 02:29:55PM -0700, Donnie Berkholz wrote:

  SRC_URI=mirror://berlios/fbsplash/${PN}-lite-${PV}.tar.bz2
  mirror://berlios/fbsplash/${GENTOOSPLASH}.tar.bz2
  mirror://gentoo/${MISCSPLASH}.tar.bz2
  mirror://sourceforge/libpng/libpng-${V_PNG}.tar.bz2
  ftp://ftp.uu.net/graphics/jpeg/jpegsrc.v${V_JPEG}.tar.gz
  mirror://sourceforge/freetype/freetype-${V_FT}.tar.bz2
  http://www.gzip.org/zlib/zlib-${V_ZLIB}.tar.bz2;
 
 Is there some way to avoid using bundled libs here? It really turns into 
 a PITA for security issues etc.

Not that I know of.  I need these libs to be compiled against klibc,
not glibc.  AFAIK I just have to build them along with the rest of
fbcondecor_helper.

  [..]
  else
  cp ${SG}/splash-functions-bl1.sh ${D}/sbin/splash-functions.sh
  fi
  
  sed -i -e s#/lib/splash#/${LIB}/splash# ${D}/sbin/splash-functions.sh
 
 Lots of places here where quotes should be added around variables that 
 can contain spaces.

Thanks, I've just submitted a change which should fix all of these in the
latest ebuild.

Best regards.
-- 
Michal Januszewski  JID: [EMAIL PROTECTED]
Gentoo Linux Developerhttp://people.gentoo.org/spock

-- 
[EMAIL PROTECTED] mailing list



[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-scheme/bigloo: ChangeLog bigloo-3.0b_p2.ebuild

2007-09-24 Thread Donnie Berkholz
On 12:35 Mon 24 Sep , Marijn Schouten (hkbst) wrote:
 hkbst   07/09/24 12:35:11
 
   Modified: ChangeLog
   Added:bigloo-3.0b_p2.ebuild
   Log:
   bump 3.0b-2, minor bugfix version
   (Portage version: 2.1.3.9)

 # make test does something weird so default src_test() in 
 /usr/lib/portage/bin/ebuild.sh fails the following test
 # elif emake -j1 test -n  /dev/null; then
 # so copy straight from default src_test() all the stuff which depends on 
 that test passing
 src_test() {
   vecho  Test phase [test]: ${CATEGORY}/${PF}
   if ! emake -j1 test; then
   hasq test $FEATURES  die Make test failed. See above for 
 details.
   hasq test $FEATURES || eerror Make test failed. See above for 
 details.
   fi
 }

I'm a bit confused about what's going on here. Isn't src_test() only 
supposed to run when 'test' is in FEATURES?

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list



[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-dotnet/libgdiplus: ChangeLog libgdiplus-1.2.5-r1.ebuild

2007-09-24 Thread Donnie Berkholz
On 17:26 Mon 24 Sep , Jurek Bartuszek (jurek) wrote:
 jurek   07/09/24 17:26:38
 
   Modified: ChangeLog
   Added:libgdiplus-1.2.5-r1.ebuild
   Log:
   dev-dotnet/libgdiplus-1.2.5-r1: Fix linking against image libraries (bug 
 #192068)
   (Portage version: 2.1.3.9)

   cd ${S}
 
   epatch ${FILESDIR}/${PN}-1.1.13-libungif-configure-fix.diff
   epatch ${FILESDIR}/${P}-imglibs.patch

Needs quotes for S and FILESDIR.

 src_compile() {
   if [[ $(gcc-major-version) -gt 3 ]] || \
  ( [[ $(gcc-major-version) -eq 3 ]]  [[ $(gcc-minor-version) 
 -gt 3 ]] )

Code block { } might be good here instead of a subshell, or perhaps it 
could use logic that's less convoluted such as if..then. Also don't need 
the double quotes.

   if use ppc ; then
   sed -i -e 's:-Werror::g' src/Makefile
   fi

We should never leave -Werror in -- make this unconditional. It tends to 
cause large quantities of packages to break every time there's a 
compiler upgrade.

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list



[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/ctags: ctags-5.6-r2.ebuild ChangeLog ctags-5.6-r3.ebuild ctags-5.7.ebuild ctags-5.6-r1.ebuild ctags-5.6.ebuild ctags-5.5.4-r3.ebuild

2007-09-24 Thread Donnie Berkholz
On 19:40 Mon 24 Sep , Ali Polatel (hawking) wrote:
 hawking 07/09/24 19:40:06
 
   Modified: ctags-5.6-r2.ebuild ChangeLog ctags-5.6-r3.ebuild
   Added:ctags-5.7.ebuild
   Removed:  ctags-5.6-r1.ebuild ctags-5.6.ebuild
 ctags-5.5.4-r3.ebuild
   Log:
   version bump. modified SRC_URI to get ada-mode depending on the ada use 
 flag. drop old.
   (Portage version: 2.1.3.9)

   mv ${D}/usr/bin/{ctags,exuberant-ctags}
   mv ${D}/usr/share/man/man1/{ctags,exuberant-ctags}.1

This ebuild did it right so many times, but missed a couple quotes for 
the D's here.

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list



[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-office/magicpoint: ChangeLog magicpoint-1.12a.ebuild

2007-09-24 Thread Christian Faulhammer
Donnie Berkholz [EMAIL PROTECTED]:

 On 09:58 Mon 24 Sep , Christian Faulhammer (opfer) wrote:
  opfer   07/09/24 09:58:29
  
Modified: ChangeLog
Added:magicpoint-1.12a.ebuild
Log:
version bump, a lot of bugfixes; on Gentoo side we have better
  Emacs support; in total fixing bugs 150312, 83313 and 186754
  (Portage version: 2.1.3.9)
 
  # no parallel make possible!
  make -j1 Makefiles || die emake failed
  make clean || die emake clean failed
  make BINDIR=/usr/bin LIBDIR=/etc/X11 || die emake failed
[...]
  make \
[...]
  make \
[...]
 Why not emake for all of these?

 Because it fails, magicpoint's build system is really old and weird.
The comment above should state that, but the leftover -j1 I tried would
confuse the reader.  Plus the stupid die comments.

V-Li
 
-- 
Christian Faulhammer, Gentoo Lisp project
URL:http://www.gentoo.org/proj/en/lisp/, #gentoo-lisp on FreeNode

URL:http://www.faulhammer.org/


signature.asc
Description: PGP signature


Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-office/magicpoint: ChangeLog magicpoint-1.12a.ebuild

2007-09-24 Thread Mike Frysinger
On Monday 24 September 2007, Christian Faulhammer wrote:
 Donnie Berkholz [EMAIL PROTECTED]:
  On 09:58 Mon 24 Sep , Christian Faulhammer (opfer) wrote:
   opfer   07/09/24 09:58:29
  
 Modified: ChangeLog
 Added:magicpoint-1.12a.ebuild
 Log:
 version bump, a lot of bugfixes; on Gentoo side we have better
   Emacs support; in total fixing bugs 150312, 83313 and 186754
   (Portage version: 2.1.3.9)
  
 # no parallel make possible!
 make -j1 Makefiles || die emake failed
 make clean || die emake clean failed
 make BINDIR=/usr/bin LIBDIR=/etc/X11 || die emake failed

 [...]

 make \

 [...]

 make \

 [...]

  Why not emake for all of these?

  Because it fails, magicpoint's build system is really old and weird.
 The comment above should state that, but the leftover -j1 I tried would
 confuse the reader.  Plus the stupid die comments.

most people associate emake with run in parallel when in reality, that is 
merely one of the things it provides

if something doesnt work in parallel, you use `emake -j1` ... using `make` 
generally doesnt make sense anywhere
-mike


signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/ctags: ctags-5.6-r2.ebuild ChangeLog ctags-5.6-r3.ebuild ctags-5.7.ebuild ctags-5.6-r1.ebuild ctags-5.6.ebuild ctags-5.5.4-r3.ebuild

2007-09-24 Thread Ali Polatel
Mon, Sep 24, 2007 at 12:59:16PM -0700 tarihinde, Donnie Berkholz yazmış:
 On 19:40 Mon 24 Sep , Ali Polatel (hawking) wrote:
  hawking 07/09/24 19:40:06
  
Modified: ctags-5.6-r2.ebuild ChangeLog ctags-5.6-r3.ebuild
Added:ctags-5.7.ebuild
Removed:  ctags-5.6-r1.ebuild ctags-5.6.ebuild
  ctags-5.5.4-r3.ebuild
Log:
version bump. modified SRC_URI to get ada-mode depending on the ada use 
  flag. drop old.
(Portage version: 2.1.3.9)
 
  mv ${D}/usr/bin/{ctags,exuberant-ctags}
  mv ${D}/usr/share/man/man1/{ctags,exuberant-ctags}.1
 
 This ebuild did it right so many times, but missed a couple quotes for 
 the D's here.
 
 Thanks,
 Donnie
 -- 
 [EMAIL PROTECTED] mailing list
 

fixed thanks

-- 
ali polatel (hawking)


pgpg7NLT6DOjT.pgp
Description: PGP signature


[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: ChangeLog udev-115-r6.ebuild

2007-09-24 Thread Donnie Berkholz
On 19:59 Mon 24 Sep , Matthias Schwarzott (zzam) wrote:
 zzam07/09/24 19:59:38
 
   Modified: ChangeLog
   Added:udev-115-r6.ebuild
   Log:
   Simplified rules a bit. Let user configure max inode nr of /dev, solving 
 bug #193586.
   (Portage version: 2.1.3.9)

 1.1  sys-fs/udev/udev-115-r6.ebuild
 
 file : 
 http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/udev/udev-115-r6.ebuild?rev=1.1view=markup
 plain: 
 http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/udev/udev-115-r6.ebuild?rev=1.1content-type=text/plain

   if [[ ${KV_MAJOR} == 2 ]]  [[ ${KV_MINOR} == 6 ]]  [[ 
 ${KV_MICRO} -ge 15 ]]; then
   if [[ $ok = 0 ]]; then
   if [ ${MD5} != 644e3c77eb866dee4ff8dda2e95cd187 ]
   if [[ -f packages/40-${ARCH}.rules ]]; then
   if [ -h ${ROOT}/etc/hotplug.d/default/udev.hotplug ]
   if [ -h ${ROOT}/etc/hotplug.d/default/05-wait_for_sysfs.hotplug ]
   if [ -h ${ROOT}/etc/hotplug.d/default/10-udev.hotplug ]
   if [ -f ${ROOT}/etc/init.d/coldplug ]
   if [[ ${coldplug_stale} == 1 ]] ; then
   if [[ -e ${ROOT}/etc/udev/rules.d/40-scsi-hotplug.rules ]]
   if [[ -d ${ROOT}/lib/udev/devices ]]; then
   if [[ -e ${ROOT}/etc/udev/rules.d/95-net.rules ]]; then
   if [[ -d ${ROOT}/etc/dev.d ]]; then
   if [[ -d ${ROOT}/etc/dev.d ]]; then
   [[ -f ${ROOT}/etc/udev/rules.d/64-device-mapper.rules ]] 
   if [[ ${ROOT} == / ]] ; then
   if [ -r /proc/1/root -a /proc/1/root/ -ef /proc/self/root/ ]; 
 then
   if [[ -n $(pidof udevd) ]] ; then
   MD5=`md5sum  ${S}/etc/udev/rules.d/50-udev-default.rules`

This ebuild has really inconsistent use of tests, quotes in tests, and 
command substitutions. Being more consistent will increase readability 
and decrease bugs due to differences between styles. For tests, pick a 
style [[ ]] or [ ] and stick with it. The [[ ]] one is pretty nice 
because it generally doesn't require quotes, so the code looks a lot 
cleaner. For command substitions, prefer $() over ``.

   newins ${FILESDIR}/blacklist-110 blacklist
   doins ${FILESDIR}/pnp-aliases

Quotes here.

   emake \
   EXTRAS=${extras} \
   libudevdir=${udev_helper_dir} \
   CROSS_COMPILE=${mycross} \
   OPTFLAGS= \
   ${myconf} || die

   emake \
   DESTDIR=${D} \
   libudevdir=${udev_helper_dir} \
   EXTRAS=${extras} \
   ${myconf} \
   install || die

Could use some die messages here.

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list



[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-office/magicpoint: ChangeLog magicpoint-1.12a.ebuild

2007-09-24 Thread Christian Faulhammer
Mike Frysinger [EMAIL PROTECTED]:

   Because it fails, magicpoint's build system is really old and
  weird. The comment above should state that, but the leftover -j1 I
  tried would confuse the reader.  Plus the stupid die comments.
 most people associate emake with run in parallel when in reality,
 that is merely one of the things it provides
 if something doesnt work in parallel, you use `emake -j1` ... using
 `make` generally doesnt make sense anywhere

 I know the difference, but thanks.  That comment has been added because
I tried it with emake -j1...it still failed, so I chose to use make.
And then forgot to remove the comment.

V-Li

-- 
Christian Faulhammer, Gentoo Lisp project
URL:http://www.gentoo.org/proj/en/lisp/, #gentoo-lisp on FreeNode

URL:http://www.faulhammer.org/


signature.asc
Description: PGP signature


Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-dotnet/libgdiplus: ChangeLog libgdiplus-1.2.5-r1.ebuild

2007-09-24 Thread Bo Ørsted Andresen
On Monday 24 September 2007 21:56:49 Donnie Berkholz wrote:
  if [[ $(gcc-major-version) -gt 3 ]] || \
 ( [[ $(gcc-major-version) -eq 3 ]]  [[ $(gcc-minor-version) 
  -gt 3 ]] )

 Code block { } might be good here instead of a subshell, or perhaps it
 could use logic that's less convoluted such as if..then. Also don't need
 the double quotes.

Or it could be as simple as:

if [[ $(gcc-major-version) -gt 3 || \
( $(gcc-major-version) -eq 3  $(gcc-minor-version) -gt 3 ) ]]

[[ allows grouping of conditions without spawning subshells.

-- 
Bo Andresen


signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-video/mplayer: ChangeLog mplayer-1.0_rc1_p20070824.ebuild

2007-09-24 Thread Bo Ørsted Andresen
On Monday 24 September 2007 21:53:14 Donnie Berkholz wrote:
  -   use video_cards_mga || myconf=${myconf} --disable-mga
  -   ( use X  use video_cards_mga ) || myconf=${myconf} --disable-xmga
  +   use video_cards_mga  myconf=${myconf} --enable-mga
  +   ( use X  use video_cards_mga )  myconf=${myconf} --enable-xmga

 Subshells are gross, can you try a code block { } instead?

A code block isn't even required since this grouping does the same as without 
it. More importantly, though, why isn't this ebuild using use_enable? It 
seems that:

use X  myconf=$myconf $(use_enable video_cards_mga xmga)
myconf=$myconf $(use_enable video_cards_mga mga)

would do the same?

In another example from the ebuild:

 use bl  myconf=${myconf} --enable-bl

if USE=bl is disabled --disable-bl isn't passed to the configure script which 
means the default is picked. There's a good chance that this kind of 
behaviour results in automagic deps...

http://www.gentoo.org/proj/en/qa/automagic.xml

-- 
Bo Andresen


signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-office/magicpoint: ChangeLog magicpoint-1.12a.ebuild

2007-09-24 Thread Mike Frysinger
On Monday 24 September 2007, Christian Faulhammer wrote:
 Mike Frysinger [EMAIL PROTECTED]:
Because it fails, magicpoint's build system is really old and
   weird. The comment above should state that, but the leftover -j1 I
   tried would confuse the reader.  Plus the stupid die comments.
 
  most people associate emake with run in parallel when in reality,
  that is merely one of the things it provides
  if something doesnt work in parallel, you use `emake -j1` ... using
  `make` generally doesnt make sense anywhere

  I know the difference, but thanks.  That comment has been added because
 I tried it with emake -j1...it still failed, so I chose to use make.
 And then forgot to remove the comment.

i dont see how (in the normal case) `emake -j1` would fail where `make` does 
not ... they expand to the same effective behavior

`emake -j1` would generally turn into `make -j2 -j1` which has the same 
behavior as the default `make`
-mike


signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] Trivial commit reviews

2007-09-24 Thread Rémi Cardona
Matti Bickel wrote:
 I totally agree with Donnie here. Please keep up the work, everybody
 should be encouraged to fix these (trivial) problems. I sincerly hope
 that these message will not have to continue for long. But as long as
 they do, they serve as a big reminder in your inbox of what is wrong.

+1, I've already learned or re-learned some very useful stuff.

/me will keep reading those ebuild reviews.

Rémi
-- 
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] Automated Package Removal and Addition Tracker, for the week ending 2007-09-23 23h59 UTC

2007-09-24 Thread Rémi Cardona
Robin H. Johnson wrote:
 Additions:
[snip]
 media-sound/jokosher  2007-09-17 16:19:02 drac

Samuli,

You'll be getting an extra tester real soon! Thanks for adding this :D

Rémi
-- 
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] New developer : Timo Gurr (tgurr)

2007-09-24 Thread Rémi Cardona
Denis Dupeyron wrote:
 It's my pleasure to introduce Timo Gurr (tgurr) who will join us as a
 new developer. He will work primarily on KDE and printing.

Good luck with those two ;)

 Timo lives in Neckarsulm, Germany, and works as an IT technician in a
 local city administration near his home. He finds his job very
 interesting and loves it, and even runs some Gentoo machines there.
 His interests are very wide-ranging and he likes to play a good game
 from time to time. This makes him believe he is a pretty normal guy.
 Well, let me tell you something, Timo. You've just entered
 Gentoo-land, so please leave all normality at the gate. Thanks for
 your understanding.

The European conspiracy grows yet again! (Rivalry only between countries
is so 20th century)

Anyway, welcome to you :)

Rémi
-- 
[EMAIL PROTECTED] mailing list



[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: ChangeLog udev-115-r6.ebuild

2007-09-24 Thread Duncan
Donnie Berkholz [EMAIL PROTECTED] posted
[EMAIL PROTECTED], excerpted below, on  Mon, 24 Sep 2007
13:09:57 -0700:

 For tests, pick a style
 [[ ]] or [ ] and stick with it. The [[ ]] one is pretty nice because it
 generally doesn't require quotes, so the code looks a lot cleaner.

Can you point me (and anyone else that may be interested) to a nice 
explanation of the difference?  I've always wondered why [[ ]] is 
considered better than [ ] for tests.

-- 
Duncan - List replies preferred.   No HTML msgs.
Every nonfree program has a lord, a master --
and if you use the program, he is your master.  Richard Stallman

-- 
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] Re: Gentoo vmware/virtualbox/qemu images

2007-09-24 Thread Chris Gianelloni
On Mon, 2007-09-24 at 13:54 +0200, Ramon van Alteren wrote:
  Currently, Release Engineering is quite understaffed.  We have lost a
  few release coordinators between the last release and now.  The arch
  teams are picking up the slack and getting people to fill the roles, but
  they have to be trained, which means more time spent training and less
  time spent working, which delays a release fairly significantly.  
 
 Are you still looking for staff ? What roles/positions/work needs doing 
 most ?

Release Engineering is almost always looking for staff.  The primary
need is architecture release coordinators for the architectures which
have lost them.  Anyone considering joining Release Engineering should
be capable of being an ebuild developer, if they're not already, as most
issues are in ebuild code.  Familiarity with catalyst and genkernel is a
requirement.  Strong python and bash skills are preferred.

 Are you aware that http://www.gentoo.org/proj/en/devrel/staffing-needs/ 
 lists no staffing needs for release engineering ?

I am well aware.  I have no intentions on asking our user pool for help
with this due to my own constraints.  It has nothing to do with the
users themselves and everything to do with what we actually need.  We
don't need people that we have to train, as that only takes time that we
already do not have to train the new person, compounding the problem
more than it helps.  We don't really need people that are not on
architecture teams, because their work is representative of the team and
they need to work with the team in question.  Unfortunately, this pretty
much leaves us pulling from our current developer pool.

 Where do I volunteer and what amount of time-investment can I expect ?

Well, first you would need to become a developer.  I don't have time to
mentor someone myself, so you'd need to find a mentor and get yourself
into the developer pool.  Aside that, you'd need to be able to use
catalyst and troubleshoot your own issues with it.  I know that this
sounds really bad, but I don't mean it to be.  It doesn't help me, at
all, if I have to teach someone.  My familiarity with catalyst is such
that it is generally faster to do something myself than to teach someone
else to do it.  Basically, we require people who are completely
self-motivated learners capable of reading code, understanding it, and
putting that new knowledge into practice without help.

The amount of time required can vary wildly, depending on the quality of
the tree for your architecture, just how crazy the architecture boot
sequence is, the speed of your hardware, etc.  On average, I spend
anywhere from 20 to 40 hours a *week* during release times.  I've spent
as little as 3 or 4 hours and as much as 60 hours.  Also, Release
Engineering is one of the few places where deadlines are very important,
meaning you have to be able to actually commit to time lines and follow
through, on time.  Of course, this makes Release Engineering one of the
more stressful jobs around Gentoo.  Just ask anyone who has been hanging
around #gentoo-releng during a release... ;]

-- 
Chris Gianelloni
Release Engineering Strategic Lead
Alpha/AMD64/x86 Architecture Teams
Games Developer/Foundation Trustee
Gentoo Foundation


signature.asc
Description: This is a digitally signed message part


Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: ChangeLog udev-115-r6.ebuild

2007-09-24 Thread Mike Frysinger
On Monday 24 September 2007, Duncan wrote:
 Donnie Berkholz [EMAIL PROTECTED] posted:
  For tests, pick a style
  [[ ]] or [ ] and stick with it. The [[ ]] one is pretty nice because it
  generally doesn't require quotes, so the code looks a lot cleaner.

 Can you point me (and anyone else that may be interested) to a nice
 explanation of the difference?

i use `man bash` myself ...

 I've always wondered why [[ ]] is 
 considered better than [ ] for tests.

as Donnie pointed out, it handles quoting sanely ... it also allows for 
extended bash logic tests (like matching and regexps) as well as your 
standard logic operators

fails:
f=moo cow with space
[ ${f} = blah ]
works:
[[ ${f} == blah ]]

wildcards:
[[ ${f} == *moo* ]]

C logic operators (rather than crappy shell '-a' / '-o' / etc...):
[[ moo == foo || moo == moo  blah == doit ]]
-mike


signature.asc
Description: This is a digitally signed message part.


[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/linuxtv-dvb-apps: ChangeLog linuxtv-dvb-apps-1.1.1.20070924.ebuild

2007-09-24 Thread Donnie Berkholz
On 20:04 Mon 24 Sep , Doug Goldstein (cardoe) wrote:
 cardoe  07/09/24 20:04:55
 
   Modified: ChangeLog
   Added:linuxtv-dvb-apps-1.1.1.20070924.ebuild
   Log:
   latest upstream snapshot. Includes many scan file updates. Drops duplicate 
 installs of scan files in /usr/share/dvb.
   (Portage version: 2.1.3.9)

 1.1  
 media-tv/linuxtv-dvb-apps/linuxtv-dvb-apps-1.1.1.20070924.ebuild
 
 file : 
 http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-tv/linuxtv-dvb-apps/linuxtv-dvb-apps-1.1.1.20070924.ebuild?rev=1.1view=markup
 plain: 
 http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-tv/linuxtv-dvb-apps/linuxtv-dvb-apps-1.1.1.20070924.ebuild?rev=1.1content-type=text/plain

Numerous instances of D, S, T without quotes.

   if ! use usb; then
   sed -i util/Makefile \
   -e '/ttusb_dec_reset/d' \
   -e '/dib3000-watch/d'
   fi
 
   # do not compile test-progs
   sed -i Makefile -e '/-C test/d'

You might want to die if these seds fail.

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list



[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-libs/gtk+: ChangeLog gtk+-2.12.0-r1.ebuild

2007-09-24 Thread Donnie Berkholz
On 20:21 Mon 24 Sep , Mart Raudsepp (leio) wrote:
 leio07/09/24 20:21:42
 
   Modified: ChangeLog
   Added:gtk+-2.12.0-r1.ebuild
   Log:
   Hopefully fix netscape-flash crashes and infinite loops and Java SWT 
 tooltips weird behaviour and related crashes. Bug #193513 and part of bug 
 #192310 and self-observation
   (Portage version: 2.1.3.9)

Numerous quoting issues for D and S

 1.1  x11-libs/gtk+/gtk+-2.12.0-r1.ebuild
 
 file : 
 http://sources.gentoo.org/viewcvs.py/gentoo-x86/x11-libs/gtk+/gtk+-2.12.0-r1.ebuild?rev=1.1view=markup
 plain: 
 http://sources.gentoo.org/viewcvs.py/gentoo-x86/x11-libs/gtk+/gtk+-2.12.0-r1.ebuild?rev=1.1content-type=text/plain

 pkg_setup() {
   if ! built_with_use x11-libs/cairo X; then
   einfo Please re-emerge x11-libs/cairo with the X USE flag set
   die cairo needs the X flag set
   fi
 }

One trick I like doing here is setting a local variable, then using it 
twice to avoid duplicating the same info. For example:

local msg=Please re-emerge x11-libs/cairo with the X USE flag set
eerror $msg
die $msg

BTW, note that I changed that einfo to an eerror, since it's dying.

   if [ -e /usr/lib/gtk-2.0/2.[^1]* ]; then
   elog You need to rebuild ebuilds that installed into 
 /usr/lib/gtk-2.0/2.[^1]*
   elog to do that you can use qfile from portage-utils:
   elog emerge -va1 \$(qfile -qC /usr/lib/gtk-2.0/2.[^1]*)

Looks like get_libdir() should be here.

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list



[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in www-apps/dspam-web: dspam-web-3.8.0.ebuild ChangeLog

2007-09-24 Thread Donnie Berkholz
On 20:40 Mon 24 Sep , Alin Nastac (mrness) wrote:
 mrness  07/09/24 20:40:54
 
   Modified: dspam-web-3.8.0.ebuild ChangeLog
   Log:
   Die in pkg_setup if dev-perl/GD has been installed without png USE flag 
 (#193662). Update patches tarball to match the one used in latest 
 mail-filter/dspam version.
   (Portage version: 2.1.3.9)

 - mirror://gentoo/dspam-${PV}-patches-20070624.tar.gz
 + mirror://gentoo/dspam-${PV}-patches-20070909.tar.gz

It might increase readability and decrease maintenance to pull this date 
out into a separate variable.

 + local use_errors=0
 + if built_with_use mail-filter/dspam user-homedirs; then
 + echo
 + eerror The DSPAM web interface requires that mail-filter/dspam 
 be installed without user-homedirs USE flag.
   eerror Please disable this flag and re-emerge dspam.
 - die Incompatible mail-filter/dspam installation
 + use_errors=$[${use_errors} + 1]
 + fi
 + if ! built_with_use dev-perl/GD png; then
 + echo
 + eerror The DSPAM web interface requires that dev-perl/GD be 
 installed with png USE flag.
 + eerror Please enable this flag and re-emerge GD.
 + use_errors=$[${use_errors} + 1]
   fi
 + [ ${use_errors} -gt 0 ]  die Dependency installed with incompatible 
 USE flags

You could use C-style syntax here:

(( use_errors++ ))

I find it a bit more readable.

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list



[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/libgphoto2: ChangeLog libgphoto2-2.4.0.ebuild

2007-09-24 Thread Donnie Berkholz
On 22:46 Mon 24 Sep , Gilles Dartiguelongue (eva) wrote:
 eva 07/09/24 22:46:36
 
   Modified: ChangeLog
   Added:libgphoto2-2.4.0.ebuild
   Log:
   bump to 2.4.0
   (Portage version: 2.1.3.9)

 1.1  media-libs/libgphoto2/libgphoto2-2.4.0.ebuild
 
 file : 
 http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-libs/libgphoto2/libgphoto2-2.4.0.ebuild?rev=1.1view=markup
 plain: 
 http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-libs/libgphoto2/libgphoto2-2.4.0.ebuild?rev=1.1content-type=text/plain

   if ! use doc  [ -d ${D}/usr/share/doc/${PF}/apidocs.html ]; then
   rm -fr ${D}/usr/share/doc/${PF}/apidocs.html
   fi

You need the double-bracket tests for this to work without quotes. Add 
quotes or switch to [[ ]].

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: ChangeLog udev-115-r6.ebuild

2007-09-24 Thread Lars Weiler
* Duncan [EMAIL PROTECTED] [07/09/24 23:51 +]:
 Can you point me (and anyone else that may be interested) to a nice 
 explanation of the difference?  I've always wondered why [[ ]] is 
 considered better than [ ] for tests.

I read about the difference in chapter 7 of the Advanced
Bash-Scripting Guide (`emerge abs-guide`).  There are some
more nice examples.

Regards, Lars

-- 
Lars Weiler  [EMAIL PROTECTED]  +49-171-1963258
Instant Messaging : [EMAIL PROTECTED]
Gentoo Linux PowerPC  : Developer
Gentoo Infrastructure : CVS/SVN Administrator


pgpDEDA4xYkGg.pgp
Description: PGP signature


[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: ChangeLog udev-115-r6.ebuild

2007-09-24 Thread Ryan Hill
Duncan wrote:
 Donnie Berkholz [EMAIL PROTECTED] posted
 [EMAIL PROTECTED], excerpted below, on  Mon, 24 Sep 2007
 13:09:57 -0700:
 
 For tests, pick a style
 [[ ]] or [ ] and stick with it. The [[ ]] one is pretty nice because it
 generally doesn't require quotes, so the code looks a lot cleaner.
 
 Can you point me (and anyone else that may be interested) to a nice 
 explanation of the difference?  I've always wondered why [[ ]] is 
 considered better than [ ] for tests.

check out http://tldp.org/LDP/abs/html/testconstructs.html#DBLBRACKETS


-- 
  fonts / wxWindows / gcc-porting / treecleaners
  9B81 6C9F E791 83BB 3AB3  5B2D E625 A073 8379 37E8 (0x837937E8)

-- 
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in www-apps/dspam-web: dspam-web-3.8.0.ebuild ChangeLog

2007-09-24 Thread Mike Frysinger
On Monday 24 September 2007, Donnie Berkholz wrote:
 On 20:40 Mon 24 Sep , Alin Nastac (mrness) wrote:
Modified: dspam-web-3.8.0.ebuild ChangeLog
 
  +   local use_errors=0
  +   if built_with_use mail-filter/dspam user-homedirs; then
  +   echo
  +   eerror The DSPAM web interface requires that mail-filter/dspam 
  be
  installed without user-homedirs USE flag. eerror Please disable this
  flag and re-emerge dspam.
  -   die Incompatible mail-filter/dspam installation
  +   use_errors=$[${use_errors} + 1]
  +   fi
  +   if ! built_with_use dev-perl/GD png; then
  +   echo
  +   eerror The DSPAM web interface requires that dev-perl/GD be 
  installed
  with png USE flag. +   eerror Please enable this flag and 
  re-emerge GD.
  +   use_errors=$[${use_errors} + 1]
  fi
  +   [ ${use_errors} -gt 0 ]  die Dependency installed with incompatible
  USE flags

 You could use C-style syntax here:

 (( use_errors++ ))

 I find it a bit more readable.

i like to get anal and use ((++use_errors))

then again, it may also be more readable like so:
use_errors=false
if ... ; then
...
use_errors=true
fi
if ... ; then
...
use_errors=true
fi
${use_errors}  die ...
-mike


signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] Automated Package Removal and Addition Tracker, for the week ending 2007-09-23 23h59 UTC

2007-09-24 Thread Samuli Suominen
On Tue, 25 Sep 2007 00:30:02 +0200
Rémi Cardona [EMAIL PROTECTED] wrote:

 Robin H. Johnson wrote:
  Additions:
 [snip]
  media-sound/jokosher2007-09-17
  16:19:02drac
 You'll be getting an extra tester real soon! Thanks for adding this :D

Good, maybe you can help me sorting out what gst-plugins should be
optional with USE and what allways installed, for now I've just picked
up what I've seen in few bugs at our bugzilla.

/me mummbles something about verifying with upstream.

Thanks, Samuli
--
[EMAIL PROTECTED] mailing list



Re: [gentoo-dev] [gentoo-commits] gentoo-x86 commit in dev-dotnet/libgdiplus: ChangeLog libgdiplus-1.2.5-r1.ebuild

2007-09-24 Thread Peter Volkov
В Пнд, 24/09/2007 в 12:56 -0700, Donnie Berkholz пишет:
  if use ppc ; then
  sed -i -e 's:-Werror::g' src/Makefile
  fi
 
 We should never leave -Werror in -- make this unconditional. 

never is too strong: for example, wireshark's upstream told me that
they want code to be built with -Werror. If something breaks they are
interested in report to fix that.

-- 
Peter.


signature.asc
Description: Эта	 часть	 сообщения	 подписана	 цифровой	 подписью