Re: [Geotools-devel] API/ABI change to move XMLTestSupport to test jar.

[Andrea Aime]

+1 here, thanks!

Cheers
Andrea


Il mar 24 lug 2018, 03:55  ha scritto:

> https://github.com/geotools/geotools/pull/1986 is a proposal to remove
> xmlunit (and junit) as dependencies we ship in geotools.
>
>
>
> The reason why we were providing that is partly because some of the
> dependency definitions were not test scoped, and partly because we actually
> do depend on it, for one class – org.geotools.xml.test.XMLTestSupport (
> http://docs.geotools.org/latest/javadocs/org/geotools/xml/test/XMLTestSupport.html
> )
>
>
>
> I propose (see PR) to remove XMLTestSupport from the GeoTools XML API and
> provide it only as a test-jar. That has impact on at least GeoServer, and
> Ben Caradoc Davies has developed a corresponding PR.
>
>
>
> That is an API/ABI break, and backport is not intended. Given the nature
> of the changes in 20.0, I don’t think this is a particularly onerous change
> if anyone else is using that class.
>
>
>
> I request approval for this change.
>
>
>
> Brad
>
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] API/ABI change to move XMLTestSupport to test jar.

[Ben Caradoc-Davies]

Thanks, Brad. I think this is a good change, so +1 from me.

Here is the corresponding GeoServer change:
https://github.com/geoserver/geoserver/pull/3019

There are two types of downstream breakages. The first are downstream 
tests that use XMLTestSupport and so need to depend on the new 
gt-xsd-core tests artifact:



org.geotools.xsd
gt-xsd-core
tests
test


The second are downstream tests that were using xmlunit as a transitive 
dependency via gt-xsd-core but not XMLTestSupport. As Brad has noted and 
fixed in his PR, the main gt-xsd-core artifact should not depend on 
xmlunit. These downstream tests that use xmlunit but not XMLTestSupport 
need only declare a test dependency on xmlunit:



xmlunit
xmlunit
test


Please let us know if you find any other affected downstream projects.

Does anyone object to this API change?

Kind regards,
Ben.

On 24/07/18 13:53, br...@frogmouth.net wrote:

https://github.com/geotools/geotools/pull/1986 is a proposal to remove
xmlunit (and junit) as dependencies we ship in geotools.

  


The reason why we were providing that is partly because some of the
dependency definitions were not test scoped, and partly because we actually
do depend on it, for one class - org.geotools.xml.test.XMLTestSupport
(http://docs.geotools.org/latest/javadocs/org/geotools/xml/test/XMLTestSuppo
rt.html)

  


I propose (see PR) to remove XMLTestSupport from the GeoTools XML API and
provide it only as a test-jar. That has impact on at least GeoServer, and
Ben Caradoc Davies has developed a corresponding PR.

  


That is an API/ABI break, and backport is not intended. Given the nature of
the changes in 20.0, I don't think this is a particularly onerous change if
anyone else is using that class.

  


I request approval for this change.

  


Brad

  





--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot



___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel



--
Ben Caradoc-Davies 
Director
Transient Software Limited 
New Zealand

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

[Geotools-devel] Incomplete Filter 2.0 Support

[Lombardi]

https://github.com/geotools/geotools/pull/1988 adds support for Expressions
on both sides of a PropertyIsLike operator when parsing & encoding Filter
2.0 documents. Curious if this is the correct approach. 



--
Sent from: http://osgeo-org.1560.x6.nabble.com/geotools-devel-f4265016.html

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

[Geotools-devel] API/ABI change to move XMLTestSupport to test jar.

[bradh]

https://github.com/geotools/geotools/pull/1986 is a proposal to remove
xmlunit (and junit) as dependencies we ship in geotools.

 

The reason why we were providing that is partly because some of the
dependency definitions were not test scoped, and partly because we actually
do depend on it, for one class - org.geotools.xml.test.XMLTestSupport
(http://docs.geotools.org/latest/javadocs/org/geotools/xml/test/XMLTestSuppo
rt.html)

 

I propose (see PR) to remove XMLTestSupport from the GeoTools XML API and
provide it only as a test-jar. That has impact on at least GeoServer, and
Ben Caradoc Davies has developed a corresponding PR.

 

That is an API/ABI break, and backport is not intended. Given the nature of
the changes in 20.0, I don't think this is a particularly onerous change if
anyone else is using that class.

 

I request approval for this change.

 

Brad

 

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30 UTC on Tuesday

[Jody Garnett]

I think we got out of sync (java 8 upgrade) and are gradually trying to
bring the release schedule back for September release
--
Jody Garnett


On Mon, 23 Jul 2018 at 15:31, Ben Caradoc-Davies  wrote:

> My only question was the 20.0/2.14.0 release timeline. It seems a month
> earlier this year. We should discuss.
>
> On 24/07/18 10:10, Jody Garnett wrote:
> > I have a meeting conflict and cannot attend.
>
> --
> Ben Caradoc-Davies 
> Director
> Transient Software Limited 
> New Zealand
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30 UTC on Tuesday

[Ben Caradoc-Davies]

My only question was the 20.0/2.14.0 release timeline. It seems a month 
earlier this year. We should discuss.


On 24/07/18 10:10, Jody Garnett wrote:

I have a meeting conflict and cannot attend.


--
Ben Caradoc-Davies 
Director
Transient Software Limited 
New Zealand

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] API changes to add AutoCloseable for try-with-resources

[Ben Caradoc-Davies]

I am still investigating this change. I think I have found a use-case 
where deprecation of dispose() and third-party migration to close() 
might introduce a resource leak. I will report back when I have finished 
my investigation.


Kind regards,
Ben.

On 07/06/18 14:29, Ben Caradoc-Davies wrote:

Jody,

the problem is that doing it this way will break any third-party code 
that already implements an interface with dispose(). Their 
implementation will override dispose() and fail to implement close().


What we could do is provide default implementations for *both* close() 
and @Deprecated dispose() that call each other. All implementations with 
dispose() will work fine, and will work just the same when dispose() is 
renamed to close().


I think we need a deprecation cycle:

Stage one (GeoTools 20): introduce @Deprecated interface Disposable 
(extends AutoCloseable) with @Deprecated default dispose() that calls 
close() and default close() that calls dispose(). All implementations 
have dispose() marked @Deprecated. All implementations can now have 
their dispose() renamed to close() as convenient, with @Deprecated 
removed. The default dispose() will provide backwards compatibility.


Stage two (GeoTools 21): remove Disposable entirely, replacing it with 
AutoClosable. Any remaining dispose() methods renamed to close(). 
Third-party code that ignored the deprecation warnings is now broken.


Is one release cycle enough deprecation before removal?

Kind regards,
Ben.

On 07/06/18 10:41, Jody Garnett wrote:

You could swap this around, rename the dispose implementations to close,
and provide a deprecated default implementation of dispose that calls
close.
This way you can manage eventually remove dispose() from the API.




--
Ben Caradoc-Davies 
Director
Transient Software Limited 
New Zealand

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30 UTC on Tuesday

[Jody Garnett]

I have a meeting conflict and cannot attend.

Updates/notes/discussion:

- Thanks to Andrea and Ian for representing us at FOSS4GE!
- Ian and I will be working on a GeoServer workshop for foss4g if you see a
chance to help out we would love ya for it :)
- Andrea has been researching Java roadmap planning, and the result is both
worse (Oracle JRE) and better (OpenJDK JRE) then expected. No matter which
way this goes we should put our time into upgrading dependencies for
compatibility going forward.
- Java roadmap compatibility sprint? Proposing October timeframe at the
start of the GeoTools 20.x lifecycle, giving some recovery after foss4g
travel, and providing some months for community modules to catch up. Would
like to settle on a timeframe so we can push this as both sponsorship and a
participation opportunity at foss4g etc...
- We have some funding for QGIS Styling compatibility. I think we could use
this to "trial" doing an RFP on the geoserver blog. Procedure would be to
make a blog post asking for proposals, proposals are added to our wiki like
normal. PSC selects and funds one of the proposals. PSC members with a
proposal in the mix may wish to vote +1/-1 to respect impartiality. We can
also use the blog post as a reminder that geoserver accepts sponsorship, in
case more than one proposal can be funded.
--
Jody Garnett


On Mon, 23 Jul 2018 at 14:45,  wrote:

> Sorry, still a bit early in my time zone.
>
> Brad
>
> -Original Message-
> From: Ben Caradoc-Davies 
> Sent: Tuesday, 24 July 2018 7:08 AM
> To: Geotools-Devel list 
> Subject: [Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30
> UTC on Tuesday
>
> GeoTools / GeoServer committee meeting on Skype at 19:30 UTC on Tuesday:
>
> https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServ
> er+Meeting=2018=7=24=19=30=0=1
> 
>
> --
> Ben Caradoc-Davies 
> Director
> Transient Software Limited  New Zealand
>
>
> 
> --
> Check out the vibrant tech community on one of the world's most engaging
> tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] geotools release train starting

[Jody Garnett]

Issue reported to OSGEO SAC (https://trac.osgeo.org/osgeo/ticket/2183) and
fixed this afternoon.

Release is complete, asking Kevin to double check the GWC release next.
--
Jody Garnett


On Sat, 21 Jul 2018 at 18:50, Jody Garnett  wrote:

> And release train stopped, ...
>
> *[ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy (default-deploy) on 
> project geotools: Failed to deploy artifacts: Could not find artifact 
> org.geotools:geotools:pom:19.2 in osgeo 
> (dav:http://download.osgeo.org/webdav/geotools/ 
> ) -> [Help 1]*
>
> *[ERROR] *
>
> *[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.*
>
> *[ERROR] Re-run Maven using the -X switch to enable full debug logging.*
>
> *[ERROR] *
>
> *[ERROR] For more information about the errors and possible solutions, please 
> read the following articles:*
>
> *[ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException 
> *
>
> *Build step 'Execute shell' marked build as failure*
>
>
> I am going to guess this is our first release since the webdav troubles
> with osgeo?
> --
> Jody Garnett
>
>
> On Sat, 21 Jul 2018 at 17:20, Jody Garnett  wrote:
>
>> Release artifacts deployed to maven.
>>
>> A few more pull requests have been accepted on the geoserver side, new
>> revisions are as follows:
>>
>> version = 2.13-SNAPSHOT
>> git revision = afacec24a28f35313f7712325be0ff8bc33ac423
>> git branch = origin/2.13.x
>> build date = 21-Jul-2018 23:25
>> geotools version = 19-SNAPSHOT
>> geotools revision = ead3d59c3da7fc3a47c9d91fddbf43f239641b61
>> geowebcache version = 1.13-SNAPSHOT
>> geowebcache revision = 5a78c4e6dc72eab179207a7832bb9f0b2d15199f/5a78c
>>
>>
>> --
>>
>> Jody Garnett
>>
>>
>> On Sat, 21 Jul 2018 at 13:42, Jody Garnett 
>> wrote:
>>
>>> Artifacts available for download and test:
>>> http://build.geoserver.org/geotools/release/19.2
>>> --
>>> Jody Garnett
>>>
>>>
>>> On Sat, 21 Jul 2018 at 08:45, Jody Garnett 
>>> wrote:
>>>
 Starting the release train, cite tests show the following revisions:


 version = 2.13-SNAPSHOT
 git revision = 71843493d53cd44b7aefe1a63f96a062d0e02390
 git branch = origin/2.13.x
 build date = 20-Jul-2018 10:17
 geotools version = 19-SNAPSHOT
 geotools revision = 0aed24969020c3c57f26d9b9e1b5c0256fb071bd
 geowebcache version = 1.13-SNAPSHOT
 geowebcache revision = 5a78c4e6dc72eab179207a7832bb9f0b2d15199f/5a78c

 --

 Jody Garnett
 --
 --
 Jody Garnett

>>>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30 UTC on Tuesday

[bradh]

Sorry, still a bit early in my time zone.

Brad

-Original Message-
From: Ben Caradoc-Davies  
Sent: Tuesday, 24 July 2018 7:08 AM
To: Geotools-Devel list 
Subject: [Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30
UTC on Tuesday

GeoTools / GeoServer committee meeting on Skype at 19:30 UTC on Tuesday:
https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServ
er+Meeting=2018=7=24=19=30=0=1

--
Ben Caradoc-Davies 
Director
Transient Software Limited  New Zealand


--
Check out the vibrant tech community on one of the world's most engaging
tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

[Geotools-devel] Reminder: GeoTools / GeoServer meeting at 19:30 UTC on Tuesday

[Ben Caradoc-Davies]

GeoTools / GeoServer committee meeting on Skype at 19:30 UTC on Tuesday:
https://www.timeanddate.com/worldclock/fixedtime.html?msg=GeoTools+/+GeoServer+Meeting=2018=7=24=19=30=0=1

--
Ben Caradoc-Davies 
Director
Transient Software Limited 
New Zealand

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel