Re: [Geotools-devel] PMC: Remove datastore view proposal
Thanks Ben, I'll add that in to the patch. Michael On 5 May 2010 12:58, Ben Caradoc-Davies wrote: > Thanks Andrea. > > Michael, +1 from me. > > The only implementation in the app-schema suite is in get-webservice > WS_DataStore, which throws UnsupportedOperationException for getView, which > is a vote to remove getView. :-) > -- ___ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] PMC: Remove datastore view proposal
Thanks Andrea. Michael, +1 from me. The only implementation in the app-schema suite is in get-webservice WS_DataStore, which throws UnsupportedOperationException for getView, which is a vote to remove getView. :-) On 03/05/10 23:01, Andrea Aime wrote: > This is actually from Michael, I just moved into its own > thread to make it more visible: > > http://docs.codehaus.org/display/GEOTOOLS/Remove+DataStore+getView+method > > Cheers > Andrea > -- Ben Caradoc-Davies Software Engineering Team Leader CSIRO Earth Science and Resource Engineering Australian Resources Research Centre -- ___ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] PMC: Remove datastore view proposal
On 5/4/10 12:10 AM, Michael Bedward wrote: > Hi Justin, > >> In ContentDataStore I attempted to implement it by having >> ContentFeatureSource be able to "join itself" to another query / view. >> But again never tested it. > > The patch doesn't include ContentDataStore currently, but would you be > happy if we dropped the getView method from it ? +1. As far as I know it is not used at all. And if I remember correctly it would go a long way to simplifying some of the classes. -Justin > > Michael -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. -- ___ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] PMC: Remove datastore view proposal
Hi Justin, > In ContentDataStore I attempted to implement it by having > ContentFeatureSource be able to "join itself" to another query / view. > But again never tested it. The patch doesn't include ContentDataStore currently, but would you be happy if we dropped the getView method from it ? Michael -- ___ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] PMC: Remove datastore view proposal
On Mon, May 3, 2010 at 11:11 AM, Andrea Aime wrote: > Andrea Aime ha scritto: >> This is actually from Michael, I just moved into its own >> thread to make it more visible: >> >> http://docs.codehaus.org/display/GEOTOOLS/Remove+DataStore+getView+method > > Oh, +1 for me as well. Barely used and can be implemented efficiently > and generically using a utility method, so it should not be in the core API > +0 from me - I've never used it but I don't want to make Jody's life harder. Ian -- ___ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] PMC: Remove datastore view proposal
Andrea Aime ha scritto: > This is actually from Michael, I just moved into its own > thread to make it more visible: > > http://docs.codehaus.org/display/GEOTOOLS/Remove+DataStore+getView+method Oh, +1 for me as well. Barely used and can be implemented efficiently and generically using a utility method, so it should not be in the core API Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. -- ___ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] PMC: Remove datastore view proposal
+1 as well as far as I know this is never something that has been implemented properly or well tested. In ContentDataStore I attempted to implement it by having ContentFeatureSource be able to "join itself" to another query / view. But again never tested it. -Justin On 5/3/10 7:22 AM, Jody Garnett wrote: > Thanks Andrea: > > One think I notice with both this proposal and your caching feature source is > that we could really stand to have a stable of features source wrappers to > roll out. I don't have my heart set on accessing them all from DataUtilities; > but I can see the attraction of not defining more new public API. > > So yeah I use getView(); but can migrate to a DataUtilities.createView( > source, query ). > > +1 > > > Jody > > > On 03/05/2010, at 11:01 PM, Andrea Aime wrote: > >> This is actually from Michael, I just moved into its own >> thread to make it more visible: >> >> http://docs.codehaus.org/display/GEOTOOLS/Remove+DataStore+getView+method >> >> Cheers >> Andrea >> >> -- >> Andrea Aime >> OpenGeo - http://opengeo.org >> Expert service straight from the developers. >> >> -- >> ___ >> Geotools-devel mailing list >> Geotools-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geotools-devel > > > -- > ___ > Geotools-devel mailing list > Geotools-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. -- ___ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] PMC: Remove datastore view proposal
Thanks Andrea: One think I notice with both this proposal and your caching feature source is that we could really stand to have a stable of features source wrappers to roll out. I don't have my heart set on accessing them all from DataUtilities; but I can see the attraction of not defining more new public API. So yeah I use getView(); but can migrate to a DataUtilities.createView( source, query ). +1 Jody On 03/05/2010, at 11:01 PM, Andrea Aime wrote: > This is actually from Michael, I just moved into its own > thread to make it more visible: > > http://docs.codehaus.org/display/GEOTOOLS/Remove+DataStore+getView+method > > Cheers > Andrea > > -- > Andrea Aime > OpenGeo - http://opengeo.org > Expert service straight from the developers. > > -- > ___ > Geotools-devel mailing list > Geotools-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel -- ___ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
