Change in osmo-ttcn3-hacks[master]: msc: TC_gsup_cancel: end with f_expect_clear() to avoid broken pipe
Neels Hofmeyr has submitted this change and it was merged. (
https://gerrit.osmocom.org/13187 )
Change subject: msc: TC_gsup_cancel: end with f_expect_clear() to avoid broken
pipe
..
msc: TC_gsup_cancel: end with f_expect_clear() to avoid broken pipe
Change-Id: I3b3ae0b9c3f02f523dfb60c9efb732db3ade2785
---
M msc/MSC_Tests.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Vadim Yanitskiy: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 5d40f09..31a7401 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -1596,6 +1596,8 @@
mtc.stop;
}
}
+
+ f_expect_clear();
setverdict(pass);
}
testcase TC_gsup_cancel() runs on MTC_CT {
--
To view, visit https://gerrit.osmocom.org/13187
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b3ae0b9c3f02f523dfb60c9efb732db3ade2785
Gerrit-Change-Number: 13187
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Vadim Yanitskiy
Change in osmo-ttcn3-hacks[master]: msc: add codec to all Assignment Complete messages
Neels Hofmeyr has submitted this change and it was merged. (
https://gerrit.osmocom.org/13186 )
Change subject: msc: add codec to all Assignment Complete messages
..
msc: add codec to all Assignment Complete messages
So far we omit a Speech Codec (Chosen) from Assignment Complete messages, which
is actually a mandatory parameter. osmo-msc seems to carry on nevertheless, but
it actually shouldn't be able to.
Always send a Speech Codec (Chosen).
Change-Id: Ib35f019383db8ace05a9dc349648e2da7ba58bfa
---
M library/BSSMAP_Templates.ttcn
M msc/BSC_ConnectionHandler.ttcn
2 files changed, 14 insertions(+), 4 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Vadim Yanitskiy: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn
index b538095..4df39d4 100644
--- a/library/BSSMAP_Templates.ttcn
+++ b/library/BSSMAP_Templates.ttcn
@@ -462,6 +462,11 @@
lengthIndicator := 0, /* overwritten */
codecElements := valueof(elem)
}
+template BSSMAP_IE_SpeechCodec ts_BSSMAP_IE_SpeechCodec(template
BSSMAP_FIELD_CodecElements elem) := {
+ elementIdentifier := '7E'O,
+ lengthIndicator := 0, /* overwritten */
+ codecElements := valueof(elem)
+}
template PDU_BSSAP
ts_BSSMAP_AssignmentReq(template BSSMAP_IE_CircuitIdentityCode cic := omit,
@@ -534,7 +539,8 @@
template PDU_BSSAP
ts_BSSMAP_AssignmentComplete(template BSSMAP_IE_CircuitIdentityCode cic :=
omit,
-template BSSMAP_IE_AoIP_TransportLayerAddress aoip
:= omit)
+template BSSMAP_IE_AoIP_TransportLayerAddress aoip
:= omit,
+template BSSMAP_IE_SpeechCodec speechCodec := omit)
modifies ts_BSSAP_BSSMAP := {
pdu := {
bssmap := {
@@ -550,7 +556,7 @@
lSAIdentifier := omit,
talkerPriority := omit,
aoIPTransportLayer := aoip,
- speechCodec := omit,
+ speechCodec := speechCodec,
codecList := omit,
lCLS_BSS_Status := omit
}
diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn
index 2cd666f..e6cf2b0 100644
--- a/msc/BSC_ConnectionHandler.ttcn
+++ b/msc/BSC_ConnectionHandler.ttcn
@@ -532,8 +532,10 @@
valueof(ts_BSSMAP_IE_AoIP_TLA4(f_inet_addr(cpars.mgw_rtp_ip_bss),cpars.mgw_rtp_port_bss));
BSSAP.receive(tr_BSSMAP_AssignmentReq(omit, tla_ass)) {
var BSSMAP_IE_AoIP_TransportLayerAddress tla;
+ var BSSMAP_IE_SpeechCodec codec;
tla :=
valueof(ts_BSSMAP_IE_AoIP_TLA4(f_inet_addr(cpars.bss_rtp_ip),
cpars.bss_rtp_port));
- BSSAP.send(ts_BSSMAP_AssignmentComplete(omit, tla));
+ codec := valueof(ts_BSSMAP_IE_SpeechCodec({ts_CodecFR}));
+ BSSAP.send(ts_BSSMAP_AssignmentComplete(omit, tla, codec));
}
/* MS -> MSC: ALERTING */
@@ -633,8 +635,10 @@
/* expect AoIP IP/Port to match what we returned in CRCX_ACK above */
[] BSSAP.receive(tr_BSSMAP_AssignmentReq(omit, tla_ass)) {
var BSSMAP_IE_AoIP_TransportLayerAddress tla;
+ var BSSMAP_IE_SpeechCodec codec;
tla :=
valueof(ts_BSSMAP_IE_AoIP_TLA4(f_inet_addr(cpars.bss_rtp_ip),
cpars.bss_rtp_port));
- BSSAP.send(ts_BSSMAP_AssignmentComplete(omit, tla));
+ codec := valueof(ts_BSSMAP_IE_SpeechCodec({ts_CodecFR}));
+ BSSAP.send(ts_BSSMAP_AssignmentComplete(omit, tla, codec));
}
}
--
To view, visit https://gerrit.osmocom.org/13186
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib35f019383db8ace05a9dc349648e2da7ba58bfa
Gerrit-Change-Number: 13186
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Vadim Yanitskiy
Change in osmo-bsc[master]: log N-CONNECT from MSC
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13228 ) Change subject: log N-CONNECT from MSC .. log N-CONNECT from MSC Change-Id: I83f15c7231b2b766aba4d25339d08acbbca3a47e --- M src/osmo-bsc/osmo_bsc_sigtran.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Max: Looks good to me, approved Pau Espin Pedrol: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index 2ff5d80..f2a6d08 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -179,6 +179,10 @@ goto refuse; } + LOGP(DMSC, LOGL_DEBUG, "(calling_addr=%s conn_id=%u) N-CONNECT.ind from MSC %d\n", +osmo_sccp_addr_dump(&scu_prim->u.connect.calling_addr), +scu_prim->u.connect.conn_id, msc->nr); + conn = bsc_subscr_con_allocate(bsc_gsmnet); if (!conn) return -ENOMEM; -- To view, visit https://gerrit.osmocom.org/13228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I83f15c7231b2b766aba4d25339d08acbbca3a47e Gerrit-Change-Number: 13228 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol
Change in osmo-bsc[master]: incoming connect: don't crash if calling addr is missing
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13227 ) Change subject: incoming connect: don't crash if calling addr is missing .. incoming connect: don't crash if calling addr is missing The idea was to guard the logging, though actually that can handle a NULL ss7 quite well. Change-Id: Ib028432b37a5c48b677bb21b869cc722575dce92 --- M src/osmo-bsc/osmo_bsc_sigtran.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Max: Looks good to me, approved Pau Espin Pedrol: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index 4b2c4ae..2ff5d80 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -122,7 +122,6 @@ } ss7 = osmo_ss7_instance_find(msc->a.cs7_instance); - OSMO_ASSERT(ss7); LOGP(DMSC, LOGL_ERROR, "Unable to find MSC data under address: %s\n", osmo_sccp_addr_name(ss7, msc_addr)); return NULL; } -- To view, visit https://gerrit.osmocom.org/13227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib028432b37a5c48b677bb21b869cc722575dce92 Gerrit-Change-Number: 13227 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol
Change in libosmocore[master]: osmo_gsm48_classmark_a5_name(): fix 'no-cm3' label
Neels Hofmeyr has submitted this change and it was merged. (
https://gerrit.osmocom.org/13207 )
Change subject: osmo_gsm48_classmark_a5_name(): fix 'no-cm3' label
..
osmo_gsm48_classmark_a5_name(): fix 'no-cm3' label
Change-Id: Id84021858dfb2f7d6a7cf81ae73bd94cd47f6776
---
M src/gsm/gsm48.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Vadim Yanitskiy: Looks good to me, approved
Pau Espin Pedrol: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index 4166c15..5dc30ad 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -1192,7 +1192,7 @@
static char buf[128];
char cm1[42] = "no-cm1";
char cm2[42] = " no-cm2";
- char cm3[42] = " no-cm2";
+ char cm3[42] = " no-cm3";
if (cm->classmark1_set)
snprintf(cm1, sizeof(cm1), "cm1{a5/1=%s}",
--
To view, visit https://gerrit.osmocom.org/13207
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id84021858dfb2f7d6a7cf81ae73bd94cd47f6776
Gerrit-Change-Number: 13207
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: Vadim Yanitskiy
Change in libosmo-sccp[master]: improve logging for rejected AS in xua_rkm.c
Neels Hofmeyr has submitted this change and it was merged. (
https://gerrit.osmocom.org/13229 )
Change subject: improve logging for rejected AS in xua_rkm.c
..
improve logging for rejected AS in xua_rkm.c
Change a loglevel from NOTICE to ERROR, for when a routing key gets
re-purposed.
Add another error log for insufficient resources case.
Change-Id: Id22e3c6bab5f7b597df3514eedb162277ce0ef7d
---
M src/xua_rkm.c
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Max: Looks good to me, but someone else must approve
Pau Espin Pedrol: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/xua_rkm.c b/src/xua_rkm.c
index a77460d..4b760ee 100644
--- a/src/xua_rkm.c
+++ b/src/xua_rkm.c
@@ -214,7 +214,7 @@
if (as) {
LOGPASP(asp, DLSS7, LOGL_NOTICE, "RKM: Found existing AS for
RCTX %u\n", rctx);
if (as->cfg.routing_key.pc != dpc) {
- LOGPASP(asp, DLSS7, LOGL_NOTICE, "RKM: DPC doesn't
match (%u != %u)\n",
+ LOGPASP(asp, DLSS7, LOGL_ERROR, "RKM: DPC doesn't
match, rejecting AS (%u != %u)\n",
as->cfg.routing_key.pc, dpc);
msgb_append_reg_res(resp, rk_id,
M3UA_RKM_REG_ERR_INVAL_RKEY, 0);
return -1;
@@ -250,6 +250,8 @@
if (*nas_idx >= max_nas_idx) {
osmo_ss7_route_destroy(rt);
osmo_ss7_as_destroy(as);
+ LOGPASP(asp, DLSS7, LOGL_ERROR, "RKM: not enough room
for newly assigned AS (max %u AS)\n",
+ max_nas_idx+1);
msgb_append_reg_res(resp, rk_id,
M3UA_RKM_REG_ERR_INSUFF_RESRC, 0);
return -1;
}
--
To view, visit https://gerrit.osmocom.org/13229
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id22e3c6bab5f7b597df3514eedb162277ce0ef7d
Gerrit-Change-Number: 13229
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Pau Espin Pedrol
Change in osmo-bsc[master]: Move LCLS references from gsm_data to osmo_bsc_lcls
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13220 ) Change subject: Move LCLS references from gsm_data to osmo_bsc_lcls .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8941f059d6e4eb21a971d48d2b66c29ec3355a6d Gerrit-Change-Number: 13220 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Comment-Date: Wed, 13 Mar 2019 21:28:56 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: ipaccess/Makefile.am: Remove unneeded libmgcp-client dep
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13218 ) Change subject: ipaccess/Makefile.am: Remove unneeded libmgcp-client dep .. ipaccess/Makefile.am: Remove unneeded libmgcp-client dep Change-Id: I3c926b088fe1b25b0f65d673465c3fa0c1d0b86f --- M src/ipaccess/Makefile.am M src/osmo-bsc/gsm_data.c 2 files changed, 0 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved Vadim Yanitskiy: Looks good to me, but someone else must approve diff --git a/src/ipaccess/Makefile.am b/src/ipaccess/Makefile.am index d73aa4d..c504234 100644 --- a/src/ipaccess/Makefile.am +++ b/src/ipaccess/Makefile.am @@ -10,7 +10,6 @@ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(COVERAGE_CFLAGS) \ - $(LIBOSMOMGCPCLIENT_CFLAGS) \ $(LIBOSMOSIGTRAN_CFLAGS) \ $(NULL) @@ -22,7 +21,6 @@ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOABIS_LIBS) \ - $(LIBOSMOMGCPCLIENT_LIBS) \ $(LIBOSMOSIGTRAN_LIBS) \ $(NULL) diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 5d667bb..0492571 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -43,7 +43,6 @@ #include #include #include -#include void *tall_bsc_ctx = NULL; -- To view, visit https://gerrit.osmocom.org/13218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3c926b088fe1b25b0f65d673465c3fa0c1d0b86f Gerrit-Change-Number: 13218 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy
Change in osmo-bsc[master]: src/utils/Makefile.am: Drop unneeded sigtran and mgcp-client deps
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13223 ) Change subject: src/utils/Makefile.am: Drop unneeded sigtran and mgcp-client deps .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a91d673e08c161dd6110bd16e8f52cb17be398c Gerrit-Change-Number: 13223 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Max Gerrit-Comment-Date: Wed, 13 Mar 2019 21:27:45 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmo-netif[master]: amr_test: add to .gitignore, use -noinstall flag
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13241 ) Change subject: amr_test: add to .gitignore, use -noinstall flag .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94ccff42dfba71aaf59bb30ca312db0bac58c27d Gerrit-Change-Number: 13241 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Alexander Huemer Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pablo Neira Ayuso Gerrit-Reviewer: dexter Gerrit-Reviewer: steve-m Gerrit-Comment-Date: Wed, 13 Mar 2019 21:27:18 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmo-netif[master]: amr_test: add to .gitignore, use -noinstall flag
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13241 ) Change subject: amr_test: add to .gitignore, use -noinstall flag .. Patch Set 1: I'm not sure with what the "no-install" LDFLAGS do, and I would therefore (humbly) guess that I'm not the only one. It might be worth one sentence inthe commit log. -- To view, visit https://gerrit.osmocom.org/13241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94ccff42dfba71aaf59bb30ca312db0bac58c27d Gerrit-Change-Number: 13241 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Alexander Huemer Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pablo Neira Ayuso Gerrit-Reviewer: dexter Gerrit-Reviewer: steve-m Gerrit-CC: Harald Welte Gerrit-Comment-Date: Wed, 13 Mar 2019 21:24:56 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-dev[master]: run.sh: fix $TO_RAN_IP and $TO_RAN_IU_IP usage
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13235 ) Change subject: run.sh: fix $TO_RAN_IP and $TO_RAN_IU_IP usage .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f0f749b74fe5fd3982e045283735151f69c2487 Gerrit-Change-Number: 13235 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 21:23:36 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmo-sccp[master]: Fix output of route destination in 'show ss7 instance <0-15> route'
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13233 ) Change subject: Fix output of route destination in 'show ss7 instance <0-15> route' .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13233/1/src/osmo_ss7.c File src/osmo_ss7.c: https://gerrit.osmocom.org/#/c/13233/1/src/osmo_ss7.c@852 PS1, Line 852: > Those look rather generic? Maybe make it part of libosmocore bits. […] yes, but it's a very stupid/inefficient implementation, and it's only five lines of code. I'd rather keep it here. -- To view, visit https://gerrit.osmocom.org/13233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa4fdbad953d40f222beb470a082eed8c20991ef Gerrit-Change-Number: 13233 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Max Gerrit-Comment-Date: Wed, 13 Mar 2019 21:22:44 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in libosmo-sccp[master]: vty: Ensure to properly save route pointcode and mask when writing
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13232 ) Change subject: vty: Ensure to properly save route pointcode and mask when writing .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/13232/2/src/osmo_ss7_vty.c File src/osmo_ss7_vty.c: https://gerrit.osmocom.org/#/c/13232/2/src/osmo_ss7_vty.c@365 PS2, Line 365: osmo_ss7_pointcode_print2(rtable->inst, rt->cfg.mask), > I really don't like having this "2" API with a different static buffer > instead of simply copying it […] I also don't like it and would very much prefer my "volatile select loop iteration talloc context" approach. However, the existing code works that way and it is out of scope for this patch -- To view, visit https://gerrit.osmocom.org/13232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica32e83cbe8af2317cb07f8d8422a399fa537012 Gerrit-Change-Number: 13232 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 21:20:09 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in libosmo-sccp[master]: vty: Ensure to properly save route pointcode and mask when writing
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/13232 )
Change subject: vty: Ensure to properly save route pointcode and mask when
writing
..
vty: Ensure to properly save route pointcode and mask when writing
As osmo_ss7_route_print() returns a static buffer, we cannot use it
twice within a single log/print statement. Rather, we must use
osmo_ss7_route_print2() for the second call, as it uses a separate
static buffer.
Change-Id: Ica32e83cbe8af2317cb07f8d8422a399fa537012
---
M src/osmo_ss7_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Max: Looks good to me, approved
Pau Espin Pedrol: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index 1b7bcb9..950eb08 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -362,7 +362,7 @@
llist_for_each_entry(rt, &rtable->routes, list) {
vty_out(vty, " update route %s %s linkset %s",
osmo_ss7_pointcode_print(rtable->inst, rt->cfg.pc),
- osmo_ss7_pointcode_print(rtable->inst, rt->cfg.mask),
+ osmo_ss7_pointcode_print2(rtable->inst, rt->cfg.mask),
rt->cfg.linkset_name);
if (rt->cfg.priority)
vty_out(vty, " priority %u", rt->cfg.priority);
--
To view, visit https://gerrit.osmocom.org/13232
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica32e83cbe8af2317cb07f8d8422a399fa537012
Gerrit-Change-Number: 13232
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Pau Espin Pedrol
Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13242/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13242/1//COMMIT_MSG@10 PS1, Line 10: Signed-off-by: Sylvain Munaut > No signed-off-by in osmocom repos. well, it doesn't hurt either. So I would just silently merge a related commit. -- To view, visit https://gerrit.osmocom.org/13242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82645708dd27864cf33ea9cc993ead0983415602 Gerrit-Change-Number: 13242 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: tnt Gerrit-CC: Harald Welte Gerrit-CC: Max Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 21:17:55 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-bsc[master]: assignment_fsm: Properly support assigning signalling mode TCH/x
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13172 ) Change subject: assignment_fsm: Properly support assigning signalling mode TCH/x .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7499c8c866ea3ff7b1327edb3615d003d927d3 Gerrit-Change-Number: 13172 Gerrit-PatchSet: 4 Gerrit-Owner: tnt Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: Max Gerrit-Comment-Date: Wed, 13 Mar 2019 21:13:28 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls .. Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c File src/libmsc/silent_call.c: https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@40 PS1, Line 40: char traffic_ip[INET_ADDRSTRLEN]; > Everywhere else in the code we use INET_ADDRSTRLEN. So I'd rather keep it > consistent. […] Fine. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@91 PS1, Line 91: osmo_timer_schedule(&scd->timer, 0, 0); > Because at this point in the code, I'm in the callback of a state machine > which isn't in the right s […] Can you at least document that in the code then? Otherwise people may attempt to simplify it. Add some "FIXME" or whatever. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@99 PS1, Line 99: } rtp_addr; > Why wouldn't it be ? […] Fine thanks, I had a look at sockaddr_storage to understand it better :) -- To view, visit https://gerrit.osmocom.org/13242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82645708dd27864cf33ea9cc993ead0983415602 Gerrit-Change-Number: 13242 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: tnt Gerrit-CC: Max Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 20:26:57 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls .. Patch Set 1: (8 comments) Tx for the review, will fix that up. https://gerrit.osmocom.org/#/c/13242/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13242/1//COMMIT_MSG@10 PS1, Line 10: Signed-off-by: Sylvain Munaut > No signed-off-by in osmocom repos. Ack https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/msc_vty.c@1072 PS1, Line 1072: uint16_t port = 0; > no initialization needed here afaiu. Ack https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c File src/libmsc/silent_call.c: https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@40 PS1, Line 40: char traffic_ip[INET_ADDRSTRLEN]; > worth using INET6_ADDRSTRLEN here in case we want to support ipv6? Not sure > if it makes sense in thi […] Everywhere else in the code we use INET_ADDRSTRLEN. So I'd rather keep it consistent. If at some point we want ipv6 the grep will turn up this code and hopefully it will be reviewed for ipv6 compat along with the rest. Using INET6_ADDRSTRLEN I think might make it look like it was tested or is v6 compatible which ... it's probably not at all and would be untested because the rest isn't v6 compatible. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@91 PS1, Line 91: osmo_timer_schedule(&scd->timer, 0, 0); > Why not calling timer_cb directly around line 120? You are immediatelly > firing this cb, and only on […] Because at this point in the code, I'm in the callback of a state machine which isn't in the right state to accept ran_conn_communicating() ... it will only be in the right state when the rest of the processing of the callback list is done. And I can't change the order of the callbacks because ... well the entire rest of the code base expects stuff to go in that exact order. I tried like 4 different approaches to solve this and this is the lest ugly/most self contained approach. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@99 PS1, Line 99: } rtp_addr; > Is this conversion from sockaddr_in to sockaddr_storage through union valid? > Never seen it before. Why wouldn't it be ? sockaddr_storage is just 'something big enough'. unions members are guaranteed to start at the beginning ... so I don't see an issue here. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@107 PS1, Line 107: gsm0808_speech_codec_from_chan_type(&scl.codec[i], scd->ct.perm_spch[i]); > Would it make sense to re-use enc_speech_codec_list() from a_iface. […] I'm not convinced ... it literally just saves 1 for loop, the bulk of the work is done by gsm0808_speech_codec_from_chan_type. If people insist I can do it, but I'm not even sure where to put/declare it ... I guess it would belong to be in libosmocore in gsm0808_utils thus introducing a cross repo version dependency, seems a bit much. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@120 PS1, Line 120: break; > Would be clearer using a return 0 here, otherwise it's confusing scheduling > scd timer then having a […] Ack https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@187 PS1, Line 187: struct gsm0808_channel_type *ct, > ct is not changed in this function - why not make it const similar to > traffic_dst_ip? Ack -- To view, visit https://gerrit.osmocom.org/13242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82645708dd27864cf33ea9cc993ead0983415602 Gerrit-Change-Number: 13242 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: tnt Gerrit-CC: Max Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 20:13:51 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-ttcn3-hacks[master]: ggsn: add tests to validate IPv4v6 pdp ctx
Max has posted comments on this change. ( https://gerrit.osmocom.org/13231 ) Change subject: ggsn: add tests to validate IPv4v6 pdp ctx .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bab7df5caddc5c8b973c81544f954d5473ac234 Gerrit-Change-Number: 13231 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 13 Mar 2019 19:39:40 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ttcn3-hacks[master]: ggsn: add tests to validate IPv4v6 pdp ctx
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13231 ) Change subject: ggsn: add tests to validate IPv4v6 pdp ctx .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bab7df5caddc5c8b973c81544f954d5473ac234 Gerrit-Change-Number: 13231 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 13 Mar 2019 19:25:31 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13067 ) Change subject: MCS: move HeaderType enum outside of class definition .. Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.h File src/coding_scheme.h: https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.h@44 PS7, Line 44: uint8_t num_data_header_bits_UL(enum HeaderType ht); > That's the whole point :) […] I didn't know possibility of writing typos was lower when using caps, I'd be glad to see some scientific study probing that ;-) -- To view, visit https://gerrit.osmocom.org/13067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f Gerrit-Change-Number: 13067 Gerrit-PatchSet: 7 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Harald Welte Gerrit-Comment-Date: Wed, 13 Mar 2019 19:23:34 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-pcu[master]: TBF: update MCS counters
Max has posted comments on this change. ( https://gerrit.osmocom.org/13243 ) Change subject: TBF: update MCS counters .. Patch Set 1: (1 comment) This change is ready for review. https://gerrit.osmocom.org/#/c/13243/1/src/tbf.h File src/tbf.h: https://gerrit.osmocom.org/#/c/13243/1/src/tbf.h@651 PS1, Line 651: void update_coding_scheme_counter_dl(enum CodingScheme cs); > Would be nice to have the enum named GprsCodingSCheme It includes both Gprs and Egprs coding schemes so I prefer smth more generic. > Can the class be dropped? Not yet unfortunately. Besides, I don't want to introduce changes which are neither immediate necessity nor convenience for the task at hand (fixing IA RO/TAI), and that class is used all over the place. -- To view, visit https://gerrit.osmocom.org/13243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I763136c2f356d63aa3d28d09c57fd5faf5336258 Gerrit-Change-Number: 13243 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Max Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 19:22:20 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls .. Patch Set 1: (6 comments) https://gerrit.osmocom.org/#/c/13242/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13242/1//COMMIT_MSG@10 PS1, Line 10: Signed-off-by: Sylvain Munaut No signed-off-by in osmocom repos. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/msc_vty.c@1072 PS1, Line 1072: uint16_t port = 0; no initialization needed here afaiu. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c File src/libmsc/silent_call.c: https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@40 PS1, Line 40: char traffic_ip[INET_ADDRSTRLEN]; worth using INET6_ADDRSTRLEN here in case we want to support ipv6? Not sure if it makes sense in this context. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@91 PS1, Line 91: osmo_timer_schedule(&scd->timer, 0, 0); Why not calling timer_cb directly around line 120? You are immediatelly firing this cb, and only once. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@99 PS1, Line 99: } rtp_addr; Is this conversion from sockaddr_in to sockaddr_storage through union valid? Never seen it before. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@120 PS1, Line 120: break; Would be clearer using a return 0 here, otherwise it's confusing scheduling scd timer then having a talloc_free(scd) after the switch block. -- To view, visit https://gerrit.osmocom.org/13242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82645708dd27864cf33ea9cc993ead0983415602 Gerrit-Change-Number: 13242 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Max Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 19:21:01 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition
Max has posted comments on this change. ( https://gerrit.osmocom.org/13067 ) Change subject: MCS: move HeaderType enum outside of class definition .. Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.h File src/coding_scheme.h: https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.h@44 PS7, Line 44: uint8_t num_data_header_bits_UL(enum HeaderType ht); > those UL/DL in caps hurt my eyes That's the whole point :) I mean - the lesser the chance for typos, the better. -- To view, visit https://gerrit.osmocom.org/13067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f Gerrit-Change-Number: 13067 Gerrit-PatchSet: 7 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Harald Welte Gerrit-Comment-Date: Wed, 13 Mar 2019 19:16:22 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-pcu[master]: MCS: remove unused function
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13239 )
Change subject: MCS: remove unused function
..
MCS: remove unused function
Change-Id: I32ab5ac36a0db90f2bea670b7684784b83a90b6b
---
M src/gprs_coding_scheme.cpp
M src/gprs_coding_scheme.h
2 files changed, 0 insertions(+), 6 deletions(-)
Approvals:
Pau Espin Pedrol: Looks good to me, approved
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/gprs_coding_scheme.cpp b/src/gprs_coding_scheme.cpp
index bcbb893..c0955d3 100644
--- a/src/gprs_coding_scheme.cpp
+++ b/src/gprs_coding_scheme.cpp
@@ -317,11 +317,6 @@
return mcs_info[m_scheme].family == mcs_info[o.m_scheme].family;
}
-bool GprsCodingScheme::isCombinable(GprsCodingScheme o) const
-{
- return numDataBlocks() == o.numDataBlocks();
-}
-
void GprsCodingScheme::decToSingleBlock(bool *needStuffing)
{
switch (m_scheme) {
diff --git a/src/gprs_coding_scheme.h b/src/gprs_coding_scheme.h
index d97df08..80f8502 100644
--- a/src/gprs_coding_scheme.h
+++ b/src/gprs_coding_scheme.h
@@ -67,7 +67,6 @@
bool isCompatible(Mode mode) const;
bool isCompatible(GprsCodingScheme o) const;
bool isFamilyCompatible(GprsCodingScheme o) const;
- bool isCombinable(GprsCodingScheme o) const;
void inc(Mode mode);
void dec(Mode mode);
--
To view, visit https://gerrit.osmocom.org/13239
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I32ab5ac36a0db90f2bea670b7684784b83a90b6b
Gerrit-Change-Number: 13239
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: osmith
Change in gr-gsm[master]: Fix the TCH/H decoder XML definition
Vasil Velichkov has posted comments on this change. ( https://gerrit.osmocom.org/13246 ) Change subject: Fix the TCH/H decoder XML definition .. Patch Set 1: The problem was reported in https://groups.google.com/d/topic/gr-gsm/Ew7BmUYBfJY/discussion -- To view, visit https://gerrit.osmocom.org/13246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92d4f49955c634df7d76f17cfb58d7106846c1bd Gerrit-Change-Number: 13246 Gerrit-PatchSet: 1 Gerrit-Owner: Vasil Velichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: Vasil Velichkov Gerrit-Comment-Date: Wed, 13 Mar 2019 19:11:48 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-bsc[master]: osmo_bsc_msc: Use meaningful amr rate configuration on BTS level
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13092 ) Change subject: osmo_bsc_msc: Use meaningful amr rate configuration on BTS level .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I916953e3fdb54168671dd13b359e78662fa31059 Gerrit-Change-Number: 13092 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Wed, 13 Mar 2019 19:10:22 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: codec_pref: fix special handling for AMR rate configuration (S15-S0)
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13093 ) Change subject: codec_pref: fix special handling for AMR rate configuration (S15-S0) .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie52376b51fe07ed07056e8df2e9557293ff67a78 Gerrit-Change-Number: 13093 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: dexter Gerrit-Comment-Date: Wed, 13 Mar 2019 19:10:03 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_assignment_codec_amr_f/h
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13236 ) Change subject: BSC_Tests: fix TC_assignment_codec_amr_f/h .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf730f76947cdeed23eb3119167450e3b7a9b314 Gerrit-Change-Number: 13236 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 19:07:07 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ttcn3-hacks[master]: BSC_Tests: add testcases to verify S15-S0 handling
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13237 ) Change subject: BSC_Tests: add testcases to verify S15-S0 handling .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica323deb9836deea72982e093c9cb31deb5a216b Gerrit-Change-Number: 13237 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Wed, 13 Mar 2019 19:08:00 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in gr-gsm[master]: Fix the TCH/H decoder XML definition
Hello Piotr Krysik, Vadim Yanitskiy, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/13246 to review the following change. Change subject: Fix the TCH/H decoder XML definition .. Fix the TCH/H decoder XML definition The second argument of tch_h_decoder constructor is a string that accepts the value of MultiRate configuration element and not an enum like the tch_f_decoder decoder. Change-Id: I92d4f49955c634df7d76f17cfb58d7106846c1bd --- M grc/decoding/gsm_tch_h_decoder.xml 1 file changed, 9 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/46/13246/1 diff --git a/grc/decoding/gsm_tch_h_decoder.xml b/grc/decoding/gsm_tch_h_decoder.xml index 895104e..cd7d9cd 100644 --- a/grc/decoding/gsm_tch_h_decoder.xml +++ b/grc/decoding/gsm_tch_h_decoder.xml @@ -3,7 +3,7 @@ TCH/H decoder gsm_tch_h_decoder import grgsm - grgsm.tch_h_decoder($sub_channel, $mode, $boundary_check) + grgsm.tch_h_decoder($sub_channel, $multi_rate, $boundary_check) sub-channel number @@ -20,37 +20,9 @@ -TCH/H coding mode -mode -enum - - GSM-HS - grgsm.TCH_HS - - - GSM-AMR 7.95 - grgsm.TCH_AHS7_95 - - - GSM-AMR 7.4 - grgsm.TCH_AHS7_4 - - - GSM-AMR 6.7 - grgsm.TCH_AHS6_7 - - - GSM-AMR 5.9 - grgsm.TCH_AHS5_9 - - - GSM-AMR 5.15 - grgsm.TCH_AHS5_15 - - - GSM-AMR 4.75 - grgsm.TCH_AHS4_75 - +MultiRrate configuration +multi_rate +string Voice boundary detection @@ -83,6 +55,11 @@ +The MultiRrate configuration string should contains the hex string from the +MultiRrate configuration element from the Assignment Command message. +Example: 28111a40. +See 3GPP TS 44.018 - 10.5.2.21aa MultiRate configuratio + If "Voice boundary detection" is enabled, then only bursts are decoded as voice where - the framenumber is greater then the framenumber of a received "Connect" or "Connect Acknowlegde" message, and -- To view, visit https://gerrit.osmocom.org/13246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I92d4f49955c634df7d76f17cfb58d7106846c1bd Gerrit-Change-Number: 13246 Gerrit-PatchSet: 1 Gerrit-Owner: Vasil Velichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: Vadim Yanitskiy
Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_assignment_codec_amr_f/h
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13236 ) Change subject: BSC_Tests: fix TC_assignment_codec_amr_f/h .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf730f76947cdeed23eb3119167450e3b7a9b314 Gerrit-Change-Number: 13236 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 18:42:18 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13067 ) Change subject: MCS: move HeaderType enum outside of class definition .. Patch Set 7: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.h File src/coding_scheme.h: https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.h@44 PS7, Line 44: uint8_t num_data_header_bits_UL(enum HeaderType ht); those UL/DL in caps hurt my eyes -- To view, visit https://gerrit.osmocom.org/13067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f Gerrit-Change-Number: 13067 Gerrit-PatchSet: 7 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Harald Welte Gerrit-Comment-Date: Wed, 13 Mar 2019 18:41:17 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: src/utils/Makefile.am: Drop unneeded sigtran and mgcp-client deps
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13223 ) Change subject: src/utils/Makefile.am: Drop unneeded sigtran and mgcp-client deps .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/13223/2/src/utils/Makefile.am File src/utils/Makefile.am: https://gerrit.osmocom.org/#/c/13223/2/src/utils/Makefile.am@a135 PS2, Line 135: > That doesn't seem related. Doesn't seem worth it having an extra patch for that, since basically I'm simplifying the file in this commit. -- To view, visit https://gerrit.osmocom.org/13223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a91d673e08c161dd6110bd16e8f52cb17be398c Gerrit-Change-Number: 13223 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Max Gerrit-Comment-Date: Wed, 13 Mar 2019 18:39:06 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in libosmo-sccp[master]: improve logging for rejected AS in xua_rkm.c
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13229 ) Change subject: improve logging for rejected AS in xua_rkm.c .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13229 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id22e3c6bab5f7b597df3514eedb162277ce0ef7d Gerrit-Change-Number: 13229 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 18:38:06 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: Fix TA index encoder
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13238 ) Change subject: Fix TA index encoder .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54482790e1cf3cb13a635a99a481250576deabaf Gerrit-Change-Number: 13238 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 18:36:14 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: MCS: remove unused function
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13239 ) Change subject: MCS: remove unused function .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32ab5ac36a0db90f2bea670b7684784b83a90b6b Gerrit-Change-Number: 13239 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 13 Mar 2019 18:33:20 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: Debian: bump copyright year
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13240 ) Change subject: Debian: bump copyright year .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If61a510fbbcd549dc7bdf6e38643a00d242be875 Gerrit-Change-Number: 13240 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 13 Mar 2019 18:33:36 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: MCS: move Mode enum outside of class definition
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13163 )
Change subject: MCS: move Mode enum outside of class definition
..
Patch Set 4:
(3 comments)
https://gerrit.osmocom.org/#/c/13163/4/src/coding_scheme.h
File src/coding_scheme.h:
https://gerrit.osmocom.org/#/c/13163/4/src/coding_scheme.h@53
PS4, Line 53: enum Mode {
GprsMode? Mode is just too generic.
https://gerrit.osmocom.org/#/c/13163/4/src/coding_scheme.h@59
PS4, Line 59: const char *mode_name(enum Mode val);
same
https://gerrit.osmocom.org/#/c/13163/4/src/coding_scheme.c
File src/coding_scheme.c:
https://gerrit.osmocom.org/#/c/13163/4/src/coding_scheme.c@92
PS4, Line 92: const char *mode_name(enum Mode val) {
same
--
To view, visit https://gerrit.osmocom.org/13163
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3baaac7f1ca3f5b88917a23c1679d63847455f47
Gerrit-Change-Number: 13163
Gerrit-PatchSet: 4
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-CC: Harald Welte
Gerrit-Comment-Date: Wed, 13 Mar 2019 18:33:05 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls
Max has posted comments on this change. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c File src/libmsc/silent_call.c: https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@107 PS1, Line 107: gsm0808_speech_codec_from_chan_type(&scl.codec[i], scd->ct.perm_spch[i]); Would it make sense to re-use enc_speech_codec_list() from a_iface.c in here? https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@187 PS1, Line 187: struct gsm0808_channel_type *ct, ct is not changed in this function - why not make it const similar to traffic_dst_ip? -- To view, visit https://gerrit.osmocom.org/13242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82645708dd27864cf33ea9cc993ead0983415602 Gerrit-Change-Number: 13242 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Max Gerrit-Comment-Date: Wed, 13 Mar 2019 18:25:20 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-pcu[master]: Update IA Rest Octets encoding
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13245
Change subject: Update IA Rest Octets encoding
..
Update IA Rest Octets encoding
Write initial bits of 3GPP TS 44.018 §10.5.2.16 IA Rest Octets the same
way as write_ia_rest_*() routines do.
This should also fix the issue addressed in
I75dd5bebc74eea85edf9582607c774d0bba0d2a6 initially by properly encoding
L/H bits.
Change-Id: I7ed5270bf95c3f6e9e026ff447eef8539f6f0314
---
M src/encoding.cpp
1 file changed, 13 insertions(+), 17 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/45/13245/1
diff --git a/src/encoding.cpp b/src/encoding.cpp
index b460d41..1b325b4 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -497,41 +497,37 @@
plen = wp / 8;
/* 3GPP TS 44.018 §10.5.2.16 IA Rest Octets */
+ dest->cur_bit = wp;
if (downlink) {
if (!as_dl_tbf(tbf)) {
LOGP(DRLCMACDL, LOGL_ERROR, "Cannot encode DL IMMEDIATE
ASSIGNMENT without TBF\n");
return -EINVAL;
}
- dest->cur_bit = wp;
rc = write_ia_rest_downlink(as_dl_tbf(tbf), dest, polling,
gsm48_ta_is_valid(ta), fn, alpha, gamma,
ta_idx);
} else if (((burst_type == GSM_L1_BURST_TYPE_ACCESS_1) || (burst_type
== GSM_L1_BURST_TYPE_ACCESS_2))) {
- bitvec_write_field(dest, &wp, 1, 2);/* LH */
- bitvec_write_field(dest, &wp, 0, 2);/* 0 EGPRS Uplink
Assignment */
- bitvec_write_field(dest, &wp, ra & 0x1F, 5);/* Extended RA
*/
- bitvec_write_field(dest, &wp, 0, 1);/* Access technology
Request */
+ SET_L(dest); SET_H(dest); // "LH"
+ SET_0(dest); SET_0(dest); // "00" < EGPRS Packet Uplink
Assignment >
+ rc = bitvec_set_u64(dest, ra & 0x1F, 5, false); // < Extended
RA >
+ CHECK(rc);
- if (as_ul_tbf(tbf) != NULL) {
- dest->cur_bit = wp;
+ SET_0(dest); // No < Access Technologies Request struct >
+
+ if (as_ul_tbf(tbf) != NULL)
rc = write_ia_rest_egprs_uplink_sba(as_ul_tbf(tbf),
dest, usf, alpha, gamma, ta_idx);
- } else {
- dest->cur_bit = wp;
+ else
rc = write_ia_rest_egprs_uplink_mba(dest, fn, alpha,
gamma);
- }
} else {
OSMO_ASSERT(!tbf || !tbf->is_egprs_enabled());
- bitvec_write_field(dest, &wp, 3, 2);// "HH"
- bitvec_write_field(dest, &wp, 0, 2);// "0" Packet Uplink
Assignment
+ SET_H(dest); SET_H(dest); // "HH"
+ SET_0(dest); SET_0(dest); // "00" < Packet Uplink Assignment >
- if (as_ul_tbf(tbf) != NULL) {
- dest->cur_bit = wp;
+ if (as_ul_tbf(tbf) != NULL)
rc = write_ia_rest_uplink_mba(as_ul_tbf(tbf), dest,
usf, alpha, gamma, ta_idx);
- } else {
- dest->cur_bit = wp;
+ else
rc = write_ia_rest_uplink_sba(dest, fn, alpha, gamma);
- }
}
if (rc < 0) {
--
To view, visit https://gerrit.osmocom.org/13245
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ed5270bf95c3f6e9e026ff447eef8539f6f0314
Gerrit-Change-Number: 13245
Gerrit-PatchSet: 1
Gerrit-Owner: Max
Change in osmo-pcu[master]: Debian: bump copyright year
Max has posted comments on this change. ( https://gerrit.osmocom.org/13240 ) Change subject: Debian: bump copyright year .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/13240/1/debian/copyright File debian/copyright: https://gerrit.osmocom.org/#/c/13240/1/debian/copyright@16 PS1, Line 16:src/gprs_coding_scheme.cpp > this file is already in line 19 Ack https://gerrit.osmocom.org/#/c/13240/1/debian/copyright@26 PS1, Line 26: > Update to 2019, too? Ack -- To view, visit https://gerrit.osmocom.org/13240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If61a510fbbcd549dc7bdf6e38643a00d242be875 Gerrit-Change-Number: 13240 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 13 Mar 2019 17:48:50 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-pcu[master]: TBF-DL: cosmetic update for helper routines
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13244
Change subject: TBF-DL: cosmetic update for helper routines
..
TBF-DL: cosmetic update for helper routines
* use enum values where appropriate
* reformat to proper code style to improve readability
Change-Id: If1d2bc69b0d43fc520e579457007704b7975117e
---
M src/tbf_dl.cpp
1 file changed, 32 insertions(+), 38 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/44/13244/1
diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp
index 04c6499..08df05a 100644
--- a/src/tbf_dl.cpp
+++ b/src/tbf_dl.cpp
@@ -688,7 +688,7 @@
* the current limit.
*/
cs = m_rlc.block(index)->cs_current_trans;
- GprsCodingScheme &cs_init = m_rlc.block(index)->cs_init;
+ enum CodingScheme cs_init = m_rlc.block(index)->cs_init;
bsns[0] = index;
num_bsns = 1;
@@ -702,11 +702,10 @@
* if the intial mcs is 8 and retransmission mcs is either 6 or 3
* we have to include the padding of 6 octets in first segment
*/
- if ((CodingScheme(cs_init) == MCS8) &&
- (CodingScheme(cs) == MCS6 ||
- CodingScheme(cs) == MCS3)) {
+ if ((cs_init == MCS8) &&
+ (cs == MCS6 || cs == MCS3)) {
if (spb_status == EGPRS_RESEG_DL_DEFAULT ||
- spb_status == EGPRS_RESEG_SECOND_SEG_SENT)
+ spb_status == EGPRS_RESEG_SECOND_SEG_SENT)
need_padding = true;
} else if (num_bsns == 1) {
/* TODO: remove the conditional when MCS-6 padding isn't
@@ -1248,8 +1247,12 @@
egprs_rlc_dl_reseg_bsn_state *block_status_dl =
&rlc_data->spb_status.block_status_dl;
- GprsCodingScheme &cs_current_trans = m_rlc.block(bsn)->cs_current_trans;
- GprsCodingScheme &cs_init = m_rlc.block(bsn)->cs_init;
+ enum CodingScheme cs_init = CodingScheme(rlc_data->cs_init);
+ enum CodingScheme cs_current_trans =
CodingScheme(rlc_data->cs_current_trans);
+
+ enum HeaderType ht_cs_init = rlc_data->cs_init.headerTypeData();
+ enum HeaderType ht_cs_current_trans =
rlc_data->cs_current_trans.headerTypeData();
+
*block_data = &rlc_data->block[0];
/*
@@ -1259,10 +1262,9 @@
* MCS8: second segment starts at 31
* MCS4: second segment starts at 44/2 = 22
*/
- if (cs_current_trans.headerTypeData() ==
- HEADER_EGPRS_DATA_TYPE_3) {
+ if (ht_cs_current_trans == HEADER_EGPRS_DATA_TYPE_3) {
if (*block_status_dl == EGPRS_RESEG_FIRST_SEG_SENT) {
- switch (CodingScheme(cs_init)) {
+ switch (cs_init) {
case MCS6 :
case MCS9 :
*block_data = &rlc_data->block[37];
@@ -1281,21 +1283,17 @@
LOGPTBFDL(this, LOGL_ERROR,
"FIXME: Software error: hit invalid
condition. "
"headerType(%d) blockstatus(%d)
cs(%s) PLEASE FIX!\n",
- cs_current_trans.headerTypeData(),
+ ht_cs_current_trans,
*block_status_dl, mcs_name(cs_init));
break;
}
return EGPRS_RESEG_SECOND_SEG_SENT;
- } else if ((cs_init.headerTypeData() ==
- HEADER_EGPRS_DATA_TYPE_1) ||
- (cs_init.headerTypeData() ==
- HEADER_EGPRS_DATA_TYPE_2)) {
+ } else if ((ht_cs_init == HEADER_EGPRS_DATA_TYPE_1) ||
+ (ht_cs_init == HEADER_EGPRS_DATA_TYPE_2)) {
return EGPRS_RESEG_FIRST_SEG_SENT;
- } else if ((CodingScheme(cs_init) ==
- MCS4) &&
- (CodingScheme(cs_current_trans) ==
- MCS1)) {
+ } else if ((cs_init == MCS4) &&
+ (cs_current_trans == MCS1)) {
return EGPRS_RESEG_FIRST_SEG_SENT;
}
}
@@ -1320,34 +1318,30 @@
enum egprs_rlcmac_dl_spb gprs_rlcmac_dl_tbf::get_egprs_dl_spb(const int bsn)
{
struct gprs_rlc_data *rlc_data = m_rlc.block(bsn);
- egprs_rlc_dl_reseg_bsn_state block_status_dl =
- rlc_data->spb_status.block_status_dl;
+ egprs_rlc_dl_reseg_bsn_state block_status_dl =
rlc_data->spb_status.block_status_dl;
- GprsCodingScheme &cs_current_trans = m_rlc.block(bsn)->cs_current_trans;
- GprsCodingScheme &cs_init = m_rlc.block(bsn)->cs_init;
+ enum CodingScheme cs_init
Change in osmo-pcu[master]: TBF: update MCS counters
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13243
Change subject: TBF: update MCS counters
..
TBF: update MCS counters
* use enum CodingScheme directly instead of converting it to class and
back
* drop useless mode check
* log errorneous update attempt
Change-Id: I763136c2f356d63aa3d28d09c57fd5faf5336258
---
M src/tbf.h
M src/tbf_dl.cpp
M src/tbf_ul.cpp
3 files changed, 116 insertions(+), 126 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/43/13243/1
diff --git a/src/tbf.h b/src/tbf.h
index dc0b050..0a58862 100644
--- a/src/tbf.h
+++ b/src/tbf.h
@@ -648,7 +648,7 @@
int abort();
uint16_t window_size() const;
void set_window_size();
- void update_coding_scheme_counter_dl(const GprsCodingScheme cs);
+ void update_coding_scheme_counter_dl(enum CodingScheme cs);
/* TODO: add the gettimeofday as parameter */
struct msgb *llc_dequeue(bssgp_bvc_ctx *bctx);
@@ -751,7 +751,7 @@
uint16_t window_size() const;
void set_window_size();
- void update_coding_scheme_counter_ul(const GprsCodingScheme cs);
+ void update_coding_scheme_counter_ul(enum CodingScheme cs);
/* Please note that all variables here will be reset when changing
* from WAIT RELEASE back to FLOW state (re-use of TBF).
diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp
index 13ef143..04c6499 100644
--- a/src/tbf_dl.cpp
+++ b/src/tbf_dl.cpp
@@ -1364,68 +1364,63 @@
m_window.set_ws(ws);
}
-void gprs_rlcmac_dl_tbf::update_coding_scheme_counter_dl(const
GprsCodingScheme cs)
+void gprs_rlcmac_dl_tbf::update_coding_scheme_counter_dl(enum CodingScheme cs)
{
- uint8_t coding_scheme = 0;
-
- coding_scheme = CodingScheme(cs);
- if (mcs_is_gprs(cs)) {
- switch (coding_scheme) {
- case CS1 :
- bts->gprs_dl_cs1();
- rate_ctr_inc(&m_dl_gprs_ctrs->ctr[TBF_CTR_GPRS_DL_CS1]);
- break;
- case CS2 :
- bts->gprs_dl_cs2();
- rate_ctr_inc(&m_dl_gprs_ctrs->ctr[TBF_CTR_GPRS_DL_CS2]);
- break;
- case CS3 :
- bts->gprs_dl_cs3();
- rate_ctr_inc(&m_dl_gprs_ctrs->ctr[TBF_CTR_GPRS_DL_CS3]);
- break;
- case CS4 :
- bts->gprs_dl_cs4();
- rate_ctr_inc(&m_dl_gprs_ctrs->ctr[TBF_CTR_GPRS_DL_CS4]);
- break;
- }
- } else {
- switch (coding_scheme) {
- case MCS1 :
- bts->egprs_dl_mcs1();
-
rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS1]);
- break;
- case MCS2 :
- bts->egprs_dl_mcs2();
-
rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS2]);
- break;
- case MCS3 :
- bts->egprs_dl_mcs3();
-
rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS3]);
- break;
- case MCS4 :
- bts->egprs_dl_mcs4();
-
rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS4]);
- break;
- case MCS5 :
- bts->egprs_dl_mcs5();
-
rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS5]);
- break;
- case MCS6 :
- bts->egprs_dl_mcs6();
-
rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS6]);
- break;
- case MCS7 :
- bts->egprs_dl_mcs7();
-
rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS7]);
- break;
- case MCS8 :
- bts->egprs_dl_mcs8();
-
rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS8]);
- break;
- case MCS9 :
- bts->egprs_dl_mcs9();
-
rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS9]);
- break;
- }
+ switch (cs) {
+ case CS1:
+ bts->gprs_dl_cs1();
+ rate_ctr_inc(&m_dl_gprs_ctrs->ctr[TBF_CTR_GPRS_DL_CS1]);
+ break;
+ case CS2:
+ bts->gprs_dl_cs2();
+ rate_ctr_inc(&m_dl_gprs_ctrs->ctr[TBF_CTR_GPRS_DL_CS2]);
+ break;
+ case CS3:
+ bts->gprs_dl_cs3();
+ rate_ctr_inc(&m_dl_gprs_ctrs->ctr[TBF_CTR_GPRS_DL_CS3]);
+ break;
+ case CS4:
+ bts->gprs_dl_cs4();
+ rate_c
Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/13242
Change subject: libmsc: Allow different channel types to be requested as silent
calls
..
libmsc: Allow different channel types to be requested as silent calls
Change-Id: I82645708dd27864cf33ea9cc993ead0983415602
Signed-off-by: Sylvain Munaut
---
M include/osmocom/msc/silent_call.h
M src/libmsc/msc_vty.c
M src/libmsc/silent_call.c
3 files changed, 153 insertions(+), 22 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/42/13242/1
diff --git a/include/osmocom/msc/silent_call.h
b/include/osmocom/msc/silent_call.h
index 70324e5..dbd7dcc 100644
--- a/include/osmocom/msc/silent_call.h
+++ b/include/osmocom/msc/silent_call.h
@@ -2,9 +2,12 @@
#define _SILENT_CALL_H
struct ran_conn;
+struct gsm0808_channel_type;
extern int gsm_silent_call_start(struct vlr_subscr *vsub,
- void *data, int type);
+ struct gsm0808_channel_type *ct,
+ const char *traffic_dst_ip, uint16_t traffic_dst_port,
+ void *data);
extern int gsm_silent_call_stop(struct vlr_subscr *vsub);
#if 0
diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index 2adb2a4..4ec2e5b 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -1042,21 +1042,35 @@
return rc;
}
-#define CHAN_TYPES "(any|tch/f|tch/any|sdcch)"
+#define CHAN_TYPES "(any|tch/f|tch/h|tch/any|sdcch)"
#define CHAN_TYPE_HELP \
"Any channel\n" \
"TCH/F channel\n" \
+ "TCH/H channel\n" \
"Any TCH channel\n" \
"SDCCH channel\n"
+#define CHAN_MODES "(signalling|speech-hr|speech-fr|speech-efr|speech-amr)"
+#define CHAN_MODE_HELP \
+ "Signalling only\n" \
+ "Speech with HR codec\n"\
+ "Speech with FR codec\n"\
+ "Speech with EFR codec\n" \
+ "Speech with AMR codec\n"
+
DEFUN(subscriber_silent_call_start,
subscriber_silent_call_start_cmd,
- "subscriber " SUBSCR_TYPES " ID silent-call start
(any|tch/f|tch/any|sdcch)",
+ "subscriber " SUBSCR_TYPES " ID silent-call start " CHAN_TYPES " "
CHAN_MODES " [IP] [<0-65536>]",
SUBSCR_HELP "Silent call operation\n" "Start silent call\n"
- CHAN_TYPE_HELP)
+ CHAN_TYPE_HELP CHAN_MODE_HELP
+ "Target IP for RTP traffic (default 127.0.0.1)\n"
+ "Target port for RTP traffic (default: 4000)\n")
{
struct vlr_subscr *vsub = get_vsub_by_argv(gsmnet, argv[0], argv[1]);
- int rc, type;
+ struct gsm0808_channel_type ct;
+ const char *ip = NULL;
+ uint16_t port = 0;
+ int rc, speech;
if (!vsub) {
vty_out(vty, "%% No subscriber found for %s %s%s",
@@ -1064,16 +1078,52 @@
return CMD_WARNING;
}
- if (!strcmp(argv[2], "tch/f"))
- type = RSL_CHANNEED_TCH_F;
- else if (!strcmp(argv[2], "tch/any"))
- type = RSL_CHANNEED_TCH_ForH;
- else if (!strcmp(argv[2], "sdcch"))
- type = RSL_CHANNEED_SDCCH;
- else
- type = RSL_CHANNEED_ANY;/* Defaults to ANY */
+ memset(&ct, 0x00, sizeof(ct));
- rc = gsm_silent_call_start(vsub, vty, type);
+ if (!strcmp(argv[3], "signalling")) {
+ ct.ch_indctr = GSM0808_CHAN_SIGN;
+ ct.perm_spch[0] = 0; /* Spare but required */
+ ct.perm_spch_len = 1;
+ } else if (!strcmp(argv[3], "speech-hr")) {
+ ct.ch_indctr = GSM0808_CHAN_SPEECH;
+ ct.perm_spch[0] = GSM0808_PERM_HR1;
+ ct.perm_spch_len = 1;
+ } else if (!strcmp(argv[3], "speech-fr")) {
+ ct.ch_indctr = GSM0808_CHAN_SPEECH;
+ ct.perm_spch[0] = GSM0808_PERM_FR1;
+ ct.perm_spch_len = 1;
+ } else if (!strcmp(argv[3], "speech-efr")) {
+ ct.ch_indctr = GSM0808_CHAN_SPEECH;
+ ct.perm_spch[0] = GSM0808_PERM_FR2;
+ ct.perm_spch_len = 1;
+ } else if (!strcmp(argv[3], "speech-amr")) {
+ ct.ch_indctr = GSM0808_CHAN_SPEECH;
+ ct.perm_spch[0] = GSM0808_PERM_FR3;
+ ct.perm_spch[1] = GSM0808_PERM_HR3;
+ ct.perm_spch_len = 2;
+ }
+
+ speech = ct.ch_indctr == GSM0808_CHAN_SPEECH;
+
+ if (!strcmp(argv[2], "tch/f"))
+ ct.ch_rate_type = speech ? GSM0808_SPEECH_FULL_BM :
GSM0808_SIGN_FULL_BM;
+ else if (!strcmp(argv[2], "tch/h"))
+ ct.ch_rate_type = speech ? GSM0808_SPEECH_HALF_LM :
GSM0808_SIGN_HALF_LM;
+ else if (!strcmp(argv[2], "tch/any"))
+ ct.ch_rate_type = speech ? GSM0808_SPEECH_FULL_PREF :
GSM0808_SIGN_FULL_PREF;
+ else if
Change in osmo-bsc[master]: codec_pref: fix special handling for AMR rate configuration (S15-S0)
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13093 to look at the new patch set (#8). Change subject: codec_pref: fix special handling for AMR rate configuration (S15-S0) .. codec_pref: fix special handling for AMR rate configuration (S15-S0) When match_codec_pref() is called and the codec selections from the ASSIGNMENT COMMAND are matched against the interal capabilities, the configurations are checked one by one. When a match is found that match is returned. However, the implementation currently does not check the AMR S15-S0 bits when the actual matching happens. This is done afterwards in case AMR gets picked. Unfortunately if the MSC implementation is not obeying the settings the MSC has previously communicated in the L3 COMPL message we may end up with an S15-S0 configuration that has all rate selection (which eventually end up as active set in RSL) bits set to zero. This is an invalid configuration and should be prevented. Also the handling of the S15-S0 bits should happen as part of the matching so that there is a chance to try the nect codec in the list if AMR is unuseable. Also S15-S0 has one special setting "Config-NB-Code = 1" (S1 = 1). When this bit is set, the four (in HR only three) most common rates are selected into the active set. If there are also other S-bits set besides S1 we should prefer S1 and discard the other bits. - Perform handling of S15-S0 while matching - If S1 is set, prefer this setting and discard all other settings Change-Id: Ie52376b51fe07ed07056e8df2e9557293ff67a78 Related: SYS#4470 --- M src/osmo-bsc/codec_pref.c M tests/codec_pref/codec_pref_test.ok 2 files changed, 62 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/93/13093/8 -- To view, visit https://gerrit.osmocom.org/13093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie52376b51fe07ed07056e8df2e9557293ff67a78 Gerrit-Change-Number: 13093 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: dexter
Change in osmo-bsc[master]: lchan_fsm: make sure multi rate configuration is valid
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13094 to look at the new patch set (#8). Change subject: lchan_fsm: make sure multi rate configuration is valid .. lchan_fsm: make sure multi rate configuration is valid When gsm48_mr_cfg_from_gsm0808_sc_cfg() is used to generate the AMR multirate configuration IE, make sure that lchan allocation fails in cases where the multirate configuration IE can not be generated. Change-Id: Icd3e5674b10b8ae223c0d13ae33fc9ae7e8a8a18 Depends: libosmocore I6fd7f4073b84093742c322752f2fd878d1071e15 Related: SYS#4470 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/13094/8 -- To view, visit https://gerrit.osmocom.org/13094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icd3e5674b10b8ae223c0d13ae33fc9ae7e8a8a18 Gerrit-Change-Number: 13094 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-bsc[master]: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13199 to look at the new patch set (#8). Change subject: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC .. AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC MGCP/SDP provides fmtp parameters in order to signal which of the two available AMR framing modes (octet-aligned or bandwith-efficient) should be used on the link between BSS and core network. osmo-bsc currently does not set up this mode which means that the RTP packets from the BTS are forwared without inspection/modification, which may lead to malfunction when a BTS is using a framing mode that is not supported by the other end. - Add VTY option to setup the framing mode - Generate related fmtp parameters in SDP Depends: osmo-mgw I622c01874b25f5049d4f59eb8157e0ea3cbe16ba Change-Id: If6d40b2407b87aad2227ea7f15533ef01a3771b3 Related OS#3807 --- M include/osmocom/bsc/bsc_msc_data.h M src/osmo-bsc/mgw_endpoint_fsm.c M src/osmo-bsc/osmo_bsc_vty.c 3 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/99/13199/8 -- To view, visit https://gerrit.osmocom.org/13199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6d40b2407b87aad2227ea7f15533ef01a3771b3 Gerrit-Change-Number: 13199 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: dexter Gerrit-CC: Pau Espin Pedrol
Change in osmo-bsc[master]: lchan_fsm: do not include 12.2k in active set on HR channels
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13095 to look at the new patch set (#8). Change subject: lchan_fsm: do not include 12.2k in active set on HR channels .. lchan_fsm: do not include 12.2k in active set on HR channels When "Config-NB-Code = 1" is set via the S-bits, then the resulting multirate configuration IE will contain 12.2K. Since the generator function is not aware if the lchan is activated for HR or FR it sets the flag for 12.2k always. We have to add a check here in order to set the 12.2k flag in the IE back to 0 so that the active set contains a set of useable rates. Change-Id: I40e7f568f4822040a2d1e78f22dbba0e49d0167e Related: SYS#4470 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/95/13095/8 -- To view, visit https://gerrit.osmocom.org/13095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I40e7f568f4822040a2d1e78f22dbba0e49d0167e Gerrit-Change-Number: 13095 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-bsc[master]: osmo_bsc_msc: Use meaningful amr rate configuration on BTS level
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13092 to look at the new patch set (#6). Change subject: osmo_bsc_msc: Use meaningful amr rate configuration on BTS level .. osmo_bsc_msc: Use meaningful amr rate configuration on BTS level The current configuration for permitted AMR rates on BTS level has been choosen arbitrarily. Lets choose the possible rates so that they match the "Config-NB-Code = 1" as defined in 3GPP TS 28.062 Table 7.11.3.1.3-2. (The current default behavior is not changed since the MSC level configuration only permits 5.90k by default.) Change-Id: I916953e3fdb54168671dd13b359e78662fa31059 Related: SYS#4470 --- M src/osmo-bsc/gsm_data.c 1 file changed, 17 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/92/13092/6 -- To view, visit https://gerrit.osmocom.org/13092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I916953e3fdb54168671dd13b359e78662fa31059 Gerrit-Change-Number: 13092 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-ttcn3-hacks[master]: BSC_Tests: add testcases to verify S15-S0 handling
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13237 to look at the new patch set (#2). Change subject: BSC_Tests: add testcases to verify S15-S0 handling .. BSC_Tests: add testcases to verify S15-S0 handling The handling of the AMR rate configuration bits S15-S0 is currently only superficially checked. Lets add more some more elaborated testcases to check through varios different situations. Also make sure that the resulting mr configuration IE is verified Change-Id: Ica323deb9836deea72982e093c9cb31deb5a216b Related: SYS#4470 --- M bsc/BSC_Tests.ttcn M bsc/MSC_ConnectionHandler.ttcn M library/Osmocom_VTY_Functions.ttcn 3 files changed, 230 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/13237/2 -- To view, visit https://gerrit.osmocom.org/13237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ica323deb9836deea72982e093c9cb31deb5a216b Gerrit-Change-Number: 13237 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_assignment_codec_amr_f/h
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13236 to look at the new patch set (#2). Change subject: BSC_Tests: fix TC_assignment_codec_amr_f/h .. BSC_Tests: fix TC_assignment_codec_amr_f/h The testcase TC_assignment_codec_amr_f uses a combination of S-Bits that has S1 which configures a set of four rates at once. This is quite a complex situation and since the BSC was upgraded with new features affecting the behavior in this special case lets simplify this testcase for now. depends: osmo-bsc Ie52376b51fe07ed07056e8df2e9557293ff67a78 Change-Id: Ibf730f76947cdeed23eb3119167450e3b7a9b314 Related: SYS#4470 --- M bsc/BSC_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/13236/2 -- To view, visit https://gerrit.osmocom.org/13236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibf730f76947cdeed23eb3119167450e3b7a9b314 Gerrit-Change-Number: 13236 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol
Change in osmo-bsc[master]: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13199 to look at the new patch set (#7). Change subject: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC .. AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC MGCP/SDP provides fmtp parameters in order to signal which of the two available AMR framing modes (octet-aligned or bandwith-efficient) should be used on the link between BSS and core network. osmo-bsc currently does not set up this mode which means that the RTP packets from the BTS are forwared without inspection/modification, which may lead to malfunction when a BTS is using a framing mode that is not supported by the other end. - Add VTY option to setup the framing mode - Generate related fmtp parameters in SDP Depends: osmo-mgw I622c01874b25f5049d4f59eb8157e0ea3cbe16ba Change-Id: If6d40b2407b87aad2227ea7f15533ef01a3771b3 Related OS#3807 --- M include/osmocom/bsc/bsc_msc_data.h M src/osmo-bsc/mgw_endpoint_fsm.c M src/osmo-bsc/osmo_bsc_vty.c 3 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/99/13199/7 -- To view, visit https://gerrit.osmocom.org/13199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6d40b2407b87aad2227ea7f15533ef01a3771b3 Gerrit-Change-Number: 13199 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: dexter Gerrit-CC: Pau Espin Pedrol
Change in osmo-bsc[master]: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13199 ) Change subject: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC .. Patch Set 6: > mgw_endpoint_fsm.c: In function ‘mgcp_pick_codec’: > mgw_endpoint_fsm.c:781:12: error: ‘struct mgcp_conn_peer’ has no > member named ‘param_present’ > verb_info->param_present = true; That is expected. This patch depends on changes in libosmo-mgcp-client. But I see that the change id at Depends: is wrong... -- To view, visit https://gerrit.osmocom.org/13199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6d40b2407b87aad2227ea7f15533ef01a3771b3 Gerrit-Change-Number: 13199 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: dexter Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 16:39:58 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in libosmo-netif[master]: amr_test: add to .gitignore, use -noinstall flag
Max has posted comments on this change. ( https://gerrit.osmocom.org/13241 ) Change subject: amr_test: add to .gitignore, use -noinstall flag .. Patch Set 1: > On stream_stream_test_LDFLAGS there is an stream_stream_test_LDFLAGS = > -no-install, but on jibuf_jibuf_test_SOURCES there is not. I wonder if jibuf > also has this problem. It's kinda tricky to test: to reproduce it on my system for example I've got to 1st install libosmo-netif version which does not include functions used by jibuf_test and than try to build it to see if it fails. Personally I'd prefer to just enable '-no-install' globally for all the tests by default and be done with it. -- To view, visit https://gerrit.osmocom.org/13241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94ccff42dfba71aaf59bb30ca312db0bac58c27d Gerrit-Change-Number: 13241 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Alexander Huemer Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pablo Neira Ayuso Gerrit-Reviewer: dexter Gerrit-Reviewer: steve-m Gerrit-Comment-Date: Wed, 13 Mar 2019 16:36:45 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in libosmo-netif[master]: amr_test: add to .gitignore, use -noinstall flag
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13241 ) Change subject: amr_test: add to .gitignore, use -noinstall flag .. Patch Set 1: On stream_stream_test_LDFLAGS there is an stream_stream_test_LDFLAGS = -no-install, but on jibuf_jibuf_test_SOURCES there is not. I wonder if jibuf also has this problem. -- To view, visit https://gerrit.osmocom.org/13241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94ccff42dfba71aaf59bb30ca312db0bac58c27d Gerrit-Change-Number: 13241 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Alexander Huemer Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pablo Neira Ayuso Gerrit-Reviewer: dexter Gerrit-Reviewer: steve-m Gerrit-Comment-Date: Wed, 13 Mar 2019 16:32:34 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in libosmo-netif[master]: amr_test: add to .gitignore, use -noinstall flag
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13241 ) Change subject: amr_test: add to .gitignore, use -noinstall flag .. Patch Set 1: Verified+1 Code-Review+1 > Worked for me too. I'm still puzzled why it doesn't fail for > jenkins tests or other people. What kind of libtool witchcraft is > that?! I have quickly tested it and it looks ok to me. -- To view, visit https://gerrit.osmocom.org/13241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94ccff42dfba71aaf59bb30ca312db0bac58c27d Gerrit-Change-Number: 13241 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Alexander Huemer Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pablo Neira Ayuso Gerrit-Reviewer: dexter Gerrit-Reviewer: steve-m Gerrit-Comment-Date: Wed, 13 Mar 2019 16:28:53 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition
Max has posted comments on this change. ( https://gerrit.osmocom.org/13067 ) Change subject: MCS: move HeaderType enum outside of class definition .. Patch Set 7: (4 comments) https://gerrit.osmocom.org/#/c/13067/5/debian/copyright File debian/copyright: https://gerrit.osmocom.org/#/c/13067/5/debian/copyright@9 PS5, Line 9:2016-2019 sysmocom s.m.f.c. GmbH > Update copyright year Done in separate patch. https://gerrit.osmocom.org/#/c/13067/5/src/coding_scheme.h File src/coding_scheme.h: https://gerrit.osmocom.org/#/c/13067/5/src/coding_scheme.h@43 PS5, Line 43: uint8_t num_data_blocks(enum HeaderType ht); > What about using usual C style code in new functions we add? > num_data_blocks() […] Ack https://gerrit.osmocom.org/#/c/13067/5/src/gprs_coding_scheme.h File src/gprs_coding_scheme.h: https://gerrit.osmocom.org/#/c/13067/5/src/gprs_coding_scheme.h@a70 PS5, Line 70: > This one looks non-related, I didn't see it being moved somewhere else like > other stuff. Ack https://gerrit.osmocom.org/#/c/13067/5/src/gprs_coding_scheme.cpp File src/gprs_coding_scheme.cpp: https://gerrit.osmocom.org/#/c/13067/5/src/gprs_coding_scheme.cpp@a320 PS5, Line 320: > Same. If it's really not used, drop it in another commit. Ack -- To view, visit https://gerrit.osmocom.org/13067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f Gerrit-Change-Number: 13067 Gerrit-PatchSet: 7 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-CC: Harald Welte Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 16:21:37 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in libosmo-netif[master]: amr_test: add to .gitignore, use -noinstall flag
Max has posted comments on this change. ( https://gerrit.osmocom.org/13241 ) Change subject: amr_test: add to .gitignore, use -noinstall flag .. Patch Set 1: Code-Review+1 Worked for me too. I'm still puzzled why it doesn't fail for jenkins tests or other people. What kind of libtool witchcraft is that?! -- To view, visit https://gerrit.osmocom.org/13241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94ccff42dfba71aaf59bb30ca312db0bac58c27d Gerrit-Change-Number: 13241 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Alexander Huemer Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pablo Neira Ayuso Gerrit-Reviewer: steve-m Gerrit-Comment-Date: Wed, 13 Mar 2019 16:19:50 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: MCS: remove unused function
Hello Pau Espin Pedrol, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13239 to look at the new patch set (#2). Change subject: MCS: remove unused function .. MCS: remove unused function Change-Id: I32ab5ac36a0db90f2bea670b7684784b83a90b6b --- M src/gprs_coding_scheme.cpp M src/gprs_coding_scheme.h 2 files changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/39/13239/2 -- To view, visit https://gerrit.osmocom.org/13239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I32ab5ac36a0db90f2bea670b7684784b83a90b6b Gerrit-Change-Number: 13239 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith
Change in osmo-pcu[master]: Debian: bump copyright year
Hello Pau Espin Pedrol, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13240 to look at the new patch set (#2). Change subject: Debian: bump copyright year .. Debian: bump copyright year Change-Id: If61a510fbbcd549dc7bdf6e38643a00d242be875 --- M debian/copyright 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/40/13240/2 -- To view, visit https://gerrit.osmocom.org/13240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If61a510fbbcd549dc7bdf6e38643a00d242be875 Gerrit-Change-Number: 13240 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith
Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13067 to look at the new patch set (#7). Change subject: MCS: move HeaderType enum outside of class definition .. MCS: move HeaderType enum outside of class definition Move functions which compute number of blocks or bits depending on header type and corresponding enum outside of GprsCodingScheme class. This will allows us to use standard libosmocore value_sting functions in upcoming patches for IA Rest Octet encoding/decoding. Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f --- M debian/copyright M src/Makefile.am A src/coding_scheme.c M src/coding_scheme.h M src/decoding.cpp M src/encoding.cpp M src/gprs_bssgp_pcu.cpp M src/gprs_coding_scheme.cpp M src/gprs_coding_scheme.h M src/rlc.cpp M src/tbf_dl.cpp M tests/edge/EdgeTest.cpp 12 files changed, 122 insertions(+), 92 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/67/13067/7 -- To view, visit https://gerrit.osmocom.org/13067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f Gerrit-Change-Number: 13067 Gerrit-PatchSet: 7 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-CC: Harald Welte Gerrit-CC: Pau Espin Pedrol
Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_assignment_codec_amr_f/h
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13236 ) Change subject: BSC_Tests: fix TC_assignment_codec_amr_f/h .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/13236/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13236/1//COMMIT_MSG@12 PS1, Line 12: affecting the behavior in this special case lets implify this testcase typo: simplify -- To view, visit https://gerrit.osmocom.org/13236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf730f76947cdeed23eb3119167450e3b7a9b314 Gerrit-Change-Number: 13236 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 16:14:24 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in libosmo-netif[master]: amr_test: add to .gitignore, use -noinstall flag
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13241 Change subject: amr_test: add to .gitignore, use -noinstall flag .. amr_test: add to .gitignore, use -noinstall flag Do not link the test against already installed libraries: https://osmocom.org/issues/3812#note-10 Related: OS#3812 Change-Id: I94ccff42dfba71aaf59bb30ca312db0bac58c27d --- M .gitignore M tests/Makefile.am 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/41/13241/1 diff --git a/.gitignore b/.gitignore index e2f2fb9..23d5b42 100644 --- a/.gitignore +++ b/.gitignore @@ -57,3 +57,4 @@ jibuf_tool osmux_test2 stream_test +amr_test diff --git a/tests/Makefile.am b/tests/Makefile.am index 36447be..a86799c 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -19,6 +19,7 @@ amr_amr_test_SOURCES = amr/amr_test.c amr_amr_test_LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(top_builddir)/src/libosmonetif.la +amr_amr_test_LDFLAGS = -no-install if HAVE_PCAP check_PROGRAMS += jibuf/jibuf_tool -- To view, visit https://gerrit.osmocom.org/13241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I94ccff42dfba71aaf59bb30ca312db0bac58c27d Gerrit-Change-Number: 13241 Gerrit-PatchSet: 1 Gerrit-Owner: osmith
Change in osmo-bsc[master]: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13199 ) Change subject: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC .. Patch Set 6: mgw_endpoint_fsm.c: In function ‘mgcp_pick_codec’: mgw_endpoint_fsm.c:781:12: error: ‘struct mgcp_conn_peer’ has no member named ‘param_present’ verb_info->param_present = true; -- To view, visit https://gerrit.osmocom.org/13199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6d40b2407b87aad2227ea7f15533ef01a3771b3 Gerrit-Change-Number: 13199 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 16:13:15 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-dev[master]: run.sh: fix $TO_RAN_IP and $TO_RAN_IU_IP usage
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13235 ) Change subject: run.sh: fix $TO_RAN_IP and $TO_RAN_IU_IP usage .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f0f749b74fe5fd3982e045283735151f69c2487 Gerrit-Change-Number: 13235 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 16:11:43 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: ipaccess/Makefile.am: Remove unneeded libosmo-sigtran dep
Max has posted comments on this change. ( https://gerrit.osmocom.org/13219 ) Change subject: ipaccess/Makefile.am: Remove unneeded libosmo-sigtran dep .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc26f178fa8942fe407ca01e23b0a21955727dca Gerrit-Change-Number: 13219 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Comment-Date: Wed, 13 Mar 2019 16:05:08 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: Move msc related code from gsm_data to bsc_msc
Max has posted comments on this change. ( https://gerrit.osmocom.org/13221 ) Change subject: Move msc related code from gsm_data to bsc_msc .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I508188896be58ddc3bd4e9c3c661c258c06866f4 Gerrit-Change-Number: 13221 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Comment-Date: Wed, 13 Mar 2019 16:04:32 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: configure.ac: Add flag to enable/disable build of ipaccess related utils
Max has posted comments on this change. ( https://gerrit.osmocom.org/13222 ) Change subject: configure.ac: Add flag to enable/disable build of ipaccess related utils .. Patch Set 2: Is there particular use-case or setup where we don't want ipaccess utils built? Would be nice to expand commit message with additional information. -- To view, visit https://gerrit.osmocom.org/13222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff70dc46c77b2ac58351ad9a91caf3f524c6fd89 Gerrit-Change-Number: 13222 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Max Gerrit-Comment-Date: Wed, 13 Mar 2019 16:03:02 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-bsc[master]: src/utils/Makefile.am: Drop unneeded sigtran and mgcp-client deps
Max has posted comments on this change. ( https://gerrit.osmocom.org/13223 ) Change subject: src/utils/Makefile.am: Drop unneeded sigtran and mgcp-client deps .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/13223/2/src/utils/Makefile.am File src/utils/Makefile.am: https://gerrit.osmocom.org/#/c/13223/2/src/utils/Makefile.am@a135 PS2, Line 135: That doesn't seem related. -- To view, visit https://gerrit.osmocom.org/13223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a91d673e08c161dd6110bd16e8f52cb17be398c Gerrit-Change-Number: 13223 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Max Gerrit-Comment-Date: Wed, 13 Mar 2019 16:01:25 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-bsc[master]: Move LCLS references from gsm_data to osmo_bsc_lcls
Max has posted comments on this change. ( https://gerrit.osmocom.org/13220 ) Change subject: Move LCLS references from gsm_data to osmo_bsc_lcls .. Patch Set 1: Code-Review+1 I don't really get how moving stuff unrelated to sigtran helps to get rid of sigtran dependency but the change itself seems rather harmless. -- To view, visit https://gerrit.osmocom.org/13220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8941f059d6e4eb21a971d48d2b66c29ec3355a6d Gerrit-Change-Number: 13220 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-CC: Harald Welte Gerrit-Comment-Date: Wed, 13 Mar 2019 16:00:24 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: net_init.c: remove unneeded header
Max has posted comments on this change. ( https://gerrit.osmocom.org/13224 ) Change subject: net_init.c: remove unneeded header .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c2d07914bb19429bfc1f2c5a38a513749068304 Gerrit-Change-Number: 13224 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Comment-Date: Wed, 13 Mar 2019 16:00:46 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ttcn3-hacks[master]: ggsn: add tests to validate IPv4v6 pdp ctx
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13231 ) Change subject: ggsn: add tests to validate IPv4v6 pdp ctx .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13231/1/ggsn_tests/GGSN_Tests.ttcn File ggsn_tests/GGSN_Tests.ttcn: https://gerrit.osmocom.org/#/c/13231/1/ggsn_tests/GGSN_Tests.ttcn@1090 PS1, Line 1090: //f_send_gtpu(ctx, c_neigh_solicit); > Comment clarifying why this is commented out might be helpful. […] Done -- To view, visit https://gerrit.osmocom.org/13231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bab7df5caddc5c8b973c81544f954d5473ac234 Gerrit-Change-Number: 13231 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 13 Mar 2019 15:58:07 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-ttcn3-hacks[master]: ggsn: add tests to validate IPv4v6 pdp ctx
Hello Pau Espin Pedrol, Daniel Willmann, Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13231 to look at the new patch set (#2). Change subject: ggsn: add tests to validate IPv4v6 pdp ctx .. ggsn: add tests to validate IPv4v6 pdp ctx Add related templates based on 3GPP TS 29.060 Figure 37A and create tests based on existing IPv4 and v6 ones. Related: OS#2900 Change-Id: I3bab7df5caddc5c8b973c81544f954d5473ac234 --- M ggsn_tests/GGSN_Tests.ttcn M library/GTP_Templates.ttcn 2 files changed, 198 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/31/13231/2 -- To view, visit https://gerrit.osmocom.org/13231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3bab7df5caddc5c8b973c81544f954d5473ac234 Gerrit-Change-Number: 13231 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol
Change in libosmo-sccp[master]: improve logging for rejected AS in xua_rkm.c
Max has posted comments on this change. ( https://gerrit.osmocom.org/13229 ) Change subject: improve logging for rejected AS in xua_rkm.c .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13229 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id22e3c6bab5f7b597df3514eedb162277ce0ef7d Gerrit-Change-Number: 13229 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Comment-Date: Wed, 13 Mar 2019 15:57:07 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: incoming connect: don't crash if calling addr is missing
Max has posted comments on this change. ( https://gerrit.osmocom.org/13227 ) Change subject: incoming connect: don't crash if calling addr is missing .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib028432b37a5c48b677bb21b869cc722575dce92 Gerrit-Change-Number: 13227 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 15:55:39 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: log N-CONNECT from MSC
Max has posted comments on this change. ( https://gerrit.osmocom.org/13228 ) Change subject: log N-CONNECT from MSC .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83f15c7231b2b766aba4d25339d08acbbca3a47e Gerrit-Change-Number: 13228 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 15:55:11 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmo-sccp[master]: Fix output of route destination in 'show ss7 instance <0-15> route'
Max has posted comments on this change. ( https://gerrit.osmocom.org/13233 ) Change subject: Fix output of route destination in 'show ss7 instance <0-15> route' .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13233/1/src/osmo_ss7.c File src/osmo_ss7.c: https://gerrit.osmocom.org/#/c/13233/1/src/osmo_ss7.c@852 PS1, Line 852: Those look rather generic? Maybe make it part of libosmocore bits.h? -- To view, visit https://gerrit.osmocom.org/13233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa4fdbad953d40f222beb470a082eed8c20991ef Gerrit-Change-Number: 13233 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Max Gerrit-Comment-Date: Wed, 13 Mar 2019 15:54:38 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in libosmo-sccp[master]: Store + show remote ip/port in dynamically created ASPs
Max has posted comments on this change. ( https://gerrit.osmocom.org/13234 ) Change subject: Store + show remote ip/port in dynamically created ASPs .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39a1c57bc72e8aff607f3a551811a2f6372adab4 Gerrit-Change-Number: 13234 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 15:51:59 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: MCS: remove unused function
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13239 ) Change subject: MCS: remove unused function .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32ab5ac36a0db90f2bea670b7684784b83a90b6b Gerrit-Change-Number: 13239 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 13 Mar 2019 15:53:02 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: Debian: update copyright file
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13240 ) Change subject: Debian: update copyright file .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/13240/1/debian/copyright File debian/copyright: https://gerrit.osmocom.org/#/c/13240/1/debian/copyright@16 PS1, Line 16:src/coding_scheme.h this file is already in line 19 https://gerrit.osmocom.org/#/c/13240/1/debian/copyright@26 PS1, Line 26: 7 Update to 2019, too? -- To view, visit https://gerrit.osmocom.org/13240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If61a510fbbcd549dc7bdf6e38643a00d242be875 Gerrit-Change-Number: 13240 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 13 Mar 2019 15:51:36 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in libosmo-sccp[master]: vty: Ensure to properly save route pointcode and mask when writing
Max has posted comments on this change. ( https://gerrit.osmocom.org/13232 ) Change subject: vty: Ensure to properly save route pointcode and mask when writing .. Patch Set 2: Code-Review+2 (1 comment) I agree that *2() is confusing as it's used for both '2nd version' and '2nd call' but cleaning that is out of scope of this patch indeed. https://gerrit.osmocom.org/#/c/13232/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13232/1//COMMIT_MSG@7 PS1, Line 7: vty: Ensure to properly save route pointcode and mask when writing > I'm of course referring to "Maksim" which is IIRC closer to the cyrillic > original of Maxim. […] Yepp, Максим it is :) -- To view, visit https://gerrit.osmocom.org/13232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica32e83cbe8af2317cb07f8d8422a399fa537012 Gerrit-Change-Number: 13232 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 15:51:11 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmo-ttcn3-hacks[master]: ggsn: add tests to validate IPv4v6 pdp ctx
Max has posted comments on this change. ( https://gerrit.osmocom.org/13231 ) Change subject: ggsn: add tests to validate IPv4v6 pdp ctx .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13231/1/ggsn_tests/GGSN_Tests.ttcn File ggsn_tests/GGSN_Tests.ttcn: https://gerrit.osmocom.org/#/c/13231/1/ggsn_tests/GGSN_Tests.ttcn@1090 PS1, Line 1090: //f_send_gtpu(ctx, c_neigh_solicit); Comment clarifying why this is commented out might be helpful. Or maybe simply drop it? -- To view, visit https://gerrit.osmocom.org/13231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bab7df5caddc5c8b973c81544f954d5473ac234 Gerrit-Change-Number: 13231 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 13 Mar 2019 15:44:16 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-pcu[master]: Fix TA index encoder
Max has posted comments on this change. ( https://gerrit.osmocom.org/13238 ) Change subject: Fix TA index encoder .. Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/13238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54482790e1cf3cb13a635a99a481250576deabaf Gerrit-Change-Number: 13238 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Comment-Date: Wed, 13 Mar 2019 15:41:06 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-pcu[master]: MCS: move Mode enum outside of class definition
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13163 to look at the new patch set (#3). Change subject: MCS: move Mode enum outside of class definition .. MCS: move Mode enum outside of class definition Move Mode (EDGE/GPRS) definition and related functions outside of GprsCodingScheme class. This allows us to use standard libosmocore value_sting functions. Change-Id: I3baaac7f1ca3f5b88917a23c1679d63847455f47 --- M src/coding_scheme.c M src/coding_scheme.h M src/gprs_coding_scheme.cpp M src/gprs_coding_scheme.h M src/gprs_ms.cpp M src/gprs_ms.h M src/pcu_vty_functions.cpp M src/tbf.cpp M tests/edge/EdgeTest.cpp 9 files changed, 50 insertions(+), 51 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/63/13163/3 -- To view, visit https://gerrit.osmocom.org/13163 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3baaac7f1ca3f5b88917a23c1679d63847455f47 Gerrit-Change-Number: 13163 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Harald Welte
Change in osmo-pcu[master]: MCS: remove unused function
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13239
Change subject: MCS: remove unused function
..
MCS: remove unused function
Change-Id: I32ab5ac36a0db90f2bea670b7684784b83a90b6b
---
M src/gprs_coding_scheme.cpp
M src/gprs_coding_scheme.h
2 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/39/13239/1
diff --git a/src/gprs_coding_scheme.cpp b/src/gprs_coding_scheme.cpp
index bcbb893..c0955d3 100644
--- a/src/gprs_coding_scheme.cpp
+++ b/src/gprs_coding_scheme.cpp
@@ -317,11 +317,6 @@
return mcs_info[m_scheme].family == mcs_info[o.m_scheme].family;
}
-bool GprsCodingScheme::isCombinable(GprsCodingScheme o) const
-{
- return numDataBlocks() == o.numDataBlocks();
-}
-
void GprsCodingScheme::decToSingleBlock(bool *needStuffing)
{
switch (m_scheme) {
diff --git a/src/gprs_coding_scheme.h b/src/gprs_coding_scheme.h
index d97df08..80f8502 100644
--- a/src/gprs_coding_scheme.h
+++ b/src/gprs_coding_scheme.h
@@ -67,7 +67,6 @@
bool isCompatible(Mode mode) const;
bool isCompatible(GprsCodingScheme o) const;
bool isFamilyCompatible(GprsCodingScheme o) const;
- bool isCombinable(GprsCodingScheme o) const;
void inc(Mode mode);
void dec(Mode mode);
--
To view, visit https://gerrit.osmocom.org/13239
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I32ab5ac36a0db90f2bea670b7684784b83a90b6b
Gerrit-Change-Number: 13239
Gerrit-PatchSet: 1
Gerrit-Owner: Max
Change in osmo-pcu[master]: Debian: update copyright file
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13240 Change subject: Debian: update copyright file .. Debian: update copyright file * add missing header * bump copyright year Change-Id: If61a510fbbcd549dc7bdf6e38643a00d242be875 --- M debian/copyright 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/40/13240/1 diff --git a/debian/copyright b/debian/copyright index 5bb2110..ca64f2b 100644 --- a/debian/copyright +++ b/debian/copyright @@ -6,13 +6,14 @@ Files: * Copyright: 2009-2015 Holger Hans Peter Freyther 2013 Jacob Erlbeck - 2016-2017 sysmocom s.m.f.c. GmbH + 2016-2019 sysmocom s.m.f.c. GmbH 2015 by Yves Godin License: AGPL-3.0+ Files: src/gprs_ms_storage.h src/gprs_ms_storage.cpp src/gprs_ms.h + src/coding_scheme.h src/gprs_coding_scheme.cpp src/gprs_coding_scheme.h src/coding_scheme.h -- To view, visit https://gerrit.osmocom.org/13240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If61a510fbbcd549dc7bdf6e38643a00d242be875 Gerrit-Change-Number: 13240 Gerrit-PatchSet: 1 Gerrit-Owner: Max
Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13067 to look at the new patch set (#6). Change subject: MCS: move HeaderType enum outside of class definition .. MCS: move HeaderType enum outside of class definition Move functions which compute number of blocks or bits depending on header type and corresponding enum outside of GprsCodingScheme class. This will allows us to use standard libosmocore value_sting functions in upcoming patches for IA Rest Octet encoding/decoding. Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f --- M debian/copyright M src/Makefile.am A src/coding_scheme.c M src/coding_scheme.h M src/decoding.cpp M src/encoding.cpp M src/gprs_bssgp_pcu.cpp M src/gprs_coding_scheme.cpp M src/gprs_coding_scheme.h M src/rlc.cpp M src/tbf_dl.cpp M tests/edge/EdgeTest.cpp 12 files changed, 122 insertions(+), 92 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/67/13067/6 -- To view, visit https://gerrit.osmocom.org/13067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f Gerrit-Change-Number: 13067 Gerrit-PatchSet: 6 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-CC: Harald Welte Gerrit-CC: Pau Espin Pedrol
Change in osmo-bsc[master]: codec_pref: fix special handling for AMR rate configuration (S15-S0)
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13093 ) Change subject: codec_pref: fix special handling for AMR rate configuration (S15-S0) .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/13093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie52376b51fe07ed07056e8df2e9557293ff67a78 Gerrit-Change-Number: 13093 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: dexter Gerrit-Comment-Date: Wed, 13 Mar 2019 15:26:28 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-pcu[master]: Fix TA index encoder
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13238
Change subject: Fix TA index encoder
..
Fix TA index encoder
The TAI is described as { 0 | 1 < TIMING_ADVANCE_INDEX : bit (4) > } in
3GPP TS 44.018 §10.5.2.16.1 so it should be encoded with if-else.
Change-Id: I54482790e1cf3cb13a635a99a481250576deabaf
---
M src/encoding.cpp
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/38/13238/1
diff --git a/src/encoding.cpp b/src/encoding.cpp
index e81ff42..55838fb 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -117,13 +117,13 @@
{
int rc;
- if (tai < 0) /* No TIMING_ADVANCE_INDEX: */
+ if (tai < 0) { /* No TIMING_ADVANCE_INDEX: */
SET_0(dest);
-
- /* TIMING_ADVANCE_INDEX: */
- SET_1(dest);
- rc = bitvec_set_u64(dest, tai, 4, false);
- CHECK(rc);
+ } else { /* TIMING_ADVANCE_INDEX: */
+ SET_1(dest);
+ rc = bitvec_set_u64(dest, tai, 4, false);
+ CHECK(rc);
+ }
return 0;
}
--
To view, visit https://gerrit.osmocom.org/13238
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54482790e1cf3cb13a635a99a481250576deabaf
Gerrit-Change-Number: 13238
Gerrit-PatchSet: 1
Gerrit-Owner: Max
Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_assignment_codec_amr_f/h
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13236
Change subject: BSC_Tests: fix TC_assignment_codec_amr_f/h
..
BSC_Tests: fix TC_assignment_codec_amr_f/h
The testcase TC_assignment_codec_amr_f uses a combination of S-Bits that
has S1 which configures a set of four rates at once. This is quite a
complex situation and since the BSC was upgraded with new features
affecting the behavior in this special case lets implify this testcase
for now.
depends: osmo-bsc Ie52376b51fe07ed07056e8df2e9557293ff67a78
Change-Id: Ibf730f76947cdeed23eb3119167450e3b7a9b314
Related: SYS#4470
---
M bsc/BSC_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/36/13236/1
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 5d8f375..58001e5 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -2045,7 +2045,7 @@
};
pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F}));
- pars.ass_codec_list.codecElements[0].s0_7 := '0110'B;
+ pars.ass_codec_list.codecElements[0].s0_7 := '0100'B; /* 5,90k */
pars.ass_codec_list.codecElements[0].s8_15 := '01010111'B;
pars.expect_mr_conf_ie := mr_conf;
@@ -2069,7 +2069,7 @@
};
pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H}));
- pars.ass_codec_list.codecElements[0].s0_7 := '0110'B;
+ pars.ass_codec_list.codecElements[0].s0_7 := '0100'B; /* 5,90k */
pars.ass_codec_list.codecElements[0].s8_15 := '0111'B;
pars.expect_mr_conf_ie := mr_conf;
--
To view, visit https://gerrit.osmocom.org/13236
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf730f76947cdeed23eb3119167450e3b7a9b314
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Change in osmo-ttcn3-hacks[master]: BSC_Tests: add testcases to verify S15-S0 handling
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13237
Change subject: BSC_Tests: add testcases to verify S15-S0 handling
..
BSC_Tests: add testcases to verify S15-S0 handling
The handling of the AMR rate configuration bits S15-S0 is currently only
superficially checked. Lets add more some more elaborated testcases to
check through varios different situations. Also make sure that the
resulting mr configuration IE is verified
Change-Id: Ica323deb9836deea72982e093c9cb31deb5a216b
Related: SYS#4470
---
M bsc/BSC_Tests.ttcn
M bsc/MSC_ConnectionHandler.ttcn
M library/Osmocom_VTY_Functions.ttcn
3 files changed, 230 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/37/13237/1
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 58001e5..659b3f6 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1953,6 +1953,10 @@
ass_cmd.pdu.bssmap.assignmentRequest.codecList :=
g_pars.ass_codec_list;
exp_compl.pdu.bssmap.assignmentComplete.speechCodec.codecElements[0] :=
g_pars.ass_codec_list.codecElements[0];
+ if (isvalue(g_pars.expect_mr_s0_s7)) {
+
exp_compl.pdu.bssmap.assignmentComplete.speechCodec.codecElements[0].s0_7 :=
+
g_pars.expect_mr_s0_s7;
+ }
}
ass_cmd.pdu.bssmap.assignmentRequest.channelType :=
f_BSSMAP_chtype_from_codec(g_pars.ass_codec_list.codecElements[0]);
@@ -1994,6 +1998,22 @@
}
}
+private function f_TC_assignment_codec_fail(charstring id) runs on
MSC_ConnHdlr {
+
+ var PDU_BSSAP ass_cmd := f_gen_ass_req();
+ var template PDU_BSSAP exp_fail := tr_BSSMAP_AssignmentFail;
+
+ /* puzzle together the ASSIGNMENT REQ for given codec[s] */
+ if (mp_bssap_cfg.transport == BSSAP_TRANSPORT_AoIP) {
+ ass_cmd.pdu.bssmap.assignmentRequest.codecList :=
g_pars.ass_codec_list;
+ }
+ ass_cmd.pdu.bssmap.assignmentRequest.channelType :=
+
f_BSSMAP_chtype_from_codec(g_pars.ass_codec_list.codecElements[0]);
+ log("expecting ASS FAIL like this: ", exp_fail);
+
+ f_establish_fully(ass_cmd, exp_fail);
+}
+
testcase TC_assignment_codec_fr() runs on test_CT {
var TestHdlrParams pars := f_gen_test_hdlr_pars();
var MSC_ConnHdlr vc_conn;
@@ -2030,6 +2050,37 @@
vc_conn.done;
}
+/* Allow 5,90k only (current default config) */
+private function f_allow_amr_rate_5_90k() runs on test_CT {
+ f_vty_enter_cfg_msc(BSCVTY, 0);
+ f_vty_transceive(BSCVTY, "amr-config 12_2k forbidden");
+ f_vty_transceive(BSCVTY, "amr-config 10_2k forbidden");
+ f_vty_transceive(BSCVTY, "amr-config 7_95k forbidden");
+ f_vty_transceive(BSCVTY, "amr-config 7_40k forbidden");
+ f_vty_transceive(BSCVTY, "amr-config 6_70k forbidden");
+ f_vty_transceive(BSCVTY, "amr-config 5_90k allowed");
+ f_vty_transceive(BSCVTY, "amr-config 5_15k forbidden");
+ f_vty_transceive(BSCVTY, "amr-config 4_75k forbidden");
+ f_vty_transceive(BSCVTY, "exit");
+ f_vty_transceive(BSCVTY, "exit");
+}
+
+/* Allow 4,75k, 5,90k, 4,70k and 12,2k, which are the most common rates
+ * ("Config-NB-Code = 1") */
+private function f_allow_amr_rate_4_75k_5_90k_7_40k_12_20k() runs on test_CT {
+ f_vty_enter_cfg_msc(BSCVTY, 0);
+ f_vty_transceive(BSCVTY, "amr-config 12_2k allowed");
+ f_vty_transceive(BSCVTY, "amr-config 10_2k forbidden");
+ f_vty_transceive(BSCVTY, "amr-config 7_95k forbidden");
+ f_vty_transceive(BSCVTY, "amr-config 7_40k allowed");
+ f_vty_transceive(BSCVTY, "amr-config 6_70k forbidden");
+ f_vty_transceive(BSCVTY, "amr-config 5_90k allowed");
+ f_vty_transceive(BSCVTY, "amr-config 5_15k forbidden");
+ f_vty_transceive(BSCVTY, "amr-config 4_75k allowed");
+ f_vty_transceive(BSCVTY, "exit");
+ f_vty_transceive(BSCVTY, "exit");
+}
+
testcase TC_assignment_codec_amr_f() runs on test_CT {
var TestHdlrParams pars := f_gen_test_hdlr_pars();
var MSC_ConnHdlr vc_conn;
@@ -2080,6 +2131,160 @@
vc_conn.done;
}
+function f_TC_assignment_codec_amr(boolean fr, octetstring mrconf, bitstring
s8_s0, bitstring exp_s8_s0)
+runs on test_CT {
+
+ var TestHdlrParams pars := f_gen_test_hdlr_pars();
+ var MSC_ConnHdlr vc_conn;
+
+ /* See note above */
+ var RSL_IE_Body mr_conf := {
+ other := {
+ len := lengthof(mrconf),
+ payload := mrconf
+ }
+ };
+
+ if (fr) {
+ pars.ass_codec_list :=
valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F}));
+ } else {
+ pars.ass_c
Change in osmo-bsc[master]: lchan_fsm: make sure multi rate configuration is valid
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13094 to look at the new patch set (#7). Change subject: lchan_fsm: make sure multi rate configuration is valid .. lchan_fsm: make sure multi rate configuration is valid When gsm48_mr_cfg_from_gsm0808_sc_cfg() is used to generate the AMR multirate configuration IE, make sure that lchan allocation fails in cases where the multirate configuration IE can not be generated. Change-Id: Icd3e5674b10b8ae223c0d13ae33fc9ae7e8a8a18 Depends: libosmocore I6fd7f4073b84093742c322752f2fd878d1071e15 Related: SYS#4470 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/13094/7 -- To view, visit https://gerrit.osmocom.org/13094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icd3e5674b10b8ae223c0d13ae33fc9ae7e8a8a18 Gerrit-Change-Number: 13094 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-bsc[master]: lchan_fsm: do not include 12.2k in active set on HR channels
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13095 to look at the new patch set (#7). Change subject: lchan_fsm: do not include 12.2k in active set on HR channels .. lchan_fsm: do not include 12.2k in active set on HR channels When "Config-NB-Code = 1" is set via the S-bits, then the resulting multirate configuration IE will contain 12.2K. Since the generator function is not aware if the lchan is activated for HR or FR it sets the flag for 12.2k always. We have to add a check here in order to set the 12.2k flag in the IE back to 0 so that the active set contains a set of useable rates. Change-Id: I40e7f568f4822040a2d1e78f22dbba0e49d0167e Related: SYS#4470 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/95/13095/7 -- To view, visit https://gerrit.osmocom.org/13095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I40e7f568f4822040a2d1e78f22dbba0e49d0167e Gerrit-Change-Number: 13095 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-bsc[master]: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13199 to look at the new patch set (#6). Change subject: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC .. AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC MGCP/SDP provides fmtp parameters in order to signal which of the two available AMR framing modes (octet-aligned or bandwith-efficient) should be used on the link between BSS and core network. osmo-bsc currently does not set up this mode which means that the RTP packets from the BTS are forwared without inspection/modification, which may lead to malfunction when a BTS is using a framing mode that is not supported by the other end. - Add VTY option to setup the framing mode - Generate related fmtp parameters in SDP Depends: osmo-mgw I622c01874b25f5049d4f59eb8157e0ea3cbe16ba Change-Id: If6d40b2407b87aad2227ea7f15533ef01a3771b3 Related OS#3807 --- M include/osmocom/bsc/bsc_msc_data.h M src/osmo-bsc/mgw_endpoint_fsm.c M src/osmo-bsc/osmo_bsc_vty.c 3 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/99/13199/6 -- To view, visit https://gerrit.osmocom.org/13199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6d40b2407b87aad2227ea7f15533ef01a3771b3 Gerrit-Change-Number: 13199 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102)
Change in libosmo-netif[master]: amr: be sure result of osmo_amr_bwe_to_oa() fits into int buf
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13211 ) Change subject: amr: be sure result of osmo_amr_bwe_to_oa() fits into int buf .. amr: be sure result of osmo_amr_bwe_to_oa() fits into int buf osmo_amr_bwe_to_oa() uses an internal buffer with static size to store intermediate results. The buffer is large enough for any real world situation, but the check that tests if the result would fit into the internal buffer is incorrect. It checks if there is enough room for the existing payload, but does not include the expected growth of the payload. Eventually the buffer could be overrun by one byte if one would put a 256 byte long AMR payload. Fixes: CID#195926 Change-Id: I4d7ac570a0b48368a82183673c46bca5f235f228 --- M src/amr.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Max: Looks good to me, but someone else must approve Pau Espin Pedrol: Looks good to me, approved diff --git a/src/amr.c b/src/amr.c index 9b423e8..9c63f60 100644 --- a/src/amr.c +++ b/src/amr.c @@ -158,7 +158,7 @@ if (payload_len + 1 > payload_maxlen) return -1; - if (payload_len > sizeof(buf)) + if (payload_len + 1 > sizeof(buf)) return -1; buf[0] = payload[0] & 0xf0; -- To view, visit https://gerrit.osmocom.org/13211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4d7ac570a0b48368a82183673c46bca5f235f228 Gerrit-Change-Number: 13211 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: dexter
Change in libosmo-netif[master]: amr: cosmetic: correct sourcecode formatting
dexter has submitted this change and it was merged. (
https://gerrit.osmocom.org/13210 )
Change subject: amr: cosmetic: correct sourcecode formatting
..
amr: cosmetic: correct sourcecode formatting
Change-Id: Ie4ad6b1a2382da4dc21e66a45c2a96224cab5752
---
M src/amr.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
Max: Looks good to me, but someone else must approve
Pau Espin Pedrol: Looks good to me, approved
diff --git a/src/amr.c b/src/amr.c
index d3f7b38..9b423e8 100644
--- a/src/amr.c
+++ b/src/amr.c
@@ -165,7 +165,7 @@
buf[1] = payload[0] << 4;
buf[1] |= (payload[1] >> 4) & 0x0c;
- for (i = 0; i < frame_len -1; i++) {
+ for (i = 0; i < frame_len - 1; i++) {
buf[i + 2] = payload[i + 1] << 2;
buf[i + 2] |= payload[i + 2] >> 6;
}
--
To view, visit https://gerrit.osmocom.org/13210
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4ad6b1a2382da4dc21e66a45c2a96224cab5752
Gerrit-Change-Number: 13210
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: dexter
Change in libosmo-netif[master]: amr: make buffer in osmo_amr_bwe_to_oa() static
dexter has abandoned this change. ( https://gerrit.osmocom.org/13212 ) Change subject: amr: make buffer in osmo_amr_bwe_to_oa() static .. Abandoned -- To view, visit https://gerrit.osmocom.org/13212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I8ffbf3a4515e1c2385a0b6b2d5fe8e756056fb0d Gerrit-Change-Number: 13212 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol
Change in osmo-dev[master]: run.sh: fix $TO_RAN_IP and $TO_RAN_IU_IP usage
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13235
Change subject: run.sh: fix $TO_RAN_IP and $TO_RAN_IU_IP usage
..
run.sh: fix $TO_RAN_IP and $TO_RAN_IU_IP usage
Add curly braces around both variables, so they get replaced properly
again.
Change-Id: I1f0f749b74fe5fd3982e045283735151f69c2487
---
M net/templates/run.sh
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/35/13235/1
diff --git a/net/templates/run.sh b/net/templates/run.sh
index 804262a..3244b11 100755
--- a/net/templates/run.sh
+++ b/net/templates/run.sh
@@ -27,14 +27,14 @@
sudo ip link set $apn up
fi
-if [ -z "$(ip addr show | grep "$TO_RAN_IP")" ]; then
- echo "No interface has IP address $TO_RAN_IP! Hit enter to continue anyway."
+if [ -z "$(ip addr show | grep "${TO_RAN_IP}")" ]; then
+ echo "No interface has IP address ${TO_RAN_IP}! Hit enter to continue
anyway."
read enter_to_continue
fi
-if [ -z "$(ip addr show | grep "$TO_RAN_IU_IP")" ]; then
- echo "No interface has IP address $TO_RAN_IU_IP! Hit enter to 'ip addr add
$TO_RAN_IU_IP/32 dev $dev'"
+if [ -z "$(ip addr show | grep "${TO_RAN_IU_IP}")" ]; then
+ echo "No interface has IP address ${TO_RAN_IU_IP}! Hit enter to 'ip addr add
${TO_RAN_IU_IP}/32 dev $dev'"
read enter_to_continue
- sudo ip addr add $TO_RAN_IU_IP/32 dev $dev
+ sudo ip addr add ${TO_RAN_IU_IP}/32 dev $dev
fi
logdir="current_log"
--
To view, visit https://gerrit.osmocom.org/13235
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f0f749b74fe5fd3982e045283735151f69c2487
Gerrit-Change-Number: 13235
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
