date:20191108

Build failure of network:osmocom:nightly/osmo-hlr in xUbuntu_16.04/x86_64

2019-11-08 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/osmo-hlr failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-hlr

Last lines of build log:
[  308s] | CFLAGS='-g -O2 -fPIE -fstack-protector-strong -Wformat 
-Werror=format-security'
[  308s] | CPP='gcc -E'
[  308s] | CPPFLAGS='-Wdate-time -D_FORTIFY_SOURCE=2'
[  308s] | CYGPATH_W='echo'
[  308s] | DB_SQLITE_DEBUG_FALSE=''
[  308s] | DB_SQLITE_DEBUG_TRUE='#'
[  308s] | DEFS='-DPACKAGE_NAME=\"osmo-hlr\" -DPACKAGE_TARNAME=\"osmo-hlr\" 
-DPACKAGE_VERSION=\"1.1.0.10-5b65\" -DPACKAGE_STRING=\"osmo-hlr\ 
1.1.0.10-5b65\" -DPACKAGE_BUGREPORT=\"open...@lists.osmocom.org\" 
-DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DPACKAGE=\"osmo-hlr\" -DVERSION=\"1.1.0.10-5b65\" 
-DSTDC_HEADERS=1'
[  308s] | DEPDIR='.deps'
[  308s] | DLLTOOL='false'
[  308s] | DSYMUTIL=''
[  308s] | DUMPBIN=''
[  308s] | ECHO_C=''
[  308s] | ECHO_N='-n'
[  308s] | ECHO_T=''
[  308s] | EGREP='/bin/grep -E'
[  308s] | ENABLE_EXT_TESTS_FALSE=''
[  308s] | ENABLE_EXT_TESTS_TRUE='#'
[  308s] | EXEEXT=''
[  308s] | FGREP='/bin/grep -F'
[  308s] | GREP='/bin/grep'
[  308s] | HAVE_SYSTEMD_FALSE='#'
[  308s] | HAVE_SYSTEMD_TRUE=''
[  308s] | INSTALL_DATA='${INSTALL} -m 644'
[  310s] | INSTALL_PROGRAM=[  258.081864] sysrq: SysRq : Power Off
[  310s] [  258.086519] reboot: Power down
[  311s] ### VM INTERACTION END ###
[  311s] 
[  311s] cloud113 failed "build osmo-hlr_1.1.0.10.5b65.dsc" at Sat Nov  9 
03:26:14 UTC 2019.
[  311s] 

-- 
Configure notifications at https://build.opensuse.org/my/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-hlr in Debian_8.0/x86_64

2019-11-08 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_8.0/x86_64

Package network:osmocom:nightly/osmo-hlr failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-hlr

Last lines of build log:
[  218s] | #define HAVE_MEMORY_H 1
[  218s] | #define HAVE_STRINGS_H 1
[  218s] | #define HAVE_INTTYPES_H 1
[  218s] | #define HAVE_STDINT_H 1
[  218s] | #define HAVE_UNISTD_H 1
[  218s] | #define HAVE_DLFCN_H 1
[  218s] | #define LT_OBJDIR ".libs/"
[  218s] | #define PACKAGE "osmo-hlr"
[  218s] | #define VERSION "1.1.0.10-5b65"
[  218s] | #define STDC_HEADERS 1
[  218s] | 
[  218s] | configure: exit 0
[  218s] 
[  218s] debian/rules:17: recipe for target 'override_dh_auto_test' failed
[  218s] make[1]: *** [override_dh_auto_test] Error 1
[  218s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  218s] debian/rules:7: recipe for target 'build' failed
[  218s] make: *** [build] Error 2
[  218s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  218s] 
[  218s] lamb09 failed "build osmo-hlr_1.1.0.10.5b65.dsc" at Sat Nov  9 
03:24:53 UTC 2019.
[  218s] 
[  218s] ### VM INTERACTION START ###
[  219s] Powering off.
[  219s] [  205.881122] reboot: Power down
[  219s] ### VM INTERACTION END ###
[  219s] 
[  219s] lamb09 failed "build osmo-hlr_1.1.0.10.5b65.dsc" at Sat Nov  9 
03:24:55 UTC 2019.
[  219s] 

-- 
Configure notifications at https://build.opensuse.org/my/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-hlr in Debian_8.0/i586

2019-11-08 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_8.0/i586

Package network:osmocom:nightly/osmo-hlr failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-hlr

Last lines of build log:
[  193s] | #define HAVE_MEMORY_H 1
[  193s] | #define HAVE_STRINGS_H 1
[  193s] | #define HAVE_INTTYPES_H 1
[  193s] | #define HAVE_STDINT_H 1
[  193s] | #define HAVE_UNISTD_H 1
[  193s] | #define HAVE_DLFCN_H 1
[  193s] | #define LT_OBJDIR ".libs/"
[  193s] | #define PACKAGE "osmo-hlr"
[  193s] | #define VERSION "1.1.0.10-5b65"
[  193s] | #define STDC_HEADERS 1
[  193s] | 
[  193s] | configure: exit 0
[  193s] 
[  193s] debian/rules:17: recipe for target 'override_dh_auto_test' failed
[  193s] make[1]: *** [override_dh_auto_test] Error 1
[  193s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  193s] debian/rules:7: recipe for target 'build' failed
[  193s] make: *** [build] Error 2
[  193s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  193s] 
[  193s] lamb15 failed "build osmo-hlr_1.1.0.10.5b65.dsc" at Sat Nov  9 
02:42:10 UTC 2019.
[  193s] 
[  193s] ### VM INTERACTION START ###
[  194s] Powering off.
[  194s] [  181.414526] reboot: Power down
[  194s] ### VM INTERACTION END ###
[  194s] 
[  194s] lamb15 failed "build osmo-hlr_1.1.0.10.5b65.dsc" at Sat Nov  9 
02:42:12 UTC 2019.
[  194s] 

-- 
Configure notifications at https://build.opensuse.org/my/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-pcu[master]: gprs_bssgp_destroy(): fix NULL-pointer dereference

2019-11-08 Thread fixeria

fixeria has abandoned this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/15281 )

Change subject: gprs_bssgp_destroy(): fix NULL-pointer dereference
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15281
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I42cb911a679b9198fd06e74b42f1e2cb28323de9
Gerrit-Change-Number: 15281
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: abandon

Change in osmo-pcu[master]: gprs_bssgp_destroy(): fix memleak and NULL-pointer dereference

2019-11-08 Thread fixeria

Hello pespin, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-pcu/+/16018

to look at the new patch set (#2).

Change subject: gprs_bssgp_destroy(): fix memleak and NULL-pointer dereference
..

gprs_bssgp_destroy(): fix memleak and NULL-pointer dereference

So far there was a memory leak, because free()ing 'the_pcu.bctx'
would cause ASAN to complain. And that's reasonable, because it
needs to be freed properly. Moreover, 'the_pcu.bctx' may simply
be uninitialized in some cases, e.g. when OsmoPCU is terminated
before connecting to the SGSN.

Let's use the new bssgp_bvc_ctx_free() from libosmogb.

Change-Id: I274e79e1746c7678b81720ec11e8a564befe38ba
Depends: Ia78979379dbdccd6e4628c16f00d0c06d9212172
---
M src/gprs_bssgp_pcu.cpp
1 file changed, 1 insertion(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/18/16018/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16018
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I274e79e1746c7678b81720ec11e8a564befe38ba
Gerrit-Change-Number: 16018
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: GPRS/BSSGP: introduce bssgp_bvc_ctx_free()

2019-11-08 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/16017 )

Change subject: GPRS/BSSGP: introduce bssgp_bvc_ctx_free()
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16017
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia78979379dbdccd6e4628c16f00d0c06d9212172
Gerrit-Change-Number: 16017
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 19:16:18 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: GPRS/BSSGP: introduce bssgp_bvc_ctx_free()

2019-11-08 Thread fixeria

Hello pespin, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/16017

to look at the new patch set (#3).

Change subject: GPRS/BSSGP: introduce bssgp_bvc_ctx_free()
..

GPRS/BSSGP: introduce bssgp_bvc_ctx_free()

So far we had a function to allocate a new bssgp_bvc_ctx, but not
the opposite one. Let's finally introduce it, so it will be used
at least in OsmoPCU.

Please note that the new symbol has 'bssgp_' prefix, not 'btsctx_'.

Change-Id: Ia78979379dbdccd6e4628c16f00d0c06d9212172
---
M TODO-RELEASE
M include/osmocom/gprs/gprs_bssgp.h
M src/gb/gprs_bssgp.c
M src/gb/libosmogb.map
4 files changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/17/16017/3
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16017
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia78979379dbdccd6e4628c16f00d0c06d9212172
Gerrit-Change-Number: 16017
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-pcu[master]: gprs_bssgp_destroy(): fix NULL-pointer dereference

2019-11-08 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/15281 )

Change subject: gprs_bssgp_destroy(): fix NULL-pointer dereference
..


Patch Set 4: Code-Review-2

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/15281/4/src/gprs_bssgp_pcu.cpp
File src/gprs_bssgp_pcu.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/15281/4/src/gprs_bssgp_pcu.cpp@977
PS4, Line 977:  if (the_pcu.bctx != NULL) {
Better move this into the free() API. free() APIs are usually expected to allow 
NULL pointers.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15281
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I42cb911a679b9198fd06e74b42f1e2cb28323de9
Gerrit-Change-Number: 15281
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 19:11:35 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: gprs_bssgp_destroy(): fix memleak: use bssgp_bvc_ctx_free()

2019-11-08 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16018 )

Change subject: gprs_bssgp_destroy(): fix memleak: use bssgp_bvc_ctx_free()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16018
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I274e79e1746c7678b81720ec11e8a564befe38ba
Gerrit-Change-Number: 16018
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 19:11:03 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: GPRS/BSSGP: introduce bssgp_bvc_ctx_free()

2019-11-08 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/16017 )

Change subject: GPRS/BSSGP: introduce bssgp_bvc_ctx_free()
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/16017/2/src/gb/gprs_bssgp.c
File src/gb/gprs_bssgp.c:

https://gerrit.osmocom.org/c/libosmocore/+/16017/2/src/gb/gprs_bssgp.c@146
PS2, Line 146:  rate_ctr_group_free(ctx->ctrg);
Missing check against ctx being NULL.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16017
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia78979379dbdccd6e4628c16f00d0c06d9212172
Gerrit-Change-Number: 16017
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 19:10:27 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: core/defs.h: introduce and use OSMO_DEPRECATED_OUTSIDE

2019-11-08 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/14864 )

Change subject: core/defs.h: introduce and use OSMO_DEPRECATED_OUTSIDE
..


Patch Set 3:

(2 comments)

Please explain better why you are changing the behavior.

https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/core/defs.h
File include/osmocom/core/defs.h:

https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/core/defs.h@46
PS3, Line 46: # define OSMO_DEPRECATED_OUTSIDE(text)
It's more clear if you keep and extend older name:
OSMO_DEPRECATED_OUTSIDE_LIBOSMOCORE_TXT(text)


https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/gsm/gsm48_ie.h
File include/osmocom/gsm/gsm48_ie.h:

https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/gsm/gsm48_ie.h@18
PS3, Line 18:   OSMO_DEPRECATED_OUTSIDE("Use gsm48_decode_bcd_number2() for 
improved bounds checking");
Why shouldn't libosmocore use gsm48_decode_bcd_number2?

In some specific cases, it may make more sense to disable the relative pragma 
for deprecation and enable it afterwards after using the function. I'm pretty 
sure that can be done and is far more clear.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14864
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1b0eff1396776900c1286e41da3aee3ff78b326e
Gerrit-Change-Number: 14864
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 19:09:12 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_req_id_req_ra_update

2019-11-08 Thread pespin

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16016

to look at the new patch set (#2).

Change subject: sgsn: Introduce test TC_attach_req_id_req_ra_update
..

sgsn: Introduce test TC_attach_req_id_req_ra_update

The scenario in this test triggers a crash in osmo-sgsn fixed by
osmo-sgsn.git I64fa5cf1b427d3abb99e553e584897261a827ce6.

With that osmo-sgsn patch applied, the process doesn't crash anymore but
the test still fails due to an XID message being sent with a new
yet-not-seen-by-ttcn3 TLLI and as a result TTCN3 BSSGP_Emulation fails:
BSSGP_Emulation.ttcn:390 setverdict(fail): none -> fail reason: "Couldn't find 
Component for TLLI 'FE791757'O", new component reason: "Couldn't find Component 
for TLLI 'FE791757'O"

Other than that, the test runs fine. It still needs to be clarified
whether the new TLLI sent by osmo-sgsn is expected and test needs to be
fixed, or whether it's an sgsn bug.

Related: OS#3957, OS#4245
Change-Id: Id5554a91a8bda712e282c5a3e9e30fb0ca1ec0e8
---
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
2 files changed, 39 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/16/16016/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16016
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id5554a91a8bda712e282c5a3e9e30fb0ca1ec0e8
Gerrit-Change-Number: 16016
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in osmo-pcu[master]: gprs_bssgp_destroy(): fix NULL-pointer dereference

2019-11-08 Thread fixeria

Hello pespin, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-pcu/+/15281

to look at the new patch set (#4).

Change subject: gprs_bssgp_destroy(): fix NULL-pointer dereference
..

gprs_bssgp_destroy(): fix NULL-pointer dereference

The 'gprs_bssgp_pcu' may not be initialized in some cases, e.g.
when OsmoPCU is terminated before connecting to the SGSN. Make
sure it was allocated before trying to release it.

Change-Id: I42cb911a679b9198fd06e74b42f1e2cb28323de9
---
M src/gprs_bssgp_pcu.cpp
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/81/15281/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15281
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I42cb911a679b9198fd06e74b42f1e2cb28323de9
Gerrit-Change-Number: 15281
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-pcu[master]: gprs_bssgp_destroy(): fix memleak: use bssgp_bvc_ctx_free()

2019-11-08 Thread fixeria

fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16018 )


Change subject: gprs_bssgp_destroy(): fix memleak: use bssgp_bvc_ctx_free()
..

gprs_bssgp_destroy(): fix memleak: use bssgp_bvc_ctx_free()

So far there was a memory leak, because free()ing 'the_pcu.bctx'
would cause ASAN to complain. And that's reasonable, because it
needs to be freed properly. Use the new libosmogb's API for that.

Change-Id: I274e79e1746c7678b81720ec11e8a564befe38ba
Depends: Ia78979379dbdccd6e4628c16f00d0c06d9212172
---
M src/gprs_bssgp_pcu.cpp
1 file changed, 1 insertion(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/18/16018/1

diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index abcb106..f367ae2 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -974,12 +974,7 @@

gprs_ns_destroy(nsi);

-   /* FIXME: move this to libgb: btsctx_free() */
-   llist_del(_pcu.bctx->list);
-#warning "This causes ASAN to complain. It is not critical for normal 
operation but should be fixed nevertheless"
-#if 0
-   talloc_free(the_pcu.bctx);
-#endif
+   bssgp_bvc_ctx_free(the_pcu.bctx);
the_pcu.bctx = NULL;
 }


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16018
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I274e79e1746c7678b81720ec11e8a564befe38ba
Gerrit-Change-Number: 16018
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange

Change in libosmocore[master]: GPRS/BSSGP: introduce bssgp_bvc_ctx_free()

2019-11-08 Thread fixeria

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/16017

to look at the new patch set (#2).

Change subject: GPRS/BSSGP: introduce bssgp_bvc_ctx_free()
..

GPRS/BSSGP: introduce bssgp_bvc_ctx_free()

So far we had a function to allocate a new bssgp_bvc_ctx, but not
the opposite one. Let's finally introduce it, so it will be used
at least in OsmoPCU.

Please note that the new symbol has 'bssgp_' prefix, not 'btsctx_'.

Change-Id: Ia78979379dbdccd6e4628c16f00d0c06d9212172
---
M TODO-RELEASE
M include/osmocom/gprs/gprs_bssgp.h
M src/gb/gprs_bssgp.c
M src/gb/libosmogb.map
4 files changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/17/16017/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16017
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia78979379dbdccd6e4628c16f00d0c06d9212172
Gerrit-Change-Number: 16017
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: GPRS/BSSGP: introduce bssgp_bvc_ctx_free()

2019-11-08 Thread fixeria

fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmocore/+/16017 )


Change subject: GPRS/BSSGP: introduce bssgp_bvc_ctx_free()
..

GPRS/BSSGP: introduce bssgp_bvc_ctx_free()

Change-Id: Ia78979379dbdccd6e4628c16f00d0c06d9212172
---
M TODO-RELEASE
M include/osmocom/gprs/gprs_bssgp.h
M src/gb/gprs_bssgp.c
M src/gb/libosmogb.map
4 files changed, 11 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/17/16017/1

diff --git a/TODO-RELEASE b/TODO-RELEASE
index 9af92c1..692bdc1 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -10,3 +10,4 @@
 core   osmo_tdef_get() change val_if_not_present arg from 
unsigned long to long to allow passing -1
 core   struct osmo_tdeffields min_val,max_val added, ABI break 
(arrays of structs used in programs)
 gsmAPI added   osmo_gsm48_rfpowercap2powerclass()
+gb API added   bssgp_bvc_ctx_free()
diff --git a/include/osmocom/gprs/gprs_bssgp.h 
b/include/osmocom/gprs/gprs_bssgp.h
index 400c3e0..0f87333 100644
--- a/include/osmocom/gprs/gprs_bssgp.h
+++ b/include/osmocom/gprs/gprs_bssgp.h
@@ -112,6 +112,8 @@
 struct bssgp_bvc_ctx *btsctx_by_raid_cid(const struct gprs_ra_id *raid, 
uint16_t cid);
 /* Find a BTS context based on BVCI+NSEI tuple */
 struct bssgp_bvc_ctx *btsctx_by_bvci_nsei(uint16_t bvci, uint16_t nsei);
+/* Free a given BTS context */
+void bssgp_bvc_ctx_free(struct bssgp_bvc_ctx *ctx);

 #define BVC_F_BLOCKED  0x0001

diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c
index b695c28..d98e4fa 100644
--- a/src/gb/gprs_bssgp.c
+++ b/src/gb/gprs_bssgp.c
@@ -141,6 +141,13 @@
return ctx;
 }

+void bssgp_bvc_ctx_free(struct bssgp_bvc_ctx *ctx)
+{
+   rate_ctr_group_free(ctx->ctrg);
+   llist_del(>list);
+   talloc_free(ctx);
+}
+
 /* Chapter 10.4.5: Flow Control BVC ACK */
 static int bssgp_tx_fc_bvc_ack(uint16_t nsei, uint8_t tag, uint16_t ns_bvci)
 {
diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map
index 5e675a6..ad139c1 100644
--- a/src/gb/libosmogb.map
+++ b/src/gb/libosmogb.map
@@ -80,6 +80,7 @@
 gprs_log_filter_fn;

 btsctx_alloc;
+bssgp_bvc_ctx_free;
 btsctx_by_bvci_nsei;
 btsctx_by_raid_cid;


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16017
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia78979379dbdccd6e4628c16f00d0c06d9212172
Gerrit-Change-Number: 16017
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_req_id_req_ra_update

2019-11-08 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16016 )


Change subject: sgsn: Introduce test TC_attach_req_id_req_ra_update
..

sgsn: Introduce test TC_attach_req_id_req_ra_update

The scenario in this test triggers a crash in osmo-sgsn fixed by
osmo-sgsn.git I64fa5cf1b427d3abb99e553e584897261a827ce6.

With that osmo-sgsn patch applied, the process doesn't crash anymore but
the test still fails due to an XID message being sent with a new
yet-not-seen-by-ttcn3 TLLI and as a result TTCN3 BSSGP_Emulation fails:
BSSGP_Emulation.ttcn:390 setverdict(fail): none -> fail reason: "Couldn't find 
Component for TLLI 'FE791757'O", new component reason: "Couldn't find Component 
for TLLI 'FE791757'O"

Other than that, the test runs fine. It still needs to be clarified
whether the new TLLI sent by osmo-sgsn is expected and test needs to be
fixed, or whether it's an sgsn bug.

Related: OS#3957, OS#4245
Change-Id: Id5554a91a8bda712e282c5a3e9e30fb0ca1ec0e8
---
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
2 files changed, 36 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/16/16016/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index a89a949..a643ce4 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -2814,6 +2814,38 @@
f_cleanup();
 }

+private function f_TC_attach_req_id_req_ra_update(charstring id) runs on 
BSSGP_ConnHdlr {
+   var RoutingAreaIdentificationV old_ra := f_random_RAI();
+   var RoutingAreaIdentificationV new_ra := f_random_RAI(); /* TODO: make 
sure old_ra != new_ra */
+   var template PDU_L3_MS_SGSN attach_req := 
ts_GMM_ATTACH_REQ(f_mi_get_lv(), old_ra, false, false, omit, omit);
+   var PDU_L3_SGSN_MS l3_mt;
+
+   f_send_l3(attach_req, 0);
+
+   BSSGP[0].receive(tr_GMM_ID_REQ('010'B));
+
+   f_send_l3(ts_GMM_RAU_REQ(f_mi_get_lv(), GPRS_UPD_T_RA, new_ra, false, 
omit, omit));
+   alt {
+   [] BSSGP[0].receive(tr_GMM_RAU_REJECT('0a'O)) {
+   setverdict(pass);
+   }
+   [] BSSGP[0].receive { repeat; }
+   }
+}
+
+testcase TC_attach_req_id_req_ra_update() runs on test_CT {
+   /*
+* MS --> SGSN: Attach Req (TMSI, RAI=901-70-356-101)
+* MS <-- SGSN: Identity Request (IMEI)
+* MS --> SGSN: RA Updating (RAI=901-70-2758-208)
+*/
+   var BSSGP_ConnHdlr vc_conn;
+   f_init();
+   vc_conn := f_start_handler(refers(f_TC_attach_req_id_req_ra_update), 
testcasename(), g_gb, 26);
+   vc_conn.done;
+   f_cleanup();
+}
+
 control {
execute( TC_attach() );
execute( TC_attach_mnc3() );
@@ -2870,6 +2902,9 @@
execute( TC_llc_null() );
execute( TC_llc_sabm_dm_llgmm() );
execute( TC_llc_sabm_dm_ll5() );
+
+   /* At the end, may crash osmo-sgsn, see OS#3957, OS#4245 */
+   execute( TC_attach_req_id_req_ra_update() );
 }


diff --git a/sgsn/expected-results.xml b/sgsn/expected-results.xml
index fc8856a..8381064 100644
--- a/sgsn/expected-results.xml
+++ b/sgsn/expected-results.xml
@@ -62,4 +62,5 @@
   
   
   
+  
 

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16016
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id5554a91a8bda712e282c5a3e9e30fb0ca1ec0e8
Gerrit-Change-Number: 16016
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-sgsn[master]: gmm: Fix assertion hit during RA UPD REQ before completting gmm attach

2019-11-08 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/16015 )


Change subject: gmm: Fix assertion hit during RA UPD REQ before completting gmm 
attach
..

gmm: Fix assertion hit during RA UPD REQ before completting gmm attach

Output:
20191107021548500 DMM <0002> gprs_gb.c:40 
MM_STATE_Gb(2596296189)[0x612084a0]{Idle}: Received Event E_MM_PDU_RECEPTION
20191107021548500 DMM <0002> gprs_gmm.c:1531 MM(/d4b6d7af) -> GMM RA UPDATE 
REQUEST type="RA updating"
20191107021548501 DMM <0002> gprs_gmm.c:1615 MM(/d4b6d7af) The MM context 
cannot be used, RA: 901-70-2758-208
Assert failed mmctx->gb.llme == NULL gprs_gmm.c:1620

Scenario reproducing the crash can be triggered with TTCN3
SGSN_Tests.TC_attach_req_id_req_ra_update.

Basically, SGSN first receives an ATTACH REQ with a given RA ID, then
SGSN switches to state CommonProcedureInitiated and sends GMM ID REQ,
and MS/PCU answers immediatelly with a RA Update instead with a new RA
ID.

Related: OS#3957, OS#4245
Change-Id: I64fa5cf1b427d3abb99e553e584897261a827ce6
---
M src/sgsn/gprs_gmm.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/15/16015/1

diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c
index b6b1685..17daa7d 100644
--- a/src/sgsn/gprs_gmm.c
+++ b/src/sgsn/gprs_gmm.c
@@ -1615,9 +1615,9 @@
osmo_rai_name(>ra));
/* mmctx is set to NULL and gprs_llgmm_unassign(llme) will be
   called below, let's make sure we don't keep dangling llme
-  pointers in mmctx (OS#3957). */
+  pointers in mmctx (OS#3957, OS#4245). */
if (mmctx->ran_type == MM_CTX_T_GERAN_Gb)
-   OSMO_ASSERT(mmctx->gb.llme == NULL);
+   mmctx->gb.llme = NULL;
mmctx = NULL;
}


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/16015
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I64fa5cf1b427d3abb99e553e584897261a827ce6
Gerrit-Change-Number: 16015
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-pcu[master]: gprs_bssgp_destroy(): fix NULL-pointer dereference

2019-11-08 Thread fixeria

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/15281 )

Change subject: gprs_bssgp_destroy(): fix NULL-pointer dereference
..


Patch Set 3:

This change is ready for review.


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15281
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I42cb911a679b9198fd06e74b42f1e2cb28323de9
Gerrit-Change-Number: 15281
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 18:10:46 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Build failure of network:osmocom:latest/limesuite in Raspbian_10/armv7l

2019-11-08 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/limesuite/Raspbian_10/armv7l

Package network:osmocom:latest/limesuite failed to build in Raspbian_10/armv7l

Check out the package for editing:
  osc checkout network:osmocom:latest limesuite

Last lines of build log:
[  567s] [ 85%] Building CXX object 
src/CMakeFiles/LimeSuiteGUI.dir/boards_wxgui/pnlLimeSDR.cpp.o
[  567s] cd /usr/src/packages/BUILD/obj-arm-linux-gnueabihf/src && /usr/bin/c++ 
 -DLIME_DLL -DWXUSINGDLL -D_FILE_OFFSET_BITS=64 -D__WXGTK__ 
-I/usr/src/packages/BUILD/src/lms7002_wxgui 
-I/usr/src/packages/BUILD/src/LMS_Programing 
-I/usr/src/packages/BUILD/src/utilities_gui 
-I/usr/src/packages/BUILD/src/RFSpark 
-I/usr/src/packages/BUILD/src/FPGAcontrols_wxgui 
-I/usr/src/packages/BUILD/src/numericSlider 
-I/usr/src/packages/BUILD/src/myriad7 
-I/usr/src/packages/BUILD/src/fftviewer_wxgui 
-I/usr/src/packages/BUILD/src/lms7suiteEvents 
-I/usr/src/packages/BUILD/src/boards_wxgui -I/usr/src/packages/BUILD/src 
-I/usr/src/packages/BUILD/src/API -I/usr/src/packages/BUILD/src/lime 
-I/usr/src/packages/BUILD/src/GFIR -I/usr/src/packages/BUILD/src/protocols 
-I/usr/src/packages/BUILD/src/ConnectionRegistry 
-I/usr/src/packages/BUILD/src/lms7002m_mcu 
-I/usr/src/packages/BUILD/src/ADF4002 -I/usr/src/packages/BUILD/src/Si5351C 
-I/usr/src/packages/BUILD/src/lms7002m -I/usr/src/packages/BUILD/src/LTEpackets 
-I/usr/src/packages/BUILD/src/FPGA_common 
-I/usr/src/packages/BUILD/external/cpp-feather-ini-parser 
-I/usr/src/packages/BUILD/src/HPM7 -I/usr/src/packages/BUILD/external/kissFFT 
-I/usr/include/libusb-1.0 -I/usr/src/packages/BUILD/src/oglGraph -isystem 
/usr/lib/arm-linux-gnueabihf/wx/include/gtk2-unicode-3.0 -isystem 
/usr/include/wx-3.0  -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time 
-D_FORTIFY_SOURCE=2 -fvisibility-inlines-hidden -pthread -O3 -DNDEBUG   
-march=native -fvisibility=hidden -std=gnu++11 -o 
CMakeFiles/LimeSuiteGUI.dir/boards_wxgui/pnlLimeSDR.cpp.o -c 
/usr/src/packages/BUILD/src/boards_wxgui/pnlLimeSDR.cpp
[  567s] [ 86%] Building CXX object 
src/CMakeFiles/LimeSuiteGUI.dir/boards_wxgui/pnlGPIO.cpp.o
[  567s] cd /usr/src/packages/BUILD/obj-arm-linux-gnueabihf/src && /usr/bin/c++ 
 -DLIME_DLL -DWXUSINGDLL -D_FILE_OFFSET_BITS=64 -D__WXGTK__ 
-I/usr/src/packages/BUILD/src/lms7002_wxgui 
-I/usr/src/packages/BUILD/src/LMS_Programing 
-I/usr/src/packages/BUILD/src/utilities_gui 
-I/usr/src/packages/BUILD/src/RFSpark 
-I/usr/src/packages/BUILD/src/FPGAcontrols_wxgui 
-I/usr/src/packages/BUILD/src/numericSlider 
-I/usr/src/packages/BUILD/src/myriad7 
-I/usr/src/packages/BUILD/src/fftviewer_wxgui 
-I/usr/src/packages/BUILD/src/lms7suiteEvents 
-I/usr/src/packages/BUILD/src/boards_wxgui -I/usr/src/packages/BUILD/src 
-I/usr/src/packages/BUILD/src/API -I/usr/src/packages/BUILD/src/lime 
-I/usr/src/packages/BUILD/src/GFIR -I/usr/src/packages/BUILD/src/protocols 
-I/usr/src/packages/BUILD/src/ConnectionRegistry 
-I/usr/src/packages/BUILD/src/lms7002m_mcu 
-I/usr/src/packages/BUILD/src/ADF4002 -I/usr/src/packages/BUILD/src/Si5351C 
-I/usr/src/packages/BUILD/src/lms7002m -I/usr/src/packages/BUILD/src/LTEpackets 
-I/usr/src/packages/BUILD/src/FPGA_common 
-I/usr/src/packages/BUILD/external/cpp-feather-ini-parser 
-I/usr/src/packages/BUILD/src/HPM7 -I/usr/src/packages/BUILD/external/kissFFT 
-I/usr/include/libusb-1.0 -I/usr/src/packages/BUILD/src/oglGraph -isystem 
/usr/lib/arm-linux-gnueabihf/wx/include/gtk2-unicode-3.0 -isystem 
/usr/include/wx-3.0  -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time 
-D_FORTIFY_SOURCE=2 -fvisibility-inlines-hidden -pthread -O3 -DNDEBUG   
-march=native -fvisibility=hidden -std=gnu++11 -o 
CMakeFiles/LimeSuiteGUI.dir/boards_wxgui/pnlGPIO.cpp.o -c 
/usr/src/packages/BUILD/src/boards_wxgui/pnlGPIO.cpp
[  579s] [ 87%] Linking CXX executable ../bin/LimeSuiteGUI
[  579s] cd /usr/src/packages/BUILD/obj-arm-linux-gnueabihf/src && 
/usr/bin/cmake -E cmake_link_script CMakeFiles/LimeSuiteGUI.dir/link.txt 
--verbose=1
[  579s] /usr/bin/c++  -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time 
-D_FORTIFY_SOURCE=2 -fvisibility-inlines-hidden -pthread -O3 -DNDEBUG  
-Wl,-z,relro -rdynamic CMakeFiles/LimeSuiteGUI.dir/ADF4002/ADF4002_wxgui.cpp.o 
CMakeFiles/LimeSuiteGUI.dir/lms7002_wxgui/lms7002_pnlXBUF_view.cpp.o 
CMakeFiles/LimeSuiteGUI.dir/lms7002_wxgui/lms7002_wxgui.cpp.o 
CMakeFiles/LimeSuiteGUI.dir/lms7002_wxgui/lms7002_pnlRFE_view.cpp.o 
CMakeFiles/LimeSuiteGUI.dir/lms7002_wxgui/lms7002_pnlCalibrations_view.cpp.o 
CMakeFiles/LimeSuiteGUI.dir/lms7002_wxgui/lms7002_pnlTRF_view.cpp.o 
CMakeFiles/LimeSuiteGUI.dir/lms7002_wxgui/lms7002_pnlCDS_view.cpp.o 
CMakeFiles/LimeSuiteGUI.dir/lms7002_wxgui/lms7002_pnlLimeLightPAD_view.cpp.o

Change in docker-playground[master]: ttcn3-stp/Makefile: Set branch to laforge/stp only if envvar not set

2019-11-08 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/15998 )

Change subject: ttcn3-stp/Makefile: Set branch to laforge/stp only if envvar 
not set
..

ttcn3-stp/Makefile: Set branch to laforge/stp only if envvar not set

Change-Id: I1f4061f2b1d62e6a42af4629ce462269cfaf317f
---
M ttcn3-stp-test/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved; Verified



diff --git a/ttcn3-stp-test/Makefile b/ttcn3-stp-test/Makefile
index 76fdbfc..4bf2fff 100644
--- a/ttcn3-stp-test/Makefile
+++ b/ttcn3-stp-test/Makefile
@@ -1,4 +1,4 @@
 RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran 
--ip 172.18.2.202 -v ggsn-test-vol:/data
-OSMO_TTCN3_BRANCH="laforge/stp"
+OSMO_TTCN3_BRANCH?="laforge/stp"

 include ../make/Makefile

--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/15998
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I1f4061f2b1d62e6a42af4629ce462269cfaf317f
Gerrit-Change-Number: 15998
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in docker-playground[master]: ttcn3-stp: Update osmo-stp.cfg to match new TTCN3 tests expectancies

2019-11-08 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/15999 )

Change subject: ttcn3-stp: Update osmo-stp.cfg to match new TTCN3 tests 
expectancies
..

ttcn3-stp: Update osmo-stp.cfg to match new TTCN3 tests expectancies

Change-Id: If3b3b7f1c05bcd2b0ea2b1ef6f432eb5f0013026
---
M ttcn3-stp-test/osmo-stp.cfg
1 file changed, 66 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved; Verified



diff --git a/ttcn3-stp-test/osmo-stp.cfg b/ttcn3-stp-test/osmo-stp.cfg
index d50e7c2..a9e377f 100644
--- a/ttcn3-stp-test/osmo-stp.cfg
+++ b/ttcn3-stp-test/osmo-stp.cfg
@@ -47,6 +47,9 @@
 !
 cs7 instance 0
  point-code format 24
+!
+!M3UA AS/ASP:
+!
  asp asp-sender  2905 m3ua
   local-ip 172.18.19.200
   remote-ip 172.18.19.203
@@ -56,6 +59,11 @@
  asp asp-receiver1 10001 2905 m3ua
   local-ip 172.18.19.200
   remote-ip 172.18.19.203
+ asp asp-client0 10002 2906 m3ua
+  local-ip 172.18.19.200
+  remote-ip 172.18.19.203
+  sctp-role client
+  role asp
  as as-sender m3ua
   asp asp-sender
   routing-key 1023 23
@@ -63,12 +71,69 @@
   asp asp-receiver0
   asp asp-receiver1
   routing-key 1042 42
- as mahlzeit ipa
+ as as-client m3ua
+  routing-key 1055 55
+  asp asp-client0
+!
+! IPA AS/ASP:
+!
+ asp ipa-asp-loadshare-sender 2 5000 ipa
+  local-ip 172.18.19.200
+  remote-ip 172.18.19.203
+! LOADSHARE:
+ as ipa-as-loadshare-sender ipa
+  routing-key 0 6
+  point-code override dpc 31
+  asp ipa-asp-loadshare-sender
+ asp ipa-asp-loadshare-receiver0 20001 5000 ipa
+  local-ip 172.18.19.200
+  remote-ip 172.18.19.203
+ asp ipa-asp-loadshare-receiver1 20002 5000 ipa
+  local-ip 172.18.19.200
+  remote-ip 172.18.19.203
+ as ipa-as-loadshare-receiver ipa
+  traffic-mode loadshare
+  routing-key 0 7
+  point-code override dpc 32
+  asp ipa-asp-loadshare-receiver0
+  asp ipa-asp-loadshare-receiver1
+! OVERRIDE:
+ asp ipa-asp-override-sender 20004 5000 ipa
+  local-ip 172.18.19.200
+  remote-ip 172.18.19.203
+ as ipa-as-override-sender ipa
+  routing-key 0 6
+  point-code override dpc 33
+  asp ipa-asp-override-sender
+ asp ipa-asp-override-receiver0 20005 5000 ipa
+  local-ip 172.18.19.200
+  remote-ip 172.18.19.203
+ asp ipa-asp-override-receiver1 20006 5000 ipa
+  local-ip 172.18.19.200
+  remote-ip 172.18.19.203
+ as ipa-as-override-receiver ipa
+  traffic-mode override
+  routing-key 0 8
+  point-code override dpc 34
+  asp ipa-asp-override-receiver0
+  asp ipa-asp-override-receiver1
+! DYNAMIC AS:
+ as ipa-as-dynamic-asp ipa
   routing-key 0 5
   point-code override dpc 23
+!
+! ROUTING TABLE:
+!
  route-table system
   update route 23 16777215 linkset as-sender
   update route 42 16777215 linkset as-receiver
+  update route 55 16777215 linkset as-client
+  update route 31 16777215 linkset ipa-as-loadshare-receiver
+  update route 33 16777215 linkset ipa-as-override-receiver
+  update route 5  16777215 linkset ipa-as-dynamic-asp
+!
+!SERVERS:
+!
  listen m3ua 2905
   accept-asp-connections dynamic-permitted
  listen ipa 5000

--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/15999
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: If3b3b7f1c05bcd2b0ea2b1ef6f432eb5f0013026
Gerrit-Change-Number: 15999
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in docker-playground[master]: ttcn3-stp/Makefile: Set branch to laforge/stp only if envvar not set

2019-11-08 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/15998 )

Change subject: ttcn3-stp/Makefile: Set branch to laforge/stp only if envvar 
not set
..


Patch Set 1: Verified+1 Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/15998
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I1f4061f2b1d62e6a42af4629ce462269cfaf317f
Gerrit-Change-Number: 15998
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Fri, 08 Nov 2019 17:33:40 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in docker-playground[master]: ttcn3-stp: Update osmo-stp.cfg to match new TTCN3 tests expectancies

2019-11-08 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/15999 )

Change subject: ttcn3-stp: Update osmo-stp.cfg to match new TTCN3 tests 
expectancies
..


Patch Set 4: Verified+1 Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/15999
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: If3b3b7f1c05bcd2b0ea2b1ef6f432eb5f0013026
Gerrit-Change-Number: 15999
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 17:33:27 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-abis[master]: ipa: Allow setting local addr and port for struct ipa_client_conn

2019-11-08 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/16014 )

Change subject: ipa: Allow setting local addr and port for struct 
ipa_client_conn
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/16014
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I3133c6b01647506a5b9c67e4699bcad3ff59f843
Gerrit-Change-Number: 16014
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Fri, 08 Nov 2019 17:33:03 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-abis[master]: ipa: Allow setting local addr and port for struct ipa_client_conn

2019-11-08 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/16014 )


Change subject: ipa: Allow setting local addr and port for struct 
ipa_client_conn
..

ipa: Allow setting local addr and port for struct ipa_client_conn

Change-Id: I3133c6b01647506a5b9c67e4699bcad3ff59f843
---
M TODO-RELEASE
M include/osmocom/abis/ipa.h
M src/input/ipa.c
M src/input/ipaccess.c
M src/ipa_proxy.c
5 files changed, 41 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/14/16014/1

diff --git a/TODO-RELEASE b/TODO-RELEASE
index d0852fc..4fe42c6 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -7,3 +7,5 @@
 # If any interfaces have been added since the last public release: c:r:a + 1.
 # If any interfaces have been removed or changed since the last public 
release: c:r:0.
 #library   whatdescription / commit summary line
+libosmo-abis   struct ipa_client_conn  Fields added at the end (no ABI 
break because instance is created through API func)
+libosmo-abis   ipa_client_conn_create2()   New API added
diff --git a/include/osmocom/abis/ipa.h b/include/osmocom/abis/ipa.h
index ff00697..4764a95 100644
--- a/include/osmocom/abis/ipa.h
+++ b/include/osmocom/abis/ipa.h
@@ -78,6 +78,8 @@
int (*write_cb)(struct ipa_client_conn *link);
void*data;
struct msgb *pending_msg;
+   const char  *local_addr;
+   uint16_tlocal_port;
 };

 struct ipa_client_conn *
@@ -86,7 +88,16 @@
void (*updown)(struct ipa_client_conn *link, int),
int (*read_cb)(struct ipa_client_conn *link, struct 
msgb *msgb),
int (*write_cb)(struct ipa_client_conn *link),
-   void *data);
+   void *data) OSMO_DEPRECATED("Use 
ipa_client_conn_create2() instead");
+struct ipa_client_conn *
+ipa_client_conn_create2(void *ctx, struct e1inp_ts *ts,
+  int priv_nr, const char *loc_addr, uint16_t loc_port,
+  const char *rem_addr, uint16_t rem_port,
+  void (*updown_cb)(struct ipa_client_conn *link, int up),
+  int (*read_cb)(struct ipa_client_conn *link,
+ struct msgb *msgb),
+  int (*write_cb)(struct ipa_client_conn *link),
+  void *data);
 void ipa_client_conn_destroy(struct ipa_client_conn *link);

 int ipa_client_conn_open(struct ipa_client_conn *link);
diff --git a/src/input/ipa.c b/src/input/ipa.c
index b4dbcb0..0f67dca 100644
--- a/src/input/ipa.c
+++ b/src/input/ipa.c
@@ -155,6 +155,20 @@
   int (*write_cb)(struct ipa_client_conn *link),
   void *data)
 {
+   return ipa_client_conn_create2(ctx, ts, priv_nr, NULL, 0, addr, port,
+  updown_cb, read_cb, write_cb, data);
+}
+
+struct ipa_client_conn *
+ipa_client_conn_create2(void *ctx, struct e1inp_ts *ts,
+  int priv_nr, const char *loc_addr, uint16_t loc_port,
+  const char *rem_addr, uint16_t rem_port,
+  void (*updown_cb)(struct ipa_client_conn *link, int up),
+  int (*read_cb)(struct ipa_client_conn *link,
+ struct msgb *msgb),
+  int (*write_cb)(struct ipa_client_conn *link),
+  void *data)
+{
struct ipa_client_conn *ipa_link;

ipa_link = talloc_zero(ctx, struct ipa_client_conn);
@@ -181,8 +195,10 @@
ipa_link->ofd->data = ipa_link;
ipa_link->ofd->fd = -1;
ipa_link->state = IPA_CLIENT_LINK_STATE_CONNECTING;
-   ipa_link->addr = talloc_strdup(ipa_link, addr);
-   ipa_link->port = port;
+   ipa_link->local_addr = talloc_strdup(ipa_link, loc_addr);
+   ipa_link->local_port = loc_port;
+   ipa_link->addr = talloc_strdup(ipa_link, rem_addr);
+   ipa_link->port = rem_port;
ipa_link->updown_cb = updown_cb;
ipa_link->read_cb = read_cb;
/* default to generic write callback if not set. */
@@ -209,9 +225,10 @@
int ret;

link->state = IPA_CLIENT_LINK_STATE_CONNECTING;
-   ret = osmo_sock_init(AF_INET, SOCK_STREAM, IPPROTO_TCP,
+   ret = osmo_sock_init2(AF_INET, SOCK_STREAM, IPPROTO_TCP,
+link->local_addr, link->local_port,
 link->addr, link->port,
-OSMO_SOCK_F_CONNECT|OSMO_SOCK_F_NONBLOCK);
+
OSMO_SOCK_F_BIND|OSMO_SOCK_F_CONNECT|OSMO_SOCK_F_NONBLOCK);
if (ret < 0)
return ret;
link->ofd->fd = ret;
diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index 474bfb4..0f8e2d5 100644
---

Change in osmo-sysmon[master]: Add oneshot mode that exits after one iteration

2019-11-08 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sysmon/+/16002 )

Change subject: Add oneshot mode that exits after one iteration
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/16002
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-Change-Id: Id920c4afee633b8da6919b7b318f9c868890a176
Gerrit-Change-Number: 16002
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 15:21:05 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-sysmon[master]: simple_ctrl: Don't cause an error if GET response is empty

2019-11-08 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-sysmon/+/16000 )

Change subject: simple_ctrl: Don't cause an error if GET response is empty
..

simple_ctrl: Don't cause an error if GET response is empty

Change-Id: I0be48c89595e71ac4dfa1b8ad1890296f2013476
Sponsored-by: On-Waves ehf.
---
M src/simple_ctrl.c
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/simple_ctrl.c b/src/simple_ctrl.c
index 883e92f..9407218 100644
--- a/src/simple_ctrl.c
+++ b/src/simple_ctrl.c
@@ -283,7 +283,11 @@
return NULL;

rc = sscanf(msgb_l2(resp), "GET_REPLY %u %ms %ms", _id, _var, 
_val);
-   if (rc == 3) {
+   if ((rc == 2) || (rc == 3)) {
+   /* If body is empty return an empty string */
+   if (rc == 2)
+   rx_val = strdup("");
+
if (rx_id == sch->next_id-1 && !strcmp(var, rx_var)) {
free(rx_var);
msgb_free(resp);

--
To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/16000
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-Change-Id: I0be48c89595e71ac4dfa1b8ad1890296f2013476
Gerrit-Change-Number: 16000
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-pcu[master]: BSSGP: properly print BVCI for signalling messages (BVCI=0)

2019-11-08 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16007 )

Change subject: BSSGP: properly print BVCI for signalling messages (BVCI=0)
..

BSSGP: properly print BVCI for signalling messages (BVCI=0)

Change-Id: I4ac0f48d2e62cd0545e8a1e1b26c9e43ef5e8dde
---
M src/gprs_bssgp_pcu.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index f99058a..dd9eb68 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -281,7 +281,7 @@
struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *) 
msgb_bssgph(msg);
enum bssgp_pdu_type pdu_type = (enum bssgp_pdu_type) bgph->pdu_type;
int rc = 0;
-   int bvci = bctx ? bctx->bvci : -1;
+   int bvci = bctx ? bctx->bvci : msgb_bvci(msg);
switch (pdu_type) {
case BSSGP_PDUT_STATUS:
/* already handled in libosmogb */

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16007
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I4ac0f48d2e62cd0545e8a1e1b26c9e43ef5e8dde
Gerrit-Change-Number: 16007
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-pcu[master]: GprsMs::update_cs_ul(): clarify the meaning of old_link_qual

2019-11-08 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16009 )

Change subject: GprsMs::update_cs_ul(): clarify the meaning of old_link_qual
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16009
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iad703a573621c64613b9b8c229079dc63fcaeb9e
Gerrit-Change-Number: 16009
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 15:19:30 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: tests/tbf: suspend warnings about the link quality measurements

2019-11-08 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16008 )

Change subject: tests/tbf: suspend warnings about the link quality measurements
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16008
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I1c82076df6cd0833d243e1e6afb140bae3bd2ec9
Gerrit-Change-Number: 16008
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 15:19:14 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: tests/tbf: suspend warnings about the link quality measurements

2019-11-08 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16008 )

Change subject: tests/tbf: suspend warnings about the link quality measurements
..

tests/tbf: suspend warnings about the link quality measurements

Share a single instance of 'pcu_l1_meas' between all unit tests,
set initial measurement values in main(). This way we can get
rid of the following warnings:

  Unable to update UL (M)CS CS-X because we don't have link quality 
measurements.

Change-Id: I1c82076df6cd0833d243e1e6afb140bae3bd2ec9
Fixes: OS#3828
---
M tests/tbf/TbfTest.cpp
M tests/tbf/TbfTest.err
2 files changed, 17 insertions(+), 34 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/tests/tbf/TbfTest.cpp b/tests/tbf/TbfTest.cpp
index bd4fbc1..bdbc138 100644
--- a/tests/tbf/TbfTest.cpp
+++ b/tests/tbf/TbfTest.cpp
@@ -50,6 +50,9 @@
 int16_t spoof_mnc = 0, spoof_mcc = 0;
 bool spoof_mnc_3_digits = false;

+/* Measurements shared by all unit tests */
+static struct pcu_l1_meas meas;
+
 static void check_tbf(gprs_rlcmac_tbf *tbf)
 {
OSMO_ASSERT(tbf);
@@ -575,7 +578,6 @@
gprs_rlcmac_ul_tbf *ul_tbf;
uint8_t trx_no = 0;
struct gprs_rlcmac_pdch *pdch;
-   struct pcu_l1_meas meas;

tfi = the_bts->tfi_find_free(GPRS_RLCMAC_UL_TBF, _no, -1);

@@ -610,9 +612,6 @@
uint8_t buf[64];
int num_bytes;
struct gprs_rlcmac_pdch *pdch;
-   struct pcu_l1_meas meas;
-
-   meas.set_rssi(31);

rlc_block = bitvec_alloc(23, tall_pcu_ctx);

@@ -657,11 +656,9 @@
struct gprs_rlcmac_pdch *pdch;
gprs_rlcmac_bts *bts;
RlcMacUplink_t ulreq = {0};
-   struct pcu_l1_meas meas;
struct gprs_rlc_ul_header_egprs_3 *egprs3  = NULL;
GprsCodingScheme cs;

-   meas.set_rssi(31);
bts = the_bts->bts_data();

/* needed to set last_rts_fn in the PDCH object */
@@ -808,11 +805,9 @@
struct gprs_rlcmac_pdch *pdch;
gprs_rlcmac_bts *bts;
RlcMacUplink_t ulreq = {0};
-   struct pcu_l1_meas meas;
struct gprs_rlc_ul_header_egprs_3 *egprs3  = NULL;
GprsCodingScheme cs;

-   meas.set_rssi(31);
bts = the_bts->bts_data();

/* needed to set last_rts_fn in the PDCH object */
@@ -1257,10 +1252,8 @@
gprs_rlcmac_ul_tbf *ul_tbf;
gprs_rlcmac_bts *bts;
RlcMacUplink_t ulreq = {0};
-   struct pcu_l1_meas meas;
GprsCodingScheme cs;
 
-   meas.set_rssi(31);
bts = the_bts->bts_data();

/* needed to set last_rts_fn in the PDCH object */
@@ -1326,7 +1319,6 @@
uint8_t trx_no = 0;
int tfi = 0;
struct gprs_rlcmac_pdch *pdch;
-   struct pcu_l1_meas meas;
GprsCodingScheme cs;


@@ -1409,7 +1401,6 @@
uint8_t trx_no = 0;
int tfi = 0;
struct gprs_rlcmac_pdch *pdch;
-   struct pcu_l1_meas meas;
GprsCodingScheme cs;

check_tbf(ul_tbf);
@@ -1492,7 +1483,6 @@
int tfi = 0;
gprs_rlcmac_ul_tbf *ul_tbf;
struct gprs_rlcmac_pdch *pdch;
-   struct pcu_l1_meas meas;
GprsCodingScheme cs;


@@ -1583,8 +1573,6 @@
struct gprs_rlcmac_pdch *pdch;
gprs_rlcmac_bts *bts;
RlcMacUplink_t ulreq = {0};
-   struct pcu_l1_meas meas;
-   meas.set_rssi(31);

bts = the_bts->bts_data();

@@ -2370,14 +2358,12 @@
struct gprs_rlcmac_pdch *pdch;
gprs_rlcmac_bts *bts;
RlcMacUplink_t ulreq = {0};
-   struct pcu_l1_meas meas;
struct gprs_rlc_ul_header_egprs_3 *egprs3  = NULL;
GprsCodingScheme cs;
Packet_Resource_Request_t *presreq = NULL;
MS_Radio_Access_capability_t *pmsradiocap = NULL;
Multislot_capability_t *pmultislotcap = NULL;

-   meas.set_rssi(31);
bts = the_bts->bts_data();

/* needed to set last_rts_fn in the PDCH object */
@@ -3298,6 +3284,10 @@
vty_init(_vty_info);
pcu_vty_init();

+   /* Initialize shared UL measurements */
+   meas.set_link_qual(12);
+   meas.set_rssi(31);
+
test_tbf_base();
test_tbf_tlli_update();
test_tbf_final_ack(TEST_MODE_STANDARD);
diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err
index 7dd14f4..6e638af 100644
--- a/tests/tbf/TbfTest.err
+++ b/tests/tbf/TbfTest.err
@@ -1470,7 +1470,7 @@
  - TRX=0 (0) TS=7 TA=7 TSC=0 TFI=0 USF=0
 Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184
 TBF(TFI=0 TLLI=0x DIR=UL STATE=FLOW) UL DATA TFI=0 received (V(Q)=0 .. 
V(R)=0)
-Unable to update UL (M)CS CS-1 because we don't have link quality measurements.
+MS (IMSI ): Link quality 12dB (12dB) left window [0, 0], modifying uplink CS 
level: CS-1 -> CS-2
 TBF(TFI=0 TLLI=0x DIR=UL STATE=FLOW) restarting timer T3169 [acked 
(data)] with 5 sec. 0

Change in osmo-pcu[master]: GprsMs::update_cs_ul(): clarify the meaning of old_link_qual

2019-11-08 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16009 )

Change subject: GprsMs::update_cs_ul(): clarify the meaning of old_link_qual
..

GprsMs::update_cs_ul(): clarify the meaning of old_link_qual

Change-Id: Iad703a573621c64613b9b8c229079dc63fcaeb9e
---
M src/gprs_ms.cpp
M tests/tbf/TbfTest.err
2 files changed, 15 insertions(+), 13 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/gprs_ms.cpp b/src/gprs_ms.cpp
index 5b35e65..8074cb4 100644
--- a/src/gprs_ms.cpp
+++ b/src/gprs_ms.cpp
@@ -648,8 +648,6 @@
return;
}

-   old_link_qual = meas->link_qual;
-
if (mcs_is_gprs(m_current_cs_ul)) {
if (current_cs >= MAX_GPRS_CS)
current_cs = MAX_GPRS_CS - 1;
@@ -667,8 +665,12 @@
return;
}

+   /* To avoid rapid changes of the coding scheme, we also take
+* the old link quality value into account (if present). */
if (m_l1_meas.have_link_qual)
old_link_qual = m_l1_meas.link_qual;
+   else
+   old_link_qual = meas->link_qual;

if (meas->link_qual < low &&  old_link_qual < low)
new_cs_ul.dec(mode());
@@ -679,7 +681,7 @@
if (m_current_cs_ul != new_cs_ul) {
LOGP(DRLCMACMEAS, LOGL_INFO,
"MS (IMSI %s): "
-   "Link quality %ddB (%ddB) left window [%d, %d], "
+   "Link quality %ddB (old %ddB) left window [%d, %d], "
"modifying uplink CS level: %s -> %s\n",
imsi(), meas->link_qual, old_link_qual,
low, high,
diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err
index 6e638af..8ec3e80 100644
--- a/tests/tbf/TbfTest.err
+++ b/tests/tbf/TbfTest.err
@@ -1470,7 +1470,7 @@
  - TRX=0 (0) TS=7 TA=7 TSC=0 TFI=0 USF=0
 Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184
 TBF(TFI=0 TLLI=0x DIR=UL STATE=FLOW) UL DATA TFI=0 received (V(Q)=0 .. 
V(R)=0)
-MS (IMSI ): Link quality 12dB (12dB) left window [0, 0], modifying uplink CS 
level: CS-1 -> CS-2
+MS (IMSI ): Link quality 12dB (old 12dB) left window [0, 0], modifying uplink 
CS level: CS-1 -> CS-2
 TBF(TFI=0 TLLI=0x DIR=UL STATE=FLOW) restarting timer T3169 [acked 
(data)] with 5 sec. 0 microsec, cur_fn=0
 TBF(TFI=0 TLLI=0x DIR=UL STATE=FLOW) Got CS-1 RLC data block: CV=0, 
BSN=0, SPB=0, PI=0, E=1, TI=1, bitoffs=24
 TBF(TFI=0 TLLI=0x DIR=UL STATE=FLOW) BSN 0 storing in window (0..63)
@@ -1827,7 +1827,7 @@
 Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7
 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) change control TS 7 -> 7 until 
assinment is complete.
 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) changes UL ASS state from 
GPRS_RLCMAC_UL_ASS_NONE to GPRS_RLCMAC_UL_ASS_SEND_ASS
-MS (IMSI ): Link quality 12dB (12dB) left window [0, 0], modifying uplink CS 
level: CS-1 -> CS-2
+MS (IMSI ): Link quality 12dB (old 12dB) left window [0, 0], modifying uplink 
CS level: CS-1 -> CS-2
 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) start Packet Uplink Assignment 
(PACCH)
 + TX : Packet Uplink Assignment 
+
 - TX : Packet Uplink Assignment 
-
@@ -1842,7 +1842,7 @@
 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) changes state from ASSIGN to 
FLOW
 Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184
 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) UL DATA TFI=0 received (V(Q)=0 .. 
V(R)=0)
-MS (IMSI ): Link quality 12dB (12dB) left window [0, 0], modifying uplink CS 
level: CS-2 -> CS-3
+MS (IMSI ): Link quality 12dB (old 12dB) left window [0, 0], modifying uplink 
CS level: CS-2 -> CS-3
 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) restarting timer T3169 [acked 
(data)] with 5 sec. 0 microsec, cur_fn=0
 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) Got CS-1 RLC data block: CV=15, 
BSN=0, SPB=0, PI=0, E=1, TI=0, bitoffs=24
 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) BSN 0 storing in window (0..63)
@@ -1920,7 +1920,7 @@
 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) starting timer T3169 
[allocation (UL-TBF)] with 5 sec. 0 microsec, cur_fn=0
 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) change control TS 7 -> 7 until 
assinment is complete.
 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) changes UL ASS state from 
GPRS_RLCMAC_UL_ASS_NONE to GPRS_RLCMAC_UL_ASS_SEND_ASS
-MS (IMSI 0011223344): Link quality 12dB (12dB) left window [0, 0], modifying 
uplink CS level: CS-3 -> CS-4
+MS (IMSI 0011223344): Link quality 12dB (old 12dB) left window [0, 0], 
modifying uplink CS level: CS-3 -> CS-4
 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) start Packet Uplink Assignment 
(PACCH)
 + TX :

Change in osmo-pcu[master]: BSSGP: do not reject SUSPEND ACK / NACK messages

2019-11-08 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16006 )

Change subject: BSSGP: do not reject SUSPEND ACK / NACK messages
..

BSSGP: do not reject SUSPEND ACK / NACK messages

Both BSSGP SUSPEND ACK and NACK messages use BVCI=0 (signaling),
which always exists. Claiming that BVCI=0 is unknown is wrong.

Instead of adding both BSSGP_PDUT_SUSPEND_{ACK,NACK} to the 'if'
statement, let's rather avoid rejection for all BVCI=0 messages,
as there may be other unlisted message types.

Change-Id: I780657c1e8f67e0bef0e92a31db7ba61b57d7ec4
Related: OS#4111
---
M src/gprs_bssgp_pcu.cpp
1 file changed, 1 insertion(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index abcb106..f99058a 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -407,10 +407,7 @@
/* look-up or create the BTS context for this BVC */
bctx = btsctx_by_bvci_nsei(ns_bvci, msgb_nsei(msg));

-   if (!bctx
-&& pdu_type != BSSGP_PDUT_BVC_RESET_ACK
-&& pdu_type != BSSGP_PDUT_BVC_UNBLOCK_ACK
-&& pdu_type != BSSGP_PDUT_PAGING_PS)
+   if (!bctx && ns_bvci != BVCI_SIGNALLING)
{
LOGP(DBSSGP, LOGL_NOTICE, "NSEI=%u/BVCI=%u Rejecting PDU type 
%s for unknown BVCI\n",
 nsei, ns_bvci, bssgp_pdu_str(pdu_type));

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16006
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I780657c1e8f67e0bef0e92a31db7ba61b57d7ec4
Gerrit-Change-Number: 16006
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-sysmon[master]: simple_ctrl: Don't cause an error if GET response is empty

2019-11-08 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sysmon/+/16000 )

Change subject: simple_ctrl: Don't cause an error if GET response is empty
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/16000
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-Change-Id: I0be48c89595e71ac4dfa1b8ad1890296f2013476
Gerrit-Change-Number: 16000
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 15:19:52 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: BSSGP: properly print BVCI for signalling messages (BVCI=0)

2019-11-08 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16007 )

Change subject: BSSGP: properly print BVCI for signalling messages (BVCI=0)
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16007
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I4ac0f48d2e62cd0545e8a1e1b26c9e43ef5e8dde
Gerrit-Change-Number: 16007
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 15:18:49 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: BSSGP: do not reject SUSPEND ACK / NACK messages

2019-11-08 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16006 )

Change subject: BSSGP: do not reject SUSPEND ACK / NACK messages
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16006
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I780657c1e8f67e0bef0e92a31db7ba61b57d7ec4
Gerrit-Change-Number: 16006
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 15:18:40 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-sccp[master]: xua: ipa_asp_fsm: Allow receiving IPA ID ACK before IPA ID RESP

2019-11-08 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16005 )

Change subject: xua: ipa_asp_fsm: Allow receiving IPA ID ACK before IPA ID RESP
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16005
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I99f5346a3854ca07979020245897334197f3cd3b
Gerrit-Change-Number: 16005
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Fri, 08 Nov 2019 15:17:04 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-sccp[master]: ss7: Set correct local addr and port during dynamic ASP creation

2019-11-08 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16013 )

Change subject: ss7: Set correct local addr and port during dynamic ASP creation
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16013
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I54aada351d5fb74f5015fdfe691d0b237354743c
Gerrit-Change-Number: 16013
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Fri, 08 Nov 2019 15:18:01 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-sccp[master]: ss7: Improve log formatting during ASP restart

2019-11-08 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16012 )

Change subject: ss7: Improve log formatting during ASP restart
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16012
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I42feaa16790f02b98bcda65281de8cd9295ddcb6
Gerrit-Change-Number: 16012
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Fri, 08 Nov 2019 15:17:30 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-sccp[master]: xua: ipa_asp_fsm: Allow moving ASP to inactive state

2019-11-08 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16004 )

Change subject: xua: ipa_asp_fsm: Allow moving ASP to inactive state
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16004
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I4ff246b2f899aaa3cf63bbdb3f3d317dc89b3d15
Gerrit-Change-Number: 16004
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Fri, 08 Nov 2019 15:16:40 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-sccp[master]: xua: Don't send NOTIFY messages to IPA ASPs

2019-11-08 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16003 )

Change subject: xua: Don't send NOTIFY messages to IPA ASPs
..

xua: Don't send NOTIFY messages to IPA ASPs

Change-Id: Ice3d948e4d2f57a8f52cfb93792d5f4d23284b96
---
M src/xua_as_fsm.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c
index c25902e..394061b 100644
--- a/src/xua_as_fsm.c
+++ b/src/xua_as_fsm.c
@@ -233,8 +233,10 @@
if (asp_cmp == asp)
continue;

-   msg = encode_notify();
-   osmo_ss7_asp_send(asp, msg);
+   if (asp->cfg.proto != OSMO_SS7_ASP_PROT_IPA) {
+   msg = encode_notify();
+   osmo_ss7_asp_send(asp, msg);
+   }

osmo_fsm_inst_state_chg(asp->fi, XUA_ASP_S_INACTIVE, 0, 0);
}

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16003
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ice3d948e4d2f57a8f52cfb93792d5f4d23284b96
Gerrit-Change-Number: 16003
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in libosmo-sccp[master]: xua: Don't send NOTIFY messages to IPA ASPs

2019-11-08 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16003 )

Change subject: xua: Don't send NOTIFY messages to IPA ASPs
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16003
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ice3d948e4d2f57a8f52cfb93792d5f4d23284b96
Gerrit-Change-Number: 16003
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Fri, 08 Nov 2019 15:15:59 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-sccp[master]: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY

2019-11-08 Thread pespin

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16011 )

Change subject: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY
..

ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY

Similar to what we do with local address. Should fix creating the stream
when no remote address is provided on an ASP configured through VTY.

Related: OS#4260
Change-Id: I33672e76a51a5d5a483906749d30e4c4e08b66ce
---
M src/osmo_ss7_vty.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  neels: Looks good to me, approved



diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index 35640df..1a246db 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -1775,6 +1775,11 @@
asp->cfg.local.host[0] = NULL;
asp->cfg.local.host_cnt = 1;
}
+   /* If no remote addr was set */
+   if (!asp->cfg.remote.host_cnt) {
+   asp->cfg.remote.host[0] = "127.0.0.1";
+   asp->cfg.remote.host_cnt = 1;
+   }
osmo_ss7_asp_restart(asp);
vty->node = L_CS7_NODE;
vty->index = asp->inst;

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16011
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I33672e76a51a5d5a483906749d30e4c4e08b66ce
Gerrit-Change-Number: 16011
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in libosmo-sccp[master]: ss7: Set correct local addr and port during dynamic ASP creation

2019-11-08 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16013 )


Change subject: ss7: Set correct local addr and port during dynamic ASP creation
..

ss7: Set correct local addr and port during dynamic ASP creation

Change-Id: I54aada351d5fb74f5015fdfe691d0b237354743c
---
M src/osmo_ss7.c
1 file changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/13/16013/1

diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index 4d5c349..0d49d1a 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1718,6 +1718,7 @@
struct osmo_xua_server *oxs = osmo_stream_srv_link_get_data(link);
struct osmo_stream_srv *srv;
struct osmo_ss7_asp *asp;
+   int i;
char *sock_name = osmo_sock_get_name(link, fd);
const char *proto_name = get_value_string(osmo_ss7_asp_protocol_vals, 
oxs->cfg.proto);

@@ -1764,8 +1765,10 @@
sock_name, asp->cfg.name);
asp->cfg.is_server = true;
asp->cfg.role = OSMO_SS7_ASP_ROLE_SG;
-   asp->cfg.local.host[0] = NULL;
-   asp->cfg.local.host_cnt = 1;
+   asp->cfg.local.port = oxs->cfg.local.port;
+   for (i = 0; i < oxs->cfg.local.host_cnt; i++)
+   asp->cfg.local.host[i] = 
talloc_strdup(asp, oxs->cfg.local.host[i]);
+   asp->cfg.local.host_cnt = 
oxs->cfg.local.host_cnt;
asp->cfg.remote.port = atoi(portbuf);
asp->cfg.remote.host[0] = talloc_strdup(asp, 
hostbuf);
asp->cfg.remote.host_cnt = 1;

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16013
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I54aada351d5fb74f5015fdfe691d0b237354743c
Gerrit-Change-Number: 16013
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in libosmo-sccp[master]: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY

2019-11-08 Thread neels

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16011 )

Change subject: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16011
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I33672e76a51a5d5a483906749d30e4c4e08b66ce
Gerrit-Change-Number: 16011
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Comment-Date: Fri, 08 Nov 2019 14:54:53 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-sccp[master]: ss7: Improve log formatting during ASP restart

2019-11-08 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16012 )


Change subject: ss7: Improve log formatting during ASP restart
..

ss7: Improve log formatting during ASP restart

Since it may act sometimes as a server and sometimes as a client, let's
better use one more neutral (2-side arrow) connector, and mark which
address is the local and which is the remote. We already use same
formatting in other osmocom code.

Change-Id: I42feaa16790f02b98bcda65281de8cd9295ddcb6
---
M src/osmo_ss7.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/12/16012/1

diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index 7ff3efe..4d5c349 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1292,8 +1292,8 @@
OSMO_ASSERT(ss7_initialized);
osmo_ss7_asp_peer_snprintf(bufloc, sizeof(bufloc), >cfg.local);
osmo_ss7_asp_peer_snprintf(bufrem, sizeof(bufrem), >cfg.remote);
-   LOGPASP(asp, DLSS7, LOGL_INFO, "Restarting ASP %s, %s ==> %s\n",
-  asp->cfg.name, bufloc, bufrem);
+   LOGPASP(asp, DLSS7, LOGL_INFO, "Restarting ASP %s, r=%s<->l=%s\n",
+  asp->cfg.name, bufrem, bufloc);

if (!asp->cfg.is_server) {
/* We are in client mode now */

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16012
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I42feaa16790f02b98bcda65281de8cd9295ddcb6
Gerrit-Change-Number: 16012
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in libosmo-sccp[master]: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY

2019-11-08 Thread fixeria

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16011 )

Change subject: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16011
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I33672e76a51a5d5a483906749d30e4c4e08b66ce
Gerrit-Change-Number: 16011
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Fri, 08 Nov 2019 14:20:15 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-sccp[master]: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY

2019-11-08 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16011 )


Change subject: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY
..

ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY

Similar to what we do with local address. Should fix creating the stream
when no remote address is provided on an ASP configured through VTY.

Related: OS#4260
Change-Id: I33672e76a51a5d5a483906749d30e4c4e08b66ce
---
M src/osmo_ss7_vty.c
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/11/16011/1

diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index 35640df..1a246db 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -1775,6 +1775,11 @@
asp->cfg.local.host[0] = NULL;
asp->cfg.local.host_cnt = 1;
}
+   /* If no remote addr was set */
+   if (!asp->cfg.remote.host_cnt) {
+   asp->cfg.remote.host[0] = "127.0.0.1";
+   asp->cfg.remote.host_cnt = 1;
+   }
osmo_ss7_asp_restart(asp);
vty->node = L_CS7_NODE;
vty->index = asp->inst;

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16011
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I33672e76a51a5d5a483906749d30e4c4e08b66ce
Gerrit-Change-Number: 16011
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-pcu[master]: tests/tbf: suspend warnings about the link quality measurements

2019-11-08 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16008 )

Change subject: tests/tbf: suspend warnings about the link quality measurements
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16008
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I1c82076df6cd0833d243e1e6afb140bae3bd2ec9
Gerrit-Change-Number: 16008
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 13:39:00 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: tests/tbf: suspend warnings about the link quality measurements

2019-11-08 Thread fixeria

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16008 )

Change subject: tests/tbf: suspend warnings about the link quality measurements
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/16008/1/tests/tbf/TbfTest.cpp
File tests/tbf/TbfTest.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/16008/1/tests/tbf/TbfTest.cpp@3288
PS1, Line 3288: meas.set_link_qual(12);
> This line looks non-related? I mean, it was not set before, or I don't see 
> any related comment in th […]
That's actually the fix for OS#3828, so of course it's related.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16008
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I1c82076df6cd0833d243e1e6afb140bae3bd2ec9
Gerrit-Change-Number: 16008
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 12:34:17 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: fix the expectations of TC_cs_lqual_ul_tbf

2019-11-08 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16010 )

Change subject: PCU_Tests_RAW.ttcn: fix the expectations of TC_cs_lqual_ul_tbf
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16010/1/pcu/PCU_Tests_RAW.ttcn
File pcu/PCU_Tests_RAW.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16010/1/pcu/PCU_Tests_RAW.ttcn@987
PS1, Line 987:   * is no need to check the both old and current link 
quality values. */
"check both the old"



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16010
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5d503d5a9c46cb9de84fbabd2d591afbe4216fdb
Gerrit-Change-Number: 16010
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 12:05:52 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: GprsMs::update_cs_ul(): clarify the meaning of old_link_qual

2019-11-08 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16009 )

Change subject: GprsMs::update_cs_ul(): clarify the meaning of old_link_qual
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16009
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iad703a573621c64613b9b8c229079dc63fcaeb9e
Gerrit-Change-Number: 16009
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 12:03:02 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: tests/tbf: suspend warnings about the link quality measurements

2019-11-08 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16008 )

Change subject: tests/tbf: suspend warnings about the link quality measurements
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/16008/1/tests/tbf/TbfTest.cpp
File tests/tbf/TbfTest.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/16008/1/tests/tbf/TbfTest.cpp@3288
PS1, Line 3288: meas.set_link_qual(12);
This line looks non-related? I mean, it was not set before, or I don't see any 
related comment in the commit message.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16008
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I1c82076df6cd0833d243e1e6afb140bae3bd2ec9
Gerrit-Change-Number: 16008
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 12:01:27 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-pcu[master]: BSSGP: properly print BVCI for signalling messages (BVCI=0)

2019-11-08 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16007 )

Change subject: BSSGP: properly print BVCI for signalling messages (BVCI=0)
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16007
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I4ac0f48d2e62cd0545e8a1e1b26c9e43ef5e8dde
Gerrit-Change-Number: 16007
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 11:59:02 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: BSSGP: do not reject SUSPEND ACK / NACK messages

2019-11-08 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/16006 )

Change subject: BSSGP: do not reject SUSPEND ACK / NACK messages
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16006
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I780657c1e8f67e0bef0e92a31db7ba61b57d7ec4
Gerrit-Change-Number: 16006
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Nov 2019 11:58:14 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

56 matches

Mail list logo