Build failure of network:osmocom:latest/libusrp in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libusrp/Debian_Testing/x86_64 Package network:osmocom:latest/libusrp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: [ 320s] touch libfx2.lib [ 320s] for obj in delay.rel fx2utils.rel i2c.rel isr.rel timer.rel usb_common.rel; do basename $obj .rel >> libfx2.lib ; done [ 320s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/lib' [ 320s] Making all in src [ 320s] make[4]: Entering directory '/usr/src/packages/BUILD/firmware/src' [ 320s] Making all in common [ 320s] make[5]: Entering directory '/usr/src/packages/BUILD/firmware/src/common' [ 320s] srcdir=. ./edit-gpif ./gpif.c usrp_gpif.c usrp_gpif_inline.h [ 320s] /usr/bin/env: 'python': No such file or directory [ 320s] make[5]: *** [Makefile:523: usrp_gpif.c] Error 127 [ 320s] make[5]: Leaving directory '/usr/src/packages/BUILD/firmware/src/common' [ 320s] make[4]: *** [Makefile:405: all-recursive] Error 1 [ 320s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/src' [ 320s] make[3]: *** [Makefile:405: all-recursive] Error 1 [ 320s] make[3]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 320s] make[2]: *** [Makefile:626: all-recursive] Error 1 [ 320s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 320s] make[1]: *** [Makefile:547: all] Error 2 [ 320s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 320s] dh_auto_build: error: make -j1 returned exit code 2 [ 320s] make: *** [debian/rules:13: build] Error 25 [ 320s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 320s] ### VM INTERACTION START ### [ 323s] [ 298.874708] sysrq: SysRq : Power Off [ 323s] [ 298.878165] reboot: Power down [ 323s] ### VM INTERACTION END ### [ 323s] [ 323s] cloud108 failed "build libusrp_3.4.4.dsc" at Mon Jun 8 04:35:17 UTC 2020. [ 323s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/libusrp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libusrp/Debian_Unstable/x86_64 Package network:osmocom:latest/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: [ 212s] touch libfx2.lib [ 212s] for obj in delay.rel fx2utils.rel i2c.rel isr.rel timer.rel usb_common.rel; do basename $obj .rel >> libfx2.lib ; done [ 212s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/lib' [ 212s] Making all in src [ 212s] make[4]: Entering directory '/usr/src/packages/BUILD/firmware/src' [ 212s] Making all in common [ 212s] make[5]: Entering directory '/usr/src/packages/BUILD/firmware/src/common' [ 212s] srcdir=. ./edit-gpif ./gpif.c usrp_gpif.c usrp_gpif_inline.h [ 212s] /usr/bin/env: 'python': No such file or directory [ 212s] make[5]: *** [Makefile:523: usrp_gpif.c] Error 127 [ 212s] make[5]: Leaving directory '/usr/src/packages/BUILD/firmware/src/common' [ 212s] make[4]: *** [Makefile:405: all-recursive] Error 1 [ 212s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/src' [ 212s] make[3]: *** [Makefile:405: all-recursive] Error 1 [ 212s] make[3]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 212s] make[2]: *** [Makefile:626: all-recursive] Error 1 [ 212s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 212s] make[1]: *** [Makefile:547: all] Error 2 [ 212s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 212s] dh_auto_build: error: make -j1 returned exit code 2 [ 212s] make: *** [debian/rules:13: build] Error 25 [ 212s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 212s] ### VM INTERACTION START ### [ 215s] [ 201.816946] sysrq: SysRq : Power Off [ 215s] [ 201.822882] reboot: Power down [ 215s] ### VM INTERACTION END ### [ 215s] [ 215s] lamb67 failed "build libusrp_3.4.4.dsc" at Mon Jun 8 04:33:55 UTC 2020. [ 215s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libusrp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 535s] touch libfx2.lib [ 535s] for obj in delay.rel fx2utils.rel i2c.rel isr.rel timer.rel usb_common.rel; do basename $obj .rel >> libfx2.lib ; done [ 535s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/lib' [ 535s] Making all in src [ 535s] make[4]: Entering directory '/usr/src/packages/BUILD/firmware/src' [ 535s] Making all in common [ 535s] make[5]: Entering directory '/usr/src/packages/BUILD/firmware/src/common' [ 535s] srcdir=. ./edit-gpif ./gpif.c usrp_gpif.c usrp_gpif_inline.h [ 535s] /usr/bin/env: 'python': No such file or directory [ 535s] make[5]: *** [Makefile:523: usrp_gpif.c] Error 127 [ 535s] make[5]: Leaving directory '/usr/src/packages/BUILD/firmware/src/common' [ 535s] make[4]: *** [Makefile:405: all-recursive] Error 1 [ 535s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/src' [ 535s] make[3]: *** [Makefile:405: all-recursive] Error 1 [ 535s] make[3]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 535s] make[2]: *** [Makefile:635: all-recursive] Error 1 [ 535s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 535s] make[1]: *** [Makefile:554: all] Error 2 [ 535s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 535s] dh_auto_build: error: make -j1 returned exit code 2 [ 535s] make: *** [debian/rules:13: build] Error 25 [ 535s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 535s] ### VM INTERACTION START ### [ 538s] [ 520.292229] sysrq: SysRq : Power Off [ 538s] [ 520.310922] reboot: Power down [ 538s] ### VM INTERACTION END ### [ 538s] [ 538s] lamb27 failed "build libusrp_3.4.4.7.50ce.dsc" at Mon Jun 8 03:09:18 UTC 2020. [ 538s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libusrp in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Testing/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 208s] touch libfx2.lib [ 208s] for obj in delay.rel fx2utils.rel i2c.rel isr.rel timer.rel usb_common.rel; do basename $obj .rel >> libfx2.lib ; done [ 208s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/lib' [ 208s] Making all in src [ 208s] make[4]: Entering directory '/usr/src/packages/BUILD/firmware/src' [ 208s] Making all in common [ 208s] make[5]: Entering directory '/usr/src/packages/BUILD/firmware/src/common' [ 208s] srcdir=. ./edit-gpif ./gpif.c usrp_gpif.c usrp_gpif_inline.h [ 208s] /usr/bin/env: 'python': No such file or directory [ 208s] make[5]: *** [Makefile:523: usrp_gpif.c] Error 127 [ 208s] make[5]: Leaving directory '/usr/src/packages/BUILD/firmware/src/common' [ 208s] make[4]: *** [Makefile:405: all-recursive] Error 1 [ 208s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/src' [ 208s] make[3]: *** [Makefile:405: all-recursive] Error 1 [ 208s] make[3]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 208s] make[2]: *** [Makefile:635: all-recursive] Error 1 [ 208s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 208s] make[1]: *** [Makefile:554: all] Error 2 [ 208s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 208s] dh_auto_build: error: make -j1 returned exit code 2 [ 208s] make: *** [debian/rules:13: build] Error 25 [ 208s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 208s] ### VM INTERACTION START ### [ 211s] [ 199.513918] sysrq: SysRq : Power Off [ 211s] [ 199.519649] reboot: Power down [ 211s] ### VM INTERACTION END ### [ 211s] [ 211s] lamb10 failed "build libusrp_3.4.4.7.50ce.dsc" at Mon Jun 8 03:03:20 UTC 2020. [ 211s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libusrp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 256s] touch libfx2.lib [ 256s] for obj in delay.rel fx2utils.rel i2c.rel isr.rel timer.rel usb_common.rel; do basename $obj .rel >> libfx2.lib ; done [ 256s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/lib' [ 256s] Making all in src [ 256s] make[4]: Entering directory '/usr/src/packages/BUILD/firmware/src' [ 256s] Making all in common [ 256s] make[5]: Entering directory '/usr/src/packages/BUILD/firmware/src/common' [ 256s] srcdir=. ./edit-gpif ./gpif.c usrp_gpif.c usrp_gpif_inline.h [ 256s] /usr/bin/env: 'python': No such file or directory [ 256s] make[5]: *** [Makefile:523: usrp_gpif.c] Error 127 [ 256s] make[5]: Leaving directory '/usr/src/packages/BUILD/firmware/src/common' [ 256s] make[4]: *** [Makefile:405: all-recursive] Error 1 [ 256s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/src' [ 256s] make[3]: *** [Makefile:405: all-recursive] Error 1 [ 256s] make[3]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 256s] make[2]: *** [Makefile:635: all-recursive] Error 1 [ 256s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 256s] make[1]: *** [Makefile:554: all] Error 2 [ 256s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 256s] dh_auto_build: error: make -j1 returned exit code 2 [ 256s] make: *** [debian/rules:13: build] Error 25 [ 256s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 256s] ### VM INTERACTION START ### [ 259s] [ 241.530855] sysrq: SysRq : Power Off [ 259s] [ 241.535049] reboot: Power down [ 259s] ### VM INTERACTION END ### [ 259s] [ 259s] lamb19 failed "build libusrp_3.4.4.7.50ce.dsc" at Mon Jun 8 01:40:36 UTC 2020. [ 259s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libusrp in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Testing/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 220s] touch libfx2.lib [ 220s] for obj in delay.rel fx2utils.rel i2c.rel isr.rel timer.rel usb_common.rel; do basename $obj .rel >> libfx2.lib ; done [ 220s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/lib' [ 220s] Making all in src [ 220s] make[4]: Entering directory '/usr/src/packages/BUILD/firmware/src' [ 220s] Making all in common [ 220s] make[5]: Entering directory '/usr/src/packages/BUILD/firmware/src/common' [ 220s] srcdir=. ./edit-gpif ./gpif.c usrp_gpif.c usrp_gpif_inline.h [ 220s] /usr/bin/env: 'python': No such file or directory [ 220s] make[5]: *** [Makefile:523: usrp_gpif.c] Error 127 [ 220s] make[5]: Leaving directory '/usr/src/packages/BUILD/firmware/src/common' [ 220s] make[4]: *** [Makefile:405: all-recursive] Error 1 [ 220s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/src' [ 220s] make[3]: *** [Makefile:405: all-recursive] Error 1 [ 220s] make[3]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 220s] make[2]: *** [Makefile:635: all-recursive] Error 1 [ 220s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 220s] make[1]: *** [Makefile:554: all] Error 2 [ 220s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 220s] dh_auto_build: error: make -j1 returned exit code 2 [ 220s] make: *** [debian/rules:13: build] Error 25 [ 220s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 220s] ### VM INTERACTION START ### [ 223s] [ 209.911389] sysrq: SysRq : Power Off [ 223s] [ 209.916868] reboot: Power down [ 223s] ### VM INTERACTION END ### [ 223s] [ 223s] lamb09 failed "build libusrp_3.4.4.7.50ce.dsc" at Mon Jun 8 01:40:05 UTC 2020. [ 223s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/open5gs in Debian_10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/i586 Package network:osmocom:nightly/open5gs failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: error=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -pthread '-DDEFAULT_CONFIG_FILENAME="/etc/open5gs/nrf.yaml"' -MD -MQ 'src/nrf/f570ec2@@open5gs-nrfd@exe/app.c.o' -MF 'src/nrf/f570ec2@@open5gs-nrfd@exe/app.c.o.d' -o 'src/nrf/f570ec2@@open5gs-nrfd@exe/app.c.o' -c ../src/nrf/app.c [ 261s] [1923/2112] cc -Isrc/nrf/f570ec2@@open5gs-nrfd@exe -Isrc/nrf -I../src/nrf -Isrc -I../src -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -pthread '-DDEFAULT_CONFIG_FILENAME="/etc/open5gs/nrf.yaml"' -MD -MQ 'src/nrf/f570ec2@@open5gs-nrfd@exe/.._main.c.o' -MF 'src/nrf/f570ec2@@open5gs-nrfd@exe/.._main.c.o.d' -o 'src/nrf/f570ec2@@open5gs-nrfd@exe/.._main.c.o' -c ../src/main.c [ 261s] [1924/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/timer.c.o' -MF 'src/udr/e340f29@@udr@sta/timer.c.o.d' -o 'src/udr/e340f29@@udr@sta/timer.c.o' -c ../src/udr/timer.c [ 261s] [1925/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn
Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.04/i586
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.04/i586
Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly open5gs
Last lines of build log:
[ 192s] [1936/2112] cc -Isrc/udm/udm@sta -Isrc/udm -I../src/udm -Ilib/app
-I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt
-Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi
-I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu
-fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra
-Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith
-Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn
-Werror=missing-prototypes -Werror=missing-declarations
-Werror=implicit-function-declaration -Werror=return-type
-Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes
-Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3
-Wwrite-strings -Werror=overflow -Werror=shift-count-overflow
-Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused
-Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare
-Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector
-fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections
-fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
-D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udm/udm@sta/nudm-handler.c.o'
-MF 'src/udm/udm@sta/nudm-handler.c.o.d' -o 'src/udm/udm@sta/nudm-handler.c.o'
-c ../src/udm/nudm-handler.c
[ 192s] [1937/2112] cc -Isrc/udm/udm@sta -Isrc/udm -I../src/udm -Ilib/app
-I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt
-Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi
-I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu
-fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra
-Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith
-Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn
-Werror=missing-prototypes -Werror=missing-declarations
-Werror=implicit-function-declaration -Werror=return-type
-Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes
-Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3
-Wwrite-strings -Werror=overflow -Werror=shift-count-overflow
-Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused
-Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare
-Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector
-fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections
-fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
-D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udm/udm@sta/context.c.o' -MF
'src/udm/udm@sta/context.c.o.d' -o 'src/udm/udm@sta/context.c.o' -c
../src/udm/context.c
[ 192s] FAILED: src/udm/udm@sta/context.c.o
[ 192s] cc -Isrc/udm/udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app
-Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi
-I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1
-I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes
-Werror=missing-declarations -Werror=implicit-function-declaration
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4
-ffunction-sections -fdata-sections -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ
'src/udm/udm@sta/context.c.o' -MF 'src/udm/udm@sta/context.c.o.d' -o
'src/udm/udm@sta/context.c.o' -c ../src/udm/context.c
[ 192s] ../src/udm/context.c: In function ‘udm_ue_add’:
[ 192s] ../src/udm/context.c:129:38: error: format ‘%ld’ expects argument of
type ‘long int’, but argument 2 has type ‘int’ [-Werror=format=]
[ 192s] udm_ue->ctx_id = ogs_msprintf("%ld", ogs_pool_index(_ue_pool,
udm_ue));
[ 192s] ~~^
[ 192s] %d
[ 192s] cc1: some warnings being treated as errors
[ 192s]
Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.10/i586 Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/src@udr@@udr@sta/context.c.o' -MF 'src/udr/src@udr@@udr@sta/context.c.o.d' -o 'src/udr/src@udr@@udr@sta/context.c.o' -c ../src/udr/context.c [ 177s] [1923/2112] cc -Isrc/udr/src@udr@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/src@udr@@udr@sta/timer.c.o' -MF 'src/udr/src@udr@@udr@sta/timer.c.o.d' -o 'src/udr/src@udr@@udr@sta/timer.c.o' -c ../src/udr/timer.c [ 177s] [1924/2112] cc -o src/pgw/open5gs-pgwd 'src/pgw/src@pgw@@open5gs-pgwd@exe/app-init.c.o' 'src/pgw/src@pgw@@open5gs-pgwd@exe/.._main.c.o' -Wl,--no-undefined -Wl,--as-needed -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -Wl,--start-group src/pgw/libpgw.a lib/ipfw/libogsipfw.so.1.2.5 lib/app/libogsapp.so.1.2.5 lib/core/libogscore.so.1.2.5 lib/diameter/gx/libogsdiameter-gx.so.1.2.5 lib/diameter/common/libogsdiameter-common.so.1.2.5 subprojects/freeDiameter/libfdcore/libfdcore.so.1.3.2 subprojects/freeDiameter/libfdproto/libfdproto.so.1.3.2 lib/gtp/libogsgtp.so.1.2.5 /usr/lib/i386-linux-gnu/libyaml.so -lidn -ldl -lsctp -lgcrypt -lgnutls -lidn -ldl -lsctp -lgcrypt -lgnutls -Wl,--end-group -pthread '-Wl,-rpath,$ORIGIN/../../lib/ipfw:$ORIGIN/../../lib/app:$ORIGIN/../../lib/core:$ORIGIN/../../lib/diameter/gx:$ORIGIN/../../lib/diameter/common:$ORIGIN/../../subprojects/freeDiameter/libfdcore:$ORIGIN/../../subprojects/freeDiameter/libfdproto:$ORIGIN/../../lib/gtp' -Wl,-rpath-link,/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/ipfw:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/app:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/core:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/diameter/gx:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/diameter/common:/usr/src/packages/BUILD/obj-i686-linux-gnu/subprojects/freeDiameter/libfdcore:/usr/src/packages/BUILD/obj-i686-linux-gnu/subprojects/freeDiameter/libfdproto:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/gtp [ 177s] [1925/2112] cc -Isrc/udm/src@udm@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels
Change in osmo-bsc[master]: use osmo_mobile_identity API everywhere
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18713 to look at the new patch set (#2). Change subject: use osmo_mobile_identity API everywhere .. use osmo_mobile_identity API everywhere Depends: Ic3f969e739654c1e8c387aedeeba5cce07fe2307 (libosmocore) Change-Id: I71c3b4c65dbfdfa51409e09d4868aea83225338a --- M include/osmocom/bsc/abis_rsl.h M include/osmocom/bsc/gsm_04_08_rr.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bsc_subscriber.c M src/osmo-bsc/gsm_04_08_rr.c M src/osmo-bsc/osmo_bsc_bssap.c M src/osmo-bsc/paging.c M src/osmo-bsc/pcu_sock.c 8 files changed, 66 insertions(+), 55 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/13/18713/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I71c3b4c65dbfdfa51409e09d4868aea83225338a Gerrit-Change-Number: 18713 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: refactor bsc_find_msc()'s round-robin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18505 ) Change subject: refactor bsc_find_msc()'s round-robin .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idf71f07ba5a17d5b870dc1a5a2875b6fedb61291 Gerrit-Change-Number: 18505 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Sun, 07 Jun 2020 21:06:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: lapd/lapdm: print user-defined string name instead of (dl=%p)
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/18002 )
Change subject: lapd/lapdm: print user-defined string name instead of (dl=%p)
..
Patch Set 8:
(3 comments)
https://gerrit.osmocom.org/c/libosmocore/+/18002/8/include/osmocom/gsm/lapd_core.h
File include/osmocom/gsm/lapd_core.h:
https://gerrit.osmocom.org/c/libosmocore/+/18002/8/include/osmocom/gsm/lapd_core.h@168
PS8, Line 168: OSMO_DEPRECATED("Use lapd_dl_init2() instaed");
typo: instead
https://gerrit.osmocom.org/c/libosmocore/+/18002/8/include/osmocom/gsm/lapdm.h
File include/osmocom/gsm/lapdm.h:
https://gerrit.osmocom.org/c/libosmocore/+/18002/8/include/osmocom/gsm/lapdm.h@89
PS8, Line 89: OSMO_DEPRECATED("Use lapdm_entity_init3() instead");
As a general comment, you don't need to deprecate stuff if it was added after
last release (not saying it's the case here). You are free to change APIs not
yet released.
https://gerrit.osmocom.org/c/libosmocore/+/18002/8/src/gsm/lapd_core.c
File src/gsm/lapd_core.c:
https://gerrit.osmocom.org/c/libosmocore/+/18002/8/src/gsm/lapd_core.c@307
PS8, Line 307: dl->name = talloc_strdup(tall_lapd_ctx, name);
see my previous comment, don't you need osmo_talloc_replace() (or however it's
called) here?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18002
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie6742843fff809edffcac24c4dce4edf66bc71be
Gerrit-Change-Number: 18002
Gerrit-PatchSet: 8
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Sun, 07 Jun 2020 21:05:03 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in pysim[master]: cards.py: added read_sst_raw and read_sst methods
gui...@gmail.com has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/17827 ) Change subject: cards.py: added read_sst_raw and read_sst methods .. Abandoned it was already added by other developer -- To view, visit https://gerrit.osmocom.org/c/pysim/+/17827 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4e85b3e6c25ede4ad4c3c46db83f8314864a036f Gerrit-Change-Number: 17827 Gerrit-PatchSet: 2 Gerrit-Owner: gui...@gmail.com Gerrit-Assignee: herlesupreeth Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: gui...@gmail.com Gerrit-CC: herlesupreeth Gerrit-MessageType: abandon
Change in osmo-sgsn[master]: use new osmo_mobile_identity API everywhere
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/18716 )
Change subject: use new osmo_mobile_identity API everywhere
..
use new osmo_mobile_identity API everywhere
Depends: Ic3f969e739654c1e8c387aedeeba5cce07fe2307 (libosmocore)
Change-Id: I4cacb10bac419633ca0c14f244f9903f7f517b49
---
M src/gbproxy/gb_proxy_patch.c
M src/gbproxy/gb_proxy_tlli.c
M src/gbproxy/gb_proxy_vty.c
M src/gprs/gprs_gb_parse.c
M src/sgsn/gprs_gmm.c
M tests/gbproxy/gbproxy_test.c
6 files changed, 135 insertions(+), 120 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/16/18716/1
diff --git a/src/gbproxy/gb_proxy_patch.c b/src/gbproxy/gb_proxy_patch.c
index 6235b04..2bc3b4b 100644
--- a/src/gbproxy/gb_proxy_patch.c
+++ b/src/gbproxy/gb_proxy_patch.c
@@ -436,28 +436,26 @@
int gbproxy_check_imsi(struct gbproxy_match *match,
const uint8_t *imsi, size_t imsi_len)
{
- char mi_buf[200];
int rc;
+ struct osmo_mobile_identity mi;
if (!match->enable)
return 1;
- rc = gprs_is_mi_imsi(imsi, imsi_len);
- if (rc > 0)
- rc = gsm48_mi_to_string(mi_buf, sizeof(mi_buf), imsi, imsi_len);
- if (rc <= 0) {
+ rc = osmo_mobile_identity_decode(, imsi, imsi_len, false);
+ if (rc || mi.type != GSM_MI_TYPE_IMSI) {
LOGP(DGPRS, LOGL_NOTICE, "Invalid IMSI %s\n",
osmo_hexdump(imsi, imsi_len));
return -1;
}
- LOGP(DGPRS, LOGL_DEBUG, "Checking IMSI '%s' (%d)\n", mi_buf, rc);
+ LOGP(DGPRS, LOGL_DEBUG, "Checking IMSI '%s' (%d)\n", mi.imsi, rc);
- rc = regexec(>re_comp, mi_buf, 0, NULL, 0);
+ rc = regexec(>re_comp, mi.imsi, 0, NULL, 0);
if (rc == REG_NOMATCH) {
LOGP(DGPRS, LOGL_INFO,
"IMSI '%s' doesn't match pattern '%s'\n",
- mi_buf, match->re_str);
+ mi.imsi, match->re_str);
return 0;
}
diff --git a/src/gbproxy/gb_proxy_tlli.c b/src/gbproxy/gb_proxy_tlli.c
index 4e21ede..e9271c2 100644
--- a/src/gbproxy/gb_proxy_tlli.c
+++ b/src/gbproxy/gb_proxy_tlli.c
@@ -401,14 +401,16 @@
peer, parse_ctx->imsi, parse_ctx->imsi_len);
if (other_link_info && other_link_info != link_info) {
- char mi_buf[200];
- mi_buf[0] = '\0';
- gsm48_mi_to_string(mi_buf, sizeof(mi_buf),
- parse_ctx->imsi, parse_ctx->imsi_len);
- LOGP(DGPRS, LOGL_INFO,
-"Removing TLLI %08x from list (IMSI %s re-used)\n",
-other_link_info->tlli.current, mi_buf);
- gbproxy_delete_link_info(peer, other_link_info);
+ struct osmo_mobile_identity mi;
+ if (osmo_mobile_identity_decode(, parse_ctx->imsi,
parse_ctx->imsi_len, false)
+ || mi.type != GSM_MI_TYPE_IMSI) {
+ LOGP(DGPRS, LOGL_ERROR, "Failed to decode Mobile
Identity\n");
+ } else {
+ LOGP(DGPRS, LOGL_INFO,
+"Removing TLLI %08x from list (IMSI %s re-used)\n",
+other_link_info->tlli.current, mi.imsi);
+ gbproxy_delete_link_info(peer, other_link_info);
+ }
}
/* Update the IMSI field */
diff --git a/src/gbproxy/gb_proxy_vty.c b/src/gbproxy/gb_proxy_vty.c
index 5c4f454..355b23f 100644
--- a/src/gbproxy/gb_proxy_vty.c
+++ b/src/gbproxy/gb_proxy_vty.c
@@ -554,7 +554,6 @@
SHOW_STR "Display information about the Gb proxy\n" "Show logical
links\n")
{
struct gbproxy_peer *peer;
- char mi_buf[200];
time_t now;
struct timespec ts = {0,};
@@ -569,17 +568,20 @@
llist_for_each_entry(link_info, >logical_links, list) {
time_t age = now - link_info->timestamp;
+ struct osmo_mobile_identity mi;
+ const char *imsi_str;
if (link_info->imsi > 0) {
- snprintf(mi_buf, sizeof(mi_buf), "(invalid)");
- gsm48_mi_to_string(mi_buf, sizeof(mi_buf),
- link_info->imsi,
- link_info->imsi_len);
+ if (osmo_mobile_identity_decode(,
link_info->imsi, link_info->imsi_len, false)
+ || mi.type != GSM_MI_TYPE_IMSI)
+ imsi_str = "(invalid)";
+ else
+ imsi_str = mi.imsi;
} else {
- snprintf(mi_buf, sizeof(mi_buf), "(none)");
+
Change in osmo-msc[master]: msc_vlr_test_gsm_ciph.c: fix IMEISV MI: even number of digits, clear ...
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-msc/+/18714 )
Change subject: msc_vlr_test_gsm_ciph.c: fix IMEISV MI: even number of digits,
clear odd bit
..
msc_vlr_test_gsm_ciph.c: fix IMEISV MI: even number of digits, clear odd bit
Change-Id: Ib1d54c59acc8b716de471ca275f54f9d22da3574
---
M tests/msc_vlr/msc_vlr_test_gsm_ciph.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/14/18714/1
diff --git a/tests/msc_vlr/msc_vlr_test_gsm_ciph.c
b/tests/msc_vlr/msc_vlr_test_gsm_ciph.c
index 1b413f9..38a5caf 100644
--- a/tests/msc_vlr/msc_vlr_test_gsm_ciph.c
+++ b/tests/msc_vlr/msc_vlr_test_gsm_ciph.c
@@ -643,7 +643,7 @@
btw("MS sends Ciphering Mode Complete with IMEISV, VLR accepts and
sends GSUP LU Req to HLR");
gsup_expect_tx("0401080971004026f0" CN_DOMAIN VLR_TO_HLR);
- ms_sends_ciphering_mode_complete("063217094b32244332244372f5");
+ ms_sends_ciphering_mode_complete("063217094332244332244372f5");
VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d");
btw("Subscriber has the IMEISV");
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18714
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ib1d54c59acc8b716de471ca275f54f9d22da3574
Gerrit-Change-Number: 18714
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: refactor bsc_find_msc()'s round-robin
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18505 to look at the new patch set (#5). Change subject: refactor bsc_find_msc()'s round-robin .. refactor bsc_find_msc()'s round-robin Prepare for MSC pooling by NRI. Before introducing actual NRI decoding and MSC matching, fix the bsc_find_msc() implementation. (Indicate the places relevant for NRI by "TODO" comments). bsc_find_msc() puts an MSC to the end of the internal list of MSCs when it was used. This has problems: - Modifying the list affects VTY output, e.g. 'show running-config' and 'show mscs' change their order in which MSCs are shown, depending on how often a round-robin selection has taken place. - Emergency calls and normal calls potentially pick quite different sets of eligible MSCs. When the round-robin choices between these sets affect each other, the choice is not balanced. For example, if only the first MSC is allow_emerg == true, every emergency call would reset the round-robin state to the first MSC in the list, also for normal calls. If there are regular emergency calls, normal calls will then tend to load more onto the first few MSCs after those picked for emergency calls. Fix: Never affect the ordering of MSCs in the internal list of MSCs. Instead, keep a "next_nr" MSC index and determine the next round-robin target like that. Keep a separate "next_emerg_nr" MSC index so that emergency call round-robin does no longer cause normal round-robin to skip MSCs. Further problems in current bsc_find_msc(): - The "blind:" label should also do round-robin. - The "paging:" part should not attempt to use disconnected MSCs. - Both should also heed NRI matches (when they are added). Fix: instead of code dup, determine Paging Response matching with an earlier Paging Request right at the start. If that yields no usable MSC, continue into the normal NRI and round-robin selection. The loop in this patch is inspired by the upcoming implementation of MSC pooling by NRI, as indicated by the two TODO comments. The point is that, in the presence of an NRI from a TMSI identity, we always need to iterate all of the MSCs to find possible NRI matches. The two round-robin sets (Emergency and non-Emergency) are determined in the same loop iteration for cases that have no or match no NRI, or where a matching MSC is currently disconnected. Change-Id: Idf71f07ba5a17d5b870dc1a5a2875b6fedb61291 --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/gsm_08_08.c 2 files changed, 71 insertions(+), 60 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/05/18505/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idf71f07ba5a17d5b870dc1a5a2875b6fedb61291 Gerrit-Change-Number: 18505 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset
Change in pysim[master]: cards.py: added generic USIM
gui...@gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18710 ) Change subject: cards.py: added generic USIM .. Patch Set 6: > Patch Set 6: > > > Patch Set 6: Verified-1 > > > > Build Failed > > > > https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/552/ : FAILURE > I don't fully get why this is failling - is FairwaveSIM an USIM ? I can see it's reporting the USIM service table in the test result, but pySim-prog is failling with the CLA byte set to 00 I don't have this type of SIM for testing it in my reader, some clarification would be really useful! -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8c0a914ed00a713fe473fc64f35d17ba34176e52 Gerrit-Change-Number: 18710 Gerrit-PatchSet: 6 Gerrit-Owner: gui...@gmail.com Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: gui...@gmail.com Gerrit-Comment-Date: Sun, 07 Jun 2020 20:53:13 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: use osmo_mobile_identity API everywhere
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/18713 )
Change subject: use osmo_mobile_identity API everywhere
..
use osmo_mobile_identity API everywhere
Depends: Ic3f969e739654c1e8c387aedeeba5cce07fe2307 (libosmocore)
Change-Id: I71c3b4c65dbfdfa51409e09d4868aea83225338a
---
M include/osmocom/bsc/abis_rsl.h
M include/osmocom/bsc/gsm_04_08_rr.h
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/bsc_subscriber.c
M src/osmo-bsc/gsm_04_08_rr.c
M src/osmo-bsc/osmo_bsc_bssap.c
M src/osmo-bsc/paging.c
M src/osmo-bsc/pcu_sock.c
8 files changed, 73 insertions(+), 59 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/13/18713/1
diff --git a/include/osmocom/bsc/abis_rsl.h b/include/osmocom/bsc/abis_rsl.h
index b43e3ae..2611a3d 100644
--- a/include/osmocom/bsc/abis_rsl.h
+++ b/include/osmocom/bsc/abis_rsl.h
@@ -43,8 +43,9 @@
int rsl_tx_chan_activ(struct gsm_lchan *lchan, uint8_t act_type, uint8_t
ho_ref);
int rsl_chan_mode_modify_req(struct gsm_lchan *ts);
int rsl_encryption_cmd(struct msgb *msg);
-int rsl_paging_cmd(struct gsm_bts *bts, uint8_t paging_group, uint8_t len,
- uint8_t *ms_ident, uint8_t chan_needed, bool is_gprs);
+int rsl_paging_cmd(struct gsm_bts *bts, uint8_t paging_group,
+ const struct osmo_mobile_identity *mi,
+ uint8_t chan_needed, bool is_gprs);
int rsl_imm_assign_cmd(struct gsm_bts *bts, uint8_t len, uint8_t *val);
int rsl_tx_imm_assignment(struct gsm_lchan *lchan);
int rsl_tx_imm_ass_rej(struct gsm_bts *bts, struct gsm48_req_ref *rqd_ref);
diff --git a/include/osmocom/bsc/gsm_04_08_rr.h
b/include/osmocom/bsc/gsm_04_08_rr.h
index d34e695..8821251 100644
--- a/include/osmocom/bsc/gsm_04_08_rr.h
+++ b/include/osmocom/bsc/gsm_04_08_rr.h
@@ -39,7 +39,6 @@
enum gsm48_reject_value value);
struct msgb *gsm48_create_mm_serv_rej(enum gsm48_reject_value value);
-int gsm48_extract_mi(uint8_t *classmark2_lv, int length, char *mi_string,
uint8_t *mi_type);
struct msgb *gsm48_create_loc_upd_rej(uint8_t cause);
struct msgb *gsm48_create_rr_status(uint8_t cause);
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 4a1d314..43c52ad 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -664,18 +664,29 @@
return abis_rsl_sendmsg(msg);
}
-int rsl_paging_cmd(struct gsm_bts *bts, uint8_t paging_group, uint8_t len,
- uint8_t *ms_ident, uint8_t chan_needed, bool is_gprs)
+int rsl_paging_cmd(struct gsm_bts *bts, uint8_t paging_group,
+ const struct osmo_mobile_identity *mi,
+ uint8_t chan_needed, bool is_gprs)
{
struct abis_rsl_dchan_hdr *dh;
struct msgb *msg = rsl_msgb_alloc();
+ uint8_t *l;
+ int rc;
dh = (struct abis_rsl_dchan_hdr *) msgb_put(msg, sizeof(*dh));
init_dchan_hdr(dh, RSL_MT_PAGING_CMD);
dh->chan_nr = RSL_CHAN_PCH_AGCH;
msgb_tv_put(msg, RSL_IE_PAGING_GROUP, paging_group);
- msgb_tlv_put(msg, RSL_IE_MS_IDENTITY, len-2, ms_ident+2);
+
+ l = msgb_tl_put(msg, RSL_IE_MS_IDENTITY);
+ rc = osmo_mobile_identity_encode_msgb(msg, mi, false);
+ if (rc < 0) {
+ msgb_free(msg);
+ return -EINVAL;
+ }
+ *l = rc;
+
msgb_tv_put(msg, RSL_IE_CHAN_NEEDED, chan_needed);
/* Ericsson wants to have this IE in case a paging message
diff --git a/src/osmo-bsc/bsc_subscriber.c b/src/osmo-bsc/bsc_subscriber.c
index ecd6f3d..9ddfcaa 100644
--- a/src/osmo-bsc/bsc_subscriber.c
+++ b/src/osmo-bsc/bsc_subscriber.c
@@ -81,7 +81,7 @@
return NULL;
switch (mi->type) {
case GSM_MI_TYPE_IMSI:
- return bsc_subscr_find_by_imsi(list, mi->string);
+ return bsc_subscr_find_by_imsi(list, mi->imsi);
case GSM_MI_TYPE_TMSI:
return bsc_subscr_find_by_tmsi(list, mi->tmsi);
default:
@@ -130,7 +130,7 @@
return NULL;
switch (mi->type) {
case GSM_MI_TYPE_IMSI:
- return bsc_subscr_find_or_create_by_imsi(list, mi->string);
+ return bsc_subscr_find_or_create_by_imsi(list, mi->imsi);
case GSM_MI_TYPE_TMSI:
return bsc_subscr_find_or_create_by_tmsi(list, mi->tmsi);
default:
diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c
index 4630b47..8a74aab 100644
--- a/src/osmo-bsc/gsm_04_08_rr.c
+++ b/src/osmo-bsc/gsm_04_08_rr.c
@@ -828,20 +828,6 @@
return msg;
}
-int gsm48_extract_mi(uint8_t *classmark2_lv, int length, char *mi_string,
uint8_t *mi_type)
-{
- /* Check the size for the classmark */
- if (length < 1 + *classmark2_lv)
- return -1;
-
- uint8_t *mi_lv = classmark2_lv + *classmark2_lv + 1;
- if (length < 2 + *classmark2_lv + mi_lv[0])
- return -2;
-
Change in osmo-bsc[master]: remove extract_sub(), add bsc_subscr_find_or_create_by_mi()
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/18712 )
Change subject: remove extract_sub(), add bsc_subscr_find_or_create_by_mi()
..
remove extract_sub(), add bsc_subscr_find_or_create_by_mi()
Use the new osmo_mobile_identity API to shed some code dup and simplify.
gsm48_paging_extract_mi() is now unused, drop.
(More refactoring to use osmo_mobile_identity follows in subsequent patch.)
Depends: Ic3f969e739654c1e8c387aedeeba5cce07fe2307 (libosmocore)
Change-Id: Id6cccaac64392b737b3bba8f3a22a88009adb23b
---
M include/osmocom/bsc/bsc_subscriber.h
M include/osmocom/bsc/gsm_04_08_rr.h
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/bsc_subscriber.c
M src/osmo-bsc/gsm_04_08_rr.c
M src/osmo-bsc/gsm_08_08.c
6 files changed, 51 insertions(+), 58 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/12/18712/1
diff --git a/include/osmocom/bsc/bsc_subscriber.h
b/include/osmocom/bsc/bsc_subscriber.h
index 93b3539..7381b84 100644
--- a/include/osmocom/bsc/bsc_subscriber.h
+++ b/include/osmocom/bsc/bsc_subscriber.h
@@ -8,6 +8,7 @@
#include
struct log_target;
+struct osmo_mobile_identity;
struct bsc_subscr {
struct llist_head entry;
@@ -25,11 +26,13 @@
const char *imsi);
struct bsc_subscr *bsc_subscr_find_or_create_by_tmsi(struct llist_head *list,
uint32_t tmsi);
+struct bsc_subscr *bsc_subscr_find_or_create_by_mi(struct llist_head *list,
const struct osmo_mobile_identity *mi);
struct bsc_subscr *bsc_subscr_find_by_imsi(struct llist_head *list,
const char *imsi);
struct bsc_subscr *bsc_subscr_find_by_tmsi(struct llist_head *list,
uint32_t tmsi);
+struct bsc_subscr *bsc_subscr_find_by_mi(struct llist_head *list, const struct
osmo_mobile_identity *mi);
void bsc_subscr_set_imsi(struct bsc_subscr *bsub, const char *imsi);
diff --git a/include/osmocom/bsc/gsm_04_08_rr.h
b/include/osmocom/bsc/gsm_04_08_rr.h
index 06cefa9..d34e695 100644
--- a/include/osmocom/bsc/gsm_04_08_rr.h
+++ b/include/osmocom/bsc/gsm_04_08_rr.h
@@ -40,8 +40,6 @@
struct msgb *gsm48_create_mm_serv_rej(enum gsm48_reject_value value);
int gsm48_extract_mi(uint8_t *classmark2_lv, int length, char *mi_string,
uint8_t *mi_type);
-int gsm48_paging_extract_mi(struct gsm48_pag_resp *resp, int length,
- char *mi_string, uint8_t *mi_type);
struct msgb *gsm48_create_loc_upd_rej(uint8_t cause);
struct msgb *gsm48_create_rr_status(uint8_t cause);
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 52ff5e4..45a868c 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -52,8 +52,6 @@
#define OBSC_LINKID_CB(__msgb) (__msgb)->cb[3]
-#define tmsi_from_string(str) strtoul(str, NULL, 10)
-
/* 3-bit long values */
#define EARFCN_PRIO_INVALID 8
#define EARFCN_MEAS_BW_INVALID 8
diff --git a/src/osmo-bsc/bsc_subscriber.c b/src/osmo-bsc/bsc_subscriber.c
index 38b532a..ecd6f3d 100644
--- a/src/osmo-bsc/bsc_subscriber.c
+++ b/src/osmo-bsc/bsc_subscriber.c
@@ -75,6 +75,20 @@
return NULL;
}
+struct bsc_subscr *bsc_subscr_find_by_mi(struct llist_head *list, const struct
osmo_mobile_identity *mi)
+{
+ if (!mi)
+ return NULL;
+ switch (mi->type) {
+ case GSM_MI_TYPE_IMSI:
+ return bsc_subscr_find_by_imsi(list, mi->string);
+ case GSM_MI_TYPE_TMSI:
+ return bsc_subscr_find_by_tmsi(list, mi->tmsi);
+ default:
+ return NULL;
+ }
+}
+
void bsc_subscr_set_imsi(struct bsc_subscr *bsub, const char *imsi)
{
if (!bsub)
@@ -110,6 +124,20 @@
return bsc_subscr_get(bsub);
}
+struct bsc_subscr *bsc_subscr_find_or_create_by_mi(struct llist_head *list,
const struct osmo_mobile_identity *mi)
+{
+ if (!mi)
+ return NULL;
+ switch (mi->type) {
+ case GSM_MI_TYPE_IMSI:
+ return bsc_subscr_find_or_create_by_imsi(list, mi->string);
+ case GSM_MI_TYPE_TMSI:
+ return bsc_subscr_find_or_create_by_tmsi(list, mi->tmsi);
+ default:
+ return NULL;
+ }
+}
+
const char *bsc_subscr_name(struct bsc_subscr *bsub)
{
static char buf[32];
diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c
index 4e5a307..4630b47 100644
--- a/src/osmo-bsc/gsm_04_08_rr.c
+++ b/src/osmo-bsc/gsm_04_08_rr.c
@@ -842,16 +842,6 @@
return gsm48_mi_to_string(mi_string, GSM48_MI_SIZE, mi_lv+1, *mi_lv);
}
-int gsm48_paging_extract_mi(struct gsm48_pag_resp *resp, int length,
- char *mi_string, uint8_t *mi_type)
-{
- static const uint32_t classmark_offset =
- offsetof(struct gsm48_pag_resp, classmark2);
-
Change in libosmocore[master]: add gsm23236: MSC pooling: TMSI and NRI utility functions
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18506 to look at the new patch set (#9). Change subject: add gsm23236: MSC pooling: TMSI and NRI utility functions .. add gsm23236: MSC pooling: TMSI and NRI utility functions These utilities will be used by osmo-bsc to determine the Network Resource Indicator seen in the TMSI, and (potentially) by osmo-msc to compose a TMSI with a specific NRI, for osmo-bsc's load balancing between several MSCs. Add utility functions to: - extract an NRI value from a TMSI. - overwrite the NRI value in a TMSI. - limit an NRI in a (random) TMSI to a given list of ranges. - add NRI value ranges to a list. - remove them from a list. - match NRI value (range) to a list. - parse NRI values from string, for VTY. - common VTY functionality of adding/removing NRI values from argv. Add C tests for the above. Why we need public API for NRI ranges: In osmo-bsc alone, we need the same NRI API twice, 1: to manage/list NRI value ranges per-MSC, and 2: to manage/list NULL-NRI values. If we also consider (potentially) adding NRI support to osmo-msc, we need the same API twice again there. Hence it is useful to define re-used API up here in libosmocore. Related: OS#3682 Change-Id: Icb57a2dd9323c7ea11b34003eccc7e68a0247bf5 --- M include/Makefile.am A include/osmocom/gsm/gsm23236.h M src/gsm/Makefile.am A src/gsm/gsm23236.c M src/gsm/libosmogsm.map M tests/Makefile.am A tests/gsm23236/gsm23236_test.c A tests/gsm23236/gsm23236_test.ok M tests/testsuite.at 9 files changed, 1,784 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/18506/9 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icb57a2dd9323c7ea11b34003eccc7e68a0247bf5 Gerrit-Change-Number: 18506 Gerrit-PatchSet: 9 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: fix: properly start virtphy
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/docker-playground/+/18709 )
Change subject: ttcn3-bts-test/jenkins.sh: fix: properly start virtphy
..
ttcn3-bts-test/jenkins.sh: fix: properly start virtphy
Change-Id: I2c92ca7d8839a5e141a756f0e1ca26f5f27ca143
---
M ttcn3-bts-test/jenkins.sh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve; Verified
diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh
index 949d650..0d0473b 100755
--- a/ttcn3-bts-test/jenkins.sh
+++ b/ttcn3-bts-test/jenkins.sh
@@ -73,11 +73,11 @@
echo Starting container with virtphy
docker run --rm \
--network $NET_NAME --ip 172.18.9.22 \
+ -v $VOL_BASE_DIR/virtphy:/data \
-v $VOL_BASE_DIR/unix:/data/unix \
--name ${BUILD_TAG}-virtphy -d \
$DOCKER_ARGS \
$REPO_USER/osmocom-bb-host-master \
- virtphy -s /data/unix/osmocom_l2
/bin/sh -c "virtphy -s /data/unix/osmocom_l2
>>/data/virtphy.log 2>&1"
}
@@ -110,6 +110,7 @@
mkdir $VOL_BASE_DIR/fake_trx
mkdir $VOL_BASE_DIR/trxcon
+mkdir $VOL_BASE_DIR/virtphy
# 1) classic test suite with BSC for OML and trxcon+fake_trx
start_bsc
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18709
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I2c92ca7d8839a5e141a756f0e1ca26f5f27ca143
Gerrit-Change-Number: 18709
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: fix: properly start virtphy
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18709 ) Change subject: ttcn3-bts-test/jenkins.sh: fix: properly start virtphy .. Patch Set 2: Verified+1 Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18709 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2c92ca7d8839a5e141a756f0e1ca26f5f27ca143 Gerrit-Change-Number: 18709 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jun 2020 20:46:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: scheduler: fix trx_sched_set_lchan(): send TRXC HANDOVER
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18708 ) Change subject: scheduler: fix trx_sched_set_lchan(): send TRXC HANDOVER .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia106baafc1b7fafb36f11ca378a285d71d1df5a3 Gerrit-Change-Number: 18708 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-MessageType: abandon
Change in osmo-bsc[master]: gsm0408_test.c: drop test_mi_functionality()
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/18648 )
Change subject: gsm0408_test.c: drop test_mi_functionality()
..
gsm0408_test.c: drop test_mi_functionality()
Testing these functions is actually done in libosmocore. Also, with new
osmo_mobile_identity API, the functions being tested are marked deprecated. So
drop the test.
BTW, the test contained an IMSI of 16 digits, which is too long, yet was
expected to succeed. GSM23003_IMSI_MAX_DIGITS == 15. I first considered fixing
the test data, but the test is in the wrong place here anyway.
Change-Id: I902d31ecd72d71892fad7945f695a9f1fb403bf2
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 0 insertions(+), 33 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
fixeria: Looks good to me, approved
diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c
index f850274..5ff9491 100644
--- a/tests/gsm0408/gsm0408_test.c
+++ b/tests/gsm0408/gsm0408_test.c
@@ -269,34 +269,6 @@
bts_del(bts);
}
-static void test_mi_functionality(void)
-{
- const char *imsi_odd = "987654321098763";
- const char *imsi_even = "9876543210987654";
- const uint32_t tmsi = 0xfabeacd0;
- uint8_t mi[128];
- unsigned int mi_len;
- char mi_parsed[GSM48_MI_SIZE];
-
- printf("Testing parsing and generating TMSI/IMSI\n");
-
- /* tmsi code */
- mi_len = gsm48_generate_mid_from_tmsi(mi, tmsi);
- gsm48_mi_to_string(mi_parsed, sizeof(mi_parsed), mi + 2, mi_len - 2);
- COMPARE((uint32_t)strtoul(mi_parsed, NULL, 10), ==, tmsi);
-
- /* imsi code */
- mi_len = gsm48_generate_mid_from_imsi(mi, imsi_odd);
- gsm48_mi_to_string(mi_parsed, sizeof(mi_parsed), mi + 2, mi_len -2);
- printf("hex: %s\n", osmo_hexdump(mi, mi_len));
- COMPARE_STR(mi_parsed, imsi_odd);
-
- mi_len = gsm48_generate_mid_from_imsi(mi, imsi_even);
- gsm48_mi_to_string(mi_parsed, sizeof(mi_parsed), mi + 2, mi_len -2);
- printf("hex: %s\n", osmo_hexdump(mi, mi_len));
- COMPARE_STR(mi_parsed, imsi_even);
-}
-
struct {
int range;
int arfcns_num;
@@ -924,8 +896,6 @@
return EXIT_FAILURE;
}
- test_mi_functionality();
-
test_si_range_helpers();
test_arfcn_filter();
test_print_encoding();
diff --git a/tests/gsm0408/gsm0408_test.ok b/tests/gsm0408/gsm0408_test.ok
index e3290b5..bad8aef 100644
--- a/tests/gsm0408/gsm0408_test.ok
+++ b/tests/gsm0408/gsm0408_test.ok
@@ -1,6 +1,3 @@
-Testing parsing and generating TMSI/IMSI
-hex: 17 08 99 78 56 34 12 90 78 36
-hex: 17 09 91 78 56 34 12 90 78 56 f4
Element is: 2 => freqs[i] = 121
Element is: 2 => freqs[i] = 1
Element is: 0 => freqs[i] = 68
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18648
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I902d31ecd72d71892fad7945f695a9f1fb403bf2
Gerrit-Change-Number: 18648
Gerrit-PatchSet: 2
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: lapd_core: Fix log line being about LAPD and not LAPDm
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18711 ) Change subject: lapd_core: Fix log line being about LAPD and not LAPDm .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I92c8a9752e88164eedffb9f9a081288458f6eadb Gerrit-Change-Number: 18711 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jun 2020 20:39:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: lapd/lapdm: print user-defined string name instead of (dl=%p)
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18002 to look at the new patch set (#8). Change subject: lapd/lapdm: print user-defined string name instead of (dl=%p) .. lapd/lapdm: print user-defined string name instead of (dl=%p) At the moment we print the pointer address to identify the log lines belonging to a specific connection. Since pointer addresses are difficult to work with, a human readable ID should be printed instead. e.g. "This is LAPD instance for SAPI3 on bts0/trx1/ts5/lchan3" Change-Id: Ie6742843fff809edffcac24c4dce4edf66bc71be Closes: OS#1938 --- M TODO-RELEASE M include/osmocom/gsm/lapd_core.h M include/osmocom/gsm/lapdm.h M src/gsm/lapd_core.c M src/gsm/lapdm.c M src/gsm/libosmogsm.map 6 files changed, 302 insertions(+), 323 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/02/18002/8 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie6742843fff809edffcac24c4dce4edf66bc71be Gerrit-Change-Number: 18002 Gerrit-PatchSet: 8 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: refactor bsc_find_msc()'s round-robin
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18505 ) Change subject: refactor bsc_find_msc()'s round-robin .. Patch Set 4: > I don't agree with your point about using a number instead of a pointer > because it's "safer". If that was the case, then we'd be dropping lots of > pointers everywhere and using c++ with references or other programming > language. > That being said, I'm not going to block this patch, so +1. well, keeping a number is in fact safer, because the msc with that number is free to go missing at any time without causing breakage. The difference is having *more than one* pointer to the same object that persist across main loops, which is always introducing the danger of segfaults. Where ever we do that, we need to carefully clean up: take a look at functions like lchan_forget_conn() and gscon_forget_lchan(), which act in a quite complex juxtaposition and are the final result of several levels of hard to crack segfault bugs I introduced before figuring out the current code. Thanks for the +1 :) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idf71f07ba5a17d5b870dc1a5a2875b6fedb61291 Gerrit-Change-Number: 18505 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Sun, 07 Jun 2020 20:38:28 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bts[master]: Ensure we include lchan name in all LAPDm log lines
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/18004 to look at the new patch set (#3). Change subject: Ensure we include lchan name in all LAPDm log lines .. Ensure we include lchan name in all LAPDm log lines This makes use of the newly-introduced lapdm_channel_init3() API, which provides the user (BTS in this case) to provide a human-readable string identifier for each LAPDm channel. This identifier is subsequently used in all related log lines to provide context. This means we will now get context information about which specific SAPI in which sub-channel (ACCH/DCCH) on which lchan/ts/trx/bts a given message originated from. Example: DLLAPD <0011> lapd_core.c:829 ((bts=0,trx=0,ts=0,ss=0)[DCCH][0]) SABM(E) received in state LAPD_STATE_IDLE Change-Id: I17e3d4797ec71e31d0775330ae36d2e1fd70423f Depends: libosmocore.git Ie6742843fff809edffcac24c4dce4edf66bc71be Related: OS#1938 --- A TODO-RELEASE M src/common/bts.c 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/04/18004/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18004 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I17e3d4797ec71e31d0775330ae36d2e1fd70423f Gerrit-Change-Number: 18004 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in libosmocore[master]: lapd_core: Fix log line being about LAPD and not LAPDm
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/18711 )
Change subject: lapd_core: Fix log line being about LAPD and not LAPDm
..
lapd_core: Fix log line being about LAPD and not LAPDm
Change-Id: I92c8a9752e88164eedffb9f9a081288458f6eadb
---
M src/gsm/lapd_core.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/11/18711/1
diff --git a/src/gsm/lapd_core.c b/src/gsm/lapd_core.c
index d9b729f..72e70f0 100644
--- a/src/gsm/lapd_core.c
+++ b/src/gsm/lapd_core.c
@@ -337,7 +337,7 @@
/* reset to IDLE state */
void lapd_dl_reset(struct lapd_datalink *dl)
{
- LOGDL(dl, LOGL_INFO, "Resetting LAPDm instance\n");
+ LOGDL(dl, LOGL_INFO, "Resetting LAPD instance\n");
/* enter idle state (and remove eventual cont_res) */
lapd_dl_newstate(dl, LAPD_STATE_IDLE);
/* flush buffer */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18711
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I92c8a9752e88164eedffb9f9a081288458f6eadb
Gerrit-Change-Number: 18711
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
Change in libosmocore[master]: lapd/lapdm: print user-defined string name instead of (dl=%p)
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18002 to look at the new patch set (#7). Change subject: lapd/lapdm: print user-defined string name instead of (dl=%p) .. lapd/lapdm: print user-defined string name instead of (dl=%p) At the moment we print the pointer address to identify the log lines belonging to a specific connection. Since pointer addresses are difficult to work with, a human readable ID should be printed instead. e.g. "This is LAPD instance for SAPI3 on bts0/trx1/ts5/lchan3" Change-Id: Ie6742843fff809edffcac24c4dce4edf66bc71be Closes: OS#1938 --- M TODO-RELEASE M include/osmocom/gsm/lapd_core.h M include/osmocom/gsm/lapdm.h M src/gsm/lapd_core.c M src/gsm/lapdm.c M src/gsm/libosmogsm.map 6 files changed, 301 insertions(+), 323 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/02/18002/7 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie6742843fff809edffcac24c4dce4edf66bc71be Gerrit-Change-Number: 18002 Gerrit-PatchSet: 7 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in libosmocore[master]: lapd/lapdm: print user-defined string name instead of (dl=%p)
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18002 ) Change subject: lapd/lapdm: print user-defined string name instead of (dl=%p) .. Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/18002/6/src/gsm/lapdm.c File src/gsm/lapdm.c: https://gerrit.osmocom.org/c/libosmocore/+/18002/6/src/gsm/lapdm.c@273 PS6, Line 273: lc->name = talloc_strdup(lc, name_pfx); don't you need to free here if lc->name is already set? Because you are not allocating lc here. osmo_talloc_replace_string -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie6742843fff809edffcac24c4dce4edf66bc71be Gerrit-Change-Number: 18002 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jun 2020 20:18:25 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: lapd/lapdm: print user-defined string name instead of (dl=%p)
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18002 to look at the new patch set (#6). Change subject: lapd/lapdm: print user-defined string name instead of (dl=%p) .. lapd/lapdm: print user-defined string name instead of (dl=%p) At the moment we print the pointer address to identify the log lines belonging to a specific connection. Since pointer addresses are difficult to work with, a human readable ID should be printed instead. e.g. "This is LAPD instance for SAPI3 on bts0/trx1/ts5/lchan3" Change-Id: Ie6742843fff809edffcac24c4dce4edf66bc71be Closes: OS#1938 --- M TODO-RELEASE M include/osmocom/gsm/lapd_core.h M include/osmocom/gsm/lapdm.h M src/gsm/lapd_core.c M src/gsm/lapdm.c M src/gsm/libosmogsm.map 6 files changed, 273 insertions(+), 316 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/02/18002/6 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie6742843fff809edffcac24c4dce4edf66bc71be Gerrit-Change-Number: 18002 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmocom-bb[master]: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18641 ) Change subject: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds .. Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py File src/target/trx_toolkit/fake_trx.py: https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py@293 PS6, Line 293: Use negative threshold to disable fake_rssi if previously enabled: > So one would need to send something like 'FAKE_TOA -60 -1' in order to make > fake_trx. […] Sorry you submitted your comment almost at the same time when I was merging it. I can add that of course, but right now there's actually no real user of that feature (even with the -1). I simply added the -1 as a workaround in case someone has this need at some point. I'm fine with adding a new command if you want, but I thought having less commands is actually simpler from protocol point of view. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3ee1a32ca22c3272e66b3ca78e4f67d283844c80 Gerrit-Change-Number: 18641 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jun 2020 19:56:15 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in osmocom-bb[master]: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18641 ) Change subject: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds .. Patch Set 6: Code-Review+2 +1+1=+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3ee1a32ca22c3272e66b3ca78e4f67d283844c80 Gerrit-Change-Number: 18641 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jun 2020 19:51:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/18641 )
Change subject: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds
..
fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds
By default RSSI on the Rx side is computed based on transmitter's
tx power and then substracting the the Rx path loss.
If FAKE_RSSI is used, then the values in there are used instead.
A default hardcoded value of tx nominal power = 50 dBm is set to keep
old behavior of RSSI=-60dB after calculations.
Change-Id: I3ee1a32ca22c3272e66b3ca78e4f67d283844c80
---
M src/target/trx_toolkit/ctrl_if_trx.py
M src/target/trx_toolkit/fake_trx.py
2 files changed, 40 insertions(+), 3 deletions(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/target/trx_toolkit/ctrl_if_trx.py
b/src/target/trx_toolkit/ctrl_if_trx.py
index 65198cf..e841975 100644
--- a/src/target/trx_toolkit/ctrl_if_trx.py
+++ b/src/target/trx_toolkit/ctrl_if_trx.py
@@ -239,6 +239,19 @@
% (self.trx, ver_cur, ver_req))
return ver_req
+ # Set Power Attenuation
+ if self.verify_cmd(request, "SETPOWER", 1):
+ log.debug("(%s) Recv SETPOWER cmd" % self.trx)
+ # Parse the requested Tx Power Attenuation
+ att_req = int(request[1])
+ self.trx.tx_att_base = att_req
+ return 0
+
+ # Retrieve Nominal Tx power
+ if self.verify_cmd(request, "NOMTXPOWER", 0):
+ log.debug("(%s) Recv NOMTXPOWER cmd" % self.trx)
+ return (0, [str(self.trx.tx_power_base)])
+
# Wrong / unknown command
else:
# We don't care about other commands,
diff --git a/src/target/trx_toolkit/fake_trx.py
b/src/target/trx_toolkit/fake_trx.py
index f14d143..4a49fa3 100755
--- a/src/target/trx_toolkit/fake_trx.py
+++ b/src/target/trx_toolkit/fake_trx.py
@@ -106,8 +106,11 @@
"""
+ NOMINAL_TX_POWER_DEFAULT = 50 # dBm
+ TX_ATT_DEFAULT = 0 # dB
+ PATH_LOSS_DEFAULT = 110 # dB
+
TOA256_BASE_DEFAULT = 0
- RSSI_BASE_DEFAULT = -60
CI_BASE_DEFAULT = 90
# Default values for NOPE / IDLE indications
@@ -118,9 +121,15 @@
def __init__(self, *trx_args, **trx_kwargs):
Transceiver.__init__(self, *trx_args, **trx_kwargs)
+ # fake RSSI is disabled by default, only enabled through TRXC
FAKE_RSSI.
+ # When disabled, RSSI is calculated based on Tx power and Rx
path loss
+ self.fake_rssi_enabled = False
+
# Actual ToA, RSSI, C/I, TA values
+ self.tx_power_base = self.NOMINAL_TX_POWER_DEFAULT
+ self.tx_att_base = self.TX_ATT_DEFAULT
self.toa256_base = self.TOA256_BASE_DEFAULT
- self.rssi_base = self.RSSI_BASE_DEFAULT
+ self.rssi_base = self.NOMINAL_TX_POWER_DEFAULT -
self.TX_ATT_DEFAULT - self.PATH_LOSS_DEFAULT
self.ci_base = self.CI_BASE_DEFAULT
self.ta = 0
@@ -156,6 +165,10 @@
return random.randint(rssi_min, rssi_max)
@property
+ def tx_power(self):
+ return self.tx_power_base - self.tx_att_base
+
+ @property
def ci(self):
# Check if randomization is required
if self.ci_rand_threshold == 0:
@@ -224,7 +237,12 @@
# Complete message header
msg.toa256 = self.toa256
- msg.rssi = self.rssi
+
+ # Apply RSSI based on transmitter:
+ if not self.fake_rssi_enabled:
+ msg.rssi = src_trx.tx_power - src_msg.pwr -
self.PATH_LOSS_DEFAULT
+ else: # Apply fake RSSI
+ msg.rssi = self.rssi
# Version specific fields
if msg.ver >= 0x01:
@@ -272,9 +290,15 @@
elif self.ctrl_if.verify_cmd(request, "FAKE_RSSI", 2):
log.debug("(%s) Recv FAKE_RSSI cmd" % self)
+ # Use negative threshold to disable fake_rssi if
previously enabled:
+ if int(request[2]) < 0:
+ self.fake_rssi_enabled = False
+ return 0
+
# Parse and apply both base and threshold
self.rssi_base = int(request[1])
self.rssi_rand_threshold = int(request[2])
+ self.fake_rssi_enabled = True
return 0
# RSSI simulation
--
To view, visit
Change in osmocom-bb[master]: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18641 ) Change subject: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds .. Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py File src/target/trx_toolkit/fake_trx.py: https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py@293 PS6, Line 293: Use negative threshold to disable fake_rssi if previously enabled: So one would need to send something like 'FAKE_TOA -60 -1' in order to make fake_trx.py stop using previously indicated 'fake' RSSI value, right? And '-60' in this example is a dummy value that simply should be there. Most of the commands on TRXC are kind of self-explaining, so you don't have to dig into the source code to understand their purpose. It would be nice to make this command self-explaining too. How about 'NOFAKE_RSSI'? or 'FAKE_RSSI OFF'? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3ee1a32ca22c3272e66b3ca78e4f67d283844c80 Gerrit-Change-Number: 18641 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jun 2020 19:50:52 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in pysim[master]: cards.py: added generic USIM
gui...@gmail.com has uploaded this change for review. (
https://gerrit.osmocom.org/c/pysim/+/18710 )
Change subject: cards.py: added generic USIM
..
cards.py: added generic USIM
Work in progress
a generic USIM class card will try to CLA set to 00
and assume it's an USIM card type if it gets a reply
Change-Id: I8c0a914ed00a713fe473fc64f35d17ba34176e52
---
M pySim-read.py
M pySim/cards.py
M pySim/transport/serial.py
3 files changed, 57 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/10/18710/1
diff --git a/pySim-read.py b/pySim-read.py
index b23e6ee..345e6d5 100755
--- a/pySim-read.py
+++ b/pySim-read.py
@@ -88,17 +88,6 @@
# Wait for SIM card
sl.wait_for_card()
- # Assuming UICC SIM
- scc.cla_byte = "00"
- scc.sel_ctrl = "0004"
-
- # Testing for Classic SIM or UICC
- (res, sw) = sl.send_apdu(scc.cla_byte + "a4" + scc.sel_ctrl + "02" +
"3f00")
- if sw == '6e00':
- # Just a Classic SIM
- scc.cla_byte = "a0"
- scc.sel_ctrl = ""
-
# Program the card
print("Reading ...")
@@ -240,7 +229,8 @@
# Check whether we have th AID of USIM, if so select it by its AID
# EF.UST - File Id in ADF USIM : 6f38
- if '9000' == card.select_adf_by_aid():
+
+ if card.name == 'GenericUSIM' and '9000' == card.select_adf_by_aid():
# EF.UST
(res, sw) = card.read_binary(EF_USIM_ADF_map['UST'])
if sw == '9000':
@@ -252,7 +242,7 @@
# Check whether we have th AID of ISIM, if so select it by its AID
# EF.IST - File Id in ADF ISIM : 6f07
- if '9000' == card.select_adf_by_aid(adf="isim"):
+ if card.name != 'GenericUSIM' and '9000' ==
card.select_adf_by_aid(adf="isim"):
# EF.IST
(res, sw) = card.read_binary('6f07')
if sw == '9000':
diff --git a/pySim/cards.py b/pySim/cards.py
index 808fde1..b0bc537 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -1156,11 +1156,63 @@
return
+class GenericUSIM(Card):
+ """
+ Generic USIM card
+ """
+
+ name = 'GenericUSIM'
+
+ def __init__(self, ssc):
+ super(GenericUSIM, self).__init__(ssc)
+ self._scc.cla_byte = "00"
+ self._scc.sel_ctrl = "0004" #request an FCP
+
+
+ @classmethod
+ def autodetect(kls, scc):
+ # reset the card, and send a PDU with CLA, P1 & P2 for USIM.
+ scc.reset_card()
+ scc._tp.wait_for_card()
+ #
+ (res, sw) = scc._tp.send_apdu("00a40004023f00")
+ if sw == '9000':
+ return kls(scc)
+ #if it is not successfull, the it's not a USIM card
+ return None
+
+
+ # Select ADF.USIM in the Card using its full AID
+ def select_adf_by_aid(self):
+ for aid in self._aids:
+ if "a000871002" in aid:
+ (res, sw) = self._scc.select_adf(aid)
+ return sw
+
+ return None
+
+ # Read the (full) AID
+ def read_aid(self):
+
+ # First (known) halves of the AID
+ aid_usim = "a000871002"
+
+ # Find out how many records the EF.DIR has, then go through
+ # all records and try to find the AID we are looking for
+ aid_record_count = self._scc.record_count(['2F00'])
+ for i in range(0, aid_record_count):
+ record = self._scc.read_record(['2F00'], i + 1)
+ if aid_usim in record[0]:
+ aid_len = int(record[0][6:8], 16)
+ return record[0][8:8 + aid_len * 2]
+
+ return None
+
# In order for autodetection ...
_cards_classes = [ FakeMagicSim, SuperSim, MagicSim, GrcardSim,
SysmoSIMgr1, SysmoSIMgr2, SysmoUSIMgr1, SysmoUSIMSJS1,
- FairwavesSIM, OpenCellsSim, WavemobileSim, SysmoISIMSJA2 ]
+ FairwavesSIM, OpenCellsSim, WavemobileSim, SysmoISIMSJA2,
GenericUSIM ]
def card_autodetect(scc):
for kls in _cards_classes:
diff --git a/pySim/transport/serial.py b/pySim/transport/serial.py
index 11fcd6a..12a7874 100644
--- a/pySim/transport/serial.py
+++ b/pySim/transport/serial.py
@@ -184,6 +184,7 @@
def send_apdu_raw(self, pdu):
"""see LinkBase.send_apdu_raw"""
+ self._dbg_print("TX PDU: %s" % pdu)
pdu = h2b(pdu)
data_len = ord(pdu[4]) # P3
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/18710
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Change in osmo-bts[master]: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18704 ) Change subject: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie2cdf547befbc0fafdb82b10b45ad85a9b188b88 Gerrit-Change-Number: 18704 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jun 2020 19:48:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bts: Fix trailing whitespace
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18653 )
Change subject: bts: Fix trailing whitespace
..
bts: Fix trailing whitespace
Change-Id: I5164212fee7e94bc98f65e60d00ccd77b4d9e01d
---
M bts/BTS_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index e3d4beb..8a297fb 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -2720,7 +2720,7 @@
Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
-/* establish DChan, verify that the BTS sets the TA in the first SACCH L1
header.
+/* establish DChan, verify that the BTS sets the TA in the first SACCH L1
header.
TA for the IMM ASS messages is still controlled by
g_pars.l1_pars.ms_actual_ta! */
function f_tc_rsl_chan_initial_ta(charstring id) runs on ConnHdlr {
var L1ctlDlMessage l1_dl;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18653
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5164212fee7e94bc98f65e60d00ccd77b4d9e01d
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: bts: Introduce test TC_tx_power_start_ramp_up_bcch
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654 ) Change subject: bts: Introduce test TC_tx_power_start_ramp_up_bcch .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654/1/bts/osmo-bts.cfg File bts/osmo-bts.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654/1/bts/osmo-bts.cfg@51 PS1, Line 51: 8000 > any particular reason to use such a large step size? I think in real-world > situations this is again […] To speed up test mainly. Otherwise it takes a considerable time to reach the maximum allowed power during ramp up. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieb7444c6312bbeab64da2732393b3facf3e1f003 Gerrit-Change-Number: 18654 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jun 2020 19:37:52 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-bts: Update cfg for test TC_tx_power_start_ramp_up_bcch
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18655 ) Change subject: ttcn3-bts: Update cfg for test TC_tx_power_start_ramp_up_bcch .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I878d329dde3d2089ee3b68f56271fcb88d210025 Gerrit-Change-Number: 18655 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jun 2020 19:36:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bts: Introduce test TC_tx_power_start_ramp_up_bcch
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654 ) Change subject: bts: Introduce test TC_tx_power_start_ramp_up_bcch .. Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654/1/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654/1/bts/BTS_Tests.ttcn@103 PS1, Line 103: 50 same as in other places. You can keep it if you like. Just every RF person will look at this as "Whut!?!" https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654/1/bts/osmo-bts.cfg File bts/osmo-bts.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654/1/bts/osmo-bts.cfg@51 PS1, Line 51: 8000 any particular reason to use such a large step size? I think in real-world situations this is again very unrealistic. 8dB is a factor of 6.3 in output power. You would neither want that in terms of slowly growing the cell, nor would you want to create that kind of a inrush power surge into your PA. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieb7444c6312bbeab64da2732393b3facf3e1f003 Gerrit-Change-Number: 18654 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jun 2020 19:34:59 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bts: Fix trailing whitespace
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18653 ) Change subject: bts: Fix trailing whitespace .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5164212fee7e94bc98f65e60d00ccd77b4d9e01d Gerrit-Change-Number: 18653 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jun 2020 19:32:02 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power from os...
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/18589 )
Change subject: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power
from osmo-trx
..
Patch Set 4: Code-Review+2
> For sure it's not here since this is a osmo-bts-trx patch. I can add that
> later in osmo-trx, but let's first have this working with Roh providing some
> values, to see which kind of data we need to provide in the VTY (be it a
> table, or one factor, or whatever).
I think the base line that we should do currently is one set of values
('maximum' gain for undistorted signal + resulting RF output power) per band.
Some people may want more comprehensive calibration tables, but let's not try
to solve all problems at once here, just get us to a point where whe use values
in the correct order of magnitude.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18589
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I682211f3d664c21f923ca4a530e0464ca383b6d9
Gerrit-Change-Number: 18589
Gerrit-PatchSet: 4
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-CC: Hoernchen
Gerrit-Comment-Date: Sun, 07 Jun 2020 19:31:35 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in osmocom-bb[master]: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18641 ) Change subject: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds .. Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py File src/target/trx_toolkit/fake_trx.py: https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py@109 PS6, Line 109: 50 # dBm > no problem doing that in a virtual environment, but it's a *very* unrealistic > value. […] I agree it's unrealistic, but I'm simply using that value in order to keep older behavior the same in tests (path loss of 110 and RSSI of -60). We can later fix those values as needed. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3ee1a32ca22c3272e66b3ca78e4f67d283844c80 Gerrit-Change-Number: 18641 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jun 2020 19:30:51 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-bts: Update cfg for test TC_tx_power_start_ramp_up_bcch
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18655 ) Change subject: ttcn3-bts: Update cfg for test TC_tx_power_start_ramp_up_bcch .. Patch Set 1: again I am a bit concerned about testing with unrealistically high dBm values (50), beyond that no concern with the patch. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I878d329dde3d2089ee3b68f56271fcb88d210025 Gerrit-Change-Number: 18655 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Sun, 07 Jun 2020 19:28:28 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-bts: jenkins.sh: Log fake_trx stdout to file
laforge has submitted this change. (
https://gerrit.osmocom.org/c/docker-playground/+/18642 )
Change subject: ttcn3-bts: jenkins.sh: Log fake_trx stdout to file
..
ttcn3-bts: jenkins.sh: Log fake_trx stdout to file
This allows easily checking if fake_trx fails to start early during
startup, for instance due to a python exception.
Change-Id: I3e13a3b1f78d071618e4848aa19bcba1eb300d18
---
M ttcn3-bts-test/jenkins.sh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Verified
diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh
index 4974a34..949d650 100755
--- a/ttcn3-bts-test/jenkins.sh
+++ b/ttcn3-bts-test/jenkins.sh
@@ -46,7 +46,7 @@
--name ${BUILD_TAG}-fake_trx -d \
$DOCKER_ARGS \
$REPO_USER/osmocom-bb-host-master \
- /tmp/osmocom-bb/src/target/trx_toolkit/fake_trx.py \
+ /bin/sh -c
"/tmp/osmocom-bb/src/target/trx_toolkit/fake_trx.py \
--log-file-name /data/fake_trx.log \
--log-file-level DEBUG \
--log-file-time \
@@ -54,7 +54,7 @@
-R 172.18.9.20 -r 172.18.9.22 \
--trx TRX1@172.18.9.20:5700/1 \
--trx TRX2@172.18.9.20:5700/2 \
- --trx TRX3@172.18.9.20:5700/3
+ --trx TRX3@172.18.9.20:5700/3
>>/data/fake_trx.out 2>&1"
}
start_trxcon() {
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18642
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I3e13a3b1f78d071618e4848aa19bcba1eb300d18
Gerrit-Change-Number: 18642
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in docker-playground[master]: ttcn3-bts: jenkins.sh: Log fake_trx stdout to file
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18642 ) Change subject: ttcn3-bts: jenkins.sh: Log fake_trx stdout to file .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3e13a3b1f78d071618e4848aa19bcba1eb300d18 Gerrit-Change-Number: 18642 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jun 2020 19:27:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: bts-trx: Re-apply tx power if nominal power is received after POWERON
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18652 ) Change subject: bts-trx: Re-apply tx power if nominal power is received after POWERON .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2ec8dba61393be6edfab9e7e478e096e2d0933ad Gerrit-Change-Number: 18652 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jun 2020 19:27:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18641 ) Change subject: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds .. Patch Set 6: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py File src/target/trx_toolkit/fake_trx.py: https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py@109 PS6, Line 109: 50 # dBm no problem doing that in a virtual environment, but it's a *very* unrealistic value. It equals a 100W BTS :) maybe use something closer to reality like 30-46 dBm. Keep in mind, dB are logarithmic, so every increase of '3' means a doubling in power. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3ee1a32ca22c3272e66b3ca78e4f67d283844c80 Gerrit-Change-Number: 18641 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jun 2020 19:26:18 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: Implement TRXC cmd NOMTXPOWER
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18586 ) Change subject: Implement TRXC cmd NOMTXPOWER .. Patch Set 1: Code-Review+1 we actually do have the real measured values for USRP Bxxx so they could be used right away. Also, it is obvious that we need infrastructure to return not some single magic value that is stated in each class, but that each class will need some support infrastructure to have a per-device (not per-driver, but per-sdr-device/model) value, and that this value will also have to be per-band. No point in having each class/driver reinvent that, so maybe some shared infrastructure? Also, it is equally known that this value must be possible to override from the VTY. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1d7efe56e008d8d60e23f9a85aa40809f7f84d9c Gerrit-Change-Number: 18586 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: roh Gerrit-Comment-Date: Sun, 07 Jun 2020 19:12:50 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in pysim[master]: Add support for ADF_USIM/EF_EHPLMN
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18649 ) Change subject: Add support for ADF_USIM/EF_EHPLMN .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/pysim/+/18649/1/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/18649/1/pySim/cards.py@82 PS1, Line 82: (res, sw) = self._scc.read_binary(EF_USIM_ADF_map['EHPLMN']) > is it ok to put this USIM specific things in the generic Card class? […] yes, I prefer your approach with an USIM card type. Would you have time to submit that as a follow-up patch? We'd probably have to do the same with ISIM. And yes, you can add other functions here, even if they're not used [yet] by pySim-read. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I22d96ab4a424ec5bc1fb02f5e80165c646a748d3 Gerrit-Change-Number: 18649 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: gui...@gmail.com Gerrit-Comment-Date: Sun, 07 Jun 2020 19:02:37 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: gui...@gmail.com Gerrit-MessageType: comment
Change in pysim[master]: Add support for ADF_USIM/EF_EHPLMN
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18649 ) Change subject: Add support for ADF_USIM/EF_EHPLMN .. Patch Set 1: > Patch Set 1: > > (1 comment) > > out of curiosity, the comment about the standard is interesting - so the > EHPLMN list actually has priority to "void" the PLMN extracted from the IMSI > in the PLMN search? yes > I have seen MVNO SIMs, with the EHPLMN service enabled, but the list empty, > what would be the HPLMN then? then those SIM cards will always be on roaming and never be in a home network. This has some implications on PLMN selection. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I22d96ab4a424ec5bc1fb02f5e80165c646a748d3 Gerrit-Change-Number: 18649 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: gui...@gmail.com Gerrit-Comment-Date: Sun, 07 Jun 2020 18:59:48 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-trx/trx_if: cosmetic: s/ocommand/command/
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18705 ) Change subject: osmo-bts-trx/trx_if: cosmetic: s/ocommand/command/ .. osmo-bts-trx/trx_if: cosmetic: s/ocommand/command/ Change-Id: I06db72deb78cbab588de2103657b0722b67887a0 --- M src/osmo-bts-trx/trx_if.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index 488aff6..24d6b9b 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -202,7 +202,7 @@ * \param[in] fmt Format string (+ variable list of arguments) * \returns 0 on success; negative on error * - * The new ocommand will be added to the end of the control command + * The new command will be added to the end of the control command * queue. */ static int trx_ctrl_cmd_cb(struct trx_l1h *l1h, int critical, void *cb, const char *cmd, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I06db72deb78cbab588de2103657b0722b67887a0 Gerrit-Change-Number: 18705 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-bts[master]: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18704 ) Change subject: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie2cdf547befbc0fafdb82b10b45ad85a9b188b88 Gerrit-Change-Number: 18704 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jun 2020 18:59:02 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb()
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/18704 )
Change subject: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb()
..
osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb()
If we do not enqueue a TRXC message, we should release memory.
Change-Id: Ie2cdf547befbc0fafdb82b10b45ad85a9b188b88
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 12 insertions(+), 11 deletions(-)
Approvals:
laforge: Looks good to me, approved
ipse: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c
index f717a0c..488aff6 100644
--- a/src/osmo-bts-trx/trx_if.c
+++ b/src/osmo-bts-trx/trx_if.c
@@ -211,9 +211,6 @@
struct trx_ctrl_msg *tcm;
struct trx_ctrl_msg *prev = NULL;
va_list ap;
- int pending;
-
- pending = !llist_empty(>trx_ctrl_list);
/* create message */
tcm = talloc_zero(tall_bts_ctx, struct trx_ctrl_msg);
@@ -236,18 +233,22 @@
tcm->cb = cb;
/* Avoid adding consecutive duplicate messages, eg: two consecutive
POWEROFF */
- if(pending)
+ if (!llist_empty(>trx_ctrl_list))
prev = llist_entry(l1h->trx_ctrl_list.prev, struct
trx_ctrl_msg, list);
-
- if (!pending ||
- !(strcmp(tcm->cmd, prev->cmd) == 0 && strcmp(tcm->params,
prev->params) == 0)) {
- LOGPPHI(l1h->phy_inst, DTRX, LOGL_INFO, "Enqueuing TRX control
command 'CMD %s%s%s'\n",
- tcm->cmd, tcm->params_len ? " ":"", tcm->params);
- llist_add_tail(>list, >trx_ctrl_list);
+ if (prev != NULL && !strcmp(tcm->cmd, prev->cmd)
+&& !strcmp(tcm->params, prev->params)) {
+ LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG,
+ "Not sending duplicate command '%s'\n", tcm->cmd);
+ talloc_free(tcm);
+ return 0;
}
+ LOGPPHI(l1h->phy_inst, DTRX, LOGL_INFO, "Enqueuing TRX control command
'CMD %s%s%s'\n",
+ tcm->cmd, tcm->params_len ? " " : "", tcm->params);
+ llist_add_tail(>list, >trx_ctrl_list);
+
/* send message, if we didn't already have pending messages */
- if (!pending)
+ if (prev == NULL)
trx_ctrl_send(l1h);
return 0;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18704
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie2cdf547befbc0fafdb82b10b45ad85a9b188b88
Gerrit-Change-Number: 18704
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: ipse
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bts[master]: scheduler: fix trx_sched_set_lchan(): send TRXC HANDOVER
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18708 ) Change subject: scheduler: fix trx_sched_set_lchan(): send TRXC HANDOVER .. Patch Set 1: Code-Review-1 see the related osmocom issue update. I'm not convinced your assesment of what the code should do is correct. I think it is correct to deactivate handover detection on channel deactivation. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia106baafc1b7fafb36f11ca378a285d71d1df5a3 Gerrit-Change-Number: 18708 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jun 2020 18:58:10 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: fix: properly start virtphy
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18709 ) Change subject: ttcn3-bts-test/jenkins.sh: fix: properly start virtphy .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18709 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2c92ca7d8839a5e141a756f0e1ca26f5f27ca143 Gerrit-Change-Number: 18709 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jun 2020 18:56:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Build failure of network:osmocom:latest/libusrp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libusrp/Debian_Unstable/x86_64 Package network:osmocom:latest/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: [ 215s] touch libfx2.lib [ 215s] for obj in delay.rel fx2utils.rel i2c.rel isr.rel timer.rel usb_common.rel; do basename $obj .rel >> libfx2.lib ; done [ 215s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/lib' [ 215s] Making all in src [ 215s] make[4]: Entering directory '/usr/src/packages/BUILD/firmware/src' [ 215s] Making all in common [ 215s] make[5]: Entering directory '/usr/src/packages/BUILD/firmware/src/common' [ 215s] srcdir=. ./edit-gpif ./gpif.c usrp_gpif.c usrp_gpif_inline.h [ 215s] /usr/bin/env: 'python': No such file or directory [ 215s] make[5]: *** [Makefile:523: usrp_gpif.c] Error 127 [ 215s] make[5]: Leaving directory '/usr/src/packages/BUILD/firmware/src/common' [ 215s] make[4]: *** [Makefile:405: all-recursive] Error 1 [ 215s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/src' [ 215s] make[3]: *** [Makefile:405: all-recursive] Error 1 [ 215s] make[3]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 215s] make[2]: *** [Makefile:626: all-recursive] Error 1 [ 215s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 215s] make[1]: *** [Makefile:547: all] Error 2 [ 215s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 215s] dh_auto_build: error: make -j1 returned exit code 2 [ 215s] make: *** [debian/rules:13: build] Error 25 [ 215s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 215s] ### VM INTERACTION START ### [ 219s] [ 204.976788] sysrq: SysRq : Power Off [ 219s] [ 204.984714] reboot: Power down [ 219s] ### VM INTERACTION END ### [ 219s] [ 219s] lamb25 failed "build libusrp_3.4.4.dsc" at Sun Jun 7 16:06:52 UTC 2020. [ 219s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libusrp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 218s] touch libfx2.lib [ 218s] for obj in delay.rel fx2utils.rel i2c.rel isr.rel timer.rel usb_common.rel; do basename $obj .rel >> libfx2.lib ; done [ 218s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/lib' [ 218s] Making all in src [ 218s] make[4]: Entering directory '/usr/src/packages/BUILD/firmware/src' [ 218s] Making all in common [ 218s] make[5]: Entering directory '/usr/src/packages/BUILD/firmware/src/common' [ 218s] srcdir=. ./edit-gpif ./gpif.c usrp_gpif.c usrp_gpif_inline.h [ 218s] /usr/bin/env: 'python': No such file or directory [ 218s] make[5]: *** [Makefile:523: usrp_gpif.c] Error 127 [ 218s] make[5]: Leaving directory '/usr/src/packages/BUILD/firmware/src/common' [ 218s] make[4]: *** [Makefile:405: all-recursive] Error 1 [ 218s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/src' [ 218s] make[3]: *** [Makefile:405: all-recursive] Error 1 [ 218s] make[3]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 218s] make[2]: *** [Makefile:635: all-recursive] Error 1 [ 218s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 218s] make[1]: *** [Makefile:554: all] Error 2 [ 218s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 218s] dh_auto_build: error: make -j1 returned exit code 2 [ 218s] make: *** [debian/rules:13: build] Error 25 [ 218s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 218s] ### VM INTERACTION START ### [ 221s] [ 203.123558] sysrq: SysRq : Power Off [ 221s] [ 203.130739] reboot: Power down [ 221s] ### VM INTERACTION END ### [ 221s] [ 221s] lamb54 failed "build libusrp_3.4.4.7.50ce.dsc" at Sun Jun 7 16:07:18 UTC 2020. [ 221s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/open5gs in Debian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/armv7l Package network:osmocom:nightly/open5gs failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 1281s] [1927/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/nudr-handler.c.o' -MF 'src/udr/e340f29@@udr@sta/nudr-handler.c.o.d' -o 'src/udr/e340f29@@udr@sta/nudr-handler.c.o' -c ../src/udr/nudr-handler.c [ 1282s] [1928/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/sbi-path.c.o' -MF 'src/udr/e340f29@@udr@sta/sbi-path.c.o.d' -o 'src/udr/e340f29@@udr@sta/sbi-path.c.o' -c ../src/udr/sbi-path.c [ 1283s] [1929/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/udr-sm.c.o' -MF 'src/udr/e340f29@@udr@sta/udr-sm.c.o.d' -o 'src/udr/e340f29@@udr@sta/udr-sm.c.o' -c ../src/udr/udr-sm.c [ 1283s] [1930/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib
Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: fix: properly start virtphy
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/docker-playground/+/18709 ) Change subject: ttcn3-bts-test/jenkins.sh: fix: properly start virtphy .. ttcn3-bts-test/jenkins.sh: fix: properly start virtphy Change-Id: I2c92ca7d8839a5e141a756f0e1ca26f5f27ca143 --- M ttcn3-bts-test/jenkins.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/09/18709/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18709 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2c92ca7d8839a5e141a756f0e1ca26f5f27ca143 Gerrit-Change-Number: 18709 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-MessageType: newpatchset
Build failure of network:osmocom:nightly/open5gs in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Raspbian_10/armv7l Package network:osmocom:nightly/open5gs failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 412s] [1931/2112] cc -Isrc/udm/3eca12a@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udm/3eca12a@@udm@sta/timer.c.o' -MF 'src/udm/3eca12a@@udm@sta/timer.c.o.d' -o 'src/udm/3eca12a@@udm@sta/timer.c.o' -c ../src/udm/timer.c [ 412s] [1932/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/udr-sm.c.o' -MF 'src/udr/e340f29@@udr@sta/udr-sm.c.o.d' -o 'src/udr/e340f29@@udr@sta/udr-sm.c.o' -c ../src/udr/udr-sm.c [ 412s] [1933/2112] rm -f src/udr/libudr.a && gcc-ar csrD src/udr/libudr.a 'src/udr/e340f29@@udr@sta/context.c.o' 'src/udr/e340f29@@udr@sta/event.c.o' 'src/udr/e340f29@@udr@sta/timer.c.o' 'src/udr/e340f29@@udr@sta/nnrf-handler.c.o' 'src/udr/e340f29@@udr@sta/nf-sm.c.o' 'src/udr/e340f29@@udr@sta/nudr-handler.c.o' 'src/udr/e340f29@@udr@sta/sbi-path.c.o' 'src/udr/e340f29@@udr@sta/udr-sm.c.o' 'src/udr/e340f29@@udr@sta/init.c.o' [ 412s] [1934/2112] cc -Isrc/udm/3eca12a@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ
Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: fix: properly start virtphy
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/docker-playground/+/18709 )
Change subject: ttcn3-bts-test/jenkins.sh: fix: properly start virtphy
..
ttcn3-bts-test/jenkins.sh: fix: properly start virtphy
Change-Id: I2c92ca7d8839a5e141a756f0e1ca26f5f27ca143
---
M ttcn3-bts-test/jenkins.sh
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground
refs/changes/09/18709/1
diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh
index 4974a34..97770e8 100755
--- a/ttcn3-bts-test/jenkins.sh
+++ b/ttcn3-bts-test/jenkins.sh
@@ -77,7 +77,6 @@
--name ${BUILD_TAG}-virtphy -d \
$DOCKER_ARGS \
$REPO_USER/osmocom-bb-host-master \
- virtphy -s /data/unix/osmocom_l2
/bin/sh -c "virtphy -s /data/unix/osmocom_l2
>>/data/virtphy.log 2>&1"
}
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18709
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I2c92ca7d8839a5e141a756f0e1ca26f5f27ca143
Gerrit-Change-Number: 18709
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-bts[master]: scheduler: fix trx_sched_set_lchan(): send TRXC HANDOVER
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/18708 ) Change subject: scheduler: fix trx_sched_set_lchan(): send TRXC HANDOVER .. scheduler: fix trx_sched_set_lchan(): send TRXC HANDOVER The purpose of TRXC [NO]HANDOVER commands is to control handover detection in transceiver. By default, handover detection is enabled on all inactive channels. As soon as the BSC activates a logical channel, osmo-bts-trx needs to send TRXC NOHANDOVER to the transceiver, so handover detection is disabled for that channel. As soon as a logical channel is deactivated, osmo-bts-trx needs to send TRXC HANDOVER to the transceiver, so handover detection is activated again. As it turns out, osmo-bts-trx never sends TRXC HANDOVER command to the transceiver. Instead, TRXC NOHANDOVER is being sent twice. The culprit is trx_sched_set_lchan(): for some reason it sends TRXC NOHANDOVER on channel deactivation, while it's supposed to send TRXC HANDOVER instead. Let's fix this. Interestingly enough, in some rare cases this bug triggers another bug (see OS#4586), causing a memory leak in trx_ctrl_cmd_cb(). Change-Id: Ia106baafc1b7fafb36f11ca378a285d71d1df5a3 Related: OS#4592, OS#4586 --- M src/common/scheduler.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/08/18708/1 diff --git a/src/common/scheduler.c b/src/common/scheduler.c index 5b398d1..bdd5387 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -1003,9 +1003,9 @@ } } - /* disable handover detection (on deactivation) */ + /* enable handover detection on deactivation */ if (!active) - _sched_act_rach_det(l1t, tn, ss, 0); + _sched_act_rach_det(l1t, tn, ss, 1); return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia106baafc1b7fafb36f11ca378a285d71d1df5a3 Gerrit-Change-Number: 18708 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in libosmocore[master]: NS: Optionally disable NS-{RESET, BLOCK, UNBLOCK} when using UDP/IP
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/18706
to look at the new patch set (#2).
Change subject: NS: Optionally disable NS-{RESET,BLOCK,UNBLOCK} when using
UDP/IP
..
NS: Optionally disable NS-{RESET,BLOCK,UNBLOCK} when using UDP/IP
3GPP TS 48.016 is quite clear in that no NS-{RESET,BLOCK,UNBLOCK}
procedures shalle be used over an IP based transport. They are only
for use in Frame Relay based transport.
However, as libosmogb was first developed against ip.access nanoBTS,
and their Gb implementation mandates those procedures, we
unconditionally implemented those procedures back then. Let's
give the user the option of disabling this behavior to become
more spec compliant (and interoperate with more other vendors out
there).
Change-Id: Ic4eba1b4dcbeac00f5879db295e0a9f1a50f71d8
---
M include/osmocom/gprs/gprs_ns.h
M src/gb/gprs_ns.c
M src/gb/gprs_ns_vty.c
3 files changed, 57 insertions(+), 24 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/18706/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18706
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic4eba1b4dcbeac00f5879db295e0a9f1a50f71d8
Gerrit-Change-Number: 18706
Gerrit-PatchSet: 2
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Change in libosmocore[master]: NS: replace use of gprs_nsvc_create() with gprs_nsvc_crate2()
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/18707 )
Change subject: NS: replace use of gprs_nsvc_create() with gprs_nsvc_crate2()
..
NS: replace use of gprs_nsvc_create() with gprs_nsvc_crate2()
Change-Id: I2b10e1707b0976b685d1c14016481d5565888150
---
M TODO-RELEASE
M include/osmocom/gprs/gprs_ns.h
M src/gb/gprs_ns.c
M src/gb/gprs_ns_vty.c
M src/gb/libosmogb.map
5 files changed, 7 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/07/18707/1
diff --git a/TODO-RELEASE b/TODO-RELEASE
index a6ed730..c9d9c56 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -11,3 +11,4 @@
simAPI/ABI change new osim_file_desc_find_aid()
simAPI/ABI change all over the place
gsmnew API new osmo_bts_unset_feature()
+gb API/ABI change deprecate gprs_nsvc_crate(); export
gprs_nsvc_create2()
diff --git a/include/osmocom/gprs/gprs_ns.h b/include/osmocom/gprs/gprs_ns.h
index 94d3036..65c7df3 100644
--- a/include/osmocom/gprs/gprs_ns.h
+++ b/include/osmocom/gprs/gprs_ns.h
@@ -197,7 +197,6 @@
/* Listen for incoming GPRS packets via NS/FR/GRE */
int gprs_ns_frgre_listen(struct gprs_ns_inst *nsi);
-struct gprs_nsvc *gprs_nsvc_create(struct gprs_ns_inst *nsi, uint16_t nsvci);
struct gprs_nsvc *gprs_nsvc_create2(struct gprs_ns_inst *nsi, uint16_t nsvci,
uint8_t sig_weight, uint8_t data_weight);
void gprs_nsvc_delete(struct gprs_nsvc *nsvc);
diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c
index f1b36f4..14fe661 100644
--- a/src/gb/gprs_ns.c
+++ b/src/gb/gprs_ns.c
@@ -347,12 +347,6 @@
return nsvc;
}
-/*! Old API for creating a NS-VC. Uses gprs_nsvc_create2 with fixed weights. */
-struct gprs_nsvc *gprs_nsvc_create(struct gprs_ns_inst *nsi, uint16_t nsvci)
-{
- return gprs_nsvc_create2(nsi, nsvci, 1, 1);
-}
-
/*! Delete given NS-VC
* \param[in] nsvc gprs_nsvc to be deleted
*/
@@ -1269,7 +1263,7 @@
nsvci, (*nsvc)->nsvci,
gprs_ns_ll_str(*nsvc));
orig_nsvc = *nsvc;
- *nsvc = gprs_nsvc_create((*nsvc)->nsi, nsvci);
+ *nsvc = gprs_nsvc_create2((*nsvc)->nsi, nsvci, 1, 1);
(*nsvc)->nsei = nsei;
}
}
@@ -1691,7 +1685,7 @@
* simply have changed addresses, or it is a SGSN */
existing_nsvc = gprs_nsvc_by_nsvci(nsi, nsvci);
if (!existing_nsvc) {
- *new_nsvc = gprs_nsvc_create(nsi, 0x);
+ *new_nsvc = gprs_nsvc_create2(nsi, 0x, 1, 1);
(*new_nsvc)->nsvci_is_valid = 0;
log_set_context(LOG_CTX_GB_NSVC, *new_nsvc);
gprs_ns_ll_copy(*new_nsvc, fallback_nsvc);
@@ -1914,7 +1908,7 @@
/* Create the dummy NSVC that we use for sending
* messages to non-existant/unknown NS-VC's */
- nsi->unknown_nsvc = gprs_nsvc_create(nsi, 0xfffe);
+ nsi->unknown_nsvc = gprs_nsvc_create2(nsi, 0xfffe, 1, 1);
nsi->unknown_nsvc->nsvci_is_valid = 0;
llist_del(>unknown_nsvc->list);
INIT_LLIST_HEAD(>unknown_nsvc->list);
@@ -2155,7 +2149,7 @@
nsvc = gprs_nsvc_by_rem_addr(nsi, dest);
if (!nsvc)
- nsvc = gprs_nsvc_create(nsi, nsvci);
+ nsvc = gprs_nsvc_create2(nsi, nsvci, 1, 1);
nsvc->ip.bts_addr = *dest;
nsvc->nsei = nsei;
nsvc->remote_end_is_sgsn = 1;
diff --git a/src/gb/gprs_ns_vty.c b/src/gb/gprs_ns_vty.c
index bd53f2f..38d4393 100644
--- a/src/gb/gprs_ns_vty.c
+++ b/src/gb/gprs_ns_vty.c
@@ -292,7 +292,7 @@
nsvc = gprs_nsvc_by_nsei(vty_nsi, nsei);
if (!nsvc) {
- nsvc = gprs_nsvc_create(vty_nsi, nsvci);
+ nsvc = gprs_nsvc_create2(vty_nsi, nsvci, 1, 1);
nsvc->nsei = nsei;
}
nsvc->nsvci = nsvci;
diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map
index ad139c1..b29ecb9 100644
--- a/src/gb/libosmogb.map
+++ b/src/gb/libosmogb.map
@@ -70,7 +70,7 @@
gprs_ns_ll_clear;
gprs_ns_msgb_alloc;
-gprs_nsvc_create;
+gprs_nsvc_create2;
gprs_nsvc_delete;
gprs_nsvc_reset;
gprs_nsvc_by_nsvci;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18707
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2b10e1707b0976b685d1c14016481d5565888150
Gerrit-Change-Number: 18707
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
