Build failure of network:osmocom:latest/libdbi in CentOS_8_Stream/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libdbi/CentOS_8_Stream/aarch64 Package network:osmocom:latest/libdbi failed to build in CentOS_8_Stream/aarch64 Check out the package for editing: osc checkout network:osmocom:latest libdbi Last lines of build log: [ 406s] [365/392] installing device-mapper-8:1.02.169-3.el8 [ 407s] [366/392] installing gpm-1.20.7-15.el8 [ 409s] [367/392] installing systemd-pam-239-31.el8_2.2 [ 410s] [368/392] installing perl-Pod-Checker-4:1.73-395.el8 [ 411s] [369/392] installing perl-Pod-Html-1.22.02-416.el8 [ 412s] [370/392] installing unbound-libs-1.7.3-14.el8 [ 414s] [371/392] installing perl-CPAN-Meta-2.150010-396.el8 [ 415s] [372/392] installing automake-1.16.1-6.el8 [ 417s] [373/392] installing initscripts-10.00.6-1.el8_2.2 [ 418s] [374/392] installing policycoreutils-2.9-9.el8 [ 420s] [375/392] installing rpm-libs-4.14.2-37.el8 [ 421s] [376/392] installing perl-ExtUtils-MakeMaker-1:7.34-1.el8 [ 422s] [377/392] installing perl-libnetcfg-4:5.26.3-416.el8 [ 423s] [378/392] installing libtool-2.4.6-25.el8 [ 425s] [379/392] installing perl-ExtUtils-Install-2.14-4.el8 [ 426s] [380/392] installing gnutls-dane-3.6.14-6.el8 [ 427s] [381/392] installing rpm-build-libs-4.14.2-37.el8 [ 429s] [382/392] installing redhat-rpm-config-123-1.el8 [ 430s] [383/392] installing perl-inc-latest-2:0.500-9.el8 [ 430s] [384/392] installing gnutls-devel-3.6.14-6.el8 [ 431s]file /usr/lib64/.libgnutls.so.30.hmac from install of gnutls-devel-3.6.14-6.el8.aarch64 conflicts with file from package gnutls-3.6.8-11.el8_2.aarch64 [ 431s] exit ... [ 431s] ### VM INTERACTION START ### [ 432s] Powering off. [ 432s] [ 349.414265] reboot: Power down [ 432s] ### VM INTERACTION END ### [ 432s] [ 432s] obs-arm-1 failed "build libdbi.spec" at Thu Oct 8 01:40:46 UTC 2020. [ 432s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/orcania in CentOS_8_Stream/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/orcania/CentOS_8_Stream/aarch64 Package network:osmocom:latest/orcania failed to build in CentOS_8_Stream/aarch64 Check out the package for editing: osc checkout network:osmocom:latest orcania Last lines of build log: [ 161s] [364/391] installing systemd-pam-239-31.el8_2.2 [ 161s] [365/391] installing perl-Pod-Checker-4:1.73-395.el8 [ 161s] [366/391] installing perl-Pod-Html-1.22.02-416.el8 [ 162s] [367/391] installing unbound-libs-1.7.3-14.el8 [ 163s] [368/391] installing perl-CPAN-Meta-2.150010-396.el8 [ 163s] [369/391] installing automake-1.16.1-6.el8 [ 164s] [370/391] installing initscripts-10.00.6-1.el8_2.2 [ 165s] [371/391] installing policycoreutils-2.9-9.el8 [ 165s] [372/391] installing rpm-libs-4.14.2-37.el8 [ 166s] [373/391] installing perl-ExtUtils-MakeMaker-1:7.34-1.el8 [ 167s] [374/391] installing perl-libnetcfg-4:5.26.3-416.el8 [ 167s] [375/391] installing libtool-2.4.6-25.el8 [ 168s] [376/391] installing perl-ExtUtils-Install-2.14-4.el8 [ 168s] [377/391] installing gnutls-dane-3.6.14-6.el8 [ 169s] [378/391] installing cmake-3.18.2-7.el8 [ 171s] [379/391] installing rpm-build-libs-4.14.2-37.el8 [ 171s] [380/391] installing redhat-rpm-config-123-1.el8 [ 172s] [381/391] installing cmake-data-3.18.2-7.el8 [ 173s] [382/391] installing perl-inc-latest-2:0.500-9.el8 [ 173s] [383/391] installing gnutls-devel-3.6.14-6.el8 [ 173s]file /usr/lib64/.libgnutls.so.30.hmac from install of gnutls-devel-3.6.14-6.el8.aarch64 conflicts with file from package gnutls-3.6.8-11.el8_2.aarch64 [ 173s] exit ... [ 173s] ### VM INTERACTION START ### [ 175s] Powering off. [ 175s] [ 152.096858] reboot: Power down [ 175s] ### VM INTERACTION END ### [ 175s] [ 175s] obs-arm-9 failed "build orcania.spec" at Thu Oct 8 01:38:37 UTC 2020. [ 175s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 124s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 125s] [COMPILING libboard/qmod/source/card_pres.c] [ 125s] [COMPILING libboard/qmod/source/wwan_led.c] [ 125s] [COMPILING libboard/qmod/source/i2c.c] [ 125s] [COMPILING libboard/qmod/source/board_qmod.c] [ 125s] [COMPILING apps/dfu/main.c] [ 125s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 125s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 125s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 126s] Memory region Used Size Region Size %age Used [ 126s] rom: 16588 B16 KB101.25% [ 126s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 126s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 204 bytes [ 126s] collect2: error: ld returned 1 exit status [ 126s] % [ 126s] make[2]: *** [Makefile:234: flash] Error 1 [ 126s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 126s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 126s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 126s] dh_auto_build: error: make -j1 returned exit code 2 [ 126s] make: *** [debian/rules:16: build] Error 25 [ 126s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 126s] ### VM INTERACTION START ### [ 129s] [ 119.632030] sysrq: Power Off [ 129s] [ 119.636567] reboot: Power down [ 129s] ### VM INTERACTION END ### [ 129s] [ 129s] sheep88 failed "build simtrace2_0.7.0.63.39070.dsc" at Thu Oct 8 01:37:43 UTC 2020. [ 129s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/libunwind in CentOS_8_Stream/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libunwind/CentOS_8_Stream/aarch64 Package network:osmocom:latest/libunwind failed to build in CentOS_8_Stream/aarch64 Check out the package for editing: osc checkout network:osmocom:latest libunwind Last lines of build log: -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/libsodium in CentOS_8_Stream/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libsodium/CentOS_8_Stream/aarch64 Package network:osmocom:latest/libsodium failed to build in CentOS_8_Stream/aarch64 Check out the package for editing: osc checkout network:osmocom:latest libsodium Last lines of build log: [ 168s] [359/386] installing device-mapper-8:1.02.169-3.el8 [ 169s] [360/386] installing gpm-1.20.7-15.el8 [ 170s] [361/386] installing systemd-pam-239-31.el8_2.2 [ 170s] [362/386] installing perl-Pod-Checker-4:1.73-395.el8 [ 171s] [363/386] installing perl-Pod-Html-1.22.02-416.el8 [ 172s] [364/386] installing unbound-libs-1.7.3-14.el8 [ 172s] [365/386] installing perl-CPAN-Meta-2.150010-396.el8 [ 173s] [366/386] installing automake-1.16.1-6.el8 [ 173s] [367/386] installing initscripts-10.00.6-1.el8_2.2 [ 174s] [368/386] installing policycoreutils-2.9-9.el8 [ 174s] [369/386] installing rpm-libs-4.14.2-37.el8 [ 175s] [370/386] installing perl-ExtUtils-MakeMaker-1:7.34-1.el8 [ 176s] [371/386] installing perl-libnetcfg-4:5.26.3-416.el8 [ 176s] [372/386] installing libtool-2.4.6-25.el8 [ 177s] [373/386] installing perl-ExtUtils-Install-2.14-4.el8 [ 178s] [374/386] installing gnutls-dane-3.6.14-6.el8 [ 178s] [375/386] installing rpm-build-libs-4.14.2-37.el8 [ 179s] [376/386] installing redhat-rpm-config-123-1.el8 [ 179s] [377/386] installing perl-inc-latest-2:0.500-9.el8 [ 179s] [378/386] installing gnutls-devel-3.6.14-6.el8 [ 179s]file /usr/lib64/.libgnutls.so.30.hmac from install of gnutls-devel-3.6.14-6.el8.aarch64 conflicts with file from package gnutls-3.6.8-11.el8_2.aarch64 [ 179s] exit ... [ 179s] ### VM INTERACTION START ### [ 181s] Powering off. [ 181s] [ 157.454200] reboot: Power down [ 181s] ### VM INTERACTION END ### [ 181s] [ 181s] obs-arm-9 failed "build libsodium.spec" at Thu Oct 8 01:35:37 UTC 2020. [ 181s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/orcania in CentOS_8_Stream/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/orcania/CentOS_8_Stream/aarch64 Package network:osmocom:latest/orcania failed to build in CentOS_8_Stream/aarch64 Check out the package for editing: osc checkout network:osmocom:latest orcania Last lines of build log: [ 173s] [364/391] installing systemd-pam-239-31.el8_2.2 [ 174s] [365/391] installing perl-Pod-Checker-4:1.73-395.el8 [ 174s] [366/391] installing perl-Pod-Html-1.22.02-416.el8 [ 174s] [367/391] installing unbound-libs-1.7.3-14.el8 [ 175s] [368/391] installing perl-CPAN-Meta-2.150010-396.el8 [ 176s] [369/391] installing automake-1.16.1-6.el8 [ 176s] [370/391] installing initscripts-10.00.6-1.el8_2.2 [ 177s] [371/391] installing policycoreutils-2.9-9.el8 [ 178s] [372/391] installing rpm-libs-4.14.2-37.el8 [ 179s] [373/391] installing perl-ExtUtils-MakeMaker-1:7.34-1.el8 [ 179s] [374/391] installing perl-libnetcfg-4:5.26.3-416.el8 [ 180s] [375/391] installing libtool-2.4.6-25.el8 [ 181s] [376/391] installing perl-ExtUtils-Install-2.14-4.el8 [ 181s] [377/391] installing gnutls-dane-3.6.14-6.el8 [ 182s] [378/391] installing cmake-3.18.2-7.el8 [ 184s] [379/391] installing rpm-build-libs-4.14.2-37.el8 [ 185s] [380/391] installing redhat-rpm-config-123-1.el8 [ 185s] [381/391] installing cmake-data-3.18.2-7.el8 [ 186s] [382/391] installing perl-inc-latest-2:0.500-9.el8 [ 187s] [383/391] installing gnutls-devel-3.6.14-6.el8 [ 187s]file /usr/lib64/.libgnutls.so.30.hmac from install of gnutls-devel-3.6.14-6.el8.aarch64 conflicts with file from package gnutls-3.6.8-11.el8_2.aarch64 [ 187s] exit ... [ 187s] ### VM INTERACTION START ### [ 188s] Powering off. [ 188s] [ 165.100485] reboot: Power down [ 189s] ### VM INTERACTION END ### [ 189s] [ 189s] obs-arm-9 failed "build orcania.spec" at Thu Oct 8 01:34:55 UTC 2020. [ 189s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libgtpnl in CentOS_8_Stream/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/CentOS_8_Stream/aarch64 Package network:osmocom:nightly/libgtpnl failed to build in CentOS_8_Stream/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libgtpnl Last lines of build log: [ 240s] [361/388] installing device-mapper-8:1.02.169-3.el8 [ 241s] [362/388] installing gpm-1.20.7-15.el8 [ 242s] [363/388] installing systemd-pam-239-31.el8_2.2 [ 243s] [364/388] installing perl-Pod-Checker-4:1.73-395.el8 [ 244s] [365/388] installing perl-Pod-Html-1.22.02-416.el8 [ 244s] [366/388] installing unbound-libs-1.7.3-14.el8 [ 245s] [367/388] installing perl-CPAN-Meta-2.150010-396.el8 [ 246s] [368/388] installing automake-1.16.1-6.el8 [ 248s] [369/388] installing initscripts-10.00.6-1.el8_2.2 [ 248s] [370/388] installing policycoreutils-2.9-9.el8 [ 250s] [371/388] installing rpm-libs-4.14.2-37.el8 [ 250s] [372/388] installing perl-ExtUtils-MakeMaker-1:7.34-1.el8 [ 251s] [373/388] installing perl-libnetcfg-4:5.26.3-416.el8 [ 252s] [374/388] installing libtool-2.4.6-25.el8 [ 253s] [375/388] installing perl-ExtUtils-Install-2.14-4.el8 [ 254s] [376/388] installing gnutls-dane-3.6.14-6.el8 [ 254s] [377/388] installing rpm-build-libs-4.14.2-37.el8 [ 255s] [378/388] installing redhat-rpm-config-123-1.el8 [ 256s] [379/388] installing perl-inc-latest-2:0.500-9.el8 [ 257s] [380/388] installing gnutls-devel-3.6.14-6.el8 [ 257s]file /usr/lib64/.libgnutls.so.30.hmac from install of gnutls-devel-3.6.14-6.el8.aarch64 conflicts with file from package gnutls-3.6.8-11.el8_2.aarch64 [ 257s] exit ... [ 257s] ### VM INTERACTION START ### [ 258s] Powering off. [ 258s] [ 221.807446] reboot: Power down [ 258s] ### VM INTERACTION END ### [ 258s] [ 258s] obs-arm-3 failed "build libgtpnl.spec" at Thu Oct 8 01:34:19 UTC 2020. [ 258s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/libunwind in CentOS_8_Stream/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libunwind/CentOS_8_Stream/aarch64 Package network:osmocom:latest/libunwind failed to build in CentOS_8_Stream/aarch64 Check out the package for editing: osc checkout network:osmocom:latest libunwind Last lines of build log: [ 171s] [361/388] installing device-mapper-8:1.02.169-3.el8 [ 172s] [362/388] installing gpm-1.20.7-15.el8 [ 172s] [363/388] installing systemd-pam-239-31.el8_2.2 [ 173s] [364/388] installing perl-Pod-Checker-4:1.73-395.el8 [ 174s] [365/388] installing perl-Pod-Html-1.22.02-416.el8 [ 174s] [366/388] installing unbound-libs-1.7.3-14.el8 [ 175s] [367/388] installing perl-CPAN-Meta-2.150010-396.el8 [ 175s] [368/388] installing automake-1.16.1-6.el8 [ 176s] [369/388] installing initscripts-10.00.6-1.el8_2.2 [ 177s] [370/388] installing policycoreutils-2.9-9.el8 [ 177s] [371/388] installing rpm-libs-4.14.2-37.el8 [ 178s] [372/388] installing perl-ExtUtils-MakeMaker-1:7.34-1.el8 [ 178s] [373/388] installing perl-libnetcfg-4:5.26.3-416.el8 [ 179s] [374/388] installing libtool-2.4.6-25.el8 [ 180s] [375/388] installing perl-ExtUtils-Install-2.14-4.el8 [ 180s] [376/388] installing gnutls-dane-3.6.14-6.el8 [ 180s] [377/388] installing rpm-build-libs-4.14.2-37.el8 [ 181s] [378/388] installing redhat-rpm-config-123-1.el8 [ 182s] [379/388] installing perl-inc-latest-2:0.500-9.el8 [ 182s] [380/388] installing gnutls-devel-3.6.14-6.el8 [ 182s]file /usr/lib64/.libgnutls.so.30.hmac from install of gnutls-devel-3.6.14-6.el8.aarch64 conflicts with file from package gnutls-3.6.8-11.el8_2.aarch64 [ 182s] exit ... [ 182s] ### VM INTERACTION START ### [ 183s] Powering off. [ 183s] [ 161.905582] reboot: Power down [ 184s] ### VM INTERACTION END ### [ 184s] [ 184s] obs-arm-8 failed "build libunwind.spec" at Thu Oct 8 01:33:47 UTC 2020. [ 184s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/libdbi in CentOS_8_Stream/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libdbi/CentOS_8_Stream/aarch64 Package network:osmocom:latest/libdbi failed to build in CentOS_8_Stream/aarch64 Check out the package for editing: osc checkout network:osmocom:latest libdbi Last lines of build log: [ 174s] [365/392] installing device-mapper-8:1.02.169-3.el8 [ 175s] [366/392] installing gpm-1.20.7-15.el8 [ 176s] [367/392] installing systemd-pam-239-31.el8_2.2 [ 176s] [368/392] installing perl-Pod-Checker-4:1.73-395.el8 [ 177s] [369/392] installing perl-Pod-Html-1.22.02-416.el8 [ 177s] [370/392] installing unbound-libs-1.7.3-14.el8 [ 178s] [371/392] installing perl-CPAN-Meta-2.150010-396.el8 [ 179s] [372/392] installing automake-1.16.1-6.el8 [ 180s] [373/392] installing initscripts-10.00.6-1.el8_2.2 [ 180s] [374/392] installing policycoreutils-2.9-9.el8 [ 181s] [375/392] installing rpm-libs-4.14.2-37.el8 [ 182s] [376/392] installing perl-ExtUtils-MakeMaker-1:7.34-1.el8 [ 182s] [377/392] installing perl-libnetcfg-4:5.26.3-416.el8 [ 183s] [378/392] installing libtool-2.4.6-25.el8 [ 183s] [379/392] installing perl-ExtUtils-Install-2.14-4.el8 [ 184s] [380/392] installing gnutls-dane-3.6.14-6.el8 [ 184s] [381/392] installing rpm-build-libs-4.14.2-37.el8 [ 185s] [382/392] installing redhat-rpm-config-123-1.el8 [ 185s] [383/392] installing perl-inc-latest-2:0.500-9.el8 [ 186s] [384/392] installing gnutls-devel-3.6.14-6.el8 [ 186s]file /usr/lib64/.libgnutls.so.30.hmac from install of gnutls-devel-3.6.14-6.el8.aarch64 conflicts with file from package gnutls-3.6.8-11.el8_2.aarch64 [ 186s] exit ... [ 186s] ### VM INTERACTION START ### [ 187s] Powering off. [ 187s] [ 163.933863] reboot: Power down [ 188s] ### VM INTERACTION END ### [ 188s] [ 188s] obs-arm-8 failed "build libdbi.spec" at Thu Oct 8 01:32:57 UTC 2020. [ 188s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libsmpp34 in CentOS_8_Stream/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsmpp34/CentOS_8_Stream/aarch64 Package network:osmocom:nightly/libsmpp34 failed to build in CentOS_8_Stream/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libsmpp34 Last lines of build log: [ 162s] [362/389] installing device-mapper-8:1.02.169-3.el8 [ 162s] [363/389] installing gpm-1.20.7-15.el8 [ 163s] [364/389] installing systemd-pam-239-31.el8_2.2 [ 164s] [365/389] installing perl-Pod-Checker-4:1.73-395.el8 [ 164s] [366/389] installing perl-Pod-Html-1.22.02-416.el8 [ 164s] [367/389] installing unbound-libs-1.7.3-14.el8 [ 165s] [368/389] installing perl-CPAN-Meta-2.150010-396.el8 [ 165s] [369/389] installing automake-1.16.1-6.el8 [ 166s] [370/389] installing initscripts-10.00.6-1.el8_2.2 [ 167s] [371/389] installing policycoreutils-2.9-9.el8 [ 167s] [372/389] installing rpm-libs-4.14.2-37.el8 [ 168s] [373/389] installing perl-ExtUtils-MakeMaker-1:7.34-1.el8 [ 168s] [374/389] installing perl-libnetcfg-4:5.26.3-416.el8 [ 169s] [375/389] installing libtool-2.4.6-25.el8 [ 169s] [376/389] installing perl-ExtUtils-Install-2.14-4.el8 [ 169s] [377/389] installing gnutls-dane-3.6.14-6.el8 [ 170s] [378/389] installing rpm-build-libs-4.14.2-37.el8 [ 170s] [379/389] installing redhat-rpm-config-123-1.el8 [ 171s] [380/389] installing perl-inc-latest-2:0.500-9.el8 [ 171s] [381/389] installing gnutls-devel-3.6.14-6.el8 [ 171s]file /usr/lib64/.libgnutls.so.30.hmac from install of gnutls-devel-3.6.14-6.el8.aarch64 conflicts with file from package gnutls-3.6.8-11.el8_2.aarch64 [ 171s] exit ... [ 171s] ### VM INTERACTION START ### [ 173s] Powering off. [ 173s] [ 148.872499] reboot: Power down [ 173s] ### VM INTERACTION END ### [ 173s] [ 173s] obs-arm-9 failed "build libsmpp34.spec" at Thu Oct 8 01:32:07 UTC 2020. [ 173s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmocore in CentOS_8_Stream/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/CentOS_8_Stream/aarch64 Package network:osmocom:nightly/libosmocore failed to build in CentOS_8_Stream/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 174s] [370/397] installing device-mapper-8:1.02.169-3.el8 [ 175s] [371/397] installing gpm-1.20.7-15.el8 [ 175s] [372/397] installing systemd-pam-239-31.el8_2.2 [ 176s] [373/397] installing perl-Pod-Checker-4:1.73-395.el8 [ 176s] [374/397] installing perl-Pod-Html-1.22.02-416.el8 [ 177s] [375/397] installing unbound-libs-1.7.3-14.el8 [ 177s] [376/397] installing perl-CPAN-Meta-2.150010-396.el8 [ 178s] [377/397] installing automake-1.16.1-6.el8 [ 178s] [378/397] installing initscripts-10.00.6-1.el8_2.2 [ 179s] [379/397] installing policycoreutils-2.9-9.el8 [ 179s] [380/397] installing rpm-libs-4.14.2-37.el8 [ 180s] [381/397] installing perl-ExtUtils-MakeMaker-1:7.34-1.el8 [ 180s] [382/397] installing perl-libnetcfg-4:5.26.3-416.el8 [ 181s] [383/397] installing libtool-2.4.6-25.el8 [ 181s] [384/397] installing perl-ExtUtils-Install-2.14-4.el8 [ 182s] [385/397] installing gnutls-dane-3.6.14-6.el8 [ 183s] [386/397] installing rpm-build-libs-4.14.2-37.el8 [ 184s] [387/397] installing redhat-rpm-config-123-1.el8 [ 184s] [388/397] installing perl-inc-latest-2:0.500-9.el8 [ 184s] [389/397] installing gnutls-devel-3.6.14-6.el8 [ 184s]file /usr/lib64/.libgnutls.so.30.hmac from install of gnutls-devel-3.6.14-6.el8.aarch64 conflicts with file from package gnutls-3.6.8-11.el8_2.aarch64 [ 184s] exit ... [ 185s] ### VM INTERACTION START ### [ 186s] Powering off. [ 186s] [ 164.374329] reboot: Power down [ 186s] ### VM INTERACTION END ### [ 186s] [ 186s] obs-arm-9 failed "build libosmocore.spec" at Thu Oct 8 01:32:03 UTC 2020. [ 186s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/orcania in CentOS_8_Stream/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/orcania/CentOS_8_Stream/aarch64 Package network:osmocom:latest/orcania failed to build in CentOS_8_Stream/aarch64 Check out the package for editing: osc checkout network:osmocom:latest orcania Last lines of build log: [ 167s] [364/391] installing systemd-pam-239-31.el8_2.2 [ 167s] [365/391] installing perl-Pod-Checker-4:1.73-395.el8 [ 168s] [366/391] installing perl-Pod-Html-1.22.02-416.el8 [ 168s] [367/391] installing unbound-libs-1.7.3-14.el8 [ 169s] [368/391] installing perl-CPAN-Meta-2.150010-396.el8 [ 169s] [369/391] installing automake-1.16.1-6.el8 [ 170s] [370/391] installing initscripts-10.00.6-1.el8_2.2 [ 171s] [371/391] installing policycoreutils-2.9-9.el8 [ 171s] [372/391] installing rpm-libs-4.14.2-37.el8 [ 172s] [373/391] installing perl-ExtUtils-MakeMaker-1:7.34-1.el8 [ 173s] [374/391] installing perl-libnetcfg-4:5.26.3-416.el8 [ 173s] [375/391] installing libtool-2.4.6-25.el8 [ 174s] [376/391] installing perl-ExtUtils-Install-2.14-4.el8 [ 174s] [377/391] installing gnutls-dane-3.6.14-6.el8 [ 174s] [378/391] installing cmake-3.18.2-7.el8 [ 177s] [379/391] installing rpm-build-libs-4.14.2-37.el8 [ 177s] [380/391] installing redhat-rpm-config-123-1.el8 [ 178s] [381/391] installing cmake-data-3.18.2-7.el8 [ 179s] [382/391] installing perl-inc-latest-2:0.500-9.el8 [ 179s] [383/391] installing gnutls-devel-3.6.14-6.el8 [ 179s]file /usr/lib64/.libgnutls.so.30.hmac from install of gnutls-devel-3.6.14-6.el8.aarch64 conflicts with file from package gnutls-3.6.8-11.el8_2.aarch64 [ 179s] exit ... [ 179s] ### VM INTERACTION START ### [ 180s] Powering off. [ 180s] [ 155.789019] reboot: Power down [ 181s] ### VM INTERACTION END ### [ 181s] [ 181s] obs-arm-9 failed "build orcania.spec" at Thu Oct 8 01:30:53 UTC 2020. [ 181s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/libsodium in CentOS_8_Stream/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libsodium/CentOS_8_Stream/aarch64 Package network:osmocom:latest/libsodium failed to build in CentOS_8_Stream/aarch64 Check out the package for editing: osc checkout network:osmocom:latest libsodium Last lines of build log: [ 169s] [359/386] installing device-mapper-8:1.02.169-3.el8 [ 170s] [360/386] installing gpm-1.20.7-15.el8 [ 170s] [361/386] installing systemd-pam-239-31.el8_2.2 [ 171s] [362/386] installing perl-Pod-Checker-4:1.73-395.el8 [ 171s] [363/386] installing perl-Pod-Html-1.22.02-416.el8 [ 172s] [364/386] installing unbound-libs-1.7.3-14.el8 [ 172s] [365/386] installing perl-CPAN-Meta-2.150010-396.el8 [ 173s] [366/386] installing automake-1.16.1-6.el8 [ 174s] [367/386] installing initscripts-10.00.6-1.el8_2.2 [ 174s] [368/386] installing policycoreutils-2.9-9.el8 [ 175s] [369/386] installing rpm-libs-4.14.2-37.el8 [ 176s] [370/386] installing perl-ExtUtils-MakeMaker-1:7.34-1.el8 [ 176s] [371/386] installing perl-libnetcfg-4:5.26.3-416.el8 [ 177s] [372/386] installing libtool-2.4.6-25.el8 [ 178s] [373/386] installing perl-ExtUtils-Install-2.14-4.el8 [ 178s] [374/386] installing gnutls-dane-3.6.14-6.el8 [ 179s] [375/386] installing rpm-build-libs-4.14.2-37.el8 [ 179s] [376/386] installing redhat-rpm-config-123-1.el8 [ 179s] [377/386] installing perl-inc-latest-2:0.500-9.el8 [ 180s] [378/386] installing gnutls-devel-3.6.14-6.el8 [ 180s]file /usr/lib64/.libgnutls.so.30.hmac from install of gnutls-devel-3.6.14-6.el8.aarch64 conflicts with file from package gnutls-3.6.8-11.el8_2.aarch64 [ 180s] exit ... [ 180s] ### VM INTERACTION START ### [ 182s] Powering off. [ 182s] [ 158.750249] reboot: Power down [ 182s] ### VM INTERACTION END ### [ 182s] [ 182s] obs-arm-8 failed "build libsodium.spec" at Thu Oct 8 01:31:41 UTC 2020. [ 182s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-bts[master]: OML: correct parse the NM_ATT_OSMO_NS_LINK_CFG field address_family
lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/20479 ) Change subject: OML: correct parse the NM_ATT_OSMO_NS_LINK_CFG field address_family .. OML: correct parse the NM_ATT_OSMO_NS_LINK_CFG field address_family The address_family is 8 bit and have a padding byte afterwards. By using osmo_load16be it's encoding it wrong and result in an empty/invalid NSVC configuration. Change-Id: Ie070b5745124d48e74a6dedd8903b74bfb3ce9d2 --- M src/common/oml.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/79/20479/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie070b5745124d48e74a6dedd8903b74bfb3ce9d2 Gerrit-Change-Number: 20479 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: OML: corect parse the NM_ATT_OSMO_NS_LINK_CFG
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/20479 )
Change subject: OML: corect parse the NM_ATT_OSMO_NS_LINK_CFG
..
OML: corect parse the NM_ATT_OSMO_NS_LINK_CFG
The address_family is 8 bit and have a padding byte afterwards.
By using osmo_load16be it's encoding it wrong and result in an empty/invalid
NSVC
configuration.
Change-Id: Ie070b5745124d48e74a6dedd8903b74bfb3ce9d2
---
M src/common/oml.c
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/79/20479/1
diff --git a/src/common/oml.c b/src/common/oml.c
index 1f74cac..5394e8a 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -1277,12 +1277,13 @@
if (TLVP_PRES_LEN(tp, NM_ATT_OSMO_NS_LINK_CFG, 10)) {
const uint8_t *cur = TLVP_VAL(tp, NM_ATT_OSMO_NS_LINK_CFG);
- uint16_t address_family;
+ uint8_t address_family;
memset(>local, 0, sizeof(nsvc->local));
memset(>remote, 0, sizeof(nsvc->remote));
- address_family = osmo_load16be(cur);
+ address_family = *cur;
+ /* 1byte padding */
cur += 2;
memcpy(>local.u.sin.sin_port, cur, 2);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20479
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie070b5745124d48e74a6dedd8903b74bfb3ce9d2
Gerrit-Change-Number: 20479
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in osmo-bts[master]: common/bts: set feature IPV6_NSVC
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/20478 )
Change subject: common/bts: set feature IPV6_NSVC
..
common/bts: set feature IPV6_NSVC
Since I310699fabbfec4255f0474f31717f215c1201eca the BTS
can decode NM_ATT_OSMO_NS_LINK_CFG. This OML attribute will be
only used if the OML feature IPV6_NSVC is present.
Change-Id: I9910f2afb3ab94167938b0fd356f2f0a8c382130
---
M src/common/bts.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/78/20478/1
diff --git a/src/common/bts.c b/src/common/bts.c
index c121609..5890c1a 100644
--- a/src/common/bts.c
+++ b/src/common/bts.c
@@ -344,6 +344,7 @@
/* features implemented in 'common', available for all models */
osmo_bts_set_feature(bts->features, BTS_FEAT_ETWS_PN);
+ osmo_bts_set_feature(bts->features, BTS_FEAT_IPV6_NSVC);
rc = bts_model_init(bts);
if (rc < 0) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20478
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I9910f2afb3ab94167938b0fd356f2f0a8c382130
Gerrit-Change-Number: 20478
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: sysmobts: expect feature IPV6_NSVC
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20477 ) Change subject: sysmobts: expect feature IPV6_NSVC .. sysmobts: expect feature IPV6_NSVC The IPV6_NSVC feature is required to use IPv6 NSVC to connect to the SGSN. Change-Id: I711efca931012b8e66516f2721390e9dbdbb72a8 --- M src/osmo-bsc/bts_sysmobts.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/77/20477/1 diff --git a/src/osmo-bsc/bts_sysmobts.c b/src/osmo-bsc/bts_sysmobts.c index d7d15eb..bef1275 100644 --- a/src/osmo-bsc/bts_sysmobts.c +++ b/src/osmo-bsc/bts_sysmobts.c @@ -60,6 +60,7 @@ osmo_bts_set_feature(_sysmobts.features, BTS_FEAT_GPRS); osmo_bts_set_feature(_sysmobts.features, BTS_FEAT_EGPRS); osmo_bts_set_feature(_sysmobts.features, BTS_FEAT_PAGING_COORDINATION); + osmo_bts_set_feature(_sysmobts.features, BTS_FEAT_IPV6_NSVC); model_sysmobts.nm_att_tlvdef.def[NM_ATT_OSMO_NS_LINK_CFG].type = TLV_TYPE_TL16V; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20477 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I711efca931012b8e66516f2721390e9dbdbb72a8 Gerrit-Change-Number: 20477 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange
Change in osmocom-bb[master]: layer23/cbch-sniff: fix: do not blindly assume presence of CBCH
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/20475 ) Change subject: layer23/cbch-sniff: fix: do not blindly assume presence of CBCH .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmocom-bb/+/20475/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/20475/1//COMMIT_MSG@9 PS1, Line 9: We cannot blindly assume that CBCH is present on TS0/SDCCH4 before > SO you are blindly assuming it's not present now? Is that a fix? The key point is that there are two ways to deal with CBCH: a) enable CBCH decoding task together with BCCH/SDCCH4 decoding tasks in the L1, so we stay on BCCH and get CBCH blocks together with CCCH/AGCH/PCH frames; b) treat CBCH like a dedicated channel and tune the L1 to it, so we receive CBCH frames only. The former only works if CBCH is allocated on C0/TS0. This application follows approach b), so even if there is CBCH on C0/TS0, it does not make sense to activate it in advance - we go to a dedicated channel anyway. Also, from my experience, CBCH on C0/TS0 is quite rare. Usually, it can be found on SDCCH8 (often hopping). -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie8ce572df292d0b03c0f743bcf26184619176321 Gerrit-Change-Number: 20475 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 21:10:38 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmocom-bb[master]: layer23/cbch-sniff: fix: use Osmocom specific RSL channel number
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/20476 ) Change subject: layer23/cbch-sniff: fix: use Osmocom specific RSL channel number .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20476 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib1d5c99587202a9d94aeb7b63de7ae8c4fb15af0 Gerrit-Change-Number: 20476 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 21:00:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: layer23/cbch-sniff: fix: do not blindly assume presence of CBCH
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/20475 ) Change subject: layer23/cbch-sniff: fix: do not blindly assume presence of CBCH .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmocom-bb/+/20475/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/20475/1//COMMIT_MSG@9 PS1, Line 9: We cannot blindly assume that CBCH is present on TS0/SDCCH4 before SO you are blindly assuming it's not present now? Is that a fix? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie8ce572df292d0b03c0f743bcf26184619176321 Gerrit-Change-Number: 20475 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 20:57:57 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmocom-bb[master]: layer23/cbch-sniff: fix: use Osmocom specific RSL channel number
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmocom-bb/+/20476 )
Change subject: layer23/cbch-sniff: fix: use Osmocom specific RSL channel number
..
layer23/cbch-sniff: fix: use Osmocom specific RSL channel number
This way the layer1 can activate proper CBCH task and send us
CBCH block with proper RSL channel number, so they do not end
up being routed to LAPDm and rejected there.
Change-Id: Ib1d5c99587202a9d94aeb7b63de7ae8c4fb15af0
---
M src/host/layer23/src/misc/app_cbch_sniff.c
1 file changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/76/20476/1
diff --git a/src/host/layer23/src/misc/app_cbch_sniff.c
b/src/host/layer23/src/misc/app_cbch_sniff.c
index 58b3324..ed85cef 100644
--- a/src/host/layer23/src/misc/app_cbch_sniff.c
+++ b/src/host/layer23/src/misc/app_cbch_sniff.c
@@ -34,6 +34,8 @@
#include
#include
+#include
+
#include
struct osmocom_ms *g_ms;
@@ -41,6 +43,8 @@
static int try_cbch(struct osmocom_ms *ms, struct gsm48_sysinfo *s)
{
+ uint8_t chan_nr;
+
if (!s->si1 || !s->si4)
return 0;
if (!s->chan_nr) {
@@ -48,6 +52,13 @@
return 0;
}
+ /* Convert received channel number to Osmocom specific one;
+* this way the layer1 can activate proper CBCH task. */
+ if (s->chan_nr != RSL_CHAN_SDCCH4_ACCH)
+ chan_nr = RSL_CHAN_OSMO_CBCH8 | (s->chan_nr & 0x07);
+ else
+ chan_nr = RSL_CHAN_OSMO_CBCH4;
+
if (s->h) {
LOGP(DRR, LOGL_INFO, "chan_nr = 0x%02x TSC = %d MAIO = %d "
"HSN = %d hseq (%d): %s\n",
@@ -56,13 +67,13 @@
osmo_hexdump((unsigned char *) s->hopping, s->hopp_len
* 2));
return l1ctl_tx_dm_est_req_h1(ms,
s->maio, s->hsn, s->hopping, s->hopp_len,
- s->chan_nr, s->tsc,
+ chan_nr, s->tsc,
GSM48_CMODE_SIGN, 0);
} else {
LOGP(DRR, LOGL_INFO, "chan_nr = 0x%02x TSC = %d ARFCN = %d\n",
s->chan_nr, s->tsc, s->arfcn);
return l1ctl_tx_dm_est_req_h0(ms, s->arfcn,
- s->chan_nr, s->tsc, GSM48_CMODE_SIGN, 0);
+ chan_nr, s->tsc, GSM48_CMODE_SIGN, 0);
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20476
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ib1d5c99587202a9d94aeb7b63de7ae8c4fb15af0
Gerrit-Change-Number: 20476
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Gerrit-MessageType: newchange
Change in osmocom-bb[master]: layer23/cbch-sniff: fix: do not blindly assume presence of CBCH
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/20475 ) Change subject: layer23/cbch-sniff: fix: do not blindly assume presence of CBCH .. layer23/cbch-sniff: fix: do not blindly assume presence of CBCH We cannot blindly assume that CBCH is present on TS0/SDCCH4 before decoding CBCH Channel Description in System Information Type 4. Change-Id: Ie8ce572df292d0b03c0f743bcf26184619176321 --- M src/host/layer23/src/misc/app_cbch_sniff.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/75/20475/1 diff --git a/src/host/layer23/src/misc/app_cbch_sniff.c b/src/host/layer23/src/misc/app_cbch_sniff.c index 1e9ef5c..58b3324 100644 --- a/src/host/layer23/src/misc/app_cbch_sniff.c +++ b/src/host/layer23/src/misc/app_cbch_sniff.c @@ -169,7 +169,7 @@ case S_L1CTL_FBSB_ERR: ms = g_ms; return l1ctl_tx_fbsb_req(ms, ms->test_arfcn, - L1CTL_FBSB_F_FB01SB, 100, 0, CCCH_MODE_COMBINED_CBCH, + L1CTL_FBSB_F_FB01SB, 100, 0, CCCH_MODE_COMBINED, dbm2rxlev(-85)); case S_L1CTL_FBSB_RESP: return 0; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie8ce572df292d0b03c0f743bcf26184619176321 Gerrit-Change-Number: 20475 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-MessageType: newchange
Change in osmocom-bb[master]: firmware: implement reading of factory RF calibration values
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/12887 ) Change subject: firmware: implement reading of factory RF calibration values .. Patch Set 7: Code-Review+2 No regressions observed during testing, LGTM! -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/12887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icf2693b751d86ec1d2563412d606c13d4c91a806 Gerrit-Change-Number: 12887 Gerrit-PatchSet: 7 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-Comment-Date: Wed, 07 Oct 2020 20:26:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: logging: introduce experimental 'systemd-journal' target
Hello Jenkins Builder, neels, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/20045 to look at the new patch set (#5). Change subject: logging: introduce experimental 'systemd-journal' target .. logging: introduce experimental 'systemd-journal' target This change implements 'systemd-journal' logging target, that is similar to the existing 'syslog' target. The key difference is that 'systemd-journal' allows us to offload rendering of the meta information, such as location (file name, line number), subsystem, and logging level, to systemd. Moreover, we can attach arbitrary, user-specific fields [1] to the logging messages, so they can be used for advanced log filtering (e.g. by IMSI/TMSI/TLLI): $ journalctl OSMO_SUBSYS=DMSC -f Since we don't want to make libsystemd a required dependency, this feature is optional, and needs to be enabled at build-time: $ ./configure --enable-systemd-logging The new logging target can be configured in the same way as any other one - via the VTY interface, or using the configuration file: log systemd-journal [raw] logging level set-all notice logging filter all 1 Two logging handlers are available: generic and raw. The first one behaves similarly to both 'syslog' and 'stderr', i.e. all the meta information is rendered by libosmocore itself, and then passed to systemd together with the logging message. The later is more like the 'gsmtap' target, so all available meta information is handed over to systemd in form of fields [1]: - CODE_FILE / CODE_LINE - location info, - PRIORITY - syslog-compatible logging level, - OSMO_SUBSYS - Osmocom-specific sub-system (e.g. DMSC), - OSMO_SUBSYS_HEX - same as OSMO_SUBSYS, but encoded in hex, - MESSAGE - the logging message itself, and then can be rendered in any supported format (e.g. JSON). More details about the API can be found in [2]. [1] https://www.freedesktop.org/software/systemd/man/systemd.journal-fields.html [2] https://www.freedesktop.org/software/systemd/man/sd-journal.html Change-Id: I609f5cf438e6ad9038d8fc95f00add6aac29fb23 --- M configure.ac M include/osmocom/core/logging.h M src/Makefile.am A src/logging_systemd.c M src/vty/logging_vty.c 5 files changed, 211 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/45/20045/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20045 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I609f5cf438e6ad9038d8fc95f00add6aac29fb23 Gerrit-Change-Number: 20045 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmocom-bb[master]: firmware: gtm900b: fix flash-based hardware variant autodetection
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/20329 ) Change subject: firmware: gtm900b: fix flash-based hardware variant autodetection .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa5bd295e9cbf6b525fa385f9d6cd7fcd7f8a4dd Gerrit-Change-Number: 20329 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 07 Oct 2020 18:05:10 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: firmware: gtm900b: fix MEMIF configuration
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/20328 ) Change subject: firmware: gtm900b: fix MEMIF configuration .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1923243937d7251f6bcfe71a0b1cc0e206a81cfa Gerrit-Change-Number: 20328 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 07 Oct 2020 17:45:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: firmware: gtm900b: fix GPIO configuration
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/20327 ) Change subject: firmware: gtm900b: fix GPIO configuration .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia41f8bc19fb1775b0587fe1ceaa8acd066710aa5 Gerrit-Change-Number: 20327 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 07 Oct 2020 17:41:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: firmware: calibration: proper support for gtm900b target
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/20326 ) Change subject: firmware: calibration: proper support for gtm900b target .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I52b63b1d086452139b1efd308d47a4183eace745 Gerrit-Change-Number: 20326 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 07 Oct 2020 17:36:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: add GAD coding for Location Services
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/20332 )
Change subject: add GAD coding for Location Services
..
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c
File src/gsm/gad.c:
https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c@250
PS1, Line 250: *gad = (struct osmo_gad){};
> the current patch version still uses memcmp to compare structs in gad_test.c
> ... […]
All that for the sake of not using memzero() in the test before calling
osmo_gad_dec and memcmp()? afterwards? To me it doesn't look like it makes a
lot of sense.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20332
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7a9dd805a91b1ebb6353bde0cd169218acbf223c
Gerrit-Change-Number: 20332
Gerrit-PatchSet: 5
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: neels
Gerrit-CC: pespin
Gerrit-Comment-Date: Wed, 07 Oct 2020 17:13:07 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels
Comment-In-Reply-To: laforge
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmocom-bb[master]: firmware: calibration: split afcparams.c from rf_tables.c for gta0x
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/20325 ) Change subject: firmware: calibration: split afcparams.c from rf_tables.c for gta0x .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I92e245843253f279dd6d61bd5098766694c5215f Gerrit-Change-Number: 20325 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 07 Oct 2020 17:12:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-bts in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:6) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-remsim in Debian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_10/armv7l Package network:osmocom:nightly/osmo-remsim failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: Reading from filehandle failed at ./bs_worker line 1365. (worker was armbuild04:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-e1d in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-e1d/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-e1d failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-e1d Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_10/armv7l Package network:osmocom:nightly/osmo-trx failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: Reading from filehandle failed at ./bs_worker line 1365. (worker was armbuild04:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-sysmon failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sysmon Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:6) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcap in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcap/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-pcap failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcap Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-e1d in Debian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-e1d/Debian_10/armv7l Package network:osmocom:nightly/osmo-e1d failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-e1d Last lines of build log: Reading from filehandle failed at ./bs_worker line 1365. (worker was armbuild04:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-remsim in Debian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-remsim failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:6) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/open5gs in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Raspbian_10/armv7l Package network:osmocom:nightly/open5gs failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-bts in Debian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_10/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: Reading from filehandle failed at ./bs_worker line 1365. (worker was armbuild04:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-e1d in Debian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-e1d/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-e1d failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-e1d Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:5) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-bts in Debian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/neocon in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/neocon/Raspbian_10/armv7l Package network:osmocom:nightly/neocon failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly neocon Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcap in Debian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcap/Debian_10/armv7l Package network:osmocom:nightly/osmo-pcap failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcap Last lines of build log: Reading from filehandle failed at ./bs_worker line 1365. (worker was armbuild04:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmo-dsp in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-dsp/Raspbian_10/armv7l Package network:osmocom:nightly/libosmo-dsp failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmo-dsp Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/open5gs in Debian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/armv7l Package network:osmocom:nightly/open5gs failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-fl2k in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-fl2k/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-fl2k failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-fl2k Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:6) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-python-tests in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-python-tests failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in Debian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-sysmon failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sysmon Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:6) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcap in Debian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcap/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-pcap failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcap Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:5) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/neocon in Debian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/neocon/Debian_9.0/armv7l Package network:osmocom:nightly/neocon failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly neocon Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:6) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/rtl-sdr in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/rtl-sdr/Raspbian_10/armv7l Package network:osmocom:nightly/rtl-sdr failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly rtl-sdr Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:5) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmo-dsp in Debian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-dsp/Debian_10/armv7l Package network:osmocom:nightly/libosmo-dsp failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmo-dsp Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/rtl-sdr in Debian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/rtl-sdr/Debian_10/armv7l Package network:osmocom:nightly/rtl-sdr failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly rtl-sdr Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-fl2k in Debian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-fl2k/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-fl2k failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-fl2k Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-fl2k in Debian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-fl2k/Debian_10/armv7l Package network:osmocom:nightly/osmo-fl2k failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-fl2k Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-python-tests in Debian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libgtpnl in Debian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/Debian_10/armv7l Package network:osmocom:nightly/libgtpnl failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libgtpnl Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:6) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/rtl-sdr in Debian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/rtl-sdr/Debian_9.0/armv7l Package network:osmocom:nightly/rtl-sdr failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly rtl-sdr Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:6) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libgtpnl in Debian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/Debian_9.0/armv7l Package network:osmocom:nightly/libgtpnl failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libgtpnl Last lines of build log: File is not a perl storable at /usr/lib/perl5/5.30.3/aarch64-linux-thread-multi/Storable.pm line 443, at ./bs_worker line 1170. (worker was armbuild04:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in libosmocore[master]: add BSSMAP-LE coding for Location Services
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/20334 to look at the new patch set (#6). Change subject: add BSSMAP-LE coding for Location Services .. add BSSMAP-LE coding for Location Services BSSMAP-LE: add Lb-interface messages between BSC and SMLC: - Reset - Reset Acknowledge - Perform Location Request, possibly containing BSSLAP TA Layer3 - Perform Location Response - Perform Location Abort - Connection Oriented Information containing any BSSLAP APDU Add encoding and decoding tests. Change-Id: I271e59b794bafc0a7ae0eabbf58918f6d7df431d --- M include/Makefile.am A include/osmocom/gsm/bssmap_le.h M include/osmocom/gsm/protocol/gsm_49_031.h M src/gsm/Makefile.am A src/gsm/bssmap_le.c M src/gsm/libosmogsm.map M tests/Makefile.am A tests/bssmap_le/bssmap_le_test.c A tests/bssmap_le/bssmap_le_test.ok M tests/testsuite.at 10 files changed, 1,320 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/34/20334/6 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I271e59b794bafc0a7ae0eabbf58918f6d7df431d Gerrit-Change-Number: 20334 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-MessageType: newpatchset
Change in libosmocore[master]: add BSSLAP coding for Location Services
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/20333 to look at the new patch set (#5). Change subject: add BSSLAP coding for Location Services .. add BSSLAP coding for Location Services BSSLAP: there are APDUs transferred in BSSMAP-LE Connection Oriented Information messages on Lb between BSC and SMLC. Add BSSLAP coding for these APDU messages: - TA Layer3 - TA Request - TA Response, possibly containing Location Estimate coded in GAD - Reject - Reset (for intra-BSS handover during TA Request) - Abort (for inter-BSS handover) Add encoding and decoding tests. Change-Id: I6409c4bcac402dc7626a3afce9081c59cd715fe8 --- M include/Makefile.am A include/osmocom/gsm/bsslap.h A include/osmocom/gsm/protocol/gsm_48_071.h A include/osmocom/gsm/protocol/gsm_49_031.h M src/gsm/Makefile.am A src/gsm/bsslap.c M src/gsm/libosmogsm.map M tests/Makefile.am A tests/bsslap/bsslap_test.c A tests/bsslap/bsslap_test.ok M tests/testsuite.at 11 files changed, 698 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/33/20333/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6409c4bcac402dc7626a3afce9081c59cd715fe8 Gerrit-Change-Number: 20333 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in libosmocore[master]: add BSSMAP-LE coding for Location Services
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/20334 to look at the new patch set (#5). Change subject: add BSSMAP-LE coding for Location Services .. add BSSMAP-LE coding for Location Services BSSMAP-LE: add Lb-interface messages between BSC and SMLC: - Reset - Reset Acknowledge - Perform Location Request, possibly containing BSSLAP TA Layer3 - Perform Location Response - Perform Location Abort - Connection Oriented Information containing any BSSLAP APDU Add encoding and decoding tests. Change-Id: I271e59b794bafc0a7ae0eabbf58918f6d7df431d --- M include/Makefile.am A include/osmocom/gsm/bssmap_le.h M include/osmocom/gsm/protocol/gsm_49_031.h M src/gsm/Makefile.am A src/gsm/bssmap_le.c M src/gsm/libosmogsm.map M tests/Makefile.am A tests/bssmap_le/bssmap_le_test.c A tests/bssmap_le/bssmap_le_test.ok M tests/testsuite.at 10 files changed, 1,320 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/34/20334/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I271e59b794bafc0a7ae0eabbf58918f6d7df431d Gerrit-Change-Number: 20334 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-MessageType: newpatchset
Change in libosmocore[master]: add BSSLAP coding for Location Services
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20333 ) Change subject: add BSSLAP coding for Location Services .. Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/20333/4/src/gsm/bsslap.c File src/gsm/bsslap.c: https://gerrit.osmocom.org/c/libosmocore/+/20333/4/src/gsm/bsslap.c@73 PS4, Line 73: err_ctx > not particularly happy that we have a macro making assumptions about variable > names in its context, […] i'd never do that in a .h file... there's always exactly one 'err' and 'err_ctx' in every IE decoding scope in this .c file, that's why I allowed myself to not pass it explicitly. https://gerrit.osmocom.org/c/libosmocore/+/20333/4/src/gsm/bsslap.c@217 PS4, Line 217: void *err_ctx > I would have avoided the extra argument and allocated from one of our > OTC_SELECT or te like talloc c […] I would have *liked* to always use OTC_SELECT, but that would make assumptions on the caller using osmo_select_main_ctx(), and maybe someone would like the error message to survive as long as the msgb that caused it? I would be very happy to strip this argument, but currently I don't see how we can? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6409c4bcac402dc7626a3afce9081c59cd715fe8 Gerrit-Change-Number: 20333 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 12:46:40 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in libosmocore[master]: add GAD coding for Location Services
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/20332 )
Change subject: add GAD coding for Location Services
..
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c
File src/gsm/gad.c:
https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c@250
PS1, Line 250: *gad = (struct osmo_gad){};
> What I don't want for sure is spending time myself fixing another test which
> uses memcmp() being ini […]
the current patch version still uses memcmp to compare structs in gad_test.c
... because it's either that, or writing a full osmo_gad_cmp() function doing a
"manual" == on each and every union and struct member, which is hrrggn. Maybe
we could write some script that writes that for us and replace all existing
memcmp()s we have around with that.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20332
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7a9dd805a91b1ebb6353bde0cd169218acbf223c
Gerrit-Change-Number: 20332
Gerrit-PatchSet: 4
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: neels
Gerrit-CC: pespin
Gerrit-Comment-Date: Wed, 07 Oct 2020 12:41:46 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels
Comment-In-Reply-To: laforge
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmo-bsc[master]: LCS: add paging reason, return in paging_request_stop()
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/20350 )
Change subject: LCS: add paging reason, return in paging_request_stop()
..
LCS: add paging reason, return in paging_request_stop()
To distinguish between the CN requiring a Complete Layer 3 response, or just
the BSC requiring a TA, allow recording a separate for-LCS paging reason.
Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
---
M include/osmocom/bsc/paging.h
M src/osmo-bsc/gsm_08_08.c
M src/osmo-bsc/osmo_bsc_bssap.c
M src/osmo-bsc/paging.c
4 files changed, 63 insertions(+), 28 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/include/osmocom/bsc/paging.h b/include/osmocom/bsc/paging.h
index cab5466..c6eb9df 100644
--- a/include/osmocom/bsc/paging.h
+++ b/include/osmocom/bsc/paging.h
@@ -33,15 +33,25 @@
struct bsc_msc_data;
#define LOG_PAGING(PARAMS, SUBSYS, LEVEL, fmt, args...) \
- LOGP(SUBSYS, LEVEL, "(msc%d) Paging: %s: " fmt, \
+ LOGP(SUBSYS, LEVEL, "(msc%d) Paging%s: %s: " fmt, \
(PARAMS)->msc ? (PARAMS)->msc->nr : -1, \
+(PARAMS)->reason == BSC_PAGING_FOR_LCS ? " for LCS" : "", \
bsc_subscr_name((PARAMS)->bsub), \
##args)
#define LOG_PAGING_BTS(PARAMS, BTS, SUBSYS, LEVEL, fmt, args...) \
LOG_PAGING(PARAMS, SUBSYS, LEVEL, "(bts%u) " fmt, (BTS) ? (BTS)->nr :
255, ##args)
+/* Bitmask of reasons for Paging. Each individual Paging via
bsc_paging_start() typically has only one of these reasons
+ * set, but when a subscriber responds, we need to aggregate all pending
Paging reasons (by bitwise-OR). */
+enum bsc_paging_reason {
+ BSC_PAGING_NONE = 0,
+ BSC_PAGING_FROM_CN = 0x1,
+ BSC_PAGING_FOR_LCS = 0x2,
+};
+
struct bsc_paging_params {
+ enum bsc_paging_reason reason;
struct bsc_msc_data *msc;
struct bsc_subscr *bsub;
uint32_t tmsi;
@@ -72,12 +82,15 @@
/* MSC that has issued this paging */
struct bsc_msc_data *msc;
+
+ enum bsc_paging_reason reason;
};
/* schedule paging request */
int paging_request_bts(const struct bsc_paging_params *params, struct gsm_bts
*bts);
-struct bsc_msc_data *paging_request_stop(struct gsm_bts *bts, struct
bsc_subscr *bsub);
+int paging_request_stop(struct bsc_msc_data **msc_p, enum bsc_paging_reason
*reasons_p,
+ struct gsm_bts *bts, struct bsc_subscr *bsub);
/* update paging load */
void paging_update_buffer_space(struct gsm_bts *bts, uint16_t);
diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index 9f3812a..e5a2774 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -366,6 +366,7 @@
struct gsm_subscriber_connection *conn;
struct bsc_subscr *bsub = NULL;
struct bsc_msc_data *paged_from_msc;
+ enum bsc_paging_reason paging_reasons;
struct bsc_msc_data *msc;
struct msgb *create_l3;
struct gsm0808_speech_codec_list scl;
@@ -424,8 +425,9 @@
/* When receiving a Paging Response, stop Paging for this subscriber on
all cells, and figure out which MSC
* sent the Paging Request, if any. */
paged_from_msc = NULL;
+ paging_reasons = BSC_PAGING_NONE;
if (pdisc == GSM48_PDISC_RR && mtype == GSM48_MT_RR_PAG_RESP) {
- paged_from_msc = paging_request_stop(bts, conn->bsub);
+ paging_request_stop(_from_msc, _reasons, bts,
conn->bsub);
if (!paged_from_msc) {
/* This looks like an unsolicited Paging Response. It
is required to pick any MSC, because any
* MT-CSFB calls were Paged by the MSC via SGs, and
hence are not listed in the BSC. */
diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 2665a9b..023929c 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -272,6 +272,7 @@
int remain;
const uint8_t *data;
struct bsc_paging_params paging = {
+ .reason = BSC_PAGING_FROM_CN,
.msc = msc,
.tmsi = GSM_RESERVED_TMSI,
};
diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c
index d026a20..54a5fd7 100644
--- a/src/osmo-bsc/paging.c
+++ b/src/osmo-bsc/paging.c
@@ -342,6 +342,7 @@
LOG_PAGING_BTS(params, bts, DPAG, LOGL_DEBUG, "Start paging\n");
req = talloc_zero(tall_paging_ctx, struct gsm_paging_request);
OSMO_ASSERT(req);
+ req->reason = params->reason;
req->bsub = bsc_subscr_get(params->bsub);
req->bts = bts;
req->chan_type = params->chan_needed;
@@ -380,61 +381,79 @@
}
/*! Stop paging a given subscriber on a given BTS.
- * If \a conn is non-NULL, we also call the paging call-back function
- * to notify the paging originator that paging has completed.
- * \param[in] bts BTS on which we
Change in libosmocore[master]: add GAD coding for Location Services
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20332 ) Change subject: add GAD coding for Location Services .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7a9dd805a91b1ebb6353bde0cd169218acbf223c Gerrit-Change-Number: 20332 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 12:39:09 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: introduce osmo_use_count for bsc_subscr
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/20351 )
Change subject: introduce osmo_use_count for bsc_subscr
..
introduce osmo_use_count for bsc_subscr
During LCS development, I'm getting use count bugs and would like to see use
token strings to figure it out.
Change-Id: I29bf60059d4cf7bb99a00753e6cdc149baf95f94
---
M include/osmocom/bsc/bsc_subscr_conn_fsm.h
M include/osmocom/bsc/bsc_subscriber.h
M include/osmocom/bsc/paging.h
M src/osmo-bsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/bsc_subscriber.c
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/gsm_08_08.c
M src/osmo-bsc/osmo_bsc_bssap.c
M src/osmo-bsc/paging.c
M tests/handover/handover_test.c
M tests/subscr/bsc_subscr_test.c
M tests/subscr/bsc_subscr_test.err
12 files changed, 155 insertions(+), 106 deletions(-)
Approvals:
Jenkins Builder: Verified
neels: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
diff --git a/include/osmocom/bsc/bsc_subscr_conn_fsm.h
b/include/osmocom/bsc/bsc_subscr_conn_fsm.h
index 354c5ee..9b6398a 100644
--- a/include/osmocom/bsc/bsc_subscr_conn_fsm.h
+++ b/include/osmocom/bsc/bsc_subscr_conn_fsm.h
@@ -3,6 +3,8 @@
#include
#include
+#define BSUB_USE_CONN "conn"
+
enum gscon_fsm_event {
/* local SCCP stack tells us incoming conn from MSC */
GSCON_EV_A_CONN_IND,
diff --git a/include/osmocom/bsc/bsc_subscriber.h
b/include/osmocom/bsc/bsc_subscriber.h
index a602a9e..6fffafd 100644
--- a/include/osmocom/bsc/bsc_subscriber.h
+++ b/include/osmocom/bsc/bsc_subscriber.h
@@ -5,6 +5,7 @@
#include
#include
+#include
#include
#include
@@ -12,7 +13,7 @@
struct bsc_subscr {
struct llist_head entry;
- int use_count;
+ struct osmo_use_count use_count;
char imsi[GSM23003_IMSI_MAX_DIGITS+1];
uint32_t tmsi;
@@ -22,25 +23,29 @@
const char *bsc_subscr_id(struct bsc_subscr *bsub);
struct bsc_subscr *bsc_subscr_find_or_create_by_imsi(struct llist_head *list,
-const char *imsi);
+const char *imsi,
+const char *use_token);
struct bsc_subscr *bsc_subscr_find_or_create_by_tmsi(struct llist_head *list,
-uint32_t tmsi);
-struct bsc_subscr *bsc_subscr_find_or_create_by_mi(struct llist_head *list,
const struct osmo_mobile_identity *mi);
+uint32_t tmsi,
+const char *use_token);
+struct bsc_subscr *bsc_subscr_find_or_create_by_mi(struct llist_head *list,
const struct osmo_mobile_identity *mi,
+ const char *use_token);
struct bsc_subscr *bsc_subscr_find_by_imsi(struct llist_head *list,
- const char *imsi);
+ const char *imsi,
+ const char *use_token);
struct bsc_subscr *bsc_subscr_find_by_tmsi(struct llist_head *list,
- uint32_t tmsi);
-struct bsc_subscr *bsc_subscr_find_by_mi(struct llist_head *list, const struct
osmo_mobile_identity *mi);
+ uint32_t tmsi,
+ const char *use_token);
+struct bsc_subscr *bsc_subscr_find_by_mi(struct llist_head *list, const struct
osmo_mobile_identity *mi,
+const char *use_token);
void bsc_subscr_set_imsi(struct bsc_subscr *bsub, const char *imsi);
-struct bsc_subscr *_bsc_subscr_get(struct bsc_subscr *bsub,
- const char *file, int line);
-struct bsc_subscr *_bsc_subscr_put(struct bsc_subscr *bsub,
- const char *file, int line);
-#define bsc_subscr_get(bsub) _bsc_subscr_get(bsub, __FILE__, __LINE__)
-#define bsc_subscr_put(bsub) _bsc_subscr_put(bsub, __FILE__, __LINE__)
+#define bsc_subscr_get(bsc_subscr, use) \
+ OSMO_ASSERT(osmo_use_count_get_put(&(bsc_subscr)->use_count, use, 1) ==
0)
+#define bsc_subscr_put(bsc_subscr, use) \
+ OSMO_ASSERT(osmo_use_count_get_put(&(bsc_subscr)->use_count, use, -1)
== 0)
void log_set_filter_bsc_subscr(struct log_target *target,
struct bsc_subscr *bsub);
diff --git a/include/osmocom/bsc/paging.h b/include/osmocom/bsc/paging.h
index c6eb9df..cd351cb 100644
--- a/include/osmocom/bsc/paging.h
+++ b/include/osmocom/bsc/paging.h
@@ -42,6 +42,9 @@
#define LOG_PAGING_BTS(PARAMS, BTS, SUBSYS, LEVEL, fmt, args...) \
LOG_PAGING(PARAMS, SUBSYS, LEVEL, "(bts%u) " fmt, (BTS) ? (BTS)->nr :
255, ##args)
+#define BSUB_USE_PAGING_START "paging-start"
+#define
Change in osmo-bsc[master]: LCS: implement re-use of existing A-interface conn
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/20355 )
Change subject: LCS: implement re-use of existing A-interface conn
..
LCS: implement re-use of existing A-interface conn
Location Services brings a new scenario to OsmoBSC: the MSC may create an
A-interface conn for a subscriber without an lchan being established (N-CONNECT
from MSC to BSC, so far only for an incoming inter-BSC handover).
If an MS becomes active while an A-interface conn is already established,
associate with an existing conn.
Change-Id: I42290f519a419ed7e8dd02a5ed0a5261b30a51e6
---
M include/osmocom/bsc/osmo_bsc_sigtran.h
M src/osmo-bsc/gsm_08_08.c
M src/osmo-bsc/osmo_bsc_sigtran.c
3 files changed, 69 insertions(+), 23 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/include/osmocom/bsc/osmo_bsc_sigtran.h
b/include/osmocom/bsc/osmo_bsc_sigtran.h
index dc86fad..faaceb2 100644
--- a/include/osmocom/bsc/osmo_bsc_sigtran.h
+++ b/include/osmocom/bsc/osmo_bsc_sigtran.h
@@ -26,6 +26,7 @@
/* Allocate resources to make a new connection oriented sigtran connection
* (not the connection ittself!) */
enum bsc_con osmo_bsc_sigtran_new_conn(struct gsm_subscriber_connection *conn,
struct bsc_msc_data *msc);
+struct gsm_subscriber_connection *bsc_conn_by_bsub(struct bsc_subscr *bsub);
/* Open a new connection oriented sigtran connection */
int osmo_bsc_sigtran_open_conn(struct gsm_subscriber_connection *conn, struct
msgb *msg);
diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index 41fc230..a4b53f0 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -363,7 +363,7 @@
/*! MS->MSC: New MM context with L3 payload. */
int bsc_compl_l3(struct gsm_lchan *lchan, struct msgb *msg, uint16_t
chosen_channel)
{
- struct gsm_subscriber_connection *conn;
+ struct gsm_subscriber_connection *conn = NULL;
struct bsc_subscr *bsub = NULL;
struct bsc_msc_data *paged_from_msc;
enum bsc_paging_reason paging_reasons;
@@ -382,7 +382,7 @@
if (msgb_l3len(msg) < sizeof(*gh)) {
LOGP(DRSL, LOGL_ERROR, "There is no GSM48 header here.\n");
- goto early_fail;
+ goto early_exit;
}
gh = msgb_l3(msg);
@@ -392,6 +392,9 @@
bts = lchan->ts->trx->bts;
OSMO_ASSERT(bts);
+ /* Normally, if an lchan has no conn yet, it is an all new Complete
Layer 3, and we allocate a new conn on the
+* A-interface. But there are cases where a conn on A already exists
for this subscriber (e.g. Perform Location
+* Request on IDLE MS). The Mobile Identity tells us whether that is
the case. */
if (osmo_mobile_identity_decode_from_l3(, msg, false)) {
LOG_COMPL_L3(pdisc, mtype, LOGL_ERROR, "Cannot extract Mobile
Identity: %s\n",
msgb_hexdump_c(OTC_SELECT, msg));
@@ -405,11 +408,19 @@
bsub =
bsc_subscr_find_or_create_by_mi(bsc_gsmnet->bsc_subscribers, , __func__);
}
- /* allocate a new connection */
- conn = bsc_subscr_con_allocate(bsc_gsmnet);
+ /* If this Mobile Identity already has an active bsc_subscr, look
whether there also is an active A-interface
+* conn for this subscriber. This may be the case during a Perform
Location Request (LCS) from the MSC that
+* started on an IDLE MS, and now the MS is becoming active. Associate
with the existing conn. */
+ if (bsub)
+ conn = bsc_conn_by_bsub(bsub);
+
if (!conn) {
- LOG_COMPL_L3(pdisc, mtype, LOGL_ERROR, "Failed to allocate
conn\n");
- goto early_fail;
+ /* Typical Complete Layer 3 with a new conn being established.
*/
+ conn = bsc_subscr_con_allocate(bsc_gsmnet);
+ if (!conn) {
+ LOG_COMPL_L3(pdisc, mtype, LOGL_ERROR, "Failed to
allocate conn\n");
+ goto early_exit;
+ }
}
if (bsub) {
/* We got the conn either from new allocation, or by searching
for it by bsub. So: */
@@ -420,6 +431,7 @@
}
bsc_subscr_put(bsub, __func__);
}
+ /* Associate lchan with the conn, and set the id string for logging */
gscon_change_primary_lchan(conn, lchan);
gscon_update_id(conn);
@@ -454,24 +466,44 @@
}
}
- /* find the MSC link we want to use */
- if (paged_from_msc)
- msc = paged_from_msc;
- else
- msc = bsc_find_msc(conn, , is_emerg,
is_lu_from_other_plmn(msg));
- if (!msc) {
- LOG_COMPL_L3(pdisc, mtype, LOGL_ERROR, "%s%s: No suitable MSC
for this Complete Layer 3 request found\n",
-
Change in osmo-bsc[master]: cosmetic: fix naming of GSCON_EV_A_CONN_REQ -> GSCON_EV_MO_COMPL_L3
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/20354 )
Change subject: cosmetic: fix naming of GSCON_EV_A_CONN_REQ ->
GSCON_EV_MO_COMPL_L3
..
cosmetic: fix naming of GSCON_EV_A_CONN_REQ -> GSCON_EV_MO_COMPL_L3
The N-CONNECT.req on the A interface is a possible *consequence* of the event
being handled, namely the incoming RSL ESTablish INDication containing the
Complete Layer 3 message: dispatched by bsc_compl_l3().
If an (LCS related) connection is already present on the A-interface when the
lchan is established, there will be no N-CONNECT but an N-DATA sending the
Complete Layer 3. See BSC_Tests.TC_cm_service_during_lcs_loc_req().
Change-Id: Ic43aabeb0d3c58ac62249ad9d3718363d32508f9
---
M include/osmocom/bsc/bsc_subscr_conn_fsm.h
M src/osmo-bsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/gsm_08_08.c
M tests/handover/handover_test.c
4 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Jenkins Builder: Verified
Vadim Yanitskiy: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/include/osmocom/bsc/bsc_subscr_conn_fsm.h
b/include/osmocom/bsc/bsc_subscr_conn_fsm.h
index 9b6398a..ccac4fa 100644
--- a/include/osmocom/bsc/bsc_subscr_conn_fsm.h
+++ b/include/osmocom/bsc/bsc_subscr_conn_fsm.h
@@ -9,7 +9,7 @@
/* local SCCP stack tells us incoming conn from MSC */
GSCON_EV_A_CONN_IND,
/* RSL side requests CONNECT to MSC */
- GSCON_EV_A_CONN_REQ,
+ GSCON_EV_MO_COMPL_L3,
/* MSC confirms the SCCP connection */
GSCON_EV_A_CONN_CFM,
/* MSC has sent BSSMAP CLEAR CMD */
diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c
b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index de73a2a..b127e7f 100644
--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c
+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c
@@ -69,7 +69,7 @@
static const struct value_string gscon_fsm_event_names[] = {
{GSCON_EV_A_CONN_IND, "MT-CONNECT.ind"},
- {GSCON_EV_A_CONN_REQ, "MO-CONNECT.req"},
+ {GSCON_EV_MO_COMPL_L3, "MO_COMPL_L3"},
{GSCON_EV_A_CONN_CFM, "MO-CONNECT.cfm"},
{GSCON_EV_A_CLEAR_CMD, "CLEAR_CMD"},
{GSCON_EV_A_DISC_IND, "DISCONNET.ind"},
@@ -280,7 +280,7 @@
enum handover_result ho_result;
switch (event) {
- case GSCON_EV_A_CONN_REQ:
+ case GSCON_EV_MO_COMPL_L3:
/* RLL ESTABLISH IND with initial L3 Message */
msg = data;
rc = osmo_bsc_sigtran_open_conn(conn, msg);
@@ -614,7 +614,7 @@
static const struct osmo_fsm_state gscon_fsm_states[] = {
[ST_INIT] = {
.name = "INIT",
- .in_event_mask = S(GSCON_EV_A_CONN_REQ) | S(GSCON_EV_A_CONN_IND)
+ .in_event_mask = S(GSCON_EV_MO_COMPL_L3) |
S(GSCON_EV_A_CONN_IND)
| S(GSCON_EV_HANDOVER_END),
.out_state_mask = S(ST_WAIT_CC) | S(ST_ACTIVE) | S(ST_CLEARING),
.action = gscon_fsm_init,
diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index 01d9d0e..41fc230 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -494,7 +494,7 @@
osmo_mobile_identity_to_str_c(OTC_SELECT, ));
goto early_fail;
}
- rc = osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_A_CONN_REQ, create_l3);
+ rc = osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_MO_COMPL_L3, create_l3);
if (!rc)
release_lchan = false;
diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c
index 8fa8fe8..d3f29e1 100644
--- a/tests/handover/handover_test.c
+++ b/tests/handover/handover_test.c
@@ -247,7 +247,7 @@
lchan->conn->bsub =
bsc_subscr_find_or_create_by_imsi(net->bsc_subscribers, imsi, BSUB_USE_CONN);
/* kick the FSM from INIT through to the ACTIVE state */
- osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_A_CONN_REQ, NULL);
+ osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_MO_COMPL_L3, NULL);
osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_A_CONN_CFM, NULL);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20354
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic43aabeb0d3c58ac62249ad9d3718363d32508f9
Gerrit-Change-Number: 20354
Gerrit-PatchSet: 4
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bsc[master]: bsc_subscr_name: print both IMSI and TMSI
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/20352 )
Change subject: bsc_subscr_name: print both IMSI and TMSI
..
bsc_subscr_name: print both IMSI and TMSI
Always use a format containing only osmo_identifier_valid() characters.
Change-Id: I6cdbaad2f0d0552f697440bf9a75bef36d59a597
---
M src/osmo-bsc/bsc_subscriber.c
M tests/subscr/bsc_subscr_test.c
M tests/subscr/bsc_subscr_test.err
3 files changed, 44 insertions(+), 37 deletions(-)
Approvals:
Jenkins Builder: Verified
Vadim Yanitskiy: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
diff --git a/src/osmo-bsc/bsc_subscriber.c b/src/osmo-bsc/bsc_subscriber.c
index 79d0c85..4a48298 100644
--- a/src/osmo-bsc/bsc_subscriber.c
+++ b/src/osmo-bsc/bsc_subscriber.c
@@ -51,7 +51,7 @@
else
level = LOGL_DEBUG;
- LOGPSRC(DREF, level, file, line, "BSC subscr %s: %s %s: now used by
%s\n",
+ LOGPSRC(DREF, level, file, line, "%s: %s %s: now used by %s\n",
bsc_subscr_name(bsub),
(e->count - old_use_count) > 0? "+" : "-", e->use,
osmo_use_count_to_str_c(OTC_SELECT, >use_count));
@@ -188,30 +188,36 @@
}
}
+static int bsc_subscr_name_buf(char *buf, size_t buflen, struct bsc_subscr
*bsub)
+{
+ struct osmo_strbuf sb = { .buf = buf, .len = buflen };
+ OSMO_STRBUF_PRINTF(sb, "subscr");
+ if (!bsub) {
+ OSMO_STRBUF_PRINTF(sb, "-null");
+ return sb.chars_needed;
+ }
+ if (bsub->imsi[0])
+ OSMO_STRBUF_PRINTF(sb, "-IMSI-%s", bsub->imsi);
+ if (bsub->tmsi != GSM_RESERVED_TMSI)
+ OSMO_STRBUF_PRINTF(sb, "-TMSI-0x%08x", bsub->tmsi);
+ return sb.chars_needed;
+}
+
+static char *bsc_subscr_name_c(void *ctx, struct bsc_subscr *bsub)
+{
+ OSMO_NAME_C_IMPL(ctx, 64, "ERROR", bsc_subscr_name_buf, bsub)
+}
+
const char *bsc_subscr_name(struct bsc_subscr *bsub)
{
- static char buf[32];
- if (!bsub)
- return "unknown";
- if (bsub->imsi[0])
- snprintf(buf, sizeof(buf), "IMSI:%s", bsub->imsi);
- else
- snprintf(buf, sizeof(buf), "TMSI:0x%08x", bsub->tmsi);
- return buf;
+ return bsc_subscr_name_c(OTC_SELECT, bsub);
}
/* Like bsc_subscr_name() but returns only characters approved by
osmo_identifier_valid(), useful for
* osmo_fsm_inst IDs. */
const char *bsc_subscr_id(struct bsc_subscr *bsub)
{
- static char buf[32];
- if (!bsub)
- return "unknown";
- if (bsub->imsi[0])
- snprintf(buf, sizeof(buf), "IMSI%s", bsub->imsi);
- else
- snprintf(buf, sizeof(buf), "TMSI%08x", bsub->tmsi);
- return buf;
+ return bsc_subscr_name(bsub);
}
static void bsc_subscr_free(struct bsc_subscr *bsub)
diff --git a/tests/subscr/bsc_subscr_test.c b/tests/subscr/bsc_subscr_test.c
index fcaea63..619d5e6 100644
--- a/tests/subscr/bsc_subscr_test.c
+++ b/tests/subscr/bsc_subscr_test.c
@@ -75,6 +75,7 @@
/* Allocate entry 2 */
s2 = bsc_subscr_find_or_create_by_imsi(bsc_subscribers, imsi2,
BSUB_USE);
+ s2->tmsi = 0x73517351;
VERBOSE_ASSERT(llist_count(bsc_subscribers), == 2, "%d");
/* Allocate entry 3 */
diff --git a/tests/subscr/bsc_subscr_test.err b/tests/subscr/bsc_subscr_test.err
index a78e757..c41d3ca 100644
--- a/tests/subscr/bsc_subscr_test.err
+++ b/tests/subscr/bsc_subscr_test.err
@@ -1,20 +1,20 @@
-DREF BSC subscr IMSI:1234567890: + test: now used by 1 (test)
-DREF BSC subscr IMSI:1234567890: + test: now used by 2 (2*test)
-DREF BSC subscr IMSI:1234567890: - test: now used by 1 (test)
-DREF BSC subscr IMSI:9876543210: + test: now used by 1 (test)
-DREF BSC subscr IMSI:5656565656: + test: now used by 1 (test)
-DREF BSC subscr IMSI:1234567890: + test: now used by 2 (2*test)
-DREF BSC subscr IMSI:1234567890: - test: now used by 1 (test)
-DREF BSC subscr IMSI:9876543210: + test: now used by 2 (2*test)
-DREF BSC subscr IMSI:9876543210: - test: now used by 1 (test)
-DREF BSC subscr IMSI:5656565656: + test: now used by 2 (2*test)
-DREF BSC subscr IMSI:5656565656: - test: now used by 1 (test)
-DREF BSC subscr IMSI:1234567890: - test: now used by 0 (-)
-DREF BSC subscr IMSI:9876543210: + test: now used by 2 (2*test)
-DREF BSC subscr IMSI:9876543210: - test: now used by 1 (test)
-DREF BSC subscr IMSI:5656565656: + test: now used by 2 (2*test)
-DREF BSC subscr IMSI:5656565656: - test: now used by 1 (test)
-DREF BSC subscr IMSI:9876543210: - test: now used by 0 (-)
-DREF BSC subscr IMSI:5656565656: + test: now used by 2 (2*test)
-DREF BSC subscr IMSI:5656565656: - test: now used by 1 (test)
-DREF BSC subscr IMSI:5656565656: - test: now used by 0 (-)
+DREF subscr-IMSI-1234567890: + test: now used by 1 (test)
+DREF
Change in osmo-bsc[master]: refactor paging: add bsc_subscr to bsc_paging_params
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/20349 )
Change subject: refactor paging: add bsc_subscr to bsc_paging_params
..
refactor paging: add bsc_subscr to bsc_paging_params
Get a bsub once at start of paging.
Change-Id: I13621cd51d934846ff6556e1f2f8839da73a5dbb
---
M include/osmocom/bsc/paging.h
M src/osmo-bsc/osmo_bsc_bssap.c
M src/osmo-bsc/paging.c
3 files changed, 23 insertions(+), 28 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/include/osmocom/bsc/paging.h b/include/osmocom/bsc/paging.h
index cebdce3..cab5466 100644
--- a/include/osmocom/bsc/paging.h
+++ b/include/osmocom/bsc/paging.h
@@ -33,10 +33,9 @@
struct bsc_msc_data;
#define LOG_PAGING(PARAMS, SUBSYS, LEVEL, fmt, args...) \
- LOGP(SUBSYS, LEVEL, "(msc%d) Paging: %s TMSI-0x%08x: " fmt, \
+ LOGP(SUBSYS, LEVEL, "(msc%d) Paging: %s: " fmt, \
(PARAMS)->msc ? (PARAMS)->msc->nr : -1, \
-osmo_mobile_identity_to_str_c(OTC_SELECT, &(PARAMS)->imsi), \
-(PARAMS)->tmsi, \
+bsc_subscr_name((PARAMS)->bsub), \
##args)
#define LOG_PAGING_BTS(PARAMS, BTS, SUBSYS, LEVEL, fmt, args...) \
@@ -44,6 +43,7 @@
struct bsc_paging_params {
struct bsc_msc_data *msc;
+ struct bsc_subscr *bsub;
uint32_t tmsi;
struct osmo_mobile_identity imsi;
uint8_t chan_needed;
@@ -75,7 +75,7 @@
};
/* schedule paging request */
-int paging_request_bts(const struct bsc_paging_params *params, struct
bsc_subscr *bsub, struct gsm_bts *bts);
+int paging_request_bts(const struct bsc_paging_params *params, struct gsm_bts
*bts);
struct bsc_msc_data *paging_request_stop(struct gsm_bts *bts, struct
bsc_subscr *bsub);
diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index ad50122..2665a9b 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -117,7 +117,6 @@
static void
page_subscriber(const struct bsc_paging_params *params, struct gsm_bts *bts,
uint32_t lac)
{
- struct bsc_subscr *subscr;
int ret;
if (!bsc_grace_allow_new_connection(bsc_gsmnet, bts)) {
@@ -125,29 +124,12 @@
return;
}
- subscr = bsc_subscr_find_or_create_by_mi(bsc_gsmnet->bsc_subscribers,
>imsi);
-
- if (subscr)
- log_set_context(LOG_CTX_BSC_SUBSCR, subscr);
-
LOG_PAGING_BTS(params, bts, DMSC, LOGL_INFO, "Paging on LAC %u\n", lac);
- if (!subscr) {
- LOGP(DMSC, LOGL_ERROR, "Paging request failed: Could not
allocate subscriber for %s\n",
-osmo_mobile_identity_to_str_c(OTC_SELECT, >imsi));
- return;
- }
-
- subscr->tmsi = params->tmsi;
- ret = paging_request_bts(params, subscr, bts);
+ ret = paging_request_bts(params, bts);
if (ret == 0)
LOG_PAGING_BTS(params, bts, DMSC, LOGL_INFO,
"Paging request failed, or repeated paging on
LAC %u\n", lac);
-
- /* the paging code has grabbed its own references */
- bsc_subscr_put(subscr);
-
- log_set_context(LOG_CTX_BSC_SUBSCR, NULL);
}
static void
@@ -363,6 +345,17 @@
{
rate_ctr_inc(_gsmnet->bsc_ctrs->ctr[BSC_CTR_PAGING_ATTEMPTED]);
+ if (!params->bsub) {
+ params->bsub =
bsc_subscr_find_or_create_by_imsi(bsc_gsmnet->bsc_subscribers,
params->imsi.imsi);
+ if (!params->bsub) {
+ LOG_PAGING(params, DMSC, LOGL_ERROR, "Paging request
failed: Could not allocate subscriber\n");
+ return -EINVAL;
+ }
+ }
+ if (params->tmsi != GSM_RESERVED_TMSI)
+ params->bsub->tmsi = params->tmsi;
+ log_set_context(LOG_CTX_BSC_SUBSCR, params->bsub);
+
switch (params->cil.id_discr) {
case CELL_IDENT_NO_CELL:
page_all_bts(params);
@@ -400,6 +393,8 @@
break;
}
+ bsc_subscr_put(params->bsub);
+ log_set_context(LOG_CTX_BSC_SUBSCR, NULL);
return 0;
}
diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c
index 1869042..d026a20 100644
--- a/src/osmo-bsc/paging.c
+++ b/src/osmo-bsc/paging.c
@@ -325,7 +325,7 @@
* \param[in] type type of radio channel we're requirign
* \param[in] msc MSC which has issue this paging
* \returns 0 on success, negative on error */
-static int _paging_request(const struct bsc_paging_params *params, struct
bsc_subscr *bsub, struct gsm_bts *bts)
+static int _paging_request(const struct bsc_paging_params *params, struct
gsm_bts *bts)
{
struct gsm_bts_paging_state *bts_entry = >paging;
struct gsm_paging_request *req;
@@ -333,7 +333,7 @@
rate_ctr_inc(>bts_ctrs->ctr[BTS_CTR_PAGING_ATTEMPTED]);
- if (paging_pending_request(bts_entry, bsub)) {
+ if
Change in osmo-bsc[master]: refactor paging: introduce bsc_paging_start()
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/20348 )
Change subject: refactor paging: introduce bsc_paging_start()
..
refactor paging: introduce bsc_paging_start()
Allow starting a paging from elsewhere than a BSSMAP Paging Request. For
upcoming Location Services (LCS), a BSSLAP TA Request from the SMLC may require
triggering a Paging.
Change-Id: Iaff91584699d163bd1963927280ff3a8ddd43073
---
M include/osmocom/bsc/paging.h
M src/osmo-bsc/osmo_bsc_bssap.c
M tests/handover/handover_test.c
3 files changed, 10 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
Vadim Yanitskiy: Looks good to me, approved
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/include/osmocom/bsc/paging.h b/include/osmocom/bsc/paging.h
index 3dd5dc6..cebdce3 100644
--- a/include/osmocom/bsc/paging.h
+++ b/include/osmocom/bsc/paging.h
@@ -88,4 +88,5 @@
void paging_flush_bts(struct gsm_bts *bts, struct bsc_msc_data *msc);
void paging_flush_network(struct gsm_network *net, struct bsc_msc_data *msc);
+int bsc_paging_start(struct bsc_paging_params *params);
#endif
diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 3c00d68..ad50122 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -293,7 +293,6 @@
.msc = msc,
.tmsi = GSM_RESERVED_TMSI,
};
- struct bsc_paging_params *params; // (tmp cosmetic shim, dropped in
subsequent patch)
tlv_parse(, gsm0808_att_tlvdef(), msg->l4h + 1, payload_length - 1,
0, 0);
remain = payload_length - 1;
@@ -357,9 +356,13 @@
LOG_PAGING(, DMSC, LOGL_ERROR, "eMLPP IE present, but
eMLPP is not handled\n");
}
- rate_ctr_inc(>network->bsc_ctrs->ctr[BSC_CTR_PAGING_ATTEMPTED]);
+ return bsc_paging_start();
+}
- params =
+int bsc_paging_start(struct bsc_paging_params *params)
+{
+ rate_ctr_inc(_gsmnet->bsc_ctrs->ctr[BSC_CTR_PAGING_ATTEMPTED]);
+
switch (params->cil.id_discr) {
case CELL_IDENT_NO_CELL:
page_all_bts(params);
diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c
index ba0ec21..bdf926d 100644
--- a/tests/handover/handover_test.c
+++ b/tests/handover/handover_test.c
@@ -48,6 +48,7 @@
#include
#include
#include
+#include
void *ctx;
@@ -1798,6 +1799,8 @@
void bsc_cipher_mode_compl(struct gsm_subscriber_connection *conn, struct msgb
*msg, uint8_t chosen_encr) {}
int bsc_compl_l3(struct gsm_lchan *lchan, struct msgb *msg, uint16_t
chosen_channel)
{ return 0; }
+int bsc_paging_start(struct bsc_paging_params *params)
+{ return 0; }
void bsc_dtap(struct gsm_subscriber_connection *conn, uint8_t link_id, struct
msgb *msg) {}
void bsc_assign_compl(struct gsm_subscriber_connection *conn, uint8_t
rr_cause) {}
void bsc_cm_update(struct gsm_subscriber_connection *conn,
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20348
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iaff91584699d163bd1963927280ff3a8ddd43073
Gerrit-Change-Number: 20348
Gerrit-PatchSet: 4
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bsc[master]: introduce osmo_use_count for bsc_subscr
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20351 ) Change subject: introduce osmo_use_count for bsc_subscr .. Patch Set 4: Code-Review+2 combine -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29bf60059d4cf7bb99a00753e6cdc149baf95f94 Gerrit-Change-Number: 20351 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 12:27:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20357 ) Change subject: LCS: implement the bulk of Location Services .. Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_loc_req.c File src/osmo-bsc/lcs_loc_req.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_loc_req.c@144 PS1, Line 144: // FIXME LCS QoS IE is mandatory for requesting the location > This probably needs to be addressed before merging? we don't require the IE, just we "should" be pedantic about accepting the message when that IE is missing. Not necessary to implement now. https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/paging.c File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/paging.c@461 PS1, Line 461: int paging_request_cancel(struct bsc_subscr *bsub, enum bsc_paging_reason reasons) > unsigned you mean the return value? keeping the same rc as paging_request_stop() above. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 12:24:32 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-bsc[master]: gscon_bssmap_clear(): guard against NULL msc
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20339 ) Change subject: gscon_bssmap_clear(): guard against NULL msc .. Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/20339/1/src/osmo-bsc/bsc_subscr_conn_fsm.c File src/osmo-bsc/bsc_subscr_conn_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20339/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@153 PS1, Line 153: return > ... […] no because resp == NULL https://gerrit.osmocom.org/c/osmo-bsc/+/20339/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@158 PS1, Line 158: return > and here? I would rather move this check upwards, because it does not make > sense to allocate msgb if […] yes -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I95b16cebb6ff78649f72a09b5d6c7c7e403233fa Gerrit-Change-Number: 20339 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Vadim Yanitskiy Gerrit-Comment-Date: Wed, 07 Oct 2020 12:23:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy Gerrit-MessageType: comment
Change in osmo-bsc[master]: LCS: SCCP next conn id: prepare Lb-interface
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20356 ) Change subject: LCS: SCCP next conn id: prepare Lb-interface .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/include/osmocom/bsc/gsm_data.h@53 PS1, Line 53: struct osmo_sccp_instance; > huh, OpenBSD guys despise #include statements? ;) […] I can explain again: whenever you #include in a .h file, you pull in potential cascades of more #includes and "dependencies", you potentially enlarge the compilation unit for each .o file, and, more critically, you may inadvertently introduce circular includes that break compilation. So every .h file that avoids an #include by an opaque declaration helps reducing #include chains. It is the .c file's responsibility to #include those headers that are required for that compilation unit. (Another theoretical argument is that the .c file might want to use a different implementation of that opaque struct, but that doesn't happen in practice, at least nowhere i've been, because that'd be insane.) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I12fcb18f6e4380f72929cfe7681bac05330a8c9a Gerrit-Change-Number: 20356 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: Vadim Yanitskiy Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 12:23:26 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Comment-In-Reply-To: Vadim Yanitskiy Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 to look at the new patch set (#3). Change subject: LCS: implement the bulk of Location Services .. LCS: implement the bulk of Location Services Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 --- M include/osmocom/bsc/bsc_msc_data.h M include/osmocom/bsc/bsc_subscr_conn_fsm.h M include/osmocom/bsc/debug.h M include/osmocom/bsc/gsm_data.h A include/osmocom/bsc/lb.h A include/osmocom/bsc/lcs_loc_req.h A include/osmocom/bsc/lcs_ta_req.h M include/osmocom/bsc/paging.h M include/osmocom/bsc/vty.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_sccp.c M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/gsm_04_08_rr.c M src/osmo-bsc/gsm_08_08.c M src/osmo-bsc/gsm_data.c M src/osmo-bsc/handover_fsm.c A src/osmo-bsc/lb.c A src/osmo-bsc/lcs_loc_req.c A src/osmo-bsc/lcs_ta_req.c M src/osmo-bsc/net_init.c M src/osmo-bsc/osmo_bsc_bssap.c M src/osmo-bsc/osmo_bsc_main.c M src/osmo-bsc/osmo_bsc_msc.c M src/osmo-bsc/paging.c M tests/bsc/bsc_test.c M tests/handover/Makefile.am M tests/timer.vty 28 files changed, 1,848 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/20357/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-smlc[master]: initial working osmo-smlc implementation
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-smlc/+/20470 to look at the new patch set (#2). Change subject: initial working osmo-smlc implementation .. initial working osmo-smlc implementation The lower level Lb/SCCP interface conn handling is essentially a copy of OsmoMSC's A/SCCP infrastructure (OsmoMSC also connects to multiple BSCs). The smlc_subscr is mostly a copy of OsmoBSC's bsc_subscr. smlc_loc_req FSM is the SMLC side of OsmoBSC's new lcs_loc_req FSM. cell_locations configures geographic coordinates of individual cells. Change-Id: I917ba8fc51a1f1150be77ae01e12a7b16a853052 --- M configure.ac M doc/examples/osmo-smlc/osmo-smlc.cfg M include/osmocom/smlc/Makefile.am A include/osmocom/smlc/cell_locations.h A include/osmocom/smlc/debug.h A include/osmocom/smlc/lb_conn.h A include/osmocom/smlc/lb_peer.h A include/osmocom/smlc/sccp_lb_inst.h M include/osmocom/smlc/smlc_data.h A include/osmocom/smlc/smlc_loc_req.h M include/osmocom/smlc/smlc_sigtran.h A include/osmocom/smlc/smlc_subscr.h A include/osmocom/smlc/smlc_vty.h M src/osmo-smlc/Makefile.am A src/osmo-smlc/cell_locations.c A src/osmo-smlc/lb_conn.c A src/osmo-smlc/lb_peer.c A src/osmo-smlc/lcs_loc_req.c A src/osmo-smlc/sccp_lb_inst.c A src/osmo-smlc/smlc_data.c A src/osmo-smlc/smlc_loc_req.c M src/osmo-smlc/smlc_main.c D src/osmo-smlc/smlc_sigtran.c A src/osmo-smlc/smlc_subscr.c M tests/Makefile.am A tests/cell_locations.vty A tests/osmo-smlc.cfg A tests/smlc_subscr/Makefile.am A tests/smlc_subscr/smlc_subscr_test.c A tests/smlc_subscr/smlc_subscr_test.err A tests/smlc_subscr/smlc_subscr_test.ok M tests/testsuite.at 32 files changed, 2,890 insertions(+), 113 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/70/20470/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/20470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I917ba8fc51a1f1150be77ae01e12a7b16a853052 Gerrit-Change-Number: 20470 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: introduce osmo_use_count for bsc_subscr
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20351 ) Change subject: introduce osmo_use_count for bsc_subscr .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29bf60059d4cf7bb99a00753e6cdc149baf95f94 Gerrit-Change-Number: 20351 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 11:08:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: mgcp_vty: add user attributes to configuration commands
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/20250 ) Change subject: mgcp_vty: add user attributes to configuration commands .. Patch Set 6: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/20250/6/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/20250/6/src/libosmo-mgcp/mgcp_vty.c@406 PS6, Line 406: CMD_ATTR_IMMEDIATE It's not a configuration command, but a navigation command. We should not add any attributes to them. https://gerrit.osmocom.org/c/osmo-mgw/+/20250/6/src/libosmo-mgcp/mgcp_vty.c@930 PS6, Line 930: CMD_ATTR_IMMEDIATE Here I agree, because this command may allocate a new trunk. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/20250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2d9487801b3b78f94577264b56d217c926ef76a9 Gerrit-Change-Number: 20250 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 07 Oct 2020 10:33:15 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: vty: add attributes to VTY commands indicating when they apply
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/20319 ) Change subject: vty: add attributes to VTY commands indicating when they apply .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-trx/+/20319/2/CommonLibs/trx_vty.c File CommonLibs/trx_vty.c: https://gerrit.osmocom.org/c/osmo-trx/+/20319/2/CommonLibs/trx_vty.c@103 PS2, Line 103: CMD_ATTR_IMMEDIATE I still disagree with this one. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6dfdedc081eb8c3d53913f6fa38591920c8b3b43 Gerrit-Change-Number: 20319 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 10:28:12 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmo-sccp[master]: vty: add attributes to VTY commands indicating when they apply
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/20465 ) Change subject: vty: add attributes to VTY commands indicating when they apply .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/20465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: If77aea2223891663d465f162614ce8db18168c09 Gerrit-Change-Number: 20465 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 10:26:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: mgcp_vty: add user attributes to configuration commands
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/20250 ) Change subject: mgcp_vty: add user attributes to configuration commands .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/20250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2d9487801b3b78f94577264b56d217c926ef76a9 Gerrit-Change-Number: 20250 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 07 Oct 2020 10:27:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: vty: add attributes to VTY commands indicating when they apply
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/20319 ) Change subject: vty: add attributes to VTY commands indicating when they apply .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6dfdedc081eb8c3d53913f6fa38591920c8b3b43 Gerrit-Change-Number: 20319 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 07 Oct 2020 10:26:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-manuals[master]: vty_reference.xsl: also handle 'global' and 'library' attributes
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/20474 ) Change subject: vty_reference.xsl: also handle 'global' and 'library' attributes .. vty_reference.xsl: also handle 'global' and 'library' attributes Unfortunately, there is no xsl:function support in XSL 1.0, so we have to duplicate the existing code :/ For more details about the attribute scopes / types, see: https://lists.osmocom.org/pipermail/openbsc/2020-October/013278.html Change-Id: I7f7e6e32c156de24dcc80166a29119e6dda8c169 Related: SYS#4937 --- M vty_reference.xsl 1 file changed, 56 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/vty_reference.xsl b/vty_reference.xsl index 414a1a8..d7aaa8b 100644 --- a/vty_reference.xsl +++ b/vty_reference.xsl @@ -40,11 +40,66 @@ + + + + + + + + Global attributes + + + + + + + + Flag: + + + Flag: (not assigned) + + + + + + + + + + + + + + + Library specific attributes + + + + + + + + Flag: + + + Flag: (not assigned) + + + + + + + + + + - Attributes + Application specific attributes -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/20474 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I7f7e6e32c156de24dcc80166a29119e6dda8c169 Gerrit-Change-Number: 20474 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-gsm-manuals[master]: vty_reference.xsl: also handle 'global' and 'library' attributes
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/20474 ) Change subject: vty_reference.xsl: also handle 'global' and 'library' attributes .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/20474 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I7f7e6e32c156de24dcc80166a29119e6dda8c169 Gerrit-Change-Number: 20474 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 07 Oct 2020 10:25:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: add doc/location_services_ta.msc
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20381 ) Change subject: add doc/location_services_ta.msc .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9372c588bf8ee68a3995102b295198f35e32eec8 Gerrit-Change-Number: 20381 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 10:24:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: LCS: implement the bulk of Location Services
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20357 ) Change subject: LCS: implement the bulk of Location Services .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 10:24:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: refactor paging: add bsc_subscr to bsc_paging_params
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20349 ) Change subject: refactor paging: add bsc_subscr to bsc_paging_params .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I13621cd51d934846ff6556e1f2f8839da73a5dbb Gerrit-Change-Number: 20349 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 10:21:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: introduce osmo_use_count for bsc_subscr
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20351 ) Change subject: introduce osmo_use_count for bsc_subscr .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29bf60059d4cf7bb99a00753e6cdc149baf95f94 Gerrit-Change-Number: 20351 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 10:22:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: LCS: add paging reason, return in paging_request_stop()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20350 ) Change subject: LCS: add paging reason, return in paging_request_stop() .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0 Gerrit-Change-Number: 20350 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 10:22:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: refactor paging: introduce bsc_paging_params
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/20347 )
Change subject: refactor paging: introduce bsc_paging_params
..
refactor paging: introduce bsc_paging_params
For LCS, I would like to add an enum indicating the paging reason. Instead of
modifying extremely many function signatures to pass the reason across all
levels of paging, introduce a struct combining these.
Change-Id: I27ca78fc6ff8ef1101554c0a8429e34945ca6f3c
---
M include/osmocom/bsc/paging.h
M src/osmo-bsc/osmo_bsc_bssap.c
M src/osmo-bsc/paging.c
3 files changed, 111 insertions(+), 109 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/bsc/paging.h b/include/osmocom/bsc/paging.h
index 449a2eb..3dd5dc6 100644
--- a/include/osmocom/bsc/paging.h
+++ b/include/osmocom/bsc/paging.h
@@ -28,9 +28,28 @@
#include
#include
+#include
struct bsc_msc_data;
+#define LOG_PAGING(PARAMS, SUBSYS, LEVEL, fmt, args...) \
+ LOGP(SUBSYS, LEVEL, "(msc%d) Paging: %s TMSI-0x%08x: " fmt, \
+(PARAMS)->msc ? (PARAMS)->msc->nr : -1, \
+osmo_mobile_identity_to_str_c(OTC_SELECT, &(PARAMS)->imsi), \
+(PARAMS)->tmsi, \
+##args)
+
+#define LOG_PAGING_BTS(PARAMS, BTS, SUBSYS, LEVEL, fmt, args...) \
+ LOG_PAGING(PARAMS, SUBSYS, LEVEL, "(bts%u) " fmt, (BTS) ? (BTS)->nr :
255, ##args)
+
+struct bsc_paging_params {
+ struct bsc_msc_data *msc;
+ uint32_t tmsi;
+ struct osmo_mobile_identity imsi;
+ uint8_t chan_needed;
+ struct gsm0808_cell_id_list2 cil;
+};
+
/**
* A pending paging request
*/
@@ -56,8 +75,7 @@
};
/* schedule paging request */
-int paging_request_bts(struct gsm_bts *bts, struct bsc_subscr *bsub, int type,
- struct bsc_msc_data *msc);
+int paging_request_bts(const struct bsc_paging_params *params, struct
bsc_subscr *bsub, struct gsm_bts *bts);
struct bsc_msc_data *paging_request_stop(struct gsm_bts *bts, struct
bsc_subscr *bsub);
diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 65fee04..3c00d68 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -115,37 +115,34 @@
* The msc parameter is the MSC which issued the corresponding paging request.
* Log an error if paging failed. */
static void
-page_subscriber(struct bsc_msc_data *msc, struct gsm_bts *bts,
-uint32_t tmsi, uint32_t lac, const char *mi_string, uint8_t chan_needed)
+page_subscriber(const struct bsc_paging_params *params, struct gsm_bts *bts,
uint32_t lac)
{
struct bsc_subscr *subscr;
int ret;
if (!bsc_grace_allow_new_connection(bsc_gsmnet, bts)) {
- LOGP(DMSC, LOGL_DEBUG, "RF-locked: not paging on BTS %u\n",
bts->nr);
+ LOG_PAGING_BTS(params, bts, DMSC, LOGL_DEBUG, "RF-locked: not
paging on this BTS\n");
return;
}
- subscr =
bsc_subscr_find_or_create_by_imsi(msc->network->bsc_subscribers,
- mi_string);
+ subscr = bsc_subscr_find_or_create_by_mi(bsc_gsmnet->bsc_subscribers,
>imsi);
if (subscr)
log_set_context(LOG_CTX_BSC_SUBSCR, subscr);
- LOGP(DMSC, LOGL_INFO, "Paging request from MSC BTS: %d IMSI: '%s' TMSI:
'0x%x/%u' LAC: 0x%x\n",
- bts->nr, mi_string, tmsi, tmsi, lac);
+ LOG_PAGING_BTS(params, bts, DMSC, LOGL_INFO, "Paging on LAC %u\n", lac);
if (!subscr) {
- LOGP(DMSC, LOGL_ERROR, "Paging request failed: Could not
allocate subscriber for %s\n", mi_string);
+ LOGP(DMSC, LOGL_ERROR, "Paging request failed: Could not
allocate subscriber for %s\n",
+osmo_mobile_identity_to_str_c(OTC_SELECT, >imsi));
return;
}
- subscr->tmsi = tmsi;
-
- ret = paging_request_bts(bts, subscr, chan_needed, msc);
+ subscr->tmsi = params->tmsi;
+ ret = paging_request_bts(params, subscr, bts);
if (ret == 0)
- LOGP(DMSC, LOGL_INFO, "Paging request failed or repeated
paging: BTS: %d IMSI: '%s' TMSI: '0x%x/%u' LAC: 0x%x\n",
-bts->nr, mi_string, tmsi, tmsi, lac);
+ LOG_PAGING_BTS(params, bts, DMSC, LOGL_INFO,
+ "Paging request failed, or repeated paging on
LAC %u\n", lac);
/* the paging code has grabbed its own references */
bsc_subscr_put(subscr);
@@ -154,141 +151,132 @@
}
static void
-page_all_bts(struct bsc_msc_data *msc, uint32_t tmsi, const char *mi_string,
uint8_t chan_needed)
+page_all_bts(const struct bsc_paging_params *params)
{
struct gsm_bts *bts;
- llist_for_each_entry(bts, >network->bts_list, list)
- page_subscriber(msc, bts, tmsi, GSM_LAC_RESERVED_ALL_BTS,
mi_string, chan_needed);
+ llist_for_each_entry(bts,
Change in osmo-bsc[master]: refactor paging: introduce bsc_paging_params
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20347 ) Change subject: refactor paging: introduce bsc_paging_params .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I27ca78fc6ff8ef1101554c0a8429e34945ca6f3c Gerrit-Change-Number: 20347 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 07 Oct 2020 10:20:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: compl l3: parse Mobile Identity once
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/20341 )
Change subject: compl l3: parse Mobile Identity once
..
compl l3: parse Mobile Identity once
Move two calls of osmo_mobile_identity_decode_from_l3() from bsc_find_msc() and
handle_page_resp() out into a single call in bsc_compl_l3().
Prepares cosmetically for upcoming LCS patch.
Change-Id: I26950b63621417da0ed3125d0dc0b06cf015cb4a
---
M src/osmo-bsc/gsm_08_08.c
1 file changed, 27 insertions(+), 28 deletions(-)
Approvals:
laforge: Looks good to me, approved
Vadim Yanitskiy: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index 9dc54d1..c37b57f 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -184,13 +184,12 @@
* c) All other cases distribute the messages across connected MSCs in a
round-robin fashion.
*/
static struct bsc_msc_data *bsc_find_msc(struct gsm_subscriber_connection
*conn,
- struct msgb *msg)
+struct msgb *msg, const struct
osmo_mobile_identity *mi)
{
struct gsm_network *net = conn->network;
struct gsm48_hdr *gh;
int8_t pdisc;
uint8_t mtype;
- struct osmo_mobile_identity mi;
struct bsc_msc_data *msc;
struct bsc_msc_data *msc_target = NULL;
struct bsc_msc_data *msc_round_robin_next = NULL;
@@ -213,44 +212,34 @@
is_emerg = (pdisc == GSM48_PDISC_MM && mtype ==
GSM48_MT_MM_CM_SERV_REQ) && is_cm_service_for_emerg(msg);
- if (osmo_mobile_identity_decode_from_l3(, msg, false)) {
- LOG_COMPL_L3(pdisc, mtype, LOGL_ERROR, "Cannot extract Mobile
Identity: %s\n",
-msgb_hexdump_c(OTC_SELECT, msg));
- /* There is no Mobile Identity to pick a matching MSC from.
Likely this is an invalid Complete Layer 3
-* message that deserves to be rejected. However, the current
state of our ttcn3 tests does send invalid
-* Layer 3 Info in some tests and expects osmo-bsc to not care
about that. So, changing the behavior to
-* rejecting on missing MI causes test failure and, if at all,
should happen in a separate patch.
-* See e.g. BSC_Tests.TC_chan_rel_rll_rel_ind: "dt :=
f_est_dchan('23'O, 23, '00010203040506'O);" */
- }
-
/* Has the subscriber been paged from a connected MSC? */
bts = conn_get_bts(conn);
if (bts && pdisc == GSM48_PDISC_RR && mtype == GSM48_MT_RR_PAG_RESP) {
- subscr = bsc_subscr_find_by_mi(conn->network->bsc_subscribers,
);
+ subscr = bsc_subscr_find_by_mi(conn->network->bsc_subscribers,
mi);
if (subscr) {
msc_target = paging_get_msc(bts, subscr);
bsc_subscr_put(subscr);
if (is_msc_usable(msc_target, is_emerg)) {
LOG_COMPL_L3(pdisc, mtype, LOGL_DEBUG, "%s
matches earlier Paging from msc %d\n",
-
osmo_mobile_identity_to_str_c(OTC_SELECT, ), msc_target->nr);
+
osmo_mobile_identity_to_str_c(OTC_SELECT, mi), msc_target->nr);
rate_ctr_inc(_target->msc_ctrs->ctr[MSC_CTR_MSCPOOL_SUBSCR_PAGED]);
return msc_target;
} else {
LOG_COMPL_L3(pdisc, mtype, LOGL_DEBUG,
"%s matches earlier Paging from
msc %d, but this MSC is not connected\n",
-
osmo_mobile_identity_to_str_c(OTC_SELECT, ), msc_target->nr);
+
osmo_mobile_identity_to_str_c(OTC_SELECT, mi), msc_target->nr);
}
msc_target = NULL;
}
}
#define LOG_NRI(LOGLEVEL, FORMAT, ARGS...) \
- LOGP(DMSC, LOGLEVEL, "%s NRI(%d)=0x%x=%d: " FORMAT,
osmo_mobile_identity_to_str_c(OTC_SELECT, ), \
+ LOGP(DMSC, LOGLEVEL, "%s NRI(%d)=0x%x=%d: " FORMAT,
osmo_mobile_identity_to_str_c(OTC_SELECT, mi), \
net->nri_bitlen, nri_v, nri_v, ##ARGS)
/* Extract NRI bits from TMSI, possibly indicating which MSC is
responsible */
- if (mi.type == GSM_MI_TYPE_TMSI) {
- if (osmo_tmsi_nri_v_get(_v, mi.tmsi, net->nri_bitlen)) {
+ if (mi->type == GSM_MI_TYPE_TMSI) {
+ if (osmo_tmsi_nri_v_get(_v, mi->tmsi, net->nri_bitlen)) {
LOGP(DMSC, LOGL_ERROR, "Unable to retrieve NRI from
TMSI, nri_bitlen == %u\n", net->nri_bitlen);
nri_v = -1;
} else if (is_lu_from_other_plmn(msg)) {
@@ -328,7
Change in osmo-bsc[master]: gscon_bssmap_clear(): guard against NULL msc
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/20339 )
Change subject: gscon_bssmap_clear(): guard against NULL msc
..
gscon_bssmap_clear(): guard against NULL msc
Change-Id: I95b16cebb6ff78649f72a09b5d6c7c7e403233fa
---
M src/osmo-bsc/bsc_subscr_conn_fsm.c
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c
b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index 63e54ba..6bfada3 100644
--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c
+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c
@@ -146,12 +146,18 @@
return;
}
+ if (!conn->sccp.msc) {
+ LOGPFSML(conn->fi, LOGL_ERROR, "Unable to deliver BSSMAP Clear
Request message, no MSC for this conn\n");
+ return;
+ }
+
LOGPFSML(conn->fi, LOGL_DEBUG, "Tx BSSMAP CLEAR REQUEST(%s) to MSC\n",
gsm0808_cause_name(cause));
resp = gsm0808_create_clear_rqst(cause);
if (!resp) {
LOGPFSML(conn->fi, LOGL_ERROR, "Unable to compose BSSMAP Clear
Request message\n");
return;
}
+
rate_ctr_inc(>sccp.msc->msc_ctrs->ctr[MSC_CTR_BSSMAP_TX_DT1_CLEAR_RQST]);
rc = osmo_bsc_sigtran_send(conn, resp);
if (rc < 0)
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20339
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I95b16cebb6ff78649f72a09b5d6c7c7e403233fa
Gerrit-Change-Number: 20339
Gerrit-PatchSet: 3
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-CC: Vadim Yanitskiy
Gerrit-MessageType: merged
Change in osmo-bsc[master]: gscon_bssmap_clear(): guard against NULL msc
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20339 ) Change subject: gscon_bssmap_clear(): guard against NULL msc .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I95b16cebb6ff78649f72a09b5d6c7c7e403233fa Gerrit-Change-Number: 20339 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Vadim Yanitskiy Gerrit-Comment-Date: Wed, 07 Oct 2020 10:19:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: compl l3: move all message parsing out of bsc_find_msc()
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/20346 )
Change subject: compl l3: move all message parsing out of bsc_find_msc()
..
compl l3: move all message parsing out of bsc_find_msc()
I lost count of how many times the gsm48_hdr got parsed from the msg in the
same compl l3 code path. Here is one less.
Change-Id: I9f15b3e5e7352ef90b4598dadf2ebc0d2665f069
---
M src/osmo-bsc/gsm_08_08.c
1 file changed, 10 insertions(+), 23 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index 984e830..9f3812a 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -184,33 +184,18 @@
*conn.
* c) All other cases distribute the messages across connected MSCs in a
round-robin fashion.
*/
-static struct bsc_msc_data *bsc_find_msc(struct gsm_subscriber_connection
*conn,
-struct msgb *msg, const struct
osmo_mobile_identity *mi)
+static struct bsc_msc_data *bsc_find_msc(struct gsm_subscriber_connection
*conn, const struct osmo_mobile_identity *mi,
+bool is_emerg, bool from_other_plmn)
{
struct gsm_network *net = conn->network;
- struct gsm48_hdr *gh;
- int8_t pdisc;
- uint8_t mtype;
struct bsc_msc_data *msc;
struct bsc_msc_data *msc_target = NULL;
struct bsc_msc_data *msc_round_robin_next = NULL;
struct bsc_msc_data *msc_round_robin_first = NULL;
uint8_t round_robin_next_nr;
- bool is_emerg = false;
int16_t nri_v = -1;
bool is_null_nri = false;
- if (msgb_l3len(msg) < sizeof(*gh)) {
- LOGP(DRSL, LOGL_ERROR, "There is no GSM48 header here.\n");
- return NULL;
- }
-
- gh = msgb_l3(msg);
- pdisc = gsm48_hdr_pdisc(gh);
- mtype = gsm48_hdr_msg_type(gh);
-
- is_emerg = (pdisc == GSM48_PDISC_MM && mtype ==
GSM48_MT_MM_CM_SERV_REQ) && is_cm_service_for_emerg(msg);
-
#define LOG_NRI(LOGLEVEL, FORMAT, ARGS...) \
LOGP(DMSC, LOGLEVEL, "%s NRI(%d)=0x%x=%d: " FORMAT,
osmo_mobile_identity_to_str_c(OTC_SELECT, mi), \
net->nri_bitlen, nri_v, nri_v, ##ARGS)
@@ -220,7 +205,7 @@
if (osmo_tmsi_nri_v_get(_v, mi->tmsi, net->nri_bitlen)) {
LOGP(DMSC, LOGL_ERROR, "Unable to retrieve NRI from
TMSI, nri_bitlen == %u\n", net->nri_bitlen);
nri_v = -1;
- } else if (is_lu_from_other_plmn(msg)) {
+ } else if (from_other_plmn) {
/* If a subscriber was previously attached to a
different PLMN, it might still send the other
* PLMN's TMSI identity in an IMSI Attach. The LU sends
a LAI indicating the previous PLMN. If
* it mismatches our PLMN, ignore the NRI. */
@@ -294,8 +279,6 @@
* them are usable -- wrap to the start. */
msc_target = msc_round_robin_next ? : msc_round_robin_first;
if (!msc_target) {
- LOG_COMPL_L3(pdisc, mtype, LOGL_ERROR, "%s%s: No suitable MSC
for this Complete Layer 3 request found\n",
-osmo_mobile_identity_to_str_c(OTC_SELECT, mi),
is_emerg ? " FOR EMERGENCY CALL" : "");
rate_ctr_inc(_gsmnet->bsc_ctrs->ctr[BSC_CTR_MSCPOOL_SUBSCR_NO_MSC]);
if (is_emerg)
rate_ctr_inc(_gsmnet->bsc_ctrs->ctr[BSC_CTR_MSCPOOL_EMERG_LOST]);
@@ -393,6 +376,7 @@
struct osmo_mobile_identity mi;
struct gsm48_hdr *gh;
uint8_t pdisc, mtype;
+ bool is_emerg;
bool release_lchan = true;
if (msgb_l3len(msg) < sizeof(*gh)) {
@@ -435,6 +419,8 @@
log_set_context(LOG_CTX_BSC_SUBSCR, conn->bsub);
+ is_emerg = (pdisc == GSM48_PDISC_MM && mtype ==
GSM48_MT_MM_CM_SERV_REQ) && is_cm_service_for_emerg(msg);
+
/* When receiving a Paging Response, stop Paging for this subscriber on
all cells, and figure out which MSC
* sent the Paging Request, if any. */
paged_from_msc = NULL;
@@ -449,7 +435,7 @@
rate_ctr_inc(>bts_ctrs->ctr[BTS_CTR_PAGING_NO_ACTIVE_PAGING]);
rate_ctr_inc(_gsmnet->bsc_ctrs->ctr[BSC_CTR_PAGING_NO_ACTIVE_PAGING]);
- } else if (is_msc_usable(paged_from_msc, false)) {
+ } else if (is_msc_usable(paged_from_msc, is_emerg)) {
LOG_COMPL_L3(pdisc, mtype, LOGL_DEBUG, "%s matches
earlier Paging from msc %d\n",
osmo_mobile_identity_to_str_c(OTC_SELECT,
), paged_from_msc->nr);
rate_ctr_inc(_from_msc->msc_ctrs->ctr[MSC_CTR_MSCPOOL_SUBSCR_PAGED]);
@@ -465,9 +451,10 @@
if (paged_from_msc)
