Change in osmocom-bb[master]: trxcon/l1ctl_link: use osmo_store16be() in l1ctl_link_send()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmocom-bb/+/21048 )
Change subject: trxcon/l1ctl_link: use osmo_store16be() in l1ctl_link_send()
..
trxcon/l1ctl_link: use osmo_store16be() in l1ctl_link_send()
Change-Id: I96ca1c581d028a1f3c89c83a575fd8dbc9751962
---
M src/host/trxcon/l1ctl_link.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/48/21048/1
diff --git a/src/host/trxcon/l1ctl_link.c b/src/host/trxcon/l1ctl_link.c
index 2e2963a..4c406d6 100644
--- a/src/host/trxcon/l1ctl_link.c
+++ b/src/host/trxcon/l1ctl_link.c
@@ -184,7 +184,7 @@
int l1ctl_link_send(struct l1ctl_link *l1l, struct msgb *msg)
{
- uint16_t *len;
+ uint8_t *len;
/* Debug print */
LOGP(DL1D, LOGL_DEBUG, "TX: '%s'\n",
@@ -194,8 +194,8 @@
LOGP(DL1D, LOGL_INFO, "Message L1 header != Message Data\n");
/* Prepend 16-bit length before sending */
- len = (uint16_t *) msgb_push(msg, L1CTL_MSG_LEN_FIELD);
- *len = htons(msg->len - L1CTL_MSG_LEN_FIELD);
+ len = msgb_push(msg, L1CTL_MSG_LEN_FIELD);
+ osmo_store16be(msg->len - L1CTL_MSG_LEN_FIELD, len);
if (osmo_wqueue_enqueue(&l1l->wq, msg) != 0) {
LOGP(DL1D, LOGL_ERROR, "Failed to enqueue msg!\n");
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/21048
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I96ca1c581d028a1f3c89c83a575fd8dbc9751962
Gerrit-Change-Number: 21048
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 93s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 93s] [COMPILING libboard/qmod/source/card_pres.c] [ 93s] [COMPILING libboard/qmod/source/wwan_led.c] [ 93s] [COMPILING libboard/qmod/source/i2c.c] [ 93s] [COMPILING libboard/qmod/source/board_qmod.c] [ 93s] [COMPILING apps/dfu/main.c] [ 94s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 94s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 94s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 94s] Memory region Used Size Region Size %age Used [ 94s] rom: 16588 B16 KB101.25% [ 94s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 94s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 204 bytes [ 94s] collect2: error: ld returned 1 exit status [ 94s] % [ 94s] make[2]: *** [Makefile:234: flash] Error 1 [ 94s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 94s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 94s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 94s] dh_auto_build: error: make -j1 returned exit code 2 [ 94s] make: *** [debian/rules:16: build] Error 25 [ 94s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 94s] ### VM INTERACTION START ### [ 97s] [ 89.883245] sysrq: Power Off [ 97s] [ 89.884793] reboot: Power down [ 97s] ### VM INTERACTION END ### [ 97s] [ 97s] build79 failed "build simtrace2_0.7.0.69.aadd.dsc" at Thu Nov 5 01:41:30 UTC 2020. [ 97s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 99s] [COMPILING apps/dfu/main.c] [ 99s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 99s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 99s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 99s] Memory region Used Size Region Size %age Used [ 99s] rom: 16580 B16 KB101.20% [ 99s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 99s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 99s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 99s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 99s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 99s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 99s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 196 bytes [ 99s] collect2: error: ld returned 1 exit status [ 99s] % [ 99s] make[2]: *** [Makefile:234: flash] Error 1 [ 99s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 99s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 99s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 99s] dh_auto_build: error: make -j1 returned exit code 2 [ 99s] make: *** [debian/rules:16: build] Error 25 [ 99s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 99s] ### VM INTERACTION START ### [ 102s] [ 94.946373] sysrq: Power Off [ 102s] [ 94.947694] reboot: Power down [ 102s] ### VM INTERACTION END ### [ 102s] [ 102s] build73 failed "build simtrace2_0.7.0.69.aadd.dsc" at Thu Nov 5 01:38:21 UTC 2020. [ 102s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-pcu[master]: pcuif: Improve BTS-supported CS/MCS handling
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/20990 )
Change subject: pcuif: Improve BTS-supported CS/MCS handling
..
pcuif: Improve BTS-supported CS/MCS handling
Take into account the MCS values supported by the BTS. In osmo-bts,
in general all MCS are enabled if "mode egprs" is selected in BSC,
and none otherwise.
Change-Id: Ie8f0215ba17da1e545e98bec9325c02f1e8efaea
---
M src/bts.cpp
M src/bts.h
M src/gprs_bssgp_pcu.cpp
M src/pcu_l1_if.cpp
M tests/emu/pcu_emu.cpp
5 files changed, 50 insertions(+), 40 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
diff --git a/src/bts.cpp b/src/bts.cpp
index 6a7960c..359f2d5 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -210,7 +210,7 @@
bts->fc_interval = 1;
bts->initial_cs_dl = bts->initial_cs_ul = 1;
bts->initial_mcs_dl = bts->initial_mcs_ul = 1;
- bts->cs1 = 1;
+ bts->cs_mask = 1 << 0; /* CS-1 always enabled by default */
bts->n3101 = 10;
bts->n3103 = 4;
bts->n3105 = 8;
diff --git a/src/bts.h b/src/bts.h
index a3fa975..7335483 100644
--- a/src/bts.h
+++ b/src/bts.h
@@ -110,10 +110,8 @@
uint32_t fc_bvc_leak_rate;
uint32_t fc_ms_bucket_size;
uint32_t fc_ms_leak_rate;
- uint8_t cs1;
- uint8_t cs2;
- uint8_t cs3;
- uint8_t cs4;
+ uint8_t cs_mask; /* Allowed CS mask from BTS */
+ uint16_t mcs_mask; /* Allowed MCS mask from BTS */
uint8_t initial_cs_dl, initial_cs_ul;
uint8_t initial_mcs_dl, initial_mcs_ul;
uint8_t max_cs_dl, max_cs_ul;
diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index 671629b..4b5582d 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -738,40 +738,49 @@
static enum CodingScheme max_coding_scheme_dl(struct gprs_rlcmac_bts *bts)
{
- int num;
+ int num = 0;
+ int i;
if (bts->egprs_enabled) {
if (!bts->cs_adj_enabled) {
- if (bts->initial_mcs_dl)
+ if (bts->initial_mcs_dl) {
num = bts->initial_mcs_dl;
- else
- num = 1;
+ } else {
+ for (i = 8; i >= 0; i--) {
+ if (bts->mcs_mask & (1 << i)) {
+ num = i + 1;
+ break;
+ }
+ }
+ }
} else if (bts->max_mcs_dl) {
num = bts->max_mcs_dl;
} else {
num = 9;
}
- return mcs_get_egprs_by_num(num);
+ if (num)
+ return mcs_get_egprs_by_num(num);
}
if (!bts->cs_adj_enabled) {
- if (bts->initial_cs_dl)
+ if (bts->initial_cs_dl) {
num = bts->initial_cs_dl;
- else if (bts->cs4)
- num = 4;
- else if (bts->cs3)
- num = 3;
- else if (bts->cs2)
- num = 2;
- else
- num = 1;
+ } else {
+ for (i = 3; i >= 0; i--) {
+ if (bts->cs_mask & (1 << i)) {
+ num = i + 1;
+ break;
+ }
+ }
+ }
} else if (bts->max_cs_dl) {
num = bts->max_cs_dl;
- } else {
- num = 4;
}
+ if (!num)
+ num = 4;
+
return mcs_get_gprs_by_num(num);
}
diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index 8a825a1..7e51763 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -551,7 +551,7 @@
struct gprs_bssgp_pcu *pcu;
int rc = 0;
unsigned int trx_nr, ts_nr;
- int i;
+ unsigned int i;
if (info_ind->version != PCU_IF_VERSION) {
fprintf(stderr, "PCU interface version number of BTS (%u) is "
@@ -613,16 +613,32 @@
LOGP(DL1IF, LOGL_DEBUG, " dl_tbf_ext=%d\n", info_ind->dl_tbf_ext);
LOGP(DL1IF, LOGL_DEBUG, " ul_tbf_ext=%d\n", info_ind->ul_tbf_ext);
bts->bsic = info_ind->bsic;
+
+ bts->cs_mask = 1 << 0; /* We need at least 1 CS, let's enable CS1 */
for (i = 0; i < 4; i++) {
- if ((info_ind->flags & (PCU_IF_FLAG_CS1 << i)))
- LOGP(DL1IF, LOGL_DEBUG, " Use CS%d\n", i+1);
+ uint8_t allowed = !!(info_ind->flags & (PCU_IF_FLAG_CS1 << i));
+ bts->cs_mask |= allowe
Change in osmo-pcu[master]: Move EGPRS MS mode set to gprs_ms.cpp
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/20991 )
Change subject: Move EGPRS MS mode set to gprs_ms.cpp
..
Move EGPRS MS mode set to gprs_ms.cpp
Some tests were wrong (TypesTest) and required modification, since they
were setting a EGPRS MS but then expecting a GPRS assignment.
Change-Id: I9d3ee21c765054a36bd22352e48bde5ffca9225a
---
M src/gprs_ms.cpp
M src/tbf.cpp
M tests/alloc/AllocTest.err
M tests/app_info/AppInfoTest.err
M tests/tbf/TbfTest.err
M tests/types/TypesTest.cpp
M tests/types/TypesTest.err
7 files changed, 77 insertions(+), 78 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
diff --git a/src/gprs_ms.cpp b/src/gprs_ms.cpp
index 3271a1d..9576c0d 100644
--- a/src/gprs_ms.cpp
+++ b/src/gprs_ms.cpp
@@ -540,6 +540,17 @@
tlli(), m_egprs_ms_class, ms_class_);
m_egprs_ms_class = ms_class_;
+
+ const struct gprs_rlcmac_bts *bts = m_bts->bts_data();
+ if (mcs_is_edge_gmsk(mcs_get_egprs_by_num(bts->max_mcs_ul)) &&
+ mcs_is_edge_gmsk(mcs_get_egprs_by_num(bts->max_mcs_dl)) &&
+ mode() != EGPRS)
+ {
+ set_mode(EGPRS_GMSK);
+ } else {
+ set_mode(EGPRS);
+ }
+ LOGPMS(this, DRLCMAC, LOGL_INFO, "Enabled EGPRS, mode %s\n",
mode_name(mode()));
}
void GprsMs::update_error_rate(gprs_rlcmac_tbf *tbf, int error_rate)
diff --git a/src/tbf.cpp b/src/tbf.cpp
index 4706eeb..4f685e8 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -117,18 +117,6 @@
tbf_ctr_description,
};
-static void setup_egprs_mode(gprs_rlcmac_bts *bts, GprsMs *ms)
-{
- if (mcs_is_edge_gmsk(mcs_get_egprs_by_num(bts->max_mcs_ul)) &&
- mcs_is_edge_gmsk(mcs_get_egprs_by_num(bts->max_mcs_dl)) &&
- ms->mode() != EGPRS)
- {
- ms->set_mode(EGPRS_GMSK);
- } else {
- ms->set_mode(EGPRS);
- }
-}
-
gprs_rlcmac_tbf::Meas::Meas() :
rssi_sum(0),
rssi_num(0)
@@ -757,11 +745,8 @@
struct gprs_rlcmac_bts *bts_data = bts->bts_data();
int rc;
- if (m_ms->egprs_ms_class() > 0 && bts_data->egprs_enabled) {
+ if (m_ms->egprs_ms_class() > 0)
enable_egprs();
- setup_egprs_mode(bts_data, m_ms);
- LOGPTBF(this, LOGL_INFO, "Enabled EGPRS, mode %s\n",
mode_name(m_ms->mode()));
- }
m_created_ts = time(NULL);
/* select algorithm */
diff --git a/tests/alloc/AllocTest.err b/tests/alloc/AllocTest.err
index 29b305b..99481be 100644
--- a/tests/alloc/AllocTest.err
+++ b/tests/alloc/AllocTest.err
@@ -202832,10 +202832,10 @@
[DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI
exhausted)
Allocated 160 TBFs (previously 160)
Allocating DL TBF: MS_CLASS=11/11
-TBF(TFI=0 TLLI=0x DIR=DL STATE=NULL) Setting Control TS 6
-TBF(TFI=0 TLLI=0x DIR=DL STATE=NULL) Allocated: trx = 0, ul_slots =
40, dl_slots = f0
+TBF(TFI=0 TLLI=0x DIR=DL STATE=NULL EGPRS) Setting Control TS 6
+TBF(TFI=0 TLLI=0x DIR=DL STATE=NULL EGPRS) Allocated: trx = 0,
ul_slots = 40, dl_slots = f0
Allocating DL TBF: MS_CLASS=11/11
-TBF(TFI=1 TLLI=0x DIR=DL STATE=NULL) Setting Control TS 5
-TBF(TFI=1 TLLI=0x DIR=DL STATE=NULL) Allocated: trx = 0, ul_slots =
20, dl_slots = 70
-TBF(TFI=0 TLLI=0x DIR=DL STATE=RELEASING) free
-TBF(TFI=1 TLLI=0x DIR=DL STATE=RELEASING) free
+TBF(TFI=1 TLLI=0x DIR=DL STATE=NULL EGPRS) Setting Control TS 5
+TBF(TFI=1 TLLI=0x DIR=DL STATE=NULL EGPRS) Allocated: trx = 0,
ul_slots = 20, dl_slots = 70
+TBF(TFI=0 TLLI=0x DIR=DL STATE=RELEASING EGPRS) free
+TBF(TFI=1 TLLI=0x DIR=DL STATE=RELEASING EGPRS) free
diff --git a/tests/app_info/AppInfoTest.err b/tests/app_info/AppInfoTest.err
index 6ef5d83..50ed2e1 100644
--- a/tests/app_info/AppInfoTest.err
+++ b/tests/app_info/AppInfoTest.err
@@ -13,20 +13,24 @@
Creating MS object, TLLI = 0x
Modifying MS object, TLLI = 0x, MS class 0 -> 10
Modifying MS object, TLLI = 0x, EGPRS MS class 0 -> 11
+MS(TLLI=0x, IMSI=, TA=220, 10/11,) Enabled EGPRS, mode EGPRS
[DL] algo B (suggested TRX: 0): using 4 slots
-PDCH(TS 4, TRX 0): Attaching TBF(TFI=0 TLLI=0x DIR=DL STATE=NULL), 1
TBFs, USFs = 00, TFIs = 0001.
-PDCH(TS 5, TRX 0): Attaching TBF(TFI=0 TLLI=0x DIR=DL STATE=NULL), 1
TBFs, USFs = 00, TFIs = 0001.
-PDCH(TS 6, TRX 0): Attaching TBF(TFI=0 TLLI=0x DIR=DL STATE=NULL), 1
TBFs, USFs = 00, TFIs = 0001.
-PDCH(TS 7, TRX 0): Attaching TBF(TFI=0 TLLI=0x DIR=DL STATE=NULL), 1
TBFs, USFs = 00, TFIs = 0001.
-Attaching TBF to MS object, TLLI = 0x, TBF = TBF(TFI=0 TLLI=0x
DIR=DL STATE=NULL)
+PDCH(TS 4, TRX 0): Attaching TBF(TFI=0 TLLI=0x
Change in osmo-bts[master]: osmo-bts-lc15: use consistent name for containing directory
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20955 ) Change subject: osmo-bts-lc15: use consistent name for containing directory .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I55c073fbd01aee42871101401d76d87e7c91832e Gerrit-Change-Number: 20955 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 22:53:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Move EGPRS MS mode set to gprs_ms.cpp
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20991 ) Change subject: Move EGPRS MS mode set to gprs_ms.cpp .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9d3ee21c765054a36bd22352e48bde5ffca9225a Gerrit-Change-Number: 20991 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 04 Nov 2020 21:35:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: pcuif: Improve BTS-supported CS/MCS handling
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20990 ) Change subject: pcuif: Improve BTS-supported CS/MCS handling .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie8f0215ba17da1e545e98bec9325c02f1e8efaea Gerrit-Change-Number: 20990 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: lynxis lazus Gerrit-Comment-Date: Wed, 04 Nov 2020 21:33:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: gprs_ms: Avoid enabling EGPRS if no MCS are supported
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21046 ) Change subject: gprs_ms: Avoid enabling EGPRS if no MCS are supported .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/21046/2/src/gprs_ms.cpp File src/gprs_ms.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/21046/2/src/gprs_ms.cpp@546 PS2, Line 546: Avoid enabling This sounds like a recommendation to the user who reads logs, 'Not enabling' fits better IMHO. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib19e9e006d851c2147de15f4aec36ab65250bdd3 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 04 Nov 2020 21:25:23 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Fix msc_is_valid(): UNKNOWN value is not a valid (M)CS
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21045 ) Change subject: Fix msc_is_valid(): UNKNOWN value is not a valid (M)CS .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21045 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0a973e10cd9477f72d8bd47a06048414b33ae96a Gerrit-Change-Number: 21045 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 04 Nov 2020 21:23:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-lc15: use consistent name for containing directory
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/20955 to look at the new patch set (#5). Change subject: osmo-bts-lc15: use consistent name for containing directory .. osmo-bts-lc15: use consistent name for containing directory The binary is called 'osmo-bts-lc15', while the containing folder is named 'osmo-bts-litecell15'. This inconsistency complicates automatic generation of the XML VTY reference - fix it. Change-Id: I55c073fbd01aee42871101401d76d87e7c91832e Related: SYS#4937, OS#3036 --- M .gitignore M configure.ac M src/Makefile.am R src/osmo-bts-lc15/Makefile.am R src/osmo-bts-lc15/calib_file.c R src/osmo-bts-lc15/hw_misc.c R src/osmo-bts-lc15/hw_misc.h R src/osmo-bts-lc15/l1_if.c R src/osmo-bts-lc15/l1_if.h R src/osmo-bts-lc15/l1_transp.h R src/osmo-bts-lc15/l1_transp_hw.c R src/osmo-bts-lc15/lc15bts.c R src/osmo-bts-lc15/lc15bts.h R src/osmo-bts-lc15/lc15bts_vty.c R src/osmo-bts-lc15/main.c R src/osmo-bts-lc15/misc/lc15bts_bid.c R src/osmo-bts-lc15/misc/lc15bts_bid.h R src/osmo-bts-lc15/misc/lc15bts_bts.c R src/osmo-bts-lc15/misc/lc15bts_bts.h R src/osmo-bts-lc15/misc/lc15bts_clock.c R src/osmo-bts-lc15/misc/lc15bts_clock.h R src/osmo-bts-lc15/misc/lc15bts_led.c R src/osmo-bts-lc15/misc/lc15bts_led.h R src/osmo-bts-lc15/misc/lc15bts_mgr.c R src/osmo-bts-lc15/misc/lc15bts_mgr.h R src/osmo-bts-lc15/misc/lc15bts_mgr_calib.c R src/osmo-bts-lc15/misc/lc15bts_mgr_nl.c R src/osmo-bts-lc15/misc/lc15bts_mgr_temp.c R src/osmo-bts-lc15/misc/lc15bts_mgr_vty.c R src/osmo-bts-lc15/misc/lc15bts_misc.c R src/osmo-bts-lc15/misc/lc15bts_misc.h R src/osmo-bts-lc15/misc/lc15bts_nl.c R src/osmo-bts-lc15/misc/lc15bts_nl.h R src/osmo-bts-lc15/misc/lc15bts_par.c R src/osmo-bts-lc15/misc/lc15bts_par.h R src/osmo-bts-lc15/misc/lc15bts_power.c R src/osmo-bts-lc15/misc/lc15bts_power.h R src/osmo-bts-lc15/misc/lc15bts_swd.c R src/osmo-bts-lc15/misc/lc15bts_swd.h R src/osmo-bts-lc15/misc/lc15bts_temp.c R src/osmo-bts-lc15/misc/lc15bts_temp.h R src/osmo-bts-lc15/misc/lc15bts_util.c R src/osmo-bts-lc15/oml.c R src/osmo-bts-lc15/tch.c R src/osmo-bts-lc15/utils.c R src/osmo-bts-lc15/utils.h 46 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/55/20955/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I55c073fbd01aee42871101401d76d87e7c91832e Gerrit-Change-Number: 20955 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-gsm-manuals[master]: Makefile.docbook.inc: generate *.pdf in the given directory
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/21026 ) Change subject: Makefile.docbook.inc: generate *.pdf in the given directory .. Makefile.docbook.inc: generate *.pdf in the given directory Change-Id: If6d19dd0359239582d41ab3577c4b8bada4c81b8 Related: SYS#4937 --- M build/Makefile.docbook.inc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/build/Makefile.docbook.inc b/build/Makefile.docbook.inc index 22e9bb4..eb0ee25 100644 --- a/build/Makefile.docbook.inc +++ b/build/Makefile.docbook.inc @@ -38,5 +38,5 @@ # xslt path: find includes in both $(OSMO_GSM_MANUALS_DIR)/common/chapters and $(builddir)/generated %.pdf: %.xml %.xml-lint $(DOCBOOKS_DEPS) build common dblatex --xslt-opts="--path $(realpath $(OSMO_GSM_MANUALS_DIR))/common/chapters:$(INC_DIR)" \ - $(dblatex_quiet) -P draft.mode=no -o $(notdir $@) $< + $(dblatex_quiet) -P draft.mode=no -o $@ $< -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/21026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: If6d19dd0359239582d41ab3577c4b8bada4c81b8 Gerrit-Change-Number: 21026 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: pcu: prepare tests for new GPRS/EGPRS multiplex support
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20984 ) Change subject: pcu: prepare tests for new GPRS/EGPRS multiplex support .. Patch Set 2: > Patch Set 2: > > Well, ok, what do you think about f_init_raw_egprs() then? Why do you want that? simply pass a different template if needed. I don't see an issue with that. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib95aae155b0712313a30f0c5404a8cb1f28b98f5 Gerrit-Change-Number: 20984 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 04 Nov 2020 20:38:39 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: tdef: Introduce OSMO_TDEF_US unit
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/21047 )
Change subject: tdef: Introduce OSMO_TDEF_US unit
..
tdef: Introduce OSMO_TDEF_US unit
Some applications may need submillisecond timers, such as those
interacting with modbus serial lines (RS-485, RTU), which require
timers of values around 1.5 char-time (T1.5), where a data char is
composed of 11 bits sent on the line: 1 start bit, 8 data bits,
1 stop bit, and and parity bit (or 2nd stop bits if no parity).
For instance, for a baudrate of 9600:
1.5 * 11 / 9600 = 1.718 ms = 1718 us
So having a granularity of MS is not enough here.
Change-Id: I71848d7c1ee0649929ce07680ee7320bb2a42f0e
---
M include/osmocom/core/tdef.h
M src/tdef.c
M tests/tdef/tdef_test.c
M tests/tdef/tdef_test.ok
4 files changed, 49 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/21047/1
diff --git a/include/osmocom/core/tdef.h b/include/osmocom/core/tdef.h
index 54819d9..627ba3f 100644
--- a/include/osmocom/core/tdef.h
+++ b/include/osmocom/core/tdef.h
@@ -40,6 +40,7 @@
OSMO_TDEF_MS, /*!< milliseconds */
OSMO_TDEF_M,/*!< minutes */
OSMO_TDEF_CUSTOM, /*!< unspecified unit, explained in
osmo_tdef.desc. */
+ OSMO_TDEF_US, /*!< microseconds */
};
extern const struct value_string osmo_tdef_unit_names[];
diff --git a/src/tdef.c b/src/tdef.c
index 71a3315..897a92f 100644
--- a/src/tdef.c
+++ b/src/tdef.c
@@ -93,6 +93,17 @@
return 1;
switch (b) {
+ case OSMO_TDEF_US:
+ switch (a) {
+ case OSMO_TDEF_MS:
+ return 1000;
+ case OSMO_TDEF_S:
+ return 1000*1000;
+ case OSMO_TDEF_M:
+ return 60*1000*1000;
+ default:
+ return 0;
+ }
case OSMO_TDEF_MS:
switch (a) {
case OSMO_TDEF_S:
@@ -351,6 +362,7 @@
{ OSMO_TDEF_MS, "ms" },
{ OSMO_TDEF_M, "m" },
{ OSMO_TDEF_CUSTOM, "custom-unit" },
+ { OSMO_TDEF_US, "us" },
{}
};
diff --git a/tests/tdef/tdef_test.c b/tests/tdef/tdef_test.c
index 9c0808e..ae5e206 100644
--- a/tests/tdef/tdef_test.c
+++ b/tests/tdef/tdef_test.c
@@ -54,6 +54,7 @@
{ .T=1006, .default_val=0, .unit=OSMO_TDEF_S, .desc="zero s" },
{ .T=1007, .default_val=0, .unit=OSMO_TDEF_M, .desc="zero m" },
{ .T=1008, .default_val=0, .unit=OSMO_TDEF_CUSTOM, .desc="zero" },
+ { .T=1009, .default_val=0, .unit=OSMO_TDEF_US, .desc="zero" },
{ .T=0, .default_val=1, .unit=OSMO_TDEF_CUSTOM, .desc="zero" },
@@ -111,7 +112,7 @@
for (i = 0; i < ARRAY_SIZE(tdefs)-1; i++) {
unsigned int T = tdefs[i].T;
print_tdef_info(T);
- for (as_unit = OSMO_TDEF_S; as_unit <= OSMO_TDEF_CUSTOM;
as_unit++) {
+ for (as_unit = OSMO_TDEF_S; as_unit <= OSMO_TDEF_US; as_unit++)
{
print_tdef_get_short(tdefs, T, as_unit);
}
}
@@ -122,7 +123,7 @@
for (i = 0; i < ARRAY_SIZE(tdefs_range)-1; i++) {
unsigned int T = tdefs_range[i].T;
print_tdef_info(T);
- for (as_unit = OSMO_TDEF_S; as_unit <= OSMO_TDEF_CUSTOM;
as_unit++) {
+ for (as_unit = OSMO_TDEF_S; as_unit <= OSMO_TDEF_US; as_unit++)
{
print_tdef_get_short(tdefs_range, T, as_unit);
}
}
@@ -136,6 +137,7 @@
print_tdef_get(tdefs, 5, OSMO_TDEF_MS);
print_tdef_get(tdefs, 5, OSMO_TDEF_M);
print_tdef_get(tdefs, 5, OSMO_TDEF_CUSTOM);
+ print_tdef_get(tdefs, 5, OSMO_TDEF_US);
}
static void test_tdef_set_and_get()
@@ -152,6 +154,7 @@
print_tdef_get_short(tdefs, 7, OSMO_TDEF_S);
print_tdef_get_short(tdefs, 7, OSMO_TDEF_M);
print_tdef_get_short(tdefs, 7, OSMO_TDEF_CUSTOM);
+ print_tdef_get_short(tdefs, 7, OSMO_TDEF_US);
printf("setting 7 = 420\n");
OSMO_ASSERT(osmo_tdef_set(tdefs, 7, 420, OSMO_TDEF_S) == 0);
@@ -160,6 +163,7 @@
print_tdef_get_short(tdefs, 7, OSMO_TDEF_S);
print_tdef_get_short(tdefs, 7, OSMO_TDEF_M);
print_tdef_get_short(tdefs, 7, OSMO_TDEF_CUSTOM);
+ print_tdef_get_short(tdefs, 7, OSMO_TDEF_US);
printf("setting 7 = 10 (ERANGE)\n");
OSMO_ASSERT(!osmo_tdef_val_in_range(t, 10));
@@ -169,6 +173,7 @@
print_tdef_get_short(tdefs, 7, OSMO_TDEF_S);
print_tdef_get_short(tdefs, 7, OSMO_TDEF_M);
print_tdef_get_short(tdefs, 7, OSMO_TDEF_CUSTOM);
+ print_tdef_get_short(tdefs, 7, OSMO_TDEF_US);
printf("setting 7 = 900 (ERANGE)\n");
OSMO_ASSERT(!osmo_tdef_val_in_range(t, 900));
@@ -178,6 +183,7 @@
print_tdef_get_short(tdefs, 7, OSM
Change in osmo-gsm-manuals[master]: Makefile.docbook.inc: generate *.pdf in the given directory
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/21026 ) Change subject: Makefile.docbook.inc: generate *.pdf in the given directory .. Patch Set 1: Code-Review+2 This is the last change that block automatic VTY reference generation for osmo-bts and osmo-trx. Let's get it merged ASAP, on my own responsibility. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/21026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: If6d19dd0359239582d41ab3577c4b8bada4c81b8 Gerrit-Change-Number: 21026 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 19:54:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: prepare tests for new GPRS/EGPRS multiplex support
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20984 ) Change subject: pcu: prepare tests for new GPRS/EGPRS multiplex support .. Patch Set 2: Well, ok, what do you think about f_init_raw_egprs() then? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib95aae155b0712313a30f0c5404a8cb1f28b98f5 Gerrit-Change-Number: 20984 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 04 Nov 2020 19:40:34 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_cs_initial_dl
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21035 ) Change subject: pcu: Introduce test TC_cs_initial_dl .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I00bae15a007935cc4e027e63de4367d83e994bd7 Gerrit-Change-Number: 21035 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 04 Nov 2020 19:39:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Implement check for expected (M)CS in received data block
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21034 ) Change subject: pcu: Implement check for expected (M)CS in received data block .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdc63f6b695c08e4ddf5894c22767d07acf21311 Gerrit-Change-Number: 21034 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 04 Nov 2020 19:38:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: RLCMAC_EncDec: Provide decoded (m)cs in (E)GPRS data blocks
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21033 ) Change subject: RLCMAC_EncDec: Provide decoded (m)cs in (E)GPRS data blocks .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I80ed44e575cc0a11510832e5bbfc07173e7b75b8 Gerrit-Change-Number: 21033 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 04 Nov 2020 19:38:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: prepare tests for new GPRS/EGPRS multiplex support
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20984 ) Change subject: pcu: prepare tests for new GPRS/EGPRS multiplex support .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib95aae155b0712313a30f0c5404a8cb1f28b98f5 Gerrit-Change-Number: 20984 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 04 Nov 2020 19:38:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_ul_multislot_tbf_ms_class_from_2phase
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20983 ) Change subject: pcu: Introduce test TC_ul_multislot_tbf_ms_class_from_2phase .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26a3cc0f2bd7bab176aa52df3e40aca7300de216 Gerrit-Change-Number: 20983 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 04 Nov 2020 19:37:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_dl_multislot_tbf_ms_class_from_2phase
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967 ) Change subject: pcu: Introduce test TC_dl_multislot_tbf_ms_class_from_2phase .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie0035bab79c286a968394d7b724d975f43d187ce Gerrit-Change-Number: 20967 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 04 Nov 2020 19:36:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_dl_multislot_tbf_ms_class_from_sgsn
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20947 ) Change subject: pcu: Introduce test TC_dl_multislot_tbf_ms_class_from_sgsn .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I417953a4c89dec82500b3b66f08ed648d266d813 Gerrit-Change-Number: 20947 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 04 Nov 2020 19:35:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: main: do not print asciiart to stdout, use stderr instead
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/20953 )
Change subject: main: do not print asciiart to stdout, use stderr instead
..
main: do not print asciiart to stdout, use stderr instead
Otherwise it ends up in the generated XML VTY reference:
$ head doc/manuals/vty/bts_trx_vty_reference.xml
((*))
|
/ \ OsmoBTS
Common Commands
Also, take a chance to move it below handle_options(), so it
will only be printed if all arguments are parsed successfully.
Change-Id: I5c35f36fdd2a8a80bd501b996f0b161c388d3510
Related: SYS#4937, OS#3036
---
M src/common/main.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/common/main.c b/src/common/main.c
index 102bf88..b2534d5 100644
--- a/src/common/main.c
+++ b/src/common/main.c
@@ -264,8 +264,6 @@
struct e1inp_line *line;
int rc;
- printf("((*))\n |\n / \\ OsmoBTS\n");
-
/* Track the use of talloc NULL memory contexts */
talloc_enable_null_tracking();
@@ -289,6 +287,8 @@
handle_options(argc, argv);
+ fprintf(stderr, "((*))\n |\n / \\ OsmoBTS\n");
+
g_bts = gsm_bts_alloc(tall_bts_ctx, 0);
if (!g_bts) {
fprintf(stderr, "Failed to create BTS structure\n");
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20953
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5c35f36fdd2a8a80bd501b996f0b161c388d3510
Gerrit-Change-Number: 20953
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bts[master]: main: do not print asciiart to stdout, use stderr instead
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20953 ) Change subject: main: do not print asciiart to stdout, use stderr instead .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5c35f36fdd2a8a80bd501b996f0b161c388d3510 Gerrit-Change-Number: 20953 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 19:33:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: main: use logging API to print SIMD info instead of printf()
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/20965 )
Change subject: main: use logging API to print SIMD info instead of printf()
..
main: use logging API to print SIMD info instead of printf()
Otherwise these logging lines end up in the automatically generated
XML VTY reference (stdout), so this breaks further XML processing.
Change-Id: I8e0fd728d406e2452c9c0ddad5bce5f6b17fab42
Related: SYS#4937, SYS#4910
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 33 insertions(+), 29 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp
index ba1c740..5099f89 100644
--- a/Transceiver52M/osmo-trx.cpp
+++ b/Transceiver52M/osmo-trx.cpp
@@ -478,6 +478,38 @@
return 0;
}
+static void print_simd_info(void)
+{
+#ifdef HAVE_SSE3
+ LOGP(DMAIN, LOGL_INFO, "SSE3 support compiled in");
+#ifdef HAVE___BUILTIN_CPU_SUPPORTS
+ if (__builtin_cpu_supports("sse3"))
+ LOGPC(DMAIN, LOGL_INFO, " and supported by CPU\n");
+ else
+ LOGPC(DMAIN, LOGL_INFO, ", but not supported by CPU\n");
+#else
+ LOGPC(DMAIN, LOGL_INFO, ", but runtime SIMD detection disabled\n");
+#endif
+#endif
+
+#ifdef HAVE_SSE4_1
+ LOGP(DMAIN, LOGL_INFO, "SSE4.1 support compiled in");
+#ifdef HAVE___BUILTIN_CPU_SUPPORTS
+ if (__builtin_cpu_supports("sse4.1"))
+ LOGPC(DMAIN, LOGL_INFO, " and supported by CPU\n");
+ else
+ LOGPC(DMAIN, LOGL_INFO, ", but not supported by CPU\n");
+#else
+ LOGPC(DMAIN, LOGL_INFO, ", but runtime SIMD detection disabled\n");
+#endif
+#endif
+
+#ifndef HAVE_ATOMIC_OPS
+#pragma message ("Built without atomic operation support. Using Mutex, it may
affect performance!")
+ LOG(NOTICE) << "Built without atomic operation support. Using Mutex, it
may affect performance!";
+#endif
+}
+
static void print_config(struct trx_ctx *trx)
{
unsigned int i;
@@ -585,35 +617,6 @@
g_trx_ctx = vty_trx_ctx_alloc(tall_trx_ctx);
-#ifdef HAVE_SSE3
- printf("Info: SSE3 support compiled in");
-#ifdef HAVE___BUILTIN_CPU_SUPPORTS
- if (__builtin_cpu_supports("sse3"))
- printf(" and supported by CPU\n");
- else
- printf(", but not supported by CPU\n");
-#else
- printf(", but runtime SIMD detection disabled\n");
-#endif
-#endif
-
-#ifdef HAVE_SSE4_1
- printf("Info: SSE4.1 support compiled in");
-#ifdef HAVE___BUILTIN_CPU_SUPPORTS
- if (__builtin_cpu_supports("sse4.1"))
- printf(" and supported by CPU\n");
- else
- printf(", but not supported by CPU\n");
-#else
- printf(", but runtime SIMD detection disabled\n");
-#endif
-#endif
-
-#ifndef HAVE_ATOMIC_OPS
-#pragma message ("Built without atomic operation support. Using Mutex, it may
affect performance!")
- printf("Built without atomic operation support. Using Mutex, it may
affect performance!\n");
-#endif
-
convolve_init();
convert_init();
@@ -660,6 +663,7 @@
" but expect your config to break in the future.";
}
+ print_simd_info();
print_config(g_trx_ctx);
if (trx_validate_config(g_trx_ctx) < 0) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20965
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I8e0fd728d406e2452c9c0ddad5bce5f6b17fab42
Gerrit-Change-Number: 20965
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-pcu[master]: Move BTS initial values inside bts.cpp
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21020 ) Change subject: Move BTS initial values inside bts.cpp .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iffd6eecb1f08bda0091f45e2ef7c9c63b42e10b3 Gerrit-Change-Number: 21020 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 04 Nov 2020 19:31:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ci[master]: Add jenkins job to update docker base images on registry.osmocom.org
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/21023 ) Change subject: Add jenkins job to update docker base images on registry.osmocom.org .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/21023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iec2d2e3a43b074cb60f75cbe852351ffa8e0009e Gerrit-Change-Number: 21023 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 04 Nov 2020 19:30:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify CS paging of multiple subscribers
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20998 )
Change subject: PCU_Tests: verify CS paging of multiple subscribers
..
PCU_Tests: verify CS paging of multiple subscribers
The change introduces three new test cases:
- TC_paging_cs_multi_ms_imsi,
- TC_paging_cs_multi_ms_tmsi,
- TC_paging_cs_multi_ms_imsi_tmsi.
Each of these establishes 56 Uplink TBFs, and then enqueues 56 CS
PAGING requests from the SGSN side. The main idea is to verify
encoding and compositing of the paging MIs in PACCH massages.
Change-Id: Ie8b4006f969598c9b0c452002d559f985d108a66
Related: OS#4838
---
M pcu/PCU_Tests.ttcn
1 file changed, 163 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 44314f3..79a5564 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -2535,6 +2535,166 @@
f_shutdown(__BFILE__, __LINE__, final := true);
}
+private function f_TC_paging_cs_multi_ms(template (value) TsTrxBtsNum nr,
+boolean exp_imsi, boolean exp_tmsi)
+runs on RAW_PCU_Test_CT {
+ var bitstring mask := f_pad_bit(''B, lengthof(g_ms), '0'B);
+ var integer pending := lengthof(g_ms);
+ var RlcmacDlBlock dl_block;
+ var boolean f1, f2;
+
+ while (pending > 0) {
+ var uint32_t poll_fn;
+
+ /* Obtain a Downlink block and make sure it is a paging request
*/
+ f_rx_rlcmac_dl_block(dl_block, poll_fn, nr := nr);
+ if (not match(dl_block, tr_RLCMAC_PACKET_PAG_REQ)) {
+ setverdict(fail, "Rx unexpected DL block: ", dl_block);
+ break;
+ }
+
+ /* This should not happen in general, but who knows... */
+ var PacketPagingReq req := dl_block.ctrl.payload.u.paging;
+ if (not ispresent(req.repeated_pageinfo)) {
+ setverdict(fail, "Repeated Page Info IE is absent?!?");
+ break;
+ }
+
+ /* A single message may contain several MIs depending on their
type */
+ for (var integer i := 0; i < lengthof(g_ms); i := i + 1) {
+ f1 := exp_imsi and f_pkt_paging_match_imsi(req,
g_ms[i].imsi,
+ ps_domain :=
false);
+ f2 := exp_tmsi and f_pkt_paging_match_tmsi(req,
oct2int(g_ms[i].tlli),
+ ps_domain :=
false);
+ if (not f1 and not f2)
+ { continue; }
+
+ /* Detect duplicate MIs */
+ if (mask[i] == '1'B) {
+ setverdict(fail, "MS is paged twice: ",
g_ms[i].imsi);
+ continue;
+ }
+
+ mask[i] := '1'B;
+ }
+
+ pending := pending - lengthof(req.repeated_pageinfo);
+ }
+
+ for (var integer i := 0; i < lengthof(mask); i := i + 1) {
+ if (mask[i] != '1'B) {
+ setverdict(fail, "MS was not paged at all: ",
g_ms[i].imsi);
+ log("= mask := ", mask);
+ }
+ }
+
+ /* All messages must have been received by now, expect a dummy block */
+ f_rx_rlcmac_dl_block_exp_dummy(dl_block, nr := nr);
+}
+
+private function f_TC_paging_cs_multi_ms_init(BIT8 pdch_mask)
+runs on RAW_PCU_Test_CT {
+ var PCUIF_info_ind info_ind := valueof(ts_PCUIF_INFO_default);
+ const BssgpBvci bvci := mp_gb_cfg.bvc[0].bvci;
+
+ /* Initialize NS/BSSGP side */
+ f_init_bssgp();
+
+ /* Explicitly set the given PDCH slot-mask to all transceivers */
+ f_PCUIF_ver_INFO_PDCHMask_set(info_ind, pdch_mask);
+
+ /* Allocate 56 GprsMS instances (maximum for 8 PDCH slots) */
+ f_init_gprs_ms(7 * 8);
+
+ /* Initialize the PCU interface abstraction */
+ f_init_raw(testcasename(), info_ind);
+
+ /* Establish BSSGP connection to the PCU */
+ f_bssgp_establish();
+ f_multi_ms_bssgp_register();
+
+ /* Establish an Uplink TBF for each GprsMS instance */
+ f_multi_ms_establish_tbf(do_activate := true);
+}
+
+testcase TC_paging_cs_multi_ms_imsi() runs on RAW_PCU_Test_CT {
+ const BssgpBvci bvci := mp_gb_cfg.bvc[0].bvci;
+
+ /* Common part: send INFO.ind, establish TBFs... */
+ f_TC_paging_cs_multi_ms_init(pdch_mask := '0001'B);
+
+ /* Enqueue multiple CS PAGING requests at a time (IMSI only) */
+ for (var integer i := 0; i < lengthof(g_ms); i := i + 1) {
+ BSSGP[0].send(ts_BSSGP_CS_PAGING_IMSI(bv
Change in osmo-ci[master]: Add jenkins job to update docker base images on registry.osmocom.org
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/21023 )
Change subject: Add jenkins job to update docker base images on
registry.osmocom.org
..
Add jenkins job to update docker base images on registry.osmocom.org
Change-Id: Iec2d2e3a43b074cb60f75cbe852351ffa8e0009e
Related: OS#4839
---
A jobs/registry-update-base-images.yml
1 file changed, 37 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, approved; Verified
diff --git a/jobs/registry-update-base-images.yml
b/jobs/registry-update-base-images.yml
new file mode 100644
index 000..e036799
--- /dev/null
+++ b/jobs/registry-update-base-images.yml
@@ -0,0 +1,37 @@
+---
+- project:
+name: registry-update-base-images
+jobs:
+ - registry-update-base-images
+
+- job:
+name: registry-update-base-images
+description: |
+Update base docker images in our private reigstry.osmocom.org with
those from docker.io
+Related:
+
+ https://osmocom.org/issues/3839";>OS#4839
+
+node: osmocom-master-debian9
+builders:
+ - shell: |
+ REGISTRY="registry.osmocom.org"
+ IMAGES="debian:stretch debian:buster debian:jessie debian:sid
ubuntu:zesty centos:centos8"
+ for i in $IMAGES; do
+src=$i
+dst=${REGISTRY}/$i
+echo
+echo === $src
+docker pull $src
+docker tag $src $dst
+docker push $dst
+ done
+triggers:
+ - timed: "@daily"
+
+publishers:
+ - email:
+ notify-every-unstable-build: true
+ recipients: 'jenkins-notificati...@lists.osmocom.org'
+
+# vim: expandtab tabstop=2 shiftwidth=2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/21023
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iec2d2e3a43b074cb60f75cbe852351ffa8e0009e
Gerrit-Change-Number: 21023
Gerrit-PatchSet: 3
Gerrit-Owner: laforge
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify CS paging of multiple subscribers
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20998 ) Change subject: PCU_Tests: verify CS paging of multiple subscribers .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie8b4006f969598c9b0c452002d559f985d108a66 Gerrit-Change-Number: 20998 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 19:30:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: vty: fix documentation for 'ext-rach (disable|enable)'
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/20971 )
Change subject: vty: fix documentation for 'ext-rach (disable|enable)'
..
vty: fix documentation for 'ext-rach (disable|enable)'
Do not use 'extended' because it's not the same 11-bit Access Burst,
as it was assumed before. Add missing docs for 'enable'/'disable'.
Change-Id: I80b5a584e554eb7cc2416017b10fee032202b372
---
M CommonLibs/trx_vty.c
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c
index eeabcbe..e672928 100644
--- a/CommonLibs/trx_vty.c
+++ b/CommonLibs/trx_vty.c
@@ -298,7 +298,9 @@
DEFUN(cfg_ext_rach, cfg_ext_rach_cmd,
"ext-rach (disable|enable)",
- "Enable extended (11-bit) RACH (default=disable)\n")
+ "11-bit Access Burst correlation support (default=disable)\n"
+ "Disable 11-bit Access Burst (TS1 & TS2) correlation\n"
+ "Enable 11-bit Access Burst (TS1 & TS2) correlation\n")
{
struct trx_ctx *trx = trx_from_vty(vty);
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20971
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I80b5a584e554eb7cc2416017b10fee032202b372
Gerrit-Change-Number: 20971
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-trx[master]: vty: fix documentation for 'ext-rach (disable|enable)'
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/20971 ) Change subject: vty: fix documentation for 'ext-rach (disable|enable)' .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I80b5a584e554eb7cc2416017b10fee032202b372 Gerrit-Change-Number: 20971 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 19:29:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1-hardware[master]: gateware/README.md: Fix typo (CERL->CERN)
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21044 ) Change subject: gateware/README.md: Fix typo (CERL->CERN) .. gateware/README.md: Fix typo (CERL->CERN) Change-Id: Ic1d0cad46a37a00714fa9b0cec5aa98ec9805a47 --- M gateware/README.md 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: tnt: Looks good to me, approved laforge: Verified diff --git a/gateware/README.md b/gateware/README.md index f4bd6ee..b91094d 100644 --- a/gateware/README.md +++ b/gateware/README.md @@ -8,7 +8,7 @@ Licensing - -Most of the cores/HDL in here is licensed under one of the CERL OHL 2.0 +Most of the cores/HDL in here is licensed under one of the CERN OHL 2.0 license. See the `doc/` subdirectory for the full license texts and refer to each file header to know the license applicable to each file. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21044 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ic1d0cad46a37a00714fa9b0cec5aa98ec9805a47 Gerrit-Change-Number: 21044 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-MessageType: merged
Change in osmo-e1-hardware[master]: e1_xcvr: Give signals proper names
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21043 ) Change subject: e1_xcvr: Give signals proper names .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I04107430cab02e493bbabef60b1cc19b535caad6 Gerrit-Change-Number: 21043 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-Comment-Date: Wed, 04 Nov 2020 19:29:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1-hardware[master]: gateware/README.md: Fix typo (CERL->CERN)
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21044 ) Change subject: gateware/README.md: Fix typo (CERL->CERN) .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21044 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ic1d0cad46a37a00714fa9b0cec5aa98ec9805a47 Gerrit-Change-Number: 21044 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-Comment-Date: Wed, 04 Nov 2020 19:29:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1-hardware[master]: e1_xcvr: Give signals proper names
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21043 ) Change subject: e1_xcvr: Give signals proper names .. e1_xcvr: Give signals proper names Change-Id: I04107430cab02e493bbabef60b1cc19b535caad6 --- M hardware/e1-xcvr/e1_xcvr.brd M hardware/e1-xcvr/e1_xcvr.sch 2 files changed, 50 insertions(+), 50 deletions(-) Approvals: tnt: Looks good to me, approved laforge: Verified diff --git a/hardware/e1-xcvr/e1_xcvr.brd b/hardware/e1-xcvr/e1_xcvr.brd index a0ba9a7..8d38750 100644 --- a/hardware/e1-xcvr/e1_xcvr.brd +++ b/hardware/e1-xcvr/e1_xcvr.brd @@ -2347,7 +2347,7 @@ - + @@ -2356,7 +2356,7 @@ - + @@ -2365,7 +2365,7 @@ - + @@ -2391,7 +2391,7 @@ - + @@ -2402,7 +2402,7 @@ - + @@ -2416,7 +2416,7 @@ - + @@ -2580,7 +2580,7 @@ - + @@ -2803,7 +2803,7 @@ - + @@ -2816,7 +2816,7 @@ - + @@ -2840,7 +2840,7 @@ - + @@ -2855,7 +2855,7 @@ - + @@ -2870,7 +2870,7 @@ - + diff --git a/hardware/e1-xcvr/e1_xcvr.sch b/hardware/e1-xcvr/e1_xcvr.sch index 69d837b..f1b832f 100644 --- a/hardware/e1-xcvr/e1_xcvr.sch +++ b/hardware/e1-xcvr/e1_xcvr.sch @@ -8,24 +8,24 @@ - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + @@ -34,8 +34,8 @@ - - + + @@ -43,12 +43,12 @@ - - - - - - + + + + + + @@ -11481,21 +11481,21 @@ - + - + - + @@ -11516,7 +11516,7 @@ - + @@ -11525,7 +11525,7 @@ - + @@ -11534,7 +11534,7 @@ - + @@ -11679,7 +11679,7 @@ - + @@ -11853,7 +11853,7 @@ - + @@ -11862,7 +11862,7 @@ - + @@ -11871,7 +11871,7 @@ - + @@ -11882,14 +11882,14 @@ - + - + -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I04107430cab02e493bbabef60b1cc19b535caad6 Gerrit-Change-Number: 21043 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-MessageType: merged
Change in osmo-pcu[master]: Fix msc_is_valid(): UNKNOWN value is not a valid (M)CS
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/21045 )
Change subject: Fix msc_is_valid(): UNKNOWN value is not a valid (M)CS
..
Fix msc_is_valid(): UNKNOWN value is not a valid (M)CS
Also add a few more asserts to make sure a valid CS/MCS is passed in
some placed where we expect (M)CS to be set.
Change-Id: I0a973e10cd9477f72d8bd47a06048414b33ae96a
---
M src/coding_scheme.c
M src/encoding.cpp
M src/rlc.cpp
3 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/45/21045/1
diff --git a/src/coding_scheme.c b/src/coding_scheme.c
index e39ed2b..27241d1 100644
--- a/src/coding_scheme.c
+++ b/src/coding_scheme.c
@@ -163,7 +163,7 @@
bool mcs_is_valid(enum CodingScheme cs)
{
- return UNKNOWN <= cs && cs <= MCS9;
+ return UNKNOWN < cs && cs <= MCS9;
}
bool mcs_is_compat_kind(enum CodingScheme cs, enum mcs_kind mode)
diff --git a/src/encoding.cpp b/src/encoding.cpp
index c6ec2e8..7f5da75 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -1692,6 +1692,7 @@
LOGP(DRLCMACDL, LOGL_ERROR, "%s data block encoding not implemented\n",
mcs_name(cs));
+ OSMO_ASSERT(mcs_is_valid(cs));
return AR_NEED_MORE_BLOCKS;
}
diff --git a/src/rlc.cpp b/src/rlc.cpp
index 4f36025..8f56a8e 100644
--- a/src/rlc.cpp
+++ b/src/rlc.cpp
@@ -350,6 +350,7 @@
void gprs_rlc_data_info_init_dl(struct gprs_rlc_data_info *rlc,
enum CodingScheme cs, bool with_padding, const unsigned int spb)
{
+ OSMO_ASSERT(mcs_is_valid(cs));
return gprs_rlc_data_header_init(rlc, cs, with_padding,
num_data_header_bits_DL(mcs_header_type(cs)), spb);
}
@@ -357,6 +358,7 @@
void gprs_rlc_data_info_init_ul(struct gprs_rlc_data_info *rlc,
enum CodingScheme cs, bool with_padding)
{
+ OSMO_ASSERT(mcs_is_valid(cs));
/*
* last parameter is sent as 0 since common function used
* for both DL and UL
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21045
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I0a973e10cd9477f72d8bd47a06048414b33ae96a
Gerrit-Change-Number: 21045
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: gprs_ms: Avoid enabling EGPRS if no MCS are supported
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/21046 )
Change subject: gprs_ms: Avoid enabling EGPRS if no MCS are supported
..
gprs_ms: Avoid enabling EGPRS if no MCS are supported
This patch avoids enabling EGPRS on MS objects if BTS/VTY assigned no
MCS supported/available for use.
As a result, if NO MCS is enabled/supported EGPRS won't be used despite
the MS announcing through EGPRS MS class that it supports EGPRS.
Change-Id: Ib19e9e006d851c2147de15f4aec36ab65250bdd3
---
M src/gprs_ms.cpp
M src/tbf.cpp
2 files changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/46/21046/1
diff --git a/src/gprs_ms.cpp b/src/gprs_ms.cpp
index b295686..8eb23d9 100644
--- a/src/gprs_ms.cpp
+++ b/src/gprs_ms.cpp
@@ -541,6 +541,13 @@
m_egprs_ms_class = ms_class_;
+ if (!m_bts->max_mcs_ul() || !m_bts->max_mcs_dl()) {
+ LOGPMS(this, DRLCMAC, LOGL_DEBUG,
+ "Avoid enabling EGPRS because use of MCS is disabled:
ul=%u dl=%u\n",
+ m_bts->max_mcs_ul(), m_bts->max_mcs_dl());
+ return;
+ }
+
if (mcs_is_edge_gmsk(mcs_get_egprs_by_num(m_bts->max_mcs_ul())) &&
mcs_is_edge_gmsk(mcs_get_egprs_by_num(m_bts->max_mcs_dl())) &&
mode() != EGPRS)
diff --git a/src/tbf.cpp b/src/tbf.cpp
index 4f685e8..2371aed 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -745,7 +745,7 @@
struct gprs_rlcmac_bts *bts_data = bts->bts_data();
int rc;
- if (m_ms->egprs_ms_class() > 0)
+ if (m_ms->mode() != GPRS)
enable_egprs();
m_created_ts = time(NULL);
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21046
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ib19e9e006d851c2147de15f4aec36ab65250bdd3
Gerrit-Change-Number: 21046
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-e1-hardware[master]: gateware/README.md: Fix typo (CERL->CERN)
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21044 ) Change subject: gateware/README.md: Fix typo (CERL->CERN) .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21044 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ic1d0cad46a37a00714fa9b0cec5aa98ec9805a47 Gerrit-Change-Number: 21044 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: tnt Gerrit-Comment-Date: Wed, 04 Nov 2020 14:58:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1-hardware[master]: e1_xcvr: Give signals proper names
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21043 ) Change subject: e1_xcvr: Give signals proper names .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I04107430cab02e493bbabef60b1cc19b535caad6 Gerrit-Change-Number: 21043 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: tnt Gerrit-Comment-Date: Wed, 04 Nov 2020 14:58:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1-hardware[master]: gateware/README.md: Fix typo (CERL->CERN)
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21044 ) Change subject: gateware/README.md: Fix typo (CERL->CERN) .. gateware/README.md: Fix typo (CERL->CERN) Change-Id: Ic1d0cad46a37a00714fa9b0cec5aa98ec9805a47 --- M gateware/README.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/44/21044/1 diff --git a/gateware/README.md b/gateware/README.md index f4bd6ee..b91094d 100644 --- a/gateware/README.md +++ b/gateware/README.md @@ -8,7 +8,7 @@ Licensing - -Most of the cores/HDL in here is licensed under one of the CERL OHL 2.0 +Most of the cores/HDL in here is licensed under one of the CERN OHL 2.0 license. See the `doc/` subdirectory for the full license texts and refer to each file header to know the license applicable to each file. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21044 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ic1d0cad46a37a00714fa9b0cec5aa98ec9805a47 Gerrit-Change-Number: 21044 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange
Change in osmo-e1-hardware[master]: e1_xcvr: Give signals proper names
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21043 ) Change subject: e1_xcvr: Give signals proper names .. e1_xcvr: Give signals proper names Change-Id: I04107430cab02e493bbabef60b1cc19b535caad6 --- M hardware/e1-xcvr/e1_xcvr.brd M hardware/e1-xcvr/e1_xcvr.sch 2 files changed, 50 insertions(+), 50 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/43/21043/1 diff --git a/hardware/e1-xcvr/e1_xcvr.brd b/hardware/e1-xcvr/e1_xcvr.brd index a0ba9a7..8d38750 100644 --- a/hardware/e1-xcvr/e1_xcvr.brd +++ b/hardware/e1-xcvr/e1_xcvr.brd @@ -2347,7 +2347,7 @@ - + @@ -2356,7 +2356,7 @@ - + @@ -2365,7 +2365,7 @@ - + @@ -2391,7 +2391,7 @@ - + @@ -2402,7 +2402,7 @@ - + @@ -2416,7 +2416,7 @@ - + @@ -2580,7 +2580,7 @@ - + @@ -2803,7 +2803,7 @@ - + @@ -2816,7 +2816,7 @@ - + @@ -2840,7 +2840,7 @@ - + @@ -2855,7 +2855,7 @@ - + @@ -2870,7 +2870,7 @@ - + diff --git a/hardware/e1-xcvr/e1_xcvr.sch b/hardware/e1-xcvr/e1_xcvr.sch index 69d837b..f1b832f 100644 --- a/hardware/e1-xcvr/e1_xcvr.sch +++ b/hardware/e1-xcvr/e1_xcvr.sch @@ -8,24 +8,24 @@ - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + @@ -34,8 +34,8 @@ - - + + @@ -43,12 +43,12 @@ - - - - - - + + + + + + @@ -11481,21 +11481,21 @@ - + - + - + @@ -11516,7 +11516,7 @@ - + @@ -11525,7 +11525,7 @@ - + @@ -11534,7 +11534,7 @@ - + @@ -11679,7 +11679,7 @@ - + @@ -11853,7 +11853,7 @@ - + @@ -11862,7 +11862,7 @@ - + @@ -11871,7 +11871,7 @@ - + @@ -11882,14 +11882,14 @@ - + - + -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I04107430cab02e493bbabef60b1cc19b535caad6 Gerrit-Change-Number: 21043 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange
Change in osmo-pcu[master]: Move BTS initial values inside bts.cpp
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21020 ) Change subject: Move BTS initial values inside bts.cpp .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/src/bts.cpp File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/src/bts.cpp@327 PS1, Line 327: bts_init > It's different object/struct so yes, to me it makes sense having it separate. Ack https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/tbf/TbfTest.cpp File tests/tbf/TbfTest.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/tbf/TbfTest.cpp@a799 PS1, Line 799: 03 > I think it can be seen already when seeing the patch (unit test output > results) and in here in the g […] Well, this is what anybody can say instead of writing a commit description ;) Yes, it can be seen that the logic is changed, but *why* is even more important question. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iffd6eecb1f08bda0091f45e2ef7c9c63b42e10b3 Gerrit-Change-Number: 21020 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 04 Nov 2020 11:48:02 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: lynxis lazus Gerrit-MessageType: comment
Change in osmo-pcu[master]: Move BTS initial values inside bts.cpp
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21020 ) Change subject: Move BTS initial values inside bts.cpp .. Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/src/bts.cpp File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/src/bts.cpp@327 PS1, Line 327: bts_init > Does it really make sense to have everything in a separate function? I would > keep/move everything he […] It's different object/struct so yes, to me it makes sense having it separate. https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/ms/MsTest.ok File tests/ms/MsTest.ok: https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/ms/MsTest.ok@a22 PS1, Line 22: UNKNOWN/UNKNOWN, UL UNKNOWN/UNKNOWN > LOL, the author of this unit test didn't seem to care about the > expectations... I pointed that out already, but given the previous state when the tests we added I can understand it's was impossible to add this amount of code path coverage and fixing all issues at the same time, so I can understand the current situation. https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/tbf/TbfTest.cpp File tests/tbf/TbfTest.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/tbf/TbfTest.cpp@a799 PS1, Line 799: 03 > In any case, would be nice if you document this positive side-effect in the > commit message. […] I think it can be seen already when seeing the patch (unit test output results) and in here in the gerrit discussion. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iffd6eecb1f08bda0091f45e2ef7c9c63b42e10b3 Gerrit-Change-Number: 21020 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 04 Nov 2020 11:43:31 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Comment-In-Reply-To: lynxis lazus Gerrit-MessageType: comment
Change in osmo-pcu[master]: Move BTS initial values inside bts.cpp
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21020 ) Change subject: Move BTS initial values inside bts.cpp .. Patch Set 1: Code-Review+1 (3 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/src/bts.cpp File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/src/bts.cpp@327 PS1, Line 327: bts_init Does it really make sense to have everything in a separate function? I would keep/move everything here. https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/ms/MsTest.ok File tests/ms/MsTest.ok: https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/ms/MsTest.ok@a22 PS1, Line 22: UNKNOWN/UNKNOWN, UL UNKNOWN/UNKNOWN LOL, the author of this unit test didn't seem to care about the expectations... https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/tbf/TbfTest.cpp File tests/tbf/TbfTest.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/tbf/TbfTest.cpp@a799 PS1, Line 799: 03 > IIRC it's the default CS which changed due to being correctly applied (see > also in MSTest and TbfTes […] In any case, would be nice if you document this positive side-effect in the commit message. Thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iffd6eecb1f08bda0091f45e2ef7c9c63b42e10b3 Gerrit-Change-Number: 21020 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 04 Nov 2020 11:13:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Comment-In-Reply-To: lynxis lazus Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: Add gprs_ns2_nsvc_state_name() to get the current state of a VC
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21039 ) Change subject: ns2: Add gprs_ns2_nsvc_state_name() to get the current state of a VC .. Patch Set 1: Code-Review+1 > Patch Set 1: > > > Patch Set 1: > > > > So do you plan to compare states with this output? or only for logging > > purposes? > > The later is fined, the former is not imho. > > Logging/reporting through ctrl. Ok, but be careful then because the FSM state names become "public" and if you change it you'll break apps using the CTRL iface and the names sent in CTRL messages. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4c4c5b9142d7240ed452218e263ba12e2b70d1a0 Gerrit-Change-Number: 21039 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 11:07:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Move BTS initial values inside bts.cpp
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21020 ) Change subject: Move BTS initial values inside bts.cpp .. Patch Set 1: BTW, as a general note, don't take osmo-pcu unit tests as expecting correct results/behavior, imho they serve so far more as triggering different code paths in order to see what a code change provoke. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iffd6eecb1f08bda0091f45e2ef7c9c63b42e10b3 Gerrit-Change-Number: 21020 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 04 Nov 2020 11:05:33 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: Add gprs_ns2_nsvc_state_name() to get the current state of a VC
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21039 ) Change subject: ns2: Add gprs_ns2_nsvc_state_name() to get the current state of a VC .. Patch Set 1: > Patch Set 1: > > So do you plan to compare states with this output? or only for logging > purposes? > The later is fined, the former is not imho. Logging/reporting through ctrl. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4c4c5b9142d7240ed452218e263ba12e2b70d1a0 Gerrit-Change-Number: 21039 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 11:05:39 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: Add gprs_ns2_nsvc_state_name() to get the current state of a VC
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21039 ) Change subject: ns2: Add gprs_ns2_nsvc_state_name() to get the current state of a VC .. Patch Set 1: > Patch Set 1: > > It's still unused in gbproxy? Yes, I want to use it in the nsvc-state ctrl cmd -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4c4c5b9142d7240ed452218e263ba12e2b70d1a0 Gerrit-Change-Number: 21039 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 11:03:39 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: library/L3_Common: use f_rnd_octstring() from Osmocom_Types
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21042 ) Change subject: library/L3_Common: use f_rnd_octstring() from Osmocom_Types .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21042 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iad46c3ab25244389a2a536065653c7ed231d1234 Gerrit-Change-Number: 21042 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 10:44:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: NS2: rework handling of unknown primitive
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20927 ) Change subject: NS2: rework handling of unknown primitive .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I50188afb83ac142e22d4bda4e8050eb4de962e70 Gerrit-Change-Number: 20927 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 10:43:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: fixup gprs_ns2_prim_strs
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21041 ) Change subject: ns2: fixup gprs_ns2_prim_strs .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21041 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie8e1e003d70af48f2d647b2c2701d4fc0f17e307 Gerrit-Change-Number: 21041 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 10:42:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: fixup gprs_ns2_prim_strs
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21041 ) Change subject: ns2: fixup gprs_ns2_prim_strs .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21041 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie8e1e003d70af48f2d647b2c2701d4fc0f17e307 Gerrit-Change-Number: 21041 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 10:42:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: pcuif: Improve BTS-supported CS/MCS handling
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20990 ) Change subject: pcuif: Improve BTS-supported CS/MCS handling .. Patch Set 2: > Patch Set 2: > > Can you add some comments? I don't understand the function. Why is it > returning initial_cs_dl? > It's used by gprs_bssgp_tx_fc_bvc(). This seems wrong. You mean max_coding_scheme_dl()? Yes I agree it's wrong and needs to be improved/fixesd, but I'm not breaking it here now, I'm simply changing some variables to accomplish what the patch does. I even add a FIXME in there in another followup commit where I also noticed that code logic is completely broken. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie8f0215ba17da1e545e98bec9325c02f1e8efaea Gerrit-Change-Number: 20990 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: lynxis lazus Gerrit-Comment-Date: Wed, 04 Nov 2020 10:41:50 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-pcu[master]: Move BTS initial values inside bts.cpp
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21020 ) Change subject: Move BTS initial values inside bts.cpp .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/tbf/TbfTest.cpp File tests/tbf/TbfTest.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/tbf/TbfTest.cpp@a799 PS1, Line 799: 03 > why has this changed? to you checked what's changed here? IIRC it's the default CS which changed due to being correctly applied (see also in MSTest and TbfTest.err how the CS show up now). -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iffd6eecb1f08bda0091f45e2ef7c9c63b42e10b3 Gerrit-Change-Number: 21020 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 04 Nov 2020 10:35:35 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus Gerrit-MessageType: comment
Change in osmo-sgsn[master]: Let libosmocore handle VTY parent node tracking
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21028 ) Change subject: Let libosmocore handle VTY parent node tracking .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2008dd9026922d29ee703c59e70d3fecced0ee18 Gerrit-Change-Number: 21028 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 10:32:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: Add gprs_ns2_nsvc_state_name() to get the current state of a VC
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21039 ) Change subject: ns2: Add gprs_ns2_nsvc_state_name() to get the current state of a VC .. Patch Set 1: So do you plan to compare states with this output? or only for logging purposes? The later is fined, the former is not imho. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4c4c5b9142d7240ed452218e263ba12e2b70d1a0 Gerrit-Change-Number: 21039 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 10:30:13 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: Send NSVC representation in NS_AFF_CAUSE_VC_* status indication
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21040 ) Change subject: ns2: Send NSVC representation in NS_AFF_CAUSE_VC_* status indication .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21040/1/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/21040/1/src/gb/gprs_ns2.c@378 PS1, Line 378: nsp.u.status.nsvc = gprs_ns2_ll_str_c(nse, nsvc); looks like a stack buffer version of the function would fit better here, since you are only using the buffer in this function (freeing it at the end). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21040 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iad6f0dc4565a46868cbbe17c361dcd473006c83d Gerrit-Change-Number: 21040 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 10:28:12 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: Port gbproxy to NS2
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 ) Change subject: Port gbproxy to NS2 .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 10:23:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bsc: add TC_ho_int_radio_link_failure
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21031 ) Change subject: bsc: add TC_ho_int_radio_link_failure .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21031/1/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21031/1/bsc/BSC_Tests.ttcn@4505 PS1, Line 4505: /* Handover fails because no HANDO DET appears on the new lchan, HANDO DET? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21031/1/bsc/BSC_Tests.ttcn@4530 PS1, Line 4530: f_sleep(0.5); why this sleep? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia94176a997dbdaf87d6b433cb24ffcfa06241d74 Gerrit-Change-Number: 21031 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 08:52:12 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
