Change in osmo-ttcn3-hacks[master]: fr-net: Fix regen_makefile.sh
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22444 ) Change subject: fr-net: Fix regen_makefile.sh .. fr-net: Fix regen_makefile.sh regen-makefile.sh should not include generated c++ code. Change-Id: I0fecfb0d3c33f8d87923d4843fee718916001978 --- M fr-net/regen_makefile.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/fr-net/regen_makefile.sh b/fr-net/regen_makefile.sh index 6aaf577..e2c143d 100755 --- a/fr-net/regen_makefile.sh +++ b/fr-net/regen_makefile.sh @@ -3,7 +3,7 @@ FILES="*.ttcn *.ttcnpp BSSGP_EncDec.cc IPL4asp_PT.cc IPL4asp_discovery.cc TCCConversion.cc TCCInterface.cc " FILES+="AF_PACKET_PT.cc " FILES+="Native_FunctionDefs.cc " -FILES+="LLC_EncDec.cc LLC_Types.cc TELNETasp_PT.cc " +FILES+="LLC_EncDec.cc TELNETasp_PT.cc " export CPPFLAGS_TTCN3="-DNS_EMULATION_FR" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0fecfb0d3c33f8d87923d4843fee718916001978 Gerrit-Change-Number: 22444 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: fr-net: use 'hdlcnet1' as default netdev
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22445 )
Change subject: fr-net: use 'hdlcnet1' as default netdev
..
fr-net: use 'hdlcnet1' as default netdev
The gbproxy tests and our scripts have started to use
hdlc0..7 paired with hdlcnet0..7. Let's adjust fr-net to
also use 'hdlcnet1' as the pairing 'fr' test uses 'hdlc1'
Change-Id: If456a575cc2ae0ab2fc63730b329131dfcc70a47
---
M fr-net/FRNET_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/fr-net/FRNET_Tests.ttcn b/fr-net/FRNET_Tests.ttcn
index 94b32dc..3943ff1 100644
--- a/fr-net/FRNET_Tests.ttcn
+++ b/fr-net/FRNET_Tests.ttcn
@@ -18,7 +18,7 @@
{
provider := {
fr := {
- netdev := "hdlc2",
+ netdev := "hdlcnet1",
dlci := 123
}
},
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22445
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If456a575cc2ae0ab2fc63730b329131dfcc70a47
Gerrit-Change-Number: 22445
Gerrit-PatchSet: 3
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: gbproxy: Use Misc_Helpers.f_shutdown() whenever applicable
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22459 )
Change subject: gbproxy: Use Misc_Helpers.f_shutdown() whenever applicable
..
gbproxy: Use Misc_Helpers.f_shutdown() whenever applicable
This should avoid some of the "known" races during shut-down
Change-Id: I4fdd47e9c5887597dca89580f856ddc6cd8f54f1
---
M gbproxy/GBProxy_Tests.ttcn
1 file changed, 43 insertions(+), 56 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/59/22459/1
diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn
index df27a3d..4879521 100644
--- a/gbproxy/GBProxy_Tests.ttcn
+++ b/gbproxy/GBProxy_Tests.ttcn
@@ -592,8 +592,7 @@
repeat;
}
[] SGSN_MGMT.receive {
- setverdict(fail, "Received unexpected message on SGSN_MGMT");
- mtc.stop;
+ f_shutdown(__FILE__, __LINE__, fail, "Received unexpected
message on SGSN_MGMT");
}
[] PCU_MGMT.receive(BssgpStatusIndication:{*, ?, BVC_S_UNBLOCKED}) ->
value bsi {
@@ -606,8 +605,7 @@
repeat;
}
[] PCU_MGMT.receive {
- setverdict(fail, "Received unexpected message on PCU_MGMT");
- mtc.stop;
+ f_shutdown(__FILE__, __LINE__, fail, "Received unexpected
message on PCU_MGMT");
}
[] T.timeout {
@@ -622,8 +620,8 @@
for (var integer j := 0; j < lengthof(g_sgsn[i].cfg.bvc); j :=
j+1) {
var BssgpBvci bvci := g_sgsn[i].cfg.bvc[j].bvci;
if (not ro_integer_contains(bvci_unblocked[i], bvci)) {
- setverdict(fail, "SGSN ", i, " BVCI=", bvci, "
was not unblocked during start-up");
- mtc.stop;
+ f_shutdown(__FILE__, __LINE__, fail,
+ log2str("SGSN ", i, " BVCI=", bvci, "
was not unblocked during start-up"));
}
}
}
@@ -742,8 +740,7 @@
private altstep as_gTguard(timer Tguard) {
[] Tguard.timeout {
- setverdict(fail, "Tguard timeout");
- mtc.stop;
+ f_shutdown(__FILE__, __LINE__, fail, "Tguard timeout");
}
}
@@ -821,16 +818,16 @@
setverdict(pass);
}
[] SGSN_PTP[sgsn_idx].receive(PDU_BSSGP:?) -> value rx {
- setverdict(fail, "Unexpected BSSGP on SGSN[", sgsn_idx, "]
side: ", rx);
- mtc.stop;
+ f_shutdown(__FILE__, __LINE__, fail,
+ log2str("Unexpected BSSGP on SGSN[", sgsn_idx, "] side:
", rx));
}
[] SGSN_SIG[sgsn_idx].receive(PDU_BSSGP:?) -> value rx {
- setverdict(fail, "Unexpected SIG BSSGP on SGSN[", sgsn_idx, "]
side: ", rx);
- mtc.stop;
+ f_shutdown(__FILE__, __LINE__, fail,
+ log2str("Unexpected SIG BSSGP on SGSN[", sgsn_idx, "]
side: ", rx));
}
[] T.timeout {
- setverdict(fail, "Timeout waiting for BSSGP on SGSN[",
sgsn_idx, "] side: ", exp_rx);
- mtc.stop;
+ f_shutdown(__FILE__, __LINE__, fail,
+ log2str("Timeout waiting for BSSGP on SGSN[", sgsn_idx,
"] side: ", exp_rx));
}
}
}
@@ -858,16 +855,16 @@
setverdict(pass);
}
[] any from SGSN_PTP.receive(PDU_BSSGP:?) -> value rx @index value
rx_idx {
- setverdict(fail, "Unexpected BSSGP on SGSN[", rx_idx, "] side:
", rx);
- mtc.stop;
+ f_shutdown(__FILE__, __LINE__, fail,
+ log2str("Unexpected BSSGP on SGSN[", rx_idx, "] side:
", rx));
}
[] any from SGSN_SIG.receive(PDU_BSSGP:?) -> value rx @index value
rx_idx {
- setverdict(fail, "Unexpected SIG BSSGP on SGSN[", rx_idx, "]
side: ", rx);
- mtc.stop;
+ f_shutdown(__FILE__, __LINE__, fail,
+ log2str("Unexpected SIG BSSGP on SGSN[", rx_idx, "]
side: ", rx));
}
[] T.timeout {
- setverdict(fail, "Timeout waiting for BSSGP on SGSN side: ",
exp_rx);
- mtc.stop;
+ f_shutdown(__FILE__, __LINE__, fail,
+ log2str("Timeout waiting for BSSGP on SGSN side: ",
exp_rx));
}
}
return rx_idx;
@@ -895,16 +892,14 @@
setverdict(pass);
}
[] PCU_PTP[pcu_idx].receive(PDU_BSSGP:?) -> value rx {
- setverdict(fail, "Unexpected BSSGP on PCU side: ", rx);
- mtc.stop;
+ f_shutdown(__FILE__, __LINE__, fail, log2str("Unexpected BSSGP
on PCU side: ", rx));
Change in osmo-trx[master]: Transceiver: use proper factor for amplitude scaling
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/22456 ) Change subject: Transceiver: use proper factor for amplitude scaling .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/22456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I98bc00bd25df4913d45e55eb008d715aca76fc7c Gerrit-Change-Number: 22456 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 09:54:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: abis_rsl: check if emergency calling is disabled before premption
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22455 ) Change subject: abis_rsl: check if emergency calling is disabled before premption .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1af1f4fefcbe6a886bb5396901ce0cb2368a0e19 Gerrit-Change-Number: 22455 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 09:55:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: abis_rsl: check if emergency calling is disabled before premption
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/22455 )
Change subject: abis_rsl: check if emergency calling is disabled before
premption
..
abis_rsl: check if emergency calling is disabled before premption
If an emergency call arrives at the BSC while all TCH are busy, one TCH
is cleared in favor of the emergency call. However, if emergency calls
are disabled (system information), it is still possible that an MS might
try an emergency call anyway or that due to interference a regular call
might look like an emergency call (channel request reason). In those
cases the preemption must not happen and the emergency call must be
rejected.
Change-Id: I1af1f4fefcbe6a886bb5396901ce0cb2368a0e19
Related: OS#4976
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 11 insertions(+), 10 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 321bcb4..388e2fc 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -1546,6 +1546,17 @@
break;
}
+ /* Block emergency calls if we explicitly disable them via sysinfo. */
+ if (rqd->reason == GSM_CHREQ_REASON_EMERG) {
+ if (bts->si_common.rach_control.t2 & 0x4) {
+ LOG_BTS(bts, DRSL, LOGL_NOTICE, "CHAN RQD: MS attempts
EMERGENCY CALL although EMERGENCY CALLS "
+ "are not allowed in sysinfo (spec violation by
MS!)\n");
+ rsl_tx_imm_ass_rej(bts, &rqd->ref);
+ talloc_free(rqd);
+ return 0;
+ }
+ }
+
/* Enqueue request */
llist_add_tail(&rqd->entry, &bts->chan_rqd_queue);
@@ -1702,16 +1713,6 @@
* - If there is still no channel available, try a TCH/F.
*
*/
- if (rqd->reason == GSM_CHREQ_REASON_EMERG) {
- if (bts->si_common.rach_control.t2 & 0x4) {
- LOG_BTS(bts, DRSL, LOGL_NOTICE, "CHAN RQD: MS attempts
EMERGENCY CALL although EMERGENCY CALLS "
- "are not allowed in sysinfo (spec violation by
MS!)\n");
- rsl_tx_imm_ass_rej(bts, &rqd->ref);
- llist_del(&rqd->entry);
- talloc_free(rqd);
- return;
- }
- }
/* Emergency calls will be put on a free TCH/H or TCH/F directly in the
code below, all other channel requests
* will get an SDCCH first (if possible). */
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22455
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1af1f4fefcbe6a886bb5396901ce0cb2368a0e19
Gerrit-Change-Number: 22455
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: rlcmac: introduce initial support for NACC related messages
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22058 ) Change subject: rlcmac: introduce initial support for NACC related messages .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22058 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4d2f123479c34e6afffe0bc8d91409e6b0529a62 Gerrit-Change-Number: 22058 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 09:58:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_nacc_outbound_success
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387 )
Change subject: pcu: Introduce test TC_nacc_outbound_success
..
Patch Set 3: Code-Review+1
(3 comments)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/library/GSM_Types.ttcn
File library/GSM_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/library/GSM_Types.ttcn@425
PS3, Line 425: bcdmccmnc := str2hex(mcc_str[0]) & str2hex(mcc_str[1])
& str2hex(mnc_str[2]) &
why not one "mncc_str_hex := str2hex(mncc_str)" above and then avoid calling
that function 9 times - plus make the code more readable?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/pcu/PCU_Tests.ttcn
File pcu/PCU_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/pcu/PCU_Tests.ttcn@3588
PS3, Line 3588: while (true) {
: f_rx_rlcmac_dl_block(dl_block, sched_fn);
: if (not match(dl_block,
tr_RLCMAC_DUMMY_CTRL())) {
: break;
: }
: if (i > 50) {
: setverdict(fail, "Rx unexpected DL
block: ", dl_block);
: f_shutdown(__BFILE__, __LINE__);
: return;
: }
: i := i + 1;
: }
does it make sense to factor this out into a separate function? something in
principle like "wait_for(rx_template, max_num_iterations)"
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/pcu/PCU_Tests.ttcn@3609
PS3, Line 3609: return
I guess that's not needed anywhere after f_shutdown()?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I951db4af731e5a7c207f0f407dd78d166e2d3d26
Gerrit-Change-Number: 22387
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Comment-Date: Wed, 27 Jan 2021 10:05:27 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_nacc_outbound_rac_ci_resolve_timeout
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22452 ) Change subject: pcu: Introduce test TC_nacc_outbound_rac_ci_resolve_timeout .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22452/1/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22452/1/pcu/PCU_Tests.ttcn@3801 PS1, Line 3801: f_rx_rlcmac_dl_block(dl_block, sched_fn); is this guarded by a timeout? un-bounded loops always make me uneasy ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia09fbfe9aba34a51e0715d1c307de280e3ae0249 Gerrit-Change-Number: 22452 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 10:10:55 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_nacc_outbound_si_resolve_timeout
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22453 ) Change subject: pcu: Introduce test TC_nacc_outbound_si_resolve_timeout .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22453/1/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22453/1/pcu/PCU_Tests.ttcn@3882 PS1, Line 3882: f_rx_rlcmac_dl_block(dl_block, sched_fn); like in te other case: is there a guard timer running here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22453 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0032b940685efaaa8f65357c56c3383fab3e283 Gerrit-Change-Number: 22453 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 10:11:40 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_nacc_outbound_rac_ci_resolve_fail_parse_response
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22454 )
Change subject: pcu: Introduce test
TC_nacc_outbound_rac_ci_resolve_fail_parse_response
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22454/1/pcu/PCU_Tests.ttcn
File pcu/PCU_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22454/1/pcu/PCU_Tests.ttcn@3868
PS1, Line 3868: if (not match(dl_block,
tr_RLCMAC_DUMMY_CTRL())) {
and once more the question about unbounded loops...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22454
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If7efddb1ae2ccb580fe85c8df45c9ccdb818c6f3
Gerrit-Change-Number: 22454
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge
Gerrit-Comment-Date: Wed, 27 Jan 2021 10:12:01 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_19.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_19.04/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: /var/cache/obs/worker/root_5/.pkgs/libosmocore-dev.deb: Input/output error (worker was wildcard2:5) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 116s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 116s] [COMPILING libboard/qmod/source/card_pres.c] [ 116s] [COMPILING libboard/qmod/source/wwan_led.c] [ 117s] [COMPILING libboard/qmod/source/i2c.c] [ 117s] [COMPILING libboard/qmod/source/board_qmod.c] [ 117s] [COMPILING apps/dfu/main.c] [ 117s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 117s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 117s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 117s] Memory region Used Size Region Size %age Used [ 117s] rom: 16588 B16 KB101.25% [ 117s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 117s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 204 bytes [ 117s] collect2: error: ld returned 1 exit status [ 117s] % [ 117s] make[2]: *** [Makefile:234: flash] Error 1 [ 117s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 117s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 117s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 117s] dh_auto_build: error: make -j1 returned exit code 2 [ 117s] make: *** [debian/rules:16: build] Error 25 [ 117s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 117s] ### VM INTERACTION START ### [ 120s] [ 109.627407] sysrq: Power Off [ 120s] [ 109.630948] reboot: Power down [ 120s] ### VM INTERACTION END ### [ 120s] [ 120s] sheep86 failed "build simtrace2_0.7.0.69.aadd.dsc" at Wed Jan 27 10:34:40 UTC 2021. [ 120s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 112s] [COMPILING apps/dfu/main.c] [ 112s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 112s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 112s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 112s] Memory region Used Size Region Size %age Used [ 112s] rom: 16580 B16 KB101.20% [ 112s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 112s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 112s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 112s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 112s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 112s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 112s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 196 bytes [ 112s] collect2: error: ld returned 1 exit status [ 112s] % [ 112s] make[2]: *** [Makefile:234: flash] Error 1 [ 112s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 112s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 112s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 112s] dh_auto_build: error: make -j1 returned exit code 2 [ 112s] make: *** [debian/rules:16: build] Error 25 [ 112s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 112s] ### VM INTERACTION START ### [ 115s] [ 106.172639] sysrq: Power Off [ 115s] [ 106.176056] reboot: Power down [ 115s] ### VM INTERACTION END ### [ 115s] [ 115s] sheep87 failed "build simtrace2_0.7.0.69.aadd.dsc" at Wed Jan 27 10:35:39 UTC 2021. [ 115s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-bts in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: /var/cache/obs/worker/root_5/.pkgs/libosmocore-dev.deb: Input/output error (worker was wildcard2:5) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-pcu[master]: Introduce NACC support
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/22385 )
Change subject: Introduce NACC support
..
Patch Set 9:
(13 comments)
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/gprs_bssgp_rim.c
File src/gprs_bssgp_rim.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/gprs_bssgp_rim.c@142
PS9, Line 142: "Rx RAN-INFO with an app error! cause: %s\n",
I think all of those log messages about incoming RIM should always print a
stringified verson of the source address, as otherwise it will be pretty
difficult to debug in any real workld network, where tons of other cells will
be sending us RIM requests
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/nacc_fsm.c
File src/nacc_fsm.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/nacc_fsm.c@55
PS9, Line 55: static struct msgb *create_packet_neighbour_cell_data(struct
nacc_fsm_ctx *ctx, struct gprs_rlcmac_tbf *tbf)
const for tbf? or is it written to?
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/nacc_fsm.c@139
PS9, Line 139: static struct msgb *create_packet_cell_chg_continue(struct
nacc_fsm_ctx *ctx, struct gprs_rlcmac_tbf *tbf)
same here: const?
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/nacc_fsm.c@182
PS9, Line 182: static int fill_rim_ran_info_req(struct nacc_fsm_ctx *ctx,
struct bssgp_ran_information_pdu *pdu)
const for the 'ctx'? usually output argument as first argument (unless pcu uses
different conventions)
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.h
File src/neigh_cache.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.h@49
PS9, Line 49: struct llist_head list; /* to be included in neigh_cache->list
*/
could possibly go for hashtable right away, now that we have it in libosmocore?
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.h@72
PS9, Line 72: struct llist_head list; /* list of si_cache_entry items */
likewise, could use hashtable.h
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.c
File src/neigh_cache.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.c@33
PS9, Line 33: static void neigh_cache_cleanup_cb(void *data) {
we normally have '{' on a separate line in C...
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.c@53
PS9, Line 53: static void neigh_cache_schedule_cleanup(struct neigh_cache
*cache) {
we normally have '{' on a separate line in C...
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.c@93
PS9, Line 93: it = talloc_zero(cache, struct neigh_cache_entry);
no OSMO_ASSERT() or NULL check after allocation
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.c@149
PS9, Line 149: static void si_cache_cleanup_cb(void *data) {
see above
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.c@169
PS9, Line 169: static void si_cache_schedule_cleanup(struct si_cache *cache) {
style, see above
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.c@193
PS9, Line 193: struct si_cache *cache = talloc_zero(ctx, struct si_cache);
no ASSERT or NULL check after allocation
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.c@208
PS9, Line 208: it = talloc_zero(cache, struct si_cache_entry);
no ASSERT or NULL check after allocation
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22385
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id35f40d05f3e081f32fddbf1fa34cb338db452ca
Gerrit-Change-Number: 22385
Gerrit-PatchSet: 9
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: fixeria
Gerrit-CC: laforge
Gerrit-Comment-Date: Wed, 27 Jan 2021 10:59:22 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in osmo-pcu[master]: NACC: allow setting keep time for entries in neigh and si cache
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22449 ) Change subject: NACC: allow setting keep time for entries in neigh and si cache .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22449 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifa336aa27dd88ff5b78dbc5a2799740f542bb369 Gerrit-Change-Number: 22449 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 10:59:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: NACC: Configure neighbor and SI resolution timeout values
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22450 ) Change subject: NACC: Configure neighbor and SI resolution timeout values .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22450 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia9932ab082ec095294e85dc4d532046970e17986 Gerrit-Change-Number: 22450 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 11:00:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: NACC: Send only Pkt Cell Chg Continue if SI retrieve fails
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22451 ) Change subject: NACC: Send only Pkt Cell Chg Continue if SI retrieve fails .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22451 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie3f12a08ad611b1086d3f4ab7c3d34af43c07961 Gerrit-Change-Number: 22451 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 11:00:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_bssgp: agregate RIM related code in gprs_bssgp_rim.c
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22442 ) Change subject: gprs_bssgp: agregate RIM related code in gprs_bssgp_rim.c .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icda279452962b06e552cb1361d2a27b7dc8a6b04 Gerrit-Change-Number: 22442 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 27 Jan 2021 11:15:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: gbproxy: Use Misc_Helpers.f_shutdown() whenever applicable
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22459 ) Change subject: gbproxy: Use Misc_Helpers.f_shutdown() whenever applicable .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4fdd47e9c5887597dca89580f856ddc6cd8f54f1 Gerrit-Change-Number: 22459 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 27 Jan 2021 11:16:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_nacc_outbound_success
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387 )
Change subject: pcu: Introduce test TC_nacc_outbound_success
..
Patch Set 3:
(3 comments)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/library/GSM_Types.ttcn
File library/GSM_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/library/GSM_Types.ttcn@425
PS3, Line 425: bcdmccmnc := str2hex(mcc_str[0]) & str2hex(mcc_str[1])
& str2hex(mnc_str[2]) &
> why not one "mncc_str_hex := str2hex(mncc_str)" above and then avoid calling
> that function 9 times - […]
I'll try that. TBH I personally find this hexstrings a bit confusing to work
with, specially how they get converted from other types, probably because I'm
not used to them.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/pcu/PCU_Tests.ttcn
File pcu/PCU_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/pcu/PCU_Tests.ttcn@3588
PS3, Line 3588: while (true) {
: f_rx_rlcmac_dl_block(dl_block, sched_fn);
: if (not match(dl_block,
tr_RLCMAC_DUMMY_CTRL())) {
: break;
: }
: if (i > 50) {
: setverdict(fail, "Rx unexpected DL
block: ", dl_block);
: f_shutdown(__BFILE__, __LINE__);
: return;
: }
: i := i + 1;
: }
> does it make sense to factor this out into a separate function? something in
> principle like "wait_fo […]
Fine. These will be removed anyway once I continue with the work to move all
this stuff to altsteps.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/pcu/PCU_Tests.ttcn@3609
PS3, Line 3609: return
> I guess that's not needed anywhere after f_shutdown()?
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I951db4af731e5a7c207f0f407dd78d166e2d3d26
Gerrit-Change-Number: 22387
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Comment-Date: Wed, 27 Jan 2021 11:25:50 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_nacc_outbound_rac_ci_resolve_timeout
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22452 ) Change subject: pcu: Introduce test TC_nacc_outbound_rac_ci_resolve_timeout .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22452/1/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22452/1/pcu/PCU_Tests.ttcn@3801 PS1, Line 3801: f_rx_rlcmac_dl_block(dl_block, sched_fn); > is this guarded by a timeout? un-bounded loops always make me uneasy ;) Yes there's a global T_Guard, IIRC I checked that a few days ago to make sure. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia09fbfe9aba34a51e0715d1c307de280e3ae0249 Gerrit-Change-Number: 22452 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 11:26:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in osmo-pcu[master]: Introduce NACC support
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/22385 )
Change subject: Introduce NACC support
..
Patch Set 9:
(7 comments)
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/gprs_bssgp_rim.c
File src/gprs_bssgp_rim.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/gprs_bssgp_rim.c@142
PS9, Line 142: "Rx RAN-INFO with an app error! cause: %s\n",
> I think all of those log messages about incoming RIM should always print a
> stringified verson of the […]
Ack
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/nacc_fsm.c
File src/nacc_fsm.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/nacc_fsm.c@55
PS9, Line 55: static struct msgb *create_packet_neighbour_cell_data(struct
nacc_fsm_ctx *ctx, struct gprs_rlcmac_tbf *tbf)
> const for tbf? or is it written to?
I'll check if any function requires it to be non-null, it could be.
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/nacc_fsm.c@182
PS9, Line 182: static int fill_rim_ran_info_req(struct nacc_fsm_ctx *ctx,
struct bssgp_ran_information_pdu *pdu)
> const for the 'ctx'? usually output argument as first argument (unless pcu
> uses different convention […]
const: ack.
order: it's arguable, I was keeping the "ctx" as first param as in object
oriented, but I don't have a strong opinion here given that's a static helper.
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.h
File src/neigh_cache.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.h@49
PS9, Line 49: struct llist_head list; /* to be included in neigh_cache->list
*/
> could possibly go for hashtable right away, now that we have it in
> libosmocore?
I would then need to hash quite complex keys, I'll have a look but I think I'll
leave it as it is. I'm not saying I'm not changing it, but I have plenty of
things to do still for this task so I'm leaving this for the end.
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.c
File src/neigh_cache.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.c@33
PS9, Line 33: static void neigh_cache_cleanup_cb(void *data) {
> we normally have '{' on a separate line in C...
Ack
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.c@53
PS9, Line 53: static void neigh_cache_schedule_cleanup(struct neigh_cache
*cache) {
> we normally have '{' on a separate line in C...
Ack
https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.c@93
PS9, Line 93: it = talloc_zero(cache, struct neigh_cache_entry);
> no OSMO_ASSERT() or NULL check after allocation
Usual rant about whether malloc can fail or not :P I'll add it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22385
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id35f40d05f3e081f32fddbf1fa34cb338db452ca
Gerrit-Change-Number: 22385
Gerrit-PatchSet: 9
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: fixeria
Gerrit-CC: laforge
Gerrit-Comment-Date: Wed, 27 Jan 2021 11:34:40 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_bssgp_rim: add functions to convert a RIM-RI to a string
pespin has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/22438 )
Change subject: gprs_bssgp_rim: add functions to convert a RIM-RI to a string
..
gprs_bssgp_rim: add functions to convert a RIM-RI to a string
RIM routing formation structs can contain different variants of address
identifiers, so it is difficult for an API user to pick the _name()
function to generate a human readable string. Lets add
bssgp_rim_ri_name() and bssgp_rim_ri_name_buf() to make printing a
routing identifier easier.
Change-Id: Idca6bdccffe663aea71a0183ca3ea5bb5b59e702
Related: SYS#5103
---
M include/osmocom/gprs/gprs_bssgp_rim.h
M src/gb/gprs_bssgp_rim.c
M src/gb/libosmogb.map
3 files changed, 66 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/gprs/gprs_bssgp_rim.h
b/include/osmocom/gprs/gprs_bssgp_rim.h
index 55341de..418c1bd 100644
--- a/include/osmocom/gprs/gprs_bssgp_rim.h
+++ b/include/osmocom/gprs/gprs_bssgp_rim.h
@@ -66,6 +66,8 @@
* address type (discr) of variable length. */
#define BSSGP_RIM_ROUTING_INFO_MAXLEN 14
+char *bssgp_rim_ri_name_buf(char *buf, size_t buf_len, const struct
bssgp_rim_routing_info *ri);
+const char *bssgp_rim_ri_name(const struct bssgp_rim_routing_info *ri);
int bssgp_parse_rim_ri(struct bssgp_rim_routing_info *ri, const uint8_t *buf,
unsigned int len);
int bssgp_create_rim_ri(uint8_t *buf, const struct bssgp_rim_routing_info *ri);
diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c
index 844268a..15d6e22 100644
--- a/src/gb/gprs_bssgp_rim.c
+++ b/src/gb/gprs_bssgp_rim.c
@@ -146,6 +146,68 @@
return len;
}
+/*! Encode a RIM Routing information into a human readable string.
+ * \param[buf] user provided string buffer to store the resulting string.
+ * \param[buf_len] maximum length of string buffer.
+ * \param[in] ri user provided input data struct.
+ * \returns pointer to the beginning of the resulting string stored in string
buffer. */
+char *bssgp_rim_ri_name_buf(char *buf, size_t buf_len, const struct
bssgp_rim_routing_info *ri)
+{
+ char plmn_str[16];
+ char enb_id_str[16];
+ char g_id_ps_str[32];
+ struct osmo_plmn_id plmn;
+ struct osmo_cell_global_id_ps g_id_ps;
+
+ if (!ri)
+ return NULL;
+
+ switch (ri->discr) {
+ case BSSGP_RIM_ROUTING_INFO_GERAN:
+ g_id_ps.rai.rac = ri->geran.raid.rac;
+ g_id_ps.rai.lac.lac = ri->geran.raid.lac;
+ g_id_ps.rai.lac.plmn.mcc = ri->geran.raid.mcc;
+ g_id_ps.rai.lac.plmn.mnc_3_digits = ri->geran.raid.mnc_3_digits;
+ g_id_ps.rai.lac.plmn.mnc = ri->geran.raid.mnc;
+ g_id_ps.cell_identity = ri->geran.cid;
+ snprintf(buf, buf_len, "%s-%s",
bssgp_rim_routing_info_discr_str(ri->discr),
+osmo_cgi_ps_name_buf(g_id_ps_str, sizeof(g_id_ps_str),
&g_id_ps));
+ break;
+ case BSSGP_RIM_ROUTING_INFO_UTRAN:
+ g_id_ps.rai.rac = ri->utran.raid.rac;
+ g_id_ps.rai.lac.lac = ri->utran.raid.lac;
+ g_id_ps.rai.lac.plmn.mcc = ri->utran.raid.mcc;
+ g_id_ps.rai.lac.plmn.mnc_3_digits = ri->utran.raid.mnc_3_digits;
+ g_id_ps.rai.lac.plmn.mnc = ri->utran.raid.mnc;
+ g_id_ps.cell_identity = ri->utran.rncid;
+ snprintf(buf, buf_len, "%s-%s",
bssgp_rim_routing_info_discr_str(ri->discr),
+osmo_cgi_ps_name_buf(g_id_ps_str, sizeof(g_id_ps_str),
&g_id_ps));
+ break;
+ case BSSGP_RIM_ROUTING_INFO_EUTRAN:
+ plmn.mcc = ri->eutran.tai.mcc;
+ plmn.mnc = ri->eutran.tai.mnc;
+ plmn.mnc_3_digits = ri->eutran.tai.mnc_3_digits;
+ snprintf(buf, buf_len, "%s-%s-%u-%s",
bssgp_rim_routing_info_discr_str(ri->discr),
+osmo_plmn_name_buf(plmn_str, sizeof(plmn_str), &plmn),
ri->eutran.tai.tac,
+osmo_hexdump_buf(enb_id_str, sizeof(enb_id_str),
ri->eutran.global_enb_id,
+ ri->eutran.global_enb_id_len, "",
false));
+ break;
+ default:
+ snprintf(buf, buf_len, "invalid");
+ }
+
+ return buf;
+}
+
+/*! Encode a RIM Routing information into a human readable string.
+ * \param[in] ri user provided input data struct.
+ * \returns pointer to the resulting string. */
+const char *bssgp_rim_ri_name(const struct bssgp_rim_routing_info *ri)
+{
+ static __thread char rim_ri_buf[64];
+ return bssgp_rim_ri_name_buf(rim_ri_buf, sizeof(rim_ri_buf), ri);
+}
+
/*! Decode a RAN Information Request Application Container for NACC (3GPP TS
48.018, section 11.3.63.1.1).
* \param[out] user provided memory for decoded data struct.
* \param[in] buf user provided memo
Change in libosmocore[master]: gprs_bssgp_rim: cosmetic: connect routing identifier strings with "-"
pespin has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/22439 )
Change subject: gprs_bssgp_rim: cosmetic: connect routing identifier strings
with "-"
..
gprs_bssgp_rim: cosmetic: connect routing identifier strings with "-"
The bssgp_rim_routing_info_discr_strs string list contains whitespaces,
when the whitespaces are replaced with a "-" the log output looks better
Change-Id: I26facd3dc160603da89dcd787cccf78b19a20f02
Related: SYS#5103
---
M src/gb/gprs_bssgp_rim.c
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c
index 15d6e22..25f9406 100644
--- a/src/gb/gprs_bssgp_rim.c
+++ b/src/gb/gprs_bssgp_rim.c
@@ -42,9 +42,9 @@
#define REP_CELL_ID_LEN 8
const struct value_string bssgp_rim_routing_info_discr_strs[] = {
- { BSSGP_RIM_ROUTING_INFO_GERAN, "GERAN cell" },
- { BSSGP_RIM_ROUTING_INFO_UTRAN, "UTRAN RNC" },
- { BSSGP_RIM_ROUTING_INFO_EUTRAN,"E-UTRAN eNodeB/HeNB" },
+ { BSSGP_RIM_ROUTING_INFO_GERAN, "GERAN-cell" },
+ { BSSGP_RIM_ROUTING_INFO_UTRAN, "UTRAN-RNC" },
+ { BSSGP_RIM_ROUTING_INFO_EUTRAN,"E-UTRAN-eNodeB/HeNB" },
{ 0, NULL }
};
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22439
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I26facd3dc160603da89dcd787cccf78b19a20f02
Gerrit-Change-Number: 22439
Gerrit-PatchSet: 3
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: gprs_bssgp: log source and destination RIM routing information
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22440 ) Change subject: gprs_bssgp: log source and destination RIM routing information .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22440 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia08d3b162a4f6257cccaa7f0764fa7ea498355ef Gerrit-Change-Number: 22440 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 27 Jan 2021 11:59:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_bssgp: log source and destination RIM routing information
pespin has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/22440 )
Change subject: gprs_bssgp: log source and destination RIM routing information
..
gprs_bssgp: log source and destination RIM routing information
Whenever a RIM PDU is received, log to which RIM routing information
(address) it is going to and where it is comming from.
Change-Id: Ia08d3b162a4f6257cccaa7f0764fa7ea498355ef
Related: SYS#5103
---
M src/gb/gprs_bssgp.c
M src/gb/gprs_bssgp_util.c
2 files changed, 12 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c
index 6fdacce..4154c4b 100644
--- a/src/gb/gprs_bssgp.c
+++ b/src/gb/gprs_bssgp.c
@@ -653,8 +653,8 @@
uint16_t nsei = msgb_nsei(msg);
struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr
*)msgb_bssgph(msg);
enum bssgp_prim prim;
-
- DEBUGP(DLBSSGP, "BSSGP BVCI=%u Rx RIM-PDU:%s\n", bvci,
bssgp_pdu_str(bgph->pdu_type));
+ char ri_src_str[64];
+ char ri_dest_str[64];
/* Specify PRIM type based on the RIM PDU */
switch (bgph->pdu_type) {
@@ -677,6 +677,10 @@
nmp.tp = tp;
if (bssgp_parse_rim_pdu(&nmp.u.rim_pdu, msg) < 0)
return bssgp_tx_status(BSSGP_CAUSE_MISSING_MAND_IE, NULL, msg);
+ DEBUGP(DLBSSGP, "BSSGP BVCI=%u Rx RIM-PDU:%s, src=%s, dest=%s\n",
+ bvci, bssgp_pdu_str(bgph->pdu_type),
+ bssgp_rim_ri_name_buf(ri_src_str, sizeof(ri_src_str),
&nmp.u.rim_pdu.routing_info_src),
+ bssgp_rim_ri_name_buf(ri_dest_str, sizeof(ri_dest_str),
&nmp.u.rim_pdu.routing_info_dest));
osmo_prim_init(&nmp.oph, SAP_BSSGP_RIM, prim, PRIM_OP_INDICATION, msg);
bssgp_prim_cb(&nmp.oph, NULL);
diff --git a/src/gb/gprs_bssgp_util.c b/src/gb/gprs_bssgp_util.c
index d93c9df..e00aed9 100644
--- a/src/gb/gprs_bssgp_util.c
+++ b/src/gb/gprs_bssgp_util.c
@@ -594,6 +594,8 @@
{
struct msgb *msg;
struct bssgp_normal_hdr *bgph;
+ char ri_src_str[64];
+ char ri_dest_str[64];
/* Encode RIM PDU into mesage buffer */
msg = bssgp_encode_rim_pdu(pdu);
@@ -607,7 +609,10 @@
msgb_bvci(msg) = 0; /* Signalling */
bgph = (struct bssgp_normal_hdr *)msgb_bssgph(msg);
- DEBUGP(DLBSSGP, "BSSGP BVCI=0 Tx RIM-PDU:%s\n",
bssgp_pdu_str(bgph->pdu_type));
+ DEBUGP(DLBSSGP, "BSSGP BVCI=0 Tx RIM-PDU:%s, src=%s, dest=%s\n",
+ bssgp_pdu_str(bgph->pdu_type),
+ bssgp_rim_ri_name_buf(ri_src_str, sizeof(ri_src_str),
&pdu->routing_info_src),
+ bssgp_rim_ri_name_buf(ri_dest_str, sizeof(ri_dest_str),
&pdu->routing_info_dest));
return bssgp_ns_send(bssgp_ns_send_data, msg);
}
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22440
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia08d3b162a4f6257cccaa7f0764fa7ea498355ef
Gerrit-Change-Number: 22440
Gerrit-PatchSet: 4
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-pcu[master]: Introduce NACC support
Hello Jenkins Builder, fixeria, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/22385 to look at the new patch set (#10). Change subject: Introduce NACC support .. Introduce NACC support A new nacc_fsm is introduced per MS object, with its partner priv structure struct nacc_fsm_ctx, which exists and is available in the MS object only during the duration of the NACC procedure. The NACC context is created on an MS whenever a Pkt Cell Change Notification is received on Uplink RLCMAC, which asks for neighbor information of a given ARFCN+BSIC. First, the target ARFCN+BSIC needs to be translated into a CGI-PS (RAC+CI) address. That's done by asking the BSC through the Neighbour Resolution Service available in osmo-bsc using the CTRL interface. Once the CGI-PS of the target cell is known, PCU starts a RIM RAN-INFO request against the SGSN (which will route the request as needed), and wait for a response containing the SI bits from the target cell. After the SI are received, the scheduler is instructed to eventually poll a TBF for the MS originating the CCN, so that we can send the SI encapsulated into multiple Packet Neighbor Cell Data messages on the downlink. One all the SI bits are sent, the scheduler is instructed to send a Packet Cell Change Continue message. Once the message above has been sent, the FSM autodestroys itself. Caches are also introduced in this patch which allows for re-using recently known translations ARFCN+BSIC -> CGI-PS and CGI-PS -> SI_INFO respectively. Change-Id: Id35f40d05f3e081f32fddbf1fa34cb338db452ca --- M configure.ac M src/Makefile.am M src/bts.cpp M src/bts.h M src/encoding.cpp M src/encoding.h M src/gprs_bssgp_rim.c M src/gprs_debug.cpp M src/gprs_debug.h M src/gprs_ms.c M src/gprs_ms.h M src/gprs_pcu.c M src/gprs_pcu.h M src/gprs_rlcmac_sched.cpp A src/nacc_fsm.c A src/nacc_fsm.h A src/neigh_cache.c A src/neigh_cache.h M src/pcu_vty.c M src/pdch.cpp M src/pdch.h M src/tbf.cpp M src/tbf.h M tests/Makefile.am 24 files changed, 1,372 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/85/22385/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id35f40d05f3e081f32fddbf1fa34cb338db452ca Gerrit-Change-Number: 22385 Gerrit-PatchSet: 10 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: tbf: Make tbf_ms() param const
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/22460 )
Change subject: tbf: Make tbf_ms() param const
..
tbf: Make tbf_ms() param const
Change-Id: I041c564b15d17d05ce97ea0085fcd9192a346578
---
M src/tbf.cpp
M src/tbf.h
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/60/22460/1
diff --git a/src/tbf.cpp b/src/tbf.cpp
index d2d55f2..0fec476 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -1165,7 +1165,7 @@
return &tbf->m_bts_list.list;
}
-struct GprsMs *tbf_ms(struct gprs_rlcmac_tbf *tbf)
+struct GprsMs *tbf_ms(const struct gprs_rlcmac_tbf *tbf)
{
return tbf->ms();
}
diff --git a/src/tbf.h b/src/tbf.h
index d616076..983d38c 100644
--- a/src/tbf.h
+++ b/src/tbf.h
@@ -196,7 +196,7 @@
void tbf_set_ms(struct gprs_rlcmac_tbf *tbf, struct GprsMs *ms);
struct llist_head *tbf_ms_list(struct gprs_rlcmac_tbf *tbf);
struct llist_head *tbf_bts_list(struct gprs_rlcmac_tbf *tbf);
-struct GprsMs *tbf_ms(struct gprs_rlcmac_tbf *tbf);
+struct GprsMs *tbf_ms(const struct gprs_rlcmac_tbf *tbf);
bool tbf_timers_pending(struct gprs_rlcmac_tbf *tbf, enum tbf_timers t);
void tbf_free(struct gprs_rlcmac_tbf *tbf);
struct gprs_llc *tbf_llc(struct gprs_rlcmac_tbf *tbf);
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22460
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I041c564b15d17d05ce97ea0085fcd9192a346578
Gerrit-Change-Number: 22460
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-trx[master]: Transceiver: use proper factor for amplitude scaling
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/22456 ) Change subject: Transceiver: use proper factor for amplitude scaling .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/22456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I98bc00bd25df4913d45e55eb008d715aca76fc7c Gerrit-Change-Number: 22456 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 12:50:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: Transceiver: use proper factor for amplitude scaling
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/22456 ) Change subject: Transceiver: use proper factor for amplitude scaling .. Transceiver: use proper factor for amplitude scaling In Transceiver::addRadioVector() we scale the I/Q samples by scaling the output voltage of the DAC. A relative factor/divisor/ration in the voltage domain cannot be used 1:1 in the power domain. There exist two similar formulas: a) X_dB = 10 * log10(X_lin / X_ref) b) Y_db = 20 * log10(Y_lin / Y_ref) both of them are correct, and according to [1]: a) If you convert a quantity X that relates to power or energy, => the factor is 10. b) If you convert a quantity Y that relates to amplitude, => the factor is 20. Therefore we should be using 20 instead of 10. This change makes osmo-trx apply per-lchan attenuation values correctly. Otherwise it would double the values indicated in TRXD messages. [1] https://dspillustrations.com/pages/posts/misc/decibel-conversion-factor-10-or-factor-20.html Change-Id: I98bc00bd25df4913d45e55eb008d715aca76fc7c Related: SYS#4918 --- M Transceiver52M/Transceiver.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 3188c70..6de266c 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -396,7 +396,7 @@ else burst = modulateBurst(bits, 8 + (wTime.TN() % 4 == 0), cfg->tx_sps); - scaleVector(*burst, txFullScale * pow(10, (double) -RSSI / 10)); + scaleVector(*burst, txFullScale * pow(10, (double) -RSSI / 20)); radio_burst = new radioVector(wTime, burst); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/22456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I98bc00bd25df4913d45e55eb008d715aca76fc7c Gerrit-Change-Number: 22456 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in libosmocore[master]: gprs_bssgp: agregate RIM related code in gprs_bssgp_rim.c
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22442 ) Change subject: gprs_bssgp: agregate RIM related code in gprs_bssgp_rim.c .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icda279452962b06e552cb1361d2a27b7dc8a6b04 Gerrit-Change-Number: 22442 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 27 Jan 2021 13:55:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si
Hello Jenkins Builder, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 to look at the new patch set (#3). Change subject: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si .. PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si Perform a full RAN information request (single report) against the PCU and check the results. Also test what happens when the request is issued at a time where osmo-bts has no system information available. Depends: osmo-pcu Id72118120c14984d2fb1b918b41fac4868150d41 Depends: osmo-bts I1726c9e29cc59c499dfabbdaf63c0f1a09984764 Related: SYS#5103 Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc --- M bts/BTS_Tests.default M library/PCUIF_Types.ttcn M pcu/PCU_Tests.default M pcu/PCU_Tests.ttcn M pcu/PCU_Tests_SNS.cfg M pcu/PCU_Tests_SNSv6.cfg 6 files changed, 176 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/69/22369/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc Gerrit-Change-Number: 22369 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: BTS_Tests: check if si1, si3, si13 are updated via PCUIF
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22431 to look at the new patch set (#2). Change subject: BTS_Tests: check if si1,si3,si13 are updated via PCUIF .. BTS_Tests: check if si1,si3,si13 are updated via PCUIF The BSC can update the system information at any time. In the case of SI1, SI3, SI14 it is important that the changes are propagated to the PCU as well. Related: SYS#5103 Change-Id: I6ec543b3cb33d82c442083b52c991add71b34644 --- M bts/BTS_Tests.ttcn M library/General_Types.ttcn 2 files changed, 58 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/31/22431/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ec543b3cb33d82c442083b52c991add71b34644 Gerrit-Change-Number: 22431 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: Osmocom_Gb_types: add minimum requred tr_ templates for RAN INF
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22461 )
Change subject: Osmocom_Gb_types: add minimum requred tr_ templates for RAN INF
..
Osmocom_Gb_types: add minimum requred tr_ templates for RAN INF
When testing the serving BSS part of the RIM application in osmo-pcu, we
will need receiving templates that allow us to verify the response (RAN
INFORMATION) rim container.
Change-Id: I964d7504f3c4aeaa4ce537316b3140e8b893003d
Related: SYS#5103
---
M library/Osmocom_Gb_Types.ttcn
1 file changed, 111 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/61/22461/1
diff --git a/library/Osmocom_Gb_Types.ttcn b/library/Osmocom_Gb_Types.ttcn
index 2bbc508..97412b8 100644
--- a/library/Osmocom_Gb_Types.ttcn
+++ b/library/Osmocom_Gb_Types.ttcn
@@ -2511,7 +2511,14 @@
},
rIMApplicationIdentity := app_id
}
-
+ template RIM_Application_Identity tr_RIM_Application_Identity(template
OCT1 app_id := ?) := {
+iEI := '4B'O,
+ext := '1'B,
+lengthIndicator := {
+ length1 := 1
+},
+rIMApplicationIdentity := app_id
+ }
/* 3GPP TS 48.018 11.3.62 */
template (value) RIM_Sequence_Number ts_RIM_Sequence_Number(integer
seq) := {
@@ -2522,6 +2529,20 @@
},
rIMSequenceNumber := int2oct(seq, 4)
}
+ function tr_RIM_Sequence_Number(template integer seq := ?) return
template RIM_Sequence_Number {
+var template RIM_Sequence_Number ret;
+ret.iEI := '4C'O;
+ret.ext := '1'B;
+ret.lengthIndicator := { length1 := 4 };
+if (istemplatekind(seq, "*")) {
+ ret.rIMSequenceNumber := *;
+} else if (istemplatekind(seq, "?")) {
+ ret.rIMSequenceNumber := ?;
+} else {
+ ret.rIMSequenceNumber := int2oct(valueof(seq), 4);
+}
+return ret;
+ }
/* 3GPP TS 48.018 11.3.62a.1 */
template (value) RAN_Information_Request_RIM_Container
@@ -2585,10 +2606,34 @@
applContainer_or_ApplErrContainer := app_cont_or_app_err,
sON_Transfer_Application_Identity := son_app_id
}
+ template RAN_Information_RIM_Container
+ tr_RAN_Information_RIM_Container(template RIM_Application_Identity
app_id := ?,
+template RIM_Sequence_Number seq := ?,
+template RIM_PDU_Indications ind := ?,
+template RIM_Protocol_Version_Number
ver := omit,
+template
ApplContainer_or_ApplErrContainer app_cont_or_app_err := omit,
+template
SON_Transfer_Application_Identity_TLV son_app_id := omit) := {
+
+iEI := '58'O,
+ext := '1'B,
+lengthIndicator := {
+ length1 := ?
+},
+rIM_Application_Identity := app_id,
+rIM_Sequence_Number := seq,
+rIM_PDU_Indications := ind,
+rIM_Protocol_Version_Number := ver,
+applContainer_or_ApplErrContainer := app_cont_or_app_err,
+sON_Transfer_Application_Identity := son_app_id
+ }
template (value) ApplContainer_or_ApplErrContainer
tsu_ApplContainer_or_ApplErrContainer_NACC(template (value)
ApplContainer_or_ApplErrContainer_NACC cont) := {
nacc := cont
}
+ template ApplContainer_or_ApplErrContainer
+ tru_ApplContainer_or_ApplErrContainer_NACC(template
ApplContainer_or_ApplErrContainer_NACC cont := ?) := {
+ nacc := cont
+ }
template (value) ApplContainer_or_ApplErrContainer
tsu_ApplContainer_or_ApplErrContainer_SI3(template (value)
ApplContainer_or_ApplErrContainer_SI3 cont) := {
si3 := cont
@@ -2601,6 +2646,10 @@
tsu_ApplContainer_NACC(template (value) BssgpCellId cid, boolean
psi_type, integer si_psi_num, octetstring si_psi) := {
application_Container :=
ts_RAN_Information_Application_Container_NACC(cid, psi_type, si_psi_num, si_psi)
}
+ template ApplContainer_or_ApplErrContainer_NACC
+ tru_ApplContainer_NACC(template BssgpCellId cid := ?, template boolean
psi_type := ?, template integer si_psi_num := ?, template octetstring si_psi :=
?) := {
+ application_Container :=
tr_RAN_Information_Application_Container_NACC(cid, psi_type, si_psi_num, si_psi)
+ }
template (value) ApplContainer_or_ApplErrContainer_NACC
tsu_ApplErrContainer_NACC(temp
Change in osmo-ttcn3-hacks[master]: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 ) Change subject: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si .. Patch Set 3: (4 comments) > Patch Set 1: Code-Review-2 > > We cannot just bump the protocol version here, as we also need to test the > 'latest' osmo-pcu. See my comments to the related changes for osmo-pcu. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/Osmocom_Gb_Types.ttcn File library/Osmocom_Gb_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/Osmocom_Gb_Types.ttcn@2814 PS2, Line 2814: function tr_RAN_Information_Application_Container_NACC(template BssgpCellId cid := ?, template boolean psi_type := ?, > You probably want to push all these templates and functions as a separate > patch Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/PCUIF_Types.ttcn File library/PCUIF_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/PCUIF_Types.ttcn@229 PS2, Line 229: variant (trx) "CROSSTAG(v09, version = 10; v10, version = 11)" > these lines changed here look wrong to me. I think I understand this now. This selects which specific type versions of trx and remote address we use. When version = 9, then pick trx type v09. In contrast to the comment above, the manual says that we can have N key = constant pairs and this means we can support N PCUIF versions, but all must be listed here. I have now added a version 11 that uses trx and remote_addr type v10. Also see jenkins.sh docker-playground/ttcn3-pcu-test, there we set mp_pcuif_version := 9 if we are on latest. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/pcu/PCU_Tests.ttcn@3659 PS2, Line 3659: f_init_raw(testcasename()); > you can pass info_ind as a second parameter here, no need to do the > BTS.send() below. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/pcu/PCU_Tests.ttcn@3717 PS2, Line 3717: f_sleep(0.2); /* i.e. give the IUT some time to process everything */ > which is exactly the problem you are having here? […] I copied this from other tests that use PCUIF, but it seems not to be necessary in my case because when I remove it the tests still work fine. PCU_Tests_NS seems to lack stuff I need, I will keep the testcases here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc Gerrit-Change-Number: 22369 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 14:58:10 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: BTS_Tests: check if si1, si3, si13 are updated via PCUIF
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22431 ) Change subject: BTS_Tests: check if si1,si3,si13 are updated via PCUIF .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22431/1/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22431/1/bts/BTS_Tests.ttcn@7203 PS1, Line 7203: /* Check that if the system informatio (si1, si3, si13, required for RIM) is > information (... […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22431/1/bts/BTS_Tests.ttcn@7204 PS1, Line 7204: * correctly propergated to the PCU after updating it via RSL */ > propergated! Properly gated! I like the construction. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ec543b3cb33d82c442083b52c991add71b34644 Gerrit-Change-Number: 22431 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 27 Jan 2021 14:58:30 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_nacc_outbound_success
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387 to look at the new patch set (#4). Change subject: pcu: Introduce test TC_nacc_outbound_success .. pcu: Introduce test TC_nacc_outbound_success Related: SYS#4909 Change-Id: I951db4af731e5a7c207f0f407dd78d166e2d3d26 --- M library/GSM_Types.ttcn M pcu/PCU_Tests.ttcn M pcu/gen_links.sh M pcu/osmo-pcu.cfg M pcu/regen_makefile.sh 5 files changed, 205 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/87/22387/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I951db4af731e5a7c207f0f407dd78d166e2d3d26 Gerrit-Change-Number: 22387 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_nacc_outbound_si_resolve_timeout
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22453 to look at the new patch set (#2). Change subject: pcu: Introduce test TC_nacc_outbound_si_resolve_timeout .. pcu: Introduce test TC_nacc_outbound_si_resolve_timeout Related: SYS#4909 Change-Id: If0032b940685efaaa8f65357c56c3383fab3e283 --- M pcu/PCU_Tests.ttcn 1 file changed, 77 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/22453/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22453 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0032b940685efaaa8f65357c56c3383fab3e283 Gerrit-Change-Number: 22453 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_nacc_outbound_rac_ci_resolve_timeout
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22452 to look at the new patch set (#2). Change subject: pcu: Introduce test TC_nacc_outbound_rac_ci_resolve_timeout .. pcu: Introduce test TC_nacc_outbound_rac_ci_resolve_timeout Related: SYS#4909 Change-Id: Ia09fbfe9aba34a51e0715d1c307de280e3ae0249 --- M pcu/PCU_Tests.ttcn 1 file changed, 63 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/22452/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia09fbfe9aba34a51e0715d1c307de280e3ae0249 Gerrit-Change-Number: 22452 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_nacc_outbound_rac_ci_resolve_fail_parse_response
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22454 to look at the new patch set (#2). Change subject: pcu: Introduce test TC_nacc_outbound_rac_ci_resolve_fail_parse_response .. pcu: Introduce test TC_nacc_outbound_rac_ci_resolve_fail_parse_response Related: SYS#4909 Change-Id: If7efddb1ae2ccb580fe85c8df45c9ccdb818c6f3 --- M pcu/PCU_Tests.ttcn 1 file changed, 62 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/22454/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If7efddb1ae2ccb580fe85c8df45c9ccdb818c6f3 Gerrit-Change-Number: 22454 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: pcu_sock: send SI1, SI3 and SI3 along with PCUIF info indication
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22367 ) Change subject: pcu_sock: send SI1, SI3 and SI3 along with PCUIF info indication .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/22367/3/TODO-RELEASE File TODO-RELEASE: https://gerrit.osmocom.org/c/osmo-bts/+/22367/3/TODO-RELEASE@2 PS3, Line 2: * increment PCUIF version number > That's not something we really need to do when we do a release right? Incrementing the version number makes the pcu incompatible with the current bts and vice versa if both sides do not increment at the time. Wenn we release we must keep an eye on this. However, I do not know if this is off-topic in TODO_RELEASE, i don't know. Do you think I should remove this point from TODO_RELEASE? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie8c3467b6cf8b8bfdeee9a281412d814cbc379b8 Gerrit-Change-Number: 22367 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 27 Jan 2021 15:06:17 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-pcu[master]: gprs_bssgp_rim: add serving BSS NACC application
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22368 ) Change subject: gprs_bssgp_rim: add serving BSS NACC application .. Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/22368/2/src/gprs_bssgp_rim.c File src/gprs_bssgp_rim.c: https://gerrit.osmocom.org/c/osmo-pcu/+/22368/2/src/gprs_bssgp_rim.c@208 PS2, Line 208: BSSGP RIM (NSEI=%u) > we just had this in the review of another patch; please introduce and use > something like #define LOG […] Done https://gerrit.osmocom.org/c/osmo-pcu/+/22368/2/src/pcu_l1_if.cpp File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/22368/2/src/pcu_l1_if.cpp@660 PS2, Line 660: LOGP(DL1IF, LOGL_DEBUG, " si1=%s\n", osmo_hexdump_nospc(info_ind->si1, GSM_MACBLOCK_LEN)); > better use sizeof(info_ind->si1) everywhere, we don't really car about the > real size here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id72118120c14984d2fb1b918b41fac4868150d41 Gerrit-Change-Number: 22368 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 27 Jan 2021 15:07:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: BTS_Tests: check if si1, si3, si13 are updated via PCUIF
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22431 ) Change subject: BTS_Tests: check if si1,si3,si13 are updated via PCUIF .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22431/2/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22431/2/bts/BTS_Tests.ttcn@7203 PS2, Line 7203: /* Check that if the system information (si1, si3, si13, required for RIM) is the "if" here should be removed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ec543b3cb33d82c442083b52c991add71b34644 Gerrit-Change-Number: 22431 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 27 Jan 2021 15:09:20 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: BTS_Tests: check if si1, si3, si13 are updated via PCUIF
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22431 ) Change subject: BTS_Tests: check if si1,si3,si13 are updated via PCUIF .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ec543b3cb33d82c442083b52c991add71b34644 Gerrit-Change-Number: 22431 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 27 Jan 2021 15:09:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: pcu_sock: send SI1, SI3 and SI3 along with PCUIF info indication
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22367 ) Change subject: pcu_sock: send SI1, SI3 and SI3 along with PCUIF info indication .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/22367/3/TODO-RELEASE File TODO-RELEASE: https://gerrit.osmocom.org/c/osmo-bts/+/22367/3/TODO-RELEASE@2 PS3, Line 2: * increment PCUIF version number > Incrementing the version number makes the pcu incompatible with the current > bts and vice versa if bo […] I think it's confusing since it's not simething I really need to care about when releasing (since the version is already bumped in this same commit). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie8c3467b6cf8b8bfdeee9a281412d814cbc379b8 Gerrit-Change-Number: 22367 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 27 Jan 2021 15:10:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: dexter Gerrit-MessageType: comment
Change in osmo-pcu[master]: gprs_bssgp_rim: add serving BSS NACC application
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22368 ) Change subject: gprs_bssgp_rim: add serving BSS NACC application .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/22368/4/TODO-RELEASE File TODO-RELEASE: https://gerrit.osmocom.org/c/osmo-pcu/+/22368/4/TODO-RELEASE@12 PS4, Line 12: osmo-pcuincrement PCUIF version number again I think this is confusing here from release point of view since I need to do nothing regarding this line upon creating new release. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id72118120c14984d2fb1b918b41fac4868150d41 Gerrit-Change-Number: 22368 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 27 Jan 2021 15:12:37 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 ) Change subject: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si .. Patch Set 3: I still don't like this approach, sorry. And still don't understand why you prefer it. Just imagine that we would need to send another type of System Information, e.g. SI4. This would require you to bump the protocol version again. If it's possible to avoid bumping the version, I would definitely avoid doing it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc Gerrit-Change-Number: 22369 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 15:23:46 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 ) Change subject: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si .. Patch Set 3: (3 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/PCUIF_Types.ttcn File library/PCUIF_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/PCUIF_Types.ttcn@229 PS2, Line 229: variant (trx) "CROSSTAG(v09, version = 10; v10, version = 11)" > I think I understand this now. […] This is basically the backwards compatibility logic. And I agree with Pau, the changes look wrong. Since PCUIFv10 we should use record 'v10' in the union, before PCUIFv10 it's 'v09'. Why do you make PCUIFv10 use record 'v09'? This is wrong. Did you try to run other test cases? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/PCUIF_Types.ttcn@919 PS2, Line 919: ? '?' implies that the field is always present (not omit). This would break PCUIFv10. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/pcu/PCU_Tests.ttcn@106 PS2, Line 106: si1 := '5506198fb1792b'O, We do have records for SI1 and SI3 in 'library/GSM_SystemInformation.ttcn', adding a new one for SI4 should be trivial, so why do we have magic octetstrings here? Check SystemInformationConfig_default in BSC_Tests for example. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc Gerrit-Change-Number: 22369 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 15:35:15 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: dexter Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 ) Change subject: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si .. Patch Set 3: > Patch Set 3: > > I still don't like this approach, sorry. And still don't understand why you > prefer it. Just imagine that we would need to send another type of System > Information, e.g. SI4. This would require you to bump the protocol version > again. If it's possible to avoid bumping the version, I would definitely > avoid doing it. You can easily support new and old versions (be backward compatible) if you add the fields at the end of the struct, I see no problem there. Older implementations won't see those fields and won't access them. The only benefit I see in adding a new message type to send SI information is that if they change more frequently, then we don't need to send the entire info_ind to the pcu and make it parse all of it again. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc Gerrit-Change-Number: 22369 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 15:39:15 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: ctrl_connection: Initialize write_queue.bfd.fd to -1 during allocation
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/22462 ) Change subject: ctrl_connection: Initialize write_queue.bfd.fd to -1 during allocation .. ctrl_connection: Initialize write_queue.bfd.fd to -1 during allocation Otherwise fd is set to 0 by default, let's avoid accidentally closing it if something goes wrong. Change-Id: I98f744d2880fbb883719cdf1d3eb31f2b22a13b6 --- M src/ctrl/control_if.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/22462/1 diff --git a/src/ctrl/control_if.c b/src/ctrl/control_if.c index 9e3e3a9..5eb81c7 100644 --- a/src/ctrl/control_if.c +++ b/src/ctrl/control_if.c @@ -514,6 +514,7 @@ INIT_LLIST_HEAD(&ccon->def_cmds); ccon->write_queue.bfd.data = data; + ccon->write_queue.bfd.fd = -1; ccon->write_queue.write_cb = control_write_cb; ccon->write_queue.read_cb = handle_control_read; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22462 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I98f744d2880fbb883719cdf1d3eb31f2b22a13b6 Gerrit-Change-Number: 22462 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in gapk[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/gapk/+/22463 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: I7d4c4e1f3663e448c5d044ccb4bbd3e813898f23 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/63/22463/1 diff --git a/configure.ac b/configure.ac index 44a7cff..b16acc8 100644 --- a/configure.ac +++ b/configure.ac @@ -6,6 +6,8 @@ AM_INIT_AUTOMAKE([dist-bzip2 subdir-objects]) LT_INIT([disable-static]) +CFLAGS="$CFLAGS -std=gnu11" + # kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/gapk/+/22463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I7d4c4e1f3663e448c5d044ccb4bbd3e813898f23 Gerrit-Change-Number: 22463 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in libgtpnl[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libgtpnl/+/22464 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: Iea60698b4cb0f9c04a6f75cc4ca2ea5fbb84bae8 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/64/22464/1 diff --git a/configure.ac b/configure.ac index 6962261..eb35f57 100644 --- a/configure.ac +++ b/configure.ac @@ -13,6 +13,8 @@ RELMAKE='-include osmo-release.mk' AC_SUBST([RELMAKE]) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/22464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Iea60698b4cb0f9c04a6f75cc4ca2ea5fbb84bae8 Gerrit-Change-Number: 22464 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in libosmo-abis[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/22465 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: Ib920af17b9a0b5d6ea5f4db33faab3a2dcf8fbbe --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/65/22465/1 diff --git a/configure.ac b/configure.ac index a7dde2f..6a3bc4b 100644 --- a/configure.ac +++ b/configure.ac @@ -8,6 +8,8 @@ AM_INIT_AUTOMAKE([foreign dist-bzip2 no-dist-gzip 1.6 subdir-objects]) AC_CONFIG_TESTDIR(tests) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/22465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib920af17b9a0b5d6ea5f4db33faab3a2dcf8fbbe Gerrit-Change-Number: 22465 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in libosmo-netif[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/22466 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: Ia646e72ce58de331c325b75e94fa1539acd5930b --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/66/22466/1 diff --git a/configure.ac b/configure.ac index 4c0e0b4..36c2f49 100644 --- a/configure.ac +++ b/configure.ac @@ -8,6 +8,8 @@ AM_INIT_AUTOMAKE([subdir-objects dist-bzip2]) AC_CONFIG_TESTDIR(tests) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/22466 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia646e72ce58de331c325b75e94fa1539acd5930b Gerrit-Change-Number: 22466 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in libosmo-sccp[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/22467 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: Iabe929a29a3c7fed2726329215097f7254cf20ca --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/67/22467/1 diff --git a/configure.ac b/configure.ac index 725014d..cd79231 100644 --- a/configure.ac +++ b/configure.ac @@ -9,6 +9,8 @@ AM_INIT_AUTOMAKE([dist-bzip2]) AC_CONFIG_TESTDIR(tests) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/22467 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iabe929a29a3c7fed2726329215097f7254cf20ca Gerrit-Change-Number: 22467 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in libtelnet[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libtelnet/+/22468 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: Ief41cc4fc2e3d763a4b84f427496a5611f3c90c5 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libtelnet refs/changes/68/22468/1 diff --git a/configure.ac b/configure.ac index 16489f4..6b85c74 100644 --- a/configure.ac +++ b/configure.ac @@ -2,6 +2,8 @@ AM_INIT_AUTOMAKE +CFLAGS="$CFLAGS -std=gnu11" + AC_PROG_CC AC_PROG_LIBTOOL -- To view, visit https://gerrit.osmocom.org/c/libtelnet/+/22468 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libtelnet Gerrit-Branch: master Gerrit-Change-Id: Ief41cc4fc2e3d763a4b84f427496a5611f3c90c5 Gerrit-Change-Number: 22468 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in libosmocore[master]: configure.ac: set -std=gnu11
Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/22355 to look at the new patch set (#5). Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Avoid using different dialects by accident (and resulting compiler errors if compiler assumes a different dialect), like in I72310886bef4db635078b75715c9d98ee45391cc. Related: https://lists.osmocom.org/pipermail/openbsc/2019-September/013030.html Related: https://lists.osmocom.org/pipermail/openbsc/2021-January/013360.html Related: osmo-pcu Ia57ba101627e3cc0babeca82631e207a3e2e0960 Change-Id: Id79b13d3c498acb565f91eba650328fccb5a13ef --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/55/22355/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id79b13d3c498acb565f91eba650328fccb5a13ef Gerrit-Change-Number: 22355 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-CC: lynxis lazus Gerrit-MessageType: newpatchset
Change in libusrp[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libusrp/+/22469 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: I9245df7569f0fed936d5e1a1783fc40203cecba1 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libusrp refs/changes/69/22469/1 diff --git a/configure.ac b/configure.ac index 0b38b93..bcc95e6 100644 --- a/configure.ac +++ b/configure.ac @@ -7,6 +7,8 @@ AC_CONFIG_MACRO_DIRS([m4]) +CFLAGS="$CFLAGS -std=gnu11" + dnl include release helper RELMAKE='-include osmo-release.mk' AC_SUBST([RELMAKE]) -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/22469 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: I9245df7569f0fed936d5e1a1783fc40203cecba1 Gerrit-Change-Number: 22469 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-bsc[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22470 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: I61ee711de5303691c2f8881b66d4614d11850be2 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/70/22470/1 diff --git a/configure.ac b/configure.ac index f1f17b8..343c031 100644 --- a/configure.ac +++ b/configure.ac @@ -9,6 +9,8 @@ AM_INIT_AUTOMAKE([dist-bzip2]) AC_CONFIG_TESTDIR(tests) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I61ee711de5303691c2f8881b66d4614d11850be2 Gerrit-Change-Number: 22470 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-bts[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/22471 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: I234394b2c8bec2a3920fd57bee238b99e4e60c22 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/71/22471/1 diff --git a/configure.ac b/configure.ac index 58a7e38..249a81a 100644 --- a/configure.ac +++ b/configure.ac @@ -9,6 +9,8 @@ AM_INIT_AUTOMAKE([dist-bzip2]) AC_CONFIG_TESTDIR(tests) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22471 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I234394b2c8bec2a3920fd57bee238b99e4e60c22 Gerrit-Change-Number: 22471 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-cbc[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/22472 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: I8fe45ab98a2a000a428a17d586f4dd4f1ba5f2d6 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/72/22472/1 diff --git a/configure.ac b/configure.ac index 342eb84..2accd12 100644 --- a/configure.ac +++ b/configure.ac @@ -9,6 +9,8 @@ AM_INIT_AUTOMAKE([dist-bzip2]) AC_CONFIG_TESTDIR(tests) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/22472 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I8fe45ab98a2a000a428a17d586f4dd4f1ba5f2d6 Gerrit-Change-Number: 22472 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-e1d[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/22474 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: Ib2356c2158b5aaa27cb4692de0f92d09d0bfca06 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/74/22474/1 diff --git a/configure.ac b/configure.ac index 548cc68..a7e4952 100644 --- a/configure.ac +++ b/configure.ac @@ -10,6 +10,8 @@ AM_INIT_AUTOMAKE([foreign dist-bzip2 no-dist-gzip 1.9]) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/22474 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib2356c2158b5aaa27cb4692de0f92d09d0bfca06 Gerrit-Change-Number: 22474 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-e1-recorder[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/22473 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: I19674944cea499d450571a7c6e47ab5676dc4b21 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-recorder refs/changes/73/22473/1 diff --git a/configure.ac b/configure.ac index dd26f5a..e986809 100644 --- a/configure.ac +++ b/configure.ac @@ -9,6 +9,8 @@ AM_INIT_AUTOMAKE([dist-bzip2]) AC_CONFIG_TESTDIR(tests) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/22473 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I19674944cea499d450571a7c6e47ab5676dc4b21 Gerrit-Change-Number: 22473 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-el2tpd[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-el2tpd/+/22475 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: I924b20265af945f5687d473b06f546ed9ac0c09b --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-el2tpd refs/changes/75/22475/1 diff --git a/configure.ac b/configure.ac index 92c1b62..3719d12 100644 --- a/configure.ac +++ b/configure.ac @@ -9,6 +9,8 @@ AM_INIT_AUTOMAKE([foreign dist-bzip2 no-dist-gzip 1.9]) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-el2tpd/+/22475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-el2tpd Gerrit-Branch: master Gerrit-Change-Id: I924b20265af945f5687d473b06f546ed9ac0c09b Gerrit-Change-Number: 22475 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-ggsn[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/22476 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: I7fed7d43242f804e6d2b005277c5b2b1bd197aa8 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/76/22476/1 diff --git a/configure.ac b/configure.ac index 9d8b4bf..a1c7180 100644 --- a/configure.ac +++ b/configure.ac @@ -9,6 +9,8 @@ AC_CONFIG_TESTDIR(tests) AC_CANONICAL_HOST +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/22476 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7fed7d43242f804e6d2b005277c5b2b1bd197aa8 Gerrit-Change-Number: 22476 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-iuh[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/22478 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: I4bf2f1cb724bc3e3c56d5a5c1270bb152b0e6e0a --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/78/22478/1 diff --git a/configure.ac b/configure.ac index c186855..d82c78f 100644 --- a/configure.ac +++ b/configure.ac @@ -13,6 +13,8 @@ AC_CONFIG_TESTDIR(src/tests) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22478 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I4bf2f1cb724bc3e3c56d5a5c1270bb152b0e6e0a Gerrit-Change-Number: 22478 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-hlr[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/22477 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: I5ea5365338248e29591a40ec1e19db95f8ae6877 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/77/22477/1 diff --git a/configure.ac b/configure.ac index 341e925..748ca56 100644 --- a/configure.ac +++ b/configure.ac @@ -12,6 +12,8 @@ AC_CONFIG_TESTDIR(tests) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/22477 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I5ea5365338248e29591a40ec1e19db95f8ae6877 Gerrit-Change-Number: 22477 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-mgw[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/22479 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: Ic2a1f20be65810a86cdc36aaa459819146a0bfcc --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/79/22479/1 diff --git a/configure.ac b/configure.ac index 83885d4..85b46eb 100644 --- a/configure.ac +++ b/configure.ac @@ -9,6 +9,8 @@ AM_INIT_AUTOMAKE([dist-bzip2]) AC_CONFIG_TESTDIR(tests) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/22479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic2a1f20be65810a86cdc36aaa459819146a0bfcc Gerrit-Change-Number: 22479 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-msc[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/22480 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: Ie93915f06a8907a80b4f081a00c1cde395015595 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/80/22480/1 diff --git a/configure.ac b/configure.ac index eea7f4b..ee4b33b 100644 --- a/configure.ac +++ b/configure.ac @@ -9,6 +9,8 @@ AM_INIT_AUTOMAKE([dist-bzip2]) AC_CONFIG_TESTDIR(tests) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22480 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie93915f06a8907a80b4f081a00c1cde395015595 Gerrit-Change-Number: 22480 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-pcap[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/22481 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: I52c86f461edd96d810fb85a60c68be581caa1799 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/81/22481/1 diff --git a/configure.ac b/configure.ac index 111d477..6660bf1 100644 --- a/configure.ac +++ b/configure.ac @@ -6,6 +6,8 @@ AM_INIT_AUTOMAKE([dist-bzip2]) AC_CONFIG_TESTDIR(tests) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/22481 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I52c86f461edd96d810fb85a60c68be581caa1799 Gerrit-Change-Number: 22481 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-pcu[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22482 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: Iac2c0b14252c46aec2b00d46800fcc9f87a5a586 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/82/22482/1 diff --git a/configure.ac b/configure.ac index 2e99a15..66b3595 100644 --- a/configure.ac +++ b/configure.ac @@ -10,7 +10,7 @@ AC_CONFIG_TESTDIR(tests) CXXFLAGS="$CXXFLAGS -std=gnu++03" -CFLAGS="$CFLAGS -std=gnu89" +CFLAGS="$CFLAGS -std=gnu11" dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iac2c0b14252c46aec2b00d46800fcc9f87a5a586 Gerrit-Change-Number: 22482 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-remsim[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/22483 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: I1c3682bfd50cfb43df041b6ca9a1cc7472a862dd --- M configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/83/22483/1 diff --git a/configure.ac b/configure.ac index 5833d0d..8592dd4 100644 --- a/configure.ac +++ b/configure.ac @@ -11,6 +11,7 @@ dnl tar-ustar: some asn1 filenames surpass the 99 char limit of tar, so we need dnl to make tar allow longer filenames. +CFLAGS="$CFLAGS -std=gnu11" dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/22483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I1c3682bfd50cfb43df041b6ca9a1cc7472a862dd Gerrit-Change-Number: 22483 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-sip-connector[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/22484 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: Ic95981af622dd713638bec775514dc4ef25594d4 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/84/22484/1 diff --git a/configure.ac b/configure.ac index 39d10f1..10a6392 100644 --- a/configure.ac +++ b/configure.ac @@ -18,6 +18,8 @@ RELMAKE='-include osmo-release.mk' AC_SUBST([RELMAKE]) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) AC_PROG_CC -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/22484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ic95981af622dd713638bec775514dc4ef25594d4 Gerrit-Change-Number: 22484 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-sysmon[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/22485 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: I708fe349fd506613af0e62a62bf6cbe611a06eef --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/85/22485/1 diff --git a/configure.ac b/configure.ac index 4682931..63615b8 100644 --- a/configure.ac +++ b/configure.ac @@ -8,6 +8,8 @@ AM_INIT_AUTOMAKE([dist-bzip2 foreign]) +CFLAGS="$CFLAGS -std=gnu11" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/22485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I708fe349fd506613af0e62a62bf6cbe611a06eef Gerrit-Change-Number: 22485 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-trx[master]: configure.ac: set -std=gnu11
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/22486 ) Change subject: configure.ac: set -std=gnu11 .. configure.ac: set -std=gnu11 Change-Id: Ie95876d1d2ebf31ff588999d85584f6981522fa8 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/86/22486/1 diff --git a/configure.ac b/configure.ac index 4ad344d..7f6aef7 100644 --- a/configure.ac +++ b/configure.ac @@ -34,6 +34,8 @@ AM_INIT_AUTOMAKE([foreign subdir-objects]) +CFLAGS="$CFLAGS -std=gnu11" + dnl Linux kernel KBuild style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/22486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie95876d1d2ebf31ff588999d85584f6981522fa8 Gerrit-Change-Number: 22486 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in libosmocore[master]: configure.ac: set -std=gnu11
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22355 ) Change subject: configure.ac: set -std=gnu11 .. Patch Set 5: Uploaded patches to set gnu11 everywhere, as discussed in team meeting. https://gerrit.osmocom.org/q/topic:cstd -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id79b13d3c498acb565f91eba650328fccb5a13ef Gerrit-Change-Number: 22355 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-CC: lynxis lazus Gerrit-Comment-Date: Wed, 27 Jan 2021 17:10:16 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-el2tpd[master]: configure.ac: set -std=gnu11
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-el2tpd/+/22475 ) Change subject: configure.ac: set -std=gnu11 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-el2tpd/+/22475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-el2tpd Gerrit-Branch: master Gerrit-Change-Id: I924b20265af945f5687d473b06f546ed9ac0c09b Gerrit-Change-Number: 22475 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 27 Jan 2021 18:24:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sip-connector[master]: configure.ac: set -std=gnu11
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/22484 ) Change subject: configure.ac: set -std=gnu11 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/22484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ic95981af622dd713638bec775514dc4ef25594d4 Gerrit-Change-Number: 22484 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 27 Jan 2021 18:24:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: configure.ac: set -std=gnu11
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22355 ) Change subject: configure.ac: set -std=gnu11 .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id79b13d3c498acb565f91eba650328fccb5a13ef Gerrit-Change-Number: 22355 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 18:24:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ggsn[master]: configure.ac: set -std=gnu11
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/22476 ) Change subject: configure.ac: set -std=gnu11 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/22476 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7fed7d43242f804e6d2b005277c5b2b1bd197aa8 Gerrit-Change-Number: 22476 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 27 Jan 2021 18:24:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: configure.ac: set -std=gnu11
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22470 ) Change subject: configure.ac: set -std=gnu11 .. Patch Set 1: Code-Review+2 4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I61ee711de5303691c2f8881b66d4614d11850be2 Gerrit-Change-Number: 22470 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 27 Jan 2021 18:24:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_nacc_outbound_rac_ci_resolve_conn_refused
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22488 )
Change subject: pcu: Introduce test TC_nacc_outbound_rac_ci_resolve_conn_refused
..
pcu: Introduce test TC_nacc_outbound_rac_ci_resolve_conn_refused
Change-Id: Ia0452879edb958098598e9e1c943f4e1e458a9bf
---
M pcu/PCU_Tests.ttcn
1 file changed, 57 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/88/22488/1
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 316ab65..6a78975 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -3837,6 +3837,62 @@
}
/* Verify PCU transmits Pkt Cell Change Continue if RAC+CI resolution fails
during outbound NACC procedure */
+testcase TC_nacc_outbound_rac_ci_resolve_conn_refused() runs on
RAW_PCU_Test_CT {
+ var RlcmacDlBlock dl_block;
+ var PollFnCtx pollctx;
+ var uint32_t sched_fn;
+ var GprsMS ms;
+ var template (value) RlcmacUlCtrlMsg cell_chf_notif;
+ var PCUIF_info_ind info_ind := valueof(ts_PCUIF_INFO_default);
+ var MultislotCap_GPRS mscap_gprs := {
+ gprsmultislotclass := '00011'B,
+ gprsextendeddynalloccap := '0'B
+ };
+ var MSRadioAccessCapabilityV ms_racap := { valueof(ts_RaCapRec('0001'B
/* E-GSM */, mscap_gprs, omit)) };
+ var GsmArfcn req_arfcn := 862;
+ var uint6_t req_bsic := 43;
+
+ /* In here we explicitly avoid starting osmo-bsc emulation neighbor
+* resolution CTRL port, to trigger Conn Refused by socket:
+* f_ipa_ctrl_start_server(mp_ctrl_neigh_ip, mp_ctrl_neigh_port);
+*/
+
+ /* Initialize NS/BSSGP side */
+ f_init_bssgp();
+ /* Initialize GPRS MS side */
+ f_init_gprs_ms();
+ ms := g_ms[0]; /* We only use first MS in this test */
+
+ /* Initialize the PCU interface abstraction */
+ f_init_raw(testcasename(), info_ind);
+
+ /* Make sure we are not affected by full cache from previous tests */
+ f_pcuvty_flush_neigh_caches();
+
+ /* Establish BSSGP connection to the PCU */
+ f_bssgp_establish();
+ f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli);
+
+ /* Send PACKET RESOURCE REQUEST */
+ pollctx := f_ms_establish_ul_tbf_2phase_access(ms,
ts_RlcMacUlCtrl_PKT_RES_REQ(ms.tlli, ms_racap));
+ /* Pkt Uplink Assignment above sets poll+rrbp requesting PACKET CONTROL
ACK */
+ f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), pollctx.fn, nr :=
pollctx.tstrxbts);
+
+ /* Start NACC from MS side */
+ cell_chf_notif := ts_RlcMacUlCtrl_PKT_CELL_CHG_NOTIF(ms.ul_tbf.tfi,
req_arfcn, req_bsic);
+ f_ms_tx_ul_block(ms, ts_RLC_UL_CTRL_ACK(cell_chf_notif), 0, nr :=
f_ms_tx_TsTrxBtsNum(ms));
+
+ /* Wait until we receive something non-dummy */
+ dl_block := f_skip_dummy(0);
+ /* Make sure it is a Pkt Cell Chg Continue */
+ if (not match(dl_block, tr_RLCMAC_DL_CTRL(?,
tr_RlcMacDlCtrl_PKT_CELL_CHG_CONTINUE))) {
+ setverdict(fail, "Rx unexpected DL block: ", dl_block);
+ }
+
+ f_shutdown(__BFILE__, __LINE__, final := true);
+}
+
+/* Verify PCU transmits Pkt Cell Change Continue if RAC+CI resolution fails
during outbound NACC procedure */
testcase TC_nacc_outbound_rac_ci_resolve_timeout() runs on RAW_PCU_Test_CT {
var RlcmacDlBlock dl_block;
var PollFnCtx pollctx;
@@ -4118,6 +4174,7 @@
execute( TC_pcuif_info_ind_subsequent() );
execute( TC_nacc_outbound_success() );
execute( TC_nacc_outbound_success_twice() );
+ execute( TC_nacc_outbound_rac_ci_resolve_conn_refused() );
execute( TC_nacc_outbound_rac_ci_resolve_timeout() );
execute( TC_nacc_outbound_rac_ci_resolve_fail_parse_response() );
execute( TC_nacc_outbound_si_resolve_timeout() );
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22488
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia0452879edb958098598e9e1c943f4e1e458a9bf
Gerrit-Change-Number: 22488
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_nacc_outbound_success_twice
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22487 )
Change subject: pcu: Introduce test TC_nacc_outbound_success_twice
..
pcu: Introduce test TC_nacc_outbound_success_twice
Change-Id: Ia7b1584b3f7abfa2697a1f155c8b7788a3b0722e
---
M pcu/PCU_Tests.ttcn
1 file changed, 145 insertions(+), 50 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/87/22487/1
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 9b17f6f..316ab65 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -112,6 +112,12 @@
f_PCUIF_AF2addr_type(mp_nsconfig.nsvc[0].provider.ip.address_family),
mp_nsconfig.nsvc[0].provider.ip.local_ip)
}
+/* Passed in RAN-INFO message from emulated neighbor using RIM */
+const octetstring si1_default := '198fb1792b'O;
+const octetstring si3_default := '1b753000f110236ec9033c274740793c0b2b2b'O;
+const octetstring si13_default :=
'009000185a6fc9e08410ab2b2b2b2b2b2b2b2b2b2b'O;
+const octetstring si_default := si1_default & si3_default & si13_default;
+
type record lqual_range {
/* component reference to the IPA_Client component used for RSL */
uint8_t low,
@@ -197,6 +203,24 @@
f_vty_config2(PCUVTY, {"pcu"}, cmd);
}
+private function f_pcuvty_flush_neigh_caches() runs on RAW_PCU_Test_CT {
+ f_pcuvty_set_neigh_caches(0, 0);
+}
+
+private function f_pcuvty_set_neigh_caches(integer neigh_cache_secs := -1,
integer si_cache_secs := -1)
+runs on RAW_PCU_Test_CT {
+ if (neigh_cache_secs == -1) {
+ f_vty_config2(PCUVTY, {"pcu"}, "timer X10 default");
+ } else {
+ f_vty_config2(PCUVTY, {"pcu"}, "timer X10 " &
int2str(neigh_cache_secs));
+ }
+ if (si_cache_secs == -1) {
+ f_vty_config2(PCUVTY, {"pcu"}, "timer X11 default");
+ } else {
+ f_vty_config2(PCUVTY, {"pcu"}, "timer X11 " &
int2str(si_cache_secs));
+ }
+}
+
private function f_init_vty(charstring id, boolean egprs_only) runs on
RAW_PCU_Test_CT {
map(self:PCUVTY, system:PCUVTY);
f_vty_set_prompts(PCUVTY);
@@ -3660,42 +3684,80 @@
return;
}
+/* Start NACC from MS side */
+private function f_outbound_nacc_success(inout GprsMS ms, PCUIF_info_ind
info_ind,
+boolean exp_rac_ci_query := true,
boolean exp_si_query := true)
+runs on RAW_PCU_Test_CT {
+ var template (value) RlcmacUlCtrlMsg cell_chf_notif;
+ var RlcmacDlBlock dl_block;
+ var uint32_t sched_fn;
+ var GsmArfcn req_arfcn := 862;
+ var uint6_t req_bsic := 43;
+
+ /* Start NACC from MS side */
+ cell_chf_notif := ts_RlcMacUlCtrl_PKT_CELL_CHG_NOTIF(ms.ul_tbf.tfi,
req_arfcn, req_bsic);
+ f_ms_tx_ul_block(ms, ts_RLC_UL_CTRL_ACK(cell_chf_notif), 0, nr :=
f_ms_tx_TsTrxBtsNum(ms));
+
+ if (exp_rac_ci_query == true) {
+ /* osmo-pcu should now ask for resolution: */
+ f_ipa_ctrl_wait_link_up();
+ var charstring ctrl_var :=
"neighbor_resolve_cgi_ps_from_lac_ci." &
+ int2str(info_ind.lac) & "." &
+ int2str(info_ind.cell_id) & "." &
+ int2str(req_arfcn) & "." &
+ int2str(req_bsic);
+ f_ctrl_exp_get(IPA_CTRL, ctrl_var, "023-43-423-2-5");
+ }
+
+ if (exp_si_query == true) {
+ /* RIM procedure: */
+ var BssgpCellId src :=
valueof(ts_BssgpCellId(ts_RAI(ts_LAI(f_enc_BcdMccMnc(info_ind.mcc,
info_ind.mnc, info_ind.mnc_3_digits == 1), /* '262F42'H */
+
info_ind.lac),
+
info_ind.rac),
+
info_ind.cell_id));
+ var BssgpCellId dst :=
valueof(ts_BssgpCellId(ts_RAI(ts_LAI('023F43'H, /* Decided by test itself
(emulating BSC) */
+
423),
+2),
+ 5));
+ var template RIM_Routing_Address src_addr :=
t_RIM_Routing_Address_cid(src);
+ var template RIM_Routing_Address dst_addr :=
t_RIM_Routing_Address_cid(dst);
+ var template RAN_Information_RIM_Container res_cont;
+ res_cont :=
ts_RAN_Information_RIM_Container(ts_RIM_Application_Identity(RIM_APP_ID_NACC),
+
ts_RIM_Sequence_Number(2),
+
ts_RIM_PDU_Indications(false, RIM_PDU_
Change in osmo-pcu[master]: NACC: Fix crash freeing struct if CTRL conn was refused during alloc
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22489 ) Change subject: NACC: Fix crash freeing struct if CTRL conn was refused during alloc .. NACC: Fix crash freeing struct if CTRL conn was refused during alloc Older versions of osmo_ctrl_conn_alloc() may not properly initialize write_queue.bfd.fd to -1, which means if osmo_sock_init2_ofd() failed during nacc_fsm_alloc(), the destructor would wrongly enter the conditon where the whole structure is set and unregister the unregistered fd. Related: libosmocore Change-Id I98f744d2880fbb883719cdf1d3eb31f2b22a13b6 Related: SYS#4909 Change-Id: I253bd9087b1f7ab039aa1127e9dc586f5106905a --- M src/nacc_fsm.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/89/22489/1 diff --git a/src/nacc_fsm.c b/src/nacc_fsm.c index 0a20ae6..b8350a6 100644 --- a/src/nacc_fsm.c +++ b/src/nacc_fsm.c @@ -623,6 +623,9 @@ ctx->neigh_ctrl_conn = osmo_ctrl_conn_alloc(ctx, ctx->neigh_ctrl); if (!ctx->neigh_ctrl_conn) goto free_ret; + /* Older versions of osmo_ctrl_conn_alloc didn't properly initialize fd to -1, +* so make sure to do it here otherwise fd may be valid fd 0 and cause trouble */ + ctx->neigh_ctrl_conn->write_queue.bfd.fd = -1; llist_add(&ctx->neigh_ctrl_conn->list_entry, &ctx->neigh_ctrl->ccon_list); rc = osmo_sock_init2_ofd(&ctx->neigh_ctrl_conn->write_queue.bfd, -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I253bd9087b1f7ab039aa1127e9dc586f5106905a Gerrit-Change-Number: 22489 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in osmo-pcu[master]: NACC: allow setting keep time for entries in neigh and si cache
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/22449 to look at the new patch set (#3). Change subject: NACC: allow setting keep time for entries in neigh and si cache .. NACC: allow setting keep time for entries in neigh and si cache Related: SYS#4909 Change-Id: Ifa336aa27dd88ff5b78dbc5a2799740f542bb369 --- M src/gprs_pcu.c M src/gprs_pcu.h M src/neigh_cache.c M src/neigh_cache.h M src/pcu_vty.c 5 files changed, 45 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/49/22449/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22449 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifa336aa27dd88ff5b78dbc5a2799740f542bb369 Gerrit-Change-Number: 22449 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: NACC: delay CTRL conn socket init until it's needed
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/22490 )
Change subject: NACC: delay CTRL conn socket init until it's needed
..
NACC: delay CTRL conn socket init until it's needed
This way, we don't open a socket and do the IPA handshake in the event
the request is already cached.
Related: SYS#4909
Change-Id: Ib1ea85e1196c8b9dc40c8837ab5d4a54f2a1f2d4
---
M src/nacc_fsm.c
1 file changed, 11 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/90/22490/1
diff --git a/src/nacc_fsm.c b/src/nacc_fsm.c
index b8350a6..5e8d51b 100644
--- a/src/nacc_fsm.c
+++ b/src/nacc_fsm.c
@@ -279,7 +279,7 @@
struct gprs_rlcmac_bts *bts = ctx->ms->bts;
struct gprs_pcu *pcu = bts->pcu;
const struct osmo_cell_global_id_ps *cgi_ps;
- struct ctrl_cmd *cmd;
+ struct ctrl_cmd *cmd = NULL;
int rc;
/* First try to find the value in the cache */
@@ -295,6 +295,16 @@
LOGPFSML(fi, LOGL_DEBUG, "No CGI-PS found in cache, resolving "
NEIGH_CACHE_ENTRY_KEY_FMT "...\n",
NEIGH_CACHE_ENTRY_KEY_ARGS(&ctx->neigh_key));
+ rc = osmo_sock_init2_ofd(&ctx->neigh_ctrl_conn->write_queue.bfd,
+AF_UNSPEC, SOCK_STREAM, IPPROTO_TCP,
+NULL, 0, pcu->vty.neigh_ctrl_addr,
pcu->vty.neigh_ctrl_port,
+OSMO_SOCK_F_CONNECT);
+ if (rc < 0) {
+ LOGPFSML(fi, LOGL_ERROR, "Can't connect to CTRL @ %s:%u\n",
+pcu->vty.neigh_ctrl_addr, pcu->vty.neigh_ctrl_port);
+ goto err_term;
+ }
+
cmd = ctrl_cmd_create(ctx, CTRL_TYPE_GET);
if (!cmd) {
LOGPFSML(fi, LOGL_ERROR, "CTRL msg creation failed\n");
@@ -603,11 +613,8 @@
struct nacc_fsm_ctx *nacc_fsm_alloc(struct GprsMs* ms)
{
- struct gprs_rlcmac_bts *bts = ms->bts;
- struct gprs_pcu *pcu = bts->pcu;
struct nacc_fsm_ctx *ctx = talloc_zero(ms, struct nacc_fsm_ctx);
char buf[64];
- int rc;
talloc_set_destructor(ctx, nacc_fsm_ctx_talloc_destructor);
@@ -628,16 +635,6 @@
ctx->neigh_ctrl_conn->write_queue.bfd.fd = -1;
llist_add(&ctx->neigh_ctrl_conn->list_entry,
&ctx->neigh_ctrl->ccon_list);
- rc = osmo_sock_init2_ofd(&ctx->neigh_ctrl_conn->write_queue.bfd,
-AF_UNSPEC, SOCK_STREAM, IPPROTO_TCP,
-NULL, 0, pcu->vty.neigh_ctrl_addr,
pcu->vty.neigh_ctrl_port,
-OSMO_SOCK_F_CONNECT);
- if (rc < 0) {
- LOGP(DNACC, LOGL_ERROR, "Can't connect to CTRL @ %s:%u\n",
-pcu->vty.neigh_ctrl_addr, pcu->vty.neigh_ctrl_port);
- goto free_ret;
- }
-
return ctx;
free_ret:
talloc_free(ctx);
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22490
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ib1ea85e1196c8b9dc40c8837ab5d4a54f2a1f2d4
Gerrit-Change-Number: 22490
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-sgsn[master]: manual/gbproxy: Update data model
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/22491 ) Change subject: manual/gbproxy: Update data model .. manual/gbproxy: Update data model Related: SYS#5115, SYS#5005 Change-Id: Icb9095f4002f2a0a4562fccecae109075cb93c7b --- M doc/manuals/chapters/gbproxy-overview.adoc 1 file changed, 44 insertions(+), 77 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/91/22491/1 diff --git a/doc/manuals/chapters/gbproxy-overview.adoc b/doc/manuals/chapters/gbproxy-overview.adoc index 1564157..9795dc5 100644 --- a/doc/manuals/chapters/gbproxy-overview.adoc +++ b/doc/manuals/chapters/gbproxy-overview.adoc @@ -1,6 +1,10 @@ [[chapter_overview]] == Overview +IMPORTANT: If you have used an earlier version of OsmoGbProxy please note +that support for various features such as PLMN/APN patching, support for a +secondary SGSN has been removed. + === About OsmoGbProxy OsmoGbProxy is the Osmocom proxy for the 3GPP Gb interface. The Gb @@ -15,7 +19,7 @@ OsmoGbProxy aggregates many PCU-facing Gb connections into one Gb connection to the SGSN. This is achieved by -* maintaining sepaate NS-VCs on the PCU side and on the SGSN side +* maintaining separate NS-VCs on the PCU side and on the SGSN side * more or less transparently routing BSSGP peer-to-peer Virtual Circuits (BVCs) through the proxy * having some special handling for the signaling BVC (BVCI=0) which is @@ -28,101 +32,64 @@ This contains the parsed configuration of the OsmoGbProxy. - gproxy_peer + gproxy_nse -A "peer" is any remote NS-entity that the proxy interacts with. A peer -includes information about: +The remote NS-entity that the proxy interacts with. Includes +information about: * the [unique] NSEI of the peer -* the [unique] BVCI of the peer * the Routeing Area (RA) of the peer +* which side this NSE is facing - SGSN or BSS +* the list of BVCs in this NSE - gbproxy_tlli_state + gbproxy_bvc -One of the (unique) TLLI of any of the subscribers/UEs attached to any of -the BTSs/PCUs served by the proxy. +A ptp-BVC on an NSE - gbproxy_link_info +* the BVCI of this BVC +* the routing area of this BVC +* the BVC state machine -One of the [unique] subscribers/connections that are served through this -proxy. The information includes + gbproxy_cell -* the TLLI on BSS side -* the TLLI on SGSN side (may be different due to P-TMSI rewriting) -* the NSEI of the SGSN for this link -* a timestamp when we last conversed with this subscriber -* state related to IMSI acquisition -** a temporary queue of stored messages (until IMSI acquisition succeeds) -** N(U) rewriting state (inserting IDENTTIY REQ changes LLC sequence numbers) +This contains a view of the cell and its associated BVCs - gbproxy_match +* the unique BVCI of this cell +* the routing area of this cell +* one bss-side BVC +* one BVC per SGSN in the pool -A single matching rule against which IMSIs are matched. The matching rule -is expressed as regular expression. There can be one such matching rule for -each + gbproxy_sgsn -* routing between two different SGSNs, see below -* patching of messages (e.g. APN, PLMN) +Represents one SGSN in the pool. Contains: +* the NSE belonging to this SGSN +* a (configurable) name of the SGSN +* pool-related configuration of the SGSNs -=== Advanced Features + IMSI cache - PLMN patching +In order to route messages to the correct BSS or SGSN OsmoGbProxy +sometimes needs to cache where messages came from. -This feature permits to modify the PLMN inside any BSSGP messages -containing the Routing Area ID (RAID). +In BSS->SGSN direction the IMSI-cache is needed for -The configured core-mcc and core-mnc will be used towards the SGSN, -irrespective of which MCC/MNC the PCU is using/reporting on Gb. +* paging ps reject +* dummy paging response - APN patching +when SGSN-pooling is enabled and multiple SGSNs are configured. The IMSI +contained in a paging ps or dummy paging message is cached together with +the originating SGSN/NSE. The answer, which also contains the IMSI, is +then routed back to the original SGSN. -This will transparently re-write the APN name inside SM ACTIVATE PDP -REQUEST messages on the way from the MS to the SGSN. The patching is -performed based on matching on the IMSI of the subscriber. + TLLI cache -The configured core-apn will be used towards the SGSN, irrespective -of which APN the MS is requesting in its Layer3 signaling. +In SGSN->BSS direction OsmoGbProxy needs a TLLI cache to correctly route the +following messages: -APN patching can only be performed if no GPRS encryption is enabled in -the network! +* suspend ack/nack +* resume ack/nack -APN patching is useful in case a valid APN cannot reliably be -provisioned via other means, such as via the SIM Card, OTA-DM or via -CAMEL rewriting in the SGSN. - - P-TMSI patching - -This f
Change in osmo-sgsn[master]: manuals/gbproxy: Update configuration chapter
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/22493 ) Change subject: manuals/gbproxy: Update configuration chapter .. manuals/gbproxy: Update configuration chapter Change-Id: I01f8d47f9fa384a2528ddf2e6c936ff28d11409e Related: SYS#5115, SYS#5005 --- M doc/manuals/chapters/gbproxy-configuration.adoc 1 file changed, 37 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/93/22493/1 diff --git a/doc/manuals/chapters/gbproxy-configuration.adoc b/doc/manuals/chapters/gbproxy-configuration.adoc index 057d1ca..20b21d6 100644 --- a/doc/manuals/chapters/gbproxy-configuration.adoc +++ b/doc/manuals/chapters/gbproxy-configuration.adoc @@ -1,10 +1,43 @@ == Configuring OsmoGbProxy -TBD. Unfortunately this chapter of the manual still needs to be written. -Osmocom has very limited funding and support resources; Feel free to help -us completing this documentation by contributing with code, documentation -or by supporting the developers financially. +OsmoGbProxy requires very little configuration, most is the configuration of +the NS links. +Most config options specific to OsmoGbProxy are related to SGSN pooling and +telling the proxy which NSE(s) it should use to talk to the SGSN(s). +=== Configure the Network Service (NS) + +A detailed description of the NS configuration can be found in <>. +The following config snippets assume the SGSN(s) (NSEI 101 and 102) are using +IP-SNS and listen on 10.0.1.1:23000 and 10.0.1.2:23000 respectively. + +This would be the NS config for the SGSN(s): + +.Example: NS configuration example (SGSN) + +ns + bind udp local + listen 127.0.0.1 23000 <1> + nse 101 <2> + ip-sns 127.0.0.2 23001 <3> + nse 102 + ip-sns 127.0.0.2 23002 + +<1> Define the local IP/port from which to connect +<2> Define an NSE with NSEI +<3> Use IP-SNS to connect to the SGSN + +=== Configure an SGSN + +Configuration of a single (non-pooling) SGSN is rather simple. + +.Example: SGSN configuration example + +sgsn 101 <1> + name Main SGSN <2> + +<1> Each SGSN is identified by its NSEI (same as in the NS configuration) +<2> An SGSN can optionally have a name. If none is set a default name will be used. === SGSN pool support -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/22493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I01f8d47f9fa384a2528ddf2e6c936ff28d11409e Gerrit-Change-Number: 22493 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange
Change in osmo-sgsn[master]: Rename OsmoGbPROXY -> *Proxy
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/22492 ) Change subject: Rename OsmoGbPROXY -> *Proxy .. Rename OsmoGbPROXY -> *Proxy Change-Id: I7542ac1d5242f1784146de2df7cecaf70fe93c6c Related: SYS#5115, SYS#5005 --- M doc/manuals/chapters/gbproxy-configuration.adoc M doc/manuals/chapters/gbproxy-control.adoc M doc/manuals/chapters/gbproxy-running.adoc M doc/manuals/osmogbproxy-usermanual.adoc 4 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/92/22492/1 diff --git a/doc/manuals/chapters/gbproxy-configuration.adoc b/doc/manuals/chapters/gbproxy-configuration.adoc index e61af48..057d1ca 100644 --- a/doc/manuals/chapters/gbproxy-configuration.adoc +++ b/doc/manuals/chapters/gbproxy-configuration.adoc @@ -1,4 +1,4 @@ -== Configuring OsmoGbPROXY +== Configuring OsmoGbProxy TBD. Unfortunately this chapter of the manual still needs to be written. Osmocom has very limited funding and support resources; Feel free to help diff --git a/doc/manuals/chapters/gbproxy-control.adoc b/doc/manuals/chapters/gbproxy-control.adoc index afe23ad..2f83e6a 100644 --- a/doc/manuals/chapters/gbproxy-control.adoc +++ b/doc/manuals/chapters/gbproxy-control.adoc @@ -3,7 +3,7 @@ The actual protocol is described in <>, the variables common to all programs using it are described in <>. Here we -describe variables specific to OsmoGbPROXY. +describe variables specific to OsmoGbProxy. .Variables available over control interface [options="header",width="100%",cols="20%,5%,5%,50%,20%"] diff --git a/doc/manuals/chapters/gbproxy-running.adoc b/doc/manuals/chapters/gbproxy-running.adoc index 9182b48..1f6b6a1 100644 --- a/doc/manuals/chapters/gbproxy-running.adoc +++ b/doc/manuals/chapters/gbproxy-running.adoc @@ -1,6 +1,6 @@ -== Running OsmoGbPROXY +== Running OsmoGbProxy -The OsmoGbPROXY executable (`osmo-gbproxy`) offers the following command-line +The OsmoGbProxy executable (`osmo-gbproxy`) offers the following command-line options: diff --git a/doc/manuals/osmogbproxy-usermanual.adoc b/doc/manuals/osmogbproxy-usermanual.adoc index c93ebec..d19bdd4 100644 --- a/doc/manuals/osmogbproxy-usermanual.adoc +++ b/doc/manuals/osmogbproxy-usermanual.adoc @@ -1,6 +1,6 @@ :gfdl-enabled: -OsmoGbPROXY User Manual +OsmoGbProxy User Manual === Harald Welte -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/22492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I7542ac1d5242f1784146de2df7cecaf70fe93c6c Gerrit-Change-Number: 22492 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange
Change in osmo-sgsn[master]: manuals/gbproxy: Add osmo-bsc MSC pooling chapter from Neels as a base
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/22494 ) Change subject: manuals/gbproxy: Add osmo-bsc MSC pooling chapter from Neels as a base .. manuals/gbproxy: Add osmo-bsc MSC pooling chapter from Neels as a base Related: SYS#5115, SYS#5005 Change-Id: I930f5df847ea6f40d0ee0c75dd25b6dd20e00839 --- A doc/manuals/chapters/gbproxy-sgsnpool.adoc 1 file changed, 213 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/94/22494/1 diff --git a/doc/manuals/chapters/gbproxy-sgsnpool.adoc b/doc/manuals/chapters/gbproxy-sgsnpool.adoc new file mode 100644 index 000..923a088 --- /dev/null +++ b/doc/manuals/chapters/gbproxy-sgsnpool.adoc @@ -0,0 +1,213 @@ +== MSC Pooling + +MSC pooling is described in 3GPP TS 23.236 <<3gpp-ts-23-236>>, and is supported +by OsmoBSC since mid 2020. + +The aim of MSC pooling is to distribute load from a BSC across multiple MSCs, +which are equivalent and redundant infrastructure for the same core network. + +The main mechanism for MSC pooling is the TMSI identity, which an MSC hands out +to its attached subscribers. Typically 10 bits of the TMSI are designated as a +Network Resource Identifier (NRI) that identifies the originating MSC, and +allows OsmoBSC to direct a subscriber back to the same MSC instance that +previously negotiated the IMSI Attach procedure. Typically, the full NRI value +range available is divided into N even ranges, where each MSC is assigned one +NRI range. + +Subscribers attaching without a TMSI identity, or those with unknown NRI value, +are evenly distributed across MSC instances. OsmoBSC uses a round-robin +approach to distribute load across all connected MSCs. + +A Paging Response from a subscriber is always returned back to whichever MSC +initiated the Paging, regardless of the Mobile Identity used. + +Finally, a NULL-NRI is a special NRI value that indicates that the MSC wishes +to offload this subscriber to a different MSC. A NULL-NRI is an arbitrary NRI +value that is chosen distinctly for each PLMN served by a BSC, so that a +subscriber can be reassigned within that PLMN. Upon (periodic) Location +Updating, an offloading MSC hands out a NULL-NRI value in the assigned TMSI, +along with a non-broadcast LAI. The subscriber will notice the LAI mismatch, +and immediately re-attempt the attach using the TMSI containing the NULL-NRI. +The BSC recognises the NULL-NRI and redirects the subscriber to one of the +other MSCs. A prerequisite for this to work well is that the particular MSC is +previously marked as not accepting new subscribers, in the BSC's configuration. + +The mechanisms described above make up the NAS node selection function +implemented in the BSC. + +3GPP TS 23.236 also defines that an offloading MSC hands subscriber information +to the newly assigned MSC, which takes place outside the scope of the BSC. + +=== Configuring MSC Pooling + +The NRI ranges assigned to each MSC must match in the BSC and the MSC +configuration. If MSC and BSC had inconsistent NRI value ranges configured, +attached subscribers would be redirected MSC instances that did not perform the +attach, possibly rendering the core network unusable. + + Connecting Multiple MSCs + +The `cs7 instance` configuration defines the SCCP addresses to reach the MSCs +at. In addition, each MSC is configured by its own `msc` section in the +configuration. An example osmo-bsc.cfg serving three MSCs: + + +cs7 instance 0 + # SCCP address book entries for the three MSCs + sccp-address my-msc-0 + point-code 0.23.0 + sccp-address my-msc-1 + point-code 0.23.1 + sccp-address my-msc-2 + point-code 0.23.2 + +# assign each MSC configuration its remote SCCP address +msc 0 + msc-addr my-msc-0 +msc 1 + msc-addr my-msc-1 +msc 2 + msc-addr my-msc-2 + +# configure NRI value ranges +network + nri bitlen 10 + nri null add 0 +msc 0 + nri add 1 341 +msc 1 + nri add 342 682 +msc 2 + nri add 683 1023 + + + NRI Value Bit Length + +In OsmoBSC, the NRI value's bit length is freely configurable from 1 to 15 +bits. 3GPP TS 23.236 suggests a typical bit length of 10, which is OsmoBSC's +default. The NRI bit length must be identical across the entire MSC pool. + +Change the NRI value bit length in OsmoBSC's VTY configuration like this: + + +network + nri bitlen 10 + + +In the TMSI bits, regardless of the NRI bit length, the NRI value always starts +just after the most significant octet of a TMSI (most significant bit at TMSI's +bit 23). + + NULL-NRI + +Since OsmoBSC supports serving only one PLMN, NULL-NRI are configured globally. +Even though 3GPP TS 23.236 indicates that there is a single NULL-NRI per PLMN, +OsmoBSC allows configuring multiple NULL-NRI values. + + +network + nri null add 0 + nri null add 423 + + + Assigning NRI Ranges to MSCs + +Each MSC configured in OsmoBSC must be assigned a distinct NRI value ra
Change in osmo-sgsn[master]: manuals/gbproxy: MSC -> SGSN for pooling chapter
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/22495 ) Change subject: manuals/gbproxy: MSC -> SGSN for pooling chapter .. manuals/gbproxy: MSC -> SGSN for pooling chapter Mostly just change the chapter so it makes sense for gbproxy. Some todos are still left Change-Id: I905835c2be7be43fe376fbc9d743107948c7e6d4 Related: SYS#5115, SYS#5005 --- M doc/manuals/chapters/gbproxy-sgsnpool.adoc 1 file changed, 85 insertions(+), 104 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/95/22495/1 diff --git a/doc/manuals/chapters/gbproxy-sgsnpool.adoc b/doc/manuals/chapters/gbproxy-sgsnpool.adoc index 923a088..c600bcf 100644 --- a/doc/manuals/chapters/gbproxy-sgsnpool.adoc +++ b/doc/manuals/chapters/gbproxy-sgsnpool.adoc @@ -1,96 +1,87 @@ -== MSC Pooling +== SGSN Pooling -MSC pooling is described in 3GPP TS 23.236 <<3gpp-ts-23-236>>, and is supported -by OsmoBSC since mid 2020. +SGSN pooling is described in 3GPP TS 23.236 <<3gpp-ts-23-236>>, and is supported +by OsmoGbProxy since early 2021. -The aim of MSC pooling is to distribute load from a BSC across multiple MSCs, +The aim of SGSN pooling is to distribute load from a BSS across multiple SGSNs, which are equivalent and redundant infrastructure for the same core network. -The main mechanism for MSC pooling is the TMSI identity, which an MSC hands out -to its attached subscribers. Typically 10 bits of the TMSI are designated as a -Network Resource Identifier (NRI) that identifies the originating MSC, and -allows OsmoBSC to direct a subscriber back to the same MSC instance that -previously negotiated the IMSI Attach procedure. Typically, the full NRI value -range available is divided into N even ranges, where each MSC is assigned one +The main mechanism for SGSN pooling is the TLLI/P-TMSI, which an SGSN hands out +to its attached subscribers. Typically 10 bits of the P-TMSI are designated as a +Network Resource Identifier (NRI) that identifies the originating SGSN, and +allows OsmoGbProxy to direct a subscriber back to the same SGSN instance that +previously negotiated the Attach procedure. Typically, the full NRI value +range available is divided into N even ranges, where each SGSN is assigned one NRI range. -Subscribers attaching without a TMSI identity, or those with unknown NRI value, -are evenly distributed across MSC instances. OsmoBSC uses a round-robin -approach to distribute load across all connected MSCs. +Subscribers attaching without a TLLI, or those with unknown NRI value, +are evenly distributed across SGSN instances. OsmoGbProxy uses a hash-based +approach to distribute load across all connected SGSNs. -A Paging Response from a subscriber is always returned back to whichever MSC +A Paging Response from a subscriber is always returned back to whichever SGSN initiated the Paging, regardless of the Mobile Identity used. -Finally, a NULL-NRI is a special NRI value that indicates that the MSC wishes -to offload this subscriber to a different MSC. A NULL-NRI is an arbitrary NRI -value that is chosen distinctly for each PLMN served by a BSC, so that a +Finally, a NULL-NRI is a special NRI value that indicates that the SGSN wishes +to offload this subscriber to a different SGSN. A NULL-NRI is an arbitrary NRI +value that is chosen distinctly for each PLMN served by a BSS, so that a subscriber can be reassigned within that PLMN. Upon (periodic) Location -Updating, an offloading MSC hands out a NULL-NRI value in the assigned TMSI, +Updating, an offloading SGSN hands out a NULL-NRI value in the assigned TLLI, along with a non-broadcast LAI. The subscriber will notice the LAI mismatch, -and immediately re-attempt the attach using the TMSI containing the NULL-NRI. -The BSC recognises the NULL-NRI and redirects the subscriber to one of the -other MSCs. A prerequisite for this to work well is that the particular MSC is -previously marked as not accepting new subscribers, in the BSC's configuration. +and immediately re-attempt the attach using the TLLI containing the NULL-NRI. +OsmoGbProxy recognises the NULL-NRI and redirects the subscriber to one of the +other SGSNs. A prerequisite for this to work well is that the particular SGSN is +previously marked as not accepting new subscribers, in OsmoGbProxy's configuration. The mechanisms described above make up the NAS node selection function -implemented in the BSC. +implemented in OsmoGbProxy. -3GPP TS 23.236 also defines that an offloading MSC hands subscriber information -to the newly assigned MSC, which takes place outside the scope of the BSC. +3GPP TS 23.236 also defines that an offloading SGSN hands subscriber information +to the newly assigned SGSN, which takes place outside the scope of OsmoGbProxy. -=== Configuring MSC Pooling +=== Configuring SGSN Pooling -The NRI ranges assigned to each MSC must match in the BSC and the MSC -configuration. If MS
Change in osmo-sgsn[master]: manuals/gbproxy: Move pooling to separate chapter
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/22496 ) Change subject: manuals/gbproxy: Move pooling to separate chapter .. manuals/gbproxy: Move pooling to separate chapter Change-Id: Ie2ad652c8261ce56cb2ed1a6f16a81486ccdf063 Related: SYS#5115, SYS#5005 --- M doc/manuals/chapters/gbproxy-configuration.adoc M doc/manuals/chapters/gbproxy-sgsnpool.adoc 2 files changed, 25 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/96/22496/1 diff --git a/doc/manuals/chapters/gbproxy-configuration.adoc b/doc/manuals/chapters/gbproxy-configuration.adoc index 20b21d6..cde3f44 100644 --- a/doc/manuals/chapters/gbproxy-configuration.adoc +++ b/doc/manuals/chapters/gbproxy-configuration.adoc @@ -39,27 +39,3 @@ <1> Each SGSN is identified by its NSEI (same as in the NS configuration) <2> An SGSN can optionally have a name. If none is set a default name will be used. -=== SGSN pool support - -In a SGSN pool, osmo-gbproxy is facing the problem of dividing the downlink -capacity of a cell towards the SGSN. The BSS advertises the per-BVC capacity -by means of the BSSGP FLOW-CONTROL-BVC messages, but as there are multiple -SGSN in a pool, they all have to share / divide that total capacity. - -By default, osmo-gbproxy advertises the full capacity to _each_ of the SGSN -pool members, which results in significant over-provisioning and can lead to -overload situations. - -The administrator can configure the _percentage_ of the overall BSS-advertised -capacity that shall be reported to each pool member SGSN using the -`pool bvc-flow-control-ratio <1-100>` configuration command. - -A setting of 100 means that each pool member is informed of 100% of the -BSS side capacity. - -A setting of 25 means that each pool member is informed of 25% of the -BSS side capacity. This would make most sense in a set-up with four -SGSN of equal share. - -More complex capacity division schemes are so far not supported by -osmo-gbproxy. diff --git a/doc/manuals/chapters/gbproxy-sgsnpool.adoc b/doc/manuals/chapters/gbproxy-sgsnpool.adoc index c600bcf..61806af 100644 --- a/doc/manuals/chapters/gbproxy-sgsnpool.adoc +++ b/doc/manuals/chapters/gbproxy-sgsnpool.adoc @@ -192,3 +192,28 @@ sgsn nsei 1 allow-attach + + Traffic allocation + +In a SGSN pool, osmo-gbproxy is facing the problem of dividing the downlink +capacity of a cell towards the SGSN. The BSS advertises the per-BVC capacity +by means of the BSSGP FLOW-CONTROL-BVC messages, but as there are multiple +SGSN in a pool, they all have to share / divide that total capacity. + +By default, osmo-gbproxy advertises the full capacity to _each_ of the SGSN +pool members, which results in significant over-provisioning and can lead to +overload situations. + +The administrator can configure the _percentage_ of the overall BSS-advertised +capacity that shall be reported to each pool member SGSN using the +`pool bvc-flow-control-ratio <1-100>` configuration command. + +A setting of 100 means that each pool member is informed of 100% of the +BSS side capacity. + +A setting of 25 means that each pool member is informed of 25% of the +BSS side capacity. This would make most sense in a set-up with four +SGSN of equal share. + +More complex capacity division schemes are so far not supported by +osmo-gbproxy. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/22496 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie2ad652c8261ce56cb2ed1a6f16a81486ccdf063 Gerrit-Change-Number: 22496 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange
Change in osmo-pcu[master]: Introduce NACC support
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22385 ) Change subject: Introduce NACC support .. Patch Set 11: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id35f40d05f3e081f32fddbf1fa34cb338db452ca Gerrit-Change-Number: 22385 Gerrit-PatchSet: 11 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 27 Jan 2021 18:35:10 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in gapk[master]: configure.ac: set -std=gnu11
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/22463 ) Change subject: configure.ac: set -std=gnu11 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/22463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I7d4c4e1f3663e448c5d044ccb4bbd3e813898f23 Gerrit-Change-Number: 22463 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Wed, 27 Jan 2021 18:38:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libgtpnl[master]: configure.ac: set -std=gnu11
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/22464 ) Change subject: configure.ac: set -std=gnu11 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/22464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Iea60698b4cb0f9c04a6f75cc4ca2ea5fbb84bae8 Gerrit-Change-Number: 22464 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Wed, 27 Jan 2021 18:38:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libtelnet[master]: configure.ac: set -std=gnu11
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libtelnet/+/22468 ) Change subject: configure.ac: set -std=gnu11 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libtelnet/+/22468 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libtelnet Gerrit-Branch: master Gerrit-Change-Id: Ief41cc4fc2e3d763a4b84f427496a5611f3c90c5 Gerrit-Change-Number: 22468 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Wed, 27 Jan 2021 18:38:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-netif[master]: configure.ac: set -std=gnu11
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/22466 ) Change subject: configure.ac: set -std=gnu11 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/22466 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia646e72ce58de331c325b75e94fa1539acd5930b Gerrit-Change-Number: 22466 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Wed, 27 Jan 2021 18:38:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libgtpnl[master]: configure.ac: set -std=gnu11
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/22464 ) Change subject: configure.ac: set -std=gnu11 .. Patch Set 1: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/22464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Iea60698b4cb0f9c04a6f75cc4ca2ea5fbb84bae8 Gerrit-Change-Number: 22464 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Wed, 27 Jan 2021 18:38:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
