date:20220810

Build failure of network:osmocom:nightly/open5gs in Raspbian_10/armv7l

2022-08-10 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Raspbian_10/armv7l

Package network:osmocom:nightly/open5gs failed to build in Raspbian_10/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly open5gs

Last lines of build log:
[  563s] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib -I../lib 
-Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app -I../lib/app 
-Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION  -MD -MQ 'lib/sbi/9848b6c@@ogssbi@sha/client.c.o' -MF 
'lib/sbi/9848b6c@@ogssbi@sha/client.c.o.d' -o 
'lib/sbi/9848b6c@@ogssbi@sha/client.c.o' -c ../lib/sbi/client.c
[  563s] In file included from 
/usr/include/arm-linux-gnueabihf/curl/curl.h:2826,
[  563s]  from ../lib/sbi/client.c:23:
[  563s] ../lib/sbi/client.c: In function ‘ogs_sbi_client_add’:
[  563s] ../lib/sbi/client.c:121:30: error: ‘CURLMOPT_MAX_CONCURRENT_STREAMS’ 
undeclared (first use in this function); did you mean ‘CURLMOPT_MAXCONNECTS’?
[  563s]  curl_multi_setopt(multi, CURLMOPT_MAX_CONCURRENT_STREAMS,
[  563s]   ^~~
[  563s] ../lib/sbi/client.c:121:30: note: each undeclared identifier is 
reported only once for each function it appears in
[  563s] [2808/3254] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi 
-Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION  -MD -MQ 'lib/sbi/9848b6c@@ogssbi@sha/nnrf-build.c.o' -MF 
'lib/sbi/9848b6c@@ogssbi@sha/nnrf-build.c.o.d' -o 
'lib/sbi/9848b6c@@ogssbi@sha/nnrf-build.c.o' -c ../lib/sbi/nnrf-build.c
[  563s] [2809/3254] cc -Isrc/sgwc/e537280@@sgwc@sta -Isrc/sgwc -I../src/sgwc 
-Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/gtp 
-I../lib/gtp -Ilib/nas/common -I../lib/nas/common -Ilib/crypt -I../lib/crypt 
-Ilib/pfcp -I../lib/pfcp -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat

Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.04/x86_64

2022-08-10 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly open5gs

Last lines of build log:
[  585s] [2802/3254] cc  -Ilib/sbi/ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib 
-I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/x86_64-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION -MD -MQ 'lib/sbi/ogssbi@sha/client.c.o' -MF 
'lib/sbi/ogssbi@sha/client.c.o.d' -o 'lib/sbi/ogssbi@sha/client.c.o' -c 
../lib/sbi/client.c
[  585s] FAILED: lib/sbi/ogssbi@sha/client.c.o 
[  585s] cc  -Ilib/sbi/ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib -I../lib 
-Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app -I../lib/app 
-Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/x86_64-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION -MD -MQ 'lib/sbi/ogssbi@sha/client.c.o' -MF 
'lib/sbi/ogssbi@sha/client.c.o.d' -o 'lib/sbi/ogssbi@sha/client.c.o' -c 
../lib/sbi/client.c
[  585s] In file included from /usr/include/x86_64-linux-gnu/curl/curl.h:2738:0,
[  585s]  from ../lib/sbi/client.c:23:
[  585s] ../lib/sbi/client.c: In function ‘ogs_sbi_client_add’:
[  585s] ../lib/sbi/client.c:121:30: error: ‘CURLMOPT_MAX_CONCURRENT_STREAMS’ 
undeclared (first use in this function); did you mean ‘CURLMOPT_MAXCONNECTS’?
[  585s]  curl_multi_setopt(multi, CURLMOPT_MAX_CONCURRENT_STREAMS,
[  585s]   ^
[  585s] ../lib/sbi/client.c:121:30: note: each undeclared identifier is 
reported only once for each function it appears in
[  585s] [2803/3254] cc  -Isrc/hss/hss@sta -Isrc/hss -I../src/hss -Ilib/app 
-I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt 
-Ilib/dbi -I../lib/dbi -Ilib/diameter/s6a -I../lib/diameter/s6a 
-Ilib/diameter/common -I../lib/diameter/common -Isubprojects/freeDiameter 
-I../subprojects/freeDiameter -Isubprojects/freeDiameter/include 
-I../subprojects/freeDiameter/include -Ilib/diameter/cx -I../lib/diameter/cx 
-Ilib/diameter/swx -I../lib/diameter/swx -I/usr/include/libmongoc-1.0 
-I/usr/include/libbson-1.0 -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math

Build failure of network:osmocom:nightly/open5gs in Debian_10/aarch64

2022-08-10 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/aarch64

Package network:osmocom:nightly/open5gs failed to build in Debian_10/aarch64

Check out the package for editing:
  osc checkout network:osmocom:nightly open5gs

Last lines of build log:
[  375s] [2776/3254] cc -Isrc/mme/e6d01c5@@mme@sta -Isrc/mme -I../src/mme 
-Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/metrics 
-I../lib/metrics -Ilib/sctp -I../lib/sctp -Ilib/s1ap -I../lib/s1ap 
-Ilib/asn1c/s1ap -I../lib/asn1c/s1ap -Ilib/asn1c/common -I../lib/asn1c/common 
-Ilib/asn1c/util -I../lib/asn1c/util -Ilib/nas/eps -I../lib/nas/eps 
-Ilib/nas/common -I../lib/nas/common -Ilib/crypt -I../lib/crypt 
-Ilib/diameter/s6a -I../lib/diameter/s6a -Ilib/diameter/common 
-I../lib/diameter/common -Isubprojects/freeDiameter/include 
-I../subprojects/freeDiameter/include -Isubprojects/freeDiameter 
-I../subprojects/freeDiameter -Ilib/gtp -I../lib/gtp -fdiagnostics-color=always 
-pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread  -MD -MQ 
'src/mme/e6d01c5@@mme@sta/mme-event.c.o' -MF 
'src/mme/e6d01c5@@mme@sta/mme-event.c.o.d' -o 
'src/mme/e6d01c5@@mme@sta/mme-event.c.o' -c ../src/mme/mme-event.c
[  375s] [2777/3254] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi 
-Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/aarch64-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION  -MD -MQ 'lib/sbi/9848b6c@@ogssbi@sha/conv.c.o' -MF 
'lib/sbi/9848b6c@@ogssbi@sha/conv.c.o.d' -o 
'lib/sbi/9848b6c@@ogssbi@sha/conv.c.o' -c ../lib/sbi/conv.c
[  375s] [2778/3254] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi 
-Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/aarch64-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION  -MD -MQ 
'lib/sbi/9848b6c@@ogssbi@sha/custom_ue_authentication_ctx.c.o' -MF 
'lib/sbi/9848b6c@@ogssbi@sha/custom_ue_authentication_ctx.c.o.d' -o

Build failure of network:osmocom:nightly/open5gs in Debian_10/x86_64

2022-08-10 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/x86_64

Package network:osmocom:nightly/open5gs failed to build in Debian_10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly open5gs

Last lines of build log:
[  162s] [2777/3254] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi 
-Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/x86_64-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION  -MD -MQ 'lib/sbi/9848b6c@@ogssbi@sha/mhd-server.c.o' -MF 
'lib/sbi/9848b6c@@ogssbi@sha/mhd-server.c.o.d' -o 
'lib/sbi/9848b6c@@ogssbi@sha/mhd-server.c.o' -c ../lib/sbi/mhd-server.c
[  162s] [2778/3254] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi 
-Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/x86_64-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION  -MD -MQ 'lib/sbi/9848b6c@@ogssbi@sha/conv.c.o' -MF 
'lib/sbi/9848b6c@@ogssbi@sha/conv.c.o.d' -o 
'lib/sbi/9848b6c@@ogssbi@sha/conv.c.o' -c ../lib/sbi/conv.c
[  162s] [2779/3254] cc -Isrc/mme/e6d01c5@@mme@sta -Isrc/mme -I../src/mme 
-Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/metrics 
-I../lib/metrics -Ilib/sctp -I../lib/sctp -Ilib/s1ap -I../lib/s1ap 
-Ilib/asn1c/s1ap -I../lib/asn1c/s1ap -Ilib/asn1c/common -I../lib/asn1c/common 
-Ilib/asn1c/util -I../lib/asn1c/util -Ilib/nas/eps -I../lib/nas/eps 
-Ilib/nas/common -I../lib/nas/common -Ilib/crypt -I../lib/crypt 
-Ilib/diameter/s6a -I../lib/diameter/s6a -Ilib/diameter/common 
-I../lib/diameter/common -Isubprojects/freeDiameter/include 
-I../subprojects/freeDiameter/include -Isubprojects/freeDiameter 
-I../subprojects/freeDiameter -Ilib/gtp -I../lib/gtp -fdiagnostics-color=always 
-pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread  -MD -MQ 
'src/mme/e6d01c5@@mme@sta/mme-init.c.o' -MF 
'src/mme/e6d01c5@@mme@sta/mme-init.c.o.d' -o 
'src/mme/e6d01c5@@mme@sta/mme-init.c.o'

Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.04/i586

2022-08-10 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.04/i586

Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly open5gs

Last lines of build log:
[  204s] cc  -Ilib/sbi/ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib -I../lib 
-Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app -I../lib/app 
-Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION -MD -MQ 'lib/sbi/ogssbi@sha/client.c.o' -MF 
'lib/sbi/ogssbi@sha/client.c.o.d' -o 'lib/sbi/ogssbi@sha/client.c.o' -c 
../lib/sbi/client.c
[  204s] In file included from /usr/include/i386-linux-gnu/curl/curl.h:2738:0,
[  204s]  from ../lib/sbi/client.c:23:
[  204s] ../lib/sbi/client.c: In function ‘ogs_sbi_client_add’:
[  204s] ../lib/sbi/client.c:121:30: error: ‘CURLMOPT_MAX_CONCURRENT_STREAMS’ 
undeclared (first use in this function); did you mean ‘CURLMOPT_MAXCONNECTS’?
[  204s]  curl_multi_setopt(multi, CURLMOPT_MAX_CONCURRENT_STREAMS,
[  204s]   ^
[  204s] ../lib/sbi/client.c:121:30: note: each undeclared identifier is 
reported only once for each function it appears in
[  204s] [2781/3254] cc  -Ilib/sbi/ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib 
-I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION -MD -MQ 'lib/sbi/ogssbi@sha/nnrf-handler.c.o' -MF 
'lib/sbi/ogssbi@sha/nnrf-handler.c.o.d' -o 
'lib/sbi/ogssbi@sha/nnrf-handler.c.o' -c ../lib/sbi/nnrf-handler.c
[  204s] [2782/3254] cc  -Ilib/sbi/ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib 
-I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION -MD -MQ

Build failure of network:osmocom:nightly/open5gs in Debian_10/i586

2022-08-10 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/i586

Package network:osmocom:nightly/open5gs failed to build in Debian_10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly open5gs

Last lines of build log:
[  165s]  (long long)triggeringMessage);
[  165s]  ^
[  165s] ../lib/core/ogs-log.h:45:8: note: in definition of macro 
‘ogs_log_message’
[  165s]  0, __VA_ARGS__)
[  165s] ^~~
[  165s] ../src/mme/s1ap-handler.c:1265:13: note: in expansion of macro 
‘ogs_debug’
[  165s]  ogs_debug("triggeringMessage: %lld",
[  165s]  ^
[  165s] ../src/mme/s1ap-handler.c:1270:21: warning: cast from pointer to 
integer of different size [-Wpointer-to-int-cast]
[  165s]  (long long)procedureCriticality);
[  165s]  ^
[  165s] ../lib/core/ogs-log.h:45:8: note: in definition of macro 
‘ogs_log_message’
[  165s]  0, __VA_ARGS__)
[  165s] ^~~
[  165s] ../src/mme/s1ap-handler.c:1269:13: note: in expansion of macro 
‘ogs_debug’
[  165s]  ogs_debug("procedureCriticality: %lld",
[  165s]  ^
[  165s] [2784/3254] cc -Isrc/mme/e6d01c5@@mme@sta -Isrc/mme -I../src/mme 
-Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/metrics 
-I../lib/metrics -Ilib/sctp -I../lib/sctp -Ilib/s1ap -I../lib/s1ap 
-Ilib/asn1c/s1ap -I../lib/asn1c/s1ap -Ilib/asn1c/common -I../lib/asn1c/common 
-Ilib/asn1c/util -I../lib/asn1c/util -Ilib/nas/eps -I../lib/nas/eps 
-Ilib/nas/common -I../lib/nas/common -Ilib/crypt -I../lib/crypt 
-Ilib/diameter/s6a -I../lib/diameter/s6a -Ilib/diameter/common 
-I../lib/diameter/common -Isubprojects/freeDiameter/include 
-I../subprojects/freeDiameter/include -Isubprojects/freeDiameter 
-I../subprojects/freeDiameter -Ilib/gtp -I../lib/gtp -fdiagnostics-color=always 
-pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread  -MD -MQ 
'src/mme/e6d01c5@@mme@sta/mme-context.c.o' -MF 
'src/mme/e6d01c5@@mme@sta/mme-context.c.o.d' -o 
'src/mme/e6d01c5@@mme@sta/mme-context.c.o' -c ../src/mme/mme-context.c
[  165s] ninja: build stopped: subcommand failed.
[  165s] dh_auto_build: cd obj-i686-linux-gnu && LC_ALL=C.UTF-8 ninja -j6 -v 
returned exit code 1
[  165s] make: *** [debian/rules:11: binary] Error 1
[  165s] dpkg-buildpackage: error: debian/rules binary subprocess returned exit 
status 2
[  165s] ### VM INTERACTION START ###
[  166s] [  155.899202][T1] sysrq: Power Off
[  166s] [  155.900907][  T139] reboot: Power down
[  166s] ### VM INTERACTION END ###
[  166s] 
[  166s] sheep83 failed "build open5gs_2.4.9.14.ec9fe.202208110052.dsc" at Thu 
Aug 11 01:07:41 UTC 2022.
[  166s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-ttcn3-hacks[master]: bsc: Rename s/use_osmux/use_osmux_cn/

2022-08-10 Thread pespin

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29008 )

Change subject: bsc: Rename s/use_osmux/use_osmux_cn/
..

bsc: Rename s/use_osmux/use_osmux_cn/

That config is used to control the use of osmux between BSC<->MSC. Since
we'll add support for Osmux in BTS<->BSC, we want to test that in a
separate way. Let's rename it so that we can add a "use_osmux_bts" later
on.

Change-Id: I3bde4e6772c18043dd763d7747b5dbe40e0da3b8
---
M bsc/BSC_Tests.ttcn
M bsc/BSC_Tests_VAMOS.ttcn
M bsc/MSC_ConnectionHandler.ttcn
3 files changed, 28 insertions(+), 28 deletions(-)

Approvals:
  daniel: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index f3e15ef..d8a660c 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -632,7 +632,7 @@
var boolean g_initialized := false;

/* Osmux is enabled through VTY */
-   var boolean g_osmux_enabled := false;
+   var boolean g_osmux_enabled_cn := false;

/*Configure T(tias) over VTY, seconds */
var integer g_bsc_sccp_timer_ias :=  7 * 60;
@@ -893,17 +893,17 @@
var boolean reset_received := false;
timer T := 5.0;
BSSAP.send(ts_BSSAP_UNITDATA_req(g_bssap[bssap_idx].sccp_addr_peer, 
g_bssap[bssap_idx].sccp_addr_own,
-ts_BSSMAP_Reset(0, g_osmux_enabled)));
+ts_BSSMAP_Reset(0, 
g_osmux_enabled_cn)));
T.start;
alt {
[] 
BSSAP.receive(tr_BSSAP_UNITDATA_ind(g_bssap[bssap_idx].sccp_addr_own, 
g_bssap[bssap_idx].sccp_addr_peer,
-  
tr_BSSMAP_ResetAck(g_osmux_enabled))) {
+  
tr_BSSMAP_ResetAck(g_osmux_enabled_cn))) {
log("BSSMAP: Received RESET-ACK in response to RESET, we're 
ready to go!");
}
-   [] BSSAP.receive(tr_BSSAP_UNITDATA_ind(?, ?, 
tr_BSSMAP_Reset(g_osmux_enabled))) -> value ud_ind {
+   [] BSSAP.receive(tr_BSSAP_UNITDATA_ind(?, ?, 
tr_BSSMAP_Reset(g_osmux_enabled_cn))) -> value ud_ind {
log("BSSMAP: Respoding to inbound RESET with RESET-ACK");
BSSAP.send(ts_BSSAP_UNITDATA_req(ud_ind.callingAddress, 
ud_ind.calledAddress,
-  ts_BSSMAP_ResetAck(g_osmux_enabled)));
+  ts_BSSMAP_ResetAck(g_osmux_enabled_cn)));
reset_received := true;
repeat;
}
@@ -1035,15 +1035,15 @@
mtc.stop;
}
/* always respond with RESET ACK to RESET */
-   [] BSSAP.receive(tr_BSSAP_UNITDATA_ind(?, ?, 
tr_BSSMAP_Reset(g_osmux_enabled))) -> value ud_ind {
+   [] BSSAP.receive(tr_BSSAP_UNITDATA_ind(?, ?, 
tr_BSSMAP_Reset(g_osmux_enabled_cn))) -> value ud_ind {
BSSAP.send(ts_BSSAP_UNITDATA_req(ud_ind.callingAddress, 
ud_ind.calledAddress,
-  ts_BSSMAP_ResetAck(g_osmux_enabled)));
+  ts_BSSMAP_ResetAck(g_osmux_enabled_cn)));
repeat;
}
 }

 altstep no_bssmap_reset() runs on test_CT {
-   [] BSSAP.receive(tr_BSSAP_UNITDATA_ind(?, ?, 
tr_BSSMAP_Reset(g_osmux_enabled))) {
+   [] BSSAP.receive(tr_BSSAP_UNITDATA_ind(?, ?, 
tr_BSSMAP_Reset(g_osmux_enabled_cn))) {
setverdict(fail, "unexpected BSSMAP Reset");
mtc.stop;
}
@@ -1074,7 +1074,7 @@
  * contains extra IE (OsmuxSupport) and osmo-bsc will handle AssignReq with
  * OsmuxCID IE.
  */
-private function f_vty_allow_osmux(boolean allow) runs on test_CT {
+private function f_vty_allow_osmux_cn(boolean allow) runs on test_CT {
f_vty_enter_cfg_msc(BSCVTY, 0);
if (allow) {
f_vty_transceive(BSCVTY, "osmux on");
@@ -1083,7 +1083,7 @@
}
f_vty_transceive(BSCVTY, "exit");
f_vty_transceive(BSCVTY, "exit");
-   g_osmux_enabled := allow;
+   g_osmux_enabled_cn := allow;
 }

 function f_init_vty(charstring id := "foo") runs on test_CT {
@@ -1187,7 +1187,7 @@
  * \param handler_mode Start an RSL_Emulation_CT component (true) or not 
(false).
  * \param nr_msc Number of virtual MSCs to bring up to connect to osmo-bsc.
  */
-function f_init(integer nr_bts := NUM_BTS, boolean handler_mode := false, 
boolean allow_osmux := false,
+function f_init(integer nr_bts := NUM_BTS, boolean handler_mode := false, 
boolean allow_osmux_cn := false,
integer nr_msc := 1, float guard_timeout := 30.0) runs on 
test_CT {
var integer bssap_idx;

@@ -1200,7 +1200,7 @@
activate(as_Tguard());

f_init_vty("VirtMSC");
-   f_vty_allow_osmux(allow_osmux);
+   f_vty_allow_osmux_cn(allow_osmux_cn);

var my_BooleanList allow_attach := { false, false, false };

Change in osmo-ttcn3-hacks[master]: bsc: Set g_osmux_enabled_cn directly in the test

2022-08-10 Thread pespin

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29009 )

Change subject: bsc: Set g_osmux_enabled_cn directly in the test
..

bsc: Set g_osmux_enabled_cn directly in the test

We want to add more options later on, and we don't want to be passing
all of them as params. Let's simply set the global fields directly in
the test and let f_init() use the confgured values.

Change-Id: I27b685c2c22cf876b5eba79cf8ad151a2643ecb1
---
M bsc/BSC_Tests.ttcn
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  daniel: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index d8a660c..7f4ce46 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1083,7 +1083,6 @@
}
f_vty_transceive(BSCVTY, "exit");
f_vty_transceive(BSCVTY, "exit");
-   g_osmux_enabled_cn := allow;
 }

 function f_init_vty(charstring id := "foo") runs on test_CT {
@@ -1187,7 +1186,7 @@
  * \param handler_mode Start an RSL_Emulation_CT component (true) or not 
(false).
  * \param nr_msc Number of virtual MSCs to bring up to connect to osmo-bsc.
  */
-function f_init(integer nr_bts := NUM_BTS, boolean handler_mode := false, 
boolean allow_osmux_cn := false,
+function f_init(integer nr_bts := NUM_BTS, boolean handler_mode := false,
integer nr_msc := 1, float guard_timeout := 30.0) runs on 
test_CT {
var integer bssap_idx;

@@ -1200,7 +1199,7 @@
activate(as_Tguard());

f_init_vty("VirtMSC");
-   f_vty_allow_osmux_cn(allow_osmux_cn);
+   f_vty_allow_osmux_cn(g_osmux_enabled_cn);

var my_BooleanList allow_attach := { false, false, false };
f_init_statsd("VirtMSC", vc_STATSD, mp_test_ip, mp_bsc_statsd_port);
@@ -5262,7 +5261,8 @@
pars.expect_mr_conf_ie := mr_conf;
pars.use_osmux_cn := true;
 
-   f_init(1, true, true);
+   g_osmux_enabled_cn := true;
+   f_init(1, true);
f_sleep(1.0);
f_vty_amr_start_mode_set(false, "1");


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29009
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I27b685c2c22cf876b5eba79cf8ad151a2643ecb1
Gerrit-Change-Number: 29009
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Build failed in Jenkins: master-osmo-opencm3-projects » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #93

2022-08-10 Thread jenkins

See 


Changes:


--
Started by upstream project "master-osmo-opencm3-projects" build number 93
originally caused by:
 Started by timer
Running as SYSTEM
Building remotely on build2-deb9build-ansible (ttcn3 osmocom-gerrit-debian9 
osmocom-master-debian9 repo-install-test coverity) in workspace 

The recommended git tool is: NONE
No credentials specified
 > git rev-parse --resolve-git-dir 
 > 
 >  # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.osmocom.org/osmo-opencm3-projects # 
 > timeout=10
Fetching upstream changes from git://git.osmocom.org/osmo-opencm3-projects
 > git --version # timeout=10
 > git --version # 'git version 2.11.0'
 > git fetch --tags --progress -- git://git.osmocom.org/osmo-opencm3-projects 
 > +refs/heads/*:refs/remotes/origin/* # timeout=10
Checking out Revision cbff8e75d06b5e8ea9a196fa4fa706ba9f9ed124 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f cbff8e75d06b5e8ea9a196fa4fa706ba9f9ed124 # timeout=10
Commit message: "Make code compatible with picolibc >= 1.7.3"
 > git rev-list --no-walk cbff8e75d06b5e8ea9a196fa4fa706ba9f9ed124 # timeout=10
 > git remote # timeout=10
 > git submodule init # timeout=10
 > git submodule sync # timeout=10
 > git config --get remote.origin.url # timeout=10
 > git submodule init # timeout=10
 > git config -f .gitmodules --get-regexp ^submodule\.(.+)\.url # timeout=10
 > git config --get submodule.libopencm3.url # timeout=10
 > git config -f .gitmodules --get submodule.libopencm3.path # timeout=10
 > git config --get submodule.librfn.url # timeout=10
 > git config -f .gitmodules --get submodule.librfn.path # timeout=10
 > git submodule update --init --recursive libopencm3 # timeout=10
 > git submodule update --init --recursive librfn # timeout=10
[osmocom-master-debian9] $ /bin/sh -xe /tmp/jenkins2814118907836490434.sh
+ ARTIFACT_STORE=/home/osmocom-build/jenkins_build_artifact_store
+ mkdir -p /home/osmocom-build/jenkins_build_artifact_store
+ docker run --rm=true --cap-add SYS_PTRACE -e ARTIFACT_STORE=/artifact_store 
-e ASCIIDOC_WARNINGS_CHECK=1 -e HOME=/build -e 
JOB_NAME=master-osmo-opencm3-projects/a1=default,a2=default,a3=default,a4=default,label=osmocom-master-debian9
 -e MAKE=make -e OSMOPY_DEBUG_TCP_SOCKETS=1 -e 
OSMO_GSM_MANUALS_DIR=/opt/osmo-gsm-manuals -e PARALLEL_MAKE=-j 8 -e PUBLISH=1 
-e WITH_MANUALS=1 -w /build -i -u build -v 
:/build
 -v /home/osmocom-build/jenkins_build_artifact_store:/artifact_store -v 
/home/osmocom-build/.ssh:/home/build/.ssh:ro 
osmocom-build/debian-bullseye-jenkins /build/contrib/jenkins.sh --publish
=== relay-driver START  ==
  CLEAN
  CC  console.c
  CC  console_stm32.c
In file included from ../../libopencm3//include/libopencm3/cm3/nvic.h:147,
 from ../../librfn/librfn/libopencm3/console_stm32.c:24:
../../libopencm3//include/libopencm3/dispatch/nvic.h:8:11: fatal error: 
libopencm3/stm32/f1/nvic.h: No such file or directory
 # include 
   ^~~~
compilation terminated.
make: *** [../../mk/libopencm3.mk:228: console_stm32.o] Error 1
Build step 'Execute shell' marked build as failure

Change in osmo-bts[master]: Clean up osmo-bts-*/Makefile.am

2022-08-10 Thread pespin

Attention is currently required from: pespin.
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29031

to look at the new patch set (#3).

Change subject: Clean up osmo-bts-*/Makefile.am
..

Clean up osmo-bts-*/Makefile.am

Make them more easy to read and edit by splitting to one lement per
line when several elements are present.

Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
---
M src/osmo-bts-lc15/Makefile.am
M src/osmo-bts-oc2g/Makefile.am
M src/osmo-bts-octphy/Makefile.am
M src/osmo-bts-omldummy/Makefile.am
M src/osmo-bts-sysmo/Makefile.am
M src/osmo-bts-virtual/Makefile.am
6 files changed, 305 insertions(+), 51 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/31/29031/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29031
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
Gerrit-Change-Number: 29031
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: Clean up osmo-bts-*/Makefile.am

2022-08-10 Thread pespin

Attention is currently required from: pespin.
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29031

to look at the new patch set (#2).

Change subject: Clean up osmo-bts-*/Makefile.am
..

Clean up osmo-bts-*/Makefile.am

Make them more easy to read and edit by splitting to one lement per
line when several elements are present.

Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
---
M src/osmo-bts-lc15/Makefile.am
M src/osmo-bts-oc2g/Makefile.am
M src/osmo-bts-octphy/Makefile.am
M src/osmo-bts-omldummy/Makefile.am
M src/osmo-bts-sysmo/Makefile.am
M src/osmo-bts-virtual/Makefile.am
6 files changed, 303 insertions(+), 51 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/31/29031/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29031
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
Gerrit-Change-Number: 29031
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-upf[master]: GTP mockup: list active GTP endecaps actions

2022-08-10 Thread neels

Attention is currently required from: laforge, fixeria.
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/28986 )

Change subject: GTP mockup: list active GTP endecaps actions
..


Patch Set 3:

(1 comment)

Patchset:

PS3:
modified the commit log to better explain why the patch is useful



--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28986
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752
Gerrit-Change-Number: 28986
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 10 Aug 2022 18:11:41 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-upf[master]: GTP mockup: list active GTP endecaps actions

2022-08-10 Thread neels

Attention is currently required from: neels, laforge, fixeria.
Hello Jenkins Builder, laforge, fixeria, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-upf/+/28986

to look at the new patch set (#3).

Change subject: GTP mockup: list active GTP endecaps actions
..

GTP mockup: list active GTP endecaps actions

In GTP mockup mode, keep a GTP device (struct upf_gtp_dev) so that
the GTP actions activated in mockup mode are listed on VTY.

Drop the global GTP mockup mode, and instead allow single GTP devices to
be mockup devices.

Do not always open the mnl_socket, but only open it when an actual
non-mockup GTP device is being opened. (In the presence of non-mockup
GTP devices, this still happens directly upon program startup.)

The GTP mockup was first introduced for VTY tests during 'make check'.
So far, in mockup mode, all GTP tunnel actions were simply cut short,
and no tunnels were ever listed as active.

TTCN3 tests do query osmo-upf to list currently active tunnels, so the
GTP mockup fails these tests. To allow running TTCN3 tests without
cap_net_admin privileges, always list (fake) active GTP tunnels.

Useful in a lab environment: send PFCP commands to osmo-upf and get a
listing of GTP tunnels that would have been active.

So far, osmo-upf always uses only the first GTP device configured, but
if we add support for multiple GTP devices, this patch allows putting
only single devices in mockup mode.

Related: SYS#5599
Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752
---
M doc/examples/osmo-upf/osmo-upf-mockup.cfg
M include/osmocom/upf/upf.h
M include/osmocom/upf/upf_gtp.h
M src/osmo-upf/osmo_upf_main.c
M src/osmo-upf/up_gtp_action.c
M src/osmo-upf/upf.c
M src/osmo-upf/upf_gtp.c
M src/osmo-upf/upf_vty.c
M tests/upf.vty
9 files changed, 82 insertions(+), 66 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/86/28986/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28986
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752
Gerrit-Change-Number: 28986
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: Clean up osmo-bts-*/Makefile.am

2022-08-10 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29031 )


Change subject: Clean up osmo-bts-*/Makefile.am
..

Clean up osmo-bts-*/Makefile.am

Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
---
M src/osmo-bts-lc15/Makefile.am
M src/osmo-bts-oc2g/Makefile.am
M src/osmo-bts-octphy/Makefile.am
M src/osmo-bts-omldummy/Makefile.am
M src/osmo-bts-sysmo/Makefile.am
M src/osmo-bts-virtual/Makefile.am
6 files changed, 303 insertions(+), 51 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/31/29031/1

diff --git a/src/osmo-bts-lc15/Makefile.am b/src/osmo-bts-lc15/Makefile.am
index bb68efa..607ce35 100644
--- a/src/osmo-bts-lc15/Makefile.am
+++ b/src/osmo-bts-lc15/Makefile.am
@@ -1,38 +1,99 @@
 AUTOMAKE_OPTIONS = subdir-objects

 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include $(LITECELL15_INCDIR)
-AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCODEC_CFLAGS) 
$(LIBOSMOGSM_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOSMOTRAU_CFLAGS) 
$(LIBOSMOABIS_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOABIS_CFLAGS) 
$(LIBGPS_CFLAGS) $(LIBSYSTEMD_CFLAGS)
-COMMON_LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOCODEC_LIBS) $(LIBOSMOGSM_LIBS) 
$(LIBOSMOVTY_LIBS) $(LIBOSMOTRAU_LIBS) $(LIBOSMOABIS_LIBS) $(LIBOSMOCTRL_LIBS)
+
+AM_CFLAGS = \
+   -Wall \
+   $(LIBOSMOCORE_CFLAGS) \
+   $(LIBOSMOCODEC_CFLAGS) \
+   $(LIBOSMOGSM_CFLAGS) \
+   $(LIBOSMOVTY_CFLAGS) \
+   $(LIBOSMOTRAU_CFLAGS) \
+   $(LIBOSMOCTRL_CFLAGS) \
+   $(LIBOSMOABIS_CFLAGS) \
+   $(LIBGPS_CFLAGS) \
+   $(LIBSYSTEMD_CFLAGS) \
+   $(NULL)
+
+COMMON_LDADD = \
+   $(LIBOSMOCORE_LIBS) \
+   $(LIBOSMOCODEC_LIBS) \
+   $(LIBOSMOGSM_LIBS) \
+   $(LIBOSMOVTY_LIBS) \
+   $(LIBOSMOTRAU_LIBS) \
+   $(LIBOSMOCTRL_LIBS) \
+   $(LIBOSMOABIS_LIBS) \
+   $(NULL)

 AM_CFLAGS += -DENABLE_LC15BTS

-EXTRA_DIST = misc/lc15bts_mgr.h misc/lc15bts_misc.h misc/lc15bts_par.h 
misc/lc15bts_led.h \
-   misc/lc15bts_temp.h misc/lc15bts_power.h misc/lc15bts_clock.h \
-   misc/lc15bts_bid.h misc/lc15bts_nl.h misc/lc15bts_bts.h 
misc/lc15bts_swd.h \
-   hw_misc.h l1_if.h l1_transp.h lc15bts.h utils.h
+EXTRA_DIST = \
+   misc/lc15bts_mgr.h \
+   misc/lc15bts_misc.h \
+   misc/lc15bts_par.h \
+   misc/lc15bts_led.h \
+   misc/lc15bts_temp.h \
+   misc/lc15bts_power.h \
+   misc/lc15bts_clock.h \
+   misc/lc15bts_bid.h \
+   misc/lc15bts_nl.h \
+   misc/lc15bts_bts.h \
+   misc/lc15bts_swd.h \
+   hw_misc.h \
+   l1_if.h \
+   l1_transp.h \
+   lc15bts.h \
+   utils.h \
+   $(NULL)

 bin_PROGRAMS = osmo-bts-lc15 lc15bts-mgr lc15bts-util

-COMMON_SOURCES = main.c lc15bts.c l1_if.c oml.c lc15bts_vty.c tch.c hw_misc.c 
calib_file.c \
-utils.c misc/lc15bts_par.c misc/lc15bts_bid.c
+COMMON_SOURCES = \
+   main.c \
+   lc15bts.c \
+   l1_if.c \
+   oml.c \
+   lc15bts_vty.c \
+   tch.c \
+   hw_misc.c \
+   calib_file.c \
+   utils.c \
+   misc/lc15bts_par.c \
+   misc/lc15bts_bid.c \
+   $(NULL)

 osmo_bts_lc15_SOURCES = $(COMMON_SOURCES) l1_transp_hw.c
-osmo_bts_lc15_LDADD = $(top_builddir)/src/common/libbts.a $(COMMON_LDADD)
+osmo_bts_lc15_LDADD = \
+   $(top_builddir)/src/common/libbts.a \
+   $(COMMON_LDADD) \
+   $(NULL)

 lc15bts_mgr_SOURCES = \
-   misc/lc15bts_mgr.c misc/lc15bts_misc.c \
-   misc/lc15bts_par.c misc/lc15bts_nl.c \
-   misc/lc15bts_temp.c misc/lc15bts_power.c \
-   misc/lc15bts_clock.c misc/lc15bts_bid.c \
+   misc/lc15bts_mgr.c \
+   misc/lc15bts_misc.c \
+   misc/lc15bts_par.c \
+   misc/lc15bts_nl.c \
+   misc/lc15bts_temp.c \
+   misc/lc15bts_power.c \
+   misc/lc15bts_clock.c \
+   misc/lc15bts_bid.c \
misc/lc15bts_mgr_vty.c \
misc/lc15bts_mgr_nl.c \
misc/lc15bts_mgr_temp.c \
misc/lc15bts_mgr_calib.c \
misc/lc15bts_led.c \
misc/lc15bts_bts.c \
-   misc/lc15bts_swd.c
+   misc/lc15bts_swd.c \
+   $(NULL)

-lc15bts_mgr_LDADD = $(top_builddir)/src/common/libbts.a $(LIBGPS_LIBS) 
$(LIBOSMOCORE_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMOABIS_LIBS) $(LIBOSMOGSM_LIBS) 
$(LIBOSMOCTRL_LIBS) $(LIBSYSTEMD_LIBS) $(COMMON_LDADD)
+lc15bts_mgr_LDADD = \
+   $(top_builddir)/src/common/libbts.a \
+   $(COMMON_LDADD) \
+   $(LIBGPS_LIBS) \
+   $(NULL)

-lc15bts_util_SOURCES = misc/lc15bts_util.c misc/lc15bts_par.c
+lc15bts_util_SOURCES = \
+   misc/lc15bts_util.c \
+   misc/lc15bts_par.c º
+   $(NULL)
 lc15bts_util_LDADD = $(LIBOSMOCORE_LIBS)
diff --git a/src/osmo-bts-oc2g/Makefile.am b/src/osmo-bts-oc2g/Makefile.am
index 7b18e88..9a5994e 100644
---

Change in osmo-bts[master]: logging: Move category descriptions to be in order with enum

2022-08-10 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29030 )


Change subject: logging: Move category descriptions to be in order with enum
..

logging: Move category descriptions to be in order with enum

Change-Id: I3a1922fcd695e08ca42ece8cf0a1804d1a00f450
---
M src/common/logging.c
1 file changed, 11 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/30/29030/1

diff --git a/src/common/logging.c b/src/common/logging.c
index 9c458e8..c79a58b 100644
--- a/src/common/logging.c
+++ b/src/common/logging.c
@@ -84,17 +84,6 @@
.loglevel = LOGL_NOTICE,
.enabled = 1,
},
-   [DABIS] = {
-   .name = "DABIS",
-   .description = "A-bis Intput Subsystem",
-   .enabled = 1, .loglevel = LOGL_NOTICE,
-   },
-   [DRTP] = {
-   .name = "DRTP",
-   .description = "Realtime Transfer Protocol",
-   .loglevel = LOGL_NOTICE,
-   .enabled = 1,
-   },
[DPCU] = {
.name = "DPCU",
.description = "PCU interface",
@@ -119,6 +108,17 @@
.color = "\033[0;94m",
.enabled = 1, .loglevel = LOGL_NOTICE,
},
+   [DABIS] = {
+   .name = "DABIS",
+   .description = "A-bis Intput Subsystem",
+   .enabled = 1, .loglevel = LOGL_NOTICE,
+   },
+   [DRTP] = {
+   .name = "DRTP",
+   .description = "Realtime Transfer Protocol",
+   .loglevel = LOGL_NOTICE,
+   .enabled = 1,
+   },
 };

 static int osmo_bts_filter_fn(const struct log_context *ctx, struct log_target 
*tgt)

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29030
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3a1922fcd695e08ca42ece8cf0a1804d1a00f450
Gerrit-Change-Number: 29030
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in libosmocore[master]: Diversify osmo_sockaddr_str_*() error codes

2022-08-10 Thread msuraev

Attention is currently required from: pespin.
msuraev has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/28996 )

Change subject: Diversify osmo_sockaddr_str_*() error codes
..


Patch Set 5:

(1 comment)

Patchset:

PS4:
> Is there really a need to have a separate error code for all paths? If an 
> invalid value is passed, t […]
To me the codes look perfectly fitting while using debugger to work around the 
inconvenience we've created ourselves makes no sense.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28996
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic1be25a076776de5b417cb5ac66f954ac5680e10
Gerrit-Change-Number: 28996
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Wed, 10 Aug 2022 15:47:42 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: msuraev 
Gerrit-MessageType: comment

Change in libosmo-netif[master]: osmux.h: Define default Osmux port

2022-08-10 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29029 )


Change subject: osmux.h: Define default Osmux port
..

osmux.h: Define default Osmux port

This has been the port being used historically in most osmux setups,
and projects using osmux.h have it defined locally. Let's define it here
so that there's no need to define it on each client.

Change-Id: Ibfd058bceeeaa1384a00d8fcd6d6268b445e19bd
---
M include/osmocom/netif/osmux.h
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/29/29029/1

diff --git a/include/osmocom/netif/osmux.h b/include/osmocom/netif/osmux.h
index ed5c1ab..ff537c0 100644
--- a/include/osmocom/netif/osmux.h
+++ b/include/osmocom/netif/osmux.h
@@ -13,6 +13,8 @@
  *  Osmocom multiplex protocol helpers
  */

+#define OSMUX_DEFAULT_PORT 1984
+
 /* OSmux header:
  *
  * rtp_m (1 bit):  RTP M field (RFC3550, RFC4867)

--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29029
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ibfd058bceeeaa1384a00d8fcd6d6268b445e19bd
Gerrit-Change-Number: 29029
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in libosmo-netif[master]: osmux.h: Add missing msgb.h header

2022-08-10 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29028 )


Change subject: osmux.h: Add missing msgb.h header
..

osmux.h: Add missing msgb.h header

Change-Id: I2002ed2352ef4db2fe0717389f1f6e24a88a973f
---
M include/osmocom/netif/osmux.h
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/28/29028/1

diff --git a/include/osmocom/netif/osmux.h b/include/osmocom/netif/osmux.h
index 6305dc8..ed5c1ab 100644
--- a/include/osmocom/netif/osmux.h
+++ b/include/osmocom/netif/osmux.h
@@ -3,6 +3,7 @@

 #include 
 #include 
+#include 

 /*! \addtogroup osmux
  *  @{

--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29028
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I2002ed2352ef4db2fe0717389f1f6e24a88a973f
Gerrit-Change-Number: 29028
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-bts[master]: rsl: rx ipac crcx/mdcx: Log payload_type2

2022-08-10 Thread fixeria

Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29027 )

Change subject: rsl: rx ipac crcx/mdcx: Log payload_type2
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29027
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id3afee50aa112051aacb9016183a78374e5ba7fc
Gerrit-Change-Number: 29027
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Wed, 10 Aug 2022 15:28:37 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ci[master]: jobs/master-builds: fix libosmo-pfcp related trigger mess

2022-08-10 Thread fixeria

fixeria has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/29017 )

Change subject: jobs/master-builds: fix libosmo-pfcp related trigger mess
..

jobs/master-builds: fix libosmo-pfcp related trigger mess

* master-libosmo-pfcp is triggered directly by libosmocore, not
  by master-libosmo-netif, nor master-libosmo-abis, so
** fix comment explaining the hierarchy.

* master-osmo-upf is triggered by master-libosmo-pfcp, so
** it should not be triggered directly by libosmocore.

Change-Id: Ie4a5cb47464e9abfc9d04e63e9e71619f33ffd42
Fixes: Icb75adec886cf1053b80c968fea59e597ed289a7
---
M jobs/master-builds.yml
1 file changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Jenkins Builder: Verified
  daniel: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved



diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml
index acb8216..f48bae5 100644
--- a/jobs/master-builds.yml
+++ b/jobs/master-builds.yml
@@ -151,19 +151,18 @@
   #   -> master-osmo-hlr
   #   -> master-osmo-mgw
   #   -> master-osmo-sgsn
-  #   -> master-libosmo-pfcp
-  #  -> master-osmo-upf
-  #  -> master-osmo-hnbgw
   #-> master-osmo-bts
+  # -> master-libosmo-pfcp
+  #-> master-osmo-upf
+  #-> master-osmo-hnbgw
   # -> master-osmo-ggsn
   #-> master-osmo-sgsn
-  # -> master-osmo-upf
   # [...]
   trigger: >
 master-libosmo-abis,
+master-libosmo-pfcp,
 master-osmo-gbproxy,
 master-osmo-ggsn,
-master-osmo-upf,
 master-osmo-gmr,
 master-osmo-pcap,
 master-osmo-pcu,
@@ -171,7 +170,6 @@
 master-osmo-tetra,
 master-osmo-trx,
 master-osmocom-bb,
-master-libosmo-pfcp,
 SIMtrace,
 xgoldmon


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29017
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a5cb47464e9abfc9d04e63e9e71619f33ffd42
Gerrit-Change-Number: 29017
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-ci[master]: OSMO_RELEASE_REPOS: add missing libosmo-pfcp and osmo-upf

2022-08-10 Thread fixeria

fixeria has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/29018 )

Change subject: OSMO_RELEASE_REPOS: add missing libosmo-pfcp and osmo-upf
..

OSMO_RELEASE_REPOS: add missing libosmo-pfcp and osmo-upf

Change-Id: Ib7431281ff78686087d23bb6d600e6c68faef6e5
---
M scripts/common.sh
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  daniel: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved



diff --git a/scripts/common.sh b/scripts/common.sh
index e8603a3..8e784cc 100644
--- a/scripts/common.sh
+++ b/scripts/common.sh
@@ -11,6 +11,7 @@
libasn1c
libosmo-abis
libosmo-netif
+   libosmo-pfcp
libosmo-sccp
libosmocore
libsmpp34
@@ -37,6 +38,7 @@
osmo-sysmon
osmo-trx
osmo-uecups
+   osmo-upf
osmocom-bb
simtrace2
 "

--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29018
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ib7431281ff78686087d23bb6d600e6c68faef6e5
Gerrit-Change-Number: 29018
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-ci[master]: {jobs,coverity}: add a new project - libosmo-gprs

2022-08-10 Thread fixeria

fixeria has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/29019 )

Change subject: {jobs,coverity}: add a new project - libosmo-gprs
..

{jobs,coverity}: add a new project - libosmo-gprs

Change-Id: I83e86084e9f7a7431bf5a70c372da1f9ccd28436
---
M coverity/build_Osmocom.sh
M coverity/prepare_source_Osmocom.sh
M jobs/gerrit-lint.yml
M jobs/gerrit-verifications.yml
M jobs/master-builds.yml
M scripts/common.sh
6 files changed, 16 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  daniel: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved



diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh
index 4291558..da2244a 100755
--- a/coverity/build_Osmocom.sh
+++ b/coverity/build_Osmocom.sh
@@ -74,6 +74,7 @@
 build_libasn1c
 build_libusrp
 build_default libosmo-abis
+build_default libosmo-gprs
 build_default libosmo-netif
 build_default libosmo-pfcp
 build_default libosmo-sccp
diff --git a/coverity/prepare_source_Osmocom.sh 
b/coverity/prepare_source_Osmocom.sh
index 73baf2c..e97c885 100755
--- a/coverity/prepare_source_Osmocom.sh
+++ b/coverity/prepare_source_Osmocom.sh
@@ -12,6 +12,7 @@
   libosmo-abis
   libosmocore
   libosmo-dsp
+  libosmo-gprs
   libosmo-netif
   libosmo-pfcp
   libosmo-sccp
diff --git a/jobs/gerrit-lint.yml b/jobs/gerrit-lint.yml
index cc83bea..9a1c1c5 100644
--- a/jobs/gerrit-lint.yml
+++ b/jobs/gerrit-lint.yml
@@ -18,6 +18,7 @@
   - libasn1c
   - libgtpnl
   - libosmo-abis
+  - libosmo-gprs
   - libosmo-netif
   - libosmo-pfcp
   - libosmo-sccp
diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index a4af343..85c78b4 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -55,6 +55,7 @@
   - libasn1c
   - libgtpnl
   - libosmo-abis
+  - libosmo-gprs
   - libosmo-netif
   - libosmo-pfcp
   - libosmo-sccp
diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml
index f48bae5..b5c42f1 100644
--- a/jobs/master-builds.yml
+++ b/jobs/master-builds.yml
@@ -83,6 +83,15 @@
   trigger: master-osmo-gmr
   email: gerrit-log@lists.osmocom.org lafo...@gnumonks.org 
246...@gmail.com

+  - libosmo-gprs:
+  # Full triggers would be:
+  # trigger: >
+  #   master-osmo-pcu
+  # Optimized:
+  # (see comment at libosmocore)
+  trigger: >
+master-osmo-pcu
+
   - libosmo-netif:
   # Full triggers would be:
   # trigger: >
@@ -152,6 +161,8 @@
   #   -> master-osmo-mgw
   #   -> master-osmo-sgsn
   #-> master-osmo-bts
+  # -> master-libosmo-gprs
+  #-> master-osmo-pcu
   # -> master-libosmo-pfcp
   #-> master-osmo-upf
   #-> master-osmo-hnbgw
@@ -165,7 +176,6 @@
 master-osmo-ggsn,
 master-osmo-gmr,
 master-osmo-pcap,
-master-osmo-pcu,
 master-osmo-sip-connector,
 master-osmo-tetra,
 master-osmo-trx,
diff --git a/scripts/common.sh b/scripts/common.sh
index 8e784cc..e085123 100644
--- a/scripts/common.sh
+++ b/scripts/common.sh
@@ -10,6 +10,7 @@
 OSMO_RELEASE_REPOS="
libasn1c
libosmo-abis
+   libosmo-gprs
libosmo-netif
libosmo-pfcp
libosmo-sccp

--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29019
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I83e86084e9f7a7431bf5a70c372da1f9ccd28436
Gerrit-Change-Number: 29019
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-ci[master]: {jobs,coverity}: add a new project - libosmo-gprs

2022-08-10 Thread fixeria

Attention is currently required from: laforge.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/29019 )

Change subject: {jobs,coverity}: add a new project - libosmo-gprs
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29019
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I83e86084e9f7a7431bf5a70c372da1f9ccd28436
Gerrit-Change-Number: 29019
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Wed, 10 Aug 2022 15:27:40 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ci[master]: OSMO_RELEASE_REPOS: add missing libosmo-pfcp and osmo-upf

2022-08-10 Thread fixeria

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/29018 )

Change subject: OSMO_RELEASE_REPOS: add missing libosmo-pfcp and osmo-upf
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29018
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ib7431281ff78686087d23bb6d600e6c68faef6e5
Gerrit-Change-Number: 29018
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 10 Aug 2022 15:27:37 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: bsc: Rename s/use_osmux/use_osmux_cn/

2022-08-10 Thread daniel

Attention is currently required from: pespin.
daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29008 )

Change subject: bsc: Rename s/use_osmux/use_osmux_cn/
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29008
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3bde4e6772c18043dd763d7747b5dbe40e0da3b8
Gerrit-Change-Number: 29008
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Wed, 10 Aug 2022 15:03:54 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: rsl: rx ipac crcx/mdcx: Log payload_type2

2022-08-10 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29027 )


Change subject: rsl: rx ipac crcx/mdcx: Log payload_type2
..

rsl: rx ipac crcx/mdcx: Log payload_type2

Change-Id: Id3afee50aa112051aacb9016183a78374e5ba7fc
---
M src/common/rsl.c
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/27/29027/1

diff --git a/src/common/rsl.c b/src/common/rsl.c
index 0a519af..e8765a7 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2793,6 +2793,8 @@
LOGPC(DRSL, LOGL_DEBUG, "\n");

payload_type2 = TLVP_VAL(, RSL_IE_IPAC_RTP_PAYLOAD2);
+   if (payload_type2)
+   LOGPC(DRSL, LOGL_DEBUG, "payload_type2=%u ", *payload_type2);

if (dch->c.msg_type == RSL_MT_IPAC_CRCX && connect_ip && connect_port)
inc_ip_port = 1;

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29027
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id3afee50aa112051aacb9016183a78374e5ba7fc
Gerrit-Change-Number: 29027
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-ci[master]: jobs/master-builds: fix libosmo-pfcp related trigger mess

2022-08-10 Thread pespin

Attention is currently required from: fixeria.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/29017 )

Change subject: jobs/master-builds: fix libosmo-pfcp related trigger mess
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29017
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a5cb47464e9abfc9d04e63e9e71619f33ffd42
Gerrit-Change-Number: 29017
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 10 Aug 2022 14:06:38 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-msc[master]: Make esme struct shared

2022-08-10 Thread pespin

Attention is currently required from: msuraev, dexter.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28846 )

Change subject: Make esme struct shared
..


Patch Set 18:

(1 comment)

File src/libsmpputil/smpp_smsc.c:

https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/9bd98785_3edc04a3
PS18, Line 879: struct esme *e = talloc_zero(ctx, struct esme);
Ah now it is allocated here, good then.
But then the function should be called emse_alloc().



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70
Gerrit-Change-Number: 28846
Gerrit-PatchSet: 18
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-CC: pespin 
Gerrit-Attention: msuraev 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Wed, 10 Aug 2022 14:05:49 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-msc[master]: Make esme struct shared

2022-08-10 Thread pespin

Attention is currently required from: msuraev, dexter.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28846 )

Change subject: Make esme struct shared
..


Patch Set 18:

(1 comment)

File src/libsmpputil/smpp_smsc.c:

https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/6e66b03b_4219ac89
PS16, Line 878: {
> It's allocated with talloc_zero() already.
I don't see it being allocated in the library, so the library doesn't know 
about that. I see you are trying to move stuff into a library but not really 
respecting implementation boundaries correctly between both.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70
Gerrit-Change-Number: 28846
Gerrit-PatchSet: 18
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-CC: pespin 
Gerrit-Attention: msuraev 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Wed, 10 Aug 2022 14:03:45 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: msuraev 
Comment-In-Reply-To: dexter 
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: bsc: Set g_osmux_enabled_cn directly in the test

2022-08-10 Thread pespin

Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29009 )

Change subject: bsc: Set g_osmux_enabled_cn directly in the test
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29009
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I27b685c2c22cf876b5eba79cf8ad151a2643ecb1
Gerrit-Change-Number: 29009
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Wed, 10 Aug 2022 14:01:55 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: Add osmo_sockaddr_strs_to_str()

2022-08-10 Thread pespin

Attention is currently required from: msuraev.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/28992 )

Change subject: Add osmo_sockaddr_strs_to_str()
..


Patch Set 6:

(4 comments)

Patchset:

PS6:
It would be great if you explain where is this going to be used and the need 
for it.


File include/osmocom/core/sockaddr_str.h:

https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/e28c28ce_7f0dc117
PS6, Line 63: #define OSMO_SOCKADDR_STR_FMT_ARGS(R) \
You could actually define these based on the ones below now.
It actually makes more sense to swap the order of the 2 groups probably anyway.


File src/sockaddr_str.c:

https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/518976a9_80b451ca
PS6, Line 565:  ret = snprintf(buf, rem, "(");
FYI, you can have a look at using OSMO_STRBUF APIs, they are useful to 
implement stuff like done in this function.


https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/020c9318_daf05360
PS6, Line 578: 
OSMO_SOCKADDR_STR_NO_PORT_FMT_ARGS(sa_str[i]), after);
maybe add a boolean print_ports to decide whether to add ports or not?



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic0d7c08f669994e37a2314555ecac85d28c42c89
Gerrit-Change-Number: 28992
Gerrit-PatchSet: 6
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Attention: msuraev 
Gerrit-Comment-Date: Wed, 10 Aug 2022 14:01:33 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-ci[master]: {jobs,coverity}: add a new project - libosmo-gprs

2022-08-10 Thread pespin

Attention is currently required from: laforge, fixeria.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/29019 )

Change subject: {jobs,coverity}: add a new project - libosmo-gprs
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29019
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I83e86084e9f7a7431bf5a70c372da1f9ccd28436
Gerrit-Change-Number: 29019
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 10 Aug 2022 13:54:56 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ci[master]: OSMO_RELEASE_REPOS: add missing libosmo-pfcp and osmo-upf

2022-08-10 Thread pespin

Attention is currently required from: fixeria.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/29018 )

Change subject: OSMO_RELEASE_REPOS: add missing libosmo-pfcp and osmo-upf
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29018
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ib7431281ff78686087d23bb6d600e6c68faef6e5
Gerrit-Change-Number: 29018
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 10 Aug 2022 13:54:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: Use osmo_sockaddr_strs_to_str() for multiaddr helper

2022-08-10 Thread pespin

Attention is currently required from: msuraev.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/28993 )

Change subject: Use osmo_sockaddr_strs_to_str() for multiaddr helper
..


Patch Set 6: Code-Review-1

(1 comment)

Patchset:

PS6:
What do we win with this? I see only drawbacks: allocating and freeing N more 
buffers on the heap everytime it is called.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28993
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icef53fe4b6e51563d97a1bc48001d67679b3b6e9
Gerrit-Change-Number: 28993
Gerrit-PatchSet: 6
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: msuraev 
Gerrit-Comment-Date: Wed, 10 Aug 2022 13:54:03 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: add library/PFCP_*, deps/PFCP

2022-08-10 Thread pespin

Attention is currently required from: neels, laforge.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 )

Change subject: add library/PFCP_*, deps/PFCP
..


Patch Set 5:

(1 comment)

File library/PFCP_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/31dfc23b_8d0ae9d4
PS4, Line 188:  var template PDU_PFCP t := ts_PDU_PFCP();
> template (value)
THis has not yet been resolved.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f
Gerrit-Change-Number: 28817
Gerrit-PatchSet: 5
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Wed, 10 Aug 2022 13:49:27 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment

Change in libosmocore[master]: Diversify osmo_sockaddr_str_*() error codes

2022-08-10 Thread pespin

Attention is currently required from: msuraev.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/28996 )

Change subject: Diversify osmo_sockaddr_str_*() error codes
..


Patch Set 5: Code-Review-1

(1 comment)

Patchset:

PS4:
> Which error code would you suggest to make those different?
Is there really a need to have a separate error code for all paths? If an 
invalid value is passed, then return -EINVAL and not some other random not 
fitting code, otherwise it's misleading.

If you want to see which error code was returned, add a specific print or use a 
debugger.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28996
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic1be25a076776de5b417cb5ac66f954ac5680e10
Gerrit-Change-Number: 28996
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: msuraev 
Gerrit-Comment-Date: Wed, 10 Aug 2022 13:47:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: msuraev 
Gerrit-MessageType: comment

Change in osmo-upf[master]: GTP mockup: allow single GTP devices in mockup mode

2022-08-10 Thread pespin

Attention is currently required from: neels, laforge.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/28986 )

Change subject: GTP mockup: allow single GTP devices in mockup mode
..


Patch Set 2:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-upf/+/28986/comment/99c6d108_5db931b3
PS1, Line 20: TTCN3 tests do query osmo-upf to list currently active tunnels, 
so the
> But I don't really have that situation, I'm just
> lazy to constantly put cap_net_admin on the binary... That's no good
> justification on its own, but I figured it could still help someone some day.
>

Simply add the set cap_net_admin in your build/install scripts so it's done 
automatically.



--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28986
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752
Gerrit-Change-Number: 28986
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Wed, 10 Aug 2022 13:45:37 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-upf[master]: GTP mockup: allow single GTP devices in mockup mode

2022-08-10 Thread pespin

Attention is currently required from: neels, laforge.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/28986 )

Change subject: GTP mockup: allow single GTP devices in mockup mode
..


Patch Set 2: Code-Review-1

(1 comment)

Patchset:

PS2:
I personally see no reason for using the mockup stuff in the ttcn3 tests, and 
hence no reason for this patch because I see no real use case.
The mockup stuff can be useful for a really specific use case, that is VTY 
testing, but nothing more really.
Let's see what others think.



--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28986
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752
Gerrit-Change-Number: 28986
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Wed, 10 Aug 2022 13:44:45 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: msc: f_tc_mt_t310: allow CRCX in either order

2022-08-10 Thread daniel

Attention is currently required from: neels.
daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29024 )

Change subject: msc: f_tc_mt_t310: allow CRCX in either order
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29024
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0ec348df08aa49ed58b3465de51b259fb74c0aea
Gerrit-Change-Number: 29024
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Wed, 10 Aug 2022 13:37:02 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ci[master]: jobs/master-builds: fix libosmo-pfcp related trigger mess

2022-08-10 Thread daniel

Attention is currently required from: fixeria.
daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/29017 )

Change subject: jobs/master-builds: fix libosmo-pfcp related trigger mess
..


Patch Set 1: Code-Review+1

(2 comments)

Patchset:

PS1:
> Because neither libosmo-pfcp depends on libosmo-netif, nor on libosmo-abis. 
> […]
Thanks


PS1: 
Thanks



--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29017
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a5cb47464e9abfc9d04e63e9e71619f33ffd42
Gerrit-Change-Number: 29017
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 10 Aug 2022 13:35:57 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria 
Comment-In-Reply-To: daniel 
Gerrit-MessageType: comment

Change in osmo-msc[master]: Make esme struct shared

2022-08-10 Thread msuraev

Attention is currently required from: pespin, msuraev, dexter.
Hello Jenkins Builder, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-msc/+/28846

to look at the new patch set (#18).

Change subject: Make esme struct shared
..

Make esme struct shared

This helps to merge similar code from smpp_mirror and smpp_* in follow-up 
patches.

Related: OS#5568
Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70
---
M include/osmocom/smpp/smpp.h
M include/osmocom/smpp/smpp_smsc.h
M src/libsmpputil/smpp_msc.c
M src/libsmpputil/smpp_smsc.c
M src/libsmpputil/smpp_vty.c
M src/utils/Makefile.am
M src/utils/smpp_mirror.c
7 files changed, 117 insertions(+), 101 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/46/28846/18
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70
Gerrit-Change-Number: 28846
Gerrit-PatchSet: 18
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-CC: pespin 
Gerrit-Attention: pespin 
Gerrit-Attention: msuraev 
Gerrit-Attention: dexter 
Gerrit-MessageType: newpatchset

Change in osmo-ci[master]: jobs/master-builds: fix libosmo-pfcp related trigger mess

2022-08-10 Thread fixeria

Attention is currently required from: daniel.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/29017 )

Change subject: jobs/master-builds: fix libosmo-pfcp related trigger mess
..


Patch Set 1:

(1 comment)

Patchset:

PS1:
> Can you explain why you didn't add the libosmo-pfcp to the 
> master-libosmo-netif trigger instead? […]
Because neither libosmo-pfcp depends on libosmo-netif, nor on libosmo-abis. The 
only dependency is libosmocore, so it should be triggered by libosmocore. So 
the code is correct, but the comment is not.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29017
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a5cb47464e9abfc9d04e63e9e71619f33ffd42
Gerrit-Change-Number: 29017
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Wed, 10 Aug 2022 13:09:24 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel 
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: bsc: Set g_osmux_enabled_cn directly in the test

2022-08-10 Thread daniel

Attention is currently required from: neels, pespin.
daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29009 )

Change subject: bsc: Set g_osmux_enabled_cn directly in the test
..


Patch Set 1: Code-Review+1

(1 comment)

Patchset:

PS1:
I was worried reading "global" part until I realized that it's "global to the 
component (instance)"



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29009
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I27b685c2c22cf876b5eba79cf8ad151a2643ecb1
Gerrit-Change-Number: 29009
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Wed, 10 Aug 2022 13:06:07 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: Add osmo_sockaddr_strs_to_str()

2022-08-10 Thread msuraev

Attention is currently required from: msuraev.
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/28992

to look at the new patch set (#6).

Change subject: Add osmo_sockaddr_strs_to_str()
..

Add osmo_sockaddr_strs_to_str()

Related: OS#5581
Change-Id: Ic0d7c08f669994e37a2314555ecac85d28c42c89
---
M include/osmocom/core/sockaddr_str.h
M src/sockaddr_str.c
M tests/sockaddr_str/sockaddr_str_test.c
M tests/sockaddr_str/sockaddr_str_test.ok
4 files changed, 120 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/92/28992/6
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic0d7c08f669994e37a2314555ecac85d28c42c89
Gerrit-Change-Number: 28992
Gerrit-PatchSet: 6
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: msuraev 
Gerrit-MessageType: newpatchset

Change in osmo-ci[master]: {jobs,coverity}: add a new project - libosmo-gprs

2022-08-10 Thread daniel

Attention is currently required from: laforge, fixeria.
daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/29019 )

Change subject: {jobs,coverity}: add a new project - libosmo-gprs
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29019
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I83e86084e9f7a7431bf5a70c372da1f9ccd28436
Gerrit-Change-Number: 29019
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:53:16 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ci[master]: OSMO_RELEASE_REPOS: add missing libosmo-pfcp and osmo-upf

2022-08-10 Thread daniel

Attention is currently required from: fixeria.
daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/29018 )

Change subject: OSMO_RELEASE_REPOS: add missing libosmo-pfcp and osmo-upf
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29018
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ib7431281ff78686087d23bb6d600e6c68faef6e5
Gerrit-Change-Number: 29018
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:50:56 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ci[master]: jobs/master-builds: fix libosmo-pfcp related trigger mess

2022-08-10 Thread daniel

Attention is currently required from: fixeria.
daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/29017 )

Change subject: jobs/master-builds: fix libosmo-pfcp related trigger mess
..


Patch Set 1:

(1 comment)

Patchset:

PS1:
Can you explain why you didn't add the libosmo-pfcp to the master-libosmo-netif 
trigger instead?

So why was the optimized comment wrong and not the code itself?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29017
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a5cb47464e9abfc9d04e63e9e71619f33ffd42
Gerrit-Change-Number: 29017
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:50:02 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in libosmocore[master]: Use osmo_sockaddr_strs_to_str() for multiaddr helper

2022-08-10 Thread msuraev

msuraev has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/28993 )

Change subject: Use osmo_sockaddr_strs_to_str() for multiaddr helper
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28993
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icef53fe4b6e51563d97a1bc48001d67679b3b6e9
Gerrit-Change-Number: 28993
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:46:19 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in libosmocore[master]: Add osmo_sockaddr_strs_to_str()

2022-08-10 Thread msuraev

Attention is currently required from: msuraev.
msuraev has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/28992 )

Change subject: Add osmo_sockaddr_strs_to_str()
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic0d7c08f669994e37a2314555ecac85d28c42c89
Gerrit-Change-Number: 28992
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: msuraev 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:45:50 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in libosmocore[master]: Make osmo_sockaddr_str_from_sockaddr() less picky

2022-08-10 Thread msuraev

Attention is currently required from: dexter.
Hello Jenkins Builder, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/28995

to look at the new patch set (#5).

Change subject: Make osmo_sockaddr_str_from_sockaddr() less picky
..

Make osmo_sockaddr_str_from_sockaddr() less picky

Attempt to guess the AF_INET* type in 'struct sockaddr_storage'
before converting it.

Related: OS#5581
Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf
---
M src/sockaddr_str.c
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/95/28995/5
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28995
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf
Gerrit-Change-Number: 28995
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: dexter 
Gerrit-Attention: dexter 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: Add osmo_sockaddr_str_from_sockaddr2()

2022-08-10 Thread msuraev

Attention is currently required from: dexter.
msuraev has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/28995 )

Change subject: Add osmo_sockaddr_str_from_sockaddr2()
..


Patch Set 4:

(3 comments)

Patchset:

PS4:
I'll update existing function instead in the next version.


File src/sockaddr_str.c:

https://gerrit.osmocom.org/c/libosmocore/+/28995/comment/70fe1509_5c875e31
PS4, Line 380: {
> as far as I can see the guess is the only difference. Maybe the api doc can 
> reflect that. […]
Ack


https://gerrit.osmocom.org/c/libosmocore/+/28995/comment/b485c13f_e36e958e
PS4, Line 385:
> the guess above dereferences src, in the case where src == NULL, the function 
> would have crashed alr […]
Ack



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28995
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf
Gerrit-Change-Number: 28995
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: dexter 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:44:27 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter 
Gerrit-MessageType: comment

Change in libosmo-abis[master]: pkgconf: require libosmocore

2022-08-10 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/29021 )

Change subject: pkgconf: require libosmocore
..

pkgconf: require libosmocore

osmocom/abis/e1_input.h includes osmocom/core/linuxlist.h, therefore
the .pc file(s) need a dependency on libosmocore so that the Cflags
from libosmocore.pc make an appearance on the compiler command line
when using `pkg-config libosmoabis --cflags`.

Committed-by: Max 
Change-Id: Iacf4ccdb1c2a0e64ac997bda11161b8fe2548725
---
M libosmoabis.pc.in
M libosmotrau.pc.in
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/libosmoabis.pc.in b/libosmoabis.pc.in
index 751149d..da113fc 100644
--- a/libosmoabis.pc.in
+++ b/libosmoabis.pc.in
@@ -8,4 +8,4 @@
 Version: @VERSION@
 Libs: -L${libdir} -losmoabis
 Cflags: -I${includedir}/
-
+Requires: libosmocore
diff --git a/libosmotrau.pc.in b/libosmotrau.pc.in
index d15c5fa..50ab9d0 100644
--- a/libosmotrau.pc.in
+++ b/libosmotrau.pc.in
@@ -8,3 +8,4 @@
 Version: @VERSION@
 Libs: -L${libdir} -losmotrau
 Cflags: -I${includedir}/
+Requires: libosmocore

--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29021
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iacf4ccdb1c2a0e64ac997bda11161b8fe2548725
Gerrit-Change-Number: 29021
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in libosmo-abis[master]: pkgconf: require libosmocore

2022-08-10 Thread laforge

Attention is currently required from: msuraev.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/29021 )

Change subject: pkgconf: require libosmocore
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29021
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iacf4ccdb1c2a0e64ac997bda11161b8fe2548725
Gerrit-Change-Number: 29021
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: msuraev 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:38:40 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-mgw[master]: mgcp_e1: fix apidoc

2022-08-10 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/29025 )

Change subject: mgcp_e1: fix apidoc
..

mgcp_e1: fix apidoc

Change-Id: Iaccb9b67e72d113483160e61f660ea9c4c2f53a5
---
M src/libosmo-mgcp/mgcp_e1.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c
index 9a6efe2..7f30c1d 100644
--- a/src/libosmo-mgcp/mgcp_e1.c
+++ b/src/libosmo-mgcp/mgcp_e1.c
@@ -496,7 +496,7 @@
}
 }

-/* !Equip E1 endpoint with I.460 mux resources.
+/*! Equip E1 endpoint with I.460 mux resources.
  *  \param[in] endp endpoint to equip
  *  \param[in] ts E1 timeslot number.
  *  \param[in] ss E1 subslot number.

--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29025
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Iaccb9b67e72d113483160e61f660ea9c4c2f53a5
Gerrit-Change-Number: 29025
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in osmo-mgw[master]: mgcp_e1: fix apidoc

2022-08-10 Thread laforge

Attention is currently required from: dexter.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/29025 )

Change subject: mgcp_e1: fix apidoc
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29025
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Iaccb9b67e72d113483160e61f660ea9c4c2f53a5
Gerrit-Change-Number: 29025
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:37:57 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: msc: f_tc_mt_t310: allow CRCX in either order

2022-08-10 Thread laforge

Attention is currently required from: neels.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29024 )

Change subject: msc: f_tc_mt_t310: allow CRCX in either order
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29024
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0ec348df08aa49ed58b3465de51b259fb74c0aea
Gerrit-Change-Number: 29024
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:37:12 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-gprs[master]: update git URLs (git -> https; gitea)

2022-08-10 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-gprs/+/29016 )

Change subject: update git URLs (git -> https; gitea)
..

update git URLs (git -> https; gitea)

Change-Id: Icb87ee511ceb9e65d7a801eeb8d4314b66e9f20a
---
M README.md
M debian/control
M debian/copyright
3 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved; Verified



diff --git a/README.md b/README.md
index d928874..8a6c5c9 100644
--- a/README.md
+++ b/README.md
@@ -17,7 +17,7 @@

 You can clone from the official libosmo-gprs.git repository using

-   git clone git://git.osmocom.org/libosmo-gprs.git
+   git clone https://gitea.osmocom.org/osmocom/libosmo-gprs.git

 To submit patches, see "Contributing" below.

diff --git a/debian/control b/debian/control
index aa5aaf1..6af9a96 100644
--- a/debian/control
+++ b/debian/control
@@ -11,8 +11,8 @@
git,
libosmocore-dev (>= 1.7.0)
 Standards-Version: 3.9.8
-Vcs-Git: git://git.osmocom.org/libosmo-gprs.git
-Vcs-Browser: http://git.osmocom.org/libosmo-gprs/
+Vcs-Git: https://gitea.osmocom.org/osmocom/libosmo-gprs
+Vcs-Browser: https://gitea.osmocom.org/osmocom/libosmo-gprs
 Homepage: https://projects.osmocom.org/projects/libosmo-gprs

 Package: libosmo-csn1-0
diff --git a/debian/copyright b/debian/copyright
index 244c8f2..670cede 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -1,6 +1,6 @@
 Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Upstream-Name: libosmo-gprs
-Source: git://git.osmocom.org/libosmo-gprs
+Source: https://gitea.osmocom.org/osmocom/libosmo-gprs

 Files: *
 Copyright: 2022 sysmocom - s.f.m.c. GmbH 

--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29016
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Icb87ee511ceb9e65d7a801eeb8d4314b66e9f20a
Gerrit-Change-Number: 29016
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in libosmo-gprs[master]: update git URLs (git -> https; gitea)

2022-08-10 Thread laforge

Attention is currently required from: fixeria.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-gprs/+/29016 )

Change subject: update git URLs (git -> https; gitea)
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29016
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Icb87ee511ceb9e65d7a801eeb8d4314b66e9f20a
Gerrit-Change-Number: 29016
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:36:17 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-gprs[master]: update git URLs (git -> https; gitea)

2022-08-10 Thread laforge

Attention is currently required from: fixeria.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-gprs/+/29016 )

Change subject: update git URLs (git -> https; gitea)
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29016
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Icb87ee511ceb9e65d7a801eeb8d4314b66e9f20a
Gerrit-Change-Number: 29016
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:36:16 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-pfcp[master]: README.md: tweak clone URL

2022-08-10 Thread fixeria

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29026 )

Change subject: README.md: tweak clone URL
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29026
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Idcfd4421189c711f95926f7e66da3402c059dfff
Gerrit-Change-Number: 29026
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:35:53 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-pfcp[master]: README.md: tweak clone URL

2022-08-10 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29026 )

Change subject: README.md: tweak clone URL
..

README.md: tweak clone URL

Change-Id: Idcfd4421189c711f95926f7e66da3402c059dfff
---
M README.md
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/README.md b/README.md
index de85ca1..9dd12c0 100644
--- a/README.md
+++ b/README.md
@@ -12,7 +12,7 @@

 You can clone from the official libosmo-pfcp.git repository using

-   git clone git://git.osmocom.org/libosmo-pfcp.git
+   git clone https://gitea.osmocom.org/osmocom/libosmo-pfcp

 To submit patches, see "Contributing" below.


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29026
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Idcfd4421189c711f95926f7e66da3402c059dfff
Gerrit-Change-Number: 29026
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in libosmo-pfcp[master]: debian packaging of libosmo-gtlv and libosmo-pfcp

2022-08-10 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005 )

Change subject: debian packaging of libosmo-gtlv and libosmo-pfcp
..

debian packaging of libosmo-gtlv and libosmo-pfcp

Fix debian packaging, so far a copy-paste from osmo-upf.git crept in
here by accident.

Related: SYS#5895
Change-Id: Id7169fc67b4f8f77dfbeff9f199e6557ced67a53
---
M debian/changelog
M debian/compat
M debian/control
M debian/copyright
A debian/libosmo-gtlv0.install
R debian/libosmo-pfcp0.install
M debian/rules
M tests/libosmo-pfcp/Makefile.am
8 files changed, 96 insertions(+), 33 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve



diff --git a/debian/changelog b/debian/changelog
index e69de29..e16e70f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -0,0 +1,5 @@
+libosmo-pfcp (0.1.0) testing; urgency=low
+
+  Create new Debian package.
+
+ -- Neels Hofmeyr   Tue, 9 Aug 2022 18:29:05 +0200
diff --git a/debian/compat b/debian/compat
index ec63514..f599e28 100644
--- a/debian/compat
+++ b/debian/compat
@@ -1 +1 @@
-9
+10
diff --git a/debian/control b/debian/control
index 04b8224..d1f8b43 100644
--- a/debian/control
+++ b/debian/control
@@ -1,8 +1,8 @@
-Source: osmo-upf
-Section: net
-Priority: extra
-Maintainer: Osmocom team 
-Build-Depends: debhelper (>=9),
+Source: libosmo-pfcp
+Section: libs
+Priority: optional
+Maintainer: Osmocom team 
+Build-Depends: debhelper (>=10),
dh-autoreconf,
autotools-dev,
autoconf,
@@ -10,33 +10,89 @@
automake,
libtool,
pkg-config,
-   python3-minimal,
-   libtalloc-dev,
-   libosmocore-dev (>= 1.6.0),
-   osmo-gsm-manuals-dev (>= 1.2.0)
+   libosmocore-dev (>= 1.7.0),
+   libtalloc-dev (>= 2.1.0)
 Standards-Version: 3.9.8
-Vcs-Git: git://git.osmocom.org/osmo-upf.git
-Vcs-Browser: https://git.osmocom.org/osmo-upf/
-Homepage: https://projects.osmocom.org/projects/osmo-upf
+Vcs-Git: https://gitea.osmocom.org/osmocom/libosmo-pfcp
+Vcs-Browser: https://gitea.osmocom.org/osmocom/libosmo-pfcp
+Homepage: https://projects.osmocom.org/projects/libosmo-pfcp

-Package: osmo-upf
+Package: libosmo-pfcp
+Section: libs
 Architecture: any
 Multi-Arch: foreign
-Depends: ${misc:Depends}, ${shlibs:Depends}
-Description: OsmoUPF: Osmocom User Plane Function
+Depends: ${misc:Depends},
+ libosmo-gtlv0 (= ${binary:Version}),
+ libosmo-pfcp0 (= ${binary:Version})
+Description: Osmocom PFCP protocol implementation (metapackage)
+ Install Osmocom PFCP and generic TLV protocol libraries.

-Package: osmo-upf-dbg
-Section: debug
+Package: libosmo-gtlv0
+Section: libs
 Architecture: any
 Multi-Arch: same
-Depends: osmo-upf (= ${binary:Version}), ${misc:Depends}
-Description: OsmoUPF: Osmocom User Plane Function
+Depends: ${shlibs:Depends},
+ ${misc:Depends},
+ libosmocore-dev (>= 1.7.0),
+ libtalloc-dev (>= 2.1.0)
+Pre-Depends: ${misc:Pre-Depends}
+Description: Generic TLV and TLIV protocol support
+ Decoding, encoding and logging of protocols using a Tag-Length-Value and/or
+ Tag-Length-Instance-Value structure.

-Package: osmo-upf-doc
-Architecture: all
-Section: doc
-Priority: optional
-Depends: ${misc:Depends}
-Description: ${misc:Package} PDF documentation
- Various manuals: user manual, VTY reference manual and/or
- protocol/interface manuals.
+Package: libosmo-gtlv-dev
+Architecture: any
+Multi-Arch: same
+Section: libdevel
+Depends: ${misc:Depends},
+ libosmo-gtlv0 (= ${binary:Version})
+Description: Development headers for libosmo-gtlv
+ libosmo-gtlv implements decoding, encoding and logging of protocols using a
+ Tag-Length-Value and/or Tag-Length-Instance-Value structure. This package in
+ particular contains the files for compiling a program using this library.
+
+Package: libosmo-gtlv-dbg
+Architecture: any
+Multi-Arch: same
+Section: debug
+Priority: extra
+Depends: ${misc:Depends},
+ libosmo-gtlv0 (= ${binary:Version})
+Description: Debug symbols for libosmo-gtlv
+ libosmo-gtlv implements decoding, encoding and logging of protocols using a
+ Tag-Length-Value and/or Tag-Length-Instance-Value structure. This package in
+ particular contains the debug symbols for this library.
+
+Package: libosmo-pfcp0
+Section: libs
+Architecture: any
+Multi-Arch: same
+Depends: ${shlibs:Depends},
+ ${misc:Depends}
+Pre-Depends: ${misc:Pre-Depends}
+Description: PFCP protocol support
+ Decoding, encoding and endpoint implementation of the Packet Forwarding 
Control Protocol
+ (3GPP TS 29.244).
+
+Package: libosmo-pfcp-dev
+Architecture: any
+Multi-Arch: same
+Section: libdevel
+Depends: ${misc:Depends},
+ libosmo-pfcp0 (= ${binary:Version})
+Description: Development headers for libosmo-pfcp
+

Change in libosmo-pfcp[master]: README.md: tweak clone URL

2022-08-10 Thread laforge

Attention is currently required from: neels.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29026 )

Change subject: README.md: tweak clone URL
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29026
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Idcfd4421189c711f95926f7e66da3402c059dfff
Gerrit-Change-Number: 29026
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:35:48 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-pfcp[master]: debian packaging of libosmo-gtlv and libosmo-pfcp

2022-08-10 Thread laforge

Attention is currently required from: osmith, neels, fixeria.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005 )

Change subject: debian packaging of libosmo-gtlv and libosmo-pfcp
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Id7169fc67b4f8f77dfbeff9f199e6557ced67a53
Gerrit-Change-Number: 29005
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Attention: neels 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:35:38 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-pfcp[master]: debian packaging of libosmo-gtlv and libosmo-pfcp

2022-08-10 Thread fixeria

Attention is currently required from: osmith, neels.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005 )

Change subject: debian packaging of libosmo-gtlv and libosmo-pfcp
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Id7169fc67b4f8f77dfbeff9f199e6557ced67a53
Gerrit-Change-Number: 29005
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:35:40 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-gprs[master]: update git URLs (git -> https; gitea)

2022-08-10 Thread fixeria

Attention is currently required from: laforge.
Hello laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmo-gprs/+/29016

to look at the new patch set (#2).

Change subject: update git URLs (git -> https; gitea)
..

update git URLs (git -> https; gitea)

Change-Id: Icb87ee511ceb9e65d7a801eeb8d4314b66e9f20a
---
M README.md
M debian/control
M debian/copyright
3 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/16/29016/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29016
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Icb87ee511ceb9e65d7a801eeb8d4314b66e9f20a
Gerrit-Change-Number: 29016
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix TC_rsl_ms_pwr_dyn_{up,ass_down,max}: reply received SA...

2022-08-10 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29023 )

Change subject: BTS_Tests: fix TC_rsl_ms_pwr_dyn_{up,ass_down,max}: reply 
received SACCH L1H
..

BTS_Tests: fix TC_rsl_ms_pwr_dyn_{up,ass_down,max}: reply received SACCH L1H

As was explained in [1], until recently we relied on trxcon sendig
dummy RR Measurement Reports with patched L1 SACCH Header values.
Now trxcon does not patch it for us, so we need to send Uplink
SACCH blocks with the correct L1H ourselves.

Revision 2 of [1] was successfully tested and proved to fix the
above-mentioned testcases.  However during code review I was asked
to make the statements sending Uplink SACCH blocks self-explanatory.

In revision 3 of [1] I modified the code to call f_send_meas_rep(),
which was introduced in [2], which as stated in the commit message
is using g_pars.l1_pars.{ms_power_level,ms_actual_ta} instead of
the values from received L1H.  Of course this does not work.

Add and use f_send_meas_rep_l1h(), which allows to send the given L1H.
Take a chance to add a log() statement, so that we can see what we Tx.

Change-Id: Ia79a0a7b06394bd34d0f40226cf40e6e8bd2ba35
Fixes: [1] I31dd6b9026d04403092256176f67785a0a6486ad
Related: [2] Ia5d0315e053702df5fa8dad8c6c66c11c9f3edcb
Related: OS#5635
---
M bts/BTS_Tests.ttcn
1 file changed, 15 insertions(+), 5 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 9f2e366..b2d6383 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -782,6 +782,15 @@
 friend function f_send_meas_rep(template (value) MeasurementResults meas_res)
 runs on ConnHdlr {
var template (value) SacchL1Header l1h;
+
+   l1h := ts_SacchL1Header(g_pars.l1_pars.ms_power_level, 
g_pars.l1_pars.ms_actual_ta);
+   f_send_meas_rep_l1h(meas_res, l1h);
+}
+
+/* Send the given measurement results and L1H to the IUT over the Um interface 
*/
+friend function f_send_meas_rep_l1h(template (value) MeasurementResults 
meas_res,
+   template (value) SacchL1Header l1h)
+runs on ConnHdlr {
var octetstring l2;

/* RR Measurement Report to be sent */
@@ -792,7 +801,8 @@

/* TITAN has weird (and often unusable) padding model, so we pad here 
manaully */
l2 := f_pad_oct(enc_LapdmFrameAB(valueof(ts_LAPDm_AB(0, meas_rep))), 
21, '00'O);
-   l1h := ts_SacchL1Header(g_pars.l1_pars.ms_power_level, 
g_pars.l1_pars.ms_actual_ta);
+
+   log(%definitionId, "(): Tx SACCH L1 header: ", l1h);

/* Send RR Measurement Report over the Um interface */
L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0), 
l1h, l2));
@@ -2979,7 +2989,7 @@
T2.start;
alt {
[] as_l1_sacch_l1h(l1h) {
-   f_send_meas_rep(ts_MeasurementResults);
+   f_send_meas_rep_l1h(ts_MeasurementResults, l1h);

if (l1h.ms_power_lvl < (pwr_var + 6)) {
repeat;
@@ -3000,7 +3010,7 @@
T4.start;
alt {
[] as_l1_sacch_l1h(l1h) {
-   f_send_meas_rep(ts_MeasurementResults);
+   f_send_meas_rep_l1h(ts_MeasurementResults, l1h);

if (l1h.ms_power_lvl > pwr_var) {
repeat;
@@ -3045,7 +3055,7 @@
T1.start;
alt {
[] as_l1_sacch_l1h(l1h) {
-   f_send_meas_rep(ts_MeasurementResults);
+   f_send_meas_rep_l1h(ts_MeasurementResults, l1h);
repeat;
}
[] L1CTL.receive { repeat; }
@@ -3094,7 +3104,7 @@
T1.start;
alt {
[] as_l1_sacch_l1h(l1h) {
-   f_send_meas_rep(ts_MeasurementResults);
+   f_send_meas_rep_l1h(ts_MeasurementResults, l1h);
repeat;
}
[] L1CTL.receive { repeat; }

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29023
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia79a0a7b06394bd34d0f40226cf40e6e8bd2ba35
Gerrit-Change-Number: 29023
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in osmo-ttcn3-hacks[master]: BTS_Tests: use f_send_meas_rep() in f_TC_ms_pwr_ctrl_{constant,pf_ewma}

2022-08-10 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29022 )

Change subject: BTS_Tests: use f_send_meas_rep() in 
f_TC_ms_pwr_ctrl_{constant,pf_ewma}
..

BTS_Tests: use f_send_meas_rep() in f_TC_ms_pwr_ctrl_{constant,pf_ewma}

Change-Id: Id80317d1e9de3873ab2d26470a3552b4f2b539b1
---
M bts/BTS_Tests.ttcn
1 file changed, 2 insertions(+), 8 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index cbbb297..9f2e366 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -7877,10 +7877,7 @@
f_trxc_fake_rssi(mp_uplink_power_target);

/* Populate SACCH cache with a Measurement Report */
-   L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0),
-  
ts_SacchL1Header(g_pars.l1_pars.ms_power_level,
-   
g_pars.l1_pars.ms_actual_ta),
-  f_pad_oct('010349'O & 
'0615004001C0'O, 21, '00'O)));
+   f_send_meas_rep(ts_MeasurementResults);

/* Establish a dedicated channel */
f_est_dchan(more_ies := valueof(ies));
@@ -7944,10 +7941,7 @@
f_trxc_fake_rssi(mp_uplink_power_target);

/* Populate SACCH cache with a Measurement Report */
-   L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0),
-  
ts_SacchL1Header(g_pars.l1_pars.ms_power_level,
-   
g_pars.l1_pars.ms_actual_ta),
-  f_pad_oct('010349'O & 
'0615004001C0'O, 21, '00'O)));
+   f_send_meas_rep(ts_MeasurementResults);

/* Establish a dedicated channel */
f_est_dchan(more_ies := valueof(ies));

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29022
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id80317d1e9de3873ab2d26470a3552b4f2b539b1
Gerrit-Change-Number: 29022
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix TC_rsl_ms_pwr_dyn_{up,ass_down,max}: reply received SA...

2022-08-10 Thread laforge

Attention is currently required from: fixeria.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29023 )

Change subject: BTS_Tests: fix TC_rsl_ms_pwr_dyn_{up,ass_down,max}: reply 
received SACCH L1H
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29023
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia79a0a7b06394bd34d0f40226cf40e6e8bd2ba35
Gerrit-Change-Number: 29023
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:35:09 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: BTS_Tests: use f_send_meas_rep() in f_TC_ms_pwr_ctrl_{constant,pf_ewma}

2022-08-10 Thread laforge

Attention is currently required from: fixeria.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29022 )

Change subject: BTS_Tests: use f_send_meas_rep() in 
f_TC_ms_pwr_ctrl_{constant,pf_ewma}
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29022
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id80317d1e9de3873ab2d26470a3552b4f2b539b1
Gerrit-Change-Number: 29022
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:34:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-pfcp[master]: debian packaging of libosmo-gtlv and libosmo-pfcp

2022-08-10 Thread neels

Attention is currently required from: osmith, laforge, fixeria.
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005 )

Change subject: debian packaging of libosmo-gtlv and libosmo-pfcp
..


Patch Set 2:

(3 comments)

File debian/control:

https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005/comment/0b8e3e49_3066d766
PS1, Line 13: python3-minimal
> i thought the same, but figured for vty tests, […]
Done


https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005/comment/2d09e5ad_7c3a5270
PS1, Line 18: Vcs
> please use https://gitea.osmocom.org/osmocom/libosmo-pfcp for Vcs-git and 
> Vcs-browser these days.
Done


File debian/copyright:

https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005/comment/77430b30_0c47070f
PS1, Line 3: Source: git://git.osmocom.org/libosmo-pfcp
> same here, please use https://gitea.osmocom. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Id7169fc67b4f8f77dfbeff9f199e6557ced67a53
Gerrit-Change-Number: 29005
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Attention: osmith 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:33:57 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels 
Comment-In-Reply-To: laforge 
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in libosmo-pfcp[master]: debian packaging of libosmo-gtlv and libosmo-pfcp

2022-08-10 Thread neels

Attention is currently required from: osmith, fixeria.
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005 )

Change subject: debian packaging of libosmo-gtlv and libosmo-pfcp
..


Patch Set 2:

(2 comments)

Patchset:

PS2:
BTW, I checked that the browsing URL

  https://gitea.osmocom.org/osmocom/libosmo-pfcp

also serves as a clone URL without having to append ".git"


File debian/control:

https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005/comment/1ba077d4_69b6c40e
PS1, Line 13: python3-minimal
> Do we really need python, btw?
i thought the same, but figured for vty tests,
but now i notice that this library-only repos has no programs with vty tests.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Id7169fc67b4f8f77dfbeff9f199e6557ced67a53
Gerrit-Change-Number: 29005
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Attention: osmith 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:32:54 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in libosmo-pfcp[master]: README.md: tweak clone URL

2022-08-10 Thread neels

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29026 )


Change subject: README.md: tweak clone URL
..

README.md: tweak clone URL

Change-Id: Idcfd4421189c711f95926f7e66da3402c059dfff
---
M README.md
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/26/29026/1

diff --git a/README.md b/README.md
index de85ca1..9dd12c0 100644
--- a/README.md
+++ b/README.md
@@ -12,7 +12,7 @@

 You can clone from the official libosmo-pfcp.git repository using

-   git clone git://git.osmocom.org/libosmo-pfcp.git
+   git clone https://gitea.osmocom.org/osmocom/libosmo-pfcp

 To submit patches, see "Contributing" below.


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29026
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Idcfd4421189c711f95926f7e66da3402c059dfff
Gerrit-Change-Number: 29026
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in libosmo-pfcp[master]: debian packaging of libosmo-gtlv and libosmo-pfcp

2022-08-10 Thread neels

Attention is currently required from: osmith, neels.
Hello osmith, Jenkins Builder, fixeria, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005

to look at the new patch set (#2).

Change subject: debian packaging of libosmo-gtlv and libosmo-pfcp
..

debian packaging of libosmo-gtlv and libosmo-pfcp

Fix debian packaging, so far a copy-paste from osmo-upf.git crept in
here by accident.

Related: SYS#5895
Change-Id: Id7169fc67b4f8f77dfbeff9f199e6557ced67a53
---
M debian/changelog
M debian/compat
M debian/control
M debian/copyright
A debian/libosmo-gtlv0.install
R debian/libosmo-pfcp0.install
M debian/rules
M tests/libosmo-pfcp/Makefile.am
8 files changed, 96 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/05/29005/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Id7169fc67b4f8f77dfbeff9f199e6557ced67a53
Gerrit-Change-Number: 29005
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Attention: osmith 
Gerrit-Attention: neels 
Gerrit-MessageType: newpatchset

Change in osmo-upf[master]: main: show just a brief talloc report for vty

2022-08-10 Thread neels

neels has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/28984 )

Change subject: main: show just a brief talloc report for vty
..

main: show just a brief talloc report for vty

Upon ^C, do not barf a huge amount of full talloc report for the entire
VTY config tree. Show a brief report on VTY instead.

Related: SYS#5599
Change-Id: I038951c6d62679e3cfcda51512768d1fbacaa0d1
---
M src/osmo-upf/osmo_upf_main.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, but someone else must approve
  neels: Looks good to me, approved



diff --git a/src/osmo-upf/osmo_upf_main.c b/src/osmo-upf/osmo_upf_main.c
index 81102dd..b4888af 100644
--- a/src/osmo-upf/osmo_upf_main.c
+++ b/src/osmo-upf/osmo_upf_main.c
@@ -377,7 +377,7 @@
talloc_report_full(tall_infra_ctx, stderr);
talloc_free(tall_infra_ctx);

-   talloc_report_full(tall_vty_ctx, stderr);
+   talloc_report(tall_vty_ctx, stderr);
talloc_free(tall_vty_ctx);

talloc_report_full(NULL, stderr);



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28984
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I038951c6d62679e3cfcda51512768d1fbacaa0d1
Gerrit-Change-Number: 28984
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-MessageType: merged

Change in osmo-upf[master]: vty doc tweaks

2022-08-10 Thread neels

neels has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/29020 )

Change subject: vty doc tweaks
..

vty doc tweaks

Clarify "Add" and "Delete" of GTP devices.
Clarify GTP device in config vs. real GTP device.
Clarify s/kernel/Linux kernel

Related: SYS#5599
Change-Id: I918e0a9a332e4dd4b71965614c19481eb41004d6
---
M src/osmo-upf/upf_vty.c
M tests/upf.vty
2 files changed, 8 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  neels: Looks good to me, approved



diff --git a/src/osmo-upf/upf_vty.c b/src/osmo-upf/upf_vty.c
index 386aa2f..5227dba 100644
--- a/src/osmo-upf/upf_vty.c
+++ b/src/osmo-upf/upf_vty.c
@@ -86,7 +86,7 @@

 DEFUN(cfg_gtp, cfg_gtp_cmd,
   "gtp",
-  "Enter the 'gtp' node to configure GTP kernel module usage\n")
+  "Enter the 'gtp' node to configure Linux GTP kernel module usage\n")
 {
vty->node = GTP_NODE;
return CMD_SUCCESS;
@@ -135,7 +135,8 @@
 DEFUN(cfg_gtp_dev_create, cfg_gtp_dev_create_cmd,
   "dev create DEVNAME [LISTEN_ADDR]",
   DEV_STR
-  "create a new GTP device. Will listen on GTPv1 port " 
OSMO_STRINGIFY_VAL(PORT_GTP1_U)
+  "Add GTP device, creating a new Linux kernel GTP device. Will listen on 
GTPv1 port "
+  OSMO_STRINGIFY_VAL(PORT_GTP1_U)
   " and GTPv0 port " OSMO_STRINGIFY_VAL(PORT_GTP0_U) " on the specified 
interface, or on ANY if LISTEN_ADDR is"
   " omitted.\n"
   "device name, e.g. 'apn0'\n"
@@ -154,7 +155,7 @@
 DEFUN(cfg_gtp_dev_use, cfg_gtp_dev_use_cmd,
   "dev use DEVNAME",
   DEV_STR
-  "use an existing GTP device, e.g. created by 'gtp-link'\n"
+  "Add GTP device, using an existing Linux kernel GTP device, e.g. created 
by 'gtp-link'\n"
   "device name, e.g. 'apn0'\n")
 {
struct gtp_vty_cfg_dev *d = talloc_zero(g_upf, struct gtp_vty_cfg_dev);
@@ -168,7 +169,7 @@
 DEFUN(cfg_gtp_dev_del, cfg_gtp_dev_del_cmd,
   "dev delete DEVNAME",
   DEV_STR
-  "Remove a GTP device from the configuration, and delete the device if it 
was created here.\n"
+  "Remove a GTP device from the configuration, and delete the Linux kernel 
GTP device if it was created here.\n"
   "device name, e.g. 'apn0'\n")
 {
const char *dev_name = argv[0];
diff --git a/tests/upf.vty b/tests/upf.vty
index 107909b..d1cebe5 100644
--- a/tests/upf.vty
+++ b/tests/upf.vty
@@ -23,9 +23,9 @@
 OsmoUPF(config-gtp)# dev?
   dev  Configure the GTP device to use for encaps/decaps.
 OsmoUPF(config-gtp)# dev ?
-  create  create a new GTP device. Will listen on GTPv1 port 2152 and GTPv0 
port 3386 on the specified interface, or on ANY if LISTEN_ADDR is omitted.
-  use use an existing GTP device, e.g. created by 'gtp-link'
-  delete  Remove a GTP device from the configuration, and delete the device if 
it was created here.
+  create  Add GTP device, creating a new Linux kernel GTP device. Will listen 
on GTPv1 port 2152 and GTPv0 port 3386 on the specified interface, or on ANY if 
LISTEN_ADDR is omitted.
+  use Add GTP device, using an existing Linux kernel GTP device, e.g. 
created by 'gtp-link'
+  delete  Remove a GTP device from the configuration, and delete the Linux 
kernel GTP device if it was created here.
 OsmoUPF(config-gtp)# dev create ?
   DEVNAME  device name, e.g. 'apn0'
 OsmoUPF(config-gtp)# dev create foo ?

--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29020
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I918e0a9a332e4dd4b71965614c19481eb41004d6
Gerrit-Change-Number: 29020
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-MessageType: merged

Change in osmo-upf[master]: log: fix/tweak log msg about nft/mockup

2022-08-10 Thread neels

neels has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/28983 )

Change subject: log: fix/tweak log msg about nft/mockup
..

log: fix/tweak log msg about nft/mockup

There is no cmdline option --mockup-nft, that was an earlier stage of
the nftables mockup patch.

Related: SYS#5599
Change-Id: I2f77cfe727649bbdcebb4a656ebf97b186134ee8
---
M src/osmo-upf/upf_nft.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/src/osmo-upf/upf_nft.c b/src/osmo-upf/upf_nft.c
index c035016..bcb6a70 100644
--- a/src/osmo-upf/upf_nft.c
+++ b/src/osmo-upf/upf_nft.c
@@ -40,7 +40,7 @@
int rc;

if (g_upf->nft.mockup) {
-   LOGP(DNFT, LOGL_NOTICE, "--mockup-gtp active, not running nft 
ruleset: '%s'\n", ruleset);
+   LOGP(DNFT, LOGL_NOTICE, "nft/mockup active: not running nft 
ruleset: '%s'\n", ruleset);
return 0;
}

@@ -63,7 +63,8 @@
 {
int rc;
if (g_upf->nft.mockup) {
-   LOGP(DNFT, LOGL_NOTICE, "--mockup-gtp active, not allocating 
libnftables nft_ctx\n");
+   LOGP(DNFT, LOGL_NOTICE,
+"nft/mockup active: not allocating libnftables nft_ctx. 
FOR TESTING PURPOSES ONLY.\n");
return 0;
}




1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28983
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I2f77cfe727649bbdcebb4a656ebf97b186134ee8
Gerrit-Change-Number: 28983
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-MessageType: merged

Change in osmo-upf[master]: add comment about fd cleanup

2022-08-10 Thread neels

neels has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/28985 )

Change subject: add comment about fd cleanup
..

add comment about fd cleanup

Clarify that calling osmo_fd_close() is fine if no fd is open.

Related: SYS#5599
Change-Id: Ibd471485fde90a14fe19f558b38a49b0b7d62909
---
M src/osmo-upf/upf_gtp.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/src/osmo-upf/upf_gtp.c b/src/osmo-upf/upf_gtp.c
index 4a430cb..6280e45 100644
--- a/src/osmo-upf/upf_gtp.c
+++ b/src/osmo-upf/upf_gtp.c
@@ -449,6 +449,7 @@
while ((t = llist_first_entry_or_null(>tunnels, struct 
upf_gtp_tun, entry)))
talloc_free(t);
llist_del(>entry);
+   /* osmo_fd_close() is a noop if ofd.fd == -1 */
osmo_fd_close(>gtpv0.ofd);
osmo_fd_close(>gtpv1.ofd);
if (dev->created)



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28985
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ibd471485fde90a14fe19f558b38a49b0b7d62909
Gerrit-Change-Number: 28985
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-upf[master]: vty doc tweaks

2022-08-10 Thread neels

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/29020 )

Change subject: vty doc tweaks
..


Patch Set 1: Code-Review+2

(1 comment)

Patchset:

PS1:
trivial change, let's spare you guys the review



--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29020
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I918e0a9a332e4dd4b71965614c19481eb41004d6
Gerrit-Change-Number: 29020
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:17:38 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: msc: f_tc_mt_t310: detect MNCC failure explicitly

2022-08-10 Thread neels

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971 )

Change subject: msc: f_tc_mt_t310: detect MNCC failure explicitly
..


Patch Set 3: Code-Review+2

(1 comment)

Patchset:

PS3:
re-adding previous +2 after trivial change



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I49a15142a4b6c51ca767a884c0574f96e01d7cb1
Gerrit-Change-Number: 28971
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:14:01 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-mgw[master]: mgcp_e1: fix apidoc

2022-08-10 Thread dexter

dexter has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/29025 )


Change subject: mgcp_e1: fix apidoc
..

mgcp_e1: fix apidoc

Change-Id: Iaccb9b67e72d113483160e61f660ea9c4c2f53a5
---
M src/libosmo-mgcp/mgcp_e1.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/25/29025/1

diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c
index 9a6efe2..7f30c1d 100644
--- a/src/libosmo-mgcp/mgcp_e1.c
+++ b/src/libosmo-mgcp/mgcp_e1.c
@@ -496,7 +496,7 @@
}
 }

-/* !Equip E1 endpoint with I.460 mux resources.
+/*! Equip E1 endpoint with I.460 mux resources.
  *  \param[in] endp endpoint to equip
  *  \param[in] ts E1 timeslot number.
  *  \param[in] ss E1 subslot number.

--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29025
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Iaccb9b67e72d113483160e61f660ea9c4c2f53a5
Gerrit-Change-Number: 29025
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: add library/PFCP_*, deps/PFCP

2022-08-10 Thread neels

Attention is currently required from: pespin.
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 )

Change subject: add library/PFCP_*, deps/PFCP
..


Patch Set 5:

(1 comment)

Patchset:

PS5:
my s/ rule missed quite a few of them in the last patch set,
i've put all possible modifiers for templates now, afaict.

In other news, i already find it annoying as hell that my ctags jumps no longer 
work for PFCP templates :/ guess i need to do universal-ctags hacking



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f
Gerrit-Change-Number: 28817
Gerrit-PatchSet: 5
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:12:50 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: add library/PFCP_*, deps/PFCP

2022-08-10 Thread neels

Attention is currently required from: neels, pespin.
Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817

to look at the new patch set (#5).

Change subject: add library/PFCP_*, deps/PFCP
..

add library/PFCP_*, deps/PFCP

Will soon be used by new subdir 'upf' (test osmo-upf),
and by 'hnbgw' (test GTP mapping via UPF).

Related: SYS#5599
Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f
---
M deps/Makefile
M library/General_Types.ttcn
A library/PFCP_CodecPort.ttcn
A library/PFCP_CodecPort_CtrlFunct.ttcn
A library/PFCP_CodecPort_CtrlFunctDef.cc
A library/PFCP_Emulation.ttcn
A library/PFCP_Templates.ttcn
7 files changed, 926 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/17/28817/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f
Gerrit-Change-Number: 28817
Gerrit-PatchSet: 5
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-ttcn3-hacks[master]: msc: f_tc_mt_t310: detect MNCC failure explicitly

2022-08-10 Thread neels

Attention is currently required from: neels.
Hello Jenkins Builder, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971

to look at the new patch set (#3).

Change subject: msc: f_tc_mt_t310: detect MNCC failure explicitly
..

msc: f_tc_mt_t310: detect MNCC failure explicitly

Helped me find a failure cause: instead of T_guard timeout, immediately
show an unexpected MNCC event.

Related: SYS#5066
Change-Id: I49a15142a4b6c51ca767a884c0574f96e01d7cb1
---
M msc/MSC_Tests.ttcn
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/71/28971/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I49a15142a4b6c51ca767a884c0574f96e01d7cb1
Gerrit-Change-Number: 28971
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-MessageType: newpatchset

Change in osmo-ttcn3-hacks[master]: msc: f_tc_mt_t310: allow CRCX in either order

2022-08-10 Thread neels

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29024 )


Change subject: msc: f_tc_mt_t310: allow CRCX in either order
..

msc: f_tc_mt_t310: allow CRCX in either order

continued from Id0c98bc267daff352fc7db7712f967111970fd4d

Upcoming changes to osmo-msc move the CN side CRCX to an earlier point
in time, reversing that order. Introduce an 'interleave' to not care
about the ordering of MGCP and BSSAP messages.

Related: SYS#5066
Related: Ie433db1ba0c46d4b97538a969233c155cefac21c (osmo-msc)
Change-Id: I0ec348df08aa49ed58b3465de51b259fb74c0aea
---
M msc/MSC_Tests.ttcn
1 file changed, 18 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/24/29024/1

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 79221d7..d6e0aba 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -1771,25 +1771,31 @@

/* NOTE: MSC is expected to start T310 here */

+   interleave {
/* MSC->MGW: CRCX (first) */
-   MGCP.receive(tr_CRCX) -> value mgcp_cmd;
-   f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */
+   [] MGCP.receive(tr_CRCX) -> value mgcp_cmd {
+   f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */
+   }

/* BSC->BSC: BSSMAP ASSIGNMENT REQ */
-   BSSAP.receive(tr_BSSMAP_AssignmentReq(omit, ?)) -> value bssap;
-   BSSAP.send(ts_BSSMAP_AssignmentComplete(omit,
-   aoip := f_ts_BSSMAP_IE_AoIP_TLA(cpars.bss_rtp_ip, 
cpars.bss_rtp_port),
-   speechCodec := ts_BSSMAP_IE_SpeechCodec({ ts_CodecFR })));
+   [] BSSAP.receive(tr_BSSMAP_AssignmentReq(omit, ?)) -> value bssap {
+   BSSAP.send(ts_BSSMAP_AssignmentComplete(omit,
+   aoip := f_ts_BSSMAP_IE_AoIP_TLA(cpars.bss_rtp_ip, 
cpars.bss_rtp_port),
+   speechCodec := ts_BSSMAP_IE_SpeechCodec({ ts_CodecFR 
})));
+   }

/* MSC->MGW: MDCX */
-   MGCP.receive(tr_MDCX) -> value mgcp_cmd;
-   MGCP.send(ts_MDCX_ACK(mgcp_cmd.line.trans_id, 
cpars.mgw_conn_1.mgcp_connection_id,
-   sdp := omit));
+   [] MGCP.receive(tr_MDCX) -> value mgcp_cmd {
+   MGCP.send(ts_MDCX_ACK(mgcp_cmd.line.trans_id, 
cpars.mgw_conn_1.mgcp_connection_id,
+   sdp := omit));
+   }

/* MSC->MGW: CRCX (second) */
-   MGCP.receive(tr_CRCX) -> value mgcp_cmd;
-   f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */
-   MNCC.receive(tr_MNCC_RTP_CREATE(cpars.mncc_callref));
+   [] MGCP.receive(tr_CRCX) -> value mgcp_cmd {
+   f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */
+   MNCC.receive(tr_MNCC_RTP_CREATE(cpars.mncc_callref));
+   }
+   }

/* Reschedule the guard timeout */
g_Tguard.start(30.0 + 10.0);

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29024
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0ec348df08aa49ed58b3465de51b259fb74c0aea
Gerrit-Change-Number: 29024
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in libosmocore[master]: Diversify osmo_sockaddr_str_*() error codes

2022-08-10 Thread msuraev

Attention is currently required from: pespin.
msuraev has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/28996 )

Change subject: Diversify osmo_sockaddr_str_*() error codes
..


Patch Set 4:

(1 comment)

Patchset:

PS4:
> I'm sorry but I see the previous errors make a lot more sense than the one 
> you are setting now, so I […]
Which error code would you suggest to make those different?



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28996
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic1be25a076776de5b417cb5ac66f954ac5680e10
Gerrit-Change-Number: 28996
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:02:17 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix TC_rsl_ms_pwr_dyn_{up,ass_down,max}: reply received SA...

2022-08-10 Thread fixeria

fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29023 )


Change subject: BTS_Tests: fix TC_rsl_ms_pwr_dyn_{up,ass_down,max}: reply 
received SACCH L1H
..

BTS_Tests: fix TC_rsl_ms_pwr_dyn_{up,ass_down,max}: reply received SACCH L1H

As was explained in [1], until recently we relied on trxcon sendig
dummy RR Measurement Reports with patched L1 SACCH Header values.
Now trxcon does not patch it for us, so we need to send Uplink
SACCH blocks with the correct L1H ourselves.

Revision 2 of [1] was successfully tested and proved to fix the
above-mentioned testcases.  However during code review I was asked
to make the statements sending Uplink SACCH blocks self-explanatory.

In revision 3 of [1] I modified the code to call f_send_meas_rep(),
which was introduced in [2], which as stated in the commit message
is using g_pars.l1_pars.{ms_power_level,ms_actual_ta} instead of
the values from received L1H.  Of course this does not work.

Add and use f_send_meas_rep_l1h(), which allows to send the given L1H.
Take a chance to add a log() statement, so that we can see what we Tx.

Change-Id: Ia79a0a7b06394bd34d0f40226cf40e6e8bd2ba35
Fixes: [1] I31dd6b9026d04403092256176f67785a0a6486ad
Related: [2] Ia5d0315e053702df5fa8dad8c6c66c11c9f3edcb
Related: OS#5635
---
M bts/BTS_Tests.ttcn
1 file changed, 15 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/23/29023/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 9f2e366..b2d6383 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -782,6 +782,15 @@
 friend function f_send_meas_rep(template (value) MeasurementResults meas_res)
 runs on ConnHdlr {
var template (value) SacchL1Header l1h;
+
+   l1h := ts_SacchL1Header(g_pars.l1_pars.ms_power_level, 
g_pars.l1_pars.ms_actual_ta);
+   f_send_meas_rep_l1h(meas_res, l1h);
+}
+
+/* Send the given measurement results and L1H to the IUT over the Um interface 
*/
+friend function f_send_meas_rep_l1h(template (value) MeasurementResults 
meas_res,
+   template (value) SacchL1Header l1h)
+runs on ConnHdlr {
var octetstring l2;

/* RR Measurement Report to be sent */
@@ -792,7 +801,8 @@

/* TITAN has weird (and often unusable) padding model, so we pad here 
manaully */
l2 := f_pad_oct(enc_LapdmFrameAB(valueof(ts_LAPDm_AB(0, meas_rep))), 
21, '00'O);
-   l1h := ts_SacchL1Header(g_pars.l1_pars.ms_power_level, 
g_pars.l1_pars.ms_actual_ta);
+
+   log(%definitionId, "(): Tx SACCH L1 header: ", l1h);

/* Send RR Measurement Report over the Um interface */
L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0), 
l1h, l2));
@@ -2979,7 +2989,7 @@
T2.start;
alt {
[] as_l1_sacch_l1h(l1h) {
-   f_send_meas_rep(ts_MeasurementResults);
+   f_send_meas_rep_l1h(ts_MeasurementResults, l1h);

if (l1h.ms_power_lvl < (pwr_var + 6)) {
repeat;
@@ -3000,7 +3010,7 @@
T4.start;
alt {
[] as_l1_sacch_l1h(l1h) {
-   f_send_meas_rep(ts_MeasurementResults);
+   f_send_meas_rep_l1h(ts_MeasurementResults, l1h);

if (l1h.ms_power_lvl > pwr_var) {
repeat;
@@ -3045,7 +3055,7 @@
T1.start;
alt {
[] as_l1_sacch_l1h(l1h) {
-   f_send_meas_rep(ts_MeasurementResults);
+   f_send_meas_rep_l1h(ts_MeasurementResults, l1h);
repeat;
}
[] L1CTL.receive { repeat; }
@@ -3094,7 +3104,7 @@
T1.start;
alt {
[] as_l1_sacch_l1h(l1h) {
-   f_send_meas_rep(ts_MeasurementResults);
+   f_send_meas_rep_l1h(ts_MeasurementResults, l1h);
repeat;
}
[] L1CTL.receive { repeat; }

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29023
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia79a0a7b06394bd34d0f40226cf40e6e8bd2ba35
Gerrit-Change-Number: 29023
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: BTS_Tests: use f_send_meas_rep() in f_TC_ms_pwr_ctrl_{constant,pf_ewma}

2022-08-10 Thread fixeria

fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29022 )


Change subject: BTS_Tests: use f_send_meas_rep() in 
f_TC_ms_pwr_ctrl_{constant,pf_ewma}
..

BTS_Tests: use f_send_meas_rep() in f_TC_ms_pwr_ctrl_{constant,pf_ewma}

Change-Id: Id80317d1e9de3873ab2d26470a3552b4f2b539b1
---
M bts/BTS_Tests.ttcn
1 file changed, 2 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/22/29022/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index cbbb297..9f2e366 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -7877,10 +7877,7 @@
f_trxc_fake_rssi(mp_uplink_power_target);

/* Populate SACCH cache with a Measurement Report */
-   L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0),
-  
ts_SacchL1Header(g_pars.l1_pars.ms_power_level,
-   
g_pars.l1_pars.ms_actual_ta),
-  f_pad_oct('010349'O & 
'0615004001C0'O, 21, '00'O)));
+   f_send_meas_rep(ts_MeasurementResults);

/* Establish a dedicated channel */
f_est_dchan(more_ies := valueof(ies));
@@ -7944,10 +7941,7 @@
f_trxc_fake_rssi(mp_uplink_power_target);

/* Populate SACCH cache with a Measurement Report */
-   L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0),
-  
ts_SacchL1Header(g_pars.l1_pars.ms_power_level,
-   
g_pars.l1_pars.ms_actual_ta),
-  f_pad_oct('010349'O & 
'0615004001C0'O, 21, '00'O)));
+   f_send_meas_rep(ts_MeasurementResults);

/* Establish a dedicated channel */
f_est_dchan(more_ies := valueof(ies));

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29022
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id80317d1e9de3873ab2d26470a3552b4f2b539b1
Gerrit-Change-Number: 29022
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange

Change in libosmo-abis[master]: pkgconf: require libosmocore

2022-08-10 Thread fixeria

Attention is currently required from: msuraev.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/29021 )

Change subject: pkgconf: require libosmocore
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29021
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iacf4ccdb1c2a0e64ac997bda11161b8fe2548725
Gerrit-Change-Number: 29021
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: msuraev 
Gerrit-Comment-Date: Wed, 10 Aug 2022 09:33:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-abis[master]: pkgconf: require libosmocore

2022-08-10 Thread msuraev

msuraev has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/29021 )

Change subject: pkgconf: require libosmocore
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29021
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iacf4ccdb1c2a0e64ac997bda11161b8fe2548725
Gerrit-Change-Number: 29021
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 10 Aug 2022 09:28:05 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

90 matches

Mail list logo