Change in osmo-ttcn3-hacks[master]: update various expected-results.xml

[neels]

neels has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28989 )

Change subject: update various expected-results.xml
..

update various expected-results.xml

Change-Id: I850b79526145307246bca40c70ed8e4d586d8c68
---
M bsc/expected-results.xml
M gbproxy/expected-results.xml
A hnbgw/expected-results.xml
M hnodeb/expected-results.xml
M mgw/expected-results.xml
M msc/expected-results.xml
M ns/expected-results.xml
M pcu/expected-results.xml
M pgw/expected-results.xml
M sgsn/expected-results.xml
10 files changed, 125 insertions(+), 18 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml
index 572c657..23217ba 100644
--- a/bsc/expected-results.xml
+++ b/bsc/expected-results.xml
@@ -1,7 +1,13 @@
 
-
+
   
   
+  
+  
+  
+  
+  
+  
   
   
   
@@ -108,6 +114,7 @@
   
   
   
+  
   
   
   
@@ -130,6 +137,8 @@
   
   
   
+  
+  
   
   
   
@@ -146,7 +155,6 @@
   
   
   
-  
   
   
   
@@ -155,9 +163,13 @@
   
   
   
+  
+  
+  
   
   
   
+  
   
   
   
@@ -165,6 +177,7 @@
   
   
   
+  
   
   
   
@@ -179,9 +192,14 @@
   
   
   
+  
+  
+  
+  
   
   
   
+  
   
   
   
@@ -197,6 +215,7 @@
   
   
   
+  
   
   
   
@@ -215,10 +234,25 @@
   
   
   
+  
+  
+  
   
   
   
   
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
   
   
   
@@ -238,6 +272,8 @@
   
   
   
+  
+  
   
   
   
@@ -247,12 +283,18 @@
   
   
   
+  
   
   
   
   
   
+  
+  
   
   
   
+  
+  
+  
 
diff --git a/gbproxy/expected-results.xml b/gbproxy/expected-results.xml
index 6221f10..5b9f8b1 100644
--- a/gbproxy/expected-results.xml
+++ b/gbproxy/expected-results.xml
@@ -1,6 +1,7 @@
 
-
+
   
+  
   
   
   
@@ -19,8 +20,8 @@
   
   
   
-  
   
+  
   
   
   
@@ -75,5 +76,4 @@
   
   
   
-  
 
diff --git a/hnbgw/expected-results.xml b/hnbgw/expected-results.xml
new file mode 100644
index 000..cc77dc6
--- /dev/null
+++ b/hnbgw/expected-results.xml
@@ -0,0 +1,16 @@
+
+
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+
diff --git a/hnodeb/expected-results.xml b/hnodeb/expected-results.xml
index 39cea9f..f2c456b 100644
--- a/hnodeb/expected-results.xml
+++ b/hnodeb/expected-results.xml
@@ -1,4 +1,10 @@
 
-
-
+
+  
+  
+  
+  
+  
+  
+  
 
diff --git a/mgw/expected-results.xml b/mgw/expected-results.xml
index b2b63cd..89d5bf0 100644
--- a/mgw/expected-results.xml
+++ b/mgw/expected-results.xml
@@ -1,5 +1,5 @@
 
-
+
   
   
   
@@ -17,6 +17,7 @@
   
   
   
+  
   
   
   
@@ -57,8 +58,24 @@
   MGCP_Test.ttcn:MASKED TC_e1_crcx_and_dlcx_ep testcase
 
   
-  
-  
+  
+Response didn't match template
+  MGCP_Test.ttcn:MASKED MGCP_Test control part
+  MGCP_Test.ttcn:MASKED TC_e1_crcx_with_overlap testcase
+
+  
+  
+Response didn't match template
+  MGCP_Test.ttcn:MASKED MGCP_Test control part
+  MGCP_Test.ttcn:MASKED TC_e1_crcx_loopback testcase
+
+  
+  
+Response didn't match template
+  MGCP_Test.ttcn:MASKED MGCP_Test control part
+  MGCP_Test.ttcn:MASKED TC_e1_dlcx_wildcarded testcase
+
+  
   
   
   
@@ -89,5 +106,9 @@
 
   
   
+  
+  
+  
+  
   
 
diff --git a/msc/expected-results.xml b/msc/expected-results.xml
index ac98215..a77bdc5 100644
--- a/msc/expected-results.xml
+++ b/msc/expected-results.xml
@@ -1,5 +1,5 @@
 
-
+
   
   
   
@@ -154,6 +154,10 @@
   
   
   
+  
+  
+  
+  
   
   
   
diff --git a/ns/expected-results.xml b/ns/expected-results.xml
index 5263981..ef0d01f 100644
--- a/ns/expected-results.xml
+++ b/ns/expected-results.xml
@@ -1,9 +1,13 @@
 
-
+
   
   
   
   
+  
+  
+  
+  
   
   
   
@@ -19,4 +23,5 @@
   
   
   
+  
 
diff --git a/pcu/expected-results.xml b/pcu/expected-results.xml
index dc5aa31..7f138cd 100644
--- a/pcu/expected-results.xml
+++ b/pcu/expected-results.xml
@@ -1,5 +1,5 @@
 
-
+
   
   
   
@@ -39,6 +39,8 @@
   
   
   
+  
+  
   
   
   
@@ -52,6 +54,7 @@
   
   
   
+  
   
   
   
@@ -59,6 +62,7 @@
   
   
   
+  
   
   
   
@@ -87,15 +91,17 @@
   
   
   
+  
+  
+  
+  
   
   
   
   
   
   
-  
   
-  
   
   
   
@@ -111,6 +117,11 @@
   
   
   
+  
+  
+  
+  
+  
   
   
   
diff --git a/pgw/expected-results.xml b/pgw/expected-results.xml
index 65daf0e..0643289 100644
--- a/pgw/expected-results.xml
+++ b/pgw/expected-results.xml
@@ -1,9 +1,10 @@
 
-
+
   
   
   
   
   
   
+  
 
diff --git a/sgsn/expected-results.xml b/sgsn/expected-results.xml
index 31484d0..944f871 100644
--- a/sgsn/expected-results.xml
+++ b/sgsn/expected-results.xml
@@ -1,5 +1,5 @@
 
-
+
   
   
   
@@ -85,8 +85,9 @@
   
   
   
+  
   
-"BSSGP_Emulation.ttcnpp:818 : Couldn't find 
Component for TLLI 'C665E43F'O"
+"BSSGP_Emulation.ttcnpp:830 : Couldn't find 
Component for TLLI 'E918E6AA'O"
   SGSN_Tests_Iu.ttcn:MASKED SGSN_Tests_Iu control part
   

Change in osmo-ttcn3-hacks[master]: add library/PFCP_*, deps/PFCP

[neels]

Attention is currently required from: neels, laforge.
Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817

to look at the new patch set (#6).

Change subject: add library/PFCP_*, deps/PFCP
..

add library/PFCP_*, deps/PFCP

Will soon be used by new subdir 'upf' (test osmo-upf),
and by 'hnbgw' (test GTP mapping via UPF).

Related: SYS#5599
Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f
---
M deps/Makefile
M library/General_Types.ttcn
A library/PFCP_CodecPort.ttcn
A library/PFCP_CodecPort_CtrlFunct.ttcn
A library/PFCP_CodecPort_CtrlFunctDef.cc
A library/PFCP_Emulation.ttcn
A library/PFCP_Templates.ttcn
7 files changed, 926 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/17/28817/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f
Gerrit-Change-Number: 28817
Gerrit-PatchSet: 6
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-MessageType: newpatchset

Change in libosmo-pfcp[master]: fix warnings: 'uninitialized'

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29054 )


Change subject: fix warnings: 'uninitialized'
..

fix warnings: 'uninitialized'

Though these can never be used uninitialized, initialize to NULL to
avoid compiler warnings like:

 pfcp_msg.c:188:66: warning: 'h_no_seid' may be used uninitialized

Change-Id: Icb338b200fe3186ccd7fd3f502c1723f60947190
---
M src/libosmo-gtlv/gtlv_dec_enc.c
M src/libosmo-pfcp/pfcp_msg.c
2 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/54/29054/1

diff --git a/src/libosmo-gtlv/gtlv_dec_enc.c b/src/libosmo-gtlv/gtlv_dec_enc.c
index 2e5509a..c3e45ea 100644
--- a/src/libosmo-gtlv/gtlv_dec_enc.c
+++ b/src/libosmo-gtlv/gtlv_dec_enc.c
@@ -71,7 +71,7 @@
 {
void *obj = MEMB(decoded_struct, obj_ofs);
const struct osmo_gtlv_coding *iec;
-   unsigned int *multi_count_p;
+   unsigned int *multi_count_p = NULL;

/* To check for presence of mandatory IEs, need to keep a flag stack of 
seen ie_coding entries. This array has
 * to have at least the nr of entries that the ie_coding array has. 
Let's allow up to this many ie_coding
diff --git a/src/libosmo-pfcp/pfcp_msg.c b/src/libosmo-pfcp/pfcp_msg.c
index 5f55575..098ffa2 100644
--- a/src/libosmo-pfcp/pfcp_msg.c
+++ b/src/libosmo-pfcp/pfcp_msg.c
@@ -158,8 +158,8 @@
 static int enc_pfcp_header(struct msgb *msg, const struct osmo_pfcp_msg *m)
 {
const struct osmo_pfcp_header_parsed *parsed = >h;
-   struct osmo_pfcp_header_seid *h_seid;
-   struct osmo_pfcp_header_no_seid *h_no_seid;
+   struct osmo_pfcp_header_seid *h_seid = NULL;
+   struct osmo_pfcp_header_no_seid *h_no_seid = NULL;
struct osmo_pfcp_header_common *c;
int rc;


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29054
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Icb338b200fe3186ccd7fd3f502c1723f60947190
Gerrit-Change-Number: 29054
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in libosmo-pfcp[master]: .gitignore fixes: generated sources, .spec file

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29055 )


Change subject: .gitignore fixes: generated sources, .spec file
..

.gitignore fixes: generated sources, .spec file

Change-Id: Id8f6c80f13a09a3dedd4577fd1460f2f72faa8f8
---
M .gitignore
1 file changed, 12 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/55/29055/1

diff --git a/.gitignore b/.gitignore
index 2d26084..56bd8e6 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,6 +11,10 @@
 *.pc
 *~

+include/osmocom/pfcp/pfcp_ies_auto.h
+src/libosmo-pfcp/gen__pfcp_ies_auto
+src/libosmo-pfcp/pfcp_ies_auto.c
+
 *.*~
 *.sw?
 .libs
@@ -51,6 +55,13 @@
 #tests
 tests/testsuite.dir
 tests/*/*_test
+tests/*/*/*_test
+tests/libosmo-gtlv/test_gtlv_gen/gen__myproto_ies_auto
+tests/libosmo-gtlv/test_gtlv_gen/myproto_ies_auto.c
+tests/libosmo-gtlv/test_gtlv_gen/myproto_ies_auto.h
+tests/libosmo-gtlv/test_tliv/gen__myproto_ies_auto
+tests/libosmo-gtlv/test_tliv/myproto_ies_auto.c
+tests/libosmo-gtlv/test_tliv/myproto_ies_auto.h

 tests/atconfig
 tests/atlocal
@@ -71,4 +82,4 @@
 doc/manuals/common
 doc/manuals/build

-contrib/osmo-upf.spec
+contrib/libosmo-pfcp.spec

--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29055
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Id8f6c80f13a09a3dedd4577fd1460f2f72faa8f8
Gerrit-Change-Number: 29055
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in libosmo-pfcp[master]: libosmo-gtlv.pc.in: tweak Description

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29053 )


Change subject: libosmo-gtlv.pc.in: tweak Description
..

libosmo-gtlv.pc.in: tweak Description

Change-Id: Idcdffe4528370b8580a30fbdde6645ec5d814021
---
M libosmo-gtlv.pc.in
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/53/29053/1

diff --git a/libosmo-gtlv.pc.in b/libosmo-gtlv.pc.in
index 69de862..63e3c73 100644
--- a/libosmo-gtlv.pc.in
+++ b/libosmo-gtlv.pc.in
@@ -4,7 +4,7 @@
 includedir=@includedir@

 Name: Osmocom Generic TLV Library
-Description: C Utility Library
+Description: C Utility Library to parse Tag-Length-Value based protocols
 Version: @VERSION@
 Libs: -L${libdir} -losmo-gtlv
 Cflags: -I${includedir}/

--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29053
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Idcdffe4528370b8580a30fbdde6645ec5d814021
Gerrit-Change-Number: 29053
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in libosmo-pfcp[master]: configure.ac: drop dependencies on vty and ctrl

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29048 )


Change subject: configure.ac: drop dependencies on vty and ctrl
..

configure.ac: drop dependencies on vty and ctrl

Change-Id: Idea223e9b039241dd35c735922b8794573730fc3
---
M configure.ac
1 file changed, 0 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/48/29048/1

diff --git a/configure.ac b/configure.ac
index 77cb672..f146c20 100644
--- a/configure.ac
+++ b/configure.ac
@@ -41,8 +41,6 @@
 AC_SUBST(LIBRARY_DL)

 PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0)
-PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0)
-PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0)

 dnl checks for header files
 AC_HEADER_STDC

--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29048
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Idea223e9b039241dd35c735922b8794573730fc3
Gerrit-Change-Number: 29048
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in libosmo-pfcp[master]: debian/control: fix confusion in description

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29051 )


Change subject: debian/control: fix confusion in description
..

debian/control: fix confusion in description

Change-Id: I380b1dd626b3e6a35f17ae09a6758bef59f51c84
---
M debian/control
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/51/29051/1

diff --git a/debian/control b/debian/control
index d1f8b43..ca7eaa6 100644
--- a/debian/control
+++ b/debian/control
@@ -46,7 +46,7 @@
 Section: libdevel
 Depends: ${misc:Depends},
  libosmo-gtlv0 (= ${binary:Version})
-Description: Development headers for libosmo-gtlv
+Description: Development files for libosmo-gtlv
  libosmo-gtlv implements decoding, encoding and logging of protocols using a
  Tag-Length-Value and/or Tag-Length-Instance-Value structure. This package in
  particular contains the files for compiling a program using this library.
@@ -80,7 +80,7 @@
 Section: libdevel
 Depends: ${misc:Depends},
  libosmo-pfcp0 (= ${binary:Version})
-Description: Development headers for libosmo-pfcp
+Description: Development files for libosmo-pfcp
  libosmo-pfcp implements decoding, encoding and endpoint implementation of the
  Packet Forwarding Control Protocol (3GPP TS 29.244). This package in 
particular
  contains the files for compiling a program using this library.

--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29051
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I380b1dd626b3e6a35f17ae09a6758bef59f51c84
Gerrit-Change-Number: 29051
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in libosmo-pfcp[master]: debian: add missing *-dev.install files

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29050 )


Change subject: debian: add missing *-dev.install files
..

debian: add missing *-dev.install files

Change-Id: I6b03624f3d93ad6b2551fb3ff673e7c7cb246f4c
---
A debian/libosmo-gtlv-dev.install
A debian/libosmo-pfcp-dev.install
2 files changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/50/29050/1

diff --git a/debian/libosmo-gtlv-dev.install b/debian/libosmo-gtlv-dev.install
new file mode 100644
index 000..ba5264b
--- /dev/null
+++ b/debian/libosmo-gtlv-dev.install
@@ -0,0 +1,5 @@
+usr/include/osmocom/gtlv
+usr/lib/*/libosmo-gtlv*.a
+usr/lib/*/libosmo-gtlv*.so
+usr/lib/*/libosmo-gtlv*.la
+usr/lib/*/pkgconfig/libosmo-gtlv.pc
diff --git a/debian/libosmo-pfcp-dev.install b/debian/libosmo-pfcp-dev.install
new file mode 100644
index 000..1b40eab
--- /dev/null
+++ b/debian/libosmo-pfcp-dev.install
@@ -0,0 +1,5 @@
+usr/include/osmocom/pfcp
+usr/lib/*/libosmo-pfcp*.a
+usr/lib/*/libosmo-pfcp*.so
+usr/lib/*/libosmo-pfcp*.la
+usr/lib/*/pkgconfig/libosmo-pfcp.pc

--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29050
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I6b03624f3d93ad6b2551fb3ff673e7c7cb246f4c
Gerrit-Change-Number: 29050
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in libosmo-pfcp[master]: RPM: fix .spec file

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29049 )


Change subject: RPM: fix .spec file
..

RPM: fix .spec file

Change-Id: Ie2fa0770b94af8637483434068b7c0df4b4272c6
---
M configure.ac
M contrib/libosmo-pfcp.spec.in
2 files changed, 77 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/49/29049/1

diff --git a/configure.ac b/configure.ac
index f146c20..446f0b1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -86,6 +86,7 @@
 AC_CONFIG_FILES([
 libosmo-gtlv.pc
 libosmo-pfcp.pc
+contrib/libosmo-pfcp.spec
 include/Makefile
 include/osmocom/Makefile
 include/osmocom/gtlv/Makefile
diff --git a/contrib/libosmo-pfcp.spec.in b/contrib/libosmo-pfcp.spec.in
index d3cf821..9e2c06a 100644
--- a/contrib/libosmo-pfcp.spec.in
+++ b/contrib/libosmo-pfcp.spec.in
@@ -12,12 +12,58 @@
 BuildRequires:  lksctp-tools-devel
 BuildRequires:  pkgconfig >= 0.20
 BuildRequires:  pkgconfig(libosmocore) >= 1.6.0
-BuildRequires:  pkgconfig(libosmoctrl) >= 1.6.0
-BuildRequires:  pkgconfig(libosmovty) >= 1.6.0
 BuildRequires:  pkgconfig(talloc)

 %description
-libosmo-pfcp: PFCP protocol encoding and decoding, and generic PFCP endpoint 
implementation
+Description: Osmocom PFCP protocol implementation (metapackage)
+
+Install Osmocom PFCP and generic TLV protocol libraries.
+libosmo-gtlv and libosmo-pfcp
+
+
+%package -n libosmo-gtlv0
+Summary:Generic TLV and TLIV protocol support
+License:GPL-2.0-or-later AND AGPL-3.0-or-later
+Group:  System/Libraries
+
+%description -n libosmo-gtlv0
+Decoding, encoding and logging of protocols using a Tag-Length-Value and/or
+Tag-Length-Instance-Value structure.
+
+
+%package -n libosmo-gtlv-devel
+Summary:Development files for libosmo-pfcp
+License:GPL-2.0-or-later
+Group:  Development/Libraries/C and C++
+Requires:   libosmo-gtlv0 = %{version}
+
+%description -n libosmo-gtlv-devel
+libosmo-pfcp implements decoding, encoding and endpoint implementation of the
+Packet Forwarding Control Protocol (3GPP TS 29.244). This package in particular
+contains the files for compiling a program using this library.
+
+
+%package -n libosmo-pfcp0
+Summary:PFCP protocol support
+License:GPL-2.0-or-later AND AGPL-3.0-or-later
+Group:  System/Libraries
+
+%description -n libosmo-pfcp0
+PFCP protocol support: Decoding, encoding and endpoint implementation of the
+Packet Forwarding Control Protocol (3GPP TS 29.244).
+
+
+%package -n libosmo-pfcp-devel
+Summary:Development files for libosmo-pfcp
+License:GPL-2.0-or-later
+Group:  Development/Libraries/C and C++
+Requires:   libosmo-pfcp0 = %{version}
+
+%description -n libosmo-pfcp-devel
+libosmo-pfcp implements decoding, encoding and endpoint implementation of the
+Packet Forwarding Control Protocol (3GPP TS 29.244). This package in particular
+contains the files for compiling a program using this library.
+

 %prep
 %setup -q
@@ -30,13 +76,36 @@

 %install
 %make_install
+find %{buildroot} -type f -name "*.la" -delete -print

 %check
 make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +)

-%files
-%license COPYING
-%doc AUTHORS README.md
-%{_bindir}/libosmo-pfcp
+%post   -n libosmo-gtlv0 -p /sbin/ldconfig
+%postun -n libosmo-gtlv0 -p /sbin/ldconfig
+%post   -n libosmo-pfcp0 -p /sbin/ldconfig
+%postun -n libosmo-pfcp0 -p /sbin/ldconfig
+
+%files -n libosmo-gtlv0
+%{_libdir}/libosmo-gltv.so.0*
+
+%files -n libosmo-gtlv-devel
+%dir %{_includedir}/%{name}
+%dir %{_includedir}/%{name}/osmocom
+%{_includedir}/%{name}/osmocom/gtlv
+%{_libdir}/libosmo-gtlv.so
+%{_libdir}/libosmo-gtlv.a
+%{_libdir}/pkgconfig/libosmo-gtlv.pc
+
+%files -n libosmo-pfcp0
+%{_libdir}/libosmo-pfcp.so.0*
+
+%files -n libosmo-pfcp-devel
+%dir %{_includedir}/%{name}
+%dir %{_includedir}/%{name}/osmocom
+%{_includedir}/%{name}/osmocom/pfcp
+%{_libdir}/libosmo-pfcp.so
+%{_libdir}/libosmo-pfcp.a
+%{_libdir}/pkgconfig/libosmo-pfcp.pc

 %changelog

--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29049
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Ie2fa0770b94af8637483434068b7c0df4b4272c6
Gerrit-Change-Number: 29049
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in libosmo-pfcp[master]: debian: fix missing dep gtlv0 <- pfcp0

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29052 )


Change subject: debian: fix missing dep gtlv0 <- pfcp0
..

debian: fix missing dep gtlv0 <- pfcp0

Change-Id: I8af60305543b06b74859e83b840b171d29af1abd
---
M debian/control
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/52/29052/1

diff --git a/debian/control b/debian/control
index ca7eaa6..c5d9f04 100644
--- a/debian/control
+++ b/debian/control
@@ -68,7 +68,8 @@
 Architecture: any
 Multi-Arch: same
 Depends: ${shlibs:Depends},
- ${misc:Depends}
+ ${misc:Depends},
+ libosmo-gtlv0 (= ${binary:Version})
 Pre-Depends: ${misc:Pre-Depends}
 Description: PFCP protocol support
  Decoding, encoding and endpoint implementation of the Packet Forwarding 
Control Protocol
@@ -79,7 +80,8 @@
 Multi-Arch: same
 Section: libdevel
 Depends: ${misc:Depends},
- libosmo-pfcp0 (= ${binary:Version})
+ libosmo-pfcp0 (= ${binary:Version}),
+ libosmo-gtlv-dev (= ${binary:Version})
 Description: Development files for libosmo-pfcp
  libosmo-pfcp implements decoding, encoding and endpoint implementation of the
  Packet Forwarding Control Protocol (3GPP TS 29.244). This package in 
particular

--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29052
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I8af60305543b06b74859e83b840b171d29af1abd
Gerrit-Change-Number: 29052
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Build failure of network:osmocom:nightly/open5gs in Raspbian_10/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Raspbian_10/armv7l

Package network:osmocom:nightly/open5gs failed to build in Raspbian_10/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly open5gs

Last lines of build log:
[  668s] ../src/sgwc/context.c: In function ‘sgwc_tunnel_add’:
[  668s] ../src/sgwc/context.c:719:17: warning: ‘dst_if’ may be used 
uninitialized in this function [-Wmaybe-uninitialized]
[  668s]  far->dst_if = dst_if;
[  668s]  ^~~~
[  668s] ../src/sgwc/context.c:710:17: warning: ‘src_if’ may be used 
uninitialized in this function [-Wmaybe-uninitialized]
[  668s]  pdr->src_if = src_if;
[  668s]  ^~~~
[  668s] [2808/3254] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi 
-Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION  -MD -MQ 'lib/sbi/9848b6c@@ogssbi@sha/client.c.o' -MF 
'lib/sbi/9848b6c@@ogssbi@sha/client.c.o.d' -o 
'lib/sbi/9848b6c@@ogssbi@sha/client.c.o' -c ../lib/sbi/client.c
[  668s] FAILED: lib/sbi/9848b6c@@ogssbi@sha/client.c.o 
[  668s] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib -I../lib 
-Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app -I../lib/app 
-Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION  -MD -MQ 'lib/sbi/9848b6c@@ogssbi@sha/client.c.o' -MF 
'lib/sbi/9848b6c@@ogssbi@sha/client.c.o.d' -o 
'lib/sbi/9848b6c@@ogssbi@sha/client.c.o' -c ../lib/sbi/client.c
[  668s] In file included from 
/usr/include/arm-linux-gnueabihf/curl/curl.h:2826,
[  668s]  from ../lib/sbi/client.c:23:
[  668s] ../lib/sbi/client.c: In function ‘ogs_sbi_client_add’:
[  668s] ../lib/sbi/client.c:121:30: error: ‘CURLMOPT_MAX_CONCURRENT_STREAMS’ 
undeclared (first use in this function); did you mean ‘CURLMOPT_MAXCONNECTS’?
[  668s]  curl_multi_setopt(multi, CURLMOPT_MAX_CONCURRENT_STREAMS,
[  668s]   ^~~
[  668s] ../lib/sbi/client.c:121:30: note: each undeclared identifier is 
reported only once for each function it appears in
[  669s] [2809/3254] cc -Isrc/hss/73a2c7a@@hss@sta -Isrc/hss -I../src/hss 
-Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt 
-I../lib/crypt -Ilib/dbi -I../lib/dbi -Ilib/diameter/s6a -I../lib/diameter/s6a 
-Ilib/diameter/common -I../lib/diameter/common 
-Isubprojects/freeDiameter/include -I../subprojects/freeDiameter/include 
-Isubprojects/freeDiameter -I../subprojects/freeDiameter -Ilib/diameter/cx 
-I../lib/diameter/cx -Ilib/diameter/swx -I../lib/diameter/swx 
-I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 
-fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra 
-Wlogical-op -Werror=missing-include-dirs 

Change in osmo-ttcn3-hacks[master]: msc: f_tc_mt_t310: detect MNCC failure explicitly

[neels]

neels has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971 )

Change subject: msc: f_tc_mt_t310: detect MNCC failure explicitly
..

msc: f_tc_mt_t310: detect MNCC failure explicitly

Helped me find a failure cause: instead of T_guard timeout, immediately
show an unexpected MNCC event.

Related: SYS#5066
Change-Id: I49a15142a4b6c51ca767a884c0574f96e01d7cb1
---
M msc/MSC_Tests.ttcn
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  neels: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index d6e0aba..e6d270d 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -1804,6 +1804,7 @@
 * the MSC would stop T310.  However, the idea is to verify T310 
expiration
 * here, so grab some popcorn and wait for MNCC DISC.ind. */
T310.start(30.0 + 2.0);
+   var MNCC_PDU mncc_rx;
alt {
[] T310.timeout {
setverdict(fail, "Timeout waiting for MNCC DISC.ind due to 
T310");
@@ -1814,6 +1815,11 @@
log("Rx MNCC DISC.ind, T310.read yelds ", T310.read);
setverdict(pass);
}
+   [] MNCC.receive(MNCC_PDU:?) -> value mncc_rx {
+   log("Rx ", mncc_rx);
+   setverdict(fail, "Expected MNCC DISC.ind, got some other MNCC 
message instead");
+   mtc.stop;
+   }
}

BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_CC_DISC(cpars.transaction_id)));

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I49a15142a4b6c51ca767a884c0574f96e01d7cb1
Gerrit-Change-Number: 28971
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-ttcn3-hacks[master]: msc: f_tc_mt_t310: allow CRCX in either order

[neels]

neels has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29024 )

Change subject: msc: f_tc_mt_t310: allow CRCX in either order
..

msc: f_tc_mt_t310: allow CRCX in either order

continued from Id0c98bc267daff352fc7db7712f967111970fd4d

Upcoming changes to osmo-msc move the CN side CRCX to an earlier point
in time, reversing that order. Introduce an 'interleave' to not care
about the ordering of MGCP and BSSAP messages.

Related: SYS#5066
Related: Ie433db1ba0c46d4b97538a969233c155cefac21c (osmo-msc)
Change-Id: I0ec348df08aa49ed58b3465de51b259fb74c0aea
---
M msc/MSC_Tests.ttcn
1 file changed, 18 insertions(+), 12 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  daniel: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 79221d7..d6e0aba 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -1771,25 +1771,31 @@

/* NOTE: MSC is expected to start T310 here */

+   interleave {
/* MSC->MGW: CRCX (first) */
-   MGCP.receive(tr_CRCX) -> value mgcp_cmd;
-   f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */
+   [] MGCP.receive(tr_CRCX) -> value mgcp_cmd {
+   f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */
+   }

/* BSC->BSC: BSSMAP ASSIGNMENT REQ */
-   BSSAP.receive(tr_BSSMAP_AssignmentReq(omit, ?)) -> value bssap;
-   BSSAP.send(ts_BSSMAP_AssignmentComplete(omit,
-   aoip := f_ts_BSSMAP_IE_AoIP_TLA(cpars.bss_rtp_ip, 
cpars.bss_rtp_port),
-   speechCodec := ts_BSSMAP_IE_SpeechCodec({ ts_CodecFR })));
+   [] BSSAP.receive(tr_BSSMAP_AssignmentReq(omit, ?)) -> value bssap {
+   BSSAP.send(ts_BSSMAP_AssignmentComplete(omit,
+   aoip := f_ts_BSSMAP_IE_AoIP_TLA(cpars.bss_rtp_ip, 
cpars.bss_rtp_port),
+   speechCodec := ts_BSSMAP_IE_SpeechCodec({ ts_CodecFR 
})));
+   }

/* MSC->MGW: MDCX */
-   MGCP.receive(tr_MDCX) -> value mgcp_cmd;
-   MGCP.send(ts_MDCX_ACK(mgcp_cmd.line.trans_id, 
cpars.mgw_conn_1.mgcp_connection_id,
-   sdp := omit));
+   [] MGCP.receive(tr_MDCX) -> value mgcp_cmd {
+   MGCP.send(ts_MDCX_ACK(mgcp_cmd.line.trans_id, 
cpars.mgw_conn_1.mgcp_connection_id,
+   sdp := omit));
+   }

/* MSC->MGW: CRCX (second) */
-   MGCP.receive(tr_CRCX) -> value mgcp_cmd;
-   f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */
-   MNCC.receive(tr_MNCC_RTP_CREATE(cpars.mncc_callref));
+   [] MGCP.receive(tr_CRCX) -> value mgcp_cmd {
+   f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */
+   MNCC.receive(tr_MNCC_RTP_CREATE(cpars.mncc_callref));
+   }
+   }

/* Reschedule the guard timeout */
g_Tguard.start(30.0 + 10.0);

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29024
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0ec348df08aa49ed58b3465de51b259fb74c0aea
Gerrit-Change-Number: 29024
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-MessageType: merged

Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly open5gs

Last lines of build log:
[  168s] cc  -Ilib/sbi/ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib -I../lib 
-Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app -I../lib/app 
-Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/x86_64-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION -MD -MQ 'lib/sbi/ogssbi@sha/client.c.o' -MF 
'lib/sbi/ogssbi@sha/client.c.o.d' -o 'lib/sbi/ogssbi@sha/client.c.o' -c 
../lib/sbi/client.c
[  168s] In file included from /usr/include/x86_64-linux-gnu/curl/curl.h:2738:0,
[  168s]  from ../lib/sbi/client.c:23:
[  168s] ../lib/sbi/client.c: In function ‘ogs_sbi_client_add’:
[  168s] ../lib/sbi/client.c:121:30: error: ‘CURLMOPT_MAX_CONCURRENT_STREAMS’ 
undeclared (first use in this function); did you mean ‘CURLMOPT_MAXCONNECTS’?
[  168s]  curl_multi_setopt(multi, CURLMOPT_MAX_CONCURRENT_STREAMS,
[  168s]   ^
[  168s] ../lib/sbi/client.c:121:30: note: each undeclared identifier is 
reported only once for each function it appears in
[  168s] [2802/3254] cc  -Ilib/sbi/ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib 
-I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/x86_64-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION -MD -MQ 'lib/sbi/ogssbi@sha/nghttp2-server.c.o' -MF 
'lib/sbi/ogssbi@sha/nghttp2-server.c.o.d' -o 
'lib/sbi/ogssbi@sha/nghttp2-server.c.o' -c ../lib/sbi/nghttp2-server.c
[  168s] [2803/3254] cc  -Isrc/hss/hss@sta -Isrc/hss -I../src/hss -Ilib/app 
-I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt 
-Ilib/dbi -I../lib/dbi -Ilib/diameter/s6a -I../lib/diameter/s6a 
-Ilib/diameter/common -I../lib/diameter/common -Isubprojects/freeDiameter 
-I../subprojects/freeDiameter -Isubprojects/freeDiameter/include 
-I../subprojects/freeDiameter/include -Ilib/diameter/cx -I../lib/diameter/cx 
-Ilib/diameter/swx -I../lib/diameter/swx -I/usr/include/libmongoc-1.0 
-I/usr/include/libbson-1.0 -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 

Build failure of network:osmocom:nightly/open5gs in Debian_10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/x86_64

Package network:osmocom:nightly/open5gs failed to build in Debian_10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly open5gs

Last lines of build log:
[  185s] [2779/3254] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi 
-Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/x86_64-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION  -MD -MQ 
'lib/sbi/9848b6c@@ogssbi@sha/custom_ue_authentication_ctx.c.o' -MF 
'lib/sbi/9848b6c@@ogssbi@sha/custom_ue_authentication_ctx.c.o.d' -o 
'lib/sbi/9848b6c@@ogssbi@sha/custom_ue_authentication_ctx.c.o' -c 
../lib/sbi/custom/ue_authentication_ctx.c
[  185s] [2780/3254] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi 
-Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/x86_64-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION  -MD -MQ 'lib/sbi/9848b6c@@ogssbi@sha/client.c.o' -MF 
'lib/sbi/9848b6c@@ogssbi@sha/client.c.o.d' -o 
'lib/sbi/9848b6c@@ogssbi@sha/client.c.o' -c ../lib/sbi/client.c
[  185s] FAILED: lib/sbi/9848b6c@@ogssbi@sha/client.c.o 
[  185s] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib -I../lib 
-Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app -I../lib/app 
-Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/x86_64-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION  -MD -MQ 'lib/sbi/9848b6c@@ogssbi@sha/client.c.o' -MF 
'lib/sbi/9848b6c@@ogssbi@sha/client.c.o.d' -o 
'lib/sbi/9848b6c@@ogssbi@sha/client.c.o' -c ../lib/sbi/client.c
[  185s] In file included from /usr/include/x86_64-linux-gnu/curl/curl.h:2826,
[  185s]  from ../lib/sbi/client.c:23:
[  185s] ../lib/sbi/client.c: In function ‘ogs_sbi_client_add’:
[  185s] ../lib/sbi/client.c:121:30: 

Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.04/i586

Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly open5gs

Last lines of build log:
[  206s]  from ../lib/sbi/client.c:23:
[  206s] ../lib/sbi/client.c: In function ‘ogs_sbi_client_add’:
[  206s] ../lib/sbi/client.c:121:30: error: ‘CURLMOPT_MAX_CONCURRENT_STREAMS’ 
undeclared (first use in this function); did you mean ‘CURLMOPT_MAXCONNECTS’?
[  206s]  curl_multi_setopt(multi, CURLMOPT_MAX_CONCURRENT_STREAMS,
[  206s]   ^
[  206s] ../lib/sbi/client.c:121:30: note: each undeclared identifier is 
reported only once for each function it appears in
[  206s] [2777/3254] cc  -Ilib/sbi/ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib 
-I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION -MD -MQ 'lib/sbi/ogssbi@sha/server.c.o' -MF 
'lib/sbi/ogssbi@sha/server.c.o.d' -o 'lib/sbi/ogssbi@sha/server.c.o' -c 
../lib/sbi/server.c
[  206s] [2778/3254] cc  -Ilib/sbi/ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib 
-I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION -MD -MQ 'lib/sbi/ogssbi@sha/mhd-server.c.o' -MF 
'lib/sbi/ogssbi@sha/mhd-server.c.o.d' -o 'lib/sbi/ogssbi@sha/mhd-server.c.o' -c 
../lib/sbi/mhd-server.c
[  206s] [2779/3254] cc  -Ilib/sbi/ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib 
-I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION -MD -MQ 'lib/sbi/ogssbi@sha/nnrf-build.c.o' -MF 
'lib/sbi/ogssbi@sha/nnrf-build.c.o.d' -o 

Build failure of network:osmocom:nightly/open5gs in Debian_10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/i586

Package network:osmocom:nightly/open5gs failed to build in Debian_10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly open5gs

Last lines of build log:
[  214s]  (long long)triggeringMessage);
[  214s]  ^
[  214s] ../lib/core/ogs-log.h:45:8: note: in definition of macro 
‘ogs_log_message’
[  214s]  0, __VA_ARGS__)
[  214s] ^~~
[  214s] ../src/mme/s1ap-handler.c:1265:13: note: in expansion of macro 
‘ogs_debug’
[  214s]  ogs_debug("triggeringMessage: %lld",
[  214s]  ^
[  214s] ../src/mme/s1ap-handler.c:1270:21: warning: cast from pointer to 
integer of different size [-Wpointer-to-int-cast]
[  214s]  (long long)procedureCriticality);
[  214s]  ^
[  214s] ../lib/core/ogs-log.h:45:8: note: in definition of macro 
‘ogs_log_message’
[  214s]  0, __VA_ARGS__)
[  214s] ^~~
[  214s] ../src/mme/s1ap-handler.c:1269:13: note: in expansion of macro 
‘ogs_debug’
[  214s]  ogs_debug("procedureCriticality: %lld",
[  214s]  ^
[  215s] [2784/3254] cc -Isrc/mme/e6d01c5@@mme@sta -Isrc/mme -I../src/mme 
-Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/metrics 
-I../lib/metrics -Ilib/sctp -I../lib/sctp -Ilib/s1ap -I../lib/s1ap 
-Ilib/asn1c/s1ap -I../lib/asn1c/s1ap -Ilib/asn1c/common -I../lib/asn1c/common 
-Ilib/asn1c/util -I../lib/asn1c/util -Ilib/nas/eps -I../lib/nas/eps 
-Ilib/nas/common -I../lib/nas/common -Ilib/crypt -I../lib/crypt 
-Ilib/diameter/s6a -I../lib/diameter/s6a -Ilib/diameter/common 
-I../lib/diameter/common -Isubprojects/freeDiameter/include 
-I../subprojects/freeDiameter/include -Isubprojects/freeDiameter 
-I../subprojects/freeDiameter -Ilib/gtp -I../lib/gtp -fdiagnostics-color=always 
-pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread  -MD -MQ 
'src/mme/e6d01c5@@mme@sta/mme-context.c.o' -MF 
'src/mme/e6d01c5@@mme@sta/mme-context.c.o.d' -o 
'src/mme/e6d01c5@@mme@sta/mme-context.c.o' -c ../src/mme/mme-context.c
[  215s] ninja: build stopped: subcommand failed.
[  215s] dh_auto_build: cd obj-i686-linux-gnu && LC_ALL=C.UTF-8 ninja -j8 -v 
returned exit code 1
[  215s] make: *** [debian/rules:11: binary] Error 1
[  215s] dpkg-buildpackage: error: debian/rules binary subprocess returned exit 
status 2
[  215s] ### VM INTERACTION START ###
[  215s] [  203.383455][T1] sysrq: Power Off
[  215s] [  203.386417][   T16] reboot: Power down
[  215s] ### VM INTERACTION END ###
[  215s] 
[  215s] lamb20 failed "build open5gs_2.4.9.14.ec9fe.202208120052.dsc" at Fri 
Aug 12 01:16:16 UTC 2022.
[  215s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/open5gs in Debian_10/aarch64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/aarch64

Package network:osmocom:nightly/open5gs failed to build in Debian_10/aarch64

Check out the package for editing:
  osc checkout network:osmocom:nightly open5gs

Last lines of build log:
[  171s] [2775/3254] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi 
-Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/aarch64-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION  -MD -MQ 'lib/sbi/9848b6c@@ogssbi@sha/custom_links.c.o' 
-MF 'lib/sbi/9848b6c@@ogssbi@sha/custom_links.c.o.d' -o 
'lib/sbi/9848b6c@@ogssbi@sha/custom_links.c.o' -c ../lib/sbi/custom/links.c
[  171s] [2776/3254] cc -Isrc/mme/e6d01c5@@mme@sta -Isrc/mme -I../src/mme 
-Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/metrics 
-I../lib/metrics -Ilib/sctp -I../lib/sctp -Ilib/s1ap -I../lib/s1ap 
-Ilib/asn1c/s1ap -I../lib/asn1c/s1ap -Ilib/asn1c/common -I../lib/asn1c/common 
-Ilib/asn1c/util -I../lib/asn1c/util -Ilib/nas/eps -I../lib/nas/eps 
-Ilib/nas/common -I../lib/nas/common -Ilib/crypt -I../lib/crypt 
-Ilib/diameter/s6a -I../lib/diameter/s6a -Ilib/diameter/common 
-I../lib/diameter/common -Isubprojects/freeDiameter/include 
-I../subprojects/freeDiameter/include -Isubprojects/freeDiameter 
-I../subprojects/freeDiameter -Ilib/gtp -I../lib/gtp -fdiagnostics-color=always 
-pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread  -MD -MQ 
'src/mme/e6d01c5@@mme@sta/mme-event.c.o' -MF 
'src/mme/e6d01c5@@mme@sta/mme-event.c.o.d' -o 
'src/mme/e6d01c5@@mme@sta/mme-event.c.o' -c ../src/mme/mme-event.c
[  171s] [2777/3254] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi 
-Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app 
-I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 
-I/usr/include/aarch64-linux-gnu -fdiagnostics-color=always -pipe 
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op 
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self 
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes 
-Werror=missing-declarations -Werror=implicit-function-declaration 
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels 
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow 
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time 
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation 
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option 
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 
-ffunction-sections -fdata-sections -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread 
-DOGS_SBI_COMPILATION  -MD -MQ 'lib/sbi/9848b6c@@ogssbi@sha/conv.c.o' -MF 
'lib/sbi/9848b6c@@ogssbi@sha/conv.c.o.d' -o 

Change in osmo-ci[master]: obs: add libosmo-pfcp, osmo-upf

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/29047 )


Change subject: obs: add libosmo-pfcp, osmo-upf
..

obs: add libosmo-pfcp, osmo-upf

Change-Id: I7192f4c9e77035cebb147b8186296bcd741d419b
---
M scripts/obs/lib/config.py
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/47/29047/1

diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py
index a4a10c5..997fff2 100644
--- a/scripts/obs/lib/config.py
+++ b/scripts/obs/lib/config.py
@@ -44,6 +44,7 @@
 "libosmo-abis",
 "libosmo-dsp",
 "libosmo-netif",
+"libosmo-pfcp",
 "libosmo-sccp",
 "libosmocore",
 "libsmpp34",
@@ -72,6 +73,7 @@
 "osmo-sysmon",
 "osmo-trx",
 "osmo-uecups",
+"osmo-upf",
 "python/osmo-python-tests",
 "rtl-sdr",
 "simtrace2",

--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29047
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I7192f4c9e77035cebb147b8186296bcd741d419b
Gerrit-Change-Number: 29047
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in osmo-bts[master]: Use libosmocore API msgb_queue_free() to free lists

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29035 )

Change subject: Use libosmocore API msgb_queue_free() to free lists
..

Use libosmocore API msgb_queue_free() to free lists

There's no need to maintain a duplicate msgb_queue_flush(), which
returns the amount of freed messages (feature not used at all by the
callers).

Change-Id: I9841e18ca0b7b852130bbb02a510e43a3b3fd93f
---
M include/osmo-bts/rsl.h
M src/common/lchan.c
M src/common/rsl.c
M src/common/scheduler.c
4 files changed, 2 insertions(+), 17 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/include/osmo-bts/rsl.h b/include/osmo-bts/rsl.h
index dcd476c..a530734 100644
--- a/include/osmo-bts/rsl.h
+++ b/include/osmo-bts/rsl.h
@@ -4,8 +4,6 @@
 #define LCHAN_FN_DUMMY 0x
 #define LCHAN_FN_WAIT 0xFFFE

-int msgb_queue_flush(struct llist_head *list);
-
 int down_rsl(struct gsm_bts_trx *trx, struct msgb *msg);
 int rsl_tx_rf_res(struct gsm_bts_trx *trx);
 int rsl_tx_chan_rqd(struct gsm_bts_trx *trx, struct gsm_time *gtime,
diff --git a/src/common/lchan.c b/src/common/lchan.c
index 83d20da..c7d8d45 100644
--- a/src/common/lchan.c
+++ b/src/common/lchan.c
@@ -638,6 +638,6 @@
 {
osmo_rtp_socket_free(lchan->abis_ip.rtp_socket);
lchan->abis_ip.rtp_socket = NULL;
-   msgb_queue_flush(>dl_tch_queue);
+   msgb_queue_free(>dl_tch_queue);
lchan->dl_tch_queue_len = 0;
 }
diff --git a/src/common/rsl.c b/src/common/rsl.c
index bcbe27c..8cdb662 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -88,19 +88,6 @@
 }
 #define OSMO_IN_ARRAY(search, arr) osmo_in_array(search, arr, ARRAY_SIZE(arr))

-int msgb_queue_flush(struct llist_head *list)
-{
-   struct msgb *msg, *msg2;
-   int count = 0;
-
-   llist_for_each_entry_safe(msg, msg2, list, list) {
-   msgb_free(msg);
-   count++;
-   }
-
-   return count;
-}
-
 /* FIXME: move this to libosmocore */
 void gsm48_gen_starting_time(uint8_t *out, struct gsm_time *gtime)
 {
diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 6564e5a..14aff34 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -659,7 +659,7 @@
struct l1sched_ts *l1ts = ts->priv;
unsigned int i;

-   msgb_queue_flush(>dl_prims);
+   msgb_queue_free(>dl_prims);
rate_ctr_group_free(l1ts->ctrs);
l1ts->ctrs = NULL;




1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29035
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I9841e18ca0b7b852130bbb02a510e43a3b3fd93f
Gerrit-Change-Number: 29035
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bts[master]: Avoid counting lchan->dl_tch_queue length every time a msg is enqueued

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29034 )

Change subject: Avoid counting lchan->dl_tch_queue length every time a msg is 
enqueued
..

Avoid counting lchan->dl_tch_queue length every time a msg is enqueued

The queue_limit_to method iterates the entire list of messages every
time a new message is added. Let's use msgb_{enqueue,dequeue}_count()
APIs to do that in constant time. It is true that since the queue is
limited to 1, there's usually at most 1 item in the queue so it's not a
real problem. However, when we add Osmux in the future, we may need to
tweak the amount of messages which can be in the list, due to Osmux
batching mechansim which may be more bursty sometimes.
In any case, this change doesn't make things worse for sure.

The patch also takes the chance to group the queue_limit_to + enqueue
into one function to avoid having the code spread several times.

Change-Id: I61818a3bb521c27bd21a8b6fa70581d27638ec9b
---
M include/osmo-bts/lchan.h
M src/common/l1sap.c
M src/common/lchan.c
3 files changed, 16 insertions(+), 19 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/include/osmo-bts/lchan.h b/include/osmo-bts/lchan.h
index c86acb0..64b7efa 100644
--- a/include/osmo-bts/lchan.h
+++ b/include/osmo-bts/lchan.h
@@ -191,6 +191,7 @@
uint8_t sapis_ul[23];
struct lapdm_channel lapdm_ch;
struct llist_head dl_tch_queue;
+   unsigned int dl_tch_queue_len;
struct {
/* bitmask of all SI that are present/valid in si_buf */
uint32_t valid;
diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index b74fd5a..640ff57 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -153,17 +153,16 @@
 }

 /*! limit number of queue entries to %u; drops any surplus messages */
-static void queue_limit_to(const char *prefix, struct llist_head *queue, 
unsigned int limit)
+static void lchan_dl_tch_queue_enqueue(struct gsm_lchan *lchan, struct msgb 
*msg, unsigned int limit)
 {
-   unsigned int count = llist_count(queue);
-
-   if (count > limit)
-   LOGP(DL1P, LOGL_NOTICE, "%s: freeing %d queued frames\n", 
prefix, count-limit);
-   while (count > limit) {
-   struct msgb *tmp = msgb_dequeue(queue);
+   if (lchan->dl_tch_queue_len > limit)
+   LOGPLCHAN(lchan, DL1P, LOGL_NOTICE, "freeing %d queued 
frames\n",
+ lchan->dl_tch_queue_len - limit);
+   while (lchan->dl_tch_queue_len > limit) {
+   struct msgb *tmp = msgb_dequeue_count(>dl_tch_queue, 
>dl_tch_queue_len);
msgb_free(tmp);
-   count--;
}
+   msgb_enqueue_count(>dl_tch_queue, msg, >dl_tch_queue_len);
 }

 /* allocate a msgb containing a osmo_phsap_prim + optional l2 data
@@ -915,7 +914,7 @@
uint8_t *p;

/* de-queue response message (loopback) */
-   loop_msg = msgb_dequeue(>dl_tch_queue);
+   loop_msg = msgb_dequeue_count(>dl_tch_queue, 
>dl_tch_queue_len);
if (!loop_msg) {
LOGPGT(DL1P, LOGL_NOTICE, tm, "%s: no looped PDTCH message, 
sending empty\n",
 gsm_lchan_name(lchan));
@@ -1305,7 +1304,7 @@
lchan->abis_ip.rtp_socket->rx_user_ts += GSM_RTP_DURATION;
}
/* get a msgb from the dl_tx_queue */
-   resp_msg = msgb_dequeue(>dl_tch_queue);
+   resp_msg = msgb_dequeue_count(>dl_tch_queue, 
>dl_tch_queue_len);
if (!resp_msg) {
DEBUGPGT(DL1P, _time, "%s DL TCH Tx queue underrun\n", 
gsm_lchan_name(lchan));
resp_l1sap = _l1sap;
@@ -1500,8 +1499,7 @@
/* we are in loopback mode (for BER testing)
 * mode and need to enqeue the frame to be
 * returned in downlink */
-   queue_limit_to(gsm_lchan_name(lchan), 
>dl_tch_queue, 1);
-   msgb_enqueue(>dl_tch_queue, msg);
+   lchan_dl_tch_queue_enqueue(lchan, msg, 1);

/* Return 1 to signal that we're still using msg
 * and it should not be freed */
@@ -1622,10 +1620,8 @@
msg->data, msg->len, fn_ms_adj(fn, lchan), 
lchan->rtp_tx_marker);
/* if loopback is enabled, also queue received RTP data */
if (lchan->loopback) {
-   /* make sure the queue doesn't get too long */
-   queue_limit_to(gsm_lchan_name(lchan), 
>dl_tch_queue, 1);
-   /* add new frame to queue */
-   msgb_enqueue(>dl_tch_queue, msg);
+   /* add new frame to queue, make sure the queue doesn't 
get too long */
+   lchan_dl_tch_queue_enqueue(lchan, msg, 1);
/* Return 1 to signal that 

Change in osmo-bts[master]: Avoid counting lchan->dl_tch_queue length every time a msg is enqueued

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29034 )

Change subject: Avoid counting lchan->dl_tch_queue length every time a msg is 
enqueued
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29034
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I61818a3bb521c27bd21a8b6fa70581d27638ec9b
Gerrit-Change-Number: 29034
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 21:21:31 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: Avoid counting lchan->dl_tch_queue length every time a msg is enqueued

[pespin]

Attention is currently required from: pespin.
Hello Jenkins Builder, laforge, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29034

to look at the new patch set (#3).

Change subject: Avoid counting lchan->dl_tch_queue length every time a msg is 
enqueued
..

Avoid counting lchan->dl_tch_queue length every time a msg is enqueued

The queue_limit_to method iterates the entire list of messages every
time a new message is added. Let's use msgb_{enqueue,dequeue}_count()
APIs to do that in constant time. It is true that since the queue is
limited to 1, there's usually at most 1 item in the queue so it's not a
real problem. However, when we add Osmux in the future, we may need to
tweak the amount of messages which can be in the list, due to Osmux
batching mechansim which may be more bursty sometimes.
In any case, this change doesn't make things worse for sure.

The patch also takes the chance to group the queue_limit_to + enqueue
into one function to avoid having the code spread several times.

Change-Id: I61818a3bb521c27bd21a8b6fa70581d27638ec9b
---
M include/osmo-bts/lchan.h
M src/common/l1sap.c
M src/common/lchan.c
3 files changed, 16 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/34/29034/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29034
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I61818a3bb521c27bd21a8b6fa70581d27638ec9b
Gerrit-Change-Number: 29034
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

Build failed in Jenkins: master-osmo-opencm3-projects » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #95

[jenkins]

See 


Changes:


--
Started by upstream project "master-osmo-opencm3-projects" build number 95
originally caused by:
 Started by user laforge
Running as SYSTEM
Building remotely on build2-deb9build-ansible (ttcn3 osmocom-gerrit-debian9 
osmocom-master-debian9 repo-install-test coverity) in workspace 

The recommended git tool is: NONE
No credentials specified
 > git rev-parse --resolve-git-dir 
 > 
 >  # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://git.osmocom.org/osmo-opencm3-projects # 
 > timeout=10
Fetching upstream changes from https://git.osmocom.org/osmo-opencm3-projects
 > git --version # timeout=10
 > git --version # 'git version 2.11.0'
 > git fetch --tags --progress -- https://git.osmocom.org/osmo-opencm3-projects 
 > +refs/heads/*:refs/remotes/origin/* # timeout=10
Checking out Revision cbff8e75d06b5e8ea9a196fa4fa706ba9f9ed124 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f cbff8e75d06b5e8ea9a196fa4fa706ba9f9ed124 # timeout=10
Commit message: "Make code compatible with picolibc >= 1.7.3"
First time build. Skipping changelog.
 > git remote # timeout=10
 > git submodule init # timeout=10
 > git submodule sync # timeout=10
 > git config --get remote.origin.url # timeout=10
 > git submodule init # timeout=10
 > git config -f .gitmodules --get-regexp ^submodule\.(.+)\.url # timeout=10
 > git config --get submodule.libopencm3.url # timeout=10
 > git config -f .gitmodules --get submodule.libopencm3.path # timeout=10
 > git config --get submodule.librfn.url # timeout=10
 > git config -f .gitmodules --get submodule.librfn.path # timeout=10
 > git submodule update --init --recursive libopencm3 # timeout=10
 > git submodule update --init --recursive librfn # timeout=10
[osmocom-master-debian9] $ /bin/sh -xe /tmp/jenkins7621413930550765280.sh
+ ARTIFACT_STORE=/home/osmocom-build/jenkins_build_artifact_store
+ mkdir -p /home/osmocom-build/jenkins_build_artifact_store
+ docker run --rm=true --cap-add SYS_PTRACE -e ARTIFACT_STORE=/artifact_store 
-e ASCIIDOC_WARNINGS_CHECK=1 -e HOME=/build -e 
JOB_NAME=master-osmo-opencm3-projects/a1=default,a2=default,a3=default,a4=default,label=osmocom-master-debian9
 -e MAKE=make -e OSMOPY_DEBUG_TCP_SOCKETS=1 -e 
OSMO_GSM_MANUALS_DIR=/opt/osmo-gsm-manuals -e PARALLEL_MAKE=-j 8 -e PUBLISH=1 
-e WITH_MANUALS=1 -w /build -i -u build -v 
:/build
 -v /home/osmocom-build/jenkins_build_artifact_store:/artifact_store -v 
/home/osmocom-build/.ssh:/home/build/.ssh:ro 
osmocom-build/debian-bullseye-jenkins /build/contrib/jenkins.sh --publish
=== relay-driver START  ==
  CLEAN
  CC  console.c
  CC  console_stm32.c
In file included from ../../libopencm3//include/libopencm3/cm3/nvic.h:147,
 from ../../librfn/librfn/libopencm3/console_stm32.c:24:
../../libopencm3//include/libopencm3/dispatch/nvic.h:8:11: fatal error: 
libopencm3/stm32/f1/nvic.h: No such file or directory
 # include 
   ^~~~
compilation terminated.
make: *** [../../mk/libopencm3.mk:228: console_stm32.o] Error 1
Build step 'Execute shell' marked build as failure

Change in osmo-ttcn3-hacks[master]: deps: use titan.TestPorts.UDPasp from ECLIPSEGITLAB_REPOS

[fixeria]

fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29046 )


Change subject: deps: use titan.TestPorts.UDPasp from ECLIPSEGITLAB_REPOS
..

deps: use titan.TestPorts.UDPasp from ECLIPSEGITLAB_REPOS

This change basically reverts [1].  Oliver's patch allowing to set
SO_REUSEADDR, which is needed for D-GSM mslookup mDNS testing, has
been merged upstream.  No need to depend on our own fork anymore.

Change-Id: Idf96a64f3d5f7928ed0fb81f4a91e469df3a9adc
Related: [1] Ie7e1c3dbd67dba9079a5768e442faffc936fd7fa
Related: SYS#4618
---
M deps/Makefile
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/46/29046/1

diff --git a/deps/Makefile b/deps/Makefile
index 2a906eb..2367f97 100644
--- a/deps/Makefile
+++ b/deps/Makefile
@@ -57,11 +57,11 @@
titan.TestPorts.SIPmsg \
titan.TestPorts.TELNETasp \
titan.TestPorts.TCPasp \
+   titan.TestPorts.UDPasp \
titan.TestPorts.UNIX_DOMAIN_SOCKETasp

 OSMOGITHUB_REPOS=  titan.TestPorts.SCTPasp \
titan.TestPorts.MTP3asp \
-   titan.TestPorts.UDPasp \
titan.ProtocolEmulations.SCCP \
titan.ProtocolModules.BSSGP_v13.0.0

@@ -124,7 +124,7 @@
 titan.TestPorts.SIPmsg_commit= R.15.A-1-ge4f9dd0
 titan.TestPorts.TCPasp_commit= R.9.A-5-g2c91bc6
 titan.TestPorts.TELNETasp_commit=  
873fe539642542cd9a901c208f1ec11c6d2f5387
-titan.TestPorts.UDPasp_commit= 
c20d77a34f288dd70dd4aaa30e520778876e9336
+titan.TestPorts.UDPasp_commit= 
54176e95850654e5e8b0ffa2f1b5f35c412b949c
 titan.TestPorts.UNIX_DOMAIN_SOCKETasp_commit=  R.2.A-13-gd34ab71
 titan.TestPorts.USB_commit=
a9470fdc99c82fbf988f4508c3161118c9106e28
 osmo-uecups_commit=
8362efef7c6fa341eb947a75786878e0685767b7

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29046
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idf96a64f3d5f7928ed0fb81f4a91e469df3a9adc
Gerrit-Change-Number: 29046
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange

Change in osmo-bts[master]: Move lchan_dl_tch_queue_enqueue to lchan.c and make it public

[fixeria]

Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29045 )

Change subject: Move lchan_dl_tch_queue_enqueue to lchan.c and make it public
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29045
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie7fa57bb04db9ad9b03971467e12ee7b8e4c190a
Gerrit-Change-Number: 29045
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: fixeria 
Gerrit-CC: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 19:18:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: Use libosmocore API msgb_queue_free() to free lists

[fixeria]

Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29035 )

Change subject: Use libosmocore API msgb_queue_free() to free lists
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29035
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I9841e18ca0b7b852130bbb02a510e43a3b3fd93f
Gerrit-Change-Number: 29035
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 19:16:10 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: Avoid counting lchan->dl_tch_queue length every time a msg is enqueued

[fixeria]

Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29034 )

Change subject: Avoid counting lchan->dl_tch_queue length every time a msg is 
enqueued
..


Patch Set 2: Code-Review+1

(1 comment)

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/29034/comment/bcc8b064_d4951524
PS2, Line 1502:
remove this space



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29034
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I61818a3bb521c27bd21a8b6fa70581d27638ec9b
Gerrit-Change-Number: 29034
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 19:15:38 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-upf[master]: GTP mockup: list active GTP endecaps actions

[laforge]

Attention is currently required from: neels, pespin, fixeria.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/28986 )

Change subject: GTP mockup: list active GTP endecaps actions
..


Patch Set 3:

(1 comment)

Patchset:

PS2:
> I personally see no reason for using the mockup stuff in the ttcn3 tests, and 
> hence no reason for th […]
I tend to agree with pespin's assessment.  We shouldn't have development/debug 
only features [enabled] in normal production builds.  Particularlly not if they 
make it look like some objects existed, while in reality they don't.  Looks 
like a huge source of potential user confusion.

Also, for the TTCN-3 tests, I think in general the goal should be to run the 
unmodified program just like in production, with all of its interfaces etc.

If for some reason we cannot do that in our existing normal jenkins slaves or 
docker containers, we can always use some kind of special slaves (we already do 
for example for testing the E1 / frame relay bits.

So I think if some testing/mocking is happening, it should happen on the tester 
(application, OS, VM, ...) side, and not inside the implementation-under-test.

VTY tests is a different special case, and we're not arguing about that here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28986
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752
Gerrit-Change-Number: 28986
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Thu, 11 Aug 2022 19:07:01 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-bts[master]: Split out lchan rtp socket creation from rsl handling code

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29032 )

Change subject: Split out lchan rtp socket creation from rsl handling code
..

Split out lchan rtp socket creation from rsl handling code

This makes the code more clear, as well as allows adding Osmux in the
future.

Change-Id: Iade43fde7f6113f9d68539f7d6cc9843783c2b3f
---
M include/osmo-bts/lchan.h
M src/common/lchan.c
M src/common/rsl.c
3 files changed, 143 insertions(+), 113 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  dexter: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/include/osmo-bts/lchan.h b/include/osmo-bts/lchan.h
index 90c28d9..c86acb0 100644
--- a/include/osmo-bts/lchan.h
+++ b/include/osmo-bts/lchan.h
@@ -2,6 +2,7 @@

 #include 
 #include 
+#include 

 #include 
 #include 
@@ -354,6 +355,10 @@

 void lchan_set_state(struct gsm_lchan *lchan, enum gsm_lchan_state state);

+int lchan_rtp_socket_create(struct gsm_lchan *lchan, const char *bind_ip);
+int lchan_rtp_socket_connect(struct gsm_lchan *lchan, const struct in_addr 
*ia, uint16_t connect_port);
+void lchan_rtp_socket_free(struct gsm_lchan *lchan);
+
 static inline bool lchan_is_dcch(const struct gsm_lchan *lchan)
 {
switch (lchan->type) {
diff --git a/src/common/lchan.c b/src/common/lchan.c
index fe5efd5..6f344e2 100644
--- a/src/common/lchan.c
+++ b/src/common/lchan.c
@@ -19,6 +19,8 @@
  *
  */

+#include "btsconfig.h" /* for PACKAGE_VERSION */
+
 #include 

 #include 
@@ -200,9 +202,7 @@
rsl_tx_ipac_dlcx_ind(lchan, RSL_ERR_NORMAL_UNSPEC);
osmo_rtp_socket_log_stats(lchan->abis_ip.rtp_socket, DRTP, 
LOGL_INFO,
"Closing RTP socket on Channel Release ");
-   osmo_rtp_socket_free(lchan->abis_ip.rtp_socket);
-   lchan->abis_ip.rtp_socket = NULL;
-   msgb_queue_flush(>dl_tch_queue);
+   lchan_rtp_socket_free(lchan);
}

/* FIXME: right now we allow creating the rtp_socket even if chan is not
@@ -510,3 +510,132 @@
return -1;
}
 }
+
+static int bind_rtp(struct gsm_bts *bts, struct osmo_rtp_socket *rs, const 
char *ip)
+{
+   int rc;
+   unsigned int i;
+   unsigned int tries;
+
+   tries = (bts->rtp_port_range_end - bts->rtp_port_range_start) / 2;
+   for (i = 0; i < tries; i++) {
+
+   if (bts->rtp_port_range_next >= bts->rtp_port_range_end)
+   bts->rtp_port_range_next = bts->rtp_port_range_start;
+
+   rc = osmo_rtp_socket_bind(rs, ip, bts->rtp_port_range_next);
+
+   bts->rtp_port_range_next += 2;
+
+   if (rc != 0)
+   continue;
+
+   if (bts->rtp_ip_dscp != -1) {
+   if (osmo_rtp_socket_set_dscp(rs, bts->rtp_ip_dscp))
+   LOGP(DRSL, LOGL_ERROR, "failed to set DSCP=%d: 
%s\n",
+   bts->rtp_ip_dscp, strerror(errno));
+   }
+   if (bts->rtp_priority != -1) {
+   if (osmo_rtp_socket_set_priority(rs, bts->rtp_priority))
+   LOGP(DRSL, LOGL_ERROR, "failed to set socket 
priority %d: %s\n",
+   bts->rtp_priority, strerror(errno));
+   }
+   return 0;
+   }
+
+   return -1;
+}
+
+int lchan_rtp_socket_create(struct gsm_lchan *lchan, const char *bind_ip)
+{
+   struct gsm_bts *bts = lchan->ts->trx->bts;
+   char cname[256+4];
+   int rc;
+
+   if (lchan->abis_ip.rtp_socket) {
+   LOGPLCHAN(lchan, DRSL, LOGL_ERROR, "Rx RSL IPAC CRCX, "
+ "but we already have socket!\n");
+   return -EALREADY;
+   }
+
+   /* FIXME: select default value depending on speech_mode */
+   //if (!payload_type)
+   lchan->tch.last_fn = LCHAN_FN_DUMMY;
+   lchan->abis_ip.rtp_socket = osmo_rtp_socket_create(lchan->ts->trx,
+   OSMO_RTP_F_POLL);
+
+   if (!lchan->abis_ip.rtp_socket) {
+   LOGPLCHAN(lchan, DRTP, LOGL_ERROR, "IPAC Failed to create 
RTP/RTCP sockets\n");
+   oml_tx_failure_event_rep(>ts->trx->mo,
+NM_SEVER_MINOR, OSMO_EVT_CRIT_RTP_TOUT,
+"%s IPAC Failed to create RTP/RTCP 
sockets",
+gsm_lchan_name(lchan));
+   return -ENOTCONN;
+   }
+
+   rc = osmo_rtp_socket_set_param(lchan->abis_ip.rtp_socket,
+  bts->rtp_jitter_adaptive ?
+  OSMO_RTP_P_JIT_ADAP :
+  OSMO_RTP_P_JITBUF,
+ 

Change in osmo-bts[master]: Clean up osmo-bts-*/Makefile.am

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29031 )

Change subject: Clean up osmo-bts-*/Makefile.am
..

Clean up osmo-bts-*/Makefile.am

Make them more easy to read and edit by splitting to one element per
line when several elements are present.

Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
---
M src/osmo-bts-lc15/Makefile.am
M src/osmo-bts-oc2g/Makefile.am
M src/osmo-bts-octphy/Makefile.am
M src/osmo-bts-omldummy/Makefile.am
M src/osmo-bts-sysmo/Makefile.am
M src/osmo-bts-trx/Makefile.am
M src/osmo-bts-virtual/Makefile.am
M tests/agch/Makefile.am
M tests/amr/Makefile.am
M tests/cipher/Makefile.am
M tests/handover/Makefile.am
M tests/meas/Makefile.am
M tests/misc/Makefile.am
M tests/paging/Makefile.am
M tests/power/Makefile.am
M tests/sysmobts/Makefile.am
M tests/ta_control/Makefile.am
M tests/tx_power/Makefile.am
18 files changed, 511 insertions(+), 86 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-lc15/Makefile.am b/src/osmo-bts-lc15/Makefile.am
index bb68efa..a4a105a 100644
--- a/src/osmo-bts-lc15/Makefile.am
+++ b/src/osmo-bts-lc15/Makefile.am
@@ -1,38 +1,100 @@
 AUTOMAKE_OPTIONS = subdir-objects

 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include $(LITECELL15_INCDIR)
-AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCODEC_CFLAGS) 
$(LIBOSMOGSM_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOSMOTRAU_CFLAGS) 
$(LIBOSMOABIS_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOABIS_CFLAGS) 
$(LIBGPS_CFLAGS) $(LIBSYSTEMD_CFLAGS)
-COMMON_LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOCODEC_LIBS) $(LIBOSMOGSM_LIBS) 
$(LIBOSMOVTY_LIBS) $(LIBOSMOTRAU_LIBS) $(LIBOSMOABIS_LIBS) $(LIBOSMOCTRL_LIBS)
+
+AM_CFLAGS = \
+   -Wall \
+   $(LIBOSMOCORE_CFLAGS) \
+   $(LIBOSMOCODEC_CFLAGS) \
+   $(LIBOSMOGSM_CFLAGS) \
+   $(LIBOSMOVTY_CFLAGS) \
+   $(LIBOSMOCTRL_CFLAGS) \
+   $(LIBOSMOABIS_CFLAGS) \
+   $(LIBOSMOTRAU_CFLAGS) \
+   $(LIBGPS_CFLAGS) \
+   $(LIBSYSTEMD_CFLAGS) \
+   $(NULL)
+
+COMMON_LDADD = \
+   $(LIBOSMOCORE_LIBS) \
+   $(LIBOSMOCODEC_LIBS) \
+   $(LIBOSMOGSM_LIBS) \
+   $(LIBOSMOVTY_LIBS) \
+   $(LIBOSMOCTRL_LIBS) \
+   $(LIBOSMOABIS_LIBS) \
+   $(LIBOSMOTRAU_LIBS) \
+   $(NULL)

 AM_CFLAGS += -DENABLE_LC15BTS
 
-EXTRA_DIST = misc/lc15bts_mgr.h misc/lc15bts_misc.h misc/lc15bts_par.h 
misc/lc15bts_led.h \
-   misc/lc15bts_temp.h misc/lc15bts_power.h misc/lc15bts_clock.h \
-   misc/lc15bts_bid.h misc/lc15bts_nl.h misc/lc15bts_bts.h 
misc/lc15bts_swd.h \
-   hw_misc.h l1_if.h l1_transp.h lc15bts.h utils.h
+EXTRA_DIST = \
+   misc/lc15bts_mgr.h \
+   misc/lc15bts_misc.h \
+   misc/lc15bts_par.h \
+   misc/lc15bts_led.h \
+   misc/lc15bts_temp.h \
+   misc/lc15bts_power.h \
+   misc/lc15bts_clock.h \
+   misc/lc15bts_bid.h \
+   misc/lc15bts_nl.h \
+   misc/lc15bts_bts.h \
+   misc/lc15bts_swd.h \
+   hw_misc.h \
+   l1_if.h \
+   l1_transp.h \
+   lc15bts.h \
+   utils.h \
+   $(NULL)

 bin_PROGRAMS = osmo-bts-lc15 lc15bts-mgr lc15bts-util

-COMMON_SOURCES = main.c lc15bts.c l1_if.c oml.c lc15bts_vty.c tch.c hw_misc.c 
calib_file.c \
-utils.c misc/lc15bts_par.c misc/lc15bts_bid.c
+COMMON_SOURCES = \
+   main.c \
+   lc15bts.c \
+   l1_if.c \
+   oml.c \
+   lc15bts_vty.c \
+   tch.c \
+   hw_misc.c \
+   calib_file.c \
+   utils.c \
+   misc/lc15bts_par.c \
+   misc/lc15bts_bid.c \
+   $(NULL)

 osmo_bts_lc15_SOURCES = $(COMMON_SOURCES) l1_transp_hw.c
-osmo_bts_lc15_LDADD = $(top_builddir)/src/common/libbts.a $(COMMON_LDADD)
+osmo_bts_lc15_LDADD = \
+   $(top_builddir)/src/common/libbts.a \
+   $(COMMON_LDADD) \
+   $(NULL)

 lc15bts_mgr_SOURCES = \
-   misc/lc15bts_mgr.c misc/lc15bts_misc.c \
-   misc/lc15bts_par.c misc/lc15bts_nl.c \
-   misc/lc15bts_temp.c misc/lc15bts_power.c \
-   misc/lc15bts_clock.c misc/lc15bts_bid.c \
+   misc/lc15bts_mgr.c \
+   misc/lc15bts_misc.c \
+   misc/lc15bts_par.c \
+   misc/lc15bts_nl.c \
+   misc/lc15bts_temp.c \
+   misc/lc15bts_power.c \
+   misc/lc15bts_clock.c \
+   misc/lc15bts_bid.c \
misc/lc15bts_mgr_vty.c \
misc/lc15bts_mgr_nl.c \
misc/lc15bts_mgr_temp.c \
misc/lc15bts_mgr_calib.c \
misc/lc15bts_led.c \
misc/lc15bts_bts.c \
-   misc/lc15bts_swd.c
+   misc/lc15bts_swd.c \
+   $(NULL)

-lc15bts_mgr_LDADD = $(top_builddir)/src/common/libbts.a $(LIBGPS_LIBS) 
$(LIBOSMOCORE_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMOABIS_LIBS) $(LIBOSMOGSM_LIBS) 
$(LIBOSMOCTRL_LIBS) $(LIBSYSTEMD_LIBS) $(COMMON_LDADD)
+lc15bts_mgr_LDADD = \
+   

Change in osmo-bts[master]: Clean up osmo-bts-*/Makefile.am

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29031 )

Change subject: Clean up osmo-bts-*/Makefile.am
..


Patch Set 6: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29031
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
Gerrit-Change-Number: 29031
Gerrit-PatchSet: 6
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 19:04:40 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: Move lchan_dl_tch_queue_enqueue to lchan.c and make it public

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29045 )


Change subject: Move lchan_dl_tch_queue_enqueue to lchan.c and make it public
..

Move lchan_dl_tch_queue_enqueue to lchan.c and make it public

It will be used too by osmux code present in another file. This is a
preparation commit to simplify the one adding osmux support.

Change-Id: Ie7fa57bb04db9ad9b03971467e12ee7b8e4c190a
---
M include/osmo-bts/lchan.h
M src/common/l1sap.c
M src/common/lchan.c
3 files changed, 15 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/45/29045/1

diff --git a/include/osmo-bts/lchan.h b/include/osmo-bts/lchan.h
index 64b7efa..484fccc 100644
--- a/include/osmo-bts/lchan.h
+++ b/include/osmo-bts/lchan.h
@@ -360,6 +360,8 @@
 int lchan_rtp_socket_connect(struct gsm_lchan *lchan, const struct in_addr 
*ia, uint16_t connect_port);
 void lchan_rtp_socket_free(struct gsm_lchan *lchan);

+void lchan_dl_tch_queue_enqueue(struct gsm_lchan *lchan, struct msgb *msg, 
unsigned int limit);
+
 static inline bool lchan_is_dcch(const struct gsm_lchan *lchan)
 {
switch (lchan->type) {
diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index d7b7abf..7bd2bbe 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -152,19 +152,6 @@
return GSM_RTP_DURATION;
 }

-/*! limit number of queue entries to %u; drops any surplus messages */
-static void lchan_dl_tch_queue_enqueue(struct gsm_lchan *lchan, struct msgb 
*msg, unsigned int limit)
-{
-   if (lchan->dl_tch_queue_len > limit)
-   LOGPLCHAN(lchan, DL1P, LOGL_NOTICE, "freeing %d queued 
frames\n",
- lchan->dl_tch_queue_len - limit);
-   while (lchan->dl_tch_queue_len > limit) {
-   struct msgb *tmp = msgb_dequeue_count(>dl_tch_queue, 
>dl_tch_queue_len);
-   msgb_free(tmp);
-   }
-   msgb_enqueue_count(>dl_tch_queue, msg, >dl_tch_queue_len);
-}
-
 /* allocate a msgb containing a osmo_phsap_prim + optional l2 data
  * in order to wrap femtobts header around l2 data, there must be enough space
  * in front and behind data pointer */
diff --git a/src/common/lchan.c b/src/common/lchan.c
index c7d8d45..c521f26 100644
--- a/src/common/lchan.c
+++ b/src/common/lchan.c
@@ -641,3 +641,16 @@
msgb_queue_free(>dl_tch_queue);
lchan->dl_tch_queue_len = 0;
 }
+
+/*! limit number of queue entries to %u; drops any surplus messages */
+void lchan_dl_tch_queue_enqueue(struct gsm_lchan *lchan, struct msgb *msg, 
unsigned int limit)
+{
+   if (lchan->dl_tch_queue_len > limit)
+   LOGPLCHAN(lchan, DL1P, LOGL_NOTICE, "freeing %d queued 
frames\n",
+ lchan->dl_tch_queue_len - limit);
+   while (lchan->dl_tch_queue_len > limit) {
+   struct msgb *tmp = msgb_dequeue_count(>dl_tch_queue, 
>dl_tch_queue_len);
+   msgb_free(tmp);
+   }
+   msgb_enqueue_count(>dl_tch_queue, msg, >dl_tch_queue_len);
+}

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29045
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie7fa57bb04db9ad9b03971467e12ee7b8e4c190a
Gerrit-Change-Number: 29045
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-bts[master]: Split out lchan rtp socket creation from rsl handling code

[pespin]

Attention is currently required from: pespin.
Hello Jenkins Builder, laforge, fixeria, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29032

to look at the new patch set (#3).

Change subject: Split out lchan rtp socket creation from rsl handling code
..

Split out lchan rtp socket creation from rsl handling code

This makes the code more clear, as well as allows adding Osmux in the
future.

Change-Id: Iade43fde7f6113f9d68539f7d6cc9843783c2b3f
---
M include/osmo-bts/lchan.h
M src/common/lchan.c
M src/common/rsl.c
3 files changed, 143 insertions(+), 113 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/32/29032/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29032
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iade43fde7f6113f9d68539f7d6cc9843783c2b3f
Gerrit-Change-Number: 29032
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: Use libosmocore API msgb_queue_free() to free lists

[pespin]

Attention is currently required from: pespin.
Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29035

to look at the new patch set (#2).

Change subject: Use libosmocore API msgb_queue_free() to free lists
..

Use libosmocore API msgb_queue_free() to free lists

There's no need to maintain a duplicate msgb_queue_flush(), which
returns the amount of freed messages (feature not used at all by the
callers).

Change-Id: I9841e18ca0b7b852130bbb02a510e43a3b3fd93f
---
M include/osmo-bts/rsl.h
M src/common/lchan.c
M src/common/rsl.c
M src/common/scheduler.c
4 files changed, 2 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/35/29035/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29035
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I9841e18ca0b7b852130bbb02a510e43a3b3fd93f
Gerrit-Change-Number: 29035
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: rsl: Reduce scope of variable

[pespin]

Attention is currently required from: pespin.
Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29036

to look at the new patch set (#2).

Change subject: rsl: Reduce scope of variable
..

rsl: Reduce scope of variable

The function is long/complex enough, so having one extra struct in_addr
declared the function top only used in one specific small path to print
the variable is unnecesary.
Let's move it to the conditional path where it is used to print the
ip address.

Change-Id: I4c16bbca6a6779537517b6b196828b47eddaa516
---
M src/common/rsl.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/36/29036/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29036
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4c16bbca6a6779537517b6b196828b47eddaa516
Gerrit-Change-Number: 29036
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: Avoid counting lchan->dl_tch_queue length every time a msg is enqueued

[pespin]

Attention is currently required from: pespin.
Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29034

to look at the new patch set (#2).

Change subject: Avoid counting lchan->dl_tch_queue length every time a msg is 
enqueued
..

Avoid counting lchan->dl_tch_queue length every time a msg is enqueued

The queue_limit_to method iterates the entire list of messages every
time a new message is added. Let's use msgb_{enqueue,dequeue}_count()
APIs to do that in constant time. It is true that since the queue is
limited to 1, there's usually at most 1 item in the queue so it's not a
real problem. However, when we add Osmux in the future, we may need to
tweak the amount of messages which can be in the list, due to Osmux
batching mechansim which may be more bursty sometimes.
In any case, this change doesn't make things worse for sure.

The patch also takes the chance to group the queue_limit_to + enqueue
into one function to avoid having the code spread several times.

Change-Id: I61818a3bb521c27bd21a8b6fa70581d27638ec9b
---
M include/osmo-bts/lchan.h
M src/common/l1sap.c
M src/common/lchan.c
3 files changed, 16 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/34/29034/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29034
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I61818a3bb521c27bd21a8b6fa70581d27638ec9b
Gerrit-Change-Number: 29034
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: Clean up osmo-bts-*/Makefile.am

[pespin]

Attention is currently required from: pespin.
Hello Jenkins Builder, laforge, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29031

to look at the new patch set (#6).

Change subject: Clean up osmo-bts-*/Makefile.am
..

Clean up osmo-bts-*/Makefile.am

Make them more easy to read and edit by splitting to one element per
line when several elements are present.

Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
---
M src/osmo-bts-lc15/Makefile.am
M src/osmo-bts-oc2g/Makefile.am
M src/osmo-bts-octphy/Makefile.am
M src/osmo-bts-omldummy/Makefile.am
M src/osmo-bts-sysmo/Makefile.am
M src/osmo-bts-trx/Makefile.am
M src/osmo-bts-virtual/Makefile.am
M tests/agch/Makefile.am
M tests/amr/Makefile.am
M tests/cipher/Makefile.am
M tests/handover/Makefile.am
M tests/meas/Makefile.am
M tests/misc/Makefile.am
M tests/paging/Makefile.am
M tests/power/Makefile.am
M tests/sysmobts/Makefile.am
M tests/ta_control/Makefile.am
M tests/tx_power/Makefile.am
18 files changed, 511 insertions(+), 86 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/31/29031/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29031
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
Gerrit-Change-Number: 29031
Gerrit-PatchSet: 6
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: rsl: Reduce scope of variable

[laforge]

Attention is currently required from: pespin.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29036 )

Change subject: rsl: Reduce scope of variable
..


Patch Set 1: Code-Review+1

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/29036/comment/d9f562a1_dd1ab9c3
PS1, Line 9: strct
struct


https://gerrit.osmocom.org/c/osmo-bts/+/29036/comment/e8fd21e9_455217b4
PS1, Line 9: length
long



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29036
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4c16bbca6a6779537517b6b196828b47eddaa516
Gerrit-Change-Number: 29036
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 19:02:21 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: Use libosmocore API msgb_queue_free() to free lists

[laforge]

Attention is currently required from: pespin.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29035 )

Change subject: Use libosmocore API msgb_queue_free() to free lists
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29035
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I9841e18ca0b7b852130bbb02a510e43a3b3fd93f
Gerrit-Change-Number: 29035
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 19:01:49 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: Avoid counting lchan->dl_tch_queue length every time a msg is enqueued

[laforge]

Attention is currently required from: pespin.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29034 )

Change subject: Avoid counting lchan->dl_tch_queue length every time a msg is 
enqueued
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29034
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I61818a3bb521c27bd21a8b6fa70581d27638ec9b
Gerrit-Change-Number: 29034
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 19:01:29 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: logging: Move category descriptions to be in order with enum

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29030 )

Change subject: logging: Move category descriptions to be in order with enum
..

logging: Move category descriptions to be in order with enum

Change-Id: I3a1922fcd695e08ca42ece8cf0a1804d1a00f450
---
M src/common/logging.c
1 file changed, 11 insertions(+), 11 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/src/common/logging.c b/src/common/logging.c
index 9c458e8..c79a58b 100644
--- a/src/common/logging.c
+++ b/src/common/logging.c
@@ -84,17 +84,6 @@
.loglevel = LOGL_NOTICE,
.enabled = 1,
},
-   [DABIS] = {
-   .name = "DABIS",
-   .description = "A-bis Intput Subsystem",
-   .enabled = 1, .loglevel = LOGL_NOTICE,
-   },
-   [DRTP] = {
-   .name = "DRTP",
-   .description = "Realtime Transfer Protocol",
-   .loglevel = LOGL_NOTICE,
-   .enabled = 1,
-   },
[DPCU] = {
.name = "DPCU",
.description = "PCU interface",
@@ -119,6 +108,17 @@
.color = "\033[0;94m",
.enabled = 1, .loglevel = LOGL_NOTICE,
},
+   [DABIS] = {
+   .name = "DABIS",
+   .description = "A-bis Intput Subsystem",
+   .enabled = 1, .loglevel = LOGL_NOTICE,
+   },
+   [DRTP] = {
+   .name = "DRTP",
+   .description = "Realtime Transfer Protocol",
+   .loglevel = LOGL_NOTICE,
+   .enabled = 1,
+   },
 };

 static int osmo_bts_filter_fn(const struct log_context *ctx, struct log_target 
*tgt)

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29030
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3a1922fcd695e08ca42ece8cf0a1804d1a00f450
Gerrit-Change-Number: 29030
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bts[master]: rsl: rx ipac crcx/mdcx: Log payload_type2

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29027 )

Change subject: rsl: rx ipac crcx/mdcx: Log payload_type2
..

rsl: rx ipac crcx/mdcx: Log payload_type2

Change-Id: Id3afee50aa112051aacb9016183a78374e5ba7fc
---
M src/common/rsl.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/common/rsl.c b/src/common/rsl.c
index 0a519af..e8765a7 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2793,6 +2793,8 @@
LOGPC(DRSL, LOGL_DEBUG, "\n");

payload_type2 = TLVP_VAL(, RSL_IE_IPAC_RTP_PAYLOAD2);
+   if (payload_type2)
+   LOGPC(DRSL, LOGL_DEBUG, "payload_type2=%u ", *payload_type2);

if (dch->c.msg_type == RSL_MT_IPAC_CRCX && connect_ip && connect_port)
inc_ip_port = 1;

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29027
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id3afee50aa112051aacb9016183a78374e5ba7fc
Gerrit-Change-Number: 29027
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bts[master]: Split out lchan rtp socket creation from rsl handling code

[laforge]

Attention is currently required from: pespin.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29032 )

Change subject: Split out lchan rtp socket creation from rsl handling code
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29032
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iade43fde7f6113f9d68539f7d6cc9843783c2b3f
Gerrit-Change-Number: 29032
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 19:00:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: Clean up osmo-bts-*/Makefile.am

[laforge]

Attention is currently required from: pespin.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29031 )

Change subject: Clean up osmo-bts-*/Makefile.am
..


Patch Set 5: Code-Review+1

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/29031/comment/96753657_dad22ca2
PS5, Line 9: Make them more easy to read and edit by splitting to one lement per
element



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29031
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
Gerrit-Change-Number: 29031
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 19:00:06 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: logging: Move category descriptions to be in order with enum

[laforge]

Attention is currently required from: pespin.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29030 )

Change subject: logging: Move category descriptions to be in order with enum
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29030
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3a1922fcd695e08ca42ece8cf0a1804d1a00f450
Gerrit-Change-Number: 29030
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:59:29 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: rsl: rx ipac crcx/mdcx: Log payload_type2

[laforge]

Attention is currently required from: pespin.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29027 )

Change subject: rsl: rx ipac crcx/mdcx: Log payload_type2
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29027
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id3afee50aa112051aacb9016183a78374e5ba7fc
Gerrit-Change-Number: 29027
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:59:17 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-netif[master]: osmux.h: Add missing msgb.h header

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29028 )

Change subject: osmux.h: Add missing msgb.h header
..

osmux.h: Add missing msgb.h header

Change-Id: I2002ed2352ef4db2fe0717389f1f6e24a88a973f
---
M include/osmocom/netif/osmux.h
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/include/osmocom/netif/osmux.h b/include/osmocom/netif/osmux.h
index 6305dc8..ed5c1ab 100644
--- a/include/osmocom/netif/osmux.h
+++ b/include/osmocom/netif/osmux.h
@@ -3,6 +3,7 @@

 #include 
 #include 
+#include 

 /*! \addtogroup osmux
  *  @{

--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29028
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I2002ed2352ef4db2fe0717389f1f6e24a88a973f
Gerrit-Change-Number: 29028
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-MessageType: merged

Change in libosmo-netif[master]: osmux.h: Define default Osmux port

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29029 )

Change subject: osmux.h: Define default Osmux port
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29029
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ibfd058bceeeaa1384a00d8fcd6d6268b445e19bd
Gerrit-Change-Number: 29029
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:58:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-pfcp[master]: gtlv: test repeated IEIs to several struct members

[laforge]

Attention is currently required from: neels.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29043 )

Change subject: gtlv: test repeated IEIs to several struct members
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29043
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I994d0fb1f1435d2c27a8630a43fe106652ac6e41
Gerrit-Change-Number: 29043
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:58:22 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-pfcp[master]: gtlv: check memory bounds 3/3: encoding to str

[laforge]

Attention is currently required from: neels.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29041 )

Change subject: gtlv: check memory bounds 3/3: encoding to str
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29041
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I63d52a4f5dba32d3a3887dd9c5e42e1695fb2aa3
Gerrit-Change-Number: 29041
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:58:00 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-pfcp[master]: gtlv: test repeated IEIs to several struct members

[pespin]

Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29043 )

Change subject: gtlv: test repeated IEIs to several struct members
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29043
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I994d0fb1f1435d2c27a8630a43fe106652ac6e41
Gerrit-Change-Number: 29043
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:57:52 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-pfcp[master]: gtlv: check memory bounds 1/3: encoding TLV

[laforge]

Attention is currently required from: neels.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29039 )

Change subject: gtlv: check memory bounds 1/3: encoding TLV
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29039
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Id8d997c9d5e655ff1842ec69eab6c073875c6330
Gerrit-Change-Number: 29039
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:57:29 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-pfcp[master]: gtlv: check memory bounds 3/3: encoding to str

[pespin]

Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29041 )

Change subject: gtlv: check memory bounds 3/3: encoding to str
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29041
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I63d52a4f5dba32d3a3887dd9c5e42e1695fb2aa3
Gerrit-Change-Number: 29041
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:57:20 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-pfcp[master]: pfcp_cp_peer: check use count correctness

[laforge]

Attention is currently required from: neels.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29038 )

Change subject: pfcp_cp_peer: check use count correctness
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29038
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Id79a84312b3ff8d562e26a525866b8bb09f9d0bf
Gerrit-Change-Number: 29038
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:56:19 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-pfcp[master]: doc: minor fix in pfcp_cp_peer_fsm.dot

[laforge]

Attention is currently required from: neels.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29037 )

Change subject: doc: minor fix in pfcp_cp_peer_fsm.dot
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29037
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I0de10d5331df128081d6b875e3ba9c0c3c32bd9f
Gerrit-Change-Number: 29037
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:56:05 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-netif[master]: rtp: Avoid memcpy(len=0)

[laforge]

Attention is currently required from: pespin.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29044 )

Change subject: rtp: Avoid memcpy(len=0)
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29044
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I7618c6509b67465d21271ea632bccc8cf11e4852
Gerrit-Change-Number: 29044
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:55:47 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-netif[master]: osmux.h: Define default Osmux port

[laforge]

Attention is currently required from: pespin.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29029 )

Change subject: osmux.h: Define default Osmux port
..


Patch Set 1: Code-Review+1

(1 comment)

File include/osmocom/netif/osmux.h:

https://gerrit.osmocom.org/c/libosmo-netif/+/29029/comment/547c45c1_883a5100
PS1, Line 16: #define OSMUX_DEFAULT_PORT 1984
might make sense to add it to 
https://osmocom.org/projects/cellular-infrastructure/wiki/Port_Numbers and add 
a link from herre to it, as well as to the manuals section which contains all 
our port numbers.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29029
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ibfd058bceeeaa1384a00d8fcd6d6268b445e19bd
Gerrit-Change-Number: 29029
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:55:35 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-pfcp[master]: gtlv: fix repeated IEIs to several struct members

[pespin]

Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29042 )

Change subject: gtlv: fix repeated IEIs to several struct members
..


Patch Set 1:

(1 comment)

Patchset:

PS1:
+1 when you fix linter.

BTW, in case it's of use, I also did some fixes in open5gs tlv parser for 
repeated IEs and used a temporary stack-based rbtree:
https://github.com/open5gs/open5gs/pull/1351/commits/1a518bff735b6c34639df4b2f81d6c18a21bb970



--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29042
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Ie37585178ff27306d425b75d8e407b71f92f1cdc
Gerrit-Change-Number: 29042
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:55:20 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in libosmo-netif[master]: osmux.h: Add missing msgb.h header

[laforge]

Attention is currently required from: neels, pespin.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29028 )

Change subject: osmux.h: Add missing msgb.h header
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29028
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I2002ed2352ef4db2fe0717389f1f6e24a88a973f
Gerrit-Change-Number: 29028
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-CC: fixeria 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:54:19 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in pysim[master]: Add new pySim.ota library, implement SIM OTA crypto

[laforge]

Attention is currently required from: laforge, pespin, Christian Amsüss.
Hello Jenkins Builder, pespin, Christian Amsüss,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/pysim/+/29033

to look at the new patch set (#4).

Change subject: Add new pySim.ota library, implement SIM OTA crypto
..

Add new pySim.ota library, implement SIM OTA crypto

This introduces a hierarchy of classes implementing

* ETS TS 102 225 (general command structure)
* 3GPP TS 31.115 (dialects for SMS-PP)

In this initial patch only the SMS "dialect" is supported,
but it is foreseen that USSD/SMSCB/HTTPS dialects can be
added at a later point.

Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84
---
M contrib/jenkins.sh
A pySim/ota.py
A pySim/sms.py
M requirements.txt
M setup.py
A tests/test_ota.py
6 files changed, 593 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/33/29033/4
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/29033
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84
Gerrit-Change-Number: 29033
Gerrit-PatchSet: 4
Gerrit-Owner: laforge 
Gerrit-Reviewer: Christian Amsüss 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: Christian Amsüss 
Gerrit-MessageType: newpatchset

Change in libosmo-pfcp[master]: gtlv: check memory bounds 1/3: encoding TLV

[pespin]

Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29039 )

Change subject: gtlv: check memory bounds 1/3: encoding TLV
..


Patch Set 1: Code-Review+1

(3 comments)

File src/libosmo-gtlv/gtlv_dec_enc.c:

https://gerrit.osmocom.org/c/libosmo-pfcp/+/29039/comment/10eacd5c_e5fed231
PS1, Line 52: /* Reverse offsetof(): return the address of the struct member 
for a given osmo_gtlv_msg and member ofs_foo value. */
"ofs_foo" you mean memb_ofs here?


https://gerrit.osmocom.org/c/libosmo-pfcp/+/29039/comment/bea708fc_aa20fdf5
PS1, Line 55:   const char *p = parent;
this extra p = parent here is only making thing smore difficult to understand. 
Just use parent or pass const uint8_t *parent.

In any case s/char/uint8_t/ here, otherwise looks more like a string.


https://gerrit.osmocom.org/c/libosmo-pfcp/+/29039/comment/5c449a51_ea4c686c
PS1, Line 390: int osmo_gtlvs_encode(struct osmo_gtlv_put *gtlv, const void 
*decoded_struct, size_t decoded_struct_max_len,
"max_len" afaict can be simply named "size", since it's the size of the decoded 
struct?



--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29039
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Id8d997c9d5e655ff1842ec69eab6c073875c6330
Gerrit-Change-Number: 29039
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:45:34 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Build failed in Jenkins: master-osmo-opencm3-projects » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #94

[jenkins]

See 


Changes:


--
Started by upstream project "master-osmo-opencm3-projects" build number 94
originally caused by:
 Started by timer
Running as SYSTEM
Building remotely on build2-deb9build-ansible (ttcn3 osmocom-gerrit-debian9 
osmocom-master-debian9 repo-install-test coverity) in workspace 

The recommended git tool is: NONE
No credentials specified
 > git rev-parse --resolve-git-dir 
 > 
 >  # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.osmocom.org/osmo-opencm3-projects # 
 > timeout=10
Fetching upstream changes from git://git.osmocom.org/osmo-opencm3-projects
 > git --version # timeout=10
 > git --version # 'git version 2.11.0'
 > git fetch --tags --progress -- git://git.osmocom.org/osmo-opencm3-projects 
 > +refs/heads/*:refs/remotes/origin/* # timeout=10
Checking out Revision cbff8e75d06b5e8ea9a196fa4fa706ba9f9ed124 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f cbff8e75d06b5e8ea9a196fa4fa706ba9f9ed124 # timeout=10
Commit message: "Make code compatible with picolibc >= 1.7.3"
 > git rev-list --no-walk cbff8e75d06b5e8ea9a196fa4fa706ba9f9ed124 # timeout=10
 > git remote # timeout=10
 > git submodule init # timeout=10
 > git submodule sync # timeout=10
 > git config --get remote.origin.url # timeout=10
 > git submodule init # timeout=10
 > git config -f .gitmodules --get-regexp ^submodule\.(.+)\.url # timeout=10
 > git config --get submodule.libopencm3.url # timeout=10
 > git config -f .gitmodules --get submodule.libopencm3.path # timeout=10
 > git config --get submodule.librfn.url # timeout=10
 > git config -f .gitmodules --get submodule.librfn.path # timeout=10
 > git submodule update --init --recursive libopencm3 # timeout=10
 > git submodule update --init --recursive librfn # timeout=10
[osmocom-master-debian9] $ /bin/sh -xe /tmp/jenkins8377583247459433701.sh
+ ARTIFACT_STORE=/home/osmocom-build/jenkins_build_artifact_store
+ mkdir -p /home/osmocom-build/jenkins_build_artifact_store
+ docker run --rm=true --cap-add SYS_PTRACE -e ARTIFACT_STORE=/artifact_store 
-e ASCIIDOC_WARNINGS_CHECK=1 -e HOME=/build -e 
JOB_NAME=master-osmo-opencm3-projects/a1=default,a2=default,a3=default,a4=default,label=osmocom-master-debian9
 -e MAKE=make -e OSMOPY_DEBUG_TCP_SOCKETS=1 -e 
OSMO_GSM_MANUALS_DIR=/opt/osmo-gsm-manuals -e PARALLEL_MAKE=-j 8 -e PUBLISH=1 
-e WITH_MANUALS=1 -w /build -i -u build -v 
:/build
 -v /home/osmocom-build/jenkins_build_artifact_store:/artifact_store -v 
/home/osmocom-build/.ssh:/home/build/.ssh:ro 
osmocom-build/debian-bullseye-jenkins /build/contrib/jenkins.sh --publish
=== relay-driver START  ==
  CLEAN
  CC  console.c
  CC  console_stm32.c
In file included from ../../libopencm3//include/libopencm3/cm3/nvic.h:147,
 from ../../librfn/librfn/libopencm3/console_stm32.c:24:
../../libopencm3//include/libopencm3/dispatch/nvic.h:8:11: fatal error: 
libopencm3/stm32/f1/nvic.h: No such file or directory
 # include 
   ^~~~
compilation terminated.
make: *** [../../mk/libopencm3.mk:228: console_stm32.o] Error 1
Build step 'Execute shell' marked build as failure

Change in libosmo-pfcp[master]: pfcp_cp_peer: check use count correctness

[pespin]

Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29038 )

Change subject: pfcp_cp_peer: check use count correctness
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29038
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Id79a84312b3ff8d562e26a525866b8bb09f9d0bf
Gerrit-Change-Number: 29038
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Thu, 11 Aug 2022 18:38:33 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-netif[master]: rtp: Avoid memcpy(len=0)

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29044 )


Change subject: rtp: Avoid memcpy(len=0)
..

rtp: Avoid memcpy(len=0)

Change-Id: I7618c6509b67465d21271ea632bccc8cf11e4852
---
M src/rtp.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/44/29044/1

diff --git a/src/rtp.c b/src/rtp.c
index 5c06c42..f4b0ada 100644
--- a/src/rtp.c
+++ b/src/rtp.c
@@ -199,7 +199,8 @@
rtph->timestamp = htonl(h->tx.timestamp);
h->tx.timestamp += duration;
rtph->ssrc = htonl(h->tx.ssrc);
-   memcpy(msg->data + sizeof(struct rtp_hdr), data, payload_len);
+   if (payload_len > 0)
+   memcpy(msg->data + sizeof(struct rtp_hdr), data, payload_len);
msgb_put(msg, sizeof(struct rtp_hdr) + payload_len);

return msg;

--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29044
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I7618c6509b67465d21271ea632bccc8cf11e4852
Gerrit-Change-Number: 29044
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in libosmo-pfcp[master]: doc: minor fix in pfcp_cp_peer_fsm.dot

[pespin]

Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29037 )

Change subject: doc: minor fix in pfcp_cp_peer_fsm.dot
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29037
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I0de10d5331df128081d6b875e3ba9c0c3c32bd9f
Gerrit-Change-Number: 29037
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Thu, 11 Aug 2022 17:47:50 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in pysim[master]: Add new pySim.ota library, implement SIM OTA crypto

[laforge]

Attention is currently required from: laforge, pespin, Christian Amsüss.
Hello Jenkins Builder, pespin, Christian Amsüss,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/pysim/+/29033

to look at the new patch set (#3).

Change subject: Add new pySim.ota library, implement SIM OTA crypto
..

Add new pySim.ota library, implement SIM OTA crypto

This introduces a hierarchy of classes implementing

* ETS TS 102 225 (general command structure)
* 3GPP TS 31.115 (dialects for SMS-PP)

In this initial patch only the SMS "dialect" is supported,
but it is foreseen that USSD/SMSCB/HTTPS dialects can be
added at a later point.

Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84
---
M contrib/jenkins.sh
A pySim/ota.py
A pySim/sms.py
M requirements.txt
M setup.py
A tests/test_ota.py
6 files changed, 593 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/33/29033/3
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/29033
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84
Gerrit-Change-Number: 29033
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Christian Amsüss 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: Christian Amsüss 
Gerrit-MessageType: newpatchset

Change in libosmo-pfcp[master]: gtlv: test repeated IEIs to several struct members

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29043 )


Change subject: gtlv: test repeated IEIs to several struct members
..

gtlv: test repeated IEIs to several struct members

Test the behavior fixed by Ie37585178ff27306d425b75d8e407b71f92f1cdc

Related: CID#275415
Related: SYS#5599
Change-Id: I994d0fb1f1435d2c27a8630a43fe106652ac6e41
---
M tests/libosmo-gtlv/gtlv_dec_enc_test.c
M tests/libosmo-gtlv/gtlv_dec_enc_test.ok
2 files changed, 380 insertions(+), 47 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/43/29043/1

diff --git a/tests/libosmo-gtlv/gtlv_dec_enc_test.c 
b/tests/libosmo-gtlv/gtlv_dec_enc_test.c
index f0de7b0..848c0ef 100644
--- a/tests/libosmo-gtlv/gtlv_dec_enc_test.c
+++ b/tests/libosmo-gtlv/gtlv_dec_enc_test.c
@@ -94,7 +94,13 @@
struct baz baz;

unsigned int repeat_int_count;
-   int repeat_int[32];
+   int repeat_int[3];
+
+   unsigned int repeat_int2_count;
+   int repeat_int2[2];
+
+   bool repeat_int3_present;
+   unsigned int repeat_int3;

unsigned int repeat_struct_count;
struct repeat repeat_struct[32];
@@ -264,6 +270,26 @@
.count_max = ARRAY_SIZE(((struct decoded_msg *)0)->repeat_int),
},
{
+   .ti = { TAG_REPEAT_INT },
+   .dec_func = dec_u16,
+   .enc_func = enc_u16,
+   .enc_to_str_func = enc_to_str_u16,
+   .memb_ofs = offsetof(struct decoded_msg, repeat_int2),
+   .memb_array_pitch = OSMO_MEMB_ARRAY_PITCH(struct decoded_msg, 
repeat_int2),
+   .has_count = true,
+   .count_ofs = offsetof(struct decoded_msg, repeat_int2_count),
+   .count_max = ARRAY_SIZE(((struct decoded_msg *)0)->repeat_int2),
+   },
+   {
+   .ti = { TAG_REPEAT_INT },
+   .dec_func = dec_u16,
+   .enc_func = enc_u16,
+   .enc_to_str_func = enc_to_str_u16,
+   .memb_ofs = offsetof(struct decoded_msg, repeat_int3),
+   .has_presence_flag = true,
+   .presence_flag_ofs = offsetof(struct decoded_msg, 
repeat_int3_present),
+   },
+   {
.ti = { TAG_REPEAT_STRUCT },
.dec_func = dec_repeat_struct,
.enc_func = enc_repeat_struct,
@@ -284,11 +310,88 @@
{}
 };

-char *decoded_msg_to_str(const struct decoded_msg *m)
-{
-   return osmo_gtlvs_encode_to_str_c(ctx, m, sizeof(*m), 0, msg_ie_coding, 
tag_names);
-}
+/* Same as msg_ie_coding, but with different ordering of the REPEAT_INT IEIs: 
in msg_ie_coding, the three separate
+ * REPEAT_INT tags follow directly after each other, while in msg_ie_coding2, 
other tags appear in-between. */
+struct osmo_gtlv_coding msg_ie_coding2[] = {
+   {
+   .ti = { TAG_FOO },
+   .dec_func = dec_u16,
+   .enc_func = enc_u16,
+   .enc_to_str_func = enc_to_str_u16,
+   .memb_ofs = offsetof(struct decoded_msg, foo),
+   },
+   {
+   .ti = { TAG_BAR },
+   .dec_func = dec_bar,
+   .enc_func = enc_bar,
+   .enc_to_str_func = enc_to_str_bar,
+   .memb_ofs = offsetof(struct decoded_msg, bar),
+   },
+   {
+   .ti = { TAG_BAZ },
+   .dec_func = dec_baz,
+   .enc_func = enc_baz,
+   .enc_to_str_func = enc_to_str_baz,
+   .memb_ofs = offsetof(struct decoded_msg, baz),
+   .has_presence_flag = true,
+   .presence_flag_ofs = offsetof(struct decoded_msg, baz_present),
+   },
+   {
+   .ti = { TAG_REPEAT_INT },
+   .dec_func = dec_u16,
+   .enc_func = enc_u16,
+   .enc_to_str_func = enc_to_str_u16,
+   .memb_ofs = offsetof(struct decoded_msg, repeat_int),
+   .memb_array_pitch = OSMO_MEMB_ARRAY_PITCH(struct decoded_msg, 
repeat_int),
+   .has_count = true,
+   .count_ofs = offsetof(struct decoded_msg, repeat_int_count),
+   .count_max = ARRAY_SIZE(((struct decoded_msg *)0)->repeat_int),
+   },
+   {
+   .ti = { TAG_REPEAT_STRUCT },
+   .dec_func = dec_repeat_struct,
+   .enc_func = enc_repeat_struct,
+   .enc_to_str_func = enc_to_str_repeat_struct,
+   .memb_ofs = offsetof(struct decoded_msg, repeat_struct),
+   .memb_array_pitch = OSMO_MEMB_ARRAY_PITCH(struct decoded_msg, 
repeat_struct),
+   .has_count = true,
+   .count_ofs = offsetof(struct decoded_msg, repeat_struct_count),
+   .count_max = ARRAY_SIZE(((struct decoded_msg 
*)0)->repeat_struct),
+   },
+   {
+   .ti = { TAG_REPEAT_INT },
+   .dec_func = dec_u16,
+

Change in libosmo-pfcp[master]: gtlv: fix repeated IEIs to several struct members

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29042 )


Change subject: gtlv: fix repeated IEIs to several struct members
..

gtlv: fix repeated IEIs to several struct members

Coverity Scan has brought my attention to a problem with decoding
repeated IEIs, where there are multiple struct members in the decoded
struct that these are decoded to.

Before this patch, gtlv aborts with an error as soon as the first struct
member for a given tag is full, not parsing following IEIs into
subsequent struct members.

After this patch, gtlv continues to look whether subsequent entries in
the message coding also decode the same tag, but to a different struct
member.

First commit without changing the gtlv regression test, to show that all
current tests still succeed. The test for this particular issue follow
in I994d0fb1f1435d2c27a8630a43fe106652ac6e41

Related: CID#275415
Related: SYS#5599
Change-Id: Ie37585178ff27306d425b75d8e407b71f92f1cdc
---
M src/libosmo-gtlv/gtlv_dec_enc.c
1 file changed, 70 insertions(+), 20 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/42/29042/1

diff --git a/src/libosmo-gtlv/gtlv_dec_enc.c b/src/libosmo-gtlv/gtlv_dec_enc.c
index 7e8d524..37b92a9 100644
--- a/src/libosmo-gtlv/gtlv_dec_enc.c
+++ b/src/libosmo-gtlv/gtlv_dec_enc.c
@@ -123,16 +123,19 @@
 * that can store them are filled up. */
ie_max_allowed_count = 0;

+   /* Unordered: for every tag, look for matching IE definitions 
from the start. */
+   iec = ie_coding;
+   /* There may be multiple subsequent occurences of the same tag, 
to be decoded into multiple members of
+* the decoded struct. Iterate until encountering a still "free 
slot" for decoding. */
do {
/* Find the IE coding for this tag */
-   for (iec = ie_coding;
-!osmo_gtlv_coding_end(iec) && 
osmo_gtlv_tag_inst_cmp(>ti, >ti);
+   for (;!osmo_gtlv_coding_end(iec) && 
osmo_gtlv_tag_inst_cmp(>ti, >ti);
 iec++);
/* No such IE coding found. */
if (osmo_gtlv_coding_end(iec))
break;

-   /* Keep track how often this tag can occur */
+   /* Keep track how often this tag can occur in total */
ie_max_allowed_count += iec->has_count ? iec->count_max 
: 1;

/* Was this iec instance already decoded? Then skip to 
the next one, if any. */
@@ -141,23 +144,35 @@
multi_count_p = iec->has_count ?
membof(obj, obj_maxlen, iec->count_ofs) : NULL;
if ((presence_flag_p && *presence_flag_p)
-   || (multi_count_p && *multi_count_p >= 
iec->count_max))
+   || (multi_count_p && *multi_count_p >= 
iec->count_max)) {
+   iec++;
continue;
+   }
+
/* For IEs with a presence flag or a multi count, the 
decoded struct provides the information
 * whether the IE has already been decoded. Do the same 
for mandatory IEs, using local state in
 * seen_ie_coding_entries[]. */
-   CHECK_SEEN(iec);
-   if (*seen_p)
-   continue;
-   } while (0);
+   if (!presence_flag_p && !multi_count_p) {
+   CHECK_SEEN(iec);
+   if (*seen_p) {
+   iec++;
+   continue;
+   }
+   }
+
+   /* Found an IE coding that has not yet been decoded / 
still has unused struct members to decode
+* to. */
+   break;
+   } while (1);
+
if (osmo_gtlv_coding_end(iec)) {
if (ie_max_allowed_count) {
-   /* There have been IE definitions for this IEI, 
but all slots to decode it are already
-* filled. */
+   /* This tag exists in the protocol definitions, 
but we've run out of struct members to
+* decode the tag to. */
RETURN_ERROR(-ENOTSUP, gtlv->ti, "Only %u 
instances of this IE are supported per message",
 ie_max_allowed_count);
}
-   /* No such IE defined in ie_coding, just skip the TLV. 
*/
+   /* 

Change in libosmo-pfcp[master]: gtlv: check memory bounds 3/3: encoding to str

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29041 )


Change subject: gtlv: check memory bounds 3/3: encoding to str
..

gtlv: check memory bounds 3/3: encoding to str

See Id8d997c9d5e655ff1842ec69eab6c073875c6330

Related: CID#275417
Change-Id: I63d52a4f5dba32d3a3887dd9c5e42e1695fb2aa3
---
M include/osmocom/gtlv/gtlv_dec_enc.h
M src/libosmo-gtlv/gtlv_dec_enc.c
M src/libosmo-gtlv/gtlv_gen.c
M tests/libosmo-gtlv/gtlv_dec_enc_test.c
M tests/libosmo-gtlv/test_gtlv_gen/gtlv_gen_test.c
M tests/libosmo-gtlv/test_tliv/tliv_test.c
6 files changed, 30 insertions(+), 23 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/41/29041/1

diff --git a/include/osmocom/gtlv/gtlv_dec_enc.h 
b/include/osmocom/gtlv/gtlv_dec_enc.h
index 243ad96..acb4ad4 100644
--- a/include/osmocom/gtlv/gtlv_dec_enc.h
+++ b/include/osmocom/gtlv/gtlv_dec_enc.h
@@ -191,10 +191,12 @@
  unsigned int obj_ofs, const struct osmo_gtlv_coding 
*ie_coding, osmo_gtlv_err_cb err_cb,
  void *err_cb_data, const struct value_string *iei_strs);

-int osmo_gtlvs_encode_to_str_buf(char *buf, size_t buflen, const void 
*decoded_struct, unsigned int obj_ofs,
-   const struct osmo_gtlv_coding *ie_coding, const 
struct value_string *iei_strs);
-char *osmo_gtlvs_encode_to_str_c(void *ctx, const void *decoded_struct, 
unsigned int obj_ofs,
-   const struct osmo_gtlv_coding *ie_coding, const 
struct value_string *iei_strs);
+int osmo_gtlvs_encode_to_str_buf(char *buf, size_t buflen,
+const void *decoded_struct, size_t 
decoded_struct_max_len, unsigned int obj_ofs,
+const struct osmo_gtlv_coding *ie_coding, 
const struct value_string *iei_strs);
+char *osmo_gtlvs_encode_to_str_c(void *ctx,
+const void *decoded_struct, size_t 
decoded_struct_max_len, unsigned int obj_ofs,
+const struct osmo_gtlv_coding *ie_coding, 
const struct value_string *iei_strs);

 static inline bool osmo_gtlv_coding_end(const struct osmo_gtlv_coding *iec)
 {
diff --git a/src/libosmo-gtlv/gtlv_dec_enc.c b/src/libosmo-gtlv/gtlv_dec_enc.c
index e442baa..7e8d524 100644
--- a/src/libosmo-gtlv/gtlv_dec_enc.c
+++ b/src/libosmo-gtlv/gtlv_dec_enc.c
@@ -28,9 +28,6 @@

 #include 

-/* Reverse offsetof(): return the address of the struct member for a given 
osmo_gtlv_msg and member ofs_foo value. */
-#define MEMB(M, MEMB_OFS) ((void *)((char *)(M) + (MEMB_OFS)))
-
 #define RETURN_ERROR(RC, TAG_INST, FMT, ARGS...) \
do {\
if (err_cb) { \
@@ -482,19 +479,23 @@
  * \param[in] iei_strs  value_string array to give IEI names in tag headers, 
or NULL.
  * \return number of characters that would be written if the buffer is large 
enough, like snprintf().
  */
-int osmo_gtlvs_encode_to_str_buf(char *buf, size_t buflen, const void 
*decoded_struct, unsigned int obj_ofs,
-   const struct osmo_gtlv_coding *ie_coding, const 
struct value_string *iei_strs)
+int osmo_gtlvs_encode_to_str_buf(char *buf, size_t buflen,
+const void *decoded_struct, size_t 
decoded_struct_max_len, unsigned int obj_ofs,
+const struct osmo_gtlv_coding *ie_coding, 
const struct value_string *iei_strs)
 {
struct osmo_strbuf sb = { .buf = buf, .len = buflen };

-   void *obj = MEMB(decoded_struct, obj_ofs);
+   const void *obj = membof_const(decoded_struct, decoded_struct_max_len, 
obj_ofs);
+   size_t obj_maxlen = decoded_struct_max_len - obj_ofs;

if (!ie_coding)
return -ENOTSUP;

for (; !osmo_gtlv_coding_end(ie_coding); ie_coding++) {
-   bool *presence_flag_p = ie_coding->has_presence_flag ? 
MEMB(obj, ie_coding->presence_flag_ofs) : NULL;
-   unsigned int *multi_count_p = ie_coding->has_count ? MEMB(obj, 
ie_coding->count_ofs) : NULL;
+   const bool *presence_flag_p = ie_coding->has_presence_flag ?
+   membof_const(obj, obj_maxlen, 
ie_coding->presence_flag_ofs) : NULL;
+   const unsigned int *multi_count_p = ie_coding->has_count ?
+   membof_const(obj, obj_maxlen, ie_coding->count_ofs) : 
NULL;
unsigned int n;
unsigned int i;

@@ -527,12 +528,14 @@

if (ie_coding->nested_ies) {
OSMO_STRBUF_PRINTF(sb, "{");
-   OSMO_STRBUF_APPEND(sb, 
osmo_gtlvs_encode_to_str_buf, decoded_struct, obj_ofs + memb_ofs,
+   OSMO_STRBUF_APPEND(sb, 
osmo_gtlvs_encode_to_str_buf,
+  decoded_struct, 
decoded_struct_max_len, obj_ofs + memb_ofs,
   

Change in libosmo-pfcp[master]: gtlv: check memory bounds 2/3: decoding TLV

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29040 )


Change subject: gtlv: check memory bounds 2/3: decoding TLV
..

gtlv: check memory bounds 2/3: decoding TLV

See Id8d997c9d5e655ff1842ec69eab6c073875c6330

Related: CID#275417
Change-Id: I841da89112ccf70fcd0f60eb902445fb1712eb48
---
M include/osmocom/gtlv/gtlv_dec_enc.h
M src/libosmo-gtlv/gtlv_dec_enc.c
M src/libosmo-gtlv/gtlv_gen.c
M tests/libosmo-gtlv/gtlv_dec_enc_test.c
4 files changed, 50 insertions(+), 30 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/40/29040/1

diff --git a/include/osmocom/gtlv/gtlv_dec_enc.h 
b/include/osmocom/gtlv/gtlv_dec_enc.h
index df8d161..243ad96 100644
--- a/include/osmocom/gtlv/gtlv_dec_enc.h
+++ b/include/osmocom/gtlv/gtlv_dec_enc.h
@@ -182,9 +182,10 @@
  */
 typedef void (*osmo_gtlv_err_cb)(void *data, void *decoded_struct, const char 
*file, int line, const char *fmt, ...);
 
-int osmo_gtlvs_decode(void *decoded_struct, unsigned int obj_ofs, struct 
osmo_gtlv_load *gtlv, bool tlv_ordered,
-const struct osmo_gtlv_coding *ie_coding,
-osmo_gtlv_err_cb err_cb, void *err_cb_data, const struct 
value_string *iei_strs);
+int osmo_gtlvs_decode(void *decoded_struct, size_t decoded_struct_max_len,
+ unsigned int obj_ofs, struct osmo_gtlv_load *gtlv, bool 
tlv_ordered,
+ const struct osmo_gtlv_coding *ie_coding,
+ osmo_gtlv_err_cb err_cb, void *err_cb_data, const struct 
value_string *iei_strs);

 int osmo_gtlvs_encode(struct osmo_gtlv_put *gtlv, const void *decoded_struct, 
size_t decoded_struct_max_len,
  unsigned int obj_ofs, const struct osmo_gtlv_coding 
*ie_coding, osmo_gtlv_err_cb err_cb,
diff --git a/src/libosmo-gtlv/gtlv_dec_enc.c b/src/libosmo-gtlv/gtlv_dec_enc.c
index f60ea94..e442baa 100644
--- a/src/libosmo-gtlv/gtlv_dec_enc.c
+++ b/src/libosmo-gtlv/gtlv_dec_enc.c
@@ -59,6 +59,11 @@
return memb;
 }

+static void *membof(void *parent, size_t parent_max_len, unsigned int memb_ofs)
+{
+   return (void*)membof_const((const void *)parent, parent_max_len, 
memb_ofs);
+}
+
 /*! Decode a TLV structure from raw data to a decoded struct, for unordered 
TLV IEs.
  * How to decode IE values and where to place them in the decoded struct, is 
defined by ie_coding, an array terminated
  * by a '{}' entry.
@@ -74,11 +79,13 @@
  * \param[in] iei_strs  value_string array to give IEI names in error messages 
passed to err_cb(), or NULL.
  * \return 0 on success, negative on error.
  */
-static int osmo_gtlvs_decode_unordered(void *decoded_struct, unsigned int 
obj_ofs, struct osmo_gtlv_load *gtlv,
- const struct osmo_gtlv_coding *ie_coding,
- osmo_gtlv_err_cb err_cb, void 
*err_cb_data, const struct value_string *iei_strs)
+static int osmo_gtlvs_decode_unordered(void *decoded_struct, size_t 
decoded_struct_max_len,
+  unsigned int obj_ofs, struct 
osmo_gtlv_load *gtlv,
+  const struct osmo_gtlv_coding *ie_coding,
+  osmo_gtlv_err_cb err_cb, void 
*err_cb_data, const struct value_string *iei_strs)
 {
-   void *obj = MEMB(decoded_struct, obj_ofs);
+   void *obj = membof(decoded_struct, decoded_struct_max_len, obj_ofs);
+   size_t obj_maxlen = decoded_struct_max_len - obj_ofs;
const struct osmo_gtlv_coding *iec;
unsigned int *multi_count_p;

@@ -132,8 +139,10 @@
ie_max_allowed_count += iec->has_count ? iec->count_max 
: 1;

/* Was this iec instance already decoded? Then skip to 
the next one, if any. */
-   presence_flag_p = iec->has_presence_flag ? MEMB(obj, 
iec->presence_flag_ofs) : NULL;
-   multi_count_p = iec->has_count ? MEMB(obj, 
iec->count_ofs) : NULL;
+   presence_flag_p = iec->has_presence_flag ?
+   membof(obj, obj_maxlen, iec->presence_flag_ofs) 
: NULL;
+   multi_count_p = iec->has_count ?
+   membof(obj, obj_maxlen, iec->count_ofs) : NULL;
if ((presence_flag_p && *presence_flag_p)
|| (multi_count_p && *multi_count_p >= 
iec->count_max))
continue;
@@ -183,15 +192,16 @@
default:
OSMO_ASSERT(0);
}
-   rc = osmo_gtlvs_decode(decoded_struct, obj_ofs + 
memb_ofs, _tlv, ordered, iec->nested_ies,
- err_cb, err_cb_data, iei_strs);
+   rc = osmo_gtlvs_decode(decoded_struct, 
decoded_struct_max_len,
+   

Change in libosmo-pfcp[master]: pfcp_cp_peer: check use count correctness

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29038 )


Change subject: pfcp_cp_peer: check use count correctness
..

pfcp_cp_peer: check use count correctness

Related: CID#275418
Change-Id: Id79a84312b3ff8d562e26a525866b8bb09f9d0bf
---
M src/libosmo-pfcp/pfcp_cp_peer.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/38/29038/1

diff --git a/src/libosmo-pfcp/pfcp_cp_peer.c b/src/libosmo-pfcp/pfcp_cp_peer.c
index 959206a..d900370 100644
--- a/src/libosmo-pfcp/pfcp_cp_peer.c
+++ b/src/libosmo-pfcp/pfcp_cp_peer.c
@@ -388,7 +388,7 @@

m->ctx.peer_use_count = _peer->use_count;
m->ctx.peer_use_token = (m->rx ? "PFCPrx" : "PFCPtx");
-   osmo_use_count_get_put(m->ctx.peer_use_count, m->ctx.peer_use_token, 1);
+   OSMO_ASSERT(osmo_use_count_get_put(m->ctx.peer_use_count, 
m->ctx.peer_use_token, 1) == 0);
 }

 /* Allocate a new PFCP request message to be sent to cp_peer->remote_addr. */

--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29038
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Id79a84312b3ff8d562e26a525866b8bb09f9d0bf
Gerrit-Change-Number: 29038
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in libosmo-pfcp[master]: gtlv: check memory bounds 1/3: encoding TLV

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29039 )


Change subject: gtlv: check memory bounds 1/3: encoding TLV
..

gtlv: check memory bounds 1/3: encoding TLV

Introduce a maximum bound of memory access to the osmo_gtlv API.

Properly pass const-ness within the gtlv implementation. This patch adds
membof_const(). The following patch will add the non-const membof()
equivalent, which is not needed in this patch, yet.

Coverity CID#275417 drew my attention to the fact that the gtlv decoding
and encoding does not actually guard against access past the end of the
decoded struct.

We have not yet officially released libosmo-gtlv; also, osmo-upf and
osmo-hnbgw so far only use the libosmo-pfcp API, which "hides" the gtlv
API. Hence just change the API without a backwards compat shim.

Related: CID#275417
Change-Id: Id8d997c9d5e655ff1842ec69eab6c073875c6330
---
M include/osmocom/gtlv/gtlv_dec_enc.h
M src/libosmo-gtlv/gtlv_dec_enc.c
M src/libosmo-gtlv/gtlv_gen.c
M tests/libosmo-gtlv/gtlv_dec_enc_test.c
4 files changed, 29 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/39/29039/1

diff --git a/include/osmocom/gtlv/gtlv_dec_enc.h 
b/include/osmocom/gtlv/gtlv_dec_enc.h
index 132239f..df8d161 100644
--- a/include/osmocom/gtlv/gtlv_dec_enc.h
+++ b/include/osmocom/gtlv/gtlv_dec_enc.h
@@ -186,9 +186,9 @@
 const struct osmo_gtlv_coding *ie_coding,
 osmo_gtlv_err_cb err_cb, void *err_cb_data, const struct 
value_string *iei_strs);

-int osmo_gtlvs_encode(struct osmo_gtlv_put *gtlv, const void *decoded_struct, 
unsigned int obj_ofs,
-const struct osmo_gtlv_coding *ie_coding,
-osmo_gtlv_err_cb err_cb, void *err_cb_data, const struct 
value_string *iei_strs);
+int osmo_gtlvs_encode(struct osmo_gtlv_put *gtlv, const void *decoded_struct, 
size_t decoded_struct_max_len,
+ unsigned int obj_ofs, const struct osmo_gtlv_coding 
*ie_coding, osmo_gtlv_err_cb err_cb,
+ void *err_cb_data, const struct value_string *iei_strs);

 int osmo_gtlvs_encode_to_str_buf(char *buf, size_t buflen, const void 
*decoded_struct, unsigned int obj_ofs,
const struct osmo_gtlv_coding *ie_coding, const 
struct value_string *iei_strs);
diff --git a/src/libosmo-gtlv/gtlv_dec_enc.c b/src/libosmo-gtlv/gtlv_dec_enc.c
index 2e5509a..f60ea94 100644
--- a/src/libosmo-gtlv/gtlv_dec_enc.c
+++ b/src/libosmo-gtlv/gtlv_dec_enc.c
@@ -49,6 +49,15 @@
return RC; \
} while (0)

+/* Reverse offsetof(): return the address of the struct member for a given 
osmo_gtlv_msg and member ofs_foo value. */
+static const void *membof_const(const void *parent, size_t parent_max_len, 
unsigned int memb_ofs)
+{
+   const char *p = parent;
+   const char *end = p + parent_max_len;
+   const char *memb = p + memb_ofs;
+   OSMO_ASSERT(memb < end);
+   return memb;
+}

 /*! Decode a TLV structure from raw data to a decoded struct, for unordered 
TLV IEs.
  * How to decode IE values and where to place them in the decoded struct, is 
defined by ie_coding, an array terminated
@@ -378,19 +387,22 @@
  * \param[in] iei_strs  value_string array to give IEI names in error messages 
passed to err_cb(), or NULL.
  * \return 0 on success, negative on error.
  */
-int osmo_gtlvs_encode(struct osmo_gtlv_put *gtlv, const void *decoded_struct, 
unsigned int obj_ofs,
-const struct osmo_gtlv_coding *ie_coding,
-osmo_gtlv_err_cb err_cb, void *err_cb_data, const struct 
value_string *iei_strs)
+int osmo_gtlvs_encode(struct osmo_gtlv_put *gtlv, const void *decoded_struct, 
size_t decoded_struct_max_len,
+ unsigned int obj_ofs, const struct osmo_gtlv_coding 
*ie_coding, osmo_gtlv_err_cb err_cb,
+ void *err_cb_data, const struct value_string *iei_strs)
 {
-   void *obj = MEMB(decoded_struct, obj_ofs);
+   const void *obj = membof_const(decoded_struct, decoded_struct_max_len, 
obj_ofs);
+   size_t obj_maxlen = decoded_struct_max_len - obj_ofs;

if (!ie_coding)
return -ENOTSUP;

for (; !osmo_gtlv_coding_end(ie_coding); ie_coding++) {
int rc;
-   bool *presence_flag_p = ie_coding->has_presence_flag ? 
MEMB(obj, ie_coding->presence_flag_ofs) : NULL;
-   unsigned int *multi_count_p = ie_coding->has_count ? MEMB(obj, 
ie_coding->count_ofs) : NULL;
+   const bool *presence_flag_p = ie_coding->has_presence_flag ?
+   membof_const(obj, obj_maxlen, 
ie_coding->presence_flag_ofs) : NULL;
+   const unsigned int *multi_count_p = ie_coding->has_count ?
+   membof_const(obj, obj_maxlen, ie_coding->count_ofs) : 
NULL;
unsigned 

Change in libosmo-pfcp[master]: doc: minor fix in pfcp_cp_peer_fsm.dot

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29037 )


Change subject: doc: minor fix in pfcp_cp_peer_fsm.dot
..

doc: minor fix in pfcp_cp_peer_fsm.dot

Change-Id: I0de10d5331df128081d6b875e3ba9c0c3c32bd9f
---
M doc/charts/pfcp_cp_peer_fsm.dot
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/37/29037/1

diff --git a/doc/charts/pfcp_cp_peer_fsm.dot b/doc/charts/pfcp_cp_peer_fsm.dot
index 101fe07..ec0d1fd 100644
--- a/doc/charts/pfcp_cp_peer_fsm.dot
+++ b/doc/charts/pfcp_cp_peer_fsm.dot
@@ -4,6 +4,7 @@

 cp [label="CP function",shape="box"]

+cp -> DISABLED [label="cp_peer_alloc()"]
 cp -> WAIT_ASSOC_SETUP_RESP [label="cp_peer_associate()"]

 txrx [label="PFCP socket",shape="box"]

--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29037
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I0de10d5331df128081d6b875e3ba9c0c3c32bd9f
Gerrit-Change-Number: 29037
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in osmo-bts[master]: rsl: Reduce scope of variable

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29036 )


Change subject: rsl: Reduce scope of variable
..

rsl: Reduce scope of variable

The function is length/complex enough, so having one extra strct in_addr
declared the function top only used in one specific small path to print
the variable is unnecesary.
Let's move it to the conditional path where it is used to print the
ip address.

Change-Id: I4c16bbca6a6779537517b6b196828b47eddaa516
---
M src/common/rsl.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/36/29036/1

diff --git a/src/common/rsl.c b/src/common/rsl.c
index 8cdb662..413c28d 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2702,7 +2702,6 @@
int rc, inc_ip_port = 0;
char *name;
struct in_addr ia;
-   struct in_addr addr;

if (dch->c.msg_type == RSL_MT_IPAC_CRCX)
name = "CRCX";
@@ -2721,6 +2720,7 @@

LOGPLCHAN(lchan, DRSL, LOGL_DEBUG, "IPAC_%s: ", name);
if (TLVP_PRES_LEN(, RSL_IE_IPAC_REMOTE_IP, 4)) {
+   struct in_addr addr;
connect_ip = tlvp_val32_unal(, RSL_IE_IPAC_REMOTE_IP);
addr.s_addr = connect_ip;
LOGPC(DRSL, LOGL_DEBUG, "connect_ip=%s ", inet_ntoa(addr));

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29036
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4c16bbca6a6779537517b6b196828b47eddaa516
Gerrit-Change-Number: 29036
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in pysim[master]: Add new pySim.ota library, implement SIM OTA crypto

[laforge]

Attention is currently required from: laforge, pespin, Christian Amsüss.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/29033 )

Change subject: Add new pySim.ota library, implement SIM OTA crypto
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/29033
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84
Gerrit-Change-Number: 29033
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Christian Amsüss 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: Christian Amsüss 
Gerrit-Comment-Date: Thu, 11 Aug 2022 16:32:43 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-bts[master]: Use libosmocore API msgb_queue_free() to free lists

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29035 )


Change subject: Use libosmocore API msgb_queue_free() to free lists
..

Use libosmocore API msgb_queue_free() to free lists

There's no need to maintain a duplicate msgb_queue_flush(), which
returns the amount of freed messages (feature not used at all by the
callers).

Change-Id: I9841e18ca0b7b852130bbb02a510e43a3b3fd93f
---
M include/osmo-bts/rsl.h
M src/common/lchan.c
M src/common/rsl.c
M src/common/scheduler.c
4 files changed, 2 insertions(+), 17 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/35/29035/1

diff --git a/include/osmo-bts/rsl.h b/include/osmo-bts/rsl.h
index dcd476c..a530734 100644
--- a/include/osmo-bts/rsl.h
+++ b/include/osmo-bts/rsl.h
@@ -4,8 +4,6 @@
 #define LCHAN_FN_DUMMY 0x
 #define LCHAN_FN_WAIT 0xFFFE

-int msgb_queue_flush(struct llist_head *list);
-
 int down_rsl(struct gsm_bts_trx *trx, struct msgb *msg);
 int rsl_tx_rf_res(struct gsm_bts_trx *trx);
 int rsl_tx_chan_rqd(struct gsm_bts_trx *trx, struct gsm_time *gtime,
diff --git a/src/common/lchan.c b/src/common/lchan.c
index 83d20da..c7d8d45 100644
--- a/src/common/lchan.c
+++ b/src/common/lchan.c
@@ -638,6 +638,6 @@
 {
osmo_rtp_socket_free(lchan->abis_ip.rtp_socket);
lchan->abis_ip.rtp_socket = NULL;
-   msgb_queue_flush(>dl_tch_queue);
+   msgb_queue_free(>dl_tch_queue);
lchan->dl_tch_queue_len = 0;
 }
diff --git a/src/common/rsl.c b/src/common/rsl.c
index bcbe27c..8cdb662 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -88,19 +88,6 @@
 }
 #define OSMO_IN_ARRAY(search, arr) osmo_in_array(search, arr, ARRAY_SIZE(arr))

-int msgb_queue_flush(struct llist_head *list)
-{
-   struct msgb *msg, *msg2;
-   int count = 0;
-
-   llist_for_each_entry_safe(msg, msg2, list, list) {
-   msgb_free(msg);
-   count++;
-   }
-
-   return count;
-}
-
 /* FIXME: move this to libosmocore */
 void gsm48_gen_starting_time(uint8_t *out, struct gsm_time *gtime)
 {
diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 6564e5a..14aff34 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -659,7 +659,7 @@
struct l1sched_ts *l1ts = ts->priv;
unsigned int i;

-   msgb_queue_flush(>dl_prims);
+   msgb_queue_free(>dl_prims);
rate_ctr_group_free(l1ts->ctrs);
l1ts->ctrs = NULL;


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29035
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I9841e18ca0b7b852130bbb02a510e43a3b3fd93f
Gerrit-Change-Number: 29035
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-bts[master]: Avoid counting lchan->dl_tch_queue length every time a msg is enqueued

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29034 )


Change subject: Avoid counting lchan->dl_tch_queue length every time a msg is 
enqueued
..

Avoid counting lchan->dl_tch_queue length every time a msg is enqueued

The queue_limit_to method iterates the entire list of messages every
time a new message is added. Let's use msgb_{enqueue,dequeue}_count()
APIs to do that in constant time. It is true that since the queue is
limited to 1, there's usually at most 1 item in the queue so it's not a
real problem. However, when we add Osmux in the future, we may need to
tweak the amount of messages which can be in the list, due to Osmux
batching mechansim which may be more bursty sometimes.
In any case, this change doesn't make things worse for sure.

The patch also takes the chance to group the queue_limit_to + enqueue
into one function to avoid having the code spread several times.

Change-Id: I61818a3bb521c27bd21a8b6fa70581d27638ec9b
---
M include/osmo-bts/lchan.h
M src/common/l1sap.c
M src/common/lchan.c
3 files changed, 16 insertions(+), 19 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/34/29034/1

diff --git a/include/osmo-bts/lchan.h b/include/osmo-bts/lchan.h
index c86acb0..64b7efa 100644
--- a/include/osmo-bts/lchan.h
+++ b/include/osmo-bts/lchan.h
@@ -191,6 +191,7 @@
uint8_t sapis_ul[23];
struct lapdm_channel lapdm_ch;
struct llist_head dl_tch_queue;
+   unsigned int dl_tch_queue_len;
struct {
/* bitmask of all SI that are present/valid in si_buf */
uint32_t valid;
diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index b74fd5a..d7b7abf 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -153,17 +153,16 @@
 }

 /*! limit number of queue entries to %u; drops any surplus messages */
-static void queue_limit_to(const char *prefix, struct llist_head *queue, 
unsigned int limit)
+static void lchan_dl_tch_queue_enqueue(struct gsm_lchan *lchan, struct msgb 
*msg, unsigned int limit)
 {
-   unsigned int count = llist_count(queue);
-
-   if (count > limit)
-   LOGP(DL1P, LOGL_NOTICE, "%s: freeing %d queued frames\n", 
prefix, count-limit);
-   while (count > limit) {
-   struct msgb *tmp = msgb_dequeue(queue);
+   if (lchan->dl_tch_queue_len > limit)
+   LOGPLCHAN(lchan, DL1P, LOGL_NOTICE, "freeing %d queued 
frames\n",
+ lchan->dl_tch_queue_len - limit);
+   while (lchan->dl_tch_queue_len > limit) {
+   struct msgb *tmp = msgb_dequeue_count(>dl_tch_queue, 
>dl_tch_queue_len);
msgb_free(tmp);
-   count--;
}
+   msgb_enqueue_count(>dl_tch_queue, msg, >dl_tch_queue_len);
 }

 /* allocate a msgb containing a osmo_phsap_prim + optional l2 data
@@ -915,7 +914,7 @@
uint8_t *p;

/* de-queue response message (loopback) */
-   loop_msg = msgb_dequeue(>dl_tch_queue);
+   loop_msg = msgb_dequeue_count(>dl_tch_queue, 
>dl_tch_queue_len);
if (!loop_msg) {
LOGPGT(DL1P, LOGL_NOTICE, tm, "%s: no looped PDTCH message, 
sending empty\n",
 gsm_lchan_name(lchan));
@@ -1305,7 +1304,7 @@
lchan->abis_ip.rtp_socket->rx_user_ts += GSM_RTP_DURATION;
}
/* get a msgb from the dl_tx_queue */
-   resp_msg = msgb_dequeue(>dl_tch_queue);
+   resp_msg = msgb_dequeue_count(>dl_tch_queue, 
>dl_tch_queue_len);
if (!resp_msg) {
DEBUGPGT(DL1P, _time, "%s DL TCH Tx queue underrun\n", 
gsm_lchan_name(lchan));
resp_l1sap = _l1sap;
@@ -1500,8 +1499,7 @@
/* we are in loopback mode (for BER testing)
 * mode and need to enqeue the frame to be
 * returned in downlink */
-   queue_limit_to(gsm_lchan_name(lchan), 
>dl_tch_queue, 1);
-   msgb_enqueue(>dl_tch_queue, msg);
+lchan_dl_tch_queue_enqueue(lchan, msg, 1);

/* Return 1 to signal that we're still using msg
 * and it should not be freed */
@@ -1622,10 +1620,8 @@
msg->data, msg->len, fn_ms_adj(fn, lchan), 
lchan->rtp_tx_marker);
/* if loopback is enabled, also queue received RTP data */
if (lchan->loopback) {
-   /* make sure the queue doesn't get too long */
-   queue_limit_to(gsm_lchan_name(lchan), 
>dl_tch_queue, 1);
-   /* add new frame to queue */
-   msgb_enqueue(>dl_tch_queue, msg);
+   /* add new frame to queue, make sure the queue doesn't 
get too long */
+   lchan_dl_tch_queue_enqueue(lchan, msg, 1);
/* Return 1 to 

Change in pysim[master]: Add new pySim.ota library, implement SIM OTA crypto

[laforge]

laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/pysim/+/29033 )


Change subject: Add new pySim.ota library, implement SIM OTA crypto
..

Add new pySim.ota library, implement SIM OTA crypto

This introduces a hierarchy of classes implementing

* ETS TS 102 225 (general command structure)
* 3GPP TS 31.115 (dialects for SMS-PP)

In this initial patch only the SMS "dialect" is supported,
but it is foreseen that USSD/SMSCB/HTTPS dialects can be
added at a later point.

Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84
---
A pySim/ota.py
A tests/test_ota.py
2 files changed, 536 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/33/29033/1

diff --git a/pySim/ota.py b/pySim/ota.py
new file mode 100644
index 000..4cac28d
--- /dev/null
+++ b/pySim/ota.py
@@ -0,0 +1,451 @@
+"""Code related to SIM/UICC OTA according to TS 102 225 + TS 31.115."""
+
+# (C) 2021-2022 by Harald Welte 
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see .
+
+from pySim.construct import *
+from pySim.utils import b2h
+from pySim.sms import UserDataHeader
+from construct import *
+from bidict import bidict
+import zlib
+import abc
+import struct
+
+# ETS TS 102 225 gives the general command structure and the dialects for 
CAT_TP, TCP/IP and HTTPS
+# 3GPP TS 31.115 gives the dialects for SMS-PP, SMS-CB, USSD and HTTP
+
+# CPI CPL CHI CHL SPI KIc KID TAR CNTR PCNTR RC/CC/DS data
+
+#   CAT_TP  TCP/IP  SMS
+# CPI   0x010x01
=IEIa=70,len=0
+# CHI   NULLNULLNULL
+# CPI, CPL and CHL included in RC/CC/DS truetrue
+# RPI   0x020x02
=IEIa=71,len=0
+# RHI   NULLNULL
+# RPI, RPL and RHL included in RC/CC/DS truetrue
+# packet-id 0-bf,ff 0-bf,ff
+# identification packet false   102 225 tbl 6
+
+# KVN 1..f; KI1=KIc, KI2=KID, KI3=DEK
+
+# TS 102 225 Table 5
+ota_status_codes = bidict({
+0x00:   'PoR OK',
+0x01:   'RC/CC/DS failed',
+0x02:   'CNTR low',
+0x03:   'CNTR high',
+0x04:   'CNTR blocked',
+0x05:   'Ciphering error',
+0x06:   'Unidentified security error',
+0x07:   'Insufficient memory',
+0x08:   'more time',
+0x09:   'TAR unknown',
+0x0a:   'Insufficient security level',
+0x0b:   'Actual Response in SMS-SUBMIT',# 31.115
+0x0c:   'Actual Response in USSD',  # 31.115
+})
+
+# ETSI TS 102 225 Table 5 + 3GPP TS 31.115 Section 7
+ResponseStatus = Enum(Int8ub, por_ok=0, rc_cc_ds_failed=1, cntr_low=2, 
cntr_high=3,
+  cntr_blocked=4, ciphering_error=5, 
undefined_security_error=6,
+  insufficient_memory=7, more_time_needed=8, tar_unknown=9,
+  insufficient_security_level=0x0A,
+  actual_response_sms_submit=0x0B,
+  actual_response_ussd=0x0C)
+
+# ETSI TS 102 226 Section 5.1.2
+CompactRemoteResp = Struct('number_of_commands'/Int8ub,
+   'last_status_word'/HexAdapter(Bytes(2)),
+   'last_response_data'/HexAdapter(GreedyBytes))
+
+RC_CC_DS = Enum(BitsInteger(2), no_rc_cc_ds=0, rc=1, cc=2, ds=3)
+
+# TS 102 225 Section 5.1.1 + TS 31.115 Section 4.2
+SPI = BitStruct(  # first octet
+Padding(3),
+'counter'/Enum(BitsInteger(2), no_counter=0, counter_no_replay_or_seq=1,
+   counter_must_be_higher=2, counter_must_be_lower=3),
+'ciphering'/Flag,
+'rc_cc_ds'/RC_CC_DS,
+# second octet
+Padding(2),
+'por_in_submit'/Flag,
+'por_shall_be_ciphered'/Flag,
+'por_rc_cc_ds'/RC_CC_DS,
+'por'/Enum(BitsInteger(2), no_por=0,
+   por_required=1, por_only_when_error=2)
+)
+
+# TS 102 225 Section 5.1.2
+KIC = BitStruct('key'/BitsInteger(4),
+'algo'/Enum(BitsInteger(4), implicit=0, single_des=1, 
triple_des_cbc2=5, triple_des_cbc3=9,
+aes_cbc=2)
+)
+
+# TS 102 225 Section 5.1.3.1
+KID_CC = BitStruct('key'/BitsInteger(4),
+   'algo'/Enum(BitsInteger(4), implicit=0, single_des=1, 

Change in osmo-bts[master]: Split out lchan rtp socket creation from rsl handling code

[dexter]

Attention is currently required from: pespin.
dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29032 )

Change subject: Split out lchan rtp socket creation from rsl handling code
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29032
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iade43fde7f6113f9d68539f7d6cc9843783c2b3f
Gerrit-Change-Number: 29032
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 15:32:46 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: Split out lchan rtp socket creation from rsl handling code

[fixeria]

Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29032 )

Change subject: Split out lchan rtp socket creation from rsl handling code
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29032
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iade43fde7f6113f9d68539f7d6cc9843783c2b3f
Gerrit-Change-Number: 29032
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 14:44:16 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-netif[master]: osmux.h: Add missing msgb.h header

[fixeria]

Attention is currently required from: neels, pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29028 )

Change subject: osmux.h: Add missing msgb.h header
..


Patch Set 1:

(1 comment)

File include/osmocom/netif/osmux.h:

https://gerrit.osmocom.org/c/libosmo-netif/+/29028/comment/2461fffa_2d9312ba
PS1, Line 6: #include 
> I don't like adding forward declarations of structs coming from other 
> libraries. […]
I see other [lib]osmo* projects having a forward declaration of 'struct msgb' 
in some header files. This reduces compile time. I do not insist, but I would 
still prefer this approach.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29028
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I2002ed2352ef4db2fe0717389f1f6e24a88a973f
Gerrit-Change-Number: 29028
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-CC: fixeria 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 14:43:40 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in libosmo-netif[master]: osmux.h: Add missing msgb.h header

[pespin]

Attention is currently required from: neels, fixeria.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29028 )

Change subject: osmux.h: Add missing msgb.h header
..


Patch Set 1:

(1 comment)

File include/osmocom/netif/osmux.h:

https://gerrit.osmocom.org/c/libosmo-netif/+/29028/comment/a6b4afa6_f4043158
PS1, Line 6: #include 
> adding a forward declaration of 'struct msgb' would have been enough.
I don't like adding forward declarations of structs coming from other 
libraries. I don't think it's the right thing to do.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29028
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I2002ed2352ef4db2fe0717389f1f6e24a88a973f
Gerrit-Change-Number: 29028
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-CC: fixeria 
Gerrit-Attention: neels 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Thu, 11 Aug 2022 13:59:42 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-bts[master]: Split out lchan rtp socket creation from rsl handling code

[pespin]

Attention is currently required from: pespin.
Hello Jenkins Builder, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29032

to look at the new patch set (#2).

Change subject: Split out lchan rtp socket creation from rsl handling code
..

Split out lchan rtp socket creation from rsl handling code

This makes the code more clear, as well as allows adding Osmux in the
future.

Change-Id: Iade43fde7f6113f9d68539f7d6cc9843783c2b3f
---
M include/osmo-bts/lchan.h
M src/common/lchan.c
M src/common/rsl.c
3 files changed, 143 insertions(+), 113 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/32/29032/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29032
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iade43fde7f6113f9d68539f7d6cc9843783c2b3f
Gerrit-Change-Number: 29032
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: Clean up osmo-bts-*/Makefile.am

[fixeria]

Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29031 )

Change subject: Clean up osmo-bts-*/Makefile.am
..


Patch Set 5:

(1 comment)

File src/osmo-bts-trx/Makefile.am:

https://gerrit.osmocom.org/c/osmo-bts/+/29031/comment/e920be35_5285b08e
PS5, Line 15:   $(LIBOSMOABIS_CFLAGS) \
> I'm putting all libosmocore.git ones together, then the libosmoabis ones.
Ok, fine with me.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29031
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
Gerrit-Change-Number: 29031
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 13:58:08 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-bts[master]: Clean up osmo-bts-*/Makefile.am

[pespin]

Attention is currently required from: fixeria.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29031 )

Change subject: Clean up osmo-bts-*/Makefile.am
..


Patch Set 5:

(1 comment)

File src/osmo-bts-trx/Makefile.am:

https://gerrit.osmocom.org/c/osmo-bts/+/29031/comment/82b999b5_65a74c55
PS5, Line 15:   $(LIBOSMOABIS_CFLAGS) \
> Why changing the order?
I'm putting all libosmocore.git ones together, then the libosmoabis ones.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29031
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
Gerrit-Change-Number: 29031
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Thu, 11 Aug 2022 13:57:18 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in libosmo-netif[master]: osmux.h: Define default Osmux port

[fixeria]

Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29029 )

Change subject: osmux.h: Define default Osmux port
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29029
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ibfd058bceeeaa1384a00d8fcd6d6268b445e19bd
Gerrit-Change-Number: 29029
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 13:55:27 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-netif[master]: osmux.h: Add missing msgb.h header

[fixeria]

Attention is currently required from: neels, pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29028 )

Change subject: osmux.h: Add missing msgb.h header
..


Patch Set 1:

(1 comment)

File include/osmocom/netif/osmux.h:

https://gerrit.osmocom.org/c/libosmo-netif/+/29028/comment/6eada0cb_d28e688a
PS1, Line 6: #include 
adding a forward declaration of 'struct msgb' would have been enough.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29028
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I2002ed2352ef4db2fe0717389f1f6e24a88a973f
Gerrit-Change-Number: 29028
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-CC: fixeria 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 13:54:43 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-bts[master]: Split out lchan rtp socket creation from rsl handling code

[fixeria]

Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29032 )

Change subject: Split out lchan rtp socket creation from rsl handling code
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29032
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iade43fde7f6113f9d68539f7d6cc9843783c2b3f
Gerrit-Change-Number: 29032
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 13:45:03 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: Clean up osmo-bts-*/Makefile.am

[fixeria]

Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29031 )

Change subject: Clean up osmo-bts-*/Makefile.am
..


Patch Set 5: Code-Review+1

(1 comment)

File src/osmo-bts-trx/Makefile.am:

https://gerrit.osmocom.org/c/osmo-bts/+/29031/comment/46673582_d8c0a122
PS5, Line 15:   $(LIBOSMOABIS_CFLAGS) \
Why changing the order?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29031
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
Gerrit-Change-Number: 29031
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 13:43:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: logging: Move category descriptions to be in order with enum

[fixeria]

Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29030 )

Change subject: logging: Move category descriptions to be in order with enum
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29030
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3a1922fcd695e08ca42ece8cf0a1804d1a00f450
Gerrit-Change-Number: 29030
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 11 Aug 2022 13:33:08 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: Split out lchan rtp socket creation from rsl handling code

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29032 )


Change subject: Split out lchan rtp socket creation from rsl handling code
..

Split out lchan rtp socket creation from rsl handling code

This makes the code more clear, as well as allows adding Osmux in the
future.

Change-Id: Iade43fde7f6113f9d68539f7d6cc9843783c2b3f
---
M include/osmo-bts/lchan.h
M src/common/lchan.c
M src/common/rsl.c
3 files changed, 143 insertions(+), 113 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/32/29032/1

diff --git a/include/osmo-bts/lchan.h b/include/osmo-bts/lchan.h
index 90c28d9..c86acb0 100644
--- a/include/osmo-bts/lchan.h
+++ b/include/osmo-bts/lchan.h
@@ -2,6 +2,7 @@

 #include 
 #include 
+#include 

 #include 
 #include 
@@ -354,6 +355,10 @@

 void lchan_set_state(struct gsm_lchan *lchan, enum gsm_lchan_state state);

+int lchan_rtp_socket_create(struct gsm_lchan *lchan, const char *bind_ip);
+int lchan_rtp_socket_connect(struct gsm_lchan *lchan, const struct in_addr 
*ia, uint16_t connect_port);
+void lchan_rtp_socket_free(struct gsm_lchan *lchan);
+
 static inline bool lchan_is_dcch(const struct gsm_lchan *lchan)
 {
switch (lchan->type) {
diff --git a/src/common/lchan.c b/src/common/lchan.c
index fe5efd5..51f579f 100644
--- a/src/common/lchan.c
+++ b/src/common/lchan.c
@@ -19,6 +19,8 @@
  *
  */

+#include "btsconfig.h" /* for PACKAGE_VERSION */
+
 #include 

 #include 
@@ -200,9 +202,7 @@
rsl_tx_ipac_dlcx_ind(lchan, RSL_ERR_NORMAL_UNSPEC);
osmo_rtp_socket_log_stats(lchan->abis_ip.rtp_socket, DRTP, 
LOGL_INFO,
"Closing RTP socket on Channel Release ");
-   osmo_rtp_socket_free(lchan->abis_ip.rtp_socket);
-   lchan->abis_ip.rtp_socket = NULL;
-   msgb_queue_flush(>dl_tch_queue);
+   lchan_rtp_socket_free(lchan);
}

/* FIXME: right now we allow creating the rtp_socket even if chan is not
@@ -510,3 +510,132 @@
return -1;
}
 }
+
+static int bind_rtp(struct gsm_bts *bts, struct osmo_rtp_socket *rs, const 
char *ip)
+{
+   int rc;
+   unsigned int i;
+   unsigned int tries;
+
+   tries = (bts->rtp_port_range_end - bts->rtp_port_range_start) / 2;
+   for (i = 0; i < tries; i++) {
+
+   if (bts->rtp_port_range_next >= bts->rtp_port_range_end)
+   bts->rtp_port_range_next = bts->rtp_port_range_start;
+
+   rc = osmo_rtp_socket_bind(rs, ip, bts->rtp_port_range_next);
+
+   bts->rtp_port_range_next += 2;
+
+   if (rc != 0)
+   continue;
+
+   if (bts->rtp_ip_dscp != -1) {
+   if (osmo_rtp_socket_set_dscp(rs, bts->rtp_ip_dscp))
+   LOGP(DRSL, LOGL_ERROR, "failed to set DSCP=%i: 
%s\n",
+   bts->rtp_ip_dscp, strerror(errno));
+   }
+   if (bts->rtp_priority != -1) {
+   if (osmo_rtp_socket_set_priority(rs, bts->rtp_priority))
+   LOGP(DRSL, LOGL_ERROR, "failed to set socket 
priority %d: %s\n",
+   bts->rtp_priority, strerror(errno));
+   }
+   return 0;
+   }
+
+   return -1;
+}
+
+int lchan_rtp_socket_create(struct gsm_lchan *lchan, const char *bind_ip)
+{
+   struct gsm_bts *bts = lchan->ts->trx->bts;
+   char cname[256+4];
+   int rc;
+
+   if (lchan->abis_ip.rtp_socket) {
+   LOGPLCHAN(lchan, DRSL, LOGL_ERROR, "Rx RSL IPAC CRCX, "
+ "but we already have socket!\n");
+   return -EALREADY;
+   }
+
+   /* FIXME: select default value depending on speech_mode */
+   //if (!payload_type)
+   lchan->tch.last_fn = LCHAN_FN_DUMMY;
+   lchan->abis_ip.rtp_socket = osmo_rtp_socket_create(lchan->ts->trx,
+   OSMO_RTP_F_POLL);
+
+   if (!lchan->abis_ip.rtp_socket) {
+   LOGPLCHAN(lchan, DRTP, LOGL_ERROR, "IPAC Failed to create 
RTP/RTCP sockets\n");
+   oml_tx_failure_event_rep(>ts->trx->mo,
+NM_SEVER_MINOR, OSMO_EVT_CRIT_RTP_TOUT,
+"%s IPAC Failed to create RTP/RTCP 
sockets",
+gsm_lchan_name(lchan));
+   return -ENOTCONN;
+   }
+
+   rc = osmo_rtp_socket_set_param(lchan->abis_ip.rtp_socket,
+  bts->rtp_jitter_adaptive ?
+  OSMO_RTP_P_JIT_ADAP :
+  OSMO_RTP_P_JITBUF,
+  bts->rtp_jitter_buf_ms);
+   if (rc < 0)
+   LOGPLCHAN(lchan, DRTP, 

Change in osmo-bts[master]: Clean up osmo-bts-*/Makefile.am

[pespin]

Attention is currently required from: pespin.
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29031

to look at the new patch set (#5).

Change subject: Clean up osmo-bts-*/Makefile.am
..

Clean up osmo-bts-*/Makefile.am

Make them more easy to read and edit by splitting to one lement per
line when several elements are present.

Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
---
M src/osmo-bts-lc15/Makefile.am
M src/osmo-bts-oc2g/Makefile.am
M src/osmo-bts-octphy/Makefile.am
M src/osmo-bts-omldummy/Makefile.am
M src/osmo-bts-sysmo/Makefile.am
M src/osmo-bts-trx/Makefile.am
M src/osmo-bts-virtual/Makefile.am
M tests/agch/Makefile.am
M tests/amr/Makefile.am
M tests/cipher/Makefile.am
M tests/handover/Makefile.am
M tests/meas/Makefile.am
M tests/misc/Makefile.am
M tests/paging/Makefile.am
M tests/power/Makefile.am
M tests/sysmobts/Makefile.am
M tests/ta_control/Makefile.am
M tests/tx_power/Makefile.am
18 files changed, 511 insertions(+), 86 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/31/29031/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29031
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
Gerrit-Change-Number: 29031
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: Clean up osmo-bts-*/Makefile.am

[pespin]

Attention is currently required from: pespin.
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/29031

to look at the new patch set (#4).

Change subject: Clean up osmo-bts-*/Makefile.am
..

Clean up osmo-bts-*/Makefile.am

Make them more easy to read and edit by splitting to one lement per
line when several elements are present.

Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
---
M src/osmo-bts-lc15/Makefile.am
M src/osmo-bts-oc2g/Makefile.am
M src/osmo-bts-octphy/Makefile.am
M src/osmo-bts-omldummy/Makefile.am
M src/osmo-bts-sysmo/Makefile.am
M src/osmo-bts-trx/Makefile.am
M src/osmo-bts-virtual/Makefile.am
7 files changed, 307 insertions(+), 53 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/31/29031/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29031
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I24ecfa1167b806dcb3a5a0c00343299df842a78b
Gerrit-Change-Number: 29031
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset