[S] Change in osmo-ttcn3-hacks[master]: library/IPA_Types: WIP codec for IPA UnitID (site/bts/trx)
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26458?usp=email ) Change subject: library/IPA_Types: WIP codec for IPA UnitID (site/bts/trx) .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26458?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I68eb0d9e28bbf5d2d8ffe916aae5a66a0fdb9bd0 Gerrit-Change-Number: 26458 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 19 Apr 2024 20:29:51 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: bsc: make use of IpaUnitId codec
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36612?usp=email )
Change subject: bsc: make use of IpaUnitId codec
..
bsc: make use of IpaUnitId codec
Change-Id: Iaf38fdb0a1c3ada5af6f1a05c7a9008e4eae0727
---
M bsc/BSC_Tests.ttcn
1 file changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/12/36612/1
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 5e4ebbc..8dcff83 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -981,7 +981,7 @@
clnt.vc_IPA := IPA_Emulation_CT.create(clnt.id & "-IPA") alive;
clnt.ccm_pars := c_IPA_default_ccm_pars;
clnt.ccm_pars.name := "Osmocom TTCN-3 BTS Simulator";
- clnt.ccm_pars.unit_id := int2str(1234 + idx.bts) & "/0/" &
int2str(idx.trx);
+ clnt.ccm_pars.unit_id := enc_IpaUnitId({1234 + idx.bts, 0, idx.trx});
if (handler_mode) {
clnt.vc_RSL := RSL_Emulation_CT.create(clnt.id & "-RSL") alive;
connect(clnt.vc_RSL:CCHAN_PT, self:RSL_CCHAN[idx.bts]);
@@ -3946,7 +3946,7 @@
client.vc_IPA := IPA_Emulation_CT.create(client.id & "-IPA") alive;
client.ccm_pars := c_IPA_default_ccm_pars;
client.ccm_pars.name := "Osmocom TTCN-3 BTS Simulator";
- client.ccm_pars.unit_id := "99/0/0"; /* value which is unknown at BTS */
+ client.ccm_pars.unit_id := enc_IpaUnitId({99, 0, 0}); /* value which is
unknown at BTS */
f_ipa_ctrl_start_client(mp_bsc_ip, mp_bsc_ctrl_port);
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36612?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iaf38fdb0a1c3ada5af6f1a05c7a9008e4eae0727
Gerrit-Change-Number: 36612
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
[S] Change in osmo-ttcn3-hacks[master]: library/RSL_Emulation: make use of IpaUnitId codec
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36611?usp=email )
Change subject: library/RSL_Emulation: make use of IpaUnitId codec
..
library/RSL_Emulation: make use of IpaUnitId codec
Change-Id: I20e1ac35707affc6aab60397a22e33fe2bd1106e
---
M library/RSL_Emulation.ttcn
1 file changed, 19 insertions(+), 20 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/11/36611/1
diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn
index 891e565..17e35ab 100644
--- a/library/RSL_Emulation.ttcn
+++ b/library/RSL_Emulation.ttcn
@@ -370,9 +370,7 @@
private function f_trx_conn_map_register(integer conn_id, in IpaCcmIdResp
id_resp)
runs on RSL_Emulation_CT return IpaStreamId {
- var template charstring unit_id_fmt := pattern "(\d+)/(\d+)/(\d+)";
- var charstring unit_id;
- var integer trx_nr;
+ var IpaUnitId unit_id;
var integer idx;
/* Check if we have room for a new connection */
@@ -386,29 +384,21 @@
testcase.stop("IPA IDENTITY RESPONSE contains no unit-id");
}
- /* Make sure that IPA unit-id is valid */
- unit_id := oct2char(id_resp[idx].data);
- if (not match(unit_id, unit_id_fmt)) {
- testcase.stop("IPA unit-id has unknown/unexpected format");
- }
+ /* Parse IPA unit-id */
+ unit_id := dec_IpaUnitId(oct2char(id_resp[idx].data));
- /* Parse transceiver number (site/bts/trx).
-* TODO: implement and use declaratice types. */
- unit_id := regexp(unit_id, unit_id_fmt, 2);
- trx_nr := str2int(unit_id);
-
- if (trx_nr >= sizeof(TrxConnMap)) {
- testcase.stop("Transceiver #", trx_nr, " does not fit");
- } else if (TrxConnMap[trx_nr] != -1) {
- testcase.stop("Transceiver #", trx_nr, " is already
connected?!?");
+ if (unit_id.trx_id >= sizeof(TrxConnMap)) {
+ testcase.stop("Transceiver #", unit_id.trx_id, " does not fit");
+ } else if (TrxConnMap[unit_id.trx_id] != -1) {
+ testcase.stop("Transceiver #", unit_id.trx_id, " is already
connected?!?");
}
/* Finally, store the connection ID */
- log("Mapped TRX#", trx_nr, " to TCP/IP conn_id=", conn_id);
- TrxConnMap[trx_nr] := conn_id;
+ log("Mapped TRX#", unit_id.trx_id, " to TCP/IP conn_id=", conn_id);
+ TrxConnMap[unit_id.trx_id] := conn_id;
TrxConnNum := TrxConnNum + 1;
- return f_streamId_by_trx(trx_nr);
+ return f_streamId_by_trx(unit_id.trx_id);
}
private function f_trx_conn_map_unregister(integer conn_id)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36611?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I20e1ac35707affc6aab60397a22e33fe2bd1106e
Gerrit-Change-Number: 36611
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match PDP Context IE
Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by osmith, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE .. sgsn: TC_sgsn_context_req_in: match PDP Context IE Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Related: SYS#6603, OS#6294 --- M library/GTPv1C_Templates.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 84 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/36601/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Gerrit-Change-Number: 36601 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-MessageType: newpatchset
[M] Change in osmo-ttcn3-hacks[master]: asterisk: Use Titan TEXT encoder to implement AMI record enc/dec
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36610?usp=email ) Change subject: asterisk: Use Titan TEXT encoder to implement AMI record enc/dec .. Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Nice! -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36610?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If179e45307a7e42b81b28db6ee4b7bf5eeb8b5f1 Gerrit-Change-Number: 36610 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Fri, 19 Apr 2024 16:55:01 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: asterisk: Use Titan TEXT encoder to implement AMI record enc/dec
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36610?usp=email )
Change subject: asterisk: Use Titan TEXT encoder to implement AMI record enc/dec
..
asterisk: Use Titan TEXT encoder to implement AMI record enc/dec
f_ami_wait_for_prompt_str had to be fixed since it was returning content
like this:
"Response: Success\nMessage: Authentication accepted"
Instead, the TEXT encoding expects:
"Response: Success\nMessage: Authentication accepted\n"
which is actually more in line with proper expectancies.
Change-Id: If179e45307a7e42b81b28db6ee4b7bf5eeb8b5f1
---
M asterisk/AMI_Functions.ttcn
1 file changed, 34 insertions(+), 48 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/10/36610/1
diff --git a/asterisk/AMI_Functions.ttcn b/asterisk/AMI_Functions.ttcn
index 53a7964..d5139f5 100644
--- a/asterisk/AMI_Functions.ttcn
+++ b/asterisk/AMI_Functions.ttcn
@@ -32,8 +32,21 @@
type record AMI_Field {
charstring key,
charstring val
+} with {
+ encode "TEXT"
+ variant "SEPARATOR(': ', ':\s+')"
};
-type set of AMI_Field AMI_Msg;
+
+type set of AMI_Field AMI_Msg with {
+ encode "TEXT"
+ variant "SEPARATOR('\r\n', '(\r\n)|[\n]')"
+ variant "END('\r\n', '(\r\n)|[\n]')"
+};
+
+external function enc_AMI_Msg(in AMI_Msg msg) return charstring
+ with { extension "prototype(convert) encode(TEXT)" }
+external function dec_AMI_Msg(in charstring stream) return AMI_Msg
+ with { extension "prototype(convert) decode(TEXT)" }
template (value) AMI_Field
ts_AMI_Field(template (value) charstring key,
@@ -102,49 +115,6 @@
* Functions:
*/
-function f_AMI_Field_from_str(charstring str) return AMI_Field {
- var AMI_Field field;
- /* "each field is a key value pair delineated by a ':'.
-* A single space MUST follow the ':' and precede the value. "*/
- var integer pos := f_strstr(str, ": ", 0);
- if (pos < 0) {
- Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
- log2str("Failed parsing AMI_Field: ",
str));
- }
- field.key := substr(str, 0, pos);
- /* skip ": " */
- pos := pos + 2;
- field.val := substr(str, pos, lengthof(str) - pos);
- return field;
-}
-
-function f_AMI_Msg_from_str(charstring str) return AMI_Msg {
- var AMI_Msg msg := {};
- var Misc_Helpers.ro_charstring lines := f_str_split(str, "\n");
-
- for (var integer i := 0; i < lengthof(lines); i := i + 1) {
- var charstring line := lines[i];
- var AMI_Field field := f_AMI_Field_from_str(lines[i]);
- msg := msg & { field };
- }
- return msg;
-}
-
-function f_AMI_Field_to_str(AMI_Field field) return charstring {
- return field.key & ": " & field.val;
-}
-
-function f_AMI_Msg_to_str(AMI_Msg msg) return charstring {
- var charstring str := "";
-
- for (var integer i := 0; i < lengthof(msg); i := i + 1) {
- str := str & f_AMI_Field_to_str(msg[i]) & "\r\n";
- }
-
- str := str & "\r\n";
- return str;
-}
-
private function f_ami_wait_for_prompt_str(TELNETasp_PT pt, charstring
log_label := "(?)")
return charstring {
var charstring rx, buf := "";
@@ -153,7 +123,7 @@
T.start(mp_ami_prompt_timeout);
alt {
- [] pt.receive(pattern "\n") { };
+ [] pt.receive(pattern "\n") { buf := buf & "\n" };
[] pt.receive(charstring:?) -> value rx { buf := buf & rx; repeat };
[] pt.receive(integer:?) -> value fd {
if (fd == -1) {
@@ -174,7 +144,7 @@
function f_ami_wait_for_prompt(TELNETasp_PT pt, charstring log_label := "(?)")
return AMI_Msg {
var charstring buf := f_ami_wait_for_prompt_str(pt, log_label);
- var AMI_Msg msg := f_AMI_Msg_from_str(buf);
+ var AMI_Msg msg := dec_AMI_Msg(buf);
return msg;
}
@@ -185,9 +155,9 @@
}
function f_ami_transceive_ret(TELNETasp_PT pt, template (value) AMI_Msg
tx_msg) return AMI_Msg {
- var charstring tx_txt := f_AMI_Msg_to_str(valueof(tx_msg));
+ var charstring tx_txt := enc_AMI_Msg(valueof(tx_msg));
var charstring resp_txt := f_ami_transceive_ret_str(pt, tx_txt);
- return f_AMI_Msg_from_str(resp_txt);
+ return dec_AMI_Msg(resp_txt);
}
function f_ami_transceive_match(TELNETasp_PT pt,
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36610?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If179e45307a7e42b81b28db6ee4b7bf5eeb8b5f1
Gerrit-Change-Number: 36610
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email )
Change subject: IPAd_Tests: add testsuite for an IPAd
..
Patch Set 3:
(1 comment)
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/7d086b52_f220b7f1
PS1, Line 445: for (i := 0; i <
sizeof(esipa_res.getBoundProfilePackageResponseEsipa.getBoundProfilePackageOkEsipa.boundProfilePackage.firstSequenceOf87);
i := i + 1) {
> I do not know if this looks much nicer ;-/ […]
lol.
But at least you have it once, not 6 times.
So your eyes only need to do the large line parsing once.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d
Gerrit-Change-Number: 36229
Gerrit-PatchSet: 3
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria
Gerrit-CC: pespin
Gerrit-Attention: fixeria
Gerrit-Attention: dexter
Gerrit-Comment-Date: Fri, 19 Apr 2024 14:09:23 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Comment-In-Reply-To: dexter
Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add new set of templates to support rollback
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36609?usp=email ) Change subject: SGP32Definitions_Templates: add new set of templates to support rollback .. Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I wonder why do we need one encoding function for each message. Couldn't we have a generic "message" structure/union holding all the others, and then have 1 enc and 1 dec functions? That's how most of the other procols work usually. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36609?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6db76afb102bf011655b7dbca9cff07b8116eb8d Gerrit-Change-Number: 36609 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Fri, 19 Apr 2024 14:07:01 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add template tr_provideEimPackageResult_e...
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36608?usp=email ) Change subject: SGP32Definitions_Templates: add template tr_provideEimPackageResult_ePRAndNotif .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36608?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I86231f0e9dcef90abf60757cc55895863ad2b1b3 Gerrit-Change-Number: 36608 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Fri, 19 Apr 2024 14:05:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: rename tx_provideEimPackageResultResponse
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36607?usp=email ) Change subject: SGP32Definitions_Templates: rename tx_provideEimPackageResultResponse .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I68536eec6d04364efdbbbd5205788cf5c8ab3028 Gerrit-Change-Number: 36607 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Fri, 19 Apr 2024 14:05:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: use enable instead of configureAutoEnable...
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36606?usp=email ) Change subject: SGP32Definitions_Templates: use enable instead of configureAutoEnable PSMO .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36606?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia364d5f6d510545988dc88cacdd15a2c03cc5d8b Gerrit-Change-Number: 36606 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Fri, 19 Apr 2024 14:05:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: remove unrelated template parameter
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36605?usp=email ) Change subject: SGP32Definitions_Templates: remove unrelated template parameter .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36605?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I365fe15a22a98ced5c6a5d13b2700df1df13014b Gerrit-Change-Number: 36605 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Fri, 19 Apr 2024 14:04:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add missing new line at the endo of file
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email ) Change subject: SGP32Definitions_Templates: add missing new line at the endo of file .. Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604/comment/365a9afe_623856b6 PS1, Line 7: SGP32Definitions_Templates: add missing new line at the endo of file endo of -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0e7c3b514ba6569c3707ae20ed213591ca7d0e1c Gerrit-Change-Number: 36604 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Fri, 19 Apr 2024 14:04:35 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: Allow API users to enable/disable SSL
Attention is currently required from: dexter, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506?usp=email )
Change subject: HTTP_Adapter: Allow API users to enable/disable SSL
..
Patch Set 2:
(1 comment)
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506/comment/b629870e_d6e27d53
PS1, Line 27: function f_http_init(charstring host, integer http_port, boolean
use_ssl := false) runs on http_CT {
> Yes, we should do this rather sooner than later. […]
For the sake of having it similar to other testsuites, usually we call these
"HTTP_Adapter_Params" and call it "pars", then have a "g_pars := pars" in
f_http_init() so you don't need to assign params one by one like you so in line
35.
Then, use eg. "g_pars.use_ssl"
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6487deea50cd9b4ed4905d9a3a78e00def8ea319
Gerrit-Change-Number: 36506
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-CC: laforge
Gerrit-Attention: laforge
Gerrit-Attention: dexter
Gerrit-Comment-Date: Fri, 19 Apr 2024 14:04:20 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
Comment-In-Reply-To: pespin
Comment-In-Reply-To: dexter
Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow body to be "omit"
Attention is currently required from: dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email )
Change subject: HTTP_Adapter: allow body to be "omit"
..
Patch Set 2:
(2 comments)
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505/comment/cd661cf5_aab37195
PS1, Line 85: msg.request := {
> I am not agreeing here. […]
why can't you just do something like:
function f_ts_body_or_empty(template (omit) body) return template (value)
charstring {
if (istemplatekind(body, "omit") {
return "";
}
return body
}
template (value) HTTPMessage ts_HTTP_Req(charstring url,
charstring method := "GET",
template charstring body := omit,
integer v_maj := 1, integer v_min := 1,
charstring host,
HeaderLines custom_hdr := { }) := {
.request := {
client_id := omit,
method := method,
uri := url,
version_major := v_maj,
version_minor := v_min,
header := valueof(f_ts_HTTP_Header(body, host,
custom_hdr))
body := f_ts_body_or_empty(body)
}
}
Btw, I wonder why can't just also just pass a "body := omit" to it? What's
wrong with that?
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505/comment/9db23800_6828990c
PS2, Line 100: if (ispresent(body)) {
I'm not that sure this ispresent(body) directly on a variable is what you are
actually want. Did you validate it? You may need istemplatekind("omit")?
You are also already using templatekind for the same stuff way up in the file.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff
Gerrit-Change-Number: 36505
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Attention: dexter
Gerrit-Comment-Date: Fri, 19 Apr 2024 14:02:14 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Comment-In-Reply-To: dexter
Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow API users to specifiy custom header
Attention is currently required from: dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email )
Change subject: HTTP_Adapter: allow API users to specifiy custom header
..
Patch Set 2: Code-Review+1
(1 comment)
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/efa2dddb_8ad3cd12
PS2, Line 72: hdr := hdr & {{ header_name := "Host", header_value :=
valueof(host) }};
hint: I usually find it way more readable to use templates instead of filling
records, eg:
hdr := hdr & { ts_Header("Host", host) };
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57
Gerrit-Change-Number: 36504
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Attention: dexter
Gerrit-Comment-Date: Fri, 19 Apr 2024 13:54:56 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match PDP Context IE
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email ) Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Gerrit-Change-Number: 36601 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 19 Apr 2024 13:50:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email )
Change subject: sgsn: add testcases for SGSN Context Request procedure
..
sgsn: add testcases for SGSN Context Request procedure
Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c
Related: SYS#6603, OS#6294
---
M library/GTPv1C_Templates.ttcn
M sgsn/SGSN_Tests.ttcn
2 files changed, 176 insertions(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/library/GTPv1C_Templates.ttcn b/library/GTPv1C_Templates.ttcn
index e9cf797..0907c5e 100644
--- a/library/GTPv1C_Templates.ttcn
+++ b/library/GTPv1C_Templates.ttcn
@@ -67,7 +67,8 @@
GTP_CAUSE_MS_REFUSES(4),
GTP_CAUSE_MS_IS_NOT_GPRS_RESPONDING (5),
/* reserved */
- GTP_CAUSE_REQUEST_ACCEPTED (128)
+ GTP_CAUSE_REQUEST_ACCEPTED (128),
+ GTP_CAUSE_INVALID_MSG_FORMAT(193)
/* FIXME */
};
diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 92b744f..9029a9e 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -3727,6 +3727,167 @@
f_cleanup();
}
+/* SGSN terminated SGSN Context Request procedure (we request, SGSN responds)
+ * 3GPP TS 23.401, Figure D.3.6-1: "Gn/Gp SGSN to MME Tracking Area Update
procedure" */
+private function f_TC_sgsn_context_req_in(charstring id) runs on
BSSGP_ConnHdlr {
+ var integer seq_nr := f_rnd_int(65535);
+ var Gtp1cUnitdata gtpc_ud;
+ timer T;
+
+ var Gtp1cPeer peer := {
+ connId := 1,
+ remName := mp_sgsn_gtp_ip,
+ remPort := GTP1C_PORT
+ }
+
+ /* The MS attaches to GERAN/UTRAN and enjoys the service */
+ f_gmm_attach(false, false);
+
+ /* The MS switches to an LTE cell and performs Tracking Area Update
Request there.
+* The MME requests information about the MS by sending SGSN Context
Request. */
+ var template (value) GTPC_PDUs ctx_req;
+ ctx_req := ts_SGSNContextReqPDU(rai := ts_RoutingAreaIdentity('250'H,
'F99'H, '4242'O, 'DE'O),
+ teic := '12345678'O,
+ sgsn_addr_control :=
f_inet_addr(mp_ggsn_ip),
+ ptmsi := ts_PTMSI(g_pars.p_tmsi),
+ ptmsi_sig := ts_PTMSI_sig('010203'O));
+ GTP.send(ts_GTPC_SGSNContextReq(peer, seq_nr, ctx_req));
+
+ /* The SGSN responds with subscriber's IMSI */
+ var template (present) GTPC_PDUs ctx_rsp;
+ ctx_rsp := tr_SGSNContextRespPDU(cause := GTP_CAUSE_REQUEST_ACCEPTED,
+imsi := g_pars.imsi);
+ /* TODO: match MM/PDP Context, GSN Address */
+
+ T.start(2.0);
+ alt {
+ [] GTP.receive(tr_GTPC_SGSNContextResp(?, ?, ctx_rsp)) -> value gtpc_ud
{
+ log("Rx SGSN Context Resp from SGSN, sending Ack");
+ GTP.send(ts_GTPC_SGSNContextAck(gtpc_ud.peer, '12345678'O,
seq_nr));
+ setverdict(pass);
+ }
+ [] GTP.receive(tr_GTPC_SGSNContextResp) -> value gtpc_ud {
+ GTP.send(ts_GTPC_SGSNContextAck(gtpc_ud.peer, '12345678'O,
seq_nr,
+
ts_SGSNContextAckPDU(GTP_CAUSE_INVALID_MSG_FORMAT)));
+ setverdict(fail, "Rx unexpected SGSN Context Resp");
+ }
+ [] T.timeout {
+ setverdict(fail, "Timeout waiting for SGSN Context Resp");
+ }
+ }
+
+ /* HLR/HSS tells SGSN to forget this MS/UE */
+ GSUP.send(ts_GSUP_CL_REQ(g_pars.imsi, OSMO_GSUP_CANCEL_TYPE_UPDATE));
+ GSUP.receive(tr_GSUP_CL_RES(g_pars.imsi));
+}
+testcase TC_sgsn_context_req_in() runs on test_CT {
+ var BSSGP_ConnHdlr vc_conn;
+ f_init();
+ f_sleep(1.0);
+ vc_conn := f_start_handler(refers(f_TC_sgsn_context_req_in),
testcasename(), g_gb, 72);
+ vc_conn.done;
+ f_cleanup();
+}
+
+/* SGSN originated SGSN Context Request procedure (SGSN requests, we respond)
+ * 3GPP TS 23.401, Figure D.3.5-1 "Routing Area Update procedure" */
+private function f_TC_sgsn_context_req_out(charstring id) runs on
BSSGP_ConnHdlr {
+ var integer seq_nr := f_rnd_int(65535);
+ var Gtp1cUnitdata gtpc_ud;
+ timer T;
+
+ /* The MS goes to GERAN/UTRAN from an LTE cell */
+ f_send_l3(ts_GMM_RAU_REQ(mi_lv := valueof(ts_MI_TMSI_LV('DE42DE42'O)),
+upd_type := GPRS_UPD_T_RA,
+old_ra := f_random_RAI()), 0);
+
+
+ /* The SGSN has no idea about the MS and inquires the MME about it */
+ T.start(2.0);
+ alt {
+ [] GTP
[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36600?usp=email )
(
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted
one.
)Change subject: sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address
IEs
..
sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs
Change-Id: Ie68794c309e548279381d044a3e34dcdf405084f
Related: SYS#6603, OS#6294
---
M library/GTPv1C_Templates.ttcn
M sgsn/SGSN_Tests.ttcn
2 files changed, 55 insertions(+), 3 deletions(-)
Approvals:
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/library/GTPv1C_Templates.ttcn b/library/GTPv1C_Templates.ttcn
index 0907c5e..2eb1d7e 100644
--- a/library/GTPv1C_Templates.ttcn
+++ b/library/GTPv1C_Templates.ttcn
@@ -341,7 +341,8 @@
/* 7.7.28 MM Context */
template (value) MM_Context ts_MM_ContextGSM(template (value) OCT8 kc,
template (value) BIT3 cksn
:= '000'B,
-template (value) BIT3 gea
:= '000'B) := {
+template (value) BIT3 gea
:= '000'B,
+template (value)
octetstring triplet := ''O) := {
type_gtpc := '81'O,
context := {
mmcontGSM := {
@@ -352,7 +353,7 @@
noofVectors := 0, /* overwritten */
security := '01'B, /* GSM key and triplets */
kc := kc,
- triplet := ''O,
+ triplet := triplet,
drx_par := ''O,
msNetW_cap_length := 0, /* overwritten */
msNetw_cap := omit,
@@ -363,6 +364,32 @@
}
}
}
+ template (present) MM_Context tr_MM_ContextGSM(template (present) OCT8
kc := ?,
+ template (present) BIT3
cksn := ?,
+ template (present) BIT3
gea := ?,
+ template (present)
octetstring triplet := ?) := {
+ type_gtpc := '81'O,
+ context := {
+ mmcontGSM := {
+ lengthf := ?,
+ cksn := cksn,
+ spare := ?,
+ usedCipher := gea,
+ noofVectors := ?,
+ security := '01'B, /* GSM key and triplets */
+ kc := kc,
+ triplet := triplet,
+ drx_par := ?,
+ msNetW_cap_length := ?,
+ msNetw_cap := *,
+ containerLength := ?,
+ container := *,
+ access_restriction_data_length := ?,
+ access_restriction_data := *
+ }
+ }
+ }
+
template (value) MM_Context ts_MM_ContextUMTS(template (value) OCT16 ck,
template (value) OCT16
ik) := {
type_gtpc := '81'O,
diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 9029a9e..67e815b 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -3757,7 +3757,22 @@
var template (present) GTPC_PDUs ctx_rsp;
ctx_rsp := tr_SGSNContextRespPDU(cause := GTP_CAUSE_REQUEST_ACCEPTED,
imsi := g_pars.imsi);
- /* TODO: match MM/PDP Context, GSN Address */
+
+ /* SGSN Address for Control Plane */
+ var octetstring sgsn_addr := f_inet_addr(mp_sgsn_gtp_ip);
+ ctx_rsp.sgsn_ContextResponse.sgsn_addr_controlPlane :=
tr_GsnAddr(sgsn_addr);
+
+ /* Match MM Context */
+ if (ispresent(g_pars.vec)) {
+ /* XXX: this is only valid for GERAN */
+ var octetstring triplet := g_pars.vec.rand & g_pars.vec.sres &
g_pars.vec.kc;
+ ctx_rsp.sgsn_ContextResponse.mm_Context := tr_MM_ContextGSM(kc
:= g_pars.vec.kc,
+
triplet := triplet);
+ /* TODO: 7.5.4 "The IMEISV shall, if available, be included in
the MM Context".
+* See also 3GPP TS 29.060, section 7.7.28 and Table 47A */
+ }
+
+ /* TODO: match PDP Context */
T.start(2.0);
[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email ) Change subject: sgsn: add testcases for SGSN Context Request procedure .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Gerrit-Change-Number: 36589 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 19 Apr 2024 13:49:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match PDP Context IE
Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email ) Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Gerrit-Change-Number: 36601 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Fri, 19 Apr 2024 12:49:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure
Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email ) Change subject: sgsn: add testcases for SGSN Context Request procedure .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Gerrit-Change-Number: 36589 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 19 Apr 2024 12:48:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter, fixeria, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd .. Patch Set 3: (13 comments) File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/f46796ca_8b6a8d1a PS3, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/bcfd9ef2_60a0e3e2 PS3, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/410f5f26_c1ed6163 PS3, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/7e0621e1_f6312244 PS3, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/bc53f7b7_c376abec PS3, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/ec9aabe9_d84e4cd8 PS3, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/pki/issued/alttest.crt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/78c41c43_a2cf1997 PS3, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/45165c80_b77f38ed PS3, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/0024ee70_b84ac930 PS3, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/e6ec6b7d_d1c727b5 PS3, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/37ac2261_2bb8b4c0 PS3, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/de9e96c7_30a219f0 PS3, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/vars: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/28191ddc_37fe8440 PS3, Line 30: # trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Fri, 19 Apr 2024 11:56:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add new set of templates to support rollback
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36609?usp=email )
Change subject: SGP32Definitions_Templates: add new set of templates to support
rollback
..
SGP32Definitions_Templates: add new set of templates to support rollback
This patch adds a number of templates that are needed to test profile
rollback.
Related: SYS#6563
Change-Id: I6db76afb102bf011655b7dbca9cff07b8116eb8d
---
M library/euicc/SGP32Definitions_EncDec.cc
M library/euicc/SGP32Definitions_Templates.ttcn
M library/euicc/SGP32Definitions_Types.ttcn
3 files changed, 91 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/09/36609/1
diff --git a/library/euicc/SGP32Definitions_EncDec.cc
b/library/euicc/SGP32Definitions_EncDec.cc
index 4dfcc6b..a457943 100644
--- a/library/euicc/SGP32Definitions_EncDec.cc
+++ b/library/euicc/SGP32Definitions_EncDec.cc
@@ -109,5 +109,39 @@
return msg;
}
+OCTETSTRING enc__ProfileRollbackRequest(const ProfileRollbackRequest &msg) {
+ TTCN_Buffer buf;
+
+ buf.clear();
+ msg.encode(ProfileRollbackRequest_descr_, buf, TTCN_EncDec::CT_BER,
BER_ENCODE_DER);
+ return OCTETSTRING(buf.get_len(), buf.get_data());
+}
+
+ProfileRollbackRequest dec__ProfileRollbackRequest(const OCTETSTRING &stream) {
+ TTCN_Buffer buf;
+ ProfileRollbackRequest msg;
+ buf.put_os(stream);
+
+ msg.decode(ProfileRollbackRequest_descr_, buf, TTCN_EncDec::CT_BER,
BER_ACCEPT_ALL);
+ return msg;
+}
+
+OCTETSTRING enc__ProfileRollbackResponse(const ProfileRollbackResponse &msg) {
+ TTCN_Buffer buf;
+
+ buf.clear();
+ msg.encode(ProfileRollbackResponse_descr_, buf, TTCN_EncDec::CT_BER,
BER_ENCODE_DER);
+ return OCTETSTRING(buf.get_len(), buf.get_data());
+}
+
+ProfileRollbackResponse dec__ProfileRollbackResponse(const OCTETSTRING
&stream) {
+ TTCN_Buffer buf;
+ ProfileRollbackResponse msg;
+ buf.put_os(stream);
+
+ msg.decode(ProfileRollbackResponse_descr_, buf, TTCN_EncDec::CT_BER,
BER_ACCEPT_ALL);
+ return msg;
+}
+
}
diff --git a/library/euicc/SGP32Definitions_Templates.ttcn
b/library/euicc/SGP32Definitions_Templates.ttcn
index 29e7579..c178a9c 100644
--- a/library/euicc/SGP32Definitions_Templates.ttcn
+++ b/library/euicc/SGP32Definitions_Templates.ttcn
@@ -437,4 +437,43 @@
}
}
+/* GSMA SGP.32, section 5.9.16 */
+template (present) ProfileRollbackRequest
+tr_profileRollbackRequest := {
+ refreshFlag := ?
+}
+template (value) ProfileRollbackRequest
+ts_profileRollbackRequest := {
+ refreshFlag := false
+}
+template (present) ProfileRollbackResponse
+tr_profileRollbackResponse := {
+ cmdResult := ?,
+ eUICCPackageResult := ?
+}
+template (value) ProfileRollbackResponse
+ts_profileRollbackResponse := {
+ cmdResult := 0,
+ eUICCPackageResult := {
+ euiccPackageResultSigned := {
+ euiccPackageResultDataSigned := {
+ eimId := "myEim",
+ counterValue := 333,
+ transactionId := omit,
+ seqNumber := 1234,
+ euiccResult := {
+ {
+ enableResult := 0
+ },
+ {
+ rollbackResult := 0
+ }
+ }
+ },
+ euiccSignEPR := 'AABBCCDDEEFF'O
+ }
+ }
+}
+
+
}
diff --git a/library/euicc/SGP32Definitions_Types.ttcn
b/library/euicc/SGP32Definitions_Types.ttcn
index 44a1a07..4b68e67 100644
--- a/library/euicc/SGP32Definitions_Types.ttcn
+++ b/library/euicc/SGP32Definitions_Types.ttcn
@@ -18,7 +18,10 @@
external function dec_GetEimConfigurationDataResponse(in octetstring stream)
return GetEimConfigurationDataResponse;
external function enc_GetEimConfigurationDataResponse(in
GetEimConfigurationDataResponse msg) return octetstring;
-external function dec_AddInitialEimResponse(in octetstring stream) return
AddInitialEimResponse;
-external function enc_AddInitialEimResponse(in AddInitialEimResponse msg)
return octetstring;
+external function dec_ProfileRollbackRequest(in octetstring stream) return
ProfileRollbackRequest;
+external function enc_ProfileRollbackRequest(in ProfileRollbackRequest msg)
return octetstring;
+
+external function dec_ProfileRollbackResponse(in octetstring stream) return
ProfileRollbackResponse;
+external function enc_ProfileRollbackResponse(in ProfileRollbackResponse msg)
return octetstring;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36609?usp=email
To unsubscribe,
[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add missing new line at the endo of file
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email ) Change subject: SGP32Definitions_Templates: add missing new line at the endo of file .. SGP32Definitions_Templates: add missing new line at the endo of file Related: SYS#6563 Change-Id: I0e7c3b514ba6569c3707ae20ed213591ca7d0e1c --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/36604/1 diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index f22778c..a8e0730 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -430,4 +430,4 @@ } } -} \ No newline at end of file +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0e7c3b514ba6569c3707ae20ed213591ca7d0e1c Gerrit-Change-Number: 36604 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: Allow API users to enable/disable SSL
Attention is currently required from: laforge, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: HTTP_Adapter: Allow API users to enable/disable SSL .. HTTP_Adapter: Allow API users to enable/disable SSL At the moment HTTP_Adapter has no option to enable SSL Related: SYS#6824 Change-Id: I6487deea50cd9b4ed4905d9a3a78e00def8ea319 --- M library/HTTP_Adapter.ttcn 1 file changed, 20 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/36506/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6487deea50cd9b4ed4905d9a3a78e00def8ea319 Gerrit-Change-Number: 36506 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add template tr_provideEimPackageResult_e...
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36608?usp=email )
Change subject: SGP32Definitions_Templates: add template
tr_provideEimPackageResult_ePRAndNotif
..
SGP32Definitions_Templates: add template tr_provideEimPackageResult_ePRAndNotif
Add a new template to verify the provideEimPackageResult request (ESipa)
from the IPAd
Related: SYS#6563
Change-Id: I86231f0e9dcef90abf60757cc55895863ad2b1b3
---
M library/euicc/SGP32Definitions_Templates.ttcn
1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/08/36608/1
diff --git a/library/euicc/SGP32Definitions_Templates.ttcn
b/library/euicc/SGP32Definitions_Templates.ttcn
index 36d77b4..29e7579 100644
--- a/library/euicc/SGP32Definitions_Templates.ttcn
+++ b/library/euicc/SGP32Definitions_Templates.ttcn
@@ -363,6 +363,15 @@
}
/* GSMA SGP.32, section 6.3.2.7 */
+template (present) EsipaMessageFromIpaToEim
+tr_provideEimPackageResult_ePRAndNotif := {
+ provideEimPackageResult := {
+ ePRAndNotifications := {
+ euiccPackageResult := ?,
+ notificationList := ?
+ }
+ }
+}
template (present) EsipaMessageFromEimToIpa
tr_provideEimPackageResultResponse_eimAck := {
provideEimPackageResultResponse := {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36608?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I86231f0e9dcef90abf60757cc55895863ad2b1b3
Gerrit-Change-Number: 36608
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: Allow API users to enable/disable SSL
Attention is currently required from: laforge, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506?usp=email )
Change subject: HTTP_Adapter: Allow API users to enable/disable SSL
..
Patch Set 2:
(1 comment)
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506/comment/5a1ab3b7_67eaf3da
PS1, Line 27: function f_http_init(charstring host, integer http_port, boolean
use_ssl := false) runs on http_CT {
> I agree it's likely useful, as there might be more and more parameters, like
> specifying certificates […]
Yes, we should do this rather sooner than later. I have now cleaned this up a
in a patch before this one.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6487deea50cd9b4ed4905d9a3a78e00def8ea319
Gerrit-Change-Number: 36506
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-CC: laforge
Gerrit-Attention: laforge
Gerrit-Attention: pespin
Gerrit-Comment-Date: Fri, 19 Apr 2024 11:55:40 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: use enable instead of configureAutoEnable...
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36606?usp=email )
Change subject: SGP32Definitions_Templates: use enable instead of
configureAutoEnable PSMO
..
SGP32Definitions_Templates: use enable instead of configureAutoEnable PSMO
The "enable" psmo is a more common example than the configureAutoEnable
PSMO.
Related: SYS#6563
Change-Id: Ia364d5f6d510545988dc88cacdd15a2c03cc5d8b
---
M library/euicc/SGP32Definitions_Templates.ttcn
1 file changed, 17 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/06/36606/1
diff --git a/library/euicc/SGP32Definitions_Templates.ttcn
b/library/euicc/SGP32Definitions_Templates.ttcn
index 140ab6e..1a33be4 100644
--- a/library/euicc/SGP32Definitions_Templates.ttcn
+++ b/library/euicc/SGP32Definitions_Templates.ttcn
@@ -259,10 +259,9 @@
euiccPackage := {
psmoList := {
{
- configureAutoEnable := {
- autoEnableFlag
:= NULL,
- smdpOid := omit,
- smdpAddress :=
omit
+ enable := {
+ iccid :=
'123456789ABCDEFF'O,
+ rollbackFlag :=
NULL
}
}
}
@@ -355,7 +354,7 @@
seqNumber := 1234,
euiccResult := {
{
- configureAutoEnableResult := 0
+ enableResult := 0
}
}
},
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36606?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia364d5f6d510545988dc88cacdd15a2c03cc5d8b
Gerrit-Change-Number: 36606
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: rename tx_provideEimPackageResultResponse
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36607?usp=email )
Change subject: SGP32Definitions_Templates: rename
tx_provideEimPackageResultResponse
..
SGP32Definitions_Templates: rename tx_provideEimPackageResultResponse
The template tr_provideEimPackageResultResponse and
ts_provideEimPackageResultResponse
should be renamed to tr_provideEimPackageResultResponse_eimAck and
ts_provideEimPackageResultResponse_eimAck as the TODO message says.
Related: SYS#6563
Change-Id: I68536eec6d04364efdbbbd5205788cf5c8ab3028
---
M library/euicc/SGP32Definitions_Templates.ttcn
1 file changed, 16 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/07/36607/1
diff --git a/library/euicc/SGP32Definitions_Templates.ttcn
b/library/euicc/SGP32Definitions_Templates.ttcn
index 1a33be4..36d77b4 100644
--- a/library/euicc/SGP32Definitions_Templates.ttcn
+++ b/library/euicc/SGP32Definitions_Templates.ttcn
@@ -363,15 +363,14 @@
}
/* GSMA SGP.32, section 6.3.2.7 */
-/* TODO rename tr_provideEimPackageResultResponse to something like
tr_provideEimPackageResultResponse_eimAck */
template (present) EsipaMessageFromEimToIpa
-tr_provideEimPackageResultResponse := {
+tr_provideEimPackageResultResponse_eimAck := {
provideEimPackageResultResponse := {
eimAcknowledgements := *
}
}
template (value) EsipaMessageFromEimToIpa
-ts_provideEimPackageResultResponse(template (value) EimAcknowledgements
eimAcknowledgements := {}) := {
+ts_provideEimPackageResultResponse_eimAck(template (value) EimAcknowledgements
eimAcknowledgements := {}) := {
provideEimPackageResultResponse := {
eimAcknowledgements := eimAcknowledgements
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36607?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I68536eec6d04364efdbbbd5205788cf5c8ab3028
Gerrit-Change-Number: 36607
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow body to be "omit"
Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: HTTP_Adapter: allow body to be "omit" .. HTTP_Adapter: allow body to be "omit" In HTTP not all requests have a body. At the moment we describe a missing body with body := "". This is not 100% correct since the rest of the code interprets this as a present body with zero length and will put a content_length = 0 header line into the HTTP header, even in the GET request. This will most likely be ignored by any HTTP server, but it is still not 100% spec compliant. Related: SYS#6824 Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff --- M library/HTTP_Adapter.ttcn 1 file changed, 38 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/36505/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff Gerrit-Change-Number: 36505 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: remove unrelated template parameter
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36605?usp=email )
Change subject: SGP32Definitions_Templates: remove unrelated template parameter
..
SGP32Definitions_Templates: remove unrelated template parameter
The template parameter eimFqdn is not relevant for this kind of
template.
Change-Id: I365fe15a22a98ced5c6a5d13b2700df1df13014b
Related: SYS#6563
---
M library/euicc/SGP32Definitions_Templates.ttcn
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/05/36605/1
diff --git a/library/euicc/SGP32Definitions_Templates.ttcn
b/library/euicc/SGP32Definitions_Templates.ttcn
index a8e0730..140ab6e 100644
--- a/library/euicc/SGP32Definitions_Templates.ttcn
+++ b/library/euicc/SGP32Definitions_Templates.ttcn
@@ -422,7 +422,7 @@
addInitialEimOk := ?
}
template (value) AddInitialEimResponse
-ts_addInitialEimResponse(template (value) charstring eimFqdn := "127.0.0.1")
:= {
+ts_addInitialEimResponse := {
addInitialEimOk := {
{
addOk := NULL
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36605?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I365fe15a22a98ced5c6a5d13b2700df1df13014b
Gerrit-Change-Number: 36605
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow API users to specifiy custom header
Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: HTTP_Adapter: allow API users to specifiy custom header .. HTTP_Adapter: allow API users to specifiy custom header At the moment HTTP_Adapter can only make requests with a fixed pre-defined HTTP header. However, some application may require additional custom header lines or different values than the ones specified in the pre-defined HTTP header. Related: SYS#6824 Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57 --- M library/HTTP_Adapter.ttcn 1 file changed, 63 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/36504/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57 Gerrit-Change-Number: 36504 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow body to be "omit"
Attention is currently required from: pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email )
Change subject: HTTP_Adapter: allow body to be "omit"
..
Patch Set 2:
(2 comments)
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505/comment/07586ff9_134a0346
PS1, Line 85: msg.request := {
> I'm not really liking this kind of functions you are adding here and in
> previous messages, it differ […]
I am not agreeing here. we are defining templates through functions in various
places, see SGsAP_Templates.ttcn or RANAP_Templates.ttcn. Its not done very
often, but its also not an exotic practice.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505/comment/f131a978_1300a78e
PS1, Line 148: template charstring body := omit, template
HTTPMessage exp := tr_HTTP_Resp2xx,
> this is most probably a "template (omit) charstring body".
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff
Gerrit-Change-Number: 36505
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Attention: pespin
Gerrit-Comment-Date: Fri, 19 Apr 2024 11:55:40 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: put HTTP config options into a record
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email )
Change subject: HTTP_Adapter: put HTTP config options into a record
..
HTTP_Adapter: put HTTP config options into a record
The function f_http_init currently takes only two config options. For the
moment this is not a problem, but the amount of additional options may grow
in the future. So let's put the options in a record to have them separate.
Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d
Related: SYS#6824
---
M cbc/CBC_Tests.ttcn
M library/HTTP_Adapter.ttcn
M remsim/RemsimServer_Tests.ttcn
3 files changed, 35 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/03/36603/1
diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn
index 2f1ad7f..18f9e6d 100644
--- a/cbc/CBC_Tests.ttcn
+++ b/cbc/CBC_Tests.ttcn
@@ -187,7 +187,12 @@
}
private function f_init(integer num_bsc := 0, integer num_mme := 0) runs on
test_CT {
- f_http_init(mp_cbc_host, mp_cbc_ecbe_port);
+ var HTTP_Adapter_cfg http_adapter_cfg;
+ http_adapter_cfg := {
+ host := mp_cbc_host,
+ http_port := mp_cbc_ecbe_port
+ };
+ f_http_init(http_adapter_cfg);
g_num_bsc := num_bsc;
for (var integer i := 0; i < g_num_bsc; i := i + 1) {
diff --git a/library/HTTP_Adapter.ttcn b/library/HTTP_Adapter.ttcn
index c54d599..b9448ff 100644
--- a/library/HTTP_Adapter.ttcn
+++ b/library/HTTP_Adapter.ttcn
@@ -23,10 +23,16 @@
var integer g_http_port;
};
-function f_http_init(charstring host, integer http_port) runs on http_CT {
+type record HTTP_Adapter_cfg {
+ charstring host,
+ integer http_port
+}
+
+function f_http_init(HTTP_Adapter_cfg cfg) runs on http_CT {
map(self:HTTP, system:HTTP);
- g_http_host := host;
- g_http_port := http_port;
+ g_http_host := cfg.host;
+ g_http_port := cfg.http_port;
+ g_use_ssl := use_ssl;
}
template (value) Connect ts_HTTP_Connect(template (value) charstring hostname,
diff --git a/remsim/RemsimServer_Tests.ttcn b/remsim/RemsimServer_Tests.ttcn
index 6d2b27d..7307faf 100644
--- a/remsim/RemsimServer_Tests.ttcn
+++ b/remsim/RemsimServer_Tests.ttcn
@@ -68,7 +68,12 @@
function f_rsres_init() runs on http_CT {
- f_http_init(mp_server_ip, mp_rsres_port);
+ var HTTP_Adapter_cfg http_adapter_cfg;
+ http_adapter_cfg := {
+ host := mp_server_ip,
+ http_port := mp_rsres_port
+ };
+ f_http_init(http_adapter_cfg);
f_rsres_post_reset();
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d
Gerrit-Change-Number: 36603
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow API users to specifiy custom header
Attention is currently required from: pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email )
Change subject: HTTP_Adapter: allow API users to specifiy custom header
..
Patch Set 2:
(4 comments)
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/a703254b_c50d7499
PS1, Line 41: function ts_HTTP_Header(template charstring body := omit,
> I'd prefer having this one prefixed "f_ts_", since it's actually a function.
> […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/c033169a_48c0c19c
PS1, Line 42: template charstring host := omit,
> template (omit) charstring
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/2752abad_bcf7364b
PS1, Line 55: if (ispresent(body)) {
> I'm not sure ispresent() can be used this way, or only for optional fields in
> a record. […]
I have verified that it works with ispresent(), but if (not
istemplatekind(body, "omit")) also works.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/05a2da73_5e253896
PS1, Line 59: /* Add custom header lines, already existing headers (name) are
updated */
> I think it makes sense to move this to a separate function "merge_headers()"
> or "overlay_headers()". […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57
Gerrit-Change-Number: 36504
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Attention: pespin
Gerrit-Comment-Date: Fri, 19 Apr 2024 11:55:40 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter, fixeria, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: IPAd_Tests: add testsuite for an IPAd .. IPAd_Tests: add testsuite for an IPAd With this patch we add a testsuite that can be used to test an IPAd implementation. The testsuite emulates the ESipa and the ES10x (pcsc cardreader) interface and is capable of testing a direct profile download and other ESipa features like the execution of an eIM package (eCO, PSMO). Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Related: SYS#6564 --- M Makefile A ipad/IPAd_Tests.cfg A ipad/IPAd_Tests.default A ipad/IPAd_Tests.ttcn A ipad/example_ca/easyrsa A ipad/example_ca/openssl-easyrsa.cnf A ipad/example_ca/pki/.rnd A ipad/example_ca/pki/ca.crt A ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem A ipad/example_ca/pki/extensions.temp A ipad/example_ca/pki/index.txt A ipad/example_ca/pki/index.txt.attr A ipad/example_ca/pki/index.txt.old A ipad/example_ca/pki/issued/alttest.cabundle A ipad/example_ca/pki/issued/alttest.crt A ipad/example_ca/pki/issued/alttest.notes A ipad/example_ca/pki/openssl-easyrsa.cnf A ipad/example_ca/pki/openssl-easyrsa.temp A ipad/example_ca/pki/private/alttest.key A ipad/example_ca/pki/private/ca.key A ipad/example_ca/pki/reqs/alttest.req A ipad/example_ca/pki/safessl-easyrsa.cnf A ipad/example_ca/pki/serial A ipad/example_ca/pki/serial.old A ipad/example_ca/vars A ipad/example_ca/x509-types A ipad/gen_links.sh A ipad/regen_makefile.sh M regen-makefile.sh 29 files changed, 1,940 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/36229/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Attention: dexter Gerrit-MessageType: newpatchset
[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure
Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email ) Change subject: sgsn: add testcases for SGSN Context Request procedure .. Patch Set 4: Code-Review+1 (1 comment) Patchset: PS3: > I first misunderstood your requests to remove the `log()` statements and > removed printing the unexpe […] I don't think this has real value once the test is in place, only during writing the test. It will just be polluting logs when running entire suites. But ok, let's merge it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Gerrit-Change-Number: 36589 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 19 Apr 2024 11:09:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure
Attention is currently required from: osmith, pespin. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: sgsn: add testcases for SGSN Context Request procedure .. sgsn: add testcases for SGSN Context Request procedure Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Related: SYS#6603, OS#6294 --- M library/GTPv1C_Templates.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 176 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/36589/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Gerrit-Change-Number: 36589 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match PDP Context IE
Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE .. sgsn: TC_sgsn_context_req_in: match PDP Context IE Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Related: SYS#6603, OS#6294 --- M library/GTPv1C_Templates.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 87 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/36601/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Gerrit-Change-Number: 36601 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36600?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs .. sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs Change-Id: Ie68794c309e548279381d044a3e34dcdf405084f Related: SYS#6603, OS#6294 --- M library/GTPv1C_Templates.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 55 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/00/36600/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie68794c309e548279381d044a3e34dcdf405084f Gerrit-Change-Number: 36600 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email ) Change subject: sgsn: add testcases for SGSN Context Request procedure .. Patch Set 3: (1 comment) Patchset: PS3: > Waiting for @vyanitskiy@sysmocom. […] I first misunderstood your requests to remove the `log()` statements and removed printing the unexpected messages from `setverdict()` statements. I prefer to keep the `log()` statements (and even added a few more) to better understand the testcase execution process/progress (e.g. when it gets stuck), but removed printing message bodies from them. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Gerrit-Change-Number: 36589 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Comment-Date: Fri, 19 Apr 2024 10:40:18 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match PDP Context IE
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email ) Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE .. Patch Set 4: (2 comments) File library/GTPv1C_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601/comment/b0dc5427_7e8ae552 PS3, Line 473: lengthf := ?, /* overwritten */ > These overwritten stuff doesn't make much sense here, should be dropped. Done File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601/comment/d8d6f76f_dd84395a PS3, Line 3765: pdp_ctx.pdp_typeorg := apars.addr.pdpTypeOrg; > All these should be passed in tr_PDP_Context_GTPC. This is not critical and can be improved later. I am leaving it as-is. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Gerrit-Change-Number: 36601 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: pespin Gerrit-Comment-Date: Fri, 19 Apr 2024 10:37:12 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email ) Change subject: sgsn: add testcases for SGSN Context Request procedure .. Patch Set 3: (1 comment) Patchset: PS3: Waiting for @vyanits...@sysmocom.de to really apply requested changes, as already disccussed over IM. It seems there was something unexpected in the push here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Gerrit-Change-Number: 36589 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 19 Apr 2024 10:25:02 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure
Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email ) Change subject: sgsn: add testcases for SGSN Context Request procedure .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Gerrit-Change-Number: 36589 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Fri, 19 Apr 2024 10:21:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ci[master]: jobs/ttcn3: run io_uring testsuites on all nodes
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36602?usp=email ) Change subject: jobs/ttcn3: run io_uring testsuites on all nodes .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36602?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I59b9a7c3928281a0557c17629029adcbc5ae7410 Gerrit-Change-Number: 36602 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Fri, 19 Apr 2024 10:19:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36600?usp=email ) Change subject: sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie68794c309e548279381d044a3e34dcdf405084f Gerrit-Change-Number: 36600 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Apr 2024 10:10:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in libosmocore[master]: osmo_io: Add iofd param to segmentation_cb
Attention is currently required from: daniel, fixeria, jolly. Hello Jenkins Builder, daniel, fixeria, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36582?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: osmo_io: Add iofd param to segmentation_cb .. osmo_io: Add iofd param to segmentation_cb See related ticket for full rant and historical facts about this callback. Since anyway we are still developing osmo_io stuff and there will be ABI breaks when releasing new version, let's udpate the callback signature too. Related: OS#6437 Change-Id: Ib8d77e30b1ea759ee5ac2a69d704e81ea71e3079 --- M include/osmocom/core/osmo_io.h M src/core/osmo_io.c 2 files changed, 53 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/36582/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36582?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib8d77e30b1ea759ee5ac2a69d704e81ea71e3079 Gerrit-Change-Number: 36582 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-MessageType: newpatchset
[S] Change in osmo-ci[master]: jobs/ttcn3: run io_uring testsuites on all nodes
osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ci/+/36602?usp=email )
Change subject: jobs/ttcn3: run io_uring testsuites on all nodes
..
jobs/ttcn3: run io_uring testsuites on all nodes
After most recent patches from Pau were merged, the io_uring testsuites
run on all jenkins nodes with the ttcn3 label again!
host2-deb11build-ansible has an older host kernel and needs ulimit
memlock increased to 1 GB. I've tried out e.g. 500 MB and it isn't
enough.
Closes: OS#6405
Change-Id: I59b9a7c3928281a0557c17629029adcbc5ae7410
---
M jobs/ttcn3-testsuites.yml
1 file changed, 19 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/02/36602/1
diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml
index a60c2a6..2e01645 100644
--- a/jobs/ttcn3-testsuites.yml
+++ b/jobs/ttcn3-testsuites.yml
@@ -219,25 +219,18 @@
# With LIBOSMO_IO_BACKEND=IO_URING (OS#6357)
- ttcn3-bsc-test-io_uring:
timer: H 11 * * *
- node: io_uring # OS#6405
- ttcn3-msc-test-io_uring:
timer: H 11 * * *
- node: io_uring # OS#6405
- ttcn3-hnbgw-test-io_uring:
timer: H 11 * * *
- node: io_uring # OS#6405
- ttcn3-gbproxy-test-io_uring:
timer: H 11 * * *
- node: io_uring # OS#6405
- ttcn3-sgsn-test-io_uring:
timer: H 11 * * *
- node: io_uring # OS#6405
- ttcn3-stp-test-io_uring:
timer: H 11 * * *
- node: io_uring # OS#6405
- ttcn3-mgw-test-io_uring:
timer: H 11 * * *
- node: io_uring # OS#6405
- job-template:
name: '{job-name}'
@@ -308,7 +301,8 @@
;;
*-io_uring)
DIR="$(echo "{job-name}" | sed s/\-io_uring$//)"
- export DOCKER_ARGS="-e LIBOSMO_IO_BACKEND=IO_URING"
+ # OS#6405: set memlock to 1 GB for older kernels
+ export DOCKER_ARGS="-e LIBOSMO_IO_BACKEND=IO_URING --ulimit
memlock=100"
;;
*-latest)
DIR="$(echo "{job-name}" | sed s/\-latest$//)"
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36602?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I59b9a7c3928281a0557c17629029adcbc5ae7410
Gerrit-Change-Number: 36602
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-MessageType: newchange
[S] Change in osmo-ttcn3-hacks[master]: library: GTPv1C: fix ts_MM_Context{GSM,UMTS} templates
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36599?usp=email )
Change subject: library: GTPv1C: fix ts_MM_Context{GSM,UMTS} templates
..
library: GTPv1C: fix ts_MM_Context{GSM,UMTS} templates
Set the values according to 3GPP TS 29.060 version 17.4.0 Release 17.
* Field 'spare' is defined as 'Spare ' in Table 40 (missing '1').
* Field 'spare1' is defined as 'Spare 111' in Table 41.
* Field 'security' must be set as per Table 47.
Change-Id: Ic8abb048f7c1fa795ee472820c5b88de0073dc66
Fixes: f95460b55 "GTP_Templates: Add templates for some GTPv1C IEs"
Fixes: fdde16846 "library: GTPv1C add ts_MM_ContextGSM"
---
M library/GTPv1C_Templates.ttcn
1 file changed, 22 insertions(+), 5 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/library/GTPv1C_Templates.ttcn b/library/GTPv1C_Templates.ttcn
index 0dc30be..e9cf797 100644
--- a/library/GTPv1C_Templates.ttcn
+++ b/library/GTPv1C_Templates.ttcn
@@ -346,10 +346,10 @@
mmcontGSM := {
lengthf := 0, /* overwritten */
cksn := cksn,
- spare := '0'B,
+ spare := '1'B,
usedCipher := gea,
- noofVectors := 0,
- security := '00'B, /* XXX */
+ noofVectors := 0, /* overwritten */
+ security := '01'B, /* GSM key and triplets */
kc := kc,
triplet := ''O,
drx_par := ''O,
@@ -372,9 +372,9 @@
usedGPRSIntegrityAlgorithm := '000'B,
ugipai := '1'B, /* Integrity Protection not
required */
gupii := '1'B, /* Ignore "Used GPRS integrity
protection algorithm" field" */
- spare1 := '000'B,
+ spare1 := '111'B,
noofVectors := 0, /* TODO: fill quintpuplets*/
- security := '01'B, /* UMTS key and quintuplets
*/
+ security := '10'B, /* UMTS key and quintuplets
*/
ck := ck,
ik := ik,
quintupletlength := 0, /* overwritten */
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36599?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic8abb048f7c1fa795ee472820c5b88de0073dc66
Gerrit-Change-Number: 36599
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in osmo-ttcn3-hacks[master]: library: GTPv1C: make ts_GTPC_SGSNContextAck more compact
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36598?usp=email )
Change subject: library: GTPv1C: make ts_GTPC_SGSNContextAck more compact
..
library: GTPv1C: make ts_GTPC_SGSNContextAck more compact
Change-Id: I9b0c948f295fd73fad79c8d09b45fd992c90a015
---
M library/GTPv1C_Templates.ttcn
1 file changed, 11 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/library/GTPv1C_Templates.ttcn b/library/GTPv1C_Templates.ttcn
index dcb8e60..0dc30be 100644
--- a/library/GTPv1C_Templates.ttcn
+++ b/library/GTPv1C_Templates.ttcn
@@ -1360,8 +1360,9 @@
private_extension_gtpc := omit
}
}
+
template (value) Gtp1cUnitdata ts_GTPC_SGSNContextAck(Gtp1cPeer peer,
OCT4 teid, uint16_t seq,
- template (value)
GTPC_PDUs SGSNContextAckPDU :=
ts_SGSNContextAckPDU(GTP_CAUSE_REQUEST_ACCEPTED)) := {
+ template (value)
GTPC_PDUs SGSNContextAckPDU := ts_SGSNContextAckPDU) := {
peer := peer,
gtpc := ts_GTP1C_PDU(sgsnContextAcknowledge, teid,
valueof(SGSNContextAckPDU), seq)
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36598?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9b0c948f295fd73fad79c8d09b45fd992c90a015
Gerrit-Change-Number: 36598
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure
Attention is currently required from: osmith, pespin. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sgsn: add testcases for SGSN Context Request procedure .. sgsn: add testcases for SGSN Context Request procedure Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Related: SYS#6603, OS#6294 --- M library/GTPv1C_Templates.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 171 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/36589/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Gerrit-Change-Number: 36589 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email )
Change subject: sgsn: add testcases for SGSN Context Request procedure
..
Patch Set 2:
(2 comments)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589/comment/6377ced0_fd15be8d
PS2, Line 3807: log("Rx SGSN Context Request from SGSN: ",
gtpc_ud.gtpc);
> This log is most probably not needed, only polluting output.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589/comment/b778b835_2170f575
PS2, Line 3852: log("Rx SGSN Context ACK from SGSN: ",
gtpc_ud.gtpc);
> same, not needed.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c
Gerrit-Change-Number: 36589
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-Attention: osmith
Gerrit-Attention: pespin
Gerrit-Comment-Date: Fri, 19 Apr 2024 09:56:22 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Make tag collisions harder
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36597?usp=email )
Change subject: SIP_Templates: Make tag collisions harder
..
SIP_Templates: Make tag collisions harder
It was spotted during some test runs that the same tag was assigned to 2
different components. Let's make this way more difficult by adding some
time to it. Asterisk uses longer strings for instance, since 32bits is
the minimum.
Change-Id: Iba26259fd48da1c2558451fe5f7014151d4935c8
---
M asterisk/gen_links.sh
M asterisk/regen_makefile.sh
M library/SIP_Templates.ttcn
M sip/gen_links.sh
M sip/regen_makefile.sh
5 files changed, 23 insertions(+), 2 deletions(-)
Approvals:
osmith: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/asterisk/gen_links.sh b/asterisk/gen_links.sh
index 97df3a2..c342e51 100755
--- a/asterisk/gen_links.sh
+++ b/asterisk/gen_links.sh
@@ -7,6 +7,7 @@
DIR=$BASEDIR/titan.Libraries.TCCUsefulFunctions/src
FILES="TCCInterface_Functions.ttcn TCCConversion_Functions.ttcn
TCCConversion.cc TCCInterface.cc TCCInterface_ip.h "
FILES+="TCCOpenSecurity_Functions.ttcn TCCOpenSecurity.cc
TCCOpenSecurity_Functions.hh "
+FILES+="TCCDateTime.cc TCCDateTime_Functions.ttcn"
gen_links $DIR $FILES
DIR=$BASEDIR/titan.TestPorts.Common_Components.Socket-API/src
diff --git a/asterisk/regen_makefile.sh b/asterisk/regen_makefile.sh
index 1aa18ae..5d5538e 100755
--- a/asterisk/regen_makefile.sh
+++ b/asterisk/regen_makefile.sh
@@ -15,6 +15,7 @@
TCCConversion.cc
TCCInterface.cc
TCCOpenSecurity.cc
+ TCCDateTime.cc
TELNETasp_PT.cc
"
diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn
index be07196..e115bb7 100644
--- a/library/SIP_Templates.ttcn
+++ b/library/SIP_Templates.ttcn
@@ -3,6 +3,7 @@
import from SIPmsg_Types all;
import from TCCConversion_Functions all;
import from TCCOpenSecurity_Functions all;
+import from TCCDateTime_Functions all;
import from Native_Functions all;
import from Osmocom_Types all;
import from Misc_Helpers all;
@@ -1151,10 +1152,12 @@
req.msgHeader.cSeq.seqNumber :=
f_sip_next_seq_nr(valueof(req.msgHeader.cSeq.seqNumber));
}
-/* Tags shall have at least 32 bit of randomness */
function f_sip_rand_tag() return charstring {
+ /* Tags shall have at least 32 bit of randomness */
var integer rnd_int := f_rnd_int(4294967296);
- return hex2str(int2hex(rnd_int, 8));
+ /* Make collisions harder by appending time to the final string: */
+ var integer ts_int := f_time_ms() mod 4294967296;
+ return hex2str(int2hex(rnd_int, 8)) & "-" & hex2str(int2hex(ts_int, 8));
}
/* Generate a "branch" tag value.
diff --git a/sip/gen_links.sh b/sip/gen_links.sh
index d12e23c..4c8456c 100755
--- a/sip/gen_links.sh
+++ b/sip/gen_links.sh
@@ -11,6 +11,7 @@
DIR=$BASEDIR/titan.Libraries.TCCUsefulFunctions/src
FILES="TCCInterface_Functions.ttcn TCCConversion_Functions.ttcn
TCCConversion.cc TCCInterface.cc TCCInterface_ip.h "
FILES+="TCCOpenSecurity_Functions.ttcn TCCOpenSecurity.cc
TCCOpenSecurity_Functions.hh "
+FILES+="TCCDateTime.cc TCCDateTime_Functions.ttcn"
gen_links $DIR $FILES
DIR=$BASEDIR/titan.TestPorts.Common_Components.Socket-API/src
diff --git a/sip/regen_makefile.sh b/sip/regen_makefile.sh
index ecec62b..b737316 100755
--- a/sip/regen_makefile.sh
+++ b/sip/regen_makefile.sh
@@ -18,6 +18,7 @@
TCCConversion.cc
TCCInterface.cc
TCCOpenSecurity.cc
+ TCCDateTime.cc
TELNETasp_PT.cc
UD_PT.cc
"
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36597?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iba26259fd48da1c2558451fe5f7014151d4935c8
Gerrit-Change-Number: 36597
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Make tag collisions harder
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36597?usp=email ) Change subject: SIP_Templates: Make tag collisions harder .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba26259fd48da1c2558451fe5f7014151d4935c8 Gerrit-Change-Number: 36597 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Fri, 19 Apr 2024 09:36:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: osmo_io: Add iofd param to segmentation_cb
Attention is currently required from: daniel, fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36582?usp=email ) Change subject: osmo_io: Add iofd param to segmentation_cb .. Patch Set 2: Code-Review-2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36582?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib8d77e30b1ea759ee5ac2a69d704e81ea71e3079 Gerrit-Change-Number: 36582 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Fri, 19 Apr 2024 09:28:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: osmo_io: Add iofd param to segmentation_cb
Attention is currently required from: daniel, fixeria, jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36582?usp=email ) Change subject: osmo_io: Add iofd param to segmentation_cb .. Patch Set 2: (1 comment) Patchset: PS2: I'd prefer to introduce a cb2 and keep the old signature, as you suggested as alternative in the redmine issue. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36582?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib8d77e30b1ea759ee5ac2a69d704e81ea71e3079 Gerrit-Change-Number: 36582 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Attention: jolly Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Fri, 19 Apr 2024 07:18:24 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Make tag collisions harder
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36597?usp=email ) Change subject: SIP_Templates: Make tag collisions harder .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba26259fd48da1c2558451fe5f7014151d4935c8 Gerrit-Change-Number: 36597 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Fri, 19 Apr 2024 07:14:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: library: GTPv1C: make ts_GTPC_SGSNContextAck more compact
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36598?usp=email ) Change subject: library: GTPv1C: make ts_GTPC_SGSNContextAck more compact .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9b0c948f295fd73fad79c8d09b45fd992c90a015 Gerrit-Change-Number: 36598 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Fri, 19 Apr 2024 07:12:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36600?usp=email ) Change subject: sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie68794c309e548279381d044a3e34dcdf405084f Gerrit-Change-Number: 36600 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 19 Apr 2024 07:11:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: library: GTPv1C: fix ts_MM_Context{GSM,UMTS} templates
Attention is currently required from: fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36599?usp=email )
Change subject: library: GTPv1C: fix ts_MM_Context{GSM,UMTS} templates
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36599?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic8abb048f7c1fa795ee472820c5b88de0073dc66
Gerrit-Change-Number: 36599
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-Attention: fixeria
Gerrit-Comment-Date: Fri, 19 Apr 2024 07:10:16 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: library: GTPv1C: make ts_GTPC_SGSNContextAck more compact
Attention is currently required from: fixeria, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36598?usp=email ) Change subject: library: GTPv1C: make ts_GTPC_SGSNContextAck more compact .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9b0c948f295fd73fad79c8d09b45fd992c90a015 Gerrit-Change-Number: 36598 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 19 Apr 2024 07:09:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
