[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
daniel has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email )
Change subject: stream: Add client-side (segmentation) support for IPA
..
stream: Add client-side (segmentation) support for IPA
With this commit, IPA segmentation is taken care of by setting the
segmentation callback provided by libosmo-netif.
The ipa-stream-server example needs to prepend IPA headers now because
those are stripped by the segm. cb on both sides.
Depends: libosmocore.git I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f
Related: OS#5753, OS#5751
Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6
---
M examples/ipa-stream-client.c
M examples/ipa-stream-server.c
M include/osmocom/netif/stream.h
M src/stream_cli.c
M tests/stream/stream_test.c
M tests/stream/stream_test.err
M tests/stream/stream_test.ok
7 files changed, 333 insertions(+), 18 deletions(-)
Approvals:
daniel: Looks good to me, approved
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, but someone else must approve
diff --git a/examples/ipa-stream-client.c b/examples/ipa-stream-client.c
index 10eb786..db7d441 100644
--- a/examples/ipa-stream-client.c
+++ b/examples/ipa-stream-client.c
@@ -106,7 +106,7 @@
static int read_cb(struct osmo_stream_cli *conn, struct msgb *msg)
{
- LOGP(DIPATEST, LOGL_DEBUG, "received message from stream (len=%d)\n",
msgb_length(msg));
+ LOGP(DIPATEST, LOGL_DEBUG, "received message from stream (payload
len=%d)\n", msgb_length(msg));
if (osmo_ipa_process_msg(msg) < 0) {
LOGP(DIPATEST, LOGL_ERROR, "bad IPA message\n");
@@ -116,7 +116,7 @@
int num;
struct msg_sent *cur, *tmp, *found = NULL;
- num = ntohl(*((int *)(msg->data + sizeof(struct ipa_head) +
sizeof(struct ipa_head_ext;
+ num = osmo_load32be(msg->data);
LOGP(DLINP, LOGL_DEBUG, "received msg number %d\n", num);
llist_for_each_entry_safe(cur, tmp, _sent_list, head) {
@@ -184,6 +184,8 @@
exit(EXIT_FAILURE);
}
+ osmo_stream_cli_set_segmentation_cb(conn, osmo_ipa_segmentation_cb);
+
LOGP(DIPATEST, LOGL_NOTICE, "Entering main loop\n");
while(1) {
diff --git a/examples/ipa-stream-server.c b/examples/ipa-stream-server.c
index 1caef96..d31b752 100644
--- a/examples/ipa-stream-server.c
+++ b/examples/ipa-stream-server.c
@@ -49,7 +49,10 @@
int read_cb(struct osmo_stream_srv *conn, struct msgb *msg)
{
- LOGP(DSTREAMTEST, LOGL_DEBUG, "received message from stream
(len=%d)\n", msgb_length(msg));
+ LOGP(DSTREAMTEST, LOGL_DEBUG, "received message from stream (payload
len=%d)\n", msgb_length(msg));
+
+ ipa_prepend_header_ext(msg, IPAC_PROTO_EXT_MGCP);
+ osmo_ipa_msg_push_header(msg, IPAC_PROTO_OSMO);
osmo_stream_srv_send(conn, msg);
return 0;
diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h
index 6ee5820..a24244c 100644
--- a/include/osmocom/netif/stream.h
+++ b/include/osmocom/netif/stream.h
@@ -100,6 +100,7 @@
void osmo_stream_cli_set_disconnect_cb(struct osmo_stream_cli *cli, int
(*disconnect_cb)(struct osmo_stream_cli *cli));
void osmo_stream_cli_set_read_cb(struct osmo_stream_cli *cli, int
(*read_cb)(struct osmo_stream_cli *cli));
void osmo_stream_cli_set_read_cb2(struct osmo_stream_cli *cli, int
(*read_cb)(struct osmo_stream_cli *cli, struct msgb *msg));
+void osmo_stream_cli_set_segmentation_cb(struct osmo_stream_cli *cli, int
(*segmentation_cb)(struct msgb *msg));
void osmo_stream_cli_reconnect(struct osmo_stream_cli *cli);
bool osmo_stream_cli_is_connected(struct osmo_stream_cli *cli);
diff --git a/src/stream_cli.c b/src/stream_cli.c
index 23e1900..ef571cc 100644
--- a/src/stream_cli.c
+++ b/src/stream_cli.c
@@ -119,6 +119,7 @@
int (*read_cb)(struct osmo_stream_cli *cli);
int (*iofd_read_cb)(struct osmo_stream_cli *cli, struct msgb *msg);
int (*write_cb)(struct osmo_stream_cli *cli);
+ int (*segmentation_cb)(struct msgb *msg);
void*data;
int flags;
int reconnect_timeout;
@@ -419,6 +420,7 @@
cli->state = STREAM_CLI_STATE_CLOSED;
osmo_timer_setup(>timer, cli_timer_cb, cli);
cli->reconnect_timeout = 5; /* default is 5 seconds. */
+ cli->segmentation_cb = NULL;
INIT_LLIST_HEAD(>tx_queue);
cli->ma_pars.sctp.version = 0;
@@ -585,6 +587,29 @@
cli->flags |= OSMO_STREAM_CLI_F_RECONF;
}
+/* Configure client side segmentation for the iofd */
+static void configure_cli_segmentation_cb(struct osmo_io_fd *iofd,
+ int (*segmentation_cb)(struct
msgb *msg))
+{
+ /* Copy default settings */
+ struct osmo_io_ops client_ops = osmo_stream_cli_ioops;
+ /* Set
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, laforge, osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 23: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 23 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: arehbein Gerrit-Attention: laforge Gerrit-Comment-Date: Mon, 02 Oct 2023 13:39:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, laforge, osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 23: (1 comment) Patchset: PS20: > Yes, it's about the test. […] osmo_sock_init2() has OSMO_SOCK_F_BIND set in flags which will enable SO_REUSEADDR (in src/core/socket.c l.392-405). For the timestamp issue ideally we are able to reproduce it at some point, so we should keep the timestamps in the test for now. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 23 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: arehbein Gerrit-Attention: laforge Gerrit-Comment-Date: Mon, 02 Oct 2023 12:52:27 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein Comment-In-Reply-To: laforge Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, daniel, laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 23: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 23 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: arehbein Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-Comment-Date: Mon, 02 Oct 2023 09:24:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, daniel, fixeria, laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 23: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 23 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: arehbein Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Sun, 01 Oct 2023 22:24:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: daniel, fixeria, laforge, osmith, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 22: (1 comment) Patchset: PS20: > Is this just about the test? Are we using REUSEADDR and/or REUSEPORT? Yes, it's about the test. I don't think so, neither flag is being passed to `osmo_sock_init()` in libosmo-netif. https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs/2208/consoleFull The 'bug' has appeared again (a search for '632499' will jump to the error). Should we just remove timestamps @dwillm...@sysmocom.de ? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 22 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Thu, 28 Sep 2023 23:13:27 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein Comment-In-Reply-To: laforge Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, daniel, fixeria, laforge, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email to look at the new patch set (#22). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: stream: Add client-side (segmentation) support for IPA .. stream: Add client-side (segmentation) support for IPA With this commit, IPA segmentation is taken care of by setting the segmentation callback provided by libosmo-netif. The ipa-stream-server example needs to prepend IPA headers now because those are stripped by the segm. cb on both sides. Depends: libosmocore.git I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Related: OS#5753, OS#5751 Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 --- M examples/ipa-stream-client.c M examples/ipa-stream-server.c M include/osmocom/netif/stream.h M src/stream_cli.c M tests/stream/stream_test.c M tests/stream/stream_test.err M tests/stream/stream_test.ok 7 files changed, 333 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/98/33198/22 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 22 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: arehbein Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-MessageType: newpatchset
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, daniel, fixeria, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: Code-Review+1 (3 comments) Patchset: PS20: > After adapting `stream_test. […] Is this just about the test? Are we using REUSEADDR and/or REUSEPORT? Patchset: PS21: > The plan is to tackle this kind of task once these preliminary libosmo-netif > changes have been submi […] Done PS21: > The patch for fixing the aliasing problem has been merged. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: arehbein Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Tue, 26 Sep 2023 14:01:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith Comment-In-Reply-To: arehbein Comment-In-Reply-To: laforge Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: daniel, fixeria, laforge, osmith. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: (1 comment) File examples/ipa-stream-client.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/2cf94fa4_77e7c5e3 PS21, Line 119: sizeof(struct ipa_head) + sizeof(struct ipa_head_ext > Just to confirm, this offset is no more needed? Yes, the segmentation callback is stripping the IPA headers (see here: https://gerrit.osmocom.org/c/libosmo-netif/+/33652/6/src/ipa.c ) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Wed, 20 Sep 2023 19:38:53 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, daniel, laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: (1 comment) File examples/ipa-stream-client.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/b9c7ed08_9493a940 PS21, Line 119: sizeof(struct ipa_head) + sizeof(struct ipa_head_ext Just to confirm, this offset is no more needed? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: arehbein Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-Comment-Date: Wed, 20 Sep 2023 16:39:10 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: daniel, fixeria, laforge, osmith. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: (1 comment) Patchset: PS21: > Patch to take care of type punning: https://gerrit.osmocom. […] The patch for fixing the aliasing problem has been merged. Hopefully, this Heisenbug here has been taken care of with that. So, as Daniel has also previously suggested, I would say let's get this patch merged and if we should encounter the timestamp issue again (if the issue should persist, it would pop up every now and then, but not on each build), then we can save the build binary `libosmo-netif.git:tests/stream/stream_test` from the failed Jenkins build (couldn't do that for the Jenkins build triggered by Gerrit patches, because it doesn't keep these build files) and investigate, if we really want to get into that again. Or we can remove timestamps from the test. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Tue, 19 Sep 2023 18:54:32 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: arehbein Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: daniel, fixeria, laforge, osmith. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: (1 comment) Patchset: PS21: > (type punning was one of the changes added right before I left, and this > timestamp issue never appea […] Patch to take care of type punning: https://gerrit.osmocom.org/c/libosmo-netif/+/34445 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Sat, 16 Sep 2023 20:54:29 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: arehbein Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: daniel, fixeria, laforge, osmith. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: (2 comments) Patchset: PS21: An alter PS21: > What we have observed was that sometimes, an arbitrary number of loop > iterations is needed until the […] (type punning was one of the changes added right before I left, and this timestamp issue never appeared until these commits were rebased on the new patch variant introducing type punning). Anyways, another possibility would be removing the timestamps from the tests (this as CR-2ed before, though) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Wed, 13 Sep 2023 18:25:06 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: arehbein Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: daniel, fixeria, laforge, osmith. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: (2 comments) Patchset: PS21: > what I don't really understand here is why there is no code being removed. […] The plan is to tackle this kind of task once these preliminary libosmo-netif changes have been submitted. PS21: > I guess printing the timestamp infront of the log should just be removed? > from a quick glance this s […] What we have observed was that sometimes, an arbitrary number of loop iterations is needed until the code section in question becomes active (each loop iteration contains one timestamp increment), and sometimes the code needs exactly the minimum number of loop needed. I'm suspecting it's due to nondeterministic compiler behavior, probably caused by type punning (Vadim has also already seen a warning because of this). The reason for this assumption being that behavior never differed for the same binary and only changed between compilations, even for the same code (but with changed timestamps due to trying different commits etc. in between). I will add a patch suggestion to get rid of the type punning, hoping we won't see this ever again. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Wed, 13 Sep 2023 18:22:24 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: arehbein Comment-In-Reply-To: laforge Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, fixeria, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: (1 comment) Patchset: PS21: what I don't really understand here is why there is no code being removed. If we are pushing the ipa [de]segmentation down the stack into the libraries, then shouldn't the code dealing with it so far be removed from the call chain somewhere? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: arehbein Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 13 Sep 2023 08:14:26 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: arehbein Gerrit-Attention: fixeria Gerrit-Comment-Date: Thu, 07 Sep 2023 14:57:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, fixeria, osmith, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: (1 comment) Patchset: PS21: > I guess printing the timestamp infront of the log should just be removed? > from a quick glance this s […] I just retriggered jenkins and it succeeds again... The tests uses osmo's gettimeofday_override functionality so it shouldn't cause these weird changes due to (wall clock) time delays. It's counting main loop iterations and the only way a mismatch could happen here (that I can think of) is if either the sending fd wasn't writable after enqueuing the msg or the receiving fd didn't become readable directly after the write. So it's definitely worrying that we don't know the cause for this issue, but since nobody can reproduce it right now I'd say we continue with this patch (with timestamps) and see if it resurfaces. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: arehbein Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Thu, 07 Sep 2023 14:05:45 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: arehbein Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, daniel, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: (1 comment) Patchset: PS21: > Sorry for the false alarm @osm...@sysmocom.de , and thanks for taking a look. > […] I guess printing the timestamp infront of the log should just be removed? from a quick glance this seems to be the problem, if there is more load on the machine then it may pause for a bit before doing the next loop iteration, which leads to getting different timestamps. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-Attention: arehbein Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Thu, 07 Sep 2023 08:46:35 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: arehbein Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: daniel, fixeria, osmith, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: (1 comment) Patchset: PS21: > Funny enough this seems to be the issue arehbein is having with timestamps Sorry for the false alarm @osm...@sysmocom.de , and thanks for taking a look. @dwillm...@sysmocom.de yeah, very much looks like it. Can't reproduce it anymore right now... the local build showed no issues right before the upload. It might be interesting to try the Jenkins build again a few times and see if it fails for the exact same job. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Wed, 06 Sep 2023 17:37:43 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: arehbein Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, fixeria, osmith, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: (1 comment) Patchset: PS21: > patch for running "make check" in jenkins.sh: https://gerrit.osmocom. […] Funny enough this seems to be the issue arehbein is having with timestamps -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: arehbein Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 05 Sep 2023 13:12:55 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: arehbein Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, daniel, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: (1 comment) Patchset: PS21: > the actual error is further above in the log: […] patch for running "make check" in jenkins.sh: https://gerrit.osmocom.org/c/libosmo-netif/+/34311 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-Attention: arehbein Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Tue, 05 Sep 2023 09:16:55 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: arehbein Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, daniel, fixeria, pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email )
Change subject: stream: Add client-side (segmentation) support for IPA
..
Patch Set 21:
(1 comment)
Patchset:
PS21:
> Excerpt from current build failure: […]
the actual error is further above in the log:
```
1. testsuite.at:4: testing stream_test ...
./testsuite.at:8: $abs_top_builddir/tests/stream/stream_test
--- expout 2023-09-04 17:53:46.409216560 +
+++ /obs/_temp/binpkgs/libosmo-netif/tests/testsuite.dir/at-groups/1/stdout
2023-09-04 17:53:46.637217558 +
@@ -169,21 +169,21 @@
{20.625031} [NA|OK] Server's send_last_third_srv():Sending:[ Last third of
IPAC_MSGT_ID_GET | IPAC_MSGT_PONG | IPAC_MSGT_PONG ]
{20.625031} [NA|OK] Server's send_last_third_srv():(msg dump: 01 01 00 01
fe 01 00 01 fe 01 )
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [5-cli]
Received message from stream (len = 3)
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg
buff data: 04 01 01
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA
payload: 04 01 01
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type:
IPAC_MSGT_ID_GET
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg
dump (including stripped headers): 00 03 fe 04 01 01 )
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [6-cli]
Received message from stream (len = 1)
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg
buff data: 01
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA
payload: 01
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type:
IPAC_MSGT_PONG
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg
dump (including stripped headers): 00 01 fe 01 )
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [7-cli]
Received message from stream (len = 1)
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg
buff data: 01
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA
payload: 01
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type:
IPAC_MSGT_PONG
-{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg
dump (including stripped headers): 00 01 fe 01 )
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [5-cli]
Received message from stream (len = 3)
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg
buff data: 04 01 01
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA
payload: 04 01 01
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type:
IPAC_MSGT_ID_GET
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg
dump (including stripped headers): 00 03 fe 04 01 01 )
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [6-cli]
Received message from stream (len = 1)
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg
buff data: 01
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA
payload: 01
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type:
IPAC_MSGT_PONG
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg
dump (including stripped headers): 00 01 fe 01 )
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [7-cli]
Received message from stream (len = 1)
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg
buff data: 01
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA
payload: 01
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type:
IPAC_MSGT_PONG
+{20.625576} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg
dump (including stripped headers): 00 01 fe 01 )
==Test test_segm_ipa_stream_cli
complete
Stream tests completed
1. testsuite.at:4: 1. stream_test (testsuite.at:4): FAILED (testsuite.at:8)
```
In addition to that, there is a bug in contrib/jenkins.sh: it does not run
"make check" as it is doing in most other Osmocom projects. Otherwise the
testsuite would fail there as well.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 21
Gerrit-Owner: arehbein
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-CC:
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: daniel, fixeria, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: (2 comments) Patchset: PS19: > *timestamp behavior of the second half of the test […] Done Patchset: PS21: Excerpt from current build failure: ``` | configure: exit 0 make[1]: *** [debian/rules:27: override_dh_auto_test] Error 1 make[1]: Leaving directory '/obs/_temp/binpkgs/libosmo-netif' make: *** [debian/rules:13: build] Error 2 dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 ERROR: build failed! ``` -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Mon, 04 Sep 2023 18:17:38 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein Comment-In-Reply-To: pespin Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: daniel, fixeria, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email to look at the new patch set (#21). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: stream: Add client-side (segmentation) support for IPA .. stream: Add client-side (segmentation) support for IPA With this commit, IPA segmentation is taken care of by setting the segmentation callback provided by libosmo-netif. The ipa-stream-server example needs to prepend IPA headers now because those are stripped by the segm. cb on both sides. Depends: libosmocore.git I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Related: OS#5753, OS#5751 Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 --- M examples/ipa-stream-client.c M examples/ipa-stream-server.c M include/osmocom/netif/stream.h M src/stream_cli.c M tests/stream/stream_test.c M tests/stream/stream_test.err M tests/stream/stream_test.ok 7 files changed, 337 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/98/33198/21 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-MessageType: newpatchset
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: pespin, fixeria, daniel. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 20: (1 comment) Patchset: PS19: > I have added a patch eliminating timestamp logging in the test: […] *timestamp behavior of the second half of the test to be more exact. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 20 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Sun, 27 Aug 2023 22:26:31 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein Comment-In-Reply-To: pespin Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: pespin, fixeria, daniel.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33198 )
Change subject: stream: Add client-side (segmentation) support for IPA
..
Patch Set 20:
(2 comments)
Patchset:
PS19:
> But if that's unrelated to this patch and it shows up as a result of rebase,
> better submit a precedi […]
I have added a patch eliminating timestamp logging in the test:
https://gerrit.osmocom.org/c/libosmo-netif/+/34224
I don't know what the cause is, but it appears recent changes to libosmocore or
libosmo-netif have changed the timestamp behavior which used to be predictable.
Patchset:
PS20:
After adapting `stream_test.err` to some of the new logs (locally), a
connectivity issue (it's not just the logging, a lag that I didn't have before
comes along with the following output) has appeared
```
unable to connect socket: 127.0.0.11:: Cannot assign requested address
no suitable remote addr found for: 127.0.0.11:
CLICONN(,){WAIT_RECONNECT} retrying reconnect in 5 seconds...
Cannot open stream client
```
It's not any patches in libosmocore causing this new behavior (I tried an older
libosmocore patch, that didn't change anything), so I took a look at
libosmo-netif and saw a couple of recent changes, probably something there.
A workaround for this was changing the port for the stream client tests from
to 1112 (similarly to how I had to change the local port from 8967 to
something else in order for osmo time not becoming unpredictable...).
But I do wonder if this shouldn't be addressed (somehow after destroying the
client, and reopening the server link, the same port remains blocked for a
noticeable amount of time, apart from the error log).
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 20
Gerrit-Owner: arehbein
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-CC: daniel
Gerrit-CC: fixeria
Gerrit-Attention: pespin
Gerrit-Attention: fixeria
Gerrit-Attention: daniel
Gerrit-Comment-Date: Sun, 27 Aug 2023 22:19:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein
Comment-In-Reply-To: pespin
Comment-In-Reply-To: daniel
Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, fixeria, daniel. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 to look at the new patch set (#20). Change subject: stream: Add client-side (segmentation) support for IPA .. stream: Add client-side (segmentation) support for IPA With this commit, IPA segmentation is taken care of by setting the segmentation callback provided by libosmo-netif. The ipa-stream-server example needs to prepend IPA headers now because those are stripped by the segm. cb on both sides. Depends: libosmocore.git I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Related: OS#5753, OS#5751 Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 --- M examples/ipa-stream-client.c M examples/ipa-stream-server.c M include/osmocom/netif/stream.h M src/stream_cli.c M tests/stream/stream_test.c M tests/stream/stream_test.err M tests/stream/stream_test.ok 7 files changed, 337 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/98/33198/20 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 20 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Attention: arehbein Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-MessageType: newpatchset
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, fixeria, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 19: (1 comment) Patchset: PS19: > Better configure logging in the test :) But if that's unrelated to this patch and it shows up as a result of rebase, better submit a preceding patch adding all that? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 19 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Attention: arehbein Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Fri, 25 Aug 2023 16:10:57 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein Comment-In-Reply-To: pespin Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, fixeria, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 19: (1 comment) Patchset: PS19: > I just tried […] Better configure logging in the test :) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 19 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Attention: arehbein Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Fri, 25 Aug 2023 16:10:21 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein Comment-In-Reply-To: pespin Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: pespin, fixeria, daniel. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 19: (1 comment) Patchset: PS19: > So I changed the local port for the stream test from 8967 (previously used) > to 8977 and the test ran […] I just tried ``` log_set_print_timestamp(osmo_stderr_target, 0); ``` in `tests/stream/stream_test.c` and got an immediate segfault (glanced at the code and I guess it's because the logging system isn't initialized by the test, it just uses `osmo_gettimeofday()` and custom macros for logging). I could remove all the time logging instead from the macros defined in the test code. If that's what we want. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 19 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Fri, 25 Aug 2023 16:02:08 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein Comment-In-Reply-To: pespin Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: pespin, fixeria, daniel. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 19: (1 comment) Patchset: PS19: > that's probably because you are not using fake time during the test. […] So I changed the local port for the stream test from 8967 (previously used) to 8977 and the test ran through. I tried it out before without this change and it worked once though, so I'm not sure what's going on. Fix for already merged commit is Ib8f01c3651c13814c212328946415094da39d6a8 I could add another patch to disable logging timestamps -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 19 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Fri, 25 Aug 2023 15:49:46 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein Comment-In-Reply-To: pespin Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, fixeria, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 19: Code-Review+1 (1 comment) Patchset: PS19: > I rechecked and all of a sudden, the timestamps aren't deterministic anymore. > […] that's probably because you are not using fake time during the test. But I'm not sure whether logging actually uses fake time. In any case, you should disable logging timestamps in tests. See for instance: """ tests/gsup/gsup_test.c 753:log_set_print_timestamp(osmo_stderr_target, 0); """ -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 19 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Attention: arehbein Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Fri, 25 Aug 2023 15:42:25 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: arehbein Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: fixeria, daniel. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 19: (1 comment) Patchset: PS19: > yeah currently working on it. […] I rechecked and all of a sudden, the timestamps aren't deterministic anymore. What could be the reason? I only added the local port config statements and changed the .err file timestamps aren't just different from the ones in the .ok file, they're consistently different each time I run the tests -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 19 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Fri, 25 Aug 2023 15:31:24 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: fixeria, daniel. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 19: (1 comment) Patchset: PS19: > > Patch Set 19: Verified-1 […] yeah currently working on it. This already is happening with the parent commit locally (I suppose because I didn't rebase before merging, would be good to have some build(test) check to be run before actually submitting, but I have no idea is Gerrit supports some sort of 'pre-submit' hook). Having a really weird issue with test times now all of a sudden though (the times printed to stdout by the test don't match the ones in the .ok-file)... not sure where it comes from -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 19 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Fri, 25 Aug 2023 15:28:59 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 19: (1 comment) Patchset: PS19: > Patch Set 19: Verified-1 > > 3 failed: Seems the rebase elevated some DEBUG messages to INFO which causes the tests to fail. You probably need to call set_local_port in the new tests (so the log entries don't vary) and then regenerate the test output -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 19 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Attention: arehbein Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 25 Aug 2023 15:06:14 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 18: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 18 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: arehbein Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 25 Aug 2023 09:29:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 18: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 18 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: arehbein Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 23 Aug 2023 17:07:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: fixeria. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 18: (1 comment) File examples/ipa-stream-client.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/02fdc653_5cdb408d PS17, Line 119: num = ntohl(*((int *)(msg->data))); > `num = osmo_load32be(msg->data)` Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 18 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 23 Aug 2023 16:15:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, daniel. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 to look at the new patch set (#18). Change subject: stream: Add client-side (segmentation) support for IPA .. stream: Add client-side (segmentation) support for IPA With this commit, IPA segmentation is taken care of by setting the segmentation callback provided by libosmo-netif. The ipa-stream-server example needs to prepend IPA headers now because those are stripped by the segm. cb on both sides. Depends: libosmocore.git I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Related: OS#5753, OS#5751 Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 --- M examples/ipa-stream-client.c M examples/ipa-stream-server.c M include/osmocom/netif/stream.h M src/stream_cli.c M tests/stream/stream_test.c M tests/stream/stream_test.ok 6 files changed, 327 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/98/33198/18 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 18 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: arehbein Gerrit-Attention: daniel Gerrit-MessageType: newpatchset
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 17: (1 comment) File examples/ipa-stream-client.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/fa5a9e29_27f97f95 PS17, Line 119: num = ntohl(*((int *)(msg->data))); `num = osmo_load32be(msg->data)` -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 17 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: arehbein Gerrit-Attention: daniel Gerrit-Comment-Date: Sat, 12 Aug 2023 06:52:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 17: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 17 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: arehbein Gerrit-Attention: daniel Gerrit-Comment-Date: Mon, 07 Aug 2023 16:09:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, pespin. daniel has uploaded a new patch set (#17) to the change originally created by arehbein. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. stream: Add client-side (segmentation) support for IPA With this commit, IPA segmentation is taken care of by setting the segmentation callback provided by libosmo-netif. The ipa-stream-server example needs to prepend IPA headers now because those are stripped by the segm. cb on both sides. Depends: libosmocore.git I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Related: OS#5753, OS#5751 Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 --- M examples/ipa-stream-client.c M examples/ipa-stream-server.c M include/osmocom/netif/stream.h M src/stream_cli.c M tests/stream/stream_test.c M tests/stream/stream_test.ok 6 files changed, 327 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/98/33198/17 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 17 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: arehbein Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 17: (2 comments) File tests/stream/stream_test.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/52cc603c_b6c847ec PS13, Line 829: rc = clock_gettime(CLOCK_MONOTONIC, ); > I think I already answered in there that the easiest/best way to timeout the > test is to use the alar […] Done File tests/stream/stream_test.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/69687a7a_e31cb863 PS16, Line 518: osmo_timer_schedule(_send_tl_cli, 0, 125000); > why this change in time? seems unrelated? Looks like it. Doesn't really matter except for the "timestamp" in the log output, though. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 17 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: arehbein Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 07 Aug 2023 16:02:38 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 16: (2 comments) File tests/stream/stream_test.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/053cb1f6_4b0b2f69 PS13, Line 829: rc = clock_gettime(CLOCK_MONOTONIC, ); > See answer to the same comment on change 33197 […] I think I already answered in there that the easiest/best way to timeout the test is to use the alarm() call, to avoid making the test even more complex with mixed calls to clock_gettime and osmo_clock_gettime. Not critical though. File tests/stream/stream_test.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/9b81ebfc_d4289221 PS16, Line 518: osmo_timer_schedule(_send_tl_cli, 0, 125000); why this change in time? seems unrelated? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 16 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: arehbein Gerrit-Comment-Date: Mon, 31 Jul 2023 09:01:19 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 15: (1 comment) File tests/stream/stream_test.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/3a5990fc_7bb9dd87 PS13, Line 829: rc = clock_gettime(CLOCK_MONOTONIC, ); > osmo_clock_gettime everywhere. See answer to the same comment on change 33197 https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comments/e3d5961c_a5eebe4b -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 15 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Comment-Date: Sat, 29 Jul 2023 18:57:53 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, daniel. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 to look at the new patch set (#15). Change subject: stream: Add client-side (segmentation) support for IPA .. stream: Add client-side (segmentation) support for IPA With this commit, IPA segmentation is taken care of by setting the segmentation callback provided by libosmo-netif. The ipa-stream-server example needs to prepend IPA headers now because those are stripped by the segm. cb on both sides. Depends: libosmocore.git I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Related: OS#5753, OS#5751 Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 --- M examples/ipa-stream-client.c M examples/ipa-stream-server.c M include/osmocom/netif/stream.h M src/stream.c M tests/stream/stream_test.c M tests/stream/stream_test.ok 6 files changed, 366 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/98/33198/15 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 15 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: arehbein Gerrit-Attention: daniel Gerrit-MessageType: newpatchset
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 14: (1 comment) Patchset: PS14: my comments where not yet taken into account -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 14 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: arehbein Gerrit-Attention: daniel Gerrit-Comment-Date: Mon, 24 Jul 2023 10:21:55 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein. daniel has uploaded a new patch set (#14) to the change originally created by arehbein. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. stream: Add client-side (segmentation) support for IPA With this commit, IPA segmentation is taken care of by setting the segmentation callback provided by libosmo-netif. Depends: libosmocore.git I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Related: OS#5753, OS#5751 Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 --- M examples/ipa-stream-client.c M examples/ipa-stream-server.c M include/osmocom/netif/stream.h M src/stream.c M tests/stream/stream_test.c M tests/stream/stream_test.ok 6 files changed, 364 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/98/33198/14 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 14 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: arehbein Gerrit-MessageType: newpatchset
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 13: Code-Review-1 (1 comment) File tests/stream/stream_test.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/19cbd99a_382acda2 PS13, Line 829: rc = clock_gettime(CLOCK_MONOTONIC, ); osmo_clock_gettime everywhere. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 13 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: arehbein Gerrit-Comment-Date: Mon, 10 Jul 2023 08:27:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 to look at the new patch set (#13). Change subject: stream: Add client-side (segmentation) support for IPA .. stream: Add client-side (segmentation) support for IPA With this commit, IPA segmentation is taken care of by setting the segmentation callback provided by libosmo-netif. Depends: libosmocore.git I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Depends: libosmocore.git I5ff2f1416f294ac84b4240fd96da4aa3255fb27b Related: OS#5753, OS#5751 Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 --- M include/osmocom/netif/stream.h M src/stream.c M tests/stream/stream_test.c M tests/stream/stream_test.ok 4 files changed, 330 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/98/33198/13 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 13 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: arehbein Gerrit-MessageType: newpatchset
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 12 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: arehbein Gerrit-Comment-Date: Sun, 09 Jul 2023 07:13:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 to look at the new patch set (#12). Change subject: stream: Add client-side (segmentation) support for IPA .. stream: Add client-side (segmentation) support for IPA With this commit, IPA segmentation is taken care of by setting the segmentation callback provided by libosmo-netif. Depends: libosmocore.git I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Depends: libosmocore.git I5ff2f1416f294ac84b4240fd96da4aa3255fb27b Related: OS#5753, OS#5751 Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 --- M include/osmocom/netif/stream.h M src/stream.c M tests/stream/stream_test.c M tests/stream/stream_test.ok 4 files changed, 330 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/98/33198/12 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 12 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Attention: arehbein Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 to look at the new patch set (#10). Change subject: stream: Add client-side (segmentation) support for IPA .. stream: Add client-side (segmentation) support for IPA With this commit, IPA segmentation is taken care of by setting the segmentation callback provided by libosmo-netif. Depends: libosmocore.git I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Depends: libosmocore.git I5ff2f1416f294ac84b4240fd96da4aa3255fb27b Related: OS#5753, OS#5751 Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 --- M include/osmocom/netif/stream.h M src/stream.c M tests/stream/stream_test.c M tests/stream/stream_test.ok 4 files changed, 330 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/98/33198/10 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 10 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Attention: arehbein Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 to look at the new patch set (#9). Change subject: stream: Add client-side (segmentation) support for IPA .. stream: Add client-side (segmentation) support for IPA With this commit, IPA segmentation is taken care of by setting the segmentation callback provided by libosmo-netif. Depends: libosmocore.git I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Related: OS#5753, OS#5751 Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 --- M include/osmocom/netif/stream.h M src/stream.c M tests/stream/stream_test.c M tests/stream/stream_test.ok 4 files changed, 329 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/98/33198/9 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 9 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Attention: arehbein Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
