Re: [Github-comments] [geany/geany] Update C++ compiler check to require C++17 (#2862)

[Matthew Brush]

The m4 files are downloaded from the Autoconf archive, they aren't shipped with 
Autoconf where they would be copied from the system directory to the local m4 
directory.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2862#issuecomment-901537124

Re: [Github-comments] [geany/geany] Update C++ compiler check to require C++17 (#2862)

[Matthew Brush]

Yeah, as @elextr mentioned, the reason for the check is for an early failure 
with a message explaining the compiler isn't supported.

Another way to do it would be to do a compile-test for only `std::string_view` 
to also support non-C++17 compilers which might have already supported 
`std::string_view`, but then that would have to be updated for each new C++17 
type/function we use, and especially with newer Scintilla 4/5 coming, probably 
LOTS of stuff.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2862#issuecomment-900703838

Re: [Github-comments] [geany/geany] WIP: Meson build system (#2761)

[Matthew Brush]

@kugel- You're doing the work, so it's your call (and can be 
discussed/refactored later). It just seems weird to have some stuff in subdirs 
and most stuff in the main file, and then have separate build artifacts, but 
not in own subdirs/subprojects; basically just seems a little inconsistent. 
That said, I don't know what's idiomatic in Meson, so feel free to ignore me :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2761#issuecomment-897239541

Re: [Github-comments] [geany/geany] WIP: Meson build system (#2761)

[Matthew Brush]

I realize this is a more-or-less direct port from the Autotools build system, 
but is it in the scope of this WIP PR to re-organize it to be more Meson-like, 
or rather to get rid of Autotools-style/cruft?

A few things that stick out:

 * Compiling all the things into helper static libs (Scintilla, Ctags, etc) 
which are not distributed and only used to build the shared libgeany. These 
could all be built into a single `shared_library` and delimit the source file 
(directories) in the arguments list with newlines and/or comments.
 * Checking for C headers which are guaranteed to exist (ex. C99 headers)
 * Using the built-in Pkgconfig module to generate .pc file
 * Different `extra_data` filenames for Windows (could be done in the 
`geany.nsi` script probably)
 * If we're going to use subdir(), why not subdir() into the `src` dir as well 
to move the libgeany/geany into a smaller file? Otherwise, maybe all of the 
things could be done in the same huge source of truth `meson.build` file in the 
source root directory?
 * Use the `/` path operator instead of `join_paths()` as well as for other 
paths where now they're just regular strings. Not sure what's idiomatic.
 * Is any explicit `rpath` stuff really needed? I only use Meson for small Vala 
projects, but in my uses it easily handles installing executables linked to 
shared libraries using correct paths for the distro.

Maybe we could do like?

  1. Merge this sort of direct-port PR once ready
  2. Do stuff like listed above to Mesonify in a separate PR(s) afterwards
  3. Once Meson build is nice and clean and maintainable, rip out Autotools

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2761#issuecomment-896427102

Re: [Github-comments] [geany/geany] WIP: Meson build system (#2761)

[Matthew Brush]

I did try to tinker with it a bit, but not too much. I'll try other stuff next 
time I boot into Windows partition.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2761#issuecomment-896412070

Re: [Github-comments] [geany/geany] WIP: Meson build system (#2761)

[Matthew Brush]

> @codebrainz not sure what the problem is, I would have thought g++ 10 would 
> default to c++17, but maybe I'm wrong, does latest git Geany build with 
> autotools on the same system?

I think the problem is with fnmatch/gnu_regex libraries which I believe are 
special for Windows, and possibly just some missing checks/macros to enable 
them. From the build output, it looks like a bunch of macros are not defined 
which just cascades into a whole pile of errors. I'm pretty sure Ninja is doing 
parallel compiles so the output is probably out of order.

It's the same setup I used to build Geany previously, but I didn't try 
Autotools since pulling latest with the c++17 requirement, though judging by 
the output, I don't think it has hit that issue (yet).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2761#issuecomment-896358305

Re: [Github-comments] [geany/geany] WIP: Meson build system (#2761)

[Matthew Brush]

Tried to test on Win10 with Msys2; seems to have some issues with the embedded 
fnmatch/gnu_regex stuff.

  * [Configure 
Output](https://gist.github.com/codebrainz/0fcbfbfb9bd21d4c06ed542ff636ea46#file-configure)
  * [Build 
Output](https://gist.github.com/codebrainz/0fcbfbfb9bd21d4c06ed542ff636ea46#file-build)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2761#issuecomment-895672363

[Github-comments] [geany/geany] Update C++ compiler check to require C++17 (#2862)

[Matthew Brush]

C++17 equivalent of previous Autoconf check that we got from the [Autoconf 
Archive](https://www.gnu.org/software/autoconf-archive), which has since been 
factored into two m4 files:

  * 
[ax_cxx_compile_stdcxx](https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html)
  * 
[ax_cxx_compile_stdcxx_17](https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx_17.html)

I didnt look to see if C++11 is mentioned in any docs and update them, 
feel free to modify to this PR to fix them, or mention in comments and Ill 
try and fix.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/2862

-- Commit Summary --

  * Update C++ compiler check to require C++17

-- File Changes --

M configure.ac (2)
A m4/ax_cxx_compile_stdcxx.m4 (962)
D m4/ax_cxx_compile_stdcxx_11.m4 (142)
A m4/ax_cxx_compile_stdcxx_17.m4 (35)

-- Patch Links --

https://github.com/geany/geany/pull/2862.patch
https://github.com/geany/geany/pull/2862.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2862

Re: [Github-comments] [geany/www.geany.org] Bye bye IRC @ Freenode, RIP. (#30)

[Matthew Brush]

A nice sexy waitress waiter brings @eht16 a piece of sweet 
chocolate, and a :+1: 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/www.geany.org/pull/30#issuecomment-863646409

Re: [Github-comments] [geany/geany-plugins] Markdown Plugin (Feature Request): Keep scroll position on reload (#1055)

[Matthew Brush]

I have not. I'll update here if I do. If anyone wants to work on it, ping me if 
you need any assistance.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1055#issuecomment-825992953

Re: [Github-comments] [geany/geany-plugins] Markdown Plugin (Feature Request): Keep scroll position on reload (#1055)

[Matthew Brush]

After a little more research I think it might be possible to do it fully within 
JS by loading the scroll position from the browser's localStorage (or maybe 
just sessionStorage) when the DOM is finished loading and saving it before the 
page is unloaded. If I can get that working, it should do the trick for both 
Webkit1 and Webkit2 and allow to remove some code from the plugin.

Basic theoretical untested code:

```js
document.addEventListener('DOMContentLoaded', () => { 
  const pos = localStorage.getItem('mdScrollPos');
  if (pos) window.scrollTo(pos.x, pos.y);
});
window.onbeforeunload = () => {
  localStorage.setItem('mdScrollPos', {
x: window.scrollX,
y: window.scrollY,
  });
};
```

To make it have different scroll positions saved per file rather than one 
global scroll position for all files will require to pass the filename through 
the template to JS so it can keep track of which scroll position to load/save. 
It might also require a bit of JS code to prune/vacuum the localStorage to get 
rid of scroll positions older than a certain date and/or above a certain 
number, but that might be overkill.

Next time I'm working on the plugin I'll try and see if it works.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1055#issuecomment-776559476

Re: [Github-comments] [geany/geany-plugins] Markdown: Update using known GeanyDocument when available (#1064)

[Matthew Brush]

I do not, I just noticed that it was giving invalid/NULL and that I had a valid 
document pointer already available. Probably one of the callbacks the plugin 
uses gets triggered early before the document list is fully initialized or 
something, but I didn't spend much time trying to understand it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1064#issuecomment-776546128

Re: [Github-comments] [geany/geany-plugins] Markdown Plugin (Feature Request): Keep scroll position on reload (#1055)

[Matthew Brush]

After a little bit of reading/experimenting, I think this is probably caused by 
the Webkit2 no longer requiring a GtkScrolledWindow and handling scrolling on 
its own in a separate process. Whenever the existing scrollbar adjustments are 
read, the value is always zero, so the hack that was previously added for the 
old Webkit version no longer works.

A possible workaround might be to run some javascript in the webview that can 
read the scroll position and pass it back up to the plugin's C code so it's 
able to save and then other JS to restore it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1055#issuecomment-776151165

[Github-comments] [geany/geany-plugins] Markdown: Update using known GeanyDocument when available (#1064)

[Matthew Brush]

For whatever reason, in some cases `document_get_current()` doesnt
return a valid document when it seems like it should, so when updating
the markdown preview from signals where the related GeanyDocument
is available, use that instead of calling `document_get_current()`.

In other cases, continue to use `document_get_current()` as before.

Closes #1062
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/1064

-- Commit Summary --

  * Markdown: Update using known GeanyDocument when available

-- File Changes --

M markdown/src/plugin.c (17)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/1064.patch
https://github.com/geany/geany-plugins/pull/1064.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1064

Re: [Github-comments] [geany/geany] Files with Chinese character in name - issues reading and writing (#2748)

[Matthew Brush]

Possibly related: #1095, #1076, #1278, #1534, #2660, #2652

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2748#issuecomment-776058604

Re: [Github-comments] [geany/geany-plugins] Markdown Plugin Preview not working after starting geany with a file that was already opened the other day (#1062)

[Matthew Brush]

Might be a bug where the preview updates before the document is loaded and 
doesn't update after it loaded. If you can reproduce, can you check what the 
filetype shown in the statusbar says before you start editing?

![Screenshot from 2021-02-04 
17-30-06](https://user-images.githubusercontent.com/181177/106977245-cc511100-670e-11eb-8583-954da7ff752d.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1062#issuecomment-773718715

Re: [Github-comments] [geany/geany-plugins] Markdown Plugin (Feature Request): Keep scroll position on reload (#1055)

[Matthew Brush]

@Sci-Mon do you mind reporting back with the version on Windows whenever you're 
next on that computer? I swear this was fixed, but maybe it got broken somehow 
in the intervening versions.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1055#issuecomment-773716894

Re: [Github-comments] [geany/geany-osx] Dark / light mode Macos (#22)

[Matthew Brush]

>From [this 
>comment](https://github.com/geany/geany/issues/2344#issuecomment-546718908):

> The main feature of this release is that I made a few things configurable 
> (probably the most interesting one is the dark/light theme) using a config 
> file which is created when you start Geany under 
> ~/.config/geany/geany_mac.conf. The default value for the theme is to use 
> your macOS settings so if you use the dark theme system-wise, it will be 
> picked automatically for you. Note that if you previously set the theme using 
> the .config/gtk-3.0/settings.ini file, you'll have to remove this file first, 
> otherwise it overrides the settings specified in 
> ~/config/geany/geany_mac.conf.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/22#issuecomment-772942391

Re: [Github-comments] [geany/geany-plugins] Compilation error with PrettyPrinter (#1059)

[Matthew Brush]

Closed #1059.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1059#event-4282565131

Re: [Github-comments] [geany/geany-plugins] Compilation error with PrettyPrinter (#1059)

[Matthew Brush]

Duplicate of #1023 and fixed in #1053.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1059#issuecomment-772131923

Re: [Github-comments] [geany/geany-osx] Dark / light mode Macos (#22)

[Matthew Brush]

>  As a last resource (not as good) allow and document a "less hacky" way to 
> change to dark mode...

If you set the `GTK_THEME` environment variable you should be able to switch to 
the dark version, for example setting the  environment variable to 
`GTK_THEME=Mojave-light-solid:dark` should work. There are a few other ways 
using `settings.ini` file and `gsettings` as well, but I'm not really sure 
what's available/included in the Macos bundle.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/22#issuecomment-772130658

Re: [Github-comments] [geany/geany] Geany not responding to certain keys (#2739)

[Matthew Brush]

Hi @subtra3t, this looks like a duplicate of #1902, #2408, #2472, #2572. It's a 
good idea to search for existing same issues before posting a new one (I 
searched "comma" to find those issues), and also to give your operating system 
and version information.

Try out the solution in [this 
comment](https://github.com/geany/geany/issues/1902#issuecomment-643657889) and 
[this 
comment](https://github.com/geany/geany/issues/1902#issuecomment-661295362) for 
the fix.

If this is indeed a duplicate, please close it as #1902 is still open. If you 
have any problems with the solution or additional information to add, you can 
follow up on #1902 where people who have solved it are probably still getting 
notifications.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2739#issuecomment-770154298

Re: [Github-comments] [geany/geany] error compiling at scintilla with C++ (#2731)

[Matthew Brush]

> paging @codebrainz search services

https://groups.google.com/g/scintilla-interest/c/ma_3cmKAEVs/m/n61l9uT4BQAJ

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2731#issuecomment-764160501

Re: [Github-comments] [geany/geany] write absolute path to geany bin in desktop file (#2728)

[Matthew Brush]

@codebrainz commented on this pull request.



> @@ -37,6 +37,7 @@ uninstall-local:
 
 # manually install some files under another name
 install-data-local:
+   sed -i '/Exec=/c\Exec=@bindir@/geany %F' @top_builddir@/geany.desktop

Ah ok. I was thinking it like the pkg-config file where do this, but I guess 
there we want them unexpanded because pkg-config takes care of it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2728#discussion_r559768929

Re: [Github-comments] [geany/geany] write absolute path to geany bin in desktop file (#2728)

[Matthew Brush]

@codebrainz commented on this pull request.



> @@ -37,6 +37,7 @@ uninstall-local:
 
 # manually install some files under another name
 install-data-local:
+   sed -i '/Exec=/c\Exec=@bindir@/geany %F' @top_builddir@/geany.desktop

Can't you just do this:

```diff
- Exec=geany %F
+ Exec=@bindir@/geany %F
```

In [the `geany.desktop.in` 
file](https://github.com/geany/geany/blob/d9f8cdbad58d09f0c18ca8acccb49209263018f0/geany.desktop.in#L7)
 or similar?

I'm pretty sure if you added it to `AC_CONFIG_FILES` it would get the 
substitutions. But maybe I'm missing something of Geany's Autotools.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2728#pullrequestreview-570165514

Re: [Github-comments] [geany/geany-plugins] geany-plugins sourceforge site should be maintained or removed (#1049)

[Matthew Brush]

@eht16 Maybe before deleting we could [snarf it up in an 
archiver](https://archive.vn/QPeDh) for posterity, including all the other SF 
pages, and link them from somewhere on the main site?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1049#issuecomment-761714313

Re: [Github-comments] [geany/geany] write absolute path to geany bin in desktop file (#2728)

[Matthew Brush]

I have no idea if other stuff (DEs, menu editors, etc.) purposefully use the 
DE's `PATH` variable in all configurations, or whether it is common for DEs to 
run under other than the currently logged in user, so not sure, no opinion.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2728#issuecomment-761296639

Re: [Github-comments] [geany/geany] write absolute path to geany bin in desktop file (#2728)

[Matthew Brush]

Yeah, it doesn't recommend either way.

I'm not sure what the consequences of hard-coding an absolute path in practice 
are - particularly in the case of multiple Geany installations - versus doing a 
`PATH` lookup, so I do not have an opinion, other than that the unrelated 
changes in this PR aren't super compelling.

Ping @dmaphy, @hyperair, @b4n et al.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2728#issuecomment-761294993

Re: [Github-comments] [geany/geany] write absolute path to geany bin in desktop file (#2728)

[Matthew Brush]

> When I look at examples for creating .desktop files, it's recommended to use 
> the full path to the binary. 

Best source for info is [the 
spec](https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#exec-variables):

>> The executable program can either be specified with its full path or with 
>> the name of the executable only. If no full path is provided the executable 
>> is looked up in the $PATH environment variable used by the desktop 
>> environment.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2728#issuecomment-761292571

Re: [Github-comments] [geany/geany-plugins] Line Operations: Reverse (#1057)

[Matthew Brush]

@TheDcoder FWIW, you can do this using just Geany:

![tac](https://user-images.githubusercontent.com/181177/104349566-f28ce380-54b7-11eb-9111-705208d64c8b.png)

https://www.geany.org/manual/current/#sending-text-through-custom-commands

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1057#issuecomment-758814363

Re: [Github-comments] [geany/geany-plugins] Markdown Plugin (Feature Request): Keep scroll position on reload (#1055)

[Matthew Brush]

I tried to fix this in d1a4dd15089551cd2eddcf9beb77ee9256f2d26f and I thought I 
remember @b4n helping with this too, but I can't seem to find that discussion.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1055#issuecomment-757373611

Re: [Github-comments] [geany/geany-plugins] Markdown Plugin (Feature Request): Reload modified template file at runtime of geany (#1054)

[Matthew Brush]

It would have to use 
[`GFileMonitor`](https://developer.gnome.org/gio/stable/GFileMonitor.html) on 
the template file, seems perfectly do-able.

For the latter part, something like [Bootswatch](https://bootswatch.com/) would 
probably do, and perhaps add a placeholder like `@@theme@@` to select which 
theme to use.

If anyone wants to work on this, drop a comment here to discuss.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1054#issuecomment-757372798

Re: [Github-comments] [geany/geany-plugins] Use stdbool.h istead of redefining bool (#1053)

[Matthew Brush]

I believe this is a dupe of #1023

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1053#issuecomment-754972321

Re: [Github-comments] [geany/geany] Preserving the 'untitled' files (#2717)

[Matthew Brush]

Closed #2717.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2717#event-4164421467

Re: [Github-comments] [geany/geany] Preserving the 'untitled' files (#2717)

[Matthew Brush]

This is a duplicate of #905 even though they may have been requested for 
different reasons. Please lets not scatter several discussions across duplicate 
issues. #905 is older, has quite a few :+1: s and only has 6 comments including 
one misunderstanding the request and one saying "patches welcome", hardly a 
mess.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2717#issuecomment-753904291

Re: [Github-comments] [geany/geany] Preserving the 'untitled' files (#2717)

[Matthew Brush]

FWIW, the weirdness with new untitled files not opening sometimes is explained 
in #2656.

I believe this issue is a duplicate of #905, and should be closed as such, with 
further discussion on the already existing issue as to not bifurcate it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2717#issuecomment-753881636

Re: [Github-comments] [geany/geany] Preserving the 'untitled' files (#2717)

[Matthew Brush]

Geany will only open additional unsaved new files if you've modified the 
previous one, and will also only present the save dialog if you've modified the 
new unsaved documents. The action of saving them to disk is what persists them.

> Is there a way to preserve those files in the editor without being forced to 
> save them, so they and their content would be kept upon the user manually 
> closes them?

I haven't tried, but it's possible with one of the plugins that provides 
auto-backup that it would do so for new unsaved documents. There is also the 
"Scribble" tab in the message window, which sounds like what you're after, but 
it's not a real document and there's only one.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2717#issuecomment-753684614

Re: [Github-comments] [geany/geany] No .conf file for the default color scheme? (#2718)

[Matthew Brush]

For historical reasons, the default colour scheme is in 
[filetypes.common](https://github.com/geany/geany/blob/d9f8cdbad58d09f0c18ca8acccb49209263018f0/data/filedefs/filetypes.common#L2).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2718#issuecomment-753683663

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

[Matthew Brush]

Link: https://sourceforge.net/p/scintilla/bugs/2226/

I'm not saying Zsh has it "wrong" per se, just that it seems to be the correct 
behaviour for POSIX shells, and that in Geany, `*.zsh` files use the regular 
[Shell 
filetype](https://github.com/geany/geany/blob/d9f8cdbad58d09f0c18ca8acccb49209263018f0/data/filedefs/filetypes.sh).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2715#issuecomment-752292904

Re: [Github-comments] [geany/geany] Link to the change log per #2701 (#2714)

[Matthew Brush]

@codebrainz requested changes on this pull request.

What do you think?

> @@ -27,6 +27,10 @@ The basic features of Geany are:
 - embedded terminal emulation
 - extensibility through plugins
 
+Changelog
+-
+See the release notes on `the website 
`_ or `on GitHub 
`_.
+

I wonder if we could make this change serve double-duty, something like:

```rst
Getting Geany
---

The current version of Geany is 1.37 (see `Release Notes here 
`_). Official releases can be 
found on the `Releases Page `_. Geany 
is also provided by a number of `Third-Party Packages 
`_.

See below for instructions on installing Geany from various release types.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2714#pullrequestreview-559748648

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

[Matthew Brush]

@RayAndrews56, @elextr is hoping you will open a bug on [the Scintilla bug 
tracker](https://sourceforge.net/p/scintilla/bugs/) (there might already be one 
for this, worth searching first), the project where the actual bug you're 
experiencing would come from. If you're willing to do that, he's asking for you 
to post a link to your bug report (or any existing one(s)) on their bug tracker 
so we can reference it here on your Github Issue.

That said, assuming the lexer is to conform to [POSIX Shell 
standards](https://pubs.opengroup.org/onlinepubs/007904875/utilities/xcu_chap02.html)
 ([`zsh` uses the normal shell lexer in 
Geany](https://github.com/geany/geany/blob/d9f8cdbad58d09f0c18ca8acccb49209263018f0/data/filetype_extensions.conf#L67)),
 it might not be an actual bug, specifically this:

> A backslash that is not quoted shall preserve the literal value of the 
> following character, with the exception of a newline. If a 
> newline follows the backslash, the shell shall interpret this as line 
> continuation. The backslash and newlines shall be removed before 
> splitting the input into tokens. Since the escaped newline is removed 
> entirely from the input and is not replaced by any white space, it cannot 
> serve as a token separator.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2715#issuecomment-752286491

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

[Matthew Brush]

@etkaar thanks, and sorry about all the confusion.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2697#issuecomment-751856162

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

[Matthew Brush]

This was finally fixed in master by 9f5b430458192388a7bf611943fc61b2a8b44246.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/758#issuecomment-751855942

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

[Matthew Brush]

Closed #758.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/758#event-4153011522

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

[Matthew Brush]

Merged #2697 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2697#event-4153008432

Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

[Matthew Brush]

Closed #2693 via #2697.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2693#event-4153008436

Re: [Github-comments] [geany/geany] [Question] gtk4 support? (#2713)

[Matthew Brush]

Slightly related: #2602

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2713#issuecomment-751852035

Re: [Github-comments] [geany/geany] Where is the CHANGELOG? (#2701)

[Matthew Brush]

Closing since same/similar info is available in numerous places.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2701#issuecomment-751850925

Re: [Github-comments] [geany/geany] Where is the CHANGELOG? (#2701)

[Matthew Brush]

Closed #2701.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2701#event-4152977836

Re: [Github-comments] [geany/geany-osx] Mac - call geany from command line to open a file with only 1 geany instance (#21)

[Matthew Brush]

The one part of this multipart issue sounds like #15 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/21#issuecomment-751645249

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

[Matthew Brush]

@etkaar since this is already a duplicate of #2565, why not just force push to 
the branch of this PR? This topic already has a number of duplicate issues and 
PRs, no need to make more, IMO.

You can still keep this current work in a branch on your Github fork, Git lets 
you branch off of branches and/or rename branches. Something like:

```bash
# backup the current version
$ git branch -m always_set_from_selected always_set_from_selected_pref
# make a new branch off of master with the same name as this PR branch
$ git checkout -b always_set_from_selected master
# use my patch (or edit the files manually)
$ git apply 
# ...do other changes, commits, etc.
# force push to this branch to update this PR
$ git push  +always_set_from_selected
# if you want the backed up version on Github too
$ git push  always_set_from_selected_pref
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2697#issuecomment-751641301

Re: [Github-comments] [geany/geany] Virtual terminal size set to unreasonable value (#2705)

[Matthew Brush]

> I am concerned that certain terminal based UI applications may not properly 
> work inside Geany.

IIRC Fish was using minimum 20 columns and 2 lines in its check, which seems 
arbitrary, unless it's from POSIX standard? Moreover, at least here, Geany's 
terminal has the correct output for `tput cols` (and `$COLUMNS`) and `tput 
lines` (and `$LINES`), so it shouldn't affect anything but the initial shell.

LibVTE has always been weird with respect to sizing due to it always having to 
update/maintain the terminal size (columns/lines) dynamically on-the-fly and 
also having to respect GTK+'s widget sizing stuff (pixels width/height), and in 
addition being inside a GTK+ scrolled window.

It's possible a workaround could be implemented, like only spawning the shell 
command after the VTE widget is sized/realized using a callback and hoping the 
user doesn't have their message window shrunk down "too" small or by enforcing 
a minimum width/height somehow like standalone VTE applications do (ex. 
gnome-terminal, xfce4-terminal), but it doesn't seem worth it to me unless 
someone volunteers to investigate and make a patch.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2705#issuecomment-751152648

Re: [Github-comments] [geany/geany] Virtual terminal size set to unreasonable value (#2705)

[Matthew Brush]

Sounds like a problem with LibVTE and/or Fish (see [this 
commit](https://github.com/fish-shell/fish-shell/issues/6980#issuecomment-625333808)),
 but not Geany. Not sure it's even worth trying to workaround in Geany since 
the message was removed in Fish and doesn't seem to affect any other shells.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2705#issuecomment-751145844

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

[Matthew Brush]

Real CSS has a property like this:

```css
filter: invert(1) hue-rotate(180deg);
```

But since GTK+ CSS is not real/complete CSS, I doubt it works.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2644#issuecomment-750106373

Re: [Github-comments] [geany/geany] Mac OS dark mode complier color in the Message Window (#2647)

[Matthew Brush]

Closed #2647.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2647#event-4143563950

Re: [Github-comments] [geany/geany] Mac OS dark mode complier color in the Message Window (#2647)

[Matthew Brush]

Duplicate of #1376, #1737, #2293, #2644, etc.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2647#issuecomment-750101493

Re: [Github-comments] [geany/geany] How modify message background color? (#2702)

[Matthew Brush]

Closed #2702.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2702#event-4143556521

Re: [Github-comments] [geany/geany] How modify message background color? (#2702)

[Matthew Brush]

`Tools` ⮞ `Configuration Files` ⮞ `geany.css`

Put this in it and save:
  
  ```css
.view {
background: black;
}
  ```

Message background color become full black when build is executed.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2702#issuecomment-750074825

Re: [Github-comments] [geany/geany] Where is the CHANGELOG? (#2701)

[Matthew Brush]

The `ChangeLog` is included in the official releases, it's generated from the 
Git log during `make dist`.

If you don't want to compile Geany first, you can run `git log` from within the 
Git source tree.

If you don't want to even check-out the Git source tree, you can [browse the 
history online](https://github.com/geany/geany/commits/master).

Finally, every release is accompanied by release notes which highlight the most 
important changes between versions and are included in the [`NEWS` 
file](https://raw.githubusercontent.com/geany/geany/master/NEWS) and can also 
be viewed through [Github releases](https://github.com/geany/geany/releases) or 
on [the Geany website](https://www.geany.org/documentation/releasenotes/).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2701#issuecomment-749817011

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

[Matthew Brush]

> If I understand your patch correct, it would change the default behaviour to 
> do exactly that what my PL does, but per default and without a hidden 
> preference.

Correct.

> ...but I think a hidden preference may be better than changing the default 
> behaviour without allowing users to fall back to the old default behaviour.

IMO, a preference is not needed here and was only suggested as a result of a 
misunderstanding of the desired behaviour. Perhaps I'm missing the use case for 
_not_ wanting the search text to be updated. If the reason to jump back to the 
Find dialogs without updating the text is to click the Find Next/Previous 
buttons, then one can simply use the keybindings for this 
(Ctrl+g and Ctrl+Shift+g 
by default). If the reason is to jump back and change some of the options 
without updating the search text, one can simply press 
Ctrl+f followed by Up to recall the previous 
search string before changing the other options.

Is there another use case I'm missing?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2697#issuecomment-749170960

Re: [Github-comments] [geany/geany] Transparent search/replace dialogs when out of focus (#2698)

[Matthew Brush]

Closed #2698.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2698#event-4137383980

Re: [Github-comments] [geany/geany] Transparent search/replace dialogs when out of focus (#2698)

[Matthew Brush]

@etkaar nice work.

> Should we then close this issue or link it to a specific "tutorial page"?

If you're willing, I would suggest to post a [HowTo on the 
wiki](https://wiki.geany.org/howtos/start).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2698#issuecomment-749162514

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

[Matthew Brush]

I thought due to [this 
comment](https://github.com/geany/geany/pull/2695#issuecomment-748722240) the 
request for an option was dropped? I think all this started over not closing 
#2693 as a duplicate of #758 and not reading the discussion there.

Key points (duplicated across issues):
1) The goal of #758 and #2693 is to update the search text in the Find and 
Replace dialogs __whenever Ctrl+f is pressed, rather than 
only the first time the dialogs are shown__. This seems like a totally 
reasonable behaviour that most applications that have a Find feature do.
2) There was a misunderstanding in both issues where it was believed that the 
goal was to update the search text in the Find and Replace dialogs __whenever 
the selection was changed__ (which would indeed be weird), thus prompting for a 
request about needing an option to turn this feature off.
3) It was clarified that the intention is **1** and not **2** so __no option is 
needed__.

I assume this issue is a duplicate of #2695 because a PR is bound the branch on 
which it was created, and it [was 
suggested](https://github.com/geany/geany/pull/2695#issuecomment-748728322) to 
not use `master` branch for the PR (a good suggestion for future PRs but not 
really essential/required).

If the above summary is accurate, then all that's needed is a patch like this:

```diff
diff --git a/src/search.c b/src/search.c
index 82682ae33..f45d7b477 100644
--- a/src/search.c
+++ b/src/search.c
@@ -575,14 +575,16 @@ void search_show_find_dialog(void)
}
else
{
-   /* only set selection if the dialog is not already visible */
-   if (! gtk_widget_get_visible(find_dlg.dialog) && sel)
+   if (sel != NULL)
+   {
+   /* update the search text from current selection */
gtk_entry_set_text(GTK_ENTRY(find_dlg.entry), sel);
+   /* reset the entry widget's background colour */
+   ui_set_search_entry_background(find_dlg.entry, TRUE);
+   }
gtk_widget_grab_focus(find_dlg.entry);
set_dialog_position(find_dlg.dialog, find_dlg.position);
gtk_widget_show(find_dlg.dialog);
-   if (sel != NULL) /* when we have a selection, reset the entry 
widget's background colour */
-   ui_set_search_entry_background(find_dlg.entry, TRUE);
/* bring the dialog back in the foreground in case it is 
already open but the focus is away */
gtk_window_present(GTK_WINDOW(find_dlg.dialog));
}
@@ -751,11 +753,13 @@ void search_show_replace_dialog(void)
}
else
{
-   /* only set selection if the dialog is not already visible */
-   if (! gtk_widget_get_visible(replace_dlg.dialog) && sel)
+   if (sel != NULL)
+   {
+   /* update the search text from current selection */
gtk_entry_set_text(GTK_ENTRY(replace_dlg.find_entry), 
sel);
-   if (sel != NULL) /* when we have a selection, reset the entry 
widget's background colour */
+   /* reset the entry widget's background colour */
ui_set_search_entry_background(replace_dlg.find_entry, 
TRUE);
+   }
gtk_widget_grab_focus(replace_dlg.find_entry);
set_dialog_position(replace_dlg.dialog, replace_dlg.position);
gtk_widget_show(replace_dlg.dialog);
@@ -1059,10 +1063,8 @@ void search_show_find_in_files_dialog_full(const gchar 
*text, const gchar *dir)
 
if (!text)
{
-   /* only set selection if the dialog is not already visible, or 
has just been created */
-   if (doc && ! sel && ! gtk_widget_get_visible(fif_dlg.dialog))
+   if (doc && ! sel)
sel = editor_get_default_selection(doc->editor, 
search_prefs.use_current_word, NULL);
-
text = sel;
}
entry = gtk_bin_get_child(GTK_BIN(fif_dlg.search_combo));
```

If that's the case, I propose to update the title and description of this PR 
and to force push a commit similar to above patch. I'm currently on vacation 
and will have time to merge this in the next days. @etkaar your work on this is 
appreciated!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2697#issuecomment-749156210

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' (default: FALSE) [...] (#2695)

[Matthew Brush]

> We are very much trying to not dump things in various...

For what it's worth, this is not shared by _all_ core developers; personally I 
feel that the Preferences dialog already has loads of options and that it's 
better for preferences that are obscure or rarely used to be dumped into the 
`Various` preferences tab. In any case, I don't feel strongly, I just mention 
so it's clear this is not some kind of agreed upon policy. IMO, leave it to the 
person willing to make the PR, it can always be moved later if it turns out 
people are using it a lot for some reason or having trouble finding it.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2695#issuecomment-748718063

Re: [Github-comments] [geany/geany] How to have a filename extension recognized as another (#2694)

[Matthew Brush]

Add code block around above paste and removed `\` from in front of the comment 
lines. Probably better to paste your exact file in between the `ini` code block 
I added.

To me it looks like it's detecting as shell script (though can't be sure, as 
@elextr said, your screenshots don't show the statusbar where it tells the file 
type). I suspect that probably your complex Bash script is tripping up the 
simplistic shell script lexer, though will need to see the status bar to be 
sure.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2694#issuecomment-748680285

Re: [Github-comments] [geany/geany] How to have a filename extension recognized as another (#2694)

[Matthew Brush]

This is the default behaviour so it should work automatically, [see 
here](https://github.com/geany/geany/blob/d2740f21feb84b6f951398c6f683674b2b56bfed/data/filetype_extensions.conf#L67).
 Documentation [is 
here](https://www.geany.org/manual/current/index.html#filetype-extensions)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2694#issuecomment-748575654

Re: [Github-comments] [geany/geany] "make check" unittests fail on Windows (#2677)

[Matthew Brush]

FWIW, the Git installer for Windows asks you about how to deal with with line 
endings  (autocrlf) during setup and sets it globally. Maybe someone had that 
configured and accidentally changed the line endings?

![autocrlf](https://user-images.githubusercontent.com/181177/102153725-b751b300-3e2c-11eb-87be-21a4ed86703a.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2677#issuecomment-744917628

Re: [Github-comments] [geany/geany] When conf files are copied from system to user the section headings should not be commented out ... (#2689)

[Matthew Brush]

Agree. It seemed like a good idea, but is proving troublesome with people who 
aren't familiar with GLib's keyfile format. At the very least the `[section]` 
lines shouldn't be commented.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2689#issuecomment-740297948

Re: [Github-comments] [geany/geany-plugins] Splitting a snowman in half crashes Geany with Spell Check (inserting a space before Unicode VARIATION SELECTOR-16) (#1041)

[Matthew Brush]

> But of course thats slower, whereas operator[] is as fast as C

Not true when distros enable debug assertions in release builds...

> reproducing syntax but with a whole other lot of constraint that only apply 
> in corner cases

Kind of like making the bitwise shift operators sometimes mean "read/write IO 
stream" :smile: 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1041#issuecomment-740241182

Re: [Github-comments] [geany/geany-plugins] Splitting a snowman in half crashes Geany with Spell Check (inserting a space before Unicode VARIATION SELECTOR-16) (#1041)

[Matthew Brush]

> So, the colored variant seems not relevant for the crash.

Agree, it seems unlikely that it's related to the font, but @hroncok does have 
a different emoji font than Noto.

> Can I run it without make install? Do I need to do this with plugins and 
> geany somehow combined?

You could configure it with a different prefix, like:

```
$ ./configure --prefix=/tmp/bleh
$ make
$ make install
$ /tmp/bleh/bin/geany -v
```
Once running you can set an `Extra plugin path` in `Preferences`->`General` to 
point to your existing plugins directory (ex. `/usr/lib/geany` or wherever your 
distro package puts them).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1041#issuecomment-739419623

Re: [Github-comments] [geany/geany-plugins] Splitting a snowman in half crashes Geany with Spell Check (inserting a space before Unicode VARIATION SELECTOR-16) (#1041)

[Matthew Brush]

Here:

```bash
$ fc-match -s monospace | grep -i emoji
NotoColorEmoji.ttf: "Noto Color Emoji" "Regular"
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1041#issuecomment-739224753

Re: [Github-comments] [geany/geany-plugins] Splitting a snowman in half crashes Geany with Spell Check (inserting a space before Unicode VARIATION SELECTOR-16) (#1041)

[Matthew Brush]

> I don't have the "DejaVu Sans Mono Regular" font variant

Me either

> Also, my snowman is always in the uncolored variant

To copy into Geany, I had to "Edit" this issue description and copy/paste from 
there (and then cancel the edit). I think you also need a fallback font that 
provides it to be installed like [Noto Color 
Emoji](https://www.google.com/get/noto/help/emoji/).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1041#issuecomment-73903

Re: [Github-comments] [geany/geany-plugins] Splitting a snowman in half crashes Geany with Spell Check (inserting a space before Unicode VARIATION SELECTOR-16) (#1041)

[Matthew Brush]

In my test I was using same font as @eht16 except size 10, but I believe 
emojies fallback to some of the Noto* fonts, one for the black and white and a 
different one for the colour emoji.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1041#issuecomment-737593078

Re: [Github-comments] [geany/geany-plugins] Splitting a snowman in half crashes Geany with Spell Check (inserting a space before Unicode VARIATION SELECTOR-16) (#1041)

[Matthew Brush]

When I split a snowman I get this:

![snowman](https://user-images.githubusercontent.com/181177/100690172-d20b2e80-333a-11eb-8733-4d2e0298d6df.png)

No crashes.

```
18:20:05: Geany INFO: Geany 1.38 (git >= d2740f21f), en_CA.UTF-8
18:20:05: Geany INFO: GTK 3.24.20, GLib 2.64.3
18:20:05: Geany INFO: OS: Ubuntu 20.04.1 LTS (focal)
```

Both Geany and Geany-Plugins freshly built and installed from `master` branch.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1041#issuecomment-736178826

Re: [Github-comments] [geany/geany] jump to def (#2680)

[Matthew Brush]

Closed #2680.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2680#event-4054622295

Re: [Github-comments] [geany/geany] ctags unable to find variables that contain hyphen (#2679)

[Matthew Brush]

It works for me, though not for `flex-direction` specifically, since I tested 
using the tags file linked from #572 and neither one includes `flex-direction`. 
If I type `flex-`, it gives auto-complete list for `flex-align`, `flex-flow`, 
`flex-line-pack`, etc.

Tested with 1.38.

What tags file are you using?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2679#issuecomment-736148209

Re: [Github-comments] [geany/geany] File edits slowly (#2675)

[Matthew Brush]

Related to/duplicate of #2484 et al.
Upstream bug: https://sourceforge.net/p/scintilla/bugs/1563/

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2675#issuecomment-735023263

Re: [Github-comments] [geany/geany] Parsing long files (#791)

[Matthew Brush]

Closed #791.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/791#event-4047544148

Re: [Github-comments] [geany/geany] Parsing long files (#791)

[Matthew Brush]

Closing as the issue seems to be resolved according to the comments. Feel free 
to reopen if it is still an issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/791#issuecomment-735022913

Re: [Github-comments] [geany/geany] "string" not highlighted as a builtin language keyword for D (#2670)

[Matthew Brush]

I believe `string` is a library type, not a keyword.

You could add it to [the `primary` 
key](https://github.com/geany/geany/blob/0a0b4b000cf18e837b921057a461ad05a08e41d3/data/filedefs/filetypes.d#L25).
 Alternatively, you could add it to [the `types` 
key](https://github.com/geany/geany/blob/0a0b4b000cf18e837b921057a461ad05a08e41d3/data/filedefs/filetypes.d#L29)
 if you wanted to highlight it different from built-in types and keywords.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2670#issuecomment-731616044

Re: [Github-comments] [geany/geany-plugins] Pasting a an odd CR+LF from website crashes Geany (possibly from an odd encoding) (#1036)

[Matthew Brush]

> Weird indeed… may be the same as #1022?

Was my first thought too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1036#issuecomment-731484823

Re: [Github-comments] [geany/geany] Geany on Fedora 33 freezes (#2665)

[Matthew Brush]

@vkireyeu good news!

If you are willing and able, it would be interesting to see if you experience 
the same issue with [Scite](https://www.scintilla.org/SciTE.html) which is the 
reference editor for the source code editing widget/component Geany uses 
(Scintilla). If you experience the same issue with Scite, it would show that 
there's probably not an issue with Geany's code and the bug could be worked on 
upstream in Scintilla.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2665#issuecomment-731483766

Re: [Github-comments] [geany/geany] Geany on Fedora 33 freezes (#2665)

[Matthew Brush]

It's probably still Wayland, I don't think you can use per-app environment 
variables if you're within Wayland. Try to log out and change the session to an 
X-session instead of Wayland (gear icon -> 'GNOME on Xorg').

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2665#issuecomment-730732069

Re: [Github-comments] [geany/geany] Try and find ldconfig on Ubuntu even with weird sudo configurations (#2661)

[Matthew Brush]

1) Result (default, not changed by me):
```bash
$ sudo env | grep PATH
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin
```
2) That's what I did when testing.

I don't really want to change `PATH` and `ldconfig` stuff for root, if that's 
what you're suggesting I do. But it does work by default on Ubuntu, both master 
and this branch, if you don't mess up your root `PATH` stuff.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2661#issuecomment-729315426

Re: [Github-comments] [geany/geany] Try and find ldconfig on Ubuntu even with weird sudo configurations (#2661)

[Matthew Brush]

For what it's worth, I just tested current `master` branch as well as this 
branch (with a `make distclean` before each try) and they both worked. Ubuntu 
20.04.1, all default build options.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2661#issuecomment-728635960

Re: [Github-comments] [geany/geany] Try and find ldconfig on Ubuntu even with weird sudo configurations (#2661)

[Matthew Brush]

@b4n I use Ubuntu 20.04 and can test. Can you describe the reproduction 
procedure?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2661#issuecomment-728623583

Re: [Github-comments] [geany/geany] Do not convert filename when opening files from command line on Windows (#2660)

[Matthew Brush]

> Btw, I tested successfully:
> * working directory with German umlaut, relative ASCII filename
> * working directory with German umlaut, relative filename with German 
> umlaut
> * working directory with German umlaut, absolute path with German umlaut 
> in directory, ASCII filename
> * working directory with German umlaut, absolute path with German umlaut 
> in directory and filename

It might be good for someone to test with other characters that don't overlap 
between CP-1252 and UTF-8 just to be sure. Like maybe some Cyrillic or Hanzi 
characters.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2660#issuecomment-728607372

Re: [Github-comments] [geany/geany] windows, new file do not create a new file (#2656)

[Matthew Brush]

I believe this is intentional and has been the case since very early, if not 
the initial commit.

See the [code 
here](https://github.com/geany/geany/blob/0a0b4b000cf18e837b921057a461ad05a08e41d3/src/document.c#L628);
 when you open new untitled document and there's only one new/untitled document 
that hasn't been changed, it closes the previous untitled document and opens a 
new one. I'm not sure I see the point of that, but I also don't see a 
particular problem with it, unless I'm just not seeing the use case for wanting 
many new/untitled tabs open with no changes to them.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2656#issuecomment-726249370

Re: [Github-comments] [geany/geany] windows, 1.37.1 , no plugin available (#2655)

[Matthew Brush]

Does it work when you choose to continue?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2655#issuecomment-725537662

Re: [Github-comments] [geany/geany] Geany fails to open a file (silently) with trailing zero chars (#2654)

[Matthew Brush]

Sounds like a duplicate of #618, #1508, #1708, #2081, etc.

Related: #1709

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2654#issuecomment-724901820

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

[Matthew Brush]

> My solution would be to add comments to the CSS file so that the users of 
> dark themes only have to uncomment to have a functional contrast.

I guess that still has the problem that we have no idea what GTK+ theme the 
user will choose, so it's not really possible to pick properly contrasting 
colours.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2644#issuecomment-724371291

Re: [Github-comments] [geany/geany] Can not open files from unicode-named folders under Windows (#2652)

[Matthew Brush]

Sounds related to #1095.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2652#issuecomment-724370158

[Github-comments] [geany/geany] Slow startup (#2649)

[Matthew Brush]

Seems to not be an issue on Linux.

References:
https://github.com/geany/geany/issues/2639#issuecomment-723489800
https://github.com/geany/geany/issues/2639#issuecomment-723494612
https://github.com/geany/geany-osx/issues/20
https://www.mail-archive.com/users@lists.geany.org/msg02989.html

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2649

Re: [Github-comments] [geany/geany-plugins] Build error with 1.37 release (#1023)

[Matthew Brush]

Reopened #1023.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1023#event-3970334423

Re: [Github-comments] [geany/geany-plugins] Build error with 1.37 release (#1023)

[Matthew Brush]

Then it is a bug.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1023#issuecomment-723514866

Re: [Github-comments] [geany/geany] Mac OS dark mode complier color in the Message Window (#2647)

[Matthew Brush]

I have no idea about Macos, I was just linking your issue to the others about 
the bad colours when dark mode/themes are used, sorry.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2647#issuecomment-723495407

Re: [Github-comments] [geany/geany] Mac OS dark mode complier color in the Message Window (#2647)

[Matthew Brush]

Sounds related to the recent https://github.com/geany/geany/issues/2644 and 
similar previous issues.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2647#issuecomment-723495024

Re: [Github-comments] [geany/geany] geany would not open (Windows 10) (#2639)

[Matthew Brush]

I noticed the slow startup on Windows since pre-releases of 1.37, I assumed it 
was something with my computer/Windows. It's not a huge deal, but it certainly 
seems slower than it ought to be.

Possibly related: https://github.com/geany/geany-osx/issues/20

Startup time in Ubuntu 20.04 seem unaffected.

I guess we should make a new Issue for the slow startup, I will do once I'm 
back in Windows and have a chance to time/test, if nobody else opens one first.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2639#issuecomment-723494612

Re: [Github-comments] [geany/geany-plugins] Build error with 1.37 release (#1023)

[Matthew Brush]

Could be a clash with another file including `stdbool.h` or also defining own 
`bool` type.

IMO, it should either include `stdbool.h` and use the standard `bool` (alias of 
`_Bool`) or else use `gboolean` that is already available via the `glib.h` 
include.

@rezso if you want to test, try removing the offending line (55) and putting 
`#include ` on line 32.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1023#issuecomment-723483198

Re: [Github-comments] [geany/geany] User defined snippets not being detected (#2646)

[Matthew Brush]

All lines starting with `#` are comments, same as with Python. Try uncommenting 
at least `[Python]` line and the line you added.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2646#issuecomment-723482403