Re: r23186 - gnucash/trunk - Bug 654196 - make check fails when built with --enable-dbi
John Ralls jra...@ceridwen.us writes: On Sep 23, 2013, at 7:42 AM, Derek Atkins warl...@mit.edu wrote: Christian Stimming christ...@cstimming.de writes: The new test fails for me as well: Kubuntu 11.10, and config.log says: configure:20323: checking Looking for at least one supported DBD module configure:20343: gcc -o conftest -I/home/cs/usr/include -ldl conftest.c - lpthread 5 Curious: What happens if this line were to become: gcc -o conftest -I/home/cs/usr/include conftest.c -ldl -lpthread The patch I proposed here yesterday does that, at least with respect to the order of the libraries wrt conftest.c. Other CFLAGS are determined elsewhere by configure and the environment, of course. I didn't take a close look at the patch, but I was just wondering because if -ldl is before conftest.c then the compiler might not notice that you need dlopen() from -ldl until after it's processing conftest.c, which would be too late. So yes, sometimes order of files/libraries on the command line *is* important. Regards, John Ralls -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH warl...@mit.eduPGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Seeking documentation review
John Ralls jra...@ceridwen.us writes: On Sep 23, 2013, at 7:32 PM, Robert Ratliff ratliff.bo...@gmail.com wrote: Can someone please review some documentation I've written that I would like to contribute to GnuCash? I've created a bug for the change, and submitted my changes as a patch. The patches are in the bug report here: https://bugzilla.gnome.org/show_bug.cgi?id=708267 Particularly someone who knows about the budget functions, for that's what Robert's doc patch is about. Where is Chris when we need him? Regards, John Ralls -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH warl...@mit.eduPGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: r23186 - gnucash/trunk - Bug 654196 - make check fails when built with --enable-dbi
Am Sonntag, 22. September 2013, 14:56:52 schrieb John Ralls: The new test fails for me as well: Kubuntu 11.10, and config.log says: configure:20323: checking Looking for at least one supported DBD module configure:20343: gcc -o conftest -I/home/cs/usr/include -ldl conftest.c - lpthread 5 /tmp/ccISRVMn.o: In function `main': conftest.c:(.text+0xf): undefined reference to `dlopen' So libtool.m4's call of AC_CHECK_LIB([ldl], [dlopen],...) found dlopen in libdl.so. More likely then that the command gcc -o conftest -I/home/cs/usr/include -ldl conftest.c - lpthread isn't trying to link libdl. Which is strange, especially since it works fine on Debian Wheezy 64. Hmm. That space between - and lpthread is bothersome. Try this patch and see if it changes anything: Indeed, with this patch it works. The log says configure:20283: checking for dbi/dbi.h configure:20283: result: yes configure:20320: checking Looking for at least one supported DBD module configure:20340: gcc -o conftest -I/home/cs/usr/include conftest.c -ldl - lpthread 5 configure:20340: $? = 0 configure:20340: ./conftest configure:20340: $? = 0 Does this mean it just was the -ldl had to come after the conftest.c argument? Seems a bit weird to me that it works for you, though. In any case, I'd be glad if you could commit this patch. Thanks! Regards, Christian diff --git a/configure.ac b/configure.ac index 2b78423..17c3c6c 100644 --- a/configure.ac +++ b/configure.ac @@ -534,6 +534,7 @@ then EXTRA_SEARCH_LIBS= AC_CHECK_HEADERS(dbi/dbi.h) if test x$ac_cv_header_dbi_dbi_h != xno; then +saved_LIBS=$LIBS AC_ARG_WITH( dbi-dbd-dir, [AS_HELP_STRING([--with-dbi-dbd-dir=PATH],[specify location of libdbi dri [[GNC_DBD_DIR=$with_dbi_dbd_dir @@ -551,7 +552,7 @@ then LDINC=#include dlfcn.h LDFUNCARGS=, RTLD_NOW LDEXT=so -export LDFLAGS=$LDFLAGS $lt_cv_dlopen_libs +LIBS=$lt_cv_dlopen_libs $LIBS ;; esac export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$EXTRA_SEARCH_LIBS @@ -581,6 +582,7 @@ to the configure argument list and run it again. LIBDBI_LIBS=-ldbi _COMPONENTS=$_COMPONENTS dbi +LIBS=$saved_libs else AC_MSG_ERROR([ Regards, John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: r23186 - gnucash/trunk - Bug 654196 - make check fails when built with --enable-dbi
On Sep 24, 2013, at 1:43 PM, Christian Stimming christ...@cstimming.de wrote: Am Sonntag, 22. September 2013, 14:56:52 schrieb John Ralls: The new test fails for me as well: Kubuntu 11.10, and config.log says: configure:20323: checking Looking for at least one supported DBD module configure:20343: gcc -o conftest -I/home/cs/usr/include -ldl conftest.c - lpthread 5 /tmp/ccISRVMn.o: In function `main': conftest.c:(.text+0xf): undefined reference to `dlopen' So libtool.m4's call of AC_CHECK_LIB([ldl], [dlopen],...) found dlopen in libdl.so. More likely then that the command gcc -o conftest -I/home/cs/usr/include -ldl conftest.c - lpthread isn't trying to link libdl. Which is strange, especially since it works fine on Debian Wheezy 64. Hmm. That space between - and lpthread is bothersome. Try this patch and see if it changes anything: Indeed, with this patch it works. The log says configure:20283: checking for dbi/dbi.h configure:20283: result: yes configure:20320: checking Looking for at least one supported DBD module configure:20340: gcc -o conftest -I/home/cs/usr/include conftest.c -ldl - lpthread 5 configure:20340: $? = 0 configure:20340: ./conftest configure:20340: $? = 0 Does this mean it just was the -ldl had to come after the conftest.c argument? Seems a bit weird to me that it works for you, though. In any case, I'd be glad if you could commit this patch. Thanks! Yay! Yes, it probably does, though it's weird that only your compiler seemed to mind. Done, r23195. Regards, John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Allowing the user to select the currency symbol
Hi, On Tue, September 24, 2013 6:01 pm, Frédéric Perrin wrote: Hi list, Since I moved to Britain, I have about half of my acocunts in euro, the other half in pounds. As I still use the same locale, some accounts use a nice ⬠symbol and some the less nice GBP ticker symbol. I want to be able to ddefine the symbol gnucash should use when printing amounts. What do you think of that feature ? I have implemented code to do that. We add a property char* user_symbol to the Commodity class. This property is populated from GConf, and then used instead of the mnemonic when printing amounts (we still use the canonical symbol of the default currency when applicable). I think I still need a nice interface in the Preferences dialog to set the user_symbol, but before I do that, what do you think of that implementation ? Patch is at: http://brol.fperrin.net/gnucash/nice-currency.patch Screenshot, where EUR is my default currency, AUD and GBP have a nice symbol defined, and CHF has no symbol defined : http://brol.fperrin.net/gnucash/nice-currency.png If you're going to extend the Commodity Class then why not just put the symbols into the default constructors in the iso-4217-currencies file? Why put it into GConf? Fred -derek -- Derek Atkins 617-623-3745 de...@ihtfp.com www.ihtfp.com Computer and Internet Security Consultant ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Allowing the user to select the currency symbol
Hi Derek, Le mercredi 25 à 0:08, Derek Atkins a écrit : If you're going to extend the Commodity Class then why not just put the symbols into the default constructors in the iso-4217-currencies file? Why put it into GConf? Which of Australian, Canadian, Zimbabwean dollar gets to use the $ sign? It seems to me only the user knows which currency they mean with $, so attributing a symbol to a currency (beyond the locale one) should be a user decision. (I guess this is why only the locale currency gets a symbol in the current implementation) -- Fred ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Allowing the user to select the currency symbol
On Tue, September 24, 2013 6:19 pm, Frédéric Perrin wrote: Hi Derek, Le mercredi 25 à 0:08, Derek Atkins a écrit : If you're going to extend the Commodity Class then why not just put the symbols into the default constructors in the iso-4217-currencies file? Why put it into GConf? Which of Australian, Canadian, Zimbabwean dollar gets to use the $ sign? It seems to me only the user knows which currency they mean with $, so attributing a symbol to a currency (beyond the locale one) should be a user decision. (I guess this is why only the locale currency gets a symbol in the current implementation) Yes, indeed, that is the main reason. Requiring people to input the symbols themselves is also something... Not Nice. Users don't want to have to figure those things out. Even worse, GConf editing is really only simple on Linux, so you're leaving out users of Mac and Windows. Fred -derek -- Derek Atkins 617-623-3745 de...@ihtfp.com www.ihtfp.com Computer and Internet Security Consultant ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Allowing the user to select the currency symbol
Le mercredi 25 à 0:33, Derek Atkins a écrit : On Tue, September 24, 2013 6:19 pm, Frédéric Perrin wrote: Hi Derek, Le mercredi 25 à 0:08, Derek Atkins a écrit : If you're going to extend the Commodity Class then why not just put the symbols into the default constructors in the iso-4217-currencies file? Why put it into GConf? Which of Australian, Canadian, Zimbabwean dollar gets to use the $ sign? It seems to me only the user knows which currency they mean with $, so attributing a symbol to a currency (beyond the locale one) should be a user decision. (I guess this is why only the locale currency gets a symbol in the current implementation) Yes, indeed, that is the main reason. Requiring people to input the symbols themselves is also something... Not Nice. Users don't want to have to figure those things out. Yes. OTOH, beyond the locale currency, we can't decide for the user what is meant by $ or £. Do you think this is too much trouble for something users won't bother to configure ? I guess we can decide to use $ for USD, £ for GBP and for the other currencies, invent some qualifier. CAD already has C$, but e.g. Brunei and Bahamain both have B$. How do we resolve this ambiguity ? Even worse, GConf editing is really only simple on Linux, so you're leaving out users of Mac and Windows. Editing GConf was only for development, if the idea is sound we'd hopefully also get a GUI editor (new tab in the Pref dialog ?). -- Fred ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
