Re: [go-nuts] Re: Go 1.14 Release Candidate 1 is released
I would caution that reduced performance with ondemand might be a good thing. If the job is doing lots of IO this means the process has little/less overhead so less drain on the cpu meaning it takes a while to spin back up. If both governors show the serious degradation I would be far more concerned. It can also be attributed to more underlying lock contention -causing deschedules - which would be a bad thing. > On Feb 7, 2020, at 5:30 PM, Ian Lance Taylor wrote: > > On Fri, Feb 7, 2020 at 11:01 AM Klaus Post wrote: >> >> I am seeing a generally negative impact of Go 1.13 -> 1.14-RC1 in terms of >> speed. > > Thanks. Would you mind opening an issue about this (if you haven't already)? > > Ian > > -- > You received this message because you are subscribed to the Google Groups > "golang-nuts" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-nuts+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/golang-nuts/CAOyqgcV2CkgiPm1%3DbWtVUA2ra71N9BkYvaAOfCACMVzALOvY2w%40mail.gmail.com. -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/51EADAE3-8664-4C8E-AAA9-6CBB20A29BCC%40ix.netcom.com.
Re: [go-nuts] Re: Go 1.14 Release Candidate 1 is released
On Fri, Feb 7, 2020 at 11:01 AM Klaus Post wrote: > > I am seeing a generally negative impact of Go 1.13 -> 1.14-RC1 in terms of > speed. Thanks. Would you mind opening an issue about this (if you haven't already)? Ian -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CAOyqgcV2CkgiPm1%3DbWtVUA2ra71N9BkYvaAOfCACMVzALOvY2w%40mail.gmail.com.
Re: [go-nuts] Re: Go 1.14 Release Candidate 1 is released
On Thu, Feb 6, 2020 at 9:51 AM Dax McDonald wrote: > > Hit a small snag while using Go 1.14. > Running go1.14beta1 build main.go on our project, github.com/rancher/rio > results in > > go: github.com/StrongMonkey/linkerd2@v0.0.0-20191021165729-976fad67457a: > parsing go.mod: go.mod:3: usage: go 1.23 > > It looks like we are hitting https://github.com/golang/go/issues/36319 but > the go.mod file in the fork seems to require 1.12.9 which makes me think it > is a different issue. > > https://github.com/StrongMonkey/linkerd2/blob/webhook/go.mod > > I wasn't sure if this rose the level of being an actual bug or just incorrect > usage of the go.mod file. This does not happen with Go 1.13.4 > > Please let me know if this isn't the right place to post this. The file https://github.com/StrongMonkey/linkerd2/blob/master/go.mod is using an invalid syntax. It says "go 1.12.9", but the format is "go MAJOR.MINOR". So "go 1.12" would be OK but "go 1.12.9" is not. I assume that someone wrote that line manually. Ian -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CAOyqgcV-KOOBVL3rj0edFhehDbc%2BP2yEV7eR%3DyPDUoobpfE3iA%40mail.gmail.com.
Re: [go-nuts] Re: Go 1.14 Release Candidate 1 is released
On Wed, Feb 5, 2020 at 11:33 PM Manlio Perillo wrote: > > Is there some overhead due to preemption? Sure, but measurements show that performance is better with this approach, especially at scale. > About EINTR, I suspect that some programs will have problems. > As an example > https://github.com/golang/go/issues/22838 > > The issue was reported for MacOS, but technically every signal, including > SIGSTOP, can interrupt a syscall. Go installs all signal handlers with SA_RESTART set, so most cases will not see an EINTR error. And the Go standard library already checks for EINTR every place that it needs to. The issue you mention is not a problem on most systems; apparently on macOS SA_RESTART doesn't work for SIGTSTP. That said, as the release notes say, some programs that make direct system calls are going to see more EINTR errors than they did before. EINTR was already a possibility; it's just more common now. Ian -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CAOyqgcW66BwS4GQecwGLVHAQ8vXJTjc_OU_YSPQwfkq2ZqC7aA%40mail.gmail.com.
Re: [go-nuts] Re: Go 1.14 Release Candidate 1 is released
On Wed, Feb 5, 2020 at 3:40 PM amr wrote: > > I'm seeing the same problem, also. Sorry about that. It's been fixed. Ian -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CAOyqgcVMTuyf7RE6TnGegwCopUPeGR5mto5%2B-xQHr5fPBaz2Ag%40mail.gmail.com.
Re: [go-nuts] Re: Go 1.14 Release Candidate 1 is released
On Wed, Feb 5, 2020 at 2:05 PM Kaveh Shahbazian wrote: >> >> "Goroutines are now asynchronously preemptible." > > Very nice! > >> "A consequence of the implementation of preemption is that on Unix systems, >> including Linux and macOS systems, programs built with Go 1.14 will receive >> more signals than programs built with earlier releases. This means that >> programs that use packages like syscall or golang.org/x/sys/unix will see >> more slow system calls fail with EINTR errors. Those programs will have to >> handle those errors in some way, most likely looping to try the system call >> again." > > How does this affects projects like Docker? I expect that Docker already checks for EINTR where required, so there shouldn't be much effect at all. Note that checking for EINTR was always required; what is new in 1.14 is that failing to check for EINTR is more likely to appear as a problem. But please do let us know if Docker doesn't work well with 1.14. Ian -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CAOyqgcX7WhnuQQW2AeaQcGNbx9guaYdGS%2BDdJvM5_V81XBUg0Q%40mail.gmail.com.
