CellTable an AsyncDataProvider: no table content
I'm trying to figure out how to use AsyncDataProvider with CellTable so I've this test code that has a Simple pager that is initialized and working ( display full range and current range and you can use () () () () ) the table is shows the headers but no dat what's wrong / package fr.metronome.web.client.table; import java.util.Arrays; import java.util.Date; import java.util.List; import com.google.gwt.cell.client.DateCell; import com.google.gwt.core.client.EntryPoint; import com.google.gwt.core.client.GWT; import com.google.gwt.requestfactory.ui.client.EntityProxyKeyProvider; import com.google.gwt.user.cellview.client.CellTable; import com.google.gwt.user.cellview.client.Column; import com.google.gwt.user.cellview.client.SimplePager; import com.google.gwt.user.cellview.client.SimplePager.TextLocation; import com.google.gwt.user.cellview.client.TextColumn; import com.google.gwt.user.client.Window; import com.google.gwt.user.client.ui.Composite; import com.google.gwt.user.client.ui.RootPanel; import com.google.gwt.user.client.ui.VerticalPanel; import com.google.gwt.view.client.AsyncDataProvider; import com.google.gwt.view.client.HasData; import fr.metronome.web.client.database.clientdao.CRegIndexBodyTableClientDAO; import fr.metronome.web.client.database.clientdao.ClientDAO; import fr.metronome.web.client.events.CRegIndexBodyTableCountEvent; import fr.metronome.web.client.events.CRegIndexBodyTableCountEventHandler; import fr.metronome.web.client.events.CRegIndexBodyTableEntriesLoadedEvent; import fr.metronome.web.client.events.CRegIndexBodyTableEntriesLoadedEventHandler; import fr.metronome.web.client.events.CRegIndexBodyTablesLoadedEvent; import fr.metronome.web.client.events.CRegIndexBodyTablesLoadedEventHandler; import fr.metronome.web.client.proxies.CRegIndexBodyTableProxy; import fr.metronome.web.client.util.Fmt; public class CellTableEx extends Composite { AsyncDataProviderCRegIndexBodyTableProxy provider = new AsyncDataProviderCRegIndexBodyTableProxy( new EntityProxyKeyProviderCRegIndexBodyTableProxy()) { @Override protected void onRangeChanged(HasDataCRegIndexBodyTableProxy display) { int start = display.getVisibleRange().getStart(); fetch(start); } }; CellTableCRegIndexBodyTableProxy table; ListCRegIndexBodyTableProxy bodies = null; Integer numRows =3; Long regId = 21049L; Long maxRows = 0L; Integer curStart = 0; public CellTableEx () { table = buildTable(); table.setPageSize(numRows); SimplePager.Resources pr = GWT.create(SimplePager.Resources.class); SimplePager pager = new SimplePager(TextLocation.CENTER,pr,false,0,true); pager.setDisplay(table); VerticalPanel vp = new VerticalPanel(); vp.add(table); vp.add(pager); initWidget(vp); provider.addDataDisplay(table); /// Gets Count ClientDAO.getControler() .getEventBus().addHandler( CRegIndexBodyTableCountEvent.TYPE, new CRegIndexBodyTableCountEventHandler() { @Override public void onLoaded(CRegIndexBodyTableCountEvent event) { maxRows = event.getCount(); provider.updateRowCount(maxRows.intValue() , true); fetch(0); // Asking for data } }); / getting Data Range ClientDAO.getControler() .getEventBus().addHandler( CRegIndexBodyTableEntriesLoadedEvent.TYPE, new CRegIndexBodyTableEntriesLoadedEventHandler() { @Override public void onLoaded(CRegIndexBodyTableEntriesLoadedEvent event) { provider.updateRowData(0, event.getBodies()); Window.alert(Updateted Size + event.getBodies().size() + max + maxRows ); } }); Asking for Count CRegIndexBodyTableClientDAO.countByRegistre(regId); } private CellTableCRegIndexBodyTableProxy buildTable () { CellTableCRegIndexBodyTableProxy t = new CellTableCRegIndexBodyTableProxy(numRows); TextColumnCRegIndexBodyTableProxy viewColumn = new TextColumnCRegIndexBodyTableProxy() { @Override public String getValue(CRegIndexBodyTableProxy body) { return body.getView().toString(); } }; TextColumnCRegIndexBodyTableProxy typeColumn = new TextColumnCRegIndexBodyTableProxy() { @Override public String getValue(CRegIndexBodyTableProxy body) { return body.getType(); } }; TextColumnCRegIndexBodyTableProxy dateColumn = new TextColumnCRegIndexBodyTableProxy() { @Override public String getValue(CRegIndexBodyTableProxy body) { return Fmt.year(body.getDate()); } }; TextColumnCRegIndexBodyTableProxy nameColumn = new TextColumnCRegIndexBodyTableProxy() { @Override public String getValue(CRegIndexBodyTableProxy body) { return body.getPatronyme().getName(); } }; t.addColumn(viewColumn, Vue); t.addColumn(typeColumn, T); t.addColumn(dateColumn, Date); t.addColumn(nameColumn, Noms); return t; } private void fetch( Integer start ) { curStart = start; CRegIndexBodyTableClientDAO.findEntries(regId, start, numRows); } } -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this
Re: Implement select all in CellTable
Hi, You can use a com.google.gwt.view.client.MultiSelectionModel with your CellTable MultiSelectionModelT msm = new MultiSelectionModelT(); cellTable.setSelectionModel(msm); for (T item : cellTable.getVisibleItems()) { msm.setSelected(item, true); } Alexandre 2011/4/18 Subhrajyoti Moitra subhrajyo...@gmail.com Hello, Can some one please point me to a Select All functionality in a CellTable? The functionality i have to implement, is that some of the CellTable headers has a select box which when clicked will select all the rows of CellTable being displayed. Please give some hints as to how to implement this. Example would be awesome!! Thanks, Subhro. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Custom Server Validation in GWT 2.2
This is just an update on this question, I am able to do the server custom constraint successfully using GWT 2.2 After checking the source code, I think GWT handles the validation the same way as other framework, hence I just following the guide below to create the customer constraint http://docs.jboss.org/hibernate/validator/4.0.1/reference/en/html/index.html and it just work ;-) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Odg.: Re: How to speed up Hosted mode
I noticed that if the temp directory wasn't cleared Eclipse took longer and longer to start up. Up to 10 minutes. I wrote a simple script which runs every boot to clear out the offending files. I am not sure if this affects the compilation performance or not. On Apr 18, 9:24 pm, Jeff Larsen larse...@gmail.com wrote: Lotus notes ouch! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Odg.: Re: How to speed up Hosted mode
I've also noticed that moving from a GWT 1.7 version of building apps to the 2.1 way (UiBinder CellWidgets etc) makes a noticable difference... (less java/ecmascript code I guess). On Apr 18, 9:24 pm, Jeff Larsen larse...@gmail.com wrote: Lotus notes ouch! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Odg.: Re: Odg.: Re: How to speed up Hosted mode
mike b, This is something to try - if I only change code in async block, maybe it will recompile only this part. But this will note have any effect on startup time. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: How to add a SliderBar to a panel instead of RootPanel?
I copied your code and realised there's a lot of missing dependencies like what's playpausebutton etc. if you want people to help, you need to address all these in fact, give all your code. :) On Apr 19, 5:49 am, Rahul Sanghi rahul7...@gmail.com wrote: I am trying to develop a HTML5 based player. Wanted to know how we can add the Slider bar to a Panel and add this Panel to the RootPanel instead of adding it directly to the RootPanel. The SliderBar doesnt work/render properly when i try to do the former, but works perfectly when i try to add it directly to the RootPanel. I am using Firefox browser. Please let me know any workaround, or if i am missing out on something! Here's my code snippet: SliderBar slider = new SliderBar(0.0, 100); slider.setStepSize(10); slider.setCurrentValue(5); slider.setNumTicks(10); slider.setNumLabels(10); slider.setWidth(100%); slider.redraw(); //TODO Create playButton, stopButton, timeLabel, fullSreenButton //TODO Assemble playStopPanel. horizontal playControlPanel.add(playPauseButton); playControlPanel.add(stopButton); playControlPanel.add(volumeButton); playControlPanel.add(timeLabel); playControlPanel.add(fullScreenButton); //playControlPanel.add(progressBar); playControlPanel.setWidth(100%); playControlPanel.add(slider); // TODO Assemble Main panel. mainPanel.add(playControlPanel); // TODO Associate the Main panel with the HTML host page. RootPanel.get(playerPanel).add(mainPanel);//doesnt render properly RootPanel.get(playerPanel).add(slider);//works fine Thanks and Regards Rahul Sanghi -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: problem in debug a gwt project
you are facing seriously basic problem. I suggest you start over again. download eclipse for java http://www.eclipse.org/downloads/ ( the second from top) download the latest jdk http://www.oracle.com/technetwork/java/javase/downloads/index.html. if you are using mac, i suggest openjdk. download eclipse plugin http://code.google.com/eclipse/ On Apr 19, 3:26 am, baha bahasheik...@gmail.com wrote: i can't debug my gwt project using the jetty on eclipse. there is no option are given to me to debug as gwt project. I tried netbeans too, but after i click (GWT dev mode w/o a JEF server ) the jetty not opened and no browser is opened. any help plase -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: External Images in CellTable cell
Hi, Try to look at this link - http://groups.google.com/group/google-web-toolkit/browse_thread/thread/1995e2bb604088c6/9c919c2ca7ce55f2?lnk=gstq=gwt+ImageCell#9c919c2ca7ce55f2 -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: External Images in CellTable cell
On Apr 19, 2:20 pm, Manvel Saroyan saroy...@gmail.com wrote: Hi, Try to look at this link -http://groups.google.com/group/google-web-toolkit/browse_thread/threa... -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: size of my text remains unchanged when I zoom in/out
On Tue, Apr 19, 2011 at 03:26, dadada ytbr...@gmail.com wrote: is this a browser issue? both of them use the webkit render engine. in chrome, you can go into the tools menu developer tools. then open the elements tab, click on the magnification glass at the bottom left, then on the element in the website. on the right you can see all the glory details for that element. I also realised that elements which has margin set in their css get rearranged when i zoom in/out. How do I avoid these issues? uhm, that's a pure html problem. are those elements floating divs or something like that? a table (Horizontal/VerticalPanel in GWT) is old-school, but might help. H -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Strange scrolling div problem in WebKit browsers
Hi, I have a strange problem and maybe someone here can give me a hint whats going on. Basically I have a custom composite that acts as a list. This list composite wraps a ScrollPanel which contains a AbsolutePanel that contains the list items positioned according to their height. The ScrollPanel has a ScrollHandler attached and everytime scrolling is detected the list will compute which list items are visible and only shows these. So its designed for a large dataset to speed things up by displaying only a small subset of the dataset (it was designed before CellList was available). A list item is a simple div like: div class=GPHOOYDBNQ title=title-of-that-list-item listmodelidx=64 style=overflow-x: hidden; overflow-y: hidden; cursor: pointer; width: 100%; height: 21px; line-height: 21px; right: 0px; position: absolute; left: 0px; top: 1344px; String representation of list model item 64/div So I have some of these divs in my absolute panel which is in a ScrollPanel. Now when I move my mouse pointer over a list items text and try to scroll with the mouses scroll wheel nothing will happen. If I move the mouse pointer inside the list item out of the text into an empty area (list is wider than the list items text and div will use the full width of the list), scrolling will be done. What might be the reason the browser thinks that he can not scroll or do not have to scroll the contents of ScrollPanel when my mouse is over a list items text but does scroll when its in an empty area inside the list/list item? I do not have any clue. It seems to happen in WebKit based browsers like Safari and Chrome. Firefox, Opera and IE are working fine. Any Suggestions? Thanks J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: GWT 2.2 CellTable dragging column widths with mouse ...
Here's my implementation to handle column resizing. I created the CellTable class in my SourceTree with same package name as Google named it. I extended the onBrowserEvent2 function with my resizing function: // Forward the event to the associated header, footer, or column. boolean isClick = click.equals(eventType); int col = tableCell.getCellIndex(); // Control resizing of columns boolean resizing = resizeColumns(event, target, col, tableCell); if (resizing) { return; } if (section == thead) { The resizing function looks like this. I added a function to calculate the column width if no with are set. Setting width must be done with Unit.PX at the moment. /** The mouse down. */ private boolean mouseDown = false; /** The resize value. */ private int oldXValue = -1; /** The column to resize. */ private int columnToResize = -1; /** * Resize columns. * * @param event *the event * @param target *the target * @param col *the col * @param tableCell *the table cell * @return true, if successful */ private boolean resizeColumns(Event event, Element target, int col, TableCellElement tableCell) { String eventType = event.getType(); int xValue = event.getClientX(); int offsetRight = xValue - (tableCell.getAbsoluteLeft() + tableCell.getClientWidth()); int offsetLeft = xValue - tableCell.getAbsoluteLeft(); boolean resize = false; if (offsetRight -10) { resize = true; } else { resize = false; } if (resize || mouseDown) { DOM.setStyleAttribute((com.google.gwt.user.client.Element) target, cursor, col-resize); } else { DOM.setStyleAttribute((com.google.gwt.user.client.Element) target, cursor, auto); return false; } if (mousedown.equals(eventType)) { mouseDown = !mouseDown; if (mouseDown columnToResize == -1 oldXValue == -1) { columnToResize = col; oldXValue = xValue; } else { calculateActualColumnWidths(); int offset = 0; offset = xValue - oldXValue; if (offset != 0 columnToResize -1) { this.setColumnWidth( columns.get(columnToResize), Double.valueOf(columnWidths.get(columns.get(columnToResize)).replace(Unit.PX.getType(), )) + offset, Unit.PX); } this.redraw(); columnToResize = -1; oldXValue = -1; } } return true; } /** * */ private void calculateActualColumnWidths() { if (columnWidths.size() == 0) { GWT.log(Calculate column width); int width = this.getOffsetWidth() / columns.size(); for (ColumnT, ? col : columns) { this.setColumnWidth(col, width, Unit.PX); } } } Resizing is done at the last 10 px of each column. No other actions are performed in this area. First click activated resizing, set the column index for resizing and takes the actual x value. Second click releases resizing, calculates the offset of saved x value and actual x value and set the width of saved column index. Not very nice, but the celltable don't fire mouseup event. Other solutions are welcome. Perhaps we could create a nice and performant column resizing together. I'd like to show resizing with a small line. Some ideas how to draw a line at a given position with GWT? On 9 Apr., 13:02, meyertee meyer...@gmail.com wrote: I'll have to implement the same in pure html/js soon, my strategy so far was to put some markup in the table header that creates an element on the right side of the header to trigger the resize-cursor and the mouse-events. I saw the same thing here http://bz.var.ru/comp/web/resizable.html and in other places. I did a quick test a few weeks ago with this markup and the styles below, which worked on the browsers I had available (Webkit/FF). Not exactly legal markup, but it seems to work. th class=resizablediv class=resizeWrapperdiv class=labelTitle/divdiv class=handle/div/div/th th.resizable {padding-right: 0;} th.resizable .resizeWrapper {position: relative;} th.resizable .label {position:relative;margin-right: 20px;} th.resizable .handle {position:absolute;height:100%;width:3px;top: 0;right: 0;cursor: e-resize;} The rest is as Sky describes an exercise in picking up mouse-events and doing some calculations depending on the desired resize behavior - flexible table width (Excel-like) or fixed width (for example Mac-Mail). Sky's idea of puting an extra column in between is also interesting. I'll have to think about
SimplePager row count
Hi, I'm encountering a problem with SimplePager; the problem is that when I clic to display the next page of rows the indicator of rows number multiply by two (for example initially I have to display 30 rows, initially the pager displays 1-8 of 30 However, when I clic to display the next page the indicator displays 9-16 of 60 ) Any help are welcome. Thanks. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Using GWT only for UI design
On Tue, Apr 19, 2011 at 00:19, The Main Meyn ajrm...@gmail.com wrote: Does GWT have an XML parser, so that I could make sure all my servlets return an XML. Yes For example how would I get a combo designed using GWT to load the following servlet. http://202.54.180.145/Global/AddrXmlServlet?country_id=100 1. you need an event when to load the data. e.g. at startup or when you press a button. 2. the request builder does the http ajax call. http://code.google.com/webtoolkit/doc/latest/DevGuideServerCommunication.html#DevGuideHttpRequests 3. the returned data needs to be parsed with the xml parser and based on what is there, fill in the items into the combo box: http://code.google.com/webtoolkit/doc/latest/DevGuideCodingBasicsXML.html Also, read in the GWT API about XML Node and Element! So, to get started, please read those articles, add these lines inherits name=com.google.gwt.xml.XML / inherits name=com.google.gwt.http.HTTP / to your module's xml description file, and you are ready to go. H -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
W3C DOM Compatibility
Looking to the W3C DOM Compatibility - CSS Object Model View (http:// www.quirksmode.org/dom/w3c_cssom.html) I see that only some properties/ methods are supported in GWT. I would like to know if there is a criteria to determine which of the methods/properties are supported and which are not. In my particular case I need to use Document's elementFromPoint method, supported in all browsers but not available in GWT. I could code it myself in a JSNI method but thinking in code maintenance and browser abstraction I think this should be part of GWT DOM model. Should I open an issue/request for this? Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Dynamic JavaScript
It's difficult to make the javascript secure like this. You would have to control who can download which javascript from the server. While it may be technically possible, it's probably not worth it. It would be much easier for you if you accept something less secure, but that achieves something similar. If you check who the user is, you can then change whether your buttons are shown or not. Most advice given on this list is that you would implement it this way, and stop there. But if you really want to stop the javascript from getting to the user's browser, then you can put the code that adds the buttons behind a runAsync call, so that the code for it will be downloaded separately and you only call thatwhen the user is somebody that should see the code. This doesn't add security though - somebody could still form the right HTTP request and get the javascript from your server. If you have to prevent that, then it's a question of implementing something in the server. HTH Paul On 16/04/11 19:20, Amit Khanna wrote: Hi I wan to create two more buttons in the GreetingServer project, but these buttons should be visible only to a list of users kept in GreetingServiceImpl. These buttons are very secure and no one, other than trusted users, should even know that these buttons exist. That is, I don't even want the compiled .js files to contain code to generated these buttons. Is it possible in GWT without making a call to check if the user can view buttons or not? I know how to selectively remove javascript from a jsp, this can be done by keeping the secure part withinc:if tag or using scriptlets. I'm looking for similar solution in GWT. Please help. Thanks Amir Khanna -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
StackPanel
Hello, I hope that someone can help me with this question. Is it possible to show more than 1 item on a stackpanel? I mean, i know that by definition it just show 1 at time, but i'd like to know if it's possible to do something like that Thank you very much for your help. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
using SuggestBox with special Oracle and Suggestion - how to keep view humble
with your (http://groups.google.com/group/google-web-toolkit/ browse_frm/thread/be1e8e363a6f0794/9ceb716e29a5b985) help i learned how to implement my own SuggestionOracle(AuSuggestOracle) and own Suggestions(AuMultiWordSuggestion). In my case the suggestion object is constructed with a DTO. On a selection event i need this dto (or some fields of it) to react appropriate. I implemented a widget containing 3 suggest boxes with this special oracle and some logic between them. Now i want to apply MVP pattern - split this widget in presenter and view. At the moment the presenters display interface look like that: public interface Display { HasSelectionHandlersSuggestion getFedLand(); HasSelectionHandlersSuggestion getCounty(); HasSelectionHandlersSuggestion getCommunity(); AuSuggestOracle getFedLandOracle(); AuSuggestOracle getCountyOracle(); AuSuggestOracle getCommunityOracle(); void clearCounty(); void clearCommunity(); void activateForm(); Widget asWidget(); } the problem is the implicit knowledge about my model in methods returning AuSuggestOracle. so my question is how to get the view/ interface humble. in my case the displayed suggestion-strings are ambiguous and i need at least the id of a selected item to know what DTObject is selected. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
R: GWT MVP how to map a Composite Place to its corresponding Activities
One way to go could be to return an instance of CompositeActivity that take the CompositePlace and manage the subplaces internally -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: StackPanel
Hi, Make the one item a VerticalPanel (or HorizontalPanel) and then put what ever you want in Vertical/Horizontal Panel.. On Apr 19, 1:44 pm, Ani anapont...@gmail.com wrote: Hello, I hope that someone can help me with this question. Is it possible to show more than 1 item on a stackpanel? I mean, i know that by definition it just show 1 at time, but i'd like to know if it's possible to do something like that Thank you very much for your help. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Problems with GPE, maven, m2eclipse, WTP
Hi Martin, thanks for your answers. - inteface generation you can tell eclipse to ignore stuff in your target folder: just right click the target-folder select 'properties' and setup resource filters then you will not have any conflict Unfortunateley, I still have two copies of the files still (with different content btw., maven generator puts some static getInstance() convenience functions into the interface). As the gwt-maven-plugin- archetype seems to be able to supress GPE based generation, there should be a way though. - Tests you can exclude test-classes:http://code.google.com/p/google-web-toolkit/issues/detail?id=4454 Even with exclusion in my Main module (Main.gwt.xml) and the JUnit module (MainJUnit.gwt.xml), GPE is still putting this GWT problems marker. Any way to prevent the GWT validation ? I'm not an eclipse pro, maybethere is some setting I didn't find yet or some manuel entry in .settings - GWT module file location I think I had it working in src/main/resources, however when I started to use the GWT designer, I had to move it back to the java folder. Yes that's the thing - It's not so much an issue I don't insist on the .gwt.xml being in resources :-). Moving the file to src/main/java solves this issue. On Apr 18, 10:25 pm, Paul Schyska pschy...@googlemail.com wrote: Hi all, I have set up a maven build utilizing gwt-maven-plugin and corresponding eclipse configuration, so that ecj incremental compilation and gwt dev mode work on my server. It got a bit complicated as I want to build a Liferay-compatible portlet out of it :-) Everything seems to be working fine, dev mode, mvn package, WTP deploy, JUnit tests through eclipse and maven. However, I'm having to issues, which seem to be related to the GPE: - GPE (or something...) keeps creating *Async Interface in my src/ main/java/../client package. Which is cool, but the maven plugin will do the same on build but put the *Async Interface to /target/../ generated-sources/... .generated-sources is also on the build path, leading to the same interface being twice in build path. I assume that GPE is creating the interfaces, but I want to keep the maven code generation for this. Less boilerplate in SCM, you know :-). Any idea how to stop GPE from doing it? I don't recall GPE doing this when using the gwt-maven-plugin-related archetype for creating my project, but was unable to pin down the setting resulting in this behavior. - GPE will mark my gwt JUnit Tests as not inheriting com.google.gwt.junit.JUnit, although the corresponding GwtTestCase.gwt.xml is inherting it. The quick fix available makes my *main* module inherit com.google.gwt.junit.JUnit, which leads to a runtime error about JUnit-Class not available in runtime, which I would like to get rid off. I understand that this is a known bug in GPE (AFAIK), but I would like to turn this particular inspection off. Is there any way to do it? - Is there still no way to have the gwt.xml file in another source folder as the implementation (for example src/main/resources as per maven convention)? Thanks for any answers, Paul -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: using SuggestBox with special Oracle and Suggestion - how to keep view humble
I ran into this issue as well - knowledge of the domain in the view. I ended up getting around it by creating a delegate for the suggest oracle. public class SuggestOracleDelegator extends SuggestOracle { private SuggestOracle delegate = null; public SuggestOracleDelegator() {} public void requestSuggestions(Request request, Callback callback) { if(this.delegate != null){ this.delegate.requestSuggestions(request, callback); } } public void setDelegate(SuggestOracle delegate) { this.delegate = delegate; } } Then I wrap this in a HasSuggestions interface that lets you set the delegate oracle from outside, and attach listeners and so forth. Seems to work quite well. -Ben -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
help diagnose: Server class 'org.junit.Before' could not be found in the web app
I'm getting a warning when starting my app in hosted mode: Server class 'org.junit.Before' could not be found in the web app, but was found on the system classpath. Apparently, one of my junit test cases is getting loaded by the server but I'm not to determine how. Can anyone suggest how I can go about diagnosing this? Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Odg.: Re: How to speed up Hosted mode
The main problem is that every time when hosted mode is started all classes are loaded. When you refresh hosted mode and your classes doesn't implement Serializable then these classes will be realoaded even when they were not modified. I don't really now if this will work for GWT hosted mode, but works for other containers like Tomcat (GWT used tomcat lite while ago i'm not sure what are they using now). Maybe this can speed up your hosted mode refresh operation. And of course set only one language and browser support. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: help diagnose: Server class 'org.junit.Before' could not be found in the web app
Do you put your test cases on the same folder as your production classes? On Tue, Apr 19, 2011 at 10:21 AM, cri chuck.irvine...@gmail.com wrote: I'm getting a warning when starting my app in hosted mode: Server class 'org.junit.Before' could not be found in the web app, but was found on the system classpath. Apparently, one of my junit test cases is getting loaded by the server but I'm not to determine how. Can anyone suggest how I can go about diagnosing this? Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. -- Magno Machado Paulo http://blog.magnomachado.com.br http://code.google.com/p/emballo/ -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: How to speed up Hosted mode
On Monday, April 18, 2011 1:49:49 PM UTC+2, maticpetek wrote: Hello, We are developing our app in GWT now for a couple of years. And code base is becoming bigger every day And hosted mode is also become very slow. Refresh in browser takes around 1 minute. Forms opening a couple of seconds. All this time my CPU is on around 160% (if I look Activity monitor). This happend in FF. Chrome is not useful because it takes too much time (I gave up after 10 minutes). Any idea how could we speed up hosted mode? Always use the latest GWT version: http://twitter.com/salvadordiaz/status/55177780895293440 (unless it adds many new features that you don't need; see below about classpath/sourcepath) GWT 2.4 (won't be in 2.3 AFAIK) will add an (optional) cache that will speed things up even more (I haven't tried it yet though) so try running from trunk if you can: http://code.google.com/p/google-web-toolkit/source/detail?r=9893 Would code split with GWT.runAsync do any help? GWT.runAsync actually runs synchronously in DevMode, so it won't help. Or on the end you just must have very fast CPU? Thank you for help. I believe memory and a fast disk are more important than a fast CPU. Trimming down your classpath and your source path (paths listed as source or super-source in your *.gwt.xml files) should help. My environment : - OS X Show Leopard - JDK 1.6 - GWT 2.2 - GXT 2.2.3 - Firefox 3.6 Remove GXT from the equation! (half-kidding only) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
background color of a row in celltable
I want to change the color of row on a particular condition but I'm not able to do this , I've have used following piece of code for this. able.setRowStyles(new RowStyleslogInfo() { @Override public String getStyleNames(logInfo p, int rowIndex) { if (p.getEventType().compareTo(emerg)==0) { return tableRowBgColorRed; } else { return tableRowBgColoryellow; } } }); -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Binary with x-user-defined Charset
Hi I am are trying to get the binary transfer data within the gwt framework. Unfortunatly this won't work. It seems as if the Binary String gets UTF-8 reinterpreted? The String going over the wire as what Wireshark tells me: a0 0f 00 00 70 85 9d 0f 00 00 ... and the data which is from the xhr.getResponseText().getBytes() function: ef 9e a0 0f 00 7f 00 63 6f ... I also tried the string to byte trick used in the quake2-gwt port: sbb.stringToByteBuffer(xhr.getResponseText()) Which gives me the strange exception: java.lang.IncompatibleClassChangeError: Class java.nio.HeapByteBuffer does not implement the requested interface com.hbm.StringToByteBuffer Another aproach was to try to get the binary data via xhr.getResponseText().getBytes(x-user-defined-binary) or xhr.getResponseText().getBytes(x-user-defined). But this charset is unfortunatly unknown. So any hints how to get the binary data? Appended is the code for reference Best regards package com.hbm.pmx.client.communication; import java.nio.ByteBuffer; import com.google.gwt.xhr.client.ReadyStateChangeHandler; import com.google.gwt.xhr.client.XMLHttpRequest; public class MeasvalManager { private static StringToByteBuffer sbb; /* = (StringToByteBuffer) (Object) (ByteBuffer.allocate(1));*/ private int m_nrOfChannels; private ReqManager m_reqManager = ReqManager.getInstance(); public MeasvalManager() { newRequest(); sbb=ByteBuffer.allocate(1); } private native void overrideMimeType(XMLHttpRequest req,String mimeType) /*-{ req.overrideMimeType(mimeType); }-*/; public void newRequest() { XMLHttpRequest oxhr=XMLHttpRequest.create(); int sessionId=m_reqManager.getSessionId(); if(sessionId0) { oxhr.setOnReadyStateChange(new ReadyStateChangeHandler() { @Override public void onReadyStateChange(XMLHttpRequest xhr) { if(xhr.getReadyState()==4) { if(xhr.getStatus()==200) { /*try { // System.out.print(java.nio.charset.Charset.availableCharsets().toString()); // System.out.print(Charset.availableCharsets().toString()); processResponse(xhr.getResponseText().getBytes(); } catch (UnsupportedEncodingException e) { e.printStackTrace(); }*/ processResponse(sbb.stringToByteBuffer(xhr.getResponseText())); } else { System.out.print(binary request failed); } } } }); overrideMimeType(oxhr,text/plain; charset=x- user-defined); oxhr.open(GET, /binary?SID=+sessionId); oxhr.send(); } else System.out.print(no session active); } private void processResponse(ByteBuffer byteBuffer) { for(int i=0;i10;i++) { System.out.print(byteBuffer.get()); System.out.print( ); } /*{ for(int i=0;i10;i++) { System.out.print((int) byteBuffer[i]); System.out.print( ); } */ /*BinaryReader br=new BinaryReader(byteBuffer); for(int i=0;i10;i++) { System.out.print((int) br.readUByte()); System.out.print( ); } /* m_nrOfChannels=br.readInt(); int tslow=br.readInt(); int tshigh=br.readInt(); long ts=tshigh32|tslow; int size=br.readInt(); System.out.print(ts); System.out.print(size); */ /* float res=br.readFloat(); System.out.print(res); for(int i=0;isize;i++) { float res=br.readFloat(); System.out.print(res); }*/ } } -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send
encoding content
Hi, I have an assignment in which I have to write a test which will send data to a servlet which extends RemoteServiceServlet using Apache HttpClient functionality. The content of the request has to be text/x- gwt-rpc. I understand that if you use GWT.create(), the serialization / encoding of the content is done by GWT internally / automatically. But what if I want to encode my own content, create my own request and send it via HttpClient? I have trouble finding the method that would do this for me. Does anybody have any hints for me? Thanks. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Imagecell in celltable
I want to add a Imagecell in celltable and used following code snippet but not able to add a column. ColumnlogInfo,String imageColumn=new Column logInfo,String(new ImageCell()) { @Override public String getValue(logInfo object) { return object.getImageUrl(); } }; table.addColumn(imageColumn, Image); LogInfo class has url for the image and getImageUrl() will get that url. But nothing is displayed at screen when I displayed the page. I want to show icons in this column for each of table. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Not able to access data of selected [row , col] visualization table
i am able to access the selected row but i am able to access the column. i think it always select the row, not the column. Anybody please to select the column as well as the data of selected row and col. I want to retrieve the selected data How should i do it? please help me... -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: help diagnose: Server class 'org.junit.Before' could not be found in the web app
Could also be that you're using maven, and have your tests getting compiled and hosted would think those classes are going to be a part of the build, but when you actually compile the app, they aren't included. I would try kicking off a deploy and see if it actually works. If it does, ignore the issue, if it doesn't then its time to figure out what class is getting compiled in that is dependent on junit. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Adding image to a cell of CellTree
Hi, i want to add an image to the cell's of a CellTree but i don't know how to do it. Thanks. CellCartella cell = new AbstractCellCartella(dblclick) { @Override public void render(Context context, Cartella value, SafeHtmlBuilder sb) { sb.appendEscaped(value.getDescCartella()); } } -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
How do I test task queue ?
Hi, We are using gwt for our application. As we need task queue because of app engine time limit, so we are adding task in the queue by using rpc call, but I need to test this task whether that task got completed or not so how do I test. I also visited task queue test: http://code.google.com/appengine/docs/java/tools/localunittesting.html#Writing_Task_Queue_Tests but I couldn't find much about task testing. Any suggestion is much appreciated. -- Regards Suresh Babu G http://www.AccountingGuru.in http://www.accountingguru.in/ -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
KeyPressevent is being called twice for suggest box - Please help!!!!!
Hi All, Here is the code I have for suggest box. But the code inside the keypress event is being called twice. Please help box = new SuggestBox(objOracle); box.addKeyPressHandler(new KeyPressHandler() { public void onKeyPress(KeyPressEvent event) { System.out.println(iN kEY pRESS EVENT); if (event.getCharCode() == KeyCodes.KEY_ENTER){ mappingTable.populateTable(box.getText()); //being called twice } } }); -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: combobox - combination of list- and suggestion box
I did use my own image for ComboBox. It can be overridden if you want to use your image instead. I think you're confused about ListBox. It's just a GWT widget wrapper for an HTML select element. The button image isn't something that comes with GWT, it's the browser's look and feel. If you want to create a button that looks like the browser's select element button, go ahead. You'll want to create a different image for each browser and use deferred binding to show the proper one in each permutation. On Tue, Apr 19, 2011 at 1:19 AM, tanteanni tantea...@hotmail.com wrote: thx for the code basically you took a suggestbox in a horizontal panel with a button right? i found similar code here: http://stackoverflow.com/questions/3039436/suggestbox-gwt-showing-all-options-on-enter-key. My Problem is how to get the button to look like the ListBox Button and how to get the button placed within the text box? or in general how to get/use styles and images of existing gwt widgets? (i didn't understand this part of your code. do you use your own image or do you use the image and style of ListBox delivered with GWT?) On 18 Apr., 20:09, Isaac Truett itru...@gmail.com wrote: I wrote a ComboBox based on the GWT 1.6 SuggestBox back in 2008. There have been a lot of changes since then, so I would be surprised if my implementation works with newer versions. The code is Apache 2.0 licensed. If you want to use any of that old code according to the terms of that license, here it is: http://code.google.com/p/simple-gwt/wiki/ComboBoxModulehttp://code.google.com/p/simple-gwt/source/browse/trunk/src/core/com/... On Mon, Apr 18, 2011 at 6:16 AM, tanteanni tantea...@hotmail.com wrote: how to make a suggestBox with a clickable drop down menu (showing suggestion on click). the use case for this is a user who don't know what text to put in to get a suggestion. i already tried listbox - no text input :-( and suggestBox with own MultiWordSuggestion and own SuggestOracle but how to get an widget that combines both? (probably by provideing a special textboxbase?) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group athttp://groups.google.com/group/google-web-toolkit?hl=en. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: How to speed up Hosted mode
One thing you can try that I believe will be in GWT 2.3 is to set the experimental GWT flag -XenableGeneratorResultCaching. It gives a modest speedup if your app uses a lot of client bundles. Thomas is referring to the new PersistentUnitCache class we've been working on. It isn't ready in GWT 2.3, but if you checkout GWT trunk, you can give it a try by adding -Dgwt.persistentunitcache -Dgwt.persistentunitcachedir=/tmp/user to your JVM args when invoking DevMode. It won't seem any faster the first time you start dev mode, but should be 40-50% faster on subsequent restarts. The initial build of all classes can be helped by trimming down your source path as Thomas says. One tool to help you do this is to run the compile report (add -compileReport to your command line), and then brows to the 'soyc' directory and pull up index.html in a web browser. Under compiler metrics you will find a list of all sources that were compiled, but remained unreferenced at the end of the build. Sometimes you can re-define your .gwt.xml module files to exclude sources from the build that are not needed. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: KeyPressevent is being called twice for suggest box - Please help!!!!!
I believe you are hitting this. http://code.google.com/p/google-web-toolkit/issues/detail?id=3533 There's a few suggestions in there for how to go about fixing it. I ended up creating a de-duping Handler that wont fire its delegate when it gets called for the duplicate event. -Ben -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: KeyPressevent is being called twice for suggest box - Please help!!!!!
Best to simply add the event handler to the SuggestBox's TextBox! suggestBox.getTextBox().addKeyPressHandler(handler); -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: KeyPressevent is being called twice for suggest box - Please help!!!!!
Thanks Broyer. You helped a lot. It worls :) On Tue, Apr 19, 2011 at 12:16 PM, Thomas Broyer t.bro...@gmail.com wrote: Best to simply add the event handler to the SuggestBox's TextBox! suggestBox.getTextBox().addKeyPressHandler(handler); -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. -- Thanks and Regards, Shilpa Kintali Ph: 585-278-3543 -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Trying out the example for gxt explorer and on compile it gives the following error - Please help
Hi All, I am trying to work on the following example from http://www.sencha.com/examples/#basicgrid and it gives me the following error Found interface com.google.gwt.core.ext.typeinfo.JClassType, but class was expected Any help is appreciated. Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
CellTable Sort in 2.2
I am using payerColumn.setSortable(true); where payerColumn is of type: private class PayerNameColumn extends ColumnBasicLocationData, String the document just tells to use the api, but I dont get the up/down arrow to do the sorting? What else needs to be done? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Trying out the example for gxt explorer and on compile it gives the following error - Please help
Please Help... I assume this is a jar conflict ..can anyone help ...what is the reason for Found interface com.google.gwt.core.ext.typeinfo.JClassType, but class was expected On Apr 19, 12:30 pm, Nisha shilp...@gmail.com wrote: Hi All, I am trying to work on the following example from http://www.sencha.com/examples/#basicgrid and it gives me the following error Found interface com.google.gwt.core.ext.typeinfo.JClassType, but class was expected Any help is appreciated. Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
How to generate complex graphs not available in google-visualization apis
Hi, I am using GWT in my project and want to have a graph which looks like http://www.graphviz.org/content/crazy . Basically a graph with a lot of interlinkings and connections with splines (curved connections). I would love to have a grph editting functionality with the same. I haven't yet found any means of implementing this. Recently I was suggested graphviz, can graphviz be integrated into gwt? Or I would be happy to know if there is any other alternative for this. I have also attached an image, the action is clicking on savemap button should enable a user to save the graph, modified by the user and modify the graph likewise. This is the requirement, and would be gracious for any kind of help regarding this. The image I am referring to can be found here : http://twitpic.com/4mbicx Thanks, Gopi Krishnan -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Trying out the example for gxt explorer and on compile it gives the following error - Please help
what version of gxt are you using? You will need to use a specific version that is compatible with gwt 2.2. If you downgrade to gwt 2.1.1 the version of gxt you're using should work. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: KeyPressevent is being called twice for suggest box - Please help!!!!!
That seems a lot simpler than what I did. Awesome. -Ben -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: KeyPressevent is being called twice for suggest box - Please help!!!!!
Is the real culprit for this behavior the following lines in the addEventsToTextBox() method of SuggestBox class: *delegateEvent(SuggestBox.this, event);* I think there are about 4 occurrences of this in the addEventsToTextBox() method: http://code.google.com/p/google-web-toolkit/issues/detail?id=3533#c9 Joel's comment seems to indicate the same. Do you guys agree ?? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Tomcat Deployment SOAP exception
Hi All, I tried to deploy my application to tomcat web server. But I couldn't make it work. It seems that the Tom Cat server cannot dynamically generated some wrapper class for SOAP. When I run it in hosted mode, everything works. It can dynamically create request wrapper Class 2011-04-19 13:35:31.437 java[664:a07] [Java CocoaComponent compatibility mode]: Enabled 2011-04-19 13:35:31.438 java[664:a07] [Java CocoaComponent compatibility mode]: Setting timeout for SWT to 0.10 Apr 19, 2011 1:35:46 PM com.sun.xml.internal.ws.model.RuntimeModeler getRequestWrapperClass INFO: Dynamically creating request wrapper Class com.rovicorp.snr.server.ws.jaxws.GetServiceList While on tom-cat web server, I got exception: SEVERE: Exception while dispatching incoming RPC call com.google.gwt.user.server.rpc.UnexpectedException: Service method 'public abstract java.util.ArrayList com.rovi.snr.ctt.client.RRSService.getServiceId(java.lang.String)' threw an unexpected exception: com.sun.xml.internal.ws.model.RuntimeModelerException: runtime modeler error: Wrapper class com.rovicorp.snr.server.ws.jaxws.GetResults is not found. Have you run APT to generate them? It seemed that the application cannot generate the wrapper classes Anyone see the similar problem before? Thanks Xing -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Search/filter form : should i use FormPanel ?
Hi, I have this page where i need to add a search/filter area at the top with several textboxes, comboxes etc. They will contain the critaerias of the research. At the bottom i will add a CellTable which will display the results of the research. My question is : what's the best way to code this search area ? may i use a FormPanel ? I will call an RPC service. Does it make sense to use a FormPanel in that case ? I mean what to put in the ACTION attribute in that case ? Maybe i should just use a SUBMIT button that will directly call the RPC service. Someone knows better ? Thanks. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re : Search/filter form : should i use FormPanel ?
Le mardi 19 avril 2011 23:11:16 UTC+2, Celinio Fernandes a écrit : Hi, I have this page where i need to add a search/filter area at the top with several textboxes, comboxes etc. They will contain the critaerias of the research. At the bottom i will add a CellTable which will display the results of the research. My question is : what's the best way to code this search area ? may i use a FormPanel ? I will call an RPC service. Does it make sense to use a FormPanel in that case ? No. I mean what to put in the ACTION attribute in that case ? Maybe i should just use a SUBMIT button that will directly call the RPC service. Not a SubmitButton, just a Button. Someone knows better ? Despite what I said above, there's a reason you would want to use FormPanel: benefit from native (browser's in-built) enter key submits form behavior; but you can just listen to KeyDownEvents to do it yourself. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Can't compile gadget with GWT Plugin 2.2 or 2.3 Beta
Thanks for your help so far but I'm still having issues. Now I'm getting this error when I attempt to compile: Compiling module com.google.gwt.gadgets.Gadgets [ERROR] Module has no entry points defined Any hints? On Apr 15, 11:25 pm, Eric Ayers zun...@google.com wrote: Yeah, I forgot, the GadgetLinker went bad with GWT 2.2 there is a patch I just put up for gadgets that builds against the latest GWT releases. http://gwt-code-reviews.appspot.com/1370808/ It doesn't handle stylesheet module directives correctly though. On Fri, Apr 15, 2011 at 2:34 AM, dicko d...@mothdesign.com.au wrote: Thanks for your help guys but I'm still having trouble. Do I just need to import the project and then re-compile it? If so, I'm getting this error: [ERROR] Unable to load class 'com.google.gwt.gadgets.linker.GadgetLinker' java.lang.ClassNotFoundException: com.google.gwt.gadgets.linker.GadgetLinker at java.net.URLClassLoader$1.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at com.google.gwt.dev.cfg.ModuleDefSchema $ClassAttrCvt.convertToArg(ModuleDefSchema.java:869) at com.google.gwt.dev.util.xml.HandlerArgs.convertToArg(HandlerArgs.java: 64) at com.google.gwt.dev.util.xml.HandlerMethod.invokeBegin(HandlerMethod.java: 221) at com.google.gwt.dev.util.xml.ReflectiveParser $Impl.startElement(ReflectiveParser.java:274) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(U nknown Source) at com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyE lement(Unknown Source) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scan StartElement(Unknown Source) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl $FragmentContentDriver.next(Unknown Source) at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(Unknown Source) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scan Document(Unknown Source) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(Unknown Source) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(Unknown Source) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(Unknown Source) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(Unknown Source) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl $JAXPSAXParser.parse(Unknown Source) at com.google.gwt.dev.util.xml.ReflectiveParser $Impl.parse(ReflectiveParser.java:331) at com.google.gwt.dev.util.xml.ReflectiveParser$Impl.access $100(ReflectiveParser.java:48) at com.google.gwt.dev.util.xml.ReflectiveParser.parse(ReflectiveParser.java: 402) at com.google.gwt.dev.cfg.ModuleDefLoader.nestedLoad(ModuleDefLoader.java: 280) at com.google.gwt.dev.cfg.ModuleDefLoader$1.load(ModuleDefLoader.java: 192) at com.google.gwt.dev.cfg.ModuleDefLoader.doLoadModule(ModuleDefLoader.java: 308) at com.google.gwt.dev.cfg.ModuleDefLoader.loadFromClassPath(ModuleDefLoader.ja va: 151) at com.google.gwt.dev.Compiler.run(Compiler.java:185) at com.google.gwt.dev.Compiler$1.run(Compiler.java:159) at com.google.gwt.dev.CompileTaskRunner.doRun(CompileTaskRunner.java: 87) at com.google.gwt.dev.CompileTaskRunner.runWithAppropriateLogger(CompileTaskRu nner.java: 81) at com.google.gwt.dev.Compiler.main(Compiler.java:166) [ERROR] Failure while parsing XML com.google.gwt.core.ext.UnableToCompleteException: (see previous log entries) at com.google.gwt.dev.cfg.ModuleDefSchema $ClassAttrCvt.convertToArg(ModuleDefSchema.java:872) at com.google.gwt.dev.util.xml.HandlerArgs.convertToArg(HandlerArgs.java: 64) at com.google.gwt.dev.util.xml.HandlerMethod.invokeBegin(HandlerMethod.java: 221) at com.google.gwt.dev.util.xml.ReflectiveParser $Impl.startElement(ReflectiveParser.java:274) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(U nknown Source) at com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyE lement(Unknown Source) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scan StartElement(Unknown Source) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl $FragmentContentDriver.next(Unknown Source) at
Gwt plugin 2.2 designer not working mac osx
Hi, I have installed the GWT plugin v2.2 under Eclipse 3.6 on Mac OSX 10.6. I can create a GWT project, and compile/test. However there are no designer options. For example the Menu Group with options to create a new Composite etc are not in my new menu tree. I checked that the project setting is using gwt 2.2 for the SDK. Is there something I can check to figure this out? I have uninstalled the plugin and sdk 3 times and re-installed but no difference. Thanks, Mike. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: How to speed up Hosted mode
I know that you can use cluster to compile your app So , 2000$ can build you 6 diskless computers :) Look that up in youtube or google On Apr 18, 2:49 pm, maticpetek maticpe...@gmail.com wrote: Hello, We are developing our app in GWT now for a couple of years. And code base is becoming bigger every day And hosted mode is also become very slow. Refresh in browser takes around 1 minute. Forms opening a couple of seconds. All this time my CPU is on around 160% (if I look Activity monitor). This happend in FF. Chrome is not useful because it takes too much time (I gave up after 10 minutes). Any idea how could we speed up hosted mode? Would code split with GWT.runAsync do any help? Or on the end you just must have very fast CPU? Thank you for help. My environment : - OS X Show Leopard - JDK 1.6 - GWT 2.2 - GXT 2.2.3 - Firefox 3.6 Regards, Matic -- GWT stuff twitter -http://twitter.com/#!/gwtstuff -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Can't compile gadget with GWT Plugin 2.2 or 2.3 Beta
Do you have a class that extend com.google.gwt.gadgets.client.GadgetT ? If that doesn't make sense to you, then check out the GettingStarted guide at http://code.google.com/p/gwt-google-apis On Tue, Apr 19, 2011 at 7:39 PM, dicko d...@mothdesign.com.au wrote: Thanks for your help so far but I'm still having issues. Now I'm getting this error when I attempt to compile: Compiling module com.google.gwt.gadgets.Gadgets [ERROR] Module has no entry points defined Any hints? On Apr 15, 11:25 pm, Eric Ayers zun...@google.com wrote: Yeah, I forgot, the GadgetLinker went bad with GWT 2.2 there is a patch I just put up for gadgets that builds against the latest GWT releases. http://gwt-code-reviews.appspot.com/1370808/ It doesn't handle stylesheet module directives correctly though. On Fri, Apr 15, 2011 at 2:34 AM, dicko d...@mothdesign.com.au wrote: Thanks for your help guys but I'm still having trouble. Do I just need to import the project and then re-compile it? If so, I'm getting this error: [ERROR] Unable to load class 'com.google.gwt.gadgets.linker.GadgetLinker' java.lang.ClassNotFoundException: com.google.gwt.gadgets.linker.GadgetLinker at java.net.URLClassLoader$1.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at com.google.gwt.dev.cfg.ModuleDefSchema $ClassAttrCvt.convertToArg(ModuleDefSchema.java:869) at com.google.gwt.dev.util.xml.HandlerArgs.convertToArg(HandlerArgs.java: 64) at com.google.gwt.dev.util.xml.HandlerMethod.invokeBegin(HandlerMethod.java: 221) at com.google.gwt.dev.util.xml.ReflectiveParser $Impl.startElement(ReflectiveParser.java:274) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(U nknown Source) at com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyE lement(Unknown Source) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scan StartElement(Unknown Source) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl $FragmentContentDriver.next(Unknown Source) at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(Unknown Source) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scan Document(Unknown Source) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(Unknown Source) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(Unknown Source) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(Unknown Source) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(Unknown Source) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl $JAXPSAXParser.parse(Unknown Source) at com.google.gwt.dev.util.xml.ReflectiveParser $Impl.parse(ReflectiveParser.java:331) at com.google.gwt.dev.util.xml.ReflectiveParser$Impl.access $100(ReflectiveParser.java:48) at com.google.gwt.dev.util.xml.ReflectiveParser.parse(ReflectiveParser.java: 402) at com.google.gwt.dev.cfg.ModuleDefLoader.nestedLoad(ModuleDefLoader.java: 280) at com.google.gwt.dev.cfg.ModuleDefLoader$1.load(ModuleDefLoader.java: 192) at com.google.gwt.dev.cfg.ModuleDefLoader.doLoadModule(ModuleDefLoader.java: 308) at com.google.gwt.dev.cfg.ModuleDefLoader.loadFromClassPath(ModuleDefLoader.ja va: 151) at com.google.gwt.dev.Compiler.run(Compiler.java:185) at com.google.gwt.dev.Compiler$1.run(Compiler.java:159) at com.google.gwt.dev.CompileTaskRunner.doRun(CompileTaskRunner.java: 87) at com.google.gwt.dev.CompileTaskRunner.runWithAppropriateLogger(CompileTaskRu nner.java: 81) at com.google.gwt.dev.Compiler.main(Compiler.java:166) [ERROR] Failure while parsing XML com.google.gwt.core.ext.UnableToCompleteException: (see previous log entries) at com.google.gwt.dev.cfg.ModuleDefSchema $ClassAttrCvt.convertToArg(ModuleDefSchema.java:872) at com.google.gwt.dev.util.xml.HandlerArgs.convertToArg(HandlerArgs.java: 64) at com.google.gwt.dev.util.xml.HandlerMethod.invokeBegin(HandlerMethod.java: 221) at com.google.gwt.dev.util.xml.ReflectiveParser $Impl.startElement(ReflectiveParser.java:274) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(U nknown Source) at com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyE lement(Unknown Source)
Re: Custom Server Validation in GWT 2.2
Is the GWT validation api released or not. I checked out the validation sample project from trunk and it complains about below missing files. com.google.gwt.validation.client.AbstractValidationMessageResolver; com.google.gwt.validation.client.UserValidationMessagesResolver; On Apr 19, 3:09 am, Andy andylamyinc...@gmail.com wrote: This is just an update on this question, I am able to do the server custom constraint successfully using GWT 2.2 After checking the source code, I think GWT handles the validation the same way as other framework, hence I just following the guide below to create the customer constraint http://docs.jboss.org/hibernate/validator/4.0.1/reference/en/html/ind... and it just work ;-) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: StackPanel
Hi Ani, If you can elaborate on what you're trying to achieve, the forum may be able to suggess you with better options. -- Happy Hacking, Gaurav Vaish http://www.incoleg.com On Apr 19, 5:33 pm, Issam boualem.is...@gmail.com wrote: Hi, Make the one item a VerticalPanel (or HorizontalPanel) and then put what ever you want in Vertical/Horizontal Panel.. On Apr 19, 1:44 pm, Ani anapont...@gmail.com wrote: Hello, I hope that someone can help me with this question. Is it possible to show more than 1 item on a stackpanel? I mean, i know that by definition it just show 1 at time, but i'd like to know if it's possible to do something like that Thank you very much for your help. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: How do I test task queue ?
I think my previous message was not proper. I am rephrasing my question again. I am adding task in the queue. The task is performing the work through worker URL. How do I setup the test environment so that the worker URL actually runs when the task is executed. Suresh. On Tue, Apr 19, 2011 at 8:09 PM, suersh babu sureshgbab...@gmail.comwrote: Hi, We are using gwt for our application. As we need task queue because of app engine time limit, so we are adding task in the queue by using rpc call, but I need to test this task whether that task got completed or not so how do I test. I also visited task queue test: http://code.google.com/appengine/docs/java/tools/localunittesting.html#Writing_Task_Queue_Tests but I couldn't find much about task testing. Any suggestion is much appreciated. -- Regards Suresh Babu G http://www.AccountingGuru.in http://www.accountingguru.in/ -- Regards Suresh Babu G http://www.AccountingGuru.in http://www.accountingguru.in/ -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
[gwt-contrib] Re: Remove JAnnotation from GWT AST. (issue1420803)
Some comments from the peanut gallery http://gwt-code-reviews.appspot.com/1420803/diff/2001/dev/core/super/com/google/gwt/core/client/impl/ArtificialRescue.java File dev/core/super/com/google/gwt/core/client/impl/ArtificialRescue.java (right): http://gwt-code-reviews.appspot.com/1420803/diff/2001/dev/core/super/com/google/gwt/core/client/impl/ArtificialRescue.java#newcode31 dev/core/super/com/google/gwt/core/client/impl/ArtificialRescue.java:31: */ On 2011/04/19 01:25:05, scottb wrote: This was always true, just not documented. Add ptr to ArtificialRescueChecker? http://gwt-code-reviews.appspot.com/1420803/diff/31/dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java File dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java (right): http://gwt-code-reviews.appspot.com/1420803/diff/31/dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java#newcode145 dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java:145: inconsistent newlines http://gwt-code-reviews.appspot.com/1420803/diff/31/dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java#newcode197 dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java:197: // Goal (2) not a very descriptive comment. http://gwt-code-reviews.appspot.com/1420803/diff/31/dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java#newcode240 dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java:240: JsniRef jsni = JsniRef.parse(@foo:: + method); This check doesn't have anything to do with JSNI does it? Its just checking the method signature using code we already have for JSNI? If so, comment this. http://gwt-code-reviews.appspot.com/1420803/diff/31/dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java File dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java (left): http://gwt-code-reviews.appspot.com/1420803/diff/31/dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java#oldcode30 dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java:30: * Represents a java annotation. It is surprising to me that the only use for JAnnotation nodes in the AST was for the internal annotations and that ArtificialRescue was the only one. I suppose this is because any other need for annotation data is already captured in TypeOracle. I'm wondering why isn't ArtificialRescue just some internal data structure we add to JType or JNode if it was all just internal bookkeeping. http://gwt-code-reviews.appspot.com/1420803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Suppresses multiple warnings related to validation .jar file and (issue1424804)
http://gwt-code-reviews.appspot.com/1424804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Suppresses multiple warnings related to validation .jar file and (issue1424804)
Before this patch, compiling this app would return many lines of output of the form: [java] Checking rule generate-with class='com.google.gwt.validation.rebind.GwtSpecificValidatorGenerator'/ [java][WARN] Unknown type 'com.google.gwt.validation.client.impl.GwtSpecificValidator' specified in deferred binding rule [java] Checking rule generate-with class='com.google.gwt.validation.rebind.ValidatorGenerator'/ [java][WARN] Unknown type 'javax.validation.Validator' specified in deferred binding rule [java] Rebinding com.google.gwt.i18n.client.BidiPolicy.BidiPolicyImpl [java] Checking rule generate-with class='com.google.gwt.editor.rebind.SimpleBeanEditorDriverGenerator'/ [java][WARN] Unknown type 'com.google.gwt.editor.client.SimpleBeanEditorDriver' specified in deferred binding rule With this patch, here is the updated output (using GWT SDK compiled from r10016 trunk) [java] Compiling module com.google.gwt.gadgets.sample.hellogadgets.HelloGadgets [java]Validating newly compiled units [java] Ignored 71 units with compilation errors in first pass. Specify -logLevel DEBUG to see all errors [java]Computing all possible rebind results for 'com.google.gwt.user.client.UserAgentAsserter' [java] Rebinding com.google.gwt.user.client.UserAgentAsserter [java] Checking rule generate-with class='com.google.gwt.editor.rebind.SimpleBeanEditorDriverGenerator'/ [java] [WARN] Detected warnings related to 'com.google.gwt.editor.client.SimpleBeanEditorDriver'. Is validation-api-version-sources.jar on the classpath? [java] Specify -logLevel DEBUG to see all errors. [java] [WARN] Unknown type 'com.google.gwt.editor.client.SimpleBeanEditorDriver' specified in deferred binding rule [java]Compiling 6 permutations [java] Compiling permutation 0... [java] Compiling permutation 1... [java] Compiling permutation 2... [java] Compiling permutation 3... [java] Compiling permutation 4... [java] Compiling permutation 5... [java]Compile of permutations succeeded http://gwt-code-reviews.appspot.com/1424804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Small generator testing framework (issue1424805)
LGTM2 http://gwt-code-reviews.appspot.com/1424805/diff/1/dev/core/src/com/google/gwt/dev/javac/testing/impl/MockResource.java File dev/core/src/com/google/gwt/dev/javac/testing/impl/MockResource.java (right): http://gwt-code-reviews.appspot.com/1424805/diff/1/dev/core/src/com/google/gwt/dev/javac/testing/impl/MockResource.java#newcode28 dev/core/src/com/google/gwt/dev/javac/testing/impl/MockResource.java:28: public abstract class MockResource extends Resource { Would you mind adding a bit of class documentation to at least some of the classes in this package that they are now an API referenced by 3rd party testing tools? I'd hate for a refactor to accidentally break this nifty new tool. http://gwt-code-reviews.appspot.com/1424805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove JAnnotation from GWT AST. (issue1420803)
LGTM. http://gwt-code-reviews.appspot.com/1420803/diff/31/dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java File dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java (left): http://gwt-code-reviews.appspot.com/1420803/diff/31/dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java#oldcode30 dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java:30: * Represents a java annotation. JAnnotation was written with the assumption that other annotation-controlled compiler passes would be added, such as @ShouldNotBeInWebMode or @MustInline. None of that work ever happened, so ArtificialRescue would up being the only user. http://gwt-code-reviews.appspot.com/1420803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10019 committed - Add daniel.r.b...@gmail.com to CLA-SIGNERS file.
Revision: 10019 Author: b...@google.com Date: Tue Apr 19 07:26:05 2011 Log: Add daniel.r.b...@gmail.com to CLA-SIGNERS file. http://code.google.com/p/google-web-toolkit/source/detail?r=10019 Modified: /CLA-SIGNERS === --- /CLA-SIGNERSThu Mar 31 15:17:46 2011 +++ /CLA-SIGNERSTue Apr 19 07:26:05 2011 @@ -5,6 +5,7 @@ alex.tkachman (Alexander Tkachman) bgu...@gmail.com (Bart Guijt) btay...@rackspace.com (Bryan Taylor) +daniel.r.b...@gmail.com (Daniel Ronald Bell) dannydaemo...@gmail.com (Daniel Valenzuela) david.no...@gmail.com (David Nouls) fredsa (Fred Sauer) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10020 committed - Suppresses multiple warnings related to validation .jar file and...
Revision: 10020 Author: zun...@google.com Date: Tue Apr 19 04:01:17 2011 Log: Suppresses multiple warnings related to validation .jar file and replaces them with a single warning to add the .jar file to the classpath. Review at http://gwt-code-reviews.appspot.com/1424804 http://code.google.com/p/google-web-toolkit/source/detail?r=10020 Modified: /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java === --- /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java Tue Apr 5 03:08:39 2011 +++ /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java Tue Apr 19 04:01:17 2011 @@ -27,6 +27,8 @@ */ public class ConditionWhenTypeAssignableTo extends Condition { + private static boolean warnedMissingValidationJar = false; + private final String assignableToTypeName; public ConditionWhenTypeAssignableTo(String assignableToTypeName) { @@ -60,7 +62,12 @@ // This isn't a strict failure case because stale rules can reference // types that have been deleted. // - logger.log(TreeLogger.WARN, Unknown type ' + assignableToTypeName + TreeLogger.Type level = TreeLogger.WARN; + if (shouldSuppressWarning(logger, assignableToTypeName)) { +// Suppress validation related errors +level = TreeLogger.DEBUG; + } + logger.log(level, Unknown type ' + assignableToTypeName + ' specified in deferred binding rule, null); return false; } @@ -86,4 +93,27 @@ return toString(); } -} + /** + * Suppress multiple validation related messages and replace with a hint. + * + * @param typeName fully qualified type name to check for filtering + */ + // TODO(zundel): Can be removed when javax.validation is included in the JRE + private boolean shouldSuppressWarning(TreeLogger logger, String typeName) { +if (typeName.startsWith(javax.validation.) +|| typeName.startsWith(com.google.gwt.validation.) +|| typeName.startsWith(com.google.gwt.editor.client)) { + if (!warnedMissingValidationJar) { +warnedMissingValidationJar = true; +logger.log(TreeLogger.WARN, Detected warnings related to ' + typeName + '. ++ Is validation-api-version-sources.jar on the classpath?); +logger.log(TreeLogger.INFO, Specify -logLevel DEBUG to see all errors.); +// Show the first error that matches +return false; + } + // Suppress subsequent errors that match + return true; +} +return false; + } +} -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10021 committed - Allow ServiceLocator instantiation to be controlled via RequestFactory...
Revision: 10021 Author: gwt.mirror...@gmail.com Date: Tue Apr 19 07:59:33 2011 Log: Allow ServiceLocator instantiation to be controlled via RequestFactory ServiceLocator. http://gwt-code-reviews.appspot.com/1427801/ http://code.google.com/p/google-web-toolkit/issues/detail?id=6264 Patch by: daniel.r.bell Review by: bobv, t.broyer http://code.google.com/p/google-web-toolkit/source/detail?r=10021 Added: /trunk/user/test/com/google/web/bindery/requestfactory/server/ServiceLocatorTest.java Modified: /trunk/user/src/com/google/web/bindery/requestfactory/server/LocatorServiceLayer.java /trunk/user/src/com/google/web/bindery/requestfactory/server/ServiceLayer.java /trunk/user/src/com/google/web/bindery/requestfactory/server/ServiceLayerDecorator.java /trunk/user/test/com/google/web/bindery/requestfactory/vm/RequestFactoryJreSuite.java === --- /dev/null +++ /trunk/user/test/com/google/web/bindery/requestfactory/server/ServiceLocatorTest.java Tue Apr 19 07:59:33 2011 @@ -0,0 +1,55 @@ +/* + * Copyright 2011 Google Inc. + * + * Licensed under the Apache License, Version 2.0 (the License); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package com.google.web.bindery.requestfactory.server; + +import com.google.web.bindery.requestfactory.shared.ServiceLocator; + +import junit.framework.TestCase; + +/** + * Tests creating of ServiceLocators with custom ServiceLayerDecorators + */ +public class ServiceLocatorTest extends TestCase { + + static class CustomLocatorLayer extends ServiceLayerDecorator { +@Override +@SuppressWarnings(unchecked) +public T extends ServiceLocator T createServiceLocator(ClassT clazz) { + return (T) ServiceLocatorImpl.INSTANCE; +} + } + + static class ServiceLocatorImpl implements ServiceLocator { +static final ServiceLocatorImpl INSTANCE = new ServiceLocatorImpl(); + +public Object getInstance(Class? clazz) { + return new Object(); +} + } + + public void testGetsServiceLocatorFromDecorator() { +ServiceLayer layer = ServiceLayer.create(new CustomLocatorLayer()); +ServiceLocatorImpl locator = layer.createServiceLocator(ServiceLocatorImpl.class); +assertSame(ServiceLocatorImpl.INSTANCE, locator); + } + + public void testInstantiatesServiceLocatorByDefault() { +ServiceLayer layer = ServiceLayer.create(); +ServiceLocatorImpl locator = layer.createServiceLocator(ServiceLocatorImpl.class); +assertNotNull(locator); +assertNotSame(ServiceLocatorImpl.INSTANCE, locator); + } +} === --- /trunk/user/src/com/google/web/bindery/requestfactory/server/LocatorServiceLayer.java Tue Apr 5 10:47:39 2011 +++ /trunk/user/src/com/google/web/bindery/requestfactory/server/LocatorServiceLayer.java Tue Apr 19 07:59:33 2011 @@ -50,15 +50,21 @@ @Override public Object createServiceInstance(Method contextMethod, Method domainMethod) { -Class? extends ServiceLocator locatorType = -getTop().resolveServiceLocator(contextMethod, domainMethod); -ServiceLocator locator = newInstance(locatorType, ServiceLocator.class); +Class? extends ServiceLocator locatorType = getTop().resolveServiceLocator( +contextMethod, domainMethod); +ServiceLocator locator = getTop().createServiceLocator(locatorType); // Enclosing class may be a parent class, so invoke on service class Class? declaringClass = contextMethod.getDeclaringClass(); -Class? serviceClass = - getTop().resolveServiceClass(declaringClass.asSubclass(RequestContext.class)); +Class? serviceClass = getTop().resolveServiceClass( +declaringClass.asSubclass(RequestContext.class)); return locator.getInstance(serviceClass); } + + @Override + public T extends ServiceLocator T createServiceLocator( + ClassT serviceLocatorType) { +return newInstance(serviceLocatorType, ServiceLocator.class); + } @Override public Object getId(Object domainObject) { @@ -94,7 +100,8 @@ * method is non-static. */ @Override - public boolean requiresServiceLocator(Method contextMethod, Method domainMethod) { + public boolean requiresServiceLocator(Method contextMethod, + Method domainMethod) { return Request.class.isAssignableFrom(contextMethod.getReturnType()) !Modifier.isStatic(domainMethod.getModifiers()); } @@ -102,7 +109,8 @@ @Override public Class? extends Locator?, ? resolveLocator(Class? domainType) {
[gwt-contrib] Re: Suppresses multiple warnings related to validation .jar file and (issue1424804)
Submitted as r10020 http://gwt-code-reviews.appspot.com/1424804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Suppresses multiple warnings related to validation .jar file and (issue1424804)
good question. I know that the -sources.jar file is needed to just make the errors go away for legacy projects that don't reference any classes that use javax.validation, but I haven't seen the messages for a sample that actually needs validation. On Tue, Apr 19, 2011 at 11:13 AM, rchan...@google.com wrote: I think gwtc also needs validation-api-version.jar (no '-sources') in the classpath. Will this make users think only the sources jar is needed? On 2011/04/19 12:08:00, zundel wrote: Before this patch, compiling this app would return many lines of output of the form: [java] Checking rule generate-with class='com.google.gwt.validation.rebind.GwtSpecificValidatorGenerator'/ [java] [WARN] Unknown type 'com.google.gwt.validation.client.impl.GwtSpecificValidator' specified in deferred binding rule [java] Checking rule generate-with class='com.google.gwt.validation.rebind.ValidatorGenerator'/ [java] [WARN] Unknown type 'javax.validation.Validator' specified in deferred binding rule [java] Rebinding com.google.gwt.i18n.client.BidiPolicy.BidiPolicyImpl [java] Checking rule generate-with class='com.google.gwt.editor.rebind.SimpleBeanEditorDriverGenerator'/ [java] [WARN] Unknown type 'com.google.gwt.editor.client.SimpleBeanEditorDriver' specified in deferred binding rule With this patch, here is the updated output (using GWT SDK compiled from r10016 trunk) [java] Compiling module com.google.gwt.gadgets.sample.hellogadgets.HelloGadgets [java] Validating newly compiled units [java] Ignored 71 units with compilation errors in first pass. Specify -logLevel DEBUG to see all errors [java] Computing all possible rebind results for 'com.google.gwt.user.client.UserAgentAsserter' [java] Rebinding com.google.gwt.user.client.UserAgentAsserter [java] Checking rule generate-with class='com.google.gwt.editor.rebind.SimpleBeanEditorDriverGenerator'/ [java] [WARN] Detected warnings related to 'com.google.gwt.editor.client.SimpleBeanEditorDriver'. Is validation-api-version-sources.jar on the classpath? [java] Specify -logLevel DEBUG to see all errors. [java] [WARN] Unknown type 'com.google.gwt.editor.client.SimpleBeanEditorDriver' specified in deferred binding rule [java] Compiling 6 permutations [java] Compiling permutation 0... [java] Compiling permutation 1... [java] Compiling permutation 2... [java] Compiling permutation 3... [java] Compiling permutation 4... [java] Compiling permutation 5... [java] Compile of permutations succeeded http://gwt-code-reviews.appspot.com/1424804/ -- Eric Z. Ayers Google Web Toolkit, Atlanta, GA USA -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Make EventBus backward compatible. (issue1423803)
Reviewers: bobv, Description: Make EventBus backward compatible. Please review this at http://gwt-code-reviews.appspot.com/1423803/ Affected files: M user/src/com/google/gwt/event/shared/EventBus.java M user/src/com/google/gwt/event/shared/ResettableEventBus.java M user/src/com/google/gwt/event/shared/SimpleEventBus.java M user/src/com/google/gwt/event/shared/testing/CountingEventBus.java Index: user/src/com/google/gwt/event/shared/EventBus.java === --- user/src/com/google/gwt/event/shared/EventBus.java (revision 10018) +++ user/src/com/google/gwt/event/shared/EventBus.java (working copy) @@ -21,8 +21,9 @@ * Extends {com.google.web.bindery.event.shared.EventBus} for legacy * compatibility. */ -public abstract class EventBus extends com.google.web.bindery.event.shared.EventBus implements HasHandlers { - +public abstract class EventBus extends com.google.web.bindery.event.shared.EventBus implements +HasHandlers { + public H extends EventHandler HandlerRegistration addHandler(GwtEvent.TypeH type, H handler) { return wrap(addHandler((Event.TypeH) type, handler)); } @@ -31,8 +32,24 @@ Object source, H handler) { return wrap(addHandlerToSource((Event.TypeH) type, source, handler)); } - - public void fireEvent(GwtEvent? event) { + + public void fireEvent(Event? event) { +throw new UnsupportedOperationException( +This class is a legacy wrapper for com.google.web.bindery.event.shared.Event. ++ Use that directly, or try com.google.web.bindery.event.shared.SimpleEventBus); + } + + abstract public void fireEvent(GwtEvent? event); + + public void fireEventFromSource(Event? event, Object source) { +throw new UnsupportedOperationException( +This class is a legacy wrapper for com.google.web.bindery.event.shared.Event. ++ Use that directly, or try com.google.web.bindery.event.shared.SimpleEventBus); + } + + abstract public void fireEventFromSource(GwtEvent? event, Object source); + + protected void castFireEvent(GwtEvent? event) { try { fireEvent((Event?) event); } catch (com.google.web.bindery.event.shared.UmbrellaException e) { @@ -40,7 +57,7 @@ } } - public void fireEventFromSource(GwtEvent? event, Object source) { + protected void castFireEventFromSource(GwtEvent? event, Object source) { try { fireEventFromSource((Event?) event, source); } catch (com.google.web.bindery.event.shared.UmbrellaException e) { Index: user/src/com/google/gwt/event/shared/ResettableEventBus.java === --- user/src/com/google/gwt/event/shared/ResettableEventBus.java (revision 10018) +++ user/src/com/google/gwt/event/shared/ResettableEventBus.java (working copy) @@ -60,8 +60,18 @@ } @Override + public void fireEvent(GwtEvent? event) { +castFireEvent(event); + } + + @Override public void fireEventFromSource(Event? event, Object source) { real.fireEventFromSource(event, source); + } + + @Override + public void fireEventFromSource(GwtEvent? event, Object source) { +castFireEventFromSource(event, source); } public void removeHandlers() { Index: user/src/com/google/gwt/event/shared/SimpleEventBus.java === --- user/src/com/google/gwt/event/shared/SimpleEventBus.java (revision 10018) +++ user/src/com/google/gwt/event/shared/SimpleEventBus.java(working copy) @@ -43,7 +43,17 @@ } @Override + public void fireEvent(GwtEvent? event) { +castFireEvent(event); + } + + @Override public void fireEventFromSource(Event? event, Object source) { real.fireEventFromSource(event, source); } + + @Override + public void fireEventFromSource(GwtEvent? event, Object source) { +castFireEventFromSource(event, source); + } } Index: user/src/com/google/gwt/event/shared/testing/CountingEventBus.java === --- user/src/com/google/gwt/event/shared/testing/CountingEventBus.java (revision 10018) +++ user/src/com/google/gwt/event/shared/testing/CountingEventBus.java (working copy) @@ -51,8 +51,18 @@ } @Override + public void fireEvent(GwtEvent? event) { +castFireEvent(event); + } + + @Override public void fireEventFromSource(Event? event, Object source) { real.fireEventFromSource(event, source); + } + + @Override + public void fireEventFromSource(GwtEvent? event, Object source) { +castFireEventFromSource(event, source); } public int getCount(GwtEvent.Type? type) { -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Suppresses multiple warnings related to validation .jar file and (issue1424804)
On Tue, Apr 19, 2011 at 11:19 AM, Eric Ayers zun...@google.com wrote: good question. I know that the -sources.jar file is needed to just make the errors go away for legacy projects that don't reference any classes that use javax.validation, but I haven't seen the messages for a sample that actually needs validation. I think you are right. I was testing with the sample app webAppCreator (and GPE) generates for new projects, which uses javax.validation on the client. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make EventBus backward compatible. (issue1423803)
http://gwt-code-reviews.appspot.com/1423803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make EventBus backward compatible. (issue1423803)
http://gwt-code-reviews.appspot.com/1423803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Adds method to customise ServiceLocator instantiation in ServiceLayerDecorator (issue1427801)
Reviewers: , Description: Issue 6264: We require a way to override default instantiation of ServiceLocators in a similar fashion to Locators in ServiceLayerDecorator, to provide ServiceLocators with Guice. Please review this at http://gwt-code-reviews.appspot.com/1427801/ Affected files: user/src/com/google/web/bindery/requestfactory/server/LocatorServiceLayer.java user/src/com/google/web/bindery/requestfactory/server/ServiceLayer.java user/src/com/google/web/bindery/requestfactory/server/ServiceLayerDecorator.java Index: user/src/com/google/web/bindery/requestfactory/server/ServiceLayerDecorator.java === --- user/src/com/google/web/bindery/requestfactory/server/ServiceLayerDecorator.java (revision 10013) +++ user/src/com/google/web/bindery/requestfactory/server/ServiceLayerDecorator.java (working copy) @@ -61,6 +61,11 @@ } @Override + public T extends ServiceLocator T createServiceLocator(ClassT clazz) { +return getNext().createServiceLocator(clazz); + } + + @Override public ClassLoader getDomainClassLoader() { return getNext().getDomainClassLoader(); } Index: user/src/com/google/web/bindery/requestfactory/server/LocatorServiceLayer.java === --- user/src/com/google/web/bindery/requestfactory/server/LocatorServiceLayer.java (revision 10013) +++ user/src/com/google/web/bindery/requestfactory/server/LocatorServiceLayer.java (working copy) @@ -52,7 +52,7 @@ public Object createServiceInstance(Method contextMethod, Method domainMethod) { Class? extends ServiceLocator locatorType = getTop().resolveServiceLocator(contextMethod, domainMethod); -ServiceLocator locator = newInstance(locatorType, ServiceLocator.class); +ServiceLocator locator = createServiceLocator(locatorType); // Enclosing class may be a parent class, so invoke on service class Class? declaringClass = contextMethod.getDeclaringClass(); Class? serviceClass = @@ -61,6 +61,11 @@ } @Override + public T extends ServiceLocator T createServiceLocator(ClassT serviceLocatorType) { +return newInstance(serviceLocatorType, ServiceLocator.class); + } + + @Override public Object getId(Object domainObject) { return doGetId(domainObject); } Index: user/src/com/google/web/bindery/requestfactory/server/ServiceLayer.java === --- user/src/com/google/web/bindery/requestfactory/server/ServiceLayer.java (revision 10013) +++ user/src/com/google/web/bindery/requestfactory/server/ServiceLayer.java (working copy) @@ -128,6 +128,15 @@ public abstract Object createServiceInstance(Method contextMethod, Method domainMethod); /** + * Create an instance of the requested {@link ServiceLocator} type. + * + * @param T the requested ServiceLocator type + * @param clazz the requested ServiceLocator type + * @return an instance of the requested ServiceLocator type + */ + public abstract T extends ServiceLocator T createServiceLocator(ClassT clazz); + + /** * Returns the ClassLoader that should be used when attempting to access * domain classes or resources. * p -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Future of CellTable
Just wanted to see if there have been any updates regarding the CellTable and the use of fixed headers + scrollable content areas. I have been keeping an eye on the commit logs and havent seen anything related to scrolling. Is this a feature that is still planned for 2.3? Thanks, Adam On Feb 18, 2:47 pm, Ray Ryan rj...@google.com wrote: Do you mean patches for CellTable? It's part of GWT, so the usual way: http://code.google.com/webtoolkit/makinggwtbetter.html On Fri, Feb 18, 2011 at 3:30 AM, dflorey daniel.flo...@gmail.com wrote: Thanks for the info! I guess I'll wait until 2.3 and will start to port the TreeTable + filter stuff. Is there a way to contribute patches since the incubator is deprecated? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Small generator testing framework (issue1424805)
Yeah, they're in an impl package. On Tue, Apr 19, 2011 at 11:12 AM, schm...@google.com wrote: I think the idea here is that no one (outside the existing GWT tests) should reference the *Resource classes directly - that's why we have the new interface Source. This way, you should be able to refactor the *Resource classes without breaking anyone, especially the original Resource interface. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)
http://gwt-code-reviews.appspot.com/1424803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make EventBus backward compatible. (issue1423803)
http://gwt-code-reviews.appspot.com/1423803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)
http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java File dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java (right): http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode45 dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:45: * Collapses derived properties. On 2011/04/18 22:35:35, bobv wrote: Expand this comment to roughly describe the process implemented for future maintainers. Done. http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode52 dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:52: // find collapsed properties On 2011/04/18 22:35:35, bobv wrote: For each input property, determine if it has a collapsed-value equivalence set containing the associated input value. Done. http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode68 dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:68: MapString, ArrayListString dependencies = new TreeMapString, ArrayListString(); On 2011/04/18 22:35:35, bobv wrote: Make this a MapBindingProperty, ListString. Add doc: A map of binding properties to the names of the properties that must be evaluated prior to computing the value of the key object. Done. http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode72 dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:72: if (deps.size() 0) { On 2011/04/18 22:35:35, bobv wrote: !deps.isEmpty() Done. http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode76 dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:76: for (Map.EntryString, ArrayListString e : dependencies.entrySet()) { On 2011/04/18 22:35:35, bobv wrote: What is this loop doing? Done. http://gwt-code-reviews.appspot.com/1424803/diff/1/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc File user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc (right): http://gwt-code-reviews.appspot.com/1424803/diff/1/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc#newcode26 user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc:26: permutations into a single compiled unit. As a consequence, collapsed units On 2011/04/18 22:35:35, bobv wrote: into a single output file Done. http://gwt-code-reviews.appspot.com/1424803/diff/1/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc#newcode39 user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc:39: By default, GWT will collapse permutations of older and less used browsers. On 2011/04/18 22:35:35, bobv wrote: s/GWT/this template/ ? http://gwt-code-reviews.appspot.com/1424803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make EventBus backward compatible. (issue1423803)
http://gwt-code-reviews.appspot.com/1423803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make EventBus backward compatible. (issue1423803)
http://gwt-code-reviews.appspot.com/1423803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Future of CellTable
I'm working on it this week. It won't be included in 2.3, but should be committed to trunk next week. Thanks, John LaBanca jlaba...@google.com On Mon, Apr 18, 2011 at 2:14 PM, Adam Bender adamben...@gmail.com wrote: Just wanted to see if there have been any updates regarding the CellTable and the use of fixed headers + scrollable content areas. I have been keeping an eye on the commit logs and havent seen anything related to scrolling. Is this a feature that is still planned for 2.3? Thanks, Adam On Feb 18, 2:47 pm, Ray Ryan rj...@google.com wrote: Do you mean patches for CellTable? It's part of GWT, so the usual way: http://code.google.com/webtoolkit/makinggwtbetter.html On Fri, Feb 18, 2011 at 3:30 AM, dflorey daniel.flo...@gmail.com wrote: Thanks for the info! I guess I'll wait until 2.3 and will start to port the TreeTable + filter stuff. Is there a way to contribute patches since the incubator is deprecated? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Wrap low-priorty log calls with an 'if' test to avoid unnecessary calls (issue1426802)
Reviewers: jat, Description: Wrap low-priorty log calls with an 'if' test to avoid unnecessary calls Use constants from TreeLogger rather than accessing TreeLogger.Type directly where possible Please review this at http://gwt-code-reviews.appspot.com/1426802/ Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java M dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java M dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java M dev/core/src/com/google/gwt/dev/AnalyzeModule.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompilePermsServer.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/ExternalPermutationWorkerFactory.java M dev/core/src/com/google/gwt/dev/GWTCompiler.java M dev/core/src/com/google/gwt/dev/Link.java M dev/core/src/com/google/gwt/dev/PermutationWorkerFactory.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/PrecompileOnePerm.java M dev/core/src/com/google/gwt/dev/ServletValidator.java M dev/core/src/com/google/gwt/dev/SwingUI.java M dev/core/src/com/google/gwt/dev/cfg/ConditionWhenPropertyIs.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java M dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java M dev/core/src/com/google/gwt/dev/javac/Dependencies.java M dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java M dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java M dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java M dev/core/src/com/google/gwt/dev/jdt/BasicWebModeCompiler.java M dev/core/src/com/google/gwt/dev/jjs/EnumNameObfuscator.java M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java M dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java M dev/core/src/com/google/gwt/dev/resource/impl/ResourceOracleImpl.java M dev/core/src/com/google/gwt/dev/shell/BrowserChannelClient.java M dev/core/src/com/google/gwt/dev/shell/BrowserListener.java M dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java M dev/core/src/com/google/gwt/dev/shell/GWTShellServlet.java M dev/core/src/com/google/gwt/dev/shell/HtmlUnitSessionHandler.java M dev/core/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java M dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java M dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java M dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java M dev/core/src/com/google/gwt/dev/shell/log/SwingTreeLogger.java M dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java M dev/core/src/com/google/gwt/dev/shell/tomcat/EmbeddedTomcatServer.java M dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerLogLevel.java M user/src/com/google/gwt/i18n/rebind/AbstractLocalizableImplCreator.java M user/src/com/google/gwt/i18n/rebind/ResourceFactory.java M user/src/com/google/gwt/resources/css/ClassRenamer.java M user/src/com/google/gwt/resources/css/GenerateCssAst.java M user/src/com/google/gwt/resources/css/InterfaceGenerator.java M user/src/com/google/gwt/resources/ext/ResourceGeneratorUtil.java M user/src/com/google/gwt/resources/rebind/context/StaticResourceContext.java M user/src/com/google/gwt/resources/rg/CssResourceGenerator.java M user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java M user/src/com/google/gwt/uibinder/rebind/FieldManager.java M user/src/com/google/gwt/uibinder/rebind/W3cDocumentBuilder.java M user/src/com/google/gwt/user/rebind/AbstractGeneratorClassCreator.java M user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java M user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java M user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java M user/src/com/google/gwt/util/regexfilter/RegexFilter.java M user/src/com/google/gwt/validation/rebind/BeanHelper.java M user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java M user/test/org/hibernate/jsr303/tck/tests/constraints/constraintcomposition/ConstraintCompositionCompileTest.java M user/test/org/hibernate/jsr303/tck/tests/constraints/customconstraint/CustomConstraintValidatorCompileTest.java M user/test/org/hibernate/jsr303/tck/tests/constraints/validatorresolution/ValidatorResolutionCompileTest.java M user/test/org/hibernate/jsr303/tck/tests/validation/ValidateCompileTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make EventBus backward compatible. (issue1423803)
LGTM http://gwt-code-reviews.appspot.com/1423803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10022 committed - Add @SkipInterfaceValidation to RequestFactory to selectively bypass m...
Revision: 10022 Author: t.bro...@gmail.com Date: Tue Apr 19 06:04:28 2011 Log: Add @SkipInterfaceValidation to RequestFactory to selectively bypass matching interface methods to domain methods. http://gwt-code-reviews.appspot.com/1338807 Patch by: t.broyer Review by: bobv http://code.google.com/p/google-web-toolkit/source/detail?r=10022 Added: /trunk/user/src/com/google/web/bindery/requestfactory/shared/SkipInterfaceValidation.java Modified: /trunk/user/src/com/google/web/bindery/requestfactory/gwt/rebind/model/EntityProxyModel.java /trunk/user/src/com/google/web/bindery/requestfactory/server/RequestFactoryInterfaceValidator.java /trunk/user/test/com/google/web/bindery/requestfactory/server/RequestFactoryInterfaceValidatorTest.java === --- /dev/null +++ /trunk/user/src/com/google/web/bindery/requestfactory/shared/SkipInterfaceValidation.java Tue Apr 19 06:04:28 2011 @@ -0,0 +1,35 @@ +/* + * Copyright 2011 Google Inc. + * + * Licensed under the Apache License, Version 2.0 (the License); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package com.google.web.bindery.requestfactory.shared; + +import java.lang.annotation.Documented; +import java.lang.annotation.ElementType; +import java.lang.annotation.Retention; +import java.lang.annotation.RetentionPolicy; +import java.lang.annotation.Target; + +/** + * Annotation on methods of {@link RequestContext}, {@link EntityProxy}, or + * {@link ValueProxy} interfaces so that the + * {@link com.google.web.bindery.requestfactory.server.RequestFactoryInterfaceValidator + * RequestFactoryInterfaceValidator} doesn't enforce the presence of a + * corresponding method on the domain type. + */ +@Documented +@Retention(RetentionPolicy.RUNTIME) +@Target(ElementType.METHOD) +public @interface SkipInterfaceValidation { +} === --- /trunk/user/src/com/google/web/bindery/requestfactory/gwt/rebind/model/EntityProxyModel.java Tue Apr 5 10:47:39 2011 +++ /trunk/user/src/com/google/web/bindery/requestfactory/gwt/rebind/model/EntityProxyModel.java Tue Apr 19 06:04:28 2011 @@ -43,10 +43,6 @@ public EntityProxyModel peek() { return toReturn; } - -public void setProxyFor(Class? value) { - toReturn.proxyFor = value; -} public void setQualifiedBinaryName(String qualifiedBinaryName) { toReturn.qualifiedBinaryName = qualifiedBinaryName; @@ -74,7 +70,6 @@ ENTITY, VALUE } - private Class? proxyFor; private String qualifiedBinaryName; private String qualifiedSourceName; private ListRequestMethod requestMethods; @@ -91,10 +86,6 @@ } visitor.endVisit(this); } - - public Class? getProxyFor() { -return proxyFor; - } public String getQualifiedBinaryName() { return qualifiedBinaryName; === --- /trunk/user/src/com/google/web/bindery/requestfactory/server/RequestFactoryInterfaceValidator.java Mon Apr 18 02:42:06 2011 +++ /trunk/user/src/com/google/web/bindery/requestfactory/server/RequestFactoryInterfaceValidator.java Tue Apr 19 06:04:28 2011 @@ -39,6 +39,7 @@ import com.google.web.bindery.requestfactory.shared.RequestFactory; import com.google.web.bindery.requestfactory.shared.Service; import com.google.web.bindery.requestfactory.shared.ServiceName; +import com.google.web.bindery.requestfactory.shared.SkipInterfaceValidation; import com.google.web.bindery.requestfactory.shared.ValueProxy; import java.io.IOException; @@ -416,17 +417,27 @@ if (clinit.equals(name) || init.equals(name)) { return null; } - RFMethod method = new RFMethod(name, desc); + final RFMethod method = new RFMethod(name, desc); method.setDeclaredStatic((access Opcodes.ACC_STATIC) != 0); method.setDeclaredSignature(signature); methods.add(method); - return null; + + return new EmptyVisitor() { +@Override +public AnnotationVisitor visitAnnotation(String desc, boolean visible) { + if (desc.equals(Type.getDescriptor(SkipInterfaceValidation.class))) { +method.setValidationSkipped(true); + } + return null; +} + }; } } private static class RFMethod extends Method { private boolean isDeclaredStatic; private String signature; +private boolean isValidationSkipped; public RFMethod(String name, String desc) { super(name, desc); @@ -439,6 +450,10 @@ public
[gwt-contrib] Re: Introduces SkipInterfaceValidation annotation. (issue1338807)
Committed with minor modifications at r10022. http://gwt-code-reviews.appspot.com/1338807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Supress errors when the binary validation.jar file is missing from the (issue1422804)
Reviewers: jbrosenberg, tobyr, rchandia, Description: Supress errors when the binary validation.jar file is missing from the class path (previous patch only address source jar) Please review this at http://gwt-code-reviews.appspot.com/1422804/ Affected files: M dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java M dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java Index: dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java === --- dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java (revision 10021) +++ dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java (working copy) @@ -106,7 +106,7 @@ if (!warnedMissingValidationJar) { warnedMissingValidationJar = true; logger.log(TreeLogger.WARN, Detected warnings related to ' + typeName + '. -+ Is validation-api-version-sources.jar on the classpath?); ++ Are validation-api-version.jar and validation-api-version-sources.jar on the classpath?); logger.log(TreeLogger.INFO, Specify -logLevel DEBUG to see all errors.); // Show the first error that matches return false; Index: dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java === --- dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (revision 10021) +++ dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (working copy) @@ -25,15 +25,15 @@ import com.google.gwt.dev.asm.signature.SignatureReader; import com.google.gwt.dev.asm.util.TraceClassVisitor; import com.google.gwt.dev.javac.asm.CollectAnnotationData; +import com.google.gwt.dev.javac.asm.CollectAnnotationData.AnnotationData; import com.google.gwt.dev.javac.asm.CollectClassData; +import com.google.gwt.dev.javac.asm.CollectClassData.AnnotationEnum; import com.google.gwt.dev.javac.asm.CollectFieldData; import com.google.gwt.dev.javac.asm.CollectMethodData; import com.google.gwt.dev.javac.asm.CollectTypeParams; import com.google.gwt.dev.javac.asm.ResolveClassSignature; import com.google.gwt.dev.javac.asm.ResolveMethodSignature; import com.google.gwt.dev.javac.asm.ResolveTypeSignature; -import com.google.gwt.dev.javac.asm.CollectAnnotationData.AnnotationData; -import com.google.gwt.dev.javac.asm.CollectClassData.AnnotationEnum; import com.google.gwt.dev.javac.typemodel.JAbstractMethod; import com.google.gwt.dev.javac.typemodel.JArrayType; import com.google.gwt.dev.javac.typemodel.JClassType; @@ -238,6 +238,11 @@ * Turn on to trace class processing. */ private static final boolean TRACE_CLASSES = false; + + /** + * Suppress some warnings related to missing valiation.jar on classpath. + */ + private static boolean warnedMissingValidationJar = false; private static JTypeParameter[] collectTypeParams(String signature) { if (signature != null) { @@ -541,22 +546,27 @@ private Class? extends Annotation getAnnotationClass(TreeLogger logger, AnnotationData annotData) { Type type = Type.getType(annotData.getDesc()); +String typeName = type.getClassName(); try { - Class? clazz = Class.forName(type.getClassName(), false, + Class? clazz = Class.forName(typeName, false, Thread.currentThread().getContextClassLoader()); if (!Annotation.class.isAssignableFrom(clazz)) { -logger.log(TreeLogger.ERROR, Type + type.getClassName() +logger.log(TreeLogger.ERROR, Type + typeName + is not an annotation); return null; } return clazz.asSubclass(Annotation.class); } catch (ClassNotFoundException e) { - logger.log(TreeLogger.WARN, Ignoring unresolvable annotation type - + type.getClassName()); + TreeLogger.Type level = TreeLogger.WARN; + if (shouldSuppressUnresolvableAnnotation(logger, typeName)) { +level = TreeLogger.DEBUG; + } + logger.log(level, Ignoring unresolvable annotation type + + typeName); return null; } } - + @SuppressWarnings(unused) private Class? getClassLiteralForPrimitive(Type type) { switch (type.getSort()) { @@ -583,7 +593,7 @@ return null; } } - + /** * Map a bitset onto a different bitset. * @@ -1164,4 +1174,27 @@ return null; } } + + /** + * Suppress multiple validation related messages and replace with a hint. + * + * @param typeName fully qualified type name to check for filtering + */ + // TODO(zundel): Can be removed when javax.validation is included in the JRE + private boolean shouldSuppressUnresolvableAnnotation(TreeLogger logger, String typeName) { +if (typeName.startsWith(javax.validation.) +|| typeName.startsWith(com.google.gwt.validation.)) { + if (!warnedMissingValidationJar) { +warnedMissingValidationJar
[gwt-contrib] Re: Supress errors when the binary validation.jar file is missing from the (issue1422804)
If you just add the validation-api-version-sources.jar, you'll get more errors. You need validation-api-version.jar too [java] Compiling module com.google.gwt.gadgets.sample.hellogadgets.HelloGadgets [java]Resolving com.google.gwt.validation.client.constraints.AbstractDecimalMaxValidator [java] Found type 'com.google.gwt.validation.client.constraints.AbstractDecimalMaxValidator' [java] Found type 'javax.validation.constraints.DecimalMax' [java] [WARN] Ignoring unresolvable annotation type javax.validation.Constraint [java]Resolving com.google.gwt.validation.client.constraints.AbstractDecimalMinValidator [java] Found type 'com.google.gwt.validation.client.constraints.AbstractDecimalMinValidator' [java] Found type 'javax.validation.constraints.DecimalMin' [java] [WARN] Ignoring unresolvable annotation type javax.validation.Constraint [java]Resolving com.google.gwt.validation.client.constraints.AbstractDigitsValidator [java] Found type 'com.google.gwt.validation.client.constraints.AbstractDigitsValidator' [java] Found type 'javax.validation.constraints.Digits' [java] [WARN] Ignoring unresolvable annotation type javax.validation.Constraint [java]Resolving com.google.gwt.validation.client.constraints.AbstractMaxValidator [java] Found type 'com.google.gwt.validation.client.constraints.AbstractMaxValidator' [java] Found type 'javax.validation.constraints.Max' [java] [WARN] Ignoring unresolvable annotation type javax.validation.Constraint [java]Resolving com.google.gwt.validation.client.constraints.AbstractMinValidator [java] Found type 'com.google.gwt.validation.client.constraints.AbstractMinValidator' [java] Found type 'javax.validation.constraints.Min' [java] [WARN] Ignoring unresolvable annotation type javax.validation.Constraint [java]Resolving com.google.gwt.validation.client.constraints.AbstractSizeValidator [java] Found type 'com.google.gwt.validation.client.constraints.AbstractSizeValidator' [java] Found type 'javax.validation.constraints.Size' [java] [WARN] Ignoring unresolvable annotation type javax.validation.Constraint [java]Resolving com.google.gwt.validation.client.constraints.AssertFalseValidator [java] Found type 'com.google.gwt.validation.client.constraints.AssertFalseValidator' [java] Found type 'javax.validation.constraints.AssertFalse' [java] [WARN] Ignoring unresolvable annotation type javax.validation.Constraint [java]Resolving com.google.gwt.validation.client.constraints.AssertTrueValidator [java] Found type 'com.google.gwt.validation.client.constraints.AssertTrueValidator' [java] Found type 'javax.validation.constraints.AssertTrue' [java] [WARN] Ignoring unresolvable annotation type javax.validation.Constraint [java]Resolving com.google.gwt.validation.client.constraints.FutureValidatorForDate [java] Found type 'com.google.gwt.validation.client.constraints.FutureValidatorForDate' [java] Found type 'javax.validation.constraints.Future' [java] [WARN] Ignoring unresolvable annotation type javax.validation.Constraint [java]Resolving com.google.gwt.validation.client.constraints.NotNullValidator [java] Found type 'com.google.gwt.validation.client.constraints.NotNullValidator' [java] Found type 'javax.validation.constraints.NotNull' [java] [WARN] Ignoring unresolvable annotation type javax.validation.Constraint [java]Resolving com.google.gwt.validation.client.constraints.NullValidator [java] Found type 'com.google.gwt.validation.client.constraints.NullValidator' [java] Found type 'javax.validation.constraints.Null' [java] [WARN] Ignoring unresolvable annotation type javax.validation.Constraint [java]Resolving com.google.gwt.validation.client.constraints.PastValidatorForDate [java] Found type 'com.google.gwt.validation.client.constraints.PastValidatorForDate' [java] Found type 'javax.validation.constraints.Past' [java] [WARN] Ignoring unresolvable annotation type javax.validation.Constraint [java]Resolving com.google.gwt.validation.client.constraints.PatternValidator [java] Found type 'com.google.gwt.validation.client.constraints.PatternValidator' [java] Found type 'javax.validation.constraints.Pattern' [java] [WARN] Ignoring unresolvable annotation type javax.validation.Constraint http://gwt-code-reviews.appspot.com/1422804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)
http://gwt-code-reviews.appspot.com/1424803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove JAnnotation from GWT AST. (issue1420803)
Thanks guys. http://gwt-code-reviews.appspot.com/1420803/diff/2001/dev/core/super/com/google/gwt/core/client/impl/ArtificialRescue.java File dev/core/super/com/google/gwt/core/client/impl/ArtificialRescue.java (right): http://gwt-code-reviews.appspot.com/1420803/diff/2001/dev/core/super/com/google/gwt/core/client/impl/ArtificialRescue.java#newcode31 dev/core/super/com/google/gwt/core/client/impl/ArtificialRescue.java:31: */ Good call, when I wrote this, the logic was scattered between GenerateJavaAST and ArtificialRescueChecker, but now it's all in ArtificialRescueChecker. http://gwt-code-reviews.appspot.com/1420803/diff/31/dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java File dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java (right): http://gwt-code-reviews.appspot.com/1420803/diff/31/dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java#newcode145 dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java:145: On 2011/04/19 11:39:04, zundel wrote: inconsistent newlines Done. http://gwt-code-reviews.appspot.com/1420803/diff/31/dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java#newcode197 dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java:197: // Goal (2) Copied in the doc from the class comment, here and elsewhere. http://gwt-code-reviews.appspot.com/1420803/diff/31/dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java#newcode240 dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java:240: JsniRef jsni = JsniRef.parse(@foo:: + method); On 2011/04/19 11:39:04, zundel wrote: This check doesn't have anything to do with JSNI does it? Its just checking the method signature using code we already have for JSNI? If so, comment this. Done. http://gwt-code-reviews.appspot.com/1420803/diff/31/dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java File dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java (left): http://gwt-code-reviews.appspot.com/1420803/diff/31/dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java#oldcode30 dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java:30: * Represents a java annotation. On 2011/04/19 11:39:04, zundel wrote: I'm wondering why isn't ArtificialRescue just some internal data structure we add to JType or JNode if it was all just internal bookkeeping. You're right on, it is an internal data structure, JDeclaredType.artificialRescues. The annotations only mattered from GenerateJavaAST until ArtificialRescueRecorder ran, which would transfer the data from annotations into the internal structure. This change basically gets rid of the intermediary format and produces the internal structures directly from GenerateJavaAST. As Bob alludes to, there could be future uses for annotations, but we decided that any such future uses are likely to be amenable to the same internal structure approach we're using here now, and so the annotations are just unnecessary baggage to carry around. http://gwt-code-reviews.appspot.com/1420803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)
http://gwt-code-reviews.appspot.com/1424803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Adds support to EditorDrivers for boolean accessors (issue1427802)
Hi All, I've uploaded another patch to Rietveld at http://gwt-code-reviews.appspot.com/1427802/ . Could somebody please review this for me? Also, is asking for a review on here the correct protocol for new (unassigned) issues? Cheers, Daniel On 20 April 2011 02:38, daniel.r.b...@gmail.com wrote: Reviewers: , Description: Issue 6267: EditorDriver implementations do not recognise boolean accessors with the prefix is (as opposed to get). This patch makes EditorDrivers search for an is accessor when no get accessor is found. Please review this at http://gwt-code-reviews.appspot.com/1427802/ Affected files: dev/core/test/com/google/gwt/dev/javac/impl/JavaResourceBase.java user/src/com/google/gwt/editor/rebind/model/EditorModel.java user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java Index: dev/core/test/com/google/gwt/dev/javac/impl/JavaResourceBase.java === --- dev/core/test/com/google/gwt/dev/javac/impl/JavaResourceBase.java (revision 10022) +++ dev/core/test/com/google/gwt/dev/javac/impl/JavaResourceBase.java (working copy) @@ -42,6 +42,22 @@ return code; } }; + public static final MockJavaResource BOOLEAN = new MockJavaResource(java.lang.Boolean) { +@Override +protected CharSequence getContent() { + StringBuffer code = new StringBuffer(); + code.append(package java.lang;\n); + code.append(public class Boolean {\n); + code.append( private boolean value;\n); + code.append( public Boolean(boolean value) {\n); + code.append(this.value = value;\n); + code.append( }\n); + code.append( public static Boolean valueOf(boolean b) { return new Boolean(b); }\n); + code.append( public boolean booleanValue() { return value; }\n); + code.append(}\n); + return code; +} + }; public static final MockJavaResource BYTE = new MockJavaResource( java.lang.Byte) { @Override @@ -401,7 +417,7 @@ public static MockJavaResource[] getStandardResources() { return new MockJavaResource[]{ -ANNOTATION, BYTE, CHARACTER, CLASS, CLASS_NOT_FOUND_EXCEPTION, +ANNOTATION, BOOLEAN, BYTE, CHARACTER, CLASS, CLASS_NOT_FOUND_EXCEPTION, COLLECTION, DOUBLE, ENUM, EXCEPTION, ERROR, FLOAT, INTEGER, IS_SERIALIZABLE, JAVASCRIPTOBJECT, LONG, MAP, NO_CLASS_DEF_FOUND_ERROR, NUMBER, OBJECT, SERIALIZABLE, SHORT, STRING, STRING_BUILDER, Index: user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java === --- user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java (revision 10022) +++ user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java (working copy) @@ -187,7 +187,7 @@ types.findType(t.CompositeEditorDriver), rfedType); EditorData[] data = m.getEditorData(); -assertEquals(7, data.length); +assertEquals(8, data.length); String[] paths = new String[data.length]; String[] expressions = new String[data.length]; @@ -196,19 +196,20 @@ expressions[i] = data[i].getExpression(); } assertEquals(Arrays.asList(address, address.city, address.street, -person, person.lastModified, person.name, person.readonly), -Arrays.asList(paths)); +person, person.alive, person.lastModified, person.name, +person.readonly), Arrays.asList(paths)); // address is a property, person is a method in CompositeEditor assertEquals(Arrays.asList(address, address.city, address.street, -person(), person().lastModified, person().name, +person(), person().alive, person().lastModified, person().name, person().readonly), Arrays.asList(expressions)); assertTrue(data[0].isDelegateRequired()); assertFalse(data[0].isLeafValueEditor() || data[0].isValueAwareEditor()); assertTrue(data[3].isDelegateRequired()); assertFalse(data[3].isLeafValueEditor() || data[3].isValueAwareEditor()); -checkPersonLastModified(data[4]); -checkPersonName(data[5]); -checkPersonReadonly(data[6]); +checkPersonAlive(data[4]); +checkPersonLastModified(data[5]); +checkPersonName(data[6]); +checkPersonReadonly(data[7]); } public void testCyclicDriver() { @@ -258,14 +259,16 @@ EditorModel m = new EditorModel(logger, types.findType(t.PersonEditorDriver), rfedType); EditorData[] fields = m.getEditorData(); -assertEquals(3, fields.length); +assertEquals(4, fields.length); +// alive +checkPersonAlive(fields[0]); // lastModified -checkPersonLastModified(fields[0]); +checkPersonLastModified(fields[1]); // name -checkPersonName(fields[1]); +checkPersonName(fields[2]); // readonly -checkPersonReadonly(fields[2]); +checkPersonReadonly(fields[3]); } public void testFlatData() throws
[gwt-contrib] [google-web-toolkit] r10023 committed - Make EventBus backward compatible....
Revision: 10023 Author: rj...@google.com Date: Tue Apr 19 06:56:46 2011 Log: Make EventBus backward compatible. Review at http://gwt-code-reviews.appspot.com/1423803 Review by: robertvaw...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=10023 Modified: /trunk/user/src/com/google/gwt/event/shared/EventBus.java /trunk/user/src/com/google/gwt/event/shared/ResettableEventBus.java /trunk/user/src/com/google/gwt/event/shared/SimpleEventBus.java /trunk/user/src/com/google/gwt/event/shared/testing/CountingEventBus.java === --- /trunk/user/src/com/google/gwt/event/shared/EventBus.java Mon Apr 18 16:25:25 2011 +++ /trunk/user/src/com/google/gwt/event/shared/EventBus.java Tue Apr 19 06:56:46 2011 @@ -21,8 +21,9 @@ * Extends {com.google.web.bindery.event.shared.EventBus} for legacy * compatibility. */ -public abstract class EventBus extends com.google.web.bindery.event.shared.EventBus implements HasHandlers { - +public abstract class EventBus extends com.google.web.bindery.event.shared.EventBus implements +HasHandlers { + public H extends EventHandler HandlerRegistration addHandler(GwtEvent.TypeH type, H handler) { return wrap(addHandler((Event.TypeH) type, handler)); } @@ -31,8 +32,24 @@ Object source, H handler) { return wrap(addHandlerToSource((Event.TypeH) type, source, handler)); } - - public void fireEvent(GwtEvent? event) { + + public void fireEvent(Event? event) { +throw new UnsupportedOperationException(Subclass responsibility. ++ This class is a legacy wrapper for com.google.web.bindery.event.shared.EventBus. ++ Use that directly, or try com.google.gwt.event.shared.SimpleEventBus); + } + + public abstract void fireEvent(GwtEvent? event); + + public void fireEventFromSource(Event? event, Object source) { +throw new UnsupportedOperationException(Subclass responsibility. ++ This class is a legacy wrapper for com.google.web.bindery.event.shared.EventBus. ++ Use that directly, or try com.google.gwt.event.shared.SimpleEventBus); + } + + public abstract void fireEventFromSource(GwtEvent? event, Object source); + + protected void castFireEvent(GwtEvent? event) { try { fireEvent((Event?) event); } catch (com.google.web.bindery.event.shared.UmbrellaException e) { @@ -40,7 +57,7 @@ } } - public void fireEventFromSource(GwtEvent? event, Object source) { + protected void castFireEventFromSource(GwtEvent? event, Object source) { try { fireEventFromSource((Event?) event, source); } catch (com.google.web.bindery.event.shared.UmbrellaException e) { === --- /trunk/user/src/com/google/gwt/event/shared/ResettableEventBus.java Mon Apr 18 16:25:25 2011 +++ /trunk/user/src/com/google/gwt/event/shared/ResettableEventBus.java Tue Apr 19 06:56:46 2011 @@ -58,11 +58,21 @@ public void fireEvent(Event? event) { real.fireEvent(event); } + + @Override + public void fireEvent(GwtEvent? event) { +castFireEvent(event); + } @Override public void fireEventFromSource(Event? event, Object source) { real.fireEventFromSource(event, source); } + + @Override + public void fireEventFromSource(GwtEvent? event, Object source) { +castFireEventFromSource(event, source); + } public void removeHandlers() { real.removeHandlers(); === --- /trunk/user/src/com/google/gwt/event/shared/SimpleEventBus.java Mon Apr 18 16:25:25 2011 +++ /trunk/user/src/com/google/gwt/event/shared/SimpleEventBus.java Tue Apr 19 06:56:46 2011 @@ -41,9 +41,19 @@ public void fireEvent(Event? event) { real.fireEvent(event); } + + @Override + public void fireEvent(GwtEvent? event) { +castFireEvent(event); + } @Override public void fireEventFromSource(Event? event, Object source) { real.fireEventFromSource(event, source); } -} + + @Override + public void fireEventFromSource(GwtEvent? event, Object source) { +castFireEventFromSource(event, source); + } +} === --- /trunk/user/src/com/google/gwt/event/shared/testing/CountingEventBus.java Mon Apr 18 16:25:25 2011 +++ /trunk/user/src/com/google/gwt/event/shared/testing/CountingEventBus.java Tue Apr 19 06:56:46 2011 @@ -49,11 +49,21 @@ public void fireEvent(Event? event) { real.fireEvent(event); } + + @Override + public void fireEvent(GwtEvent? event) { +castFireEvent(event); + } @Override public void fireEventFromSource(Event? event, Object source) { real.fireEventFromSource(event, source); } + + @Override + public void fireEventFromSource(GwtEvent? event, Object source) { +castFireEventFromSource(event, source); + } public int getCount(GwtEvent.Type? type) { return real.getCount(type); --
[gwt-contrib] Re: Supress errors when the binary validation.jar file is missing from the (issue1422804)
LGTM http://gwt-code-reviews.appspot.com/1422804/diff/1/dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/1422804/diff/1/dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java#newcode1190 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:1190: + Is validation-version-sources.jar on the classpath?); and validation-version.jar too? http://gwt-code-reviews.appspot.com/1422804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make EventBus backward compatible. (issue1423803)
Inadequate, need to give similar treatment to the addHandler methods. Duh. http://gwt-code-reviews.appspot.com/1423803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Suppresses multiple warnings related to validation .jar file and (issue1424804)
Well you are right. This patch will suppress errors if you are missing both .jar files, but if you add in validation-api-version-sources.jar, you get a different slew of non-fatal errors. followup patch at: http://gwt-code-reviews.appspot.com/1422804 On Tue, Apr 19, 2011 at 11:24 AM, Rodrigo Chandia rchan...@google.com wrote: On Tue, Apr 19, 2011 at 11:19 AM, Eric Ayers zun...@google.com wrote: good question. I know that the -sources.jar file is needed to just make the errors go away for legacy projects that don't reference any classes that use javax.validation, but I haven't seen the messages for a sample that actually needs validation. I think you are right. I was testing with the sample app webAppCreator (and GPE) generates for new projects, which uses javax.validation on the client. -- Eric Z. Ayers Google Web Toolkit, Atlanta, GA USA -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Include all needed javax.validation classes for the api checker. (issue1425802)
LGTM http://gwt-code-reviews.appspot.com/1425802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10025 committed - Supress errors when the binary validation.jar file is missing from the...
Revision: 10025 Author: zun...@google.com Date: Tue Apr 19 07:37:00 2011 Log: Supress errors when the binary validation.jar file is missing from the class path (previous patch only address source jar) Review at http://gwt-code-reviews.appspot.com/1422804 http://code.google.com/p/google-web-toolkit/source/detail?r=10025 Modified: /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java /trunk/dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java === --- /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java Tue Apr 19 04:01:17 2011 +++ /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java Tue Apr 19 07:37:00 2011 @@ -106,7 +106,7 @@ if (!warnedMissingValidationJar) { warnedMissingValidationJar = true; logger.log(TreeLogger.WARN, Detected warnings related to ' + typeName + '. -+ Is validation-api-version-sources.jar on the classpath?); ++ Are validation-api-version.jar and validation-api-version-sources.jar on the classpath?); logger.log(TreeLogger.INFO, Specify -logLevel DEBUG to see all errors.); // Show the first error that matches return false; === --- /trunk/dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java Wed Feb 9 07:49:06 2011 +++ /trunk/dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java Tue Apr 19 07:37:00 2011 @@ -25,15 +25,15 @@ import com.google.gwt.dev.asm.signature.SignatureReader; import com.google.gwt.dev.asm.util.TraceClassVisitor; import com.google.gwt.dev.javac.asm.CollectAnnotationData; +import com.google.gwt.dev.javac.asm.CollectAnnotationData.AnnotationData; import com.google.gwt.dev.javac.asm.CollectClassData; +import com.google.gwt.dev.javac.asm.CollectClassData.AnnotationEnum; import com.google.gwt.dev.javac.asm.CollectFieldData; import com.google.gwt.dev.javac.asm.CollectMethodData; import com.google.gwt.dev.javac.asm.CollectTypeParams; import com.google.gwt.dev.javac.asm.ResolveClassSignature; import com.google.gwt.dev.javac.asm.ResolveMethodSignature; import com.google.gwt.dev.javac.asm.ResolveTypeSignature; -import com.google.gwt.dev.javac.asm.CollectAnnotationData.AnnotationData; -import com.google.gwt.dev.javac.asm.CollectClassData.AnnotationEnum; import com.google.gwt.dev.javac.typemodel.JAbstractMethod; import com.google.gwt.dev.javac.typemodel.JArrayType; import com.google.gwt.dev.javac.typemodel.JClassType; @@ -239,6 +239,11 @@ */ private static final boolean TRACE_CLASSES = false; + /** + * Suppress some warnings related to missing valiation.jar on classpath. + */ + private static boolean warnedMissingValidationJar = false; + private static JTypeParameter[] collectTypeParams(String signature) { if (signature != null) { ListJTypeParameter params = new ArrayListJTypeParameter(); @@ -541,22 +546,27 @@ private Class? extends Annotation getAnnotationClass(TreeLogger logger, AnnotationData annotData) { Type type = Type.getType(annotData.getDesc()); +String typeName = type.getClassName(); try { - Class? clazz = Class.forName(type.getClassName(), false, + Class? clazz = Class.forName(typeName, false, Thread.currentThread().getContextClassLoader()); if (!Annotation.class.isAssignableFrom(clazz)) { -logger.log(TreeLogger.ERROR, Type + type.getClassName() +logger.log(TreeLogger.ERROR, Type + typeName + is not an annotation); return null; } return clazz.asSubclass(Annotation.class); } catch (ClassNotFoundException e) { - logger.log(TreeLogger.WARN, Ignoring unresolvable annotation type - + type.getClassName()); + TreeLogger.Type level = TreeLogger.WARN; + if (shouldSuppressUnresolvableAnnotation(logger, typeName)) { +level = TreeLogger.DEBUG; + } + logger.log(level, Ignoring unresolvable annotation type + + typeName); return null; } } - + @SuppressWarnings(unused) private Class? getClassLiteralForPrimitive(Type type) { switch (type.getSort()) { @@ -583,7 +593,7 @@ return null; } } - + /** * Map a bitset onto a different bitset. * @@ -1164,4 +1174,27 @@ return null; } } -} + + /** + * Suppress multiple validation related messages and replace with a hint. + * + * @param typeName fully qualified type name to check for filtering + */ + // TODO(zundel): Can be removed when javax.validation is included in the JRE + private boolean shouldSuppressUnresolvableAnnotation(TreeLogger logger, String typeName) { +if (typeName.startsWith(javax.validation.) +|| typeName.startsWith(com.google.gwt.validation.)) { + if (!warnedMissingValidationJar) { +warnedMissingValidationJar = true; +
[gwt-contrib] Re: Make EventBus backward compatible. (issue1423803)
Noticed the half-assedness after submitting r10023. Will follow up w/new patch. With unit test. And less rushing. http://gwt-code-reviews.appspot.com/1423803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Finishes the job of making EventBus backward compatible, (issue1425804)
Reviewers: bobv, Description: Finishes the job of making EventBus backward compatible, half done in r10023 Please review this at http://gwt-code-reviews.appspot.com/1425804/ Affected files: M user/src/com/google/gwt/event/shared/EventBus.java M user/src/com/google/gwt/event/shared/ResettableEventBus.java M user/src/com/google/gwt/event/shared/SimpleEventBus.java M user/src/com/google/gwt/event/shared/testing/CountingEventBus.java M user/test/com/google/gwt/event/EventSuite.java A user/test/com/google/gwt/event/shared/EventBusTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Future of CellTable
John, can you elaborate what - Expandable rows (really, a fully customizable table builder, probably post GWT 2.3) means? I'm currently working on adding groupability to a copy of celltable and its hierarchy. Will the fully customizale table builder be the solution I'm looking for? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors