How to get default loading indicator for DataGrid

2012-06-05 Thread dayanandabv
Hi all,

How to get default loading indicator for DataGrid?
Is Default blinking 3 boxes while loading data is animated image?

I tried to use  Widget defaultWidget =  getLoadingIndicator();
but it gives me null value.

what i want is i need to show static text before the 3 boxes.

i tried overriding setLoadingIndicator  but no help, any help
regarding the same
public void setLoadingIndicator()
{
//giving null value here
Widget defaultWidget =  getLoadingIndicator();
HorizontalPanel hp = new HorizontalPanel();

hp.add(new Label(Please wait loading));
hp.add(defaultWidget);
super.setLoadingIndicator(hp);
}

Thanks in advance
Daya

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Authentification With Selenium

2012-06-05 Thread alaa aadil
hello ,

what i want to do is :
 i want to create an application of monitoring
with GWT , and the first view of this application should be an
Athentification view  of the user .
 when i was searching in the Net , i found that some people suggest
to
use Selenium to do this Authentification part.
i don't know if i can do this witout Selenium , just with GWT ?

please, what do you advice me to use ?
thanks
best regards Adil

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Resubmitting RequestFactory request when server side logic requires it

2012-06-05 Thread Thomas Broyer


On Monday, June 4, 2012 10:17:52 PM UTC+2, Ryan McFall wrote:

 I am having issues when I want to resubmit some requests to the server 
 when the server-side logic indicates it should happen.  In particular, 
 here's what happens: 

 1.  The user logins in, which causes an object (SurveyResponseHeader) 
 to be created on the server-side, and sent back to the client.  edit 
 is then called on the client side on that object. 

 2.  The user fills in a set of SurveyResponse objects into a list 
 contained by the SurveyResponseHeader object (and a corresponding 
 request is made to save the object on the server). 

 3.  The user submits the survey responses, but the session has timed 
 out on the server.  An error code is sent back to the client, and the 
 user is asked to re-authenticate. 

 At this point, I want to resubmit the request that caused the error; 
 it should succeed on the server now because the session has been 
 restarted.  However, I can't use the same request object because I'll 
 get the request is already in progress error message. 

 Rather than tell you everything I've tried, I'd like to hear what 
 people think is the right way to accomplish this.  I can provide more 
 details if needed, but I want to keep the description simple at least 
 to start. 


You have to make sure you convey the session-expiry-error as a transport 
error or general failure, and not as a service method return value.
Using the DefaultRequestTransport, any non-200 response from the server 
will be a transport error, so handling session expiration from a servlet 
filter on the server and responding with a non-200 status code (let's say, 
for instance, a 401, or 400; make sure you don't redirect to your login 
page though!) should Just Work(tm).
To tell the difference between a real server failure and session expiration 
though, you'll have to make your own RequestTransport on the client 
(possibly extending DefaultRequestTransport) and define some kind of 
protocol (shared knowledge) with the server. Have a look at how it's done 
in the MobileWebApp sample in the GWT SDK: 
http://code.google.com/p/google-web-toolkit/source/browse/trunk/samples/mobilewebapp/src/main/java/com/google/gwt/sample/gaerequest/
 It's 
specific to Google AppEngine but is really easy to adapt to whatever you 
use. The trick is to make sure you don't set a security-constraint on the 
RequestFactoryServlet in your web.xml, and instead handle the absence of 
authenticated user from code (in a servlet filter is the easiest)

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/4IdupKo3KhAJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: 3-tier architecture /gwt

2012-06-05 Thread Thomas Broyer
I'm still looking for the best / most productive way to do it 
(see https://plus.google.com/113945685385052458154/posts/3VKPRDU2xZz) but 
you can simply “Run as… → Maven build…” on the server project, and select 
the jetty:start goal with a “dev” property (set to whatever value, “true” 
is fine); i.e. the exact equivalent to “cd *-server  mvn jetty:start 
-Ddev”.

On Tuesday, June 5, 2012 3:23:18 AM UTC+2, Juan Pablo Gardella wrote:

 Hi,

 I have problems to run the project inside eclipse. I add this to the 
 parent pom.xml:

 plugin
 groupIdorg.apache.maven.plugins/groupId
  artifactIdmaven-eclipse-plugin/artifactId
 version2.9/version
  configuration
 wtpmanifesttrue/wtpmanifest
 wtpapplicationxmltrue/wtpapplicationxml
  manifest${basedir}/src/main/resources/META-INF/MANIFEST.MF
 /manifest
  projectNameTemplate
 [artifactId]
 /projectNameTemplate
  wtpversion2.0/wtpversion
 workspace${workspace.path}/workspace
  downloadSourcestrue/downloadSources
 /configuration
  /plugin

 So, the project is added as a dependency in the eclipse. With this I can 
 run the *client* module, I change in shared project, refresh the browser 
 and the changes happens. So I can remove in client module the part where 
 use build-helper-maven-plugin to add sources. I don't know why, but in 
 eclipse doesn't found this sources folder.

 The problem that I facing now is, how I can run the server code too inside 
 eclipse? I want to click on Run - Web application and run in dev mode all 
 modules to test server code too.

 If run server module fails because don't found entry module:
 Missing required argument 'module[s]'
 Google Web Toolkit 2.4.0
 DevMode [-noserver] [-port port-number | auto] [-whitelist 
 whitelist-string] [-blacklist blacklist-string] [-logdir directory] 
 [-logLevel level] [-gen dir] [-bindAddress host-name-or-address] 
 [-codeServerPort port-number | auto] [-server 
 servletContainerLauncher[:args]] [-startupUrl url] [-war dir] [-deploy dir] 
 [-extra dir] [-workDir dir] module[s] 

 And if run client module fail because:

 [WARN] 404 - POST /app/greet (127.0.0.1) 1395 bytes

 And in my server module has:

 servlet-mapping
 servlet-namegreetServlet/servlet-name
 url-pattern/app/greet/url-pattern
   /servlet-mapping

 Can someone help me to run inside Eclipse? 


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/OqM05pUDwYMJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT JSNI Callback

2012-06-05 Thread Thomas Broyer


On Tuesday, June 5, 2012 3:42:36 AM UTC+2, zorro wrote:

 I am trying to implement a callback using JSNI. 
  1. I don't know if changing this is allowed in the way I do it.


No.
BTW, you're not doing much.
 

  2. I don't know if such an assignment is advisable from the perspective 
 of JSNI functionality


No.
 

  3. The compiler in Eclispe does not seem to grasp that as well and I 
 don't know the right syntax 

 for
 this.@com.roamtopix.client.StaticFacad.JsCallback::callback.execute(Lcom/google/gwt/core/client/JavaScriptObject;)(jsObject);
  with 
 callback.execute it says 
 JavaScript parsing: Missing ) after argument list

 for 
 this.@com.roamtopix.client.StaticFacad.JsCallback::callback::execute(Lcom/google/gwt/core/client/JavaScriptObject;)(jsObject);with
  
 callback::execute it says
 JavaScript parsing: Invalid label



var callback = this.@com.roamtopix.client.StaticFacad.JsCallback::callback;
callback.@com.roamtopix.client.StaticFacad.JavaCallback::execute(Lcom/google/gwt/core/client/JavaScriptObject;)(jsObject);

But there's simpler.
It depends how you (intend to) use your callback though.
Have a look 
at 
https://code.google.com/p/gwt-in-the-air/source/browse/trunk/src/net/ltgt/gwt/browserplus/core/client/BrowserPlus.java#145
 
(the createNativeCallback method) for a way of wrapping a Java callback 
into a JS function to be passed as a callback to some API.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/3RJnhZ4JhhoJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: if use mouse wheel to scroll, the speed is slower?

2012-06-05 Thread Thomas Broyer
It could be due 
to http://code.google.com/p/google-web-toolkit/issues/detail?id=6167
When dragging the scrollbar thumb, you're not over the CellTable, so it has 
no mouse event to process.

On Tuesday, June 5, 2012 11:30:39 AM UTC+2, tong123123 wrote:

 as attached, if I drag the scrollbar in the upper right, the flow is very 
 fluency, but if I use the mouse wheel to scroll, the speed is slower and 
 always has some lags (that is, the scrolling is sometimes slower and 
 sometimes sudden faster, and sometimes not scroll even scroll the mouse 
 wheel)
 what is the problem come from? or it is default behavior of gwt celltable 
 and scrollbar( the upper part is a scrollpanel enclose a celltable)?


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/JjkyvF8Cm8cJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: SOP, GWT, and XMLHTTPRequest Calls

2012-06-05 Thread zorro


Dne neděle, 27. května 2012 13:12:41 UTC+2 zorro napsal(a):

 I just read the  
 https://developers.google.com/web-toolkit/doc/latest/FAQ_Server after 
 unsuccessful attempt to run local appengine server separately from my GWT 
 junit integration tests of GWT RPC. I am getting SOP error SEVERE: 
 runtimeError: message=[Access to restricted URI denied] 
 sourceName=[injected script] line=[93] lineSource=[null] lineOffset=[0].

 Now my question is, is it possible to achieve this somehow?

 If not, regarding aforementioned link, can you guys make it possible to 
 set up different hosts not breaking SOP for GWT development? This is 
 possible for Chrome extensions. This feature would make testing much easier 
 for me.




-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/fP8U2wsfMVsJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Resubmitting RequestFactory request when server side logic requires it

2012-06-05 Thread Ryan McFall
Thanks for the ideas, Thomas.

Two questions on the response:
1.  I was hoping to detect this within my service method, rather than
at a higher level like a servlet filter.  Is it possible to return a
non-200 error code from within the service method?  I tried getting
the thread local HttpResponse object and changing its status code, but
this had no effect.

2.  If I do write a servlet filter, there are only certain service
methods that I want this code to apply to (for example, I use a
service method, rather than the built in servlet authentication to
authenticate the user, and I certainly don't want to require a valid
session during this call).  From what I see in the sample code you
posted, it looks like that application is doing this on every
request.  What is the best way to differentiate which service
method(s) are being called as part of the request?  Are there classes
available that will help me parse the request payload on the server
and identify the methods being called?

Ryan

On Jun 5, 5:21 am, Thomas Broyer t.bro...@gmail.com wrote:
 On Monday, June 4, 2012 10:17:52 PM UTC+2, Ryan McFall wrote:

  I am having issues when I want to resubmit some requests to the server
  when the server-side logic indicates it should happen.  In particular,
  here's what happens:

  1.  The user logins in, which causes an object (SurveyResponseHeader)
  to be created on the server-side, and sent back to the client.  edit
  is then called on the client side on that object.

  2.  The user fills in a set of SurveyResponse objects into a list
  contained by the SurveyResponseHeader object (and a corresponding
  request is made to save the object on the server).

  3.  The user submits the survey responses, but the session has timed
  out on the server.  An error code is sent back to the client, and the
  user is asked to re-authenticate.

  At this point, I want to resubmit the request that caused the error;
  it should succeed on the server now because the session has been
  restarted.  However, I can't use the same request object because I'll
  get the request is already in progress error message.

  Rather than tell you everything I've tried, I'd like to hear what
  people think is the right way to accomplish this.  I can provide more
  details if needed, but I want to keep the description simple at least
  to start.

 You have to make sure you convey the session-expiry-error as a transport
 error or general failure, and not as a service method return value.
 Using the DefaultRequestTransport, any non-200 response from the server
 will be a transport error, so handling session expiration from a servlet
 filter on the server and responding with a non-200 status code (let's say,
 for instance, a 401, or 400; make sure you don't redirect to your login
 page though!) should Just Work(tm).
 To tell the difference between a real server failure and session expiration
 though, you'll have to make your own RequestTransport on the client
 (possibly extending DefaultRequestTransport) and define some kind of
 protocol (shared knowledge) with the server. Have a look at how it's done
 in the MobileWebApp sample in the GWT 
 SDK:http://code.google.com/p/google-web-toolkit/source/browse/trunk/sampl...It's
 specific to Google AppEngine but is really easy to adapt to whatever you
 use. The trick is to make sure you don't set a security-constraint on the
 RequestFactoryServlet in your web.xml, and instead handle the absence of
 authenticated user from code (in a servlet filter is the easiest)

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Resubmitting RequestFactory request when server side logic requires it

2012-06-05 Thread ashwin.desi...@gmail.com
Ryan,

You can create your own custom annotation (for example : LoggedIn). Apply
this on all methods you want to authenticate the user/ session to be
validated.

Define your own ApplicationRequestFactoryServlet and
ApplicationServiceLayerDecorators. Override the invoke method under
ServiceLayerDecorator and validate for the presence of @LoggedIn
annotation. If present, check if the user session is valid.

regards
Ashwin



On Tue, Jun 5, 2012 at 4:08 PM, Ryan McFall mcfall.r...@gmail.com wrote:

 Thanks for the ideas, Thomas.

 Two questions on the response:
 1.  I was hoping to detect this within my service method, rather than
 at a higher level like a servlet filter.  Is it possible to return a
 non-200 error code from within the service method?  I tried getting
 the thread local HttpResponse object and changing its status code, but
 this had no effect.





 2.  If I do write a servlet filter, there are only certain service
 methods that I want this code to apply to (for example, I use a
 service method, rather than the built in servlet authentication to
 authenticate the user, and I certainly don't want to require a valid
 session during this call).  From what I see in the sample code you
 posted, it looks like that application is doing this on every
 request.  What is the best way to differentiate which service
 method(s) are being called as part of the request?  Are there classes
 available that will help me parse the request payload on the server
 and identify the methods being called?

 Ryan







 On Jun 5, 5:21 am, Thomas Broyer t.bro...@gmail.com wrote:
  On Monday, June 4, 2012 10:17:52 PM UTC+2, Ryan McFall wrote:
 
   I am having issues when I want to resubmit some requests to the server
   when the server-side logic indicates it should happen.  In particular,
   here's what happens:
 
   1.  The user logins in, which causes an object (SurveyResponseHeader)
   to be created on the server-side, and sent back to the client.  edit
   is then called on the client side on that object.
 
   2.  The user fills in a set of SurveyResponse objects into a list
   contained by the SurveyResponseHeader object (and a corresponding
   request is made to save the object on the server).
 
   3.  The user submits the survey responses, but the session has timed
   out on the server.  An error code is sent back to the client, and the
   user is asked to re-authenticate.
 
   At this point, I want to resubmit the request that caused the error;
   it should succeed on the server now because the session has been
   restarted.  However, I can't use the same request object because I'll
   get the request is already in progress error message.
 
   Rather than tell you everything I've tried, I'd like to hear what
   people think is the right way to accomplish this.  I can provide more
   details if needed, but I want to keep the description simple at least
   to start.
 
  You have to make sure you convey the session-expiry-error as a transport
  error or general failure, and not as a service method return value.
  Using the DefaultRequestTransport, any non-200 response from the server
  will be a transport error, so handling session expiration from a
 servlet
  filter on the server and responding with a non-200 status code (let's
 say,
  for instance, a 401, or 400; make sure you don't redirect to your login
  page though!) should Just Work(tm).
  To tell the difference between a real server failure and session
 expiration
  though, you'll have to make your own RequestTransport on the client
  (possibly extending DefaultRequestTransport) and define some kind of
  protocol (shared knowledge) with the server. Have a look at how it's
 done
  in the MobileWebApp sample in the GWT SDK:
 http://code.google.com/p/google-web-toolkit/source/browse/trunk/sampl...It's
  specific to Google AppEngine but is really easy to adapt to whatever you
  use. The trick is to make sure you don't set a security-constraint on
 the
  RequestFactoryServlet in your web.xml, and instead handle the absence of
  authenticated user from code (in a servlet filter is the easiest)

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: 3-tier architecture /gwt

2012-06-05 Thread Juan Pablo Gardella
Thanks Thomas! I will try it

2012/6/5 Thomas Broyer t.bro...@gmail.com

 I'm still looking for the best / most productive way to do it (see
 https://plus.google.com/113945685385052458154/posts/3VKPRDU2xZz) but you
 can simply “Run as… → Maven build…” on the server project, and select the
 jetty:start goal with a “dev” property (set to whatever value, “true” is
 fine); i.e. the exact equivalent to “cd *-server  mvn jetty:start -Ddev”.


 On Tuesday, June 5, 2012 3:23:18 AM UTC+2, Juan Pablo Gardella wrote:

 Hi,

 I have problems to run the project inside eclipse. I add this to the
 parent pom.xml:

 plugin
 groupIdorg.apache.maven.**plugins/groupId
  artifactIdmaven-eclipse-**plugin/artifactId
 version2.9/version
  configuration
 wtpmanifesttrue/**wtpmanifest
 wtpapplicationxmltrue/**wtpapplicationxml
  manifest${basedir}/src/main/**resources/META-INF/MANIFEST.MF
 /manifest
  projectNameTemplate
 [artifactId]
 /projectNameTemplate
  wtpversion2.0/wtpversion
 workspace${workspace.path}/**workspace
  downloadSourcestrue/**downloadSources
 /configuration
  /plugin

 So, the project is added as a dependency in the eclipse. With this I can
 run the *client* module, I change in shared project, refresh the browser
 and the changes happens. So I can remove in client module the part where
 use build-helper-maven-plugin to add sources. I don't know why, but in
 eclipse doesn't found this sources folder.

 The problem that I facing now is, how I can run the server code too
 inside eclipse? I want to click on Run - Web application and run in dev
 mode all modules to test server code too.

 If run server module fails because don't found entry module:
 Missing required argument 'module[s]'
 Google Web Toolkit 2.4.0
 DevMode [-noserver] [-port port-number | auto] [-whitelist
 whitelist-string] [-blacklist blacklist-string] [-logdir directory]
 [-logLevel level] [-gen dir] [-bindAddress host-name-or-address]
 [-codeServerPort port-number | auto] [-server servletContainerLauncher[:
 **args]] [-startupUrl url] [-war dir] [-deploy dir] [-extra dir]
 [-workDir dir] module[s]

 And if run client module fail because:

 [WARN] 404 - POST /app/greet (127.0.0.1) 1395 bytes

 And in my server module has:

 servlet-mapping
 servlet-namegreetServlet/**servlet-name
 url-pattern/app/greet/url-**pattern
   /servlet-mapping

 Can someone help me to run inside Eclipse?

  --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To view this discussion on the web visit
 https://groups.google.com/d/msg/google-web-toolkit/-/OqM05pUDwYMJ.

 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Setting focus on a Anchor button

2012-06-05 Thread Qrunk
Hi

Can some one help me understand why we can't set focus on Anchor button 
though its a focus-able widget.
We are using Anchor button as a Composite widget wrapped around a 
FlowPanel. We are unable to setFocus(true) on Anchor button.

A sample code on this would be nice. :)

Thanks.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/y2JWxavD938J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Resubmitting RequestFactory request when server side logic requires it

2012-06-05 Thread Jens


 You can create your own custom annotation (for example : LoggedIn). Apply 
 this on all methods you want to authenticate the user/ session to be 
 validated. 


Better do it the opposite way if you only have few methods that are allowed 
for unauthenticated users (I think thats more typically), e.g. create a 
@AllowUnauthenticated annotation and if its absent assume the user must be 
logged in. That way you have few opt-out methods instead of many opt-in 
methods.

-- J.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/Y7SWwBLfRlkJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Resubmitting RequestFactory request when server side logic requires it

2012-06-05 Thread Ryan McFall
After I wrote my original follow-up to Thomas' message, I thought of
having different services - one for methods that require
authentication, and one for those that don't.  Then I can map my
ServletFilter to the URL for the service that requires authentication,
and not map it to those that don't.

That seems easier to me than the annotation route.  Anyone have any
reasons to think otherwise?

Ryan

On Jun 5, 8:22 am, Jens jens.nehlme...@gmail.com wrote:
  You can create your own custom annotation (for example : LoggedIn). Apply
  this on all methods you want to authenticate the user/ session to be
  validated.

 Better do it the opposite way if you only have few methods that are allowed
 for unauthenticated users (I think thats more typically), e.g. create a
 @AllowUnauthenticated annotation and if its absent assume the user must be
 logged in. That way you have few opt-out methods instead of many opt-in
 methods.

 -- J.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Resubmitting RequestFactory request when server side logic requires it

2012-06-05 Thread Thomas Broyer


On Tuesday, June 5, 2012 3:58:22 PM UTC+2, Ryan McFall wrote:

 After I wrote my original follow-up to Thomas' message, I thought of 
 having different services - one for methods that require 
 authentication, and one for those that don't.  Then I can map my 
 ServletFilter to the URL for the service that requires authentication, 
 and not map it to those that don't. 

 That seems easier to me than the annotation route.  Anyone have any 
 reasons to think otherwise?


It won't work. RequestFactoryServlet loads from the classpath, so unless 
you somehow constrain the classpath of each servlet to only contain the 
classes you want to expose, the unauthenticated servlet would be able to 
load the services requiring authentication, therefore allowing 
unauthenticated access to them.
In other words, that's not how RF has been designed. 

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/fl0PLdvGKHUJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Resubmitting RequestFactory request when server side logic requires it

2012-06-05 Thread Ashwin Desikan
Thomas is correct. I had tried the route of creating two separate RF's. But 
that involves more work in comparison to annotations. In fact I changed my 
approach post Thomas suggestion in this forum quite sometime bac 

~Ashwin

Sent from my iPhone

On Jun 5, 2012, at 7:38 PM, Thomas Broyer t.bro...@gmail.com wrote:

 
 
 On Tuesday, June 5, 2012 3:58:22 PM UTC+2, Ryan McFall wrote:
 After I wrote my original follow-up to Thomas' message, I thought of 
 having different services - one for methods that require 
 authentication, and one for those that don't.  Then I can map my 
 ServletFilter to the URL for the service that requires authentication, 
 and not map it to those that don't. 
 
 That seems easier to me than the annotation route.  Anyone have any 
 reasons to think otherwise?
 
 It won't work. RequestFactoryServlet loads from the classpath, so unless you 
 somehow constrain the classpath of each servlet to only contain the classes 
 you want to expose, the unauthenticated servlet would be able to load the 
 services requiring authentication, therefore allowing unauthenticated 
 access to them.
 In other words, that's not how RF has been designed. 
 -- 
 You received this message because you are subscribed to the Google Groups 
 Google Web Toolkit group.
 To view this discussion on the web visit 
 https://groups.google.com/d/msg/google-web-toolkit/-/fl0PLdvGKHUJ.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to 
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at 
 http://groups.google.com/group/google-web-toolkit?hl=en.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Firefox 13 DevMode Plugin

2012-06-05 Thread Alan Leung
If anyone is wondering, I am aware and working on it.

-Alan

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Firefox 13 DevMode Plugin

2012-06-05 Thread James Wendel
As always, thanks for the heads up Alan.

On Jun 5, 1:05 pm, Alan Leung acle...@google.com wrote:
 If anyone is wondering, I am aware and working on it.

 -Alan

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Firefox 13 DevMode Plugin

2012-06-05 Thread Stefano Ciccarelli
Thanks.  
I hope you could put it on the official download page because I'm still stuck 
on Firefox 11.  

--  
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


Il giorno martedì 5 giugno 2012, alle ore 20:05, Alan Leung ha scritto:  

 If anyone is wondering, I am aware and working on it.
  
 -Alan
  
  
 --  
 You received this message because you are subscribed to the Google Groups 
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to 
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at 
 http://groups.google.com/group/google-web-toolkit?hl=en.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Using the Frame class, and adding Elements to it directly - doesn't display?

2012-06-05 Thread King_V
All,

I've got this very short program, and I don't understand why it's not
working.  I am creating a Frame object, trying to append element
children to it, and while the Frame instance seems to be aware of its
children, they do not get displayed.

Here is what I have.  What am I doing wrong?  When I attach to the
RootPanel, I get a blank rectangular square with nothing in it.
Inspection with Firebug also shows that the head and body elements are
empty.


public class TestFrameAndElement implements EntryPoint {

  public void onModuleLoad() {
Frame frame = new Frame();
Element html = DOM.createElement(html);
Element head = DOM.createElement(head);
Element body = DOM.createElement(body);
Element element = DOM.createElement(div);
element.setInnerHTML(spanhello/spanspan style=\color: blue;
\goodbye/span);
html.appendChild(head);
html.appendChild(body);
body.appendChild(element);
frame.getElement().appendChild(html);
RootPanel.get().add(frame);
System.out.println(Frame children:  +
frame.getElement().getChildCount());
System.out.println(HTML children :  +
frame.getElement().getChild(0).getChildCount());
System.out.println(HEAD children :  +
frame.getElement().getChild(0).getChild(0).getChildCount());
System.out.println(BODY children :  +
frame.getElement().getChild(0).getChild(1).getChildCount());
System.out.println(DIV  children :  +
frame.getElement().getChild(0).getChild(1).getChild(0).getChildCount());
  }
}

I've also noticed that if I do NOT add any elements, there is still an
html/head/body in the Frame section when I inspect with Firebug, but
in the code, the first sysout returns 0 and of course I have to
comment out the rest of the sysout statements.

How do I correctly work with this?

Thanks.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Celltable performance issue

2012-06-05 Thread kim young ill
check out the showcase  this:

https://developers.google.com/web-toolkit/doc/latest/DevGuideUiCellWidgets#data-provider



On Mon, Jun 4, 2012 at 1:23 PM, lucky lucky.begum...@gmail.com wrote:



 Could you please provide me the sample example for this?


  --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To view this discussion on the web visit
 https://groups.google.com/d/msg/google-web-toolkit/-/ubpiMGBB0FUJ.

 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Using the Frame class, and adding Elements to it directly - doesn't display?

2012-06-05 Thread Thomas Broyer
You're adding your elements as children of the frame, which is used as a 
fallback in case the browser does support frames. You should add them to the 
document that's displayed within the frame.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/RBDQBVG5qikJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: 3-tier architecture /gwt

2012-06-05 Thread Juan Pablo Gardella
Thanks Thomas, but is not what I need. I want to run with dev mode, the RPC
services for example. In the way that you say, is not dev mode. I will
investigate if exists a way to do this (only if I have all in one module)

Cheers,
Juan

2012/6/5 Juan Pablo Gardella gardellajuanpa...@gmail.com

 Thanks Thomas! I will try it


 2012/6/5 Thomas Broyer t.bro...@gmail.com

 I'm still looking for the best / most productive way to do it (see
 https://plus.google.com/113945685385052458154/posts/3VKPRDU2xZz) but you
 can simply “Run as… → Maven build…” on the server project, and select the
 jetty:start goal with a “dev” property (set to whatever value, “true” is
 fine); i.e. the exact equivalent to “cd *-server  mvn jetty:start -Ddev”.


 On Tuesday, June 5, 2012 3:23:18 AM UTC+2, Juan Pablo Gardella wrote:

 Hi,

 I have problems to run the project inside eclipse. I add this to the
 parent pom.xml:

 plugin
 groupIdorg.apache.maven.**plugins/groupId
  artifactIdmaven-eclipse-**plugin/artifactId
 version2.9/version
  configuration
 wtpmanifesttrue/**wtpmanifest
 wtpapplicationxmltrue/**wtpapplicationxml
  manifest${basedir}/src/main/**resources/META-INF/MANIFEST.MF
 /manifest
  projectNameTemplate
 [artifactId]
 /projectNameTemplate
  wtpversion2.0/wtpversion
 workspace${workspace.path}/**workspace
  downloadSourcestrue/**downloadSources
 /configuration
  /plugin

 So, the project is added as a dependency in the eclipse. With this I can
 run the *client* module, I change in shared project, refresh the
 browser and the changes happens. So I can remove in client module the part
 where use build-helper-maven-plugin to add sources. I don't know why, but
 in eclipse doesn't found this sources folder.

 The problem that I facing now is, how I can run the server code too
 inside eclipse? I want to click on Run - Web application and run in dev
 mode all modules to test server code too.

 If run server module fails because don't found entry module:
 Missing required argument 'module[s]'
 Google Web Toolkit 2.4.0
 DevMode [-noserver] [-port port-number | auto] [-whitelist
 whitelist-string] [-blacklist blacklist-string] [-logdir directory]
 [-logLevel level] [-gen dir] [-bindAddress host-name-or-address]
 [-codeServerPort port-number | auto] [-server servletContainerLauncher[:
 **args]] [-startupUrl url] [-war dir] [-deploy dir] [-extra dir]
 [-workDir dir] module[s]

 And if run client module fail because:

 [WARN] 404 - POST /app/greet (127.0.0.1) 1395 bytes

 And in my server module has:

 servlet-mapping
 servlet-namegreetServlet/**servlet-name
 url-pattern/app/greet/url-**pattern
   /servlet-mapping

 Can someone help me to run inside Eclipse?

  --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To view this discussion on the web visit
 https://groups.google.com/d/msg/google-web-toolkit/-/OqM05pUDwYMJ.

 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.




-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Setting focus on a Anchor button

2012-06-05 Thread Joseph Lust
Qrunk,

Anchor uses AnchorElement to set its focus, firing the *.focus()* method. 
The anchor tag http://www.w3schools.com/tags/tag_a.asp has a focus event 
which I was able to observer working in Chrome v19 just using the dev 
console.

What exactly are you expecting to see and what browser you're using it on? 
This issue might be that your browser has not implemented the focus event 
on the anchor element as this is not quite yet a standard behavior.


Sincerely,
Joseph

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/ZMqN1fXlDWQJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: 3-tier architecture /gwt

2012-06-05 Thread Thomas Broyer


On Wednesday, June 6, 2012 1:53:39 AM UTC+2, Juan Pablo Gardella wrote:

 Thanks Thomas, but is not what I need. I want to run with dev mode, the 
 RPC services for example. In the way that you say, is not dev mode. I will 
 investigate if exists a way to do this (only if I have all in one module)


The archetype is designed to run the server and client code separately, 
side-by-side: run the server code using mvn jetty:start -Ddev (or Eclipse 
WTP or Sonatype's M2Eclipse Webby) and run the client code in GWT DevMode 
in -noserver mode (or SuperDevMode).
BTW, SuperDevMode only hosts your client code, so this approach of running 
server and client separately is future-proof.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/L3I5ETtaZGAJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



create project component

2012-06-05 Thread thiago borges martins
How do I create a gwt project which are the components (jar) for a web
project?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: synchronized object int GWT

2012-06-05 Thread Ashton Thomas
You might want to consider the use of synchronized methods when dealing 
with async rpcs request. The blog post linked below shows one use case 
involving synchronized methods

http://www.summa-tech.com/blog/2010/11/29/parallel-asynchronous-calls-in-gwt/

http://www.bennorthrop.com/code/gwt-parallel-async/ParentCallback.java


On Thursday, May 24, 2012 4:22:28 PM UTC-4, Rand wrote:

 hello all 
 i am new in GWT ..and i have one question : 
 dose it enabled to apply the concept od synchronized objects java in 
 GWT ?? in way that i can synchronize the client and the server ? 

 thank

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/UTZfGv-_L2QJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: How to get default loading indicator for DataGrid

2012-06-05 Thread dayanandabv
Hi all,

The below code worked

private void setLoadingIndicator(DataGrid grid)
{
VerticalPanel vp = new VerticalPanel();
AbsolutePanel ap = new AbsolutePanel();
Image image = new Image(loadingboxes.gif);
HorizontalPanel hp = new HorizontalPanel();
AbsolutePanel ap1 = new AbsolutePanel();

ap1.setWidth(30px);
hp.add(ap1);
hp.add(image);

ap.setHeight(50px);
vp.add(ap);
vp.add(new Label(Searching Please wait...));
vp.add(hp);
vp.setSpacing(10);
grid.setLoadingIndicator(vp);
}

On Jun 5, 2:59 am, dayanandabv dayananda.veera...@hcl.com wrote:
 Hi all,

 How to get default loading indicator for DataGrid?
 Is Default blinking 3 boxes while loading data is animated image?

 I tried to use  Widget defaultWidget =  getLoadingIndicator();
 but it gives me null value.

 what i want is i need to show static text before the 3 boxes.

 i tried overriding setLoadingIndicator  but no help, any help
 regarding the same
 public void setLoadingIndicator()
         {
 //giving null value here
             Widget defaultWidget =  getLoadingIndicator();
             HorizontalPanel hp = new HorizontalPanel();

             hp.add(new Label(Please wait loading));
             hp.add(defaultWidget);
             super.setLoadingIndicator(hp);
         }

 Thanks in advance
 Daya

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: create project component

2012-06-05 Thread Andy Stevko
Not exactly sure what you are looking for but I'll give it a shot.
You may be looking for how to create a gwt module which can be referenced
by another gwt project.
Here is one way of creating a module which consists of a reusable widget.
http://davidmaddison.blogspot.com/2009/01/creating-gwt-component.html
One detail to be aware of - when you create a jar of the module, be sure to
include both the source and binary files.


On Tue, Jun 5, 2012 at 10:03 PM, thiago borges martins 
tborgesmart...@gmail.com wrote:

 How do I create a gwt project which are the components (jar) for a web
 project?

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.




-- 
-- A. Stevko
===
If everything seems under control, you're just not going fast enough. M.
Andretti

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



[gwt-contrib] Re: Add Map support to RequestFactory (issue 6132056)

2012-06-05 Thread james . horsley

Based on the email thread with Alexis and Thomas I've fixed the handling
of nested entities along with adding the appropriate tests to verify the
behaviour. To retrieve nested entities in a Map using .with() the syntax
is theMap.keys.nestedProp and theMap.values.nestedProp.

http://codereview.appspot.com/6132056/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Move Super Dev Mode to the open source repository. (issue1727804)

2012-06-05 Thread t . broyer

Most of my comments should be seen as TODOs, as I really don't want to
delay landing: this is highly experimental anyway, and we know it'll
need some more work.


http://gwt-code-reviews.appspot.com/1727804/diff/1/dev/codeserver/java/com/google/gwt/dev/codeserver/AppSpace.java
File dev/codeserver/java/com/google/gwt/dev/codeserver/AppSpace.java
(right):

http://gwt-code-reviews.appspot.com/1727804/diff/1/dev/codeserver/java/com/google/gwt/dev/codeserver/AppSpace.java#newcode2
dev/codeserver/java/com/google/gwt/dev/codeserver/AppSpace.java:2: *
Copyright 2011 Google Inc.
2012 ?

http://gwt-code-reviews.appspot.com/1727804/diff/1/dev/codeserver/java/com/google/gwt/dev/codeserver/ModuleState.java
File dev/codeserver/java/com/google/gwt/dev/codeserver/ModuleState.java
(right):

http://gwt-code-reviews.appspot.com/1727804/diff/1/dev/codeserver/java/com/google/gwt/dev/codeserver/ModuleState.java#newcode49
dev/codeserver/java/com/google/gwt/dev/codeserver/ModuleState.java:49:
defaultProps.put(user.agent, safari);
This is just a default for the very first compilation, right?
(but hard-coding things that way will prevent detecting the right
permutation later on, no?)

http://gwt-code-reviews.appspot.com/1727804/diff/1/dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java
File dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java
(right):

http://gwt-code-reviews.appspot.com/1727804/diff/1/dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java#newcode134
dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java:134:
private class SourceFlag extends ArgHandler {
Why not use ArgHandlerDir?

http://gwt-code-reviews.appspot.com/1727804/diff/1/dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java#newcode148
dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java:148:
return The root of a directory tree containing GWT source code to
compile.;
Does this mean SuperDevMode no longer loads sources from the classpath?

http://gwt-code-reviews.appspot.com/1727804/diff/1/dev/codeserver/java/com/google/gwt/dev/codeserver/WebServer.java
File dev/codeserver/java/com/google/gwt/dev/codeserver/WebServer.java
(right):

http://gwt-code-reviews.appspot.com/1727804/diff/1/dev/codeserver/java/com/google/gwt/dev/codeserver/WebServer.java#newcode164
dev/codeserver/java/com/google/gwt/dev/codeserver/WebServer.java:164: //
This is a GET because a bookmarklet can call it from a different origin
(JSONP).
We should probably use CORS and XMLHttpRequest with a POST request,
instead of JSON-P. The bookmarklet could handle XDomainRequest for IE8/9
and even possibly create an HTML form if we want to support IE6/7.

White-listing origins from command-line arguments would also add some
security.

http://gwt-code-reviews.appspot.com/1727804/diff/1/dev/codeserver/java/com/google/gwt/dev/codeserver/WebServer.java#newcode456
dev/codeserver/java/com/google/gwt/dev/codeserver/WebServer.java:456:
private static String escapeHtmlCharacters(String line) {
Couldn't we use SafeHtml.fromString() here?

http://gwt-code-reviews.appspot.com/1727804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Add GWT CSS compiler support for RTL flipping of many CSS3 properties (border-image, border-radi... (issue1727803)

2012-06-05 Thread t . broyer


http://gwt-code-reviews.appspot.com/1727803/diff/1/user/src/com/google/gwt/resources/css/RtlVisitor.java
File user/src/com/google/gwt/resources/css/RtlVisitor.java (right):

http://gwt-code-reviews.appspot.com/1727803/diff/1/user/src/com/google/gwt/resources/css/RtlVisitor.java#newcode43
user/src/com/google/gwt/resources/css/RtlVisitor.java:43: // TODO: These
could be moved to somewhere common before submitting.
Into CssProperty maybe?

http://gwt-code-reviews.appspot.com/1727803/diff/1/user/src/com/google/gwt/resources/css/RtlVisitor.java#newcode44
user/src/com/google/gwt/resources/css/RtlVisitor.java:44: // TODO: Can
GWT use Guava libraries? This would be much easier with
gwt-dev.jar bundles Guava, so you can use Guava from generators.

http://gwt-code-reviews.appspot.com/1727803/diff/1/user/src/com/google/gwt/resources/css/RtlVisitor.java#newcode204
user/src/com/google/gwt/resources/css/RtlVisitor.java:204:
swapFour(values);
Maybe rename swapFour to swapFourBorders?

http://gwt-code-reviews.appspot.com/1727803/diff/1/user/src/com/google/gwt/resources/css/RtlVisitor.java#newcode370
user/src/com/google/gwt/resources/css/RtlVisitor.java:370: if
(parts.length  2  .equals(parts[0])
How about transforming the property name before splitting it?
(also, we could fix the locale-sensitive toLowerCase)

name = name.toLowerCase(Locale.ENGLISH);
if (name.charAt(0) == '-') {
  int nextHyphen = name.indexOf('-', 1);
  if (nextHyphen  0) {
String prefix = name.substring(1, nextHyphen);
if (VENDOR_PREFIXES.contains(prefix)) {
  name = name.substring(nextHyphen + 1);
}
  }
}
String[] parts = name.split(-);


Alternatively, we could loop over the known prefixes (with
VENDOR_PREFIXES containing the -webkit-, -o-, etc.):
name = name.toLowerCase(Locale.ENGLISH);
if (name.charAt(0) == '-') {
   for (String prefix : VENDOR_PREFIXES) {
  if (name.startsWith(prefix)) {
 name = name.substring(prefix.length());
 break;
  }
   }
}
String[] parts = name.split(-);

http://gwt-code-reviews.appspot.com/1727803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Move Super Dev Mode to the open source repository. (issue1727804)

2012-06-05 Thread cromwellian


http://gwt-code-reviews.appspot.com/1727804/diff/1/dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java
File dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java
(right):

http://gwt-code-reviews.appspot.com/1727804/diff/1/dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java#newcode148
dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java:148:
return The root of a directory tree containing GWT source code to
compile.;
On 2012/06/05 10:52:58, tbroyer wrote:

Does this mean SuperDevMode no longer loads sources from the

classpath?

It picks up from the classpath, but this directory shadows the
classpath. The reason is, at least for Google, we always produce
source-jars in our internal build system, and you can't 'edit' them.
That is, when we launch superdevmode, it has the source, but it's been
compiled and put into jars on the CP. This directory allows us to
specify another location to look at, in addition to the classpath (which
is the fallback)

For external users, it may not be needed, although I could see if
superdevmode is launched from a Maven build you might run into the same
issue.

http://gwt-code-reviews.appspot.com/1727804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: MeniItem should use ScheduledCommand instead of Command (issue1698803)

2012-06-05 Thread rchandia

On 2012/06/05 01:09:12, Patrick Tucker wrote:

Is this acceptable, or should I modify the patch?


I think the change in this patch is good. What is needed is for this
patch to also modify
tools/api-checker/config/gwt24_25userApi.conf
to allow the API change.



http://gwt-code-reviews.appspot.com/1698803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] VerticalSplitPanel should not use DeferredCommand (issue1730803)

2012-06-05 Thread rchandia

Reviewers: rdayal,

Description:
VerticalSplitPanel should not use DeferredCommand

Repost of issue 1725803
Thanks Patrick!


Please review this at http://gwt-code-reviews.appspot.com/1730803/

Affected files:
  M user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java


Index: user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java
===
--- user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java	 
(revision 10982)
+++ user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java	(working  
copy)

@@ -16,13 +16,13 @@
 package com.google.gwt.user.client.ui;

 import com.google.gwt.core.client.GWT;
+import com.google.gwt.core.client.Scheduler;
+import com.google.gwt.core.client.Scheduler.ScheduledCommand;
 import com.google.gwt.dom.client.Style.TextAlign;
 import com.google.gwt.resources.client.ClientBundle;
 import com.google.gwt.resources.client.ImageResource;
 import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
-import com.google.gwt.user.client.Command;
 import com.google.gwt.user.client.DOM;
-import com.google.gwt.user.client.DeferredCommand;
 import com.google.gwt.user.client.Element;
 import com.google.gwt.user.client.Timer;

@@ -399,7 +399,7 @@
  * This first call is simply to try to avoid a jitter effect if  
possible.

  */
 setSplitPosition(lastSplitPosition);
-DeferredCommand.addCommand(new Command() {
+Scheduler.get().scheduleDeferred(new ScheduledCommand() {
   public void execute() {
 setSplitPosition(lastSplitPosition);
   }


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: VerticalSplitPanel should not use DeferredCommand (issue1725803)

2012-06-05 Thread rchandia

LGTM.
Reposting at http://gwt-code-reviews.appspot.com/1730803

http://gwt-code-reviews.appspot.com/1725803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: VerticalSplitPanel should not use DeferredCommand (issue1730803)

2012-06-05 Thread rchandia

Submitted as r11013

http://gwt-code-reviews.appspot.com/1730803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: VerticalSplitPanel should not use DeferredCommand (issue1725803)

2012-06-05 Thread rchandia

Submitted as r11013

http://gwt-code-reviews.appspot.com/1725803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] WindowImplIE should use ScheduledCommand instead of Command (issue1725805)

2012-06-05 Thread rchandia

Reviewers: rdayal,

Description:
WindowImplIE should use ScheduledCommand instead of Command

Repost of 1697803
Thanks Patrick!


Please review this at http://gwt-code-reviews.appspot.com/1725805/

Affected files:
  M user/src/com/google/gwt/user/client/impl/WindowImplIE.java


Index: user/src/com/google/gwt/user/client/impl/WindowImplIE.java
===
--- user/src/com/google/gwt/user/client/impl/WindowImplIE.java	(revision  
11013)
+++ user/src/com/google/gwt/user/client/impl/WindowImplIE.java	(working  
copy)

@@ -16,11 +16,11 @@
 package com.google.gwt.user.client.impl;

 import com.google.gwt.core.client.GWT;
+import com.google.gwt.core.client.Scheduler.ScheduledCommand;
 import com.google.gwt.dom.client.Document;
 import com.google.gwt.dom.client.ScriptElement;
 import com.google.gwt.resources.client.ClientBundle;
 import com.google.gwt.resources.client.TextResource;
-import com.google.gwt.user.client.Command;

 /**
  * IE implementation of {@link com.google.gwt.user.client.impl.WindowImpl}.
@@ -82,7 +82,7 @@
   @Override
   public void initWindowCloseHandler() {
 initHandler(Resources.INSTANCE.initWindowCloseHandler().getText(),
-new Command() {
+new ScheduledCommand() {
   public void execute() {
 initWindowCloseHandlerImpl();
   }
@@ -92,7 +92,7 @@
   @Override
   public void initWindowResizeHandler() {
 initHandler(Resources.INSTANCE.initWindowResizeHandler().getText(),
-new Command() {
+new ScheduledCommand() {
   public void execute() {
 initWindowResizeHandlerImpl();
   }
@@ -102,7 +102,7 @@
   @Override
   public void initWindowScrollHandler() {
 initHandler(Resources.INSTANCE.initWindowScrollHandler().getText(),
-new Command() {
+new ScheduledCommand() {
   public void execute() {
 initWindowScrollHandlerImpl();
   }
@@ -117,7 +117,7 @@
* @param initFunc the string representation of the init function
* @param cmd the command to execute the init function
*/
-  private void initHandler(String initFunc, Command cmd) {
+  private void initHandler(String initFunc, ScheduledCommand cmd) {
 if (GWT.isClient()) {
   // Embed the init script on the page
   ScriptElement scriptElem =  
Document.get().createScriptElement(initFunc);



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: WindowImplIE should use ScheduledCommand instead of Command (issue1697803)

2012-06-05 Thread rchandia

LGTM
Repost at http://gwt-code-reviews.appspot.com/1725805

http://gwt-code-reviews.appspot.com/1697803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: WindowImplIE should use ScheduledCommand instead of Command (issue1697803)

2012-06-05 Thread rchandia

Submitted as r11014

http://gwt-code-reviews.appspot.com/1697803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: WindowImplIE should use ScheduledCommand instead of Command (issue1725805)

2012-06-05 Thread rchandia

Submitted as r11014

http://gwt-code-reviews.appspot.com/1725805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Move Super Dev Mode to the open source repository. (issue1727804)

2012-06-05 Thread skybrian

http://gwt-code-reviews.appspot.com/1727804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Add clear support to Style (issue1731803)

2012-06-05 Thread rchandia

Reviewers: rdayal,

Description:
Add clear support to Style

Repost of 1720803
Thanks Patrick!


Please review this at http://gwt-code-reviews.appspot.com/1731803/

Affected files:
  M user/src/com/google/gwt/dom/client/Style.java
  M user/src/com/google/gwt/safecss/shared/SafeStylesBuilder.java
  M user/src/com/google/gwt/safecss/shared/SafeStylesUtils.java
  M user/test/com/google/gwt/dom/client/StyleTest.java
  M user/test/com/google/gwt/safecss/shared/GwtSafeStylesUtilsTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Add clear support to Style (issue1720803)

2012-06-05 Thread rchandia

Submitted as r11015

http://gwt-code-reviews.appspot.com/1720803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Add clear support to Style (issue1731803)

2012-06-05 Thread rchandia

Submitted as r11015

http://gwt-code-reviews.appspot.com/1731803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Checkstyle fixes (issue1565806)

2012-06-05 Thread rchandia


http://gwt-code-reviews.appspot.com/1565806/diff/1/user/test/com/google/gwt/editor/client/DirtyEditorTest.java
File user/test/com/google/gwt/editor/client/DirtyEditorTest.java
(right):

http://gwt-code-reviews.appspot.com/1565806/diff/1/user/test/com/google/gwt/editor/client/DirtyEditorTest.java#newcode11
user/test/com/google/gwt/editor/client/DirtyEditorTest.java:11: * or
implied. See the License for the specific language governing permissions
and limitations under
Please keep the license header as it was before.

http://gwt-code-reviews.appspot.com/1565806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Add javadocs for ExternalTextResource.getText, fixes #7035 (issue1605803)

2012-06-05 Thread rchandia


http://gwt-code-reviews.appspot.com/1605803/diff/1/user/src/com/google/gwt/resources/client/ExternalTextResource.java
File user/src/com/google/gwt/resources/client/ExternalTextResource.java
(right):

http://gwt-code-reviews.appspot.com/1605803/diff/1/user/src/com/google/gwt/resources/client/ExternalTextResource.java#newcode23
user/src/com/google/gwt/resources/client/ExternalTextResource.java:23: *
initialization.
On 2011/12/01 03:00:25, stephenh wrote:

I didn't change the license/javadocs, but just formatted the file with

the

Eclipse formatter settings. I can undo that if needed.


Yes, please. The license in particular should stay as it was before.

http://gwt-code-reviews.appspot.com/1605803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: MeniItem should use ScheduledCommand instead of Command (issue1698803)

2012-06-05 Thread tuckerpmt

On 2012/06/05 17:58:08, rchandia wrote:

On 2012/06/05 01:09:12, Patrick Tucker wrote:
 Is this acceptable, or should I modify the patch?



I think the change in this patch is good. What is needed is for this

patch to

also modify
tools/api-checker/config/gwt24_25userApi.conf
to allow the API change.


Are these changes considered OVERRIDABLE_METHOD_ARGUMENT_TYPE_CHANGE?

Is there a tutorial or something like that to explain how this file
works?

http://gwt-code-reviews.appspot.com/1698803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors