Re: Exception reporting is broken in GWT: would you support a kickstarter project to fix it?
On Thursday, May 23, 2013 11:11:22 PM UTC+2, Alex Epshteyn wrote: Hi Thomas, Thanks for chiming in and providing the extra info. Good to know. I'd like to ask, however, the reasons for planning to remove support for IE6/7/8? Why would we do that? It's already there and doesn't require too much maintenance. Have a look at the I/O talk: http://youtu.be/Ul-LbfkJ-tw?t=10m20s As of today, nearly 8% of my site's visitors are on IE8 and close to 1% are still on IE7. These are pretty big numbers for a high traffic website, and would translate into lost revenue if the browsers weren't supported. I can't imagine Google pulling support for a browser with that kind of usage for one of its products. . Here's the full data: https://docs.google.com/spreadsheet/ccc?key=0AvMlWdpkpAA6dGdpa3lsZTVQWl9qcFJrWmZCZ0ZZb0E#gid=0 Also, as you guys can see from the data, stack emulation is still required for 54% of my site's traffic. While I'd like to see users upgrading to the latest browsers as much as any developer, let's be realistic: WinXP is not going away any time soon (Microsoft dropping support for it isn't going to make people like my dad go out and buy a new computer). Google Analytics is shows that 80% of my users are on Windows and 21% of those are still on Windows XP: that is a very big number! There are many other browsers available on Windows XP, and you should tell your dad that by continuing using an unsupported browser, his computer is at risk. See also http://www.troyhunt.com/2013/01/the-impending-crisis-that-is-windows-xp.html -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: How to override gwt styles in uibinder?
On Friday, May 24, 2013 3:52:54 AM UTC+2, V.B. wrote: Hi Thomas, In your post above you mention @external .gwt-*;. You also use the same trick in thishttp://stackoverflow.com/questions/8182917/how-to-override-default-css-in-modern-gwt-applications StackOverflow question. But, I have never been able to make that work. Instead I have to have @external for every gwt type that I need to override, which is quite a hassle. (Note: in your post above you don't have the leading period. I have tried it both ways just to be sure.) When I try to use @external .gwt-*; I get errors of this flavor: [ERROR] Line 69: The annotation @CssResource.ClassName is disallowed for this location [ERROR] Line 70: Syntax error on token *, delete this token The generated lines in question look like this: @ClassName(gwt-*) String gwt*(); Am I doing something wrong? You're using InterfaceGenerator (to me, it's a one shot tool to help in migrating to CssResource, not something to use as part of your build process) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Exception reporting is broken in GWT: would you support a kickstarter project to fix it?
There are many other browsers available on Windows XP, and you should tell your dad that by continuing using an unsupported browser, his computer is at risk. See also http://www.troyhunt.com/2013/01/the-impending-crisis-that-is-windows-xp.html Hehe, I like the IE7 tax idea mentioned on that site :) -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: IE9 problem with GWT
Have played with the z-index property? On Tue, May 21, 2013 at 4:00 PM, Honza Rames rame...@gmail.com wrote: If you display the message in DialogBox (or PopupPanel), are you displaying glass to darken the window? If so doesn't the glass overlap your message? It could be a problem of layouting, are you using multiple z-orders in your app? These issues should be easy to figure out in developer tools that are present in IE9. Honza On Tuesday, May 21, 2013 12:48:41 PM UTC+2, Mike wrote: GWT Release: 2.5.0 Browser: IE9 Our clients have a problem using our web application because, on IE9, when the application shows a message (i.e., to confirm if a file is uploaded or not), the focus remains behind the message shown and it is impossible to interact with the message, so you can't close it and you can't work with the application either. It is not a problem of the application code, it is a problem of the version 9 of IE, it does not happen with IE 10. The message shown is modal. I know it is an alternative using Mozilla or Google Chrome, but our client is a little bit special, so he does not want to use other web browsers. Any idea? Has this problem happened to someone else? P.D.: Sorry if there is any mistake in the grammar or in some word. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- El precio es lo que pagas. El valor es lo que recibes. Warren Buffet -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: java arrays in JSNI
Like explained in http://stackoverflow.com/a/6130473/1666829 you can call:
public static final native void trigger(String eventName, JsArray
params)/*-{
$wnd.mylib.trigger.apply(this, [eventName].concat(params)) ;
}-*/;
Pay attention to the second parameter which is a JsArray. You can convert
it in e seperate method.
Am Dienstag, 15. Mai 2012 18:54:03 UTC+2 schrieb Sebastián Gurin:
Hi all. I'm trying to create a java API for a JavaScript function that can
accept variable number of parameters, for ex. trigger(eventName, param1,
param2, ...).
In java the desired java method signature, do not need to use java
varargs, could be simple something like this:
public static final native void trigger(String eventName, Object[]
params)/*-{
///$wnd.mylib.trigger(eventName, )
}-*/;
The thing is that the params array elements can be of any and mixed types.
Could be POJOS or JavaScriptObject or java.lang.Integer.
My problem with this is that I don't know how to create a JsArray or a
native JavaScript array and put all the elements of parameter
object[]params.
I tried doing this in java using a JsArray and JsArrayMixed but elements
must be casted to JavaScriptObject, and when doing so I get a
java.lang.Object cannot cast to com...JavaScriptObject exception. This
happens when trying to push an element into the jsarray: it need to be
casted for java compiler: jsArray1.push((JavaScriptObject) myJavaArray[i]);
I also tried doing it in jsni javascript code, but I don't know how to
access java arrays for obtaining its elements. The documentation says that
from javascript java arrays are opaque objects. It also says :
Although Java arrays are not directly usable in JavaScript, there are
some helper classes that efficiently achieve a similar effect:
JsArray,. These classes are wrappers around a native JavaScript array.
But I think in my case, if I need to access a java array with java objects
these classes have not use... ?
I think I'm missing something here... IMHO it is a common javascript
technic defining functions with variable parameters ,and it sould be
available to work with these from java using GWT JSNI. -
Any suggestion is mmost appreciated. Thanks in advance.
--
Sebastian Gurin sgu...@softpoint.org javascript:
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
RequestFactory Session timeout
Hello,
i'm having a problem when using RequestFactory and resetting the session
timeout.
Here is what i have:
- GWT + GWTP Projekt
- A separate GWT Projekt for RequestFactory Service
- All running on JBoss 6.1.0 Final
- I'm also using JAAS and SSO Valve (didn't get it to work without SSO, i
think its needed because i'm using multiple gwt projects)
In the entry point method of my main project im doing this:
*ginjector.getRequestFactory().initialize(ginjector.getEventBus(), new
DelegatingRequestTransport());*
DelegationRequestTransport is a class in my requestFactory service project:
*public class DelegatingRequestTransport extends DefaultRequestTransport {
public static final String REQUEST_PATH =
/myRequestFactoryProject/gwtRequest;
public DelegatingRequestTransport() {
String host = Window.Location.getHost();
String prot = Window.Location.getProtocol();
super.setRequestUrl(prot + // + host + REQUEST_PATH);
}
}*
I have one JSESSIONID cookie, a JSESSIONIDSSO cookie and the xsrf security
cookie.
All cookies are sent on a gwt rpc call, but when using requestfactory
JSESSIONID is missing.
I also tried to set the cookie path for session cookie in the web.xml on
main project to root /.
Now the JSESSIONID cookie is sent when using requestfactory, but the
session timeout is not reset.
How is the session managed on JBoss? I think there is a sessionManager in
the jboss web-server. But how
is a cookie identified, just with the id or also with cookie path?
The SSO cookie is just needed to transfer principal information right?
JSESSIONID is for session information for
every webapp, when one webapp times out, you also have to relogin for the
other webapps?
So how do i reset the session timeout for my main project when using a
separate gwt project with requestFactory?
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Printing
If somebody want to use it change call element.toString() to
+ element.getTagName() + + element.getInnerHTML() + / +
element.getTagName() +
Other way it won't work after compilation.
On Monday, January 15, 2007 6:35:55 PM UTC+4, Freller wrote:
Following the thread about printing at
http://groups-beta.google.com/group/Google-Web-Toolkit/browse_frm/thread/53624cb05aa85624/247e890d73a76948?lnk=gstq=printrnum=2#247e890d73a76948
I created a simple class that can print any HTML, DOM.Element or Widget
without opening a new window.
Regards,
Freller
/**
* pre
* Generic printing class
* can be used to print the Window it self, DOM.Elements, UIObjects
(Widgets) and plain HTML
*
* Usage:
* You must insert this iframe in your host page:
* iframe id=__printingFrame
style=width:0;height:0;border:0/iframe
*
* Window:
* Print.it();
*
* Objects/HTML:
* Print.it(RootPanel.get(myId));
*
Print.it(DOM.getElementById(myId));
* Print.it(Just bPrint.it()/b!);
*
* Objects/HTML using styles:
* Print.it(link rel='StyleSheet' type='text/css'
media='paper' href='/paperStyle.css', RootPanel.get('myId'));
* Print.it(style type='text/css' media='paper' .newPage {
page-break-after: always; } /style,
*
Hip class='newPage'/pBy);
* /pre
*/
package org.gwtcommons.user.client;
import com.google.gwt.user.client.Element;
import com.google.gwt.user.client.ui.UIObject;
public class Print {
public static native void it() /*-{
$wnd.print();
}-*/;
public static native void it(String html) /*-{
var frame = $doc.getElementById('__printingFrame');
if (!frame) {
$wnd.alert(Error: Can't find printing frame.);
return;
}
frame = frame.contentWindow;
var doc = frame.document;
doc.open();
doc.write(html);
doc.close();
frame.focus();
frame.print();
}-*/;
public static void it(UIObject obj) {
it(, obj.getElement().toString());
}
public static void it(Element element) {
it(, element.toString());
}
public static void it(String style, String it) {
it(itheader+style+/headerbody+it+/body/it);
}
public static void it(String style, UIObject obj) {
it(style, obj.getElement().toString());
}
public static void it(String style, Element element) {
it(style, element.toString ());
}
} // end of class Print
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
How do I call the service maps this servlet through url?
Hi! Does anyone know if you can do so using GWT? thanks (: -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Static dependency Injection vs Direct deferred binding
Hi every,
Recently I am working on a i18n project in which I created some utility
class to provide localized content like the following:
public class Foo {
@Inject
private static MyConstantsWithLookup constants;
public static String getLocalizedContent(String rawContent) {
return constants.getString(rawContent);
}
}
Where MyConstantsWithLookup is an interface extending ConstantsWithLookup.
And I have the following in my GinModule:
requestStaticInjection(Foo.class);
@Provides
@Singleton
public MyConstantsWithLookup getMyConstantsWithLookup() {
MyConstantsWithLookup constants =
GWT.create(MyConstantsWithLookup.class);
return constants;
}
However, my teammate doesn't agree my use of @Inject here, he argued that I
should use GWT.create(MyConstantsWithLookup.class) in Foo directly so
MyConstantsWithLookup can be resolved in compile time and got certain
optimizations from deferred binding, instead of letting it be handled in
runtime by Gin. He also said it's generally undesired to do static
injection. But I do like the brevity of @inject and MyConstantsWithLookup
is not something I usually need to mock out. So I wonder what are the exact
pros and cons here? Thanks a lot!
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Static dependency Injection vs Direct deferred binding
There's no runtime overhead from using Gin, actually Gin does exactly what's your teammate is telling you to do, read here: https://code.google.com/p/google-gin/wiki/GinTutorial#Gin_Magic;https://code.google.com/p/google-gin/wiki/GinTutorial#Gin_ https://code.google.com/p/google-gin/wiki/GinFaq#Does_GIN_have_runtime_overhead? Also, you don't have to added any configurations for things such as Constants and RPC interfaces, because will automate the deferred binding. You just need to inject them when you need to use them. This is also explained in the links above. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Spring Security and Google App Engine
Found the solution from Huseyin OZVEREN: Simply replace .html files to .jsp Refer to: http://www.javablog.fr/springgwtgae-spring-security-on-google-cloud-jetty-tomcat.html#comment-165 For full description of solution -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
John Ahlroos has posted comments on this change.
Change subject: Use JSON.parse() instead of eval() to deserialize rpc
callback payload
..
Patch Set 3:
(2 comments)
File user/src/com/google/gwt/core/client/JsonUtils.java
Line 129: public static native boolean hasJsonParse() /*-{
I am too neutral on this, if JSONParser is already using it though JSNI
then the ClientSerializationStreamWriter could do it as well and there
would be no need to open this up.
File
user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java
Line 57: if(!JsonUtils.hasJsonParse() ||
encoded.contains(].concat([)){
Wouldn't passing everything though JSON.parse() yield an unnecessary
performance hit in cases where we know .concat/NaN/Infity has been used and
the JSON.parse() will throw the exception?
The version should be easily enough deducible from the encoded string and
using that we could then simply do:
if(version 8){
eval()
} else {
try{
JSONUtils.safeEval()
} catch(IllegalArgumentException iae){
throw new IncompatibleRemoteServiceException(Expected valid
JSON, got something else.);
}
}
--
To view, visit https://gwt-review.googlesource.com/2900
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos j...@vaadin.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Colin Alworth niloc...@gmail.com
Gerrit-Reviewer: John Ahlroos j...@vaadin.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: RequestFactory: Enabling support for interfaces in @ProxyFor.
Manuel Carrasco Moñino has uploaded a new change for review.
https://gwt-review.googlesource.com/2961
Change subject: RequestFactory: Enabling support for interfaces in
@ProxyFor.
..
RequestFactory: Enabling support for interfaces in @ProxyFor.
Fixes issues #7509 and #5762.
Patch moved from rietveld (http://gwt-code-reviews.appspot.com/1764804/)
RequestFactory should allow that client-proxies point to interfaces in
server side, facilitating different implementations of the object.
This feature allows as well that we could reuse proxy interfaces in both
sides, what reduces the code and allows to use the same value class in both
sides, example:
@ProxyFor(value = A.class, locator = ALocator.class)
public interface A {
String getSomething();
void setSomething(String s);
}
public class ALocator extends LocatorA, String {
@Override
public A create(Class? extends A clazz) {
return new AImpl();
}
}
public class AImpl implements A {
String getSomething(){return null}
void setSomething(String s){}
}
Change-Id: I273ed2c403b275f4c9bec2b7e7ba72a3d05930b9
---
M requestfactory/build.xml
M
user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java
M
user/test/com/google/web/bindery/requestfactory/gwt/RequestFactorySuite.java
A
user/test/com/google/web/bindery/requestfactory/gwt/client/ProxyForInterfacesTest.java
A
user/test/com/google/web/bindery/requestfactory/server/ProxyForInterfacesJreTest.java
M
user/test/com/google/web/bindery/requestfactory/vm/RequestFactoryJreSuite.java
6 files changed, 214 insertions(+), 15 deletions(-)
diff --git a/requestfactory/build.xml b/requestfactory/build.xml
index 9215bfe..25414ea 100755
--- a/requestfactory/build.xml
+++ b/requestfactory/build.xml
@@ -119,6 +119,7 @@
arg path=${gwt.build.lib}/requestfactory-test-validated.jar /
arg
value=com.google.web.bindery.requestfactory.gwt.client.RequestFactoryChainedContextTest.Factory
/
arg
value=com.google.web.bindery.requestfactory.gwt.client.RequestFactoryPolymorphicTest.Factory
/
+ arg
value=com.google.web.bindery.requestfactory.gwt.client.ProxyForInterfacesTest.Factory
/
arg
value=com.google.web.bindery.requestfactory.shared.BoxesAndPrimitivesTest.Factory
/
arg
value=com.google.web.bindery.requestfactory.shared.ComplexKeysTest.Factory
/
arg
value=com.google.web.bindery.requestfactory.shared.LocatorTest.Factory /
diff --git
a/user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java
b/user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java
index 43b1b82..ac5a09a 100644
---
a/user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java
+++
b/user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java
@@ -74,23 +74,12 @@
if (TypeUtils.isValueType(domainClass)) {
return domainClass.asSubclass(clientClass);
}
-Class? toSearch = domainClass;
-while (toSearch != null) {
- ListString clientTypes =
deobfuscator.getClientProxies(toSearch.getName());
- if (clientTypes != null) {
-for (String clientType : clientTypes) {
- Class? proxy = forName(clientType);
- if (clientClass.isAssignableFrom(proxy)) {
-return proxy.asSubclass(clientClass);
- }
-}
- }
- toSearch = toSearch.getSuperclass();
-}
-if (required) {
+
+Class? extends T ret = resolveClientType(domainClass, clientClass);
+if (ret == null required) {
die(null, The domain type %s cannot be sent to the client,
domainClass.getCanonicalName());
}
-return null;
+return ret;
}
@Override
@@ -257,4 +246,29 @@
}
return params.toArray(new Class?[params.size()]);
}
+
+ private T Class? extends T resolveClientType(Class? domainClass,
ClassT clientClass) {
+if (domainClass == null) {
+ return null;
+}
+
+ListString clientTypes =
deobfuscator.getClientProxies(domainClass.getName());
+if (clientTypes != null) {
+ for (String clientType : clientTypes) {
+Class? proxy = forName(clientType);
+if (clientClass.isAssignableFrom(proxy)) {
+ return proxy.asSubclass(clientClass);
+}
+ }
+}
+
+for (Class? toSearch : domainClass.getInterfaces()) {
+ Class? extends T ret = resolveClientType(toSearch, clientClass);
+ if (ret != null) {
+return ret;
+ }
+}
+
+return resolveClientType(domainClass.getSuperclass(), clientClass);
+ }
}
diff --git
a/user/test/com/google/web/bindery/requestfactory/gwt/RequestFactorySuite.java
b/user/test/com/google/web/bindery/requestfactory/gwt/RequestFactorySuite.java
index 0d4db18..ae45216 100644
---
a/user/test/com/google/web/bindery/requestfactory/gwt/RequestFactorySuite.java
+++
[gwt-contrib] Change in gwt[master]: RequestFactory: Enabling support for interfaces in @ProxyFor.
Manuel Carrasco Moñino has uploaded a new patch set (#2).
Change subject: RequestFactory: Enabling support for interfaces in
@ProxyFor.
..
RequestFactory: Enabling support for interfaces in @ProxyFor.
Fixes issues #7509 and #5762.
Patch moved from rietveld (http://gwt-code-reviews.appspot.com/1764804/)
RequestFactory should allow that client-proxies point to interfaces in
server side, facilitating different implementations of the object.
This feature allows as well that we could reuse proxy interfaces in both
sides, what reduces the code and allows to use the same value class in both
sides, example:
@ProxyFor(value = A.class, locator = ALocator.class)
public interface A {
String getSomething();
void setSomething(String s);
}
public class ALocator extends LocatorA, String {
@Override
public A create(Class? extends A clazz) {
return new AImpl();
}
}
public class AImpl implements A {
String getSomething(){return null}
void setSomething(String s){}
}
Change-Id: I273ed2c403b275f4c9bec2b7e7ba72a3d05930b9
---
M requestfactory/build.xml
M
user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java
M
user/test/com/google/web/bindery/requestfactory/gwt/RequestFactorySuite.java
A
user/test/com/google/web/bindery/requestfactory/gwt/client/ProxyForInterfacesTest.java
A
user/test/com/google/web/bindery/requestfactory/server/ProxyForInterfacesJreTest.java
M
user/test/com/google/web/bindery/requestfactory/vm/RequestFactoryJreSuite.java
6 files changed, 214 insertions(+), 15 deletions(-)
--
To view, visit https://gwt-review.googlesource.com/2961
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I273ed2c403b275f4c9bec2b7e7ba72a3d05930b9
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Manuel Carrasco Moñino manuel.carrasc...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Trouble with gwt push (contributor agreement)
Hi, I update Books section on gwtproject.org and I would like to send updates to Gerrit for review. I Sign Electronically cont. agreement (by filling the form). Should I do something alse? Thank you. Regards, Matic -- -- git push origin HEAD:refs/for/master Username for 'https://gwt.googlesource.com': git-maticpetek.gmail.com Password for 'https://git-maticpetek.gmail@gwt.googlesource.com': fatal: remote error: Individual contributor agreement requires current contact information. Please review your contact information: https://gwt-review.googlesource.com/#/settings/contact -- -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. attachment: agreement.png
[gwt-contrib] Change in gwt[master]: Removed unnecessary whitespace in JSONObject.toString.
Manuel Carrasco Moñino has posted comments on this change. Change subject: Removed unnecessary whitespace in JSONObject.toString. .. Patch Set 2: Code-Review+1 LGTM -- To view, visit https://gwt-review.googlesource.com/2430 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie87abe91c1bcc57285a6d749d3a2dd6081daaa9a Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Cut circular dependency between c.g.g.core.linker and c.g.g....
Manuel Carrasco Moñino has posted comments on this change. Change subject: Cut circular dependency between c.g.g.core.linker and c.g.g.dev.js .. Patch Set 1: Code-Review+1 (2 comments) LGTM File dev/core/src/com/google/gwt/util/tools/shared/StringUtils.java Line 81: escape = 'n'; It is a matter not related with this commit, but shouldn't be an optimization if we replace '\n with ; instead of \\n so as we save some bytes in final JS? We should consider edge cases like ',\n' in js objects, etc, though Line 109: * I think code-style has been relaxed, but spaces at the end of the line should be removed, right? -- To view, visit https://gwt-review.googlesource.com/1031 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id33cdf94725981c9c5779553444c1ac64659892c Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Cut circular dependency between c.g.g.core.linker and c.g.g....
Thomas Broyer has posted comments on this change. Change subject: Cut circular dependency between c.g.g.core.linker and c.g.g.dev.js .. Patch Set 1: (1 comment) File dev/core/src/com/google/gwt/util/tools/shared/StringUtils.java Line 109: * Eclipse and IntelliJ disagree about what counts as spaces at the end of the line in comments; or rather about what is the prefix for multiline comments: in Eclipse, multiline comments are lines prefixed an indented * (the space is part of the prefix, it's not considered end of line; it's there to somehow align everything). I don't think we want to make a hard rule about that, unless someone finds a way to make Eclipse and IntelliJ behave the same (and I'm not even talking about NetBeans). We'll have to have that discussion at some point, so feel free to start it on gwt-contrib. -- To view, visit https://gwt-review.googlesource.com/1031 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id33cdf94725981c9c5779553444c1ac64659892c Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Cut circular dependency between c.g.g.core.linker and c.g.g....
Manuel Carrasco Moñino has posted comments on this change. Change subject: Cut circular dependency between c.g.g.core.linker and c.g.g.dev.js .. Patch Set 1: (1 comment) File dev/core/src/com/google/gwt/util/tools/shared/StringUtils.java Line 109: * I think you can configure 'remove trailing spaces' on save, but anyway, I agree that it is not a big deal, maybe it is easy to remove this visual warning from Gerrit someway. -- To view, visit https://gwt-review.googlesource.com/1031 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id33cdf94725981c9c5779553444c1ac64659892c Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Generator, get method body
It seems that the eclipse-jdt-core included in GWT doesnt have certain classes like ASTParser. I would give a try including the eclipse dependency in my pom.xml. On Fri, May 24, 2013 at 2:35 AM, John A. Tamplin j...@jaet.org wrote: On Thu, May 23, 2013 at 7:56 PM, Manuel Carrasco Moñino man...@apache.org wrote: The ShowcaseGenerator, is actually reading the content of the source files and generating .html files, but I want to extract method bodies and their javadoc so what I need an AST. So my question is more about how to use the gwt ast from a generator. The GWT AST is not available to generators, so you will have to build your own -- you can use JDT as that is included with GWT. -- John A. Tamplin -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Generator, get method body
Good to know. thanks. On Fri, May 24, 2013 at 6:54 AM, Roberto Lublinerman rlu...@google.comwrote: Even if it were accessible to the generators the GWT AST does not contain javadocs nor comments. Roberto Lublinerman | Software Engineer | rlu...@google.com | 408-500-9148 On Thu, May 23, 2013 at 5:35 PM, John A. Tamplin j...@jaet.org wrote: On Thu, May 23, 2013 at 7:56 PM, Manuel Carrasco Moñino man...@apache.org wrote: The ShowcaseGenerator, is actually reading the content of the source files and generating .html files, but I want to extract method bodies and their javadoc so what I need an AST. So my question is more about how to use the gwt ast from a generator. The GWT AST is not available to generators, so you will have to build your own -- you can use JDT as that is included with GWT. -- John A. Tamplin -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
Hello Leeroy Jenkins, Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2900 to look at the new patch set (#4). Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Use JSON.parse() instead of eval() to deserialize rpc callback payload IE9 is currently leaking memory on every RPC call you make. The root cause is that eval() on IE9 is designed to keep everyting evaled in memory until the browser session dies (see http://support.microsoft.com/kb/2572253). To work around this issue this patch instead of using eval() on the RPC callback payload uses JSON.parse which does not have these problems. Since JSON does not support the special values NaN, Infinity and -Infinity they are now converted into strings and later converted back with Number(x) on the client side. This patch also increases the RPC request version number to 8 and allows the browser to request which version the server implementation should respond with. Browsers without support for JSON.parse (IE6/7) will always request version 7. Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f --- M user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java M user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStreamWriter.java M user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamWriter.java M user/src/com/google/gwt/user/server/rpc/RPC.java M user/src/com/google/gwt/user/server/rpc/RPCRequest.java M user/src/com/google/gwt/user/server/rpc/RemoteServiceServlet.java M user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java M user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java 8 files changed, 99 insertions(+), 14 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2900 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add History.getUrl(String token) which returns the correspon...
Johannes Barop has uploaded a new patch set (#2). Change subject: Add History.getUrl(String token) which returns the corresponding URL for a history token. .. Add History.getUrl(String token) which returns the corresponding URL for a history token. This enables custom History implementations (for example a implementation with pushstate) to modify the display of URLs in widgets (for example Hyperlink). Change-Id: I9f9b261547b539489d9cee8a72f660264d64e9f2 --- M user/src/com/google/gwt/user/client/History.java M user/src/com/google/gwt/user/client/impl/HistoryImpl.java M user/src/com/google/gwt/user/client/ui/Hyperlink.java 3 files changed, 17 insertions(+), 2 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2960 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9f9b261547b539489d9cee8a72f660264d64e9f2 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Johannes Barop j...@barop.de -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
John Ahlroos has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 4: Patch Set 4 now bumps the default version number and changes the versioning so that the server now always responds with the same version as the browser has requested. If JSON.parse() is not available, the client will always request version 7. I didn't do anything to the concat part on the server side, if it kicks in the JSONUtils.safeEval() will fail and the eval() will be used instead. It could be refactored further to not kick in at all if the version 8 but I think that could be done in another changeset. -- To view, visit https://gwt-review.googlesource.com/2900 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Generator, get method body
ASTParser should be in eclipse-jdt-core, although there seems to be different AST representation, GWT uses the one in org.eclipse.jdt.internal.compiler.ast whereas the ASTParser works in org.eclipse.jdt.core.dom. JDT has a very thick api to support the eclipse editor and some simple tasks might become overly complex. I wonder if the approach you have taken using a much smaller and simpler parser is not actually better. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add History.getUrl(String token) which returns the correspon...
Jens Nehlmeier has posted comments on this change.
Change subject: Add History.getUrl(String token) which returns the
corresponding URL for a history token.
..
Patch Set 2:
(2 comments)
File user/src/com/google/gwt/user/client/History.java
Line 247:*
Nit-pick: Trailing whitespace at end of line.
Line 250: public static String getUrl(String historyToken) {
getRelativeUrl() is probably a bit more descriptive?
--
To view, visit https://gwt-review.googlesource.com/2960
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f9b261547b539489d9cee8a72f660264d64e9f2
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Johannes Barop j...@barop.de
Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
Thomas Broyer has posted comments on this change.
Change subject: Use JSON.parse() instead of eval() to deserialize rpc
callback payload
..
Patch Set 4:
(6 comments)
Looking at the history, I stumbled on another case besides the .concat hack
where the protocol does not emit JSON but rather JSON-like JavaScript: the
ClientSerializationStreamReader in DevMode uses Rhino to eval() the
response, and Rhino has a hard limit on the length of a string literal, so
the server emits a concatenation of string literals in this case. See
https://code.google.com/p/google-web-toolkit/source/detail?r=10888
That means we'll want to:
* only emit those concatenated strings in getVersion() 8
* parse the response without Rhino (and as pure JSON) when it's in version
8.
About detecting version 8, I wonder if we shouldn't change the response
format to include the version outside the JSON. I have no idea what impact
it would have on the code though, so maybe it's a bad idea and extracting
the version from the JSON like you did is the way to go.
But much more importantly: I'd wait for our decision whether we continue to
support IE6/7 before going any farther. If we drop IE6/7 support, we can
simplify the client *and* server code.
Also, currently the server-side code supports back to version 5 of the
GWT-RPC protocol; but that support is actually limited to accepting
requests from old clients, because responses are always sent with the last
known version (according to the changes made in this patch). Is this really
needed? should backwards-compatibility be kept at all? only for the last 2
versions? (7 and 8 here) Note that clients will choke just after parsing
the response because getVersion() doesn't exactly match what they know how
to deal with, so supporting older requests on the server-side means that
the RPC is executed but the client can't decode the response. I don't know
what's best here (vs. failing early), but we're not really concerned here,
as we're only changing the response format, so we can continue to support
old requests; I don't think it's worth supporting clients older than v7
though (cached/running clients while the server is being updated/redeployed)
FYI, ServerSerializationStreamWriter has some code that depends on
getVersion() in writeLong, which is why I though the changes would be
limited to that class. Digging further, that code was added in
https://code.google.com/p/google-web-toolkit/source/detail?r=8274 and
simply copied from AbstractSerializationStreamWriter (shared between client
and server), so I think it was an oversight.
FYI, backwards-compat on the server-side for decoding requests was added at
https://code.google.com/p/google-web-toolkit/source/detail?r=8269
File
user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStreamWriter.java
Line 92: if (Double.isNaN(fieldValue) || Double.isInfinite(fieldValue))
{
if (getVersion() 7 (Double.isNaN(fieldValue) ||
Double.isInfinite(fieldValue))
(except with a the '7' replaced by a constant in
AbstractSerializationStream)
File
user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamWriter.java
Line 191: int version = isJsonParseSupported() ? getVersion() : 7;
Use a constant instead of '7' (see comment on
AbstractSerializationStreamWriter too)
File
user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java
Depending on the version, this class should decide whether to use
LengthConstrainedArray (the .concat hack) or not (or tweak its behavior to
enable/disable the .concat hack)
That way, we can decide on the client-side whether to use eval() or
JSON.parse and be sure that in the JSON.parse case (version 8) we should
have valid JSON as input.
Line 636: if (getVersion() 8) {
Should be done in AbstractSerializationStreamWriter (see comment there)
File
user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java
Line 61: if(version 8){
Formatting (spaces):
if•(version 8)•{
and use a constant instead of a magic number.
Line 62: // Versions prior to 8 uses invalid JSON; e.g., using
].concat([ or non-stringified NaN/Infinity.
Versions prior to 8 use JavaScript, not JSON.
--
To view, visit https://gwt-review.googlesource.com/2900
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos j...@vaadin.com
Gerrit-Reviewer: Brian Slesinsky
Re: [gwt-contrib] Re: Generator, get method body
On Fri, May 24, 2013 at 6:33 AM, Roberto Lublinerman rlu...@google.comwrote: ASTParser should be in eclipse-jdt-core, although there seems to be different AST representation, GWT uses the one in org.eclipse.jdt.internal.compiler.ast whereas the ASTParser works in org.eclipse.jdt.core.dom. JDT has a very thick api to support the eclipse editor and some simple tasks might become overly complex. I wonder if the approach you have taken using a much smaller and simpler parser is not actually better. When I needed to parse the source to get parameter names from interface methods (which aren't included in the bytecode), I used CodeSnippetParsingUtil in JDT and it seemed straightforward enough. -- John A. Tamplin -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Trouble with gwt push (contributor agreement)
On there left there is a link HTTP Password. If you haven't already, you have to click that to get the password that you will use for authentication. On Thursday, May 23, 2013 6:51:55 PM UTC-4, Matic Petek wrote: Hi, I update Books section on gwtproject.org and I would like to send updates to Gerrit for review. I Sign Electronically cont. agreement (by filling the form). Should I do something alse? Thank you. Regards, Matic -- -- git push origin HEAD:refs/for/master Username for 'https://gwt.googlesource.com': git-maticpetek.gmail.com Password for 'https://git-maticpetek.gmail@gwt.googlesource.com': fatal: remote error: Individual contributor agreement requires current contact information. Please review your contact information: https://gwt-review.googlesource.com/#/settings/contact -- -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: working on issue 8063, ie10 permutation and ms pointer events
Manuel Carrasco Moñino has posted comments on this change. Change subject: working on issue 8063, ie10 permutation and ms pointer events .. Patch Set 4: Matti the patch looks good to me, but I dont understand why you continue having the block 'none' in the HTTP.gwt.xml. replace-with class=com.google.gwt.http.client.Request.RequestImplIE6To9 when-type-is class=com.google.gwt.http.client.Request.RequestImpl / all none when-property-is name=user.agent value=ie10 / /none any when-property-is name=user.agent value=ie6 / when-property-is name=user.agent value=ie8 / when-property-is name=user.agent value=ie9 / /any /all /replace-with IMO it does nothing and it is confusing to leave it there. Or maybe I'm missing something. -- To view, visit https://gwt-review.googlesource.com/2421 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba0cec6e33ffd3fefa69c3c760868beb00d42076 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matti Tahvonen ma...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Trouble with gwt push (contributor agreement)
Hi, I already obtain this password and use it for username and password. And I also try with .netrc file. No luck. I'm still getting the some error message. On Friday, May 24, 2013 2:49:50 PM UTC+2, Patrick Tucker wrote: On there left there is a link HTTP Password. If you haven't already, you have to click that to get the password that you will use for authentication. On Thursday, May 23, 2013 6:51:55 PM UTC-4, Matic Petek wrote: Hi, I update Books section on gwtproject.org and I would like to send updates to Gerrit for review. I Sign Electronically cont. agreement (by filling the form). Should I do something alse? Thank you. Regards, Matic -- -- git push origin HEAD:refs/for/master Username for 'https://gwt.googlesource.com': git-maticpetek.gmail.com Password for 'https://git-maticpetek.gmail@gwt.googlesource.com': fatal: remote error: Individual contributor agreement requires current contact information. Please review your contact information: https://gwt-review.googlesource.com/#/settings/contact -- -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
Matthew Dempsky has posted comments on this change.
Change subject: Use JSON.parse() instead of eval() to deserialize rpc
callback payload
..
Patch Set 4:
(1 comment)
File
user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java
Line 636: if (getVersion() 8) {
Also, I think the comparison is backwards? Shouldn't we be writing the
stringified value on getVersion() = 8?
--
To view, visit https://gwt-review.googlesource.com/2900
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos j...@vaadin.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Colin Alworth niloc...@gmail.com
Gerrit-Reviewer: John Ahlroos j...@vaadin.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Trouble with gwt push (contributor agreement)
Is your contact info filled in? The error indicates that it isn't... On Friday, May 24, 2013 10:37:07 AM UTC-4, Matic Petek wrote: Hi, I already obtain this password and use it for username and password. And I also try with .netrc file. No luck. I'm still getting the some error message. On Friday, May 24, 2013 2:49:50 PM UTC+2, Patrick Tucker wrote: On there left there is a link HTTP Password. If you haven't already, you have to click that to get the password that you will use for authentication. On Thursday, May 23, 2013 6:51:55 PM UTC-4, Matic Petek wrote: Hi, I update Books section on gwtproject.org and I would like to send updates to Gerrit for review. I Sign Electronically cont. agreement (by filling the form). Should I do something alse? Thank you. Regards, Matic -- -- git push origin HEAD:refs/for/master Username for 'https://gwt.googlesource.com': git-maticpetek.gmail.com Password for 'https://git-maticpetek.gmail@gwt.googlesource.com': fatal: remote error: Individual contributor agreement requires current contact information. Please review your contact information: https://gwt-review.googlesource.com/#/settings/contact -- -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: working on issue 8063, ie10 permutation and ms pointer events
Thomas Broyer has posted comments on this change. Change subject: working on issue 8063, ie10 permutation and ms pointer events .. Patch Set 5: Gerrit has minimal formatting support (only paragraphs, preformatted text and lists): https://gerrit.googlesource.com/gerrit/+/master/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtml.java -- To view, visit https://gwt-review.googlesource.com/2421 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba0cec6e33ffd3fefa69c3c760868beb00d42076 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matti Tahvonen ma...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matti Tahvonen ma...@vaadin.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
Brian Slesinsky has posted comments on this change.
Change subject: Use JSON.parse() instead of eval() to deserialize rpc
callback payload
..
Patch Set 4:
(4 comments)
To add to the versioning mess, there are Google projects that are using
GWT-RPC to serialize data without using the RPC part (via hacks). For
example, GWT-RPC encoded data might be stored client-side or embedded into
the HTML page served up at initial page load. I think they're just calling
the static methods and not worrying about versioning since we haven't
changed the protocol in years. So this could cause unexpected breakage for
them. On the other hand if they're using a serialization policy they're
probably used to it :-)
It seems like we should do this gradually and start by supporting 7 and 8
for decoding, and make the decision in the caller to use version 8 when we
know it's safe?
We will need to announce the change for people using trunk and include it
in release notes for the next stable version.
File
user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java
Line 44:* one in that it supports {@links RpcToken}s.
update comment
File
user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamWriter.java
Line 191: int version = isJsonParseSupported() ? getVersion() : 7;
Maybe extract a chooseClientVersion() method?
File user/src/com/google/gwt/user/server/rpc/RPC.java
Line 381: AbstractSerializationStream.SERIALIZATION_STREAM_VERSION);
This is tricky. Seems like there are four choices:
(1) If we bump the version to 8 here then all clients need to immediately
support version 8 for decoding responses. (That includes IE6/7 since we
haven't dropped them quite yet.)
(2) Leave it leave it at 7, so we don't need to worry about getting version
8 to work in old browsers. But that means new browsers need to handle both
version 7 and version 8 responses.
(3) I was hoping that each permutation would only need to support one
version. To do that, responses should always use the version sent in the
request, as you've started on, but we would also need to choose the correct
version for sending failures. In that case I'd deprecate this method and
force the callers to make the decision. (But we're still faced with
choosing a version for the deprecated method.)
(4) Wait to commit this change until we've actually dropped IE6/7.
Line 455: AbstractSerializationStream.SERIALIZATION_STREAM_VERSION);
Similar version issues apply here, except that you've already fixed it for
the success case. I think we should deprecate this method. We should choose
the same version here as in encodeResponseForFailure (use the same
constant).
--
To view, visit https://gwt-review.googlesource.com/2900
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos j...@vaadin.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Colin Alworth niloc...@gmail.com
Gerrit-Reviewer: John Ahlroos j...@vaadin.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
Thomas Broyer has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 4: (1 comment) We need to take a decision re. supporting version 7 in parallel to version 8 and how to do it (for those using the RPC class without doing remote calls). When we'll drop support for IE6/7 (and thus need to continue supporting version 7 of the protocol) is being discussed by the steering committee, so we should IMO stop working on this patch pending that decision; unless Google wants to get this fixed sooner in master with a transition period (but then you could also do that in your branch). If there's a transition period where both protocol versions have to be supported in parallel, then we need to decide how best to do it. I'd like to propose moving this discussion to gwt-contrib (generally speaking, we should try to only discuss in Gerrit about the code itself, and move other discussions to gwt-contrib, or ask the SC to make a decision, depending on the kind of thing that needs to be decided) File user/src/com/google/gwt/user/server/rpc/RPC.java Line 381: AbstractSerializationStream.SERIALIZATION_STREAM_VERSION); Which I'd summarize as / reduce to: * we bump to 8 but then we wait until we actually dropped IE6/7 (which we're currently deciding) * we support both 7 and 8, with IE6/7 continuing using version 7 and all other browsers use version 8; the server-side responds with the same version that was used in the request. I agree that using permutations rather than a dynamic switch would make the code clearer/cleaner. That doesn't solve the problem re. those encodeResponseForFailure/Success methods though; and we'd introduce them only for a short transition period: they wouldn't be needed as soon as we remove support for IE6/7 (and thus the need to support version 7 of the protocol in parallel to version 8). If the transition period ends before the next GWT release, then I'm OK to make that change, otherwise I wouldn't like making such a change. -- To view, visit https://gwt-review.googlesource.com/2900 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add History.getUrl(String token) which returns the correspon...
Goktug Gokdogan has posted comments on this change. Change subject: Add History.getUrl(String token) which returns the corresponding URL for a history token. .. Patch Set 2: I'm still not sure how we want to move forward with pushstate. So I'm hesitant to add a new public API to History. Can you look for an alternative where we don't need to expose a new public API? -- To view, visit https://gwt-review.googlesource.com/2960 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f9b261547b539489d9cee8a72f660264d64e9f2 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Johannes Barop j...@barop.de Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2910 to look at the new patch set (#5). Change subject: Chooses a default GWT source level to match the current java runtime. .. Chooses a default GWT source level to match the current java runtime. Now the GWT default source compatibility level will try to match the system property java.specification.version. A small refactor in SourceLevel and a fix to apicheck have been made to allow specifing the java source compatibility level when processing apis in order to avoid a compile error on an old version of emul.Enum. Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f --- M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java M dev/core/src/com/google/gwt/dev/util/Util.java M dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java M dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java M dev/core/src/com/google/gwt/util/tools/Utility.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/util/UtilityTest.java M tools/api-checker/config/gwt25_26userApi.conf M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiCompatibilityChecker.java M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiContainer.java 19 files changed, 171 insertions(+), 47 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2910 to look at the new patch set (#6). Change subject: Chooses a default GWT source level to match the current java runtime. .. Chooses a default GWT source level to match the current java runtime. Now the GWT default source compatibility level will try to match the system property java.specification.version. A small refactor in SourceLevel and a fix to apicheck have been made to allow specifing the java source compatibility level when processing apis in order to avoid a compile error on an old version of emul.Enum. Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f --- M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java M dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java M dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java M dev/core/src/com/google/gwt/util/tools/Utility.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/util/UtilityTest.java M tools/api-checker/config/gwt25_26userApi.conf M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiCompatibilityChecker.java M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiContainer.java 18 files changed, 169 insertions(+), 47 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2910 to look at the new patch set (#7). Change subject: Chooses a default GWT source level to match the current java runtime. .. Chooses a default GWT source level to match the current java runtime. Now the GWT default source compatibility level will try to match the system property java.specification.version. A small refactor in SourceLevel and a fix to apicheck have been made to allow specifing the java source compatibility level when processing apis in order to avoid a compile error on an old version of emul.Enum. Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f --- M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java M dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java M dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java M dev/core/src/com/google/gwt/util/tools/Utility.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/util/UtilityTest.java M tools/api-checker/config/gwt25_26userApi.conf M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiCompatibilityChecker.java M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiContainer.java 18 files changed, 170 insertions(+), 48 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix module unloading with multiple modules on a page
Matthew Dempsky has posted comments on this change. Change subject: Fix module unloading with multiple modules on a page .. Patch Set 1: (Hm, I thought I already posted this as a comment last night.) I agree this is technically a semantic change from before, but I think the risk of it actually breaking anything is low. If getEventListener() returns an object from another module, there's nothing we can actually do with it since the methods might have been mangled differently. The only possibly safe thing to do is to compare against null. RootPanel does limit itself to only just null testing, but then those actions are also only done for debugging asserts from what I can tell. So the risk there seems relatively low. More generally, Roberto and I discussed that perhaps the compiler could (optionally, and primarily for development/testing) add appropriate instanceof checks to JSNI return values. Then we could have caught earlier on that getEventListener() was returning non-EventListener objects contrary to its method signature. -- To view, visit https://gwt-review.googlesource.com/2941 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25d9471c1e14756196a11223eadb765ed303a3b4 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Matthew Dempsky has posted comments on this change.
Change subject: Chooses a default GWT source level to match the current
java runtime.
..
Patch Set 4:
(2 comments)
Argh, apparently these comments didn't get posted when I reviewed patch set
5. Frustrating.
File dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
Line 30: /**
Nit: Blank line before the javadoc.
Line 67: if (Util.versionCompare(javaSpecLevel,
sourceLevel.stringValue) = 0) {
I like Util.versionCompare() a lot more than the double parsing from
before. :) [Edit: Renaming to Utility is fine by me too.]
However, the last match wins strategy seems to assume that the
SourceLevels will be in increasing order? If so, I think that's worth
adding as a quick comment like Static initializer for DEFAULT_SOURCE_LEVEL
depends on these being in increasing order right before JAVA6 and JAVA7
above.
--
To view, visit https://gwt-review.googlesource.com/2910
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Matthew Dempsky has posted comments on this change. Change subject: Chooses a default GWT source level to match the current java runtime. .. Patch Set 7: Code-Review+2 Nice. -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Doing migrations one step at a time
Following up on discussion in: https://gwt-review.googlesource.com/#/c/2900/ There's been some talk about dropping IE 6/7 and it's confused the conversation a bit. I'd like to distinguish between what happens short term and how things will look by our next stable release. I expect that by GWT 2.6, IE6 and 7 support will be gone. People who use stable releases have opted in for big-bang, everything changing all at once and they can do it on whatever schedule is convenient to them, including not upgrading until they're ready. Short-term for those of us at trunk, it's a whole lot easier if we take it one step at a time. First add the new stuff, perhaps hiding it behind a flag. Turn it on by default. Then remove the old stuff. If these land as separate commits then we can verify that each one didn't break our customers before moving on to the next. I realize it's more work than a single atomic change, but it's a lot smoother. I'm fine with waiting on some patches until IE6/7 goes away entirely, but it's also possible to move a few steps forward on some things without waiting on a different patch. At the moment, I don't know anyone specifically working on removing IE6/7, which should proceed in a similar way. We've agreed that it should be done, but someone has to do it, and I'd expect it also to go one step at a time. I think the first step is to make sure everyone knows how to enable or disable the IE6/7 permutation (are any code changes necessary?), and the next step is to change the default so it's off. - Brian -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
Brian Slesinsky has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 4: Okay, I started a discussion in contrib: https://groups.google.com/forum/?fromgroups#!topic/google-web-toolkit-contributors/NWyaRsfy0-Q -- To view, visit https://gwt-review.googlesource.com/2900 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes ISSUE 7079 - Add support for the newer bindery Handler...
Matthew Dempsky has posted comments on this change. Change subject: Fixes ISSUE 7079 - Add support for the newer bindery HandlerRegistration .. Patch Set 2: (1 comment) Commit Message Line 7: Fixes ISSUE 7079 - Add support for the newer bindery HandlerRegistration I think the commit message could be a little more descriptive. Also, could you please change it to something like: Add support for the newer bindery HandlerRegistration Bug: issue 7079 Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Then Gerrit can autolink to issue 7079. -- To view, visit https://gwt-review.googlesource.com/1350 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes the static book keeping in the Timer class.
Goktug Gokdogan has posted comments on this change. Change subject: Removes the static book keeping in the Timer class. .. Patch Set 1: Verified+1 -- To view, visit https://gwt-review.googlesource.com/2851 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf6a9c81a5654bc2eb736a2b4ef81d5cf0517728 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes the static book keeping in the Timer class.
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Removes the static book keeping in the Timer class.
..
Removes the static book keeping in the Timer class.
This changes removes code that keeps track of Timer statically.
Based on history the code was always there from the beginning but
my guess is, this is no longer needed: New-ish Scheduler API is not
doing the same workaround and also there are other places that are
using Impl.setTimeout directly without the workaround.
Change-Id: Idf6a9c81a5654bc2eb736a2b4ef81d5cf0517728
---
M user/src/com/google/gwt/user/client/Timer.java
1 file changed, 0 insertions(+), 31 deletions(-)
Approvals:
John A. Tamplin: Looks good to me, but someone else must approve
Matthew Dempsky: Looks good to me, approved
Leeroy Jenkins: Verified
Goktug Gokdogan: Verified
diff --git a/user/src/com/google/gwt/user/client/Timer.java
b/user/src/com/google/gwt/user/client/Timer.java
index be226b8..f95a5a7 100644
--- a/user/src/com/google/gwt/user/client/Timer.java
+++ b/user/src/com/google/gwt/user/client/Timer.java
@@ -15,10 +15,6 @@
*/
package com.google.gwt.user.client;
-import com.google.gwt.event.logical.shared.CloseEvent;
-import com.google.gwt.event.logical.shared.CloseHandler;
-
-import java.util.ArrayList;
/**
* A simplified, browser-safe timer class. This class serves the same
purpose as
@@ -43,12 +39,6 @@
*/
public abstract class Timer {
- private static ArrayListTimer timers = new ArrayListTimer();
-
- static {
-hookWindowClosing();
- }
-
private static native void clearInterval(int id) /*-{
@com.google.gwt.core.client.impl.Impl::clearInterval(I)(id);
}-*/;
@@ -68,18 +58,6 @@
$entry(function() {
tim...@com.google.gwt.user.client.Timer::fire(I)(cancelCounter); }),
delay);
}-*/;
-
- private static void hookWindowClosing() {
-// Catch the window closing event.
-Window.addCloseHandler(new CloseHandlerWindow() {
-
- public void onClose(CloseEventWindow event) {
-while (timers.size() 0) {
- timers.get(0).cancel();
-}
- }
-});
- }
private boolean isRepeating;
@@ -101,7 +79,6 @@
} else {
clearTimeout(timerId);
}
-timers.remove(this);
}
/**
@@ -123,7 +100,6 @@
cancel();
isRepeating = false;
timerId = createTimeout(this, delayMillis, cancelCounter);
-timers.add(this);
}
/**
@@ -139,7 +115,6 @@
cancel();
isRepeating = true;
timerId = createInterval(this, periodMillis, cancelCounter);
-timers.add(this);
}
/*
@@ -150,12 +125,6 @@
final void fire(int scheduleCancelCounter) {
if (scheduleCancelCounter != cancelCounter) {
return;
-}
-
-// If this is a one-shot timer, remove it from the timer list. This
will
-// allow it to be garbage collected.
-if (!isRepeating) {
- timers.remove(this);
}
// Run the timer's code.
--
To view, visit https://gwt-review.googlesource.com/2851
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf6a9c81a5654bc2eb736a2b4ef81d5cf0517728
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add History.getUrl(String token) which returns the correspon...
Johannes Barop has posted comments on this change. Change subject: Add History.getUrl(String token) which returns the corresponding URL for a history token. .. Patch Set 2: The first alternative is HyperlinkImpl. But this would introduce spaghetti inheritance because of the existing HyperlinkImpl's. And it clutters the History stuff across multiple classes. Other alternative: Add it only to HistoryImpl and let Hyperlink use HistoryImpl directly. But this is not optimal because then we have to duplicate the HistoryImpl.init() error handling and it feels hacky to me. I think a new method to generate a link for a given history token is the best way in the end because generating URLs is a part of implementing History mechanisms. This change makes the code of gwt-pushstate simpler. However I have already a workaround for it. So it's not critical and we can take time to think over it. -- To view, visit https://gwt-review.googlesource.com/2960 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f9b261547b539489d9cee8a72f660264d64e9f2 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Johannes Barop j...@barop.de Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Johannes Barop j...@barop.de Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add History.getUrl(String token) which returns the correspon...
Johannes Barop has uploaded a new patch set (#3). Change subject: Add History.getUrl(String token) which returns the corresponding URL for a history token. .. Add History.getUrl(String token) which returns the corresponding URL for a history token. This enables custom History implementations (for example a implementation with pushstate) to modify the display of URLs in widgets (for example Hyperlink). Change-Id: I9f9b261547b539489d9cee8a72f660264d64e9f2 --- M user/src/com/google/gwt/user/client/History.java M user/src/com/google/gwt/user/client/impl/HistoryImpl.java M user/src/com/google/gwt/user/client/ui/Hyperlink.java 3 files changed, 16 insertions(+), 2 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2960 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9f9b261547b539489d9cee8a72f660264d64e9f2 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Johannes Barop j...@barop.de Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Johannes Barop j...@barop.de -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Doing migrations one step at a time
On Saturday, May 25, 2013 12:57:09 AM UTC+2, Brian Slesinsky wrote: Following up on discussion in: https://gwt-review.googlesource.com/#/c/2900/ There's been some talk about dropping IE 6/7 and it's confused the conversation a bit. I'd like to distinguish between what happens short term and how things will look by our next stable release. I expect that by GWT 2.6, IE6 and 7 support will be gone. People who use stable releases have opted in for big-bang, everything changing all at once and they can do it on whatever schedule is convenient to them, including not upgrading until they're ready. Short-term for those of us at trunk, it's a whole lot easier if we take it one step at a time. First add the new stuff, perhaps hiding it behind a flag. Turn it on by default. Then remove the old stuff. If these land as separate commits then we can verify that each one didn't break our customers before moving on to the next. I realize it's more work than a single atomic change, but it's a lot smoother. I'm fine with waiting on some patches until IE6/7 goes away entirely, but it's also possible to move a few steps forward on some things without waiting on a different patch. At the moment, I don't know anyone specifically working on removing IE6/7, which should proceed in a similar way. We've agreed that it should be done, but someone has to do it, and I'd expect it also to go one step at a time. I think the first step is to make sure everyone knows how to enable or disable the IE6/7 permutation (are any code changes necessary?), and the next step is to change the default so it's off. Does Google still support IE6/7 on some apps? I thought you only supported IE9+ If you don't support IE6/7, and we choose to drop IE6/7 support in the next release, then 'master' could have a transition period where RPC simply wouldn't work in IE6/7 without removing the ie6 permutation. BTW, disabling the IE6/7 permutation is only a matter of set-property name=user.agent value=ie8,ie9,gecko1_8,safari,opera/ right? Removing support would start by removing the ie6 permutation and then cleaning up the code by removing now-unused code, and finally possibly clean up further by refactoring some code that was used in both ie6 and ie8 to better take advantage that it'd now only be running in IE8. I otherwise agree about the principle: first deprecate, add a flag, then turn the flag off by default and remove the code then remove the flag (or remove everything in one go). Well, anyway, that's the basis of trunk-based development which is what we chose to use for GWT. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Doing migrations one step at a time
On Fri, May 24, 2013 at 5:53 PM, Thomas Broyer t.bro...@gmail.com wrote: On Saturday, May 25, 2013 12:57:09 AM UTC+2, Brian Slesinsky wrote: Following up on discussion in: https://gwt-review.** googlesource.com/#/c/2900/https://gwt-review.googlesource.com/#/c/2900/ There's been some talk about dropping IE 6/7 and it's confused the conversation a bit. I'd like to distinguish between what happens short term and how things will look by our next stable release. I expect that by GWT 2.6, IE6 and 7 support will be gone. People who use stable releases have opted in for big-bang, everything changing all at once and they can do it on whatever schedule is convenient to them, including not upgrading until they're ready. Short-term for those of us at trunk, it's a whole lot easier if we take it one step at a time. First add the new stuff, perhaps hiding it behind a flag. Turn it on by default. Then remove the old stuff. If these land as separate commits then we can verify that each one didn't break our customers before moving on to the next. I realize it's more work than a single atomic change, but it's a lot smoother. I'm fine with waiting on some patches until IE6/7 goes away entirely, but it's also possible to move a few steps forward on some things without waiting on a different patch. At the moment, I don't know anyone specifically working on removing IE6/7, which should proceed in a similar way. We've agreed that it should be done, but someone has to do it, and I'd expect it also to go one step at a time. I think the first step is to make sure everyone knows how to enable or disable the IE6/7 permutation (are any code changes necessary?), and the next step is to change the default so it's off. Does Google still support IE6/7 on some apps? I thought you only supported IE9+ Depends on the product. I see that Adwords is dropping IE8 soon: https://www.en.adwords-community.com/t5/Ad-Approvals-and-Advertising/Google-Ads-cease-support-for-Internet-Explorer-8/td-p/133766 Can't find it for Wallet but it says IE7+ for the API: https://developers.google.com/commerce/wallet/digital/faq#faq-technical-02 If you don't support IE6/7, and we choose to drop IE6/7 support in the next release, then 'master' could have a transition period where RPC simply wouldn't work in IE6/7 without removing the ie6 permutation. BTW, disabling the IE6/7 permutation is only a matter of set-property name=user.agent value=ie8,ie9,gecko1_8,safari,opera/ right? Perhaps. There was some talk about having a trivial permutation that just shows an alert if your browser is unsupported. We never had that before, though. - Brian -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Doing migrations one step at a time
On Fri, May 24, 2013 at 8:53 PM, Thomas Broyer t.bro...@gmail.com wrote: BTW, disabling the IE6/7 permutation is only a matter of set-property name=user.agent value=ie8,ie9,gecko1_8,safari,opera/ right? Removing support would start by removing the ie6 permutation and then cleaning up the code by removing now-unused code, and finally possibly clean up further by refactoring some code that was used in both ie6 and ie8 to better take advantage that it'd now only be running in IE8. Yes, and maybe we should go ahead and do that immediately -- leave all the support for ie6/7 in place, but just don't build it by default. If anyone is running from trunk and needs it, they simple add it back with an extend-property. -- John A. Tamplin -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
