Re: Overuse of AssumedStale Issue Tag
For the latter two issues above, also note that our goal is to modularize GWT and externalize things How will this look like? To my experience, currently it's very hard to change/extend GWT core functionality. How will this change? A few examples that popup: the classes Event, Element, HandlerManager (there are more) are very hard to change/extend because the methods/classes are final, or package protected or lack of interface usage. Looking at the changes issues (AssumedStale) I don't get the impression that this will change soon as the issues about making classes like Event, Element, HandlerManager, etc... more flexible such that they can be extended, or all marked as Not-Planned, as-Designed, AssumeStale... Also a few issues about making more use of interfaces are destroyed, which I think is needed to make GWT more modular. Please more insight? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Web Application (running on an external server).
Hello everybody, I am using GWT 2.5.1 on eclipse(JUNO). I want to run a google maps API with external libraries(JUNG for graphs, JDOM XML document) and the complete JRE libraries. On the client side I get : No source code is available for type java.io.FileInputStream; did you forget to inherit a required module? I have consulted some posts here and there. All speak about server side and RPC. Yet I do not find a complete tutorial on the subject. Please can you provide me some interesting links ? Many thanks in advance. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Zoom image in GWT
Hi All, I want to allow a zoom on image hover in GWT. Example can be seen over here http://zoomy.me/home but that is implemented in jQuery. Thanks in advance, Vineet Minj -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: History back in chrome and safari
Manually set the href attribute using widget.getElementById(nextLink).setAttribute(href, #topic2); to the prev and next buttons everytime time the page loads set them. Never put #nextPage or #prevPage through the history manager. Duncan On Tuesday, 10 November 2009 21:15:38 UTC-6, Amir wrote: Hi, I am developing a GWT application. Inside my main GWT window I have an iFrame which loads a non gwt url. The user can click on links inside the iFrame window to navigate to other pages. Now I want to provide back/forward functionality to move back and forward between the pages loaded in the iFrame. I tried using the standard history.back() technique and it works fine on FF and IE but not on Chrome and Safari. Does anyone know I can accomplish that across all browsers? Many thanks, Amir -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: History back in chrome and safari
I am having the same exact problem. Wondering if anyone has a solution. Duncan On Tuesday, 10 November 2009 21:15:38 UTC-6, Amir wrote: Hi, I am developing a GWT application. Inside my main GWT window I have an iFrame which loads a non gwt url. The user can click on links inside the iFrame window to navigate to other pages. Now I want to provide back/forward functionality to move back and forward between the pages loaded in the iFrame. I tried using the standard history.back() technique and it works fine on FF and IE but not on Chrome and Safari. Does anyone know I can accomplish that across all browsers? Many thanks, Amir -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Overuse of AssumedStale Issue Tag
On Tuesday, May 28, 2013 10:10:31 AM UTC+2, Ed wrote: For the latter two issues above, also note that our goal is to modularize GWT and externalize things How will this look like? To my experience, currently it's very hard to change/extend GWT core functionality. How will this change? A few examples that popup: the classes Event, Element, HandlerManager (there are more) are very hard to change/extend because the methods/classes are final, or package protected or lack of interface usage. Looking at the changes issues (AssumedStale) I don't get the impression that this will change soon as the issues about making classes like Event, Element, HandlerManager, etc... more flexible such that they can be extended, or all marked as Not-Planned, as-Designed, AssumeStale... Also a few issues about making more use of interfaces are destroyed, which I think is needed to make GWT more modular. Please more insight? Modular in the sense that gwt-user.jar will be split into smaller parts and you only include in your classpath the modules you need. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Overuse of AssumedStale Issue Tag
Thanks, was a afraid of that ;)... So still difficult to extend/change core gwt functionality like mentioned above.. :( (it's time to become a contributor ;) ) On Tue, May 28, 2013 at 1:28 PM, Thomas Broyer t.bro...@gmail.com wrote: On Tuesday, May 28, 2013 10:10:31 AM UTC+2, Ed wrote: For the latter two issues above, also note that our goal is to modularize GWT and externalize things How will this look like? To my experience, currently it's very hard to change/extend GWT core functionality. How will this change? A few examples that popup: the classes Event, Element, HandlerManager (there are more) are very hard to change/extend because the methods/classes are final, or package protected or lack of interface usage. Looking at the changes issues (AssumedStale) I don't get the impression that this will change soon as the issues about making classes like Event, Element, HandlerManager, etc... more flexible such that they can be extended, or all marked as Not-Planned, as-Designed, AssumeStale... Also a few issues about making more use of interfaces are destroyed, which I think is needed to make GWT more modular. Please more insight? Modular in the sense that gwt-user.jar will be split into smaller parts and you only include in your classpath the modules you need. -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/5aNsIcPKDm4/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Announcing Flash4j 3.1
Hello GWT Folks Flash4j 3.1 just hits the road. This GWT based library combines Flash and GWT to help devs create stunning Desktop Apps. New stuff among others in thie release : 1)UI binders for Flex 2) Google Maps for Flex. 3) ClientIO: A GWT/Flash based Widget for Excel and PDF I/O to use in any GWT app(No Flex required) Check out the full release announcement here : http://www.emitrom.com/announcements/flash4j-3.1-ga. Cheers, Alain -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Interesting behavior with google maps..
Just as update! I tried to compile with 2.5.0 and 2.5.1 but still same behavior. If compiled with PRETTY markers are working(shown), but for the polylines still the same(not painted because of exception). In obf or detailed markers and polylines are not painted. This makes me think that the problem is in the GWT compile process... Any thoughts on difference from devmode to compiled? We use an in house subversion from the brainflake maps wrapper... The exception in chrome is the same as from before, and happens deep in the maps js script because of a undefined parameter... -- Blaze Am Montag, 27. Mai 2013 19:52:03 UTC+2 schrieb Blaze: Hi, I have small question, since google move from 3.11 to maps version 3.12 as a new stable release, my application started to act uncorrect. What is interesting is that the devmode works all ok on FF, but after compile and deploy the polylines and markers are not working...(on any browser) Im getting this kind of exception in the chrome console... 1. Uncaught TypeError: Cannot read property 'length' of undefined 1. Mt 2. iI.vl 3. iI.re 4. (anonymous function) 5. (anonymous function)main.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 6. Nmain.js:9http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 7. Hfmain.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 8. Mfmain.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 9. (anonymous function) 10. If.util 11. (anonymous function)main.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 12. (anonymous function)main.js:10http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 13. (anonymous function)main.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 14. Nmain.js:9http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 15. (anonymous function)main.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 16. Ef.(anonymous function).Oemain.js:23http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 17. Ff.(anonymous function).Vcmain.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 18. Jfmain.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 19. (anonymous function)%7Bonion%7D.js:1http://maps.gstatic.com/cat_js/intl/de_de/mapfiles/api-3/12/12/%7Bonion%7D.js 1. Uncaught TypeError: Cannot read property 'length' of undefined 1. Mt 2. xG 3. RG.(anonymous function).d 4. (anonymous function)main.js:37http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 5. (anonymous function)main.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 6. Nmain.js:9http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 7. Hfmain.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 8. Mfmain.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 9. (anonymous function) 10. If.util 11. (anonymous function)main.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 12. (anonymous function)main.js:10http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 13. (anonymous function)main.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 14. Nmain.js:9http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 15. (anonymous function)main.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 16. Ef.(anonymous function).Oemain.js:23http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 17. Ff.(anonymous function).Vcmain.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 18. Jfmain.js:24http://maps.gstatic.com/intl/de_de/mapfiles/api-3/12/12/main.js 19. (anonymous function)%7Bgeometry,poly%7D.js:2http://maps.gstatic.com/cat_js/intl/de_de/mapfiles/api-3/12/12/%7Bgeometry,poly%7D.js All are pointing to the maps.js files... My question is, what is the main difference from devmode and compiled...meaning in the loadded maps related js files? As I understand should be non, right? Thanks for any thoughts! I fired the question also to the maps guys...:) Blaze -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit
Re: com.google.apphosting.utils.jetty.JettyLogger warn WARNING: EXCEPTION java.lang.ClassNotFoundException
Hi, as you are saying, if it worked for couple of times and then not, then I guess the exception is not mapped correct. Do you have enough free memory on the machine? Try restarting the machine...if this helps and after time the exception appiar again then is a machine problem(memory etc..). Ofcourse before re-check all the deployed libs if they are the same with the one on the compile time... Am Montag, 27. Mai 2013 13:48:03 UTC+2 schrieb Raghu rao: Hi, I am trying to store blob data into datastore, successfully i have inserted two rows of data. after that am not able to run the application and am getting below error. Pls advice me what to do? i tried with adding of Jdk1.7 in the build path but it did't work. error code is : May 27, 2013 11:33:56 AM com.google.apphosting.utils.jetty.JettyLogger warn WARNING: EXCEPTION java.lang.ClassNotFoundException: Serve at java.net.URLClassLoader$1.run(URLClassLoader.java:366) at java.net.URLClassLoader$1.run(URLClassLoader.java:355) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:354) at java.lang.ClassLoader.loadClass(ClassLoader.java:423) at com.google.appengine.tools.development.IsolatedAppClassLoader.loadClass(IsolatedAppClassLoader.java:213) at java.lang.ClassLoader.loadClass(ClassLoader.java:356) at org.mortbay.util.Loader.loadClass(Loader.java:91) at org.mortbay.util.Loader.loadClass(Loader.java:71) at org.mortbay.jetty.servlet.Holder.doStart(Holder.java:73) at org.mortbay.jetty.servlet.ServletHolder.doStart(ServletHolder.java:242) at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) at org.mortbay.jetty.servlet.ServletHandler.initialize(ServletHandler.java:685) at org.mortbay.jetty.servlet.Context.startContext(Context.java:140) at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1250) at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:517) at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:467) at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130) at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130) at org.mortbay.jetty.Server.doStart(Server.java:224) at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) at com.google.appengine.tools.development.JettyContainerService.startContainer(JettyContainerService.java:228) at com.google.appengine.tools.development.AbstractContainerService.startup(AbstractContainerService.java:255) at com.google.appengine.tools.development.AbstractServer.startup(AbstractServer.java:79) at com.google.appengine.tools.development.DevAppServerImpl$Servers.startup(DevAppServerImpl.java:451) at com.google.appengine.tools.development.DevAppServerImpl.start(DevAppServerImpl.java:198) at com.google.appengine.tools.development.gwt.AppEngineLauncher.start(AppEngineLauncher.java:97) at com.google.gwt.dev.DevMode.doStartUpServer(DevMode.java:509) at com.google.gwt.dev.DevModeBase.startUp(DevModeBase.java:1093) at com.google.gwt.dev.DevModeBase.run(DevModeBase.java:836) at com.google.gwt.dev.DevMode.main(DevMode.java:311) May 27, 2013 11:33:56 AM com.google.appengine.tools.development.ApiProxyLocalImpl log SEVERE: javax.servlet.ServletContext log: unavailable javax.servlet.UnavailableException: Serve at org.mortbay.jetty.servlet.Holder.doStart(Holder.java:79) at org.mortbay.jetty.servlet.ServletHolder.doStart(ServletHolder.java:242) at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) at org.mortbay.jetty.servlet.ServletHandler.initialize(ServletHandler.java:685) at org.mortbay.jetty.servlet.Context.startContext(Context.java:140) at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1250) at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:517) at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:467) at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130) at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130) at org.mortbay.jetty.Server.doStart(Server.java:224) at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) at com.google.appengine.tools.development.JettyContainerService.startContainer(JettyContainerService.java:228) at com.google.appengine.tools.development.AbstractContainerService.startup(AbstractContainerService.java:255) at com.google.appengine.tools.development.AbstractServer.startup(AbstractServer.java:79) at
Lessons learned moving from GWT to Spring MVC
Just wanted to share the following webinar: Lessons learned moving from GWT to Spring MVC I was just listening to it (it's live now)... and really didn't like it... The speaker wasn't talking very nice about GWT, not very objective... all the little negatives things where made BIG... Or maybe they had very bad developers as they talked about slow development, hosted mode startup times with over a minute :( etc.. etc... Or maybe they were just using gwt 1.1 ;) Strangge not my experience at all... -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Sporadic error with GWT and GAE
Dear all, I have developed an application in GWT that is running on GAE and I am receiving sporadic error like the one that I have reported in this post. The problem is that from the stack trace I cannot figure out which is the cause (there is no my own code as you can see): please could you help me understanding how to solve the problem? Thank you very much and best Regards, Marco. javax.servlet.ServletContext log: Exception while dispatching incoming RPC call java.lang.IllegalArgumentException: encodedRequest cannot be empty at com.google.gwt.user.server.rpc.RPC.decodeRequest(RPC.java:232) at com.google.gwt.user.server.rpc.RemoteServiceServlet.processCall(RemoteServiceServlet.java:206) at com.google.gwt.user.server.rpc.RemoteServiceServlet.processPost(RemoteServiceServlet.java:248) at com.google.gwt.user.server.rpc.AbstractRemoteServiceServlet.doPost(AbstractRemoteServiceServlet.java:62) at javax.servlet.http.HttpServlet.service(HttpServlet.java:637) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1166) at com.google.apphosting.utils.servlet.ParseBlobUploadFilter.doFilter(ParseBlobUploadFilter.java:125) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157) at com.google.apphosting.runtime.jetty.SaveSessionFilter.doFilter(SaveSessionFilter.java:35) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157) at com.google.apphosting.utils.servlet.JdbcMySqlConnectionCleanupFilter.doFilter(JdbcMySqlConnectionCleanupFilter.java:57) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157) at com.google.apphosting.utils.servlet.TransactionCleanupFilter.doFilter(TransactionCleanupFilter.java:43) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418) at com.google.apphosting.runtime.jetty.AppVersionHandlerMap.handle(AppVersionHandlerMap.java:266) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:326) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:923) at com.google.apphosting.runtime.jetty.RpcRequestParser.parseAvailable(RpcRequestParser.java:76) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404) at com.google.apphosting.runtime.jetty.JettyServletEngineAdapter.serviceRequest(JettyServletEngineAdapter.java:146) at com.google.apphosting.runtime.JavaRuntime$RequestRunnable.run(JavaRuntime.java:439) at com.google.tracing.TraceContext$TraceContextRunnable.runInContext(TraceContext.java:480) at com.google.tracing.TraceContext$TraceContextRunnable$1.run(TraceContext.java:487) at com.google.tracing.TraceContext.runInContext(TraceContext.java:774) at com.google.tracing.TraceContext$DoInTraceContext.runInContext(TraceContext.java:751) at com.google.tracing.TraceContext$AbstractTraceContextCallback.runInInheritedContextNoUnref(TraceContext.java:342) at com.google.tracing.TraceContext$AbstractTraceContextCallback.runInInheritedContext(TraceContext.java:334) at com.google.tracing.TraceContext$TraceContextRunnable.run(TraceContext.java:484) at com.google.apphosting.runtime.ThreadGroupPool$PoolEntry.run(ThreadGroupPool.java:251) at java.lang.Thread.run(Thread.java:722) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Compiling Error (not Present in Eclipse) with Generics (requestfactory related interface)
Hi all,
I can't figure this out, haven't found anything on the interwebs, and it's
really, really getting to me. I have the following interface:
public interface PersistedClassRCP extends EntityProxy, N extends
Serializable {
RequestP save(P entityProxy,int version);
RequestVoid delete(P entityProxy);
RequestP findById(N id);
}
Now in Eclipse there are no errors, no warnings and I can run in Devmode
just fine. However when I compile it I get the following error:
.../PersistedClassRC.java:39: error: The type N cannot be used here
[javac] RequestP findById(N id);
[javac]
I'm using Java 1.6.0_30 but have also tried it on 1.7.0_05 and 1.7.0_21 and
all yield the same error. Is there something I'm not seeing, is this
illegal? Please any help would be greatly appreciated, thanks in advance.
-Seth
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Lessons learned moving from GWT to Spring MVC
How can one compare something what lives almost entirely in presentation-layer and has none strong dependencies on server-side (GWT) with framework which is focused on server-side without any real widget library? Every SpringMVC app I developed used jQuery to add better experience to users. W dniu wtorek, 28 maja 2013 16:21:22 UTC+2 użytkownik Ed napisał: Just wanted to share the following webinar: Lessons learned moving from GWT to Spring MVC I was just listening to it (it's live now)... and really didn't like it... The speaker wasn't talking very nice about GWT, not very objective... all the little negatives things where made BIG... Or maybe they had very bad developers as they talked about slow development, hosted mode startup times with over a minute :( etc.. etc... Or maybe they were just using gwt 1.1 ;) Strangge not my experience at all... -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Announcing Flash4j 3.1
TOP! :-) Am Dienstag, 28. Mai 2013 13:49:18 UTC+2 schrieb Alain: Hello GWT Folks Flash4j 3.1 just hits the road. This GWT based library combines Flash and GWT to help devs create stunning Desktop Apps. New stuff among others in thie release : 1)UI binders for Flex 2) Google Maps for Flex. 3) ClientIO: A GWT/Flash based Widget for Excel and PDF I/O to use in any GWT app(No Flex required) Check out the full release announcement here : http://www.emitrom.com/announcements/flash4j-3.1-ga. Cheers, Alain -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...
Hello Matthew Dempsky, Matthew Dempsky, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2110 to look at the new patch set (#8). Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Adds isStandalone to ImageResource so Image can used an UnclippedState. isStandalone should be true for data: URLs and non-inlined images (preventInlining=true or repeatStyle=Both). In other words, it should actually rarely be false (IE6/7). Fixes issue 7403 Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 --- M tools/api-checker/config/gwt25_26userApi.conf M user/src/com/google/gwt/resources/client/ImageResource.java M user/src/com/google/gwt/resources/client/impl/ImageResourcePrototype.java M user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java M user/src/com/google/gwt/user/client/ui/AbstractImagePrototype.java M user/src/com/google/gwt/user/client/ui/Image.java M user/src/com/google/gwt/user/client/ui/ImageResourceRenderer.java M user/test/com/google/gwt/cell/client/ImageResourceCellTest.java M user/test/com/google/gwt/resources/client/ImageResourceTest.java M user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java M user/test/com/google/gwt/user/client/ui/ImageTest.java 11 files changed, 173 insertions(+), 17 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2110 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Unary plus in Jsni code was always discarded.
Roberto Lublinerman has uploaded a new change for review.
https://gwt-review.googlesource.com/2990
Change subject: Unary plus in Jsni code was always discarded.
..
Unary plus in Jsni code was always discarded.
Unary plus in JavaScript is only noop when applied to a
numeric value otherwise it behaves as a conversion to double
operator. The compiler incorrectly assumed that is was a noop
in all cases.
The fix was already made in r5951 by cromwellian but was lost
in a subsequent rollback (r5954).
Fixes issue 6373 and issue 3942.
Change-Id: I4d260d7fdc08b942f44b0275fb1c842be1c807fd
---
M dev/core/src/com/google/gwt/dev/js/JsParser.java
M dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
M
dev/core/test/com/google/gwt/dev/js/JsToStringGenerationVisitorAccuracyTest.java
M user/test/com/google/gwt/dev/jjs/CompilerSuite.java
A user/test/com/google/gwt/dev/jjs/test/CompilerMiscRegressionTest.java
5 files changed, 82 insertions(+), 13 deletions(-)
diff --git a/dev/core/src/com/google/gwt/dev/js/JsParser.java
b/dev/core/src/com/google/gwt/dev/js/JsParser.java
index 2a7b218..a4e35dd 100644
--- a/dev/core/src/com/google/gwt/dev/js/JsParser.java
+++ b/dev/core/src/com/google/gwt/dev/js/JsParser.java
@@ -1,12 +1,12 @@
/*
* Copyright 2008 Google Inc.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the License); you may
not
* use this file except in compliance with the License. You may obtain a
copy of
* the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
@@ -1204,8 +1204,13 @@
return mapPrefixOperation(JsUnaryOperator.TYPEOF, unOp);
case TokenStream.ADD:
-// Pretend we didn't see it.
-return mapExpression(unOp.getFirstChild());
+if (unOp.getFirstChild().getType() != TokenStream.NUMBER) {
+ return mapPrefixOperation(JsUnaryOperator.POS, unOp);
+} else {
+ // Pretend we didn't see it.
+ return mapExpression(unOp.getFirstChild());
+}
+
case TokenStream.VOID:
return mapPrefixOperation(JsUnaryOperator.VOID, unOp);
diff --git
a/dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
b/dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
index ed1f569..55fab01 100644
--- a/dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
+++ b/dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
@@ -1,12 +1,12 @@
/*
* Copyright 2008 Google Inc.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the License); you may
not
* use this file except in compliance with the License. You may obtain a
copy of
* the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
@@ -1340,7 +1340,7 @@
/**
* Decide whether, if codeop/code is printed followed by
codearg/code,
* there needs to be a space between the operator and expression.
- *
+ *
* @return codetrue/code if a space needs to be printed
*/
private boolean _spaceCalc(JsOperator op, JsExpression arg) {
@@ -1362,7 +1362,8 @@
JsOperator op2 = ((JsPrefixOperation) arg).getOperator();
return (op == JsBinaryOperator.SUB || op == JsUnaryOperator.NEG)
(op2 == JsUnaryOperator.DEC || op2 == JsUnaryOperator.NEG)
- || (op == JsBinaryOperator.ADD op2 == JsUnaryOperator.INC);
+ || (op == JsBinaryOperator.ADD || op == JsUnaryOperator.POS)
+ (op2 == JsUnaryOperator.INC || op2 == JsUnaryOperator.POS);
}
if (arg instanceof JsNumberLiteral) {
JsNumberLiteral literal = (JsNumberLiteral) arg;
diff --git
a/dev/core/test/com/google/gwt/dev/js/JsToStringGenerationVisitorAccuracyTest.java
b/dev/core/test/com/google/gwt/dev/js/JsToStringGenerationVisitorAccuracyTest.java
index 5a99ddd..117ead1 100644
---
a/dev/core/test/com/google/gwt/dev/js/JsToStringGenerationVisitorAccuracyTest.java
+++
b/dev/core/test/com/google/gwt/dev/js/JsToStringGenerationVisitorAccuracyTest.java
@@ -140,6 +140,12 @@
doTest(var x = +y, var x = +y);
// + prefix stripped when operand is literal number
doTest(var x = +42, var x = 42);
+// + prefix not stripped when operand is not literal number
+doTest(var x = +y, var x = +y);
+// + prefix stripped when operand is literal number
+doTest(var x = +42,var x = 42);
+// + blank + should not become ++
+doTest(var x = 10+ +\2\, var x = 10+ +\2\);
}
public
[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...
Thomas Broyer has posted comments on this change. Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Patch Set 8: Code-Review+2 Patch-set 8 is only a rebase of patch-set 7 that Gerrit couldn't do automatically (configured with automatically resolve conflicts = false), and that one was +2'd by Goktug. -- To view, visit https://gwt-review.googlesource.com/2110 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...
Thomas Broyer has submitted this change and it was merged.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Adds isStandalone to ImageResource so Image can used an UnclippedState.
isStandalone should be true for data: URLs and non-inlined images
(preventInlining=true or repeatStyle=Both). In other words, it should
actually rarely be false (IE6/7).
Fixes issue 7403
Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1
---
M tools/api-checker/config/gwt25_26userApi.conf
M user/src/com/google/gwt/resources/client/ImageResource.java
M user/src/com/google/gwt/resources/client/impl/ImageResourcePrototype.java
M user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java
M user/src/com/google/gwt/user/client/ui/AbstractImagePrototype.java
M user/src/com/google/gwt/user/client/ui/Image.java
M user/src/com/google/gwt/user/client/ui/ImageResourceRenderer.java
M user/test/com/google/gwt/cell/client/ImageResourceCellTest.java
M user/test/com/google/gwt/resources/client/ImageResourceTest.java
M user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
M user/test/com/google/gwt/user/client/ui/ImageTest.java
11 files changed, 173 insertions(+), 17 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Thomas Broyer: Looks good to me, approved
diff --git a/tools/api-checker/config/gwt25_26userApi.conf
b/tools/api-checker/config/gwt25_26userApi.conf
index c151c41..82d5a92 100644
--- a/tools/api-checker/config/gwt25_26userApi.conf
+++ b/tools/api-checker/config/gwt25_26userApi.conf
@@ -138,6 +138,7 @@
:com.google.gwt.benchmarks.client.impl\
:com.google.gwt.user.client.ui.impl\
:com.google.gwt.i18n.client.impl\
+:com.google.gwt.resources.client.impl\
##
#Api whitelist
diff --git a/user/src/com/google/gwt/resources/client/ImageResource.java
b/user/src/com/google/gwt/resources/client/ImageResource.java
index 5f72fb8..f1885ed 100644
--- a/user/src/com/google/gwt/resources/client/ImageResource.java
+++ b/user/src/com/google/gwt/resources/client/ImageResource.java
@@ -147,4 +147,10 @@
* Return codetrue/code if the image contains multiple frames.
*/
boolean isAnimated();
+
+ /**
+ * Returns codetrue/code if the image is standalone,
codefalse/code
+ * if it's a region of a composite image.
+ */
+ boolean isStandalone();
}
diff --git
a/user/src/com/google/gwt/resources/client/impl/ImageResourcePrototype.java
b/user/src/com/google/gwt/resources/client/impl/ImageResourcePrototype.java
index 7a422d4..ffabd21 100644
---
a/user/src/com/google/gwt/resources/client/impl/ImageResourcePrototype.java
+++
b/user/src/com/google/gwt/resources/client/impl/ImageResourcePrototype.java
@@ -26,6 +26,7 @@
private final boolean animated;
private final boolean lossy;
+ private final boolean standalone;
private final String name;
private final SafeUri url;
private final int left;
@@ -37,7 +38,7 @@
* Only called by generated code.
*/
public ImageResourcePrototype(String name, SafeUri url, int left, int
top, int width, int height,
- boolean animated, boolean lossy) {
+ boolean animated, boolean lossy, boolean standalone) {
this.name = name;
this.left = left;
this.top = top;
@@ -46,6 +47,7 @@
this.url = url;
this.animated = animated;
this.lossy = lossy;
+this.standalone = standalone;
}
/**
@@ -95,4 +97,9 @@
public boolean isLossy() {
return lossy;
}
+
+ @Override
+ public boolean isStandalone() {
+return standalone;
+ }
}
diff --git
a/user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java
b/user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java
index 4509439..9e25e69 100644
--- a/user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java
+++ b/user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java
@@ -71,6 +71,11 @@
localizedByImageResource = Maps.create();
}
+@Override
+public boolean isStandalone() {
+ return false;
+}
+
public LocalizedImage addImage(TreeLogger logger, ResourceContext
context,
ImageResourceDeclaration image) throws UnableToCompleteException,
CannotBundleImageException {
@@ -192,6 +197,7 @@
if (isExternal) {
return External: + image.get();
}
+ // test mirrored in prepare(), make sure to keep them in sync
if (image.isPreventInlining() || image.getRepeatStyle() ==
RepeatStyle.Both) {
return Unbundled: + image.get();
}
@@ -253,6 +259,8 @@
protected String normalContentsFieldName;
protected String rtlContentsFieldName;
+public abstract boolean isStandalone();
+
public abstract ImageRect getImageRect(ImageResourceDeclaration image);
/**
@@ -293,6 +301,11 @@
this.image = image;
this.localized = localized;
this.rect = rect;
+}
[gwt-contrib] Change in gwt[master]: Add support for the newer bindery HandlerRegistration Bug:...
Julien Dramaix has posted comments on this change. Change subject: Add support for the newer bindery HandlerRegistration Bug: issue 7079 Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 .. Patch Set 4: Why the build failed ? -- To view, visit https://gwt-review.googlesource.com/1350 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add support for the newer bindery HandlerRegistration Bug:...
Roberto Lublinerman has posted comments on this change. Change subject: Add support for the newer bindery HandlerRegistration Bug: issue 7079 Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 .. Patch Set 4: The Jenkins server run out of disk (I think) and this failure might be the result of that. It has been fixed now but I don't think this patch will be resubmitted for testing. For sure when a new patch is uploaded, it will be tested. To see the output just click on the Jenkins link and and then go to console output. -- To view, visit https://gwt-review.googlesource.com/1350 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Fixes #8036, properly sorting of places in PlaceHistoryGeneratorContext (issue1895803)
On 2013/05/28 08:52:04, larsaaslin wrote: Can I run only MostToLeastDerivedPlaceTypeComparatorTest with an ant command? Yes ant test -Dgwt.junit.testcase.includes=**/MostToLeastDerivedPlaceTypeComparatorTest.class or cd user ant test.nongwt -Dgwt.nongwt.testcase.includes=**/MostToLeastDerivedPlaceTypeComparatorTest.class Only getting the following errors when I run it from Eclipse: java.lang.NullPointerException at com.google.gwt.dev.util.Util.copyNoClose(Util.java:265) at com.google.gwt.dev.util.Util.copy(Util.java:186) at com.google.gwt.dev.util.Util.readStreamAsString(Util.java:713) at com.google.gwt.place.rebind.RealJavaResource.getContent(RealJavaResource.java:41) Make sure you include the sources into the classpath. http://gwt-code-reviews.appspot.com/1895803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Fixes #8036, properly sorting of places in PlaceHistoryGeneratorContext (issue1895803)
On 2013/04/08 23:51:51, goktug wrote: On 2013/04/04 14:06:13, tbroyer wrote: We just need someone with commit rights. Calling in Matthew (at random), who will delegate if needed. I'm not sure if this doesn't introduce any new problems and solves all problems with the comparator. Can you reproduce the problem in MostToLeastDerivedPlaceTypeComparatorTest and additional test cases? Can I run only MostToLeastDerivedPlaceTypeComparatorTest with an ant command? Only getting the following errors when I run it from Eclipse: java.lang.NullPointerException at com.google.gwt.dev.util.Util.copyNoClose(Util.java:265) at com.google.gwt.dev.util.Util.copy(Util.java:186) at com.google.gwt.dev.util.Util.readStreamAsString(Util.java:713) at com.google.gwt.place.rebind.RealJavaResource.getContent(RealJavaResource.java:41) at com.google.gwt.dev.javac.testing.impl.MockResource.openContents(MockResource.java:74) at com.google.gwt.dev.javac.CompilationUnitBuilder$ResourceCompilationUnitBuilder.doGetSource(CompilationUnitBuilder.java:144) at com.google.gwt.dev.javac.CompilationUnitBuilder.getSource(CompilationUnitBuilder.java:286) at com.google.gwt.dev.javac.JdtCompiler$Adapter.getContents(JdtCompiler.java:203) at org.eclipse.jdt.internal.compiler.parser.Parser.parse(Parser.java:9485) at org.eclipse.jdt.internal.compiler.parser.Parser.parse(Parser.java:9457) at org.eclipse.jdt.internal.compiler.parser.Parser.dietParse(Parser.java:8102) at org.eclipse.jdt.internal.compiler.Compiler.internalBeginToCompile(Compiler.java:696) at org.eclipse.jdt.internal.compiler.Compiler.beginToCompile(Compiler.java:376) at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:420) at com.google.gwt.dev.javac.JdtCompiler.doCompile(JdtCompiler.java:718) at com.google.gwt.dev.javac.CompilationStateBuilder$CompileMoreLater.compile(CompilationStateBuilder.java:248) at com.google.gwt.dev.javac.CompilationStateBuilder.doBuildFrom(CompilationStateBuilder.java:464) at com.google.gwt.dev.javac.CompilationStateBuilder.buildFrom(CompilationStateBuilder.java:388) at com.google.gwt.dev.javac.CompilationStateBuilder.buildFrom(CompilationStateBuilder.java:376) at com.google.gwt.place.rebind.MostToLeastDerivedPlaceTypeComparatorTest.setUp(MostToLeastDerivedPlaceTypeComparatorTest.java:72) at junit.framework.TestCase.runBare(TestCase.java:132) at junit.framework.TestResult$1.protect(TestResult.java:110) at junit.framework.TestResult.runProtected(TestResult.java:128) at junit.framework.TestResult.run(TestResult.java:113) at junit.framework.TestCase.run(TestCase.java:124) at junit.framework.TestSuite.runTest(TestSuite.java:243) at junit.framework.TestSuite.run(TestSuite.java:238) at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130) at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197) http://gwt-code-reviews.appspot.com/1895803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix for issue 1525
Hilbrand Bouwkamp has posted comments on this change. Change subject: Fix for issue 1525 .. Patch Set 2: I tested it and it doesn't seem native buttons work like that. If you mouse click on a native button, hold it, and move the mouse outside the button other elements do get mouseover and mouseout events. I also created a test (not added here) with a native preview handler. It does work, except when you move the mouse (quickly) outside the browser window, in which case it can happen that no native preview event is triggered until you move the mouse inside the window again. However, it's also about 15 lines (of code), which seems a lot of code for a workaround for a small but annoying bug. -- To view, visit https://gwt-review.googlesource.com/2922 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d49cae5ce0f8b8248aa15347914a5cd8da95287 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Hilbrand Bouwkamp hilbr...@h72.nl Gerrit-Reviewer: Hilbrand Bouwkamp hilbr...@h72.nl Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds support for lower case encoding names to String
Thomas Broyer has posted comments on this change.
Change subject: Adds support for lower case encoding names to String
..
Patch Set 1: Code-Review+1
(2 comments)
Only nits within tests; the fix is otherwise OK.
File user/test/com/google/gwt/emultest/java/lang/StringTest.java
Line 612:
nit: remove whitespace
Line 613: private void testConstructorLatin1(String encoding) throws
UnsupportedEncodingException {
nit: can you move those private methods right below the test methods that
call them?
--
To view, visit https://gwt-review.googlesource.com/3000
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9532ba1e7e6e863093727e354f7f3174229c2ab
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Honza Rameš rame...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Make Element.hasTagName(...) case-insensitive.
Thomas Broyer has posted comments on this change. Change subject: Make Element.hasTagName(...) case-insensitive. .. Patch Set 1: Do you think we could add a test for that? (in ElementTest; something like createDivElement() and then hasTagName(div) and hasTagName(DIV) should both be OK) -- To view, visit https://gwt-review.googlesource.com/2975 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib24bee7fa494c0345a7bc97e1b5df1095a05d024 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roy Paterson roy.pater...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add static is(...) to complement as as(...).
Thomas Broyer has posted comments on this change. Change subject: Add static is(...) to complement as as(...). .. Patch Set 1: Code-Review+1 (3 comments) Could you add a test (not for all elements) in ElementTest#testIsOrAs ? File user/src/com/google/gwt/dom/client/AnchorElement.java Line 38: nit: whitespace Line 41:* A codenull/code node will cause this method to return This is not what's implemented: null will cause an exception. Line 45: return elem.getTagName().equalsIgnoreCase(TAG); Couldn't this use hasTagName(TAG) ? -- To view, visit https://gwt-review.googlesource.com/2976 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14aa6163e52adb2f71cd1ca3557ff3514571a6a2 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roy Paterson roy.pater...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add static is(...) to complement as as(...).
Thomas Broyer has posted comments on this change.
Change subject: Add static is(...) to complement as as(...).
..
Patch Set 1:
(1 comment)
File user/src/com/google/gwt/dom/client/AnchorElement.java
Line 41:* A codenull/code node will cause this method to return
Given that the various existing as() and is() methods all accept null, I'd
rather accept it and do as the javadoc says (i.e. fix the code rather than
the doc).
I also wonder if we should add a is(Node) and is(JavaScriptObject) like in
Element (Element redefines a is(JavaScriptObject) and adds a is(Element);
we could redefine both those methods and add the is(Element)):
public static boolean is(JavaScriptObject o) {
if (Element.is(o)) {
return is((Element) o);
}
return false;
}
public static boolean is(Node node) {
if (Element.is(node)) {
return is((Element) node);
}
return false;
}
Maybe we could do that in a later patch if you don't feel like adding them
now, let's see what others think.
--
To view, visit https://gwt-review.googlesource.com/2976
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14aa6163e52adb2f71cd1ca3557ff3514571a6a2
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roy Paterson roy.pater...@gmail.com
Gerrit-Reviewer: Roy Paterson roy.pater...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds support for lower case encoding names to String
Thomas Broyer has posted comments on this change. Change subject: Adds support for lower case encoding names to String .. Patch Set 2: Code-Review+2 Note: our CI server seems broken, and we cannot submit until it's fixed; I'd otherwise have merged the change. Will merge asap. -- To view, visit https://gwt-review.googlesource.com/3000 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9532ba1e7e6e863093727e354f7f3174229c2ab Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Honza Rameš rame...@gmail.com Gerrit-Reviewer: Honza Rameš rame...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds support for lower case encoding names to String
James Nelson has posted comments on this change.
Change subject: Adds support for lower case encoding names to String
..
Patch Set 2:
(1 comment)
lgtm;
made a nit for production mode performance (using native js regex), though
I'm not sure it's worth it.
File user/super/com/google/gwt/emul/java/lang/String.java
Line 309: if (CHARSET_UTF8.equalsIgnoreCase(charset)) {
I wonder if we might see better performance using native methods w/ js
regex.
native boolean isUtf8(String charset)
/*-[
return (charset||'').match(/utf-8/i)
]-*/;
--
To view, visit https://gwt-review.googlesource.com/3000
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9532ba1e7e6e863093727e354f7f3174229c2ab
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Honza Rameš rame...@gmail.com
Gerrit-Reviewer: Honza Rameš rame...@gmail.com
Gerrit-Reviewer: James Nelson ja...@wetheinter.net
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds support for lower case encoding names to String
James Nelson has posted comments on this change. Change subject: Adds support for lower case encoding names to String .. Patch Set 2: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/3000 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9532ba1e7e6e863093727e354f7f3174229c2ab Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Honza Rameš rame...@gmail.com Gerrit-Reviewer: Honza Rameš rame...@gmail.com Gerrit-Reviewer: James Nelson ja...@wetheinter.net Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Have SimpleCheckBox implement HasValue, fixes 4018.
Stephen Haberman has uploaded a new change for review.
https://gwt-review.googlesource.com/3010
Change subject: Have SimpleCheckBox implement HasValue, fixes 4018.
..
Have SimpleCheckBox implement HasValue, fixes 4018.
Change-Id: I790120198cb22ff38e676a303782b719f87083c6
---
M user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java
M user/test/com/google/gwt/user/client/ui/SimpleCheckBoxTest.java
2 files changed, 93 insertions(+), 2 deletions(-)
diff --git a/user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java
b/user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java
index 4975554..9007b0d 100644
--- a/user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java
+++ b/user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java
@@ -21,7 +21,11 @@
import com.google.gwt.editor.client.IsEditor;
import com.google.gwt.editor.client.LeafValueEditor;
import com.google.gwt.editor.client.adapters.TakesValueEditor;
-import com.google.gwt.user.client.TakesValue;
+import com.google.gwt.event.dom.client.ClickEvent;
+import com.google.gwt.event.dom.client.ClickHandler;
+import com.google.gwt.event.logical.shared.ValueChangeEvent;
+import com.google.gwt.event.logical.shared.ValueChangeHandler;
+import com.google.gwt.event.shared.HandlerRegistration;
/**
* A simple checkbox widget, with no label.
@@ -33,7 +37,7 @@
* /ul
*/
public class SimpleCheckBox extends FocusWidget implements HasName,
-TakesValueBoolean, IsEditorLeafValueEditorBoolean {
+HasValueBoolean, IsEditorLeafValueEditorBoolean {
/**
* Creates a SimpleCheckBox widget that wraps an existing lt;input
@@ -59,6 +63,7 @@
}
private LeafValueEditorBoolean editor;
+ private boolean valueChangeHandlerInitialized;
/**
* Creates a new simple checkbox.
@@ -84,6 +89,17 @@
if (styleName != null) {
setStyleName(styleName);
}
+ }
+
+ @Override
+ public HandlerRegistration addValueChangeHandler(
+ ValueChangeHandlerBoolean handler) {
+// Is this the first value change handler? If so, time to add handlers
+if (!valueChangeHandlerInitialized) {
+ ensureDomEventHandlers();
+ valueChangeHandlerInitialized = true;
+}
+return addHandler(handler, ValueChangeEvent.getType());
}
public LeafValueEditorBoolean asEditor() {
@@ -187,12 +203,45 @@
* @param value true to check, false to uncheck; null value implies false
*/
public void setValue(Boolean value) {
+setValue(value, false);
+ }
+
+ /**
+ * Checks or unchecks the check box, firing {@link ValueChangeEvent} if
+ * appropriate.
+ * p
+ * Note that this emdoes not/em set the value property of the
checkbox
+ * input element wrapped by this widget. For access to that property, see
+ * {@link #setFormValue(String)}
+ *
+ * @param value true to check, false to uncheck; null value implies false
+ * @param fireEvents If true, and value has changed, fire a
+ * {@link ValueChangeEvent}
+ */
+ @Override
+ public void setValue(Boolean value, boolean fireEvents) {
if (value == null) {
value = Boolean.FALSE;
}
+Boolean oldValue = getValue();
getInputElement().setChecked(value);
getInputElement().setDefaultChecked(value);
+if (value.equals(oldValue)) {
+ return;
+}
+if (fireEvents) {
+ ValueChangeEvent.fire(this, value);
+}
+ }
+
+ protected void ensureDomEventHandlers() {
+addClickHandler(new ClickHandler() {
+ @Override
+ public void onClick(ClickEvent event) {
+ValueChangeEvent.fire(SimpleCheckBox.this, getValue());
+ }
+});
}
/**
diff --git
a/user/test/com/google/gwt/user/client/ui/SimpleCheckBoxTest.java
b/user/test/com/google/gwt/user/client/ui/SimpleCheckBoxTest.java
index 7df2ec6..75bed2f 100644
--- a/user/test/com/google/gwt/user/client/ui/SimpleCheckBoxTest.java
+++ b/user/test/com/google/gwt/user/client/ui/SimpleCheckBoxTest.java
@@ -15,6 +15,9 @@
*/
package com.google.gwt.user.client.ui;
+import com.google.gwt.dom.client.ButtonElement;
+import com.google.gwt.event.logical.shared.ValueChangeEvent;
+import com.google.gwt.event.logical.shared.ValueChangeHandler;
import com.google.gwt.junit.client.GWTTestCase;
/**
@@ -22,11 +25,20 @@
*/
public class SimpleCheckBoxTest extends GWTTestCase {
+ private static class Handler implements ValueChangeHandlerBoolean {
+Boolean received = null;
+
+public void onValueChange(ValueChangeEventBoolean event) {
+ received = event.getValue();
+}
+ }
+
@Override
public String getModuleName() {
return com.google.gwt.user.UserTest;
}
+ @SuppressWarnings(deprecation)
public void testProperties() {
SimpleCheckBox checkbox = new SimpleCheckBox();
@@ -50,4 +62,34 @@
RootPanel.get().remove(checkbox);
assertEquals(true, checkbox.isChecked());
}
+
+ @SuppressWarnings(deprecation)
+ public void
[gwt-contrib] Change in gwt[master]: Add static is(...) to complement as as(...).
Thomas Broyer has posted comments on this change. Change subject: Add static is(...) to complement as as(...). .. Patch Set 1: (1 comment) Commit Message Line 12: Partially fixes issue 7756 Can you change this to point to issue 5723 (and remove partially; I think you can remove partially from your other commit too) -- To view, visit https://gwt-review.googlesource.com/2976 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14aa6163e52adb2f71cd1ca3557ff3514571a6a2 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roy Paterson roy.pater...@gmail.com Gerrit-Reviewer: Roy Paterson roy.pater...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Have SimpleCheckBox implement HasValue, fixes 4018.
Thomas Broyer has posted comments on this change.
Change subject: Have SimpleCheckBox implement HasValue, fixes 4018.
..
Patch Set 1: Code-Review+2
(2 comments)
File user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java
Line 230: if (value.equals(oldValue)) {
Can't we use ValueChangeEvent.fireIfNotEqual instead?
File user/test/com/google/gwt/user/client/ui/SimpleCheckBoxTest.java
Line 92: cb.getElement().ButtonElement cast().click();
Which makes me think that we should move click() up to Element (or possibly
add it to InputElement; I've had to do the same cast to ButtonElement for a
fileupload in an application)
--
To view, visit https://gwt-review.googlesource.com/3010
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I790120198cb22ff38e676a303782b719f87083c6
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Source tab at code.google.com
Hi there, Can someone with admin rights on the code.google.com project change the Source tab to show a wiki page pointing to gwt.googlesource.com for browsing the sources, and gwtproject.org/makinggwtbetter.html for working with the code? (and maybe also have links to .../source/browse/ and .../source/list to access the archives) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add static is(...) to complement as as(...).
Daniel Kurka has posted comments on this change. Change subject: Add static is(...) to complement as as(...). .. Patch Set 2: Could you rebase on trunk? -- To view, visit https://gwt-review.googlesource.com/2976 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14aa6163e52adb2f71cd1ca3557ff3514571a6a2 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roy Paterson roy.pater...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Roy Paterson roy.pater...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add support for the newer bindery HandlerRegistration Bug:...
Hello Manuel Carrasco Moñino, Matthew Dempsky, Thomas Broyer, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a rebased change. Please visit https://gwt-review.googlesource.com/1350 to look at the new rebased patch set (#5). Change subject: Add support for the newer bindery HandlerRegistration Bug: issue 7079 Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 .. Add support for the newer bindery HandlerRegistration Bug: issue 7079 Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 --- M user/src/com/google/gwt/uibinder/rebind/HandlerEvaluator.java M user/test/com/google/gwt/uibinder/rebind/HandlerEvaluatorTest.java 2 files changed, 4 insertions(+), 3 deletions(-) -- To view, visit https://gwt-review.googlesource.com/1350 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Unary plus in Jsni code was always discarded.
Matthew Dempsky has posted comments on this change. Change subject: Unary plus in Jsni code was always discarded. .. Patch Set 1: Code-Review+1 Do you know why we needed to roll the fix back originally? Is that something we'll need to worry about again? -- To view, visit https://gwt-review.googlesource.com/2990 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d260d7fdc08b942f44b0275fb1c842be1c807fd Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Resolving issues
Hi Folks, Open issues in gwt-steering don't seem to get resolved unless either there's a SC meeting, or someone send a poll email asking people for their opinions, which sometimes take too long. I'd like to propose that we make this a more formal process, so we'll get quicker decisions. Here's my thoughts on a process: 1. Initiator sends email to gwt-contrib gwt-steering to get initial thoughts, asking for responses within a fixed timeframe. For example: I propose we drop support for IE8 in GWT 3.0, coming around spring 2014. The motivation is to get some conversation going, as well as flushing out some of the questions, for example: does that mean we will continue to update 2.6 for those who need IE8 support', or 'when does IE8 support start disappearing from trunk?'. 2. After the specified time period, if there's enough initial support, the initiator writes up a formal proposal (in Google docs) in a template similar to: 1. Proposal 2. Motivation 3. Schedule 4. Owner(2) 5. Decision date and checkbox for each SC member to signify position on it (yes, no, nuetral) 3. The proposal is discussed in the Google doc (open to comments from everyone, but editable only by the owner). 4. By the decision date, each SC member indicates whether they support the proposal. If a SC meeting is needed, a meeting is held. Note: I'm not saying we do this for every CL or change in GWT - that should be the decision of the committers and reviewers. This is for mainly higher level (perhaps non-technical) decisions. Thoughts? Bhaskar -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] GWT presentations
Hi all, I saw presentations in the page are very old. How we can improve that? http://www.gwtproject.org/presentations.html Regards -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Have SimpleCheckBox implement HasValue, fixes 4018.
Hello Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3010 to look at the new patch set (#2). Change subject: Have SimpleCheckBox implement HasValue, fixes 4018. .. Have SimpleCheckBox implement HasValue, fixes 4018. Change-Id: I790120198cb22ff38e676a303782b719f87083c6 --- M user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java M user/test/com/google/gwt/user/client/ui/SimpleCheckBoxTest.java 2 files changed, 90 insertions(+), 2 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3010 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I790120198cb22ff38e676a303782b719f87083c6 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Have SimpleCheckBox implement HasValue, fixes 4018.
Stephen Haberman has posted comments on this change.
Change subject: Have SimpleCheckBox implement HasValue, fixes 4018.
..
Patch Set 1:
(2 comments)
File user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java
Line 230: if (value.equals(oldValue)) {
Yeah; this code is copy/pasted from CheckBox, and I had thought of using
fireIfNotEqual, but went back and forth on keeping it like CheckBox or not;
technically fireIfNotEqual does a few more operations (null checks) but it
won't matter.
I'll use fireIfNotEqual instead.
File user/test/com/google/gwt/user/client/ui/SimpleCheckBoxTest.java
Line 92: cb.getElement().ButtonElement cast().click();
Would be fine with me; I admittedly copy/pasted this from one of your
Stackoverflow answers. :-)
--
To view, visit https://gwt-review.googlesource.com/3010
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I790120198cb22ff38e676a303782b719f87083c6
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: GWT presentations
You can pull gwt-site from gwt.googlesource.com and then update https://gwt.googlesource.com/gwt-site/+/master/src/main/markdown/presentations.md Finally push your changes to Gerrit for review. http://www.gwtproject.org/makinggwtbetter.html#webpage -- J. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: GWT presentations
Thanks! 2013/5/28 Jens jens.nehlme...@gmail.com You can pull gwt-site from gwt.googlesource.com and then update https://gwt.googlesource.com/gwt-site/+/master/src/main/markdown/presentations.md Finally push your changes to Gerrit for review. http://www.gwtproject.org/makinggwtbetter.html#webpage -- J. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Resolving issues
1. Initiator sends email to gwt-contrib gwt-steering to get initial thoughts, asking for responses within a fixed timeframe. I don't see the point of duplicating the discussion by putting gwt-contrib and gwt-steering in cc. Once Gerrit does not send mails to gwt-contrib I think gwt-contrib will be easy to follow as currently there are not a lot non-gerrit posts. So I would vote for holding the whole discussion on gwt-contrib only, and announce the final decision for a proposal on gwt-steering. Also who is Initiator? Everyone or just SC members? I assume its just SC members because you said you want the discussion on both mailing lists as gwt-steering is read only for most of us. 2. After the specified time period, if there's enough initial support, the initiator writes up a formal proposal (in Google docs) in a template similar to: 1. Proposal 2. Motivation 3. Schedule 4. Owner(2) 5. Decision date and checkbox for each SC member to signify position on it (yes, no, nuetral) A proposal template should be created. If you mean everyone with Initiator then it should be uploaded/linked somewhere where its easy to find (gwtproject.org) 3. The proposal is discussed in the Google doc (open to comments from everyone, but editable only by the owner). 4. By the decision date, each SC member indicates whether they support the proposal. If a SC meeting is needed, a meeting is held. Basically I like the idea of having a formal document describing the issue and after the whole decision process is done that contains the votes (and maybe reasons of a no vote) of each steering member. In an ideal world I would like to see a condensed view of all steering decisions (= link to the final signed proposal) on gwtproject.org along with links to relevant information (gwt-contrib discussion, meeting minutes) that have led to these decisions. That would give visitors of gwtproject.org a strong signal how decisions are made in GWT and who made them (name + company name if available). If the who part also contains the company name its also a strong signal that GWT probably wont die anytime soon because some big players are involved. Basically I would not like to search for decisions on gwt-steering because it is polluted with lots of discussions over time. IMHO a mailing list is just bad for documenting these more important, high level issues and decisions. -- J. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Removing support for old browsers
Agreed. I think we need to think about the permutations and soft vs. hard for future releases. We started to have more and more newer vs older separations instead of Browser A ve Browser B separations, especially with the new-ish IEs. On Mon, May 27, 2013 at 11:42 AM, Matthew Dempsky mdemp...@google.comwrote: [-gwt-steering, +gwt-contrib] On Mon, May 27, 2013 at 9:32 AM, Daniel Kurka danku...@google.com wrote: We also need the permutations for blink. Are there technical reasons for why we need to remove permutations to be able to add new ones? E.g., why can't we start using soft permutationshttps://code.google.com/p/google-web-toolkit/wiki/SoftPermutationsby default to limit permutation growth from old or similar permutations? I'm also curious what reasons you had in mind for needing a Blink-specific permutation in GWT. Chromium and Firefox have policies now to avoid introducing vendor prefixes for new functionality, so a Blink permutation seems limited in use to working around bugs or performance tuning. Not to mention GWT's release and update cycles are much slower than Chromium and Firefox's, so it's likely our tweaks/workarounds are irrelevant before GWT users can start utilizing them. ;) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds support for lower case encoding names to String
John A. Tamplin has posted comments on this change. Change subject: Adds support for lower case encoding names to String .. Patch Set 2: If you are going for the regex, you probably want to create the pattern once and reuse it rather than creating a new pattern every time. Also, doesn't the pattern need to be anchored? I don't care much either way -- I can't imagine that looking up a character set is going to be very common. -- To view, visit https://gwt-review.googlesource.com/3000 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9532ba1e7e6e863093727e354f7f3174229c2ab Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Honza Rameš rame...@gmail.com Gerrit-Reviewer: Honza Rameš rame...@gmail.com Gerrit-Reviewer: James Nelson ja...@wetheinter.net Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds support for lower case encoding names to String
Goktug Gokdogan has posted comments on this change. Change subject: Adds support for lower case encoding names to String .. Patch Set 2: Code-Review+1 Simple comparison is OK; it is simpler and fast enough. Don't need to investigate the regex route any further. -- To view, visit https://gwt-review.googlesource.com/3000 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9532ba1e7e6e863093727e354f7f3174229c2ab Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Honza Rameš rame...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Honza Rameš rame...@gmail.com Gerrit-Reviewer: James Nelson ja...@wetheinter.net Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Have SimpleCheckBox implement HasValue, fixes 4018.
Goktug Gokdogan has posted comments on this change. Change subject: Have SimpleCheckBox implement HasValue, fixes 4018. .. Patch Set 2: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3010 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I790120198cb22ff38e676a303782b719f87083c6 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Make Element.hasTagName(...) case-insensitive.
Goktug Gokdogan has posted comments on this change. Change subject: Make Element.hasTagName(...) case-insensitive. .. Patch Set 3: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/2975 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib24bee7fa494c0345a7bc97e1b5df1095a05d024 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roy Paterson roy.pater...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Fixes #8036, properly sorting of places in PlaceHistoryGeneratorContext (issue1895803)
On 2013/04/08 23:51:51, goktug wrote: On 2013/04/04 14:06:13, tbroyer wrote: We just need someone with commit rights. Calling in Matthew (at random), who will delegate if needed. I'm not sure if this doesn't introduce any new problems and solves all problems with the comparator. Can you reproduce the problem in MostToLeastDerivedPlaceTypeComparatorTest and additional test cases? The test I added in PlaceHistoryMapperGeneratorTest.java is an example of reproducing the problem since it will fail if executed with the original version of MostToLeastDerivedPlaceTypeComparator.java. I also added a new patch set that fixes MostToLeastDerivedPlaceTypeComparatorTest.java which, from what I can see, haven't been working properly before. Please let me now if there is anything more I can do. http://gwt-code-reviews.appspot.com/1895803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds support for lower case encoding names to String
James Nelson has posted comments on this change. Change subject: Adds support for lower case encoding names to String .. Patch Set 2: Aye, my tests on the regex show it way slower, even with cached regex matcher. equalsIgnoreCase is the better solution. So, my bad there. Next time I'll test before I suggest ;) -- To view, visit https://gwt-review.googlesource.com/3000 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9532ba1e7e6e863093727e354f7f3174229c2ab Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Honza Rameš rame...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Honza Rameš rame...@gmail.com Gerrit-Reviewer: James Nelson ja...@wetheinter.net Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: ActivityManager fails to clear Eventbus
Goktug Gokdogan has posted comments on this change. Change subject: ActivityManager fails to clear Eventbus .. Patch Set 1: Code-Review-2 This doesn't look safe. The API permits setDisplay to be called any time and any number of times and unfortunately semantics are unfortunately not very clear for different scenarios. Currently, calling setDisplay with 'null' doesn't cause stop behavior on activities which means, they are still active in active state. If you call remove handlers, it will break the active Activity. Safe thing to do is to actually, stop the active Activity and let it remove the handlers and the next time setDisplay is called with a new display reactivate the activity with the correct display. I can imagine even that behavior will potentially break some projects. -- To view, visit https://gwt-review.googlesource.com/2974 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ffb6911b0723969001bd43c73059b4dfad104cf Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Make Element.hasTagName(...) case-insensitive.
Goktug Gokdogan has posted comments on this change. Change subject: Make Element.hasTagName(...) case-insensitive. .. Patch Set 3: Code-Review+1 Opps, Thomas has some comments. I'll revert to +1 and let him to do +2. -- To view, visit https://gwt-review.googlesource.com/2975 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib24bee7fa494c0345a7bc97e1b5df1095a05d024 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roy Paterson roy.pater...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds support for lower case encoding names to String
Goktug Gokdogan has posted comments on this change. Change subject: Adds support for lower case encoding names to String .. Patch Set 2: Optimization is a black art; it is always better to go with simpler when in doubt :) -- To view, visit https://gwt-review.googlesource.com/3000 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9532ba1e7e6e863093727e354f7f3174229c2ab Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Honza Rameš rame...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Honza Rameš rame...@gmail.com Gerrit-Reviewer: James Nelson ja...@wetheinter.net Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add static is(...) to complement as as(...).
Goktug Gokdogan has posted comments on this change. Change subject: Add static is(...) to complement as as(...). .. Patch Set 2: Code-Review+1 I didn't go over all files but I'm ok with the change in principle :) -- To view, visit https://gwt-review.googlesource.com/2976 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14aa6163e52adb2f71cd1ca3557ff3514571a6a2 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roy Paterson roy.pater...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Roy Paterson roy.pater...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Stephen Haberman has uploaded a new change for review.
https://gwt-review.googlesource.com/3030
Change subject: Fix non-final field initializers running before the super
cstr.
..
Fix non-final field initializers running before the super cstr.
Previously, any field with an initializer would get assigned at
the top-level scope, before any cstrs had run.
However, this does not match the JVM behavior, which is that final fields
behave
this way, but non-field fields have their type's default value assigned when
super cstrs run, and then only later in their cstr are assigned to the
initializer.
Fixes #380.
Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918
---
M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git
a/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
b/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
index c0e1423..7a93095 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
@@ -857,10 +857,13 @@
JsNameRef localRef = (JsNameRef) pop(); // localRef
JVariable target = x.getVariableRef().getTarget();
- if (target instanceof JField ((JField)
target).getLiteralInitializer() != null) {
-// Will initialize at top scope; no need to double-initialize.
-push(null);
-return;
+ if (target instanceof JField) {
+JField field = (JField) target;
+if (field.isFinal() field.getLiteralInitializer() != null) {
+ // Will initialize at top scope; no need to double-initialize.
+ push(null);
+ return;
+}
}
JsBinaryOperation binOp =
@@ -891,8 +894,13 @@
public void endVisit(JField x, Context ctx) {
// if we need an initial value, create an assignment
if (x.getLiteralInitializer() != null) {
-// setup the constant value
-accept(x.getLiteralInitializer());
+if (x.isFinal()) {
+ // setup the constant value
+ accept(x.getLiteralInitializer());
+} else {
+ // setup the default value, see Issue 380
+ accept(x.getType().getDefaultValue());
+}
} else if (!x.hasInitializer() x.getEnclosingType() !=
program.getTypeJavaLangObject()) {
// setup a default value
accept(x.getType().getDefaultValue());
--
To view, visit https://gwt-review.googlesource.com/3030
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Matthew Dempsky has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 1: (1 comment) Commit Message Line 16: Fixes #380. Can you change this to Bug: issue 380 and move it right above the Change-Id line, please? -- To view, visit https://gwt-review.googlesource.com/3030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Stephen Haberman has uploaded a new patch set (#2). Change subject: Fix non-final field initializers running before the super cstr. .. Fix non-final field initializers running before the super cstr. Previously, any field with an initializer would get assigned at the top-level scope, before any cstrs had run. However, this does not match the JVM behavior, which is that final fields behave this way, but non-field fields have their type's default value assigned when super cstrs run, and then only later in their cstr are assigned to the initializer. Bug: issue 380. Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 --- M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java 1 file changed, 14 insertions(+), 6 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Stephen Haberman has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 1: (1 comment) Commit Message Line 16: Fixes #380. Done -- To view, visit https://gwt-review.googlesource.com/3030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Stephen Haberman has uploaded a new patch set (#3). Change subject: Fix non-final field initializers running before the super cstr. .. Fix non-final field initializers running before the super cstr. Previously, any field with an initializer would get assigned at the top-level scope, before any cstrs had run. However, this does not match the JVM behavior, which is that final fields behave this way, but non-field fields have their type's default value assigned when super cstrs run, and then only later in their cstr are assigned to the initializer. Bug: issue 380 Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 --- M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java 1 file changed, 14 insertions(+), 6 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Matthew Dempsky has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 3: Is it possible to write a regression test for this too? -- To view, visit https://gwt-review.googlesource.com/3030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Have SimpleCheckBox implement HasValue.
Hello Thomas Broyer, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3010 to look at the new patch set (#3). Change subject: Have SimpleCheckBox implement HasValue. .. Have SimpleCheckBox implement HasValue. Bug: issue 4018 Change-Id: I790120198cb22ff38e676a303782b719f87083c6 --- M user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java M user/test/com/google/gwt/user/client/ui/SimpleCheckBoxTest.java 2 files changed, 90 insertions(+), 2 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3010 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I790120198cb22ff38e676a303782b719f87083c6 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix ValuePicker.setValue(T) to no longer fire events.
Goktug Gokdogan has posted comments on this change. Change subject: Fix ValuePicker.setValue(T) to no longer fire events. .. Patch Set 2: Code-Review+2 Unfortunately, this is a breaking change. Marked the issue accordingly. -- To view, visit https://gwt-review.googlesource.com/2980 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Have SimpleCheckBox implement HasValue.
Goktug Gokdogan has posted comments on this change. Change subject: Have SimpleCheckBox implement HasValue. .. Patch Set 3: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3010 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I790120198cb22ff38e676a303782b719f87083c6 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: JsRootScope contained typo in literal
Daniel Kurka has submitted this change and it was merged. Change subject: JsRootScope contained typo in literal .. JsRootScope contained typo in literal fixes issue 8123 Change-Id: Ia301464078cd57ba91234cdc886644bcdf3973e9 --- M dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Leeroy Jenkins: Verified Thomas Broyer: Looks good to me, approved diff --git a/dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java b/dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java index 11df9f1..b214d78 100644 --- a/dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java +++ b/dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java @@ -49,7 +49,7 @@ eval, parseInt, parseFloat, - isNan, + isNaN, isFinite, // 15.1.3 URI Handling Function Properties -- To view, visit https://gwt-review.googlesource.com/2972 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia301464078cd57ba91234cdc886644bcdf3973e9 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: make FastMap use JavaScriptObject
Daniel Kurka has submitted this change and it was merged.
Change subject: make FastMap use JavaScriptObject
..
make FastMap use JavaScriptObject
fixes issue 2356
Change-Id: I6619b551b1b6421988479354a831ca745d06ab2e
---
M user/src/com/google/gwt/user/client/ui/FastStringMap.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Leeroy Jenkins: Verified
Thomas Broyer: Looks good to me, approved
diff --git a/user/src/com/google/gwt/user/client/ui/FastStringMap.java
b/user/src/com/google/gwt/user/client/ui/FastStringMap.java
index 4316783..8538ccc 100644
--- a/user/src/com/google/gwt/user/client/ui/FastStringMap.java
+++ b/user/src/com/google/gwt/user/client/ui/FastStringMap.java
@@ -268,7 +268,7 @@
}-*/;
private native void init() /*-{
-th...@com.google.gwt.user.client.ui.FastStringMap::map = [];
+th...@com.google.gwt.user.client.ui.FastStringMap::map = {};
}-*/;
private String keyMustBeString(Object key) {
--
To view, visit https://gwt-review.googlesource.com/2973
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6619b551b1b6421988479354a831ca745d06ab2e
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: fix mismatch in Double/Float.isInfinite between dev / produc...
Daniel Kurka has submitted this change and it was merged.
Change subject: fix mismatch in Double/Float.isInfinite between dev /
production
..
fix mismatch in Double/Float.isInfinite between dev / production
Double/Float.isFinite(Double/Float.NaN) behaved differently
in production
fixes ISSUE 8073
Change-Id: I6e7a891ff1339a64f3d9aaa57978fac6b23fdb64
---
M user/super/com/google/gwt/emul/java/lang/Double.java
M user/super/com/google/gwt/emul/java/lang/Float.java
M user/test/com/google/gwt/emultest/java/lang/DoubleTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
4 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
John A. Tamplin: Looks good to me, approved
Matthew Dempsky: Looks good to me, but someone else must approve
Leeroy Jenkins: Verified
Thomas Broyer: Looks good to me, but someone else must approve
Brian Slesinsky: Looks good to me, but someone else must approve
diff --git a/user/super/com/google/gwt/emul/java/lang/Double.java
b/user/super/com/google/gwt/emul/java/lang/Double.java
index 5144653..e32f9d2 100644
--- a/user/super/com/google/gwt/emul/java/lang/Double.java
+++ b/user/super/com/google/gwt/emul/java/lang/Double.java
@@ -192,7 +192,7 @@
}
public static native boolean isInfinite(double x) /*-{
-return !isFinite(x);
+return !isFinite(x) !isNaN(x);
}-*/;
public static native boolean isNaN(double x) /*-{
diff --git a/user/super/com/google/gwt/emul/java/lang/Float.java
b/user/super/com/google/gwt/emul/java/lang/Float.java
index f10cd9e..fe4bc2b 100644
--- a/user/super/com/google/gwt/emul/java/lang/Float.java
+++ b/user/super/com/google/gwt/emul/java/lang/Float.java
@@ -138,7 +138,7 @@
}
public static native boolean isInfinite(float x) /*-{
-return !isFinite(x);
+return !isFinite(x) !isNaN(x);
}-*/;
public static native boolean isNaN(float x) /*-{
diff --git a/user/test/com/google/gwt/emultest/java/lang/DoubleTest.java
b/user/test/com/google/gwt/emultest/java/lang/DoubleTest.java
index c5a6cc7..c00782e 100644
--- a/user/test/com/google/gwt/emultest/java/lang/DoubleTest.java
+++ b/user/test/com/google/gwt/emultest/java/lang/DoubleTest.java
@@ -119,6 +119,8 @@
// Double.MAX_EXPONENT);
// jdk1.6 assertEquals(Math.getExponent(Double.MIN_NORMAL),
// Double.MIN_EXPONENT);
+// issue 8073 - used to fail in prod mode
+assertFalse(Double.isInfinite(Double.NaN));
}
public void testParse() {
diff --git a/user/test/com/google/gwt/emultest/java/lang/FloatTest.java
b/user/test/com/google/gwt/emultest/java/lang/FloatTest.java
index 15c6718..67f5be6 100644
--- a/user/test/com/google/gwt/emultest/java/lang/FloatTest.java
+++ b/user/test/com/google/gwt/emultest/java/lang/FloatTest.java
@@ -64,6 +64,8 @@
// Math.getExponent(Float.MIN_NORMAL));
// jdk1.6 assertEquals(Float.MAX_EXPONENT,
// Math.getExponent(Float.MAX_VALUE));
+// issue 8073 - used to fail in prod mode
+assertFalse(Float.isInfinite(Float.NaN));
}
public void testParse() {
--
To view, visit https://gwt-review.googlesource.com/2250
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e7a891ff1339a64f3d9aaa57978fac6b23fdb64
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Ray Cromwell has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 3: Code-Review+1 It would be nice to have a GWTTestCase (to be run in web-mode) which tests against this (I guess by reading the value and finding it is already set), in case there is a regression. When we start mucking around with the code-gen for incremental JS output, it be nice to catch regressions. -- To view, visit https://gwt-review.googlesource.com/3030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Avoid NPE in Timestamp.equals.
Stephen Haberman has uploaded a new change for review.
https://gwt-review.googlesource.com/3011
Change subject: Avoid NPE in Timestamp.equals.
..
Avoid NPE in Timestamp.equals.
Bug: issue 6992
Change-Id: I044d3ddcabc5e41ed8fb9f871c35f700ff1d02eb
---
M user/super/com/google/gwt/emul/java/sql/Timestamp.java
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/user/super/com/google/gwt/emul/java/sql/Timestamp.java
b/user/super/com/google/gwt/emul/java/sql/Timestamp.java
index cfa4fa4..f63f359 100644
--- a/user/super/com/google/gwt/emul/java/sql/Timestamp.java
+++ b/user/super/com/google/gwt/emul/java/sql/Timestamp.java
@@ -128,7 +128,7 @@
}
public boolean equals(Timestamp ts) {
-return (getTime() == ts.getTime() getNanos() == ts.getNanos());
+return ts != null getTime() == ts.getTime() getNanos() ==
ts.getNanos();
}
public int getNanos() {
--
To view, visit https://gwt-review.googlesource.com/3011
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I044d3ddcabc5e41ed8fb9f871c35f700ff1d02eb
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Avoid NPE in Timestamp.equals.
Daniel Kurka has posted comments on this change. Change subject: Avoid NPE in Timestamp.equals. .. Patch Set 1: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3011 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044d3ddcabc5e41ed8fb9f871c35f700ff1d02eb Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Inliner produces incorrect code if a parameter is a new arra...
Roberto Lublinerman has uploaded a new change for review.
https://gwt-review.googlesource.com/3040
Change subject: Inliner produces incorrect code if a parameter is a new
array expression.
..
Inliner produces incorrect code if a parameter is a new array expression.
The inliner incorrectly inlines a call when a parameter is a new array
expression resulting in the new array contruct beign duplicated if more
that one reference to such parameter is present.
Fixes issue 6638.
Change-Id: Ic083ac15d7d84ab4728c441fd590977cd684a87a
---
M dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java
M dev/core/test/com/google/gwt/dev/jjs/impl/ExpressionAnalyzerTest.java
M user/test/com/google/gwt/dev/jjs/test/CompilerMiscRegressionTest.java
3 files changed, 27 insertions(+), 0 deletions(-)
diff --git
a/dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java
b/dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java
index 2b17399..3be97ad 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java
@@ -177,6 +177,7 @@
@Override
public void endVisit(JNewArray x, Context ctx) {
+createsObject = true;
/*
* If no array bounds, the new array is being automatically
initialized. If
* there are side-effects, they'll show up when we visit the
initializers.
diff --git
a/dev/core/test/com/google/gwt/dev/jjs/impl/ExpressionAnalyzerTest.java
b/dev/core/test/com/google/gwt/dev/jjs/impl/ExpressionAnalyzerTest.java
index 7cf1909..fb8bae5 100644
--- a/dev/core/test/com/google/gwt/dev/jjs/impl/ExpressionAnalyzerTest.java
+++ b/dev/core/test/com/google/gwt/dev/jjs/impl/ExpressionAnalyzerTest.java
@@ -168,6 +168,10 @@
analyzeExpression(boolean, FOO =
false).accessesFieldNonFinal().hasAssignmentToField().check();
}
+ public void testNewArray() throws Exception {
+analyzeExpression(float[], new float[3]).createsObject().check();
+ }
+
private Result analyzeExpression(String type, String expression)
throws UnableToCompleteException {
JProgram program = compileSnippet(type, return + expression + ;);
diff --git
a/user/test/com/google/gwt/dev/jjs/test/CompilerMiscRegressionTest.java
b/user/test/com/google/gwt/dev/jjs/test/CompilerMiscRegressionTest.java
index 841eec3..0ce2cd0 100644
--- a/user/test/com/google/gwt/dev/jjs/test/CompilerMiscRegressionTest.java
+++ b/user/test/com/google/gwt/dev/jjs/test/CompilerMiscRegressionTest.java
@@ -52,4 +52,26 @@
assertEquals(12.0, addAndConvert(10, 2));
assertEquals(-10.0, minusAndDecrement(11));
}
+ private static float[] copy(float[] src, float[] dest) {
+System.arraycopy(src, 0, dest, 0, Math.min(src.length, dest.length));
+return dest;
+ }
+
+ /**
+ * Test for issue 6638.
+ */
+ public void testNewArrayInlining() {
+float[] src = new float[]{1,1,1};
+float[] dest = copy(src, new float[3]);
+
+assertEqualContents(src, dest);
+ }
+
+ private static void assertEqualContents(float[] expected, float[]
actual) {
+
+assertEquals(Array length mismatch, expected.length, actual.length);
+for (int i = 0; i expected.length; i++) {
+ assertEquals(Array mismatch at element + i , expected[i],
actual[i]);
+}
+ }
}
--
To view, visit https://gwt-review.googlesource.com/3040
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic083ac15d7d84ab4728c441fd590977cd684a87a
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Unary plus in Jsni code was always discarded.
Hello Matthew Dempsky, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2990 to look at the new patch set (#2). Change subject: Unary plus in Jsni code was always discarded. .. Unary plus in Jsni code was always discarded. Unary plus in JavaScript is only noop when applied to a numeric value otherwise it behaves as a conversion to double operator. The compiler incorrectly assumed that is was a noop in all cases. The fix was already made in r5960 by cromwellian but was lost in a subsequent rollback (r5961). Fixes issue 6373 and issue 3942. Change-Id: I4d260d7fdc08b942f44b0275fb1c842be1c807fd --- M dev/core/src/com/google/gwt/dev/js/JsParser.java M dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java M dev/core/test/com/google/gwt/dev/js/JsToStringGenerationVisitorAccuracyTest.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/test/CompilerMiscRegressionTest.java 5 files changed, 82 insertions(+), 13 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2990 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4d260d7fdc08b942f44b0275fb1c842be1c807fd Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] GWT trunk with IntelliJ
Hi, I tried to create an IntelliJ 12 project with the following modules: - gwt-dev (imported from trunk/eclipse/dev) - gwt-user (imported from trunk/eclipse/user) - gwt-trunk-testing-app I want to run gwt-trunk-testing-app against the imported gwt-* modules but I can't figure out how to tell IntelliJ that it needs to include super source folders in classpath when launching DevMode or GWTTestCases. What I have done is: 1.) Setting up GWT_TOOLS and GWT_ROOT path variables 2.) After importing the gwt-dev/gwt-user modules from eclipse .classpath files. I had to adjust compile exclusions as IntelliJ did not set them up automatically. So I excluded all super folders in gwt-user/src and also super/com/google/gwt/dev/jjs/intrinsic in gwt-dev (Project Settings - Compiler - Excludes) 3.) Add module dependencies to gwt-trunk-testing-app. Now when creating a run configuration in IntelliJ (ordinary java application run config) I can only choose a classpath of a given module, so gwt-trunk-testing-app is the way to go. The problem is that I can't add additional super source folders to the classpath like in eclipse run configuration (classpath - user entries - folder). So I tried to figure out how I could add source folders to a module classpath: - creating a new library and adding source folders (gwt-dev/super, gwt-user/src, gwt-user/super) to it doesn't seem to work - marking super folders as source folders and then exclude them from compiling (Project Settings - Compiler - Excludes) doesn't work either. I am wondering if I am missing something obvious, as I am relatively new to IntelliJ, or if its just not possible to run DevMode using gwt-dev/gwt-user source in IntelliJ. Does anyone have a working setup for IntelliJ 12? -- J. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Fixes #8036, properly sorting of places in PlaceHistoryGeneratorContext (issue1895803)
On 2013/05/28 19:29:46, aaslin wrote: On 2013/04/08 23:51:51, goktug wrote: On 2013/04/04 14:06:13, tbroyer wrote: We just need someone with commit rights. Calling in Matthew (at random), who will delegate if needed. I'm not sure if this doesn't introduce any new problems and solves all problems with the comparator. Can you reproduce the problem in MostToLeastDerivedPlaceTypeComparatorTest and additional test cases? The test I added in PlaceHistoryMapperGeneratorTest.java is an example of reproducing the problem since it will fail if executed with the original version of MostToLeastDerivedPlaceTypeComparator.java. I also added a new patch set that fixes MostToLeastDerivedPlaceTypeComparatorTest.java which, from what I can see, haven't been working properly before. Please let me now if there is anything more I can do. Do you mind moving your patch to gwt-review.googlesource.com which is our newer code review system? About the test: Why did you change the order in the previous test case instead of adding new one? I think it would be best to see the new comparator working in as many scenarios as possible. Perhaps also we can simplify this further as we touch it. From what I can see, the only reason we have a TreeMap is because of getPlaceTypes call. We can keep the places in a LinkedHashMap and change getPlaceTypes to getSortedPlaceTypes and do the sort there. With that change we will avoid keeping a sorted list also we will no longer need to be consistent with equals in a comparator (i.e. you can just do return o2.getFlattenedSupertypeHierarchy().size() - o1.getFlattenedSupertypeHierarchy().size;). Anyway this refactoring is optional, I can do it later. http://gwt-code-reviews.appspot.com/1895803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Stephen Haberman has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 4: Okay, I added a test in CompilerTest--I had went looking for where to put the bug's reproduction before, but didn't find it, and so gave up too early. What's interesting is that I can't seem to get the Integer i3 = new Integer(1) case to pass. In the JVM, if the superclass reads this field via a subclass's method, it sees null. In JS, it sees undefined. I had thought the fix would be easy, just changing the push(null) statement (which assumes we can skip top-scope init because the subclass's cstr will do it) to also set the default value, but this causes strange/spurious-looking failures, like the tests won't even run in production mode. So it obviously does not like that, but I'm really puzzled as to how that would change the semantics. It just adds another preemptive field assignment to the JS...so fields that were previously undefined for awhile, then null/assigned, are now more immediately null. I'm puzzled; can someone else take a look? -- To view, visit https://gwt-review.googlesource.com/3030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Avoid NPE in Timestamp.equals.
Daniel Kurka has posted comments on this change. Change subject: Avoid NPE in Timestamp.equals. .. Patch Set 1: Stephan are you aware that you can commit these days now, using publish and submit? -- To view, visit https://gwt-review.googlesource.com/3011 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044d3ddcabc5e41ed8fb9f871c35f700ff1d02eb Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Avoid NPE in Timestamp.equals.
Stephen Haberman has posted comments on this change. Change subject: Avoid NPE in Timestamp.equals. .. Patch Set 1: Hi Daniel, no, I didn't know that--nifty! So, I assume the workflow is to wait until 1 reviewer + the jenkins build both vote okay, and I then go ahead and hit Publish and Submit? (I.e. I should do that now?) -- To view, visit https://gwt-review.googlesource.com/3011 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044d3ddcabc5e41ed8fb9f871c35f700ff1d02eb Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Avoid NPE in Timestamp.equals.
Stephen Haberman has submitted this change and it was merged.
Change subject: Avoid NPE in Timestamp.equals.
..
Avoid NPE in Timestamp.equals.
Bug: issue 6992
Change-Id: I044d3ddcabc5e41ed8fb9f871c35f700ff1d02eb
---
M user/super/com/google/gwt/emul/java/sql/Timestamp.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Kurka: Looks good to me, approved
Leeroy Jenkins: Verified
diff --git a/user/super/com/google/gwt/emul/java/sql/Timestamp.java
b/user/super/com/google/gwt/emul/java/sql/Timestamp.java
index cfa4fa4..f63f359 100644
--- a/user/super/com/google/gwt/emul/java/sql/Timestamp.java
+++ b/user/super/com/google/gwt/emul/java/sql/Timestamp.java
@@ -128,7 +128,7 @@
}
public boolean equals(Timestamp ts) {
-return (getTime() == ts.getTime() getNanos() == ts.getNanos());
+return ts != null getTime() == ts.getTime() getNanos() ==
ts.getNanos();
}
public int getNanos() {
--
To view, visit https://gwt-review.googlesource.com/3011
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I044d3ddcabc5e41ed8fb9f871c35f700ff1d02eb
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Have SimpleCheckBox implement HasValue.
Stephen Haberman has submitted this change and it was merged.
Change subject: Have SimpleCheckBox implement HasValue.
..
Have SimpleCheckBox implement HasValue.
Bug: issue 4018
Change-Id: I790120198cb22ff38e676a303782b719f87083c6
---
M user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java
M user/test/com/google/gwt/user/client/ui/SimpleCheckBoxTest.java
2 files changed, 90 insertions(+), 2 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Goktug Gokdogan: Looks good to me, approved
diff --git a/user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java
b/user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java
index 4975554..7e08f4c 100644
--- a/user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java
+++ b/user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java
@@ -21,7 +21,11 @@
import com.google.gwt.editor.client.IsEditor;
import com.google.gwt.editor.client.LeafValueEditor;
import com.google.gwt.editor.client.adapters.TakesValueEditor;
-import com.google.gwt.user.client.TakesValue;
+import com.google.gwt.event.dom.client.ClickEvent;
+import com.google.gwt.event.dom.client.ClickHandler;
+import com.google.gwt.event.logical.shared.ValueChangeEvent;
+import com.google.gwt.event.logical.shared.ValueChangeHandler;
+import com.google.gwt.event.shared.HandlerRegistration;
/**
* A simple checkbox widget, with no label.
@@ -33,7 +37,7 @@
* /ul
*/
public class SimpleCheckBox extends FocusWidget implements HasName,
-TakesValueBoolean, IsEditorLeafValueEditorBoolean {
+HasValueBoolean, IsEditorLeafValueEditorBoolean {
/**
* Creates a SimpleCheckBox widget that wraps an existing lt;input
@@ -59,6 +63,7 @@
}
private LeafValueEditorBoolean editor;
+ private boolean valueChangeHandlerInitialized;
/**
* Creates a new simple checkbox.
@@ -84,6 +89,17 @@
if (styleName != null) {
setStyleName(styleName);
}
+ }
+
+ @Override
+ public HandlerRegistration addValueChangeHandler(
+ ValueChangeHandlerBoolean handler) {
+// Is this the first value change handler? If so, time to add handlers
+if (!valueChangeHandlerInitialized) {
+ ensureDomEventHandlers();
+ valueChangeHandlerInitialized = true;
+}
+return addHandler(handler, ValueChangeEvent.getType());
}
public LeafValueEditorBoolean asEditor() {
@@ -187,12 +203,42 @@
* @param value true to check, false to uncheck; null value implies false
*/
public void setValue(Boolean value) {
+setValue(value, false);
+ }
+
+ /**
+ * Checks or unchecks the check box, firing {@link ValueChangeEvent} if
+ * appropriate.
+ * p
+ * Note that this emdoes not/em set the value property of the
checkbox
+ * input element wrapped by this widget. For access to that property, see
+ * {@link #setFormValue(String)}
+ *
+ * @param value true to check, false to uncheck; null value implies false
+ * @param fireEvents If true, and value has changed, fire a
+ * {@link ValueChangeEvent}
+ */
+ @Override
+ public void setValue(Boolean value, boolean fireEvents) {
if (value == null) {
value = Boolean.FALSE;
}
+Boolean oldValue = getValue();
getInputElement().setChecked(value);
getInputElement().setDefaultChecked(value);
+if (fireEvents) {
+ ValueChangeEvent.fireIfNotEqual(this, oldValue, value);
+}
+ }
+
+ protected void ensureDomEventHandlers() {
+addClickHandler(new ClickHandler() {
+ @Override
+ public void onClick(ClickEvent event) {
+ValueChangeEvent.fire(SimpleCheckBox.this, getValue());
+ }
+});
}
/**
diff --git
a/user/test/com/google/gwt/user/client/ui/SimpleCheckBoxTest.java
b/user/test/com/google/gwt/user/client/ui/SimpleCheckBoxTest.java
index 7df2ec6..75bed2f 100644
--- a/user/test/com/google/gwt/user/client/ui/SimpleCheckBoxTest.java
+++ b/user/test/com/google/gwt/user/client/ui/SimpleCheckBoxTest.java
@@ -15,6 +15,9 @@
*/
package com.google.gwt.user.client.ui;
+import com.google.gwt.dom.client.ButtonElement;
+import com.google.gwt.event.logical.shared.ValueChangeEvent;
+import com.google.gwt.event.logical.shared.ValueChangeHandler;
import com.google.gwt.junit.client.GWTTestCase;
/**
@@ -22,11 +25,20 @@
*/
public class SimpleCheckBoxTest extends GWTTestCase {
+ private static class Handler implements ValueChangeHandlerBoolean {
+Boolean received = null;
+
+public void onValueChange(ValueChangeEventBoolean event) {
+ received = event.getValue();
+}
+ }
+
@Override
public String getModuleName() {
return com.google.gwt.user.UserTest;
}
+ @SuppressWarnings(deprecation)
public void testProperties() {
SimpleCheckBox checkbox = new SimpleCheckBox();
@@ -50,4 +62,34 @@
RootPanel.get().remove(checkbox);
assertEquals(true, checkbox.isChecked());
}
+
+ @SuppressWarnings(deprecation)
+ public void
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Roberto Lublinerman has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 4: I'll take a look. -- To view, visit https://gwt-review.googlesource.com/3030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
