[gwt-contrib] Re: RR : GWT 2.0 : Shuffle ArgHandlers for DevMode
http://gwt-code-reviews.appspot.com/92804/diff/1/4 File dev/core/src/com/google/gwt/dev/GWTShell.java (right): http://gwt-code-reviews.appspot.com/92804/diff/1/4#newcode86 Line 86: registerHandler(new ArgHandlerOutDir(options)); Most of these don't really apply to GWTShell either -- they should be on Compiler (etc) and JUnitShell (since it can run the compiler for web-mode tests). http://gwt-code-reviews.appspot.com/92804 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] RR : GWT 2.0 : Shuffle ArgHandlers for DevMode
Reviewers: jat, Message: Review requested. @John, you have better state than I do on what flags can be usefully used with DevMode today. Description: DevMode has a bunch of irrelevant and confusing options since it doesn't support compiling the app into JS. This patch shuffles the ArgHandlers around from DevModeBase into GWTShell. Please review this at http://gwt-code-reviews.appspot.com/92804 Affected files: M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/GWTShell.java --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] RR : GWT 2.0 : Make SingleJsoImpl play nicely with generic parametrs in hosted mode
Reviewers: Lex, Message: Review requested. Description: This patch makes SingleJsoImpl interfaces that have generic method parameters work. Two real changes: - Always use erased types when computing method signatures - Used erased types when finding the concrete method that implements the abstract interface method Please review this at http://gwt-code-reviews.appspot.com/92803 Affected files: M dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java M user/test/com/google/gwt/dev/jjs/test/SingleJsoImplTest.java --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] RR : GWT 2.0 : Fix SingleJsoImpl and method overloads
Reviewers: Lex, Message: Review requsted Description: Adds support for overloaded method names to SingleJsoImpl Please review this at http://gwt-code-reviews.appspot.com/92801 Affected files: M dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java M dev/core/src/com/google/gwt/dev/shell/rewrite/HostedModeClassRewriter.java M dev/core/src/com/google/gwt/dev/shell/rewrite/RewriteSingleJsoImplDispatches.java M dev/core/src/com/google/gwt/dev/shell/rewrite/WriteJsoImpl.java M user/test/com/google/gwt/dev/jjs/test/SingleJsoImplTest.java --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Add support for launching a default browser from Swing interface
Reviewers: Ray Ryan, bruce, Description: This patch adds support for launching the user's default browser using several methods. This facility is then used for HelpInfo links in the logger detail messages (falling back to the old method of using the Swing HTML panel if none work), including the "launch browser" message. This won't launch automatically (there are still too many variables, such as wanting to launch a different browser or a particular profile), but it will make it much easier to launch if the default is what they want. It will also give a much better experience for clicking other HelpInfo links, such as the upgrade message. BrowserLauncher includes a main method that takes one or more URLs, so you can run it with an arg of http://www.google.com, for example, to make sure it works independent of the Swing logger. I have tested it on Linux with JDK 1.5 and 1.6 (which is significant since 1.6 adds a platform-independent way to launch the browser) -- please test on other platforms and make sure it works properly. Please review this at http://gwt-code-reviews.appspot.com/92802 Affected files: dev/core/src/com/google/gwt/core/ext/TreeLogger.java dev/core/src/com/google/gwt/dev/DevModeBase.java dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java dev/core/src/com/google/gwt/dev/util/BrowserLauncher.java --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Make Horiz and Vert constant parsers field ref friendly
Committed tr...@6632, releases/2...@6634 http://gwt-code-reviews.appspot.com/91811 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Make User depend upon UiBinder
Bob LGTM'd offline. committed tr...@6633, releases/2...@6634 http://gwt-code-reviews.appspot.com/89820 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit] r6634 committed - Merges tr...@6632, 6633 into this branch...
Revision: 6634
Author: rj...@google.com
Date: Tue Nov 3 21:19:08 2009
Log: Merges tr...@6632, 6633 into this branch
Make the alignment parsers field ref friendly, Makes User depend upon
UiBinder
svn merge --ignore-ancestry -r 6631:6633
https://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit/source/detail?r=6634
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/user/src/com/google/gwt/uibinder/parsers/HorizontalAlignmentConstantParser.java
/releases/2.0/user/src/com/google/gwt/uibinder/parsers/StrictAttributeParser.java
/releases/2.0/user/src/com/google/gwt/uibinder/parsers/VerticalAlignmentConstantParser.java
/releases/2.0/user/src/com/google/gwt/user/User.gwt.xml
/releases/2.0/user/test/com/google/gwt/uibinder/test/UiBinderTestApp.gwt.xml
/releases/2.0/user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml
===
--- /releases/2.0/branch-info.txt Tue Nov 3 18:02:50 2009
+++ /releases/2.0/branch-info.txt Tue Nov 3 21:19:08 2009
@@ -242,3 +242,7 @@
tr...@6612 was merged into this branch
Checkstyle fixes in UiBinder tests
svn merge --ignore-ancestry -c r6612
https://google-web-toolkit.googlecode.com/svn/trunk .
+
+tr...@6632, 6633 were merged into this branch
+ Make the alignment parsers field ref friendly, Makes User depend upon
UiBinder
+ svn merge --ignore-ancestry -r 6631:6633
https://google-web-toolkit.googlecode.com/svn/trunk .
===
---
/releases/2.0/user/src/com/google/gwt/uibinder/parsers/HorizontalAlignmentConstantParser.java
Mon Nov 2 13:18:15 2009
+++
/releases/2.0/user/src/com/google/gwt/uibinder/parsers/HorizontalAlignmentConstantParser.java
Tue Nov 3 21:19:08 2009
@@ -24,7 +24,7 @@
* Parses a
* {...@link
com.google.gwt.user.client.ui.HasHorizontalAlignment.HorizontalAlignmentConstant}.
*/
-public class HorizontalAlignmentConstantParser implements AttributeParser {
+public class HorizontalAlignmentConstantParser extends
StrictAttributeParser {
private static final HashMap values =
new HashMap();
@@ -41,9 +41,9 @@
public String parse(String value, MortalLogger logger)
throws UnableToCompleteException {
String translated = values.get(value);
-if (translated == null) {
- logger.die("Invalid value: horizontalAlignment='" + value + "'");
-}
-return translated;
+if (translated != null) {
+ return translated;
+}
+return super.parse(value, logger);
}
}
===
---
/releases/2.0/user/src/com/google/gwt/uibinder/parsers/StrictAttributeParser.java
Mon Nov 2 13:18:15 2009
+++
/releases/2.0/user/src/com/google/gwt/uibinder/parsers/StrictAttributeParser.java
Tue Nov 3 21:19:08 2009
@@ -66,7 +66,7 @@
try {
return new FieldReferenceConverter(new
FieldReferenceDelegate()).convert(value);
} catch (IllegalFieldReferenceException e) {
- logger.die("Bad field reference: \"%s\"", value);
+ logger.die("Cannot parse value: \"%s\"", value);
return null; // Unreachable
}
}
===
---
/releases/2.0/user/src/com/google/gwt/uibinder/parsers/VerticalAlignmentConstantParser.java
Mon Nov 2 13:18:15 2009
+++
/releases/2.0/user/src/com/google/gwt/uibinder/parsers/VerticalAlignmentConstantParser.java
Tue Nov 3 21:19:08 2009
@@ -24,7 +24,7 @@
* Parses a
* {...@link
com.google.gwt.user.client.ui.HasVerticalAlignment.VerticalAlignmentConstant}.
*/
-public class VerticalAlignmentConstantParser implements AttributeParser {
+public class VerticalAlignmentConstantParser extends StrictAttributeParser
{
private static final HashMap values =
new HashMap();
@@ -41,9 +41,9 @@
public String parse(String value, MortalLogger logger)
throws UnableToCompleteException {
String translated = values.get(value);
-if (translated == null) {
- logger.die("Invalid value: vorizontalAlignment='%s'", value);
-}
-return translated;
+if (translated != null) {
+ return translated;
+}
+return super.parse(value, logger);
}
}
===
--- /releases/2.0/user/src/com/google/gwt/user/User.gwt.xml Wed Aug 5
08:05:56 2009
+++ /releases/2.0/user/src/com/google/gwt/user/User.gwt.xml Tue Nov 3
21:19:08 2009
@@ -23,6 +23,7 @@
+
===
---
/releases/2.0/user/test/com/google/gwt/uibinder/test/UiBinderTestApp.gwt.xml
Fri Oct 30 16:12:45 2009
+++
/releases/2.0/user/test/com/google/gwt/uibinder/test/UiBinderTestApp.gwt.xml
Tue Nov 3 21:19:08 2009
@@ -13,7 +13,7 @@
-
+
===
---
/releases/2.0/user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml
[gwt-contrib] [google-web-toolkit] r6622 committed - Merged tr...@6580 into this branch...
Revision: 6622 Author: r...@google.com Date: Tue Nov 3 13:26:55 2009 Log: Merged tr...@6580 into this branch Implement a -standardsMode flag for junit tests svn merge --ignore-ancestry -c 6580 http://google-web-toolkit.googlecode.com/svn/trunk/ . http://code.google.com/p/google-web-toolkit/source/detail?r=6622 Added: /releases/2.0/user/src/com/google/gwt/junit/public/junit-standards.html /releases/2.0/user/test/com/google/gwt/i18n/public_es_AR/junit-standards.html /releases/2.0/user/test/com/google/gwt/i18n/public_es_MX/junit-standards.html Modified: /releases/2.0/branch-info.txt /releases/2.0/user/build.xml /releases/2.0/user/src/com/google/gwt/junit/JUnitShell.java /releases/2.0/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java === --- /dev/null +++ /releases/2.0/user/src/com/google/gwt/junit/public/junit-standards.html Tue Nov 3 13:26:55 2009 @@ -0,0 +1,68 @@ +http://www.w3.org/TR/html4/DTD/strict.dtd";> + + + + + + + + + + + + + +Your web browser must have JavaScript enabled +in order for this application to display correctly. + + + + === --- /dev/null +++ /releases/2.0/user/test/com/google/gwt/i18n/public_es_AR/junit-standards.html Tue Nov 3 13:26:55 2009 @@ -0,0 +1,73 @@ + + + + + + + + + + + + + +Your web browser must have JavaScript enabled +in order for this application to display correctly. + + + + === --- /dev/null +++ /releases/2.0/user/test/com/google/gwt/i18n/public_es_MX/junit-standards.html Tue Nov 3 13:26:55 2009 @@ -0,0 +1,73 @@ + + + + + + + + +