[gwt-contrib] [google-web-toolkit] r8123 committed - Deleting a managed entity makes all its fields null. Updated the code ...

[codesite-noreply]

Revision: 8123
Author: amitman...@google.com
Date: Wed May 12 20:20:59 2010
Log: Deleting a managed entity makes all its fields null. Updated the code  
to account for this behavior.


Review at http://gwt-code-reviews.appspot.com/520801

http://code.google.com/p/google-web-toolkit/source/detail?r=8123

Modified:
  
/branches/2.1/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java


===
---  
/branches/2.1/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java	 
Wed May 12 15:17:57 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java	 
Wed May 12 20:20:59 2010

@@ -500,27 +500,32 @@
   Set> violations) throws  
SecurityException,

   JSONException, IllegalAccessException, InvocationTargetException,
   NoSuchMethodException {
-
+// id/futureId, the identifying field is sent back from the incoming  
record.

 JSONObject returnObject = new JSONObject();
-if (writeOperation == WriteOperation.CREATE && violations != null
-&& !violations.isEmpty()) {
-  // don't send anything back
-} else {
-  // currently sending back only two properties.
-  for (String propertyName : new String[] {"id", "version"}) {
-if ("version".equals(propertyName) && violations != null
-&& !violations.isEmpty()) {
-  continue;
-}
-returnObject.put(propertyName, getPropertyValueFromDataStore(
-entityInstance, propertyName));
-  }
-}
-if (violations != null && !violations.isEmpty()) {
+final boolean hasViolations = violations != null  
&& !violations.isEmpty();

+if (hasViolations) {
   returnObject.put("violations", getViolationsAsJson(violations));
 }
-if (writeOperation == WriteOperation.CREATE) {
-  returnObject.put("futureId", recordObject.getString("id"));
+switch (writeOperation) {
+  case CREATE:
+returnObject.put("futureId", recordObject.getString("id"));
+if (!hasViolations) {
+  returnObject.put("id",  
getPropertyValueFromDataStore(entityInstance,

+  "id"));
+  returnObject.put("version", getPropertyValueFromDataStore(
+  entityInstance, "version"));
+}
+break;
+  case DELETE:
+returnObject.put("id", recordObject.getString("id"));
+break;
+  case UPDATE:
+returnObject.put("id", recordObject.getString("id"));
+if (!hasViolations) {
+  returnObject.put("version", getPropertyValueFromDataStore(
+  entityInstance, "version"));
+}
+break;
 }
 return returnObject;
   }
@@ -562,8 +567,8 @@
 return violationsAsJson;
   }

-  private Object invokeStaticDomainMethod(Method domainMethod,
-  Object args[]) throws IllegalAccessException,  
InvocationTargetException {
+  private Object invokeStaticDomainMethod(Method domainMethod, Object  
args[])

+  throws IllegalAccessException, InvocationTargetException {
 return domainMethod.invoke(null, args);
   }

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Deleting a managed entity makes all its fields null. Updated the code to account for this behavior. (issue520801)

[amitmanjhi]

Reviewers: Ray Ryan,

Description:
Deleting a managed entity makes all its fields null. Updated the code to
account for this behavior.


Please review this at http://gwt-code-reviews.appspot.com/520801/show

Affected files:
  M  
trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java



Index:  
trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java

===
---  
trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java	 
(revision 8109)
+++  
trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java	 
(working copy)

@@ -500,27 +500,32 @@
   Set> violations) throws  
SecurityException,

   JSONException, IllegalAccessException, InvocationTargetException,
   NoSuchMethodException {
-
+// id/futureId, the identifying field is sent back from the incoming  
record.

 JSONObject returnObject = new JSONObject();
-if (writeOperation == WriteOperation.CREATE && violations != null
-&& !violations.isEmpty()) {
-  // don't send anything back
-} else {
-  // currently sending back only two properties.
-  for (String propertyName : new String[] {"id", "version"}) {
-if ("version".equals(propertyName) && violations != null
-&& !violations.isEmpty()) {
-  continue;
-}
-returnObject.put(propertyName, getPropertyValueFromDataStore(
-entityInstance, propertyName));
-  }
-}
-if (violations != null && !violations.isEmpty()) {
+final boolean hasViolations = violations != null  
&& !violations.isEmpty();

+if (hasViolations) {
   returnObject.put("violations", getViolationsAsJson(violations));
 }
-if (writeOperation == WriteOperation.CREATE) {
-  returnObject.put("futureId", recordObject.getString("id"));
+switch (writeOperation) {
+  case CREATE:
+returnObject.put("futureId", recordObject.getString("id"));
+if (!hasViolations) {
+  returnObject.put("id",  
getPropertyValueFromDataStore(entityInstance,

+  "id"));
+  returnObject.put("version", getPropertyValueFromDataStore(
+  entityInstance, "version"));
+}
+break;
+  case DELETE:
+returnObject.put("id", recordObject.getString("id"));
+break;
+  case UPDATE:
+returnObject.put("id", recordObject.getString("id"));
+if (!hasViolations) {
+  returnObject.put("version", getPropertyValueFromDataStore(
+  entityInstance, "version"));
+}
+break;
 }
 return returnObject;
   }
@@ -562,8 +567,8 @@
 return violationsAsJson;
   }

-  private Object invokeStaticDomainMethod(Method domainMethod,
-  Object args[]) throws IllegalAccessException,  
InvocationTargetException {
+  private Object invokeStaticDomainMethod(Method domainMethod, Object  
args[])

+  throws IllegalAccessException, InvocationTargetException {
 return domainMethod.invoke(null, args);
   }



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8122 committed - Leave "dead" views in place to reduce flicker, at least until...

[codesite-noreply]

Revision: 8122
Author: gwt.mirror...@gmail.com
Date: Wed May 12 18:36:06 2010
Log: Leave "dead" views in place to reduce flicker, at least until
caching is here.

Review at http://gwt-code-reviews.appspot.com/493802

Review by: cromwell...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8122

Modified:
 /branches/2.1/bikeshed/src/com/google/gwt/app/place/ActivityManager.java
  
/branches/2.1/bikeshed/test/com/google/gwt/app/place/ActivityManagerTest.java


===
---  
/branches/2.1/bikeshed/src/com/google/gwt/app/place/ActivityManager.java	 
Tue May  4 17:35:40 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/app/place/ActivityManager.java	 
Wed May 12 18:36:06 2010

@@ -88,7 +88,11 @@
   currentActivity = null;
   startingNext = false;
 } else if (currentActivity != null) {
-  display.showActivityWidget(null);
+  /*
+   * TODO until caching is in place, relying on stopped activities to  
be

+   * good citizens to reduce flicker. This makes me very nervous.
+   */
+//  display.showActivityWidget(null);
   currentActivity.onStop();
 }

@@ -119,9 +123,8 @@

   /*
* TODO Allow asynchronous willClose check? Could have the event  
object

-   * vend callbacks. Place change doesn't happen until they all vended
-   * callbacks, if any, reply with yes. Would likely need to add
-   * onPlaceChangeCanceled?
+   * vend callbacks. Place change doesn't happen until all vended  
callbacks,
+   * if any, reply with yes. Would likely need to add  
onPlaceChangeCanceled?

*
* Complicated, but I really want to keep AM and PC isolated.  
Alternative
* is to mash them together and take place conversation off the  
event bus.

===
---  
/branches/2.1/bikeshed/test/com/google/gwt/app/place/ActivityManagerTest.java	 
Wed May  5 12:33:04 2010
+++  
/branches/2.1/bikeshed/test/com/google/gwt/app/place/ActivityManagerTest.java	 
Wed May 12 18:36:06 2010

@@ -162,7 +162,11 @@
 assertNull(asyncActivity2.display);

 eventBus.fireEvent(new PlaceChangeEvent(place2));
-assertNull(realDisplay.widget);
+/*
+ * TODO until caching is in place, relying on stopped activities to be
+ * good citizens to reduce flicker. This makes me very nervous.
+ */
+//assertNull(realDisplay.widget);
 assertFalse(asyncActivity1.canceled);
 assertTrue(asyncActivity1.stopped);
 assertFalse(asyncActivity2.stopped);

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Leave "dead" views in place to reduce flicker, at least until (issue493802)

[rjrjr]

Reviewers: cromwellian,

Description:
Leave "dead" views in place to reduce flicker, at least until
caching is here.

Review by: cromwell...@google.com

Please review this at http://gwt-code-reviews.appspot.com/493802/show

Affected files:
  M /bikeshed/src/com/google/gwt/app/place/ActivityManager.java
  M /bikeshed/test/com/google/gwt/app/place/ActivityManagerTest.java


Index: /bikeshed/src/com/google/gwt/app/place/ActivityManager.java
===
--- /bikeshed/src/com/google/gwt/app/place/ActivityManager.java	(revision  
8109)
+++ /bikeshed/src/com/google/gwt/app/place/ActivityManager.java	(working  
copy)

@@ -88,7 +88,11 @@
   currentActivity = null;
   startingNext = false;
 } else if (currentActivity != null) {
-  display.showActivityWidget(null);
+  /*
+   * TODO until caching is in place, relying on stopped activities to  
be

+   * good citizens to reduce flicker. This makes me very nervous.
+   */
+//  display.showActivityWidget(null);
   currentActivity.onStop();
 }

@@ -119,9 +123,8 @@

   /*
* TODO Allow asynchronous willClose check? Could have the event  
object

-   * vend callbacks. Place change doesn't happen until they all vended
-   * callbacks, if any, reply with yes. Would likely need to add
-   * onPlaceChangeCanceled?
+   * vend callbacks. Place change doesn't happen until all vended  
callbacks,
+   * if any, reply with yes. Would likely need to add  
onPlaceChangeCanceled?

*
* Complicated, but I really want to keep AM and PC isolated.  
Alternative
* is to mash them together and take place conversation off the  
event bus.

Index: /bikeshed/test/com/google/gwt/app/place/ActivityManagerTest.java
===
--- /bikeshed/test/com/google/gwt/app/place/ActivityManagerTest.java	 
(revision 8109)
+++ /bikeshed/test/com/google/gwt/app/place/ActivityManagerTest.java	 
(working copy)

@@ -162,7 +162,11 @@
 assertNull(asyncActivity2.display);

 eventBus.fireEvent(new PlaceChangeEvent(place2));
-assertNull(realDisplay.widget);
+/*
+ * TODO until caching is in place, relying on stopped activities to be
+ * good citizens to reduce flicker. This makes me very nervous.
+ */
+//assertNull(realDisplay.widget);
 assertFalse(asyncActivity1.canceled);
 assertTrue(asyncActivity1.stopped);
 assertFalse(asyncActivity2.stopped);


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8121 committed - Maintain the list's selection as we move between record specific...

[codesite-noreply]

Revision: 8121
Author: rj...@google.com
Date: Wed May 12 17:53:17 2010
Log: Maintain the list's selection as we move between record specific
places. This is most visible when the table selection is cleared
if you click the create button.

Review at http://gwt-code-reviews.appspot.com/517801

Review by: jaime...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8121

Added:
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/place/ScaffoldPlaceToRecordType.java

Modified:
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldMasterActivities.java
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/ListActivitiesMapper.java
  
/branches/2.1/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java
  
/branches/2.1/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListView.java

 /branches/2.1/bikeshed/src/com/google/gwt/valuestore/ui/RecordListView.java

===
--- /dev/null
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/place/ScaffoldPlaceToRecordType.java	 
Wed May 12 17:53:17 2010

@@ -0,0 +1,24 @@
+package com.google.gwt.sample.expenses.gwt.client.place;
+
+import com.google.gwt.sample.expenses.gwt.request.EmployeeRecord;
+import com.google.gwt.sample.expenses.gwt.request.ReportRecord;
+import com.google.gwt.valuestore.shared.Record;
+
+/**
+ * Filters an {...@link ScaffoldPlace} to the corresponding record
+ * type.
+ */
+public final class ScaffoldPlaceToRecordType implements
+ScaffoldPlaceFilter> {
+  public Class filter(EmployeeScaffoldPlace place) {
+return EmployeeRecord.class;
+  }
+
+  public Class filter(ListScaffoldPlace place) {
+return place.getType();
+  }
+
+  public Class filter(ReportScaffoldPlace place) {
+return ReportRecord.class;
+  }
+}
===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldMasterActivities.java	 
Tue May  4 17:35:40 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldMasterActivities.java	 
Wed May 12 17:53:17 2010

@@ -19,6 +19,11 @@
 import com.google.gwt.app.place.ActivityMapper;
 import com.google.gwt.sample.expenses.gwt.client.place.ListScaffoldPlace;
 import com.google.gwt.sample.expenses.gwt.client.place.ScaffoldPlace;
+import  
com.google.gwt.sample.expenses.gwt.client.place.ScaffoldPlaceToRecordType;

+import com.google.gwt.sample.expenses.gwt.client.place.ScaffoldRecordPlace;
+import com.google.gwt.sample.expenses.gwt.ui.ListActivitiesMapper;
+import com.google.gwt.valuestore.shared.Record;
+import com.google.gwt.valuestore.ui.AbstractRecordListActivity;

 /**
  * Finds the activity to run for a particular {...@link ScaffoldPlace} in the  
top

@@ -27,20 +32,28 @@
 public final class ScaffoldMasterActivities implements
 ActivityMapper {

-  private final ActivityMapper listActivities;
-
-  private Activity last = null;
-
-  public ScaffoldMasterActivities(
-  ActivityMapper listActivities) {
+  private final ListActivitiesMapper listActivities;
+
+  private AbstractRecordListActivity last = null;
+  private Class lastType = null;
+
+  public ScaffoldMasterActivities(ListActivitiesMapper listActivities) {
 this.listActivities = listActivities;
   }

   public Activity getActivity(ScaffoldPlace place) {
 if (place instanceof ListScaffoldPlace) {
-  last = listActivities.getActivity((ListScaffoldPlace) place);
+  ListScaffoldPlace listPlace = (ListScaffoldPlace) place;
+  last = listActivities.getActivity(listPlace);
+  lastType = listPlace.getType();
 }

+if (last != null && place instanceof ScaffoldRecordPlace) {
+  Class thisType = place.acceptFilter(new  
ScaffoldPlaceToRecordType());

+  if (lastType.equals(thisType)) {
+last.select(((ScaffoldRecordPlace) place).getId());
+  }
+}
 return last;
   }
 }
===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/ListActivitiesMapper.java	 
Tue May  4 17:35:40 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/ListActivitiesMapper.java	 
Wed May 12 17:53:17 2010

@@ -26,13 +26,11 @@
 import com.google.gwt.sample.expenses.gwt.request.ReportRecord;
 import com.google.gwt.sample.expenses.gwt.ui.employee.EmployeeListActivity;
 import com.google.gwt.sample.expenses.gwt.ui.report.ReportListActivity;
+import com.google.gwt.valuestore.ui.AbstractRecordListActivity;

 /**
  * The class that knows what {...@link Activity} to run when the user goes to  
a

  * particular {...@link ListScaffoldPlace}.
- * 
- * To create a new list activity, copy one of the existing ones (and the
- * corresponding view), and register it here.
  */
 public class ListActivitiesMapper implements  
ActivityMapper {

   private final ExpensesRequestFactory requests;
@@ -47,7 +45,7 @@
 this.placeController = placeCo

[gwt-contrib] Re: Add MD5 implementation, String byte manipulation methods/constructors. (issue516801)

[jat]

Thanks for the feedback.


http://gwt-code-reviews.appspot.com/516801/diff/1/4
File user/super/com/google/gwt/emul/java/lang/String.java (right):

http://gwt-code-reviews.appspot.com/516801/diff/1/4#newcode458
user/super/com/google/gwt/emul/java/lang/String.java:458: int n =
str.length();
Are you sure that is guaranteed to be UTF8?  I would expect it to be
whatever encoding the host page was in.  Maybe that is the right
behavior for getBytes(), but here I think we have to guarantee that it
is UTF8.

Regarding getting the bytes, I suspect that you can do something like
str.split('') and then apply some function to the resulting array, but I
am not really sure how that can be faster.

http://gwt-code-reviews.appspot.com/516801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add MD5 implementation, String byte manipulation methods/constructors. (issue516801)

[t . broyer]

http://gwt-code-reviews.appspot.com/516801/diff/1/4
File user/super/com/google/gwt/emul/java/lang/String.java (right):

http://gwt-code-reviews.appspot.com/516801/diff/1/4#newcode458
user/super/com/google/gwt/emul/java/lang/String.java:458: int n =
str.length();
There's actually a much easier and faster way, if you can somehow cast a
String to a byte[]:
   unescape(encodeURIComponent(bytes))

encodeURIComponent will %-escape each char using UTF-8, and unescape
will unescape each %hh sequence. This would turn, e.g. "\u00E9" into
"\u00C3\u00A9". You could then get the bytes just like getChars(), which
is still probably faster than all those if/else, bit-shifts et al. to do
UTF-8 encoding yourself.

http://gwt-code-reviews.appspot.com/516801/diff/1/4#newcode515
user/super/com/google/gwt/emul/java/lang/String.java:515: private static
String utf8ToString(byte[] bytes, int ofs, int len) {
Same as above re. getBytesUtf8:
   decodeURIComponent(escape(bytes))
would turn "\xC3\xA9" into "\u00E9". Building the "\xC3\xA9" string from
a byte[] should be as easy as String.fromCharCode.apply(null,
bytes.splice(ofs, len)), as in valueOf.
In case the String-constructed-from-bytes contains chars out of the
0-255 range (such as when a byte[] array contain non-byte values, which
could happen in web mode), then escape() will turn them into %u
escapes and decodeURIComponent then throws; this can be fixed upfront as
in getBytesLatin1 or afterwards with a .replace(/%u([0-9a-f]){4}/gi,
function(...
I don't have numbers but I think it'd be faster than the "manual UTF-8"
algorithm as done here.

http://gwt-code-reviews.appspot.com/516801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Factored out the invoke method for a READ request. (issue519801)

[Ray Ryan]

LGTM

On Wed, May 12, 2010 at 6:11 PM,  wrote:

> Reviewers: amitmanjhi,
>
> Description:
> Factored out the invoke method for a READ request.
>
> Patch by: jon...@gmail.com
> Commited by: amitmanjhi
> Review by: amitmanjhi
>
>
> Please review this at http://gwt-code-reviews.appspot.com/519801/show
>
> Affected files:
>  M
> trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java
>
>
> Index:
> trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java
> ===
> ---
> trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java
>  (revision 8109)
> +++
> trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java
>  (working copy)
> @@ -130,7 +130,7 @@
> Object args[] = RequestDataManager.getObjectsFromParameterMap(
> getParameterMap(topLevelJsonObject),
> domainMethod.getParameterTypes());
> -Object result = domainMethod.invoke(null, args);
> +Object result = invokeStaticDomainMethod(domainMethod, args);
>
> if ((result instanceof List) != operation.isReturnTypeList()) {
>   throw new IllegalArgumentException(String.format(
> @@ -569,6 +569,11 @@
> return violationsAsJson;
>   }
>
> +  private Object invokeStaticDomainMethod(Method domainMethod,
> +  Object args[]) throws IllegalAccessException,
> InvocationTargetException {
> +return domainMethod.invoke(null, args);
> +  }
> +
>   /**
>* returns true if the property has been requested. TODO: use the
> properties
>* that should be coming with the request.
>
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removed dead code. (issue514802)

[Ray Ryan]

LGTM

On Wed, May 12, 2010 at 6:17 PM,  wrote:

> Reviewers: Ray Ryan,
>
> Description:
> Removed dead code.
>
>
> Please review this at http://gwt-code-reviews.appspot.com/514802/show
>
> Affected files:
>  M
> trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java
>
>
> Index:
> trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java
> ===
> ---
> trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java
>  (revision 8109)
> +++
> trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java
>  (working copy)
> @@ -106,7 +106,6 @@
>   protected void doPost(HttpServletRequest request, HttpServletResponse
> response)
>   throws IOException {
>
> -initDb(); // temporary place-holder
> ensureConfig();
>
> RequestDefinition operation = null;
> @@ -171,12 +170,6 @@
> } catch (InstantiationException e) {
>   throw new RuntimeException(e);
> }
> -  }
> -
> -  /**
> -   * Allow subclass to initialize database.
> -   */
> -  protected void initDb() {
>   }
>
>   /**
>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: The employee records now have a supervisorId that is propagated to the reports. Plus, minor cleanup. (issue518801)

[rjrjr]

LGTM

http://gwt-code-reviews.appspot.com/518801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8120 committed - Removed dead code....

[codesite-noreply]

Revision: 8120
Author: amitman...@google.com
Date: Wed May 12 15:17:57 2010
Log: Removed dead code.

Review at http://gwt-code-reviews.appspot.com/514802

http://code.google.com/p/google-web-toolkit/source/detail?r=8120

Modified:
  
/branches/2.1/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java


===
---  
/branches/2.1/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java	 
Wed May 12 15:12:40 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java	 
Wed May 12 15:17:57 2010

@@ -106,7 +106,6 @@
   protected void doPost(HttpServletRequest request, HttpServletResponse  
response)

   throws IOException {

-initDb(); // temporary place-holder
 ensureConfig();

 RequestDefinition operation = null;
@@ -172,12 +171,6 @@
   throw new RuntimeException(e);
 }
   }
-
-  /**
-   * Allow subclass to initialize database.
-   */
-  protected void initDb() {
-  }

   /**
* Persist a recordObject of token "recordToken" and return useful  
information


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8119 committed - Factored out the invoke method for a READ request....

[codesite-noreply]

Revision: 8119
Author: amitman...@google.com
Date: Wed May 12 15:12:40 2010
Log: Factored out the invoke method for a READ request.

Patch by: jon...@gmail.com
Commited by: amitmanjhi
Review by: amitmanjhi

Review at http://gwt-code-reviews.appspot.com/519801

http://code.google.com/p/google-web-toolkit/source/detail?r=8119

Modified:
  
/branches/2.1/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java


===
---  
/branches/2.1/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java	 
Wed May 12 09:47:07 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java	 
Wed May 12 15:12:40 2010

@@ -130,7 +130,7 @@
 Object args[] = RequestDataManager.getObjectsFromParameterMap(
 getParameterMap(topLevelJsonObject),
 domainMethod.getParameterTypes());
-Object result = domainMethod.invoke(null, args);
+Object result = invokeStaticDomainMethod(domainMethod, args);

 if ((result instanceof List) != operation.isReturnTypeList()) {
   throw new IllegalArgumentException(String.format(
@@ -568,6 +568,11 @@
 }
 return violationsAsJson;
   }
+
+  private Object invokeStaticDomainMethod(Method domainMethod,
+  Object args[]) throws IllegalAccessException,  
InvocationTargetException {

+return domainMethod.invoke(null, args);
+  }

   /**
* returns true if the property has been requested. TODO: use the  
properties


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Removed dead code. (issue514802)

[amitmanjhi]

Reviewers: Ray Ryan,

Description:
Removed dead code.


Please review this at http://gwt-code-reviews.appspot.com/514802/show

Affected files:
  M  
trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java



Index:  
trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java

===
---  
trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java	 
(revision 8109)
+++  
trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java	 
(working copy)

@@ -106,7 +106,6 @@
   protected void doPost(HttpServletRequest request, HttpServletResponse  
response)

   throws IOException {

-initDb(); // temporary place-holder
 ensureConfig();

 RequestDefinition operation = null;
@@ -171,12 +170,6 @@
 } catch (InstantiationException e) {
   throw new RuntimeException(e);
 }
-  }
-
-  /**
-   * Allow subclass to initialize database.
-   */
-  protected void initDb() {
   }

   /**


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Factored out the invoke method for a READ request. (issue519801)

[amitmanjhi]

Reviewers: amitmanjhi,

Description:
Factored out the invoke method for a READ request.

Patch by: jon...@gmail.com
Commited by: amitmanjhi
Review by: amitmanjhi


Please review this at http://gwt-code-reviews.appspot.com/519801/show

Affected files:
  M  
trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java



Index:  
trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java

===
---  
trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java	 
(revision 8109)
+++  
trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java	 
(working copy)

@@ -130,7 +130,7 @@
 Object args[] = RequestDataManager.getObjectsFromParameterMap(
 getParameterMap(topLevelJsonObject),
 domainMethod.getParameterTypes());
-Object result = domainMethod.invoke(null, args);
+Object result = invokeStaticDomainMethod(domainMethod, args);

 if ((result instanceof List) != operation.isReturnTypeList()) {
   throw new IllegalArgumentException(String.format(
@@ -569,6 +569,11 @@
 return violationsAsJson;
   }

+  private Object invokeStaticDomainMethod(Method domainMethod,
+  Object args[]) throws IllegalAccessException,  
InvocationTargetException {

+return domainMethod.invoke(null, args);
+  }
+
   /**
* returns true if the property has been requested. TODO: use the  
properties

* that should be coming with the request.


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Maintain the list's selection as we move between record specific (issue517801)

[rjrjr]

http://gwt-code-reviews.appspot.com/517801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Maintain the list's selection as we move between record specific (issue517801)

[rjrjr]

http://gwt-code-reviews.appspot.com/517801/diff/1/5
File
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java
(right):

http://gwt-code-reviews.appspot.com/517801/diff/1/5#newcode56
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java:56:
private boolean itsMeDoingTheSelecting = false;
Good point, and much simpler. Will do.

http://gwt-code-reviews.appspot.com/517801/diff/1/5#newcode76
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java:76:
// TODO
How'd that get there? This is a subclass responsibility, deleted.

http://gwt-code-reviews.appspot.com/517801/diff/1/6
File
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListView.java
(right):

http://gwt-code-reviews.appspot.com/517801/diff/1/6#newcode45
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListView.java:45:

On 2010/05/13 00:46:39, jaimeyap wrote:

space


Done.

http://gwt-code-reviews.appspot.com/517801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8118 committed - The employee records now have a supervisorId that is propagated to the...

[codesite-noreply]

Revision: 8118
Author: amitman...@google.com
Date: Wed May 12 14:52:17 2010
Log: The employee records now have a supervisorId that is propagated to the  
reports. Plus, minor cleanup.


Patch by: amitmanjhi
Review by: rjrjr (tbr)

Review at http://gwt-code-reviews.appspot.com/518801

http://code.google.com/p/google-web-toolkit/source/detail?r=8118

Added:
 /branches/2.1/bikeshed/scripts/expensesJsonData_small.txt
Modified:
  
/branches/2.1/bikeshed/src/com/google/gwt/requestfactory/server/SampleDataPopulator.java
  
/branches/2.1/bikeshed/src/com/google/gwt/requestfactory/shared/impl/RequestDataManager.java
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/server/DataGenerator.java


===
--- /dev/null
+++ /branches/2.1/bikeshed/scripts/expensesJsonData_small.txt	Wed May 12  
14:52:17 2010

@@ -0,0 +1,443 @@
+{"CREATE": [
+{"EmployeeRecord": {
+"id": "1",
+"department": "Sales",
+"userName": "dluminous",
+"displayName": "Dave Luminous"
+}},
+{"ReportRecord": {
+"id": "2",
+"created": 1267662990534,
+"reporterKey": 1,
+"department": "Sales",
+"purpose": "Visting Miami",
+"notes": ""
+}},
+{"ExpenseRecord": {
+"amount": 223.74,
+"id": "3",
+"category": "Local Transportation",
+"created": 1268397466537,
+"description": "Train fare",
+"reportId": 2
+}},
+{"ReportRecord": {
+"id": "4",
+"created": 1269746087537,
+"reporterKey": 1,
+"department": "Sales",
+"purpose": "Paid vacation in Chicago",
+"notes": "Need approval by Monday"
+}},
+{"ExpenseRecord": {
+"amount": 64.39,
+"id": "5",
+"category": "Local Transportation",
+"created": 1270791569537,
+"description": "Bus ticket",
+"reportId": 4
+}},
+{"EmployeeRecord": {
+"id": "6",
+"supervisorKey": "1",
+"department": "Marketing",
+"userName": "cperfect",
+"displayName": "Catherine Perfect"
+}},
+{"ReportRecord": {
+"id": "7",
+"created": 1268750893537,
+"approvedSupervisorKey": "1",
+"reporterKey": 6,
+"department": "Marketing",
+"purpose": "Travelling to Zurich",
+"notes": "Need approval by Monday"
+}},
+{"ExpenseRecord": {
+"amount": 90.13,
+"id": "8",
+"category": "Office Supplies",
+"created": 1271192214537,
+"description": "Paperclips",
+"reportId": 7
+}},
+{"EmployeeRecord": {
+"id": "9",
+"supervisorKey": "1",
+"department": "Engineering",
+"userName": "sluminous",
+"displayName": "Sally Luminous"
+}},
+{"ReportRecord": {
+"id": "10",
+"created": 1268855245537,
+"approvedSupervisorKey": "1",
+"reporterKey": 9,
+"department": "Engineering",
+"purpose": "Paid vacation in Miami",
+"notes": "Please bill to the Widgets project"
+}},
+{"ExpenseRecord": {
+"amount": 106.19,
+"id": "11",
+"category": "Office Supplies",
+"created": 1271298705537,
+"description": "Paperclips",
+"reportId": 10
+}},
+{"ExpenseRecord": {
+"amount": 155.1,
+"id": "12",
+"category": "Office Supplies",
+"created": 1267514069537,
+"description": "Scissors",
+"reportId": 10
+}},
+{"ReportRecord": {
+"id": "13",
+"created": 1268344663537,
+"approvedSupervisorKey": "1",
+"reporterKey": 9,
+"department": "Engineering",
+"purpose": "Having fun in Bangalore",
+"notes": "Please bill to the Widgets project"
+}},
+{"ExpenseRecord": {
+"amount": 117.64,
+"id": "14",
+"category": "Office Supplies",
+"created": 1269771680537,
+"description": "Stapler",
+"reportId": 13
+}},
+{"EmployeeRecord": {
+"id": "15",
+"supervisorKey": "1",
+"department": "Operations",
+"userName": "hperfect",
+"displayName": "Harriot Perfect"
+}},
+{"ReportRecord": {
+"id": "16",
+"created": 1273352534537,
+"approvedSupervisorKey": "1",
+"reporterKey": 15,
+"department": "Operations",
+"purpose": "Paid vacation in Atlanta",
+"notes": "Show me the money"
+}},
+{"ExpenseRecord": {
+"amount": 78.66,
+"id": "17",
+"category": "Local Transportation",
+"created": 1266686806537,
+"description": "Bus ticket",
+"reportId": 16
+}},
+{"ExpenseRecord": {
+"amount": 5.23,
+"id": "18",
+"category": "Office Supplies",
+"created": 1269234622537,
+"description": "Stapler",
+"reportId": 16
+}},
+{"EmployeeRecord":

[gwt-contrib] [google-web-toolkit] r8117 committed - Updates the Scaffoling sample UI. Also updates the behavior of the sam...

[codesite-noreply]

Revision: 8117
Author: gwt.mirror...@gmail.com
Date: Wed May 12 17:53:06 2010
Log: Updates the Scaffoling sample UI. Also updates the behavior of the  
sample to display the first entity when the app is loaded.


http://code.google.com/p/google-web-toolkit/source/detail?r=8117

Modified:
  
/branches/2.1/bikeshed/src/com/google/gwt/app/client/CellListPlacePickerView.java
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldShell.ui.xml
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeDetailsView.ui.xml
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditView.ui.xml
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeListView.ui.xml
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportDetailsView.ui.xml
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportEditView.ui.xml
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportListView.ui.xml

 /branches/2.1/bikeshed/war/Scaffold.html

===
---  
/branches/2.1/bikeshed/src/com/google/gwt/app/client/CellListPlacePickerView.java	 
Tue May 11 09:34:32 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/app/client/CellListPlacePickerView.java	 
Wed May 12 17:53:06 2010

@@ -83,5 +83,6 @@
 // Replace the current renderer.
 this.renderer = renderer;
 cellList.setData(0, places.size(), places);
+smodel.setSelected(places.get(0), true);
   }
 }
===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldShell.ui.xml	 
Tue May 11 09:04:15 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldShell.ui.xml	 
Wed May 12 17:53:06 2010

@@ -4,48 +4,48 @@
   xmlns:a='urn:import:com.google.gwt.app.client'>

   
-@def contentWidth 800px;
+@def contentWidth 850px;

 .disabled {
- color: gray;
-}
-
+  color: gray;
+}
+
 .body {
-   overflow:auto;
- }
+  overflow:auto;
+}

 .banner {
-   background-color: #777;
-   -moz-border-radius-topleft: 10px;
-   -webkit-border-top-left-radius: 10px;
-   -moz-border-radius-topright: 10px;
-   -webkit-border-top-right-radius: 10px;
-   margin-top: 1.5em;
-   height: 4em;
- }
+  background-color: #777;
+  -moz-border-radius-topleft: 10px;
+  -webkit-border-top-left-radius: 10px;
+  -moz-border-radius-topright: 10px;
+  -webkit-border-top-right-radius: 10px;
+  margin-top: 1.5em;
+  height: 4em;
+}

 .title {
-   color: white;
-   padding: 1em;
-   position: absolute;
-   color: #def;
- }
-
- .title h2 {
-   margin:0;
- }
+  color: white;
+  padding: 1em;
+  position: absolute;
+  color: #def;
+}
+
+.title h2 {
+  margin:0;
+}

 .error {
-   position: absolute;
-   left: 12%;
-   right: 12%;
-   text-align: center;
-   background-color: red;
+  position: absolute;
+  left: 12%;
+  right: 12%;
+  text-align: center;
+  background-color: red;
 }

 .users {
- position: absolute;
- right: 0;
+  position: absolute;
+  right: 0;
 }

 .centered {
@@ -56,7 +56,7 @@

 .content {
   position: relative;
-  border: 1px solid #888;
+  border: 1px solid #ddf;
   overflow-y: auto;
   overflow-x: hidden;
   -moz-border-radius-bottomleft: 10px;
@@ -74,7 +74,7 @@
  }

  .entitiesList {
-   border-right: 1px solid #888;
+   border-right: 1px solid #ddf;
height: 100%;
outline: none;
  }
@@ -86,7 +86,7 @@
  }

  .entityDetails {
-   margin-left: 12em;
+   margin-left: 11em;
  }
   

@@ -95,21 +95,17 @@
   
 
   
-  Your Entities
+  Data Browser
 
   
 
-
+
 
   
 
   width='100%' pageSize='100' ui:field='placesBox'/>

 
 
-  
-Welcome to the Entity Browser
-Choose an entity set from the list on the left to get  
started

-  
 
 ui:field='details'>

 
===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeDetailsView.ui.xml	 
Tue May 11 09:04:15 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeDetailsView.ui.xml	 
Wed May 12 17:53:06 2010

@@ -3,44 +3,45 @@
   xmlns:g='urn:import:com.google.gwt.user.client.ui'>
   
 .fields {
-   margin: 0.5em;
- }
-
-.fields div {
-   margin: 0.5em;
- }
-
+  margin-top: 0.5em;
+  margin-left: 1em;
+}
 .label {
-  font-weight:bold;
- }
-
+  font-weight: bold;
+  min-height: 25px;
+}
 .button {
   

[gwt-contrib] The employee records now have a supervisorId that is propagated to the reports. Plus, minor cleanup. (issue518801)

[amitmanjhi]

Reviewers: Ray Ryan,

Description:
The employee records now have a supervisorId that is propagated to the
reports. Plus, minor cleanup.

Patch by: amitmanjhi
Review by: rjrjr (tbr)


Please review this at http://gwt-code-reviews.appspot.com/518801/show

Affected files:
  A trunk/bikeshed/scripts/expensesJsonData_small.txt
  M  
trunk/bikeshed/src/com/google/gwt/requestfactory/server/SampleDataPopulator.java
  M  
trunk/bikeshed/src/com/google/gwt/requestfactory/shared/impl/RequestDataManager.java
  M  
trunk/bikeshed/src/com/google/gwt/sample/expenses/server/DataGenerator.java



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Maintain the list's selection as we move between record specific (issue517801)

[jaimeyap]

LGTM after addressing nits.


http://gwt-code-reviews.appspot.com/517801/diff/1/5
File
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java
(right):

http://gwt-code-reviews.appspot.com/517801/diff/1/5#newcode56
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java:56:
private boolean itsMeDoingTheSelecting = false;
nit. wouldnt block on this.

But it seems like this state tries to accomplish the same thing as
"don't redisplay the same thing that is already displayed".

Can we not somehow just check the currently selected with the thing we
want to select?

http://gwt-code-reviews.appspot.com/517801/diff/1/5#newcode76
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java:76:
// TODO
empty todo

http://gwt-code-reviews.appspot.com/517801/diff/1/6
File
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListView.java
(right):

http://gwt-code-reviews.appspot.com/517801/diff/1/6#newcode45
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListView.java:45:

space

http://gwt-code-reviews.appspot.com/517801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a more user friendly popup for logging messages using the new logging framework (issue508801)

[fredsa]

LGTM.

Getting some community feedback on the panel makes sense to me.

http://gwt-code-reviews.appspot.com/508801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Maintain the list's selection as we move between record specific (issue517801)

[rjrjr]

Reviewers: jaimeyap,

Description:
Maintain the list's selection as we move between record specific
places. This is most visible when the table selection is cleared
if you click the create button.

Review by: jaime...@google.com

Please review this at http://gwt-code-reviews.appspot.com/517801/show

Affected files:
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldMasterActivities.java
  A  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/place/ScaffoldPlaceToRecordType.java
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/ListActivitiesMapper.java
  M  
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java

  M /bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListView.java
  M /bikeshed/src/com/google/gwt/valuestore/ui/RecordListView.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a more user friendly popup for logging messages using the new logging framework (issue508801)

[unnurg]

http://gwt-code-reviews.appspot.com/508801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a more user friendly popup for logging messages using the new logging framework (issue508801)

[unnurg]

On 2010/05/12 23:15:22, unnurg wrote:

Testing on the standard Linux and Mac browsers in standard and quirks

mode is

finished - working on finding a virtual Windows machine which will let

me access

corp...

Ok - tested IE 6/7/8 and some firefox/chrome on Windows as well. Seems
to work fine, although not all the browsers are showing the SE arrow, so
I may just replace that with a "//" instead.  After the initial IO
release, we can see what people think and whether we should replace this
ASCII art with something better...



On 2010/05/12 22:53:28, unnurg wrote:
>




http://gwt-code-reviews.appspot.com/508801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a more user friendly popup for logging messages using the new logging framework (issue508801)

[unnurg]

Testing on the standard Linux and Mac browsers in standard and quirks
mode is finished - working on finding a virtual Windows machine which
will let me access corp...

On 2010/05/12 22:53:28, unnurg wrote:




http://gwt-code-reviews.appspot.com/508801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a more user friendly popup for logging messages using the new logging framework (issue508801)

[unnurg]

http://gwt-code-reviews.appspot.com/508801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add MD5 implementation, String byte manipulation methods/constructors. (issue516801)

[jat]

Reviewers: rchandia,

Description:
Add MD5 implementation, String byte manipulation methods/constructors.

Patch by: jat
Review by: rchandia, dhanji


Please review this at http://gwt-code-reviews.appspot.com/516801/show

Affected files:
  A user/src/com/google/gwt/core/client/impl/Md5Digest.java
  A user/super/com/google/gwt/emul/java/io/UnsupportedEncodingException.java
  M user/super/com/google/gwt/emul/java/lang/String.java
  A user/super/com/google/gwt/emul/java/security/DigestException.java
  A  
user/super/com/google/gwt/emul/java/security/GeneralSecurityException.java

  A user/super/com/google/gwt/emul/java/security/MessageDigest.java
  A user/super/com/google/gwt/emul/java/security/MessageDigestSpi.java
  A  
user/super/com/google/gwt/emul/java/security/NoSuchAlgorithmException.java

  M user/test/com/google/gwt/emultest/EmulSuite.java
  M user/test/com/google/gwt/emultest/java/lang/StringTest.java
  A user/test/com/google/gwt/emultest/java/security/MessageDigestTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8116 committed - Style tweaks to the denied popup on the Expense Details page. Also re...

[codesite-noreply]

Revision: 8116
Author: jlaba...@google.com
Date: Wed May 12 12:06:30 2010
Log: Style tweaks to the denied popup on the Expense Details page.  Also  
removing the 'no data' message in the mobile version.


Review at http://gwt-code-reviews.appspot.com/515801

http://code.google.com/p/google-web-toolkit/source/detail?r=8116

Modified:
  
/branches/2.1/bikeshed/src/com/google/gwt/bikeshed/list/client/CellList.java
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/bikeshed/style/client/Styles.java
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/bikeshed/style/client/common.css
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseDetails.java
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseDetails.ui.xml
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseList.ui.xml
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileReportList.java


===
---  
/branches/2.1/bikeshed/src/com/google/gwt/bikeshed/list/client/CellList.java	 
Wed May 12 10:44:13 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/bikeshed/list/client/CellList.java	 
Wed May 12 12:06:30 2010

@@ -101,6 +101,7 @@
   private final Element childContainer;
   private final Element emptyMessageElem;
   private final CellListImpl impl;
+  private String emptyListMessage = "";
   private final Style style;
   private ValueUpdater valueUpdater;

@@ -129,7 +130,6 @@
 childContainer = Document.get().createDivElement();

 emptyMessageElem = Document.get().createDivElement();
-emptyMessageElem.setInnerHTML("no data");
 showOrHide(emptyMessageElem, false);

 // TODO: find some way for cells to communicate what they're  
interested in.

@@ -199,6 +199,15 @@
   public List getDisplayedItems() {
 return new ArrayList(impl.getData());
   }
+
+  /**
+   * Get the message that is displayed when there is no data.
+   *
+   * @return the empty message
+   */
+  public String getEmptyListMessage() {
+return emptyListMessage;
+  }

   public int getPageSize() {
 return impl.getPageSize();
@@ -252,6 +261,20 @@
   }
 }
   }
+
+  /**
+   * Redraw the list using the existing data.
+   */
+  public void redraw() {
+impl.redraw();
+  }
+
+  /**
+   * Redraw the list, requesting data from the delegate.
+   */
+  public void refresh() {
+impl.refresh();
+  }

   public void setData(int start, int length, List values) {
 impl.setData(values, start);
@@ -264,6 +287,16 @@
   public void setDelegate(Delegate delegate) {
 impl.setDelegate(delegate);
   }
+
+  /**
+   * Set the message to display when there is no data.
+   *
+   * @param html the message to display when there are no results
+   */
+  public void setEmptyListMessage(String html) {
+this.emptyListMessage = html;
+emptyMessageElem.setInnerHTML(html);
+  }

   public void setPager(Pager pager) {
 impl.setPager(pager);
===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/bikeshed/style/client/Styles.java	 
Wed May 12 10:44:13 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/bikeshed/style/client/Styles.java	 
Wed May 12 12:06:30 2010

@@ -87,6 +87,11 @@

 String padded();

+/**
+ * Applied to popup panels.
+ */
+String popupPanel();
+
 /**
  * Applied to columns used as spacers.
  */
===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/bikeshed/style/client/common.css	 
Wed May 12 10:44:13 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/bikeshed/style/client/common.css	 
Wed May 12 12:06:30 2010

@@ -82,10 +82,19 @@
   width: 250px;
 }
 .expenseDetailsErrorPopupMessage {
-  padding: 20px;
+  padding-bottom: 20px;
   font-size: 130%;
   color: red;
 }
+
+.popupPanel {
+  border: 8px solid white;
+  border-right: 11px solid white;
+  border-bottom: 11px solid white;
+  -webkit-border-image: url(blueborder.png) 8 11 11 8 round round;
+  -moz-border-image: url(blueborder.png) 8 11 11 8 round round;
+  padding: 10px;
+}

 @sprite .blankOption {
   gwt-image: 'blankIcon';
@@ -204,23 +213,6 @@
   cursor: pointer;
   padding: 0px 4px;
 }
-
-/* dialog box */
-.gwt-DialogBox {
-  border: 8px solid white;
-  border-right: 11px solid white;
-  border-bottom: 11px solid white;
-  -webkit-border-image: url(blueborder.png) 8 11 11 8 round round;
-  -moz-border-image: url(blueborder.png) 8 11 11 8 round round;
-}
-
-.gwt-DialogBox .Caption {
-  font-weight: light;
-  font-size: 12pt;
-  text-align: center;
-  margin-bottom: 0.5em;
-  border-bottom: 1px solid #ccc;
-}

 /* splitters */
 .gwt-SplitLayoutPanel-HDragger {
===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseDetails.java	 
Wed May 12 10:44:13 2010
+++  
/branche

[gwt-contrib] Style tweaks to the denied popup on the Expense Details page. Also removing the 'no data' messa... (issue515801)

[jlabanca]

Reviewers: jgw,

Description:
Style tweaks to the denied popup on the Expense Details page.  Also
removing the 'no data' message in the mobile version.


Please review this at http://gwt-code-reviews.appspot.com/515801/show

Affected files:
  M /bikeshed/src/com/google/gwt/bikeshed/list/client/CellList.java
  M /bikeshed/src/com/google/gwt/sample/bikeshed/style/client/Styles.java
  M /bikeshed/src/com/google/gwt/sample/bikeshed/style/client/common.css
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseDetails.java
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseDetails.ui.xml
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseList.ui.xml
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileReportList.java



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8115 committed - Get data generation ready for bulk uploading

[codesite-noreply]

Revision: 8115
Author: r...@google.com
Date: Wed May 12 11:38:12 2010
Log: Get data generation ready for bulk uploading

http://code.google.com/p/google-web-toolkit/source/detail?r=8115

Modified:
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/DataGenerationService.java
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/DataGenerationServiceAsync.java
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/LoadExpensesDB.java
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/server/DataGenerationServiceImpl.java

 /branches/2.1/bikeshed/war/WEB-INF/web.xml

===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/DataGenerationService.java	 
Tue May 11 10:56:00 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/DataGenerationService.java	 
Wed May 12 11:38:12 2010

@@ -18,6 +18,8 @@
 import com.google.gwt.user.client.rpc.RemoteService;
 import com.google.gwt.user.client.rpc.RemoteServiceRelativePath;

+import java.util.List;
+
 /**
  * Generate random records.
  */
@@ -31,10 +33,11 @@

   /**
* Generate reports for approximately the given number of milliseconds.
-   *
-   * @return the number of reports in the data store following generation
*/
-  int generate(int millis);
-
-  int getNumReports();
-}
+  void generate(int millis);
+
+  /**
+   * @return the number of Employees, Reports, and Expenses.
+   */
+  List getCounts();
+}
===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/DataGenerationServiceAsync.java	 
Tue May 11 10:56:00 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/DataGenerationServiceAsync.java	 
Wed May 12 11:38:12 2010

@@ -17,11 +17,13 @@

 import com.google.gwt.user.client.rpc.AsyncCallback;

+import java.util.List;
+
 /**
  * Async counterpart of {...@link DataGenerationService}.
  */
 public interface DataGenerationServiceAsync {
   void delete(AsyncCallback callback);
-  void generate(int millis, AsyncCallback callback);
-  void getNumReports(AsyncCallback callback);
-}
+  void generate(int millis, AsyncCallback callback);
+  void getCounts(AsyncCallback> callback);
+}
===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/LoadExpensesDB.java	 
Tue May 11 11:18:39 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/LoadExpensesDB.java	 
Wed May 12 11:38:12 2010

@@ -21,10 +21,13 @@
 import com.google.gwt.event.dom.client.ClickHandler;
 import com.google.gwt.user.client.rpc.AsyncCallback;
 import com.google.gwt.user.client.ui.Button;
+import com.google.gwt.user.client.ui.HTML;
 import com.google.gwt.user.client.ui.Label;
 import com.google.gwt.user.client.ui.RootPanel;
 import com.google.gwt.user.client.ui.TextBox;

+import java.util.List;
+
 /**
  * Entry point to create database entries for the Expenses app.
  */
@@ -32,13 +35,20 @@

   private final DataGenerationServiceAsync dataService =  
GWT.create(DataGenerationService.class);


-  private Label generateLabel;
+  private Label statusLabel;
+  private Label numEmployeesLabel;
+  private Label numReportsLabel;
+  private Label numExpensesLabel;
   private Button generateButton;
   private Button deleteButton;
   private TextBox amountTextBox;

   public void onModuleLoad() {
-generateLabel = new Label("-- Expense Reports");
+statusLabel = new Label("");
+numEmployeesLabel = new Label("-- Employees");
+numReportsLabel = new Label("-- Reports");
+numExpensesLabel = new Label("-- Expenses");
+
 generateButton = new Button("Generate Data");
 deleteButton = new Button("Delete everything");
 amountTextBox = new TextBox();
@@ -52,6 +62,7 @@

 deleteButton.addClickHandler(new ClickHandler() {
   public void onClick(ClickEvent event) {
+deleteButton.setEnabled(false);
 deleteData();
   }
 });
@@ -59,43 +70,68 @@
 RootPanel root = RootPanel.get();
 root.add(generateButton);
 root.add(amountTextBox);
-root.add(generateLabel);
-
-// This button deletes the entire data store -- don't expose it by  
default

-// root.add(deleteButton);
-
-dataService.getNumReports(new AsyncCallback() {
+root.add(statusLabel);
+root.add(numEmployeesLabel);
+root.add(numReportsLabel);
+root.add(numExpensesLabel);
+
+root.add(new HTML(""));
+root.add(new HTML(""));
+root.add(new HTML(""));
+root.add(new HTML(""));
+root.add(new HTML(""));
+root.add(new HTML(""));
+
+// This button deletes the entire data store -- be careful
+root.add(deleteButton);
+
+updateCounts();
+  }
+
+  private void deleteData() {
+dataService.delete(new AsyncCallback() {
   public void onFailure(Throwable caught) {
+statusLabel.setText("Deletion failed");
+deleteButton.s

[gwt-contrib] Re: Add a more user friendly popup for logging messages using the new logging framework (issue508801)

[unnurg]

http://gwt-code-reviews.appspot.com/508801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8113 committed - Fixes a bug in RequestFactoryServlet.getContent that corrupts...

[codesite-noreply]

Revision: 8113
Author: knor...@google.com
Date: Wed May 12 09:47:07 2010
Log: Fixes a bug in RequestFactoryServlet.getContent that corrupts
POST data is it spans more than a single read.

http://code.google.com/p/google-web-toolkit/source/detail?r=8113

Modified:
  
/branches/2.1/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java


===
---  
/branches/2.1/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java	 
Mon May 10 13:04:43 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java	 
Wed May 12 09:47:07 2010

@@ -332,9 +332,11 @@
 byte contentBytes[] = new byte[contentLength];
 BufferedInputStream bis = new  
BufferedInputStream(request.getInputStream());

 try {
-  int readBytes = 0;
-  while (bis.read(contentBytes, readBytes, contentLength - readBytes)  

0) {

-// read the contents
+  int contentBytesOffset = 0;
+  int readLen;
+  while ((readLen = bis.read(contentBytes, contentBytesOffset,
+  contentLength - contentBytesOffset)) > 0) {
+contentBytesOffset += readLen;
   }
   // TODO: encoding issues?
   return new String(contentBytes);

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8112 committed - Ant tests for bikeshed/...

[codesite-noreply]

Revision: 8112
Author: gwt.mirror...@gmail.com
Date: Wed May 12 08:52:43 2010
Log: Ant tests for bikeshed/

Review at http://gwt-code-reviews.appspot.com/501801

Review by: k...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8112

Modified:
 /branches/2.1/bikeshed/build.xml

===
--- /branches/2.1/bikeshed/build.xmlTue May  4 09:58:17 2010
+++ /branches/2.1/bikeshed/build.xmlWed May 12 08:52:43 2010
@@ -8,15 +8,42 @@
   location="${gwt.build.lib}/gwt-dev.jar" />
   location="${gwt.build.lib}/gwt-user.jar" />


+  
+  
+  value="${gwt.junit.testcase.includes}" />

+  
+
+  value="${gwt.junit.testcase.includes}" />

+  
+
+  
+  
+
+
+
+
+location="${gwt.tools.lib}/easymock/easymockclassextension.jar"/>

+
+
+  
+
+
+
   
 
   
+  
 
  
   
 
 
   
+  
+
+  
 
   

@@ -42,4 +69,535 @@
 
   

+  
+  
+
+
+  
+
+
+location="${gwt.tools.lib}/tomcat/servlet-api-2.5.jar" />

+
+location="${gwt.tools.lib}/selenium/selenium-java-client-driver.jar" />

+   
+   
+   location="${gwt.tools.lib}/easymock/easymockclassextension.jar"/>

+   
+
+
+  
+
+  
+
+  
+

+  
+
+  
+
+/>

+
++test.args="${test.web.remote.args} -out www -prod -standardsMode  
-runStyle RemoteWeb:${gwt.hosts.web.remote}"

+test.out="${junit.out}/web-remote"
+test.cases="test.web.remote.tests" >
+  
+
+  
+
+  
+
+  
+
+/>

+
++test.args="${test.dev.remote.args} -out www -standardsMode  
-runStyle RemoteWeb:${gwt.hosts.dev.remote}"
+test.out="${junit.out}/dev-remote"  
test.cases="test.dev.remote.tests" >

+  
+
+  
+
+  
+
+  
+
+/>

+
+  +  test.args="${test.emma.remote.args} -out www -standardsMode  
-runStyle RemoteWeb:${gwt.hosts.dev.remote}"

+  test.out="${junit.out}/emma-remote"
+  test.cases="test.emma.remote.tests" >
+  
+
+
+  
+
+  
+
+  
+
+value="${test.args.dev.selenium}" />

+
++test.args='${test.emma.selenium.args} -out www -standardsMode  
-runStyle "Selenium:${gwt.hosts.dev.selenium}"'

+test.out="${junit.out}/emma-selenium"
+test.cases="test.emma.selenium.tests" >
+  
+
+
+  
+
+  
+
+  
+
+value="${test.args.web.remote}" />

+
++test.args="${test.draft.remote.args} -draftCompile -prod  
-standardsMode -out www -runStyle RemoteWeb:${gwt.hosts.web.remote}"

+test.out="${junit.out}/draft-remote"
+test.cases="test.draft.remote.tests" >
+  
+
+  
+
+  
+
+  
+
+value="${test.args.web.remote}" />

+
++test.args="${test.nometa.remote.args} -XdisableClassMetadata -prod  
-standardsMode -out www -runStyle RemoteWeb:${gwt.hosts.web.remote}"

+test.out="${junit.out}/nometa-remote"
+test.cases="test.nometa.remote.tests" >
+  
+
+  
+
+  
+
+  
+

+  
+
+  
+
+value="${test.args.web.selenium}" />

+
++test.args='${test.web.selenium.args} -prod -out www -standardsMode  
-runStyle "Selenium:${gwt.hosts.web.selenium}"'

+test.out="${junit.out}/web-selenium"
+test.cases="test.web.selenium.tests" >
+  
+
+  
+
+  
+
+  
+
+value="${test.args.dev.selenium}" />

+
++test.args='${test.dev.selenium.args} -out www -standardsMode  
-runStyle "Selenium:${gwt.hosts.dev.selenium}"'

+test.out="${junit.out}/dev-selenium"
+test.cases="test.dev.selenium.tests" >
+  
+
+  
+
+  
+
+  
+

+
+
++test.args='${test.nometa.selenium.args} -XdisableClassMetadata  
-prod -standardsMode -out www  
-runStyle "Selenium:${gwt.hosts.web.selenium}"'

+test.out="${junit.out}/nometa-selenium"
+test.cases="test.nometa.selenium.tests" >
+  
+
+  
+
+  
+
+  
+

+
+
++test.args='${test.draft.selenium.args} -draftCompile -prod -out  
www -standardsMode -runStyle "Selenium:${gwt.hosts.web.selenium}"'

+test.out="${junit.out}/draft-selenium"
+test.cases="test.draft.selenium.tests" >
+  
+
+  
+
+  
+
+  
+  
+  
+  
+
+
+  
+
+  
+
+  
+
+
+  
+
+  
+
+  
+
+  
+

+  
+
+  
+
+  
+
+  
+
+
+  
+
+  
+
+  
+
+  
+
+
+  
+
+  
+
+  
+
+  
+
++test.args="${test.args} -XdisableClassMetadata -out www -prod  
-standardsMode"

+test.out="${junit.out}/nometa-htmlunit"
+test.cases="test.nometa.htmlunit.tests" >
+  
+
+  
+
+  
+
+  +  description="Run d

[gwt-contrib] Re: Make JettyLauncher work with Spring apps (issue496802)

[Scott Blum]

On Wed, May 12, 2010 at 5:13 PM,  wrote:

> I don't know either. The way it is done now essentially breaks apps
> running Dev Mode in GPE which don't have all jars in WEB-INF/lib but
> instead have them on the project's classpath and by this on the system
> path.


That was actually the intent.  We wanted to nudge users into putting
everything they need into WEB-INF so that their war is in a readily
deployable state.  Otherwise, things that worked in dev mode might suddenly
break in a real deployment.

If you are working in an environment where you don't want to put things into
WEB-INF, maybe what you really want is a new SCL?

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a more user friendly popup for logging messages using the new logging framework (issue508801)

[unnurg]

Comments Addressed


http://gwt-code-reviews.appspot.com/508801/diff/1/6
File /user/src/com/google/gwt/logging/client/LoggingPopup.java (right):

http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode50
/user/src/com/google/gwt/logging/client/LoggingPopup.java:50:
MouseUpHandler, MouseDownHandler {
On 2010/05/12 19:38:26, fredsa wrote:

I understand the need to drag and resize the panel, and the lack of a

standard

widget for this, but I hate to see all this custom drag/drop code

here.

Also, does all of this work in both quirks and standard mode in

supported

browsers?
Would it make sense to use the existing drag/drop functionality of

DialogBox and

only add resizing here?


That's the way this was originally written, but I ran into 2 problems. 1
- I couldn't add anything to that top panel (in the end, I put the
minimize button at the bottom anyway, but this implementation leaves me
the option of changing it if I want to) and 2 - Making a border around
the entire popup with the correct outlines was a pain.  In the end, the
only additional code to support drag as well as resize is the
WindowMoveHandler (which only has a single 2-line function).  If I used
a DialogBox, I'd still need all of the code in this base class for
WindowResizeHandler.

http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode137
/user/src/com/google/gwt/logging/client/LoggingPopup.java:137: //
library, styling for this window is done pretty manually.
On 2010/05/12 19:38:26, fredsa wrote:

Have you verified styling in both standards and quirks mode in all

supported

browsers?


Working on that now - will send confirmation when done (along with a
separate patch with any required fixes)

http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode141
/user/src/com/google/gwt/logging/client/LoggingPopup.java:141:
mainPanel.getElement().setAttribute("style", "background-color:white");
On 2010/05/12 19:38:26, fredsa wrote:

mainPanel.getElement().getStyle().setBackgroundColor("white");


Done.

http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode143
/user/src/com/google/gwt/logging/client/LoggingPopup.java:143: final
HTML titleBar = new HTML("Logging");
On 2010/05/12 19:38:26, fredsa wrote:

IIRC,  is deprecated. Does it still work in standards mode

with a strict

DOCTYPE?


Replaced with 

http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode151
/user/src/com/google/gwt/logging/client/LoggingPopup.java:151:
scrollPanel.setPixelSize(300, 200);
On 2010/05/12 19:38:26, fredsa wrote:

Might need to be set these values relative to the available window

size, which

may be small (mobile) in some cases, or large (developer desktop), in

which case

you may want it bigger by default. Perhaps set the size in absolute

pixels, but

calculate based on current window size.


Done.

http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode158
/user/src/com/google/gwt/logging/client/LoggingPopup.java:158: final
Button maxmin = new Button("Minimize");
On 2010/05/12 19:38:26, fredsa wrote:

For i18n suggest simple ASCII art:



Minimize -->   ><
Maximize -->   <>


Done.

http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode176
/user/src/com/google/gwt/logging/client/LoggingPopup.java:176:
resizeIcon.setHorizontalAlignment(HasHorizontalAlignment.ALIGN_RIGHT);
On 2010/05/12 19:38:26, fredsa wrote:

Add comment to indicate name of this unicode character


Done.

http://gwt-code-reviews.appspot.com/508801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8111 committed - Adds remote_api support for the datastore bulk uploader to web.xml...

[codesite-noreply]

Revision: 8111
Author: zun...@google.com
Date: Wed May 12 08:28:52 2010
Log: Adds remote_api support for the datastore bulk uploader to web.xml
Note that this change also requires that you add appengine-tools-api.jar to
get the servlet class.

Review at http://gwt-code-reviews.appspot.com/513801

http://code.google.com/p/google-web-toolkit/source/detail?r=8111

Modified:
 /branches/2.1/bikeshed/eclipse.README
 /branches/2.1/bikeshed/war/WEB-INF/web.xml

===
--- /branches/2.1/bikeshed/eclipse.README   Tue May 11 05:04:43 2010
+++ /branches/2.1/bikeshed/eclipse.README   Wed May 12 08:28:52 2010
@@ -37,5 +37,6 @@
   * Java Build Path > Libraries > Add Variable > GWT_TOOLS, Extend >  
lib/apache/commons/commons-httpclient-3.1.jar

 * Copy tools/redist/json/r2_20080312/json.jar to bikeshed/war/WEB_INF/lib
 * Copy all jars from  bikeshed/war/temp-lib to bikeshed/war/WEB-INF/lib
+* Copy appengine-tools-api.jar from your appengine sdk to  
bikeshed/war/WEB-INF/lib
 * Right click on the bikeshed project and choose Run as > Web Application.  
Choose from the various .html files


===
--- /branches/2.1/bikeshed/war/WEB-INF/web.xml  Tue May 11 21:32:44 2010
+++ /branches/2.1/bikeshed/war/WEB-INF/web.xml  Wed May 12 08:28:52 2010
@@ -89,6 +89,26 @@
   
   -->

+  
+  
+  
+remoteapi
+ 
com.google.apphosting.utils.remoteapi.RemoteApiServlet

+  
+  
+remoteapi
+/remote_api
+  
+  
+
+  remoteapi
+  /remote_api
+
+
+  admin
+
+  
+
   
 

[gwt-contrib] [google-web-toolkit] r8110 committed - Merging tr...@7971 back into branches/2.1....

[codesite-noreply]

Revision: 8110
Author: sco...@google.com
Date: Wed May 12 14:13:16 2010
Log: Merging tr...@7971 back into branches/2.1.

Review by: fabbott

http://code.google.com/p/google-web-toolkit/source/detail?r=8110

Added:
  
/branches/2.1/user/test/com/google/gwt/junit/DevModeOnCompiledScriptTest.gwt.xml

 /branches/2.1/user/test/com/google/gwt/junit/JUnitBridge.java
  
/branches/2.1/user/test/com/google/gwt/junit/client/DevModeOnCompiledScriptTest.java
  
/branches/2.1/user/test-super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/DevModeOnCompiledScriptTest.java

Modified:
 /branches/2.1/dev/core/src/com/google/gwt/dev/Compiler.java
 /branches/2.1/dev/core/src/com/google/gwt/dev/DevMode.java
 /branches/2.1/dev/core/src/com/google/gwt/dev/DevModeBase.java
  
/branches/2.1/dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java
  
/branches/2.1/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerWarDir.java

 /branches/2.1/eclipse/user/.classpath
 /branches/2.1/user/build.xml
 /branches/2.1/user/src/com/google/gwt/junit/CompileStrategy.java
 /branches/2.1/user/src/com/google/gwt/junit/JUnit.gwt.xml
 /branches/2.1/user/src/com/google/gwt/junit/JUnitShell.java
 /branches/2.1/user/src/com/google/gwt/junit/server/JUnitHostImpl.java
 /branches/2.1/user/test/com/google/gwt/core/ext/test/XSLinkerTest.java
 /branches/2.1/user/test/com/google/gwt/dev/jjs/RunAsyncFailure.gwt.xml
 /branches/2.1/user/test/com/google/gwt/http/RequestBuilderTest.gwt.xml
 /branches/2.1/user/test/com/google/gwt/http/ResponseTest.gwt.xml
  
/branches/2.1/user/test/com/google/gwt/http/server/RequestBuilderTestServlet.java

 /branches/2.1/user/test/com/google/gwt/junit/JUnitSuite.java

===
--- /dev/null
+++  
/branches/2.1/user/test/com/google/gwt/junit/DevModeOnCompiledScriptTest.gwt.xml	 
Wed May 12 14:13:16 2010

@@ -0,0 +1,17 @@
+
+
+
+
+
+
+
+
+
+
+
+
+

+
+
+  
+
===
--- /dev/null
+++ /branches/2.1/user/test/com/google/gwt/junit/JUnitBridge.java	Wed May  
12 14:13:16 2010

@@ -0,0 +1,31 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,  
WITHOUT

+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under

+ * the License.
+ */
+package com.google.gwt.junit;
+
+import com.google.gwt.core.ext.UnableToCompleteException;
+import com.google.gwt.dev.cfg.ModuleDef;
+
+/**
+ * Provides access to {...@link JUnitShell}.
+ */
+public class JUnitBridge {
+  public static void compileForWebMode(ModuleDef module)
+  throws UnableToCompleteException {
+JUnitShell.getUnitTestShell().compileForWebMode(module,
+JUnitShell.getRemoteUserAgents());
+  }
+
+}
===
--- /dev/null
+++  
/branches/2.1/user/test/com/google/gwt/junit/client/DevModeOnCompiledScriptTest.java	 
Wed May 12 14:13:16 2010

@@ -0,0 +1,75 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,  
WITHOUT

+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under

+ * the License.
+ */
+package com.google.gwt.junit.client;
+
+import com.google.gwt.core.ext.UnableToCompleteException;
+import com.google.gwt.dev.cfg.ModuleDef;
+import com.google.gwt.junit.DoNotRunWith;
+import com.google.gwt.junit.JUnitBridge;
+import com.google.gwt.junit.Platform;
+import com.google.gwt.junit.JUnitShell.Strategy;
+import com.google.gwt.junit.client.impl.JUnitResult;
+
+import junit.framework.TestCase;
+
+/**
+ * Tests that we can run a test in dev mode even when the selection script  
is
+ * from a compile. Note that this is the VM-only version of the class;  
there is

+ * a translatable version for the client side.
+ */
+...@donotrunwith(Platform.Prod)
+public class DevModeOnCompiledScriptTest extends GWTTestCase {
+
+  @Override
+  public String getModuleName() {
+return "com.google.gwt.junit.DevModeOnCompiledScriptTest";
+  }
+
+  /**
+   * GWT-unfriendly, forcing us to use a translatable class.
+   */
+  @Override
+  public Strategy getStrategy() {
+final Strategy impl = super.getStrategy();
+return new Strategy() {
+  pub

[gwt-contrib] Re: Make JettyLauncher work with Spring apps (issue496802)

[Scott Blum]

On Wed, May 12, 2010 at 4:41 PM,  wrote:

> Scott, your changes work from my end.
>
> I needed to do another change which I like your comment on:
>
>  @Override
>  public boolean isServerPath(String name) {
>if (name.startsWith("org.slf4j")) {
>  return false;
>}
>return super.isServerPath(name);
>  }
>
> I need this as some components (like Hibernate Validator) that are
> loaded from the WebAppClassLoader need access to slf4j.
>

Honestly, this whole mess is pretty confusing.  I have no idea why the Jetty
guys wanted to blacklist that package in the first place
(org.mortbay.jetty.webapp.WebAppContextClass._serverClasses), or exactly
what the semantics are supposed to be.

Is it possible they wanted to force the user to stick their *own* copy of
slf4j inside of WEB-INF and have it live in an isolated world from the
servlet container's version?

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RR : Reimplement DevMode JavaScriptObject support (issue473801)

[scottb]

Cursory review of the non-dev code.  Having .cast() not work would
bother me.  Will get to the dev code soon.


http://gwt-code-reviews.appspot.com/473801/diff/5001/6015
File user/src/com/google/gwt/user/client/DOM.java (right):

http://gwt-code-reviews.appspot.com/473801/diff/5001/6015#newcode750
user/src/com/google/gwt/user/client/DOM.java:750: return (Element)
Document.get().getElementById(id);
This change doesn't make sense to me.  At some point, the bytecode
really has to do a cast operation to Element.  Is this necessary?  If
so, I think something is broken.

http://gwt-code-reviews.appspot.com/473801/diff/5001/6016
File user/src/com/google/gwt/user/client/ui/RootPanel.java (right):

http://gwt-code-reviews.appspot.com/473801/diff/5001/6016#newcode286
user/src/com/google/gwt/user/client/ui/RootPanel.java:286: element =
element.getParentElement();
Again.. necessary?

http://gwt-code-reviews.appspot.com/473801/diff/5001/6019
File user/test/com/google/gwt/dev/jjs/test/SingleJsoImplTest.java
(right):

http://gwt-code-reviews.appspot.com/473801/diff/5001/6019#newcode960
user/test/com/google/gwt/dev/jjs/test/SingleJsoImplTest.java:960: public
void XXXtestCreatedWithCast() {
Sounds like this whole test and a lot of code wants to be deleted.

http://gwt-code-reviews.appspot.com/473801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RR : Fix JsoRestrictionsChecker bug with abstract JSO types (issue495801)

[scottb]

Mostly LG, concerned about generics though.  I'm 99% sure the code in
GenerateJavaAST is correct.


http://gwt-code-reviews.appspot.com/495801/diff/1/2
File dev/core/src/com/google/gwt/dev/javac/JSORestrictionsChecker.java
(right):

http://gwt-code-reviews.appspot.com/495801/diff/1/2#newcode275
dev/core/src/com/google/gwt/dev/javac/JSORestrictionsChecker.java:275:
private boolean implementsMethod(ReferenceBinding implType,
Generally speaking, are you sure this handles generics correctly?
Compare with the code in
GenerateJavaAST.JavaASTGenerationVisitor.tryFindUpRefsRecursive(JMethod,
MethodBinding, ReferenceBinding).

Two key things it does:

1)

/*
 * Always look for uprefs in the original, so we can correctly compare
 * erased signatures. The general design for uprefs is to model what the
 * JVM does in terms of matching up overrides based on binary match.
 */
searchThisType = (ReferenceBinding) searchThisType.original();

2)

if (binding.returnType.erasure() == tryMethod.returnType.erasure()
&& binding.areParameterErasuresEqual(tryMethod)) {

http://gwt-code-reviews.appspot.com/495801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adds a loading animation to the table. Adds timers to desktop and mobile to refresh tables as d... (issue503802)

[jlabanca]

Reviewers: jgw,

Description:
Adds a loading animation to the table.  Adds timers to desktop and
mobile to refresh tables as data becomes available.  In desktop, new
reports and expenses flash and fade out.  In mobile, denied expenses
flash and fade out.


Please review this at http://gwt-code-reviews.appspot.com/503802/show

Affected files:
  M /bikeshed/src/com/google/gwt/bikeshed/list/client/AbstractPager.java
  M /bikeshed/src/com/google/gwt/bikeshed/list/client/CellList.java
  M /bikeshed/src/com/google/gwt/bikeshed/list/client/CellTable.css
  M /bikeshed/src/com/google/gwt/bikeshed/list/client/CellTable.java
  M /bikeshed/src/com/google/gwt/bikeshed/list/client/CellTableClean.css
  M /bikeshed/src/com/google/gwt/bikeshed/list/client/SimplePager.java
  M /bikeshed/src/com/google/gwt/sample/bikeshed/style/client/Styles.java
  M /bikeshed/src/com/google/gwt/sample/bikeshed/style/client/common.css
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseDetails.java
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseDetailsCellTable.css

  M /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseList.java
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseListCellTable.css

  M /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/Expenses.java
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobileShell.java
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseDetails.java
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseEntry.java
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java

  M /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobilePage.java
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileReportList.java
  A  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/PhaseAnimation.java
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ReportRequest.java
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/server/DataGenerationServiceImpl.java

  M /bikeshed/src/com/google/gwt/sample/expenses/server/domain/Report.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make JettyLauncher work with Spring apps (issue496802)

[scottb]

   if (!addContainingClassPathEntry(warnMessage, next, name)) {
 return null;
   }


Should just be:


  addContainingClassPathEntry(warnMessage, next, name);


http://gwt-code-reviews.appspot.com/496802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a more user friendly popup for logging messages using the new logging framework (issue508801)

[fredsa]

http://gwt-code-reviews.appspot.com/508801/diff/1/6
File /user/src/com/google/gwt/logging/client/LoggingPopup.java (right):

http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode50
/user/src/com/google/gwt/logging/client/LoggingPopup.java:50:
MouseUpHandler, MouseDownHandler {
I understand the need to drag and resize the panel, and the lack of a
standard widget for this, but I hate to see all this custom drag/drop
code here.
Also, does all of this work in both quirks and standard mode in
supported browsers?
Would it make sense to use the existing drag/drop functionality of
DialogBox and only add resizing here?

http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode137
/user/src/com/google/gwt/logging/client/LoggingPopup.java:137: //
library, styling for this window is done pretty manually.
Have you verified styling in both standards and quirks mode in all
supported browsers?

http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode141
/user/src/com/google/gwt/logging/client/LoggingPopup.java:141:
mainPanel.getElement().setAttribute("style", "background-color:white");
mainPanel.getElement().getStyle().setBackgroundColor("white");

http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode143
/user/src/com/google/gwt/logging/client/LoggingPopup.java:143: final
HTML titleBar = new HTML("Logging");
IIRC,  is deprecated. Does it still work in standards mode with
a strict DOCTYPE?

http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode151
/user/src/com/google/gwt/logging/client/LoggingPopup.java:151:
scrollPanel.setPixelSize(300, 200);
Might need to be set these values relative to the available window size,
which may be small (mobile) in some cases, or large (developer desktop),
in which case you may want it bigger by default. Perhaps set the size in
absolute pixels, but calculate based on current window size.

http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode158
/user/src/com/google/gwt/logging/client/LoggingPopup.java:158: final
Button maxmin = new Button("Minimize");
For i18n suggest simple ASCII art:

Minimize -->   ><
Maximize -->   <>

http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode176
/user/src/com/google/gwt/logging/client/LoggingPopup.java:176:
resizeIcon.setHorizontalAlignment(HasHorizontalAlignment.ALIGN_RIGHT);
Add comment to indicate name of this unicode character

http://gwt-code-reviews.appspot.com/508801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make JettyLauncher work with Spring apps (issue496802)

[scottb]

I think I see where this is going, but it seems a little overly
simplistic to me.  What about something like this (untested)?

@SuppressWarnings("unchecked")
@Override
public Enumeration findResources(String name) throws IOException {
  LinkedHashSet results = new LinkedHashSet();

  // Specifically for
META-INF/services/javax.xml.parsers.SAXParserFactory
  String checkName = name;
  if (checkName.startsWith(META_INF_SERVICES)) {
checkName = checkName.substring(META_INF_SERVICES.length());
  }

  // For a system path, load from the outside world first without
warning.
  if (isSystemPath(checkName)) {
for (Enumeration resources =
systemClassLoader.getResources(name); resources.hasMoreElements();) {
  results.add(resources.nextElement());
}
  }

  // Check this ClassLoader.
  for (Enumeration resources = super.findResources(name);
resources.hasMoreElements();) {
results.add(resources.nextElement());
  }

  // Add any additional system resources, but this time warn.
  if (!isSystemPath(checkName)) {
Enumeration resources = systemClassLoader.getResources(name);
if (resources != null) {
  while (resources.hasMoreElements()) {
URL next = resources.nextElement();
if (!results.contains(next)) {
  // Warn, add containing URL to our own ClassLoader.
  String warnMessage = "Server resource '" + name
  + "' was found on the system classpath";
  if (!addContainingClassPathEntry(warnMessage, next, name)) {
return null;
  }
  results.add(next);
}
  }
}
  }

  return new IteratorEnumeration(results.iterator());
}

http://gwt-code-reviews.appspot.com/496802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8109 committed - Updated servlet mappings.

[codesite-noreply]

Revision: 8109
Author: zun...@google.com
Date: Wed May 12 09:16:18 2010
Log: Updated servlet mappings.

http://code.google.com/p/google-web-toolkit/source/detail?r=8109

Modified:
 /trunk/bikeshed/war/WEB-INF/web.xml

===
--- /trunk/bikeshed/war/WEB-INF/web.xml Tue May 11 06:23:45 2010
+++ /trunk/bikeshed/war/WEB-INF/web.xml Wed May 12 09:16:18 2010
@@ -27,11 +27,6 @@
  
com.google.gwt.sample.bikeshed.cookbook.server.TreeServiceImpl

   

-  
-remoteApi
- 
com.google.apphosting.utils.remoteapi.RemoteApiServlet

-  
-
   
 expensesData
 /expenses/data
@@ -52,11 +47,6 @@
 /cookbook/tree
   

-  
-remoteApi
-/remote_api
-  
-
   
   
 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make JettyLauncher work with Spring apps (issue496802)

[rjrjr]

Scott, can you take this? The patch file is a bit botched but it's just
a new method override.

http://gwt-code-reviews.appspot.com/496802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: use ParameterizedType at GWT#create method (issue429801)

[Scott Blum]

This link works:

http://gwt-code-reviews.appspot.com/429801/show

Why don't you close out the
other issues, if they're still open.

On Wed, May 12, 2010 at 2:05 PM, Joel Webber  wrote:

> I'm not the right one to review this, but I just wanted you to (a)
> apologize for your email getting caught by the spam filter (which I just
> fixed), and (b) let you know that we're all pretty slammed getting ready for
> I/O, so it might be a while before anyone has time to take a look. This
> looks like a fairly complex change, so it would be very helpful if you could
> post some sort of (at least rough) design document.
>
> Le 1 mai 2010 03:50,  a écrit :
>
> Hi All
>>
>> This patch is my first contribution.
>> I don't know whom to ask for this review.
>> Please teach it to me?
>>
>>
>> http://gwt-code-reviews.appspot.com/429801/show
>>
>> --
>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>>
>
>  --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: use ParameterizedType at GWT#create method (issue429801)

[Joel Webber]

I'm not the right one to review this, but I just wanted you to (a) apologize
for your email getting caught by the spam filter (which I just fixed), and
(b) let you know that we're all pretty slammed getting ready for I/O, so it
might be a while before anyone has time to take a look. This looks like a
fairly complex change, so it would be very helpful if you could post some
sort of (at least rough) design document.

Le 1 mai 2010 03:50,  a écrit :

> Hi All
>
> This patch is my first contribution.
> I don't know whom to ask for this review.
> Please teach it to me?
>
>
> http://gwt-code-reviews.appspot.com/429801/show
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8108 committed - Updating Mobile expenses app now that prices are stored in dollars ins...

[codesite-noreply]

Revision: 8108
Author: jlaba...@google.com
Date: Wed May 12 07:49:05 2010
Log: Updating Mobile expenses app now that prices are stored in dollars  
instead of cents.


Review at http://gwt-code-reviews.appspot.com/514801

Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8108

Modified:
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobile.java
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseDetails.java
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseEntry.java
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java


===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobile.java	 
Mon May 10 10:53:16 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobile.java	 
Wed May 12 07:49:05 2010

@@ -28,10 +28,13 @@

   /**
* TODO(jgw): Put this some place more sensible.
+   *
+   * @param amount the amount in dollars
*/
-  public static String formatCurrency(int price) {
+  public static String formatCurrency(double amount) {
 StringBuilder sb = new StringBuilder();

+int price = (int) (amount * 100);
 boolean negative = price < 0;
 if (negative) {
   price = -price;
===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseDetails.java	 
Tue May 11 10:56:00 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseDetails.java	 
Wed May 12 07:49:05 2010

@@ -119,6 +119,6 @@
 nameText.setInnerText(expense.getDescription());
 dateText.setInnerText(formatter.format(expense.getCreated()));
 categoryText.setInnerText(expense.getCategory());
- 
priceText.setInnerText(ExpensesMobile.formatCurrency(expense.getAmount().intValue()));
+ 
priceText.setInnerText(ExpensesMobile.formatCurrency(expense.getAmount()));

   }
 }
===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseEntry.java	 
Tue May 11 10:56:00 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseEntry.java	 
Wed May 12 07:49:05 2010

@@ -105,7 +105,7 @@
 // TODO(jgw): validate amount (in dollars -- database is in pennies)
 String amountText = priceText.getText();
 double amount = Double.parseDouble(amountText);
-deltas.set(ExpenseRecord.amount, expense, amount * 100);
+deltas.set(ExpenseRecord.amount, expense, amount);

 // TODO(jgw): Use non-deprecated date methods for this.
 Date date = new Date(
@@ -145,7 +145,7 @@
   private void displayExpense() {
 nameText.setText(expense.getDescription());
 categoryText.setText(expense.getCategory());
- 
priceText.setText(ExpensesMobile.formatCurrency(expense.getAmount().intValue()));

+priceText.setText(ExpensesMobile.formatCurrency(expense.getAmount()));

 // TODO(jgw): Use non-deprecated date methods for this.
 Date d = expense.getCreated();
===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java	 
Tue May 11 07:01:15 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java	 
Wed May 12 07:49:05 2010

@@ -44,6 +44,7 @@
*/
   public interface Listener {
 void onExpenseSelected(ExpenseRecord expense);
+
 void onCreateExpense(String reportId);
   }

@@ -65,8 +66,8 @@
   @Override
   public void render(ExpenseRecord value, Object viewData,
   StringBuilder sb) {
-sb.append("" +  
value.getDescription() + " ($" +

-ExpensesMobile.formatCurrency(value.getAmount().intValue())
+sb.append("" +  
value.getDescription()

++ " ($" + ExpensesMobile.formatCurrency(value.getAmount())
 + ")");
   }
 });

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Any plans (new) for supporting Scala?

[Jxtps]

I followed the "Any plans for supporting Scala ?" thread with great
interest:

http://groups.google.com/group/google-web-toolkit-contributors/browse_thread/thread/6d4339fb17803e/c85e2f10a0d743ec?lnk=gst&q=scala#c85e2f10a0d743ec

Now that GWT 2.0 is out, is there any renewed interest in/progress on
this?

Would love to switch to "all scala, all the time" - I very much second
Maxime's comment that it's a chicken and egg thing. Scala is almost
there in terms of tool & framework/library support and looks so
promising - getting GWT support would be a deal maker for at least
yours truly.

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] use ParameterizedType at GWT#create method (issue428801)

[takeshi . kondo]

Reviewers: ,

Description:
Google Guice can inject ParameterizedType instance. But google-gin
ignores
TypeParameters. Because GWT#create method can't accept
ParameterizedType.

I want to use ParameterizedType at GWT#create. I think it makes simple
programing model.

http://code.google.com/p/google-web-toolkit/issues/detail?id=4897

Please review this at http://gwt-code-reviews.appspot.com/428801/show

Affected files:
  dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java
  dev/core/src/com/google/gwt/dev/jdt/FindDeferredBindingSitesVisitor.java
  dev/core/src/com/google/gwt/dev/jjs/ast/JClassLiteral.java
  dev/core/src/com/google/gwt/dev/jjs/ast/JClassType.java
  dev/core/src/com/google/gwt/dev/jjs/ast/JParameterizedType.java
  dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
  dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java
  dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRebinds.java
  dev/core/src/com/google/gwt/dev/jjs/impl/TypeMap.java
  dev/core/src/com/google/gwt/dev/shell/GWTBridgeImpl.java
  dev/core/super/com/google/gwt/core/client/GWTBridge.java
  user/src/com/google/gwt/core/client/GWT.java
  user/src/com/google/gwt/core/client/TypeLiteral.java
  user/src/com/google/gwt/core/client/impl/ParameterizedTypeImpl.java
  user/src/com/google/gwt/junit/GWTDummyBridge.java
  user/super/com/google/gwt/emul/java/lang/Class.java
  user/super/com/google/gwt/emul/java/lang/reflect/GenericArrayType.java
  user/super/com/google/gwt/emul/java/lang/reflect/ParameterizedType.java
  user/super/com/google/gwt/emul/java/lang/reflect/Type.java
  user/test/com/google/gwt/core/client/GWTTest.java
  user/test/com/google/gwt/core/ext/GeneratorTest.gwt.xml
  user/test/com/google/gwt/core/ext/rebind/TestGenerator.java
  user/test/com/google/gwt/core/ext/test/GeneratorTest.java
  user/test/com/google/gwt/emultest/EmulSuite.java
  user/test/com/google/gwt/emultest/java/lang/ClassTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] use ParameterizedType at GWT#create method (issue369806)

[takeshi . kondo]

Reviewers: ,

Description:
Google Guice can inject ParameterizedType instance. But google-gin
ignores TypeParameters. Because GWT#create method can't accept
ParameterizedType.

I want to use ParameterizedType at GWT#create.
I think it makes simple programing model of GWT.

http://code.google.com/p/google-web-toolkit/issues/detail?id=4897

Please review this at http://gwt-code-reviews.appspot.com/369806/show

Affected files:
  dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java
  dev/core/src/com/google/gwt/dev/jdt/FindDeferredBindingSitesVisitor.java
  dev/core/src/com/google/gwt/dev/jjs/ast/JClassLiteral.java
  dev/core/src/com/google/gwt/dev/jjs/ast/JClassType.java
  dev/core/src/com/google/gwt/dev/jjs/ast/JParameterizedType.java
  dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
  dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java
  dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRebinds.java
  dev/core/src/com/google/gwt/dev/jjs/impl/TypeMap.java
  dev/core/src/com/google/gwt/dev/shell/GWTBridgeImpl.java
  dev/core/super/com/google/gwt/core/client/GWTBridge.java
  user/src/com/google/gwt/core/client/GWT.java
  user/src/com/google/gwt/core/client/TypeLiteral.java
  user/src/com/google/gwt/core/client/impl/ParameterizedTypeImpl.java
  user/src/com/google/gwt/junit/GWTDummyBridge.java
  user/super/com/google/gwt/emul/java/lang/Class.java
  user/super/com/google/gwt/emul/java/lang/reflect/GenericArrayType.java
  user/super/com/google/gwt/emul/java/lang/reflect/ParameterizedType.java
  user/super/com/google/gwt/emul/java/lang/reflect/Type.java
  user/test/com/google/gwt/core/client/GWTTest.java
  user/test/com/google/gwt/core/ext/GeneratorTest.gwt.xml
  user/test/com/google/gwt/core/ext/rebind/TestGenerator.java
  user/test/com/google/gwt/core/ext/test/GeneratorTest.java
  user/test/com/google/gwt/emultest/EmulSuite.java
  user/test/com/google/gwt/emultest/java/lang/ClassTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: use ParameterizedType at GWT#create method (issue429801)

[takeshi . kondo]

Hi All

This patch is my first contribution.
I don't know whom to ask for this review.
Please teach it to me?

http://gwt-code-reviews.appspot.com/429801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] use ParameterizedType at GWT#create method (issue429801)

[takeshi . kondo]

Reviewers: ,

Description:
Google Guice can inject ParameterizedType instance. But google-gin
ignores
TypeParameters. Because GWT#create method can't accept
ParameterizedType.

I want to use ParameterizedType at GWT#create. I think it makes simple
programing model.

http://code.google.com/p/google-web-toolkit/issues/detail?id=4897

Please review this at http://gwt-code-reviews.appspot.com/429801/show

Affected files:
  .project
  dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java
  dev/core/src/com/google/gwt/dev/jdt/FindDeferredBindingSitesVisitor.java
  dev/core/src/com/google/gwt/dev/jjs/ast/JClassLiteral.java
  dev/core/src/com/google/gwt/dev/jjs/ast/JClassType.java
  dev/core/src/com/google/gwt/dev/jjs/ast/JParameterizedType.java
  dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
  dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java
  dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRebinds.java
  dev/core/src/com/google/gwt/dev/jjs/impl/TypeMap.java
  dev/core/src/com/google/gwt/dev/shell/GWTBridgeImpl.java
  dev/core/super/com/google/gwt/core/client/GWTBridge.java
  user/src/com/google/gwt/core/client/GWT.java
  user/src/com/google/gwt/core/client/TypeLiteral.java
  user/src/com/google/gwt/core/client/impl/ParameterizedTypeImpl.java
  user/src/com/google/gwt/junit/GWTDummyBridge.java
  user/super/com/google/gwt/emul/java/lang/Class.java
  user/super/com/google/gwt/emul/java/lang/reflect/GenericArrayType.java
  user/super/com/google/gwt/emul/java/lang/reflect/ParameterizedType.java
  user/super/com/google/gwt/emul/java/lang/reflect/Type.java
  user/test/com/google/gwt/core/client/GWTTest.java
  user/test/com/google/gwt/core/ext/GeneratorTest.gwt.xml
  user/test/com/google/gwt/core/ext/rebind/TestGenerator.java
  user/test/com/google/gwt/core/ext/test/GeneratorTest.java
  user/test/com/google/gwt/emultest/EmulSuite.java
  user/test/com/google/gwt/emultest/java/lang/ClassTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updating Mobile expenses app now that prices are stored in dollars instead of cents. (issue514801)

[jgw]

On 2010/05/12 16:49:01, jlabanca wrote:


LGTM

http://gwt-code-reviews.appspot.com/514801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8107 committed - Reverting tr...@7971: "Re-rolling r7955: JUnitShell now subclasses Dev...

[codesite-noreply]

Revision: 8107
Author: sco...@google.com
Date: Wed May 12 10:39:51 2010
Log: Reverting tr...@7971: "Re-rolling r7955: JUnitShell now subclasses  
DevMode instead of GWTShell."


Review by: fabbott (desk)
http://code.google.com/p/google-web-toolkit/source/detail?r=8107

Deleted:
  
/branches/2.1/user/test/com/google/gwt/junit/DevModeOnCompiledScriptTest.gwt.xml

 /branches/2.1/user/test/com/google/gwt/junit/JUnitBridge.java
  
/branches/2.1/user/test/com/google/gwt/junit/client/DevModeOnCompiledScriptTest.java
  
/branches/2.1/user/test-super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/DevModeOnCompiledScriptTest.java

Modified:
 /branches/2.1/dev/core/src/com/google/gwt/dev/Compiler.java
 /branches/2.1/dev/core/src/com/google/gwt/dev/DevMode.java
  
/branches/2.1/dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java
  
/branches/2.1/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerWarDir.java

 /branches/2.1/eclipse/user/.classpath
 /branches/2.1/user/src/com/google/gwt/junit/CompileStrategy.java
 /branches/2.1/user/src/com/google/gwt/junit/JUnitShell.java
 /branches/2.1/user/src/com/google/gwt/junit/server/JUnitHostImpl.java
 /branches/2.1/user/test/com/google/gwt/core/ext/test/XSLinkerTest.java
 /branches/2.1/user/test/com/google/gwt/dev/jjs/RunAsyncFailure.gwt.xml
 /branches/2.1/user/test/com/google/gwt/http/RequestBuilderTest.gwt.xml
 /branches/2.1/user/test/com/google/gwt/http/ResponseTest.gwt.xml
  
/branches/2.1/user/test/com/google/gwt/http/server/RequestBuilderTestServlet.java

 /branches/2.1/user/test/com/google/gwt/junit/JUnitSuite.java

===
---  
/branches/2.1/user/test/com/google/gwt/junit/DevModeOnCompiledScriptTest.gwt.xml	 
Fri Apr 23 06:39:33 2010

+++ /dev/null
@@ -1,17 +0,0 @@
-
-
-
-
-
-
-
-
-
-
-
-
-

-
-
-  
-
===
--- /branches/2.1/user/test/com/google/gwt/junit/JUnitBridge.java	Fri Apr  
23 06:39:33 2010

+++ /dev/null
@@ -1,31 +0,0 @@
-/*
- * Copyright 2010 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may  
not
- * use this file except in compliance with the License. You may obtain a  
copy of

- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,  
WITHOUT

- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations  
under

- * the License.
- */
-package com.google.gwt.junit;
-
-import com.google.gwt.core.ext.UnableToCompleteException;
-import com.google.gwt.dev.cfg.ModuleDef;
-
-/**
- * Provides access to {...@link JUnitShell}.
- */
-public class JUnitBridge {
-  public static void compileForWebMode(ModuleDef module)
-  throws UnableToCompleteException {
-JUnitShell.getUnitTestShell().compileForWebMode(module,
-JUnitShell.getRemoteUserAgents());
-  }
-
-}
===
---  
/branches/2.1/user/test/com/google/gwt/junit/client/DevModeOnCompiledScriptTest.java	 
Fri Apr 23 06:39:33 2010

+++ /dev/null
@@ -1,75 +0,0 @@
-/*
- * Copyright 2010 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may  
not
- * use this file except in compliance with the License. You may obtain a  
copy of

- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,  
WITHOUT

- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations  
under

- * the License.
- */
-package com.google.gwt.junit.client;
-
-import com.google.gwt.core.ext.UnableToCompleteException;
-import com.google.gwt.dev.cfg.ModuleDef;
-import com.google.gwt.junit.DoNotRunWith;
-import com.google.gwt.junit.JUnitBridge;
-import com.google.gwt.junit.Platform;
-import com.google.gwt.junit.JUnitShell.Strategy;
-import com.google.gwt.junit.client.impl.JUnitResult;
-
-import junit.framework.TestCase;
-
-/**
- * Tests that we can run a test in dev mode even when the selection script  
is
- * from a compile. Note that this is the VM-only version of the class;  
there is

- * a translatable version for the client side.
- */
-...@donotrunwith(Platform.Prod)
-public class DevModeOnCompiledScriptTest extends GWTTestCase {
-
-  @Override
-  public String getModuleName() {
-return "com.google.gwt.junit.DevModeOnCompiledScriptTest";
-  }
-
-  /**
-   * GWT-unfriendly, forcing us to use a translatable class.
-   */
-  @Override
-  public Strategy getStrategy() {
-final Strategy impl = super.getStrategy();
-return new Strategy() {
-  public String getModuleInherit() {
-return impl.getModuleInherit();
-  }
-
-   

[gwt-contrib] Updating Mobile expenses app now that prices are stored in dollars instead of cents. (issue514801)

[jlabanca]

Reviewers: jgw,

Description:
Updating Mobile expenses app now that prices are stored in dollars
instead of cents.


Please review this at http://gwt-code-reviews.appspot.com/514801/show

Affected files:
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobile.java
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseDetails.java
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseEntry.java
  M  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java



Index:  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobile.java

===
---  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobile.java	 
(revision 8094)
+++  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobile.java	 
(working copy)

@@ -28,10 +28,13 @@

   /**
* TODO(jgw): Put this some place more sensible.
+   *
+   * @param amount the amount in dollars
*/
-  public static String formatCurrency(int price) {
+  public static String formatCurrency(double amount) {
 StringBuilder sb = new StringBuilder();

+int price = (int) (amount * 100);
 boolean negative = price < 0;
 if (negative) {
   price = -price;
Index:  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseDetails.java

===
---  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseDetails.java	 
(revision 8094)
+++  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseDetails.java	 
(working copy)

@@ -119,6 +119,6 @@
 nameText.setInnerText(expense.getDescription());
 dateText.setInnerText(formatter.format(expense.getCreated()));
 categoryText.setInnerText(expense.getCategory());
- 
priceText.setInnerText(ExpensesMobile.formatCurrency(expense.getAmount().intValue()));
+ 
priceText.setInnerText(ExpensesMobile.formatCurrency(expense.getAmount()));

   }
 }
Index:  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseEntry.java

===
---  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseEntry.java	 
(revision 8094)
+++  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseEntry.java	 
(working copy)

@@ -105,7 +105,7 @@
 // TODO(jgw): validate amount (in dollars -- database is in pennies)
 String amountText = priceText.getText();
 double amount = Double.parseDouble(amountText);
-deltas.set(ExpenseRecord.amount, expense, amount * 100);
+deltas.set(ExpenseRecord.amount, expense, amount);

 // TODO(jgw): Use non-deprecated date methods for this.
 Date date = new Date(
@@ -145,7 +145,7 @@
   private void displayExpense() {
 nameText.setText(expense.getDescription());
 categoryText.setText(expense.getCategory());
- 
priceText.setText(ExpensesMobile.formatCurrency(expense.getAmount().intValue()));

+priceText.setText(ExpensesMobile.formatCurrency(expense.getAmount()));

 // TODO(jgw): Use non-deprecated date methods for this.
 Date d = expense.getCreated();
Index:  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java

===
---  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java	 
(revision 8094)
+++  
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java	 
(working copy)

@@ -44,6 +44,7 @@
*/
   public interface Listener {
 void onExpenseSelected(ExpenseRecord expense);
+
 void onCreateExpense(String reportId);
   }

@@ -65,8 +66,8 @@
   @Override
   public void render(ExpenseRecord value, Object viewData,
   StringBuilder sb) {
-sb.append("" +  
value.getDescription() + " ($" +

-ExpensesMobile.formatCurrency(value.getAmount().intValue())
+sb.append("" +  
value.getDescription()

++ " ($" + ExpensesMobile.formatCurrency(value.getAmount())
 + ")");
   }
 });


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adds remote_api support for the datastore bulk uploader to web.xml (issue513801)

[zundel]

Reviewers: rice_google.dom, rjrjr_google.dom, amitmanjhi,

Description:
Adds remote_api support for the datastore bulk uploader to web.xml
Note that this change also requires that you add appengine-tools-api.jar
to
get the servlet class.


Please review this at http://gwt-code-reviews.appspot.com/513801/show

Affected files:
  M /bikeshed/eclipse.README
  M /bikeshed/war/WEB-INF/web.xml


Index: /bikeshed/eclipse.README
===
--- /bikeshed/eclipse.README(revision 8094)
+++ /bikeshed/eclipse.README(working copy)
@@ -37,5 +37,6 @@
   * Java Build Path > Libraries > Add Variable > GWT_TOOLS, Extend >  
lib/apache/commons/commons-httpclient-3.1.jar

 * Copy tools/redist/json/r2_20080312/json.jar to bikeshed/war/WEB_INF/lib
 * Copy all jars from  bikeshed/war/temp-lib to bikeshed/war/WEB-INF/lib
+* Copy appengine-tools-api.jar from your appengine sdk to  
bikeshed/war/WEB-INF/lib
 * Right click on the bikeshed project and choose Run as > Web Application.  
Choose from the various .html files


Index: /bikeshed/war/WEB-INF/web.xml
===
--- /bikeshed/war/WEB-INF/web.xml   (revision 8094)
+++ /bikeshed/war/WEB-INF/web.xml   (working copy)
@@ -89,6 +89,26 @@
   
   -->

+  
+  
+  
+remoteapi
+ 
com.google.apphosting.utils.remoteapi.RemoteApiServlet

+  
+  
+remoteapi
+/remote_api
+  
+  
+
+  remoteapi
+  /remote_api
+
+
+  admin
+
+  
+
   
 

[gwt-contrib] [google-web-toolkit] r8106 committed - Configure the logging level to not show the warning by default....

[codesite-noreply]

Revision: 8106
Author: amitman...@google.com
Date: Wed May 12 05:43:10 2010
Log: Configure the logging level to not show the warning by default.

Patch by: amitmanjhi
Review by: rjrjr (tbr)

Review at http://gwt-code-reviews.appspot.com/495803

http://code.google.com/p/google-web-toolkit/source/detail?r=8106

Modified:
 /branches/2.1/bikeshed/scripts/dataPopulator

===
--- /branches/2.1/bikeshed/scripts/dataPopulatorTue May 11 20:06:57 2010
+++ /branches/2.1/bikeshed/scripts/dataPopulatorWed May 12 05:43:10 2010
@@ -27,4 +27,6 @@

NEW_CLASSPATH=$MAVEN_REPO/com/google/gwt/gwt-${i}/2.0.999/gwt-${i}-2.0.999.jar:$NEW_CLASSPATH

 done

-java -cp $NEW_CLASSPATH  
com.google.gwt.requestfactory.server.SampleDataPopulator "$@"
+java  
-Dorg.apache.commons.logging.Log=org.apache.commons.logging.impl.SimpleLog\

+ -Dorg.apache.commons.logging.simplelog.defaultlog=ERROR\
+ -cp $NEW_CLASSPATH  
com.google.gwt.requestfactory.server.SampleDataPopulator "$@"


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Configure the logging level to not show the warning by default. (issue495803)

[amitmanjhi]

Reviewers: Ray Ryan,

Description:
Configure the logging level to not show the warning by default.

Patch by: amitmanjhi
Review by: rjrjr (tbr)


Please review this at http://gwt-code-reviews.appspot.com/495803/show

Affected files:
  M trunk/bikeshed/scripts/dataPopulator


Index: trunk/bikeshed/scripts/dataPopulator
===
--- trunk/bikeshed/scripts/dataPopulator(revision 8094)
+++ trunk/bikeshed/scripts/dataPopulator(working copy)
@@ -27,4 +27,6 @@

NEW_CLASSPATH=$MAVEN_REPO/com/google/gwt/gwt-${i}/2.0.999/gwt-${i}-2.0.999.jar:$NEW_CLASSPATH

 done

-java -cp $NEW_CLASSPATH  
com.google.gwt.requestfactory.server.SampleDataPopulator "$@"
+java  
-Dorg.apache.commons.logging.Log=org.apache.commons.logging.impl.SimpleLog\

+ -Dorg.apache.commons.logging.simplelog.defaultlog=ERROR\
+ -cp $NEW_CLASSPATH  
com.google.gwt.requestfactory.server.SampleDataPopulator "$@"



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8105 committed - The generated data was missing an Expense -> Report link. Fixed it. Up...

[codesite-noreply]

Revision: 8105
Author: amitman...@google.com
Date: Wed May 12 04:54:10 2010
Log: The generated data was missing an Expense -> Report link. Fixed it.  
Updated the sample Json data.


Patch by: amitmanjhi
Review by: jgw (tbr)

Review at http://gwt-code-reviews.appspot.com/512801

http://code.google.com/p/google-web-toolkit/source/detail?r=8105

Modified:
 /branches/2.1/bikeshed/scripts/expensesJsonData.txt
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/server/DataGenerator.java


===
--- /branches/2.1/bikeshed/scripts/expensesJsonData.txt	Tue May 11 17:08:18  
2010
+++ /branches/2.1/bikeshed/scripts/expensesJsonData.txt	Wed May 12 04:54:10  
2010

@@ -1,5273 +1,6706 @@
 {"CREATE": [
 {"EmployeeRecord": {
 "id": "1",
-"department": "Marketing",
-"userName": "jawesome",
-"displayName": "John Awesome"
+"department": "Engineering",
+"userName": "iignoranomous",
+"displayName": "Ingrid Ignoranomous"
 }},
 {"ReportRecord": {
 "id": "2",
-"created": 1270158940643,
+"created": 1270457783871,
 "reporterKey": 1,
-"department": "Marketing",
-"purpose": "Spending lots of money",
-"notes": "High priority"
+"department": "Engineering",
+"purpose": "Team building diamond cutting offsite",
+"notes": "Please bill to the Widgets project"
 }},
 {"ExpenseRecord": {
-"amount": 27.51,
+"amount": 108.57,
 "id": "3",
-"category": "Local Transportation",
-"created": 1267741470646,
-"description": "Bus ticket"
+"category": "Air Travel",
+"created": 1272650531874,
+"description": "Flight from ATL to SFO",
+"reportId": 2
 }},
 {"ExpenseRecord": {
-"amount": 224.5,
+"amount": 214.99,
 "id": "4",
 "category": "Dining",
-"created": 1268194980646,
-"description": "Lunch"
+"created": 1268025438874,
+"description": "Breakfast",
+"reportId": 2
 }},
 {"ExpenseRecord": {
-"amount": 0.97,
+"amount": 218.19,
 "id": "5",
 "category": "Local Transportation",
-"created": 1271959835646,
-"description": "Train fare"
+"created": 1271760323874,
+"description": "Taxi fare",
+"reportId": 2
 }},
 {"ReportRecord": {
 "id": "6",
-"created": 1270606338646,
+"created": 1266376476874,
 "reporterKey": 1,
-"department": "Marketing",
-"purpose": "Visit to Istanbul",
-"notes": "Need approval by Monday"
+"department": "Engineering",
+"purpose": "ISDN modem for telecommuting",
+"notes": ""
 }},
 {"ExpenseRecord": {
-"amount": 31.65,
+"amount": 74.65,
 "id": "7",
-"category": "Dining",
-"created": 1267447426646,
-"description": "Dinner"
+"category": "Office Supplies",
+"created": 1273398834874,
+"description": "Paperclips",
+"reportId": 6
 }},
 {"ExpenseRecord": {
-"amount": 59.01,
+"amount": 106.89,
 "id": "8",
 "category": "Local Transportation",
-"created": 1272708151646,
-"description": "Bus ticket"
+"created": 1273057148874,
+"description": "Bus ticket",
+"reportId": 6
 }},
-{"ReportRecord": {
+{"ExpenseRecord": {
+"amount": 207.62,
 "id": "9",
-"created": 1273335119646,
-"reporterKey": 1,
-"department": "Marketing",
-"purpose": "Spending lots of money",
-"notes": ""
+"category": "Air Travel",
+"created": 1273405596874,
+"description": "Flight from SFO to ATL",
+"reportId": 6
 }},
 {"ExpenseRecord": {
-"amount": 74.41,
+"amount": 39.16,
 "id": "10",
 "category": "Lodging",
-"created": 1267889638646,
-"description": "Bed & Breakfast"
+"created": 1266005294874,
+"description": "Hotel",
+"reportId": 6
 }},
-{"ReportRecord": {
+{"ExpenseRecord": {
+"amount": 61.91,
 "id": "11",
-"created": 1271034778646,
-"reporterKey": 1,
-"department": "Marketing",
-"purpose": "Sushi offsite",
-"notes": "Show me the money"
+"category": "Dining",
+"created": 1270242578874,
+"description": "Lunch",
+"reportId": 6
 }},
-{"ExpenseRecord": {
-"amount": 157.66,
+{"ReportRecord": {
 "id": "12",
-"category": "Lodging",
-"created": 1270713890646,
-"description": "Bed & Breakfast"
+"created": 1267040869874,
+"reporterKey": 1,
+"department": "Engineering",
+"purpose": "Spending lots of money",
+"notes": "High priority"
 }},
 {"Ex

[gwt-contrib] Re: The generated data was missing an Expense -> Report link. Fixed it. Updated the sample Json data. (issue512801)

[jgw]

On 2010/05/12 14:53:32, amitmanjhi wrote:


LGTM.

http://gwt-code-reviews.appspot.com/512801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] The generated data was missing an Expense -> Report link. Fixed it. Updated the sample Json data. (issue512801)

[amitmanjhi]

Reviewers: jgw,

Description:
The generated data was missing an Expense -> Report link. Fixed it.
Updated the sample Json data.

Patch by: amitmanjhi
Review by: jgw (tbr)


Please review this at http://gwt-code-reviews.appspot.com/512801/show

Affected files:
  M trunk/bikeshed/scripts/expensesJsonData.txt
  M  
trunk/bikeshed/src/com/google/gwt/sample/expenses/server/DataGenerator.java



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8104 committed - Fix GAE deploy after gwtRequest change

[codesite-noreply]

Revision: 8104
Author: rj...@google.com
Date: Tue May 11 21:32:44 2010
Log: Fix GAE deploy after gwtRequest change

http://code.google.com/p/google-web-toolkit/source/detail?r=8104

Modified:
 /branches/2.1/bikeshed/war/WEB-INF/appengine-web.xml
 /branches/2.1/bikeshed/war/WEB-INF/web.xml

===
--- /branches/2.1/bikeshed/war/WEB-INF/appengine-web.xml	Mon May 10  
15:03:36 2010
+++ /branches/2.1/bikeshed/war/WEB-INF/appengine-web.xml	Tue May 11  
21:32:44 2010

@@ -1,7 +1,7 @@
 
 http://appengine.google.com/ns/1.0";>
gwt-bikeshed
-   5
+   11



===
--- /branches/2.1/bikeshed/war/WEB-INF/web.xml  Tue May 11 18:52:23 2010
+++ /branches/2.1/bikeshed/war/WEB-INF/web.xml  Tue May 11 21:32:44 2010
@@ -34,7 +34,7 @@

   
 requestFactoryServlet
-gwtRequest
+/gwtRequest
   

   

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8103 committed - Fix some missing dependencies so web mode compile will work

[codesite-noreply]

Revision: 8103
Author: rj...@google.com
Date: Tue May 11 20:56:53 2010
Log: Fix some missing dependencies so web mode compile will work

http://code.google.com/p/google-web-toolkit/source/detail?r=8103

Added:
 /branches/2.1/bikeshed/src/com/google/gwt/user/User.gwt.xml
Modified:
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/bikeshed/cookbook/Cookbook.gwt.xml
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/bikeshed/stocks/StocksDesktop.gwt.xml
  
/branches/2.1/bikeshed/src/com/google/gwt/sample/bikeshed/stocks/StocksMobile.gwt.xml


===
--- /dev/null
+++ /branches/2.1/bikeshed/src/com/google/gwt/user/User.gwt.xml	Tue May 11  
20:56:53 2010

@@ -0,0 +1,55 @@
+
+
+
+
+

+
+   

+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+
+   
+   
+
===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/bikeshed/cookbook/Cookbook.gwt.xml	 
Thu Apr 22 06:58:10 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/bikeshed/cookbook/Cookbook.gwt.xml	 
Tue May 11 20:56:53 2010

@@ -1,4 +1,5 @@
 
+  
   
   
   
===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/bikeshed/stocks/StocksDesktop.gwt.xml	 
Fri Mar 26 06:15:07 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/bikeshed/stocks/StocksDesktop.gwt.xml	 
Tue May 11 20:56:53 2010

@@ -1,6 +1,7 @@
 
 0.0.999//EN" "http://google-web-toolkit.googlecode.com/svn/tags/0.0.999/distro-source/core/src/gwt-module.dtd";>

 
+  
   
   class='com.google.gwt.sample.bikeshed.stocks.client.StocksDesktop'/>

 
===
---  
/branches/2.1/bikeshed/src/com/google/gwt/sample/bikeshed/stocks/StocksMobile.gwt.xml	 
Fri Mar 26 06:15:07 2010
+++  
/branches/2.1/bikeshed/src/com/google/gwt/sample/bikeshed/stocks/StocksMobile.gwt.xml	 
Tue May 11 20:56:53 2010

@@ -1,6 +1,7 @@
 
 0.0.999//EN" "http://google-web-toolkit.googlecode.com/svn/tags/0.0.999/distro-source/core/src/gwt-module.dtd";>

 
+  
   
   class='com.google.gwt.sample.bikeshed.stocks.client.StocksMobile'/>

 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors