[gwt-contrib] [google-web-toolkit] r9221 committed - Edited wiki page AutoBean through web user interface.

[codesite-noreply]

Revision: 9221
Author: b...@google.com
Date: Fri Nov 12 20:08:46 2010
Log: Edited wiki page AutoBean through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9221

Modified:
 /wiki/AutoBean.wiki

===
--- /wiki/AutoBean.wiki Fri Nov  5 09:42:49 2010
+++ /wiki/AutoBean.wiki Fri Nov 12 20:08:46 2010
@@ -189,6 +189,8 @@

 == JSON structures ==

+The AutoBean framework can be used as a JSON interoperability layer to  
provide a Java typesystem wrapper around an existing JSON api or to create  
JSON payloads to interact with a remote service.  This is accomplished by  
designing the Java APIs according to the JSON schema.  The `...@propertyname`  
annotation can be applied to  getters and setters where the Java naming  
convention does not align with the JSON schema.

+
 Generally speaking, the serialized form of an object emitted by  
AutoBeanCodex mirrors the interface declaration.  For instance, the example  
Person interface described in the quckstart section of this document might  
be serialized as:


 {{{
@@ -212,6 +214,8 @@
 {{{
 [ [ { "name" : "John Doe" } , { "name" : "Jim Smith" } ] , [  
{ "street" : "1234 Maple Ave" }, { "street" : "5678 Fair Oaks Lane" } ] ]

 }}}
+
+Java enum values are written out as the string name of the enum value.   
This can be overridden by applying the `PropertyName` annotation to the  
enum field declaration.  The use of names instead of ordinal values will  
allow the payloads to be robust against endpoint schema skew.


 == Categories ==

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9220 committed - Switching CellList to trigger selection on click instead of mousedown....

[codesite-noreply]

Revision: 9220
Author: jlaba...@google.com
Date: Fri Nov 12 11:57:52 2010
Log: Switching CellList to trigger selection on click instead of mousedown.  
Selection causes the cell to be redrawn, which interrupts the click event  
sequence and prevents click from ever firing to the Cell. This is  
particularly annoying for Cells that contain Buttons. The same change needs  
to be made for keyboard selection, which can be bound to selection and  
cause the cell to be redrawn.  CellTable already triggers selection on  
click, and now triggers keyboard selection on click.


Review at http://gwt-code-reviews.appspot.com/1102801

Review by: sbruba...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9220

Modified:
 /trunk/user/src/com/google/gwt/user/cellview/client/AbstractHasData.java
 /trunk/user/src/com/google/gwt/user/cellview/client/CellList.java
 /trunk/user/src/com/google/gwt/user/cellview/client/CellTable.java

===
---  
/trunk/user/src/com/google/gwt/user/cellview/client/AbstractHasData.java	 
Tue Nov  9 07:53:09 2010
+++  
/trunk/user/src/com/google/gwt/user/cellview/client/AbstractHasData.java	 
Fri Nov 12 11:57:52 2010

@@ -270,8 +270,9 @@
 Set eventTypes = new HashSet();
 eventTypes.add("focus");
 eventTypes.add("blur");
-eventTypes.add("keydown");
-eventTypes.add("mousedown"); // Used by subclasses to steal focus.
+eventTypes.add("keydown"); // Used for keyboard navigation.
+eventTypes.add("click"); // Used by subclasses for selection.
+eventTypes.add("mousedown"); // No longer used, but here for legacy  
support.

 CellBasedWidgetImpl.get().sinkEvents(this, eventTypes);
   }

===
--- /trunk/user/src/com/google/gwt/user/cellview/client/CellList.java	Tue  
Nov  9 07:53:09 2010
+++ /trunk/user/src/com/google/gwt/user/cellview/client/CellList.java	Fri  
Nov 12 11:57:52 2010

@@ -379,7 +379,7 @@
   // before firing the event to the cell in case the cell operates on  
the

   // currently selected item.
   String eventType = event.getType();
-  boolean isMouseDown = "mousedown".equals(eventType);
+  boolean isClick = "click".equals(eventType);
   int idx = Integer.parseInt(idxString);
   int indexOnPage = idx - getPageStart();
   if (!isRowWithinBounds(indexOnPage)) {
@@ -390,12 +390,12 @@
   // Get the cell parent before doing selection in case the list is  
redrawn.

   Element cellParent = getCellParent(cellTarget);
   T value = getDisplayedItem(indexOnPage);
-  if (isMouseDown && !cell.handlesSelection()) {
+  if (isClick && !cell.handlesSelection()) {
 doSelection(event, value, indexOnPage);
   }

   // Focus on the cell.
-  if (isMouseDown
+  if (isClick
   && getPresenter().getKeyboardSelectedRowInView() != indexOnPage)  
{

 /*
  * If the selected element is natively focusable, then we do not  
want to

===
--- /trunk/user/src/com/google/gwt/user/cellview/client/CellTable.java	Tue  
Nov  9 07:53:09 2010
+++ /trunk/user/src/com/google/gwt/user/cellview/client/CellTable.java	Fri  
Nov 12 11:57:52 2010

@@ -563,7 +563,6 @@

 // Sink events.
 Set eventTypes = new HashSet();
-eventTypes.add("click");
 eventTypes.add("mouseover");
 eventTypes.add("mouseout");
 CellBasedWidgetImpl.get().sinkEvents(this, eventTypes);
@@ -926,7 +925,7 @@
   }
 } else if (section == tbody) {
   // Update the hover state.
-  boolean isMouseDown = "mousedown".equals(eventType);
+  boolean isClick = "click".equals(eventType);
   int row = tr.getSectionRowIndex();
   if ("mouseover".equals(eventType)) {
 // Unstyle the old row if it is still part of the table.
@@ -941,7 +940,7 @@
 setRowStyleName(hoveringRow, style.cellTableHoveredRow(),
 style.cellTableHoveredRowCell(), false);
 hoveringRow = null;
-  } else if (isMouseDown
+  } else if (isClick
   && ((getPresenter().getKeyboardSelectedRowInView() != row)
   || (keyboardSelectedColumn != col))) {
 // Move keyboard focus. Since the user clicked, allow focus to go  
to a

@@ -960,7 +959,7 @@
 return;
   }
   T value = getDisplayedItem(row);
-  if ("click".equals(eventType) && !handlesSelection) {
+  if (isClick && !handlesSelection) {
 doSelection(event, value, row, col);
   }

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a permissions model to the Chrome NPAPI plugin. (issue1084801)

[fabiomfv]

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020
File plugins/npapi/VisualStudio/npapi-plugin.vcproj (left):

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode1
plugins/npapi/VisualStudio/npapi-plugin.vcproj:1: 
On 2010/11/12 21:53:42, conroy wrote:

On 2010/11/12 20:50:38, fabiomfv wrote:
> not sure how you are building this project. I could not find any

targets in

> build.xml or any other reference to devenv.exe
>
> you may also want to double check that the bin is release flavor as

the

default
> is debug when you invoke vs build.



huh? the build.xml is brand new and is just for building the

DevModeOptions GWT

module.


I meant to ask how we build the plugin for windows. what invokes the
project (msbuild, devenv, ant) to build. I just wanted to make sure we
can build this solution successfully with these changes.

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode4
plugins/npapi/VisualStudio/npapi-plugin.vcproj:4: Version="8.00"
On 2010/11/12 21:53:42, conroy wrote:

On 2010/11/12 20:50:38, fabiomfv wrote:
> not sure what the intent was, but if you put back allowdialog.h you

will need

to
> add allowdialog.cpp in the project as well.



the intent is to nuke it so we have a common, platform independent UI.


my comment is that the vcproj as-is is broken and will not build.

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode9
plugins/npapi/VisualStudio/npapi-plugin.vcproj:9: >
On 2010/11/12 21:53:42, conroy wrote:

On 2010/11/12 20:50:38, fabiomfv wrote:
> I made most of these fixes on my box and it is building fine. if you

will I

can
> roll them in your CL, bar knowing how you want to invoke the vs

build.


my only changes here are just to nuke the allowdialog/preferences

stuff.

hopefully these changes didn't break the build. are you saying the

build was

already borked before this CL?



i think the mechanism for building before was just invoking the build

in VS, no?


in either case, send me a patch and I'll update accordingly.



I just wanted to brought up that allowdialog.h was deleted in the CL and
main.cpp still references it int the windows build. this will break the
build for windows.

http://gwt-code-reviews.appspot.com/1084801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a permissions model to the Chrome NPAPI plugin. (issue1084801)

[conroy]

http://gwt-code-reviews.appspot.com/1084801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a permissions model to the Chrome NPAPI plugin. (issue1084801)

[conroy]

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020
File plugins/npapi/VisualStudio/npapi-plugin.vcproj (left):

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode1
plugins/npapi/VisualStudio/npapi-plugin.vcproj:1: 
On 2010/11/12 20:50:38, fabiomfv wrote:

not sure how you are building this project. I could not find any

targets in

build.xml or any other reference to devenv.exe



you may also want to double check that the bin is release flavor as

the default

is debug when you invoke vs build.


huh? the build.xml is brand new and is just for building the
DevModeOptions GWT module.

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode4
plugins/npapi/VisualStudio/npapi-plugin.vcproj:4: Version="8.00"
On 2010/11/12 20:50:38, fabiomfv wrote:

not sure what the intent was, but if you put back allowdialog.h you

will need to

add allowdialog.cpp in the project as well.


the intent is to nuke it so we have a common, platform independent UI.

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode9
plugins/npapi/VisualStudio/npapi-plugin.vcproj:9: >
On 2010/11/12 20:50:38, fabiomfv wrote:

I made most of these fixes on my box and it is building fine. if you

will I can

roll them in your CL, bar knowing how you want to invoke the vs build.


my only changes here are just to nuke the allowdialog/preferences stuff.
hopefully these changes didn't break the build. are you saying the build
was already borked before this CL?

i think the mechanism for building before was just invoking the build in
VS, no?

in either case, send me a patch and I'll update accordingly.

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29028
File plugins/platform/Win/AllowDialog.h (left):

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29028#oldcode1
plugins/platform/Win/AllowDialog.h:1: #ifndef _H_AllowDialog
On 2010/11/12 20:50:38, fabiomfv wrote:

looks like allowdialog.h is still referenced in main.cpp.


fixed.

http://gwt-code-reviews.appspot.com/1084801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a new CommonResources class that provides access to commonly used styles in GWT. For now,... (issue1106801)

[sbrubaker]

LGTM

http://gwt-code-reviews.appspot.com/1106801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds overflow-x and overflow-y to Style since they have at least partial (issue1100801)

[jgw]

On 2010/11/11 23:22:56, knorton wrote:


LGTM

http://gwt-code-reviews.appspot.com/1100801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adding a new CommonResources class that provides access to commonly used styles in GWT. For now,... (issue1106801)

[jlabanca]

Reviewers: sbrubaker,

Description:
Adding a new CommonResources class that provides access to commonly used
styles in GWT. For now, the only style defined is a cross browser
implementation of inline block, but we can expand to include more common
styles later.


Please review this at http://gwt-code-reviews.appspot.com/1106801/show

Affected files:
  A user/src/com/google/gwt/resources/client/CommonResources.java
  A user/src/com/google/gwt/resources/client/inline-block.css


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a permissions model to the Chrome NPAPI plugin. (issue1084801)

[fabiomfv]

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020
File plugins/npapi/VisualStudio/npapi-plugin.vcproj (left):

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode1
plugins/npapi/VisualStudio/npapi-plugin.vcproj:1: 
not sure how you are building this project. I could not find any targets
in build.xml or any other reference to devenv.exe

you may also want to double check that the bin is release flavor as the
default is debug when you invoke vs build.

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode4
plugins/npapi/VisualStudio/npapi-plugin.vcproj:4: Version="8.00"
not sure what the intent was, but if you put back allowdialog.h you will
need to add allowdialog.cpp in the project as well.

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode7
plugins/npapi/VisualStudio/npapi-plugin.vcproj:7:
RootNamespace="npapi-plugin"
Also, maybe it will be in the next step, but It seems that the out bin
is not checked out for replacement. I am guessing it will done a later
step.

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode9
plugins/npapi/VisualStudio/npapi-plugin.vcproj:9: >
I made most of these fixes on my box and it is building fine. if you
will I can roll them in your CL, bar knowing how you want to invoke the
vs build.

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29028
File plugins/platform/Win/AllowDialog.h (left):

http://gwt-code-reviews.appspot.com/1084801/diff/28001/29028#oldcode1
plugins/platform/Win/AllowDialog.h:1: #ifndef _H_AllowDialog
looks like allowdialog.h is still referenced in main.cpp.

http://gwt-code-reviews.appspot.com/1084801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a new widget CellWidget that can wrap any Cell and turn it into a Widget. CellWidget can... (issue1103801)

[sbrubaker]

LGTM, just one nit.


http://gwt-code-reviews.appspot.com/1103801/diff/1/2
File user/src/com/google/gwt/user/cellview/client/CellWidget.java
(right):

http://gwt-code-reviews.appspot.com/1103801/diff/1/2#newcode54
user/src/com/google/gwt/user/cellview/client/CellWidget.java:54: * The
cell being wrapper.
wrapper -> wrapped

http://gwt-code-reviews.appspot.com/1103801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Enum Ordinalization Optimization (revisited) (issue1104801)

[jbrosenberg]

Reviewers: cromwellian,

Description:
Enum Ordinalization Optimization (revisited)


Please review this at http://gwt-code-reviews.appspot.com/1104801/show

Affected files:
  M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
  M dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
  A dev/core/src/com/google/gwt/dev/jjs/impl/AstDumper.java
  A dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java
  A dev/core/src/com/google/gwt/dev/jjs/impl/ImplicitUpcastAnalyzer.java
  A dev/core/src/com/google/gwt/dev/jjs/impl/TypeRemapper.java
  M dev/core/test/com/google/gwt/dev/jjs/JavaAstConstructor.java
  A dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java
  M dev/core/test/com/google/gwt/dev/jjs/impl/OptimizerTestBase.java
  M user/test/com/google/gwt/user/client/rpc/EnumsTest.java
  M user/test/com/google/gwt/user/client/rpc/EnumsTestService.java
  M user/test/com/google/gwt/user/client/rpc/EnumsTestServiceAsync.java
  M user/test/com/google/gwt/user/server/rpc/EnumsTestServiceImpl.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adding a new widget CellWidget that can wrap any Cell and turn it into a Widget. CellWidget can... (issue1103801)

[jlabanca]

Reviewers: sbrubaker,

Description:
Adding a new widget CellWidget that can wrap any Cell and turn it into a
Widget.  CellWidget can be used on its own (it isn't abstract) to wrap a
widget.  It can also be used inside a Composite to create a formal
version of an existing Cell, such as creating EditText from
EditTextCell. This feature will not be included in GWT 2.1.1.


Please review this at http://gwt-code-reviews.appspot.com/1103801/show

Affected files:
  A user/src/com/google/gwt/user/cellview/client/CellWidget.java
  M user/test/com/google/gwt/user/cellview/CellViewSuite.java
  A user/test/com/google/gwt/user/cellview/client/CellWidgetTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Internal compiler error with GWT 2.1.0 RC1 when using generics

[yves]

I've found a similar old problem : look at
http://code.google.com/p/google-web-toolkit/issues/detail?id=2279
Yves

On 12 nov, 19:52, yves  wrote:
> @All
>
> I replaced the array T[] by a List and I still get the same OOME.
>
> Summary :
> 1) when you break the self-referenced generics ResultNode ResultNode> by
> public class ResultNode implements IResultNode
> and
> public interface IResultNode extends Result
>
> => this still produces the error
>
> 2) when you replace the array T[] by a List
> => still the same error
>
> Thus my conclusion : the only way to avoid this error is to avoid the
> usage of generics in a Serializable type (used in a RPC call)
>
> HTH
> Yves
>
> On 12 nov, 16:21, Miguel Méndez  wrote:
>
> > [+zhuyi]
>
> > On Fri, Nov 12, 2010 at 9:52 AM, Miguel Méndez  wrote:
> > > On Fri, Nov 12, 2010 at 5:34 AM, yves  wrote:
>
> > >> @Jeff
> > >> As you suggested me, I tried the followig without success (same OOME
> > >> problem):
>
> > >> public class ResultNode implements IResultNode
> > >> and
> > >> public interface IResultNode extends Result
>
> > >> Again this is syntaxically correct and compiles sucessfully with
> > >> javac, BUT gives again the OOME problem with the GWT compiler.
>
> > >> So apprently the problem is NOT due to the self-referenced generics
> > >> ResulNode>
>
> > >> @Miguel
> > >> As youl suggests in your link, is the problem the serialization of an
> > >> array of type T : T[] next; ?
>
> > >> As a workarround, I'll try to replace this array T[] by an
> > >> ArrayList which serializes without know issue.
> > >> Yves
>
> > > I do suspect that T[] is the issue. �...@zhuyi: can you take a look at
> > >http://code.google.com/p/google-web-toolkit/issues/detail?id=5582andlet
> > > me know what you think.
>
> > > --
> > > Miguel
>
> > --
> > Miguel

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Internal compiler error with GWT 2.1.0 RC1 when using generics

[yves]

@All

I replaced the array T[] by a List and I still get the same OOME.

Summary :
1) when you break the self-referenced generics ResultNode> by
public class ResultNode implements IResultNode
and
public interface IResultNode extends Result

=> this still produces the error

2) when you replace the array T[] by a List
=> still the same error

Thus my conclusion : the only way to avoid this error is to avoid the
usage of generics in a Serializable type (used in a RPC call)

HTH
Yves




On 12 nov, 16:21, Miguel Méndez  wrote:
> [+zhuyi]
>
>
>
> On Fri, Nov 12, 2010 at 9:52 AM, Miguel Méndez  wrote:
> > On Fri, Nov 12, 2010 at 5:34 AM, yves  wrote:
>
> >> @Jeff
> >> As you suggested me, I tried the followig without success (same OOME
> >> problem):
>
> >> public class ResultNode implements IResultNode
> >> and
> >> public interface IResultNode extends Result
>
> >> Again this is syntaxically correct and compiles sucessfully with
> >> javac, BUT gives again the OOME problem with the GWT compiler.
>
> >> So apprently the problem is NOT due to the self-referenced generics
> >> ResulNode>
>
> >> @Miguel
> >> As youl suggests in your link, is the problem the serialization of an
> >> array of type T : T[] next; ?
>
> >> As a workarround, I'll try to replace this array T[] by an
> >> ArrayList which serializes without know issue.
> >> Yves
>
> > I do suspect that T[] is the issue. �...@zhuyi: can you take a look at
> >http://code.google.com/p/google-web-toolkit/issues/detail?id=5582and let
> > me know what you think.
>
> > --
> > Miguel
>
> --
> Miguel

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Switching CellList to trigger selection on click instead of mousedown. Selection causes the cell... (issue1102801)

[sbrubaker]

LGTM

http://gwt-code-reviews.appspot.com/1102801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Switching CellList to trigger selection on click instead of mousedown. Selection causes the cell... (issue1102801)

[jlabanca]

Reviewers: sbrubaker,

Description:
Switching CellList to trigger selection on click instead of mousedown.
Selection causes the cell to be redrawn, which interrupts the click
event sequence and prevents click from ever firing to the Cell. This is
particularly annoying for Cells that contain Buttons. The same change
needs to be made for keyboard selection, which can be bound to selection
and cause the cell to be redrawn.  CellTable already triggers selection
on click, and now triggers keyboard selection on click.


Please review this at http://gwt-code-reviews.appspot.com/1102801/show

Affected files:
  M user/src/com/google/gwt/user/cellview/client/AbstractHasData.java
  M user/src/com/google/gwt/user/cellview/client/CellList.java
  M user/src/com/google/gwt/user/cellview/client/CellTable.java


Index: user/src/com/google/gwt/user/cellview/client/AbstractHasData.java
===
--- user/src/com/google/gwt/user/cellview/client/AbstractHasData.java	 
(revision 9218)
+++ user/src/com/google/gwt/user/cellview/client/AbstractHasData.java	 
(working copy)

@@ -270,8 +270,9 @@
 Set eventTypes = new HashSet();
 eventTypes.add("focus");
 eventTypes.add("blur");
-eventTypes.add("keydown");
-eventTypes.add("mousedown"); // Used by subclasses to steal focus.
+eventTypes.add("keydown"); // Used for keyboard navigation.
+eventTypes.add("click"); // Used by subclasses for selection.
+eventTypes.add("mousedown"); // No longer used, but here for legacy  
support.

 CellBasedWidgetImpl.get().sinkEvents(this, eventTypes);
   }

Index: user/src/com/google/gwt/user/cellview/client/CellList.java
===
--- user/src/com/google/gwt/user/cellview/client/CellList.java	(revision  
9218)
+++ user/src/com/google/gwt/user/cellview/client/CellList.java	(working  
copy)

@@ -379,7 +379,7 @@
   // before firing the event to the cell in case the cell operates on  
the

   // currently selected item.
   String eventType = event.getType();
-  boolean isMouseDown = "mousedown".equals(eventType);
+  boolean isClick = "click".equals(eventType);
   int idx = Integer.parseInt(idxString);
   int indexOnPage = idx - getPageStart();
   if (!isRowWithinBounds(indexOnPage)) {
@@ -390,12 +390,12 @@
   // Get the cell parent before doing selection in case the list is  
redrawn.

   Element cellParent = getCellParent(cellTarget);
   T value = getDisplayedItem(indexOnPage);
-  if (isMouseDown && !cell.handlesSelection()) {
+  if (isClick && !cell.handlesSelection()) {
 doSelection(event, value, indexOnPage);
   }

   // Focus on the cell.
-  if (isMouseDown
+  if (isClick
   && getPresenter().getKeyboardSelectedRowInView() != indexOnPage)  
{

 /*
  * If the selected element is natively focusable, then we do not  
want to

Index: user/src/com/google/gwt/user/cellview/client/CellTable.java
===
--- user/src/com/google/gwt/user/cellview/client/CellTable.java	(revision  
9218)
+++ user/src/com/google/gwt/user/cellview/client/CellTable.java	(working  
copy)

@@ -563,7 +563,6 @@

 // Sink events.
 Set eventTypes = new HashSet();
-eventTypes.add("click");
 eventTypes.add("mouseover");
 eventTypes.add("mouseout");
 CellBasedWidgetImpl.get().sinkEvents(this, eventTypes);
@@ -926,7 +925,7 @@
   }
 } else if (section == tbody) {
   // Update the hover state.
-  boolean isMouseDown = "mousedown".equals(eventType);
+  boolean isClick = "click".equals(eventType);
   int row = tr.getSectionRowIndex();
   if ("mouseover".equals(eventType)) {
 // Unstyle the old row if it is still part of the table.
@@ -941,7 +940,7 @@
 setRowStyleName(hoveringRow, style.cellTableHoveredRow(),
 style.cellTableHoveredRowCell(), false);
 hoveringRow = null;
-  } else if (isMouseDown
+  } else if (isClick
   && ((getPresenter().getKeyboardSelectedRowInView() != row)
   || (keyboardSelectedColumn != col))) {
 // Move keyboard focus. Since the user clicked, allow focus to go  
to a

@@ -960,7 +959,7 @@
 return;
   }
   T value = getDisplayedItem(row);
-  if ("click".equals(eventType) && !handlesSelection) {
+  if (isClick && !handlesSelection) {
 doSelection(event, value, row, col);
   }



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removing references to gecko user agent in favor of gecko1_8. gecko refers to very old versions... (issue1081801)

[jlabanca]

committed as r9216


http://gwt-code-reviews.appspot.com/1081801/diff/1/8
File user/src/com/google/gwt/user/CaptionPanel.gwt.xml (right):

http://gwt-code-reviews.appspot.com/1081801/diff/1/8#newcode26
user/src/com/google/gwt/user/CaptionPanel.gwt.xml:26: 
On 2010/11/08 14:50:43, pdr wrote:

Is the  tag needed here?


Done.

http://gwt-code-reviews.appspot.com/1081801/diff/1/10
File user/src/com/google/gwt/user/Focus.gwt.xml (right):

http://gwt-code-reviews.appspot.com/1081801/diff/1/10#newcode26
user/src/com/google/gwt/user/Focus.gwt.xml:26: 
On 2010/11/08 14:50:43, pdr wrote:

Is the  tag required anymore?


Done.

http://gwt-code-reviews.appspot.com/1081801/diff/1/11
File user/src/com/google/gwt/user/History.gwt.xml (right):

http://gwt-code-reviews.appspot.com/1081801/diff/1/11#newcode27
user/src/com/google/gwt/user/History.gwt.xml:27: 
On 2010/11/08 14:50:43, pdr wrote:

Is the  tag needed here?


Done.

http://gwt-code-reviews.appspot.com/1081801/diff/1/12
File user/src/com/google/gwt/user/Popup.gwt.xml (right):

http://gwt-code-reviews.appspot.com/1081801/diff/1/12#newcode26
user/src/com/google/gwt/user/Popup.gwt.xml:26: 
On 2010/11/08 14:50:43, pdr wrote:

Is the  tag needed here?


Done.

http://gwt-code-reviews.appspot.com/1081801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9218 committed - Add README step to use the Google Web Toolkit SDK in the gwt-user proj...

[codesite-noreply]

Revision: 9218
Author: p...@google.com
Date: Fri Nov 12 04:18:43 2010
Log: Add README step to use the Google Web Toolkit SDK in the gwt-user  
project so that users can run GWT tests.


Also, fixes duplicate step 2 in the README.

Review at http://gwt-code-reviews.appspot.com/966802

http://code.google.com/p/google-web-toolkit/source/detail?r=9218

Modified:
 /trunk/eclipse/README.txt

===
--- /trunk/eclipse/README.txt   Wed Sep  1 04:21:58 2010
+++ /trunk/eclipse/README.txt   Fri Nov 12 04:18:43 2010
@@ -169,7 +169,16 @@
 - DynaTable: uses RPC
   Then press the Finish button.

-2) Dismiss the welcome tab if you are setting up an Eclipse workspace
+2) If you are using the Google Plugin for Eclipse
+  (http://code.google.com/eclipse), enable it for 'gwt-user'
+
+  Right click the 'gwt-user' project and go to properties. Select
+  Google->Web Toolkit, and check the box for 'Use Google Web Toolkit'.
+
+  Then, select Google->Web Application, and uncheck 'This project has a WAR
+  directory'. Then press the "Apply" button.
+
+3) Dismiss the welcome tab if you are setting up an Eclipse workspace
   for the first time.

   You should now have several new projects in your Eclipse workspace.
@@ -183,7 +192,7 @@

   Then refresh each project.

-3) Finally, drop to the command line and build the project
+4) Finally, drop to the command line and build the project
   using 'ant'. You may need to first download ant from the web:

 http://ant.apache.org/
@@ -241,7 +250,7 @@
  Project->Preferences...->Projects Tab->Add...
  Add 'gwt-user' as a project dependency.

-2) Create a new launch configuration
+3) Create a new launch configuration

   Select the project in the tree on the left of the Main Window
   Open the Run... dialog

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Internal compiler error with GWT 2.1.0 RC1 when using generics

[Miguel Méndez]

[+zhuyi]

On Fri, Nov 12, 2010 at 9:52 AM, Miguel Méndez  wrote:

> On Fri, Nov 12, 2010 at 5:34 AM, yves  wrote:
>
>> @Jeff
>> As you suggested me, I tried the followig without success (same OOME
>> problem):
>>
>> public class ResultNode implements IResultNode
>> and
>> public interface IResultNode extends Result
>>
>> Again this is syntaxically correct and compiles sucessfully with
>> javac, BUT gives again the OOME problem with the GWT compiler.
>>
>> So apprently the problem is NOT due to the self-referenced generics
>> ResulNode>
>>
>> @Miguel
>> As youl suggests in your link, is the problem the serialization of an
>> array of type T : T[] next; ?
>>
>> As a workarround, I'll try to replace this array T[] by an
>> ArrayList which serializes without know issue.
>> Yves
>>
>>
> I do suspect that T[] is the issue.  @zhuyi: can you take a look at
> http://code.google.com/p/google-web-toolkit/issues/detail?id=5582 and let
> me know what you think.
>
> --
> Miguel
>



-- 
Miguel

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Internal compiler error with GWT 2.1.0 RC1 when using generics

[Miguel Méndez]

On Fri, Nov 12, 2010 at 5:34 AM, yves  wrote:

> @Jeff
> As you suggested me, I tried the followig without success (same OOME
> problem):
>
> public class ResultNode implements IResultNode
> and
> public interface IResultNode extends Result
>
> Again this is syntaxically correct and compiles sucessfully with
> javac, BUT gives again the OOME problem with the GWT compiler.
>
> So apprently the problem is NOT due to the self-referenced generics
> ResulNode>
>
> @Miguel
> As youl suggests in your link, is the problem the serialization of an
> array of type T : T[] next; ?
>
> As a workarround, I'll try to replace this array T[] by an
> ArrayList which serializes without know issue.
> Yves
>
>
I do suspect that T[] is the issue.  @zhuyi: can you take a look at
http://code.google.com/p/google-web-toolkit/issues/detail?id=5582 and let me
know what you think.

-- 
Miguel

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add README step to use the Google Web Toolkit SDK in the gwt-user project so that users can run ... (issue966802)

[pdr]

http://gwt-code-reviews.appspot.com/966802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] static findEntity method cannot access jndi resources

[BobV]

> If anything I'm putting this out there in the hopes there's a better
> way, or that at least it's considered within the upcoming design of
> RequestFactory in 2.1.1

The code is starting to make its way into trunk.  The request
processing code is now separated from all of the reflection /
domain-manipulation code.  Probably next week, the
ReflectiveServiceLayer will accept some kind of helper object to give
you more control over how domain objects are located and mutated.

-- 
Bob Vawter
Google Web Toolkit Team

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Would GWT and/or incubator be interested in Run Time UiBinding

[TedM]

Hi,

I made a run time UiBinding prototype.  This allows for the creation
of forms or screens without having to recompile.  Let me know if GWT
or the incubator is interested.  If so I will release the code as an
open source project on google source.

Here is the prototype hosted on Google App Engine

http://gwt-binding-fly.appspot.com/

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] static findEntity method cannot access jndi resources

[Cory]

Hi,

The static findEntity methods required by RequestFactory in 2.1.0 seem
to prevent looking up JNDI resources?

I am not using a normal persistence layer in my JEE server side code,
and instead need to access a JNDI resource and marshal my entity
objects without the aid of JPA or JDO.

So I need to do something such as:
  new InitialContext().lookup("jndi/path")
and operate on the resource.

I have seen in the Wiki (http://code.google.com/p/google-web-toolkit/
wiki/RequestFactory_2_1_1) and issue 5111 (http://code.google.com/p/
google-web-toolkit/issues/detail?id=5111) that there are plans to
allow a "ReflectiveServiceLayer", and I'm assuming that will allow
something like the above?
(more preferably allowing use of @Inject or other such CDI goodness?)

If anything I'm putting this out there in the hopes there's a better
way, or that at least it's considered within the upcoming design of
RequestFactory in 2.1.1

Thanks,

 -- Cory

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Internal compiler error with GWT 2.1.0 RC1 when using generics

[yves]

@Jeff
As you suggested me, I tried the followig without success (same OOME
problem):

public class ResultNode implements IResultNode
and
public interface IResultNode extends Result

Again this is syntaxically correct and compiles sucessfully with
javac, BUT gives again the OOME problem with the GWT compiler.

So apprently the problem is NOT due to the self-referenced generics
ResulNode>

@Miguel
As youl suggests in your link, is the problem the serialization of an
array of type T : T[] next; ?

As a workarround, I'll try to replace this array T[] by an
ArrayList which serializes without know issue.
Yves


On 11 nov, 19:30, Miguel Méndez  wrote:
> Thanks.  I was able to reproduce the problem and filed issue
> 5582
> .
>
> @zhuyi: can you take a look at this bug?
>
> On Thu, Nov 11, 2010 at 11:58 AM, yves  wrote:
> > Miguel,
>
> > Here is the ResultNode class
>
> > public class ResultNode> implements Result {
>
> >        private static final long serialVersionUID = -3560238969723137110L;
>
> >        public int dataType;
> >        public int id1;
> >        public int id2;
> >        public int id3;
> >        public int id4;
> >        public int numChildren;
> >        public String data;
> >        public T[] next;
>
> >        public ResultNode() {}
> > }
>
> > and its parent, which is an empty placeholder for Serializable:
>
> > public interface Result extends Serializable {
>
> > }
>
> > This class implements a node in a tree.
> > The goal of the generics is to define the children nodes type (the
> > next[] member).
> > Actually ResultNode is not used by itself, only subtypes are
> > instanciated. Subtypes of ResultNode define only additional int,
> > boolean or float members. Nothing else.
>
> > Even if the goal here is not to justify why I am doing this, this
> > usage of the genrics allows me to remove from the code many unsafe
> > type cast. Now with the generics I am sure of the member type
> > (next[]). Isn't this the goal of generics ? :-)
>
> > Yves
>
> > On 11 nov, 17:34, Miguel Méndez  wrote:
> > > @yves: What does the ResultNode class look like?  It is class
> > ResultNode > > extends ResultNode> but what about its supertype and fields?
>
> > > On Thu, Nov 11, 2010 at 10:50 AM, yves  wrote:
> > > > Chris,
>
> > > > JConsole does not succeed to connect to the java compilation : I get
> > > > an out of memory error in sun.rmi.transport.tcp.TCPTransport
> > > > $AcceptLoop.executeAcceptLoop while trying to start a new thread.
> > > > => Result: no data in jconsole
>
> > > > The compiler is the one shipped with GWT 2.1.0RC1
>
> > > > I'll send you the output of -verbose:gc
> > > > Yves
>
> > > > On 10 nov, 23:26, Chris Conroy  wrote:
> > > > > Yves,
>
> > > > > You say this error did not occur before your most recent change. It
> > > > > would be useful to get an idea for the memory usage before this
> > > > > change: it could be that your app is just very large and you were
> > > > > already on the edge of an OOME, your change really necessitates more
> > > > > memory, or this is a pathological case.
>
> > > > > Here are a few things to try for gathering more useful information:
>
> > > > > -Try attaching jconsole to the compile in the before and after
> > > > > scenario and see how the memory usage compares between both.
>
> > > > > -add -XX:-HeapDumpOnOutOfMemoryError to the JVM args for your failing
> > > > > compile. There may be some interesting data in the resulting dump. If
> > > > > you can share the heap dump with us (you can send me a link off list
> > > > > if you like), then I can take a look.
>
> > > > > -Of course, make sure you are using the latest version of the GWT
> > > > > compiler. The 2.1 compiler contains some changes that will reduce the
> > > > > memory footprint of your compile.
>
> > > > > On Wed, Nov 10, 2010 at 1:20 PM, Scott Blum 
> > wrote:
> > > > > > Hmmm what happens if you turn down the log level, say to
> > "WARN"?
> > > > > > Are you invoking from the command line, or are you using the Google
> > > > Plugin
> > > > > > for Eclipse?
>
> > > > > > On Wed, Nov 10, 2010 at 4:16 PM, yves 
> > wrote:
>
> > > > > >> Scott,
> > > > > >> Thx for the tip. Anyway I can't allocate more than -Xmx1590M and I
> > get
> > > > > >> exactly the same error.
> > > > > >> Yves
>
> > > > > >> On 9 nov, 07:47, Scott Blum  wrote:
> > > > > >> > Hmm can you increase your virtual memory?
>
> > > > > >> > On Mon, Nov 8, 2010 at 5:13 PM, yves 
> > wrote:
> > > > > >> > > I can't, I only have 2GB RAM, I get this error as from
> > -Xmx1024M
> > > > > >> > >     [java] Error occurred during initialization of VM
> > > > > >> > >     [java] Could not reserve enough space for object heap
> > > > > >> > >     [java] Could not create the Java virtual machine.
>
> > > > > >> > > and the log level is INFO
> > > > > >> > > Yves
>
> > > > > >> > > On 8 nov, 22:53, Scott Blum  wrote:
> > > > > >> > > > What if you turn the