Re: [gwt-contrib] Re: gwt rebranding

2013-03-20 Thread Ray Cromwell 
The rebranding is not about "selling" GWT, it's about the fact that it is
no longer solely Google-owned.



On Tue, Mar 19, 2013 at 1:37 PM, vitaly goji  wrote:

> I tried to convince IT manager to use GWT for a project, but he told me
> that GWT has poor widgets library and lacks essential things like
> validation etc..
> Don't think my manager will change his mind because of re-branding.
>
> In a 90's everyone was using Visual Basic. Check out how they got almost
> all market.
> Certainly not by asking developers and manages to gamble with third-party
> libraries.
> They simply provided developers with what they need to build apps 'out of
> the box'.
>
> And if you look at what is missing in GWT in comparison to POPULAR
> frameworks, you will see that it would not be too difficult to catch up.
>
> On Friday, March 15, 2013 2:07:04 AM UTC-7, Daniel Kurka wrote:
>
>> Crosspost from gwt-steering:
>> https://groups.google.com/d/**msg/gwt-steering/q9bSOldSBFU/**ki5nQk39fJ8J
>>
>>
>>
>>
>>
>> GWT should rebrand
>>
>>
>>  --
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "Google Web Toolkit Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

-- 
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Re: gwt rebranding

2013-03-20 Thread James Horsley 
I really like the re-branding idea; it's important to make the clear
distinction, as Jens and Ray pointed out, that GWT's grown beyond being
just a Google owned project. Ideally it'll be in a place where the question
of "what happens if google stops working on GWT?" isn't even something that
potential adopters worry about when making their decision, much like
Eclipse isn't thought of in the context of IBM anymore.

On the note of @Gorgeous Web Toolkit@, my $.02 is nice but isn't quite
"Gorgeous" isn't geeky enough. The self referential thing is an option and
flows nicely when said out loud "Gwit Web Toolkit" but isn't necessarily
very descriptive.


On 20 March 2013 09:35, Ray Cromwell  wrote:

>
> The rebranding is not about "selling" GWT, it's about the fact that it is
> no longer solely Google-owned.
>
>
>
> On Tue, Mar 19, 2013 at 1:37 PM, vitaly goji  wrote:
>
>> I tried to convince IT manager to use GWT for a project, but he told me
>> that GWT has poor widgets library and lacks essential things like
>> validation etc..
>> Don't think my manager will change his mind because of re-branding.
>>
>> In a 90's everyone was using Visual Basic. Check out how they got almost
>> all market.
>> Certainly not by asking developers and manages to gamble with third-party
>> libraries.
>> They simply provided developers with what they need to build apps 'out of
>> the box'.
>>
>> And if you look at what is missing in GWT in comparison to POPULAR
>> frameworks, you will see that it would not be too difficult to catch up.
>>
>> On Friday, March 15, 2013 2:07:04 AM UTC-7, Daniel Kurka wrote:
>>
>>> Crosspost from gwt-steering:
>>> https://groups.google.com/d/**msg/gwt-steering/q9bSOldSBFU/**
>>> ki5nQk39fJ8J
>>>
>>>
>>>
>>>
>>>
>>> GWT should rebrand
>>>
>>>
>>>  --
>> --
>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Google Web Toolkit Contributors" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>>
>
>  --
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "Google Web Toolkit Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

-- 
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Re: gwt rebranding

2013-03-20 Thread Jens 


> On the note of @Gorgeous Web Toolkit@, my $.02 is nice but isn't quite 
> "Gorgeous" isn't geeky enough. The self referential thing is an option and 
> flows nicely when said out loud "Gwit Web Toolkit" but isn't necessarily 
> very descriptive.
>

Hehe yeah "Gorgeous" doesn't really convince me either (feels too 
self-regarding to me). Just treat it as a slogan that can be added to the 
logo. May it be "Gorgeous Web Toolkit" or a totally different slogan like 
"type safe web development". Just having "icon + GWT" feels a bit too less 
when using the logo at larger dimensions. 
At small dimensions its totally fine to just have "icon + GWT" like shown 
in my second example.

-- J.


-- 
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Re: gwt rebranding

2013-03-20 Thread Kerry Wilson 
I would leave gorgeous out of it.  I would just consider it a recursive
acronym like PHP.

GWT: Web Toolkit

kw


On Wed, Mar 20, 2013 at 5:28 AM, Jens  wrote:

>
> On the note of @Gorgeous Web Toolkit@, my $.02 is nice but isn't quite
>> "Gorgeous" isn't geeky enough. The self referential thing is an option and
>> flows nicely when said out loud "Gwit Web Toolkit" but isn't necessarily
>> very descriptive.
>>
>
> Hehe yeah "Gorgeous" doesn't really convince me either (feels too
> self-regarding to me). Just treat it as a slogan that can be added to the
> logo. May it be "Gorgeous Web Toolkit" or a totally different slogan like
> "type safe web development". Just having "icon + GWT" feels a bit too less
> when using the logo at larger dimensions.
> At small dimensions its totally fine to just have "icon + GWT" like shown
> in my second example.
>
> -- J.
>
>
>  --
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "Google Web Toolkit Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>



-- 
http://www.allthingswilson.com

-- 
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Re: Issue 7890 : ListBox: allow CSS class for options (issue1897803)

2013-03-20 Thread tuckerpmt 

On 2013/03/19 15:40:06, tbroyer wrote:

I agree, returning the OptionElement seems like a better idea.

http://gwt-code-reviews.appspot.com/1897803/

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Issue 6256: getAbsoluteTop/getScrollTop returns wrong values...

2013-03-20 Thread Thomas Broyer 

Thomas Broyer has posted comments on this change.

Change subject: Issue 6256: getAbsoluteTop/getScrollTop returns wrong  
values for IE9 when body has been scrolled * Moved methods that are  
specific to WebKit/Safari from DOMImplStandardBase to DOMImplWebkit so that  
they don't affect DOMImplIE9 (which currently extends DOM

..


Patch Set 1:

(6 comments)


Commit Message
Line 8: * Moved methods that are specific to WebKit/Safari from  
DOMImplStandardBase to DOMImplWebkit so that they don't affect DOMImplIE9  
(which currently extends DOMImplStandardBase). There might be other methods  
in DOMImplStandardBase that are specific to WebKit/Safari; I moved only  
those methods that had comments specifying Safari.
Add a blank line above to please Git  
(one-line-summary\n\nmultiline-description)




File user/src/com/google/gwt/dom/client/DOMImplWebkit.java
Line 71:   public native ButtonElement createButtonElement(Document doc,  
String type) /*-{

We no longer enforce it but can you please sort the methods by name?


Line 78:* Safari 2 does not support {@link  
ScriptElement#setText(String)}.
I don't think we still support Safari 2: we removed an old hack in  
DOMImplWebKit last June, and we removed support in History more than 3  
years ago!


http://gwt-code-reviews.appspot.com/29803 said "I also ditched the  
no-longer-supported Safari 2 history implementation" (note that it's  
specific to "history" though, as it never really worked); unfortunately  
Safari 2 is still mentioned in the javadoc despite the code its refererring  
to is long gone.



Line 89: // Safari always applies document scrolling to the body  
element, even in
BTW is this true of Chrome too? I suppose it's more a WebKit thing  
independent of its various "ports", so it'd be the appropriate time to  
s/Safari/WebKit/ in those comments.



Line 98: return doc.getBody().getScrollTop();
As we're at it, we might want to revisit this, in light of issue 5836


Line 102:   public native int getTabIndex(Element elem) /*-{
nit: trailing space


--
To view, visit https://gwt-review.googlesource.com/2260
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8eb89528e534b3b474c60e002ea9d775ca04a796
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Marius Dumitru Florea 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Changes StackTraceDeobfuscator to abstract and provide vario...

2013-03-20 Thread Thomas Broyer 

Thomas Broyer has posted comments on this change.

Change subject: Changes StackTraceDeobfuscator to abstract and provide  
various factory methods.

..


Patch Set 3: Code-Review+1

--
To view, visit https://gwt-review.googlesource.com/2270
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I562e052caef8da7f3434319cf11b8984bc347fe5
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Refactors c.g.gwt.junit to use common SerializableThrowable ...

2013-03-20 Thread Goktug Gokdogan 

Goktug Gokdogan has uploaded a new change for review.

  https://gwt-review.googlesource.com/2290


Change subject: Refactors c.g.gwt.junit to use common SerializableThrowable  
& StacktraceDeobfuscator.

..

Refactors c.g.gwt.junit to use common SerializableThrowable &  
StacktraceDeobfuscator.


- Gets rid of dublicate code in junit for deobfuscation of stack traces
- Improves the messaging of unserializable exceptions
- Minor improvements to the reporting of test infra failures

Change-Id: I1e1021bc99ac88ea6d9d47c3d23c83e79a896213
---
M user/src/com/google/gwt/core/client/JavaScriptException.java
M user/src/com/google/gwt/junit/JUnitMessageQueue.java
M user/src/com/google/gwt/junit/JUnitShell.java
D user/src/com/google/gwt/junit/client/impl/ExceptionWrapper.java
M user/src/com/google/gwt/junit/client/impl/JUnitResult.java
M user/src/com/google/gwt/junit/rebind/GWTRunnerProxyGenerator.java
M user/src/com/google/gwt/junit/server/JUnitHostImpl.java
M  
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java

A user/test/com/google/gwt/junit/DefaultExceptionAsserter.java
M user/test/com/google/gwt/junit/GwtTestSuiteWithExpectedFailures.java
M user/test/com/google/gwt/junit/JUnitSuite.java
M user/test/com/google/gwt/junit/TestResultWithExpectedFailures.java
M user/test/com/google/gwt/junit/TestSuiteWithOrder.java
A user/test/com/google/gwt/junit/client/ExceptionAsserter.java
R user/test/com/google/gwt/junit/client/ExpectedFailure.java
M user/test/com/google/gwt/junit/client/GWTTestCaseAsyncTest.java
M user/test/com/google/gwt/junit/client/GWTTestCaseSetupTearDownTest.java
A user/test/com/google/gwt/junit/client/GWTTestCaseStackTraceTest.java
M user/test/com/google/gwt/junit/client/GWTTestCaseTest.java
M  
user/test/com/google/gwt/junit/client/GWTTestCaseUncaughtExceptionHandlerTest.java

20 files changed, 365 insertions(+), 280 deletions(-)



diff --git a/user/src/com/google/gwt/core/client/JavaScriptException.java  
b/user/src/com/google/gwt/core/client/JavaScriptException.java

index 5c44f48..8f15edd 100644
--- a/user/src/com/google/gwt/core/client/JavaScriptException.java
+++ b/user/src/com/google/gwt/core/client/JavaScriptException.java
@@ -128,7 +128,7 @@
   StackTraceCreator.createStackTrace(this);
 }
   }
-
+
   public JavaScriptException(String name, String description) {
 this.message = "JavaScript " + name + " exception: " + description;
 this.name = name;
@@ -137,10 +137,8 @@
   }

   /**
-   * Used for server-side instantiation during JUnit runs. Exceptions are
-   * manually marshaled through
-   * com.google.gwt.junit.client.impl.ExceptionWrapper  
objects.

-   *
+   * Used for testing instantiations.
+   *
* @param message the detail message
*/
   protected JavaScriptException(String message) {
diff --git a/user/src/com/google/gwt/junit/JUnitMessageQueue.java  
b/user/src/com/google/gwt/junit/JUnitMessageQueue.java

index e2c4bf7..c03a03a 100644
--- a/user/src/com/google/gwt/junit/JUnitMessageQueue.java
+++ b/user/src/com/google/gwt/junit/JUnitMessageQueue.java
@@ -15,11 +15,12 @@
  */
 package com.google.gwt.junit;

+import com.google.gwt.core.shared.SerializableThrowable;
 import com.google.gwt.junit.client.TimeoutException;
-import com.google.gwt.junit.client.impl.JUnitResult;
 import com.google.gwt.junit.client.impl.JUnitHost.ClientInfo;
 import com.google.gwt.junit.client.impl.JUnitHost.TestBlock;
 import com.google.gwt.junit.client.impl.JUnitHost.TestInfo;
+import com.google.gwt.junit.client.impl.JUnitResult;

 import java.util.ArrayList;
 import java.util.HashMap;
@@ -27,8 +28,8 @@
 import java.util.IdentityHashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.Set;
 import java.util.Map.Entry;
+import java.util.Set;

 /**
  * A message queue to pass data between {@link JUnitShell} and
@@ -463,12 +464,21 @@
   if (result == null) {
 return true;
   }
-  Throwable exception = result.getException();
-  if (exception != null && !isMember(exception,  
THROWABLES_NOT_RETRIED)) {

+
+  Class thrown = getExceptionClass(result.getException());
+  if (thrown != null && !isMember(thrown, THROWABLES_NOT_RETRIED)) {
 return true;
   }
 }
 return false;
+  }
+
+  private Class getExceptionClass(SerializableThrowable throwable) {
+try {
+  return throwable == null ? null :  
Class.forName(throwable.getDesignatedType());

+} catch (Exception e) {
+  return null;
+}
   }

   void removeResults(TestInfo testInfo) {
@@ -521,10 +531,10 @@
 return results;
   }

-  private boolean isMember(Throwable exception,
+  private boolean isMember(Class throwableClass,
   Set> throwableSet) {
 for (Class throwable : throwableSet) {
-  if (throwable.isInstance(exception)) {
+  if (throwable.isAssignableFrom(throwableClass)) {
 return true;
   }
 }
diff --git a/us

Re: [gwt-contrib] Re: gwt rebranding

2013-03-20 Thread David 
Not that I have anything of authority here, but why not adopt Guice instead
of all the gwt.xml trickery and call it the Guicy Web ToolKit

David

On Wed, Mar 20, 2013 at 1:44 PM, Kerry Wilson wrote:

> I would leave gorgeous out of it.  I would just consider it a recursive
> acronym like PHP.
>
> GWT: Web Toolkit
>
> kw
>
>
> On Wed, Mar 20, 2013 at 5:28 AM, Jens  wrote:
>
>>
>> On the note of @Gorgeous Web Toolkit@, my $.02 is nice but isn't quite
>>> "Gorgeous" isn't geeky enough. The self referential thing is an option and
>>> flows nicely when said out loud "Gwit Web Toolkit" but isn't necessarily
>>> very descriptive.
>>>
>>
>> Hehe yeah "Gorgeous" doesn't really convince me either (feels too
>> self-regarding to me). Just treat it as a slogan that can be added to the
>> logo. May it be "Gorgeous Web Toolkit" or a totally different slogan like
>> "type safe web development". Just having "icon + GWT" feels a bit too less
>> when using the logo at larger dimensions.
>> At small dimensions its totally fine to just have "icon + GWT" like shown
>> in my second example.
>>
>> -- J.
>>
>>
>>  --
>> --
>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Google Web Toolkit Contributors" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>>
>
>
>
> --
> http://www.allthingswilson.com
>
> --
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "Google Web Toolkit Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

-- 
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Moves GWTTestCase to Impl#setUncaughtExceptionHandlerForTest.

2013-03-20 Thread Goktug Gokdogan 

Hello Brian Slesinsky,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/2190

to look at the new patch set (#3).

Change subject: Moves GWTTestCase to  
Impl#setUncaughtExceptionHandlerForTest.

..

Moves GWTTestCase to Impl#setUncaughtExceptionHandlerForTest.

This will prevent the competition between the test and production uncaught  
exception handlers.
This change also introduces GWTTestCase#reportUncaughtException to enable  
test cases to change the behavior in order to test uncaught exceptions.


Fixes issue 5016

Change-Id: I8d32c6f4ff4cbcd55f238116b8bcc4c8685d6f35
Review-Link: https://gwt-review.googlesource.com/#/c/2190/
---
M user/src/com/google/gwt/core/client/impl/Impl.java
M user/src/com/google/gwt/junit/client/GWTTestCase.java
M  
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/GWTTestCase.java

M user/test/com/google/gwt/dev/jjs/test/RunAsyncTest.java
M  
user/test/com/google/gwt/junit/client/GWTTestCaseUncaughtExceptionHandlerTest.java

M user/test/com/google/gwt/user/client/CommandExecutorTest.java
M user/test/com/google/gwt/user/client/ui/DOMTest.java
M  
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryExceptionPropagationTest.java
M  
user/test/com/google/web/bindery/requestfactory/server/RequestFactoryExceptionPropagationJreTest.java

9 files changed, 248 insertions(+), 305 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/2190
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8d32c6f4ff4cbcd55f238116b8bcc4c8685d6f35
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Goktug Gokdogan 

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Moves GWTTestCase to Impl#setUncaughtExceptionHandlerForTest.

2013-03-20 Thread Brian Slesinsky 

Brian Slesinsky has posted comments on this change.

Change subject: Moves GWTTestCase to  
Impl#setUncaughtExceptionHandlerForTest.

..


Patch Set 3: Code-Review+1

(5 comments)

Looking good. Some javadoc tweaks.


File user/src/com/google/gwt/junit/client/GWTTestCase.java
Line 350:* This method is called by the test framework to report  
uncaught exceptions. The default
"to report uncaught exceptions" -> "to report uncaught exceptions thrown by  
callbacks."



Line 351:* implementation causes test case to be reported as 'failed'  
however in some rare situations

...causes the test case to be reported as 'failed.' However, in...


Line 352:* where an uncaught exception is expected then test case may  
choose to alter the behavior by

... is expected, a test case...


Line 362:* if (t instanceof ExpectedUmbrellaException) {
...instanceof ExpectedTestException...


Line 373:* already finished before this method is called, the behavior  
is undefined.
Maybe replace "the behavior is undefined" with "The reported exception is  
currently ignored, but this may change in a future version of GWT."


Maybe add another paragraph.

"If reportUncaughtException() is called multiple times during a test  
method, only the first one will be reported. If it's called during a test  
method that also throws an exception, the reported  exception takes  
priority over the thrown exception."



--
To view, visit https://gwt-review.googlesource.com/2190
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d32c6f4ff4cbcd55f238116b8bcc4c8685d6f35
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Moves GWTTestCase to Impl#setUncaughtExceptionHandlerForTest.

2013-03-20 Thread Goktug Gokdogan 

Hello Brian Slesinsky,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/2190

to look at the new patch set (#4).

Change subject: Moves GWTTestCase to  
Impl#setUncaughtExceptionHandlerForTest.

..

Moves GWTTestCase to Impl#setUncaughtExceptionHandlerForTest.

This will prevent the competition between the test and production uncaught  
exception handlers.
This change also introduces GWTTestCase#reportUncaughtException to enable  
test cases to change the behavior in order to test uncaught exceptions.


Fixes issue 5016

Change-Id: I8d32c6f4ff4cbcd55f238116b8bcc4c8685d6f35
Review-Link: https://gwt-review.googlesource.com/#/c/2190/
---
M user/src/com/google/gwt/core/client/impl/Impl.java
M user/src/com/google/gwt/junit/client/GWTTestCase.java
M  
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/GWTTestCase.java

M user/test/com/google/gwt/dev/jjs/test/RunAsyncTest.java
M  
user/test/com/google/gwt/junit/client/GWTTestCaseUncaughtExceptionHandlerTest.java

M user/test/com/google/gwt/user/client/CommandExecutorTest.java
M user/test/com/google/gwt/user/client/ui/DOMTest.java
M  
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryExceptionPropagationTest.java
M  
user/test/com/google/web/bindery/requestfactory/server/RequestFactoryExceptionPropagationJreTest.java

9 files changed, 252 insertions(+), 305 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/2190
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8d32c6f4ff4cbcd55f238116b8bcc4c8685d6f35
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Thomas Broyer 

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Moves GWTTestCase to Impl#setUncaughtExceptionHandlerForTest.

2013-03-20 Thread Goktug Gokdogan 

Goktug Gokdogan has posted comments on this change.

Change subject: Moves GWTTestCase to  
Impl#setUncaughtExceptionHandlerForTest.

..


Patch Set 3:

(5 comments)


File user/src/com/google/gwt/junit/client/GWTTestCase.java
Line 350:* This method is called by the test framework to report  
uncaught exceptions. The default
I think we should not try specify how uncaught exception are generated  
here. I added a @see below for someone who needs to read more about it.



Line 351:* implementation causes test case to be reported as 'failed'  
however in some rare situations

Done


Line 352:* where an uncaught exception is expected then test case may  
choose to alter the behavior by

Done


Line 362:* if (t instanceof ExpectedUmbrellaException) {
Done


Line 373:* already finished before this method is called, the behavior  
is undefined.

Done.

About the additional paragraph: I put more info various places to cover  
more aspects, but I think we should not over specify as it makes it harder  
to read and ends up confusing the developer.



--
To view, visit https://gwt-review.googlesource.com/2190
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d32c6f4ff4cbcd55f238116b8bcc4c8685d6f35
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Moves GWTTestCase to Impl#setUncaughtExceptionHandlerForTest.

2013-03-20 Thread Brian Slesinsky 

Brian Slesinsky has posted comments on this change.

Change subject: Moves GWTTestCase to  
Impl#setUncaughtExceptionHandlerForTest.

..


Patch Set 4: Code-Review+1

--
To view, visit https://gwt-review.googlesource.com/2190
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d32c6f4ff4cbcd55f238116b8bcc4c8685d6f35
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Moves c.g.gwt.logging to common StackTraceDeobfuscator.

2013-03-20 Thread Goktug Gokdogan 

Goktug Gokdogan has uploaded a new change for review.

  https://gwt-review.googlesource.com/2300


Change subject: Moves c.g.gwt.logging to common StackTraceDeobfuscator.
..

Moves c.g.gwt.logging to common StackTraceDeobfuscator.

Change-Id: I44bee6a3abdf550831f6f9263a8c6e3c807ca063
---
M user/src/com/google/gwt/logging/server/RemoteLoggingServiceImpl.java
M user/src/com/google/gwt/logging/server/RemoteLoggingServiceUtil.java
M user/src/com/google/web/bindery/requestfactory/server/Logging.java
M user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java
M user/test/com/google/gwt/user/server/rpc/LoggingRPCTestServiceImpl.java
5 files changed, 42 insertions(+), 91 deletions(-)



diff --git  
a/user/src/com/google/gwt/logging/server/RemoteLoggingServiceImpl.java  
b/user/src/com/google/gwt/logging/server/RemoteLoggingServiceImpl.java

index ac85b0a..15cc374 100644
--- a/user/src/com/google/gwt/logging/server/RemoteLoggingServiceImpl.java
+++ b/user/src/com/google/gwt/logging/server/RemoteLoggingServiceImpl.java
@@ -16,6 +16,7 @@

 package com.google.gwt.logging.server;

+import com.google.gwt.core.server.impl.StackTraceDeobfuscator;
 import  
com.google.gwt.logging.server.RemoteLoggingServiceUtil.RemoteLoggingException;

 import com.google.gwt.logging.shared.RemoteLoggingService;
 import com.google.gwt.user.server.rpc.RemoteServiceServlet;
@@ -27,16 +28,14 @@
 /**
  * Server side code for the remote log handler.
  */
-public class RemoteLoggingServiceImpl extends RemoteServiceServlet  
implements

-RemoteLoggingService {
-  // No deobfuscator by default
-  private static StackTraceDeobfuscator deobfuscator = null;
+public class RemoteLoggingServiceImpl extends RemoteServiceServlet  
implements RemoteLoggingService {


-  private static Logger logger =
-Logger.getLogger(RemoteServiceServlet.class.getName());
-
-  private static String loggerNameOverride = null;
-
+  private static Logger logger =  
Logger.getLogger(RemoteServiceServlet.class.getName());

+
+  // No deobfuscator by default
+  private StackTraceDeobfuscator deobfuscator = null;
+  private String loggerNameOverride = null;
+
   /**
* Logs a Log Record which has been serialized using GWT RPC on the  
server.

* @return either an error message, or null if logging is successful.
@@ -67,13 +66,8 @@
* By default, this service does not do any deobfuscation. In order to do
* server side deobfuscation, you must copy the symbolMaps files to a
* directory visible to the server and set the directory using this  
method.

-   * @param symbolMapsDir
*/
   public void setSymbolMapsDirectory(String symbolMapsDir) {
-if (deobfuscator == null) {
-  deobfuscator = new StackTraceDeobfuscator(symbolMapsDir);
-} else {
-  deobfuscator.setSymbolMapsDirectory(symbolMapsDir);
-}
+deobfuscator = StackTraceDeobfuscator.fromFileSystem(symbolMapsDir);
   }
 }
diff --git  
a/user/src/com/google/gwt/logging/server/RemoteLoggingServiceUtil.java  
b/user/src/com/google/gwt/logging/server/RemoteLoggingServiceUtil.java

index 2b0b6dc..940cc95 100644
--- a/user/src/com/google/gwt/logging/server/RemoteLoggingServiceUtil.java
+++ b/user/src/com/google/gwt/logging/server/RemoteLoggingServiceUtil.java
@@ -16,6 +16,8 @@

 package com.google.gwt.logging.server;

+import com.google.gwt.core.server.impl.StackTraceDeobfuscator;
+
 import java.util.logging.LogRecord;
 import java.util.logging.Logger;

@@ -53,7 +55,7 @@
   StackTraceDeobfuscator deobfuscator, String loggerNameOverride)  
throws

   RemoteLoggingException {
 if (deobfuscator != null) {
-  lr = deobfuscator.deobfuscateLogRecord(lr, strongName);
+  lr = deobfuscateLogRecord(deobfuscator, lr, strongName);
 }
 String loggerName = loggerNameOverride == null ? lr.getLoggerName() :
   loggerNameOverride;
@@ -61,13 +63,19 @@
 logger.log(lr);
   }

+  public static LogRecord deobfuscateLogRecord(
+  StackTraceDeobfuscator deobfuscator, LogRecord lr, String  
strongName) {

+if (lr.getThrown() != null && strongName != null) {
+  deobfuscator.deobfuscateStackTrace(lr.getThrown(), strongName);
+}
+return lr;
+  }
+
   public static void logOnServer(String serializedLogRecordJson,
   String strongName, StackTraceDeobfuscator deobfuscator,
   String loggerNameOverride) throws RemoteLoggingException {
-LogRecord lr;
 try {
-  lr = JsonLogRecordServerUtil.logRecordFromJson(
-  serializedLogRecordJson);
+  LogRecord lr =  
JsonLogRecordServerUtil.logRecordFromJson(serializedLogRecordJson);

   logOnServer(lr, strongName, deobfuscator, loggerNameOverride);
 } catch (Exception e) {
   // We don't want to import the JsonException, which will require the  
json
diff --git  
a/user/src/com/google/web/bindery/requestfactory/server/Logging.java  
b/user/src/com/google/web/bindery/requestfactory/server/Logging.java

index 7

[gwt-contrib] Change in gwt[master]: Attempt to continue after the JDT compiler aborts.

2013-03-20 Thread Matthew Dempsky 

Matthew Dempsky has posted comments on this change.

Change subject: Attempt to continue after the JDT compiler aborts.
..


Patch Set 1: Code-Review+1

--
To view, visit https://gwt-review.googlesource.com/2271
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia94d998c6b4e56d880570c726aa09f004a4f552c
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Brian Slesinsky 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Re: gwt rebranding

2013-03-20 Thread Matthew Dempsky 
On Wed, Mar 20, 2013 at 12:25 PM, David  wrote:

> Not that I have anything of authority here, but why not adopt Guice
> instead of all the gwt.xml trickery and call it the Guicy Web ToolKit


I don't believe Guice can 100% replicate the functionality provided by
.gwt.xml files, though reducing how often developers need to manually write
.gwt.xml files is something we're interested in.

Having a separate config file for managing how GWT builds work is also
likely going to be important to optimizing GWT compile time.  If the config
format were something turing complete like Java source code, then improving
the GWT compiler becomes a lot more difficult.

-- 
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Re: gwt rebranding

2013-03-20 Thread Matthew Dempsky 
On Wed, Mar 20, 2013 at 2:53 AM, James Horsley wrote:

> On the note of @Gorgeous Web Toolkit@, my $.02 is nice but isn't quite
> "Gorgeous" isn't geeky enough.
>

My internal '3-word mission statement' is "Great Web Toolkit". ;)

 The self referential thing is an option and flows nicely when said out
> loud "Gwit Web Toolkit" but isn't necessarily very descriptive.
>

I'd prefer "GWT Web Toolkit" over "Gwit Web Toolkit", but that's my 2c.  I
think any "G* Web Toolkit" name will likely be just as descriptive; it's
not like calling it "Google Web Toolkit" really told you anything more
about the project other than knowing it's associated with Google! :)

-- 
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Re: gwt rebranding

2013-03-20 Thread Andy Stevko 
Guru's Web Toolkit


On Wed, Mar 20, 2013 at 6:06 PM, Matthew Dempsky wrote:

> On Wed, Mar 20, 2013 at 2:53 AM, James Horsley wrote:
>
>> On the note of @Gorgeous Web Toolkit@, my $.02 is nice but isn't quite
>> "Gorgeous" isn't geeky enough.
>>
>
> My internal '3-word mission statement' is "Great Web Toolkit". ;)
>
>  The self referential thing is an option and flows nicely when said out
>> loud "Gwit Web Toolkit" but isn't necessarily very descriptive.
>>
>
> I'd prefer "GWT Web Toolkit" over "Gwit Web Toolkit", but that's my 2c.  I
> think any "G* Web Toolkit" name will likely be just as descriptive; it's
> not like calling it "Google Web Toolkit" really told you anything more
> about the project other than knowing it's associated with Google! :)
>
> --
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "Google Web Toolkit Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>



-- 
-- A. Stevko
===
"If everything seems under control, you're just not going fast enough." M.
Andretti

-- 
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Refactors c.g.gwt.logging to use SerializableThrowable.

2013-03-20 Thread Goktug Gokdogan 

Goktug Gokdogan has uploaded a new change for review.

  https://gwt-review.googlesource.com/2310


Change subject: Refactors c.g.gwt.logging to use SerializableThrowable.
..

Refactors c.g.gwt.logging to use SerializableThrowable.

Change-Id: Ifeee26a9b36cbe40bd1cf0942da8fae39179e985
---
M user/src/com/google/gwt/logging/client/HtmlLogFormatter.java
M user/src/com/google/gwt/logging/client/TextLogFormatter.java
M user/src/com/google/gwt/logging/impl/FormatterImpl.java
A user/src/com/google/gwt/logging/impl/StackTracePrintStream.java
M user/src/com/google/gwt/logging/server/JsonLogRecordServerUtil.java
M  
user/src/com/google/gwt/user/client/rpc/core/java/util/logging/LogRecord_CustomFieldSerializer.java
D  
user/src/com/google/gwt/user/server/rpc/core/java/util/logging/LogRecord_ServerCustomFieldSerializer.java

M user/super/com/google/gwt/emul/java/lang/Throwable.java
M user/super/com/google/gwt/emul/java/util/logging/Level.java
M user/super/com/google/gwt/emul/java/util/logging/LogRecord.java
A user/test/com/google/gwt/logging/LoggingSuite.java
A user/test/com/google/gwt/logging/LoggingTest.gwt.xml
A user/test/com/google/gwt/logging/client/StackTracePrintStreamTest.java
13 files changed, 265 insertions(+), 197 deletions(-)



diff --git a/user/src/com/google/gwt/logging/client/HtmlLogFormatter.java  
b/user/src/com/google/gwt/logging/client/HtmlLogFormatter.java

index 74cc1c1..acf0697 100644
--- a/user/src/com/google/gwt/logging/client/HtmlLogFormatter.java
+++ b/user/src/com/google/gwt/logging/client/HtmlLogFormatter.java
@@ -17,6 +17,7 @@
 package com.google.gwt.logging.client;

 import com.google.gwt.logging.impl.FormatterImpl;
+import com.google.gwt.logging.impl.StackTracePrintStream;

 import java.util.logging.Level;
 import java.util.logging.LogRecord;
@@ -27,28 +28,35 @@
  * is properly escaped.
  */
 public class HtmlLogFormatter extends FormatterImpl {
-  private static String newline = "__GWT_LOG_FORMATTER_BR__";
   private boolean showStackTraces;
-
+
   public HtmlLogFormatter(boolean showStackTraces) {
 this.showStackTraces = showStackTraces;
   }

-  // TODO(unnurg): Handle the outputting of Throwables.
   @Override
   public String format(LogRecord event) {
-StringBuilder html = new StringBuilder();
+final StringBuilder html = new StringBuilder();
 html.append(getHtmlPrefix(event));
 html.append(getRecordInfo(event, " "));
 html.append(getEscaped(event.getMessage()));
-if (showStackTraces) {
-  html.append(getEscaped(getStackTraceAsString(
-  event.getThrown(), newline, "   ")));
+if (showStackTraces && event.getThrown() != null) {
+  event.getThrown().printStackTrace(new StackTracePrintStream(html) {
+@Override
+public void print(String str) {
+  html.append(getEscaped(str));
+}
+
+@Override
+public void println() {
+  html.append("");
+}
+  });
 }
 html.append(getHtmlSuffix(event));
 return html.toString();
   }
-
+
   protected String getHtmlPrefix(LogRecord event) {
 StringBuilder prefix = new StringBuilder();
 prefix.append("
+
+  
+
diff --git  
a/user/test/com/google/gwt/logging/client/StackTracePrintStreamTest.java  
b/user/test/com/google/gwt/logging/client/StackTracePrintStreamTest.java

new file mode 100644
index 000..cb3655c
--- /dev/null
+++ b/user/test/com/google/gwt/logging/client/StackTracePrintStreamTest.java
@@ -0,0 +1,66 @@
+/*
+ * Copyright 2013 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,  
WITHOUT

+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under

+ * the License.
+ */
+package com.google.gwt.logging.client;
+
+import com.google.gwt.junit.client.GWTTestCase;
+import com.google.gwt.logging.impl.StackTracePrintStream;
+
+/**
+ * Tests {@link StackTracePrintStream}.
+ */
+public class StackTracePrintStreamTest extends GWTTestCase {
+  @Override
+  public String getModuleName() {
+return "com.google.gwt.logging.LoggingTest";
+  }
+
+  public void testPrintStackTrace() throws Exception {
+StringBuilder stackTraceBuilder = new StringBuilder();
+createTestException().printStackTrace(new  
StackTracePrintStream(stackTraceBuilder));

+
+StringBuilder expectedStackTraceBuilder = new StringBuilder();
+expectedStackTraceBuilder.append("custom msg\n");
+expectedStackTraceBuilder.append("\tat c1.m1(f1:1)\n");
+expectedStackTraceBuilder.append("\tat c2.m2(f2:2)\n");
+expectedStackTraceBu

Re: [gwt-contrib] Re: gwt rebranding

2013-03-20 Thread 何兢 
Gava Web Toolkit
(soft G)


On Wed, Mar 20, 2013 at 8:56 PM, Andy Stevko  wrote:

> Guru's Web Toolkit
>
>
> On Wed, Mar 20, 2013 at 6:06 PM, Matthew Dempsky wrote:
>
>> On Wed, Mar 20, 2013 at 2:53 AM, James Horsley 
>> wrote:
>>
>>> On the note of @Gorgeous Web Toolkit@, my $.02 is nice but isn't quite
>>> "Gorgeous" isn't geeky enough.
>>>
>>
>> My internal '3-word mission statement' is "Great Web Toolkit". ;)
>>
>>  The self referential thing is an option and flows nicely when said out
>>> loud "Gwit Web Toolkit" but isn't necessarily very descriptive.
>>>
>>
>> I'd prefer "GWT Web Toolkit" over "Gwit Web Toolkit", but that's my 2c.
>>  I think any "G* Web Toolkit" name will likely be just as descriptive; it's
>> not like calling it "Google Web Toolkit" really told you anything more
>> about the project other than knowing it's associated with Google! :)
>>
>> --
>> --
>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Google Web Toolkit Contributors" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>>
>
>
>
> --
> -- A. Stevko
> ===
> "If everything seems under control, you're just not going fast enough."
> M. Andretti
>
>
>
>
>  --
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "Google Web Toolkit Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>



-- 

 Andrew Bachmann |  Software Engineer |  345 Spear St, San Francisco, CA |
 415-652-0315

-- 
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.