[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Thomas Broyer has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 2: (1 comment) File user/src/com/google/gwt/user/client/ui/Composite.java Line 37: * @param type of the widget wrapped Well, setWidget() is a deprecated alias to initWidget, and initWidget(T) is an alias for initWidget(Widget,T) where the argument is passed as both the "root widget" and the "delegate widget"; so while it looks a bit weird (when you look at the signatures of setWidget vs. getWidget), it's actually consistent. I however agree the javadoc could be enhanced to talk about that new concept of 'delegate'. And maybe it's time to delete setWidget(), it's deprecated since the very first public commit more than 6 years ago! -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Jens Nehlmeier Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Jens Nehlmeier has posted comments on this change.
Change subject: Introduces generic Composite widgets.
..
Patch Set 2:
(4 comments)
File user/src/com/google/gwt/user/client/ui/Composite.java
Line 127: public T getDelegate() {
protected final instead of public. I dont think a composite wants to leak
out "T".
Line 148:*
Maybe add an example to illustrate the purpose (for new GWT users).
Line 151:*will be delegated (e.g. HasWidget#add)
I am not a native speaker but "the child widget that higher level API calls
(if any) will be delegated (e.g. HasWidget#add) to" sounds better to me.
File user/src/com/google/gwt/user/client/ui/FocusComposite.java
Line 52: HasAllMouseHandlers, HasAllGestureHandlers,
HasAllTouchHandlers {
What about the remaining interfaces that FocusWidget implements?
HasDoubleClickHandlers, HasAllDragAndDropHandlers?
--
To view, visit https://gwt-review.googlesource.com/2582
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan
Gerrit-Reviewer: Brian Slesinsky
Gerrit-Reviewer: Goktug Gokdogan
Gerrit-Reviewer: Jens Nehlmeier
Gerrit-Reviewer: Leeroy Jenkins
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Thomas Broyer
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Brian Slesinsky has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 2: (2 comments) File user/src/com/google/gwt/user/client/ui/Composite.java Line 29: * methods. When added to a panel, a composite behaves exactly as if the widget This javadoc doesn't seem quite true anymore if widget != delegate. Line 37: * @param type of the widget wrapped The way we're using T seems confusing. Widget getWidget(); T getDelegate(); void setWidget(T); So I'm wondering whether T is supposed to be the type of the widget, or the delegate, or both? We should clarify that. -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Thomas Broyer has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 2: That's what I thought it was about; this is great! Just a note that the getDelegate could possibly break some people that defined a getDelegate method in their Composite subclass. I don't think it'll break many people in practice though, so I'm fine with this (same for the overloaded initWidget, with even less impact I guess). -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Goktug Gokdogan has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 2: Yes, we haven't discussed =) The idea behind is some composite scenarios you want you delegate to something different than your base widget. A good example is following: This is my header This is my footer -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Thomas Broyer has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 2: Code-Review+1 That new 'delegate' concept is interesting. I don't think we discussed it earlier though, so I'll let someone else put the +2. -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Thomas Broyer has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 3:
(1 comment)
File build.xml
Line 36:
value="${gwt.tools}/api-checker-reference/2.5.1/gwt-dev.jar:${gwt.tools}/api-checker-reference/2.5.1/gwt-user.jar"/>
Done
--
To view, visit https://gwt-review.googlesource.com/2500
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer
Gerrit-Reviewer: Brian Slesinsky
Gerrit-Reviewer: John A. Tamplin
Gerrit-Reviewer: Leeroy Jenkins
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Ray Cromwell
Gerrit-Reviewer: Thomas Broyer
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Hello Matthew Dempsky, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2500 to look at the new patch set (#4). Change subject: Removes api-checker reference JARs from the source tree. .. Removes api-checker reference JARs from the source tree. Now expects them in GWT_TOOLS. Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 --- M build.xml D tools/api-checker/reference/README D tools/api-checker/reference/createApiCheckerReferenceJars.sh D tools/api-checker/reference/gwt-dev-modified.jar D tools/api-checker/reference/gwt-user-modified.jar 5 files changed, 3 insertions(+), 46 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: John A. Tamplin Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Hello Matthew Dempsky, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2582 to look at the new patch set (#2). Change subject: Introduces generic Composite widgets. .. Introduces generic Composite widgets. Composite can now be 'safely' extended to add delegation to methods for more specific types. Adds FocusComposite and PanelComposite. Improves error messaging for incorrect use. Fixes issue 4665, issue 6997. Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Review-Link: https://gwt-review.googlesource.com/#/c/2582/ --- M user/src/com/google/gwt/user/client/ui/Composite.java A user/src/com/google/gwt/user/client/ui/FocusComposite.java A user/src/com/google/gwt/user/client/ui/PanelComposite.java M user/src/com/google/gwt/user/client/ui/ResizeComposite.java 4 files changed, 297 insertions(+), 20 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Goktug Gokdogan has posted comments on this change.
Change subject: Introduces generic Composite widgets.
..
Patch Set 1:
(2 comments)
Sending a new patch without TypedXYZ.
PTAL.
File user/src/com/google/gwt/user/client/ui/PanelComposite.java
Line 39: this.add(asWidgetOrNull(w));
I think I understand what you are trying to achieve. Done.
File user/src/com/google/gwt/user/client/ui/TypedComposite.java
Line 118: if (widget == null) {
I change how this is asserted in the new code. I took a less conservative
approach and handled cases where it is harder to understand what is going
on.
--
To view, visit https://gwt-review.googlesource.com/2582
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan
Gerrit-Reviewer: Brian Slesinsky
Gerrit-Reviewer: Goktug Gokdogan
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Thomas Broyer
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add SafeUri overloads for setting properties used for naviga...
Matthew Dempsky has posted comments on this change. Change subject: Add SafeUri overloads for setting properties used for navigation .. Patch Set 4: Yeah, renaming setInnerSafeHtml(SafeHtml) to just setInnerHTML(SafeHtml) would make things more consistent. Checking internally, I only see two calls to "setInnerHTML(null)", and one of them is in the open source Wave code. ;) So even less risk of breaking existing users there I think. I see a *lot* of calls to setInnerSafeHtml() though, so we'd probably need to keep the current method as a @Deprecated forwarding method for a few releases. -- To view, visit https://gwt-review.googlesource.com/2663 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ab7a472b0c0c4470f00f7178de216f7c7e4e415 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Guillaume Ryder Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Patrick Tucker Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add SafeUri overloads for setting properties used for naviga...
Goktug Gokdogan has posted comments on this change. Change subject: Add SafeUri overloads for setting properties used for navigation .. Patch Set 4: Yeah, making it more discoverable looks worthwhile. Perhaps, you would also want to make it consistent by changing Element#setInnerSafeHtml to setInnerHtml? -- To view, visit https://gwt-review.googlesource.com/2663 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ab7a472b0c0c4470f00f7178de216f7c7e4e415 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Guillaume Ryder Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Patrick Tucker Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...
Goktug Gokdogan has posted comments on this change. Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Patch Set 5: (2 comments) I hate gerrit when "Add comment" doesn't publish the draft comments :( File tools/api-checker/config/gwt25_26userApi.conf Line 45: :com/google/gwt/resources/client/impl/**\ He he, nobody in gwt-team knew about this document when I asked about it and created the file :) It could have saved me a lot of time. Thanks for looking into this. When you do the change, it would be good to put the documentation link to the readme file in the script directory. File user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java Line 549: @DoNotRunWith(Platform.HtmlUnitUnknown) I'm not sure which is the best way to follow here. Feel free to go with what makes sense to you. -- To view, visit https://gwt-review.googlesource.com/2110 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add SafeUri overloads for setting properties used for naviga...
Matthew Dempsky has posted comments on this change. Change subject: Add SafeUri overloads for setting properties used for navigation .. Patch Set 4: My personal inclination is still to keep the setFoo(SafeUri) overloads instead of renaming them to setSafeFoo(SafeUri). In Google's internal code base, only about 1% of existing call sites to AnchorElement.setHref(String) were of the form anchor.setHref(null) and needed to be disambiguated. I think the minor inconvenience to those use cases is worthwhile if it makes using SafeUri easier / more visible. -- To view, visit https://gwt-review.googlesource.com/2663 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ab7a472b0c0c4470f00f7178de216f7c7e4e415 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Guillaume Ryder Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Patrick Tucker Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...
Goktug Gokdogan has posted comments on this change. Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Patch Set 7: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/2110 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
On 2013/05/16 19:35:21, mdempsky wrote: Thanks for the patch! But do you mind reuploading it to https://gwt-review.googlesource.com/gwt so we can review and merge it there? Oops, sorry, the link is just https://gwt-review.googlesource.com http://gwt-code-reviews.appspot.com/1832803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
Thanks for the patch! But do you mind reuploading it to https://gwt-review.googlesource.com/gwt so we can review and merge it there? http://gwt-code-reviews.appspot.com/1832803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add SafeUri overloads for setting properties used for naviga...
Goktug Gokdogan has posted comments on this change. Change subject: Add SafeUri overloads for setting properties used for navigation .. Patch Set 4: Matthew, can you do the change if Thomas doesn't have any other concerns? -- To view, visit https://gwt-review.googlesource.com/2663 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ab7a472b0c0c4470f00f7178de216f7c7e4e415 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Guillaume Ryder Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Patrick Tucker Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
On 2012/09/16 02:36:41, Patrick Tucker wrote: Anybody? http://gwt-code-reviews.appspot.com/1832803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Don't call toString() on plain Java arrays
Matthew Dempsky has submitted this change and it was merged.
Change subject: Don't call toString() on plain Java arrays
..
Don't call toString() on plain Java arrays
Error Prone will soon warn about calling toString() on plain Java
arrays, because the return value is rarely useful. In JsoTest, we
don't actually care about what it returns because the cast to
String[][] should throw an exception anyway, but presumably we want to
make sure the variable doesn't get discarded as dead and the cast
optimized away.
Instead of applying the Error Prone automated refactoring of calling
java.util.Arrays.toString(), we can just call getClass() instead.
Change-Id: I2e90cf1442d126efe8d7ec866204f20c5e4cf3e9
---
M user/test/com/google/gwt/dev/jjs/test/JsoTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
John A. Tamplin: Looks good to me, approved
Leeroy Jenkins: Verified
Thomas Broyer: Looks good to me, approved
diff --git a/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
b/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
index 059d1c9..9164f25 100644
--- a/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
+++ b/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
@@ -407,7 +407,7 @@
assertFalse(o instanceof String[][]);
try {
String[][] s = (String[][]) o;
- s.toString();
+ s.getClass();
fail("Expected ClassCastException");
} catch (ClassCastException expected) {
}
--
To view, visit https://gwt-review.googlesource.com/2771
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e90cf1442d126efe8d7ec866204f20c5e4cf3e9
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky
Gerrit-Reviewer: John A. Tamplin
Gerrit-Reviewer: Leeroy Jenkins
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Roberto Lublinerman
Gerrit-Reviewer: Thomas Broyer
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Don't call toString() on plain Java arrays
John A. Tamplin has posted comments on this change. Change subject: Don't call toString() on plain Java arrays .. Patch Set 1: Code-Review+2 (1 comment) File user/test/com/google/gwt/dev/jjs/test/JsoTest.java Line 410: s.getClass(); I'm kind of surprised that getClass wouldn't get optimized out anyway, since it gets replaced with a field reference, but I think this should be fine since the test would be failing if the cast/getClass call get optimized away. -- To view, visit https://gwt-review.googlesource.com/2771 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e90cf1442d126efe8d7ec866204f20c5e4cf3e9 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky Gerrit-Reviewer: John A. Tamplin Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Matthew Dempsky has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 3:
(1 comment)
File build.xml
Line 36:
value="${gwt.tools}/api-checker-reference/2.5.1/gwt-dev.jar:${gwt.tools}/api-checker-reference/2.5.1/gwt-user.jar"/>
Oh, I added the jars to GWT_TOOLS as gwt-{dev,user}-modified.jar like they
were already. I'd like to keep the "modified" label for now just so it's
clearer that the files aren't the pristine release jar files.
--
To view, visit https://gwt-review.googlesource.com/2500
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer
Gerrit-Reviewer: Brian Slesinsky
Gerrit-Reviewer: John A. Tamplin
Gerrit-Reviewer: Leeroy Jenkins
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Ray Cromwell
Gerrit-Reviewer: Thomas Broyer
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...
Matthew Dempsky has posted comments on this change. Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Patch Set 7: Verified+1 Code-Review+1 LGTM, tests all pass now. Goktug, I'll let you +2. :) -- To view, visit https://gwt-review.googlesource.com/2110 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Don't call toString() on plain Java arrays
Matthew Dempsky has posted comments on this change. Change subject: Don't call toString() on plain Java arrays .. Patch Set 1: (1 comment) File user/test/com/google/gwt/dev/jjs/test/JsoTest.java Line 410: s.getClass(); That's my best guess as well. Maybe Roberto has some insight, but it's probably not very important either way. -- To view, visit https://gwt-review.googlesource.com/2771 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e90cf1442d126efe8d7ec866204f20c5e4cf3e9 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Don't call toString() on plain Java arrays
Thomas Broyer has posted comments on this change. Change subject: Don't call toString() on plain Java arrays .. Patch Set 1: Code-Review+2 (1 comment) File user/test/com/google/gwt/dev/jjs/test/JsoTest.java Line 410: s.getClass(); I suppose this is call is only there so that the cast is not purely optimized out? -- To view, visit https://gwt-review.googlesource.com/2771 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e90cf1442d126efe8d7ec866204f20c5e4cf3e9 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Don't call toString() on plain Java arrays
Matthew Dempsky has uploaded a new change for review.
https://gwt-review.googlesource.com/2771
Change subject: Don't call toString() on plain Java arrays
..
Don't call toString() on plain Java arrays
Error Prone will soon warn about calling toString() on plain Java
arrays, because the return value is rarely useful. In JsoTest, we
don't actually care about what it returns because the cast to
String[][] should throw an exception anyway, but presumably we want to
make sure the variable doesn't get discarded as dead and the cast
optimized away.
Instead of applying the Error Prone automated refactoring of calling
java.util.Arrays.toString(), we can just call getClass() instead.
Change-Id: I2e90cf1442d126efe8d7ec866204f20c5e4cf3e9
---
M user/test/com/google/gwt/dev/jjs/test/JsoTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
b/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
index 059d1c9..9164f25 100644
--- a/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
+++ b/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
@@ -407,7 +407,7 @@
assertFalse(o instanceof String[][]);
try {
String[][] s = (String[][]) o;
- s.toString();
+ s.getClass();
fail("Expected ClassCastException");
} catch (ClassCastException expected) {
}
--
To view, visit https://gwt-review.googlesource.com/2771
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e90cf1442d126efe8d7ec866204f20c5e4cf3e9
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...
Hello Matthew Dempsky, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a rebased change. Please visit https://gwt-review.googlesource.com/2110 to look at the new rebased patch set (#7). Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Adds isStandalone to ImageResource so Image can used an UnclippedState. isStandalone should be true for "data:" URLs and non-inlined images (preventInlining=true or repeatStyle=Both). In other words, it should actually rarely be false (IE6/7). Fixes issue 7403 Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 --- M tools/api-checker/config/gwt25_26userApi.conf M user/src/com/google/gwt/resources/client/ImageResource.java M user/src/com/google/gwt/resources/client/impl/ImageResourcePrototype.java M user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java M user/src/com/google/gwt/user/client/ui/AbstractImagePrototype.java M user/src/com/google/gwt/user/client/ui/Image.java M user/src/com/google/gwt/user/client/ui/ImageResourceRenderer.java M user/test/com/google/gwt/cell/client/ImageResourceCellTest.java M user/test/com/google/gwt/resources/client/ImageResourceTest.java M user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java M user/test/com/google/gwt/user/client/ui/ImageTest.java 11 files changed, 173 insertions(+), 17 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2110 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...
Hello Matthew Dempsky, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2110 to look at the new patch set (#6). Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Adds isStandalone to ImageResource so Image can used an UnclippedState. isStandalone should be true for "data:" URLs and non-inlined images (preventInlining=true or repeatStyle=Both). In other words, it should actually rarely be false (IE6/7). Fixes issue 7403 Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 --- M tools/api-checker/config/gwt25_26userApi.conf M user/src/com/google/gwt/resources/client/ImageResource.java M user/src/com/google/gwt/resources/client/impl/ImageResourcePrototype.java M user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java M user/src/com/google/gwt/user/client/ui/AbstractImagePrototype.java M user/src/com/google/gwt/user/client/ui/Image.java M user/src/com/google/gwt/user/client/ui/ImageResourceRenderer.java M user/test/com/google/gwt/cell/client/ImageResourceCellTest.java M user/test/com/google/gwt/resources/client/ImageResourceTest.java M user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java M user/test/com/google/gwt/user/client/ui/ImageTest.java 11 files changed, 173 insertions(+), 17 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2110 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...
Thomas Broyer has posted comments on this change. Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Patch Set 5: (2 comments) File tools/api-checker/config/gwt25_26userApi.conf Line 45: :com/google/gwt/resources/client/impl/**\ Good question :-) I have absolutely no idea how api_checker works (I already looked at it a couple times but forget everything about it as soon as I stop looking at it) From https://code.google.com/p/google-web-toolkit/wiki/ApiChecker_User_Guide (which we should really all check from time to time: it seems like we didn't follow the process when creating this file), I think we should actually simply list com.google.gwt.resources.client.impl in excludedPackages. excludedFiles are about excluding those files that are not "translatable" to JS by GWT, so it should exclude all rebind or server code, and those classes that have a super-sourced version. I'll make the change. File user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java Line 549: @DoNotRunWith(Platform.HtmlUnitUnknown) Here we're changing Image so that it'll use an UnclippedState when initialized with an ImageResource that isStandalone, whereas previously it would unconditionally use a ClippedState when initialized with an ImageResource (as opposed to a URL). Previously, with the ClippedState, the image would be rendered using innerHTML and its dimensions set within style="" (from ClippedImageImpl); whereas the UnclippedState sets the ImageElement's width and height properties. I confirmed in a small test with ImageElement that getOffsetWidth returns 1256 there even though getWidth returns 56 (the value I had passed to setWidth). This is independent from the image being loaded. I also tried deferring the asserts with Scheduler#scheduleDeferred and it didn't change anything. Using getStyle().setWidth(56, Unit.PX) fixes getOffsetWidth, but now getWidth returns 24 (a hard-coded value). So, should we change UnclippedState to use getStyle().setWidth() or do we simply declare a bug in HTMLUnit and disable the tests? (i.e. what I've done here, but maybe change it Platform.HtmlUnitBug)) -- To view, visit https://gwt-review.googlesource.com/2110 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
