Jens Nehlmeier has posted comments on this change.
Change subject: Introduces generic Composite widgets.
......................................................................
Patch Set 2:
(4 comments)
....................................................
File user/src/com/google/gwt/user/client/ui/Composite.java
Line 127: public T getDelegate() {
protected final instead of public. I dont think a composite wants to leak
out "T".
Line 148: *
Maybe add an example to illustrate the purpose (for new GWT users).
Line 151: * will be delegated (e.g. HasWidget#add)
I am not a native speaker but "the child widget that higher level API calls
(if any) will be delegated (e.g. HasWidget#add) to" sounds better to me.
....................................................
File user/src/com/google/gwt/user/client/ui/FocusComposite.java
Line 52: HasAllMouseHandlers, HasAllGestureHandlers,
HasAllTouchHandlers {
What about the remaining interfaces that FocusWidget implements?
HasDoubleClickHandlers, HasAllDragAndDropHandlers?
--
To view, visit https://gwt-review.googlesource.com/2582
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Jens Nehlmeier <jens.nehlme...@gmail.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@gwtproject.org>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
