Brian Slesinsky has posted comments on this change.
Change subject: Introduces generic Composite widgets.
......................................................................
Patch Set 2:
(2 comments)
....................................................
File user/src/com/google/gwt/user/client/ui/Composite.java
Line 29: * methods. When added to a panel, a composite behaves exactly as
if the widget
This javadoc doesn't seem quite true anymore if widget != delegate.
Line 37: * @param <T> type of the widget wrapped
The way we're using T seems confusing.
Widget getWidget();
T getDelegate();
void setWidget(T);
So I'm wondering whether T is supposed to be the type of the widget, or the
delegate, or both? We should clarify that.
--
To view, visit https://gwt-review.googlesource.com/2582
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@gwtproject.org>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
