[gwt-contrib] Change in gwt[master]: Add support for the newer bindery HandlerRegistration Bug:...
Manuel Carrasco Moñino has posted comments on this change. Change subject: Add support for the newer bindery HandlerRegistration Bug: issue 7079 Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 .. Patch Set 5: Code-Review+1 LGTM -- To view, visit https://gwt-review.googlesource.com/1350 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Removing support for old browsers
On Tuesday, May 28, 2013 8:12:44 PM UTC+2, Goktug Gokdogan wrote: Agreed. I think we need to think about the permutations and soft vs. hard for future releases. We started to have more and more newer vs older separations instead of Browser A ve Browser B separations, especially with the new-ish IEs. Maybe it no longer holds but when I first added support for requestAnimationFrame I used soft permutations instead of a runtime check and it was reverted as it broke projects inside Google: https://code.google.com/p/google-web-toolkit/source/detail?r=9986 (in the end, soft permutations were ditched for other reasons: https://code.google.com/p/google-web-toolkit/source/detail?r=10257, and maybe the build failures were due to a bug in soft perms: https://code.google.com/p/google-web-toolkit/issues/detail?id=7409) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add support for the newer bindery HandlerRegistration Bug:...
Thomas Broyer has posted comments on this change. Change subject: Add support for the newer bindery HandlerRegistration Bug: issue 7079 Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 .. Patch Set 5: Code-Review+2 Julien: would you mind creating the issue about fully supporting com.google.web.bindery.event in UiBinder? -- To view, visit https://gwt-review.googlesource.com/1350 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add support for the newer bindery HandlerRegistration Bug:...
Thomas Broyer has submitted this change and it was merged.
Change subject: Add support for the newer bindery HandlerRegistration
Bug: issue 7079 Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850
..
Add support for the newer bindery HandlerRegistration
Bug: issue 7079
Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850
---
M user/src/com/google/gwt/uibinder/rebind/HandlerEvaluator.java
M user/test/com/google/gwt/uibinder/rebind/HandlerEvaluatorTest.java
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Manuel Carrasco Moñino: Looks good to me, but someone else must approve
Leeroy Jenkins: Verified
Thomas Broyer: Looks good to me, approved
diff --git a/user/src/com/google/gwt/uibinder/rebind/HandlerEvaluator.java
b/user/src/com/google/gwt/uibinder/rebind/HandlerEvaluator.java
index 91a5c5f..cc7bc2c 100644
--- a/user/src/com/google/gwt/uibinder/rebind/HandlerEvaluator.java
+++ b/user/src/com/google/gwt/uibinder/rebind/HandlerEvaluator.java
@@ -23,9 +23,9 @@
import com.google.gwt.core.ext.typeinfo.JType;
import com.google.gwt.core.ext.typeinfo.TypeOracle;
import com.google.gwt.event.shared.EventHandler;
-import com.google.gwt.event.shared.HandlerRegistration;
import com.google.gwt.uibinder.client.UiHandler;
import com.google.gwt.uibinder.rebind.model.OwnerClass;
+import com.google.web.bindery.event.shared.HandlerRegistration;
/**
* This class implements an easy way to bind widget event handlers to
methods
@@ -272,7 +272,8 @@
for (JMethod method : objectType.getInheritableMethods()) {
// Condition 1: returns HandlerRegistration?
- if (method.getReturnType() == handlerRegistrationJClass) {
+ JClassType returnClassType =
method.getReturnType().isClassOrInterface();
+ if (returnClassType != null
handlerRegistrationJClass.isAssignableFrom(returnClassType)) {
// Condition 2: single parameter of the same type of handlerType?
JParameter[] parameters = method.getParameters();
diff --git
a/user/test/com/google/gwt/uibinder/rebind/HandlerEvaluatorTest.java
b/user/test/com/google/gwt/uibinder/rebind/HandlerEvaluatorTest.java
index 98de89b..c4a0b1d 100644
--- a/user/test/com/google/gwt/uibinder/rebind/HandlerEvaluatorTest.java
+++ b/user/test/com/google/gwt/uibinder/rebind/HandlerEvaluatorTest.java
@@ -19,8 +19,8 @@
import com.google.gwt.core.ext.typeinfo.TypeOracle;
import com.google.gwt.dev.util.log.PrintWriterTreeLogger;
import com.google.gwt.event.shared.EventHandler;
-import com.google.gwt.event.shared.HandlerRegistration;
import com.google.gwt.uibinder.rebind.model.OwnerClass;
+import com.google.web.bindery.event.shared.HandlerRegistration;
import junit.framework.TestCase;
--
To view, visit https://gwt-review.googlesource.com/1350
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Julien Dramaix julien.dram...@gmail.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Set KeyboardSelectedRow with relative index in AbstractHasDa...
Thomas Broyer has posted comments on this change. Change subject: Set KeyboardSelectedRow with relative index in AbstractHasData focus event preview .. Patch Set 1: Code-Review+2 Note: can't merge until Jenkins verifies the patch. -- To view, visit https://gwt-review.googlesource.com/3012 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319b10f109914237d1a26ea7e0e401bfab5a691b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Isaiah Billingsley iza.billings...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Added missing lineStart and lineEnd in UiBinder xsd file; is...
Thomas Broyer has posted comments on this change. Change subject: Added missing lineStart and lineEnd in UiBinder xsd file; issue 6596 .. Patch Set 1: Code-Review+2 Note: can't merge until Jenkins verifies the patch. -- To view, visit https://gwt-review.googlesource.com/2977 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d73e13947746bcf92f5312d2913cebe6aea05d5 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Markus Mårtensson markus.martens...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Set KeyboardSelectedRow with relative index in AbstractHasDa...
Thomas Broyer has posted comments on this change. Change subject: Set KeyboardSelectedRow with relative index in AbstractHasData focus event preview .. Patch Set 1: (1 comment) Commit Message Line 9: Change-Id: I319b10f109914237d1a26ea7e0e401bfab5a691b Can you add the following line above that one: Bug: issue 8106 -- To view, visit https://gwt-review.googlesource.com/3012 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319b10f109914237d1a26ea7e0e401bfab5a691b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Isaiah Billingsley iza.billings...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Added missing lineStart and lineEnd in UiBinder xsd file; is...
Thomas Broyer has posted comments on this change. Change subject: Added missing lineStart and lineEnd in UiBinder xsd file; issue 6596 .. Patch Set 1: (1 comment) Commit Message Line 7: Added missing lineStart and lineEnd in UiBinder xsd file; issue 6596 Could you change the commit message to: Added missing lineStart and lineEnd in UiBinder xsd file Bug: issue 6596 Change-Id: I9d73e13947746bcf92f5312d2913cebe6aea05d5 -- To view, visit https://gwt-review.googlesource.com/2977 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d73e13947746bcf92f5312d2913cebe6aea05d5 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Markus Mårtensson markus.martens...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: FileUpload failed to initialize internal state
Hello John A. Tamplin, Leeroy Jenkins, I'd like you to reexamine a rebased change. Please visit https://gwt-review.googlesource.com/2981 to look at the new rebased patch set (#3). Change subject: FileUpload failed to initialize internal state .. FileUpload failed to initialize internal state fixes issue 5055 Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca Review-Link: https://gwt-review.googlesource.com/#/c/2981/ --- M user/src/com/google/gwt/user/client/ui/FileUpload.java 1 file changed, 3 insertions(+), 3 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2981 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix ValuePicker.setValue(T) to no longer fire events.
Thomas Broyer has submitted this change and it was merged.
Change subject: Fix ValuePicker.setValue(T) to no longer fire events.
..
Fix ValuePicker.setValue(T) to no longer fire events.
Bug: issue 7330
Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a
---
M user/src/com/google/gwt/user/client/ui/ValuePicker.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Jens Nehlmeier: Looks good to me, but someone else must approve
Goktug Gokdogan: Looks good to me, approved
diff --git a/user/src/com/google/gwt/user/client/ui/ValuePicker.java
b/user/src/com/google/gwt/user/client/ui/ValuePicker.java
index 45ced21..5914791 100644
--- a/user/src/com/google/gwt/user/client/ui/ValuePicker.java
+++ b/user/src/com/google/gwt/user/client/ui/ValuePicker.java
@@ -64,7 +64,7 @@
cellList.setSelectionModel(smodel);
smodel.addSelectionChangeHandler(new SelectionChangeEvent.Handler() {
public void onSelectionChange(SelectionChangeEvent event) {
-setValue(smodel.getSelectedObject());
+setValue(smodel.getSelectedObject(), true);
}
});
}
@@ -112,7 +112,7 @@
}
public void setValue(T value) {
-setValue(value, true);
+setValue(value, false);
}
public void setValue(T value, boolean fireEvents) {
--
To view, visit https://gwt-review.googlesource.com/2980
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: FileUpload failed to initialize internal state
Thomas Broyer has posted comments on this change. Change subject: FileUpload failed to initialize internal state .. Patch Set 3: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/2981 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: FileUpload failed to initialize internal state
Daniel Kurka has submitted this change and it was merged.
Change subject: FileUpload failed to initialize internal state
..
FileUpload failed to initialize internal state
fixes issue 5055
Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca
Review-Link: https://gwt-review.googlesource.com/#/c/2981/
---
M user/src/com/google/gwt/user/client/ui/FileUpload.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Thomas Broyer: Looks good to me, approved
diff --git a/user/src/com/google/gwt/user/client/ui/FileUpload.java
b/user/src/com/google/gwt/user/client/ui/FileUpload.java
index dd14e84..48f2292 100644
--- a/user/src/com/google/gwt/user/client/ui/FileUpload.java
+++ b/user/src/com/google/gwt/user/client/ui/FileUpload.java
@@ -130,10 +130,8 @@
* Constructs a new file upload widget.
*/
public FileUpload() {
-setElement(Document.get().createFileInputElement());
+this(Document.get().createFileInputElement());
setStyleName(gwt-FileUpload);
-impl = GWT.create(FileUploadImpl.class);
-impl.init(this);
}
/**
@@ -146,6 +144,8 @@
protected FileUpload(Element element) {
assert InputElement.as(element).getType().equalsIgnoreCase(file);
setElement(element);
+impl = GWT.create(FileUploadImpl.class);
+impl.init(this);
}
public HandlerRegistration addChangeHandler(ChangeHandler handler) {
--
To view, visit https://gwt-review.googlesource.com/2981
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: SuggestBox causes native events to fire twice (3533) (issue1785803)
On 2012/09/05 15:44:32, Patrick Tucker wrote: On 2012/07/19 20:48:12, tbroyer wrote: Can this patch be committed? Can you move this patch to gerrit or would you prefer me to do that for you? http://gwt-code-reviews.appspot.com/1785803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element
Andrey Korzhevskiy has uploaded a new change for review.
https://gwt-review.googlesource.com/3070
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Add hasClassName method in com.google.gwt.dom.client.Element
Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
---
M user/src/com/google/gwt/dom/client/Element.java
M user/test/com/google/gwt/dom/client/ElementTest.java
2 files changed, 36 insertions(+), 9 deletions(-)
diff --git a/user/src/com/google/gwt/dom/client/Element.java
b/user/src/com/google/gwt/dom/client/Element.java
index 7d1fd5b..dd0abd5 100644
--- a/user/src/com/google/gwt/dom/client/Element.java
+++ b/user/src/com/google/gwt/dom/client/Element.java
@@ -89,10 +89,7 @@
* @see #setClassName(String)
*/
public final boolean addClassName(String className) {
-assert (className != null) : Unexpectedly null class name;
-
-className = className.trim();
-assert (className.length() != 0) : Unexpectedly empty class name;
+className = checkClassName(className);
// Get the current style string.
String oldClassName = getClassName();
@@ -108,6 +105,18 @@
return true;
}
return false;
+ }
+
+ /**
+ * Checks if this element's class property contains specified class name.
+ *
+ * @param className the class name to be added
+ * @return codetrue/code if this element has the specified class name
+ */
+ public final boolean hasClassName(String className) {
+className = checkClassName(className);
+int idx = indexOfName(getClassName(), className);
+return idx != -1;
}
/**
@@ -524,10 +533,7 @@
* @see #setClassName(String)
*/
public final boolean removeClassName(String className) {
-assert (className != null) : Unexpectedly null class name;
-
-className = className.trim();
-assert (className.length() != 0) : Unexpectedly empty class name;
+className = checkClassName(className);
// Get the current style string.
String oldStyle = getClassName();
@@ -582,6 +588,21 @@
}
/**
+ * Checks if className is valid and trims it.
+ *
+ * @param className a non-empty string
+ * @return trimmed class name string
+ */
+ static String checkClassName(String className) {
+assert (className != null) : Unexpectedly null class name;
+
+className = className.trim();
+assert (className.length() != 0) : Unexpectedly empty class name;
+
+return className;
+ }
+
+ /**
* Replace one class name with another.
*
* @param oldClassName the class name to be replaced
diff --git a/user/test/com/google/gwt/dom/client/ElementTest.java
b/user/test/com/google/gwt/dom/client/ElementTest.java
index a1e6145..b79a784 100644
--- a/user/test/com/google/gwt/dom/client/ElementTest.java
+++ b/user/test/com/google/gwt/dom/client/ElementTest.java
@@ -34,7 +34,7 @@
return com.google.gwt.dom.DOMTest;
}
- public void testAddRemoveReplaceClassName() {
+ public void testAddRemoveReplaceHasClassName() {
DivElement div = Document.get().createDivElement();
div.setClassName(foo);
@@ -64,6 +64,12 @@
assertTrue(div.removeClassName(foo));
assertEquals(, div.getClassName());
+
+div.setClassName(foo bar);
+assertTrue(div.hasClassName(bar));
+assertTrue(div.hasClassName(foo));
+div.removeClassName(foo);
+assertFalse(div.hasClassName(foo));
}
public void testIndexOfName() {
--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element
Goktug Gokdogan has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 2:
(5 comments)
Looks good. Only a few style related comments...
File user/src/com/google/gwt/dom/client/Element.java
Line 595:*/
private static
Line 596: static String checkClassName(String className) {
I think it is better to name this method trimClassName and update the
javadoc accordingly.
Line 600: assert (className.length() != 0) : Unexpectedly empty class
name;
assert !className.isEmpty()
Line 602: return className;
nit: can you remove extra spaces in this method
File user/test/com/google/gwt/dom/client/ElementTest.java
Line 72: assertFalse(div.hasClassName(foo));
Can you also add:
assertTrue(div.hasClassName(bar));
--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element
Andrey Korzhevskiy has uploaded a new change for review.
https://gwt-review.googlesource.com/3071
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Add hasClassName method in com.google.gwt.dom.client.Element
Change-Id: Ibe9a1aacb3530c9c688ab321e64f6dff95eb2b20
---
M user/src/com/google/gwt/dom/client/Element.java
M user/test/com/google/gwt/dom/client/ElementTest.java
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/user/src/com/google/gwt/dom/client/Element.java
b/user/src/com/google/gwt/dom/client/Element.java
index dd0abd5..c9c9592 100644
--- a/user/src/com/google/gwt/dom/client/Element.java
+++ b/user/src/com/google/gwt/dom/client/Element.java
@@ -89,7 +89,7 @@
* @see #setClassName(String)
*/
public final boolean addClassName(String className) {
-className = checkClassName(className);
+className = trimClassName(className);
// Get the current style string.
String oldClassName = getClassName();
@@ -114,7 +114,7 @@
* @return codetrue/code if this element has the specified class name
*/
public final boolean hasClassName(String className) {
-className = checkClassName(className);
+className = trimClassName(className);
int idx = indexOfName(getClassName(), className);
return idx != -1;
}
@@ -533,7 +533,7 @@
* @see #setClassName(String)
*/
public final boolean removeClassName(String className) {
-className = checkClassName(className);
+className = trimClassName(className);
// Get the current style string.
String oldStyle = getClassName();
@@ -588,17 +588,15 @@
}
/**
- * Checks if className is valid and trims it.
+ * Trim class name.
*
* @param className a non-empty string
* @return trimmed class name string
*/
- static String checkClassName(String className) {
+ private static String trimClassName(String className) {
assert (className != null) : Unexpectedly null class name;
-
className = className.trim();
-assert (className.length() != 0) : Unexpectedly empty class name;
-
+assert !className.isEmpty() : Unexpectedly empty class name;
return className;
}
diff --git a/user/test/com/google/gwt/dom/client/ElementTest.java
b/user/test/com/google/gwt/dom/client/ElementTest.java
index b79a784..907f736 100644
--- a/user/test/com/google/gwt/dom/client/ElementTest.java
+++ b/user/test/com/google/gwt/dom/client/ElementTest.java
@@ -70,6 +70,7 @@
assertTrue(div.hasClassName(foo));
div.removeClassName(foo);
assertFalse(div.hasClassName(foo));
+assertTrue(div.hasClassName(bar));
}
public void testIndexOfName() {
--
To view, visit https://gwt-review.googlesource.com/3071
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe9a1aacb3530c9c688ab321e64f6dff95eb2b20
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element
Andrey Korzhevskiy has posted comments on this change. Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Patch Set 2: Sorry, i accidently pushed to a new review https://gwt-review.googlesource.com/3071 Should i do anything about that? -- To view, visit https://gwt-review.googlesource.com/3070 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Revert the automatic selection of sourceLevel.
Roberto Lublinerman has uploaded a new change for review.
https://gwt-review.googlesource.com/3080
Change subject: Revert the automatic selection of sourceLevel.
..
Revert the automatic selection of sourceLevel.
There is a JDT bug (https://bugs.eclipse.org/bugs/show_bug.cgi?id=397462)
that only occurs when sourceLevel 7 that prevents the compilation
of code that is correct.
When that bug is fixed or patched in GWT we can revert.
Change-Id: I20b1e0206763179e6e8abcfe7ad4308487277e1d
---
M dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
b/dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
index b2d5309..bc181a4 100644
--- a/dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
+++ b/dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
@@ -62,6 +62,11 @@
static {
SourceLevel result = SourceLevel.values()[0];
+/* TODO(rluble): source level should be set automatically to match the
java version
+ * but a JDT bug is preventing the change (some correct code does not
compile
+ * under sourceLevel 7).
+ * Uncomment the following code use the JDT is fixed or patched.
+
String javaSpecLevel =
System.getProperty(java.specification.version);
try {
for (SourceLevel sourceLevel : SourceLevel.values()) {
@@ -71,7 +76,7 @@
}
} catch (IllegalArgumentException e) {
}
-
+*/
DEFAULT_SOURCE_LEVEL = result;
}
--
To view, visit https://gwt-review.googlesource.com/3080
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20b1e0206763179e6e8abcfe7ad4308487277e1d
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Revert the automatic selection of sourceLevel.
Roberto Lublinerman has uploaded a new patch set (#2). Change subject: Revert the automatic selection of sourceLevel. .. Revert the automatic selection of sourceLevel. There is a JDT bug (https://bugs.eclipse.org/bugs/show_bug.cgi?id=397462) that only occurs when sourceLevel 7 that prevents the compilation of code that is correct. When that bug is fixed or patched in GWT we can revert. Change-Id: I20b1e0206763179e6e8abcfe7ad4308487277e1d --- M dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java 1 file changed, 6 insertions(+), 3 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3080 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I20b1e0206763179e6e8abcfe7ad4308487277e1d Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element
Goktug Gokdogan has abandoned this change. Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Abandoned -- To view, visit https://gwt-review.googlesource.com/3071 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ibe9a1aacb3530c9c688ab321e64f6dff95eb2b20 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element
Daniel Kurka has posted comments on this change. Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Patch Set 2: You can close off the version you do not want for review -- To view, visit https://gwt-review.googlesource.com/3070 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Revert the automatic selection of sourceLevel.
Goktug Gokdogan has posted comments on this change. Change subject: Revert the automatic selection of sourceLevel. .. Patch Set 2: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3080 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20b1e0206763179e6e8abcfe7ad4308487277e1d Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Revert the automatic selection of sourceLevel.
Brian Slesinsky has posted comments on this change. Change subject: Revert the automatic selection of sourceLevel. .. Patch Set 2: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3080 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20b1e0206763179e6e8abcfe7ad4308487277e1d Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Revert the automatic selection of sourceLevel.
Brian Slesinsky has submitted this change and it was merged.
Change subject: Revert the automatic selection of sourceLevel.
..
Revert the automatic selection of sourceLevel.
There is a JDT bug (https://bugs.eclipse.org/bugs/show_bug.cgi?id=397462)
that only occurs when sourceLevel 7 that prevents the compilation
of code that is correct.
When that bug is fixed or patched in GWT we can revert.
Change-Id: I20b1e0206763179e6e8abcfe7ad4308487277e1d
---
M dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Brian Slesinsky: Looks good to me, approved
Goktug Gokdogan: Looks good to me, approved
diff --git a/dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
b/dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
index b2d5309..be8c8d5 100644
--- a/dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
+++ b/dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
@@ -15,8 +15,6 @@
*/
package com.google.gwt.dev.util.arg;
-import com.google.gwt.util.tools.Utility;
-
/**
* Java source level compatibility constants.
* Java versions range from 1.0 to 1.7.
@@ -62,6 +60,11 @@
static {
SourceLevel result = SourceLevel.values()[0];
+/* TODO(rluble): source level should be set automatically to match the
java version
+ * but a JDT bug is preventing the change (some correct code does not
compile
+ * under sourceLevel 7).
+ * Uncomment the following code use the JDT is fixed or patched.
+
String javaSpecLevel =
System.getProperty(java.specification.version);
try {
for (SourceLevel sourceLevel : SourceLevel.values()) {
@@ -71,7 +74,7 @@
}
} catch (IllegalArgumentException e) {
}
-
+*/
DEFAULT_SOURCE_LEVEL = result;
}
--
To view, visit https://gwt-review.googlesource.com/3080
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20b1e0206763179e6e8abcfe7ad4308487277e1d
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element
Andrey Korzhevskiy has uploaded a new patch set (#3). Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Add hasClassName method in com.google.gwt.dom.client.Element Fixes issue 7550 Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c --- M user/src/com/google/gwt/dom/client/Element.java M user/test/com/google/gwt/dom/client/ElementTest.java 2 files changed, 35 insertions(+), 9 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3070 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Unary plus in Jsni code was always discarded.
Roberto Lublinerman has posted comments on this change. Change subject: Unary plus in Jsni code was always discarded. .. Patch Set 2: It seems to have been rolled back with quite a few other changes (from r5961 back to r5956). It does seem correct and I performed an extensive test and did not break anything. -- To view, visit https://gwt-review.googlesource.com/2990 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d260d7fdc08b942f44b0275fb1c842be1c807fd Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element
Goktug Gokdogan has posted comments on this change. Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Patch Set 3: Code-Review+1 (1 comment) LGTM. Let's wait for tomorrow before +2 so other can provide feedback if they have any. Thanks for the patch! File user/src/com/google/gwt/dom/client/Element.java Line 595:*/ Actually you can remove the javadoc as it doesn't add anything in this case. -- To view, visit https://gwt-review.googlesource.com/3070 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Unary plus in Jsni code was always discarded.
Ray Cromwell has posted comments on this change. Change subject: Unary plus in Jsni code was always discarded. .. Patch Set 2: Code-Review+2 Likely there was a global submit failure somewhere and all of the CLs between the last green build and the failure were rolled back. Wonder how many of these slipped through the cracks. -- To view, visit https://gwt-review.googlesource.com/2990 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d260d7fdc08b942f44b0275fb1c842be1c807fd Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element
Colin Alworth has posted comments on this change. Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Patch Set 3: Code-Review-1 As an idea, looks good, but remember that JSOs are a particularly bad place to add new arbitrary methods, especially mid-release (i.e. consider 3.0). Any downstream code that extends Element and has a method with the same signature is going to break. As an example (admittedly, one that I am biased toward), GXT has a Element subclass class that supports this very same method signature, hasClassName(String). Adding final methods to non-final classes in general must be done carefully - since in a JSO either all methods must be final or the type itself must be final, all new methods should be carefully scrutinized. My vote would be that this would be implemented in a different way to not require new methods, at least for 2.x - breaking changes with downstream code isn't generally expected in minor releases (though that hasn't stopped us in the past, see JClassType about 2.2.0). The 3.0 release might be a better target for the patch as-is. -- To view, visit https://gwt-review.googlesource.com/3070 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Stephen Haberman has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 4: Interesting, thanks, Roberto, I never would have thought of/found the typeMarker issue. I'll use what you've got and see what happens. -- To view, visit https://gwt-review.googlesource.com/3030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Unary plus in Jsni code was always discarded.
Roberto Lublinerman has submitted this change and it was merged.
Change subject: Unary plus in Jsni code was always discarded.
..
Unary plus in Jsni code was always discarded.
Unary plus in JavaScript is only noop when applied to a
numeric value otherwise it behaves as a conversion to double
operator. The compiler incorrectly assumed that is was a noop
in all cases.
The fix was already made in r5960 by cromwellian but was lost
in a subsequent rollback (r5961).
Fixes issue 6373 and issue 3942.
Change-Id: I4d260d7fdc08b942f44b0275fb1c842be1c807fd
---
M dev/core/src/com/google/gwt/dev/js/JsParser.java
M dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
M
dev/core/test/com/google/gwt/dev/js/JsToStringGenerationVisitorAccuracyTest.java
M user/test/com/google/gwt/dev/jjs/CompilerSuite.java
A user/test/com/google/gwt/dev/jjs/test/CompilerMiscRegressionTest.java
5 files changed, 82 insertions(+), 13 deletions(-)
Approvals:
Ray Cromwell: Looks good to me, approved
Leeroy Jenkins: Verified
diff --git a/dev/core/src/com/google/gwt/dev/js/JsParser.java
b/dev/core/src/com/google/gwt/dev/js/JsParser.java
index 2a7b218..a4e35dd 100644
--- a/dev/core/src/com/google/gwt/dev/js/JsParser.java
+++ b/dev/core/src/com/google/gwt/dev/js/JsParser.java
@@ -1,12 +1,12 @@
/*
* Copyright 2008 Google Inc.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the License); you may
not
* use this file except in compliance with the License. You may obtain a
copy of
* the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
@@ -1204,8 +1204,13 @@
return mapPrefixOperation(JsUnaryOperator.TYPEOF, unOp);
case TokenStream.ADD:
-// Pretend we didn't see it.
-return mapExpression(unOp.getFirstChild());
+if (unOp.getFirstChild().getType() != TokenStream.NUMBER) {
+ return mapPrefixOperation(JsUnaryOperator.POS, unOp);
+} else {
+ // Pretend we didn't see it.
+ return mapExpression(unOp.getFirstChild());
+}
+
case TokenStream.VOID:
return mapPrefixOperation(JsUnaryOperator.VOID, unOp);
diff --git
a/dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
b/dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
index ed1f569..55fab01 100644
--- a/dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
+++ b/dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java
@@ -1,12 +1,12 @@
/*
* Copyright 2008 Google Inc.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the License); you may
not
* use this file except in compliance with the License. You may obtain a
copy of
* the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
@@ -1340,7 +1340,7 @@
/**
* Decide whether, if codeop/code is printed followed by
codearg/code,
* there needs to be a space between the operator and expression.
- *
+ *
* @return codetrue/code if a space needs to be printed
*/
private boolean _spaceCalc(JsOperator op, JsExpression arg) {
@@ -1362,7 +1362,8 @@
JsOperator op2 = ((JsPrefixOperation) arg).getOperator();
return (op == JsBinaryOperator.SUB || op == JsUnaryOperator.NEG)
(op2 == JsUnaryOperator.DEC || op2 == JsUnaryOperator.NEG)
- || (op == JsBinaryOperator.ADD op2 == JsUnaryOperator.INC);
+ || (op == JsBinaryOperator.ADD || op == JsUnaryOperator.POS)
+ (op2 == JsUnaryOperator.INC || op2 == JsUnaryOperator.POS);
}
if (arg instanceof JsNumberLiteral) {
JsNumberLiteral literal = (JsNumberLiteral) arg;
diff --git
a/dev/core/test/com/google/gwt/dev/js/JsToStringGenerationVisitorAccuracyTest.java
b/dev/core/test/com/google/gwt/dev/js/JsToStringGenerationVisitorAccuracyTest.java
index 5a99ddd..117ead1 100644
---
a/dev/core/test/com/google/gwt/dev/js/JsToStringGenerationVisitorAccuracyTest.java
+++
b/dev/core/test/com/google/gwt/dev/js/JsToStringGenerationVisitorAccuracyTest.java
@@ -140,6 +140,12 @@
doTest(var x = +y, var x = +y);
// + prefix stripped when operand is literal number
doTest(var x = +42, var x = 42);
+// + prefix not stripped when operand is not literal number
+doTest(var x = +y, var x = +y);
+// + prefix stripped when operand is literal number
+doTest(var x = +42,var x = 42);
+// + blank + should not become ++
+doTest(var x =
[gwt-contrib] Change in gwt[master]: Inliner produces incorrect code if a parameter is a new arra...
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3040 to look at the new patch set (#2). Change subject: Inliner produces incorrect code if a parameter is a new array expression. .. Inliner produces incorrect code if a parameter is a new array expression. The inliner incorrectly inlines a call when a parameter is a new array expression resulting in the new array contruct beign duplicated if more that one reference to such parameter is present. Fixes issue 6638. Change-Id: Ic083ac15d7d84ab4728c441fd590977cd684a87a --- M dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java M dev/core/test/com/google/gwt/dev/jjs/impl/ExpressionAnalyzerTest.java M user/test/com/google/gwt/dev/jjs/test/CompilerMiscRegressionTest.java 3 files changed, 27 insertions(+), 0 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3040 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic083ac15d7d84ab4728c441fd590977cd684a87a Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Hello Ray Cromwell, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3030 to look at the new patch set (#5). Change subject: Fix non-final field initializers running before the super cstr. .. Fix non-final field initializers running before the super cstr. Previously, any field with an initializer would get assigned at the top-level scope, before any cstrs had run. However, this does not match the JVM behavior, which is that final fields behave this way, but non-field fields have their type's default value assigned when super cstrs run, and then only later in their cstr are assigned to the initializer. Bug: issue 380 Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 --- M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java M user/test/com/google/gwt/dev/jjs/test/CompilerTest.java A user/test/com/google/gwt/dev/jjs/test/FieldInitOrderBase.java A user/test/com/google/gwt/dev/jjs/test/FieldInitOrderChild.java 4 files changed, 76 insertions(+), 10 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Hello Ray Cromwell, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3030 to look at the new patch set (#7). Change subject: Fix non-final field initializers running before the super cstr. .. Fix non-final field initializers running before the super cstr. Previously, any field with an initializer would get assigned at the top-level scope, before any cstrs had run. However, this does not match the JVM behavior, which is that final fields behave this way, but non-field fields have their type's default value assigned when super cstrs run, and then only later in their cstr are assigned to the initializer. Bug: issue 380 Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 --- M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java M user/test/com/google/gwt/dev/jjs/test/CompilerTest.java A user/test/com/google/gwt/dev/jjs/test/FieldInitOrderBase.java A user/test/com/google/gwt/dev/jjs/test/FieldInitOrderChild.java 4 files changed, 83 insertions(+), 10 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Hello Ray Cromwell, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3030 to look at the new patch set (#8). Change subject: Fix non-final field initializers running before the super cstr. .. Fix non-final field initializers running before the super cstr. Previously, any field with an initializer would get assigned at the top-level scope, before any cstrs had run. However, this does not match the JVM behavior, which is that final fields behave this way, but non-field fields have their type's default value assigned when super cstrs run, and then only later in their cstr are assigned to the initializer. Bug: issue 380 Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 --- M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java M user/test/com/google/gwt/dev/jjs/test/CompilerTest.java A user/test/com/google/gwt/dev/jjs/test/FieldInitOrderBase.java A user/test/com/google/gwt/dev/jjs/test/FieldInitOrderChild.java 4 files changed, 113 insertions(+), 10 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Stephen Haberman has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 8: Okay, I believe this is correct now. CompilerTest all passes. I had not been handling static fields correctly (or basically at all), which is likely why typeMarker was broken. A summary of the change is that, previously, any field with a literal initializer was set eagerly at top-scope. However, per the JVM semantics, only static or final fields should be treated this way. Non-final/non-static fields with literal initializers should (just like fields with non-literal initializers) be set with the type's default at top-scope, and then only later have their initializer assigned in their class's cstr. -- To view, visit https://gwt-review.googlesource.com/3030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
