Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
Danny Milosavljevic writes: > Hi ng0, > > On Sun, 5 Mar 2017 14:50:26 + > ng0 wrote: > >> What I take from the discussion is, all is good to go except for >> subsystems. I'm okay with reviewing subsystems as an individual patch >> later on. For me this works. Push the 3 patches, and send the subsystems >> one later as a new discussion-bug. > > The 3 were pushed to master. > > Patch 4 not yet. So let's discuss. > > I have no preference for pairs or lists - it's just that the documentation > should say what it actually expects - because the user has to write the form > differently: > > Pair: '(a . b) > > List: '(a b) > > Those are not compatible with each other. > > (I think as the patch is written now it expects lists) > > And I'm against calling pairs "two-element tuple"s. It reminds me of these > math joke equations which write the value 2 in a really complicated way (but > correctly) :) > > And lists are definitely not two-element tuples. That would be seriously > confusing. > > What do you think? Hi Danny, I forgot to thank you for this explanation of pairs and lists. I took it into account here: http://lists.gnu.org/archive/html/guix-patches/2017-03/msg00610.html. Clément
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
Hi Ludovic, Ludovic Courtès writes: > Hi Clément, > > Clément Lassieur skribis: > >> I think there is a misunderstanding. I didn't want to push this because >> it was not tested, and because subsystems are often useless without >> Match, and Match is unsupported. The pair/list thing is not the >> problem. >> >> And I was waiting for ng0 to test, because he asked for this patch (see >> http://lists.gnu.org/archive/html/guix-devel/2017-02/msg00906.html), so >> I thought he was able to test. >> >> If ng0 still needs the patch and confirms that it works well, I'm >> willing to update it. Otherwise, let's drop it. > > The patch looks like a useful addition. It would be sad to drop it, no? > > If you could add a test to (gnu tests ssh) that would be perfect, but > otherwise it LGTM. Perhaps the default value for ‘subsystems’ should > include internal-sftp though, as users probably expect sftp to just work. Yes, you are right. I changed my mind :) And the other distributions I've seen have SFTP enabled as well. So I updated the service, and I did a test: http://lists.gnu.org/archive/html/guix-patches/2017-03/msg00546.html. > I don’t have any issue with using two-element lists; I think the syntax > for pairs can be a bit confusing for newcomers to it’s probably better > to avoid it in service configuration. Ok, I used two-element lists then. Clément
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
2017-03-18 12:45 GMT+01:00 Mathieu Lirzin : > ng0 writes: > > > John Darrington transcribed 2.0K bytes: > > > >> I am glad that at least one person can express a point of view and be > polite about > >> it at the same time. If you think it is fine, then it is your right > to use it. > >> > >> I find it confusing and clunky in most cases, and I refuse to use it. > I also > >> reserve the right, when others advocate its use, to present my own > point of view. > >> > >> If anyone chooses to interpret that as rude, sexist, intolerant or > whatever - then > >> that is their problem and not mine. They will have to get over it. > > > > Okay, so you are just one of those ignorant assholes who drive people > > away from projects because they think their are the middle of the > > universe and other problems don't exist because they have never > > experienced them and oh deity forbid if someone insults their holy > > grammarbooks and linguists. Cool. Glad that we have solved that. > > > > That's actually the first time that I'm not polite. But I can't be > > polite to ignorant people. I just won't work with you anymore and ignore > > you, as you choose to ignore other people with your behavior and > > invalidate their existence and bother them with your view of what's > > "correct" and what's not. > > This reaction is highly intolerant and not acceptable in this community. > Disagreeing doesn't justify being rude or insulting people. > I wholeheartedly disagree ng0's reaction is legitimate and due. ng0 is being shown hostility. I don't see why hostility is legitimate when one side expresses it but it's not legitimate anymore when a reaction comes. I don't see why John should be allowed to say "I will raise this and if anyone feels hit they will have to deal with it" and people's reaction to this wold be not acceptable. The result of ng0's reaction to be deemed unacceptable would be that a transgender person raising the issue of gendered pronouns would be dealt with a shrug and their reaction would be dealt with... what ? I find your remark not only ridiculous. I find it discriminating.
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
2017-03-18 13:10 GMT+01:00 John Darrington : > On Sat, Mar 18, 2017 at 11:52:16AM +, ng0 wrote: > > May I remind you that the first reaction of John is being rude to > anyone > who isn't a native speaker? > > That is absolutely not true. I have reviewed this current thread and I do > not > see any instance of rudeness on my part. > > As I have explained *most* people appreciate it when offerred corrections > - be > it code, language or whatever. I certainly appreciate corrections of my > mistakes, Do you ? You are fiercely fighting a correction that has been offered to you by ng0 and by mantainers too. Corrections are not about linguistics or programming langages only. There are community (people) issues too. and on occassion people have taken the time to thank me for the time > I take to correct theirs. Well, this is not the case, is it ? > That is what collaboration is about. You have > explicitly asked me not to correct you - and I respect that request - I > will not > do so in future. However, if I see you giving erroneous advice to a third > party > I may interject with my own opinion. > In so doing, you would be actively assaulting a member of this community. > > I'm sorry that you feel this way. No, you're not > I would still like to work with you - and > that means I appreciate constructive criticism from anyone, about anything. > Plenty of constructive critism iis being offered, here, and you seem to be belligerent against it On the only basis that the criticism is not about language. > > For example, we don't often speak German in Guix, but if we were to do so, > I would be very grateful to you, as a native German speaker, if you would > correct > me when I make a grammatical mistake. > Well, other people is not being grateful, here
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
On Sat, Mar 18, 2017 at 11:52:16AM +, ng0 wrote: May I remind you that the first reaction of John is being rude to anyone who isn't a native speaker? That is absolutely not true. I have reviewed this current thread and I do not see any instance of rudeness on my part. As I have explained *most* people appreciate it when offerred corrections - be it code, language or whatever. I certainly appreciate corrections of my mistakes, and on occassion people have taken the time to thank me for the time I take to correct theirs. That is what collaboration is about. You have explicitly asked me not to correct you - and I respect that request - I will not do so in future. However, if I see you giving erroneous advice to a third party I may interject with my own opinion. I'm sorry that you feel this way. I would still like to work with you - and that means I appreciate constructive criticism from anyone, about anything. For example, we don't often speak German in Guix, but if we were to do so, I would be very grateful to you, as a native German speaker, if you would correct me when I make a grammatical mistake. Regards, John -- Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. signature.asc Description: Digital signature
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
Mathieu Lirzin transcribed 1.4K bytes: > ng0 writes: > > > John Darrington transcribed 2.0K bytes: > > > >> I am glad that at least one person can express a point of view and be > >> polite about > >> it at the same time. If you think it is fine, then it is your right to > >> use it. > >> > >> I find it confusing and clunky in most cases, and I refuse to use it.I > >> also > >> reserve the right, when others advocate its use, to present my own point > >> of view. > >> > >> If anyone chooses to interpret that as rude, sexist, intolerant or > >> whatever - then > >> that is their problem and not mine. They will have to get over it. > > > > Okay, so you are just one of those ignorant assholes who drive people > > away from projects because they think their are the middle of the > > universe and other problems don't exist because they have never > > experienced them and oh deity forbid if someone insults their holy > > grammarbooks and linguists. Cool. Glad that we have solved that. > > > > That's actually the first time that I'm not polite. But I can't be > > polite to ignorant people. I just won't work with you anymore and ignore > > you, as you choose to ignore other people with your behavior and > > invalidate their existence and bother them with your view of what's > > "correct" and what's not. > > This reaction is highly intolerant and not acceptable in this community. > Disagreeing doesn't justify being rude or insulting people. > > -- > Mathieu Lirzin > GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37 > May I remind you that the first reaction of John is being rude to anyone who isn't a native speaker? Yes, my reply was rude and insulting, but if you feel like supporting someone in that behavior in the first place (which is disrespectful towards any newcomers who are not fluent in english and additionally, not including, towards those who are not binary) then this is indeed the wrong community. I don't see repetition of John's behavior as solving the problem. It's not just in Email. It happens on IRC too. I doubt that inclusion of such behavior is according to the Code of Conduct. If it is, please tell me so that I have social reasons to fork Guix.
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
ng0 writes: > John Darrington transcribed 2.0K bytes: > >> I am glad that at least one person can express a point of view and be >> polite about >> it at the same time. If you think it is fine, then it is your right to use >> it. >> >> I find it confusing and clunky in most cases, and I refuse to use it.I >> also >> reserve the right, when others advocate its use, to present my own point of >> view. >> >> If anyone chooses to interpret that as rude, sexist, intolerant or >> whatever - then >> that is their problem and not mine. They will have to get over it. > > Okay, so you are just one of those ignorant assholes who drive people > away from projects because they think their are the middle of the > universe and other problems don't exist because they have never > experienced them and oh deity forbid if someone insults their holy > grammarbooks and linguists. Cool. Glad that we have solved that. > > That's actually the first time that I'm not polite. But I can't be > polite to ignorant people. I just won't work with you anymore and ignore > you, as you choose to ignore other people with your behavior and > invalidate their existence and bother them with your view of what's > "correct" and what's not. This reaction is highly intolerant and not acceptable in this community. Disagreeing doesn't justify being rude or insulting people. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
John Darrington transcribed 2.0K bytes: > On Fri, Mar 17, 2017 at 12:21:31PM -0400, Leo Famulari wrote: > On Fri, Mar 17, 2017 at 06:36:20AM +0100, John Darrington wrote: > > On Thu, Mar 16, 2017 at 08:45:27PM +, ng0 wrote: > > > > ps Cl??ment: 'them'/'they' are pronouns if you don't know the > gender and/or > > prefered pronoun of a person :) > > > > > > ... according to some. - but most linguists, and many orators (the > president of > > the Free Software Foundation being one of them) consider this to be a > misuse of > > the English language and refuse to (mis)use these words for such a > purpose. > > As a native USA English speaker, I think this usage is fine, and widely > accepted by speakers, at least in this country. There are some cases > where it sounds a little clunky, but we don't have other words for this > use case that enjoy wider common usage. > > I am glad that at least one person can express a point of view and be polite > about > it at the same time. If you think it is fine, then it is your right to use > it. > > I find it confusing and clunky in most cases, and I refuse to use it.I > also > reserve the right, when others advocate its use, to present my own point of > view. > > If anyone chooses to interpret that as rude, sexist, intolerant or whatever > - then > that is their problem and not mine. They will have to get over it. Okay, so you are just one of those ignorant assholes who drive people away from projects because they think their are the middle of the universe and other problems don't exist because they have never experienced them and oh deity forbid if someone insults their holy grammarbooks and linguists. Cool. Glad that we have solved that. That's actually the first time that I'm not polite. But I can't be polite to ignorant people. I just won't work with you anymore and ignore you, as you choose to ignore other people with your behavior and invalidate their existence and bother them with your view of what's "correct" and what's not. Have a nice life. > J' > > > > -- > Avoid eavesdropping. Send strong encrypted email. > PGP Public key ID: 1024D/2DE827B3 > fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 > See http://sks-keyservers.net or any PGP keyserver for public key.
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
On Fri, Mar 17, 2017 at 12:21:31PM -0400, Leo Famulari wrote: On Fri, Mar 17, 2017 at 06:36:20AM +0100, John Darrington wrote: > On Thu, Mar 16, 2017 at 08:45:27PM +, ng0 wrote: > > ps Cl??ment: 'them'/'they' are pronouns if you don't know the gender and/or > prefered pronoun of a person :) > > > ... according to some. - but most linguists, and many orators (the president of > the Free Software Foundation being one of them) consider this to be a misuse of > the English language and refuse to (mis)use these words for such a purpose. As a native USA English speaker, I think this usage is fine, and widely accepted by speakers, at least in this country. There are some cases where it sounds a little clunky, but we don't have other words for this use case that enjoy wider common usage. I am glad that at least one person can express a point of view and be polite about it at the same time. If you think it is fine, then it is your right to use it. I find it confusing and clunky in most cases, and I refuse to use it.I also reserve the right, when others advocate its use, to present my own point of view. If anyone chooses to interpret that as rude, sexist, intolerant or whatever - then that is their problem and not mine. They will have to get over it. J' -- Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. signature.asc Description: Digital signature
Re: grammar usage (was: Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.)
On Fri, Mar 17, 2017 at 05:13:49PM +0100, Tobias Geerinckx-Rice wrote: No. John, I find you very rude in this thread. Please stop dismissing as ???reproachful, judgemental, censorious, or sanctimonious??? anyone who dares correct your unsolicited incorrections. Yelling ???DON'T BRING IT UP??? when they address your behaviour isn't helping your case either. I would point out that I did not raise this issue. I have taken great pains to avoid rudeness in this thread. Suggesting that a person does not raise a topic, orthogonal to guix, if it is likely to produce a response that annoys him/her is entirely appropriate. > but most linguists, and many orators (the president of the Free > Software Foundation being one of them) consider this to be a misuse > of the English language and refuse to (mis)use these words for such > a purpose. They then promptly, disingenuously, linguistically, and politically misuse English in order to thrust masculinity upon people against their will, or by default. So most linguists do that do they? If you have evidence to back this up, then please present it. If you cannot, the be aware there are terms for people who display intolerant or prejudical attitudes such as this in the absence of supporting evidence. J' -- Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. signature.asc Description: Digital signature
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
On Fri, Mar 17, 2017 at 06:36:20AM +0100, John Darrington wrote: > On Thu, Mar 16, 2017 at 08:45:27PM +, ng0 wrote: > > ps Cl??ment: 'them'/'they' are pronouns if you don't know the gender > and/or > prefered pronoun of a person :) > > > ... according to some. - but most linguists, and many orators (the president > of > the Free Software Foundation being one of them) consider this to be a misuse > of > the English language and refuse to (mis)use these words for such a purpose. As a native USA English speaker, I think this usage is fine, and widely accepted by speakers, at least in this country. There are some cases where it sounds a little clunky, but we don't have other words for this use case that enjoy wider common usage. signature.asc Description: PGP signature
Re: grammar usage (was: Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.)
No. John, I find you very rude in this thread. Please stop dismissing as ‘reproachful, judgemental, censorious, or sanctimonious’ anyone who dares correct your unsolicited incorrections. Yelling ‘DON'T BRING IT UP’ when they address your behaviour isn't helping your case either. Everyone's allowing themselves one sneaky reply. Here's mine. On 17/03/17 06:36, John Darrington wrote: > ... according to some. According to the vast majority of contemporary English speakers. This is not a matter of opinion. ‘They’ has been in common use as a gender-neutral singular pronoun for centuries. The (pseudo-)linguistic case against it remains as unconvincing today as it was then. > but most linguists, and many orators (the president of the Free > Software Foundation being one of them) consider this to be a misuse > of the English language and refuse to (mis)use these words for such > a purpose. They then promptly, disingenuously, linguistically, and politically misuse English in order to thrust masculinity upon people against their will, or by default. I find the whole ruse tiringly transparent. Kind regards, T(hey, btw) G-R signature.asc Description: OpenPGP digital signature
Re: grammar usage (was: Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.)
On Fri, Mar 17, 2017 at 10:42:10AM +, ng0 wrote: Respecting people is more important than correct grammar. I agree. So please afford me a little respect. My choice of pronoun for myself is they/them. I'm not picking strawman arguments here, all I wanted to express is that it is impolite and disrespectful against everybody to keep correcting them. Did you notice that this last sentence of yours is correcting an assertion of mine? J' -- Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. signature.asc Description: Digital signature
Re: grammar usage (was: Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.)
John Darrington transcribed 2.9K bytes: > On Fri, Mar 17, 2017 at 11:08:04AM +, ng0 wrote: > John Darrington transcribed 1.1K bytes: > > On Thu, Mar 16, 2017 at 08:45:27PM +, ng0 wrote: > > > > ps Cl??ment: 'them'/'they' are pronouns if you don't know the > gender and/or > > prefered pronoun of a person :) > > > > > > ... according to some. - but most linguists, and many orators (the > president of > > the Free Software Foundation being one of them) consider this to be a > misuse of > > the English language and refuse to (mis)use these words for such a > purpose. > > > > J' > > > > > > -- > > Avoid eavesdropping. Send strong encrypted email. > > PGP Public key ID: 1024D/2DE827B3 > > fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 > > See http://sks-keyservers.net or any PGP keyserver for public key. > > > > You keep mentioning this every time it comes up. It's annoying, really. > Linguists aren't the central authority of a language. > > 1. Yes. I have mentioned it several times when the subject has been brought > up, > and I see no reason why I shouldn't do so the next time it is brought up. > > 2. If you find it annoying then - DON'T BRING IT UP. > > > 3. You are right that linguists are not an authority - I never claimed that > so please don't make a strawman out of that. > > If it's bothering you that much, this is on topic as it is in the > documentation of Guix, and there are several ways to express gender > neutral pronouns in some languages. > > 4. So when using those languages I will be all in favour of people using > the correct word for that language. > > "According to linguists" what a > larger group of people in Germany uses is also a misuse of the language. > Do they care? No. > > 5. That is unfortunate. As a resident in Germany whose first language is > not German, sometimes I make mistakes when speaking German. When I do - and > when people take the time to correct me - then I am always grateful to them. > Conversly, I often correct Germans who make mistakes in their English. Most > appreciate the help - some, like you say, don't care. But guess what: Das ist > mir Scheissegal! > > J' > > > -- > Avoid eavesdropping. Send strong encrypted email. > PGP Public key ID: 1024D/2DE827B3 > fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 > See http://sks-keyservers.net or any PGP keyserver for public key. > Respecting people is more important than correct grammar. My choice of pronoun for myself is they/them. I'm not picking strawman arguments here, all I wanted to express is that it is impolite and disrespectful against everybody to keep correcting them. Especially if english is your native language.
Re: grammar usage (was: Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.)
On Fri, Mar 17, 2017 at 11:08:04AM +, ng0 wrote: John Darrington transcribed 1.1K bytes: > On Thu, Mar 16, 2017 at 08:45:27PM +, ng0 wrote: > > ps Cl??ment: 'them'/'they' are pronouns if you don't know the gender and/or > prefered pronoun of a person :) > > > ... according to some. - but most linguists, and many orators (the president of > the Free Software Foundation being one of them) consider this to be a misuse of > the English language and refuse to (mis)use these words for such a purpose. > > J' > > > -- > Avoid eavesdropping. Send strong encrypted email. > PGP Public key ID: 1024D/2DE827B3 > fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 > See http://sks-keyservers.net or any PGP keyserver for public key. > You keep mentioning this every time it comes up. It's annoying, really. Linguists aren't the central authority of a language. 1. Yes. I have mentioned it several times when the subject has been brought up, and I see no reason why I shouldn't do so the next time it is brought up. 2. If you find it annoying then - DON'T BRING IT UP. 3. You are right that linguists are not an authority - I never claimed that so please don't make a strawman out of that. If it's bothering you that much, this is on topic as it is in the documentation of Guix, and there are several ways to express gender neutral pronouns in some languages. 4. So when using those languages I will be all in favour of people using the correct word for that language. "According to linguists" what a larger group of people in Germany uses is also a misuse of the language. Do they care? No. 5. That is unfortunate. As a resident in Germany whose first language is not German, sometimes I make mistakes when speaking German. When I do - and when people take the time to correct me - then I am always grateful to them. Conversly, I often correct Germans who make mistakes in their English. Most appreciate the help - some, like you say, don't care. But guess what: Das ist mir Scheissegal! J' -- Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. signature.asc Description: Digital signature
grammar usage (was: Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.)
John Darrington transcribed 1.1K bytes: > On Thu, Mar 16, 2017 at 08:45:27PM +, ng0 wrote: > > ps Cl??ment: 'them'/'they' are pronouns if you don't know the gender > and/or > prefered pronoun of a person :) > > > ... according to some. - but most linguists, and many orators (the president > of > the Free Software Foundation being one of them) consider this to be a misuse > of > the English language and refuse to (mis)use these words for such a purpose. > > J' > > > -- > Avoid eavesdropping. Send strong encrypted email. > PGP Public key ID: 1024D/2DE827B3 > fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 > See http://sks-keyservers.net or any PGP keyserver for public key. > You keep mentioning this every time it comes up. It's annoying, really. Linguists aren't the central authority of a language. If it's bothering you that much, this is on topic as it is in the documentation of Guix, and there are several ways to express gender neutral pronouns in some languages. "According to linguists" what a larger group of people in Germany uses is also a misuse of the language. Do they care? No.
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
On Thu, Mar 16, 2017 at 08:45:27PM +, ng0 wrote: ps Cl??ment: 'them'/'they' are pronouns if you don't know the gender and/or prefered pronoun of a person :) ... according to some. - but most linguists, and many orators (the president of the Free Software Foundation being one of them) consider this to be a misuse of the English language and refuse to (mis)use these words for such a purpose. J' -- Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. signature.asc Description: Digital signature
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
ng0 writes: > Ludovic Courtès transcribed 1.1K bytes: >> Hi Clément, >> >> Clément Lassieur skribis: >> >> > I think there is a misunderstanding. I didn't want to push this because >> > it was not tested, and because subsystems are often useless without >> > Match, and Match is unsupported. The pair/list thing is not the >> > problem. >> > >> > And I was waiting for ng0 to test, because he asked for this patch (see >> > http://lists.gnu.org/archive/html/guix-devel/2017-02/msg00906.html), so >> > I thought he was able to test. >> > >> > If ng0 still needs the patch and confirms that it works well, I'm >> > willing to update it. Otherwise, let's drop it. >> >> The patch looks like a useful addition. It would be sad to drop it, no? >> >> If you could add a test to (gnu tests ssh) that would be perfect, but >> otherwise it LGTM. Perhaps the default value for ‘subsystems’ should >> include internal-sftp though, as users probably expect sftp to just work. >> >> I don’t have any issue with using two-element lists; I think the syntax >> for pairs can be a bit confusing for newcomers to it’s probably better >> to avoid it in service configuration. >> >> Thanks, >> Ludo’. >> > > I'm taking a break currently and only deal with planing things or > documenting work and future Guix related work, so I won't test this in > the next 1 or 2 weeks. > I am fairly sure that sshfs still needs this. > > ps Clément: 'them'/'they' are pronouns if you don't know the gender and/or > prefered pronoun of a person :) Oh, I apologize.
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
Ludovic Courtès transcribed 1.1K bytes: > Hi Clément, > > Clément Lassieur skribis: > > > I think there is a misunderstanding. I didn't want to push this because > > it was not tested, and because subsystems are often useless without > > Match, and Match is unsupported. The pair/list thing is not the > > problem. > > > > And I was waiting for ng0 to test, because he asked for this patch (see > > http://lists.gnu.org/archive/html/guix-devel/2017-02/msg00906.html), so > > I thought he was able to test. > > > > If ng0 still needs the patch and confirms that it works well, I'm > > willing to update it. Otherwise, let's drop it. > > The patch looks like a useful addition. It would be sad to drop it, no? > > If you could add a test to (gnu tests ssh) that would be perfect, but > otherwise it LGTM. Perhaps the default value for ‘subsystems’ should > include internal-sftp though, as users probably expect sftp to just work. > > I don’t have any issue with using two-element lists; I think the syntax > for pairs can be a bit confusing for newcomers to it’s probably better > to avoid it in service configuration. > > Thanks, > Ludo’. > I'm taking a break currently and only deal with planing things or documenting work and future Guix related work, so I won't test this in the next 1 or 2 weeks. I am fairly sure that sshfs still needs this. ps Clément: 'them'/'they' are pronouns if you don't know the gender and/or prefered pronoun of a person :)
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
Hi Clément, Clément Lassieur skribis: > I think there is a misunderstanding. I didn't want to push this because > it was not tested, and because subsystems are often useless without > Match, and Match is unsupported. The pair/list thing is not the > problem. > > And I was waiting for ng0 to test, because he asked for this patch (see > http://lists.gnu.org/archive/html/guix-devel/2017-02/msg00906.html), so > I thought he was able to test. > > If ng0 still needs the patch and confirms that it works well, I'm > willing to update it. Otherwise, let's drop it. The patch looks like a useful addition. It would be sad to drop it, no? If you could add a test to (gnu tests ssh) that would be perfect, but otherwise it LGTM. Perhaps the default value for ‘subsystems’ should include internal-sftp though, as users probably expect sftp to just work. I don’t have any issue with using two-element lists; I think the syntax for pairs can be a bit confusing for newcomers to it’s probably better to avoid it in service configuration. Thanks, Ludo’.
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
> Hi ng0, > > On Sun, 5 Mar 2017 14:50:26 + > ng0 wrote: > >> What I take from the discussion is, all is good to go except for >> subsystems. I'm okay with reviewing subsystems as an individual patch >> later on. For me this works. Push the 3 patches, and send the subsystems >> one later as a new discussion-bug. > > The 3 were pushed to master. > > Patch 4 not yet. So let's discuss. > > I have no preference for pairs or lists - it's just that the > documentation should say what it actually expects - because the user > has to write the form differently: Hi Danny, I think there is a misunderstanding. I didn't want to push this because it was not tested, and because subsystems are often useless without Match, and Match is unsupported. The pair/list thing is not the problem. And I was waiting for ng0 to test, because he asked for this patch (see http://lists.gnu.org/archive/html/guix-devel/2017-02/msg00906.html), so I thought he was able to test. If ng0 still needs the patch and confirms that it works well, I'm willing to update it. Otherwise, let's drop it. Sorry for the confusion. Clément
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
Hi ng0, On Sun, 5 Mar 2017 14:50:26 + ng0 wrote: > What I take from the discussion is, all is good to go except for > subsystems. I'm okay with reviewing subsystems as an individual patch > later on. For me this works. Push the 3 patches, and send the subsystems > one later as a new discussion-bug. The 3 were pushed to master. Patch 4 not yet. So let's discuss. I have no preference for pairs or lists - it's just that the documentation should say what it actually expects - because the user has to write the form differently: Pair: '(a . b) List: '(a b) Those are not compatible with each other. (I think as the patch is written now it expects lists) And I'm against calling pairs "two-element tuple"s. It reminds me of these math joke equations which write the value 2 in a really complicated way (but correctly) :) And lists are definitely not two-element tuples. That would be seriously confusing. What do you think?
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
On 17-03-02 22:00:47, Clément Lassieur wrote:
> Hi Danny,
>
> Danny Milosavljevic writes:
>
> > Hi,
> >
> > On Tue, 21 Feb 2017 00:53:55 +0100
> > Clément Lassieur wrote:
> >> +This is a list of two-element tuples,
> >
> > list of pairs.
> >
> >>where each tuple contains the
> >
> > each pair
> >
> >> +subsystem name and a command (with optional arguments) to execute upon
> >> +subsystem request.
> >> +
> >> +The command @command{sftp-server} implements the SFTP file transfer
> >> +subsystem.
> >> +@example
> >> +'(("sftp" "/usr/libexec/sftp-server"))
> >
> > Hmm, that is a list in there, not a two-element tuple:
> >
> > scheme@(guile-user)> (car '(("A" "B")))
> > $1 = ("A" "B")
> > scheme@(guile-user)> (car (car '(("A" "B"
> > $3 = "A"
> > scheme@(guile-user)> (cdr (car '(("A" "B"
> > $2 = ("B") < should be "B" without the parens for tuples
> >
> > So I suggest either fix the example to be a pair ("sftp" .
> > "/usr/libexec/sftp-server") or fix the docs.
>
> Ok. I'll correct this later, for now I don't want to push this patch,
> I'm waiting for a confirmation from ng0.
>
> Thanks for the review!
>
Okay, I've tried to figure out what the correct patches are but now that
I know the fact that subsystems was left out later (or my tree view is
wrong) is strange.
What I take from the discussion is, all is good to go except for
subsystems. I'm okay with reviewing subsystems as an individual patch
later on. For me this works. Push the 3 patches, and send the subsystems
one later as a new discussion-bug.
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
Hi Danny,
Danny Milosavljevic writes:
> Hi,
>
> On Tue, 21 Feb 2017 00:53:55 +0100
> Clément Lassieur wrote:
>> +This is a list of two-element tuples,
>
> list of pairs.
>
>>where each tuple contains the
>
> each pair
>
>> +subsystem name and a command (with optional arguments) to execute upon
>> +subsystem request.
>> +
>> +The command @command{sftp-server} implements the SFTP file transfer
>> +subsystem.
>> +@example
>> +'(("sftp" "/usr/libexec/sftp-server"))
>
> Hmm, that is a list in there, not a two-element tuple:
>
> scheme@(guile-user)> (car '(("A" "B")))
> $1 = ("A" "B")
> scheme@(guile-user)> (car (car '(("A" "B"
> $3 = "A"
> scheme@(guile-user)> (cdr (car '(("A" "B"
> $2 = ("B") < should be "B" without the parens for tuples
>
> So I suggest either fix the example to be a pair ("sftp" .
> "/usr/libexec/sftp-server") or fix the docs.
Ok. I'll correct this later, for now I don't want to push this patch,
I'm waiting for a confirmation from ng0.
Thanks for the review!
Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
Hi,
On Tue, 21 Feb 2017 00:53:55 +0100
Clément Lassieur wrote:
> +This is a list of two-element tuples,
list of pairs.
>where each tuple contains the
each pair
> +subsystem name and a command (with optional arguments) to execute upon
> +subsystem request.
> +
> +The command @command{sftp-server} implements the SFTP file transfer
> +subsystem.
> +@example
> +'(("sftp" "/usr/libexec/sftp-server"))
Hmm, that is a list in there, not a two-element tuple:
scheme@(guile-user)> (car '(("A" "B")))
$1 = ("A" "B")
scheme@(guile-user)> (car (car '(("A" "B"
$3 = "A"
scheme@(guile-user)> (cdr (car '(("A" "B"
$2 = ("B") < should be "B" without the parens for tuples
So I suggest either fix the example to be a pair ("sftp" .
"/usr/libexec/sftp-server") or fix the docs.
[PATCH 4/4] services: openssh: Add 'subsystems' option.
* gnu/services/ssh.scm (openssh-config-file): Add it.
()[subsystems]: Add it.
* doc/guix.texi (Networking Services): Document it.
---
doc/guix.texi| 19 +
gnu/services/ssh.scm | 80 +---
2 files changed, 64 insertions(+), 35 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index db0bf0f9b..69ff33149 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -9175,6 +9175,25 @@ equivalent role to password authentication, you should
disable either
@item @code{print-last-log?} (default: @code{#t})
Specifies whether @command{sshd} should print the date and time of the
last user login when a user logs in interactively.
+
+@item @code{subsystems} (default: @code{'()})
+Configures external subsystems (e.g. file transfer daemon).
+
+This is a list of two-element tuples, where each tuple contains the
+subsystem name and a command (with optional arguments) to execute upon
+subsystem request.
+
+The command @command{sftp-server} implements the SFTP file transfer
+subsystem.
+@example
+'(("sftp" "/usr/libexec/sftp-server"))
+@end example
+
+Alternately the name @command{internal-sftp} implements an in-process
+SFTP server.
+@example
+'(("sftp" "internal-sftp"))
+@end example
@end table
@end deftp
diff --git a/gnu/services/ssh.scm b/gnu/services/ssh.scm
index 9e1449743..054743d11 100644
--- a/gnu/services/ssh.scm
+++ b/gnu/services/ssh.scm
@@ -280,7 +280,9 @@ The other options should be self-descriptive."
(use-pam? openssh-configuration-use-pam?
(default #t)) ;Boolean
(print-last-log? openssh-configuration-print-last-log?
- (default #t))) ;Boolean
+ (default #t)) ;Boolean
+ (subsystemsopenssh-configuration-subsystems
+ (default '( ;List of two-element tuples
(define %openssh-accounts
(list (user-group (name "sshd") (system? #t))
@@ -314,40 +316,48 @@ The other options should be self-descriptive."
"Return the sshd configuration file corresponding to CONFIG."
(computed-file
"sshd_config"
- #~(call-with-output-file #$output
- (lambda (port)
- (display "# Generated by 'openssh-service'.\n" port)
- (format port "Port ~a\n"
- #$(number->string (openssh-configuration-port-number config)))
- (format port "PermitRootLogin ~a\n"
- #$(match (openssh-configuration-permit-root-login config)
- (#t "yes")
- (#f "no")
- ('without-password "without-password")))
- (format port "PermitEmptyPasswords ~a\n"
- #$(if (openssh-configuration-allow-empty-passwords? config)
- "yes" "no"))
- (format port "PasswordAuthentication ~a\n"
- #$(if (openssh-configuration-password-authentication? config)
- "yes" "no"))
- (format port "PubkeyAuthentication ~a\n"
- #$(if (openssh-configuration-public-key-authentication?
config)
- "yes" "no"))
- (format port "X11Forwarding ~a\n"
- #$(if (openssh-configuration-x11-forwarding? config)
- "yes" "no"))
- (format port "PidFile ~a\n"
- #$(openssh-configuration-pid-file config))
- (format port "ChallengeResponseAuthentication ~a\n"
- #$(if (openssh-challenge-response-authentication? config)
- "yes" "no"))
- (format port "UsePAM ~a\n"
- #$(if (openssh-configuration-use-pam? config)
- "yes" "no"))
- (format port "PrintLastLog ~a\n"
- #$(if (openssh-configuration-print-last-log? config)
- "yes" "no"))
- #t
+ #~(begin
+ (use-modules (ice-9 match))
+ (call-with-output-file #$output
+ (lambda (port)
+ (display "# Generated by 'openssh-service'.\n" port)
+ (format port "Port ~a\n"
+ #$(number->string
+ (openssh-configuration-port-number config)))
+ (format port "PermitRootLogin ~a\n"
+ #$(match (openssh-configuration-permit-root-login config)
+ (#t "yes")
+ (#f "no")
+ ('without-password "without-password")))
+ (format port "PermitEmptyPasswords ~a\n"
+ #$(if (openssh-configuration-allow-empty-passwords? config)
+ "yes" "no"))
+ (format port "PasswordAuthentication ~a\n"
+ #$(if (openssh-configuration-password-authentication?
config)
+ "yes" "no"))
+ (format port "PubkeyAuthentication ~a\n"
+ #$(if (openssh-configuration-public-key-authentication?
+ config)
+ "yes" "no
