Re: [drlvm][jvmti] Last commit of Harmony-1582 brocks JVMTI support for DRLVM.
I'd like to rephrase this to be clear - It seems that HARMONY-1826 breaks the interpreter - when applied to current SVN trunk, all smoke tests fail for interpreter geir Geir Magnusson Jr. wrote: It seems to break the interpreter. jitrino smoke tests run fine, but all interpreter tests fail... Pavel Rebriy wrote: The fix is ready. See http://issues.apache.org/jira/browse/HARMONY-1826 On 10/10/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: Pavel Rebriy wrote: > Hello, > > Fix for Harmony-1582 brocks initialization of JVMTI support. I'm > investigating the problem and going to create fixing JIRA as soon as > possible. Great - thanks > > P.S. May be include several JVMTI tests into "build test". Yes, please do. > - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [drlvm] Interpreter is broken. (Was: Re: [drlvm][jvmti] Last commit of Harmony-1582 brocks JVMTI support for DRLVM.)
Pavel Pervov wrote: Geir, as I may observe, interpreter is broken both on windows and linux for at least 3 days now. The interpreter library just does not load. From system diagnostics it looks like SIGSEGV in initialization static block of the library. I dunno. My system passes interpreter smoke tests now w/o that patch, or so I thought... geir Regards, Pavel. On 10/15/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: It seems to break the interpreter. jitrino smoke tests run fine, but all interpreter tests fail... Pavel Rebriy wrote: > The fix is ready. See http://issues.apache.org/jira/browse/HARMONY-1826 > > On 10/10/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: >> >> >> >> Pavel Rebriy wrote: >> > Hello, >> > >> > Fix for Harmony-1582 brocks initialization of JVMTI support. I'm >> > investigating the problem and going to create fixing JIRA as soon as >> > possible. >> >> Great - thanks >> >> > >> > P.S. May be include several JVMTI tests into "build test". >> >> Yes, please do. >> >> > >> >> - >> Terms of use : http://incubator.apache.org/harmony/mailing.html >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> > > - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [drlvm] Interpreter is broken. (Was: Re: [drlvm][jvmti] Last commit of Harmony-1582 brocks JVMTI support for DRLVM.)
False alarm. It works just fine now. But it was broken on Friday!.. Mistery. Pavel. On 10/15/06, Pavel Pervov <[EMAIL PROTECTED]> wrote: Geir, as I may observe, interpreter is broken both on windows and linux for at least 3 days now. The interpreter library just does not load. From system diagnostics it looks like SIGSEGV in initialization static block of the library. Regards, Pavel. On 10/15/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: > > It seems to break the interpreter. jitrino smoke tests run fine, but > all interpreter tests fail... > > Pavel Rebriy wrote: > > The fix is ready. See > http://issues.apache.org/jira/browse/HARMONY-1826 > > > > On 10/10/06, Geir Magnusson Jr. < [EMAIL PROTECTED]> wrote: > >> > >> > >> > >> Pavel Rebriy wrote: > >> > Hello, > >> > > >> > Fix for Harmony-1582 brocks initialization of JVMTI support. I'm > >> > investigating the problem and going to create fixing JIRA as soon > as > >> > possible. > >> > >> Great - thanks > >> > >> > > >> > P.S. May be include several JVMTI tests into "build test". > >> > >> Yes, please do. > >> > >> > > >> > >> - > >> Terms of use : http://incubator.apache.org/harmony/mailing.html > >> To unsubscribe, e-mail: [EMAIL PROTECTED] > >> For additional commands, e-mail: > [EMAIL PROTECTED] > >> > >> > > > > > > - > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
[drlvm] Interpreter is broken. (Was: Re: [drlvm][jvmti] Last commit of Harmony-1582 brocks JVMTI support for DRLVM.)
Geir, as I may observe, interpreter is broken both on windows and linux for at least 3 days now. The interpreter library just does not load. From system diagnostics it looks like SIGSEGV in initialization static block of the library. Regards, Pavel. On 10/15/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: It seems to break the interpreter. jitrino smoke tests run fine, but all interpreter tests fail... Pavel Rebriy wrote: > The fix is ready. See http://issues.apache.org/jira/browse/HARMONY-1826 > > On 10/10/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: >> >> >> >> Pavel Rebriy wrote: >> > Hello, >> > >> > Fix for Harmony-1582 brocks initialization of JVMTI support. I'm >> > investigating the problem and going to create fixing JIRA as soon as >> > possible. >> >> Great - thanks >> >> > >> > P.S. May be include several JVMTI tests into "build test". >> >> Yes, please do. >> >> > >> >> - >> Terms of use : http://incubator.apache.org/harmony/mailing.html >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> > > - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [drlvm][jvmti] Last commit of Harmony-1582 brocks JVMTI support for DRLVM.
It seems to break the interpreter. jitrino smoke tests run fine, but all interpreter tests fail... Pavel Rebriy wrote: The fix is ready. See http://issues.apache.org/jira/browse/HARMONY-1826 On 10/10/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: Pavel Rebriy wrote: > Hello, > > Fix for Harmony-1582 brocks initialization of JVMTI support. I'm > investigating the problem and going to create fixing JIRA as soon as > possible. Great - thanks > > P.S. May be include several JVMTI tests into "build test". Yes, please do. > - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [drlvm][jvmti] Last commit of Harmony-1582 brocks JVMTI support for DRLVM.
Regarding patching generation of native callback, function gen_native_readinternal() doesn't use in VM and this is a dead code. As to me it should be eliminated. -s = mov(s, M_Base_Opnd(esp_reg, 0), Imm_Opnd((int)jni_native_intf)) ; // o0=jni_native_intf +s = mov(s, M_Base_Opnd(esp_reg, 0), Imm_Opnd((int)p_TLS_vmthread->jni_env)) ; // o0=jni_native_intf Regarding patching SingleStep, it's so trivial patch I think it can be applied with issue with or without it TI doesn't work anyway. Anyway, I vote for a quick inclusion of this patch. Good point!. -- Best regards, Pavel Rebriy
Re: [drlvm][jvmti] Last commit of Harmony-1582 brocks JVMTI support for DRLVM.
Geir Magnusson Jr. wrote: > If all agree, please submit your change as a patch to that patch :) Sorry for confusion, it wasn't my change, but commented changes from HARMONY-1826. - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [drlvm][jvmti] Last commit of Harmony-1582 brocks JVMTI support for DRLVM.
If all agree, please submit your change as a patch to that patch :)
Salikh Zakirov wrote:
Pavel Rebriy wrote:
Fix for Harmony-1582 brocks initialization of JVMTI support. I'm
investigating the problem and going to create fixing JIRA as soon as
possible.
The fix is ready. See http://issues.apache.org/jira/browse/HARMONY-1826
Pavel, I have reviewed the patch in HARMONY-1826, and it looks great!
A couple of minor comments.
The change like this doesn't really move us closer to multi-VM support,
as the jni_env is hardcoded to the emitted code.
-s = mov(s, M_Base_Opnd(esp_reg, 0), Imm_Opnd((int)jni_native_intf)) ; //
o0=jni_native_intf
+s = mov(s, M_Base_Opnd(esp_reg, 0),
Imm_Opnd((int)p_TLS_vmthread->jni_env)) ; // o0=jni_native_intf
The following change seems to fix unrelated issue ('Fixed Single Step event
disabling'?),
so I think it would have been better if it filed as a separate JIRA/patch.
-
ti->vm_brpt->release_intf(vm_thread->ss_state->predicted_breakpoints);
-_deallocate((unsigned char *)vm_thread->ss_state);
-vm_thread->ss_state = NULL;
+if( vm_thread->ss_state ) {
+if( vm_thread->ss_state->predicted_breakpoints ) {
+
ti->vm_brpt->release_intf(vm_thread->ss_state->predicted_breakpoints);
+}
+_deallocate((unsigned char *)vm_thread->ss_state);
+vm_thread->ss_state = NULL;
+}
Anyway, I vote for a quick inclusion of this patch.
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [drlvm][jvmti] Last commit of Harmony-1582 brocks JVMTI support for DRLVM.
Pavel Rebriy wrote:
>> > Fix for Harmony-1582 brocks initialization of JVMTI support. I'm
>> > investigating the problem and going to create fixing JIRA as soon as
>> > possible.
> The fix is ready. See http://issues.apache.org/jira/browse/HARMONY-1826
Pavel, I have reviewed the patch in HARMONY-1826, and it looks great!
A couple of minor comments.
The change like this doesn't really move us closer to multi-VM support,
as the jni_env is hardcoded to the emitted code.
-s = mov(s, M_Base_Opnd(esp_reg, 0), Imm_Opnd((int)jni_native_intf)) ; //
o0=jni_native_intf
+s = mov(s, M_Base_Opnd(esp_reg, 0),
Imm_Opnd((int)p_TLS_vmthread->jni_env)) ; // o0=jni_native_intf
The following change seems to fix unrelated issue ('Fixed Single Step event
disabling'?),
so I think it would have been better if it filed as a separate JIRA/patch.
-
ti->vm_brpt->release_intf(vm_thread->ss_state->predicted_breakpoints);
-_deallocate((unsigned char *)vm_thread->ss_state);
-vm_thread->ss_state = NULL;
+if( vm_thread->ss_state ) {
+if( vm_thread->ss_state->predicted_breakpoints ) {
+
ti->vm_brpt->release_intf(vm_thread->ss_state->predicted_breakpoints);
+}
+_deallocate((unsigned char *)vm_thread->ss_state);
+vm_thread->ss_state = NULL;
+}
Anyway, I vote for a quick inclusion of this patch.
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [drlvm][jvmti] Last commit of Harmony-1582 brocks JVMTI support for DRLVM.
The fix is ready. See http://issues.apache.org/jira/browse/HARMONY-1826 On 10/10/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: Pavel Rebriy wrote: > Hello, > > Fix for Harmony-1582 brocks initialization of JVMTI support. I'm > investigating the problem and going to create fixing JIRA as soon as > possible. Great - thanks > > P.S. May be include several JVMTI tests into "build test". Yes, please do. > - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Best regards, Pavel Rebriy
Re: [drlvm][jvmti] Last commit of Harmony-1582 brocks JVMTI support for DRLVM.
Pavel Rebriy wrote: Hello, Fix for Harmony-1582 brocks initialization of JVMTI support. I'm investigating the problem and going to create fixing JIRA as soon as possible. Great - thanks P.S. May be include several JVMTI tests into "build test". Yes, please do. - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[drlvm][jvmti] Last commit of Harmony-1582 brocks JVMTI support for DRLVM.
Hello, Fix for Harmony-1582 brocks initialization of JVMTI support. I'm investigating the problem and going to create fixing JIRA as soon as possible. P.S. May be include several JVMTI tests into "build test". -- Best regards, Pavel Rebriy
