[jira] [Commented] (HDFS-12759) Ozone: web: integrate configuration reader page to the SCM/KSM web ui.
[ https://issues.apache.org/jira/browse/HDFS-12759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455328#comment-16455328 ] Hudson commented on HDFS-12759: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14070 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14070/]) HDFS-12759. Ozone: web: integrate configuration reader page to the (omalley: rev 4deb845d7c574252b9a0b98a7ed83c7b60909c24) * (delete) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/templates/ozone-config.html * (delete) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/js/ozone-conf.js * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/ozone.js * (delete) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/scm/main.css * (add) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/ksm/main.html * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/templates/rpc-metrics.html * (add) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/templates/menu.html * (add) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/templates/config.html * (delete) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/templates/tools.html * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/ksm/index.html * (delete) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/css/ozone-conf.css * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/scm/index.html * (add) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/ozone.css * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/ksm/ksm.js * (add) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/scm/main.html > Ozone: web: integrate configuration reader page to the SCM/KSM web ui. > -- > > Key: HDFS-12759 > URL: https://issues.apache.org/jira/browse/HDFS-12759 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Elek, Marton >Assignee: Elek, Marton >Priority: Trivial > Labels: web-ui > Attachments: HDFS-12759-HDFS-7240.001.patch, > HDFS-12759-HDFS-7240.003.patch, HDFS-12759-HDFS-7240.004.patch, > HDFS-12759-HDFS-7280.002.patch, after1.png, after2.png, before1.png, > before2.png, conf.png > > > In the current SCM/KSM web ui the configuration are > * hidden under the Common Tools menu > * opens a different type of web page (different menu and style). > In this patch I integrate the configuration page to the existing web ui: > From user point of view: > * Configuration page is moved to a separated main menu > * The menu of the Configuration page is the same as all the others > * Metrics are also moved to separatad pages/menus > * As the configuraiton page requires full width, all the pages use full > width layout > From technical point of view: > * To support multiple pages I enabled the angular router (which has already > been added as component) > * Not, it's suppored to create multiple pages and navigate between them, so > I also moved the metrics pages to different pages, making the main overview > page more clean. > * The layout changed to use the full width. > TESTING: > It's a client side only change. The easiest way to test is doing a full > build, start SCM/KSM and check the menu items > > * All the menu items should work > * Configuration page (from the main menu) should use the same header > * The configuration item of the Common tools menu shows the good old raw > configuration page -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12759) Ozone: web: integrate configuration reader page to the SCM/KSM web ui.
[ https://issues.apache.org/jira/browse/HDFS-12759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451116#comment-16451116 ] Hudson commented on HDFS-12759: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14057/]) HDFS-12759. Ozone: web: integrate configuration reader page to the (aengineer: rev 6d79f90bbaea40a24a0ce6e7049bb565d676e7f3) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/ksm/index.html * (add) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/scm/main.html * (delete) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/templates/ozone-config.html * (delete) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/templates/tools.html * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/ksm/ksm.js * (add) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/templates/menu.html * (add) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/ozone.css * (add) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/templates/config.html * (delete) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/css/ozone-conf.css * (delete) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/scm/main.css * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/ozone.js * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/scm/index.html * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/templates/rpc-metrics.html * (add) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/ksm/main.html * (delete) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/js/ozone-conf.js > Ozone: web: integrate configuration reader page to the SCM/KSM web ui. > -- > > Key: HDFS-12759 > URL: https://issues.apache.org/jira/browse/HDFS-12759 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Elek, Marton >Assignee: Elek, Marton >Priority: Trivial > Labels: web-ui > Attachments: HDFS-12759-HDFS-7240.001.patch, > HDFS-12759-HDFS-7240.003.patch, HDFS-12759-HDFS-7240.004.patch, > HDFS-12759-HDFS-7280.002.patch, after1.png, after2.png, before1.png, > before2.png, conf.png > > > In the current SCM/KSM web ui the configuration are > * hidden under the Common Tools menu > * opens a different type of web page (different menu and style). > In this patch I integrate the configuration page to the existing web ui: > From user point of view: > * Configuration page is moved to a separated main menu > * The menu of the Configuration page is the same as all the others > * Metrics are also moved to separatad pages/menus > * As the configuraiton page requires full width, all the pages use full > width layout > From technical point of view: > * To support multiple pages I enabled the angular router (which has already > been added as component) > * Not, it's suppored to create multiple pages and navigate between them, so > I also moved the metrics pages to different pages, making the main overview > page more clean. > * The layout changed to use the full width. > TESTING: > It's a client side only change. The easiest way to test is doing a full > build, start SCM/KSM and check the menu items > > * All the menu items should work > * Configuration page (from the main menu) should use the same header > * The configuration item of the Common tools menu shows the good old raw > configuration page -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12759) Ozone: web: integrate configuration reader page to the SCM/KSM web ui.
[
https://issues.apache.org/jira/browse/HDFS-12759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257710#comment-16257710
]
Hadoop QA commented on HDFS-12759:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 9m
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} HDFS-7240 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m
3s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
32m 35s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 56s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 55m 54s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:d11161b |
| JIRA Issue | HDFS-12759 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12898283/HDFS-12759-HDFS-7240.004.patch
|
| Optional Tests | asflicense shadedclient |
| uname | Linux dbfa7e435998 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18
11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDFS-7240 / 2ed98ac |
| maven | version: Apache Maven 3.3.9 |
| Max. process+thread count | 297 (vs. ulimit of 5000) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/22134/console |
| Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone: web: integrate configuration reader page to the SCM/KSM web ui.
> --
>
> Key: HDFS-12759
> URL: https://issues.apache.org/jira/browse/HDFS-12759
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Elek, Marton
>Assignee: Elek, Marton
>Priority: Trivial
> Labels: web-ui
> Attachments: HDFS-12759-HDFS-7240.001.patch,
> HDFS-12759-HDFS-7240.003.patch, HDFS-12759-HDFS-7240.004.patch,
> HDFS-12759-HDFS-7280.002.patch, after1.png, after2.png, before1.png,
> before2.png, conf.png
>
>
> In the current SCM/KSM web ui the configuration are
> * hidden under the Common Tools menu
> * opens a different type of web page (different menu and style).
> In this patch I integrate the configuration page to the existing web ui:
> From user point of view:
> * Configuration page is moved to a separated main menu
> * The menu of the Configuration page is the same as all the others
> * Metrics are also moved to separatad pages/menus
> * As the configuraiton page requires full width, all the pages use full
> width layout
> From technical point of view:
> * To support multiple pages I enabled the angular router (which has already
> been added as component)
> * Not, it's suppored to create multiple pages and navigate between them, so
> I also moved the metrics pages to different pages, making the main overview
> page more clean.
> * The layout changed to use the full width.
> TESTING:
> It's a client side only change. The easiest way to test is doing a full
> build, start SCM/KSM and check the menu items
>
> * All the menu items should work
> * Configuration page (from the main menu) should use the same header
> * The configuration item of the Common tools menu shows the good old raw
> configuration page
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12759) Ozone: web: integrate configuration reader page to the SCM/KSM web ui.
[
https://issues.apache.org/jira/browse/HDFS-12759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241755#comment-16241755
]
Hadoop QA commented on HDFS-12759:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} HDFS-7240 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m
50s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
30m 8s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 8s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 44m 20s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:d11161b |
| JIRA Issue | HDFS-12759 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12896362/HDFS-12759-HDFS-7240.003.patch
|
| Optional Tests | asflicense shadedclient |
| uname | Linux 9dcfaf443979 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26
18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDFS-7240 / 8107e52 |
| maven | version: Apache Maven 3.3.9 |
| Max. process+thread count | 284 (vs. ulimit of 5000) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/21981/console |
| Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone: web: integrate configuration reader page to the SCM/KSM web ui.
> --
>
> Key: HDFS-12759
> URL: https://issues.apache.org/jira/browse/HDFS-12759
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Elek, Marton
>Assignee: Elek, Marton
>Priority: Trivial
> Labels: web-ui
> Attachments: HDFS-12759-HDFS-7240.001.patch,
> HDFS-12759-HDFS-7240.003.patch, HDFS-12759-HDFS-7280.002.patch, after1.png,
> after2.png, before1.png, before2.png, conf.png
>
>
> In the current SCM/KSM web ui the configuration are
> * hidden under the Common Tools menu
> * opens a different type of web page (different menu and style).
> In this patch I integrate the configuration page to the existing web ui:
> From user point of view:
> * Configuration page is moved to a separated main menu
> * The menu of the Configuration page is the same as all the others
> * Metrics are also moved to separatad pages/menus
> * As the configuraiton page requires full width, all the pages use full
> width layout
> From technical point of view:
> * To support multiple pages I enabled the angular router (which has already
> been added as component)
> * Not, it's suppored to create multiple pages and navigate between them, so
> I also moved the metrics pages to different pages, making the main overview
> page more clean.
> * The layout changed to use the full width.
> TESTING:
> It's a client side only change. The easiest way to test is doing a full
> build, start SCM/KSM and check the menu items
>
> * All the menu items should work
> * Configuration page (from the main menu) should use the same header
> * The configuration item of the Common tools menu shows the good old raw
> configuration page
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12759) Ozone: web: integrate configuration reader page to the SCM/KSM web ui.
[
https://issues.apache.org/jira/browse/HDFS-12759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238464#comment-16238464
]
Anu Engineer commented on HDFS-12759:
-
Looks like the patch failed because it ran against the trunk
{noformat}
HEAD is now at e6ec020 YARN-7370: Preemption properties should be refreshable.
Contrubted by Gergely Novák.
Switched to a new branch 'trunk'
Branch trunk set up to track remote branch trunk from origin.
Current branch trunk is up to date.
Already on 'trunk'
Your branch is up-to-date with 'origin/trunk'.
{noformat}
I think the issue is the branch part of the patch has a typo. I think we should
rename this patch to
HDFS-12759\-HDFS-*7280*.002.patch ==> HDFS-12759\-HDFS-*7240*.002.patch
> Ozone: web: integrate configuration reader page to the SCM/KSM web ui.
> --
>
> Key: HDFS-12759
> URL: https://issues.apache.org/jira/browse/HDFS-12759
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Elek, Marton
>Assignee: Elek, Marton
> Labels: web-ui
> Attachments: HDFS-12759-HDFS-7240.001.patch,
> HDFS-12759-HDFS-7280.002.patch, after1.png, after2.png, before1.png,
> before2.png, conf.png
>
>
> In the current SCM/KSM web ui the configuration are
> * hidden under the Common Tools menu
> * opens a different type of web page (different menu and style).
> In this patch I integrate the configuration page to the existing web ui:
> From user point of view:
> * Configuration page is moved to a separated main menu
> * The menu of the Configuration page is the same as all the others
> * Metrics are also moved to separatad pages/menus
> * As the configuraiton page requires full width, all the pages use full
> width layout
> From technical point of view:
> * To support multiple pages I enabled the angular router (which has already
> been added as component)
> * Not, it's suppored to create multiple pages and navigate between them, so
> I also moved the metrics pages to different pages, making the main overview
> page more clean.
> * The layout changed to use the full width.
> TESTING:
> It's a client side only change. The easiest way to test is doing a full
> build, start SCM/KSM and check the menu items
>
> * All the menu items should work
> * Configuration page (from the main menu) should use the same header
> * The configuration item of the Common tools menu shows the good old raw
> configuration page
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12759) Ozone: web: integrate configuration reader page to the SCM/KSM web ui.
[
https://issues.apache.org/jira/browse/HDFS-12759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236686#comment-16236686
]
Hadoop QA commented on HDFS-12759:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} HDFS-12759 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-12759 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12895496/HDFS-12759-HDFS-7280.002.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/21934/console |
| Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone: web: integrate configuration reader page to the SCM/KSM web ui.
> --
>
> Key: HDFS-12759
> URL: https://issues.apache.org/jira/browse/HDFS-12759
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Elek, Marton
>Assignee: Elek, Marton
> Labels: web-ui
> Attachments: HDFS-12759-HDFS-7240.001.patch,
> HDFS-12759-HDFS-7280.002.patch, after1.png, after2.png, before1.png,
> before2.png, conf.png
>
>
> In the current SCM/KSM web ui the configuration are
> * hidden under the Common Tools menu
> * opens a different type of web page (different menu and style).
> In this patch I integrate the configuration page to the existing web ui:
> From user point of view:
> * Configuration page is moved to a separated main menu
> * The menu of the Configuration page is the same as all the others
> * Metrics are also moved to separatad pages/menus
> * As the configuraiton page requires full width, all the pages use full
> width layout
> From technical point of view:
> * To support multiple pages I enabled the angular router (which has already
> been added as component)
> * Not, it's suppored to create multiple pages and navigate between them, so
> I also moved the metrics pages to different pages, making the main overview
> page more clean.
> * The layout changed to use the full width.
> TESTING:
> It's a client side only change. The easiest way to test is doing a full
> build, start SCM/KSM and check the menu items
>
> * All the menu items should work
> * Configuration page (from the main menu) should use the same header
> * The configuration item of the Common tools menu shows the good old raw
> configuration page
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12759) Ozone: web: integrate configuration reader page to the SCM/KSM web ui.
[ https://issues.apache.org/jira/browse/HDFS-12759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236438#comment-16236438 ] Anu Engineer commented on HDFS-12759: - one more minor comment, in common tools->config, it looks like a blob of text. since it is supposed to be XML, I am wondering why the browser does not understand it? > Ozone: web: integrate configuration reader page to the SCM/KSM web ui. > -- > > Key: HDFS-12759 > URL: https://issues.apache.org/jira/browse/HDFS-12759 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Elek, Marton >Assignee: Elek, Marton > Labels: web-ui > Attachments: HDFS-12759-HDFS-7240.001.patch, after1.png, after2.png, > before1.png, before2.png > > > In the current SCM/KSM web ui the configuration are > * hidden under the Common Tools menu > * opens a different type of web page (different menu and style). > In this patch I integrate the configuration page to the existing web ui: > From user point of view: > * Configuration page is moved to a separated main menu > * The menu of the Configuration page is the same as all the others > * Metrics are also moved to separatad pages/menus > * As the configuraiton page requires full width, all the pages use full > width layout > From technical point of view: > * To support multiple pages I enabled the angular router (which has already > been added as component) > * Not, it's suppored to create multiple pages and navigate between them, so > I also moved the metrics pages to different pages, making the main overview > page more clean. > * The layout changed to use the full width. > TESTING: > It's a client side only change. The easiest way to test is doing a full > build, start SCM/KSM and check the menu items > > * All the menu items should work > * Configuration page (from the main menu) should use the same header > * The configuration item of the Common tools menu shows the good old raw > configuration page -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12759) Ozone: web: integrate configuration reader page to the SCM/KSM web ui.
[ https://issues.apache.org/jira/browse/HDFS-12759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236415#comment-16236415 ] Anu Engineer commented on HDFS-12759: - Could you please take care of the ASF Licensing issues. +1 after fixing that. > Ozone: web: integrate configuration reader page to the SCM/KSM web ui. > -- > > Key: HDFS-12759 > URL: https://issues.apache.org/jira/browse/HDFS-12759 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Elek, Marton >Assignee: Elek, Marton > Labels: web-ui > Attachments: HDFS-12759-HDFS-7240.001.patch, after1.png, after2.png, > before1.png, before2.png > > > In the current SCM/KSM web ui the configuration are > * hidden under the Common Tools menu > * opens a different type of web page (different menu and style). > In this patch I integrate the configuration page to the existing web ui: > From user point of view: > * Configuration page is moved to a separated main menu > * The menu of the Configuration page is the same as all the others > * Metrics are also moved to separatad pages/menus > * As the configuraiton page requires full width, all the pages use full > width layout > From technical point of view: > * To support multiple pages I enabled the angular router (which has already > been added as component) > * Not, it's suppored to create multiple pages and navigate between them, so > I also moved the metrics pages to different pages, making the main overview > page more clean. > * The layout changed to use the full width. > TESTING: > It's a client side only change. The easiest way to test is doing a full > build, start SCM/KSM and check the menu items > > * All the menu items should work > * Configuration page (from the main menu) should use the same header > * The configuration item of the Common tools menu shows the good old raw > configuration page -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12759) Ozone: web: integrate configuration reader page to the SCM/KSM web ui.
[
https://issues.apache.org/jira/browse/HDFS-12759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236255#comment-16236255
]
Hadoop QA commented on HDFS-12759:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} HDFS-7240 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m
39s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
30m 19s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 57s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
20s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 44m 15s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:d11161b |
| JIRA Issue | HDFS-12759 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12895439/HDFS-12759-HDFS-7240.001.patch
|
| Optional Tests | asflicense shadedclient |
| uname | Linux ce6447e03420 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26
18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDFS-7240 / 6e74039 |
| maven | version: Apache Maven 3.3.9 |
| asflicense |
https://builds.apache.org/job/PreCommit-HDFS-Build/21929/artifact/out/patch-asflicense-problems.txt
|
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/21929/console |
| Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone: web: integrate configuration reader page to the SCM/KSM web ui.
> --
>
> Key: HDFS-12759
> URL: https://issues.apache.org/jira/browse/HDFS-12759
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Elek, Marton
>Assignee: Elek, Marton
> Labels: web-ui
> Attachments: HDFS-12759-HDFS-7240.001.patch, after1.png, after2.png,
> before1.png, before2.png
>
>
> In the current SCM/KSM web ui the configuration are
> * hidden under the Common Tools menu
> * opens a different type of web page (different menu and style).
> In this patch I integrate the configuration page to the existing web ui:
> From user point of view:
> * Configuration page is moved to a separated main menu
> * The menu of the Configuration page is the same as all the others
> * Metrics are also moved to separatad pages/menus
> * As the configuraiton page requires full width, all the pages use full
> width layout
> From technical point of view:
> * To support multiple pages I enabled the angular router (which has already
> been added as component)
> * Not, it's suppored to create multiple pages and navigate between them, so
> I also moved the metrics pages to different pages, making the main overview
> page more clean.
> * The layout changed to use the full width.
> TESTING:
> It's a client side only change. The easiest way to test is doing a full
> build, start SCM/KSM and check the menu items
>
> * All the menu items should work
> * Configuration page (from the main menu) should use the same header
> * The configuration item of the Common tools menu shows the good old raw
> configuration page
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
