[jira] [Commented] (HDFS-1620) FSConstants vs FsConstants
[
https://issues.apache.org/jira/browse/HDFS-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096740#comment-13096740
]
Hadoop QA commented on HDFS-1620:
-
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12492913/HDFS-1620.r4.diff
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 200 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
-1 release audit. The applied patch generated 1 release audit warnings
(more than the trunk's current 0 warnings).
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hdfs.server.namenode.TestBackupNode
org.apache.hadoop.hdfs.TestDfsOverAvroRpc
org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap
org.apache.hadoop.hdfs.server.datanode.TestReplicasMap
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1192//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1192//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1192//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1192//console
This message is automatically generated.
> FSConstants vs FsConstants
> ---
>
> Key: HDFS-1620
> URL: https://issues.apache.org/jira/browse/HDFS-1620
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Tsz Wo (Nicholas), SZE
>Assignee: Harsh J
>Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1620.r1.diff, HDFS-1620.r2.diff, HDFS-1620.r3.diff,
> HDFS-1620.r4.diff
>
>
> We have {{org.apache.hadoop.hdfs.protocol.*FSConstants*}} and
> {{org.apache.hadoop.fs.*FsConstants*}}. Elegant or confused?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1620) FSConstants vs FsConstants
[
https://issues.apache.org/jira/browse/HDFS-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068038#comment-13068038
]
Aaron T. Myers commented on HDFS-1620:
--
bq. Ideally, the class protocol.FSConstants ought to be protocol.HdfsConstants
and the class server.HdfsConstants can be server.HdfsServerConstants, to
preserve their meaning in the classnames itself. The contents look like they
should still be kept separate, and with these names I think they'd make more
sense.
+1, I think this plan makes a lot of sense. You've clearly thought about this
quite a bit.
> FSConstants vs FsConstants
> ---
>
> Key: HDFS-1620
> URL: https://issues.apache.org/jira/browse/HDFS-1620
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Tsz Wo (Nicholas), SZE
>Assignee: Harsh J
>Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1620.r1.diff, HDFS-1620.r2.diff, HDFS-1620.r3.diff
>
>
> We have {{org.apache.hadoop.hdfs.protocol.*FSConstants*}} and
> {{org.apache.hadoop.fs.*FsConstants*}}. Elegant or confused?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1620) FSConstants vs FsConstants
[
https://issues.apache.org/jira/browse/HDFS-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067932#comment-13067932
]
Harsh J commented on HDFS-1620:
---
Ok, so taking a step back and re-looking, these are multiple things here. To
elaborate, there are HDFS specific constants in the current
{{org.apache.hadoop.hdfs.protocol.FSConstants}} and there's also server
specific constants under {{org.apache.hadoop.hdfs.server.common.HdfsConstants}}
Ideally, the class {{protocol.FSConstants}} ought to be
{{protocol.HdfsConstants}} and the class {{server.HdfsConstants}} can be
{{server.HdfsServerConstants}}, to preserve their meaning in the classnames
itself. The contents look like they should still be kept separate, and with
these names I think they'd make more sense.
The earlier used DfsConstants is too generic, given the way Hadoop interacts
with lots of DFS-es, its best to name them explicitly as Hdfs-prefixed.
I'll also update the comments in the interfaces to reflect what ought to be in
each and how it differs.
Thoughts?
> FSConstants vs FsConstants
> ---
>
> Key: HDFS-1620
> URL: https://issues.apache.org/jira/browse/HDFS-1620
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Tsz Wo (Nicholas), SZE
>Assignee: Harsh J
>Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1620.r1.diff, HDFS-1620.r2.diff, HDFS-1620.r3.diff
>
>
> We have {{org.apache.hadoop.hdfs.protocol.*FSConstants*}} and
> {{org.apache.hadoop.fs.*FsConstants*}}. Elegant or confused?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1620) FSConstants vs FsConstants
[
https://issues.apache.org/jira/browse/HDFS-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067873#comment-13067873
]
Aaron T. Myers commented on HDFS-1620:
--
Hey Harsh, we're unfortunately inconsistent throughout the projects in our
camel casing of initialisms (I'm guilty of this myself) but I think we should
tend toward treating an initialism as though it were a normal word when it
comes to capitalization. So rather than {{DFSConstants}}, I think it should be
{{DfsConstants}}.
Otherwise the patch looks good. I'll commit it pending that concern being
addressed (either by updating the patch or by telling me I'm being pedantic.) :)
> FSConstants vs FsConstants
> ---
>
> Key: HDFS-1620
> URL: https://issues.apache.org/jira/browse/HDFS-1620
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Tsz Wo (Nicholas), SZE
>Assignee: Harsh J
>Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1620.r1.diff, HDFS-1620.r2.diff
>
>
> We have {{org.apache.hadoop.hdfs.protocol.*FSConstants*}} and
> {{org.apache.hadoop.fs.*FsConstants*}}. Elegant or confused?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1620) FSConstants vs FsConstants
[
https://issues.apache.org/jira/browse/HDFS-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039145#comment-13039145
]
Harsh J Chouraria commented on HDFS-1620:
-
The failing test:
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery.testBlockPoolStorageStates
is unrelated to this patch (age 93 as per hudson).
> FSConstants vs FsConstants
> ---
>
> Key: HDFS-1620
> URL: https://issues.apache.org/jira/browse/HDFS-1620
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Tsz Wo (Nicholas), SZE
>Assignee: Harsh J Chouraria
>Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1620.r1.diff
>
>
> We have {{org.apache.hadoop.hdfs.protocol.*FSConstants*}} and
> {{org.apache.hadoop.fs.*FsConstants*}}. Elegant or confused?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1620) FSConstants vs FsConstants
[
https://issues.apache.org/jira/browse/HDFS-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038660#comment-13038660
]
Hadoop QA commented on HDFS-1620:
-
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12480271/HDFS-1620.r1.diff
against trunk revision 1126795.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 131 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/618//testReport/
Findbugs warnings:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/618//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/618//console
This message is automatically generated.
> FSConstants vs FsConstants
> ---
>
> Key: HDFS-1620
> URL: https://issues.apache.org/jira/browse/HDFS-1620
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Tsz Wo (Nicholas), SZE
>Assignee: Harsh J Chouraria
>Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1620.r1.diff
>
>
> We have {{org.apache.hadoop.hdfs.protocol.*FSConstants*}} and
> {{org.apache.hadoop.fs.*FsConstants*}}. Elegant or confused?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1620) FSConstants vs FsConstants
[
https://issues.apache.org/jira/browse/HDFS-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030371#comment-13030371
]
Harsh J Chouraria commented on HDFS-1620:
-
We should make the hdfs.protocol.FSConstants into DFSConstants. That should
solve the confusion I think?
We can mark protocol.FSConstants deprecated, and make it extend the copied over
DFSConstants class (although its marked Private as an interface, its a better
approach than to earn the wrath of a thousand users).
> FSConstants vs FsConstants
> ---
>
> Key: HDFS-1620
> URL: https://issues.apache.org/jira/browse/HDFS-1620
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Tsz Wo (Nicholas), SZE
>Priority: Minor
>
> We have {{org.apache.hadoop.hdfs.protocol.*FSConstants*}} and
> {{org.apache.hadoop.fs.*FsConstants*}}. Elegant or confused?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
