[jira] [Commented] (HDFS-4268) Remove redundant enum NNHAStatusHeartbeat.State
[
https://issues.apache.org/jira/browse/HDFS-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578947#comment-13578947
]
Konstantin Shvachko commented on HDFS-4268:
---
{{HAServiceState.INITIALIZING}} means that {{NameNode.state == null}}. Based on
the initialization sequence this means RPC server has not started and therefore
there cannot be any heartbeats. Do you have a use case for AssertError?
Remove redundant enum NNHAStatusHeartbeat.State
---
Key: HDFS-4268
URL: https://issues.apache.org/jira/browse/HDFS-4268
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.0.2-alpha
Reporter: Konstantin Shvachko
Assignee: Konstantin Shvachko
Fix For: 2.0.3-alpha
Attachments: heartbeatHAState.patch, heartbeatHAState.patch
NNHAStatusHeartbeat.State is redundant and can be replaced with commonly used
enum HAServiceState.
We should also consistently use HAServiceState to check if the state is
ACTIVE or STANDBY rather than using {{instanceof}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4268) Remove redundant enum NNHAStatusHeartbeat.State
[
https://issues.apache.org/jira/browse/HDFS-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573027#comment-13573027
]
Eli Collins commented on HDFS-4268:
---
HAServiceState has 3 states (active,standy,initializing) and
NNHAStatusHeartbeat.State has 2 (active,standby). Previously we failed an
assert when creating a NNHAStatusHeartbeat with the initializing state, now we
permit it - intentional?
Remove redundant enum NNHAStatusHeartbeat.State
---
Key: HDFS-4268
URL: https://issues.apache.org/jira/browse/HDFS-4268
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.0.2-alpha
Reporter: Konstantin Shvachko
Assignee: Konstantin Shvachko
Fix For: 2.0.3-alpha
Attachments: heartbeatHAState.patch, heartbeatHAState.patch
NNHAStatusHeartbeat.State is redundant and can be replaced with commonly used
enum HAServiceState.
We should also consistently use HAServiceState to check if the state is
ACTIVE or STANDBY rather than using {{instanceof}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4268) Remove redundant enum NNHAStatusHeartbeat.State
[
https://issues.apache.org/jira/browse/HDFS-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13511323#comment-13511323
]
Hudson commented on HDFS-4268:
--
Integrated in Hadoop-Hdfs-trunk #1246 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1246/])
HDFS-4268. Remove redundant enum NNHAStatusHeartbeat.State. Contributed by
Konstantin Shvachko. (Revision 1417752)
Result = FAILURE
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1417752
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupState.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/NNHAStatusHeartbeat.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBPOfferService.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery.java
Remove redundant enum NNHAStatusHeartbeat.State
---
Key: HDFS-4268
URL: https://issues.apache.org/jira/browse/HDFS-4268
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.0.2-alpha
Reporter: Konstantin Shvachko
Assignee: Konstantin Shvachko
Fix For: 2.0.3-alpha
Attachments: heartbeatHAState.patch, heartbeatHAState.patch
NNHAStatusHeartbeat.State is redundant and can be replaced with commonly used
enum HAServiceState.
We should also consistently use HAServiceState to check if the state is
ACTIVE or STANDBY rather than using {{instanceof}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4268) Remove redundant enum NNHAStatusHeartbeat.State
[
https://issues.apache.org/jira/browse/HDFS-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13511392#comment-13511392
]
Hudson commented on HDFS-4268:
--
Integrated in Hadoop-Mapreduce-trunk #1277 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1277/])
HDFS-4268. Remove redundant enum NNHAStatusHeartbeat.State. Contributed by
Konstantin Shvachko. (Revision 1417752)
Result = SUCCESS
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1417752
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupState.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/NNHAStatusHeartbeat.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBPOfferService.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery.java
Remove redundant enum NNHAStatusHeartbeat.State
---
Key: HDFS-4268
URL: https://issues.apache.org/jira/browse/HDFS-4268
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.0.2-alpha
Reporter: Konstantin Shvachko
Assignee: Konstantin Shvachko
Fix For: 2.0.3-alpha
Attachments: heartbeatHAState.patch, heartbeatHAState.patch
NNHAStatusHeartbeat.State is redundant and can be replaced with commonly used
enum HAServiceState.
We should also consistently use HAServiceState to check if the state is
ACTIVE or STANDBY rather than using {{instanceof}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4268) Remove redundant enum NNHAStatusHeartbeat.State
[
https://issues.apache.org/jira/browse/HDFS-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13511001#comment-13511001
]
Hadoop QA commented on HDFS-4268:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12556046/heartbeatHAState.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.TestSaveNamespace
org.apache.hadoop.hdfs.server.namenode.TestEditLog
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3601//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3601//console
This message is automatically generated.
Remove redundant enum NNHAStatusHeartbeat.State
---
Key: HDFS-4268
URL: https://issues.apache.org/jira/browse/HDFS-4268
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.0.2-alpha
Reporter: Konstantin Shvachko
Assignee: Konstantin Shvachko
Attachments: heartbeatHAState.patch
NNHAStatusHeartbeat.State is redundant and can be replaced with commonly used
enum HAServiceState.
We should also consistently use HAServiceState to check if the state is
ACTIVE or STANDBY rather than using {{instanceof}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4268) Remove redundant enum NNHAStatusHeartbeat.State
[
https://issues.apache.org/jira/browse/HDFS-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1356#comment-1356
]
Hadoop QA commented on HDFS-4268:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12556203/heartbeatHAState.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.TestEditLog
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3607//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3607//console
This message is automatically generated.
Remove redundant enum NNHAStatusHeartbeat.State
---
Key: HDFS-4268
URL: https://issues.apache.org/jira/browse/HDFS-4268
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.0.2-alpha
Reporter: Konstantin Shvachko
Assignee: Konstantin Shvachko
Attachments: heartbeatHAState.patch, heartbeatHAState.patch
NNHAStatusHeartbeat.State is redundant and can be replaced with commonly used
enum HAServiceState.
We should also consistently use HAServiceState to check if the state is
ACTIVE or STANDBY rather than using {{instanceof}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4268) Remove redundant enum NNHAStatusHeartbeat.State
[
https://issues.apache.org/jira/browse/HDFS-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13511184#comment-13511184
]
Hudson commented on HDFS-4268:
--
Integrated in Hadoop-trunk-Commit #3090 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/3090/])
HDFS-4268. Remove redundant enum NNHAStatusHeartbeat.State. Contributed by
Konstantin Shvachko. (Revision 1417752)
Result = SUCCESS
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1417752
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupState.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/NNHAStatusHeartbeat.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBPOfferService.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery.java
Remove redundant enum NNHAStatusHeartbeat.State
---
Key: HDFS-4268
URL: https://issues.apache.org/jira/browse/HDFS-4268
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.0.2-alpha
Reporter: Konstantin Shvachko
Assignee: Konstantin Shvachko
Attachments: heartbeatHAState.patch, heartbeatHAState.patch
NNHAStatusHeartbeat.State is redundant and can be replaced with commonly used
enum HAServiceState.
We should also consistently use HAServiceState to check if the state is
ACTIVE or STANDBY rather than using {{instanceof}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4268) Remove redundant enum NNHAStatusHeartbeat.State
[
https://issues.apache.org/jira/browse/HDFS-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13510281#comment-13510281
]
Konstantin Boudnik commented on HDFS-4268:
--
+1 patch looks good.
Remove redundant enum NNHAStatusHeartbeat.State
---
Key: HDFS-4268
URL: https://issues.apache.org/jira/browse/HDFS-4268
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.0.2-alpha
Reporter: Konstantin Shvachko
Assignee: Konstantin Shvachko
Attachments: heartbeatHAState.patch
NNHAStatusHeartbeat.State is redundant and can be replaced with commonly used
enum HAServiceState.
We should also consistently use HAServiceState to check if the state is
ACTIVE or STANDBY rather than using {{instanceof}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
