[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[ https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13851593#comment-13851593 ] Hudson commented on HDFS-5538: -- FAILURE: Integrated in Hadoop-Yarn-trunk #425 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/425/]) Move HDFS-5538, HDFS-5545, HDFS-5536, HDFS-5312, and HDFS-5629 from trunk to 2.4.0 section. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1551724) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt URLConnectionFactory should pick up the SSL related configuration by default Key: HDFS-5538 URL: https://issues.apache.org/jira/browse/HDFS-5538 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 2.4.0 Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch, HDFS-5538.002.patch, HDFS-5538.003.patch The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does not pick up any hadoop-specific, SSL-related configuration. Its customers have to set up the ConnectionConfigurator explicitly in order to pick up these configurations. This is less than ideal for HTTPS because whenever the code needs to make a HTTPS connection, the code is forced to go through the set up. This jira refactors URLConnectionFactory to ease the handling of HTTPS connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now). In particular, instead of loading the SSL configurator statically in SecurityUtil (based on a global configuration about SSL), and determine whether we should set up SSL for a given connection based on whether the SSL configurator is null, we now load the SSL configurator in URLConnectionFactory, and determine if we need to use the configurator to set up an SSL connection based on if the given URL/connection is https. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[ https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13851705#comment-13851705 ] Hudson commented on HDFS-5538: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1616 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1616/]) Move HDFS-5538, HDFS-5545, HDFS-5536, HDFS-5312, and HDFS-5629 from trunk to 2.4.0 section. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1551724) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt URLConnectionFactory should pick up the SSL related configuration by default Key: HDFS-5538 URL: https://issues.apache.org/jira/browse/HDFS-5538 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 2.4.0 Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch, HDFS-5538.002.patch, HDFS-5538.003.patch The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does not pick up any hadoop-specific, SSL-related configuration. Its customers have to set up the ConnectionConfigurator explicitly in order to pick up these configurations. This is less than ideal for HTTPS because whenever the code needs to make a HTTPS connection, the code is forced to go through the set up. This jira refactors URLConnectionFactory to ease the handling of HTTPS connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now). In particular, instead of loading the SSL configurator statically in SecurityUtil (based on a global configuration about SSL), and determine whether we should set up SSL for a given connection based on whether the SSL configurator is null, we now load the SSL configurator in URLConnectionFactory, and determine if we need to use the configurator to set up an SSL connection based on if the given URL/connection is https. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[ https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13851812#comment-13851812 ] Hudson commented on HDFS-5538: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1642 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1642/]) Move HDFS-5538, HDFS-5545, HDFS-5536, HDFS-5312, and HDFS-5629 from trunk to 2.4.0 section. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1551724) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt URLConnectionFactory should pick up the SSL related configuration by default Key: HDFS-5538 URL: https://issues.apache.org/jira/browse/HDFS-5538 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 2.4.0 Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch, HDFS-5538.002.patch, HDFS-5538.003.patch The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does not pick up any hadoop-specific, SSL-related configuration. Its customers have to set up the ConnectionConfigurator explicitly in order to pick up these configurations. This is less than ideal for HTTPS because whenever the code needs to make a HTTPS connection, the code is forced to go through the set up. This jira refactors URLConnectionFactory to ease the handling of HTTPS connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now). In particular, instead of loading the SSL configurator statically in SecurityUtil (based on a global configuration about SSL), and determine whether we should set up SSL for a given connection based on whether the SSL configurator is null, we now load the SSL configurator in URLConnectionFactory, and determine if we need to use the configurator to set up an SSL connection based on if the given URL/connection is https. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[ https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13850965#comment-13850965 ] Hudson commented on HDFS-5538: -- SUCCESS: Integrated in Hadoop-trunk-Commit #4903 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4903/]) Move HDFS-5538, HDFS-5545, HDFS-5536, HDFS-5312, and HDFS-5629 from trunk to 2.4.0 section. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1551724) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt URLConnectionFactory should pick up the SSL related configuration by default Key: HDFS-5538 URL: https://issues.apache.org/jira/browse/HDFS-5538 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 2.4.0 Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch, HDFS-5538.002.patch, HDFS-5538.003.patch The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does not pick up any hadoop-specific, SSL-related configuration. Its customers have to set up the ConnectionConfigurator explicitly in order to pick up these configurations. This is less than ideal for HTTPS because whenever the code needs to make a HTTPS connection, the code is forced to go through the set up. This jira refactors URLConnectionFactory to ease the handling of HTTPS connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now). In particular, instead of loading the SSL configurator statically in SecurityUtil (based on a global configuration about SSL), and determine whether we should set up SSL for a given connection based on whether the SSL configurator is null, we now load the SSL configurator in URLConnectionFactory, and determine if we need to use the configurator to set up an SSL connection based on if the given URL/connection is https. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[ https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832487#comment-13832487 ] Hudson commented on HDFS-5538: -- FAILURE: Integrated in Hadoop-Yarn-trunk #403 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/403/]) HDFS-5538. URLConnectionFactory should pick up the SSL related configuration by default. Contributed by Haohui Mai. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1545491) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogFileInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DelegationTokenFetcher.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/HftpFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/HsftpFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/SWebHdfsFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLogFileInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestURLConnectionFactory.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsTimeouts.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestDelegationTokenRemoteFetcher.java URLConnectionFactory should pick up the SSL related configuration by default Key: HDFS-5538 URL: https://issues.apache.org/jira/browse/HDFS-5538 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 3.0.0 Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch, HDFS-5538.002.patch, HDFS-5538.003.patch The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does not pick up any hadoop-specific, SSL-related configuration. Its customers have to set up the ConnectionConfigurator explicitly in order to pick up these configurations. This is less than ideal for HTTPS because whenever the code needs to make a HTTPS connection, the code is forced to go through the set up. This jira refactors URLConnectionFactory to ease the handling of HTTPS connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now). In particular, instead of loading the SSL configurator statically in SecurityUtil (based on a global configuration about SSL), and determine whether we should set up SSL for a given connection based on whether the SSL configurator is null, we now load the SSL configurator in URLConnectionFactory, and determine if we need to use the configurator to set up an SSL connection based on if the given URL/connection is https. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[ https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832568#comment-13832568 ] Hudson commented on HDFS-5538: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1594 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1594/]) HDFS-5538. URLConnectionFactory should pick up the SSL related configuration by default. Contributed by Haohui Mai. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1545491) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogFileInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DelegationTokenFetcher.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/HftpFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/HsftpFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/SWebHdfsFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLogFileInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestURLConnectionFactory.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsTimeouts.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestDelegationTokenRemoteFetcher.java URLConnectionFactory should pick up the SSL related configuration by default Key: HDFS-5538 URL: https://issues.apache.org/jira/browse/HDFS-5538 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 3.0.0 Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch, HDFS-5538.002.patch, HDFS-5538.003.patch The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does not pick up any hadoop-specific, SSL-related configuration. Its customers have to set up the ConnectionConfigurator explicitly in order to pick up these configurations. This is less than ideal for HTTPS because whenever the code needs to make a HTTPS connection, the code is forced to go through the set up. This jira refactors URLConnectionFactory to ease the handling of HTTPS connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now). In particular, instead of loading the SSL configurator statically in SecurityUtil (based on a global configuration about SSL), and determine whether we should set up SSL for a given connection based on whether the SSL configurator is null, we now load the SSL configurator in URLConnectionFactory, and determine if we need to use the configurator to set up an SSL connection based on if the given URL/connection is https. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[ https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831796#comment-13831796 ] Jing Zhao commented on HDFS-5538: - The patch looks pretty good to me. Some comments: # nit: In EditLogInputStream#fromUrl, please update the javadoc (add description about the new parameter) and fix the indentation. # Please post some testing results for HA setup (to cover the changes in EditLogFileInputStream and QuorumJournalManager) when https is enabled. # It will be better to update the jira description to provide details about how the patch eases the handling of HTTPS connections (e.g., loading the SSL factory setup in the beginning, and getting rid of its dependency of the global configuration HttpConfig when determining whether we need to setup an ssl connection). URLConnectionFactory should pick up the SSL related configuration by default Key: HDFS-5538 URL: https://issues.apache.org/jira/browse/HDFS-5538 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Haohui Mai Assignee: Haohui Mai Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch, HDFS-5538.002.patch The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does not pick up any hadoop-specific, SSL-related configuration. Its customers have to set up the ConnectionConfigurator explicitly in order to pick up these configurations. This is less than ideal for HTTPS because whenever the code needs to make a HTTPS connection, the code is forced to go through the set up. This jira refactors URLConnectionFactory to ease the handling of HTTPS connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now). -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[ https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831967#comment-13831967 ] Haohui Mai commented on HDFS-5538: -- I've tested the patch by running a secondary namenode, and it works for both http and https. URLConnectionFactory should pick up the SSL related configuration by default Key: HDFS-5538 URL: https://issues.apache.org/jira/browse/HDFS-5538 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Haohui Mai Assignee: Haohui Mai Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch, HDFS-5538.002.patch, HDFS-5538.003.patch The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does not pick up any hadoop-specific, SSL-related configuration. Its customers have to set up the ConnectionConfigurator explicitly in order to pick up these configurations. This is less than ideal for HTTPS because whenever the code needs to make a HTTPS connection, the code is forced to go through the set up. This jira refactors URLConnectionFactory to ease the handling of HTTPS connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now). -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[ https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832027#comment-13832027 ] Haohui Mai commented on HDFS-5538: -- We'll defer the system test of HA / QJM in HDFS-5545 / HDFS-5536. URLConnectionFactory should pick up the SSL related configuration by default Key: HDFS-5538 URL: https://issues.apache.org/jira/browse/HDFS-5538 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Haohui Mai Assignee: Haohui Mai Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch, HDFS-5538.002.patch, HDFS-5538.003.patch The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does not pick up any hadoop-specific, SSL-related configuration. Its customers have to set up the ConnectionConfigurator explicitly in order to pick up these configurations. This is less than ideal for HTTPS because whenever the code needs to make a HTTPS connection, the code is forced to go through the set up. This jira refactors URLConnectionFactory to ease the handling of HTTPS connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now). In particular, instead of loading the SSL configurator statically in SecurityUtil (based on a global configuration about SSL), and determine whether we should set up SSL for a given connection based on whether the SSL configurator is null, we now load the SSL configurator in URLConnectionFactory, and determine if we need to use the configurator to set up an SSL connection based on if the given URL/connection is https. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[ https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832059#comment-13832059 ] Jing Zhao commented on HDFS-5538: - Sounds good to me. +1 pending Jenkins URLConnectionFactory should pick up the SSL related configuration by default Key: HDFS-5538 URL: https://issues.apache.org/jira/browse/HDFS-5538 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Haohui Mai Assignee: Haohui Mai Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch, HDFS-5538.002.patch, HDFS-5538.003.patch The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does not pick up any hadoop-specific, SSL-related configuration. Its customers have to set up the ConnectionConfigurator explicitly in order to pick up these configurations. This is less than ideal for HTTPS because whenever the code needs to make a HTTPS connection, the code is forced to go through the set up. This jira refactors URLConnectionFactory to ease the handling of HTTPS connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now). In particular, instead of loading the SSL configurator statically in SecurityUtil (based on a global configuration about SSL), and determine whether we should set up SSL for a given connection based on whether the SSL configurator is null, we now load the SSL configurator in URLConnectionFactory, and determine if we need to use the configurator to set up an SSL connection based on if the given URL/connection is https. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[
https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832134#comment-13832134
]
Hadoop QA commented on HDFS-5538:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12615686/HDFS-5538.003.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5562//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5562//console
This message is automatically generated.
URLConnectionFactory should pick up the SSL related configuration by default
Key: HDFS-5538
URL: https://issues.apache.org/jira/browse/HDFS-5538
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch,
HDFS-5538.002.patch, HDFS-5538.003.patch
The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does
not pick up any hadoop-specific, SSL-related configuration. Its customers
have to set up the ConnectionConfigurator explicitly in order to pick up
these configurations. This is less than ideal for HTTPS because whenever the
code needs to make a HTTPS connection, the code is forced to go through the
set up.
This jira refactors URLConnectionFactory to ease the handling of HTTPS
connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now).
In particular, instead of loading the SSL configurator statically in
SecurityUtil (based on a global configuration about SSL), and determine
whether we should set up SSL for a given connection based on whether the SSL
configurator is null, we now load the SSL configurator in
URLConnectionFactory, and determine if we need to use the configurator to set
up an SSL connection based on if the given URL/connection is https.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[ https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832264#comment-13832264 ] Hudson commented on HDFS-5538: -- SUCCESS: Integrated in Hadoop-trunk-Commit #4793 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4793/]) HDFS-5538. URLConnectionFactory should pick up the SSL related configuration by default. Contributed by Haohui Mai. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1545491) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogFileInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DelegationTokenFetcher.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/HftpFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/HsftpFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/SWebHdfsFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/URLConnectionFactory.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLogFileInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestURLConnectionFactory.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsTimeouts.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestDelegationTokenRemoteFetcher.java URLConnectionFactory should pick up the SSL related configuration by default Key: HDFS-5538 URL: https://issues.apache.org/jira/browse/HDFS-5538 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 3.0.0 Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch, HDFS-5538.002.patch, HDFS-5538.003.patch The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does not pick up any hadoop-specific, SSL-related configuration. Its customers have to set up the ConnectionConfigurator explicitly in order to pick up these configurations. This is less than ideal for HTTPS because whenever the code needs to make a HTTPS connection, the code is forced to go through the set up. This jira refactors URLConnectionFactory to ease the handling of HTTPS connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now). In particular, instead of loading the SSL configurator statically in SecurityUtil (based on a global configuration about SSL), and determine whether we should set up SSL for a given connection based on whether the SSL configurator is null, we now load the SSL configurator in URLConnectionFactory, and determine if we need to use the configurator to set up an SSL connection based on if the given URL/connection is https. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[
https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829802#comment-13829802
]
Hadoop QA commented on HDFS-5538:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12615272/HDFS-5538.002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestDistributedFileSystem
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5539//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5539//console
This message is automatically generated.
URLConnectionFactory should pick up the SSL related configuration by default
Key: HDFS-5538
URL: https://issues.apache.org/jira/browse/HDFS-5538
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch,
HDFS-5538.002.patch
The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does
not pick up any hadoop-specific, SSL-related configuration. Its customers
have to set up the ConnectionConfigurator explicitly in order to pick up
these configurations.
This is less than ideal for HTTPS because whenever the code needs to make a
HTTPS connection, the code is forced to go through the set up.
This jira refactors URLConnectionFactory to ease the handling of HTTPS
connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[
https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830318#comment-13830318
]
Hadoop QA commented on HDFS-5538:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12615272/HDFS-5538.002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5542//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5542//console
This message is automatically generated.
URLConnectionFactory should pick up the SSL related configuration by default
Key: HDFS-5538
URL: https://issues.apache.org/jira/browse/HDFS-5538
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch,
HDFS-5538.002.patch
The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does
not pick up any hadoop-specific, SSL-related configuration. Its customers
have to set up the ConnectionConfigurator explicitly in order to pick up
these configurations.
This is less than ideal for HTTPS because whenever the code needs to make a
HTTPS connection, the code is forced to go through the set up.
This jira refactors URLConnectionFactory to ease the handling of HTTPS
connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[
https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829661#comment-13829661
]
Hadoop QA commented on HDFS-5538:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12615270/HDFS-5538.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.ipc.TestRPC
org.apache.hadoop.ipc.TestIPC
org.apache.hadoop.conf.TestConfiguration
org.apache.hadoop.ipc.TestRPCCallBenchmark
org.apache.hadoop.hdfs.server.blockmanagement.TestBlockManager
org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
org.apache.hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps
org.apache.hadoop.hdfs.TestListFilesInFileContext
org.apache.hadoop.security.TestRefreshUserMappings
org.apache.hadoop.hdfs.server.namenode.ha.TestHAWebUI
org.apache.hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
org.apache.hadoop.fs.TestSymlinkHdfsFileContext
org.apache.hadoop.hdfs.TestDFSClientFailover
org.apache.hadoop.hdfs.server.namenode.ha.TestDFSZKFailoverController
org.apache.hadoop.hdfs.server.datanode.TestBlockReport
org.apache.hadoop.hdfs.TestParallelRead
org.apache.hadoop.hdfs.server.blockmanagement.TestHeartbeatHandling
org.apache.hadoop.hdfs.TestLeaseRecovery2
org.apache.hadoop.hdfs.TestBlockMissingException
org.apache.hadoop.security.TestPermissionSymlinks
org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage
org.apache.hadoop.hdfs.TestParallelUnixDomainRead
org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache
org.apache.hadoop.hdfs.TestWriteConfigurationToDFS
org.apache.hadoop.hdfs.TestLargeBlock
org.apache.hadoop.fs.TestGlobPaths
org.apache.hadoop.hdfs.TestCrcCorruption
org.apache.hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
org.apache.hadoop.hdfs.TestFileAppend
org.apache.hadoop.hdfs.TestPread
org.apache.hadoop.hdfs.server.namenode.TestEditLogRace
org.apache.hadoop.hdfs.qjournal.server.TestJournalNodeMXBean
org.apache.hadoop.hdfs.TestReplication
org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery
org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs
org.apache.hadoop.hdfs.TestMissingBlocksAlert
org.apache.hadoop.hdfs.TestDFSUpgradeFromImage
org.apache.hadoop.hdfs.server.datanode.TestMultipleNNDataBlockScanner
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
org.apache.hadoop.hdfs.TestDFSAddressConfig
org.apache.hadoop.hdfs.web.TestTokenAspect
org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner
org.apache.hadoop.hdfs.TestSmallBlock
org.apache.hadoop.hdfs.web.TestWebHDFS
org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite
org.apache.hadoop.hdfs.TestBlockReaderLocalLegacy
org.apache.hadoop.hdfs.server.namenode.TestBackupNode
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
org.apache.hadoop.hdfs.server.datanode.TestRefreshNamenodes
org.apache.hadoop.hdfs.server.namenode.TestAuditLogger
org.apache.hadoop.hdfs.server.namenode.TestFsck
org.apache.hadoop.hdfs.qjournal.client.TestQJMWithFaults
[jira] [Commented] (HDFS-5538) URLConnectionFactory should pick up the SSL related configuration by default
[
https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13828391#comment-13828391
]
Hadoop QA commented on HDFS-5538:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12615021/HDFS-5538.000.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5514//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5514//console
This message is automatically generated.
URLConnectionFactory should pick up the SSL related configuration by default
Key: HDFS-5538
URL: https://issues.apache.org/jira/browse/HDFS-5538
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-5538.000.patch
The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does
not pick up any hadoop-specific, SSL-related configuration. Its customers
have to set up the ConnectionConfigurator explicitly in order to pick up
these configurations.
This is less than ideal for HTTPS because whenever the code needs to make a
HTTPS connection, the code is forced to go through the set up.
This jira refactors URLConnectionFactory to ease the handling of HTTPS
connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
