[jira] [Commented] (HDFS-5665) Remove the unnecessary writeLock while initializing CacheManager in FsNameSystem Ctor
[
https://issues.apache.org/jira/browse/HDFS-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850536#comment-13850536
]
Hudson commented on HDFS-5665:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1641 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1641/])
HDFS-5665. Remove the unnecessary writeLock while initializing CacheManager in
FsNameSystem Ctor. (Uma Maheswara Rao G via Andrew Wang) (wang:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551270)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
> Remove the unnecessary writeLock while initializing CacheManager in
> FsNameSystem Ctor
> -
>
> Key: HDFS-5665
> URL: https://issues.apache.org/jira/browse/HDFS-5665
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Fix For: 3.0.0
>
> Attachments: HDFS-5665.patch
>
>
> I just saw the below piece of code in Fsnamesystem ctor.
> {code}
> writeLock();
> try {
> this.cacheManager = new CacheManager(this, conf, blockManager);
> } finally {
> writeUnlock();
> }
> {code}
> It seems unnecessary to keep writeLock here. I am not sure if there is a
> clear reason to keep the lock.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HDFS-5665) Remove the unnecessary writeLock while initializing CacheManager in FsNameSystem Ctor
[
https://issues.apache.org/jira/browse/HDFS-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850448#comment-13850448
]
Hudson commented on HDFS-5665:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1615 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1615/])
HDFS-5665. Remove the unnecessary writeLock while initializing CacheManager in
FsNameSystem Ctor. (Uma Maheswara Rao G via Andrew Wang) (wang:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551270)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
> Remove the unnecessary writeLock while initializing CacheManager in
> FsNameSystem Ctor
> -
>
> Key: HDFS-5665
> URL: https://issues.apache.org/jira/browse/HDFS-5665
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Fix For: 3.0.0
>
> Attachments: HDFS-5665.patch
>
>
> I just saw the below piece of code in Fsnamesystem ctor.
> {code}
> writeLock();
> try {
> this.cacheManager = new CacheManager(this, conf, blockManager);
> } finally {
> writeUnlock();
> }
> {code}
> It seems unnecessary to keep writeLock here. I am not sure if there is a
> clear reason to keep the lock.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HDFS-5665) Remove the unnecessary writeLock while initializing CacheManager in FsNameSystem Ctor
[
https://issues.apache.org/jira/browse/HDFS-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850352#comment-13850352
]
Hudson commented on HDFS-5665:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #424 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/424/])
HDFS-5665. Remove the unnecessary writeLock while initializing CacheManager in
FsNameSystem Ctor. (Uma Maheswara Rao G via Andrew Wang) (wang:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551270)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
> Remove the unnecessary writeLock while initializing CacheManager in
> FsNameSystem Ctor
> -
>
> Key: HDFS-5665
> URL: https://issues.apache.org/jira/browse/HDFS-5665
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Fix For: 3.0.0
>
> Attachments: HDFS-5665.patch
>
>
> I just saw the below piece of code in Fsnamesystem ctor.
> {code}
> writeLock();
> try {
> this.cacheManager = new CacheManager(this, conf, blockManager);
> } finally {
> writeUnlock();
> }
> {code}
> It seems unnecessary to keep writeLock here. I am not sure if there is a
> clear reason to keep the lock.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HDFS-5665) Remove the unnecessary writeLock while initializing CacheManager in FsNameSystem Ctor
[
https://issues.apache.org/jira/browse/HDFS-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849355#comment-13849355
]
Hudson commented on HDFS-5665:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #4887 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/4887/])
HDFS-5665. Remove the unnecessary writeLock while initializing CacheManager in
FsNameSystem Ctor. (Uma Maheswara Rao G via Andrew Wang) (wang:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551270)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
> Remove the unnecessary writeLock while initializing CacheManager in
> FsNameSystem Ctor
> -
>
> Key: HDFS-5665
> URL: https://issues.apache.org/jira/browse/HDFS-5665
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Fix For: 3.0.0
>
> Attachments: HDFS-5665.patch
>
>
> I just saw the below piece of code in Fsnamesystem ctor.
> {code}
> writeLock();
> try {
> this.cacheManager = new CacheManager(this, conf, blockManager);
> } finally {
> writeUnlock();
> }
> {code}
> It seems unnecessary to keep writeLock here. I am not sure if there is a
> clear reason to keep the lock.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HDFS-5665) Remove the unnecessary writeLock while initializing CacheManager in FsNameSystem Ctor
[
https://issues.apache.org/jira/browse/HDFS-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849338#comment-13849338
]
Andrew Wang commented on HDFS-5665:
---
These test failures look spurious to me. +1, thanks Uma!
> Remove the unnecessary writeLock while initializing CacheManager in
> FsNameSystem Ctor
> -
>
> Key: HDFS-5665
> URL: https://issues.apache.org/jira/browse/HDFS-5665
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Attachments: HDFS-5665.patch
>
>
> I just saw the below piece of code in Fsnamesystem ctor.
> {code}
> writeLock();
> try {
> this.cacheManager = new CacheManager(this, conf, blockManager);
> } finally {
> writeUnlock();
> }
> {code}
> It seems unnecessary to keep writeLock here. I am not sure if there is a
> clear reason to keep the lock.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HDFS-5665) Remove the unnecessary writeLock while initializing CacheManager in FsNameSystem Ctor
[
https://issues.apache.org/jira/browse/HDFS-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849306#comment-13849306
]
Hadoop QA commented on HDFS-5665:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12618875/HDFS-5665.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.TestNameNodeHttpServer
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5731//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5731//console
This message is automatically generated.
> Remove the unnecessary writeLock while initializing CacheManager in
> FsNameSystem Ctor
> -
>
> Key: HDFS-5665
> URL: https://issues.apache.org/jira/browse/HDFS-5665
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Attachments: HDFS-5665.patch
>
>
> I just saw the below piece of code in Fsnamesystem ctor.
> {code}
> writeLock();
> try {
> this.cacheManager = new CacheManager(this, conf, blockManager);
> } finally {
> writeUnlock();
> }
> {code}
> It seems unnecessary to keep writeLock here. I am not sure if there is a
> clear reason to keep the lock.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HDFS-5665) Remove the unnecessary writeLock while initializing CacheManager in FsNameSystem Ctor
[
https://issues.apache.org/jira/browse/HDFS-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849069#comment-13849069
]
Hadoop QA commented on HDFS-5665:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12618875/HDFS-5665.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 eclipse:eclipse{color}. The patch failed to build with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1
release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5728//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/5728//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5728//console
This message is automatically generated.
> Remove the unnecessary writeLock while initializing CacheManager in
> FsNameSystem Ctor
> -
>
> Key: HDFS-5665
> URL: https://issues.apache.org/jira/browse/HDFS-5665
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Attachments: HDFS-5665.patch
>
>
> I just saw the below piece of code in Fsnamesystem ctor.
> {code}
> writeLock();
> try {
> this.cacheManager = new CacheManager(this, conf, blockManager);
> } finally {
> writeUnlock();
> }
> {code}
> It seems unnecessary to keep writeLock here. I am not sure if there is a
> clear reason to keep the lock.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HDFS-5665) Remove the unnecessary writeLock while initializing CacheManager in FsNameSystem Ctor
[
https://issues.apache.org/jira/browse/HDFS-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847897#comment-13847897
]
Colin Patrick McCabe commented on HDFS-5665:
I agree-- I think it would be fine to initialize this without holding the
writeLock.
> Remove the unnecessary writeLock while initializing CacheManager in
> FsNameSystem Ctor
> -
>
> Key: HDFS-5665
> URL: https://issues.apache.org/jira/browse/HDFS-5665
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
>
> I just saw the below piece of code in Fsnamesystem ctor.
> {code}
> writeLock();
> try {
> this.cacheManager = new CacheManager(this, conf, blockManager);
> } finally {
> writeUnlock();
> }
> {code}
> It seems unnecessary to keep writeLock here. I am not sure if there is a
> clear reason to keep the lock.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HDFS-5665) Remove the unnecessary writeLock while initializing CacheManager in FsNameSystem Ctor
[
https://issues.apache.org/jira/browse/HDFS-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847317#comment-13847317
]
Uma Maheswara Rao G commented on HDFS-5665:
---
Feel free to close this JIRA if you have a valid reason.
> Remove the unnecessary writeLock while initializing CacheManager in
> FsNameSystem Ctor
> -
>
> Key: HDFS-5665
> URL: https://issues.apache.org/jira/browse/HDFS-5665
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
>
> I just saw the below piece of code in Fsnamesystem ctor.
> {code}
> writeLock();
> try {
> this.cacheManager = new CacheManager(this, conf, blockManager);
> } finally {
> writeUnlock();
> }
> {code}
> It seems unnecessary to keep writeLock here. I am not sure if there is a
> clear reason to keep the lock.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
