Re: [PHP-DEV] Disabling arginfo argument type checks for internal functions
On Thu, Jun 6, 2019 at 7:42 AM Nikita Popov wrote: > I plan to disable the checking of arginfo argument types for internal > functions in https://github.com/php/php-src/pull/4232 (PHP 8 only). This > is > necessary to avoid duplicate type checks in both arginfo and zpp. Once this > lands, PRs to add arginfo types (available through reflection) to internal > functions will be accepted. > > Yay! We can finally get decent reflection for internal function signatures! -Sara
Re: [PHP-DEV] Using [ci skip]
Hi Peter, I think it's pretty well known about, but don't think we have it written down anywhere. I could make a note of it somewhere. I think in the case of azure it can be configured but I'm not sure about the others. I'll try to find out. Cheers Joe On Fri, 7 Jun 2019 at 16:00, Peter Cowburn wrote: > > > On Fri, 7 Jun 2019 at 12:09, Joe Watkins wrote: > >> Oh to be absolutely clear, I'm talking about commits that *only* touch >> these non-source files ... >> >> Cheers >> Joe >> >> On Fri, 7 Jun 2019 at 13:07, Joe Watkins wrote: >> >> > Hi Marco, >> > >> > It wasn't a topic for discussion, it was a request to committers in >> > php-src. >> > >> > We do not need to run CI for NEWS changes, and we can definitely be sure >> > it doesn't effect the build. >> > >> > The same goes for other files like UPGRADING, UPGRADING.INTERNALS ... >> > >> > Under normal circumstances these files are not changed by themslves, but >> > occasionally, we have to correct one of these files and omitting [ci >> ski] >> > puts the build behind by up to an hour ... >> > >> > Cheers >> > Joe >> > >> > On Fri, 7 Jun 2019 at 13:02, Marco Pivetta wrote: >> > >> >> Please avoid doing that: >> >> >> >> 1. Commit messages are for humans >> >> 2. You never know what can break, that's why it's "continuous" there >> >> (besides religious views around what "continuous integration" means) >> >> >> >> On Fri, Jun 7, 2019, 12:51 Joe Watkins wrote: >> >> >> >> > Hi all, >> >> > >> >> > Just a friendly reminder that when we're committing changes to files >> >> that >> >> > do not contain source, test code, or build configuration, it's >> helpful >> >> to >> >> > include [ci skip] in the commit message. Omitting it can put our CI >> >> quite >> >> > far behind. >> > > Is this documented somewhere? I'm not seeing it in the docs held in > php-src, nor a search of the wiki, for example. > Also, is this not something that the CI application(s) can be configured > to do for us? > > >> >> > >> >> > Cheers >> >> > Joe >> >> > >> >> >> > >> >
Re: [PHP-DEV] Using [ci skip]
On Fri, Jun 7, 2019 at 4:01 PM Peter Cowburn wrote: > On Fri, 7 Jun 2019 at 12:09, Joe Watkins wrote: > > > Oh to be absolutely clear, I'm talking about commits that *only* touch > > these non-source files ... > > > > Cheers > > Joe > > > > On Fri, 7 Jun 2019 at 13:07, Joe Watkins wrote: > > > > > Hi Marco, > > > > > > It wasn't a topic for discussion, it was a request to committers in > > > php-src. > > > > > > We do not need to run CI for NEWS changes, and we can definitely be > sure > > > it doesn't effect the build. > > > > > > The same goes for other files like UPGRADING, UPGRADING.INTERNALS ... > > > > > > Under normal circumstances these files are not changed by themslves, > but > > > occasionally, we have to correct one of these files and omitting [ci > ski] > > > puts the build behind by up to an hour ... > > > > > > Cheers > > > Joe > > > > > > On Fri, 7 Jun 2019 at 13:02, Marco Pivetta wrote: > > > > > >> Please avoid doing that: > > >> > > >> 1. Commit messages are for humans > > >> 2. You never know what can break, that's why it's "continuous" there > > >> (besides religious views around what "continuous integration" means) > > >> > > >> On Fri, Jun 7, 2019, 12:51 Joe Watkins wrote: > > >> > > >> > Hi all, > > >> > > > >> > Just a friendly reminder that when we're committing changes to files > > >> that > > >> > do not contain source, test code, or build configuration, it's > helpful > > >> to > > >> > include [ci skip] in the commit message. Omitting it can put our CI > > >> quite > > >> > far behind. > > > > Is this documented somewhere? I'm not seeing it in the docs held in > php-src, nor a search of the wiki, for example. > Also, is this not something that the CI application(s) can be configured to > do for us? > That's a good point. It looks like the option exists: https://docs.microsoft.com/en-us/azure/devops/pipelines/build/triggers?view=azure-devops=yaml#paths I think we used something like this on AppVeyor at some time, but had to disable it for some reason (?) Nikita
Re: [PHP-DEV] Using [ci skip]
On Fri, 7 Jun 2019 at 12:09, Joe Watkins wrote: > Oh to be absolutely clear, I'm talking about commits that *only* touch > these non-source files ... > > Cheers > Joe > > On Fri, 7 Jun 2019 at 13:07, Joe Watkins wrote: > > > Hi Marco, > > > > It wasn't a topic for discussion, it was a request to committers in > > php-src. > > > > We do not need to run CI for NEWS changes, and we can definitely be sure > > it doesn't effect the build. > > > > The same goes for other files like UPGRADING, UPGRADING.INTERNALS ... > > > > Under normal circumstances these files are not changed by themslves, but > > occasionally, we have to correct one of these files and omitting [ci ski] > > puts the build behind by up to an hour ... > > > > Cheers > > Joe > > > > On Fri, 7 Jun 2019 at 13:02, Marco Pivetta wrote: > > > >> Please avoid doing that: > >> > >> 1. Commit messages are for humans > >> 2. You never know what can break, that's why it's "continuous" there > >> (besides religious views around what "continuous integration" means) > >> > >> On Fri, Jun 7, 2019, 12:51 Joe Watkins wrote: > >> > >> > Hi all, > >> > > >> > Just a friendly reminder that when we're committing changes to files > >> that > >> > do not contain source, test code, or build configuration, it's helpful > >> to > >> > include [ci skip] in the commit message. Omitting it can put our CI > >> quite > >> > far behind. > Is this documented somewhere? I'm not seeing it in the docs held in php-src, nor a search of the wiki, for example. Also, is this not something that the CI application(s) can be configured to do for us? > >> > > >> > Cheers > >> > Joe > >> > > >> > > >
Re: [PHP-DEV] Using [ci skip]
Oh to be absolutely clear, I'm talking about commits that *only* touch these non-source files ... Cheers Joe On Fri, 7 Jun 2019 at 13:07, Joe Watkins wrote: > Hi Marco, > > It wasn't a topic for discussion, it was a request to committers in > php-src. > > We do not need to run CI for NEWS changes, and we can definitely be sure > it doesn't effect the build. > > The same goes for other files like UPGRADING, UPGRADING.INTERNALS ... > > Under normal circumstances these files are not changed by themslves, but > occasionally, we have to correct one of these files and omitting [ci ski] > puts the build behind by up to an hour ... > > Cheers > Joe > > On Fri, 7 Jun 2019 at 13:02, Marco Pivetta wrote: > >> Please avoid doing that: >> >> 1. Commit messages are for humans >> 2. You never know what can break, that's why it's "continuous" there >> (besides religious views around what "continuous integration" means) >> >> On Fri, Jun 7, 2019, 12:51 Joe Watkins wrote: >> >> > Hi all, >> > >> > Just a friendly reminder that when we're committing changes to files >> that >> > do not contain source, test code, or build configuration, it's helpful >> to >> > include [ci skip] in the commit message. Omitting it can put our CI >> quite >> > far behind. >> > >> > Cheers >> > Joe >> > >> >
Re: [PHP-DEV] Using [ci skip]
Hi Marco, It wasn't a topic for discussion, it was a request to committers in php-src. We do not need to run CI for NEWS changes, and we can definitely be sure it doesn't effect the build. The same goes for other files like UPGRADING, UPGRADING.INTERNALS ... Under normal circumstances these files are not changed by themslves, but occasionally, we have to correct one of these files and omitting [ci ski] puts the build behind by up to an hour ... Cheers Joe On Fri, 7 Jun 2019 at 13:02, Marco Pivetta wrote: > Please avoid doing that: > > 1. Commit messages are for humans > 2. You never know what can break, that's why it's "continuous" there > (besides religious views around what "continuous integration" means) > > On Fri, Jun 7, 2019, 12:51 Joe Watkins wrote: > > > Hi all, > > > > Just a friendly reminder that when we're committing changes to files that > > do not contain source, test code, or build configuration, it's helpful to > > include [ci skip] in the commit message. Omitting it can put our CI quite > > far behind. > > > > Cheers > > Joe > > >
Re: [PHP-DEV] Using [ci skip]
Please avoid doing that: 1. Commit messages are for humans 2. You never know what can break, that's why it's "continuous" there (besides religious views around what "continuous integration" means) On Fri, Jun 7, 2019, 12:51 Joe Watkins wrote: > Hi all, > > Just a friendly reminder that when we're committing changes to files that > do not contain source, test code, or build configuration, it's helpful to > include [ci skip] in the commit message. Omitting it can put our CI quite > far behind. > > Cheers > Joe >
[PHP-DEV] Using [ci skip]
Hi all, Just a friendly reminder that when we're committing changes to files that do not contain source, test code, or build configuration, it's helpful to include [ci skip] in the commit message. Omitting it can put our CI quite far behind. Cheers Joe
