[jira] [Work logged] (ARTEMIS-4348) CLI Abstract Connector should parse connectors if can't find acceptor on broker.xml
[
https://issues.apache.org/jira/browse/ARTEMIS-4348?focusedWorklogId=869703=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869703
]
ASF GitHub Bot logged work on ARTEMIS-4348:
---
Author: ASF GitHub Bot
Created on: 07/Jul/23 05:05
Start Date: 07/Jul/23 05:05
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #4539:
URL: https://github.com/apache/activemq-artemis/pull/4539#discussion_r1255245184
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/ActionAbstract.java:
##
@@ -39,6 +39,8 @@ public abstract class ActionAbstract implements Action {
@Option(name = "--verbose", description = "Print additional information.")
public boolean verbose;
+ String brokerConfiguration = "broker.xml";
Review Comment:
The name `brokerConfiguration` is already used in the method `protected
Configuration getBrokerConfiguration()`
```suggestion
String brokerConfigurationFilename = "broker.xml";
```
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/Transfer.java:
##
@@ -43,7 +43,7 @@ public class Transfer extends InputAbstract {
protected String sourceURL = DEFAULT_BROKER_URL;
@Option(name = "--source-acceptor", description = "Acceptor used to build
URL towards the broker. Default: 'artemis'.")
- protected String sourceAcceptor;
+ protected String sourceAcceptor = "artemis";
Review Comment:
The `DEFAULT_BROKER_ACCEPTOR` could be reused here:
```suggestion
protected String sourceAcceptor = DEFAULT_BROKER_ACCEPTOR;
```
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/ActionAbstract.java:
##
@@ -113,7 +115,23 @@ public String getBrokerURLInstance(String acceptor) {
return new URI(scheme, null, host, port, null, null,
null).toString();
}
}
+
+for (TransportConfiguration connectorConfiguration:
brokerConfiguration.getConnectorConfigurations().values()) {
+ if (connectorConfiguration.getName().equals(acceptor)) {
+ Map acceptorParams =
connectorConfiguration.getParams();
+ String scheme =
ConfigurationHelper.getStringProperty(TransportConstants.SCHEME_PROP_NAME,
SchemaConstants.TCP, acceptorParams);
+ String host =
ConfigurationHelper.getStringProperty(TransportConstants.HOST_PROP_NAME,
"localhost", acceptorParams);
+ int port =
ConfigurationHelper.getIntProperty(TransportConstants.PORT_PROP_NAME, 61616,
acceptorParams);
+
+ if (InetAddress.getByName(host).isAnyLocalAddress()) {
+ host = "localhost";
+ }
+
+ return new URI(scheme, null, host, port, null, null,
null).toString();
+ }
+}
Review Comment:
This block of the code is causing a duplication warning in my IDE because is
very similar to the block of code for the acceptors.
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/ActionAbstract.java:
##
@@ -113,7 +115,23 @@ public String getBrokerURLInstance(String acceptor) {
return new URI(scheme, null, host, port, null, null,
null).toString();
}
}
+
+for (TransportConfiguration connectorConfiguration:
brokerConfiguration.getConnectorConfigurations().values()) {
+ if (connectorConfiguration.getName().equals(acceptor)) {
+ Map acceptorParams =
connectorConfiguration.getParams();
+ String scheme =
ConfigurationHelper.getStringProperty(TransportConstants.SCHEME_PROP_NAME,
SchemaConstants.TCP, acceptorParams);
+ String host =
ConfigurationHelper.getStringProperty(TransportConstants.HOST_PROP_NAME,
"localhost", acceptorParams);
+ int port =
ConfigurationHelper.getIntProperty(TransportConstants.PORT_PROP_NAME, 61616,
acceptorParams);
+
+ if (InetAddress.getByName(host).isAnyLocalAddress()) {
+ host = "localhost";
+ }
+
+ return new URI(scheme, null, host, port, null, null,
null).toString();
+ }
+}
} catch (Exception e) {
+e.printStackTrace();
Review Comment:
Why is not the stack trace printed using `getActionContext().out` ?
Issue Time Tracking
---
Worklog Id: (was: 869703)
Time Spent: 20m (was: 10m)
> CLI Abstract Connector should parse connectors if can't find acceptor on
> broker.xml
> ---
>
> Key: ARTEMIS-4348
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4348
> Project: ActiveMQ
[jira] [Work logged] (ARTEMIS-4349) Replace Guava cache with Caffeine
[ https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=869681=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869681 ] ASF GitHub Bot logged work on ARTEMIS-4349: --- Author: ASF GitHub Bot Created on: 07/Jul/23 01:54 Start Date: 07/Jul/23 01:54 Worklog Time Spent: 10m Work Description: ben-manes commented on PR #4540: URL: https://github.com/apache/activemq-artemis/pull/4540#issuecomment-1624526398 Hi, If you do not have a performance reason to switch then staying with Guava's is perfectly fine. I would not use their `asMap().compute` as a wonky implementation given it was added so late (and you don't use it, so that's fine). Guava's is robust but not actively maintained (CacheBuilder's JavaDoc recommends Caffeine). The most common cause for tests to fail during a migration is that Caffeine switches eviction and listeners to be executed async by default, whereas Guava piggybacks on the calling thread. You can emulate that using `Caffeine.executor(Runnable::run)` if desired. The problem is that often tests assumed no concurrency (immediate eviction or callbacks invoked) and that is no longer a valid assumption. In both cache's their internal logic is very inexpensive (e.g. LRU reordering), but we do not know the cost of the user's callback. Since the JVM now offers shared threads and Caffeine offers an AsyncCache, defaulting to async to minimize user-facing latencies seemed like a reasonable choice. There are other subtle differences, such as if assuming lru eviction order, so you might want to review this [migration page](https://github.com/ben-manes/caffeine/wiki/Guava). Whatever you decide to do is fine with me. Feel welcome to reach out if you have any questions or concerns. Issue Time Tracking --- Worklog Id: (was: 869681) Time Spent: 1h 40m (was: 1.5h) > Replace Guava cache with Caffeine > - > > Key: ARTEMIS-4349 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4349 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.29.0 >Reporter: Alexey Markevich >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4349) Replace Guava cache with Caffeine
[ https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=869680=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869680 ] ASF GitHub Bot logged work on ARTEMIS-4349: --- Author: ASF GitHub Bot Created on: 07/Jul/23 00:54 Start Date: 07/Jul/23 00:54 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4540: URL: https://github.com/apache/activemq-artemis/pull/4540#issuecomment-1624485692 apparently there are a lot of test failures if running this. leave it with me for another day please so I can check if it was a real failure or a build issue. Issue Time Tracking --- Worklog Id: (was: 869680) Time Spent: 1.5h (was: 1h 20m) > Replace Guava cache with Caffeine > - > > Key: ARTEMIS-4349 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4349 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.29.0 >Reporter: Alexey Markevich >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4331) Upgrade JGroups
[
https://issues.apache.org/jira/browse/ARTEMIS-4331?focusedWorklogId=869668=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869668
]
ASF GitHub Bot logged work on ARTEMIS-4331:
---
Author: ASF GitHub Bot
Created on: 06/Jul/23 20:47
Start Date: 06/Jul/23 20:47
Worklog Time Spent: 10m
Work Description: erwindon commented on PR #4524:
URL:
https://github.com/apache/activemq-artemis/pull/4524#issuecomment-1624289644
Artemis build procedure works fine for current jgroups version 5.2.0.
jgroups 5.2.1 does not exist.
Artemis build procedure works fine for jgroups version 5.2.2.
jgroups 5.2.3 does not exist.
Artemis build procedure with jgroups 5.2.4+ fails in 'artemis-features'.
rebase did not change anything about that.
@jbertram
unfortunately, I have to give up here as this is unknown territory...
Issue Time Tracking
---
Worklog Id: (was: 869668)
Time Spent: 1h 10m (was: 1h)
> Upgrade JGroups
> ---
>
> Key: ARTEMIS-4331
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4331
> Project: ActiveMQ Artemis
> Issue Type: Dependency upgrade
> Components: clustering
>Affects Versions: 2.29.0
>Reporter: Erwin Dondorp
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I encountered a NPE in the JGROUPS facility of Artemis.
> I found that it was already solved upstream in
> https://issues.redhat.com/browse/JGRP-2707
> hereby requesting that the updated JGroups is included in Artemis.
> {noformat}
> 2023-06-23 14:37:59,999 INFO [org.apache.activemq.artemis] AMQ241004:
> Artemis Console available at http://0.0.0.0:8161/console
> java.lang.NullPointerException
> at
> org.jgroups.protocols.FD_SOCK2.getPhysicalAddresses(FD_SOCK2.java:440)
> at org.jgroups.protocols.FD_SOCK2.connectTo(FD_SOCK2.java:390)
> at
> org.jgroups.protocols.FD_SOCK2.connectToNextPingDest(FD_SOCK2.java:371)
> at org.jgroups.protocols.FD_SOCK2.handle(FD_SOCK2.java:342)
> at org.jgroups.protocols.FD_SOCK2.handle(FD_SOCK2.java:31)
> ...
> {noformat}
> (first line is not part of the error message, but provided as context)
> current version of jgroups is 5.2.0.Final, fix version is 5.2.15
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4349) Replace Guava cache with Caffeine
[ https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=869661=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869661 ] ASF GitHub Bot logged work on ARTEMIS-4349: --- Author: ASF GitHub Bot Created on: 06/Jul/23 20:30 Start Date: 06/Jul/23 20:30 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4540: URL: https://github.com/apache/activemq-artemis/pull/4540#issuecomment-1624272168 Guava itself is much more than just the cache, but if you're comparing Guava Cache vs. Caffeine then I think more folks are using Caffeine. Also, since Guava is a lot more than just a cache that means Caffeine is much smaller and will likely reduce risk of CVEs. Issue Time Tracking --- Worklog Id: (was: 869661) Time Spent: 1h 20m (was: 1h 10m) > Replace Guava cache with Caffeine > - > > Key: ARTEMIS-4349 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4349 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.29.0 >Reporter: Alexey Markevich >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4349) Replace Guava cache with Caffeine
[ https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=869660=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869660 ] ASF GitHub Bot logged work on ARTEMIS-4349: --- Author: ASF GitHub Bot Created on: 06/Jul/23 20:29 Start Date: 06/Jul/23 20:29 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4540: URL: https://github.com/apache/activemq-artemis/pull/4540#issuecomment-1624271282 I'm running the whole test suite with these changes (on a separate CI). If caffeine has a bigger community, the jar is smaller, I think we should bring this right away (if tests are ok of course). my initial concern was about the community support and CVEs.. but from what I later gathered this is actually better. performance wise I think the differences would be impossible to measure. We currently use some login changes from Security as Justin mentioned... but you would have to use the cache quite a lot to have any significant result. I think we should merge this, but not much for the performance reasons. anyone has anything against that? Issue Time Tracking --- Worklog Id: (was: 869660) Time Spent: 1h 10m (was: 1h) > Replace Guava cache with Caffeine > - > > Key: ARTEMIS-4349 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4349 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.29.0 >Reporter: Alexey Markevich >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4349) Replace Guava cache with Caffeine
[ https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=869655=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869655 ] ASF GitHub Bot logged work on ARTEMIS-4349: --- Author: ASF GitHub Bot Created on: 06/Jul/23 19:57 Start Date: 06/Jul/23 19:57 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4540: URL: https://github.com/apache/activemq-artemis/pull/4540#issuecomment-1624235147 @jbertram based on what you said it sounds like caffeine has a bigger community than guava? that would be a good reason for the replacement by itself. Issue Time Tracking --- Worklog Id: (was: 869655) Time Spent: 1h (was: 50m) > Replace Guava cache with Caffeine > - > > Key: ARTEMIS-4349 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4349 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.29.0 >Reporter: Alexey Markevich >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4349) Replace Guava cache with Caffeine
[ https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=869652=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869652 ] ASF GitHub Bot logged work on ARTEMIS-4349: --- Author: ASF GitHub Bot Created on: 06/Jul/23 19:08 Start Date: 06/Jul/23 19:08 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4540: URL: https://github.com/apache/activemq-artemis/pull/4540#issuecomment-1624181340 Caffeine is essentially the successor to Google's Guava Cache. It's used by a lot of projects. Spring, for example, started moving [away from Guava to Caffeine in 2015](https://github.com/spring-projects/spring-framework/issues/18370). I considered using Caffeine when I first started using Guava Cache on [ARTEMIS-2886](https://issues.apache.org/jira/browse/ARTEMIS-2886), but I decided on Guava mainly because we already had a dependency on it. This PR completely removes Guava from the code-base in lieu of Caffeine which is fine by me. My only real concern is essentially the same as Tim's which I put on [ARTEMIS-4349](https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedCommentId=17740337=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17740337). Changing Caffeine for the sake of performance doesn't make much sense without clear data that changing will actually make any meaningful difference. At this point we don't have that data. Issue Time Tracking --- Worklog Id: (was: 869652) Time Spent: 50m (was: 40m) > Replace Guava cache with Caffeine > - > > Key: ARTEMIS-4349 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4349 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.29.0 >Reporter: Alexey Markevich >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4349) Replace Guava cache with Caffeine
[ https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=869651=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869651 ] ASF GitHub Bot logged work on ARTEMIS-4349: --- Author: ASF GitHub Bot Created on: 06/Jul/23 19:02 Start Date: 06/Jul/23 19:02 Worklog Time Spent: 10m Work Description: tabish121 commented on PR #4540: URL: https://github.com/apache/activemq-artemis/pull/4540#issuecomment-1624175542 I'm no fan of guava but my first question on any change like this is what benefit if any does it actually impart? Is there some measurable performance improvement worth changing it now vs at some later stage like a major version bump where these types of changes are more expected? (e.g. Artemis 3.0) Issue Time Tracking --- Worklog Id: (was: 869651) Time Spent: 40m (was: 0.5h) > Replace Guava cache with Caffeine > - > > Key: ARTEMIS-4349 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4349 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.29.0 >Reporter: Alexey Markevich >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4349) Replace Guava cache with Caffeine
[ https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=869650=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869650 ] ASF GitHub Bot logged work on ARTEMIS-4349: --- Author: ASF GitHub Bot Created on: 06/Jul/23 18:50 Start Date: 06/Jul/23 18:50 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4540: URL: https://github.com/apache/activemq-artemis/pull/4540#issuecomment-1624160862 well.. at least some initial googling shows that they are active on fixing this: https://security.snyk.io/package/maven/com.github.ben-manes.caffeine:caffeine any opinions? Issue Time Tracking --- Worklog Id: (was: 869650) Time Spent: 0.5h (was: 20m) > Replace Guava cache with Caffeine > - > > Key: ARTEMIS-4349 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4349 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.29.0 >Reporter: Alexey Markevich >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4349) Replace Guava cache with Caffeine
[ https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=869649=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869649 ] ASF GitHub Bot logged work on ARTEMIS-4349: --- Author: ASF GitHub Bot Created on: 06/Jul/23 18:48 Start Date: 06/Jul/23 18:48 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4540: URL: https://github.com/apache/activemq-artemis/pull/4540#issuecomment-1624158604 any idea how active is Caffeine? more specifically how good are them with fixing CVEs? there was a couple of CVEs in the past with guava. https://www.cvedetails.com/product/52274/Google-Guava.html?vendor_id=1224 and we had to update the version before. my concern with the replacement is how good would be fix things like these? Issue Time Tracking --- Worklog Id: (was: 869649) Time Spent: 20m (was: 10m) > Replace Guava cache with Caffeine > - > > Key: ARTEMIS-4349 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4349 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.29.0 >Reporter: Alexey Markevich >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4331) Upgrade JGroups
[
https://issues.apache.org/jira/browse/ARTEMIS-4331?focusedWorklogId=869623=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869623
]
ASF GitHub Bot logged work on ARTEMIS-4331:
---
Author: ASF GitHub Bot
Created on: 06/Jul/23 16:34
Start Date: 06/Jul/23 16:34
Worklog Time Spent: 10m
Work Description: erwindon commented on PR #4524:
URL:
https://github.com/apache/activemq-artemis/pull/4524#issuecomment-1623978253
checks failing with "Unable to resolve
wrap_file__home_runner_.m2_repository_org_jgroups_jgroups_5.2.16.Final_jgroups-5.2.16.Final.jar/0.0.0:
missing requirement[...]"
so seems related
back to local development...
Issue Time Tracking
---
Worklog Id: (was: 869623)
Time Spent: 1h (was: 50m)
> Upgrade JGroups
> ---
>
> Key: ARTEMIS-4331
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4331
> Project: ActiveMQ Artemis
> Issue Type: Dependency upgrade
> Components: clustering
>Affects Versions: 2.29.0
>Reporter: Erwin Dondorp
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I encountered a NPE in the JGROUPS facility of Artemis.
> I found that it was already solved upstream in
> https://issues.redhat.com/browse/JGRP-2707
> hereby requesting that the updated JGroups is included in Artemis.
> {noformat}
> 2023-06-23 14:37:59,999 INFO [org.apache.activemq.artemis] AMQ241004:
> Artemis Console available at http://0.0.0.0:8161/console
> java.lang.NullPointerException
> at
> org.jgroups.protocols.FD_SOCK2.getPhysicalAddresses(FD_SOCK2.java:440)
> at org.jgroups.protocols.FD_SOCK2.connectTo(FD_SOCK2.java:390)
> at
> org.jgroups.protocols.FD_SOCK2.connectToNextPingDest(FD_SOCK2.java:371)
> at org.jgroups.protocols.FD_SOCK2.handle(FD_SOCK2.java:342)
> at org.jgroups.protocols.FD_SOCK2.handle(FD_SOCK2.java:31)
> ...
> {noformat}
> (first line is not part of the error message, but provided as context)
> current version of jgroups is 5.2.0.Final, fix version is 5.2.15
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4340) ByteUtil.uncheckedZeros throws IndexOutOfBoundsException in else condition
[ https://issues.apache.org/jira/browse/ARTEMIS-4340?focusedWorklogId=869618=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869618 ] ASF GitHub Bot logged work on ARTEMIS-4340: --- Author: ASF GitHub Bot Created on: 06/Jul/23 16:19 Start Date: 06/Jul/23 16:19 Worklog Time Spent: 10m Work Description: tabish121 commented on PR #4533: URL: https://github.com/apache/activemq-artemis/pull/4533#issuecomment-1623959294 LGTM Issue Time Tracking --- Worklog Id: (was: 869618) Time Spent: 1h (was: 50m) > ByteUtil.uncheckedZeros throws IndexOutOfBoundsException in else condition > -- > > Key: ARTEMIS-4340 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4340 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.22.0 > Environment: Windows 10, Linux >Reporter: David Hoffer >Assignee: Robbie Gemmell >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > In artemis-commons: > ByteUtil.uncheckedZeros throws IndexOutOfBoundsException in the else part of > the method. > The code in the else part is looping through number of bytes specified by > bytes input parameter which is often provided by buffer.capacity(), but then > the code at > buffer.put(i + offset, zero) where buffer is of DirectByteBuffer type calls > checkIndex(int i) and it throws if i is >= limit. > But limit is not the same as capacity in a Buffer. In our case capacity is > 4096 and limit is 16 so method always throws IndexOutOfBoundsException if the > else case is executed as soon as i ==16. > This code is called when Artemis is launched and it validates/creates the > various bindings files. This causes Artemis to fail to load properly. > Note I believe all versions of artemis-commons has this bug but I currently > am testing with 2.22.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4331) Upgrade JGroups
[
https://issues.apache.org/jira/browse/ARTEMIS-4331?focusedWorklogId=869615=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869615
]
ASF GitHub Bot logged work on ARTEMIS-4331:
---
Author: ASF GitHub Bot
Created on: 06/Jul/23 16:13
Start Date: 06/Jul/23 16:13
Worklog Time Spent: 10m
Work Description: erwindon commented on PR #4524:
URL:
https://github.com/apache/activemq-artemis/pull/4524#issuecomment-1623950965
Jgroups 5.2.15.Final has been published.
But also its successor 5.2.16.Final is already there.
I've updated the PR to use 5.2.16.Final.
Issue Time Tracking
---
Worklog Id: (was: 869615)
Time Spent: 50m (was: 40m)
> Upgrade JGroups
> ---
>
> Key: ARTEMIS-4331
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4331
> Project: ActiveMQ Artemis
> Issue Type: Dependency upgrade
> Components: clustering
>Affects Versions: 2.29.0
>Reporter: Erwin Dondorp
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I encountered a NPE in the JGROUPS facility of Artemis.
> I found that it was already solved upstream in
> https://issues.redhat.com/browse/JGRP-2707
> hereby requesting that the updated JGroups is included in Artemis.
> {noformat}
> 2023-06-23 14:37:59,999 INFO [org.apache.activemq.artemis] AMQ241004:
> Artemis Console available at http://0.0.0.0:8161/console
> java.lang.NullPointerException
> at
> org.jgroups.protocols.FD_SOCK2.getPhysicalAddresses(FD_SOCK2.java:440)
> at org.jgroups.protocols.FD_SOCK2.connectTo(FD_SOCK2.java:390)
> at
> org.jgroups.protocols.FD_SOCK2.connectToNextPingDest(FD_SOCK2.java:371)
> at org.jgroups.protocols.FD_SOCK2.handle(FD_SOCK2.java:342)
> at org.jgroups.protocols.FD_SOCK2.handle(FD_SOCK2.java:31)
> ...
> {noformat}
> (first line is not part of the error message, but provided as context)
> current version of jgroups is 5.2.0.Final, fix version is 5.2.15
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (ARTEMIS-4350) MQTT queue creation does not honor the delimiter and always uses '.'
[
https://issues.apache.org/jira/browse/ARTEMIS-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erwin Dondorp closed ARTEMIS-4350.
--
Resolution: Won't Fix
too much work and risk
> MQTT queue creation does not honor the delimiter and always uses '.'
>
>
> Key: ARTEMIS-4350
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4350
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: MQTT
>Affects Versions: 2.29.0
>Reporter: Erwin Dondorp
>Priority: Minor
> Attachments: 1.png, 2.png
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> When subscribing using an MQTT client on an address, a subscription queue is
> created.
> For MQTT, the subscription-queue has a name that is constructed using the
> client-id and the address-name. The parts are always joined using the {{.}}
> character.
> It is more consistent when the _delimiter_ character is used for that.
> a PR will be added
> using {{/}} as separator, before:
> !1.png!
> using {{/}} as separator, after:
> !2.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4350) MQTT queue creation does not honor the delimiter and always uses '.'
[
https://issues.apache.org/jira/browse/ARTEMIS-4350?focusedWorklogId=869612=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869612
]
ASF GitHub Bot logged work on ARTEMIS-4350:
---
Author: ASF GitHub Bot
Created on: 06/Jul/23 15:50
Start Date: 06/Jul/23 15:50
Worklog Time Spent: 10m
Work Description: erwindon closed pull request #4541: ARTEMIS-4350 use
consistent delimiters when constructing mqtt subscription queues
URL: https://github.com/apache/activemq-artemis/pull/4541
Issue Time Tracking
---
Worklog Id: (was: 869612)
Time Spent: 1h 20m (was: 1h 10m)
> MQTT queue creation does not honor the delimiter and always uses '.'
>
>
> Key: ARTEMIS-4350
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4350
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: MQTT
>Affects Versions: 2.29.0
>Reporter: Erwin Dondorp
>Priority: Minor
> Attachments: 1.png, 2.png
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> When subscribing using an MQTT client on an address, a subscription queue is
> created.
> For MQTT, the subscription-queue has a name that is constructed using the
> client-id and the address-name. The parts are always joined using the {{.}}
> character.
> It is more consistent when the _delimiter_ character is used for that.
> a PR will be added
> using {{/}} as separator, before:
> !1.png!
> using {{/}} as separator, after:
> !2.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4350) MQTT queue creation does not honor the delimiter and always uses '.'
[
https://issues.apache.org/jira/browse/ARTEMIS-4350?focusedWorklogId=869611=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869611
]
ASF GitHub Bot logged work on ARTEMIS-4350:
---
Author: ASF GitHub Bot
Created on: 06/Jul/23 15:50
Start Date: 06/Jul/23 15:50
Worklog Time Spent: 10m
Work Description: erwindon commented on PR #4541:
URL:
https://github.com/apache/activemq-artemis/pull/4541#issuecomment-1623913252
> checkstyle issues
ah, sorry, my local build did not croak on that. adjusted+pushed.
And the rest of my comments have become obsolete after the recommendations
from @jbertram and @gemmellr.
Issue Time Tracking
---
Worklog Id: (was: 869611)
Time Spent: 1h 10m (was: 1h)
> MQTT queue creation does not honor the delimiter and always uses '.'
>
>
> Key: ARTEMIS-4350
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4350
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: MQTT
>Affects Versions: 2.29.0
>Reporter: Erwin Dondorp
>Priority: Minor
> Attachments: 1.png, 2.png
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When subscribing using an MQTT client on an address, a subscription queue is
> created.
> For MQTT, the subscription-queue has a name that is constructed using the
> client-id and the address-name. The parts are always joined using the {{.}}
> character.
> It is more consistent when the _delimiter_ character is used for that.
> a PR will be added
> using {{/}} as separator, before:
> !1.png!
> using {{/}} as separator, after:
> !2.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4350) MQTT queue creation does not honor the delimiter and always uses '.'
[
https://issues.apache.org/jira/browse/ARTEMIS-4350?focusedWorklogId=869608=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869608
]
ASF GitHub Bot logged work on ARTEMIS-4350:
---
Author: ASF GitHub Bot
Created on: 06/Jul/23 15:48
Start Date: 06/Jul/23 15:48
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #4541:
URL:
https://github.com/apache/activemq-artemis/pull/4541#issuecomment-1623910314
I wouldn't change it in this way either. It is a breaking change as Justin
says, very questionable for whats only marked as a 'minor improvement', and as
the ClientID and address are ultimately distinct things and the wildcard
deliminator is about the address its also not clear to me either that this
would really be 'more consistent'.
Issue Time Tracking
---
Worklog Id: (was: 869608)
Time Spent: 1h (was: 50m)
> MQTT queue creation does not honor the delimiter and always uses '.'
>
>
> Key: ARTEMIS-4350
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4350
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: MQTT
>Affects Versions: 2.29.0
>Reporter: Erwin Dondorp
>Priority: Minor
> Attachments: 1.png, 2.png
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When subscribing using an MQTT client on an address, a subscription queue is
> created.
> For MQTT, the subscription-queue has a name that is constructed using the
> client-id and the address-name. The parts are always joined using the {{.}}
> character.
> It is more consistent when the _delimiter_ character is used for that.
> a PR will be added
> using {{/}} as separator, before:
> !1.png!
> using {{/}} as separator, after:
> !2.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4350) MQTT queue creation does not honor the delimiter and always uses '.'
[
https://issues.apache.org/jira/browse/ARTEMIS-4350?focusedWorklogId=869603=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869603
]
ASF GitHub Bot logged work on ARTEMIS-4350:
---
Author: ASF GitHub Bot
Created on: 06/Jul/23 15:35
Start Date: 06/Jul/23 15:35
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #4541:
URL:
https://github.com/apache/activemq-artemis/pull/4541#issuecomment-1623890430
I do believe this will break compatibility for users who upgrade and also
have existing MQTT subscriptions and a non-default wildcard configuration
(which is fairly common among folks who use the broker mainly for MQTT).
Furthermore, I'm not entirely sure this is actually more consistent overall.
Using the configured delimiter instead of `.` is certainly more consistent with
MQTT syntax, but the name of the queue is an internal implementation detail and
`.` characters are used in other places for queue names so now this name is
inconsistent with that.
I think this should probably just stay the way it is.
Issue Time Tracking
---
Worklog Id: (was: 869603)
Time Spent: 50m (was: 40m)
> MQTT queue creation does not honor the delimiter and always uses '.'
>
>
> Key: ARTEMIS-4350
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4350
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: MQTT
>Affects Versions: 2.29.0
>Reporter: Erwin Dondorp
>Priority: Minor
> Attachments: 1.png, 2.png
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When subscribing using an MQTT client on an address, a subscription queue is
> created.
> For MQTT, the subscription-queue has a name that is constructed using the
> client-id and the address-name. The parts are always joined using the {{.}}
> character.
> It is more consistent when the _delimiter_ character is used for that.
> a PR will be added
> using {{/}} as separator, before:
> !1.png!
> using {{/}} as separator, after:
> !2.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4332) Add management method to close stuck server sessions
[
https://issues.apache.org/jira/browse/ARTEMIS-4332?focusedWorklogId=869602=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869602
]
ASF GitHub Bot logged work on ARTEMIS-4332:
---
Author: ASF GitHub Bot
Created on: 06/Jul/23 15:34
Start Date: 06/Jul/23 15:34
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #4526:
URL: https://github.com/apache/activemq-artemis/pull/4526#discussion_r1254609777
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java:
##
@@ -104,6 +107,29 @@ public static void setContext(final OperationContext
context) {
private final Executor executor;
+ public static final String MAX_STORE_OPERATION_TRACKERS_PROP =
"artemis.maxStoreOperationTrackers";
+
+ private static int maxStoreOperationTrackers = -1;
Review Comment:
What about `ARTEMIS_OPCONTEXT_MAX_DEBUG_TRACKERS`/`maxDebugTrackers` ?
Issue Time Tracking
---
Worklog Id: (was: 869602)
Time Spent: 1h 10m (was: 1h)
> Add management method to close stuck server sessions
>
>
> Key: ARTEMIS-4332
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4332
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> In rare cases a store operation could silently fails or starves, blocking the
> related server session and all delivering messages. Those server sessions can
> be closed adding a management method that cleans their operation context
> before closing them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4350) MQTT queue creation does not honor the delimiter and always uses '.'
[
https://issues.apache.org/jira/browse/ARTEMIS-4350?focusedWorklogId=869590=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869590
]
ASF GitHub Bot logged work on ARTEMIS-4350:
---
Author: ASF GitHub Bot
Created on: 06/Jul/23 14:59
Start Date: 06/Jul/23 14:59
Worklog Time Spent: 10m
Work Description: tabish121 commented on PR #4541:
URL:
https://github.com/apache/activemq-artemis/pull/4541#issuecomment-1623834954
I would also recommend spending time on adding tests, as the PR has none
now.
Issue Time Tracking
---
Worklog Id: (was: 869590)
Time Spent: 40m (was: 0.5h)
> MQTT queue creation does not honor the delimiter and always uses '.'
>
>
> Key: ARTEMIS-4350
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4350
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: MQTT
>Affects Versions: 2.29.0
>Reporter: Erwin Dondorp
>Priority: Minor
> Attachments: 1.png, 2.png
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When subscribing using an MQTT client on an address, a subscription queue is
> created.
> For MQTT, the subscription-queue has a name that is constructed using the
> client-id and the address-name. The parts are always joined using the {{.}}
> character.
> It is more consistent when the _delimiter_ character is used for that.
> a PR will be added
> using {{/}} as separator, before:
> !1.png!
> using {{/}} as separator, after:
> !2.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4350) MQTT queue creation does not honor the delimiter and always uses '.'
[
https://issues.apache.org/jira/browse/ARTEMIS-4350?focusedWorklogId=869586=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869586
]
ASF GitHub Bot logged work on ARTEMIS-4350:
---
Author: ASF GitHub Bot
Created on: 06/Jul/23 14:56
Start Date: 06/Jul/23 14:56
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #4541:
URL:
https://github.com/apache/activemq-artemis/pull/4541#issuecomment-1623830540
@erwindon checkstyle issues ^^
but we should spend some time on the compatibility
Issue Time Tracking
---
Worklog Id: (was: 869586)
Time Spent: 0.5h (was: 20m)
> MQTT queue creation does not honor the delimiter and always uses '.'
>
>
> Key: ARTEMIS-4350
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4350
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: MQTT
>Affects Versions: 2.29.0
>Reporter: Erwin Dondorp
>Priority: Minor
> Attachments: 1.png, 2.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When subscribing using an MQTT client on an address, a subscription queue is
> created.
> For MQTT, the subscription-queue has a name that is constructed using the
> client-id and the address-name. The parts are always joined using the {{.}}
> character.
> It is more consistent when the _delimiter_ character is used for that.
> a PR will be added
> using {{/}} as separator, before:
> !1.png!
> using {{/}} as separator, after:
> !2.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4350) MQTT queue creation does not honor the delimiter and always uses '.'
[
https://issues.apache.org/jira/browse/ARTEMIS-4350?focusedWorklogId=869579=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869579
]
ASF GitHub Bot logged work on ARTEMIS-4350:
---
Author: ASF GitHub Bot
Created on: 06/Jul/23 14:48
Start Date: 06/Jul/23 14:48
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #4541:
URL:
https://github.com/apache/activemq-artemis/pull/4541#issuecomment-1623816634
@jbertram can you look into this?
@jbertram , @erwindon what about compatibility with previous versions?
usually compatibility is a deterrent for things like this.
Issue Time Tracking
---
Worklog Id: (was: 869579)
Time Spent: 20m (was: 10m)
> MQTT queue creation does not honor the delimiter and always uses '.'
>
>
> Key: ARTEMIS-4350
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4350
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: MQTT
>Affects Versions: 2.29.0
>Reporter: Erwin Dondorp
>Priority: Minor
> Attachments: 1.png, 2.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When subscribing using an MQTT client on an address, a subscription queue is
> created.
> For MQTT, the subscription-queue has a name that is constructed using the
> client-id and the address-name. The parts are always joined using the {{.}}
> character.
> It is more consistent when the _delimiter_ character is used for that.
> a PR will be added
> using {{/}} as separator, before:
> !1.png!
> using {{/}} as separator, after:
> !2.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4332) Add management method to close stuck server sessions
[
https://issues.apache.org/jira/browse/ARTEMIS-4332?focusedWorklogId=869576=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869576
]
ASF GitHub Bot logged work on ARTEMIS-4332:
---
Author: ASF GitHub Bot
Created on: 06/Jul/23 14:34
Start Date: 06/Jul/23 14:34
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4526:
URL: https://github.com/apache/activemq-artemis/pull/4526#discussion_r1254532745
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java:
##
@@ -104,6 +107,29 @@ public static void setContext(final OperationContext
context) {
private final Executor executor;
+ public static final String MAX_STORE_OPERATION_TRACKERS_PROP =
"artemis.maxStoreOperationTrackers";
+
+ private static int maxStoreOperationTrackers = -1;
Review Comment:
- I think this should be final
and it should be initialized with a static initializer, or simply use the
System.getProperty straight away.
{
}
- Also the property name. and the pattern used here.
RefCountMessage used a different pattern. I think we should stick to the
same pattern used in there.
ARTEMIS_
and maxStoreOperationsTrackers.. it doesn't not really translate to anything
unless I read the code and understand what is doing.
I'm not sure what better name we could use (I'm terrible with names). but
what about:
ARTEMIS_OPCONTEXT_TRACKER_NUMBER?
And some javadoc of what it does?
Issue Time Tracking
---
Worklog Id: (was: 869576)
Time Spent: 1h (was: 50m)
> Add management method to close stuck server sessions
>
>
> Key: ARTEMIS-4332
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4332
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In rare cases a store operation could silently fails or starves, blocking the
> related server session and all delivering messages. Those server sessions can
> be closed adding a management method that cleans their operation context
> before closing them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4318) Architecture documentation links to deprecated library "Airline"
[ https://issues.apache.org/jira/browse/ARTEMIS-4318?focusedWorklogId=869562=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869562 ] ASF GitHub Bot logged work on ARTEMIS-4318: --- Author: ASF GitHub Bot Created on: 06/Jul/23 13:40 Start Date: 06/Jul/23 13:40 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4516: URL: https://github.com/apache/activemq-artemis/pull/4516#issuecomment-1623702088 FWIW, I was never able to get in touch with Rob. Issue Time Tracking --- Worklog Id: (was: 869562) Time Spent: 1h 10m (was: 1h) > Architecture documentation links to deprecated library "Airline" > > > Key: ARTEMIS-4318 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4318 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.28.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Major > Labels: deprecated, documentation, library > Time Spent: 1h 10m > Remaining Estimate: 0h > > There's a link on this page (under "Stand-alone Broker") to a project called > "Airline" which is deprecated: > https://activemq.apache.org/components/artemis/documentation/latest/architecture.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4318) Architecture documentation links to deprecated library "Airline"
[ https://issues.apache.org/jira/browse/ARTEMIS-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740605#comment-17740605 ] ASF subversion and git services commented on ARTEMIS-4318: -- Commit 4b91d1d57e7387df4865fab5005a05d139c30a5e in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=4b91d1d57e ] ARTEMIS-4318 migrate to Airline 2 The "Airline" library we're currently using is deprecated according the GitHub project - https://github.com/airlift/airline. It recommends using either Airline 2 or Picocli. The former offers the simplest migration path as it's almost completely compatible with the current code. This commit implements that migration. > Architecture documentation links to deprecated library "Airline" > > > Key: ARTEMIS-4318 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4318 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.28.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Major > Labels: deprecated, documentation, library > Time Spent: 1h > Remaining Estimate: 0h > > There's a link on this page (under "Stand-alone Broker") to a project called > "Airline" which is deprecated: > https://activemq.apache.org/components/artemis/documentation/latest/architecture.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4318) Architecture documentation links to deprecated library "Airline"
[ https://issues.apache.org/jira/browse/ARTEMIS-4318?focusedWorklogId=869561=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869561 ] ASF GitHub Bot logged work on ARTEMIS-4318: --- Author: ASF GitHub Bot Created on: 06/Jul/23 13:36 Start Date: 06/Jul/23 13:36 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4516: URL: https://github.com/apache/activemq-artemis/pull/4516 Issue Time Tracking --- Worklog Id: (was: 869561) Time Spent: 1h (was: 50m) > Architecture documentation links to deprecated library "Airline" > > > Key: ARTEMIS-4318 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4318 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.28.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Major > Labels: deprecated, documentation, library > Time Spent: 1h > Remaining Estimate: 0h > > There's a link on this page (under "Stand-alone Broker") to a project called > "Airline" which is deprecated: > https://activemq.apache.org/components/artemis/documentation/latest/architecture.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4318) Architecture documentation links to deprecated library "Airline"
[ https://issues.apache.org/jira/browse/ARTEMIS-4318?focusedWorklogId=869559=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869559 ] ASF GitHub Bot logged work on ARTEMIS-4318: --- Author: ASF GitHub Bot Created on: 06/Jul/23 13:30 Start Date: 06/Jul/23 13:30 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4516: URL: https://github.com/apache/activemq-artemis/pull/4516#issuecomment-1623688227 @jbertram @brusdev I am thinking we should merge this. Airlift has been pretty stable for us. at the worst case we can eventually fork it if it needed. Issue Time Tracking --- Worklog Id: (was: 869559) Time Spent: 50m (was: 40m) > Architecture documentation links to deprecated library "Airline" > > > Key: ARTEMIS-4318 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4318 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.28.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Major > Labels: deprecated, documentation, library > Time Spent: 50m > Remaining Estimate: 0h > > There's a link on this page (under "Stand-alone Broker") to a project called > "Airline" which is deprecated: > https://activemq.apache.org/components/artemis/documentation/latest/architecture.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4338) STOMP inoperable w/resource audit logging enabled
[
https://issues.apache.org/jira/browse/ARTEMIS-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740553#comment-17740553
]
ASF subversion and git services commented on ARTEMIS-4338:
--
Commit 2d1a8661fd58ba26e5353b53799344a3f9b58d58 in activemq-artemis's branch
refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=2d1a8661fd ]
ARTEMIS-4338 STOMP inoperable w/resource audit logging
When resource audit logging is enabled STOMP is completely inoperable
due to an NPE during the protocol handshake. Unfortunately the failure
is completely silent. There are no logs to indicate a problem.
This commit fixes this problem via the following changes:
- Mitigate the original NPE via a check for null
- Move the logic necessary to set the "protocol connection" on the
"transport connection" to a class shared by all implementations.
- Add exception handling to log failures like this in the future.
- Add tests to ensure the audit logging is correct.
> STOMP inoperable w/resource audit logging enabled
> -
>
> Key: ARTEMIS-4338
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4338
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: STOMP
>Affects Versions: 2.29.0
>Reporter: Otavio Rodolfo Piske
>Assignee: Justin Bertram
>Priority: Blocker
> Attachments: camel-stomp-test-debug-2.28.0.log,
> camel-stomp-test-debug-2.29.0.log
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Recently we tried upgrading to Artemis 2.29, but when doing so our
> integration tests started to fail. No code was changed as part of the upgrade.
> With 2.29, the connection seems to fail due to a connection timeout:
>
> {noformat}
> 2023-06-29 07:51:40,739 [Impl$6@b91d8c4)] WARN server
> - AMQ222067: Connection failure has been detected: AMQ229014: Did not
> receive data from /127.0.0.1:50934 within the 6ms connection TTL. The
> connection will now be closed. [code=CONNECTION_TIMEDOUT]{noformat}
>
> I wasn't able to determine the problem, so I am attaching the debug logs for
> an execution with 2.28 and another with 2.29.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (ARTEMIS-4338) STOMP inoperable w/resource audit logging enabled
[
https://issues.apache.org/jira/browse/ARTEMIS-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell resolved ARTEMIS-4338.
-
Fix Version/s: 2.30.0
Resolution: Fixed
> STOMP inoperable w/resource audit logging enabled
> -
>
> Key: ARTEMIS-4338
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4338
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: STOMP
>Affects Versions: 2.29.0
>Reporter: Otavio Rodolfo Piske
>Assignee: Justin Bertram
>Priority: Blocker
> Fix For: 2.30.0
>
> Attachments: camel-stomp-test-debug-2.28.0.log,
> camel-stomp-test-debug-2.29.0.log
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Recently we tried upgrading to Artemis 2.29, but when doing so our
> integration tests started to fail. No code was changed as part of the upgrade.
> With 2.29, the connection seems to fail due to a connection timeout:
>
> {noformat}
> 2023-06-29 07:51:40,739 [Impl$6@b91d8c4)] WARN server
> - AMQ222067: Connection failure has been detected: AMQ229014: Did not
> receive data from /127.0.0.1:50934 within the 6ms connection TTL. The
> connection will now be closed. [code=CONNECTION_TIMEDOUT]{noformat}
>
> I wasn't able to determine the problem, so I am attaching the debug logs for
> an execution with 2.28 and another with 2.29.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4338) STOMP inoperable w/resource audit logging enabled
[
https://issues.apache.org/jira/browse/ARTEMIS-4338?focusedWorklogId=869539=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869539
]
ASF GitHub Bot logged work on ARTEMIS-4338:
---
Author: ASF GitHub Bot
Created on: 06/Jul/23 11:08
Start Date: 06/Jul/23 11:08
Worklog Time Spent: 10m
Work Description: gemmellr merged PR #4530:
URL: https://github.com/apache/activemq-artemis/pull/4530
Issue Time Tracking
---
Worklog Id: (was: 869539)
Time Spent: 1h 40m (was: 1.5h)
> STOMP inoperable w/resource audit logging enabled
> -
>
> Key: ARTEMIS-4338
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4338
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: STOMP
>Affects Versions: 2.29.0
>Reporter: Otavio Rodolfo Piske
>Assignee: Justin Bertram
>Priority: Blocker
> Attachments: camel-stomp-test-debug-2.28.0.log,
> camel-stomp-test-debug-2.29.0.log
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Recently we tried upgrading to Artemis 2.29, but when doing so our
> integration tests started to fail. No code was changed as part of the upgrade.
> With 2.29, the connection seems to fail due to a connection timeout:
>
> {noformat}
> 2023-06-29 07:51:40,739 [Impl$6@b91d8c4)] WARN server
> - AMQ222067: Connection failure has been detected: AMQ229014: Did not
> receive data from /127.0.0.1:50934 within the 6ms connection TTL. The
> connection will now be closed. [code=CONNECTION_TIMEDOUT]{noformat}
>
> I wasn't able to determine the problem, so I am attaching the debug logs for
> an execution with 2.28 and another with 2.29.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4350) MQTT queue creation does not honor the delimiter and always uses '.'
[
https://issues.apache.org/jira/browse/ARTEMIS-4350?focusedWorklogId=869527=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869527
]
ASF GitHub Bot logged work on ARTEMIS-4350:
---
Author: ASF GitHub Bot
Created on: 06/Jul/23 10:23
Start Date: 06/Jul/23 10:23
Worklog Time Spent: 10m
Work Description: erwindon opened a new pull request, #4541:
URL: https://github.com/apache/activemq-artemis/pull/4541
see https://issues.apache.org/jira/browse/ARTEMIS-4350
Issue Time Tracking
---
Worklog Id: (was: 869527)
Remaining Estimate: 0h
Time Spent: 10m
> MQTT queue creation does not honor the delimiter and always uses '.'
>
>
> Key: ARTEMIS-4350
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4350
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: MQTT
>Affects Versions: 2.29.0
>Reporter: Erwin Dondorp
>Priority: Minor
> Attachments: 1.png, 2.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When subscribing using an MQTT client on an address, a subscription queue is
> created.
> For MQTT, the subscription-queue has a name that is constructed using the
> client-id and the address-name. The parts are always joined using the {{.}}
> character.
> It is more consistent when the _delimiter_ character is used for that.
> a PR will be added
> using {{/}} as separator, before:
> !1.png!
> using {{/}} as separator, after:
> !2.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4350) MQTT queue creation does not honor the delimiter and always uses '.'
[
https://issues.apache.org/jira/browse/ARTEMIS-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erwin Dondorp updated ARTEMIS-4350:
---
Attachment: 2.png
1.png
Description:
When subscribing using an MQTT client on an address, a subscription queue is
created.
For MQTT, the subscription-queue has a name that is constructed using the
client-id and the address-name. The parts are always joined using the {{.}}
character.
It is more consistent when the _delimiter_ character is used for that.
a PR will be added
using {{/}} as separator, before:
!1.png!
using {{/}} as separator, after:
!2.png!
was:
When subscribing using an MQTT client on an address, a subscription queue is
created.
For MQTT, the subscription-queue has a name that is constructed using the
client-id and the address-name. The parts are always joined using the `.`
character.
It is more consistent when the _delimiter_ character is used for that.
a PR will be added
> MQTT queue creation does not honor the delimiter and always uses '.'
>
>
> Key: ARTEMIS-4350
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4350
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: MQTT
>Affects Versions: 2.29.0
>Reporter: Erwin Dondorp
>Priority: Minor
> Attachments: 1.png, 2.png
>
>
> When subscribing using an MQTT client on an address, a subscription queue is
> created.
> For MQTT, the subscription-queue has a name that is constructed using the
> client-id and the address-name. The parts are always joined using the {{.}}
> character.
> It is more consistent when the _delimiter_ character is used for that.
> a PR will be added
> using {{/}} as separator, before:
> !1.png!
> using {{/}} as separator, after:
> !2.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (ARTEMIS-4350) MQTT queue creation does not honor the delimiter and always uses '.'
Erwin Dondorp created ARTEMIS-4350: -- Summary: MQTT queue creation does not honor the delimiter and always uses '.' Key: ARTEMIS-4350 URL: https://issues.apache.org/jira/browse/ARTEMIS-4350 Project: ActiveMQ Artemis Issue Type: Improvement Components: MQTT Affects Versions: 2.29.0 Reporter: Erwin Dondorp When subscribing using an MQTT client on an address, a subscription queue is created. For MQTT, the subscription-queue has a name that is constructed using the client-id and the address-name. The parts are always joined using the `.` character. It is more consistent when the _delimiter_ character is used for that. a PR will be added -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (ARTEMIS-4347) Upgrade Keycloak in security example
[ https://issues.apache.org/jira/browse/ARTEMIS-4347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved ARTEMIS-4347. - Fix Version/s: 2.30.0 Resolution: Fixed > Upgrade Keycloak in security example > > > Key: ARTEMIS-4347 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4347 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Trivial > Fix For: 2.30.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4347) Upgrade Keycloak in security example
[ https://issues.apache.org/jira/browse/ARTEMIS-4347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740484#comment-17740484 ] ASF subversion and git services commented on ARTEMIS-4347: -- Commit 092f154963c2d74ee706f5c55f2b2934f18c9f9d in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=092f154963 ] ARTEMIS-4347 upgrade Keycloak in security example > Upgrade Keycloak in security example > > > Key: ARTEMIS-4347 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4347 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Trivial > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4347) Upgrade Keycloak in security example
[ https://issues.apache.org/jira/browse/ARTEMIS-4347?focusedWorklogId=869471=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869471 ] ASF GitHub Bot logged work on ARTEMIS-4347: --- Author: ASF GitHub Bot Created on: 06/Jul/23 08:30 Start Date: 06/Jul/23 08:30 Worklog Time Spent: 10m Work Description: gemmellr merged PR #4538: URL: https://github.com/apache/activemq-artemis/pull/4538 Issue Time Tracking --- Worklog Id: (was: 869471) Time Spent: 20m (was: 10m) > Upgrade Keycloak in security example > > > Key: ARTEMIS-4347 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4347 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Trivial > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
