[jira] [Work logged] (BEAM-4620) UnboundedReadFromBoundedSource.split() should always call split()
[ https://issues.apache.org/jira/browse/BEAM-4620?focusedWorklogId=191144=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191144 ] ASF GitHub Bot logged work on BEAM-4620: Author: ASF GitHub Bot Created on: 28/Jan/19 17:29 Start Date: 28/Jan/19 17:29 Worklog Time Spent: 10m Work Description: swegner commented on pull request #7633: [BEAM-4620] Updates UnboundedReadFromBoundedSource.split() to at least create one split URL: https://github.com/apache/beam/pull/7633 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 191144) Time Spent: 1h 40m (was: 1.5h) > UnboundedReadFromBoundedSource.split() should always call split() > - > > Key: BEAM-4620 > URL: https://issues.apache.org/jira/browse/BEAM-4620 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Josh M >Assignee: Chamikara Jayalath >Priority: Minor > Fix For: 2.11.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > If the source contains too little data (rounds the result down to 0), or if > size estimation fails, then we don't call .split(). We must always call > split(); instead of returning original source, we should have computed some > fallback value for desiredBundleSize. > This bug has existed since the code was first introduced, so it is not a > regression - but it is certainly a bug. > > source: > https://github.com/apache/beam/blob/697a1d17e473cd5b097aaaeee24c08f43cc77f58/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java#L137 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4620) UnboundedReadFromBoundedSource.split() should always call split()
[ https://issues.apache.org/jira/browse/BEAM-4620?focusedWorklogId=190331=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-190331 ] ASF GitHub Bot logged work on BEAM-4620: Author: ASF GitHub Bot Created on: 26/Jan/19 06:35 Start Date: 26/Jan/19 06:35 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #7633: [BEAM-4620] Updates UnboundedReadFromBoundedSource.split() to at least create one split URL: https://github.com/apache/beam/pull/7633#issuecomment-457807239 R: @youngoli @swegner This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 190331) Time Spent: 1.5h (was: 1h 20m) > UnboundedReadFromBoundedSource.split() should always call split() > - > > Key: BEAM-4620 > URL: https://issues.apache.org/jira/browse/BEAM-4620 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Josh M >Assignee: Chamikara Jayalath >Priority: Minor > Fix For: 2.11.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > If the source contains too little data (rounds the result down to 0), or if > size estimation fails, then we don't call .split(). We must always call > split(); instead of returning original source, we should have computed some > fallback value for desiredBundleSize. > This bug has existed since the code was first introduced, so it is not a > regression - but it is certainly a bug. > > source: > https://github.com/apache/beam/blob/697a1d17e473cd5b097aaaeee24c08f43cc77f58/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java#L137 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4620) UnboundedReadFromBoundedSource.split() should always call split()
[ https://issues.apache.org/jira/browse/BEAM-4620?focusedWorklogId=190273=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-190273 ] ASF GitHub Bot logged work on BEAM-4620: Author: ASF GitHub Bot Created on: 26/Jan/19 01:17 Start Date: 26/Jan/19 01:17 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #7633: [BEAM-4620] Updates UnboundedReadFromBoundedSource.split() to at least create one split URL: https://github.com/apache/beam/pull/7633 This is to make sure that we do not break existing sources due to https://github.com/apache/beam/pull/7555 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 190273) Time Spent: 1h 20m (was: 1h 10m) > UnboundedReadFromBoundedSource.split() should always call split() > - > > Key: BEAM-4620
[jira] [Work logged] (BEAM-4620) UnboundedReadFromBoundedSource.split() should always call split()
[ https://issues.apache.org/jira/browse/BEAM-4620?focusedWorklogId=189762=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189762 ] ASF GitHub Bot logged work on BEAM-4620: Author: ASF GitHub Bot Created on: 24/Jan/19 23:59 Start Date: 24/Jan/19 23:59 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #7555: [BEAM-4620] UnboundedReadFromBoundedSource invokes split for small bounded sources URL: https://github.com/apache/beam/pull/7555#issuecomment-457404131 Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189762) Time Spent: 1h 10m (was: 1h) > UnboundedReadFromBoundedSource.split() should always call split() > - > > Key: BEAM-4620 > URL: https://issues.apache.org/jira/browse/BEAM-4620 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Josh M >Assignee: Chamikara Jayalath >Priority: Minor > Fix For: 2.11.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > If the source contains too little data (rounds the result down to 0), or if > size estimation fails, then we don't call .split(). We must always call > split(); instead of returning original source, we should have computed some > fallback value for desiredBundleSize. > This bug has existed since the code was first introduced, so it is not a > regression - but it is certainly a bug. > > source: > https://github.com/apache/beam/blob/697a1d17e473cd5b097aaaeee24c08f43cc77f58/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java#L137 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4620) UnboundedReadFromBoundedSource.split() should always call split()
[ https://issues.apache.org/jira/browse/BEAM-4620?focusedWorklogId=189759=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189759 ] ASF GitHub Bot logged work on BEAM-4620: Author: ASF GitHub Bot Created on: 24/Jan/19 23:50 Start Date: 24/Jan/19 23:50 Worklog Time Spent: 10m Work Description: swegner commented on pull request #7555: [BEAM-4620] UnboundedReadFromBoundedSource invokes split for small bounded sources URL: https://github.com/apache/beam/pull/7555 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189759) Time Spent: 1h (was: 50m) > UnboundedReadFromBoundedSource.split() should always call split() > - > > Key: BEAM-4620 > URL: https://issues.apache.org/jira/browse/BEAM-4620 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Josh M >Assignee: Chamikara Jayalath >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > If the source contains too little data (rounds the result down to 0), or if > size estimation fails, then we don't call .split(). We must always call > split(); instead of returning original source, we should have computed some > fallback value for desiredBundleSize. > This bug has existed since the code was first introduced, so it is not a > regression - but it is certainly a bug. > > source: > https://github.com/apache/beam/blob/697a1d17e473cd5b097aaaeee24c08f43cc77f58/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java#L137 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4620) UnboundedReadFromBoundedSource.split() should always call split()
[ https://issues.apache.org/jira/browse/BEAM-4620?focusedWorklogId=189648=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189648 ] ASF GitHub Bot logged work on BEAM-4620: Author: ASF GitHub Bot Created on: 24/Jan/19 19:45 Start Date: 24/Jan/19 19:45 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #7555: [BEAM-4620] UnboundedReadFromBoundedSource invokes split for small bounded sources URL: https://github.com/apache/beam/pull/7555#issuecomment-457331131 PTAL. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189648) Time Spent: 50m (was: 40m) > UnboundedReadFromBoundedSource.split() should always call split() > - > > Key: BEAM-4620 > URL: https://issues.apache.org/jira/browse/BEAM-4620 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Josh M >Assignee: Chamikara Jayalath >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > If the source contains too little data (rounds the result down to 0), or if > size estimation fails, then we don't call .split(). We must always call > split(); instead of returning original source, we should have computed some > fallback value for desiredBundleSize. > This bug has existed since the code was first introduced, so it is not a > regression - but it is certainly a bug. > > source: > https://github.com/apache/beam/blob/697a1d17e473cd5b097aaaeee24c08f43cc77f58/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java#L137 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4620) UnboundedReadFromBoundedSource.split() should always call split()
[
https://issues.apache.org/jira/browse/BEAM-4620?focusedWorklogId=189647=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189647
]
ASF GitHub Bot logged work on BEAM-4620:
Author: ASF GitHub Bot
Created on: 24/Jan/19 19:45
Start Date: 24/Jan/19 19:45
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #7555:
[BEAM-4620] UnboundedReadFromBoundedSource invokes split for small bounded
sources
URL: https://github.com/apache/beam/pull/7555#discussion_r250752064
##
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java
##
@@ -127,9 +131,11 @@ public void validate() {
long desiredBundleSize = boundedSource.getEstimatedSizeBytes(options)
/ desiredNumSplits;
if (desiredBundleSize <= 0) {
LOG.warn(
- "BoundedSource {} cannot estimate its size, skips the initial
splits.",
Review comment:
Your comment makes sense. To make matters more complicated our API instructs
source authors to return 0L if size of source cannot be determined.
So I updated code to pick a default size of 64MB in case 0 is returned as
the estimated source. Otherwise we'll try to maximize splitting by setting
desiredBindleSize to 1 when a valid value cannot be determined.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 189647)
Time Spent: 40m (was: 0.5h)
> UnboundedReadFromBoundedSource.split() should always call split()
> -
>
> Key: BEAM-4620
> URL: https://issues.apache.org/jira/browse/BEAM-4620
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
>Reporter: Josh M
>Assignee: Chamikara Jayalath
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> If the source contains too little data (rounds the result down to 0), or if
> size estimation fails, then we don't call .split(). We must always call
> split(); instead of returning original source, we should have computed some
> fallback value for desiredBundleSize.
> This bug has existed since the code was first introduced, so it is not a
> regression - but it is certainly a bug.
>
> source:
> https://github.com/apache/beam/blob/697a1d17e473cd5b097aaaeee24c08f43cc77f58/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java#L137
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4620) UnboundedReadFromBoundedSource.split() should always call split()
[
https://issues.apache.org/jira/browse/BEAM-4620?focusedWorklogId=189576=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189576
]
ASF GitHub Bot logged work on BEAM-4620:
Author: ASF GitHub Bot
Created on: 24/Jan/19 17:29
Start Date: 24/Jan/19 17:29
Worklog Time Spent: 10m
Work Description: swegner commented on pull request #7555: [BEAM-4620]
UnboundedReadFromBoundedSource invokes split for small bounded sources
URL: https://github.com/apache/beam/pull/7555#discussion_r249216191
##
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java
##
@@ -127,9 +131,11 @@ public void validate() {
long desiredBundleSize = boundedSource.getEstimatedSizeBytes(options)
/ desiredNumSplits;
if (desiredBundleSize <= 0) {
LOG.warn(
- "BoundedSource {} cannot estimate its size, skips the initial
splits.",
Review comment:
I'm trying to reason about whether there's a scenario where this might
happen with `boundedSource.getEstimatedSizeBytes(options) > 0`. For example, if
a runner does over-splitting: dividing a small/normal estimated size by a large
`desiredNumSplits` would round down to 0.
In such a case, would it be better to use `desiredBundleSize = 1`? This will
would result in lots of very small splits, but presumably for a runner doing
oversplitting that's what they'd expect.
Note: I'm not an expert here, just brainstorming. It's possible this
scenario doesn't really exist, or that your proposed behavior would be more
desirable.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 189576)
Time Spent: 0.5h (was: 20m)
> UnboundedReadFromBoundedSource.split() should always call split()
> -
>
> Key: BEAM-4620
> URL: https://issues.apache.org/jira/browse/BEAM-4620
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
>Reporter: Josh M
>Assignee: Chamikara Jayalath
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If the source contains too little data (rounds the result down to 0), or if
> size estimation fails, then we don't call .split(). We must always call
> split(); instead of returning original source, we should have computed some
> fallback value for desiredBundleSize.
> This bug has existed since the code was first introduced, so it is not a
> regression - but it is certainly a bug.
>
> source:
> https://github.com/apache/beam/blob/697a1d17e473cd5b097aaaeee24c08f43cc77f58/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java#L137
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4620) UnboundedReadFromBoundedSource.split() should always call split()
[ https://issues.apache.org/jira/browse/BEAM-4620?focusedWorklogId=187005=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187005 ] ASF GitHub Bot logged work on BEAM-4620: Author: ASF GitHub Bot Created on: 18/Jan/19 19:26 Start Date: 18/Jan/19 19:26 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #7555: [BEAM-4620] UnboundedReadFromBoundedSource invokes split for small bounded sources URL: https://github.com/apache/beam/pull/7555#issuecomment-455660026 R: @swegner This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 187005) Time Spent: 20m (was: 10m) > UnboundedReadFromBoundedSource.split() should always call split() > - > > Key: BEAM-4620 > URL: https://issues.apache.org/jira/browse/BEAM-4620 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Josh M >Assignee: Chamikara Jayalath >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > If the source contains too little data (rounds the result down to 0), or if > size estimation fails, then we don't call .split(). We must always call > split(); instead of returning original source, we should have computed some > fallback value for desiredBundleSize. > This bug has existed since the code was first introduced, so it is not a > regression - but it is certainly a bug. > > source: > https://github.com/apache/beam/blob/697a1d17e473cd5b097aaaeee24c08f43cc77f58/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java#L137 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4620) UnboundedReadFromBoundedSource.split() should always call split()
[ https://issues.apache.org/jira/browse/BEAM-4620?focusedWorklogId=186674=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186674 ] ASF GitHub Bot logged work on BEAM-4620: Author: ASF GitHub Bot Created on: 18/Jan/19 02:22 Start Date: 18/Jan/19 02:22 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #7555: [BEAM-4620] UnboundedReadFromBoundedSource should invoke split for small sources URL: https://github.com/apache/beam/pull/7555 **Please** add a meaningful description for your change here Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186674) Time Spent: 10m Remaining Estimate: 0h >
