[jira] [Commented] (CALCITE-1353) first_frame_max_size in an ExecuteRequest should be an int32 in protobuf definitions.

[Francis Chuang (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960229#comment-15960229
 ] 

Francis Chuang commented on CALCITE-1353:
-

Thanks for fixing this one, Josh!

> first_frame_max_size in an ExecuteRequest should be an int32 in protobuf 
> definitions.
> -
>
> Key: CALCITE-1353
> URL: https://issues.apache.org/jira/browse/CALCITE-1353
> Project: Calcite
>  Issue Type: Bug
>  Components: avatica
>Affects Versions: avatica-1.8.0
>Reporter: Francis Chuang
>Assignee: Josh Elser
>Priority: Minor
> Fix For: avatica-1.10.0
>
>
> In the protobuf definition for {{ExecuteRequest}}, the 
> {{first_frame_max_size}} parameter is typed as an {{uint64}}. See 
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L130.
>  For consistency, it should be an {{int32}}.
> Similar parameters relating to the frame size are all typed as {{int32}}.
> For a {{PrepareAndExecuteRequest}}, {{first_frame_max_size}} is a{{int32}}: 
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L78
> For a {{FetchRequest}}, {{frame_max_size}} is a {{int32}}: 
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L96



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (CALCITE-1742) CalciteCatalogReader should not add resolved tables into CalciteSchema's explicit table map

[Jinfeng Ni (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960018#comment-15960018
 ] 

Jinfeng Ni edited comment on CALCITE-1742 at 4/7/17 12:07 AM:
--

Do we know why the {{TableEntry}} found in schema could not be unwrapped into a 
{{PreparingTable}} instance? Sounds like we will only hit the code of 
schema.add on L149 when the existing TableEntry could not be unwrapped. Is it 
because the table is an implicit table?

I agreed with your argument of side effect of getTableFrom() call; we probably 
should not call schema.add(), either if we could not find a {{TableEntry}}, or 
the {{TableEntry}} could not be unwrapped. The current code means the call 
{{getTableFrom()}} would have side effect.  [~julianhyde], what's your thoughts 
regarding this? 
 


was (Author: jni):
Do we know why the {{TableEntry}} found in schema could not be unwrapped into a 
{PreparingTable} instance? Sounds like we will only hit the code of schema.add 
on L149 when the existing TableEntry could not be unwrapped. Is it because the 
table is an implicit table?

I agreed with your argument of side effect of getTableFrom() call; we probably 
should not call schema.add(), either if we could not find a {{TableEntry}}, or 
the {{TableEntry}} could not be unwrapped. The current code means the call 
{{getTableFrom()}} would have side effect.  [~julianhyde], what's your thoughts 
regarding this? 
 

> CalciteCatalogReader should not add resolved tables into CalciteSchema's 
> explicit table map
> ---
>
> Key: CALCITE-1742
> URL: https://issues.apache.org/jira/browse/CALCITE-1742
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.12.0
>Reporter: Maryann Xue
>Assignee: Maryann Xue
>
> {{CalciteSchema}} is designed to have two sets of objects, the explicit and 
> the implicit. A explicit object means an object we add through explicit 
> {{CalciteSchema#addTable}} (or {{CalciteSchema.addFunction}}, etc) calls, 
> while an implicit object means an object we get from the underlying 
> {{Schema}} object's getXXX methods.
>  
> However, in {{CalciteCatalogReader#getTableFrom}}, after a table is resolved 
> through {{CalciteSchema.getTable}} method, it will be added to the 
> {{CalciteSchema}} again as an explicit object regardless of whether it is 
> originally implicit or explicit. So if it happens to be an implicit table, 
> any change about that table later on will be shadowed by the newly added 
> explicit object and thus cannot be accessed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1742) CalciteCatalogReader should not add resolved tables into CalciteSchema's explicit table map

[Jinfeng Ni (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960018#comment-15960018
 ] 

Jinfeng Ni commented on CALCITE-1742:
-

Do we know why the {{TableEntry}} found in schema could not be unwrapped into a 
{PreparingTable} instance? Sounds like we will only hit the code of schema.add 
on L149 when the existing TableEntry could not be unwrapped. Is it because the 
table is an implicit table?

I agreed with your argument of side effect of getTableFrom() call; we probably 
should not call schema.add(), either if we could not find a {{TableEntry}}, or 
the {{TableEntry}} could not be unwrapped. The current code means the call 
{{getTableFrom()}} would have side effect.  [~julianhyde], what's your thoughts 
regarding this? 
 

> CalciteCatalogReader should not add resolved tables into CalciteSchema's 
> explicit table map
> ---
>
> Key: CALCITE-1742
> URL: https://issues.apache.org/jira/browse/CALCITE-1742
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.12.0
>Reporter: Maryann Xue
>Assignee: Maryann Xue
>
> {{CalciteSchema}} is designed to have two sets of objects, the explicit and 
> the implicit. A explicit object means an object we add through explicit 
> {{CalciteSchema#addTable}} (or {{CalciteSchema.addFunction}}, etc) calls, 
> while an implicit object means an object we get from the underlying 
> {{Schema}} object's getXXX methods.
>  
> However, in {{CalciteCatalogReader#getTableFrom}}, after a table is resolved 
> through {{CalciteSchema.getTable}} method, it will be added to the 
> {{CalciteSchema}} again as an explicit object regardless of whether it is 
> originally implicit or explicit. So if it happens to be an implicit table, 
> any change about that table later on will be shadowed by the newly added 
> explicit object and thus cannot be accessed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1353) first_frame_max_size in an ExecuteRequest should be an int32 in protobuf definitions.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959976#comment-15959976
 ] 

ASF GitHub Bot commented on CALCITE-1353:
-

GitHub user joshelser opened a pull request:

https://github.com/apache/calcite-avatica/pull/5

[CALCITE-1353] Convert first_frame_max_size to an int32

A uint64 is wrong because -1 is a valid value and Java can only
handle a max of 2**32, not 2**64, elements.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/joshelser/calcite-avatica 1353-execute-request

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/calcite-avatica/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5


commit 2b4762275c9833f305438a895dd8764f4f1b4d53
Author: Josh Elser 
Date:   2017-04-06T23:37:37Z

[CALCITE-1353] Convert first_frame_max_size to an int32

A uint64 is wrong because -1 is a valid value and Java can only
handle a max of 2**32, not 2**64, elements.




> first_frame_max_size in an ExecuteRequest should be an int32 in protobuf 
> definitions.
> -
>
> Key: CALCITE-1353
> URL: https://issues.apache.org/jira/browse/CALCITE-1353
> Project: Calcite
>  Issue Type: Bug
>  Components: avatica
>Affects Versions: avatica-1.8.0
>Reporter: Francis Chuang
>Assignee: Josh Elser
>Priority: Minor
> Fix For: avatica-1.10.0
>
>
> In the protobuf definition for {{ExecuteRequest}}, the 
> {{first_frame_max_size}} parameter is typed as an {{uint64}}. See 
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L130.
>  For consistency, it should be an {{int32}}.
> Similar parameters relating to the frame size are all typed as {{int32}}.
> For a {{PrepareAndExecuteRequest}}, {{first_frame_max_size}} is a{{int32}}: 
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L78
> For a {{FetchRequest}}, {{frame_max_size}} is a {{int32}}: 
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L96



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (CALCITE-1353) first_frame_max_size in an ExecuteRequest should be an int32 in protobuf definitions.

[Josh Elser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CALCITE-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Elser reassigned CALCITE-1353:
---

Assignee: Josh Elser  (was: Francis Chuang)

> first_frame_max_size in an ExecuteRequest should be an int32 in protobuf 
> definitions.
> -
>
> Key: CALCITE-1353
> URL: https://issues.apache.org/jira/browse/CALCITE-1353
> Project: Calcite
>  Issue Type: Bug
>  Components: avatica
>Affects Versions: avatica-1.8.0
>Reporter: Francis Chuang
>Assignee: Josh Elser
>Priority: Minor
> Fix For: avatica-1.10.0
>
>
> In the protobuf definition for {{ExecuteRequest}}, the 
> {{first_frame_max_size}} parameter is typed as an {{uint64}}. See 
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L130.
>  For consistency, it should be an {{int32}}.
> Similar parameters relating to the frame size are all typed as {{int32}}.
> For a {{PrepareAndExecuteRequest}}, {{first_frame_max_size}} is a{{int32}}: 
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L78
> For a {{FetchRequest}}, {{frame_max_size}} is a {{int32}}: 
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L96



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1353) first_frame_max_size in an ExecuteRequest should be an int32 in protobuf definitions.

[Josh Elser (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959952#comment-15959952
 ] 

Josh Elser commented on CALCITE-1353:
-

Hope you don't mind, [~francischuang], stealing this one from you :)

> first_frame_max_size in an ExecuteRequest should be an int32 in protobuf 
> definitions.
> -
>
> Key: CALCITE-1353
> URL: https://issues.apache.org/jira/browse/CALCITE-1353
> Project: Calcite
>  Issue Type: Bug
>  Components: avatica
>Affects Versions: avatica-1.8.0
>Reporter: Francis Chuang
>Assignee: Josh Elser
>Priority: Minor
> Fix For: avatica-1.10.0
>
>
> In the protobuf definition for {{ExecuteRequest}}, the 
> {{first_frame_max_size}} parameter is typed as an {{uint64}}. See 
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L130.
>  For consistency, it should be an {{int32}}.
> Similar parameters relating to the frame size are all typed as {{int32}}.
> For a {{PrepareAndExecuteRequest}}, {{first_frame_max_size}} is a{{int32}}: 
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L78
> For a {{FetchRequest}}, {{frame_max_size}} is a {{int32}}: 
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L96



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1742) CalciteCatalogReader should not add resolved tables into CalciteSchema's explicit table map

[Maryann Xue (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959938#comment-15959938
 ] 

Maryann Xue commented on CALCITE-1742:
--

Thank you, [~jni], for pressing me on the details! I first thought the tableMap 
was more like another layer of cache and then when I started to fix the issue I 
realized it was for another purpose. I had decided to update the description 
together with my PR, but it's definitely better that I do it now.

> CalciteCatalogReader should not add resolved tables into CalciteSchema's 
> explicit table map
> ---
>
> Key: CALCITE-1742
> URL: https://issues.apache.org/jira/browse/CALCITE-1742
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.12.0
>Reporter: Maryann Xue
>Assignee: Maryann Xue
>
> {{CalciteSchema}} is designed to have two sets of objects, the explicit and 
> the implicit. A explicit object means an object we add through explicit 
> {{CalciteSchema#addTable}} (or {{CalciteSchema.addFunction}}, etc) calls, 
> while an implicit object means an object we get from the underlying 
> {{Schema}} object's getXXX methods.
>  
> However, in {{CalciteCatalogReader#getTableFrom}}, after a table is resolved 
> through {{CalciteSchema.getTable}} method, it will be added to the 
> {{CalciteSchema}} again as an explicit object regardless of whether it is 
> originally implicit or explicit. So if it happens to be an implicit table, 
> any change about that table later on will be shadowed by the newly added 
> explicit object and thus cannot be accessed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (CALCITE-1742) CalciteCatalogReader should not add resolved tables into CalciteSchema's explicit table map

[Maryann Xue (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CALCITE-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maryann Xue updated CALCITE-1742:
-
Description: 
{{CalciteSchema}} is designed to have two sets of objects, the explicit and the 
implicit. A explicit object means an object we add through explicit 
{{CalciteSchema#addTable}} (or {{CalciteSchema.addFunction}}, etc) calls, while 
an implicit object means an object we get from the underlying {{Schema}} 
object's getXXX methods.
 
However, in {{CalciteCatalogReader#getTableFrom}}, after a table is resolved 
through {{CalciteSchema.getTable}} method, it will be added to the 
{{CalciteSchema}} again as an explicit object regardless of whether it is 
originally implicit or explicit. So if it happens to be an implicit table, any 
change about that table later on will be shadowed by the newly added explicit 
object and thus cannot be accessed.

  was:We have two implementations of CalciteSchema, {{CachingCalciteSchema}} 
and {{SimpleCalciteSchema}}. There is still caching in the parent class 
{{CalciteSchema}}, though, that causes objects to be cached even if caching is 
not enabled (as in {{SimpleCalciteSchema}}).


> CalciteCatalogReader should not add resolved tables into CalciteSchema's 
> explicit table map
> ---
>
> Key: CALCITE-1742
> URL: https://issues.apache.org/jira/browse/CALCITE-1742
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.12.0
>Reporter: Maryann Xue
>Assignee: Maryann Xue
>
> {{CalciteSchema}} is designed to have two sets of objects, the explicit and 
> the implicit. A explicit object means an object we add through explicit 
> {{CalciteSchema#addTable}} (or {{CalciteSchema.addFunction}}, etc) calls, 
> while an implicit object means an object we get from the underlying 
> {{Schema}} object's getXXX methods.
>  
> However, in {{CalciteCatalogReader#getTableFrom}}, after a table is resolved 
> through {{CalciteSchema.getTable}} method, it will be added to the 
> {{CalciteSchema}} again as an explicit object regardless of whether it is 
> originally implicit or explicit. So if it happens to be an implicit table, 
> any change about that table later on will be shadowed by the newly added 
> explicit object and thus cannot be accessed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (CALCITE-1744) Cleanup avatica project pom

[Josh Elser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CALCITE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Elser resolved CALCITE-1744.
-
Resolution: Fixed

Eclipse is happy locally and we had a nice reduction in pom.xml sizes

Fixed in 
https://git-wip-us.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=d961f4d6019f778ad1b886dc344bbc1dd66fc17f

> Cleanup avatica project pom
> ---
>
> Key: CALCITE-1744
> URL: https://issues.apache.org/jira/browse/CALCITE-1744
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Minor
> Fix For: avatica-1.10.0
>
>
> I'm noticing that, somehow, avatica has inherited a number of 
> plugins/dependencies it doesn't actually need (e.g. freemarker).
> Make a pass through the poms to remove unnecessary things after the split and 
> try to get Eclipse happy on a fresh import.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1744) Cleanup avatica project pom

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959932#comment-15959932
 ] 

ASF GitHub Bot commented on CALCITE-1744:
-

Github user asfgit closed the pull request at:

https://github.com/apache/calcite-avatica/pull/4


> Cleanup avatica project pom
> ---
>
> Key: CALCITE-1744
> URL: https://issues.apache.org/jira/browse/CALCITE-1744
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Minor
> Fix For: avatica-1.10.0
>
>
> I'm noticing that, somehow, avatica has inherited a number of 
> plugins/dependencies it doesn't actually need (e.g. freemarker).
> Make a pass through the poms to remove unnecessary things after the split and 
> try to get Eclipse happy on a fresh import.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (CALCITE-1742) CalciteCatalogReader should not add resolved tables into CalciteSchema's explicit table map

[Maryann Xue (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CALCITE-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maryann Xue updated CALCITE-1742:
-
Summary: CalciteCatalogReader should not add resolved tables into 
CalciteSchema's explicit table map  (was: Avoid caching sub-objects from 
CalciteSchema if caching is not enabled)

> CalciteCatalogReader should not add resolved tables into CalciteSchema's 
> explicit table map
> ---
>
> Key: CALCITE-1742
> URL: https://issues.apache.org/jira/browse/CALCITE-1742
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.12.0
>Reporter: Maryann Xue
>Assignee: Maryann Xue
>
> We have two implementations of CalciteSchema, {{CachingCalciteSchema}} and 
> {{SimpleCalciteSchema}}. There is still caching in the parent class 
> {{CalciteSchema}}, though, that causes objects to be cached even if caching 
> is not enabled (as in {{SimpleCalciteSchema}}).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (CALCITE-1742) Avoid caching sub-objects from CalciteSchema if caching is not enabled

[Maryann Xue (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959924#comment-15959924
 ] 

Maryann Xue edited comment on CALCITE-1742 at 4/6/17 10:51 PM:
---

bq. From the code, schema.addTable is only called when the located TableEntry 
was not successfully unwrapped into a PreparingTable instance. If that happens, 
it will replace the old one with a new properly created TableEntry in schema.
I don't think calling {{addSchema}} will actually do anything about the 
{{Table}} instance other than create a new {{TableEntry}} object with exactly 
the same name and Table objects, i.e. it won't wrap the {{Table}} instance with 
a {{RelOptTableImpl}} at this point. The side effect of calling {{addSchema}} 
though, is adding this Table into the {{tableMap}} which is targeted for 
explicit tables only (sorry I shouldn't have called it cache). Note that the 
{{Table}} instance here can be an "explicit" or an "implicit" table, so it 
should NOT be added to the {{tableMap}}. Otherwise if it's an implicit Table, 
the change of this Table from the underlying {{Schema}} provider object can be 
shadowed.


was (Author: maryannxue):
bq. From the code, schema.addTable is only called when the located TableEntry 
was not successfully unwrapped into a PreparingTable instance. If that happens, 
it will replace the old one with a new properly created TableEntry in schema.
I don't calling {{addSchema}} will actually do anything about the {{Table}} 
instance other than create a new {{TableEntry}} object with exactly the same 
name and Table objects. The side effect of calling {{addSchema}} though, is 
adding this Table into the {{tableMap}} which is targeted for explicit tables 
only (sorry I shouldn't have called it cache). Note that the {{Table}} instance 
here can be an "explicit" or an "implicit" table, so it should NOT be added to 
the {{tableMap}}. Otherwise if it's an implicit Table, the change of this Table 
from the underlying {{Schema}} provider object can be shadowed.

> Avoid caching sub-objects from CalciteSchema if caching is not enabled
> --
>
> Key: CALCITE-1742
> URL: https://issues.apache.org/jira/browse/CALCITE-1742
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.12.0
>Reporter: Maryann Xue
>Assignee: Maryann Xue
>
> We have two implementations of CalciteSchema, {{CachingCalciteSchema}} and 
> {{SimpleCalciteSchema}}. There is still caching in the parent class 
> {{CalciteSchema}}, though, that causes objects to be cached even if caching 
> is not enabled (as in {{SimpleCalciteSchema}}).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1744) Cleanup avatica project pom

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959911#comment-15959911
 ] 

ASF GitHub Bot commented on CALCITE-1744:
-

GitHub user joshelser opened a pull request:

https://github.com/apache/calcite-avatica/pull/4

CALCITE-1744 Clean up the Avatica poms

* Set some additional information
* Remove some unnecessary/OBE plugins/configurations
* Upgrading to the newer build-helper-maven-plugin gets around the eclipse 
errors
* Consolidate m2e plugin ignores in the parent

Pushed up here to make sure Travis is happy with building this as well (not 
just me, locally)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/joshelser/calcite-avatica 1744-pom-cleanup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/calcite-avatica/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4


commit f62b3617cfce89bc740fceb40766aca6407e4171
Author: Josh Elser 
Date:   2017-04-06T21:55:45Z

[CALCITE-1744] Clean up the Avatica poms

* Set some additional information
* Remove some unnecessary/OBE plugins/configurations
* Upgrading to the newer build-helper-maven-plugin gets around the eclipse 
errors
* Consolidate m2e plugin ignores in the parent




> Cleanup avatica project pom
> ---
>
> Key: CALCITE-1744
> URL: https://issues.apache.org/jira/browse/CALCITE-1744
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Minor
> Fix For: avatica-1.10.0
>
>
> I'm noticing that, somehow, avatica has inherited a number of 
> plugins/dependencies it doesn't actually need (e.g. freemarker).
> Make a pass through the poms to remove unnecessary things after the split and 
> try to get Eclipse happy on a fresh import.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1742) Avoid caching sub-objects from CalciteSchema if caching is not enabled

[Jinfeng Ni (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959890#comment-15959890
 ] 

Jinfeng Ni commented on CALCITE-1742:
-

>From the code,  {{schema.addTable}} is only called when the located TableEntry 
>was not successfully unwrapped into a {{PreparingTable}} instance. If that 
>happens,  it will replace the old one with a new properly created TableEntry 
>in schema.  Seems such addTable call has nothing to do with cache?

1. 
https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/prepare/CalciteCatalogReader.java#L148-L149
 

> Avoid caching sub-objects from CalciteSchema if caching is not enabled
> --
>
> Key: CALCITE-1742
> URL: https://issues.apache.org/jira/browse/CALCITE-1742
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.12.0
>Reporter: Maryann Xue
>Assignee: Maryann Xue
>
> We have two implementations of CalciteSchema, {{CachingCalciteSchema}} and 
> {{SimpleCalciteSchema}}. There is still caching in the parent class 
> {{CalciteSchema}}, though, that causes objects to be cached even if caching 
> is not enabled (as in {{SimpleCalciteSchema}}).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1742) Avoid caching sub-objects from CalciteSchema if caching is not enabled

[Maryann Xue (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959847#comment-15959847
 ] 

Maryann Xue commented on CALCITE-1742:
--

Sorry, the description was a little inaccurate. In fact, I think the issue 
exists in {{CalciteCatalogReader#getTableFrom}} which after calling 
{{schema.getTable}}, it again calls {{schema.addTable}}. I suppose 
{{schema.addTable}} is for adding so-called "explicit" tables but not for 
caching table objects.

> Avoid caching sub-objects from CalciteSchema if caching is not enabled
> --
>
> Key: CALCITE-1742
> URL: https://issues.apache.org/jira/browse/CALCITE-1742
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.12.0
>Reporter: Maryann Xue
>Assignee: Maryann Xue
>
> We have two implementations of CalciteSchema, {{CachingCalciteSchema}} and 
> {{SimpleCalciteSchema}}. There is still caching in the parent class 
> {{CalciteSchema}}, though, that causes objects to be cached even if caching 
> is not enabled (as in {{SimpleCalciteSchema}}).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1742) Avoid caching sub-objects from CalciteSchema if caching is not enabled

[Jinfeng Ni (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959833#comment-15959833
 ] 

Jinfeng Ni commented on CALCITE-1742:
-

Can you elaborate a bit more on this? Which objects will be cached in parent 
class CalciteSchema? 

> Avoid caching sub-objects from CalciteSchema if caching is not enabled
> --
>
> Key: CALCITE-1742
> URL: https://issues.apache.org/jira/browse/CALCITE-1742
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.12.0
>Reporter: Maryann Xue
>Assignee: Maryann Xue
>
> We have two implementations of CalciteSchema, {{CachingCalciteSchema}} and 
> {{SimpleCalciteSchema}}. There is still caching in the parent class 
> {{CalciteSchema}}, though, that causes objects to be cached even if caching 
> is not enabled (as in {{SimpleCalciteSchema}}).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (CALCITE-1744) Cleanup avatica project pom

[Josh Elser (JIRA)]

Josh Elser created CALCITE-1744:
---

 Summary: Cleanup avatica project pom
 Key: CALCITE-1744
 URL: https://issues.apache.org/jira/browse/CALCITE-1744
 Project: Calcite
  Issue Type: Task
  Components: avatica
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Minor
 Fix For: avatica-1.10.0


I'm noticing that, somehow, avatica has inherited a number of 
plugins/dependencies it doesn't actually need (e.g. freemarker).

Make a pass through the poms to remove unnecessary things after the split and 
try to get Eclipse happy on a fresh import.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (CALCITE-1743) Move Avatica tags to "rel/*" and update release documentation

[Josh Elser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CALCITE-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Elser resolved CALCITE-1743.
-
Resolution: Fixed

Fixed in 
https://git-wip-us.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=6e62e0b4f710122c2bebba86ba43e2d3f7b65435

> Move Avatica tags to "rel/*" and update release documentation
> -
>
> Key: CALCITE-1743
> URL: https://issues.apache.org/jira/browse/CALCITE-1743
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Minor
> Fix For: avatica-1.10.0
>
>
> Realized that all of the old tags were not migrated to match the "protected" 
> tag name {{rel/*}}.
> * Copy the existing tags to {{rel/*}}
> * Update the documentation



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (CALCITE-1743) Move Avatica tags to "rel/*" and update release documentation

[Josh Elser (JIRA)]

Josh Elser created CALCITE-1743:
---

 Summary: Move Avatica tags to "rel/*" and update release 
documentation
 Key: CALCITE-1743
 URL: https://issues.apache.org/jira/browse/CALCITE-1743
 Project: Calcite
  Issue Type: Task
  Components: avatica
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Minor
 Fix For: avatica-1.10.0


Realized that all of the old tags were not migrated to match the "protected" 
tag name {{rel/*}}.

* Copy the existing tags to {{rel/*}}
* Update the documentation



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (CALCITE-1742) Avoid caching sub-objects from CalciteSchema if caching is not enabled

[Maryann Xue (JIRA)]

Maryann Xue created CALCITE-1742:


 Summary: Avoid caching sub-objects from CalciteSchema if caching 
is not enabled
 Key: CALCITE-1742
 URL: https://issues.apache.org/jira/browse/CALCITE-1742
 Project: Calcite
  Issue Type: Bug
  Components: core
Affects Versions: 1.12.0
Reporter: Maryann Xue
Assignee: Maryann Xue


We have two implementations of CalciteSchema, {{CachingCalciteSchema}} and 
{{SimpleCalciteSchema}}. There is still caching in the parent class 
{{CalciteSchema}}, though, that causes objects to be cached even if caching is 
not enabled (as in {{SimpleCalciteSchema}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (CALCITE-1742) Avoid caching sub-objects from CalciteSchema if caching is not enabled

[Maryann Xue (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CALCITE-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maryann Xue updated CALCITE-1742:
-
Description: We have two implementations of CalciteSchema, 
{{CachingCalciteSchema}} and {{SimpleCalciteSchema}}. There is still caching in 
the parent class {{CalciteSchema}}, though, that causes objects to be cached 
even if caching is not enabled (as in {{SimpleCalciteSchema}}).  (was: We have 
two implementations of CalciteSchema, {{CachingCalciteSchema}} and 
{{SimpleCalciteSchema}}. There is still caching in the parent class 
{{CalciteSchema}}, though, that causes objects to be cached even if caching is 
not enabled (as in {{SimpleCalciteSchema}}.)

> Avoid caching sub-objects from CalciteSchema if caching is not enabled
> --
>
> Key: CALCITE-1742
> URL: https://issues.apache.org/jira/browse/CALCITE-1742
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.12.0
>Reporter: Maryann Xue
>Assignee: Maryann Xue
>
> We have two implementations of CalciteSchema, {{CachingCalciteSchema}} and 
> {{SimpleCalciteSchema}}. There is still caching in the parent class 
> {{CalciteSchema}}, though, that causes objects to be cached even if caching 
> is not enabled (as in {{SimpleCalciteSchema}}).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (CALCITE-1741) Upgrade to maven-assembly-plugin 3.0.0

[Josh Elser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CALCITE-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Elser resolved CALCITE-1741.
-
Resolution: Fixed

Fixed in 
https://git-wip-us.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=d93f4fa8250dbec81acff855b2fea51b16b74d6d

> Upgrade to maven-assembly-plugin 3.0.0
> --
>
> Key: CALCITE-1741
> URL: https://issues.apache.org/jira/browse/CALCITE-1741
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Minor
> Fix For: avatica-1.10.0
>
>
> Usage of the maven-assembly-plugin is failing on jdk9 due to MASSEMBLY-797. 
> Need to upgrade to 3.0.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (CALCITE-1741) Upgrade to maven-assembly-plugin 3.0.0

[Josh Elser (JIRA)]

Josh Elser created CALCITE-1741:
---

 Summary: Upgrade to maven-assembly-plugin 3.0.0
 Key: CALCITE-1741
 URL: https://issues.apache.org/jira/browse/CALCITE-1741
 Project: Calcite
  Issue Type: Task
  Components: avatica
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Minor
 Fix For: avatica-1.10.0


Usage of the maven-assembly-plugin is failing on jdk9 due to MASSEMBLY-797. 
Need to upgrade to 3.0.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[Josh Elser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Elser resolved CALCITE-1364.
-
Resolution: Fixed

Fixed in 
https://git-wip-us.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=c43aec5449653d08dc4c183742aa28528ee280a9

Big thanks again to [~risdenk] for the great review!

> Bring Docker image for avatica-standalone-server into Apache
> 
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959409#comment-15959409
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user asfgit closed the pull request at:

https://github.com/apache/calcite-avatica/pull/3


> Bring Docker image for avatica-standalone-server into Apache
> 
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959328#comment-15959328
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user risdenk commented on a diff in the pull request:

https://github.com/apache/calcite-avatica/pull/3#discussion_r110216971
  
--- Diff: docker/src/main/docker/Dockerfile ---
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM openjdk:8-jre-alpine
+MAINTAINER Apache Avatica 
+
+# Create an avatica user
+RUN addgroup -S avatica && adduser -S -G avatica avatica
+RUN mkdir -p /home/avatica/classpath
+
+# Dependencies
+# TODO would be nice to remove the hard-coded version
--- End diff --

Last nit: comment is out of date now :)


> Bring Docker image for avatica-standalone-server into Apache
> 
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959308#comment-15959308
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user joshelser commented on a diff in the pull request:

https://github.com/apache/calcite-avatica/pull/3#discussion_r110215394
  
--- Diff: site/_docs/docker_images.md ---
@@ -0,0 +1,151 @@
+---
+layout: docs
+title: Docker Images
+sidebar_title: Docker Images
+permalink: /docs/docker.html
+---
+
+
+
+## Docker Images for Avatica
+
+[Docker](https://en.wikipedia.org/wiki/Docker_(software)) is a popular 
piece of
+software that enables other software to run "anywhere". In the context of 
Avatica,
+we can use Docker to enable a run-anywhere Avatica server. These Docker 
containers
+can be used to easily create a server for the development of custom 
Avatica clients
+or encapsulating database access for testing software that uses Avatica.
+
+### Base "avatica-server" Docker Image
+
+Starting with the Avatica 1.10.0 release, Avatica is providing a number of 
Docker
+containers. Each of these images is based on a "parent" "avatica-server" 
Docker image.
+
+This Docker image has no bindings to a specific database (it has not 
database-specific
+JDBC driver included). It only contains a Java runtime and the Avatica 
Standalone Server
+jar (which contains all the necessary dependencies of the Avatica server). 
This docker
+image is not directly useful for end users; it is useful for those who 
want to use Avatica
+with a database of their choosing.
+
+This Docker image will be deployed to the [Apache Dockerhub 
account](https://hub.docker.com/r/apache/) after the release
+of 1.10.0 and will be updated for future releases of Avatica.
+
+### Database-specific Docker Images
+
+To make the lives of end-users who want to use a specific database easier, 
some Docker
+images are provided for some common databases. The current databases 
include:
+
+* [HyperSQL](http://hsqldb.org) (2.3.1)
+* [MySQL](https://www.mysql.com/) (Client 5.1.41, supports MySQL server 
4.1, 5.0, 5.1, 5.5, 5.6, 5.7)
+* [PostgreSQL](https://www.postgresql.org/) (Client 42.0.0, supports 
PostgreSQL servers >=8.3)
+
+These images are not deployed as the licensing on each database driver is 
varied. Please
+understand and accept the license of each before using in any software 
project.
+
+Each of these images include a `build.sh` script which will build the 
docker image using
+the latest `avatica-server` Docker image. The resulting Docker image will 
be named according
+to the following format: `avatica--server`. For example, 
`avatica-hsqldb-server`,
+`avatica-mysql-server`, and `avatica-postgresql-server`.
+
+Additionally, [Docker Compose](https://github.com/docker/compose) 
configuration files for the above
+databases (sans HyperSQL) are provided which configure the database's 
standard Docker image
+and then connect Avatica to that Docker container. For example, the 
PostgreSQL docker-compose configuration
+file will start an instance of PostgreSQL and an instance of the Avatica 
server, each in their own container,
+exposing an Avatica server configured against a "real" PostgreSQL database.
+
+All of the `Dockerfile` and `docker-compose.yml` files are conveniently 
provided in an archive for
+each release, starting with 1.10.0.
+
+```
+avatica-docker-1.10.0-SNAPSHOT/
+avatica-docker-1.10.0-SNAPSHOT/hypersql/
+avatica-docker-1.10.0-SNAPSHOT/mysql/
+avatica-docker-1.10.0-SNAPSHOT/postgresql/
+avatica-docker-1.10.0-SNAPSHOT/Dockerfile
+avatica-docker-1.10.0-SNAPSHOT/hypersql/build.sh
+avatica-docker-1.10.0-SNAPSHOT/hypersql/Dockerfile
+avatica-docker-1.10.0-SNAPSHOT/mysql/build.sh
+avatica-docker-1.10.0-SNAPSHOT/mysql/docker-compose.yml
+avatica-docker-1.10.0-SNAPSHOT/mysql/Dockerfile
+avatica-docker-1.10.0-SNAPSHOT/postgresql/build.sh
+avatica-docker-1.10.0-SNAPSHOT/postgresql/docker-compose.yml
+avatica-docker-1.10.0-SNAPSHOT/postgresql/Dockerfile
+```
+
+ Running
+
+Each of the provided database-specific Docker images set an `ENTRYPOINT` 
which
+encapsulate most of the Java command. The following options are available 
to specify:
+
+```
+Usage:  [options]
+  Options:
+-h, -help, --help
+   Print the help message
+   Default: false
+-p, --port
+   Port the server should bind
+   Default: 0
+-s, --serialization
+   Serialization method to use
+   Default: PROTOBUF
+   Possible Values: [JSON, PROTOBUF]
+  * -u, --url
+   JDBC driver url for the server
+```
+

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959306#comment-15959306
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user joshelser commented on a diff in the pull request:

https://github.com/apache/calcite-avatica/pull/3#discussion_r110215293
  
--- Diff: docker/src/main/dockerhub/Dockerfile ---
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM openjdk:8-jre-alpine
+MAINTAINER Apache Avatica 
+
+# Create an avatica user
+RUN addgroup -S avatica && adduser -S -G avatica avatica
+RUN mkdir -p /home/avatica/classpath
+
+# This line must be preserved. The Maven build will verify this version 
matches its version
+ARG AVATICA_VERSION="1.10.0"
+
+# Dependencies
+ADD 
https://repository.apache.org/content/groups/public/org/apache/calcite/avatica/avatica-standalone-server/${AVATICA_VERSION}/avatica-standalone-server-${AVATICA_VERSION}-shaded.jar
 /home/avatica/classpath
+
+# Make sure avatica owns its files
+RUN chown -R avatica: /home/avatica
+
+# Expose the default port as a convenience
+EXPOSE 8765
+
+# TODO Would like to do this, but screws up downstream due to 
https://github.com/docker/docker/issues/6119
+# USER avatica
--- End diff --

Right you are!


> Bring Docker image for avatica-standalone-server into Apache
> 
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959304#comment-15959304
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user joshelser commented on a diff in the pull request:

https://github.com/apache/calcite-avatica/pull/3#discussion_r110215283
  
--- Diff: docker/src/main/docker/Dockerfile ---
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM openjdk:8-jre-alpine
+MAINTAINER Apache Avatica 
+
+# Create an avatica user
+RUN addgroup -S avatica && adduser -S -G avatica avatica
+RUN mkdir -p /home/avatica/classpath
+
+# Dependencies
+# TODO would be nice to remove the hard-coded version
+ADD avatica-standalone-server-1.10.0-SNAPSHOT-shaded.jar 
/home/avatica/classpath
--- End diff --

Will test.


> Bring Docker image for avatica-standalone-server into Apache
> 
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959270#comment-15959270
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user risdenk commented on a diff in the pull request:

https://github.com/apache/calcite-avatica/pull/3#discussion_r110212292
  
--- Diff: site/_docs/docker_images.md ---
@@ -0,0 +1,151 @@
+---
+layout: docs
+title: Docker Images
+sidebar_title: Docker Images
+permalink: /docs/docker.html
+---
+
+
+
+## Docker Images for Avatica
+
+[Docker](https://en.wikipedia.org/wiki/Docker_(software)) is a popular 
piece of
+software that enables other software to run "anywhere". In the context of 
Avatica,
+we can use Docker to enable a run-anywhere Avatica server. These Docker 
containers
+can be used to easily create a server for the development of custom 
Avatica clients
+or encapsulating database access for testing software that uses Avatica.
+
+### Base "avatica-server" Docker Image
+
+Starting with the Avatica 1.10.0 release, Avatica is providing a number of 
Docker
+containers. Each of these images is based on a "parent" "avatica-server" 
Docker image.
+
+This Docker image has no bindings to a specific database (it has not 
database-specific
+JDBC driver included). It only contains a Java runtime and the Avatica 
Standalone Server
+jar (which contains all the necessary dependencies of the Avatica server). 
This docker
+image is not directly useful for end users; it is useful for those who 
want to use Avatica
+with a database of their choosing.
+
+This Docker image will be deployed to the [Apache Dockerhub 
account](https://hub.docker.com/r/apache/) after the release
+of 1.10.0 and will be updated for future releases of Avatica.
+
+### Database-specific Docker Images
+
+To make the lives of end-users who want to use a specific database easier, 
some Docker
+images are provided for some common databases. The current databases 
include:
+
+* [HyperSQL](http://hsqldb.org) (2.3.1)
+* [MySQL](https://www.mysql.com/) (Client 5.1.41, supports MySQL server 
4.1, 5.0, 5.1, 5.5, 5.6, 5.7)
+* [PostgreSQL](https://www.postgresql.org/) (Client 42.0.0, supports 
PostgreSQL servers >=8.3)
+
+These images are not deployed as the licensing on each database driver is 
varied. Please
+understand and accept the license of each before using in any software 
project.
+
+Each of these images include a `build.sh` script which will build the 
docker image using
+the latest `avatica-server` Docker image. The resulting Docker image will 
be named according
+to the following format: `avatica--server`. For example, 
`avatica-hsqldb-server`,
+`avatica-mysql-server`, and `avatica-postgresql-server`.
+
+Additionally, [Docker Compose](https://github.com/docker/compose) 
configuration files for the above
+databases (sans HyperSQL) are provided which configure the database's 
standard Docker image
+and then connect Avatica to that Docker container. For example, the 
PostgreSQL docker-compose configuration
+file will start an instance of PostgreSQL and an instance of the Avatica 
server, each in their own container,
+exposing an Avatica server configured against a "real" PostgreSQL database.
+
+All of the `Dockerfile` and `docker-compose.yml` files are conveniently 
provided in an archive for
+each release, starting with 1.10.0.
+
+```
+avatica-docker-1.10.0-SNAPSHOT/
+avatica-docker-1.10.0-SNAPSHOT/hypersql/
+avatica-docker-1.10.0-SNAPSHOT/mysql/
+avatica-docker-1.10.0-SNAPSHOT/postgresql/
+avatica-docker-1.10.0-SNAPSHOT/Dockerfile
+avatica-docker-1.10.0-SNAPSHOT/hypersql/build.sh
+avatica-docker-1.10.0-SNAPSHOT/hypersql/Dockerfile
+avatica-docker-1.10.0-SNAPSHOT/mysql/build.sh
+avatica-docker-1.10.0-SNAPSHOT/mysql/docker-compose.yml
+avatica-docker-1.10.0-SNAPSHOT/mysql/Dockerfile
+avatica-docker-1.10.0-SNAPSHOT/postgresql/build.sh
+avatica-docker-1.10.0-SNAPSHOT/postgresql/docker-compose.yml
+avatica-docker-1.10.0-SNAPSHOT/postgresql/Dockerfile
+```
+
+ Running
+
+Each of the provided database-specific Docker images set an `ENTRYPOINT` 
which
+encapsulate most of the Java command. The following options are available 
to specify:
+
+```
+Usage:  [options]
+  Options:
+-h, -help, --help
+   Print the help message
+   Default: false
+-p, --port
+   Port the server should bind
+   Default: 0
+-s, --serialization
+   Serialization method to use
+   Default: PROTOBUF
+   Possible Values: [JSON, PROTOBUF]
+  * -u, --url
+   JDBC driver url for the server
+```
+
+For 

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959271#comment-15959271
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user risdenk commented on a diff in the pull request:

https://github.com/apache/calcite-avatica/pull/3#discussion_r110211825
  
--- Diff: docker/src/main/docker/Dockerfile ---
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM openjdk:8-jre-alpine
+MAINTAINER Apache Avatica 
+
+# Create an avatica user
+RUN addgroup -S avatica && adduser -S -G avatica avatica
+RUN mkdir -p /home/avatica/classpath
+
+# Dependencies
+# TODO would be nice to remove the hard-coded version
+ADD avatica-standalone-server-1.10.0-SNAPSHOT-shaded.jar 
/home/avatica/classpath
--- End diff --

You might be able to get away with:

`ADD avatica-standalone-server-*-SNAPSHOT-shaded.jar 
/home/avatica/classpath/`

I think Docker will be able to handle the globbing. I can never remember.


> Bring Docker image for avatica-standalone-server into Apache
> 
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959272#comment-15959272
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user risdenk commented on a diff in the pull request:

https://github.com/apache/calcite-avatica/pull/3#discussion_r110212037
  
--- Diff: docker/src/main/dockerhub/Dockerfile ---
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM openjdk:8-jre-alpine
+MAINTAINER Apache Avatica 
+
+# Create an avatica user
+RUN addgroup -S avatica && adduser -S -G avatica avatica
+RUN mkdir -p /home/avatica/classpath
+
+# This line must be preserved. The Maven build will verify this version 
matches its version
+ARG AVATICA_VERSION="1.10.0"
+
+# Dependencies
+ADD 
https://repository.apache.org/content/groups/public/org/apache/calcite/avatica/avatica-standalone-server/${AVATICA_VERSION}/avatica-standalone-server-${AVATICA_VERSION}-shaded.jar
 /home/avatica/classpath
+
+# Make sure avatica owns its files
+RUN chown -R avatica: /home/avatica
+
+# Expose the default port as a convenience
+EXPOSE 8765
+
+# TODO Would like to do this, but screws up downstream due to 
https://github.com/docker/docker/issues/6119
+# USER avatica
--- End diff --

Look like this is missing the entrypoint?


> Bring Docker image for avatica-standalone-server into Apache
> 
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959252#comment-15959252
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user joshelser commented on a diff in the pull request:

https://github.com/apache/calcite-avatica/pull/3#discussion_r110211043
  
--- Diff: docker/src/main/docker/postgresql/Dockerfile ---
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM avatica-server:latest
+MAINTAINER Apache Avatica 
+
+# Dependencies
+ADD 
https://repo1.maven.org/maven2/org/postgresql/postgresql/42.0.0.jre7/postgresql-42.0.0.jre7.jar
 /home/avatica/classpath/
--- End diff --

Wow, I have no justification as to why I missed "42.0.0" the first time 
around :) Switching..


> Bring Docker image for avatica-standalone-server into Apache
> 
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959238#comment-15959238
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user joshelser commented on the issue:

https://github.com/apache/calcite-avatica/pull/3
  
Alright, I think I have all of your great feedback addressed, @risdenk. I 
really appreciate your comments; they've made this *tons* better than it was 
previously.


> Bring Docker image for avatica-standalone-server into Apache
> 
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959216#comment-15959216
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user joshelser commented on a diff in the pull request:

https://github.com/apache/calcite-avatica/pull/3#discussion_r110205783
  
--- Diff: docker/src/main/docker/Dockerfile ---
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM openjdk:8-jre-alpine
+MAINTAINER Apache Avatica 
+
+# Create an avatica user
+RUN addgroup -S avatica && adduser -S -G avatica avatica
+RUN mkdir -p /home/avatica/classpath
+
+# Dependencies
+ADD avatica-standalone-server-1.10.0-SNAPSHOT-shaded.jar 
/home/avatica/classpath
+
+# Make sure avatica owns its files
+RUN chown -R avatica: /home/avatica
+
+# Expose the default port as a convenience
+EXPOSE 8765
+# Switch off of the root user
+# TODO Would like to do this, but screws up downstream due to 
https://github.com/docker/docker/issues/6119
+# USER avatica
--- End diff --

Yup, and it makes no sense that I didn't put `-p 8765` here, given I was 
expose-ing 8765...


> Bring Docker image for avatica-standalone-server into Apache
> 
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959217#comment-15959217
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user joshelser commented on a diff in the pull request:

https://github.com/apache/calcite-avatica/pull/3#discussion_r110205841
  
--- Diff: docker/src/main/docker/hypersql/Dockerfile ---
@@ -0,0 +1,23 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM avatica-server:latest
+MAINTAINER Apache Avatica 
+
+# Dependencies
+ADD 
https://repo1.maven.org/maven2/net/hydromatic/scott-data-hsqldb/0.1/scott-data-hsqldb-0.1.jar
 /home/avatica/classpath/
+ADD 
https://repo1.maven.org/maven2/org/hsqldb/hsqldb/2.3.1/hsqldb-2.3.1.jar 
/home/avatica/classpath/
+
+ENTRYPOINT ["/usr/bin/java", "-cp", "/home/avatica/classpath/*", 
"org.apache.calcite.avatica.standalone.StandaloneServer", "-u", 
"jdbc:hsqldb:res:scott"]
--- End diff --

Just did this. Very nice. Thanks for the tip!


> Bring Docker image for avatica-standalone-server into Apache
> 
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959166#comment-15959166
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user risdenk commented on a diff in the pull request:

https://github.com/apache/calcite-avatica/pull/3#discussion_r110199982
  
--- Diff: docker/src/main/docker/postgresql/Dockerfile ---
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM avatica-server:latest
+MAINTAINER Apache Avatica 
+
+# Dependencies
+ADD 
https://repo1.maven.org/maven2/org/postgresql/postgresql/42.0.0.jre7/postgresql-42.0.0.jre7.jar
 /home/avatica/classpath/
--- End diff --

It looks like the difference between 42.0.0.jre7 and 42.0.0 is the level of 
the JDBC driver. Either JDBC 4.2 vs JDBC 4.1.


> Bring Docker image for avatica-standalone-server into Apache
> 
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959160#comment-15959160
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user risdenk commented on a diff in the pull request:

https://github.com/apache/calcite-avatica/pull/3#discussion_r110199676
  
--- Diff: docker/src/main/docker/postgresql/Dockerfile ---
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM avatica-server:latest
+MAINTAINER Apache Avatica 
+
+# Dependencies
+ADD 
https://repo1.maven.org/maven2/org/postgresql/postgresql/42.0.0.jre7/postgresql-42.0.0.jre7.jar
 /home/avatica/classpath/
--- End diff --

I'm not sure but found this:

https://jdbc.postgresql.org/download.html

There is a Maven version without the .jre7.

https://mvnrepository.com/artifact/org.postgresql/postgresql/42.0.0

The other thought is you might just want to pull from the postgres website?

https://jdbc.postgresql.org/download/postgresql-42.0.0.jar


> Bring Docker image for avatica-standalone-server into Apache
> 
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959111#comment-15959111
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user joshelser commented on a diff in the pull request:

https://github.com/apache/calcite-avatica/pull/3#discussion_r110195141
  
--- Diff: docker/src/main/docker/postgresql/Dockerfile ---
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM avatica-server:latest
+MAINTAINER Apache Avatica 
+
+# Dependencies
+ADD 
https://repo1.maven.org/maven2/org/postgresql/postgresql/42.0.0.jre7/postgresql-42.0.0.jre7.jar
 /home/avatica/classpath/
--- End diff --

42.0.0.jre7 was the most recent one I could find. Pulled it out and will do 
some digging to update the website to list the major client version used (had 
that nagging thought in the back of my head anyways)


> Bring Docker image for avatica-standalone-server into Apache
> 
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1364) Bring Docker image for avatica-standalone-server into Apache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959110#comment-15959110
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-

Github user joshelser commented on a diff in the pull request:

https://github.com/apache/calcite-avatica/pull/3#discussion_r110194907
  
--- Diff: docker/src/main/docker/mysql/Dockerfile ---
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM avatica-server:latest
+MAINTAINER Apache Avatica 
+
+# Dependencies
+ADD 
https://repo1.maven.org/maven2/mysql/mysql-connector-java/5.1.41/mysql-connector-java-5.1.41.jar
 /home/avatica/classpath/
--- End diff --

Done


> Bring Docker image for avatica-standalone-server into Apache
> 
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
>  Issue Type: Task
>  Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)