[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/972 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2460/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/972 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2461/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/972 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/344/Failed Tests: 7carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-hadoop: 4org.apache.carbondata.hadoop.ft.CarbonInputMapperTest.testInputFormatMapperReadAllRowsAndColumnsorg.apache.carbondata.hadoop.ft.CarbonInputMapperTest.testInputFormatMapperReadAllRowsAndFewColumnsWithFilterorg.apache.carbondata.hadoop.ft.CarbonInputMapperTest.testInputFormatMapperReadAllRowsAndFewColumnsorg.apache.carbondata.hadoop.ft.InputFilesTest.testGetSplitscarbondata-pr-s park-1.6/org.apache.carbondata:carbondata-processing: 3org.apache.carbondata.carbon.datastore.BlockIndexStoreTest.testloadAndGetTaskIdToSegmentsMapForDifferentSegmentLoadedConcurrentlyorg.apache.carbondata.carbon.datastore.BlockIndexStoreTest.testLoadAndGetTaskIdToSegmentsMapForSingleSegmentorg.apache.carbondata.carbon.datastore.BlockIndexStoreTest.testloadAndGetTaskIdToSegmentsMapForSameBlockLoadedConcurrently --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/972 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2462/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/972 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/345/Failed Tests: 7carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-hadoop: 4org.apache.carbondata.hadoop.ft.CarbonInputMapperTest.testInputFormatMapperReadAllRowsAndColumnsorg.apache.carbondata.hadoop.ft.CarbonInputMapperTest.testInputFormatMapperReadAllRowsAndFewColumnsWithFilterorg.apache.carbondata.hadoop.ft.CarbonInputMapperTest.testInputFormatMapperReadAllRowsAndFewColumnsorg.apache.carbondata.hadoop.ft.InputFilesTest.testGetSplitscarbondata-pr-s park-1.6/org.apache.carbondata:carbondata-processing: 3org.apache.carbondata.carbon.datastore.BlockIndexStoreTest.testloadAndGetTaskIdToSegmentsMapForDifferentSegmentLoadedConcurrentlyorg.apache.carbondata.carbon.datastore.BlockIndexStoreTest.testLoadAndGetTaskIdToSegmentsMapForSingleSegmentorg.apache.carbondata.carbon.datastore.BlockIndexStoreTest.testloadAndGetTaskIdToSegmentsMapForSameBlockLoadedConcurrently --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/972 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/346/Failed Tests: 7carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-hadoop: 4org.apache.carbondata.hadoop.ft.CarbonInputMapperTest.testInputFormatMapperReadAllRowsAndColumnsorg.apache.carbondata.hadoop.ft.CarbonInputMapperTest.testInputFormatMapperReadAllRowsAndFewColumnsWithFilterorg.apache.carbondata.hadoop.ft.CarbonInputMapperTest.testInputFormatMapperReadAllRowsAndFewColumnsorg.apache.carbondata.hadoop.ft.InputFilesTest.testGetSplitscarbondata-pr-s park-1.6/org.apache.carbondata:carbondata-processing: 3org.apache.carbondata.carbon.datastore.BlockIndexStoreTest.testloadAndGetTaskIdToSegmentsMapForDifferentSegmentLoadedConcurrentlyorg.apache.carbondata.carbon.datastore.BlockIndexStoreTest.testLoadAndGetTaskIdToSegmentsMapForSingleSegmentorg.apache.carbondata.carbon.datastore.BlockIndexStoreTest.testloadAndGetTaskIdToSegmentsMapForSameBlockLoadedConcurrently --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1025: [CARBONDATA-1165] solved bug for class cast exceptio...
Github user zzcclp commented on the issue: https://github.com/apache/carbondata/pull/1025 LGTM, I met the same issue: java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.Long at org.apache.carbondata.processing.sortandgroupby.sortdata.IntermediateFileMerger.writeDataTofile(IntermediateFileMerger.java:347) at org.apache.carbondata.processing.sortandgroupby.sortdata.IntermediateFileMerger.call(IntermediateFileMerger.java:112) at org.apache.carbondata.processing.sortandgroupby.sortdata.IntermediateFileMerger.call(IntermediateFileMerger.java:1) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Github user watermen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1000#discussion_r121874665
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -98,56 +117,54 @@ public static ColumnPage newPage(DataType dataType,
int pageSize) {
default:
throw new RuntimeException("Unsupported data dataType: " +
dataType);
}
-instance.stats = new ColumnPageStatsVO(dataType);
-instance.nullBitSet = new BitSet(pageSize);
return instance;
}
protected static ColumnPage newBytePage(byte[] byteData) {
ColumnPage columnPage = new ColumnPage(BYTE, byteData.length);
--- End diff --
If don't support, we'd better to add some notes to explain.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1025: [CARBONDATA-1165] solved bug for class cast exceptio...
Github user anubhav100 commented on the issue: https://github.com/apache/carbondata/pull/1025 @chenliang613 he also face the same issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Github user watermen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1000#discussion_r121875823
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -508,7 +567,7 @@ public static ColumnPage decompress(Compressor
compressor, DataType dataType,
}
// input byte[] is LV encoded, this function can expand it into byte[][]
- private static byte[][] deflatten(byte[] input) {
+ protected static byte[][] deflatten(byte[] input) {
--- End diff --
Agree with erlu.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1025: [CARBONDATA-1165] solved bug for class cast exceptio...
Github user zzcclp commented on the issue: https://github.com/apache/carbondata/pull/1025 @jackylk @ravipesala ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Github user watermen commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1000#discussion_r121876896
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -323,15 +340,8 @@ public double getDouble(int rowId) {
return doubleData[rowId];
}
- /**
- * Get decimal value at rowId
- */
- public byte[] getDecimalBytes(int rowId) {
-return byteArrayData[rowId];
- }
-
public BigDecimal getDecimal(int rowId) {
--- End diff --
Add annotation like getDouble
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1000: [CARBONDATA-1018] Add unsafe ColumnPage implementati...
Github user watermen commented on the issue: https://github.com/apache/carbondata/pull/1000 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/972 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2463/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/972 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/347/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (CARBONDATA-1170) Skip single_pass loading during first load
Kunal Kapoor created CARBONDATA-1170: Summary: Skip single_pass loading during first load Key: CARBONDATA-1170 URL: https://issues.apache.org/jira/browse/CARBONDATA-1170 Project: CarbonData Issue Type: Bug Reporter: Kunal Kapoor Assignee: Kunal Kapoor Priority: Minor The user should not be able to load using "single_pass"="true" for the first load instead the load would be restarted with "single_pass"="false" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (CARBONDATA-1171) Add support for show partition DDL
Kunal Kapoor created CARBONDATA-1171: Summary: Add support for show partition DDL Key: CARBONDATA-1171 URL: https://issues.apache.org/jira/browse/CARBONDATA-1171 Project: CarbonData Issue Type: Bug Reporter: Kunal Kapoor Assignee: Kunal Kapoor Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (CARBONDATA-1171) Add support for show partition DDL
[ https://issues.apache.org/jira/browse/CARBONDATA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor updated CARBONDATA-1171: - Component/s: sql > Add support for show partition DDL > -- > > Key: CARBONDATA-1171 > URL: https://issues.apache.org/jira/browse/CARBONDATA-1171 > Project: CarbonData > Issue Type: Bug > Components: sql >Reporter: Kunal Kapoor >Assignee: Kunal Kapoor >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] carbondata pull request #995: [CARBONDATA-1123] Rename interface and variabl...
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/995#discussion_r121879498
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForNoInvertedIndex.java
---
@@ -38,26 +37,26 @@
private byte[] max;
public BlockIndexerStorageForNoInvertedIndex(byte[][] keyBlockInput) {
--- End diff --
rename parameter keyBlockInput
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #995: [CARBONDATA-1123] Rename interface and variabl...
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/995#discussion_r121880914
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForInt.java
---
@@ -27,25 +27,26 @@
public class BlockIndexerStorageForInt implements IndexStorage {
private boolean alreadySorted;
- private int[] dataAfterComp;
+ private int[] rowIdPage;
- private int[] indexMap;
+ private int[] rowIdRlePage;
- private byte[][] keyBlock;
+ private byte[][] dataPage;
- private int[] dataIndexMap;
+ private int[] dataRlePage;
private int totalSize;
- public BlockIndexerStorageForInt(byte[][] keyBlock, boolean
compressData, boolean isNoDictionary,
+ public BlockIndexerStorageForInt(byte[][] dataPage, boolean rleOnData,
boolean isNoDictionary,
boolean isSortRequired) {
-ColumnWithIntIndex[] columnWithIndexs =
createColumnWithIndexArray(keyBlock, isNoDictionary);
+ColumnWithIntIndex[] dataWithRowId =
createColumnWithIndexArray(dataPage, isNoDictionary);
if (isSortRequired) {
- Arrays.sort(columnWithIndexs);
+ Arrays.sort(dataWithRowId);
}
-compressMyOwnWay(extractDataAndReturnIndexes(columnWithIndexs,
keyBlock));
-if (compressData) {
- compressDataMyOwnWay(columnWithIndexs);
+int[] rowIds = extractDataAndReturnIndexes(dataWithRowId, dataPage);
--- End diff --
suggest to change:
extractDataAndReturnIndexes => extractDataAndReturnRowIds
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #995: [CARBONDATA-1123] Rename interface and variabl...
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/995#discussion_r121883050
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
---
@@ -193,13 +194,13 @@ private void
compressDataMyOwnWay(ColumnWithShortIndex[] indexes) {
map.add(counter);
// if rle is index size is more than 70% then rle wont give any benefit
// so better to avoid rle index and write data as it is
-boolean useRle = (((list.size() + map.size()) * 100) / indexes.length)
< 70;
+boolean useRle = (((list.size() + map.size()) * 100) /
dataWithRowId.length) < 70;
if (useRle) {
- this.keyBlock = convertToKeyArray(list);
- dataIndexMap = convertToArray(map);
+ this.dataPage = convertToKeyArray(list);
--- End diff --
convertToDataPage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #995: [CARBONDATA-1123] Rename interface and variabl...
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/995#discussion_r121882250
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
---
@@ -27,25 +27,26 @@
private boolean alreadySorted;
- private short[] dataAfterComp;
+ private short[] rowIdPage;
- private short[] indexMap;
+ private short[] rowIdRlePage;
- private byte[][] keyBlock;
+ private byte[][] dataPage;
- private short[] dataIndexMap;
+ private short[] dataRlePage;
private int totalSize;
- public BlockIndexerStorageForShort(byte[][] keyBlock, boolean
compressData,
+ public BlockIndexerStorageForShort(byte[][] dataPage, boolean rleOnData,
boolean isNoDictionary, boolean isSortRequired) {
-ColumnWithShortIndex[] columnWithIndexs =
createColumnWithIndexArray(keyBlock, isNoDictionary);
+ColumnWithShortIndex[] dataWithRowId =
createColumnWithIndexArray(dataPage, isNoDictionary);
--- End diff --
ColumnWithShortIndex => ColumnWithShortRowId
createColumnWithIndexArray => createColumnWithRowId
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #995: [CARBONDATA-1123] Rename interface and variabl...
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/995#discussion_r121879268 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForNoInvertedIndexForShort.java --- @@ -38,42 +38,42 @@ public BlockIndexerStorageForNoInvertedIndexForShort(byte[][] keyBlockInput, --- End diff -- rename parameter keyBlockInput --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #995: [CARBONDATA-1123] Rename interface and variabl...
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/995#discussion_r121879795
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
---
@@ -71,14 +72,14 @@ public BlockIndexerStorageForShort(byte[][] keyBlock,
boolean compressData,
return columnWithIndexs;
}
- private short[] extractDataAndReturnIndexes(ColumnWithShortIndex[]
columnWithIndexs,
+ private short[] extractDataAndReturnRowId(ColumnWithShortIndex[]
dataWithRowId,
byte[][] keyBlock) {
--- End diff --
rename parameter keyBlock, and line 58 also need
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #995: [CARBONDATA-1123] Rename interface and variabl...
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/995#discussion_r121882386
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
---
@@ -27,25 +27,26 @@
private boolean alreadySorted;
- private short[] dataAfterComp;
+ private short[] rowIdPage;
- private short[] indexMap;
+ private short[] rowIdRlePage;
- private byte[][] keyBlock;
+ private byte[][] dataPage;
- private short[] dataIndexMap;
+ private short[] dataRlePage;
private int totalSize;
- public BlockIndexerStorageForShort(byte[][] keyBlock, boolean
compressData,
+ public BlockIndexerStorageForShort(byte[][] dataPage, boolean rleOnData,
boolean isNoDictionary, boolean isSortRequired) {
-ColumnWithShortIndex[] columnWithIndexs =
createColumnWithIndexArray(keyBlock, isNoDictionary);
+ColumnWithShortIndex[] dataWithRowId =
createColumnWithIndexArray(dataPage, isNoDictionary);
if (isSortRequired) {
- Arrays.sort(columnWithIndexs);
+ Arrays.sort(dataWithRowId);
}
-compressMyOwnWay(extractDataAndReturnIndexes(columnWithIndexs,
keyBlock));
-if (compressData) {
- compressDataMyOwnWay(columnWithIndexs);
+short[] rowIds = extractDataAndReturnRowId(dataWithRowId, dataPage);
--- End diff --
extractDataAndReturnRowId => extractDataAndReturnRowIds
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #995: [CARBONDATA-1123] Rename interface and variabl...
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/995#discussion_r121880639
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForInt.java
---
@@ -27,25 +27,26 @@
public class BlockIndexerStorageForInt implements IndexStorage {
private boolean alreadySorted;
- private int[] dataAfterComp;
+ private int[] rowIdPage;
- private int[] indexMap;
+ private int[] rowIdRlePage;
- private byte[][] keyBlock;
+ private byte[][] dataPage;
- private int[] dataIndexMap;
+ private int[] dataRlePage;
private int totalSize;
- public BlockIndexerStorageForInt(byte[][] keyBlock, boolean
compressData, boolean isNoDictionary,
+ public BlockIndexerStorageForInt(byte[][] dataPage, boolean rleOnData,
boolean isNoDictionary,
boolean isSortRequired) {
-ColumnWithIntIndex[] columnWithIndexs =
createColumnWithIndexArray(keyBlock, isNoDictionary);
+ColumnWithIntIndex[] dataWithRowId =
createColumnWithIndexArray(dataPage, isNoDictionary);
--- End diff --
suggest to change as following.
ColumnWithIntIndex => ColumnWithRowId
createColumnWithIndexArray => createColumnWithRowId
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #995: [CARBONDATA-1123] Rename interface and variabl...
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/995#discussion_r121881594
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForInt.java
---
@@ -189,11 +190,11 @@ private void
compressDataMyOwnWay(ColumnWithIntIndex[] indexes) {
}
map.add(start);
map.add(counter);
-this.keyBlock = convertToKeyArray(list);
-if (indexes.length == keyBlock.length) {
- dataIndexMap = new int[0];
+this.dataPage = convertToKeyArray(list);
--- End diff --
convertToDataPage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #995: [CARBONDATA-1123] Rename interface and variabl...
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/995#discussion_r121873409
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForInt.java
---
@@ -73,14 +74,14 @@ public BlockIndexerStorageForInt(byte[][] keyBlock,
boolean compressData, boolea
return columnWithIndexs;
}
- private int[] extractDataAndReturnIndexes(ColumnWithIntIndex[]
columnWithIndexs,
+ private int[] extractDataAndReturnIndexes(ColumnWithIntIndex[]
dataWithRowId,
byte[][] keyBlock) {
--- End diff --
rename parameter keyBlock, and line 58 also need
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1016: [CARBONDATA-1152] List partition not working ...
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1016#discussion_r121887136
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -774,11 +774,17 @@ abstract class CarbonDDLSqlParser extends
AbstractCarbonSparkSQLParser {
* @return
*/
protected def getProperties(node: Node): Seq[(String, String)] = {
+val noConvertList = Array("LIST_INFO", "RANGE_INFO")
--- End diff --
remove unused variable
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1016: [CARBONDATA-1152] List partition not working properl...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1016 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2464/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/972 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #961: [CARBONDATA-1098] change PageStatistics to use exact ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/961 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2465/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1016: [CARBONDATA-1152] List partition not working properl...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/1016 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/348/Failed Tests: 1carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-core: 1org.apache.carbondata.core.scan.filter.executer.ExcludeFilterExecuterImplTest.testPerformance --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #961: [CARBONDATA-1098] change PageStatistics to use exact ...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/961 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/349/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/972 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2466/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1031: [CARBONDATA-1170] Added condition to skip sin...
GitHub user kunal642 opened a pull request: https://github.com/apache/carbondata/pull/1031 [CARBONDATA-1170] Added condition to skip single_pass for first load The user should not be able to load using "single_pass"="true" for the first load instead the load would be restarted with "single_pass"="false" You can merge this pull request into a Git repository by running: $ git pull https://github.com/kunal642/carbondata single_pass_restrictions Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/1031.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1031 commit 00d9d2db83cfb4b08d5f317cc6a051e658130a0e Author: kunal642 Date: 2017-06-14T07:51:47Z added condition to skip single_pass for first load --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1031: [CARBONDATA-1170] Added condition to skip single_pas...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/1031 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user watermen commented on the issue: https://github.com/apache/carbondata/pull/972 I think we'd better to use `SET carbon.load.sort.scope = LOCAL_SORT` insteads of `SET SORT_SCOPE = LOCAL_SORT`, @mohammadshahidkhan can you explain the reason? cc @jackylk --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1016: [CARBONDATA-1152] List partition not working properl...
Github user BJangir commented on the issue: https://github.com/apache/carbondata/pull/1016 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/972 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/350/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1031: [CARBONDATA-1170] Added condition to skip single_pas...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1031 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2467/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1031: [CARBONDATA-1170] Added condition to skip single_pas...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/1031 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/351/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1016: [CARBONDATA-1152] List partition not working properl...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/1016 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/352/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #961: [CARBONDATA-1098] change PageStatistics to use...
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/961#discussion_r121898445
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatsVO.java
---
@@ -195,15 +192,36 @@ private int getDecimalCount(double value) {
}
public Object getMin() {
-return min;
+switch (dataType) {
+ case BYTE:
+ case SHORT:
+ case INT:
+ case LONG:
+return minLong;
+ case FLOAT:
+ case DOUBLE:
+return minDouble;
+ case DECIMAL:
+return minDecimal;
+ default:
+return null;
+}
}
public Object getMax() {
-return max;
- }
-
- public Object nonExistValue() {
-return nonExistValue;
+switch (dataType) {
+ case SHORT:
--- End diff --
please use the same datatype set in all switch case statements of this
class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1016: [CARBONDATA-1152] List partition not working properl...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1016 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2468/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1016: [CARBONDATA-1152] List partition not working properl...
Github user QiangCai commented on the issue: https://github.com/apache/carbondata/pull/1016 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/972 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2469/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/972 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/353/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1030: [CARBONDATA-1163][Bug-Fix] Convert decimal to byte a...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/1030 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/354/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1030: [CARBONDATA-1163][Bug-Fix] Convert decimal to byte a...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1030 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2470/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1031: [CARBONDATA-1170] Added condition to skip single_pas...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/1031 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/355/Failed Tests: 2carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-core: 2org.apache.carbondata.core.dictionary.client.DictionaryClientTest.testClientorg.apache.carbonda ta.core.dictionary.client.DictionaryClientTest.testToCheckIfCorrectTimeOutExceptionMessageIsThrown --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1016: [CARBONDATA-1152] List partition not working ...
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1016 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1002: [CARBONDATA-1136] Fix compaction bug for the partiti...
Github user QiangCai commented on the issue: https://github.com/apache/carbondata/pull/1002 @gvramana I will raise another PR to optimize the compaction for normal table. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1002: [CARBONDATA-1136] Fix compaction bug for the partiti...
Github user QiangCai commented on the issue: https://github.com/apache/carbondata/pull/1002 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1031: [CARBONDATA-1170] Added condition to skip single_pas...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1031 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2471/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1026: [CARBONDATA-1166] Fix bug on decimal partition colum...
Github user QiangCai commented on the issue: https://github.com/apache/carbondata/pull/1026 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1002: [CARBONDATA-1136] Fix compaction bug for the partiti...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1002 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2472/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1031: [CARBONDATA-1170] Added condition to skip single_pas...
Github user kunal642 commented on the issue: https://github.com/apache/carbondata/pull/1031 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1002: [CARBONDATA-1136] Fix compaction bug for the partiti...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/1002 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/356/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1020: [CARBONDATA-1155] Load query were failing if sort_co...
Github user QiangCai commented on the issue: https://github.com/apache/carbondata/pull/1020 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/972 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/357/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1020: [CARBONDATA-1155] Load query were failing if sort_co...
Github user QiangCai commented on the issue: https://github.com/apache/carbondata/pull/1020 @jackylk please review also --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1008: [CARBONDATA-1145] Fix single-pass issue for multi-ta...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/1008 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/358/Failed Tests: 0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1008: [CARBONDATA-1145] Fix single-pass issue for multi-ta...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1008 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2473/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1031: [CARBONDATA-1170] Added condition to skip single_pas...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/1031 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/361/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/972 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/972 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2474/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1026: [CARBONDATA-1166] Fix bug on decimal partition colum...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/1026 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/360/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/972 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/362/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1026: [CARBONDATA-1166] Fix bug on decimal partition colum...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1026 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2475/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1031: [CARBONDATA-1170] Added condition to skip single_pas...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1031 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2476/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/972 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2477/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1000#discussion_r121914301
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeColumnPage.java
---
@@ -0,0 +1,321 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.core.datastore.page;
+
+import java.math.BigDecimal;
+import java.nio.ByteBuffer;
+
+import org.apache.carbondata.core.constants.CarbonCommonConstants;
+import org.apache.carbondata.core.memory.CarbonUnsafe;
+import org.apache.carbondata.core.memory.MemoryBlock;
+import org.apache.carbondata.core.memory.MemoryException;
+import org.apache.carbondata.core.memory.UnsafeMemoryManager;
+import org.apache.carbondata.core.metadata.datatype.DataType;
+import org.apache.carbondata.core.util.DataTypeUtil;
+
+// This extension uses unsafe memory to store page data
+public class UnsafeColumnPage extends ColumnPage {
+ private MemoryBlock memoryBlock;
+
+ // base address of memoryBlock
+ private Object baseAddress;
+
+ // base offset of memoryBlock
+ private long baseOffset;
+
+ private static final int byteBits = DataType.BYTE.getSizeBits();
+ private static final int shortBits = DataType.SHORT.getSizeBits();
+ private static final int intBits = DataType.INT.getSizeBits();
+ private static final int longBits = DataType.LONG.getSizeBits();
+ private static final int floatBits = DataType.FLOAT.getSizeBits();
+ private static final int doubleBits = DataType.DOUBLE.getSizeBits();
+
+ UnsafeColumnPage(DataType dataType, int pageSize) throws MemoryException
{
+super(dataType, pageSize);
+switch (dataType) {
+ case BYTE:
+ case SHORT:
+ case INT:
+ case LONG:
+ case FLOAT:
+ case DOUBLE:
+int size = pageSize << dataType.getSizeBits();
+memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(size);
+baseAddress = memoryBlock.getBaseObject();
+baseOffset = memoryBlock.getBaseOffset();
+break;
+ case DECIMAL:
+ case STRING:
+byteArrayData = new byte[pageSize][];
--- End diff --
Why this is not moved to offheap?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1031: [CARBONDATA-1170] Added condition to skip single_pas...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1031 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2478/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1031: [CARBONDATA-1170] Added condition to skip single_pas...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/1031 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/363/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/972 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/364/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #972: [CARBONDATA-1065] Added set command in carbon to upda...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/972 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2479/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1026: [CARBONDATA-1166] Fix bug on decimal partition colum...
Github user QiangCai commented on the issue: https://github.com/apache/carbondata/pull/1026 @gvramana --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1030: [CARBONDATA-1163][Bug-Fix] Convert decimal to byte a...
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1030 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1030: [CARBONDATA-1163][Bug-Fix] Convert decimal to...
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1030 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1020: [CARBONDATA-1155] Load query were failing if ...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1020#discussion_r121927124
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
---
@@ -603,7 +603,7 @@ private void copyLocalFileToCarbonStore(String
carbonStoreFilePath, String local
short numberOfByteToStorLength = 2;
// as length part is removed, so each no dictionary value index
// needs to be reshuffled by 2 bytes
-for (int i = 0; i < dataWriterVo.getNoDictionaryCount(); i++) {
+for (int i = 0; i <
dataWriterVo.getSegmentProperties().getNumberOfNoDictSortColumns(); i++) {
--- End diff --
Please create a local variable for
`dataWriterVo.getSegmentProperties().getNumberOfNoDictSortColumns()`, it is
better not put in loop
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1000#discussion_r121928413
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -98,56 +117,54 @@ public static ColumnPage newPage(DataType dataType,
int pageSize) {
default:
throw new RuntimeException("Unsupported data dataType: " +
dataType);
}
-instance.stats = new ColumnPageStatsVO(dataType);
-instance.nullBitSet = new BitSet(pageSize);
return instance;
}
protected static ColumnPage newBytePage(byte[] byteData) {
ColumnPage columnPage = new ColumnPage(BYTE, byteData.length);
--- End diff --
ok, it supports, I will fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1000#discussion_r121928358
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -98,56 +117,54 @@ public static ColumnPage newPage(DataType dataType,
int pageSize) {
default:
throw new RuntimeException("Unsupported data dataType: " +
dataType);
}
-instance.stats = new ColumnPageStatsVO(dataType);
-instance.nullBitSet = new BitSet(pageSize);
return instance;
}
protected static ColumnPage newBytePage(byte[] byteData) {
ColumnPage columnPage = new ColumnPage(BYTE, byteData.length);
--- End diff --
ok, I will fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1000#discussion_r121928939
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -98,56 +117,54 @@ public static ColumnPage newPage(DataType dataType,
int pageSize) {
default:
throw new RuntimeException("Unsupported data dataType: " +
dataType);
}
-instance.stats = new ColumnPageStatsVO(dataType);
-instance.nullBitSet = new BitSet(pageSize);
return instance;
}
protected static ColumnPage newBytePage(byte[] byteData) {
ColumnPage columnPage = new ColumnPage(BYTE, byteData.length);
-columnPage.byteData = byteData;
+columnPage.setBytePage(byteData);
return columnPage;
}
- protected static ColumnPage newShortPage(short[] shortData) {
-ColumnPage columnPage = new ColumnPage(SHORT, shortData.length);
-columnPage.shortData = shortData;
+ private static ColumnPage newShortPage(short[] shortData) {
+ColumnPage columnPage = createPage(SHORT, shortData.length);
+columnPage.setShortPage(shortData);
return columnPage;
}
- protected static ColumnPage newIntPage(int[] intData) {
-ColumnPage columnPage = new ColumnPage(INT, intData.length);
-columnPage.intData = intData;
+ private static ColumnPage newIntPage(int[] intData) {
+ColumnPage columnPage = createPage(INT, intData.length);
+columnPage.setIntPage(intData);
return columnPage;
}
- protected static ColumnPage newLongPage(long[] longData) {
-ColumnPage columnPage = new ColumnPage(LONG, longData.length);
-columnPage.longData = longData;
+ private static ColumnPage newLongPage(long[] longData) {
+ColumnPage columnPage = createPage(LONG, longData.length);
+columnPage.setLongPage(longData);
return columnPage;
}
- protected static ColumnPage newFloatPage(float[] floatData) {
-ColumnPage columnPage = new ColumnPage(FLOAT, floatData.length);
-columnPage.floatData = floatData;
+ private static ColumnPage newFloatPage(float[] floatData) {
+ColumnPage columnPage = createPage(FLOAT, floatData.length);
+columnPage.setFloatPage(floatData);
return columnPage;
}
- protected static ColumnPage newDoublePage(double[] doubleData) {
-ColumnPage columnPage = new ColumnPage(DOUBLE, doubleData.length);
-columnPage.doubleData = doubleData;
+ private static ColumnPage newDoublePage(double[] doubleData) {
+ColumnPage columnPage = createPage(DOUBLE, doubleData.length);
+columnPage.setDoublePage(doubleData);
return columnPage;
}
- protected static ColumnPage newDecimalPage(byte[][] decimalData) {
-ColumnPage columnPage = new ColumnPage(DECIMAL, decimalData.length);
-columnPage.byteArrayData = decimalData;
+ private static ColumnPage newDecimalPage(byte[][] decimalData) {
+ColumnPage columnPage = createPage(DECIMAL, decimalData.length);
+columnPage.setByteArrayPage(decimalData);
return columnPage;
}
- protected static ColumnPage newVarLengthPage(byte[][] stringData) {
-ColumnPage columnPage = new ColumnPage(BYTE_ARRAY, stringData.length);
-columnPage.byteArrayData = stringData;
+ private static ColumnPage newVarLengthPage(byte[][] byteArray) {
+ColumnPage columnPage = new ColumnPage(BYTE_ARRAY, byteArray.length);
--- End diff --
It supports, I will update
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1000#discussion_r121928967
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -508,7 +567,7 @@ public static ColumnPage decompress(Compressor
compressor, DataType dataType,
}
// input byte[] is LV encoded, this function can expand it into byte[][]
- private static byte[][] deflatten(byte[] input) {
+ protected static byte[][] deflatten(byte[] input) {
--- End diff --
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Created] (CARBONDATA-1172) Batch load fails randomly
Ravindra Pesala created CARBONDATA-1172: --- Summary: Batch load fails randomly Key: CARBONDATA-1172 URL: https://issues.apache.org/jira/browse/CARBONDATA-1172 Project: CarbonData Issue Type: Bug Reporter: Ravindra Pesala Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1000#discussion_r121930114
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -323,15 +340,8 @@ public double getDouble(int rowId) {
return doubleData[rowId];
}
- /**
- * Get decimal value at rowId
- */
- public byte[] getDecimalBytes(int rowId) {
-return byteArrayData[rowId];
- }
-
public BigDecimal getDecimal(int rowId) {
--- End diff --
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1000#discussion_r121930195
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeColumnPage.java
---
@@ -0,0 +1,321 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.core.datastore.page;
+
+import java.math.BigDecimal;
+import java.nio.ByteBuffer;
+
+import org.apache.carbondata.core.constants.CarbonCommonConstants;
+import org.apache.carbondata.core.memory.CarbonUnsafe;
+import org.apache.carbondata.core.memory.MemoryBlock;
+import org.apache.carbondata.core.memory.MemoryException;
+import org.apache.carbondata.core.memory.UnsafeMemoryManager;
+import org.apache.carbondata.core.metadata.datatype.DataType;
+import org.apache.carbondata.core.util.DataTypeUtil;
+
+// This extension uses unsafe memory to store page data
+public class UnsafeColumnPage extends ColumnPage {
+ private MemoryBlock memoryBlock;
+
+ // base address of memoryBlock
+ private Object baseAddress;
+
+ // base offset of memoryBlock
+ private long baseOffset;
+
+ private static final int byteBits = DataType.BYTE.getSizeBits();
+ private static final int shortBits = DataType.SHORT.getSizeBits();
+ private static final int intBits = DataType.INT.getSizeBits();
+ private static final int longBits = DataType.LONG.getSizeBits();
+ private static final int floatBits = DataType.FLOAT.getSizeBits();
+ private static final int doubleBits = DataType.DOUBLE.getSizeBits();
+
+ UnsafeColumnPage(DataType dataType, int pageSize) throws MemoryException
{
+super(dataType, pageSize);
+switch (dataType) {
+ case BYTE:
+ case SHORT:
+ case INT:
+ case LONG:
+ case FLOAT:
+ case DOUBLE:
+int size = pageSize << dataType.getSizeBits();
+memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(size);
+baseAddress = memoryBlock.getBaseObject();
+baseOffset = memoryBlock.getBaseOffset();
+break;
+ case DECIMAL:
+ case STRING:
+byteArrayData = new byte[pageSize][];
--- End diff --
I updated this PR, now all types are unsafe
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1020: [CARBONDATA-1155] Load query were failing if sort_co...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1020 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2480/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1020: [CARBONDATA-1155] Load query were failing if sort_co...
Github user rahulforallp commented on the issue: https://github.com/apache/carbondata/pull/1020 @jackylk code has refactored. Please review it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1029: [CARBONDATA-1172] Fixed batch load issue
Github user gvramana commented on the issue: https://github.com/apache/carbondata/pull/1029 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1029: [CARBONDATA-1172] Fixed batch load issue
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1029 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1020: [CARBONDATA-1155] Load query were failing if sort_co...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/1020 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/365/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata issue #1000: [CARBONDATA-1018] Add unsafe ColumnPage implementati...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1000 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2481/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (CARBONDATA-1172) Batch load fails randomly
[ https://issues.apache.org/jira/browse/CARBONDATA-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venkata Ramana G resolved CARBONDATA-1172. -- Resolution: Fixed Assignee: Ravindra Pesala Fix Version/s: 1.1.1 1.2.0 > Batch load fails randomly > - > > Key: CARBONDATA-1172 > URL: https://issues.apache.org/jira/browse/CARBONDATA-1172 > Project: CarbonData > Issue Type: Bug >Reporter: Ravindra Pesala >Assignee: Ravindra Pesala >Priority: Minor > Fix For: 1.2.0, 1.1.1 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] carbondata issue #1000: [CARBONDATA-1018] Add unsafe ColumnPage implementati...
Github user asfgit commented on the issue: https://github.com/apache/carbondata/pull/1000 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/carbondata-pr-spark-1.6/366/Failed Tests: 2carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test: 2org.apache.carbondata.spark.testsuite.bigdecimal.TestNullAndEmptyFields.test filter query on column is nullorg.apache.carbondata.spark.testsuite.bigdecimal.TestNullAndEmptyFields.test filter query on column is not null --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1000#discussion_r121932974
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java
---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.core.datastore.page;
+
+import java.math.BigDecimal;
+
+import org.apache.carbondata.core.memory.CarbonUnsafe;
+import org.apache.carbondata.core.memory.MemoryBlock;
+import org.apache.carbondata.core.memory.MemoryException;
+import org.apache.carbondata.core.memory.UnsafeMemoryManager;
+import org.apache.carbondata.core.metadata.datatype.DataType;
+import org.apache.carbondata.core.util.DataTypeUtil;
+
+// This extension uses unsafe memory to store page data, for variable
length data type (string,
+// decimal)
+public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
+
+ // memory allocated by Unsafe
+ private MemoryBlock memoryBlock;
+
+ // base address of memoryBlock
+ private Object baseAddress;
+
+ // base offset of memoryBlock
+ private long baseOffset;
+
+ // size of the allocated memory, in bytes
+ private int capacity;
+
+ // default size for each row, grows as needed
+ private static final int DEFAULT_ROW_SIZE = 8;
+
+ UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws
MemoryException {
+super(dataType, pageSize);
+capacity = pageSize * DEFAULT_ROW_SIZE;
+memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(capacity);
+baseAddress = memoryBlock.getBaseObject();
+baseOffset = memoryBlock.getBaseOffset();
+rowOffset = new int[pageSize];
+totolLength = 0;
+ }
+
+ @Override
+ public void freeMemory() {
+if (memoryBlock != null) {
+ UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
+}
+ }
+
+ private void ensureMemory(int requestSize) throws MemoryException {
+if (totolLength + requestSize > capacity) {
+ memoryBlock =
UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, requestSize);
--- End diff --
how about the data which is stored in old memory block,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1000#discussion_r121933673
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java
---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.core.datastore.page;
+
+import java.math.BigDecimal;
+
+import org.apache.carbondata.core.memory.CarbonUnsafe;
+import org.apache.carbondata.core.memory.MemoryBlock;
+import org.apache.carbondata.core.memory.MemoryException;
+import org.apache.carbondata.core.memory.UnsafeMemoryManager;
+import org.apache.carbondata.core.metadata.datatype.DataType;
+import org.apache.carbondata.core.util.DataTypeUtil;
+
+// This extension uses unsafe memory to store page data, for variable
length data type (string,
+// decimal)
+public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
+
+ // memory allocated by Unsafe
+ private MemoryBlock memoryBlock;
+
+ // base address of memoryBlock
+ private Object baseAddress;
+
+ // base offset of memoryBlock
+ private long baseOffset;
+
+ // size of the allocated memory, in bytes
+ private int capacity;
+
+ // default size for each row, grows as needed
+ private static final int DEFAULT_ROW_SIZE = 8;
+
+ UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws
MemoryException {
+super(dataType, pageSize);
+capacity = pageSize * DEFAULT_ROW_SIZE;
+memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(capacity);
+baseAddress = memoryBlock.getBaseObject();
+baseOffset = memoryBlock.getBaseOffset();
+rowOffset = new int[pageSize];
+totolLength = 0;
+ }
+
+ @Override
+ public void freeMemory() {
+if (memoryBlock != null) {
+ UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
+}
+ }
+
+ private void ensureMemory(int requestSize) throws MemoryException {
+if (totolLength + requestSize > capacity) {
+ memoryBlock =
UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, requestSize);
--- End diff --
In C/C++ world, old data should be copied to the reallocated address.
http://en.cppreference.com/w/c/memory/realloc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1000#discussion_r121934356
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java
---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.core.datastore.page;
+
+import java.math.BigDecimal;
+
+import org.apache.carbondata.core.memory.CarbonUnsafe;
+import org.apache.carbondata.core.memory.MemoryBlock;
+import org.apache.carbondata.core.memory.MemoryException;
+import org.apache.carbondata.core.memory.UnsafeMemoryManager;
+import org.apache.carbondata.core.metadata.datatype.DataType;
+import org.apache.carbondata.core.util.DataTypeUtil;
+
+// This extension uses unsafe memory to store page data, for variable
length data type (string,
+// decimal)
+public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
+
+ // memory allocated by Unsafe
+ private MemoryBlock memoryBlock;
+
+ // base address of memoryBlock
+ private Object baseAddress;
+
+ // base offset of memoryBlock
+ private long baseOffset;
+
+ // size of the allocated memory, in bytes
+ private int capacity;
+
+ // default size for each row, grows as needed
+ private static final int DEFAULT_ROW_SIZE = 8;
+
+ UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws
MemoryException {
+super(dataType, pageSize);
+capacity = pageSize * DEFAULT_ROW_SIZE;
+memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(capacity);
+baseAddress = memoryBlock.getBaseObject();
+baseOffset = memoryBlock.getBaseOffset();
+rowOffset = new int[pageSize];
+totolLength = 0;
+ }
+
+ @Override
+ public void freeMemory() {
+if (memoryBlock != null) {
+ UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
+}
+ }
+
+ private void ensureMemory(int requestSize) throws MemoryException {
+if (totolLength + requestSize > capacity) {
+ memoryBlock =
UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, requestSize);
+}
+ }
+
+ @Override
+ public void putBytes(int rowId, byte[] bytes) {
+int offset;
+if (rowId == 0) {
+ offset = 0;
+} else {
+ offset = rowOffset[rowId - 1];
+}
+
+try {
+ ensureMemory(bytes.length);
+} catch (MemoryException e) {
+ throw new RuntimeException(e);
+}
+
+for (int i = 0; i < bytes.length; i++) {
+ CarbonUnsafe.unsafe.putByte(baseAddress, baseOffset + offset + i,
bytes[i]);
--- End diff --
it is inefficient to put data byte by byte, use `copyMemory` method
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1000#discussion_r121934452
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java
---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.core.datastore.page;
+
+import java.math.BigDecimal;
+
+import org.apache.carbondata.core.memory.CarbonUnsafe;
+import org.apache.carbondata.core.memory.MemoryBlock;
+import org.apache.carbondata.core.memory.MemoryException;
+import org.apache.carbondata.core.memory.UnsafeMemoryManager;
+import org.apache.carbondata.core.metadata.datatype.DataType;
+import org.apache.carbondata.core.util.DataTypeUtil;
+
+// This extension uses unsafe memory to store page data, for variable
length data type (string,
+// decimal)
+public class UnsafeVarLengthColumnPage extends VarLengthColumnPageBase {
+
+ // memory allocated by Unsafe
+ private MemoryBlock memoryBlock;
+
+ // base address of memoryBlock
+ private Object baseAddress;
+
+ // base offset of memoryBlock
+ private long baseOffset;
+
+ // size of the allocated memory, in bytes
+ private int capacity;
+
+ // default size for each row, grows as needed
+ private static final int DEFAULT_ROW_SIZE = 8;
+
+ UnsafeVarLengthColumnPage(DataType dataType, int pageSize) throws
MemoryException {
+super(dataType, pageSize);
+capacity = pageSize * DEFAULT_ROW_SIZE;
+memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(capacity);
+baseAddress = memoryBlock.getBaseObject();
+baseOffset = memoryBlock.getBaseOffset();
+rowOffset = new int[pageSize];
+totolLength = 0;
+ }
+
+ @Override
+ public void freeMemory() {
+if (memoryBlock != null) {
+ UnsafeMemoryManager.INSTANCE.freeMemory(memoryBlock);
+}
+ }
+
+ private void ensureMemory(int requestSize) throws MemoryException {
+if (totolLength + requestSize > capacity) {
+ memoryBlock =
UnsafeMemoryManager.reallocateMemoryWithRetry(memoryBlock, requestSize);
+}
+ }
+
+ @Override
+ public void putBytes(int rowId, byte[] bytes) {
+int offset;
+if (rowId == 0) {
+ offset = 0;
+} else {
+ offset = rowOffset[rowId - 1];
+}
+
+try {
+ ensureMemory(bytes.length);
+} catch (MemoryException e) {
+ throw new RuntimeException(e);
+}
+
+for (int i = 0; i < bytes.length; i++) {
+ CarbonUnsafe.unsafe.putByte(baseAddress, baseOffset + offset + i,
bytes[i]);
+}
+rowOffset[rowId] = offset + bytes.length + 4;
+totolLength += bytes.length;
+ }
+
+ @Override
+ public void putBytes(int rowId, byte[] bytes, int offset, int length) {
+int currentRowOffset = rowOffset[rowId];
+for (int i = 0; i < length; i++) {
+ CarbonUnsafe.unsafe.putByte(baseAddress, baseOffset +
currentRowOffset + i, bytes[i]);
+}
+ }
+
+ @Override
+ public BigDecimal getDecimal(int rowId) {
+int offset, length;
+if (rowId == 0) {
+ length = rowOffset[rowId];
+ offset = 0;
+} else {
+ length = rowOffset[rowId] - rowOffset[rowId - 1];
+ offset = rowOffset[rowId - 1];
+}
+
+byte[] bytes = new byte[length];
+for (int i = 0; i < length; i++) {
+ bytes[i] = CarbonUnsafe.unsafe.getByte(baseAddress, baseOffset +
offset + i);
+}
+
+return DataTypeUtil.byteToBigDecimal(bytes);
+ }
+
+ @Override
+ public byte[][] getByteArrayPage() {
+byte[][] bytes = new byte[pageSize][];
+for (int rowId = 0; rowId < pageSize; rowId++) {
+ int offset, length;
+ if (rowId == 0) {
+length = rowOffset[rowId] - 4;
+offset = 0;
+ } else {
