[jira] [Commented] (CLOUDSTACK-9199) deployVirtualMachine API does not throw an error when cpunumber is specified for static compute offering
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275116#comment-15275116 ] ASF GitHub Bot commented on CLOUDSTACK-9199: Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1280#issuecomment-217610090 @rhtyd @swill There will not be backward compatibility issues as with static offering those parameters were not taken into consideration. They were wrongly giving the impression that they are being used. > deployVirtualMachine API does not throw an error when cpunumber is specified > for static compute offering > > > Key: CLOUDSTACK-9199 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9199 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Anshul Gangwar >Assignee: Anshul Gangwar > > When a dynamic compute offering is chosen, deployVirtualMachine API requires > details[0].cpuSpeed, details[0].cpuNumber and details[0]memory parameters to > deploy a VM. > But when a static compute offering is chosen and these parameters are > provided, then the API should throw an error as there is conflict. > ACTUAL BEHAVIOR : > VM is getting deployed with static compute offering's parameters > http://10.220.135.6/client/api?command=deployVirtualMachine&name=olotwo&response=&zoneid=ab6e4154-62a3-42a8-9627-3cbdc66bcbb6&templateid=3ce6-91b4-11e5-b6fc-e26c2aa1d1d0&hypervisor=XenServer&serviceofferingid=39643075-4b45-489d-afac-88f09d536bdd&details[0].cpuNumber=1&details[0].cpuSpeed=1000&details[0].memory=1000&securitygroupids=60844698-91b4-11e5-b6fc-e26c2aa1d1d0&_=1448277187743 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8562) User Definable Roles
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275080#comment-15275080 ] ASF GitHub Bot commented on CLOUDSTACK-8562: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-217606327 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 2 Errors: 0 Duration: 6h 11m 18s ``` **Summary of the problem(s):** ``` FAIL: Test redundant router internals -- Traceback (most recent call last): File "/data/git/cs2/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 290, in test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true "Attempt to retrieve google.com index page should be successful!" AssertionError: Attempt to retrieve google.com index page should be successful! -- Additional details in: /tmp/MarvinLogs/test_network_MN3MB5/results.txt ``` ``` FAIL: Test redundant router internals -- Traceback (most recent call last): File "/data/git/cs2/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 483, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false "Attempt to retrieve google.com index page should be successful once rule is added!" AssertionError: Attempt to retrieve google.com index page should be successful once rule is added! -- Additional details in: /tmp/MarvinLogs/test_network_MN3MB5/results.txt ``` **Associated Uploads** **`/tmp/MarvinLogs/DeployDataCenter__May_06_2016_21_34_18_ZVNY8R:`** * [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1489/tmp/MarvinLogs/DeployDataCenter__May_06_2016_21_34_18_ZVNY8R/dc_entries.obj) * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1489/tmp/MarvinLogs/DeployDataCenter__May_06_2016_21_34_18_ZVNY8R/failed_plus_exceptions.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1489/tmp/MarvinLogs/DeployDataCenter__May_06_2016_21_34_18_ZVNY8R/runinfo.txt) **`/tmp/MarvinLogs/test_network_MN3MB5:`** * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1489/tmp/MarvinLogs/test_network_MN3MB5/failed_plus_exceptions.txt) * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1489/tmp/MarvinLogs/test_network_MN3MB5/results.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1489/tmp/MarvinLogs/test_network_MN3MB5/runinfo.txt) **`/tmp/MarvinLogs/test_vpc_routers_DZWFXD:`** * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1489/tmp/MarvinLogs/test_vpc_routers_DZWFXD/failed_plus_exceptions.txt) * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1489/tmp/MarvinLogs/test_vpc_routers_DZWFXD/results.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1489/tmp/MarvinLogs/test_vpc_routers_DZWFXD/runinfo.txt) Uploads will be available until `2016-07-07 02:00:00 +0200 CEST` *Comment created by [`upr comment`](https://github.com/cloudops/upr).* > User Definable Roles > > > Key: CLOUDSTACK-8562 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Reporter: Paul Angus >Assignee: Rohit Yadav > > Static command.properties moved to database and made user definable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275079#comment-15275079 ] ASF GitHub Bot commented on CLOUDSTACK-9299: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-217606318 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 1 Errors: 0 Duration: 6h 07m 49s ``` **Summary of the problem(s):** ``` FAIL: test_03_vpc_privategw_restart_vpc_cleanup (integration.smoke.test_privategw_acl.TestPrivateGwACL) -- Traceback (most recent call last): File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 265, in test_03_vpc_privategw_restart_vpc_cleanup self.performVPCTests(vpc_off, True) File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 332, in performVPCTests self.check_pvt_gw_connectivity(vm2, public_ip_2, vm1.nic[0].ipaddress) File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 559, in check_pvt_gw_connectivity "Ping to outside world from VM should be successful" AssertionError: Ping to outside world from VM should be successful -- Additional details in: /tmp/MarvinLogs/test_network_FIVJNA/results.txt ``` **Associated Uploads** **`/tmp/MarvinLogs/DeployDataCenter__May_06_2016_21_31_06_LPI7VW:`** * [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1502/tmp/MarvinLogs/DeployDataCenter__May_06_2016_21_31_06_LPI7VW/dc_entries.obj) * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1502/tmp/MarvinLogs/DeployDataCenter__May_06_2016_21_31_06_LPI7VW/failed_plus_exceptions.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1502/tmp/MarvinLogs/DeployDataCenter__May_06_2016_21_31_06_LPI7VW/runinfo.txt) **`/tmp/MarvinLogs/test_network_FIVJNA:`** * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1502/tmp/MarvinLogs/test_network_FIVJNA/failed_plus_exceptions.txt) * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1502/tmp/MarvinLogs/test_network_FIVJNA/results.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1502/tmp/MarvinLogs/test_network_FIVJNA/runinfo.txt) **`/tmp/MarvinLogs/test_vpc_routers_WUHEVI:`** * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1502/tmp/MarvinLogs/test_vpc_routers_WUHEVI/failed_plus_exceptions.txt) * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1502/tmp/MarvinLogs/test_vpc_routers_WUHEVI/results.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1502/tmp/MarvinLogs/test_vpc_routers_WUHEVI/runinfo.txt) Uploads will be available until `2016-07-07 02:00:00 +0200 CEST` *Comment created by [`upr comment`](https://github.com/cloudops/upr).* > Out-of-band Management for CloudStack > - > > Key: CLOUDSTACK-9299 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.9.0, Future > > > Support access to a host’s out-of-band management interface (e.g. IPMI, iLO, > DRAC, etc.) to manage host power operations (on/off etc.) and querying > current power state. > FS: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9287) As an User I want to use Private Gateways with Redundant VPCs
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275072#comment-15275072
]
ASF GitHub Bot commented on CLOUDSTACK-9287:
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-217605374
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 1
Duration: 10h 26m 38s
```
**Summary of the problem(s):**
```
FAIL: Test destroy(expunge) Virtual Machine
--
Traceback (most recent call last):
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line
646, in test_09_expunge_vm
self.assertEqual(list_vm_response,None,"Check Expunged virtual machine
is in listVirtualMachines response")
AssertionError: Check Expunged virtual machine is in listVirtualMachines
response
--
Additional details in: /tmp/MarvinLogs/test_vpc_routers_LJEVIW/results.txt
```
```
ERROR: Test to verify access to loadbalancer haproxy admin stats page
--
Traceback (most recent call last):
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line
854, in tearDown
raise Exception("Cleanup failed with %s" % e)
Exception: Cleanup failed with Job failed: {jobprocstatus : 0, created :
u'2016-05-07T01:17:22+0200', jobresult : {errorcode : 530, errortext : u'Failed
to delete network'}, cmd :
u'org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd', userid :
u'ecdfa0ce-13af-11e6-929e-5254001daa61', jobstatus : 2, jobid :
u'7ba837e5-36f2-4467-ab1b-69305fe3c897', jobresultcode : 530, jobresulttype :
u'object', jobinstancetype : u'Network', accountid :
u'ecdf8a0d-13af-11e6-929e-5254001daa61'}
--
Additional details in: /tmp/MarvinLogs/test_network_4LL71G/results.txt
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_06_2016_19_30_38_6T9JP6:`**
*
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1483/tmp/MarvinLogs/DeployDataCenter__May_06_2016_19_30_38_6T9JP6/dc_entries.obj)
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1483/tmp/MarvinLogs/DeployDataCenter__May_06_2016_19_30_38_6T9JP6/failed_plus_exceptions.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1483/tmp/MarvinLogs/DeployDataCenter__May_06_2016_19_30_38_6T9JP6/runinfo.txt)
**`/tmp/MarvinLogs/test_network_4LL71G:`**
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1483/tmp/MarvinLogs/test_network_4LL71G/failed_plus_exceptions.txt)
*
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1483/tmp/MarvinLogs/test_network_4LL71G/results.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1483/tmp/MarvinLogs/test_network_4LL71G/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_LJEVIW:`**
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1483/tmp/MarvinLogs/test_vpc_routers_LJEVIW/failed_plus_exceptions.txt)
*
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1483/tmp/MarvinLogs/test_vpc_routers_LJEVIW/results.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1483/tmp/MarvinLogs/test_vpc_routers_LJEVIW/runinfo.txt)
Uploads will be available until `2016-07-07 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
> As an User I want to use Private Gateways with Redundant VPCs
> -
>
> Key: CLOUDSTACK-9287
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9287
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
>Affects Versions: 4.6.0, 4.7.0, 4.8.0
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.9.0
>
>
> Currently we cannot:
> 1. Delete the gateway from a rVPC
> 2. Restart a rVPC that has a private gateway configured
> 3. Have redundancy with private gateway on a rVPC: once master dies the pvt
> gw is not properly configured in the new master router
--
This me
[jira] [Commented] (CLOUDSTACK-6928) IOPS throttling setting isn't applied to a dinamically attached volume
[ https://issues.apache.org/jira/browse/CLOUDSTACK-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275026#comment-15275026 ] haijiao commented on CLOUDSTACK-6928: - can anyone take review on this ? as IOPS throttling is important feature to serve massive users. > IOPS throttling setting isn't applied to a dinamically attached volume > -- > > Key: CLOUDSTACK-6928 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6928 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM >Affects Versions: 4.4.0, Future > Environment: CloudStack 4.4-forward w/ KVM deployment > Ubuntu Server 14.04 >Reporter: Yoshikazu Nojima >Assignee: Wei Zhou >Priority: Critical > Labels: KVM > > IOPS throttling setting is NOT applied to a volume attached while VM is > running. > I confirmed the setting is applied to a volume attached while VM is stopped. > attach volume agent log: > 2014-06-17 19:07:22,356 DEBUG [cloud.agent.Agent] > (agentRequest-Handler-3:null) Processing command: > org.apache.cloudstack.storage.command.AttachCommand > 2014-06-17 19:07:22,401 DEBUG [kvm.storage.KVMStorageProcessor] > (agentRequest-Handler-3:null) Attaching device: type='file'> > > file='/mnt/ec7a4ea0-a11f-3ab6-89f5-6c2702e3fcf8/e01df6a7-f832-4616-a151-8ad8bcd4cf64'/> > > > start instance agent log: > 2014-06-17 19:10:47,984 DEBUG [kvm.resource.LibvirtComputingResource] > (agentRequest-Handler-1:null) starting i-2-3-VM: > i-2-3-VM > 8fad689b-d63d-4802-81d9-d11acf91b879 > CentOS 5.5 (64-bit) > > > > > > > > > /usr/bin/kvm-spice > > > > > > > > > > > > > passwd='987a62e28e4358d8'/> > > > file='/mnt/e70b1e09-b7e8-3f14-8779-cfb75b651119/b1967fe4-6100-4777-8804-26a349ef06ea'/> > > > > > file='/mnt/ec7a4ea0-a11f-3ab6-89f5-6c2702e3fcf8/92920d85-1190-43ce-af03-5d2f6a6e1004'/> > > > 200 > 200 > > > > > file='/mnt/ec7a4ea0-a11f-3ab6-89f5-6c2702e3fcf8/e01df6a7-f832-4616-a151-8ad8bcd4cf64'/> > > > 200 > 200 > > > > > > > > > > > > > 1048576 > > > > 1 > > hvm > > > > > 1000 > > restart > destroy > destroy > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9375) Cloudstack Management Memory Leak on org.apache.coyote.RequestInfo
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274714#comment-15274714
]
Carles Figuerola commented on CLOUDSTACK-9375:
--
Thanks to everyone for your comments, I've set up three different nodes with
different versions. I still have the node running tomcat6-6.0.24-90.el6.x86_64
which seems to unequivocally be going to its death
(http://i.imgur.com/Is6GsLv.png). I set up the second management server with
[~jburwell]'s recommended tomcat6-6.0.43-62.el6 and the third with
[~sudhansu]'s recommended tomcat6-6.0.24-80.el6. I'm also graphing those two
servers and we'll see how the test fares. I'll keep you updated.
Also, [~serverchief], all three hosts seem to have a similar results for the
number of threads. Running that command prints the pid as many times as the
number of threads I'm graphing.
> Cloudstack Management Memory Leak on org.apache.coyote.RequestInfo
> --
>
> Key: CLOUDSTACK-9375
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9375
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
>Affects Versions: 4.5.2
> Environment: CentOS release 6.7 (Final)
>Reporter: Carles Figuerola
>
> After deploying ACS (cloudstack-management-4.5.2-1.el6.x86_64), using a 4
> management cluster, the management pid keeps crashing with out of memory
> errors. Eclipse Memory Analyzer points to this class
> (org.apache.coyote.RequestInfo) as the culpable one:
> {code}
> 66,923 instances of "org.apache.coyote.RequestInfo", loaded by
> "org.apache.catalina.loader.StandardClassLoader @ 0x600026b98" occupy
> 6,227,824,472 (94.91%) bytes. These instances are referenced from one
> instance of "java.lang.Object[]", loaded by ""
> {code}
> Strangely, this is not affecting a smaller installation (2 management, 90
> hosts, ~2000 VMs) that is running ACS 4.5.2 over CentOS 6.7 or a clone of the
> broken one (4 management, 300 hosts, ~4000 VMs) running ACS 4.5.2 over Ubuntu
> 12.04.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8800) Improve the listVirtualMachines API call to include memory utilization information for a VM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274608#comment-15274608 ] ASF GitHub Bot commented on CLOUDSTACK-8800: Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-217537499 @swill done ;) > Improve the listVirtualMachines API call to include memory utilization > information for a VM > --- > > Key: CLOUDSTACK-8800 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8800 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.5.2 >Reporter: Maneesha >Assignee: Maneesha > Fix For: Future > > > Currently the feature of memory utilization is not available via API call > (listVirtualMachines). > https://cloudstack.apache.org/api/apidocs-4.5/root_admin/listVirtualMachines.html > > The listVirtualMachine get its values from the "user_vm_view" table in the > database. Currently it shows the CPU utilization of the VM's. > The only way to find out the memory utilization of VM's running on XenServer, > is to run the "xentop" command on the pool master of the cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9348) CloudStack Server degrades when a lot of connections on port 8250
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274516#comment-15274516 ] ASF subversion and git services commented on CLOUDSTACK-9348: - Commit 9f970f28b18534dffe33196ead60ea861f501fa9 in cloudstack's branch refs/heads/master from [~williamstev...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9f970f2 ] Merge pull request #1534 from shapeblue/niotest-fix CLOUDSTACK-9348: Optimize NioTest and NioConnection main loop- Reduces SSL handshake timeout to 15s, previously this was only 10s in commit debfcdef788ce0d51be06db0ef10f6815f9b563b - Adds an aggresive explicit wakeup to save the Nio main IO loop/handler from getting blocked - Fix NioTest to fail/succeed in about 60s, previously this was 300s - Due to aggresive wakeup usage, NioTest should complete in less than 5s on most systems. On virtualized environment this may slightly increase due to thread, CPU burst/scheduling delays. /cc @swill please review and merge. Sorry about the previous values, they were not optimized for virtualized env. The aggressive selector.wakeup will ensure main IO loop does not get blocked even by malicious users, even for any timeout (ssl handshake etc). * pr/1534: CLOUDSTACK-9348: Optimize NioTest and NioConnection main loop Signed-off-by: Will Stevens > CloudStack Server degrades when a lot of connections on port 8250 > - > > Key: CLOUDSTACK-9348 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9348 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.9.0 > > > An intermittent issue was found with a large CloudStack deployment, where > servers could not keep agents connected on port 8250. > All connections are handled by accept() in NioConnection: > https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L125 > A new connection is handled by accept() which does blocking SSL handshake. A > good fix would be to make this non-blocking and handle expensive tasks in > separate threads/pool. This way the main IO loop won't be blocked and can > continue to serve other agents/clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9348) CloudStack Server degrades when a lot of connections on port 8250
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274518#comment-15274518 ] ASF GitHub Bot commented on CLOUDSTACK-9348: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1534 > CloudStack Server degrades when a lot of connections on port 8250 > - > > Key: CLOUDSTACK-9348 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9348 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.9.0 > > > An intermittent issue was found with a large CloudStack deployment, where > servers could not keep agents connected on port 8250. > All connections are handled by accept() in NioConnection: > https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L125 > A new connection is handled by accept() which does blocking SSL handshake. A > good fix would be to make this non-blocking and handle expensive tasks in > separate threads/pool. This way the main IO loop won't be blocked and can > continue to serve other agents/clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9348) CloudStack Server degrades when a lot of connections on port 8250
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274517#comment-15274517 ] ASF subversion and git services commented on CLOUDSTACK-9348: - Commit 9f970f28b18534dffe33196ead60ea861f501fa9 in cloudstack's branch refs/heads/master from [~williamstev...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9f970f2 ] Merge pull request #1534 from shapeblue/niotest-fix CLOUDSTACK-9348: Optimize NioTest and NioConnection main loop- Reduces SSL handshake timeout to 15s, previously this was only 10s in commit debfcdef788ce0d51be06db0ef10f6815f9b563b - Adds an aggresive explicit wakeup to save the Nio main IO loop/handler from getting blocked - Fix NioTest to fail/succeed in about 60s, previously this was 300s - Due to aggresive wakeup usage, NioTest should complete in less than 5s on most systems. On virtualized environment this may slightly increase due to thread, CPU burst/scheduling delays. /cc @swill please review and merge. Sorry about the previous values, they were not optimized for virtualized env. The aggressive selector.wakeup will ensure main IO loop does not get blocked even by malicious users, even for any timeout (ssl handshake etc). * pr/1534: CLOUDSTACK-9348: Optimize NioTest and NioConnection main loop Signed-off-by: Will Stevens > CloudStack Server degrades when a lot of connections on port 8250 > - > > Key: CLOUDSTACK-9348 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9348 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.9.0 > > > An intermittent issue was found with a large CloudStack deployment, where > servers could not keep agents connected on port 8250. > All connections are handled by accept() in NioConnection: > https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L125 > A new connection is handled by accept() which does blocking SSL handshake. A > good fix would be to make this non-blocking and handle expensive tasks in > separate threads/pool. This way the main IO loop won't be blocked and can > continue to serve other agents/clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9348) CloudStack Server degrades when a lot of connections on port 8250
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274515#comment-15274515 ] ASF subversion and git services commented on CLOUDSTACK-9348: - Commit ea22869593f68a3a34b12aeb23c2bb6c34efd365 in cloudstack's branch refs/heads/master from [~rohit.ya...@shapeblue.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ea22869 ] CLOUDSTACK-9348: Optimize NioTest and NioConnection main loop - Reduces SSL handshake timeout to 15s, previously this was only 10s in commit debfcdef788ce0d51be06db0ef10f6815f9b563b - Adds an aggresive explicit wakeup to save the Nio main IO loop/handler from getting blocked - Fix NioTest to fail/succeed in about 60s, previously this was 300s - Due to aggresive wakeup usage, NioTest should complete in less than 5s on most systems. On virtualized environment this may slightly increase due to thread, CPU burst/scheduling delays. Signed-off-by: Rohit Yadav > CloudStack Server degrades when a lot of connections on port 8250 > - > > Key: CLOUDSTACK-9348 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9348 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.9.0 > > > An intermittent issue was found with a large CloudStack deployment, where > servers could not keep agents connected on port 8250. > All connections are handled by accept() in NioConnection: > https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L125 > A new connection is handled by accept() which does blocking SSL handshake. A > good fix would be to make this non-blocking and handle expensive tasks in > separate threads/pool. This way the main IO loop won't be blocked and can > continue to serve other agents/clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9348) CloudStack Server degrades when a lot of connections on port 8250
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274509#comment-15274509 ] ASF GitHub Bot commented on CLOUDSTACK-9348: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1534#issuecomment-217521378 I am not concerned about the two failures. One happens randomly in my environment and one is a cleanup issue between test runs which is not related to this PR. Since `master` is currently broken due to some issues with #1493, I am going to merge this right away... > CloudStack Server degrades when a lot of connections on port 8250 > - > > Key: CLOUDSTACK-9348 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9348 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.9.0 > > > An intermittent issue was found with a large CloudStack deployment, where > servers could not keep agents connected on port 8250. > All connections are handled by accept() in NioConnection: > https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L125 > A new connection is handled by accept() which does blocking SSL handshake. A > good fix would be to make this non-blocking and handle expensive tasks in > separate threads/pool. This way the main IO loop won't be blocked and can > continue to serve other agents/clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9348) CloudStack Server degrades when a lot of connections on port 8250
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274498#comment-15274498
]
ASF GitHub Bot commented on CLOUDSTACK-9348:
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1534#issuecomment-217519767
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 2
Errors: 0
Duration: 4h 31m 04s
```
**Summary of the problem(s):**
```
FAIL: Test redundant router internals
--
Traceback (most recent call last):
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py",
line 290, in test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true
"Attempt to retrieve google.com index page should be successful!"
AssertionError: Attempt to retrieve google.com index page should be
successful!
--
Additional details in: /tmp/MarvinLogs/test_network_C0JJZR/results.txt
```
```
FAIL: test_02_vpc_privategw_static_routes
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line
253, in test_02_vpc_privategw_static_routes
self.performVPCTests(vpc_off)
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line
304, in performVPCTests
privateGw_1 = self.createPvtGw(vpc_1, "10.0.3.100", "10.0.3.101",
acl1.id, vlan_1)
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line
472, in createPvtGw
self.fail("Failed to create Private Gateway ==> %s" % e)
AssertionError: Failed to create Private Gateway ==> Execute cmd:
createprivategateway failed, due to: errorCode: 431, errorText:Network with
vlan vlan://100 already exists in zone 1
--
Additional details in: /tmp/MarvinLogs/test_network_C0JJZR/results.txt
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_06_2016_15_29_07_FHJDSL:`**
*
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1534/tmp/MarvinLogs/DeployDataCenter__May_06_2016_15_29_07_FHJDSL/dc_entries.obj)
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1534/tmp/MarvinLogs/DeployDataCenter__May_06_2016_15_29_07_FHJDSL/failed_plus_exceptions.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1534/tmp/MarvinLogs/DeployDataCenter__May_06_2016_15_29_07_FHJDSL/runinfo.txt)
**`/tmp/MarvinLogs/test_network_C0JJZR:`**
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1534/tmp/MarvinLogs/test_network_C0JJZR/failed_plus_exceptions.txt)
*
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1534/tmp/MarvinLogs/test_network_C0JJZR/results.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1534/tmp/MarvinLogs/test_network_C0JJZR/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_7C30C4:`**
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1534/tmp/MarvinLogs/test_vpc_routers_7C30C4/failed_plus_exceptions.txt)
*
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1534/tmp/MarvinLogs/test_vpc_routers_7C30C4/results.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1534/tmp/MarvinLogs/test_vpc_routers_7C30C4/runinfo.txt)
Uploads will be available until `2016-07-06 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
> CloudStack Server degrades when a lot of connections on port 8250
> -
>
> Key: CLOUDSTACK-9348
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9348
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.9.0
>
>
> An intermittent issue was found with a large CloudStack deployment, where
> servers could not keep agents connected on port 8250.
> All connections are handled by accept() in NioConnection:
> https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274467#comment-15274467 ] ASF GitHub Bot commented on CLOUDSTACK-9299: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-217515255 Both this one and dynamic roles are queued up for CI as soon as I stabilize master. > Out-of-band Management for CloudStack > - > > Key: CLOUDSTACK-9299 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.9.0, Future > > > Support access to a host’s out-of-band management interface (e.g. IPMI, iLO, > DRAC, etc.) to manage host power operations (on/off etc.) and querying > current power state. > FS: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9300) MySQL HA feature StaticStrategy throws exception
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274457#comment-15274457 ] ASF GitHub Bot commented on CLOUDSTACK-9300: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217513880 Ok, I will get CI run against this one to make sure that nothing else is broken. This is ready pending the CI run... > MySQL HA feature StaticStrategy throws exception > > > Key: CLOUDSTACK-9300 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9300 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.7.0, 4.7.1, 4.8.0, Future > Environment: Centos 7 >Reporter: Simon Weller >Assignee: Simon Weller >Priority: Minor > Fix For: 4.9.0 > > > 2016-03-03 12:00:13,204 INFO [c.c.u.d.T.Transaction] > (localhost-startStop-1:null) (logid:) Is Data Base High Availiability > enabled? Ans : true > 2016-03-03 12:00:13,239 INFO [c.c.u.d.T.Transaction] > (localhost-startStop-1:null) (logid:) The slaves configured for Cloud Data > base is/are : localhost,localhost > 2016-03-03 12:00:13,303 ERROR [c.c.u.d.Merovingian2] > (localhost-startStop-1:null) (logid:) Unable to get a new db connection > java.sql.SQLException: Invalid load balancing strategy > 'com.cloud.utils.db.StaticStrategy'. > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:927) > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:924) > at com.mysql.jdbc.Util.loadExtensions(Util.java:602) > at > com.mysql.jdbc.LoadBalancingConnectionProxy.(LoadBalancingConnectionProxy.java:280) > at > com.mysql.jdbc.FailoverConnectionProxy.(FailoverConnectionProxy.java:67) > at > com.mysql.jdbc.NonRegisteringDriver.connectFailover(NonRegisteringDriver.java:433) > at > com.mysql.jdbc.NonRegisteringDriver.connect(NonRegisteringDriver.java:346) > at java.sql.DriverManager.getConnection(DriverManager.java:571) > at java.sql.DriverManager.getConnection(DriverManager.java:215) > at > org.apache.commons.dbcp.DriverManagerConnectionFactory.createConnection(DriverManagerConnectionFactory.java:75) > at > org.apache.commons.dbcp.PoolableConnectionFactory.makeObject(PoolableConnectionFactory.java:582) > at > org.apache.commons.pool.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:1188) > at > org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) > at > com.cloud.utils.db.TransactionLegacy.getStandaloneConnectionWithException(TransactionLegacy.java:202) > at com.cloud.utils.db.Merovingian2.(Merovingian2.java:68) > at > com.cloud.utils.db.Merovingian2.createLockMaster(Merovingian2.java:88) > at > com.cloud.server.LockMasterListener.(LockMasterListener.java:33) > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native > Method) > at > sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57) > at > sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at java.lang.reflect.Constructor.newInstance(Constructor.java:526) > at > org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:148) > at > org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:121) > at > org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:277) > at > org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireConstructor(AbstractAutowireCapableBeanFactory.java:1077) > at > org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:981) > at > org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:487) > at > org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:458) > at > org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:293) > at > org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:223) > at > org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:290) > at > org.springframework.beans.factory.support.AbstractBe
[jira] [Commented] (CLOUDSTACK-9300) MySQL HA feature StaticStrategy throws exception
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274408#comment-15274408 ] ASF GitHub Bot commented on CLOUDSTACK-9300: Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217507957 LGTM (code review only) > MySQL HA feature StaticStrategy throws exception > > > Key: CLOUDSTACK-9300 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9300 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.7.0, 4.7.1, 4.8.0, Future > Environment: Centos 7 >Reporter: Simon Weller >Assignee: Simon Weller >Priority: Minor > Fix For: 4.9.0 > > > 2016-03-03 12:00:13,204 INFO [c.c.u.d.T.Transaction] > (localhost-startStop-1:null) (logid:) Is Data Base High Availiability > enabled? Ans : true > 2016-03-03 12:00:13,239 INFO [c.c.u.d.T.Transaction] > (localhost-startStop-1:null) (logid:) The slaves configured for Cloud Data > base is/are : localhost,localhost > 2016-03-03 12:00:13,303 ERROR [c.c.u.d.Merovingian2] > (localhost-startStop-1:null) (logid:) Unable to get a new db connection > java.sql.SQLException: Invalid load balancing strategy > 'com.cloud.utils.db.StaticStrategy'. > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:927) > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:924) > at com.mysql.jdbc.Util.loadExtensions(Util.java:602) > at > com.mysql.jdbc.LoadBalancingConnectionProxy.(LoadBalancingConnectionProxy.java:280) > at > com.mysql.jdbc.FailoverConnectionProxy.(FailoverConnectionProxy.java:67) > at > com.mysql.jdbc.NonRegisteringDriver.connectFailover(NonRegisteringDriver.java:433) > at > com.mysql.jdbc.NonRegisteringDriver.connect(NonRegisteringDriver.java:346) > at java.sql.DriverManager.getConnection(DriverManager.java:571) > at java.sql.DriverManager.getConnection(DriverManager.java:215) > at > org.apache.commons.dbcp.DriverManagerConnectionFactory.createConnection(DriverManagerConnectionFactory.java:75) > at > org.apache.commons.dbcp.PoolableConnectionFactory.makeObject(PoolableConnectionFactory.java:582) > at > org.apache.commons.pool.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:1188) > at > org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) > at > com.cloud.utils.db.TransactionLegacy.getStandaloneConnectionWithException(TransactionLegacy.java:202) > at com.cloud.utils.db.Merovingian2.(Merovingian2.java:68) > at > com.cloud.utils.db.Merovingian2.createLockMaster(Merovingian2.java:88) > at > com.cloud.server.LockMasterListener.(LockMasterListener.java:33) > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native > Method) > at > sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57) > at > sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at java.lang.reflect.Constructor.newInstance(Constructor.java:526) > at > org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:148) > at > org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:121) > at > org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:277) > at > org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireConstructor(AbstractAutowireCapableBeanFactory.java:1077) > at > org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:981) > at > org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:487) > at > org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:458) > at > org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:293) > at > org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:223) > at > org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:290) > at > org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:191) > at > org.springframework.beans.facto
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274367#comment-15274367 ] ASF GitHub Bot commented on CLOUDSTACK-9299: Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-217501592 @jburwell thanks, I'll sort them out. Meanwhile, if we can get the dynamic-roles PR merged today/tomorrow, I can use the annotations/validation usage in APIs and further improve the PR > Out-of-band Management for CloudStack > - > > Key: CLOUDSTACK-9299 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.9.0, Future > > > Support access to a host’s out-of-band management interface (e.g. IPMI, iLO, > DRAC, etc.) to manage host power operations (on/off etc.) and querying > current power state. > FS: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8562) User Definable Roles
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274358#comment-15274358 ] ASF GitHub Bot commented on CLOUDSTACK-8562: Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-217500553 Thanks @swill as soon as we can merge this one, I can rebase and use some of the annotations work and ListUtils from this PR into out-of-band management PR /cc @jburwell > User Definable Roles > > > Key: CLOUDSTACK-8562 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Reporter: Paul Angus >Assignee: Rohit Yadav > > Static command.properties moved to database and made user definable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9351) Add ids parameter to resource listing API calls
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274350#comment-15274350
]
ASF GitHub Bot commented on CLOUDSTACK-9351:
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-217499701
@koushik-das @rhtyd I finished writing marvin test for this feature, I copy
my test results:
[root@ussarlabcsmgt41 cloudstack]# nosetests --with-marvin
--marvin-config=setup/dev/advanced.cfg
test/integration/smoke/test_list_ids_parameter.py
Marvin Init Started
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
Log Folder Path: /tmp//MarvinLogs//May_06_2016_09_34_04_NHXZGI. All
logs will be available here
=== Marvin Init Logging Successful===
Marvin Init Successful
===final results are now copied to:
/tmp//MarvinLogs/test_list_ids_parameter_TRKKN0===
[root@ussarlabcsmgt41 cloudstack]# cat
/tmp//MarvinLogs/test_list_ids_parameter_TRKKN0/results.txt
Test listing Volumes using 'ids' parameter ... === TestName:
test_01_list_volumes | Status : SUCCESS ===
ok
Test listing Templates using 'ids' parameter ... === TestName:
test_02_list_templates | Status : SUCCESS ===
ok
Test listing Snapshots using 'ids' parameter ... === TestName:
test_03_list_snapshots | Status : SUCCESS ===
ok
Test listing VMSnapshots using 'vmsnapshotids' parameter ... === TestName:
test_04_list_vm_snapshots | Status : SUCCESS ===
ok
--
Ran 4 tests in 1187.175s
OK
> Add ids parameter to resource listing API calls
> ---
>
> Key: CLOUDSTACK-9351
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9351
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
>Affects Versions: 4.9.0
>Reporter: Nicolas Vazquez
> Fix For: 4.9.0
>
>
> h2. General behaviour
> A new parameter is added in each method, its type a list of IDs of the
> entity, it will be mutually exclusive with id. (Similar to {{id}} and {{ids}}
> parameters in {{listVirtualMachines}} method)
> h3. API Methods affected
> * +{{listTemplates}}+: new parameter *{{ids}}*, mutually exclusive with {{id}}
> * +{{listVolumes}}+: new parameter *{{ids}}*, mutually exclusive with {{id}}
> * +{{listSnapshots}}+: new parameter *{{ids}}*, mutually exclusive with {{id}}
> * +{{listVMSnapshots}}+: new parameter *{{vmsnapshotids}}*, mutually
> exclusive with {{vmsnapshotid}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9300) MySQL HA feature StaticStrategy throws exception
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274259#comment-15274259 ] ASF GitHub Bot commented on CLOUDSTACK-9300: Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217482136 tag:mergeready > MySQL HA feature StaticStrategy throws exception > > > Key: CLOUDSTACK-9300 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9300 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.7.0, 4.7.1, 4.8.0, Future > Environment: Centos 7 >Reporter: Simon Weller >Assignee: Simon Weller >Priority: Minor > Fix For: 4.9.0 > > > 2016-03-03 12:00:13,204 INFO [c.c.u.d.T.Transaction] > (localhost-startStop-1:null) (logid:) Is Data Base High Availiability > enabled? Ans : true > 2016-03-03 12:00:13,239 INFO [c.c.u.d.T.Transaction] > (localhost-startStop-1:null) (logid:) The slaves configured for Cloud Data > base is/are : localhost,localhost > 2016-03-03 12:00:13,303 ERROR [c.c.u.d.Merovingian2] > (localhost-startStop-1:null) (logid:) Unable to get a new db connection > java.sql.SQLException: Invalid load balancing strategy > 'com.cloud.utils.db.StaticStrategy'. > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:927) > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:924) > at com.mysql.jdbc.Util.loadExtensions(Util.java:602) > at > com.mysql.jdbc.LoadBalancingConnectionProxy.(LoadBalancingConnectionProxy.java:280) > at > com.mysql.jdbc.FailoverConnectionProxy.(FailoverConnectionProxy.java:67) > at > com.mysql.jdbc.NonRegisteringDriver.connectFailover(NonRegisteringDriver.java:433) > at > com.mysql.jdbc.NonRegisteringDriver.connect(NonRegisteringDriver.java:346) > at java.sql.DriverManager.getConnection(DriverManager.java:571) > at java.sql.DriverManager.getConnection(DriverManager.java:215) > at > org.apache.commons.dbcp.DriverManagerConnectionFactory.createConnection(DriverManagerConnectionFactory.java:75) > at > org.apache.commons.dbcp.PoolableConnectionFactory.makeObject(PoolableConnectionFactory.java:582) > at > org.apache.commons.pool.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:1188) > at > org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) > at > com.cloud.utils.db.TransactionLegacy.getStandaloneConnectionWithException(TransactionLegacy.java:202) > at com.cloud.utils.db.Merovingian2.(Merovingian2.java:68) > at > com.cloud.utils.db.Merovingian2.createLockMaster(Merovingian2.java:88) > at > com.cloud.server.LockMasterListener.(LockMasterListener.java:33) > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native > Method) > at > sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57) > at > sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at java.lang.reflect.Constructor.newInstance(Constructor.java:526) > at > org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:148) > at > org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:121) > at > org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:277) > at > org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireConstructor(AbstractAutowireCapableBeanFactory.java:1077) > at > org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:981) > at > org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:487) > at > org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:458) > at > org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:293) > at > org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:223) > at > org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:290) > at > org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:191) > at > org.springframework.beans.factory.suppo
[jira] [Commented] (CLOUDSTACK-9199) deployVirtualMachine API does not throw an error when cpunumber is specified for static compute offering
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274245#comment-15274245 ] ASF GitHub Bot commented on CLOUDSTACK-9199: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1280#issuecomment-217480884 @anshul1886 can you answer @rhtyd's question so we can get his code review and get this moving forward. Thanks... > deployVirtualMachine API does not throw an error when cpunumber is specified > for static compute offering > > > Key: CLOUDSTACK-9199 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9199 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Anshul Gangwar >Assignee: Anshul Gangwar > > When a dynamic compute offering is chosen, deployVirtualMachine API requires > details[0].cpuSpeed, details[0].cpuNumber and details[0]memory parameters to > deploy a VM. > But when a static compute offering is chosen and these parameters are > provided, then the API should throw an error as there is conflict. > ACTUAL BEHAVIOR : > VM is getting deployed with static compute offering's parameters > http://10.220.135.6/client/api?command=deployVirtualMachine&name=olotwo&response=&zoneid=ab6e4154-62a3-42a8-9627-3cbdc66bcbb6&templateid=3ce6-91b4-11e5-b6fc-e26c2aa1d1d0&hypervisor=XenServer&serviceofferingid=39643075-4b45-489d-afac-88f09d536bdd&details[0].cpuNumber=1&details[0].cpuSpeed=1000&details[0].memory=1000&securitygroupids=60844698-91b4-11e5-b6fc-e26c2aa1d1d0&_=1448277187743 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8800) Improve the listVirtualMachines API call to include memory utilization information for a VM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274238#comment-15274238 ] ASF GitHub Bot commented on CLOUDSTACK-8800: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-217479698 Can we get another code review on this one. Also, can you force push to kick off Jenkins again? Thx... > Improve the listVirtualMachines API call to include memory utilization > information for a VM > --- > > Key: CLOUDSTACK-8800 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8800 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.5.2 >Reporter: Maneesha >Assignee: Maneesha > Fix For: Future > > > Currently the feature of memory utilization is not available via API call > (listVirtualMachines). > https://cloudstack.apache.org/api/apidocs-4.5/root_admin/listVirtualMachines.html > > The listVirtualMachine get its values from the "user_vm_view" table in the > database. Currently it shows the CPU utilization of the VM's. > The only way to find out the memory utilization of VM's running on XenServer, > is to run the "xentop" command on the pool master of the cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9366) Disable a host also disables storage pool capacity
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274192#comment-15274192 ] ASF GitHub Bot commented on CLOUDSTACK-9366: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-217472184 Can you force push again to get the jobs to kick off again. thanks... > Disable a host also disables storage pool capacity > -- > > Key: CLOUDSTACK-9366 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9366 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.8.0 >Reporter: Sudhansu Sahu >Assignee: Sudhansu Sahu > > Disable and Remove Host operation disables the primary storage capacity. > Steps to replicate: > Base Condition: There exists a host and storage pool with same id > Steps: > 1. Find a host and storage pool having same id > 2. Disable the host > 3. verify that the CPU(1) and MEMORY(0) capacity in op_host_capacity for > above host is disabled > 4. verify that the STORAGE(3) capacity in op_host_capacity for storage pool > with id same as above host is also disabled > RCA: > 'host_id' column in 'op_host_capacity' table used for storing both storage > pool id (for STORAGE capacity) and host id (MEMORY and CPU). While removing a > HOST we also disable the capacity associated with host. > Ideally while disabling capacity we should only disable MEMORY and CPU > capacity, but we are not doing so. > Code Path: > ResourceManagerImpl.doDeleteHost() -> > ResourceManagerImpl.resourceStateTransitTo() -> > CapacityDaoImpl.updateCapacityState(null, null, null, host.getId(), > capacityState.toString()) > updateCapacityState is updating disabling all entries which matches the > host_id. This will also disable a entry having storage pool id same as that > of host id. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8970) Centos 6.{1,2,3,4,5} guest OS mapping for vmware is not available
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274188#comment-15274188
]
ASF GitHub Bot commented on CLOUDSTACK-8970:
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-217471716
Can you do a force push again. Jenkins has been in this state for 3 days
now. Thx...
> Centos 6.{1,2,3,4,5} guest OS mapping for vmware is not available
> -
>
> Key: CLOUDSTACK-8970
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8970
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: sudharma jain
>
> "Dynamically Scale" fails everytime because the setting of the guest OS in
> VMware is not correctly set. When we set the OS Type of a
> VM(account1-centos1) to "CentOS 6.5 (64-bit)". Then the value of the guest OS
> in VMware is set to "Other (64-bit) and memory size is displayed by a grayed
> out.
> If the OS type of VM is "CentOS 6.4 (64-bit)" , "CentOS 6.3 (64-bit)"
> ,"CentOS 6.2 (64-bit)" or "CentOS 6.1 (64-bit)", the same issue happen.
> However, for "CentOS 6.0 (64-bit)", the value of the guest OS in VMware is
> set to "Linux CentOS4/5/6/7(64-bit)" and memory size is not displayed by a
> grayed out, we were able to "Dynamically Scale" the VM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9265) some java classes use commons-httpclient where httpcomponents is intended
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274189#comment-15274189 ] ASF GitHub Bot commented on CLOUDSTACK-9265: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-217471764 Can you do a force push again. Jenkins has been in this state for 3 days now. Thx... > some java classes use commons-httpclient where httpcomponents is intended > - > > Key: CLOUDSTACK-9265 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9265 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Daan Hoogland >Priority: Trivial > > in several classes imports of HttpStatus or -Exception is from the old > org.apache.commons.httpclient package while the newer org.apache.http should > be used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-6975) Service monitoring starts dnsmasq on backup router when using redundant VRs
[
https://issues.apache.org/jira/browse/CLOUDSTACK-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274186#comment-15274186
]
ASF GitHub Bot commented on CLOUDSTACK-6975:
Github user dsclose commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1514#discussion_r62344011
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -54,7 +54,8 @@ def process(self):
self.cloud.commit()
# We restart DNSMASQ every time the configure.py is called in
order to avoid lease problems.
-CsHelper.service("dnsmasq", "restart")
+if not self.cl.is_redundant() or self.cl.is_master():
--- End diff --
@jburwell Whilst that check might be convenient in some cases, I think that
convenience would be a curse. For example "bring up dnsmasq on non-redundant or
master routers" is a nice explicit declaration of behaviour. Simplifying that
to "bring up dnsmasq on master routers" might do the same thing but it
increases the learning curve for someone reading the code for the first time.
> Service monitoring starts dnsmasq on backup router when using redundant VRs
> ---
>
> Key: CLOUDSTACK-6975
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6975
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
>Affects Versions: 4.3.0
> Environment: KVM
>Reporter: Magnus Bengtsson
>
> When using a network offering with redundant routers the default setting of
> EnableServiceMonitoring enables monit on the routers.
> "network.router.EnableServiceMonitoring service monitoring in router
> enable/disable option, default truefalse"
> This causes monit to run dnsmasq on both the Master and Backup router. When
> the backup router assigns dhcp to clients, password and userdata retrieval
> from that node fails since the services are not running on the backup router.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CLOUDSTACK-9338) listAccount returns 0 for cputotal and memorytotal if VMs are using a ComputeOffering with custom=enabled
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francois Scheurer updated CLOUDSTACK-9338: -- Affects Version/s: 4.8.0 > listAccount returns 0 for cputotal and memorytotal if VMs are using a > ComputeOffering with custom=enabled > - > > Key: CLOUDSTACK-9338 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9338 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Cloudmonkey, UI >Affects Versions: 4.5.2, 4.8.0 > Environment: CloudStack 4.5.1 > MariaDB 10.0 and 10.1 >Reporter: Francois Scheurer > > listAccount on a domain returns 0 for cputotal and memorytotal if the domain > accounts own VMs using a ComputeOffering with custom=enabled. > Basically, looking into the vm_instance table you get the service_offering_id > and in the service_offering table you find normally the amount of CPU/RAM > allocated for the VM. > But if your VM's ComputeOffering has custom=enabled, then you need to get the > specific CPU/RAM values from the user_vm_details table: > mysql> select * from user_vm_details WHERE vm_id=957; > Apparently the listAccount code is not doing that and it just returns zero, > because the service_offering table has cpu=0 and ram_size=0 for > ComputeOfferings with custom=enabled. > solution: the SQL query of listAccount should also look in the > user_vm_details table for matching rows. (instead of just querying in the > service_offering table) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8973) Unusual response when creating a template from a snapshot with Swift as secondary storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274145#comment-15274145
]
ASF GitHub Bot commented on CLOUDSTACK-8973:
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-217460449
Can I get one more code review on this one? Thx...
> Unusual response when creating a template from a snapshot with Swift as
> secondary storage
> -
>
> Key: CLOUDSTACK-8973
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8973
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.4.4
>Reporter: Franz-Philippe Garcia
>Priority: Minor
>
> I am not getting this issue with NFS. When I create a template from a
> snapshot, I get the following response:
> {noformat}
> {
>"queryasyncjobresultresponse":{
> "accountid":"fd8ecd27-b6d6-4086-8644-783f769f68c1",
> "userid":"f9ce0c4a-36c6-4e7e-a49c-d77ecda227b6",
>
> "cmd":"org.apache.cloudstack.api.command.user.template.CreateTemplateCmd",
> "jobstatus":1,
> "jobprocstatus":0,
> "jobresultcode":0,
> "jobresulttype":"object",
> "jobresult":{
> "null":{
> "ispublic":false,
> "isready":false,
> "isfeatured":false,
> "crossZones":false,
> "tags":[
> ]
> }
> },
> "created":"2015-10-20T11:58:07-0400",
> "jobid":"4549d467-d0e0-4ce9-bfdd-c20c174c8ad0"
>}
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8562) User Definable Roles
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274116#comment-15274116 ] ASF GitHub Bot commented on CLOUDSTACK-8562: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-217456452 I will get this CI'ed. I have 4 new CI boxes in play now, but I am trying to figure out how to stabilize master, so I will run this as soon as I get master sorted out. Sorry for the delay... > User Definable Roles > > > Key: CLOUDSTACK-8562 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Reporter: Paul Angus >Assignee: Rohit Yadav > > Static command.properties moved to database and made user definable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9099) SecretKey is returned from the APIs
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274111#comment-15274111
]
ASF GitHub Bot commented on CLOUDSTACK-9099:
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1152#discussion_r62337172
--- Diff: server/test/com/cloud/user/MockAccountManagerImpl.java ---
@@ -401,5 +403,24 @@ public Long finalyzeAccountId(String accountName, Long
domainId, Long projectId,
return null;
}
+@Override
+public List getKeys(GetUserKeysCmd cmd) {
+return null;
+}
+
+@Override
+public void checkAccess(User user, ControlledEntity entity)
+throws PermissionDeniedException {
+
+}
+@Override
+public String getConfigComponentName() {
+return null;
+}
+
+@Override
+public ConfigKey[] getConfigKeys() {
+return null;
--- End diff --
Please return an empty array to avoid NPEs.
> SecretKey is returned from the APIs
> ---
>
> Key: CLOUDSTACK-9099
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9099
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Kshitij Kansal
>Assignee: Kshitij Kansal
>
> The sercreKey parameter is returned from the following APIs:
> createAccount
> createUser
> disableAccount
> disableUser
> enableAccount
> enableUser
> listAccounts
> listUsers
> lockAccount
> lockUser
> registerUserKeys
> updateAccount
> updateUser
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9099) SecretKey is returned from the APIs
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274108#comment-15274108
]
ASF GitHub Bot commented on CLOUDSTACK-9099:
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1152#discussion_r62337077
--- Diff: server/test/com/cloud/user/MockAccountManagerImpl.java ---
@@ -401,5 +403,24 @@ public Long finalyzeAccountId(String accountName, Long
domainId, Long projectId,
return null;
}
+@Override
+public List getKeys(GetUserKeysCmd cmd) {
+return null;
--- End diff --
Please return a ``Collections.emptyList()`` to avoid NPEs.
> SecretKey is returned from the APIs
> ---
>
> Key: CLOUDSTACK-9099
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9099
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Kshitij Kansal
>Assignee: Kshitij Kansal
>
> The sercreKey parameter is returned from the following APIs:
> createAccount
> createUser
> disableAccount
> disableUser
> enableAccount
> enableUser
> listAccounts
> listUsers
> lockAccount
> lockUser
> registerUserKeys
> updateAccount
> updateUser
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9099) SecretKey is returned from the APIs
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274109#comment-15274109
]
ASF GitHub Bot commented on CLOUDSTACK-9099:
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1152#discussion_r62337130
--- Diff: server/test/com/cloud/user/MockAccountManagerImpl.java ---
@@ -401,5 +403,24 @@ public Long finalyzeAccountId(String accountName, Long
domainId, Long projectId,
return null;
}
+@Override
+public List getKeys(GetUserKeysCmd cmd) {
+return null;
+}
+
+@Override
+public void checkAccess(User user, ControlledEntity entity)
+throws PermissionDeniedException {
+
+}
+@Override
+public String getConfigComponentName() {
+return null;
--- End diff --
Please return a blank string to avoid NPEs.
> SecretKey is returned from the APIs
> ---
>
> Key: CLOUDSTACK-9099
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9099
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Kshitij Kansal
>Assignee: Kshitij Kansal
>
> The sercreKey parameter is returned from the following APIs:
> createAccount
> createUser
> disableAccount
> disableUser
> enableAccount
> enableUser
> listAccounts
> listUsers
> lockAccount
> lockUser
> registerUserKeys
> updateAccount
> updateUser
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9099) SecretKey is returned from the APIs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274102#comment-15274102 ] ASF GitHub Bot commented on CLOUDSTACK-9099: Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1152#discussion_r62336941 --- Diff: server/src/com/cloud/user/AccountManager.java --- @@ -198,4 +200,11 @@ void buildACLViewSearchCriteria(SearchCriteria s public static final String MESSAGE_ADD_ACCOUNT_EVENT = "Message.AddAccount.Event"; public static final String MESSAGE_REMOVE_ACCOUNT_EVENT = "Message.RemoveAccount.Event"; +public static final ConfigKey UseSecretKeyInResponse = new ConfigKey( +"Advanced", +Boolean.class, +"use.secret.key.in.response", +"true", --- End diff -- @kansal I agree with @DaanHoogland and @remibergsma -- it's about reasonable and secure defaults. We should not configure a management server insecurely by default. > SecretKey is returned from the APIs > --- > > Key: CLOUDSTACK-9099 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9099 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Kshitij Kansal >Assignee: Kshitij Kansal > > The sercreKey parameter is returned from the following APIs: > createAccount > createUser > disableAccount > disableUser > enableAccount > enableUser > listAccounts > listUsers > lockAccount > lockUser > registerUserKeys > updateAccount > updateUser -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9099) SecretKey is returned from the APIs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274101#comment-15274101 ] ASF GitHub Bot commented on CLOUDSTACK-9099: Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1152#discussion_r62336714 --- Diff: api/src/org/apache/cloudstack/api/command/admin/user/GetUserKeysCmd.java --- @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.cloudstack.api.command.admin.user; + + +import com.cloud.user.Account; +import com.cloud.user.User; +import org.apache.cloudstack.api.APICommand; +import org.apache.cloudstack.api.ApiConstants; +import org.apache.cloudstack.api.BaseCmd; +import org.apache.cloudstack.api.Parameter; +import org.apache.cloudstack.api.response.RegisterResponse; +import org.apache.cloudstack.api.response.UserResponse; + +import java.util.List; +import java.util.logging.Logger; + +@APICommand(name = "getUserKeys", +description = "This command allows the user to query the seceret and API keys for the account", +responseObject = RegisterResponse.class, +requestHasSensitiveInfo = false, +responseHasSensitiveInfo = true) --- End diff -- Please add the version annotation to indicate that this command was added for 4.9. > SecretKey is returned from the APIs > --- > > Key: CLOUDSTACK-9099 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9099 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Kshitij Kansal >Assignee: Kshitij Kansal > > The sercreKey parameter is returned from the following APIs: > createAccount > createUser > disableAccount > disableUser > enableAccount > enableUser > listAccounts > listUsers > lockAccount > lockUser > registerUserKeys > updateAccount > updateUser -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8973) Unusual response when creating a template from a snapshot with Swift as secondary storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274082#comment-15274082
]
ASF GitHub Bot commented on CLOUDSTACK-8973:
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-217451440
LGTM based on code review
> Unusual response when creating a template from a snapshot with Swift as
> secondary storage
> -
>
> Key: CLOUDSTACK-8973
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8973
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.4.4
>Reporter: Franz-Philippe Garcia
>Priority: Minor
>
> I am not getting this issue with NFS. When I create a template from a
> snapshot, I get the following response:
> {noformat}
> {
>"queryasyncjobresultresponse":{
> "accountid":"fd8ecd27-b6d6-4086-8644-783f769f68c1",
> "userid":"f9ce0c4a-36c6-4e7e-a49c-d77ecda227b6",
>
> "cmd":"org.apache.cloudstack.api.command.user.template.CreateTemplateCmd",
> "jobstatus":1,
> "jobprocstatus":0,
> "jobresultcode":0,
> "jobresulttype":"object",
> "jobresult":{
> "null":{
> "ispublic":false,
> "isready":false,
> "isfeatured":false,
> "crossZones":false,
> "tags":[
> ]
> }
> },
> "created":"2015-10-20T11:58:07-0400",
> "jobid":"4549d467-d0e0-4ce9-bfdd-c20c174c8ad0"
>}
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8562) User Definable Roles
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274078#comment-15274078 ] ASF GitHub Bot commented on CLOUDSTACK-8562: Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-217450750 @rhtyd @swill LGTM based on code review > User Definable Roles > > > Key: CLOUDSTACK-8562 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Reporter: Paul Angus >Assignee: Rohit Yadav > > Static command.properties moved to database and made user definable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9348) CloudStack Server degrades when a lot of connections on port 8250
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274027#comment-15274027 ] ASF GitHub Bot commented on CLOUDSTACK-9348: Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1534#issuecomment-217442413 LGTM based on code review > CloudStack Server degrades when a lot of connections on port 8250 > - > > Key: CLOUDSTACK-9348 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9348 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.9.0 > > > An intermittent issue was found with a large CloudStack deployment, where > servers could not keep agents connected on port 8250. > All connections are handled by accept() in NioConnection: > https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L125 > A new connection is handled by accept() which does blocking SSL handshake. A > good fix would be to make this non-blocking and handle expensive tasks in > separate threads/pool. This way the main IO loop won't be blocked and can > continue to serve other agents/clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-6975) Service monitoring starts dnsmasq on backup router when using redundant VRs
[
https://issues.apache.org/jira/browse/CLOUDSTACK-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274026#comment-15274026
]
ASF GitHub Bot commented on CLOUDSTACK-6975:
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1514#discussion_r62329838
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -54,7 +54,8 @@ def process(self):
self.cloud.commit()
# We restart DNSMASQ every time the configure.py is called in
order to avoid lease problems.
-CsHelper.service("dnsmasq", "restart")
+if not self.cl.is_redundant() or self.cl.is_master():
--- End diff --
Would is make sense for the ``is_redundant()`` check to be in the
``is_master()`` method? To my way of thinking, any non-redundant router is a
de facto master.
I understand such a change may be too far to be practical at this time, so
we may want to table it.
> Service monitoring starts dnsmasq on backup router when using redundant VRs
> ---
>
> Key: CLOUDSTACK-6975
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6975
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
>Affects Versions: 4.3.0
> Environment: KVM
>Reporter: Magnus Bengtsson
>
> When using a network offering with redundant routers the default setting of
> EnableServiceMonitoring enables monit on the routers.
> "network.router.EnableServiceMonitoring service monitoring in router
> enable/disable option, default truefalse"
> This causes monit to run dnsmasq on both the Master and Backup router. When
> the backup router assigns dhcp to clients, password and userdata retrieval
> from that node fails since the services are not running on the backup router.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274005#comment-15274005 ] ASF GitHub Bot commented on CLOUDSTACK-9299: Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-217434570 @rhtyd @swill we are very close. I have a couple of outstanding comments -- particularly around potential thread explosion in ``ProcessRunner``. Ultimately, I think the issues are straightforward to address. /cc @borisstoyanov > Out-of-band Management for CloudStack > - > > Key: CLOUDSTACK-9299 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.9.0, Future > > > Support access to a host’s out-of-band management interface (e.g. IPMI, iLO, > DRAC, etc.) to manage host power operations (on/off etc.) and querying > current power state. > FS: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273997#comment-15273997
]
ASF GitHub Bot commented on CLOUDSTACK-9299:
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62325927
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,111 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import org.apache.log4j.Logger;
+
+import java.io.IOException;
+import java.util.List;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private String stdOutput;
+private String stdError;
+private int returnCode = -1;
+
+public String getStdOutput() {
+return stdOutput;
+}
+
+public void setStdOutput(String stdOutput) {
+this.stdOutput = stdOutput;
+}
+
+public String getStdError() {
+return stdError;
+}
+
+public void setStdError(String stdError) {
+this.stdError = stdError;
+}
+
+public int getReturnCode() {
+return returnCode;
+}
+
+public void setReturnCode(int returnCode) {
+this.returnCode = returnCode;
+}
+
+public static ProcessRunner executeCommands(List commands,
long timeOutSeconds) {
+ProcessRunner result = new ProcessRunner();
+try {
+Process process = new
ProcessBuilder().command(commands).start();
+StreamGobbler stdInputGobbler = new
StreamGobbler(process.getInputStream());
+StreamGobbler stdErrorGobbler = new
StreamGobbler(process.getErrorStream());
--- End diff --
The ``StreamGobbler`` idiom was replaced with ``ProcessBuilder.inheritIO``
in Java 1.7+. Using it would simplify this code and allow the removal of the
``StreamGobbler`` class.
> Out-of-band Management for CloudStack
> -
>
> Key: CLOUDSTACK-9299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.9.0, Future
>
>
> Support access to a host’s out-of-band management interface (e.g. IPMI, iLO,
> DRAC, etc.) to manage host power operations (on/off etc.) and querying
> current power state.
> FS:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273991#comment-15273991
]
ASF GitHub Bot commented on CLOUDSTACK-9299:
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62325553
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,111 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import org.apache.log4j.Logger;
+
+import java.io.IOException;
+import java.util.List;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private String stdOutput;
+private String stdError;
+private int returnCode = -1;
+
+public String getStdOutput() {
+return stdOutput;
+}
+
+public void setStdOutput(String stdOutput) {
+this.stdOutput = stdOutput;
+}
+
+public String getStdError() {
+return stdError;
+}
+
+public void setStdError(String stdError) {
+this.stdError = stdError;
+}
+
+public int getReturnCode() {
+return returnCode;
+}
+
+public void setReturnCode(int returnCode) {
+this.returnCode = returnCode;
+}
+
+public static ProcessRunner executeCommands(List commands,
long timeOutSeconds) {
+ProcessRunner result = new ProcessRunner();
+try {
+Process process = new
ProcessBuilder().command(commands).start();
+StreamGobbler stdInputGobbler = new
StreamGobbler(process.getInputStream());
+StreamGobbler stdErrorGobbler = new
StreamGobbler(process.getErrorStream());
+stdInputGobbler.start();
+stdErrorGobbler.start();
+
+if (timeOutSeconds > 0) {
+ProcessWaitForThread worker = new
ProcessWaitForThread(process);
--- End diff --
I am concerned about unbounded thread growth here. Please consider using a
bounded ``Executor`` and a
[``ListenableFuture``](https://github.com/google/guava/wiki/ListenableFutureExplained)
here. It would also remove the need for the ``ProcessWaitForThread`` class.
> Out-of-band Management for CloudStack
> -
>
> Key: CLOUDSTACK-9299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.9.0, Future
>
>
> Support access to a host’s out-of-band management interface (e.g. IPMI, iLO,
> DRAC, etc.) to manage host power operations (on/off etc.) and querying
> current power state.
> FS:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273971#comment-15273971
]
ASF GitHub Bot commented on CLOUDSTACK-9299:
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62322683
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,111 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import org.apache.log4j.Logger;
+
+import java.io.IOException;
+import java.util.List;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private String stdOutput;
+private String stdError;
+private int returnCode = -1;
+
+public String getStdOutput() {
+return stdOutput;
+}
+
+public void setStdOutput(String stdOutput) {
+this.stdOutput = stdOutput;
+}
+
+public String getStdError() {
+return stdError;
+}
+
+public void setStdError(String stdError) {
+this.stdError = stdError;
+}
+
+public int getReturnCode() {
+return returnCode;
+}
+
+public void setReturnCode(int returnCode) {
+this.returnCode = returnCode;
+}
+
+public static ProcessRunner executeCommands(List commands,
long timeOutSeconds) {
--- End diff --
Consider adding ``Preconditions.checkArguments`` to verify that
``commands`` is not ``null``.
Also, consider using JodaTime's ``Duration`` to represent the timeout as
number with a unit of measure. This step is not required for LGTM, but would
be a good refactoring if we fit it in.
> Out-of-band Management for CloudStack
> -
>
> Key: CLOUDSTACK-9299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.9.0, Future
>
>
> Support access to a host’s out-of-band management interface (e.g. IPMI, iLO,
> DRAC, etc.) to manage host power operations (on/off etc.) and querying
> current power state.
> FS:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273970#comment-15273970
]
ASF GitHub Bot commented on CLOUDSTACK-9299:
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62322543
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,111 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import org.apache.log4j.Logger;
+
+import java.io.IOException;
+import java.util.List;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private String stdOutput;
+private String stdError;
+private int returnCode = -1;
--- End diff --
Consider making this class immutable and/or creating a static, immutable
inner class (e.g. ``ProcessResult``).
> Out-of-band Management for CloudStack
> -
>
> Key: CLOUDSTACK-9299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.9.0, Future
>
>
> Support access to a host’s out-of-band management interface (e.g. IPMI, iLO,
> DRAC, etc.) to manage host power operations (on/off etc.) and querying
> current power state.
> FS:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273965#comment-15273965
]
ASF GitHub Bot commented on CLOUDSTACK-9299:
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62322259
--- Diff: server/test/com/cloud/resource/MockResourceManagerImpl.java ---
@@ -172,6 +173,12 @@ public Cluster getCluster(final Long clusterId) {
return null;
}
+@Override
+public DataCenter getZone(Long zoneId) {
+// TODO Auto-generated method stub
--- End diff --
Because we have tools to search for TODOs, please remove the comment if
there is nothing outstanding to be done.
> Out-of-band Management for CloudStack
> -
>
> Key: CLOUDSTACK-9299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.9.0, Future
>
>
> Support access to a host’s out-of-band management interface (e.g. IPMI, iLO,
> DRAC, etc.) to manage host power operations (on/off etc.) and querying
> current power state.
> FS:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273961#comment-15273961
]
ASF GitHub Bot commented on CLOUDSTACK-9299:
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62321963
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -412,6 +428,36 @@ protected void runInContext() {
}
}
+class HostOutOfBandManagementStatsCollector extends
ManagedContextRunnable {
+@Override
+protected void runInContext() {
+try {
+s_logger.debug("HostOutOfBandManagementStatsCollector is
running...");
+List outOfBandManagementHosts =
outOfBandManagementDao.findAllByManagementServer(ManagementServerNode.getManagementServerId());
+if (outOfBandManagementHosts == null) {
+return;
+}
+for (OutOfBandManagement outOfBandManagementHost :
outOfBandManagementHosts) {
+Host host =
_hostDao.findById(outOfBandManagementHost.getHostId());
+if (host == null) {
+continue;
+}
+if
(outOfBandManagementService.isOutOfBandManagementEnabled(host)) {
+
outOfBandManagementService.submitBackgroundPowerSyncTask(host);
+} else {
+if (outOfBandManagementHost.getPowerState() !=
OutOfBandManagement.PowerState.Disabled) {
+if
(outOfBandManagementService.transitionPowerStateToDisabled(Collections.singletonList(host)))
{
--- End diff --
Collapse these two ``if`` blocks into a single ``else if`` on line 447 to
improve readability.
> Out-of-band Management for CloudStack
> -
>
> Key: CLOUDSTACK-9299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.9.0, Future
>
>
> Support access to a host’s out-of-band management interface (e.g. IPMI, iLO,
> DRAC, etc.) to manage host power operations (on/off etc.) and querying
> current power state.
> FS:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273963#comment-15273963
]
ASF GitHub Bot commented on CLOUDSTACK-9299:
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62321985
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -412,6 +428,36 @@ protected void runInContext() {
}
}
+class HostOutOfBandManagementStatsCollector extends
ManagedContextRunnable {
+@Override
+protected void runInContext() {
+try {
+s_logger.debug("HostOutOfBandManagementStatsCollector is
running...");
+List outOfBandManagementHosts =
outOfBandManagementDao.findAllByManagementServer(ManagementServerNode.getManagementServerId());
+if (outOfBandManagementHosts == null) {
+return;
+}
+for (OutOfBandManagement outOfBandManagementHost :
outOfBandManagementHosts) {
+Host host =
_hostDao.findById(outOfBandManagementHost.getHostId());
+if (host == null) {
+continue;
+}
+if
(outOfBandManagementService.isOutOfBandManagementEnabled(host)) {
+
outOfBandManagementService.submitBackgroundPowerSyncTask(host);
+} else {
+if (outOfBandManagementHost.getPowerState() !=
OutOfBandManagement.PowerState.Disabled) {
+if
(outOfBandManagementService.transitionPowerStateToDisabled(Collections.singletonList(host)))
{
+s_logger.debug("Out-of-band management was
disabled in zone/cluster/host, disabled power state for host id:" +
host.getId());
--- End diff --
Please wrap in a ``if (LOGGER.isDebugEnabled)`` check.
> Out-of-band Management for CloudStack
> -
>
> Key: CLOUDSTACK-9299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.9.0, Future
>
>
> Support access to a host’s out-of-band management interface (e.g. IPMI, iLO,
> DRAC, etc.) to manage host power operations (on/off etc.) and querying
> current power state.
> FS:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273959#comment-15273959
]
ASF GitHub Bot commented on CLOUDSTACK-9299:
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62321858
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -251,8 +262,9 @@ public boolean start() {
}
private void init(Map configs) {
-_executor = Executors.newScheduledThreadPool(4, new
NamedThreadFactory("StatsCollector"));
+_executor = Executors.newScheduledThreadPool(6, new
NamedThreadFactory("StatsCollector"));
--- End diff --
I understand that ``6`` is in the ``init`` method. My question is how did
we arrive at that number? Why is 6 instead of 2 or 10?
> Out-of-band Management for CloudStack
> -
>
> Key: CLOUDSTACK-9299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.9.0, Future
>
>
> Support access to a host’s out-of-band management interface (e.g. IPMI, iLO,
> DRAC, etc.) to manage host power operations (on/off etc.) and querying
> current power state.
> FS:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273955#comment-15273955
]
ASF GitHub Bot commented on CLOUDSTACK-9299:
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62321576
--- Diff:
api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java
---
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.outofbandmanagement;
+
+import com.cloud.dc.DataCenter;
+import com.cloud.host.Host;
+import com.cloud.org.Cluster;
+import com.google.common.collect.ImmutableMap;
+import org.apache.cloudstack.api.response.OutOfBandManagementResponse;
+import org.apache.cloudstack.framework.config.ConfigKey;
+
+import java.util.List;
+
+public interface OutOfBandManagementService {
+
+ConfigKey OutOfBandManagementActionTimeout = new
ConfigKey("Advanced", Long.class, "outofbandmanagement.action.timeout",
"60",
+"The out of band management action timeout in seconds,
configurable by cluster", true, ConfigKey.Scope.Cluster);
+
+ConfigKey OutOfBandManagementSyncThreadInterval = new
ConfigKey("Advanced", Long.class, "outofbandmanagement.sync.interval",
"30",
+"The interval (in milliseconds) when the out-of-band
management background sync are retrieved", true, ConfigKey.Scope.Global);
+
+ConfigKey OutOfBandManagementSyncThreadPoolSize = new
ConfigKey("Advanced", Integer.class,
"outofbandmanagement.sync.poolsize", "50",
+"The out of band management background sync thread pool size",
true, ConfigKey.Scope.Global);
+
+long getId();
+boolean isOutOfBandManagementEnabled(Host host);
+void submitBackgroundPowerSyncTask(Host host);
+boolean transitionPowerStateToDisabled(List hosts);
--- End diff --
@rhtyd the issue is that it is a wider type specification that is
necessary. It can also cause erasure compiler errors. Therefore, we should
only be using when it is truly necessary. In this case, the
``OutOfBandManagementService`` only operates on instances of ``Host``.
> Out-of-band Management for CloudStack
> -
>
> Key: CLOUDSTACK-9299
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.9.0, Future
>
>
> Support access to a host’s out-of-band management interface (e.g. IPMI, iLO,
> DRAC, etc.) to manage host power operations (on/off etc.) and querying
> current power state.
> FS:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273947#comment-15273947
]
ASF GitHub Bot commented on CLOUDSTACK-9299:
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62321148
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java
---
@@ -0,0 +1,128 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.outofbandmanagement;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.host.Host;
+import com.google.common.base.Strings;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandJobType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.HostResponse;
+import org.apache.cloudstack.api.response.OutOfBandManagementResponse;
+import org.apache.cloudstack.context.CallContext;
+import
org.apache.cloudstack.outofbandmanagement.OutOfBandManagement.PowerOperation;
+import
org.apache.cloudstack.outofbandmanagement.OutOfBandManagementService;
+
+import javax.inject.Inject;
+
+@APICommand(name = "issueOutOfBandManagementPowerAction", description =
"Initiates the specified power action to the host's out-of-band management
interface",
+responseObject = OutOfBandManagementResponse.class,
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false, authorized =
{RoleType.Admin})
+public class IssueOutOfBandManagementPowerActionCmd extends BaseAsyncCmd {
+@Inject
+private OutOfBandManagementService outOfBandManagementService;
+
+/
+ API parameters /
+/
+
+@Parameter(name = ApiConstants.HOST_ID, type = CommandType.UUID,
entityType = HostResponse.class, required = true, description = "the ID of the
host")
+private Long hostId;
+
+@Parameter(name = ApiConstants.TIMEOUT, type = CommandType.LONG,
description = "optional operation timeout in seconds that overrides the global
or cluster-level out-of-band management timeout setting")
+private Long actionTimeout;
+
+@Parameter(name = ApiConstants.ACTION, type = CommandType.STRING,
required = true, description = "out-of-band management power actions, valid
actions are: ON, OFF, CYCLE, RESET, SOFT, STATUS")
+private String outOfBandManagementPowerOperation;
+
+/
+/// API Implementation///
+/
+
+@Override
+public String getCommandName() {
+return "issueoutofbandmanagementpoweractionresponse";
+}
+
+private void validateParams() {
+if (getHostId() == null || getHostId() < 1L) {
+throw new ServerApiException(ApiErrorCode.PARAM_ERROR,
"Invalid host ID: " + getHostId());
+}
+if (Strings.isNullOrEmpty(getOutOfBandManagementPowerOperation()))
{
+throw new ServerApiException(ApiErrorCode.PARAM_ERROR,
"Invalid out-of-band management power action: " +
getOutOfBandManagementP
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273926#comment-15273926 ] ASF GitHub Bot commented on CLOUDSTACK-9299: Github user borisstoyanov commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-217414515 I've just run final sanity tests on this PR, all the OOBM features are working and did not observed any side effects, so I'm happy with the latest changes getting merged. LGTM! > Out-of-band Management for CloudStack > - > > Key: CLOUDSTACK-9299 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.9.0, Future > > > Support access to a host’s out-of-band management interface (e.g. IPMI, iLO, > DRAC, etc.) to manage host power operations (on/off etc.) and querying > current power state. > FS: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8562) User Definable Roles
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273921#comment-15273921 ] ASF GitHub Bot commented on CLOUDSTACK-8562: Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-217413190 @swill this PR is ready for CI test run and merge, thanks > User Definable Roles > > > Key: CLOUDSTACK-8562 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Reporter: Paul Angus >Assignee: Rohit Yadav > > Static command.properties moved to database and made user definable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9348) CloudStack Server degrades when a lot of connections on port 8250
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273922#comment-15273922 ] ASF GitHub Bot commented on CLOUDSTACK-9348: Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1534#issuecomment-217413262 @swill this PR is ready for CI test run and merge, thanks > CloudStack Server degrades when a lot of connections on port 8250 > - > > Key: CLOUDSTACK-9348 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9348 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.9.0 > > > An intermittent issue was found with a large CloudStack deployment, where > servers could not keep agents connected on port 8250. > All connections are handled by accept() in NioConnection: > https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L125 > A new connection is handled by accept() which does blocking SSL handshake. A > good fix would be to make this non-blocking and handle expensive tasks in > separate threads/pool. This way the main IO loop won't be blocked and can > continue to serve other agents/clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9299) Out-of-band Management for CloudStack
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273920#comment-15273920 ] ASF GitHub Bot commented on CLOUDSTACK-9299: Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-217413162 @swill this PR is ready for CI test run and merge, thanks > Out-of-band Management for CloudStack > - > > Key: CLOUDSTACK-9299 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9299 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.9.0, Future > > > Support access to a host’s out-of-band management interface (e.g. IPMI, iLO, > DRAC, etc.) to manage host power operations (on/off etc.) and querying > current power state. > FS: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Out-of-band+Management+for+CloudStack -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-6975) Service monitoring starts dnsmasq on backup router when using redundant VRs
[
https://issues.apache.org/jira/browse/CLOUDSTACK-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273824#comment-15273824
]
ASF GitHub Bot commented on CLOUDSTACK-6975:
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-217392996
@DaanHoogland yes, the line `CsHelper.service("dnsmasq", "restart")` in
`set_master` is in
systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py. When a backup
router transitions to master, it successfully launches the dnsmasq service.
I should point out that I have only verified that the service is running. I
have not confirmed that it is successfully configured.
> Service monitoring starts dnsmasq on backup router when using redundant VRs
> ---
>
> Key: CLOUDSTACK-6975
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6975
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
>Affects Versions: 4.3.0
> Environment: KVM
>Reporter: Magnus Bengtsson
>
> When using a network offering with redundant routers the default setting of
> EnableServiceMonitoring enables monit on the routers.
> "network.router.EnableServiceMonitoring service monitoring in router
> enable/disable option, default truefalse"
> This causes monit to run dnsmasq on both the Master and Backup router. When
> the backup router assigns dhcp to clients, password and userdata retrieval
> from that node fails since the services are not running on the backup router.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
