[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-22 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483810#comment-16483810
 ] 

ASF subversion and git services commented on CLOUDSTACK-10276:
--

Commit 8b09620d777805bdbb59255ef722e0a6ddbb85b8 in cloudstack's branch 
refs/heads/4.11 from [~rafaelweingartner]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=8b09620 ]

CLOUDSTACK-10276: listVolumes not working when storage UUID is not a UUID 
(#2639)

When configuring a pre-setup primary storage we can enter the name-label of the 
storage that is going to be used by ACS and is already set up in the host. The 
problem is that we can use any String of characters there, and this String does 
not need to be a UUID. When listing volumes from a primary storage that has 
such conditions, the list will return all of the volumes in the cloud because 
the “API framework” will ignore that value as it is not a UUID type.

> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-22 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483812#comment-16483812
 ] 

ASF subversion and git services commented on CLOUDSTACK-10276:
--

Commit 8b09620d777805bdbb59255ef722e0a6ddbb85b8 in cloudstack's branch 
refs/heads/master from [~rafaelweingartner]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=8b09620 ]

CLOUDSTACK-10276: listVolumes not working when storage UUID is not a UUID 
(#2639)

When configuring a pre-setup primary storage we can enter the name-label of the 
storage that is going to be used by ACS and is already set up in the host. The 
problem is that we can use any String of characters there, and this String does 
not need to be a UUID. When listing volumes from a primary storage that has 
such conditions, the list will return all of the volumes in the cloud because 
the “API framework” will ignore that value as it is not a UUID type.

> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-22 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483803#comment-16483803
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

DaanHoogland commented on issue #2639: [CLOUDSTACK-10276] listVolumes not 
working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-390955253
 
 
   @rafaelweingartner I am fine with merging this so far as we don't allow for 
manually entering a non-uuid storage id. In my understanding it doesn't. Is 
that correct?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-22 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483722#comment-16483722
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

rafaelweingartner commented on issue #2639: [CLOUDSTACK-10276] listVolumes not 
working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-390929227
 
 
   I really do not see any other smaller/simpler solution for this issue. 
Moreover, it does not affect/break anything in the client side. The client is 
already seeing an ID, which is a UUID.
   
   The changes are only internal to ACS. I changed the type of `storageId` from 
`long` to `String` to avoid using that method that converts the given UUID to 
an internal database ID. That method is validating the input, and ignoring 
anything that is not an UUID. Then, I am using the UUID as the filter at 
`QueryManagerImpl.java`.
   
   The changed lines are only 2. The other lines are a result of a code cleanup 
that I did, and the code formatting I applied.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-22 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483562#comment-16483562
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

rhtyd commented on issue #2639: [CLOUDSTACK-10276] listVolumes not working when 
storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-390881251
 
 
   I'm unable to find time to do the investigation on this. @DaanHoogland can 
you advise, and if it's all okay please go ahead with merging this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482630#comment-16482630
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

rhtyd commented on issue #2639: [CLOUDSTACK-10276] listVolumes not working when 
storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-390691842
 
 
   @rafaelweingartner yes you're right, I tested it and it works due to a 
heuristic I had implemented (and forgotten about it, which uses the api arg 
removing id/ids and tries to find a list API). It's eod for me here, let me get 
back to you tomorrow if there can be any simpler fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482407#comment-16482407
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

rafaelweingartner commented on issue #2639: [CLOUDSTACK-10276] listVolumes not 
working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-390626277
 
 
   @rhtyd how does it break cloudmonkey? 
   Cloudmonkey continues to see the same thing. There is not change in the API, 
nothing will change for clients. I just stopped using the automagic conversion 
system via reflection that takes the UUID entered as ID (a UUID) and then 
converts to a database long ID. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482258#comment-16482258
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

rhtyd commented on issue #2639: [CLOUDSTACK-10276] listVolumes not working when 
storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-390575404
 
 
   I've my reservations on the fix, instead perhaps it may be better and could 
be simpler to handle use of external id as uuid when adding a pre-setup storage 
pool. This may not require us to remove the uuid-id conversations/annotations 
in the list API, also this will break auto-completion of storage ids in various 
APIs for CLIs such as cloudmonkey.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480411#comment-16480411
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

DaanHoogland closed pull request #2639: [CLOUDSTACK-10276] listVolumes not 
working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/api/src/org/apache/cloudstack/api/command/admin/volume/ListVolumesCmdByAdmin.java
 
b/api/src/org/apache/cloudstack/api/command/admin/volume/ListVolumesCmdByAdmin.java
index 5fe5bfea485..add22713931 100644
--- 
a/api/src/org/apache/cloudstack/api/command/admin/volume/ListVolumesCmdByAdmin.java
+++ 
b/api/src/org/apache/cloudstack/api/command/admin/volume/ListVolumesCmdByAdmin.java
@@ -16,50 +16,15 @@
 // under the License.
 package org.apache.cloudstack.api.command.admin.volume;
 
-import org.apache.log4j.Logger;
-
-import org.apache.cloudstack.acl.RoleType;
 import org.apache.cloudstack.api.APICommand;
-import org.apache.cloudstack.api.ApiConstants;
-import org.apache.cloudstack.api.Parameter;
 import org.apache.cloudstack.api.ResponseObject.ResponseView;
 import org.apache.cloudstack.api.command.user.volume.ListVolumesCmd;
-import org.apache.cloudstack.api.response.PodResponse;
-import org.apache.cloudstack.api.response.StoragePoolResponse;
 import org.apache.cloudstack.api.response.VolumeResponse;
 
 import com.cloud.storage.Volume;
 
-
-@APICommand(name = "listVolumes", description = "Lists all volumes.", 
responseObject = VolumeResponse.class, responseView = ResponseView.Full, 
entityType = {Volume.class},
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+@APICommand(name = "listVolumes", description = "Lists all volumes.", 
responseObject = VolumeResponse.class, responseView = ResponseView.Full, 
entityType = {
+Volume.class}, requestHasSensitiveInfo = false, 
responseHasSensitiveInfo = false)
 public class ListVolumesCmdByAdmin extends ListVolumesCmd {
-public static final Logger s_logger = 
Logger.getLogger(ListVolumesCmdByAdmin.class.getName());
-
-@Parameter(name=ApiConstants.POD_ID, type=CommandType.UUID, 
entityType=PodResponse.class,
-description="the pod id the disk volume belongs to")
-private Long podId;
-
-
-@Parameter(name=ApiConstants.STORAGE_ID, type=CommandType.UUID, 
entityType=StoragePoolResponse.class,
-description="the ID of the storage pool, available to ROOT admin 
only", since="4.3", authorized = { RoleType.Admin })
-private Long storageId;
-
-
-/
-/// Accessors ///
-/
-
-
-@Override
-public Long getPodId() {
-return podId;
-}
-
-
-@Override
-public Long getStorageId() {
-return storageId;
-}
 
 }
diff --git 
a/api/src/org/apache/cloudstack/api/command/user/volume/ListVolumesCmd.java 
b/api/src/org/apache/cloudstack/api/command/user/volume/ListVolumesCmd.java
index 554e029fc48..c858f494fef 100644
--- a/api/src/org/apache/cloudstack/api/command/user/volume/ListVolumesCmd.java
+++ b/api/src/org/apache/cloudstack/api/command/user/volume/ListVolumesCmd.java
@@ -16,9 +16,8 @@
 // under the License.
 package org.apache.cloudstack.api.command.user.volume;
 
-import org.apache.log4j.Logger;
-
 import java.util.List;
+
 import org.apache.cloudstack.acl.RoleType;
 import org.apache.cloudstack.api.APICommand;
 import org.apache.cloudstack.api.ApiCommandJobType;
@@ -35,11 +34,12 @@
 import org.apache.cloudstack.api.response.UserVmResponse;
 import org.apache.cloudstack.api.response.VolumeResponse;
 import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.log4j.Logger;
 
 import com.cloud.storage.Volume;
 
-@APICommand(name = "listVolumes", description = "Lists all volumes.", 
responseObject = VolumeResponse.class, responseView = ResponseView.Restricted, 
entityType = {Volume.class},
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+@APICommand(name = "listVolumes", description = "Lists all volumes.", 
responseObject = VolumeResponse.class, responseView = ResponseView.Restricted, 
entityType = {
+Volume.class}, requestHasSensitiveInfo = false, 
responseHasSensitiveInfo = false)
 public class ListVolumesCmd extends BaseListTaggedResourcesCmd {
 public static final Logger s_logger = 
Logger.getLogger(ListVolumesCmd.class.getName());
 
@@ -55,7 +55,7 @@
 @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType = 
VolumeResponse.class, description = 

[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480410#comment-16480410
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

DaanHoogland commented on issue #2639: [CLOUDSTACK-10276] listVolumes not 
working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-390152847
 
 
   arguing with jenkins


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480413#comment-16480413
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

rafaelweingartner opened a new pull request #2639: [CLOUDSTACK-10276] 
listVolumes not working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639
 
 
   ## Description
   
   When configuring a pre-setup primary storage we can enter the name-label of 
the storage that is going to be used by ACS and is already set up in the host. 
The problem is that we can use any String of characters there, and this String 
does not need to be a UUID. When listing volumes from a primary storage that 
has such conditions, the list will return all of the volumes in the cloud 
because the “API framework” will ignore that value as it is not a UUID type.
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   
   
   
   
   
   
   ## How Has This Been Tested?
   Locally
   
   
   
   
   
   ## Checklist:
   
   
   - [X] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [X] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [X] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480412#comment-16480412
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

DaanHoogland commented on issue #2639: [CLOUDSTACK-10276] listVolumes not 
working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-390152934
 
 
   see if jenkins is convinced


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478176#comment-16478176
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

blueorangutan commented on issue #2639: [CLOUDSTACK-10276] listVolumes not 
working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-389678864
 
 
   Trillian test result (tid-2680)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41932 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2639-t2680-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 63 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 296.09 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 454.61 | 
test_privategw_acl.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 7.21 | 
test_vm_life_cycle.py
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 5.23 | 
test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1.20 | 
test_host_maintenance.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 4.44 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477181#comment-16477181
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

borisstoyanov commented on issue #2639: [CLOUDSTACK-10276] listVolumes not 
working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-389461115
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477182#comment-16477182
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

blueorangutan commented on issue #2639: [CLOUDSTACK-10276] listVolumes not 
working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-389461294
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477168#comment-16477168
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

blueorangutan commented on issue #2639: [CLOUDSTACK-10276] listVolumes not 
working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-389458208
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2058


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477129#comment-16477129
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

borisstoyanov commented on issue #2639: [CLOUDSTACK-10276] listVolumes not 
working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-389450556
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477131#comment-16477131
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

blueorangutan commented on issue #2639: [CLOUDSTACK-10276] listVolumes not 
working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-389450701
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473083#comment-16473083
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

rafaelweingartner commented on issue #2639: [CLOUDSTACK-10276] listVolumes not 
working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-388553399
 
 
   @rhtyd I thought about that. However, after evaluating the volume of 
changes, I decided to do a simple fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472240#comment-16472240
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

rhtyd commented on a change in pull request #2639: [CLOUDSTACK-10276] 
listVolumes not working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#discussion_r187669301
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/volume/ListVolumesCmdByAdmin.java
 ##
 @@ -34,32 +34,5 @@
 @APICommand(name = "listVolumes", description = "Lists all volumes.", 
responseObject = VolumeResponse.class, responseView = ResponseView.Full, 
entityType = {Volume.class},
 requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
 public class ListVolumesCmdByAdmin extends ListVolumesCmd {
-public static final Logger s_logger = 
Logger.getLogger(ListVolumesCmdByAdmin.class.getName());
-
-@Parameter(name=ApiConstants.POD_ID, type=CommandType.UUID, 
entityType=PodResponse.class,
-description="the pod id the disk volume belongs to")
-private Long podId;
 
 Review comment:
   make sense to remove if parent class has them already declared.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472239#comment-16472239
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

rhtyd commented on issue #2639: [CLOUDSTACK-10276] listVolumes not working when 
storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-388418653
 
 
   @rafaelweingartner for pre-setup is the name label used in place of uuid, 
than the name field? While adding such a presetup pool, should the add API be 
updated to save the sr label in name field but still created a UUID for the 
resource in db?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472233#comment-16472233
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

rafaelweingartner commented on a change in pull request #2639: 
[CLOUDSTACK-10276] listVolumes not working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#discussion_r187668341
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/volume/ListVolumesCmdByAdmin.java
 ##
 @@ -34,32 +34,5 @@
 @APICommand(name = "listVolumes", description = "Lists all volumes.", 
responseObject = VolumeResponse.class, responseView = ResponseView.Full, 
entityType = {Volume.class},
 requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
 public class ListVolumesCmdByAdmin extends ListVolumesCmd {
-public static final Logger s_logger = 
Logger.getLogger(ListVolumesCmdByAdmin.class.getName());
-
-@Parameter(name=ApiConstants.POD_ID, type=CommandType.UUID, 
entityType=PodResponse.class,
-description="the pod id the disk volume belongs to")
-private Long podId;
 
 Review comment:
   It is in the superclass as well. These parameters were declared twice. One 
in the "admin" class, and other in the "normal" one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472228#comment-16472228
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

rhtyd commented on a change in pull request #2639: [CLOUDSTACK-10276] 
listVolumes not working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#discussion_r187668006
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/volume/ListVolumesCmdByAdmin.java
 ##
 @@ -34,32 +34,5 @@
 @APICommand(name = "listVolumes", description = "Lists all volumes.", 
responseObject = VolumeResponse.class, responseView = ResponseView.Full, 
entityType = {Volume.class},
 requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
 public class ListVolumesCmdByAdmin extends ListVolumesCmd {
-public static final Logger s_logger = 
Logger.getLogger(ListVolumesCmdByAdmin.class.getName());
-
-@Parameter(name=ApiConstants.POD_ID, type=CommandType.UUID, 
entityType=PodResponse.class,
-description="the pod id the disk volume belongs to")
-private Long podId;
 
 Review comment:
   @rafaelweingartner Is podId an unused parameter?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID

2018-05-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472067#comment-16472067
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
-

rafaelweingartner opened a new pull request #2639: [CLOUDSTACK-10276] 
listVolumes not working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639
 
 
   ## Description
   
   When configuring a pre-setup primary storage we can enter the name-label of 
the storage that is going to be used by ACS and is already set up in the host. 
The problem is that we can use any String of characters there, and this String 
does not need to be a UUID. When listing volumes from a primary storage that 
has such conditions, the list will return all of the volumes in the cloud 
because the “API framework” will ignore that value as it is not a UUID type.
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   
   
   
   
   
   
   ## How Has This Been Tested?
   Locally
   
   
   
   
   
   ## Checklist:
   
   
   - [X] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [X] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [X] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)