[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[Wido den Hollander (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348735#comment-14348735
 ] 

Wido den Hollander commented on CLOUDSTACK-8302:


I'll look into this, but I'll probably won't have time for it soon

> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[Wido den Hollander (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907786#comment-14907786
 ] 

Wido den Hollander commented on CLOUDSTACK-8302:


Depending on version 0.2.0 should partially fix this

> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[Andrei Mikhailovsky (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974603#comment-14974603
 ] 

Andrei Mikhailovsky commented on CLOUDSTACK-8302:
-

Hi Wido,

Is there any update on this? Seems like one of the important features to have 
so that the primary storage does not get clogged up, as it seems to be 
happening here. How would one perform a manual cleanup of the old snapshots?

Cheers

> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[Wido den Hollander (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975932#comment-14975932
 ] 

Wido den Hollander commented on CLOUDSTACK-8302:


Not really. Haven't got the time to look into this. Partially it has been fixed 
that when you remove a volume so do all the snapshots.

You can manually remove any snapshots with the 'rbd' command in your Ceph 
cluster.

> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[Andrei Mikhailovsky (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976528#comment-14976528
 ] 

Andrei Mikhailovsky commented on CLOUDSTACK-8302:
-

Wido, thanks 

is it safe to remove all the primary storage stored snapshots if they have been 
successfully backed up to the secondary storage? 

Thanks 


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[Wido den Hollander (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976586#comment-14976586
 ] 

Wido den Hollander commented on CLOUDSTACK-8302:


Yes, that is safe. No problem.

> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15054348#comment-15054348
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


GitHub user dmytro-shevchenko opened a pull request:

https://github.com/apache/cloudstack/pull/1230

CLOUDSTACK-8302: Removing snapshots on RBD

Snapshot removing implemented if primary datastore is RBD
https://issues.apache.org/jira/browse/CLOUDSTACK-8302

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SafeSwissCloud/cloudstack CLOUDSTACK-8302

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1230


commit 32df243422d5985c8631686a0b2a29835f804079
Author: Amin 
Date:   2015-11-30T13:39:50Z

Merge pull request #1 from apache/master

Volume snapshot lifecycle patch on RBD as primary storage

commit c4d749f3b41090c47d98431aef67fa769642c798
Author: Dmytro Shevchenko 
Date:   2015-12-10T15:07:58Z

Merge from apache/master

commit a47b9300e414039734017fde0a41d162b54891f2
Author: Dmytro Shevchenko 
Date:   2015-12-12T14:44:09Z

https://issues.apache.org/jira/browse/CLOUDSTACK-8302
Snapshot removing implemented on RBD




> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15054364#comment-15054364
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-164161973
  
Hi @dmytro-shevchenko

Thanks for implementing the removal code. Could you squash the commits and 
add a descriptive commit message?


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056070#comment-15056070
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user dmytro-shevchenko commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-164459723
  
Commits are squashed and message updated.


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056096#comment-15056096
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-164464276
  
@dmytro-shevchenko Thank you, I'll give them a test run!


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062103#comment-15062103
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user voloshanenko commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-165465027
  
Guys, i see that build hangs... Can you please re run them?


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063711#comment-15063711
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user andrijapanic commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-165716739
  
Anyone has any more feedback ? Should we merge?


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063713#comment-15063713
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-165717186
  
I'll see if I can run tests on it today with @borisroman on our dev setup


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063714#comment-15063714
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1230#discussion_r48005662
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
 ---
@@ -1274,7 +1274,45 @@ public Answer createVolumeFromSnapshot(final 
CopyCommand cmd) {
 
 @Override
 public Answer deleteSnapshot(final DeleteCommand cmd) {
-return new Answer(cmd);
+try {
+SnapshotObjectTO snapshotTO = (SnapshotObjectTO) cmd.getData();
+PrimaryDataStoreTO primaryStore = (PrimaryDataStoreTO) 
snapshotTO.getDataStore();
+VolumeObjectTO volume = snapshotTO.getVolume();
+String snapshotFullPath = snapshotTO.getPath();
+String snapshotName = 
snapshotFullPath.substring(snapshotFullPath.lastIndexOf("/") + 1);
+KVMStoragePool primaryPool = 
storagePoolMgr.getStoragePool(primaryStore.getPoolType(), 
primaryStore.getUuid());
+KVMPhysicalDisk disk = 
storagePoolMgr.getPhysicalDisk(primaryStore.getPoolType(), 
primaryStore.getUuid(), volume.getPath());
+if (primaryPool.getType() == StoragePoolType.RBD) {
+Rados r = new Rados(primaryPool.getAuthUserName());
+r.confSet("mon_host", primaryPool.getSourceHost() + ":" + 
primaryPool.getSourcePort());
+r.confSet("key", primaryPool.getAuthSecret());
+r.confSet("client_mount_timeout", "30");
+r.connect();
+s_logger.debug("Succesfully connected to Ceph cluster at " 
+ r.confGet("mon_host"));
+IoCTX io = r.ioCtxCreate(primaryPool.getSourceDir());
+Rbd rbd = new Rbd(io);
+RbdImage image = rbd.open(disk.getName());
+try {
+s_logger.info("Attempting to remove RBD snapshot " + 
disk.getName() + "@" + snapshotName);
+if (image.snapIsProtected(snapshotName)) {
+s_logger.debug("Unprotecting snapshot " + 
snapshotFullPath);
+image.snapUnprotect(snapshotName);
+}
+image.snapRemove(snapshotName);
+s_logger.info("Snapshot " + snapshotFullPath + " 
successfully removed.");
+} finally {
+rbd.close(image);
+r.ioCtxDestroy(io);
+}
+} else {
+s_logger.warn("Operation not implemented!");
+throw new InternalErrorException("Operation not 
implemented!");
--- End diff --

Can we also add the type of storage pool in this message? Now this line 
doesn't say much. snapshotTO and primaryStore should contain all the 
information you need


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063951#comment-15063951
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user voloshanenko commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1230#discussion_r48025223
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
 ---
@@ -1274,7 +1274,45 @@ public Answer createVolumeFromSnapshot(final 
CopyCommand cmd) {
 
 @Override
 public Answer deleteSnapshot(final DeleteCommand cmd) {
-return new Answer(cmd);
+try {
+SnapshotObjectTO snapshotTO = (SnapshotObjectTO) cmd.getData();
+PrimaryDataStoreTO primaryStore = (PrimaryDataStoreTO) 
snapshotTO.getDataStore();
+VolumeObjectTO volume = snapshotTO.getVolume();
+String snapshotFullPath = snapshotTO.getPath();
+String snapshotName = 
snapshotFullPath.substring(snapshotFullPath.lastIndexOf("/") + 1);
+KVMStoragePool primaryPool = 
storagePoolMgr.getStoragePool(primaryStore.getPoolType(), 
primaryStore.getUuid());
+KVMPhysicalDisk disk = 
storagePoolMgr.getPhysicalDisk(primaryStore.getPoolType(), 
primaryStore.getUuid(), volume.getPath());
+if (primaryPool.getType() == StoragePoolType.RBD) {
+Rados r = new Rados(primaryPool.getAuthUserName());
+r.confSet("mon_host", primaryPool.getSourceHost() + ":" + 
primaryPool.getSourcePort());
+r.confSet("key", primaryPool.getAuthSecret());
+r.confSet("client_mount_timeout", "30");
+r.connect();
+s_logger.debug("Succesfully connected to Ceph cluster at " 
+ r.confGet("mon_host"));
+IoCTX io = r.ioCtxCreate(primaryPool.getSourceDir());
+Rbd rbd = new Rbd(io);
+RbdImage image = rbd.open(disk.getName());
+try {
+s_logger.info("Attempting to remove RBD snapshot " + 
disk.getName() + "@" + snapshotName);
+if (image.snapIsProtected(snapshotName)) {
+s_logger.debug("Unprotecting snapshot " + 
snapshotFullPath);
+image.snapUnprotect(snapshotName);
+}
+image.snapRemove(snapshotName);
+s_logger.info("Snapshot " + snapshotFullPath + " 
successfully removed.");
+} finally {
+rbd.close(image);
+r.ioCtxDestroy(io);
+}
+} else {
+s_logger.warn("Operation not implemented!");
+throw new InternalErrorException("Operation not 
implemented!");
--- End diff --

Wido, what do your mean? Improve s_logger.info messages? And include 
shared/dedicated message for pool type? Because if you mean RBD pool type - 
it's already included into message " .. remove RBD sn..."


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063967#comment-15063967
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1230#discussion_r48026314
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
 ---
@@ -1274,7 +1274,45 @@ public Answer createVolumeFromSnapshot(final 
CopyCommand cmd) {
 
 @Override
 public Answer deleteSnapshot(final DeleteCommand cmd) {
-return new Answer(cmd);
+try {
+SnapshotObjectTO snapshotTO = (SnapshotObjectTO) cmd.getData();
+PrimaryDataStoreTO primaryStore = (PrimaryDataStoreTO) 
snapshotTO.getDataStore();
+VolumeObjectTO volume = snapshotTO.getVolume();
+String snapshotFullPath = snapshotTO.getPath();
+String snapshotName = 
snapshotFullPath.substring(snapshotFullPath.lastIndexOf("/") + 1);
+KVMStoragePool primaryPool = 
storagePoolMgr.getStoragePool(primaryStore.getPoolType(), 
primaryStore.getUuid());
+KVMPhysicalDisk disk = 
storagePoolMgr.getPhysicalDisk(primaryStore.getPoolType(), 
primaryStore.getUuid(), volume.getPath());
+if (primaryPool.getType() == StoragePoolType.RBD) {
+Rados r = new Rados(primaryPool.getAuthUserName());
+r.confSet("mon_host", primaryPool.getSourceHost() + ":" + 
primaryPool.getSourcePort());
+r.confSet("key", primaryPool.getAuthSecret());
+r.confSet("client_mount_timeout", "30");
+r.connect();
+s_logger.debug("Succesfully connected to Ceph cluster at " 
+ r.confGet("mon_host"));
+IoCTX io = r.ioCtxCreate(primaryPool.getSourceDir());
+Rbd rbd = new Rbd(io);
+RbdImage image = rbd.open(disk.getName());
+try {
+s_logger.info("Attempting to remove RBD snapshot " + 
disk.getName() + "@" + snapshotName);
+if (image.snapIsProtected(snapshotName)) {
+s_logger.debug("Unprotecting snapshot " + 
snapshotFullPath);
+image.snapUnprotect(snapshotName);
+}
+image.snapRemove(snapshotName);
+s_logger.info("Snapshot " + snapshotFullPath + " 
successfully removed.");
+} finally {
+rbd.close(image);
+r.ioCtxDestroy(io);
+}
+} else {
+s_logger.warn("Operation not implemented!");
+throw new InternalErrorException("Operation not 
implemented!");
--- End diff --

For example:

"Operation not supported for storage pool type of NFS"


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065580#comment-15065580
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user dmytro-shevchenko commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1230#discussion_r48097934
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
 ---
@@ -1274,7 +1274,45 @@ public Answer createVolumeFromSnapshot(final 
CopyCommand cmd) {
 
 @Override
 public Answer deleteSnapshot(final DeleteCommand cmd) {
-return new Answer(cmd);
+try {
+SnapshotObjectTO snapshotTO = (SnapshotObjectTO) cmd.getData();
+PrimaryDataStoreTO primaryStore = (PrimaryDataStoreTO) 
snapshotTO.getDataStore();
+VolumeObjectTO volume = snapshotTO.getVolume();
+String snapshotFullPath = snapshotTO.getPath();
+String snapshotName = 
snapshotFullPath.substring(snapshotFullPath.lastIndexOf("/") + 1);
+KVMStoragePool primaryPool = 
storagePoolMgr.getStoragePool(primaryStore.getPoolType(), 
primaryStore.getUuid());
+KVMPhysicalDisk disk = 
storagePoolMgr.getPhysicalDisk(primaryStore.getPoolType(), 
primaryStore.getUuid(), volume.getPath());
+if (primaryPool.getType() == StoragePoolType.RBD) {
+Rados r = new Rados(primaryPool.getAuthUserName());
+r.confSet("mon_host", primaryPool.getSourceHost() + ":" + 
primaryPool.getSourcePort());
+r.confSet("key", primaryPool.getAuthSecret());
+r.confSet("client_mount_timeout", "30");
+r.connect();
+s_logger.debug("Succesfully connected to Ceph cluster at " 
+ r.confGet("mon_host"));
+IoCTX io = r.ioCtxCreate(primaryPool.getSourceDir());
+Rbd rbd = new Rbd(io);
+RbdImage image = rbd.open(disk.getName());
+try {
+s_logger.info("Attempting to remove RBD snapshot " + 
disk.getName() + "@" + snapshotName);
+if (image.snapIsProtected(snapshotName)) {
+s_logger.debug("Unprotecting snapshot " + 
snapshotFullPath);
+image.snapUnprotect(snapshotName);
+}
+image.snapRemove(snapshotName);
+s_logger.info("Snapshot " + snapshotFullPath + " 
successfully removed.");
+} finally {
+rbd.close(image);
+r.ioCtxDestroy(io);
+}
+} else {
+s_logger.warn("Operation not implemented!");
+throw new InternalErrorException("Operation not 
implemented!");
--- End diff --

Storage pool type added to messages.


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065665#comment-15065665
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-166087210
  
@andrijapanic Merge without testing and LGTMs? Really?


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065686#comment-15065686
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1230#discussion_r48101628
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
 ---
@@ -1274,7 +1274,46 @@ public Answer createVolumeFromSnapshot(final 
CopyCommand cmd) {
 
 @Override
 public Answer deleteSnapshot(final DeleteCommand cmd) {
-return new Answer(cmd);
+try {
+SnapshotObjectTO snapshotTO = (SnapshotObjectTO) cmd.getData();
+PrimaryDataStoreTO primaryStore = (PrimaryDataStoreTO) 
snapshotTO.getDataStore();
+VolumeObjectTO volume = snapshotTO.getVolume();
+String snapshotFullPath = snapshotTO.getPath();
+String snapshotName = 
snapshotFullPath.substring(snapshotFullPath.lastIndexOf("/") + 1);
+KVMStoragePool primaryPool = 
storagePoolMgr.getStoragePool(primaryStore.getPoolType(), 
primaryStore.getUuid());
+KVMPhysicalDisk disk = 
storagePoolMgr.getPhysicalDisk(primaryStore.getPoolType(), 
primaryStore.getUuid(), volume.getPath());
+if (primaryPool.getType() == StoragePoolType.RBD) {
+Rados r = new Rados(primaryPool.getAuthUserName());
+r.confSet("mon_host", primaryPool.getSourceHost() + ":" + 
primaryPool.getSourcePort());
+r.confSet("key", primaryPool.getAuthSecret());
+r.confSet("client_mount_timeout", "30");
+r.connect();
+s_logger.debug("Succesfully connected to Ceph cluster at " 
+ r.confGet("mon_host"));
+IoCTX io = r.ioCtxCreate(primaryPool.getSourceDir());
+Rbd rbd = new Rbd(io);
+RbdImage image = rbd.open(disk.getName());
+try {
+s_logger.info("Attempting to remove RBD snapshot " + 
disk.getName() + "@" + snapshotName);
+if (image.snapIsProtected(snapshotName)) {
+s_logger.debug("Unprotecting RBD snapshot " + 
snapshotFullPath);
+image.snapUnprotect(snapshotName);
+}
+image.snapRemove(snapshotName);
+s_logger.info("Snapshot " + snapshotFullPath + " 
successfully removed from " +
+primaryPool.getType().toString() + "  pool.");
+} finally {
+rbd.close(image);
+r.ioCtxDestroy(io);
+}
+} else {
+s_logger.warn("Operation not implemented for storage pool 
type of " + primaryPool.getType().toString());
+throw new InternalErrorException("Operation not 
implemented for storage pool type of " + primaryPool.getType().toString());
+}
+return new Answer(cmd, true, "Snapshot removed successfully.");
--- End diff --

I would add the path of the snapshot here: pool/image@snap. Logs should be 
easy to consume


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065687#comment-15065687
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1230#discussion_r48101631
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
 ---
@@ -1274,7 +1274,46 @@ public Answer createVolumeFromSnapshot(final 
CopyCommand cmd) {
 
 @Override
 public Answer deleteSnapshot(final DeleteCommand cmd) {
-return new Answer(cmd);
+try {
+SnapshotObjectTO snapshotTO = (SnapshotObjectTO) cmd.getData();
+PrimaryDataStoreTO primaryStore = (PrimaryDataStoreTO) 
snapshotTO.getDataStore();
+VolumeObjectTO volume = snapshotTO.getVolume();
+String snapshotFullPath = snapshotTO.getPath();
+String snapshotName = 
snapshotFullPath.substring(snapshotFullPath.lastIndexOf("/") + 1);
+KVMStoragePool primaryPool = 
storagePoolMgr.getStoragePool(primaryStore.getPoolType(), 
primaryStore.getUuid());
+KVMPhysicalDisk disk = 
storagePoolMgr.getPhysicalDisk(primaryStore.getPoolType(), 
primaryStore.getUuid(), volume.getPath());
+if (primaryPool.getType() == StoragePoolType.RBD) {
+Rados r = new Rados(primaryPool.getAuthUserName());
+r.confSet("mon_host", primaryPool.getSourceHost() + ":" + 
primaryPool.getSourcePort());
+r.confSet("key", primaryPool.getAuthSecret());
+r.confSet("client_mount_timeout", "30");
+r.connect();
+s_logger.debug("Succesfully connected to Ceph cluster at " 
+ r.confGet("mon_host"));
+IoCTX io = r.ioCtxCreate(primaryPool.getSourceDir());
+Rbd rbd = new Rbd(io);
+RbdImage image = rbd.open(disk.getName());
+try {
+s_logger.info("Attempting to remove RBD snapshot " + 
disk.getName() + "@" + snapshotName);
+if (image.snapIsProtected(snapshotName)) {
+s_logger.debug("Unprotecting RBD snapshot " + 
snapshotFullPath);
+image.snapUnprotect(snapshotName);
+}
+image.snapRemove(snapshotName);
+s_logger.info("Snapshot " + snapshotFullPath + " 
successfully removed from " +
+primaryPool.getType().toString() + "  pool.");
+} finally {
+rbd.close(image);
+r.ioCtxDestroy(io);
+}
+} else {
+s_logger.warn("Operation not implemented for storage pool 
type of " + primaryPool.getType().toString());
+throw new InternalErrorException("Operation not 
implemented for storage pool type of " + primaryPool.getType().toString());
+}
+return new Answer(cmd, true, "Snapshot removed successfully.");
+} catch (Exception e) {
+s_logger.error(e.getMessage());
+return new Answer(cmd, false, "Failed to remove snapshot!");
--- End diff --

Same here. Tell which snapshot couldn't be removed


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for 

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065689#comment-15065689
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-166100502
  
Last code review is LGTM to me, but didn't have the time to test it yet. I 
*think* it works, but need to verify first.


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066283#comment-15066283
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user dmytro-shevchenko commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-166261539
  
Full snapshot path added into log messages.


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070797#comment-15070797
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-167075932
  
ping @borisroman. I would like to see this one go in. Code-wise it looks 
good.


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074839#comment-15074839
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-167965031
  
Tests seem good according to @borisroman Just looking into why the 
XenServer strategy had to be used. That should be all


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082986#comment-15082986
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-168988457
  
Any other LGTMs?


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083609#comment-15083609
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user davidamorimfaria commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-169104666
  
LGTM, but haven't had the chance to test it yet.


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085400#comment-15085400
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-169295971
  
Really wondering why you need to alter XenserverSnapshotStrategy.java for 
something to work on KVM, like @wido asked. Please give an answer on that one, 
thanks!

Also, could someone run the integration tests and post the results?


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119444#comment-15119444
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-175687764
  
@dmytro-shevchenko can you rebase against latest master (with 4.9xx as the 
version) etc.


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129361#comment-15129361
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user dmytro-shevchenko commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-178890524
  
Done, rebased with 4.9xx master.


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180013#comment-15180013
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1230#discussion_r55043098
  
--- Diff: engine/storage/snapshot/pom.xml ---
@@ -37,6 +37,11 @@
   test-jar
   test
   
+  
+  org.apache.cloudstack
+  cloud-engine-storage-volume
+  4.9.0-SNAPSHOT
--- End diff --

this shopuld read ${project.version} instead of 4.9.0-SNAPSHOT


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180023#comment-15180023
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-192325294
  
@dmytro-shevchenko you are changing XenserverSnapshotStrategy from the 
storage engine and KVMStorageProcessor from the kvm hypervisor plugin. It seems 
that you are solving this for two hypervisors half. Can you explain what you 
encountered in the code to come up with this solution?


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208407#comment-15208407
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-200347989
  
@DaanHoogland 

So I've been digging into this a bit. I could be very wrong here, but it 
seems that XenserverSnapshotStrategy is a very inaccurate description of what 
this class is actually doing. It seems to be very general and based on some 
investigation being used for KVM as well. This might be an old artifact of the 
original feature being Xen specific, until others re-purposed it for other 
hypervisors.

Mike @mike-tutkowski mentioned something to this effect very recently in 
this PR: https://github.com/apache/cloudstack/pull/1441


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208417#comment-15208417
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user andrijapanic commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-200350271
  
I believe this is the reason Dmytro edit it, since it handles KVM stuff
also...

On 23 March 2016 at 14:40, Simon Weller  wrote:

> @DaanHoogland 
>
> So I've been digging into this a bit. I could be very wrong here, but it
> seems that XenserverSnapshotStrategy is a very inaccurate description of
> what this class is actually doing. It seems to be very general and based 
on
> some investigation being used for KVM as well. This might be an old
> artifact of the original feature being Xen specific, until others
> re-purposed it for other hypervisors.
>
> Mike @mike-tutkowski  mentioned
> something to this effect very recently in this PR: #1441
> 
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> 
>



-- 

Andrija Panić



> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210702#comment-15210702
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-200958562
  
Yes, @kiwiflyer, the naming XenserverSnapshotStrategy appears to be old and 
no longer accurate. I believe it should be renamed to something like 
DefaultSnapshotStrategy.


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232145#comment-15232145
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user swill commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1230#discussion_r59020704
  
--- Diff: engine/storage/snapshot/pom.xml ---
@@ -37,6 +37,11 @@
   test-jar
   test
   
+  
+  org.apache.cloudstack
+  cloud-engine-storage-volume
+  4.9.0-SNAPSHOT
--- End diff --

@dmytro-shevchenko please address this for forward compatibility.  Thanks...


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234605#comment-15234605
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-208196999
  
@mike-tutkowski @kiwiflyer So, it is just the class which has a incorrect 
name? The code is good?


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235439#comment-15235439
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-208438657
  
Lab testing of feature:

Cloudstack RBD snapshot job:

2016-04-11 11:26:22,955 DEBUG [c.c.a.t.Request] 
(Work-Job-Executor-1:ctx-5ac9d6c8 job-121/job-122 ctx-e3c6a9f8) 
(logid:af23718c) Seq 1-1541075497490841731: Received:  { Ans: , MgmtId: 
52239507206, via: 1(njcloudhost.dev.ena.net), Ver: v1, Flags: 10, { 
CreateObjectAnswer } }
2016-04-11 11:26:23,025 DEBUG [o.a.c.s.m.AncientDataMotionStrategy] 
(Work-Job-Executor-1:ctx-5ac9d6c8 job-121/job-122 ctx-e3c6a9f8) 
(logid:af23718c) copyAsync inspecting src type SNAPSHOT copyAsync inspecting 
dest type SNAPSHOT
2016-04-11 11:26:23,056 DEBUG [c.c.h.o.r.Ovm3HypervisorGuru] 
(Work-Job-Executor-1:ctx-5ac9d6c8 job-121/job-122 ctx-e3c6a9f8) 
(logid:af23718c) getCommandHostDelegation: class 
org.apache.cloudstack.storage.command.CopyCommand
2016-04-11 11:26:23,056 DEBUG [c.c.h.XenServerGuru] 
(Work-Job-Executor-1:ctx-5ac9d6c8 job-121/job-122 ctx-e3c6a9f8) 
(logid:af23718c) getCommandHostDelegation: class 
org.apache.cloudstack.storage.command.CopyCommand
2016-04-11 11:26:23,058 DEBUG [c.c.a.t.Request] 
(Work-Job-Executor-1:ctx-5ac9d6c8 job-121/job-122 ctx-e3c6a9f8) 
(logid:af23718c) Seq 1-1541075497490841732: Sending  { Cmd , MgmtId: 
52239507206, via: 1(njcloudhost.dev.ena.net), Ver: v1, Flags: 100111, 
[{"org.apache.cloudstack.storage.command.CopyCommand":{"srcTO":{"org.apache.cloudstack.storage.to.SnapshotObjectTO":{"path":"rbdnjcloudhost/c656809e-ecec-47a0-875d-af297fb77fe3/938125ff-da6d-4355-b83a-e3aa8d941807","volume":{"uuid":"c656809e-ecec-47a0-875d-af297fb77fe3","volumeType":"ROOT","dataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"f0dbafaa-52a3-3077-bc53-d7ad3a5ac132","id":4,"poolType":"RBD","host":"192.168.100.100","path":"rbdnjcloudhost","port":6789,"url":"RBD://192.168.100.100/rbdnjcloudhost/?ROLE=Primary&STOREUUID=f0dbafaa-52a3-3077-bc53-d7ad3a5ac132"}},"name":"ROOT-8","size":8589934592,"path":"c656809e-ecec-47a0-875d-af297fb77fe3","volumeId":8,"vmName":"i-4-8-VM","accountId":4,"format":"RAW","provisioningType":"THIN","id":8,"deviceId":0,"hypervisorType":"KVM"},"dataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"f0dbafaa-52a3-3077-bc53-d7ad3a5ac132","id":4,"poolType":"RBD","host":"192.168.100.100","path":"rbdnjcloudhost","port":6789,"url":"RBD://192.168.100.100/rbdnjcloudhost/?ROLE=Primary&STOREUUID=f0dbafaa-52a3-3077-bc53-d7ad3a5ac132"}},"vmName":"i-4-8-VM","name":"test","hypervisorType":"KVM","id":1,"quiescevm":false,"physicalSize":0}},"destTO":{"org.apache.cloudstack.storage.to.SnapshotObjectTO":{"path":"snapshots/4/8","volume":{"uuid":"c656809e-ecec-47a0-875d-af297fb77fe3","volumeType":"ROOT","dataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"f0dbafaa-52a3-3077-bc53-d7ad3a5ac132","id":4,"poolType":"RBD","host":"192.168.100.100","path":"rbdnjcloudhost","port":6789,"url":"RBD://192.168.100.100/rbdnjcloudhost/?ROLE=Primary&STOREUUID=f0dbafaa-52a3-3077-bc53-d7ad3a5ac132"}},"name":"ROOT-8","size":8589934592,"path":"c656809e-ecec-47a0-875d-af297fb77fe3","volumeId":8,"vmName":"i-4-8-VM","accountId":4,"format":"RAW","provisioningType":"THIN","id":8,"deviceId":0,"hypervisorType":"KVM"},"dataStore":{"com.cloud.agent.api.to.NfsTO":{"_url":"nfs://10.103.0.42/secondary","_role":"Image"}},"vmName":"i-4-8-VM","name":"test","hypervisorType":"KVM","id":1,"quiescevm":false,"physicalSize":0}},"executeInSequence":true,"options":{"fullSnapshot":"true"},"options2":{},"wait":21600}}]
 }


2016-04-11 11:27:41,178 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(API-Job-Executor-1:ctx-80f166f9 job-121) (logid:af23718c) Done executing 
org.apache.cloudstack.api.command.user.snapshot.CreateSnapshotCmd for job-121
2016-04-11 11:27:41,178 INFO  [o.a.c.f.j.i.AsyncJobMonitor] 
(API-Job-Executor-1:ctx-80f166f9 job-121) (logid:af23718c) Remove job-121 from 
job monitoring

Ceph Log show snapshot has been created:

rbd snap ls -p rbdnjcloudhost c656809e-ecec-47a0-875d-af297fb77fe3
SNAPID NAMESIZE 
12 938125ff-da6d-4355-b83a-e3aa8d941807 8192 MB 


Cloudstack delete RBD snashot job:

2016-04-11 11:34:03,679 DEBUG [c.c.a.ApiServlet] 
(catalina-exec-5:ctx-954c6978) (logid:3f05f35f) ===START===  10.16.0.38 -- GET  
command=deleteSnapshot&id=36e2eebe-8268-4c36-b21c-b2e57cb62974&response=json&_=1460392443709
2016-04-11 11:34:03,730 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(catalina-exec-5:ctx-954c6978 ctx-02ab09fe) (logid:3f05f35f) submit async 
job-123, details: AsyncJobVO {id:123, userId: 

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235447#comment-15235447
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-208439532
  
LGTM based on hardware lab testing of feature on 4.8 branch with PR applied.

Wido, 

As far as I can tell, the changes to XenserverSnapshotStrategy look to be 
valid for KVM.


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235655#comment-15235655
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-208484491
  
@wido Yes, the name is no longer valid, but it should work just fine for 
KVM.


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235659#comment-15235659
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-208484921
  
I'm not sure of the history for that particular file, but I believe it 
would be better named DefaultSnapshotStrategy.

Does anyone else have a better name?

If not, I can submit a PR for that on master.


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235666#comment-15235666
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-208486444
  
Based on the tests I see above LGTM.

A new PR afterwards to rename seems good.


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[haijiao (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257614#comment-15257614
 ] 

haijiao commented on CLOUDSTACK-8302:
-

Need another LGTM for including this in 4.9. :-)

> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258736#comment-15258736
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-214856246
  
With these changes I think we are good?


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260314#comment-15260314
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-215118770
  
I'm building this now and I'll give it a final manual test. Then we'll do a 
CI run against a hardware lab.


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260327#comment-15260327
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-215122706
  
@kiwiflyer Thank you sir.  :)


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261021#comment-15261021
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-215242253
  
Manual testing against a 4.8 hardware lab with Ceph Primary Storage.

2 volume snapshots triggered:
rbd snap ls -p rbdnjcloudhost cabf9a9e-7ac3-44b5-a3bb-02b820bed376
SNAPID NAMESIZE 
70 6efbba74-372c-4bd7-95bb-e539524e7209 5120 MB 
71 de6acd1b-ccac-4d3f-80aa-b40b05b86a63 5120 MB 

both snapshots are deleted
rbd snap ls -p rbdnjcloudhost cabf9a9e-7ac3-44b5-a3bb-02b820bed376
(no results as expected)

Works as expected. Functional tests are good.


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266424#comment-15266424
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-216208373
  
tag:mergeready


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266541#comment-15266541
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-216226380
  
@kiwiflyer thank you.  I will merge this today... 


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270705#comment-15270705
 ] 

ASF subversion and git services commented on CLOUDSTACK-8302:
-

Commit c9319e21fb33eaab42dee90cbfedd88eff23e842 in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c9319e2 ]

Merge pull request #1230 from SafeSwissCloud/CLOUDSTACK-8302

CLOUDSTACK-8302: Removing snapshots on RBDSnapshot removing implemented if 
primary datastore is RBD
https://issues.apache.org/jira/browse/CLOUDSTACK-8302

* pr/1230:
  CLOUDSTACK-8302 - Cleanup snapshot on KVM with RBD Snapshot removing 
implemented on RBD. 1. On management side: when created new shanpshot we 
checking if our primary storage is RBD, then do not remove record from 
cloud.snapshot_store_ref with link to Ceph image via 'install_path' field. 2. 
On management side: when removing snapshot, also send command to agent 
'DeleteCommand'. 3. On agent side: method implemented 'public Answer 
deleteSnapshot(final DeleteCommand cmd)'

Signed-off-by: Will Stevens 


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270703#comment-15270703
 ] 

ASF subversion and git services commented on CLOUDSTACK-8302:
-

Commit c9319e21fb33eaab42dee90cbfedd88eff23e842 in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c9319e2 ]

Merge pull request #1230 from SafeSwissCloud/CLOUDSTACK-8302

CLOUDSTACK-8302: Removing snapshots on RBDSnapshot removing implemented if 
primary datastore is RBD
https://issues.apache.org/jira/browse/CLOUDSTACK-8302

* pr/1230:
  CLOUDSTACK-8302 - Cleanup snapshot on KVM with RBD Snapshot removing 
implemented on RBD. 1. On management side: when created new shanpshot we 
checking if our primary storage is RBD, then do not remove record from 
cloud.snapshot_store_ref with link to Ceph image via 'install_path' field. 2. 
On management side: when removing snapshot, also send command to agent 
'DeleteCommand'. 3. On agent side: method implemented 'public Answer 
deleteSnapshot(final DeleteCommand cmd)'

Signed-off-by: Will Stevens 


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270706#comment-15270706
 ] 

ASF subversion and git services commented on CLOUDSTACK-8302:
-

Commit c9319e21fb33eaab42dee90cbfedd88eff23e842 in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c9319e2 ]

Merge pull request #1230 from SafeSwissCloud/CLOUDSTACK-8302

CLOUDSTACK-8302: Removing snapshots on RBDSnapshot removing implemented if 
primary datastore is RBD
https://issues.apache.org/jira/browse/CLOUDSTACK-8302

* pr/1230:
  CLOUDSTACK-8302 - Cleanup snapshot on KVM with RBD Snapshot removing 
implemented on RBD. 1. On management side: when created new shanpshot we 
checking if our primary storage is RBD, then do not remove record from 
cloud.snapshot_store_ref with link to Ceph image via 'install_path' field. 2. 
On management side: when removing snapshot, also send command to agent 
'DeleteCommand'. 3. On agent side: method implemented 'public Answer 
deleteSnapshot(final DeleteCommand cmd)'

Signed-off-by: Will Stevens 


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270704#comment-15270704
 ] 

ASF subversion and git services commented on CLOUDSTACK-8302:
-

Commit c9319e21fb33eaab42dee90cbfedd88eff23e842 in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c9319e2 ]

Merge pull request #1230 from SafeSwissCloud/CLOUDSTACK-8302

CLOUDSTACK-8302: Removing snapshots on RBDSnapshot removing implemented if 
primary datastore is RBD
https://issues.apache.org/jira/browse/CLOUDSTACK-8302

* pr/1230:
  CLOUDSTACK-8302 - Cleanup snapshot on KVM with RBD Snapshot removing 
implemented on RBD. 1. On management side: when created new shanpshot we 
checking if our primary storage is RBD, then do not remove record from 
cloud.snapshot_store_ref with link to Ceph image via 'install_path' field. 2. 
On management side: when removing snapshot, also send command to agent 
'DeleteCommand'. 3. On agent side: method implemented 'public Answer 
deleteSnapshot(final DeleteCommand cmd)'

Signed-off-by: Will Stevens 


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270707#comment-15270707
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8302:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1230


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270702#comment-15270702
 ] 

ASF subversion and git services commented on CLOUDSTACK-8302:
-

Commit 10ae2aff28cae69f0199fa2820472bb9cd7f3ebc in cloudstack's branch 
refs/heads/master from [~Demonsh]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=10ae2af ]

CLOUDSTACK-8302 - Cleanup snapshot on KVM with RBD
Snapshot removing implemented on RBD.
1. On management side: when created new shanpshot we checking if our primary 
storage is RBD,
then do not remove record from cloud.snapshot_store_ref with link to Ceph
image via 'install_path' field.
2. On management side: when removing snapshot, also send command to agent 
'DeleteCommand'.
3. On agent side: method implemented 'public Answer deleteSnapshot(final 
DeleteCommand cmd)'


> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD

[Wido den Hollander (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738855#comment-14738855
 ] 

Wido den Hollander commented on CLOUDSTACK-8302:


This seems to be a problem with rados-java as well.

It is hardcoded to 16 RBD snapshots at maximum and crashes otherwise it seems.

> Cleanup snapshot on KVM with RBD
> 
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When 
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD 
> pool is still exist.
> And I find the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null;  //To change body of implemented methods use File | 
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but 
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)