[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690137#comment-15690137
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
btw, I don't think this PR should be backport since it would change 
behavior for someone that would upgrade from 4.x.x to 4.9.0 or 4.9.x(that would 
include this PR)


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689269#comment-15689269
 ] 

ASF subversion and git services commented on CLOUDSTACK-9489:
-

Commit 072af7a6771d2feb571ab37db70451296d2256f3 in cloudstack's branch 
refs/heads/master from [~rohit.ya...@shapeblue.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=072af7a ]

Merge pull request #1684 from shapeblue/cloudstack-9489

CLOUDSTACK-9489: the new config vars that are added do not goto DB if values 
are set to NULL, removing this check so the entries in DB are made with NULL 
values

* pr/1684:
  CLOUDSTACK-9489: the new config vars that are added do not goto DB if values 
are set to NULL, removing this check so the entries in DB are made with NULL 
values

Signed-off-by: Rohit Yadav 


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689268#comment-15689268
 ] 

ASF subversion and git services commented on CLOUDSTACK-9489:
-

Commit 072af7a6771d2feb571ab37db70451296d2256f3 in cloudstack's branch 
refs/heads/master from [~rohit.ya...@shapeblue.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=072af7a ]

Merge pull request #1684 from shapeblue/cloudstack-9489

CLOUDSTACK-9489: the new config vars that are added do not goto DB if values 
are set to NULL, removing this check so the entries in DB are made with NULL 
values

* pr/1684:
  CLOUDSTACK-9489: the new config vars that are added do not goto DB if values 
are set to NULL, removing this check so the entries in DB are made with NULL 
values

Signed-off-by: Rohit Yadav 


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689267#comment-15689267
 ] 

ASF subversion and git services commented on CLOUDSTACK-9489:
-

Commit a39cc61fc61a52b5d57e963a9a6a2d6f0e951c28 in cloudstack's branch 
refs/heads/master from [~abhi_shapeblue]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a39cc61 ]

CLOUDSTACK-9489: the new config vars that are added do not goto DB if values 
are set to NULL, removing this check so the entries in DB are made with NULL 
values


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689263#comment-15689263
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1684


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689260#comment-15689260
 ] 

ASF subversion and git services commented on CLOUDSTACK-9489:
-

Commit 072af7a6771d2feb571ab37db70451296d2256f3 in cloudstack's branch 
refs/heads/4.9 from [~rohit.ya...@shapeblue.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=072af7a ]

Merge pull request #1684 from shapeblue/cloudstack-9489

CLOUDSTACK-9489: the new config vars that are added do not goto DB if values 
are set to NULL, removing this check so the entries in DB are made with NULL 
values

* pr/1684:
  CLOUDSTACK-9489: the new config vars that are added do not goto DB if values 
are set to NULL, removing this check so the entries in DB are made with NULL 
values

Signed-off-by: Rohit Yadav 


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689259#comment-15689259
 ] 

ASF subversion and git services commented on CLOUDSTACK-9489:
-

Commit a39cc61fc61a52b5d57e963a9a6a2d6f0e951c28 in cloudstack's branch 
refs/heads/4.9 from [~abhi_shapeblue]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a39cc61 ]

CLOUDSTACK-9489: the new config vars that are added do not goto DB if values 
are set to NULL, removing this check so the entries in DB are made with NULL 
values


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689261#comment-15689261
 ] 

ASF subversion and git services commented on CLOUDSTACK-9489:
-

Commit 072af7a6771d2feb571ab37db70451296d2256f3 in cloudstack's branch 
refs/heads/4.9 from [~rohit.ya...@shapeblue.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=072af7a ]

Merge pull request #1684 from shapeblue/cloudstack-9489

CLOUDSTACK-9489: the new config vars that are added do not goto DB if values 
are set to NULL, removing this check so the entries in DB are made with NULL 
values

* pr/1684:
  CLOUDSTACK-9489: the new config vars that are added do not goto DB if values 
are set to NULL, removing this check so the entries in DB are made with NULL 
values

Signed-off-by: Rohit Yadav 


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689240#comment-15689240
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
Thanks @pdion891 we'll open a doc PR shortly. Based on the discussion, 
review and tests, I'll proceed with the merge now.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15686834#comment-15686834
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
I haven't retested recently but the upgrade path will need documentation 
update I think because of the ``commands.properties``.

Otherwise it's LGTM for me too.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15686624#comment-15686624
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
LGTM. Failures in tests around RVR/VPC are known intermittent failures.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15684217#comment-15684217
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
Trillian test result (tid-375)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26478 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1684-t375-kvm-centos7.zip
Test completed. 46 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 389.90 
| test_vpc_redundant.py
test_02_vpc_privategw_static_routes | `Failure` | 199.18 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 168.16 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.16 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 386.11 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 283.79 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 570.99 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 512.61 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1447.91 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 561.81 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 771.72 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.48 | test_volumes.py
test_08_resize_volume | Success | 15.44 | test_volumes.py
test_07_resize_fail | Success | 20.56 | test_volumes.py
test_06_download_detached_volume | Success | 15.32 | test_volumes.py
test_05_detach_volume | Success | 100.28 | test_volumes.py
test_04_delete_attached_volume | Success | 10.21 | test_volumes.py
test_03_download_attached_volume | Success | 15.40 | test_volumes.py
test_02_attach_volume | Success | 45.16 | test_volumes.py
test_01_create_volume | Success | 714.83 | test_volumes.py
test_deploy_vm_multiple | Success | 303.97 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 27.01 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.26 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 41.48 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.91 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.87 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.19 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.36 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 85.72 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.23 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.18 | test_templates.py
test_01_create_template | Success | 35.43 | test_templates.py
test_10_destroy_cpvm | Success | 136.69 | test_ssvm.py
test_09_destroy_ssvm | Success | 168.72 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.59 | test_ssvm.py
test_07_reboot_ssvm | Success | 134.60 | test_ssvm.py
test_06_stop_cpvm | Success | 162.03 | test_ssvm.py
test_05_stop_ssvm | Success | 134.04 | test_ssvm.py
test_04_cpvm_internals | Success | 1.20 | test_ssvm.py
test_03_ssvm_internals | Success | 5.29 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_01_snapshot_root_disk | Success | 21.46 | test_snapshots.py
test_04_change_offering_small | Success | 239.71 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py
test_09_reboot_router | Success | 35.30 | test_routers.py
test_08_start_router | Success | 30.30 | test_routers.py
test_07_stop_router | Success | 10.17 | test_routers.py
test_06_router_advanced | Success | 0.07 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682831#comment-15682831
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682829#comment-15682829
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@blueorangutan test


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681475#comment-15681475
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-198


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15680703#comment-15680703
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@blueorangutan package


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15680708#comment-15680708
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672814#comment-15672814
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@pdion891 I don't care for the idea of potentially ignoring a custom 
security configuration as it may unexpectedly reduce a user's security.   By 
default, we should take the most conservative path when setting security 
defaults.

/cc @PaulAngus 


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624857#comment-15624857
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 133
 Hypervisor xenserver
 NetworkType Advanced
 Passed=98
 Failed=5
 Skipped=6

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_non_contigiousvlan.py

 * test_extendPhysicalNetworkVlan Failed

* test_deploy_vm_iso.py

 * test_deploy_vm_from_iso Failing since 17 runs

* test_list_ids_parameter.py

 * ContextSuite context=TestListIdsParams>:setup Failing since 6 runs

* test_vm_life_cycle.py

 * test_10_attachAndDetach_iso Failing since 18 runs

* test_routers_network_ops.py

 * test_01_isolate_network_FW_PF_default_routes_egress_true Failed


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538628#comment-15538628
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
I've re-perform my upgrade test this morning with this PR, I just add to 
change ``dynamic.apichecker.enabled`` value have the authentication working, so 
nothing else have to change.

As @PaulAngus raised, in an upgrade scenario where the management-server is 
build for scratch to perform a cloud upgrade, ``dynamic.apichecker.enabled`` 
will cause issues and headache.

So to me it would make more sense if during and upgrade the value of 
``dynamic.apichecker.enabled`` is automatically set to "true" which is already 
the value of a new deployment, then we should update the release notes so if 
users have customized the ``commands.properties`` file, it's up to them to 
rollback ``dynamic.apichecker.enabled`` to false and make sure they have a copy 
of the commands.properties file. what do you think @PaulAngus ?

Maybe the ideal scenario would be that if the ``commands.properties`` file 
exist, cloudstack during is upgrade phase when it's started would update is 
dynamic apichecker values to those defined in the commands.properties 

Does this should go in this PR or we consider this PR is ok?


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536026#comment-15536026
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@rhtyd I agree with you for the documentation part.

For sure in-place upgrade must be transparent to user and not required 
manual steps.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533514#comment-15533514
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@rhtyd we have a case where two experienced users (and likely more to come) 
have gotten tripped up by this case.  Therefore, we need to address it.  As I 
mentioned previously, the solution to this issue may be improved documentation. 
 In discussing it further, we may also find a technical solution as well.  


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533406#comment-15533406
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@PaulAngus but it's up to the admin and how they want to upgrade/setup a 
new mgmt server. Assuming you want to create a new mgmt server for each old 
mgmt server, one strategy could be to copy the commands.properties from each 
old mgmt server to each such new mgmt server.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533399#comment-15533399
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user PaulAngus commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
That isnt correct @bhaisaab.  commands.properties can be different on every 
mgmt server.  Cloudstack would not know which version to use.




From: Rohit Yadav 
Sent: 29 Sep 2016 18:16
To: apache/cloudstack
Cc: Paul Angus; Mention
Subject: Re: [apache/cloudstack] CLOUDSTACK-9489: the new config vars that 
are added do not goto DB if… (#1684)


@jburwell when a fresh mgmt server is deployed 
for upgrading an existing CloudStack environment, several files from 
/etc/cloudstack/management are copied to the new server, especially the 
db.properties file. The commands.properties is no different, in the past all 
such deployment (where in-place upgrades were avoided) copied all these config 
files in /etc/cloudstack/management from old server to new server.

Official docs only talk about in-place upgrades, our packaging system 
(post-install/upgrade scripts) assume in-place upgrade as well; if someone's 
doing fresh mgmt server for upgrade, they know what they are doing and its 
out-of-scope of what the project can support. At the same time, we may add 
documentation for such kind of upgrades as well. The solution for this problem 
is documentation and release/upgrade notes.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on 
GitHub, 
or mute the 
thread.


Paul Angus
VP Technology
s: +44 203 603 0540  |   m: +44 7711 418784  |   d: +44 203 468 5163
e: paul.an...@shapeblue.com  |  w: www.shapeblue.com  |  t: @cloudyangus 
@shapeblue
a: 53 Chandos Place, Covent Garden, London  WC2N 4HSUK


Shape Blue Ltd is a company incorporated in England  Wales. ShapeBlue 
Services India LLP is a company incorporated in India and is operated under 
license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company 
incorporated in Brasil and is operated under license from Shape Blue Ltd. 
ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa 
and is traded under license from Shape Blue Ltd. ShapeBlue is a registered 
trademark.This email and any attachments to it may be confidential and are 
intended solely for the use of the individual to whom it is addressed. Any 
views or opinions expressed are solely those of the author and do not 
necessarily represent those of Shape Blue Ltd or related companies. If you are 
not the intended recipient of this email, you must neither take any action 
based upon its contents, nor copy or show it to anyone. Please contact the 
sender if you believe you have received this email in error.

Find out more about ShapeBlue and our range of CloudStack related services:
IaaS Cloud Design  Build|CSForge - rapid IaaS deployment 
framework
CloudStack Consulting|CloudStack Software Engineering
CloudStack Infrastructure Support|CloudStack Bootcamp Training 
Courses



> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533380#comment-15533380
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@jburwell when a fresh mgmt server is deployed for upgrading an existing 
CloudStack environment, several files from `/etc/cloudstack/management` are 
copied to the new server, especially the `db.properties` file. The 
`commands.properties` is no different, in the past all such deployment (where 
in-place upgrades were avoided) copied all these config files in 
/etc/cloudstack/management from old server to new server.

Official docs only talk about in-place upgrades, our packaging system 
(post-install/upgrade scripts) assume in-place upgrade as well; if someone's 
doing fresh mgmt server for upgrade, they know what they are doing and its 
out-of-scope of what the project can support. At the same time, we may add 
documentation for such kind of upgrades as well. The solution for this problem 
is documentation and release/upgrade notes.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533219#comment-15533219
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@rhtyd discussing this issue with @paul, there is a scenario where this 
wedged condition can occur.  If you perform an upgrade by creating a new 
management server VM then no commands.properties file will be present and the 
dynamic API checker will be set to off.  This upgrade approach is taken as a 
best practice to provide a simple, reliable rollback strategy and an 
opportunity to perform OS upgrades.  I think the solution in this situation is 
combination of improved upgrade documentation (i.e. copy over your 
commands.properties or run the import script and turn on the dynamic role API 
checker) and some better error messages that will help admins understand how to 
remedy the problem.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533174#comment-15533174
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@pdion891 @jburwell as I've already explained, there should be no need to 
enable dynamic apichecker if you're upgrading from an older system that has a 
commands.properties file. I think the upgrade tests was performed not using 
packages but maven/jetty. The current 4.9+ branch don't have 
commands.properties so when you rebuild mgmt server you don't get the 
commands.properties in the classpath. This has been documented in the admin 
docs as well. If you've installed 4.9+ based mgmt server on a new server, the 
old commands.properties file need to be copied to the new server to continue to 
use the static checker, otherwise the dynamic checker need to be enabled and 
migrated using a migration script as documented here: 
http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/4.9/accounts.html#using-dynamic-roles


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532774#comment-15532774
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@pdion891 based on the behavior reported, I believe we can make this 
experience much smoother if not completely consistent.  Do you have time to 
grab a quick GTM to discuss tomorrow (29 Sept 2016)?  I will report the results 
of the call back to this PR (and by extension dev@).


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532700#comment-15532700
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
Thanks @abhinandanprateek.  So I guest it's an LGTM for this PR but it's 
not solving the whole issue for CLOUDSTACK-9489 which is configuration 
inconsistency between fresh install and upgrade. So to me this PR cannot close 
CLOUDSTACK-9489 unless we create a new jira issue for the auth issue after an 
upgrade where we would need to manually change ``dynamic.apichecker.enabled``.




> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15531707#comment-15531707
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@pdion891 The issue regarding dynamic apichecker will happen even without 
this patch. In 4.9 there is no command.properties and it has been moved to 
apichecker schema.

 All this patch does is write the configuration that have 'null' values to 
db. As such it is not going to reset any of the existing values during an 
upgrade. cc @rhtyd @jburwell 


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15531480#comment-15531480
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
Thanks @rhtyd, @jburwell @abhinandanprateek for the clarifications.

Look like doing the ``update cloud.configuration set value='true' where 
name='dynamic.apichecker.enabled';`` fixe the authentication issue.

Should we expect another issue post upgrade because of this db change? 
should we roll it back later? I haven't found the file command.properties when 
running 4.9.1.0-SNAPSHOT via jetty in the repo.

also, in the context a user did customized some values, will they be reset?

Thanks! 


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15531040#comment-15531040
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@rhtyd this issue feels like it should no occur.  For example, could the 
role permission tables be populated with default values when they are created?  
If/when values are imported from an existing `command.properties`, the import 
tool could clear the tables as the first step in the process. 


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528655#comment-15528655
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@abhinandanprateek 4.9+ does not contain commands.properties so which is 
why dynamic roles is enabled for them (by default). When upgrading, if you or 
@pdion891 upgraded using maven/git code and not packages you won't have 
commands.properties file and login won't work if dynamic roles is not enabled, 
but for existing deployments login should work who will have 
commands.properties in their classpath.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528109#comment-15528109
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@pdion891 The root of this issue is that 4.9 uses dynamic api checker, 
which by default is not enabled. So even when the login succeed it does not go 
anywhere as the access to any api is denied.
After upgrade run this on cloud db:  update cloud.configuration set 
value='true' where name='dynamic.apichecker.enabled';

This will fix the login issue.
I am sure this is there in upgrade documentation, @rhtyd will be the best 
person to comment if it can be included in upgrade scripts. cc @jburwell 


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526145#comment-15526145
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@abhinandanprateek did you ran a fresh install of 4.9.x  or did an upgrade 
from example 4.4.4 ?

The way I'm testing is as follow, in case I do something wrong:

1) ``git checkout tags/4.4.4 -b 4.4.4``
2) Deploy and start management-server
```
mvn -DskipTests=true clean install -T 2
mvn -Pdeveloper -pl developer -Ddeploydb
mvn -pl client jetty:run
```
4) Auth test on the ui,  then stop jetty 
5) Change version to upgrade: ``git fetch origin pull/1684/head:pr-1684``
6) Build the new version but not deploy the DB to force the upgrade path:
```
mvn -DskipTests=true clean install -T 2
mvn -pl client jetty:run
```
7) test auth as admin in the UI and it's not working.



> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526039#comment-15526039
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@pdion891 I am unable to reproduce the issue. All the authenticators 
configured are tried.
I find it strange that there are no logs. Will it be possible to take a 
second look. I need either logs or some leads to move further on this.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523213#comment-15523213
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user dagsonstebo commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@pdion891 - client system so limited access, not got cloudmonkey access but 
here's what's in the DB:

mysql> select name from configuration;
| name|
| account.cleanup.interval|
| affinity.processors.exclude |
| affinity.processors.order   |
| agent.lb.enabled|
| agent.load.threshold|
| alert.email.addresses   |
| alert.email.sender  |
| alert.purge.delay   |
| alert.purge.interval|
| alert.smtp.connectiontimeout|
| alert.smtp.host |
| alert.smtp.password |
| alert.smtp.port |
| alert.smtp.timeout  |
| alert.smtp.useAuth  |
| alert.smtp.username |
| alert.wait  |
| allow.public.user.templates |
| allow.subdomain.network.access  |
| allow.user.create.projects  |
| allow.user.expunge.recover.vm   |
| allow.user.view.destroyed.vm|
| api.checkers.exclude|
| api.throttling.cachesize|
| api.throttling.enabled  |
| api.throttling.interval |
| api.throttling.max  |
| apply.allocation.algorithm.to.pods  |
| backup.snapshot.wait|
| baremetal.ipmi.fail.retry   |
| baremetal.ipmi.lan.interface|
| blacklisted.routes  |
| capacity.check.period   |
| capacity.skipcounting.hours |
| check.pod.cidrs |
| check.txn.before.sending.agent.commands |
| cloud.dns.name  |
| cloud.identifier|
| cloudbyte.management.apikey |
| cloudbyte.management.ip |
| cluster.cpu.allocated.capacity.disablethreshold |
| cluster.cpu.allocated.capacity.notificationthreshold|
| cluster.heartbeat.interval  |
| cluster.heartbeat.threshold |
| cluster.localStorage.capacity.notificationthreshold |
| cluster.memory.allocated.capacity.disablethreshold  |
| cluster.memory.allocated.capacity.notificationthreshold |
| cluster.message.timeout.seconds |
| cluster.storage.allocated.capacity.notificationthreshold|
| cluster.storage.capacity.notificationthreshold  |
| cluster.storage.operations.exclude  |
| concurrent.snapshots.threshold.perhost  |
| console.proxy.allocator.exclude |
| consoleproxy.capacity.standby   |
| consoleproxy.capacityscan.interval  |
| consoleproxy.cmd.port   |
| consoleproxy.disable.rpfilter   |
| consoleproxy.launch.max |
| consoleproxy.loadscan.interval  |
| consoleproxy.management.state   |
| consoleproxy.management.state.last  |
| consoleproxy.restart|
| consoleproxy.service.offering   |
| consoleproxy.session.max|
| consoleproxy.session.timeout|

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523198#comment-15523198
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@dagsonstebo for your scenario 2 can you get the count of global settings ? 

via cloudmonkey as admin:
```
list configurations
```
You should have a count of about 468.

Also this current PR did apply some changes from the Config.java that were 
not applied in your upgrades. I have test upgrade path without this fix and I 
had no issues, but we end up with missing configurations entrees.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523174#comment-15523174
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user dagsonstebo commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@pdion891 in my list above:

1) Was an upgrade CCP4.5.1 to ACS4.5.2 - and this was where we potentially 
saw a bug, but never proven.
2) Was an upgrade CCP3.0.7 to ACS4.9.0 - no issues found.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523036#comment-15523036
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@dagsonstebo, did you upgrade to 4.9 ?  So far, I had no authentication 
issue upgrading to 4.7.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522970#comment-15522970
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user dagsonstebo commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@abhinandanprateek @jburwell @pdion891 - my twopence worth - I've come 
across issues with this on two uprade projects in the last 8-10 months. Both 
cases were CCP to ACS upgrades:

1) In the first case we hit an issue where the admin account could log in - 
but no users. We carried out a preliminary check of this, and the suspicion was 
on changes in the MD5 authenticator - but the client eventually chose to just 
reset all users passwords, hence no accurate RCA carried out.

2) In the second, more recent case the client wanted to use either 
PLAINTEXT or MD5 authenticators, hence we updated the authenticators order 
similar to @pdion891 did above. During troubleshooting of this trace level 
logging showed the authenticator order in ACS4.9 was respected, no issues 
found. RCA of the underlying issue concluded with it being a user configuration 
and usage issue rather than a bug.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522883#comment-15522883
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@abhinandanprateek  I did replace the following 4 settings by the original 
values. But after restarting jetty I'm unable to login, but this time the 
behavior is a bit different, it look like it doesn't try to login, no log or 
message in the UI.

```
update configuration set value=null where 
name='user.password.encoders.exclude';
update configuration set value='SHA256SALT,MD5,LDAP,PLAINTEXT' where 
name='user.authenticators.order';
update configuration set value=null where 
name='user.authenticators.exclude';
update configuration set value='SHA256SALT,MD5,LDAP,PLAINTEXT' where 
name='user.password.encoders.order';
```

Could it be possible the  authentication order is not followed at the 
login? if the password does not meet ``PBKDF2`` requirement, which is the first 
in the order list of 4.9.0, shouldn't try with the next encoder in the list and 
so on?




> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522327#comment-15522327
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@jburwell yes we might have to further investigate this. I am waiting for 
info about the global params from @pdion891 to further this.
I think it will require a fix in upgrade scripts as the original 
authenticator should be preserved.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521944#comment-15521944
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@abhinandanprateek do we need to add a note to the upgrade documentation 
and/or refine the upgrade script to protect against a change in 
`user.password.encoders.exclude` and `user.password.encoders.order`?


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521927#comment-15521927
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@pdion891 You need to look at user.authenticators.order and 
user.authenticators.exclude and see if they will provide same authenticator in 
chain as the one configured pre-upgrade.
Also check values of user.password.encoders.exclude and 
user.password.encoders.order for consistency. cc @jburwell @rhtyd 


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521910#comment-15521910
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@DagSonsteboSB @rhtyd this issue looks similar one we had with another 
upgrade.  Do you agree?  If so, do you recall what we did to fix it?


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521841#comment-15521841
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
upgrade from 4.7.0 to 4.9.0.1 not working with same error:
```
WARN  [o.a.c.s.a.PBKDF2UserAuthenticator] (qtp204585401-22:ctx-9e4c5615) 
(logid:1ca9f551) The stored password for admin isn't in the right format for 
this authenticator
```


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521821#comment-15521821
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
I've applied this fix to 4.7.0 and I got the upgrade from 4.4.4 working.  
but when I upgrade 4.4.4 to this PR  I end with inability to logon into the UI.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521118#comment-15521118
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
Unfortunately, Authentication is not working after an upgrade.  the 
configration table as been updated  but login is not working anymore.

Upgrade test from 4.4.4 to the PR (4.9), I can see that configuration table 
changes, origin confi count = 413, after starting 4.9 = 488

Here is the error display from jetty when trying to login into the UI or 
via cloudmonkey:

```
WARN  [o.a.c.s.a.PBKDF2UserAuthenticator] (qtp368929124-24:ctx-97af69ff) 
(logid:0d6ca986) The stored password for admin isn't in the right format for 
this authenticator
```


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520920#comment-15520920
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@pdion891 yes, it will be merged to 4.8 and forward merged to 4.9 and 
master.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520914#comment-15520914
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
I will test this PR, allow me few days..
This will be ported into master as well right? 

Thanks


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520104#comment-15520104
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@jburwell a Trillian-Jenkins matrix job (centos6 mgmt + xs56sp1, centos7 
mgmt + vmware55u3, ubuntu mgmt + kvmcentos7) has been kicked to run smoke tests


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520102#comment-15520102
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@blueorangutan test matrix


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520100#comment-15520100
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@blueorganutan test matrix


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517151#comment-15517151
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-24


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517086#comment-15517086
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@abhinandanprateek this issue also affects 4.8.  Would it be possible to 
[change the base 
branch](https://github.com/blog/2224-change-the-base-branch-of-a-pull-request) 
of this PR to 4.8?


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517082#comment-15517082
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@jburwell a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517078#comment-15517078
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@blueorangutan package


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517075#comment-15517075
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
LGTM for code.

@pdion891 could you re-execute your upgrade scenario to verify that 
CLOUDSTACK-9489 is fixed?


> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515465#comment-15515465
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9489:


GitHub user abhinandanprateek opened a pull request:

https://github.com/apache/cloudstack/pull/1684

CLOUDSTACK-9489: the new config vars that are added do not goto DB if…

… values are set to NULL, removing this check so the entries in DB are made 
with NULL values

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack cloudstack-9489

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1684.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1684


commit a39cc61fc61a52b5d57e963a9a6a2d6f0e951c28
Author: Abhinandan Prateek 
Date:   2016-09-23T05:28:11Z

CLOUDSTACK-9489: the new config vars that are added do not goto DB if 
values are set to NULL, removing this check so the entries in DB are made with 
NULL values




> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[Abhinandan Prateek (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515417#comment-15515417
 ] 

Abhinandan Prateek commented on CLOUDSTACK-9489:


I think yes there is an issue. Thanks [~pdion] for sharing the upgrade diff. 
This helped me nail the issue.

There are these following variables added to Config.java in 4.6:

   // Ovm
OvmPublicNetwork("Hidden", ManagementServer.class, String.class, 
"ovm.public.network.device", null, "Specify the public bridge on host for 
public network", null),
OvmPrivateNetwork("Hidden", ManagementServer.class, String.class, 
"ovm.private.network.device", null, "Specify the private bridge on host for 
private network", null),
OvmGuestNetwork("Hidden", ManagementServer.class, String.class, 
"ovm.guest.network.device", null, "Specify the private bridge on host for 
private network", null),

// Ovm3
Ovm3PublicNetwork("Hidden", ManagementServer.class, String.class, 
"ovm3.public.network.device", null, "Specify the public bridge on host for 
public network", null),
Ovm3PrivateNetwork("Hidden", ManagementServer.class, String.class, 
"ovm3.private.network.device", null, "Specify the private bridge on host for 
private network", null),
Ovm3GuestNetwork("Hidden", ManagementServer.class, String.class, 
"ovm3.guest.network.device", null, "Specify the guest bridge on host for guest 
network", null),
Ovm3StorageNetwork("Hidden", ManagementServer.class, String.class, 
"ovm3.storage.network.device", null, "Specify the storage bridge on host for 
storage network", null),
Ovm3HeartBeatTimeout(
"Advanced",
ManagementServer.class,
Integer.class,
"ovm3.heartbeat.timeout",
"120",
"timeout used for primary storage check, upon timeout a panic is 
triggered.",
null),
Ovm3HeartBeatInterval(
"Advanced",
ManagementServer.class,
Integer.class,
"ovm3.heartbeat.interval",
"1",
"interval used to check primary storage availability.",
null),


Only two have default values the rest have default value as NULL. The db values 
are only created for those config variables whose default value is not NULL.

ie: ovm3.heartbeat.interval, ovm3.heartbeat.timeout are in configuration table 
while the ones nodd by Luc are missing:
   
ovm3.guest.network.device  
ovm3.private.network.device
ovm3.public.network.device 
ovm3.storage.network.device   





> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[Pierre-Luc Dion (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513772#comment-15513772
 ] 

Pierre-Luc Dion commented on CLOUDSTACK-9489:
-

Hi,
Here is the configuration table diff from a fresh 4.7 and my 4.4 upgraded to 4.7
Those settings are missing from my upgraded environment:
{code}
baremetal.internal.storage.server.ip   
baremetal.provision.done.notification.enabled  
baremetal.provision.done.notification.port 
baremetal.provision.done.notification.timeout  
enable.secure.session.cookie   
ovm3.guest.network.device  
ovm3.private.network.device
ovm3.public.network.device 
ovm3.storage.network.device
publish.action.events  
publish.alert.events   
publish.async.job.events   
publish.resource.state.events  
publish.usage.events   
xenserver.heartbeat.timeout 
{code}

Those settings are defined and created in the Java.config file and not from a 
.sql file.  I did test changing the init settings to false but this seams to 
reset the encryption of the database so login is not working anymore after the 
restart of the management server.

> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[Abhinandan Prateek (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502897#comment-15502897
 ] 

Abhinandan Prateek commented on CLOUDSTACK-9489:


I upgraded from 4.5 to 4.9. There are a bunch of 'quota' related config 
variables that were added.
After the upgrade I can see them listed on global config/db. Note that these 
config variable do not have explicit insert statements during upgrade.
Some of these variables are: quota.enable.service, quota.enable.enforcement, 
quota.enable.enforcement etc.

So this is not a generic issue, we need to look for variables that were 
expected and were not found after upgrade to narrow down on cause.

> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Assignee: Abhinandan Prateek
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[John Burwell (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502074#comment-15502074
 ] 

John Burwell commented on CLOUDSTACK-9489:
--

I have upgraded the priority of this defect to 'Blocker' as it represents a 
potential break of upgrades.

> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>Priority: Blocker
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[Pierre-Luc Dion (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464901#comment-15464901
 ] 

Pierre-Luc Dion commented on CLOUDSTACK-9489:
-

I think I've wrongly describe the problem. I've experience the issue while 
upgrading packages (rpm). But the resolution should not be fixed in the code 
itself, not in package description, because the issue can be replicated when 
building CloudStack from source and run it inside Jetty.



> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[Wido den Hollander (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464480#comment-15464480
 ] 

Wido den Hollander commented on CLOUDSTACK-9489:


I don't know why that isn't done there. But I think it should be done there and 
not in the packaging.

> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[John Burwell (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15461291#comment-15461291
 ] 

John Burwell commented on CLOUDSTACK-9489:
--

[~pdion] Requiring a database to running and properly configured as part of 
package post-installation is against best packaging practices for both Debian 
and Red Hat/Fedora.  If we were to change this value, it seems more appropriate 
to do it as part of the DatabaseUpgradeChecker.

[~rohit.ya...@shapeblue.com] [~widodh] do you know of any reason why we don't 
set this value as part of the database upgrade?

> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9489) When upgrading, Config.java new configuration are not updated.

[Pierre-Luc Dion (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458890#comment-15458890
 ] 

Pierre-Luc Dion commented on CLOUDSTACK-9489:
-

When Upgrading CloudStack to apply changes from Config.java, we need to set 
configuration::init to false

Prior to start CloudStack management server after upgrading is packages, we 
must change the init value:
in MySQL database:
{code}
use cloud;
update configuration set value='false' where name='init';
{code}

> When upgrading, Config.java new configuration are not updated.
> --
>
> Key: CLOUDSTACK-9489
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>Reporter: Pierre-Luc Dion
>
> When Upgrading CloudStack, new configurations (Global Settings) defined in  
> {{server/src/com/cloud/configuration/Config.java}} are not populated.
> This file changed in 4.5 and 4.6 and those configurations are not applied 
> when upgrading to post 4.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)