[GitHub] [commons-vfs] MaxKellermann commented on pull request #154: Rework SoftRefFilesCache locking
MaxKellermann commented on pull request #154: URL: https://github.com/apache/commons-vfs/pull/154#issuecomment-774418907 > Given that the Loom project will likely have issues with `synchronized` in its first iterations What kind of problems are caused by `synchronized`? I'm not a Java expert, I'm curious, I thought that was the first-class synchronization feature that always "just works", and you only need stuff like `ReentrantLock` when you need special features. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] arturobernalg commented on a change in pull request #72: Minor Improvement:
arturobernalg commented on a change in pull request #72:
URL: https://github.com/apache/commons-net/pull/72#discussion_r571367504
##
File path: src/main/java/org/apache/commons/net/util/NetConstants.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.net.util;
+
+/**
+ *
+ * An constant class providing functionality related to the {@code
+ * apache.commons.net} package.
+ *
+ *
+ * @since 3.7
+ */
+public class NetConstants {
+
+/**
+ * An empty immutable {@code String} array.
+ */
+public static final String[] EMPTY_STRING_ARRAY = new String[0];
+/**
+ * Private constructor so that no instances can be created. This class
+ * contains only static utility methods and constant.
Review comment:
Changed
##
File path: src/main/java/org/apache/commons/net/util/NetConstants.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.net.util;
+
+/**
+ *
+ * An constant class providing functionality related to the {@code
+ * apache.commons.net} package.
+ *
+ *
+ * @since 3.7
Review comment:
Changed
##
File path: src/main/java/org/apache/commons/net/util/NetConstants.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.net.util;
+
+/**
+ *
+ * An constant class providing functionality related to the {@code
+ * apache.commons.net} package.
Review comment:
Changed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-daemon] garydgregory merged pull request #22: Minor Improvements
garydgregory merged pull request #22: URL: https://github.com/apache/commons-daemon/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #709: Implement StopWatch lap
coveralls commented on pull request #709: URL: https://github.com/apache/commons-lang/pull/709#issuecomment-774348545 [](https://coveralls.io/builds/36914682) Coverage increased (+0.003%) to 94.978% when pulling **2b828299022c7f4f88cea54fabf2e05d53c3986e on michaldo:master** into **a1495290b931856840bf358dbfd551639081d227 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] efge commented on pull request #154: Rework SoftRefFilesCache locking
efge commented on pull request #154: URL: https://github.com/apache/commons-vfs/pull/154#issuecomment-774342799 Given that the Loom project will likely have issues with `synchronized` in its first iterations, I would not include the last commit switching from locks to synchronized. Otherwise the cleanups look good. I totally sympathise with @garydgregory about the lack of test, but also with @MaxKellermann in that writing tests that exercise thread-safety issues is a PITA. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] efge commented on a change in pull request #154: Rework SoftRefFilesCache locking
efge commented on a change in pull request #154:
URL: https://github.com/apache/commons-vfs/pull/154#discussion_r571304065
##
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/cache/SoftRefFilesCache.java
##
@@ -290,6 +286,9 @@ private boolean removeFile(final FileSystemAndNameKey key) {
return files.isEmpty();
}
+/**
+ * Called while the lock is held
+ */
protected Map>
getOrCreateFilesystemCache(final FileSystem fileSystem) {
Review comment:
Could you make this `private` so that it's consistent with all the other
methods that are "called while the lock is held"?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] michaldo commented on pull request #709: Implement StopWatch lap
michaldo commented on pull request #709: URL: https://github.com/apache/commons-lang/pull/709#issuecomment-774331817 BTW, split has a bug: if stop watch is suspended and resumed, startTimeNanos is moved forward but stopTimeNanos not. For example: ``` watch.start() watch.split() watch.suspend() sleep(100ms) watch.resume() watch.getSplitTime() // -100 ``` IMHO split is overengineering. Instead of `split()->getSplitTime()->unsplit()` I can just call `watch.getTime()` when I need. I suggest delete split functionality at all. BTW2, I suggest also drop `reset`, because buying brand new StopWatch cost nothing. BTW3, I suggest also drop a `stop`, because when StopWatch is done, caller just calls `watch.getTime()` and does not care StopWatch anymore. There is no battery nor thread inside the StopWatch, and `stop` is not needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] michaldo opened a new pull request #709: Implement StopWatch lap
michaldo opened a new pull request #709: URL: https://github.com/apache/commons-lang/pull/709 Example: StopWatch watch = StopWatch.createStarted(); sleep(30ms) watch.lap() // returns 30 sleep(10ms) watch.lap() // returns 10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] kinow closed pull request #33: Bump spotbugs-maven-plugin from 4.1.4 to 4.2.0
kinow closed pull request #33: URL: https://github.com/apache/commons-release-plugin/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] dependabot[bot] commented on pull request #33: Bump spotbugs-maven-plugin from 4.1.4 to 4.2.0
dependabot[bot] commented on pull request #33: URL: https://github.com/apache/commons-release-plugin/pull/33#issuecomment-774315693 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] dependabot[bot] commented on pull request #213: Bump commons.junit.version from 5.7.0 to 5.7.1
dependabot[bot] commented on pull request #213: URL: https://github.com/apache/commons-collections/pull/213#issuecomment-774313600 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] kinow closed pull request #213: Bump commons.junit.version from 5.7.0 to 5.7.1
kinow closed pull request #213: URL: https://github.com/apache/commons-collections/pull/213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] dependabot[bot] commented on pull request #37: Bump spotbugs from 4.2.0 to 4.2.1
dependabot[bot] commented on pull request #37: URL: https://github.com/apache/commons-release-plugin/pull/37#issuecomment-774312248 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] kinow closed pull request #37: Bump spotbugs from 4.2.0 to 4.2.1
kinow closed pull request #37: URL: https://github.com/apache/commons-release-plugin/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] dependabot[bot] commented on pull request #118: Bump spotbugs from 4.2.0 to 4.2.1
dependabot[bot] commented on pull request #118: URL: https://github.com/apache/commons-imaging/pull/118#issuecomment-774308572 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow closed pull request #118: Bump spotbugs from 4.2.0 to 4.2.1
kinow closed pull request #118: URL: https://github.com/apache/commons-imaging/pull/118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow commented on pull request #118: Bump spotbugs from 4.2.0 to 4.2.1
kinow commented on pull request #118: URL: https://github.com/apache/commons-imaging/pull/118#issuecomment-774304528 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] dependabot[bot] commented on pull request #119: Bump junit-jupiter from 5.7.0 to 5.7.1
dependabot[bot] commented on pull request #119: URL: https://github.com/apache/commons-imaging/pull/119#issuecomment-774304277 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow closed pull request #119: Bump junit-jupiter from 5.7.0 to 5.7.1
kinow closed pull request #119: URL: https://github.com/apache/commons-imaging/pull/119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow commented on pull request #119: Bump junit-jupiter from 5.7.0 to 5.7.1
kinow commented on pull request #119: URL: https://github.com/apache/commons-imaging/pull/119#issuecomment-774304261 Merged This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #117: VFS-782 - Pass correct proxy authentication credentials
garydgregory commented on pull request #117: URL: https://github.com/apache/commons-vfs/pull/117#issuecomment-774302165 I pushed the tests portion of this PR to git master since they do test the code, but not the main change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-daemon] garydgregory commented on a change in pull request #22: Minor Improvement:
garydgregory commented on a change in pull request #22:
URL: https://github.com/apache/commons-daemon/pull/22#discussion_r571251558
##
File path: src/test/java/org/apache/commons/daemon/SimpleDaemon.java
##
@@ -28,18 +28,18 @@
*/
public class SimpleDaemon implements Daemon, Runnable, DaemonUserSignal {
-private ServerSocket server=null;
-private Thread thread=null;
-private DaemonController controller=null;
-private volatile boolean stopping=false;
-private String directory=null;
-private Vector handlers=null;
+private ServerSocket server;
+private Thread thread;
+private DaemonController controller;
+private volatile boolean stopping;
+private String directory;
+private final Vector HANDLERS;
private boolean softReloadSignalled;
public SimpleDaemon() {
System.err.println("SimpleDaemon: instance "+this.hashCode()+
" created");
-this.handlers=new Vector();
+this.HANDLERS =new Vector();
Review comment:
It is still upper case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-daemon] arturobernalg commented on a change in pull request #22: Minor Improvement:
arturobernalg commented on a change in pull request #22:
URL: https://github.com/apache/commons-daemon/pull/22#discussion_r571240224
##
File path: src/test/java/org/apache/commons/daemon/SimpleDaemon.java
##
@@ -28,18 +28,18 @@
*/
public class SimpleDaemon implements Daemon, Runnable, DaemonUserSignal {
-private ServerSocket server=null;
-private Thread thread=null;
-private DaemonController controller=null;
-private volatile boolean stopping=false;
-private String directory=null;
-private Vector handlers=null;
+private ServerSocket server;
+private Thread thread;
+private DaemonController controller;
+private volatile boolean stopping;
+private String directory;
+private final Vector HANDLERS;
private boolean softReloadSignalled;
public SimpleDaemon() {
System.err.println("SimpleDaemon: instance "+this.hashCode()+
" created");
-this.handlers=new Vector();
+this.HANDLERS =new Vector();
Review comment:
changed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on a change in pull request #72: Minor Improvement:
garydgregory commented on a change in pull request #72:
URL: https://github.com/apache/commons-net/pull/72#discussion_r571232271
##
File path: src/main/java/org/apache/commons/net/util/NetConstants.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.net.util;
+
+/**
+ *
+ * An constant class providing functionality related to the {@code
+ * apache.commons.net} package.
Review comment:
Package name is wrong and this is not just for this package. Since this
class is only public for access from other packages, we could/should only say
"Constants provided as public only for our own implementation, you can consider
this private for now."
##
File path: src/main/java/org/apache/commons/net/util/NetConstants.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.net.util;
+
+/**
+ *
+ * An constant class providing functionality related to the {@code
+ * apache.commons.net} package.
+ *
+ *
+ * @since 3.7
+ */
+public class NetConstants {
+
+/**
+ * An empty immutable {@code String} array.
+ */
+public static final String[] EMPTY_STRING_ARRAY = new String[0];
+/**
+ * Private constructor so that no instances can be created. This class
+ * contains only static utility methods and constant.
Review comment:
Fix comment, there are no methods in this class. All that the comment
needs to say is "Prevents instantiation." IMO.
##
File path: src/main/java/org/apache/commons/net/util/NetConstants.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.net.util;
+
+/**
+ *
+ * An constant class providing functionality related to the {@code
+ * apache.commons.net} package.
+ *
+ *
+ * @since 3.7
Review comment:
The since tag is wrong, pom.xml currently has 3.7.3 as the next version,
but, since this is a new public element, we could bump the version up to 3.8.0.
Let's keep 3.7.3 since this is just a constant that happens to be public for
internal convenience.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-codec] boris-github commented on a change in pull request #35: [CODEC-280] Added strict decoding property to BaseNCodec.
boris-github commented on a change in pull request #35:
URL: https://github.com/apache/commons-codec/pull/35#discussion_r571224495
##
File path: src/main/java/org/apache/commons/codec/binary/BaseNCodec.java
##
@@ -223,6 +230,47 @@ protected BaseNCodec(final int unencodedBlockSize, final
int encodedBlockSize,
this.pad = pad;
}
+/**
+ * Sets the decoding behaviour when the input bytes contain leftover
trailing bits that
+ * cannot be created by a valid encoding. These can be bits that are
unused from the final
+ * character or entire characters. The default mode is lenient decoding.
Set this to
+ * {@code true} to enable strict decoding.
+ *
+ * Lenient: Any trailing bits are composed into 8-bit bytes where
possible.
+ * The remainder are discarded.
+ * Strict: The decoding will raise an {@link IllegalArgumentException}
if trailing bits
+ * are not part of a valid encoding. Any unused bits from the final
character must
+ * be zero. Impossible counts of entire final characters are not
allowed.
+ *
+ *
+ * When strict decoding is enabled it is expected that the decoded
bytes will be re-encoded
+ * to a byte array that matches the original, i.e. no changes occur on the
final
+ * character. This requires that the input bytes use the same padding and
alphabet
+ * as the encoder.
+ *
+ * @param strictDecoding Set to true to enable strict decoding; otherwise
use lenient decoding.
+ * @see #encode(byte[])
+ * @since 1.15
+ */
+public void setStrictDecoding(boolean strictDecoding) {
Review comment:
Oh, I see why. Browsing the history of the file, I found that it was
modified in [Reimplement the new-in-1.15 BaseNCodec's and friends' strict vs.
lenient](https://github.com/apache/commons-codec/commit/9f1b740a17f0d54366edfb45df0636b8e302666a#diff-2cf424122556d939f7804a29ae0c501d22e744e725c1a239efd0bf687ccd7402).
Sadly the [release
notes](https://commons.apache.org/proper/commons-codec/changes-report.html#a1.15)
haven't been updated to reflect that.
(cost me 2 hours)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NET-695) Apply SocketClient timeout after connection but before SSL negotiation
[
https://issues.apache.org/jira/browse/NET-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279966#comment-17279966
]
Cott Lang commented on NET-695:
---
I've had this in production for several weeks, but as is normally the case, the
problem hasn't occurred again. :)
If I confirm it works, I will update this ticket.
Thanks!
> Apply SocketClient timeout after connection but before SSL negotiation
> --
>
> Key: NET-695
> URL: https://issues.apache.org/jira/browse/NET-695
> Project: Commons Net
> Issue Type: Bug
> Components: FTP, POP3, SMTP
>Reporter: Gary D. Gregory
>Assignee: Gary D. Gregory
>Priority: Major
>
> Apply SocketClient timeout after connection but before SSL negotiation.
> Note that this is is a different timeout from the connect timeout.
> This applies to the following {{SocketClient}} subclasses:
> - {{FTPSClient}}; see also [https://github.com/apache/commons-net/pull/70]
> - {{POP3SClient}}
> - {{SMTPSClient}}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NET-695) Apply SocketClient timeout after connection but before SSL negotiation
[
https://issues.apache.org/jira/browse/NET-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279959#comment-17279959
]
Gary D. Gregory commented on NET-695:
-
May you please confirm that a 3.7.3-SNAPSHOT build fixes your use case?
> Apply SocketClient timeout after connection but before SSL negotiation
> --
>
> Key: NET-695
> URL: https://issues.apache.org/jira/browse/NET-695
> Project: Commons Net
> Issue Type: Bug
> Components: FTP, POP3, SMTP
>Reporter: Gary D. Gregory
>Assignee: Gary D. Gregory
>Priority: Major
>
> Apply SocketClient timeout after connection but before SSL negotiation.
> Note that this is is a different timeout from the connect timeout.
> This applies to the following {{SocketClient}} subclasses:
> - {{FTPSClient}}; see also [https://github.com/apache/commons-net/pull/70]
> - {{POP3SClient}}
> - {{SMTPSClient}}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NET-695) Apply SocketClient timeout after connection but before SSL negotiation
[
https://issues.apache.org/jira/browse/NET-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279957#comment-17279957
]
Gary D. Gregory commented on NET-695:
-
I'm looking into doing a release... within a week or so... maybe.
> Apply SocketClient timeout after connection but before SSL negotiation
> --
>
> Key: NET-695
> URL: https://issues.apache.org/jira/browse/NET-695
> Project: Commons Net
> Issue Type: Bug
> Components: FTP, POP3, SMTP
>Reporter: Gary D. Gregory
>Assignee: Gary D. Gregory
>Priority: Major
>
> Apply SocketClient timeout after connection but before SSL negotiation.
> Note that this is is a different timeout from the connect timeout.
> This applies to the following {{SocketClient}} subclasses:
> - {{FTPSClient}}; see also [https://github.com/apache/commons-net/pull/70]
> - {{POP3SClient}}
> - {{SMTPSClient}}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-codec] boris-github commented on a change in pull request #35: [CODEC-280] Added strict decoding property to BaseNCodec.
boris-github commented on a change in pull request #35:
URL: https://github.com/apache/commons-codec/pull/35#discussion_r571215936
##
File path: src/main/java/org/apache/commons/codec/binary/BaseNCodec.java
##
@@ -223,6 +230,47 @@ protected BaseNCodec(final int unencodedBlockSize, final
int encodedBlockSize,
this.pad = pad;
}
+/**
+ * Sets the decoding behaviour when the input bytes contain leftover
trailing bits that
+ * cannot be created by a valid encoding. These can be bits that are
unused from the final
+ * character or entire characters. The default mode is lenient decoding.
Set this to
+ * {@code true} to enable strict decoding.
+ *
+ * Lenient: Any trailing bits are composed into 8-bit bytes where
possible.
+ * The remainder are discarded.
+ * Strict: The decoding will raise an {@link IllegalArgumentException}
if trailing bits
+ * are not part of a valid encoding. Any unused bits from the final
character must
+ * be zero. Impossible counts of entire final characters are not
allowed.
+ *
+ *
+ * When strict decoding is enabled it is expected that the decoded
bytes will be re-encoded
+ * to a byte array that matches the original, i.e. no changes occur on the
final
+ * character. This requires that the input bytes use the same padding and
alphabet
+ * as the encoder.
+ *
+ * @param strictDecoding Set to true to enable strict decoding; otherwise
use lenient decoding.
+ * @see #encode(byte[])
+ * @since 1.15
+ */
+public void setStrictDecoding(boolean strictDecoding) {
Review comment:
@aherbert looking at the
[BaseNCodec](https://commons.apache.org/proper/commons-codec/archives/1.15/apidocs/org/apache/commons/codec/binary/BaseNCodec.html)
Javadoc I can't find the **setStrictDecoding()** method, however
**isStrictDecoding()** is available. Can you please double check?
And following [your
example](https://issues.apache.org/jira/browse/CODEC-280) for
`codec.setStrictDecoding(true)` I'm getting a compilation error when using
[commons-codec
1.15](https://search.maven.org/artifact/commons-codec/commons-codec/1.15/jar):
```
symbol: method setStrictDecoding(boolean)
location: variable codec of type org.apache.commons.codec.binary.Base32
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (VFS-792) Usage of default mode for "AES" is insecure
[ https://issues.apache.org/jira/browse/VFS-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279929#comment-17279929 ] Gary D. Gregory commented on VFS-792: - Did you read the Javadoc for this class? Gary > Usage of default mode for "AES" is insecure > > > Key: VFS-792 > URL: https://issues.apache.org/jira/browse/VFS-792 > Project: Commons VFS > Issue Type: Improvement >Reporter: Md Mahir Asef Kabir >Priority: Major > > In file > [https://github.com/apache/commons-vfs/blob/bd1ed002b0fb0f43505adc469479eb11e9bf731a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/DefaultCryptor.java] > (at Line 61), the default "AES" algorithm has been used which imposes > insecure "ECB" mode. > *Security Impact*: > ECB mode allows the attacker to do the following - > detect whether two ECB-encrypted messages are identical; > detect whether two ECB-encrypted messages share a common prefix; > detect whether two ECB-encrypted messages share other common substrings, as > long as those substrings are aligned at block boundaries; or > detect whether (and where) a single ECB-encrypted message contains > repetitive data (such as long runs of spaces or null bytes, repeated header > fields, or coincidentally repeated phrases in the text). - Collected from > [here|https://crypto.stackexchange.com/questions/20941/why-shouldnt-i-use-ecb-encryption#:~:text=The%20main%20reason%20not%20to,will%20leak%20to%20some%20extent).] > *Useful Resources*: > [https://blog.filippo.io/the-ecb-penguin/] > *Solution we suggest*: > Use GCM mode instead of default or ECB mode. > *Please share with us your opinions/comments if there is any*: > Is the bug report helpful? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-daemon] garydgregory commented on a change in pull request #22: Minor Improvement:
garydgregory commented on a change in pull request #22:
URL: https://github.com/apache/commons-daemon/pull/22#discussion_r571192372
##
File path: src/test/java/org/apache/commons/daemon/SimpleDaemon.java
##
@@ -28,18 +28,18 @@
*/
public class SimpleDaemon implements Daemon, Runnable, DaemonUserSignal {
-private ServerSocket server=null;
-private Thread thread=null;
-private DaemonController controller=null;
-private volatile boolean stopping=false;
-private String directory=null;
-private Vector handlers=null;
+private ServerSocket server;
+private Thread thread;
+private DaemonController controller;
+private volatile boolean stopping;
+private String directory;
+private final Vector HANDLERS;
private boolean softReloadSignalled;
public SimpleDaemon() {
System.err.println("SimpleDaemon: instance "+this.hashCode()+
" created");
-this.handlers=new Vector();
+this.HANDLERS =new Vector();
Review comment:
Why is this upper case?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-daemon] garydgregory commented on a change in pull request #23: Fix for https://issues.apache.org/jira/browse/DAEMON-314
garydgregory commented on a change in pull request #23:
URL: https://github.com/apache/commons-daemon/pull/23#discussion_r571186576
##
File path: src/native/windows/src/service.c
##
@@ -575,6 +575,57 @@ apxServiceControl(APXHANDLE hService, DWORD dwControl,
UINT uMsg,
return FALSE;
}
+BOOL
+apxServiceCheckStop(APXHANDLE hService)
+{
+LPAPXSERVICE lpService;
+SERVICE_STATUS stStatus;
+DWORD dwState = SERVICE_STOPPED;
+DWORD sleepMillis;
+
+if (hService->dwType != APXHANDLE_TYPE_SERVICE)
+return FALSE;
+
+lpService = APXHANDLE_DATA(hService);
+/* Manager mode cannot handle services */
+if (lpService->bManagerMode) {
+apxLogWrite(APXLOG_MARK_ERROR "apxServiceCheck(): Manager mode cannot
handle services, returning FALSE");
+return FALSE;
+}
+/* Check if the ServiceOpen has been called */
+if (IS_INVALID_HANDLE(lpService->hService)) {
+apxLogWrite(APXLOG_MARK_ERROR "apxServiceCheck(): Service is not open,
returning FALSE");
+return FALSE;
+}
+
+/* Check if we are in the stopped state */
+sleepMillis = 1000;
+apxLogWrite(APXLOG_MARK_DEBUG "apxServiceCheck(): Sleeping %d
milliseconds", sleepMillis);
+Sleep(sleepMillis);
+
+if (QueryServiceStatus(lpService->hService, )) {
+apxLogWrite(APXLOG_MARK_DEBUG "apxServiceCheck(): QueryServiceStatus
OK");
+if (stStatus.dwCurrentState == dwState) {
+return TRUE;
+} else {
+apxLogWrite(APXLOG_MARK_DEBUG
Review comment:
We have an API that does this kind of logging in prunsrv, refactor and
reuse?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-daemon] garydgregory commented on a change in pull request #23: Fix for https://issues.apache.org/jira/browse/DAEMON-314
garydgregory commented on a change in pull request #23: URL: https://github.com/apache/commons-daemon/pull/23#discussion_r571185640 ## File path: src/native/windows/src/service.c ## @@ -575,6 +575,57 @@ apxServiceControl(APXHANDLE hService, DWORD dwControl, UINT uMsg, return FALSE; } +BOOL Review comment: A comment here would be better. Think of folks reading the code in the future ;-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-daemon] jfclere opened a new pull request #23: Fix for https://issues.apache.org/jira/browse/DAEMON-314
jfclere opened a new pull request #23: URL: https://github.com/apache/commons-daemon/pull/23 https://github.com/apache/commons-daemon/commit/5bca7af78162fbdd2d2f4b6b95470b29d15039a8 was the first part of fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-daemon] arturobernalg commented on a change in pull request #22: Minor Improvement:
arturobernalg commented on a change in pull request #22:
URL: https://github.com/apache/commons-daemon/pull/22#discussion_r571081927
##
File path: src/main/java/org/apache/commons/daemon/support/DaemonWrapper.java
##
@@ -40,12 +40,17 @@
private final static String STOP_CLASS = "stop";
private final static String STOP_METHOD = "stop.method";
private final static String STOP_ARGS = "stop.args";
-private String configFileName = null;
+private String configFileName;
private final DaemonConfiguration config;
private final Invoker startup;
private final Invoker shutdown;
+/**
+ * An empty immutable {@code String} array.
Review comment:
Changed
##
File path:
src/main/java/org/apache/commons/daemon/support/DaemonConfiguration.java
##
@@ -62,6 +62,11 @@
private final Properties configurationProperties;
private final Properties systemProperties;
+/**
+ * An empty immutable {@code String} array.
+ */
Review comment:
Changed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #157: Solve the problem of download huge file
garydgregory commented on pull request #157: URL: https://github.com/apache/commons-vfs/pull/157#issuecomment-774104989 @xiaqingyun Please see git master for a slightly different way to provide this feature. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-daemon] garydgregory commented on pull request #22: Minor Improvement:
garydgregory commented on pull request #22: URL: https://github.com/apache/commons-daemon/pull/22#issuecomment-774094303 Also please rebase on master to pick up the GitHub build addition. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (VFS-792) Usage of default mode for "AES" is insecure
Md Mahir Asef Kabir created VFS-792: --- Summary: Usage of default mode for "AES" is insecure Key: VFS-792 URL: https://issues.apache.org/jira/browse/VFS-792 Project: Commons VFS Issue Type: Improvement Reporter: Md Mahir Asef Kabir In file [https://github.com/apache/commons-vfs/blob/bd1ed002b0fb0f43505adc469479eb11e9bf731a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/DefaultCryptor.java] (at Line 61), the default "AES" algorithm has been used which imposes insecure "ECB" mode. *Security Impact*: ECB mode allows the attacker to do the following - detect whether two ECB-encrypted messages are identical; detect whether two ECB-encrypted messages share a common prefix; detect whether two ECB-encrypted messages share other common substrings, as long as those substrings are aligned at block boundaries; or detect whether (and where) a single ECB-encrypted message contains repetitive data (such as long runs of spaces or null bytes, repeated header fields, or coincidentally repeated phrases in the text). - Collected from [here|https://crypto.stackexchange.com/questions/20941/why-shouldnt-i-use-ecb-encryption#:~:text=The%20main%20reason%20not%20to,will%20leak%20to%20some%20extent).] *Useful Resources*: [https://blog.filippo.io/the-ecb-penguin/] *Solution we suggest*: Use GCM mode instead of default or ECB mode. *Please share with us your opinions/comments if there is any*: Is the bug report helpful? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Deleted] (COLLECTIONS-782) add http status code 509 Bandwidth Limit Exceeded (Unofficial code)
[ https://issues.apache.org/jira/browse/COLLECTIONS-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory deleted COLLECTIONS-782: > add http status code 509 Bandwidth Limit Exceeded (Unofficial code) > --- > > Key: COLLECTIONS-782 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-782 > Project: Commons Collections > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Minor > > * 509 Bandwidth Limit Exceeded > Currently, the HTTP Status code list doesn't include this codes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-daemon] garydgregory commented on a change in pull request #22: Minor Improvement:
garydgregory commented on a change in pull request #22:
URL: https://github.com/apache/commons-daemon/pull/22#discussion_r571033303
##
File path:
src/main/java/org/apache/commons/daemon/support/DaemonConfiguration.java
##
@@ -62,6 +62,11 @@
private final Properties configurationProperties;
private final Properties systemProperties;
+/**
+ * An empty immutable {@code String} array.
+ */
Review comment:
This does not need to be public. You could define ONE constant to be
package private and reuse it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-daemon] garydgregory commented on a change in pull request #22: Minor Improvement:
garydgregory commented on a change in pull request #22:
URL: https://github.com/apache/commons-daemon/pull/22#discussion_r571032801
##
File path: src/main/java/org/apache/commons/daemon/support/DaemonWrapper.java
##
@@ -40,12 +40,17 @@
private final static String STOP_CLASS = "stop";
private final static String STOP_METHOD = "stop.method";
private final static String STOP_ARGS = "stop.args";
-private String configFileName = null;
+private String configFileName;
private final DaemonConfiguration config;
private final Invoker startup;
private final Invoker shutdown;
+/**
+ * An empty immutable {@code String} array.
Review comment:
This does not need to be public does it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (COLLECTIONS-782) add http status code 509 Bandwidth Limit Exceeded (Unofficial code)
[ https://issues.apache.org/jira/browse/COLLECTIONS-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279738#comment-17279738 ] Arturo Bernal commented on COLLECTIONS-782: --- Hi [~ggregory1] . Nothings. Mi mistake. ;-) Sorry > add http status code 509 Bandwidth Limit Exceeded (Unofficial code) > --- > > Key: COLLECTIONS-782 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-782 > Project: Commons Collections > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Minor > > * 509 Bandwidth Limit Exceeded > Currently, the HTTP Status code list doesn't include this codes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-daemon] garydgregory merged pull request #20: Enable Dependabot
garydgregory merged pull request #20: URL: https://github.com/apache/commons-daemon/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory closed pull request #36: Made some variable names more consistent with the other parts.
garydgregory closed pull request #36: URL: https://github.com/apache/commons-bcel/pull/36 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on pull request #36: Made some variable names more consistent with the other parts.
garydgregory commented on pull request #36: URL: https://github.com/apache/commons-bcel/pull/36#issuecomment-774085065 No action, closing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory merged pull request #78: Bump junit-jupiter from 5.7.0 to 5.7.1
garydgregory merged pull request #78: URL: https://github.com/apache/commons-bcel/pull/78 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on a change in pull request #76: Minor Improvements:
garydgregory commented on a change in pull request #76:
URL: https://github.com/apache/commons-bcel/pull/76#discussion_r571025073
##
File path: src/main/java/org/apache/bcel/classfile/Utility.java
##
@@ -831,7 +831,7 @@ public static String signatureToString( final String
signature, final boolean ch
// Could be Class or Type...
type = typeSignatureToString(signature.substring(index), chopit);
index += unwrap(CONSUMER_CHARS); // update position
-if ((typeParams.isEmpty()) && (index == signature.length())) {
+if ((typeParams.length() == 0) && (index == signature.length())) {
Review comment:
-1: Don't in-line `isEmpty()` calls.
##
File path: src/main/java/org/apache/bcel/classfile/Utility.java
##
@@ -1014,71 +1014,71 @@ public static String typeSignatureToString( final
String signature, final boolea
// we have TypeArguments; build up partial result
// as we recurse for each TypeArgument
final StringBuilder type = new
StringBuilder(compactClassName(signature.substring(1, bracketIndex),
chopit)).append("<");
-int consumed_chars = bracketIndex + 1; // Shadows global
var
+int CONSUMER_CHARS = bracketIndex + 1; // Shadows global
var
Review comment:
-1: don't upper case local vars.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (COLLECTIONS-782) add http status code 509 Bandwidth Limit Exceeded (Unofficial code)
[ https://issues.apache.org/jira/browse/COLLECTIONS-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279732#comment-17279732 ] Gary D. Gregory commented on COLLECTIONS-782: - [~arturobernalg] What does this have to do with Collections? > add http status code 509 Bandwidth Limit Exceeded (Unofficial code) > --- > > Key: COLLECTIONS-782 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-782 > Project: Commons Collections > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Minor > > * 509 Bandwidth Limit Exceeded > Currently, the HTTP Status code list doesn't include this codes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (DAEMON-430) prunsrv stop timeout not honored
Jean-Frederic Clere created DAEMON-430: -- Summary: prunsrv stop timeout not honored Key: DAEMON-430 URL: https://issues.apache.org/jira/browse/DAEMON-430 Project: Commons Daemon Issue Type: Bug Components: Procrun Affects Versions: 1.2.3 Reporter: Jean-Frederic Clere Assignee: Jean-Frederic Clere Fix For: 1.2.4 >From [procrun|https://commons.apache.org/proper/commons-daemon/procrun.html] , >--StopTimeout can be used to define the time that procrun waits for service to >exit. But it waits forever even setting --StopTimeout when apxServiceControl(SERVICE_CONTROL_STOP) hangs. 1105apxLogWrite(APXLOG_MARK_DEBUG "Waiting for stop worker to finish..."); 1106apxHandleWait(hWorker, INFINITE, FALSE); 1107apxLogWrite(APXLOG_MARK_DEBUG "Stop worker finished."); -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (DAEMON-314) [daemon] feature request: jsvc stop with force option
[ https://issues.apache.org/jira/browse/DAEMON-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Frederic Clere updated DAEMON-314: --- Comment: was deleted (was: According to my tests that it is probably due to INFINITE time-out on the stop command (–StopTimeout n is ignored in serviceStop() for both waiting for JNI and the external stop process).) > [daemon] feature request: jsvc stop with force option > - > > Key: DAEMON-314 > URL: https://issues.apache.org/jira/browse/DAEMON-314 > Project: Commons Daemon > Issue Type: New Feature > Components: Jsvc >Reporter: Jungtaek Lim >Assignee: Jean-Frederic Clere >Priority: Major > > I have been used Apache Commons Daemon, and jsvc in product. > If we stop processes with "jsvc stop", sometimes process doesn't shutdown. > I think it's more beautiful to let parent process to force shutdown child > process than kill parent process and child process manually. > Does it make sense and is it possible? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-release-plugin] coveralls commented on pull request #37: Bump spotbugs from 4.2.0 to 4.2.1
coveralls commented on pull request #37: URL: https://github.com/apache/commons-release-plugin/pull/37#issuecomment-773807172 [](https://coveralls.io/builds/36890364) Coverage remained the same at 75.124% when pulling **09f47d6ef88160a1ae32487c4266c5f0f663d485 on dependabot/maven/com.github.spotbugs-spotbugs-4.2.1** into **9be7e02774673cf89d5ef5bfe60e5d6bf15b4ece on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory merged pull request #77: Bump maven-checkstyle-plugin from 3.1.1 to 3.1.2
garydgregory merged pull request #77: URL: https://github.com/apache/commons-bcel/pull/77 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] coveralls commented on pull request #119: Bump junit-jupiter from 5.7.0 to 5.7.1
coveralls commented on pull request #119: URL: https://github.com/apache/commons-imaging/pull/119#issuecomment-773806697 [](https://coveralls.io/builds/36890302) Coverage remained the same at 76.445% when pulling **ff527abb92772202e54d2f8320a1a27d1add6229 on dependabot/maven/org.junit.jupiter-junit-jupiter-5.7.1** into **11ff1d6d23fc2f10b00053c0939c08f6377a5d0e on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] coveralls commented on pull request #55: Bump junit-jupiter from 5.7.0 to 5.7.1
coveralls commented on pull request #55: URL: https://github.com/apache/commons-fileupload/pull/55#issuecomment-773802126 [](https://coveralls.io/builds/36890104) Coverage remained the same at 78.34% when pulling **94757a73c2cbc449390e692112e19692de0582e7 on dependabot/maven/org.junit.jupiter-junit-jupiter-5.7.1** into **9d48c8ebcfb097e0676fd8467842d9817c59bec7 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-crypto] coveralls commented on pull request #131: Bump junit-bom from 5.7.0 to 5.7.1
coveralls commented on pull request #131: URL: https://github.com/apache/commons-crypto/pull/131#issuecomment-773841978 [](https://coveralls.io/builds/36891799) Coverage remained the same at 83.793% when pulling **f44c6631c9620d319d123f2d23e36c27e9b42b57 on dependabot/maven/org.junit-junit-bom-5.7.1** into **cca4d8d650d7c5397cb2d04053292c46a0903280 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] coveralls commented on pull request #199: Bump spotbugs from 4.2.0 to 4.2.1
coveralls commented on pull request #199: URL: https://github.com/apache/commons-io/pull/199#issuecomment-773811044 [](https://coveralls.io/builds/36890607) Coverage remained the same at 89.24% when pulling **4c01017dc814eeaf21195e3972159776f2457f74 on dependabot/maven/com.github.spotbugs-spotbugs-4.2.1** into **29b70e156f9241b0c3e25896c931d1ef8725ad66 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] coveralls commented on pull request #118: Bump spotbugs from 4.2.0 to 4.2.1
coveralls commented on pull request #118: URL: https://github.com/apache/commons-imaging/pull/118#issuecomment-773806148 [](https://coveralls.io/builds/36890286) Coverage remained the same at 76.445% when pulling **27cd5b4d507b78b3539add16304876c0c45ecf02 on dependabot/maven/com.github.spotbugs-spotbugs-4.2.1** into **11ff1d6d23fc2f10b00053c0939c08f6377a5d0e on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on pull request #76: Minor Improvements:
garydgregory commented on pull request #76: URL: https://github.com/apache/commons-bcel/pull/76#issuecomment-773450583 @arturobernalg May you please rebase? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-build-plugin] dependabot[bot] closed pull request #22: Bump spotbugs from 4.1.3 to 4.2.0
dependabot[bot] closed pull request #22: URL: https://github.com/apache/commons-build-plugin/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #707: Bump junit-bom from 5.7.0 to 5.7.1
coveralls commented on pull request #707: URL: https://github.com/apache/commons-lang/pull/707#issuecomment-773806458 [](https://coveralls.io/builds/36890220) Coverage increased (+0.006%) to 94.981% when pulling **fa35a41bb276288a810402575e0a02e565033e32 on dependabot/maven/org.junit-junit-bom-5.7.1** into **a1495290b931856840bf358dbfd551639081d227 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jexl] henrib merged pull request #40: Bump maven-checkstyle-plugin from 3.1.1 to 3.1.2
henrib merged pull request #40: URL: https://github.com/apache/commons-jexl/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] coveralls commented on pull request #203: Bump spotbugs from 4.2.0 to 4.2.1
coveralls commented on pull request #203: URL: https://github.com/apache/commons-text/pull/203#issuecomment-773807641 [](https://coveralls.io/builds/36890355) Coverage remained the same at 98.682% when pulling **fec2d90cc7a35c0649331e57e3a45ab0ba14a1bb on dependabot/maven/com.github.spotbugs-spotbugs-4.2.1** into **9eaf80cd4ec6264bb589ff6a8ed9cced8564b4c0 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] coveralls commented on pull request #200: Bump junit-bom from 5.7.0 to 5.7.1
coveralls commented on pull request #200: URL: https://github.com/apache/commons-io/pull/200#issuecomment-773812076 [](https://coveralls.io/builds/36890653) Coverage increased (+0.01%) to 89.255% when pulling **0f674fb67e925941e565eb9ebd776210913d0c7e on dependabot/maven/org.junit-junit-bom-5.7.1** into **29b70e156f9241b0c3e25896c931d1ef8725ad66 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #708: Bump spotbugs from 4.2.0 to 4.2.1
coveralls commented on pull request #708: URL: https://github.com/apache/commons-lang/pull/708#issuecomment-773805686 [](https://coveralls.io/builds/36890241) Coverage increased (+0.006%) to 94.981% when pulling **0bad0808b2ab3bdb25e7c9f28738ececd6dd55ea on dependabot/maven/com.github.spotbugs-spotbugs-4.2.1** into **a1495290b931856840bf358dbfd551639081d227 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-pool] coveralls commented on pull request #63: Bump junit-bom from 5.7.0 to 5.7.1
coveralls commented on pull request #63: URL: https://github.com/apache/commons-pool/pull/63#issuecomment-773807554 [](https://coveralls.io/builds/36890398) Coverage remained the same at 84.428% when pulling **8b36eb8746bdf58691bb7ca4dcd656b747179848 on dependabot/maven/org.junit-junit-bom-5.7.1** into **0da5c540983485565f08711bf986e1ea43b162f3 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-pool] coveralls commented on pull request #62: Bump spotbugs from 4.2.0 to 4.2.1
coveralls commented on pull request #62: URL: https://github.com/apache/commons-pool/pull/62#issuecomment-773806950 [](https://coveralls.io/builds/36890351) Coverage increased (+0.03%) to 84.461% when pulling **d8daf075a297445d88cf2cf58cc00bfd1b92bda8 on dependabot/maven/com.github.spotbugs-spotbugs-4.2.1** into **0da5c540983485565f08711bf986e1ea43b162f3 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] arturobernalg commented on pull request #76: Minor Improvements:
arturobernalg commented on pull request #76: URL: https://github.com/apache/commons-bcel/pull/76#issuecomment-773795390 > @arturobernalg > May you please rebase? HI @garydgregory Done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-build-plugin] dependabot[bot] commented on pull request #22: Bump spotbugs from 4.1.3 to 4.2.0
dependabot[bot] commented on pull request #22: URL: https://github.com/apache/commons-build-plugin/pull/22#issuecomment-773801491 Superseded by #24. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] coveralls commented on pull request #204: Bump junit-jupiter from 5.7.0 to 5.7.1
coveralls commented on pull request #204: URL: https://github.com/apache/commons-text/pull/204#issuecomment-773807589 [](https://coveralls.io/builds/36890365) Coverage remained the same at 98.682% when pulling **d3aee52b8641c3f4c7075e81c13386c3d8e0a8fb on dependabot/maven/org.junit.jupiter-junit-jupiter-5.7.1** into **9eaf80cd4ec6264bb589ff6a8ed9cced8564b4c0 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
