[GitHub] [commons-fileupload] coveralls commented on pull request #125: Bump actions/checkout from 2.3.4 to 2.4.0
coveralls commented on pull request #125: URL: https://github.com/apache/commons-fileupload/pull/125#issuecomment-958617571 [](https://coveralls.io/builds/43970729) Coverage remained the same at 77.585% when pulling **c1b2c15139128cee63f20c2f833ffcd1143235cf on dependabot/github_actions/actions/checkout-2.4.0** into **55f485d8436578a3f0b89a753043311e93b3849a on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-geometry] asfgit merged pull request #188: Updating checkstyle and pmd versions
asfgit merged pull request #188: URL: https://github.com/apache/commons-geometry/pull/188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-daemon] dependabot[bot] closed pull request #33: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #33: URL: https://github.com/apache/commons-daemon/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] coveralls commented on pull request #195: Bump actions/checkout from 2.3.5 to 2.4.0
coveralls commented on pull request #195: URL: https://github.com/apache/commons-csv/pull/195#issuecomment-959786931 [](https://coveralls.io/builds/43990986) Coverage remained the same at 98.323% when pulling **33f5c2fb3c2001916b0811848c366aee3dd26fcc on dependabot/github_actions/actions/checkout-2.4.0** into **1e5c7c3181906f2377793763be69dd37a9eba15f on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #227: Bump actions/checkout from 2.3.5 to 2.4.0
coveralls commented on pull request #227: URL: https://github.com/apache/commons-compress/pull/227#issuecomment-958780831 [](https://coveralls.io/builds/43976480) Coverage remained the same at 86.312% when pulling **079ff25f31b4f457a65ad73e5bde2d213bc0a07c on dependabot/github_actions/actions/checkout-2.4.0** into **4246b887ba88dc0b2bc09e92c63fff97381b4a12 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow merged pull request #181: Bump actions/checkout from 2.3.5 to 2.4.0
kinow merged pull request #181: URL: https://github.com/apache/commons-imaging/pull/181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] data443-cboyd commented on pull request #295: Make FileWriterWithEncoding more precisely match its JavaDoc contract
data443-cboyd commented on pull request #295: URL: https://github.com/apache/commons-io/pull/295#issuecomment-958689368 Hi @garydgregory , the pull request has been updated. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] coveralls commented on pull request #98: Bump actions/checkout from 2.3.4 to 2.4.0
coveralls commented on pull request #98: URL: https://github.com/apache/commons-codec/pull/98#issuecomment-960125760 [](https://coveralls.io/builds/43997040) Coverage remained the same at 94.682% when pulling **098f04f7f1abd5d726e49c4734dc2e711ef18b9e on dependabot/github_actions/actions/checkout-2.4.0** into **20797f43c980cde307aea654ad3d3b9d7d24094c on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-159) There should be a Parameters class
[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=676032=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-676032
]
ASF GitHub Bot logged work on IMAGING-159:
--
Author: ASF GitHub Bot
Created on: 04/Nov/21 01:52
Start Date: 04/Nov/21 01:52
Worklog Time Spent: 10m
Work Description: darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-959156762
I just had another thought on this: it strikes me that the main issue with
the generic `ImagerParser` format is how to deal
with format-agnostic code, mainly the utility methods in `Imaging`. In other
words, how do users specify parameters when they don't even know what the
format is? The current approach is to have users pass in their own parameters
objects to these utility methods but this gets into the problem of what happens
when they pass the wrong parameters type. What if we flipped this? Instead of
having the users create the parameters object, we have the parser create one
and then have the user modify it as needed in a callback. So, instead of this
```
public static byte[] getICCProfileBytes(final File file, final
ImagingParameters params) {
// hopefully params is of the correct type!
}
```
we do this
```
public static byte[] getICCProfileBytes(final File file, final
Consumer configurer) {
ImageParser parser = ...; // get the parser
return getICCProfileBytes(parser, configurer);
}
private static byte[] getICCProfileBytes(final
ImageParser parser, final Consumer configurer) {
P params = parser.getDefaultParameters();
if (configurer != null) {
// let the caller configure the parameters
configurer.accept(params);
}
// params is known to be the correct type
return parser.getICCProfileBytes(params);
}
```
Users would then call it like this:
```
Imaging.getICCProfileBytes(file, p -> p.setStrict(true));
```
We could also add methods to `ImageParser` that accept consumers like this
for consistency. That would probably be best.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 676032)
Time Spent: 12h 40m (was: 12.5h)
> There should be a Parameters class
> --
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
>Affects Versions: 1.0-alpha2
>Reporter: Benedikt Ritter
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Labels: github
> Fix For: 1.0-alpha3
>
> Time Spent: 12h 40m
> Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides
> additional methods like {{public int getInt(String key)}}. The implementation
> could then look up the value from the map through an exception if it is null
> or not a number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-digester] dependabot[bot] commented on pull request #21: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #21: URL: https://github.com/apache/commons-digester/pull/21#issuecomment-958640404 Superseded by #22. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-geometry] darkma773r commented on pull request #160: [COMMONSSITE-145]upgrade checkstyle
darkma773r commented on pull request #160: URL: https://github.com/apache/commons-geometry/pull/160#issuecomment-958935863 Checkstyle upgraded in #188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] darkma773r commented on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)
darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-959156762
I just had another thought on this: it strikes me that the main issue with
the generic `ImagerParser` format is how to deal
with format-agnostic code, mainly the utility methods in `Imaging`. In other
words, how do users specify parameters when they don't even know what the
format is? The current approach is to have users pass in their own parameters
objects to these utility methods but this gets into the problem of what happens
when they pass the wrong parameters type. What if we flipped this? Instead of
having the users create the parameters object, we have the parser create one
and then have the user modify it as needed in a callback. So, instead of this
```
public static byte[] getICCProfileBytes(final File file, final
ImagingParameters params) {
// hopefully params is of the correct type!
}
```
we do this
```
public static byte[] getICCProfileBytes(final File file, final
Consumer configurer) {
ImageParser parser = ...; // get the parser
return getICCProfileBytes(parser, configurer);
}
private static byte[] getICCProfileBytes(final
ImageParser parser, final Consumer configurer) {
P params = parser.getDefaultParameters();
if (configurer != null) {
// let the caller configure the parameters
configurer.accept(params);
}
// params is known to be the correct type
return parser.getICCProfileBytes(params);
}
```
Users would then call it like this:
```
Imaging.getICCProfileBytes(file, p -> p.setStrict(true));
```
We could also add methods to `ImageParser` that accept consumers like this
for consistency. That would probably be best.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] commented on pull request #20: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #20: URL: https://github.com/apache/commons-chain/pull/20#issuecomment-958658936 Superseded by #21. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] dependabot[bot] closed pull request #43: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #43: URL: https://github.com/apache/commons-exec/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] dependabot[bot] closed pull request #96: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #96: URL: https://github.com/apache/commons-codec/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] kinow merged pull request #98: Bump actions/checkout from 2.3.4 to 2.4.0
kinow merged pull request #98: URL: https://github.com/apache/commons-codec/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] dependabot[bot] commented on pull request #96: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #96: URL: https://github.com/apache/commons-codec/pull/96#issuecomment-959359645 Superseded by #98. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-159) There should be a Parameters class
[ https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=675987=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675987 ] ASF GitHub Bot logged work on IMAGING-159: -- Author: ASF GitHub Bot Created on: 04/Nov/21 01:48 Start Date: 04/Nov/21 01:48 Worklog Time Spent: 10m Work Description: kinow commented on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958618064 >> If the JpegImageParser requires a parameter different than the TiffImageParser, I assume we would have to create a new JpegImagingParameter. In that case, wouldn't we have to keep the old constructor for backward compatibility until a new major release? > >I'm not totally sure what you mean here. Can you give an example? Sorry, I wasn't very clear. At the moment we have `JpegImageParser parser = new JpegImageParser();`. Internally, the `JpegImageParser` is using a `TiffImagingParameters`. But if we need to add a parameter that is used only by the `JpegImageParser`, I think we would want to have a `JpegImagingParameters`. In which case I am not sure if we would be able to maintain backward compatibility by replacing the `TiffImagingParameters` in the `JpegImageParser`. >since it makes it it kind of hard to tell what parameters to use when creating images of a certain type. :point_up: this is my main concern. Avoid users having to guess what's the parameter that they want to use when parsing a Jpeg, Tiff, Gif, etc. Preferably something that their IDE's can assist with, using auto-complete for example. >One idea for making this readily available in the API would be to add convenience factory methods in Imaging for creating instances of each parameters type. Ex: Possibly another design to consider/experiment :-) >Side note: Is there a reason the JpegImageParser uses TiffImageParameters? The two formats are not related, correct? Perhaps we could have a common base class for them? We can probably avoid that. I agree it doesn't make much sense for the parameters to have a relationship like that. Currently, [`JpegImageParser`](https://github.com/apache/commons-imaging/blob/0ccabc3416cecf25cdec90a522f0912baf19bc58/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java#L751) has some code in common with the `TiffImageParser` for parsing EXIF metadata. I don't recall 100%, but I believe that's why I implemented everything in the `TiffImagingParameters` and, realizing the Jpeg parameters were the same, made the parent-child class relantionship. >Is the idea that it is confusing on what properties are copied over? Not at all, that part is clear and looks OK. It's with users being able to use the wrong parameter class by accident, and realizing only in runtime iff a runtime exception is thrown (or in the worst case, no exception is thrown and the program behaves in a wrong way; debugging an issue like that can be annoying I think). >I attempted to retain the null parameter functionality. In the normalizeParameters method, if a null parameter is passed, a default instance is created and returned, allowing downstream code to bypass null checks. mvn clean install passes with my current setup. Is there a unit test I missed? Ah, my bad! Your solution works with the method I was looking at. I wrote this one before looking at the method that creates the default parameters :+1: I need to find some time to “get in the zone” and try a few things. But it would be, mainly, to prevent users being able to use the wrong parameter types by accident, and making it so that we can add/remove parameters (deprecating what was removed) in the 1.x release series without worrying about backward compatibility. If we are able to modify your PR again to accommodate these two requirements, I think we would have the perfect solution :-) Thanks a lot! Bruno -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 675987) Time Spent: 12.5h (was: 12h 20m) > There should be a Parameters class > -- > > Key: IMAGING-159 > URL: https://issues.apache.org/jira/browse/IMAGING-159 > Project: Commons Imaging > Issue Type: Improvement > Components: imaging.* >Affects Versions: 1.0-alpha2 >Reporter: Benedikt Ritter >Assignee: Bruno P. Kinoshita >Priority: Major > Labels: github >
[GitHub] [commons-build-plugin] dependabot[bot] closed pull request #45: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #45: URL: https://github.com/apache/commons-build-plugin/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow commented on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)
kinow commented on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958618064 >> If the JpegImageParser requires a parameter different than the TiffImageParser, I assume we would have to create a new JpegImagingParameter. In that case, wouldn't we have to keep the old constructor for backward compatibility until a new major release? > >I'm not totally sure what you mean here. Can you give an example? Sorry, I wasn't very clear. At the moment we have `JpegImageParser parser = new JpegImageParser();`. Internally, the `JpegImageParser` is using a `TiffImagingParameters`. But if we need to add a parameter that is used only by the `JpegImageParser`, I think we would want to have a `JpegImagingParameters`. In which case I am not sure if we would be able to maintain backward compatibility by replacing the `TiffImagingParameters` in the `JpegImageParser`. >since it makes it it kind of hard to tell what parameters to use when creating images of a certain type. :point_up: this is my main concern. Avoid users having to guess what's the parameter that they want to use when parsing a Jpeg, Tiff, Gif, etc. Preferably something that their IDE's can assist with, using auto-complete for example. >One idea for making this readily available in the API would be to add convenience factory methods in Imaging for creating instances of each parameters type. Ex: Possibly another design to consider/experiment :-) >Side note: Is there a reason the JpegImageParser uses TiffImageParameters? The two formats are not related, correct? Perhaps we could have a common base class for them? We can probably avoid that. I agree it doesn't make much sense for the parameters to have a relationship like that. Currently, [`JpegImageParser`](https://github.com/apache/commons-imaging/blob/0ccabc3416cecf25cdec90a522f0912baf19bc58/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java#L751) has some code in common with the `TiffImageParser` for parsing EXIF metadata. I don't recall 100%, but I believe that's why I implemented everything in the `TiffImagingParameters` and, realizing the Jpeg parameters were the same, made the parent-child class relantionship. >Is the idea that it is confusing on what properties are copied over? Not at all, that part is clear and looks OK. It's with users being able to use the wrong parameter class by accident, and realizing only in runtime iff a runtime exception is thrown (or in the worst case, no exception is thrown and the program behaves in a wrong way; debugging an issue like that can be annoying I think). >I attempted to retain the null parameter functionality. In the normalizeParameters method, if a null parameter is passed, a default instance is created and returned, allowing downstream code to bypass null checks. mvn clean install passes with my current setup. Is there a unit test I missed? Ah, my bad! Your solution works with the method I was looking at. I wrote this one before looking at the method that creates the default parameters :+1: I need to find some time to “get in the zone” and try a few things. But it would be, mainly, to prevent users being able to use the wrong parameter types by accident, and making it so that we can add/remove parameters (deprecating what was removed) in the 1.x release series without worrying about backward compatibility. If we are able to modify your PR again to accommodate these two requirements, I think we would have the perfect solution :-) Thanks a lot! Bruno -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-daemon] dependabot[bot] commented on pull request #33: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #33: URL: https://github.com/apache/commons-daemon/pull/33#issuecomment-959577450 Superseded by #34. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] data443-cboyd removed a comment on pull request #295: Make FileWriterWithEncoding more precisely match its JavaDoc contract
data443-cboyd removed a comment on pull request #295: URL: https://github.com/apache/commons-io/pull/295#issuecomment-958689368 Hi @garydgregory , the pull request has been updated. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] kinow merged pull request #264: Bump actions/checkout from 2.3.5 to 2.4.0
kinow merged pull request #264: URL: https://github.com/apache/commons-collections/pull/264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-211) TextStringBuilder equals method changed behaviour from 1.8 to 1.9
[
https://issues.apache.org/jira/browse/TEXT-211?focusedWorklogId=675945=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675945
]
ASF GitHub Bot logged work on TEXT-211:
---
Author: ASF GitHub Bot
Created on: 04/Nov/21 01:43
Start Date: 04/Nov/21 01:43
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #281:
URL: https://github.com/apache/commons-text/pull/281#discussion_r742274854
##
File path: src/main/java/org/apache/commons/text/TextStringBuilder.java
##
@@ -1850,7 +1850,14 @@ public boolean equals(final Object obj) {
* @return true if the builders contain the same characters in the same
order
*/
public boolean equals(final TextStringBuilder other) {
-return other != null && Arrays.equals(buffer, other.buffer);
+
+ if(other == null) {
+ return false;
+ }
+ if (this.size != other.size) {
+return false;
+}
+return Arrays.equals(ArrayUtils.subarray(buffer, 0, size),
ArrayUtils.subarray(other.buffer, 0, size));
Review comment:
I think we can reuse our own toString() here.
##
File path: src/main/java/org/apache/commons/text/TextStringBuilder.java
##
@@ -1947,7 +1954,7 @@ public String getNullText() {
*/
@Override
public int hashCode() {
-return Arrays.hashCode(buffer);
+return Arrays.hashCode(ArrayUtils.subarray(buffer, 0, size));
Review comment:
I think we can reuse our own toString() here.
##
File path: src/test/java/org/apache/commons/text/TextStringBuilderTest.java
##
@@ -1057,15 +1057,24 @@ public void testHashCode() {
final TextStringBuilder sb = new TextStringBuilder();
final int hc1a = sb.hashCode();
final int hc1b = sb.hashCode();
-final int emptyHc = Arrays.hashCode(sb.getBuffer());
-assertEquals(emptyHc, hc1a);
Review comment:
I'm not a fan of removing passing asserts because it could hide a
regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 675945)
Time Spent: 3h (was: 2h 50m)
> TextStringBuilder equals method changed behaviour from 1.8 to 1.9
> -
>
> Key: TEXT-211
> URL: https://issues.apache.org/jira/browse/TEXT-211
> Project: Commons Text
> Issue Type: Bug
>Affects Versions: 1.9
>Reporter: Nikolaos Georgiou
>Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> We found a regression (or breaking compatibility change) in the
> TextStringBuilder equals method when upgrading commons-text from 1.8 to 1.9
>
> The 1.8 version (
> [https://github.com/apache/commons-text/blob/commons-text-1.8/src/main/java/org/apache/commons/text/TextStringBuilder.java#L2915]
> ) would only compare the parts of the buffer that fall within the range
> 0..size.
> The 1.9 version (
> [https://github.com/apache/commons-text/blob/rel/commons-text-1.9/src/main/java/org/apache/commons/text/TextStringBuilder.java#L1855]
> ) compares the entire buffer arrays.
> If a TextStringBuilder has extra capacity in the buffer, comparison fails.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-geometry] darkma773r closed pull request #160: [COMMONSSITE-145]upgrade checkstyle
darkma773r closed pull request #160: URL: https://github.com/apache/commons-geometry/pull/160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] closed pull request #20: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #20: URL: https://github.com/apache/commons-chain/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] garydgregory commented on a change in pull request #281: TEXT-211 - TextStringBuilder.equals whatever the capacity is
garydgregory commented on a change in pull request #281:
URL: https://github.com/apache/commons-text/pull/281#discussion_r742274854
##
File path: src/main/java/org/apache/commons/text/TextStringBuilder.java
##
@@ -1850,7 +1850,14 @@ public boolean equals(final Object obj) {
* @return true if the builders contain the same characters in the same
order
*/
public boolean equals(final TextStringBuilder other) {
-return other != null && Arrays.equals(buffer, other.buffer);
+
+ if(other == null) {
+ return false;
+ }
+ if (this.size != other.size) {
+return false;
+}
+return Arrays.equals(ArrayUtils.subarray(buffer, 0, size),
ArrayUtils.subarray(other.buffer, 0, size));
Review comment:
I think we can reuse our own toString() here.
##
File path: src/main/java/org/apache/commons/text/TextStringBuilder.java
##
@@ -1947,7 +1954,7 @@ public String getNullText() {
*/
@Override
public int hashCode() {
-return Arrays.hashCode(buffer);
+return Arrays.hashCode(ArrayUtils.subarray(buffer, 0, size));
Review comment:
I think we can reuse our own toString() here.
##
File path: src/test/java/org/apache/commons/text/TextStringBuilderTest.java
##
@@ -1057,15 +1057,24 @@ public void testHashCode() {
final TextStringBuilder sb = new TextStringBuilder();
final int hc1a = sb.hashCode();
final int hc1b = sb.hashCode();
-final int emptyHc = Arrays.hashCode(sb.getBuffer());
-assertEquals(emptyHc, hc1a);
Review comment:
I'm not a fan of removing passing asserts because it could hide a
regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-dbutils] coveralls commented on pull request #93: Bump actions/checkout from 2.3.4 to 2.4.0
coveralls commented on pull request #93: URL: https://github.com/apache/commons-dbutils/pull/93#issuecomment-959092301 [](https://coveralls.io/builds/43982464) Coverage remained the same at 65.619% when pulling **fa8a6e590551f083926f49f30f18a54e86396d65 on dependabot/github_actions/actions/checkout-2.4.0** into **39b907d76c8d9ab43aedc7ca5839a291bba7a077 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] coveralls commented on pull request #181: Bump actions/checkout from 2.3.5 to 2.4.0
coveralls commented on pull request #181: URL: https://github.com/apache/commons-imaging/pull/181#issuecomment-960312971 [](https://coveralls.io/builds/44000301) Coverage remained the same at 77.127% when pulling **70e3f6d96857556d46ac9918d88206e6c6201ed3 on dependabot/github_actions/actions/checkout-2.4.0** into **0ccabc3416cecf25cdec90a522f0912baf19bc58 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-211) TextStringBuilder equals method changed behaviour from 1.8 to 1.9
[
https://issues.apache.org/jira/browse/TEXT-211?focusedWorklogId=675926=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675926
]
ASF GitHub Bot logged work on TEXT-211:
---
Author: ASF GitHub Bot
Created on: 04/Nov/21 01:41
Start Date: 04/Nov/21 01:41
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #281:
URL: https://github.com/apache/commons-text/pull/281#discussion_r742269475
##
File path: src/main/java/org/apache/commons/text/TextStringBuilder.java
##
@@ -1850,7 +1850,14 @@ public boolean equals(final Object obj) {
* @return true if the builders contain the same characters in the same
order
*/
public boolean equals(final TextStringBuilder other) {
-return other != null && Arrays.equals(buffer, other.buffer);
+
+ if(other == null) {
+ return false;
+ }
+ if (this.size != other.size) {
+return false;
+}
+return Arrays.equals(ArrayUtils.subarray(buffer, 0, size),
ArrayUtils.subarray(other.buffer, 0, size));
Review comment:
Bad formatting here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 675926)
Time Spent: 2h 50m (was: 2h 40m)
> TextStringBuilder equals method changed behaviour from 1.8 to 1.9
> -
>
> Key: TEXT-211
> URL: https://issues.apache.org/jira/browse/TEXT-211
> Project: Commons Text
> Issue Type: Bug
>Affects Versions: 1.9
>Reporter: Nikolaos Georgiou
>Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> We found a regression (or breaking compatibility change) in the
> TextStringBuilder equals method when upgrading commons-text from 1.8 to 1.9
>
> The 1.8 version (
> [https://github.com/apache/commons-text/blob/commons-text-1.8/src/main/java/org/apache/commons/text/TextStringBuilder.java#L2915]
> ) would only compare the parts of the buffer that fall within the range
> 0..size.
> The 1.9 version (
> [https://github.com/apache/commons-text/blob/rel/commons-text-1.9/src/main/java/org/apache/commons/text/TextStringBuilder.java#L1855]
> ) compares the entire buffer arrays.
> If a TextStringBuilder has extra capacity in the buffer, comparison fails.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (IO-756) Update FileWriterWithEncoding to extend ProxyWriter
[ https://issues.apache.org/jira/browse/IO-756?focusedWorklogId=675924=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675924 ] ASF GitHub Bot logged work on IO-756: - Author: ASF GitHub Bot Created on: 04/Nov/21 01:41 Start Date: 04/Nov/21 01:41 Worklog Time Spent: 10m Work Description: wodencafe commented on a change in pull request #296: URL: https://github.com/apache/commons-io/pull/296#discussion_r741647754 ## File path: src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java ## @@ -245,7 +240,7 @@ public FileWriterWithEncoding(final String fileName, final String charsetName, f */ Review comment: Good point, we should just let the super class handle it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 675924) Time Spent: 50m (was: 40m) > Update FileWriterWithEncoding to extend ProxyWriter > --- > > Key: IO-756 > URL: https://issues.apache.org/jira/browse/IO-756 > Project: Commons IO > Issue Type: Improvement > Components: Streams/Writers >Affects Versions: 2.11.0 >Reporter: Woden Cafe >Priority: Minor > Labels: Commons, io > Fix For: 2.12.0 > > Time Spent: 50m > Remaining Estimate: 0h > > This change is to make org.apache.commons.io.output.FileWriterWithEncoding > extend org.apache.commons.io.output.ProxyWriter, to use the ProxyWriter's > delegate Writer rather than storing the delegate Writer reference within > FileWriterWithEncoding explicitly. > This simplifies FileWriterWithEncoding as it no longer needs to override any > methods from its super class, and no longer needs to store and maintain a > reference to a delegate Writer explicitly - this is provided by the super > class already. > [~kinow] Here is the ticket for the Pull Request. > https://github.com/apache/commons-io/pull/296 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] kinow commented on a change in pull request #281: TEXT-211 - TextStringBuilder.equals whatever the capacity is
kinow commented on a change in pull request #281:
URL: https://github.com/apache/commons-text/pull/281#discussion_r742269475
##
File path: src/main/java/org/apache/commons/text/TextStringBuilder.java
##
@@ -1850,7 +1850,14 @@ public boolean equals(final Object obj) {
* @return true if the builders contain the same characters in the same
order
*/
public boolean equals(final TextStringBuilder other) {
-return other != null && Arrays.equals(buffer, other.buffer);
+
+ if(other == null) {
+ return false;
+ }
+ if (this.size != other.size) {
+return false;
+}
+return Arrays.equals(ArrayUtils.subarray(buffer, 0, size),
ArrayUtils.subarray(other.buffer, 0, size));
Review comment:
Bad formatting here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-io] wodencafe commented on a change in pull request #296: IO-756: Update FileWriterWithEncoding to extend ProxyWriter
wodencafe commented on a change in pull request #296: URL: https://github.com/apache/commons-io/pull/296#discussion_r741647754 ## File path: src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java ## @@ -245,7 +240,7 @@ public FileWriterWithEncoding(final String fileName, final String charsetName, f */ Review comment: Good point, we should just let the super class handle it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bsf] dependabot[bot] commented on pull request #26: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #26: URL: https://github.com/apache/commons-bsf/pull/26#issuecomment-958928837 Superseded by #29. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-cli] coveralls commented on pull request #78: Bump actions/checkout from 2.3.5 to 2.4.0
coveralls commented on pull request #78: URL: https://github.com/apache/commons-cli/pull/78#issuecomment-958950442 [](https://coveralls.io/builds/43979617) Coverage remained the same at 96.195% when pulling **02e5378f717e107706f421e06bda36fa5ba56e9b on dependabot/github_actions/actions/checkout-2.4.0** into **ae7bc3f3cf57cabf3e663ba5df76affa36633255 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-211) TextStringBuilder equals method changed behaviour from 1.8 to 1.9
[ https://issues.apache.org/jira/browse/TEXT-211?focusedWorklogId=675890=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675890 ] ASF GitHub Bot logged work on TEXT-211: --- Author: ASF GitHub Bot Created on: 04/Nov/21 01:38 Start Date: 04/Nov/21 01:38 Worklog Time Spent: 10m Work Description: sebx59 commented on pull request #281: URL: https://github.com/apache/commons-text/pull/281#issuecomment-959027541 You're right, my bad, new commit for hashcode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 675890) Time Spent: 2h 40m (was: 2.5h) > TextStringBuilder equals method changed behaviour from 1.8 to 1.9 > - > > Key: TEXT-211 > URL: https://issues.apache.org/jira/browse/TEXT-211 > Project: Commons Text > Issue Type: Bug >Affects Versions: 1.9 >Reporter: Nikolaos Georgiou >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > > We found a regression (or breaking compatibility change) in the > TextStringBuilder equals method when upgrading commons-text from 1.8 to 1.9 > > The 1.8 version ( > [https://github.com/apache/commons-text/blob/commons-text-1.8/src/main/java/org/apache/commons/text/TextStringBuilder.java#L2915] > ) would only compare the parts of the buffer that fall within the range > 0..size. > The 1.9 version ( > [https://github.com/apache/commons-text/blob/rel/commons-text-1.9/src/main/java/org/apache/commons/text/TextStringBuilder.java#L1855] > ) compares the entire buffer arrays. > If a TextStringBuilder has extra capacity in the buffer, comparison fails. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] coveralls commented on pull request #264: Bump actions/checkout from 2.3.5 to 2.4.0
coveralls commented on pull request #264: URL: https://github.com/apache/commons-collections/pull/264#issuecomment-959786323 [](https://coveralls.io/builds/43990870) Coverage decreased (-0.03%) to 90.107% when pulling **6eca7138141b1ad6ad0d7b89728afc53b27d91e0 on dependabot/github_actions/actions/checkout-2.4.0** into **49d56376ebcef39b6b3f8e6f7c8b6798764427cc on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] sebx59 commented on pull request #281: TEXT-211 - TextStringBuilder.equals whatever the capacity is
sebx59 commented on pull request #281: URL: https://github.com/apache/commons-text/pull/281#issuecomment-959027541 You're right, my bad, new commit for hashcode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] closed pull request #21: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #21: URL: https://github.com/apache/commons-digester/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-configuration] dependabot[bot] commented on pull request #147: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #147: URL: https://github.com/apache/commons-configuration/pull/147#issuecomment-959561532 Superseded by #150. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-211) TextStringBuilder equals method changed behaviour from 1.8 to 1.9
[ https://issues.apache.org/jira/browse/TEXT-211?focusedWorklogId=675860=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675860 ] ASF GitHub Bot logged work on TEXT-211: --- Author: ASF GitHub Bot Created on: 04/Nov/21 01:35 Start Date: 04/Nov/21 01:35 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #281: URL: https://github.com/apache/commons-text/pull/281#issuecomment-958980765 Hi @sebx59 - What about also testing `hashCode()`? - The formatting looks messed up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 675860) Time Spent: 2.5h (was: 2h 20m) > TextStringBuilder equals method changed behaviour from 1.8 to 1.9 > - > > Key: TEXT-211 > URL: https://issues.apache.org/jira/browse/TEXT-211 > Project: Commons Text > Issue Type: Bug >Affects Versions: 1.9 >Reporter: Nikolaos Georgiou >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > We found a regression (or breaking compatibility change) in the > TextStringBuilder equals method when upgrading commons-text from 1.8 to 1.9 > > The 1.8 version ( > [https://github.com/apache/commons-text/blob/commons-text-1.8/src/main/java/org/apache/commons/text/TextStringBuilder.java#L2915] > ) would only compare the parts of the buffer that fall within the range > 0..size. > The 1.9 version ( > [https://github.com/apache/commons-text/blob/rel/commons-text-1.9/src/main/java/org/apache/commons/text/TextStringBuilder.java#L1855] > ) compares the entire buffer arrays. > If a TextStringBuilder has extra capacity in the buffer, comparison fails. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] garydgregory commented on pull request #281: TEXT-211 - TextStringBuilder.equals whatever the capacity is
garydgregory commented on pull request #281: URL: https://github.com/apache/commons-text/pull/281#issuecomment-958980765 Hi @sebx59 - What about also testing `hashCode()`? - The formatting looks messed up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-pool] coveralls commented on pull request #112: Bump actions/checkout from 2.3.5 to 2.4.0
coveralls commented on pull request #112: URL: https://github.com/apache/commons-pool/pull/112#issuecomment-959794660 [](https://coveralls.io/builds/43991205) Coverage remained the same at 85.053% when pulling **22533a2cf9214a0530584db0609026b40880c716 on dependabot/github_actions/actions/checkout-2.4.0** into **1c57be31e8dae6cd504ee7932d62f332eef69ec1 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] kinow edited a comment on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
kinow edited a comment on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-958613424 @wodencafe we would also need a JIRA for this, could you create one? I think we will be able to make `FilterWriterWithEncoding` extend `ProxyWriter`. But in case we find a roadblock somewhere and we are not able to make `FileWriterWithEncoding` extend `ProxyWriter`, we should be able to at least improve the existing comment in the code explaining better why that's not possible (just in case it's indeed not possible :+1: ) Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] dependabot[bot] closed pull request #76: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #76: URL: https://github.com/apache/commons-jcs/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bsf] dependabot[bot] closed pull request #26: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #26: URL: https://github.com/apache/commons-bsf/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] dependabot[bot] closed pull request #142: Bump checkstyle from 9.0 to 9.0.1
dependabot[bot] closed pull request #142: URL: https://github.com/apache/commons-dbcp/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-configuration] dependabot[bot] closed pull request #147: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #147: URL: https://github.com/apache/commons-configuration/pull/147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-211) TextStringBuilder equals method changed behaviour from 1.8 to 1.9
[ https://issues.apache.org/jira/browse/TEXT-211?focusedWorklogId=675797=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675797 ] ASF GitHub Bot logged work on TEXT-211: --- Author: ASF GitHub Bot Created on: 04/Nov/21 01:29 Start Date: 04/Nov/21 01:29 Worklog Time Spent: 10m Work Description: sebx59 edited a comment on pull request #281: URL: https://github.com/apache/commons-text/pull/281#issuecomment-959027541 You're right, my bad, new commit for hashcode What do you mean about formatting ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 675797) Time Spent: 2h 20m (was: 2h 10m) > TextStringBuilder equals method changed behaviour from 1.8 to 1.9 > - > > Key: TEXT-211 > URL: https://issues.apache.org/jira/browse/TEXT-211 > Project: Commons Text > Issue Type: Bug >Affects Versions: 1.9 >Reporter: Nikolaos Georgiou >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > We found a regression (or breaking compatibility change) in the > TextStringBuilder equals method when upgrading commons-text from 1.8 to 1.9 > > The 1.8 version ( > [https://github.com/apache/commons-text/blob/commons-text-1.8/src/main/java/org/apache/commons/text/TextStringBuilder.java#L2915] > ) would only compare the parts of the buffer that fall within the range > 0..size. > The 1.9 version ( > [https://github.com/apache/commons-text/blob/rel/commons-text-1.9/src/main/java/org/apache/commons/text/TextStringBuilder.java#L1855] > ) compares the entire buffer arrays. > If a TextStringBuilder has extra capacity in the buffer, comparison fails. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] sebx59 edited a comment on pull request #281: TEXT-211 - TextStringBuilder.equals whatever the capacity is
sebx59 edited a comment on pull request #281: URL: https://github.com/apache/commons-text/pull/281#issuecomment-959027541 You're right, my bad, new commit for hashcode What do you mean about formatting ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #825: Bump actions/checkout from 2.3.5 to 2.4.0
coveralls commented on pull request #825: URL: https://github.com/apache/commons-lang/pull/825#issuecomment-960144350 [](https://coveralls.io/builds/43997170) Coverage remained the same at 94.948% when pulling **0d2cb63097dce54c014f257f310d003f260e9e5d on dependabot/github_actions/actions/checkout-2.4.0** into **18a82dc4ae9c1095216b6cb288b3c5567ffd179b on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] kinow merged pull request #263: Bump checkstyle from 9.0.1 to 9.1
kinow merged pull request #263: URL: https://github.com/apache/commons-collections/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] dependabot[bot] closed pull request #89: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #89: URL: https://github.com/apache/commons-dbutils/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] dependabot[bot] commented on pull request #43: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #43: URL: https://github.com/apache/commons-exec/pull/43#issuecomment-959734600 Superseded by #44. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-ognl] lukaszlenart merged pull request #52: Bump actions/checkout from 2.3.5 to 2.4.0
lukaszlenart merged pull request #52: URL: https://github.com/apache/commons-ognl/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jexl] coveralls commented on pull request #67: Bump actions/checkout from 2.3.5 to 2.4.0
coveralls commented on pull request #67: URL: https://github.com/apache/commons-jexl/pull/67#issuecomment-959788204 [](https://coveralls.io/builds/43991022) Coverage decreased (-0.03%) to 87.095% when pulling **4a28e4dbfd6c47db1a26f9e9d6d17f369b782819 on dependabot/github_actions/actions/checkout-2.4.0** into **bfe11f48dd3432e8250ee68e0255f9c56b77538d on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-build-plugin] dependabot[bot] commented on pull request #45: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #45: URL: https://github.com/apache/commons-build-plugin/pull/45#issuecomment-958674352 Superseded by #48. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] wodencafe commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
wodencafe commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-958602720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-211) TextStringBuilder equals method changed behaviour from 1.8 to 1.9
[ https://issues.apache.org/jira/browse/TEXT-211?focusedWorklogId=675720=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675720 ] ASF GitHub Bot logged work on TEXT-211: --- Author: ASF GitHub Bot Created on: 04/Nov/21 01:21 Start Date: 04/Nov/21 01:21 Worklog Time Spent: 10m Work Description: sebx59 opened a new pull request #281: URL: https://github.com/apache/commons-text/pull/281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 675720) Time Spent: 2h 10m (was: 2h) > TextStringBuilder equals method changed behaviour from 1.8 to 1.9 > - > > Key: TEXT-211 > URL: https://issues.apache.org/jira/browse/TEXT-211 > Project: Commons Text > Issue Type: Bug >Affects Versions: 1.9 >Reporter: Nikolaos Georgiou >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > We found a regression (or breaking compatibility change) in the > TextStringBuilder equals method when upgrading commons-text from 1.8 to 1.9 > > The 1.8 version ( > [https://github.com/apache/commons-text/blob/commons-text-1.8/src/main/java/org/apache/commons/text/TextStringBuilder.java#L2915] > ) would only compare the parts of the buffer that fall within the range > 0..size. > The 1.9 version ( > [https://github.com/apache/commons-text/blob/rel/commons-text-1.9/src/main/java/org/apache/commons/text/TextStringBuilder.java#L1855] > ) compares the entire buffer arrays. > If a TextStringBuilder has extra capacity in the buffer, comparison fails. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-logging] dependabot[bot] commented on pull request #60: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #60: URL: https://github.com/apache/commons-logging/pull/60#issuecomment-958802054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-logging] dependabot[bot] closed pull request #60: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #60: URL: https://github.com/apache/commons-logging/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] dependabot[bot] commented on pull request #89: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #89: URL: https://github.com/apache/commons-dbutils/pull/89#issuecomment-958758914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] kinow commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
kinow commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-958613424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] kinow commented on a change in pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
kinow commented on a change in pull request #296: URL: https://github.com/apache/commons-io/pull/296#discussion_r741586353 ## File path: src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java ## @@ -245,7 +240,7 @@ public FileWriterWithEncoding(final String fileName, final String charsetName, f */ Review comment: @wodencafe do we need to override the methods below? Could we just use the parent methods directly? ## File path: src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java ## @@ -245,7 +240,7 @@ public FileWriterWithEncoding(final String fileName, final String charsetName, f */ Review comment: @wodencafe do we need to override the methods below? Could we just use the parent methods directly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] dependabot[bot] commented on pull request #142: Bump checkstyle from 9.0 to 9.0.1
dependabot[bot] commented on pull request #142: URL: https://github.com/apache/commons-dbcp/pull/142#issuecomment-958649485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-scxml] dependabot[bot] closed pull request #29: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #29: URL: https://github.com/apache/commons-scxml/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] tvand merged pull request #71: Simplify conditions avoiding unnecessary validation
tvand merged pull request #71: URL: https://github.com/apache/commons-jcs/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] wodencafe commented on pull request #295: Make FileWriterWithEncoding more precisely match its JavaDoc contract
wodencafe commented on pull request #295: URL: https://github.com/apache/commons-io/pull/295#issuecomment-960343378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] dependabot[bot] commented on pull request #76: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #76: URL: https://github.com/apache/commons-jcs/pull/76#issuecomment-958697542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] coveralls commented on pull request #125: Bump actions/checkout from 2.3.4 to 2.4.0
coveralls commented on pull request #125: URL: https://github.com/apache/commons-fileupload/pull/125#issuecomment-958617571 [](https://coveralls.io/builds/43970729) Coverage remained the same at 77.585% when pulling **c1b2c15139128cee63f20c2f833ffcd1143235cf on dependabot/github_actions/actions/checkout-2.4.0** into **55f485d8436578a3f0b89a753043311e93b3849a on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] closed pull request #21: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #21: URL: https://github.com/apache/commons-digester/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] dependabot[bot] closed pull request #76: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #76: URL: https://github.com/apache/commons-jcs/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] commented on pull request #21: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #21: URL: https://github.com/apache/commons-digester/pull/21#issuecomment-958640404 Superseded by #22. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow merged pull request #181: Bump actions/checkout from 2.3.5 to 2.4.0
kinow merged pull request #181: URL: https://github.com/apache/commons-imaging/pull/181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-756) Update FileWriterWithEncoding to extend ProxyWriter
[ https://issues.apache.org/jira/browse/IO-756?focusedWorklogId=675643=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675643 ] ASF GitHub Bot logged work on IO-756: - Author: ASF GitHub Bot Created on: 04/Nov/21 01:11 Start Date: 04/Nov/21 01:11 Worklog Time Spent: 10m Work Description: wodencafe commented on a change in pull request #296: URL: https://github.com/apache/commons-io/pull/296#discussion_r741647754 ## File path: src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java ## @@ -245,7 +240,7 @@ public FileWriterWithEncoding(final String fileName, final String charsetName, f */ Review comment: Good point, we should just let the super class handle it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 675643) Time Spent: 40m (was: 0.5h) > Update FileWriterWithEncoding to extend ProxyWriter > --- > > Key: IO-756 > URL: https://issues.apache.org/jira/browse/IO-756 > Project: Commons IO > Issue Type: Improvement > Components: Streams/Writers >Affects Versions: 2.11.0 >Reporter: Woden Cafe >Priority: Minor > Labels: Commons, io > Fix For: 2.12.0 > > Time Spent: 40m > Remaining Estimate: 0h > > This change is to make org.apache.commons.io.output.FileWriterWithEncoding > extend org.apache.commons.io.output.ProxyWriter, to use the ProxyWriter's > delegate Writer rather than storing the delegate Writer reference within > FileWriterWithEncoding explicitly. > This simplifies FileWriterWithEncoding as it no longer needs to override any > methods from its super class, and no longer needs to store and maintain a > reference to a delegate Writer explicitly - this is provided by the super > class already. > [~kinow] Here is the ticket for the Pull Request. > https://github.com/apache/commons-io/pull/296 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] wodencafe commented on a change in pull request #296: IO-756: Update FileWriterWithEncoding to extend ProxyWriter
wodencafe commented on a change in pull request #296: URL: https://github.com/apache/commons-io/pull/296#discussion_r741647754 ## File path: src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java ## @@ -245,7 +240,7 @@ public FileWriterWithEncoding(final String fileName, final String charsetName, f */ Review comment: Good point, we should just let the super class handle it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] kinow edited a comment on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
kinow edited a comment on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-958613424 @wodencafe we would also need a JIRA for this, could you create one? I think we will be able to make `FilterWriterWithEncoding` extend `ProxyWriter`. But in case we find a roadblock somewhere and we are not able to make `FileWriterWithEncoding` extend `ProxyWriter`, we should be able to at least improve the existing comment in the code explaining better why that's not possible (just in case it's indeed not possible :+1: ) Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #227: Bump actions/checkout from 2.3.5 to 2.4.0
coveralls commented on pull request #227: URL: https://github.com/apache/commons-compress/pull/227#issuecomment-958780831 [](https://coveralls.io/builds/43976480) Coverage remained the same at 86.312% when pulling **079ff25f31b4f457a65ad73e5bde2d213bc0a07c on dependabot/github_actions/actions/checkout-2.4.0** into **4246b887ba88dc0b2bc09e92c63fff97381b4a12 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-159) There should be a Parameters class
[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=675626=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675626
]
ASF GitHub Bot logged work on IMAGING-159:
--
Author: ASF GitHub Bot
Created on: 04/Nov/21 01:10
Start Date: 04/Nov/21 01:10
Worklog Time Spent: 10m
Work Description: darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958597172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 675626)
Time Spent: 12h 20m (was: 12h 10m)
> There should be a Parameters class
> --
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
>Affects Versions: 1.0-alpha2
>Reporter: Benedikt Ritter
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Labels: github
> Fix For: 1.0-alpha3
>
> Time Spent: 12h 20m
> Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides
> additional methods like {{public int getInt(String key)}}. The implementation
> could then look up the value from the map through an exception if it is null
> or not a number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-imaging] darkma773r commented on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)
darkma773r commented on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958597172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] commented on pull request #20: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #20: URL: https://github.com/apache/commons-chain/pull/20#issuecomment-958658936 Superseded by #21. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] kinow merged pull request #264: Bump actions/checkout from 2.3.5 to 2.4.0
kinow merged pull request #264: URL: https://github.com/apache/commons-collections/pull/264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] dependabot[bot] closed pull request #142: Bump checkstyle from 9.0 to 9.0.1
dependabot[bot] closed pull request #142: URL: https://github.com/apache/commons-dbcp/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] kinow merged pull request #98: Bump actions/checkout from 2.3.4 to 2.4.0
kinow merged pull request #98: URL: https://github.com/apache/commons-codec/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-build-plugin] dependabot[bot] closed pull request #45: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #45: URL: https://github.com/apache/commons-build-plugin/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-scxml] dependabot[bot] commented on pull request #29: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #29: URL: https://github.com/apache/commons-scxml/pull/29#issuecomment-958508599 Superseded by #30. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] data443-cboyd commented on pull request #295: Make FileWriterWithEncoding more precisely match its JavaDoc contract
data443-cboyd commented on pull request #295: URL: https://github.com/apache/commons-io/pull/295#issuecomment-958689368 Hi @garydgregory , the pull request has been updated. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow commented on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)
kinow commented on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958618064 >> If the JpegImageParser requires a parameter different than the TiffImageParser, I assume we would have to create a new JpegImagingParameter. In that case, wouldn't we have to keep the old constructor for backward compatibility until a new major release? > >I'm not totally sure what you mean here. Can you give an example? Sorry, I wasn't very clear. At the moment we have `JpegImageParser parser = new JpegImageParser();`. Internally, the `JpegImageParser` is using a `TiffImagingParameters`. But if we need to add a parameter that is used only by the `JpegImageParser`, I think we would want to have a `JpegImagingParameters`. In which case I am not sure if we would be able to maintain backward compatibility by replacing the `TiffImagingParameters` in the `JpegImageParser`. >since it makes it it kind of hard to tell what parameters to use when creating images of a certain type. :point_up: this is my main concern. Avoid users having to guess what's the parameter that they want to use when parsing a Jpeg, Tiff, Gif, etc. Preferably something that their IDE's can assist with, using auto-complete for example. >One idea for making this readily available in the API would be to add convenience factory methods in Imaging for creating instances of each parameters type. Ex: Possibly another design to consider/experiment :-) >Side note: Is there a reason the JpegImageParser uses TiffImageParameters? The two formats are not related, correct? Perhaps we could have a common base class for them? We can probably avoid that. I agree it doesn't make much sense for the parameters to have a relationship like that. Currently, [`JpegImageParser`](https://github.com/apache/commons-imaging/blob/0ccabc3416cecf25cdec90a522f0912baf19bc58/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java#L751) has some code in common with the `TiffImageParser` for parsing EXIF metadata. I don't recall 100%, but I believe that's why I implemented everything in the `TiffImagingParameters` and, realizing the Jpeg parameters were the same, made the parent-child class relantionship. >Is the idea that it is confusing on what properties are copied over? Not at all, that part is clear and looks OK. It's with users being able to use the wrong parameter class by accident, and realizing only in runtime iff a runtime exception is thrown (or in the worst case, no exception is thrown and the program behaves in a wrong way; debugging an issue like that can be annoying I think). >I attempted to retain the null parameter functionality. In the normalizeParameters method, if a null parameter is passed, a default instance is created and returned, allowing downstream code to bypass null checks. mvn clean install passes with my current setup. Is there a unit test I missed? Ah, my bad! Your solution works with the method I was looking at. I wrote this one before looking at the method that creates the default parameters :+1: I need to find some time to “get in the zone” and try a few things. But it would be, mainly, to prevent users being able to use the wrong parameter types by accident, and making it so that we can add/remove parameters (deprecating what was removed) in the 1.x release series without worrying about backward compatibility. If we are able to modify your PR again to accommodate these two requirements, I think we would have the perfect solution :-) Thanks a lot! Bruno -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-159) There should be a Parameters class
[ https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=675602=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675602 ] ASF GitHub Bot logged work on IMAGING-159: -- Author: ASF GitHub Bot Created on: 04/Nov/21 01:06 Start Date: 04/Nov/21 01:06 Worklog Time Spent: 10m Work Description: kinow commented on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958618064 >> If the JpegImageParser requires a parameter different than the TiffImageParser, I assume we would have to create a new JpegImagingParameter. In that case, wouldn't we have to keep the old constructor for backward compatibility until a new major release? > >I'm not totally sure what you mean here. Can you give an example? Sorry, I wasn't very clear. At the moment we have `JpegImageParser parser = new JpegImageParser();`. Internally, the `JpegImageParser` is using a `TiffImagingParameters`. But if we need to add a parameter that is used only by the `JpegImageParser`, I think we would want to have a `JpegImagingParameters`. In which case I am not sure if we would be able to maintain backward compatibility by replacing the `TiffImagingParameters` in the `JpegImageParser`. >since it makes it it kind of hard to tell what parameters to use when creating images of a certain type. :point_up: this is my main concern. Avoid users having to guess what's the parameter that they want to use when parsing a Jpeg, Tiff, Gif, etc. Preferably something that their IDE's can assist with, using auto-complete for example. >One idea for making this readily available in the API would be to add convenience factory methods in Imaging for creating instances of each parameters type. Ex: Possibly another design to consider/experiment :-) >Side note: Is there a reason the JpegImageParser uses TiffImageParameters? The two formats are not related, correct? Perhaps we could have a common base class for them? We can probably avoid that. I agree it doesn't make much sense for the parameters to have a relationship like that. Currently, [`JpegImageParser`](https://github.com/apache/commons-imaging/blob/0ccabc3416cecf25cdec90a522f0912baf19bc58/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java#L751) has some code in common with the `TiffImageParser` for parsing EXIF metadata. I don't recall 100%, but I believe that's why I implemented everything in the `TiffImagingParameters` and, realizing the Jpeg parameters were the same, made the parent-child class relantionship. >Is the idea that it is confusing on what properties are copied over? Not at all, that part is clear and looks OK. It's with users being able to use the wrong parameter class by accident, and realizing only in runtime iff a runtime exception is thrown (or in the worst case, no exception is thrown and the program behaves in a wrong way; debugging an issue like that can be annoying I think). >I attempted to retain the null parameter functionality. In the normalizeParameters method, if a null parameter is passed, a default instance is created and returned, allowing downstream code to bypass null checks. mvn clean install passes with my current setup. Is there a unit test I missed? Ah, my bad! Your solution works with the method I was looking at. I wrote this one before looking at the method that creates the default parameters :+1: I need to find some time to “get in the zone” and try a few things. But it would be, mainly, to prevent users being able to use the wrong parameter types by accident, and making it so that we can add/remove parameters (deprecating what was removed) in the 1.x release series without worrying about backward compatibility. If we are able to modify your PR again to accommodate these two requirements, I think we would have the perfect solution :-) Thanks a lot! Bruno -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 675602) Time Spent: 12h 10m (was: 12h) > There should be a Parameters class > -- > > Key: IMAGING-159 > URL: https://issues.apache.org/jira/browse/IMAGING-159 > Project: Commons Imaging > Issue Type: Improvement > Components: imaging.* >Affects Versions: 1.0-alpha2 >Reporter: Benedikt Ritter >Assignee: Bruno P. Kinoshita >Priority: Major > Labels: github >
[GitHub] [commons-collections] kinow merged pull request #263: Bump checkstyle from 9.0.1 to 9.1
kinow merged pull request #263: URL: https://github.com/apache/commons-collections/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] dependabot[bot] closed pull request #89: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #89: URL: https://github.com/apache/commons-dbutils/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] data443-cboyd removed a comment on pull request #295: Make FileWriterWithEncoding more precisely match its JavaDoc contract
data443-cboyd removed a comment on pull request #295: URL: https://github.com/apache/commons-io/pull/295#issuecomment-958689368 Hi @garydgregory , the pull request has been updated. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-ognl] lukaszlenart merged pull request #52: Bump actions/checkout from 2.3.5 to 2.4.0
lukaszlenart merged pull request #52: URL: https://github.com/apache/commons-ognl/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jexl] coveralls commented on pull request #67: Bump actions/checkout from 2.3.5 to 2.4.0
coveralls commented on pull request #67: URL: https://github.com/apache/commons-jexl/pull/67#issuecomment-959788204 [](https://coveralls.io/builds/43991022) Coverage decreased (-0.03%) to 87.095% when pulling **4a28e4dbfd6c47db1a26f9e9d6d17f369b782819 on dependabot/github_actions/actions/checkout-2.4.0** into **bfe11f48dd3432e8250ee68e0255f9c56b77538d on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] kinow merged pull request #298: Bump actions/checkout from 2.3.5 to 2.4.0
kinow merged pull request #298: URL: https://github.com/apache/commons-io/pull/298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] closed pull request #20: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #20: URL: https://github.com/apache/commons-chain/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-build-plugin] dependabot[bot] commented on pull request #45: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #45: URL: https://github.com/apache/commons-build-plugin/pull/45#issuecomment-958674352 Superseded by #48. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] coveralls commented on pull request #181: Bump actions/checkout from 2.3.5 to 2.4.0
coveralls commented on pull request #181: URL: https://github.com/apache/commons-imaging/pull/181#issuecomment-960312971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] coveralls commented on pull request #93: Bump actions/checkout from 2.3.4 to 2.4.0
coveralls commented on pull request #93: URL: https://github.com/apache/commons-dbutils/pull/93#issuecomment-959092301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-211) TextStringBuilder equals method changed behaviour from 1.8 to 1.9
[
https://issues.apache.org/jira/browse/TEXT-211?focusedWorklogId=675503=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675503
]
ASF GitHub Bot logged work on TEXT-211:
---
Author: ASF GitHub Bot
Created on: 04/Nov/21 00:56
Start Date: 04/Nov/21 00:56
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #281:
URL: https://github.com/apache/commons-text/pull/281#discussion_r742269475
##
File path: src/main/java/org/apache/commons/text/TextStringBuilder.java
##
@@ -1850,7 +1850,14 @@ public boolean equals(final Object obj) {
* @return true if the builders contain the same characters in the same
order
*/
public boolean equals(final TextStringBuilder other) {
-return other != null && Arrays.equals(buffer, other.buffer);
+
+ if(other == null) {
+ return false;
+ }
+ if (this.size != other.size) {
+return false;
+}
+return Arrays.equals(ArrayUtils.subarray(buffer, 0, size),
ArrayUtils.subarray(other.buffer, 0, size));
Review comment:
Bad formatting here
##
File path: src/main/java/org/apache/commons/text/TextStringBuilder.java
##
@@ -1850,7 +1850,14 @@ public boolean equals(final Object obj) {
* @return true if the builders contain the same characters in the same
order
*/
public boolean equals(final TextStringBuilder other) {
-return other != null && Arrays.equals(buffer, other.buffer);
+
+ if(other == null) {
+ return false;
+ }
+ if (this.size != other.size) {
+return false;
+}
+return Arrays.equals(ArrayUtils.subarray(buffer, 0, size),
ArrayUtils.subarray(other.buffer, 0, size));
Review comment:
Bad formatting here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 675503)
Time Spent: 2h (was: 1h 50m)
> TextStringBuilder equals method changed behaviour from 1.8 to 1.9
> -
>
> Key: TEXT-211
> URL: https://issues.apache.org/jira/browse/TEXT-211
> Project: Commons Text
> Issue Type: Bug
>Affects Versions: 1.9
>Reporter: Nikolaos Georgiou
>Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> We found a regression (or breaking compatibility change) in the
> TextStringBuilder equals method when upgrading commons-text from 1.8 to 1.9
>
> The 1.8 version (
> [https://github.com/apache/commons-text/blob/commons-text-1.8/src/main/java/org/apache/commons/text/TextStringBuilder.java#L2915]
> ) would only compare the parts of the buffer that fall within the range
> 0..size.
> The 1.9 version (
> [https://github.com/apache/commons-text/blob/rel/commons-text-1.9/src/main/java/org/apache/commons/text/TextStringBuilder.java#L1855]
> ) compares the entire buffer arrays.
> If a TextStringBuilder has extra capacity in the buffer, comparison fails.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
