[jira] [Commented] (COLLECTIONS-404) Adding an implementation of Eugene Myers difference algorithm
[ https://issues.apache.org/jira/browse/COLLECTIONS-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251026#comment-13251026 ] Hudson commented on COLLECTIONS-404: Integrated in commons-collections #19 (See [https://builds.apache.org/job/commons-collections/19/]) Added an implementation of Eugene Myers difference algorithm. JIRA: COLLECTIONS-404 (Revision 1311964) Result = SUCCESS luc : http://svn.apache.org/viewvc/?view=rev&rev=1311964 Files : * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/CommandVisitor.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/DeleteCommand.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/EditCommand.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/EditScript.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/InsertCommand.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/KeepCommand.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/ReplacementsFinder.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/ReplacementsHandler.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/SequencesComparator.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/Snake.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/package.html * /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/difference * /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/difference/SequencesComparatorTest.java > Adding an implementation of Eugene Myers difference algorithm > - > > Key: COLLECTIONS-404 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-404 > Project: Commons Collections > Issue Type: Improvement > Components: Collection >Affects Versions: 3.2.1 > Environment: all >Reporter: Luc Maisonobe >Assignee: Luc Maisonobe >Priority: Minor > Attachments: commons-collections-difference-v2.patch, > commons-collections-difference.patch, comparator.zip > > > The difference algorithm aims at comparing two sequences of objects and > return an "edit script" which represents how one can transform the first > sequence into the second sequence. The script describes the various insert > object, delete object and keep object commands. The script is guaranteed to > be the shortest possible in terms of number of commands. > From the script, one can either extract longest common sub-sequences (i.e. > how similar the sequences are) or on the contrary the needed changes (i.e. > how different the sequences are). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COLLECTIONS-404) Adding an implementation of Eugene Myers difference algorithm
[ https://issues.apache.org/jira/browse/COLLECTIONS-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250960#comment-13250960 ] Hudson commented on COLLECTIONS-404: Integrated in commons-collections #18 (See [https://builds.apache.org/job/commons-collections/18/]) Added an implementation of Eugene Myers difference algorithm. JIRA: COLLECTIONS-404 (Revision 1311904) Result = ABORTED luc : http://svn.apache.org/viewvc/?view=rev&rev=1311904 Files : * /commons/proper/collections/trunk/pom.xml * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/IndexedCollection.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/CatchAndRethrowClosure.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ComparatorPredicate.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/CommandVisitor.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/DeleteCommand.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/EditCommand.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/EditScript.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/InsertCommand.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/KeepCommand.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/ReplacementsFinder.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/ReplacementsHandler.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/SequencesComparator.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/Snake.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/difference/package.html * /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/AbstractDecoratedCollectionTest.java * /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/MockTestCase.java * /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/TestIndexedCollection.java * /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/functors/BasicClosureTestBase.java * /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/functors/TestCatchAndRethrowClosure.java * /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/functors/TestComparatorPredicate.java * /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/difference * /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/difference/SequencesComparatorTest.java > Adding an implementation of Eugene Myers difference algorithm > - > > Key: COLLECTIONS-404 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-404 > Project: Commons Collections > Issue Type: Improvement > Components: Collection >Affects Versions: 3.2.1 > Environment: all >Reporter: Luc Maisonobe >Assignee: Luc Maisonobe >Priority: Minor > Attachments: commons-collections-difference-v2.patch, > commons-collections-difference.patch, comparator.zip > > > The difference algorithm aims at comparing two sequences of objects and > return an "edit script" which represents how one can transform the first > sequence into the second sequence. The script describes the various insert > object, delete object and keep object commands. The script is guaranteed to > be the shortest possible in terms of number of commands. > From the script, one can either extract longest common sub-sequences (i.e. > how similar the sequences are) or on the contrary the needed changes (i.e. > how different the sequences are). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COLLECTIONS-380) UnmodifiableBoundedCollection.unmodifiableBoundedCollection is an infinite loop
[
https://issues.apache.org/jira/browse/COLLECTIONS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250051#comment-13250051
]
Hudson commented on COLLECTIONS-380:
Integrated in commons-collections #17 (See
[https://builds.apache.org/job/commons-collections/17/])
[COLLECTIONS-380] Fixed infinte recursion when creating an unmodifiable
bounded collection, added unit test, fixed additional javadoc, thanks to Dave
Brosius for reporting. (Revision 1311366)
Result = SUCCESS
tn : http://svn.apache.org/viewvc/?view=rev&rev=1311366
Files :
*
/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/UnmodifiableBoundedCollection.java
*
/commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/collection/TestUnmodifiableBoundedCollection.java
> UnmodifiableBoundedCollection.unmodifiableBoundedCollection is an infinite
> loop
> ---
>
> Key: COLLECTIONS-380
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-380
> Project: Commons Collections
> Issue Type: Bug
> Components: Collection
>Reporter: Dave Brosius
>Priority: Minor
> Fix For: 4.0
>
>
> This method, just calls itself. As BoundedCollection extends Collection, it
> would seem to me that this method should be removed:
> /**
> * Factory method to create an unmodifiable bounded collection.
> *
> * @param coll the BoundedCollection to decorate, must not
> be null
> * @return a new unmodifiable bounded collection
> * @throws IllegalArgumentException if bag is null
> */
> public static BoundedCollection
> unmodifiableBoundedCollection(BoundedCollection coll) {
> return unmodifiableBoundedCollection(coll);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COLLECTIONS-391) Inconsistent Javadoc comment and code for toProperties(final Map) in org.apache.commons.collections.MapUtils
[
https://issues.apache.org/jira/browse/COLLECTIONS-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250052#comment-13250052
]
Hudson commented on COLLECTIONS-391:
Integrated in commons-collections #17 (See
[https://builds.apache.org/job/commons-collections/17/])
[COLLECTIONS-391] Fixed javadoc, thanks to Shin Hwei Tan. (Revision 1311359)
Result = SUCCESS
tn : http://svn.apache.org/viewvc/?view=rev&rev=1311359
Files :
*
/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/MapUtils.java
> Inconsistent Javadoc comment and code for toProperties(final Map) in
> org.apache.commons.collections.MapUtils
> --
>
> Key: COLLECTIONS-391
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-391
> Project: Commons Collections
> Issue Type: Bug
> Components: Collection
>Affects Versions: 4.0, 4.x
> Environment: Platform Indepedent
>Reporter: SHIN HWEI TAN
> Labels: javadoc, null
> Fix For: 4.0
>
> Original Estimate: 2m
> Remaining Estimate: 2m
>
> The Javadoc comment below states that the parameter map "..., may not be
> null":
> /**
> ..
>* @param map the map to convert to a Properties object, may not
> be null
>* @return the properties object
>*/
> public static Properties toProperties(final Map map) {
> Properties answer = new Properties();
> if (map != null) {
> ...
> }
> return answer;
> }
> However, the method return normally without throwing any exception when
> called with null.
> Suggested Fixes:
> 1. Change "@param map the map to convert to a Properties object, may not be
> null" to "@param map the map to convert to a Properties object, may be null"
> or
> 2. Remove "may not be null" from @param.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COLLECTIONS-389) Inconsistent Javadoc comment and code for mapTransformer(Map) in org.apache.commons.collections.TransformerUtils
[
https://issues.apache.org/jira/browse/COLLECTIONS-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249986#comment-13249986
]
Hudson commented on COLLECTIONS-389:
Integrated in commons-collections #16 (See
[https://builds.apache.org/job/commons-collections/16/])
[COLLECTIONS-389] Fixed javadoc, thanks to Shin Hwei Tan. (Revision 1311337)
Result = SUCCESS
tn : http://svn.apache.org/viewvc/?view=rev&rev=1311337
Files :
*
/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/TransformerUtils.java
> Inconsistent Javadoc comment and code for mapTransformer(Map extends O>) in org.apache.commons.collections.TransformerUtils
>
>
> Key: COLLECTIONS-389
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-389
> Project: Commons Collections
> Issue Type: Bug
> Components: Collection
>Affects Versions: 4.0, 4.x
> Environment: Platform Independent
>Reporter: SHIN HWEI TAN
> Labels: javadoc, null
> Fix For: 4.0
>
> Original Estimate: 2m
> Remaining Estimate: 2m
>
> The Javadoc comment below states that the method "throws
> IllegalArgumentException if the map is null":
> /**
>
>* @param map the map to use to transform the objects
>* @return the transformer
>* @throws IllegalArgumentException if the map is null
>*/
> public static Transformer mapTransformer(Map I, ? extends O> map) {
> return MapTransformer.mapTransformer(map);
> }
> However, the method returns a NULL_INSTANCE object instead of throwing
> IllegalArgumentException when called with null.
> Suggested Fixes:
> 1. Change "@throws IllegalArgumentException if the map is null" and "@return"
> to "@return NULL_INSTANCE if the map is null".
> or
> 2. Remove the entire "throws IllegalArgumentException if the map is null".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COLLECTIONS-400) Inconsistent Javadoc comment and code in addIgnoreNull(Collection, T) in org.apache.commons.collections.CollectionUtils
[
https://issues.apache.org/jira/browse/COLLECTIONS-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249987#comment-13249987
]
Hudson commented on COLLECTIONS-400:
Integrated in commons-collections #16 (See
[https://builds.apache.org/job/commons-collections/16/])
[COLLECTIONS-400] Added missing null check, thanks to Shin Hwei Tan.
(Revision 1311344)
Result = SUCCESS
tn : http://svn.apache.org/viewvc/?view=rev&rev=1311344
Files :
*
/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/CollectionUtils.java
> Inconsistent Javadoc comment and code in addIgnoreNull(Collection, T) in
> org.apache.commons.collections.CollectionUtils
> --
>
> Key: COLLECTIONS-400
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-400
> Project: Commons Collections
> Issue Type: Bug
> Components: Collection
>Affects Versions: 3.2.1
> Environment: Platform independent
>Reporter: SHIN HWEI TAN
> Labels: javadoc
> Fix For: 4.0
>
> Original Estimate: 0.05h
> Remaining Estimate: 0.05h
>
> The Javadoc comment below states that the method "throws NullPointerException
> if the collection is null".
> /**
> .
>* @param collection the collection to add to, must not be null
>* @param object the object to add, if null it will not be added
>* @return true if the collection changed
>* @throws NullPointerException if the collection is null
>*/
> public static boolean addIgnoreNull(Collection collection, T
> object) {
> return (object != null && collection.add(object));
> }
> However, when called with an null collection and a null object (i.e.,
> "addIgnoreNull((Collection)null, null)"), the method executes normally
> without throwing any exception.
> Suggested Fixes:
> 1. Add code "if (collection == null) throw NullPointerException();" at the
> beginning of the method body.
> or
> 2. Remove "@throws NullPointerException if the collection is null" from the
> Javadoc.
> or
> 3. Change "@throws NullPointerException if the collection is null" to
> "@throws NullPointerException if the collection is null and the object is
> non-null)".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COLLECTIONS-388) Inconsistent Javadoc comment and code for prototypeFactory(T) in org.apache.commons.collections.FactoryUtils
[
https://issues.apache.org/jira/browse/COLLECTIONS-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249988#comment-13249988
]
Hudson commented on COLLECTIONS-388:
Integrated in commons-collections #16 (See
[https://builds.apache.org/job/commons-collections/16/])
[COLLECTIONS-388] Fixed javadoc, thanks to Shin Hwei Tan. (Revision 1311334)
Result = SUCCESS
tn : http://svn.apache.org/viewvc/?view=rev&rev=1311334
Files :
*
/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/FactoryUtils.java
*
/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/PrototypeFactory.java
> Inconsistent Javadoc comment and code for prototypeFactory(T) in
> org.apache.commons.collections.FactoryUtils
>
>
> Key: COLLECTIONS-388
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-388
> Project: Commons Collections
> Issue Type: Bug
> Components: Collection
>Affects Versions: 4.0, 4.x
> Environment: Platform independent
>Reporter: SHIN HWEI TAN
> Labels: javadoc, null
> Fix For: 4.0
>
> Original Estimate: 2m
> Remaining Estimate: 2m
>
> The Javadoc comment below states that the method "throws
> IllegalArgumentException if the prototype is null":
> /**
>..
>* @param prototype the object to clone each time in the factory
>* @return the prototype factory
>* @throws IllegalArgumentException if the prototype is null
>* @throws IllegalArgumentException if the prototype cannot be
> cloned
>*/
> public static Factory prototypeFactory(T prototype) {
> return PrototypeFactory.prototypeFactory(prototype);
> }
> However, the method returns a NULL_INSTANCE object instead of throwing
> IllegalArgumentException when called with null.
> Suggested Fixes:
> 1. Change "@throws IllegalArgumentException if the prototype is null" and
> "@return" to "@return NULL_INSTANCE if the prototype is null".
> or
> 2. Remove the entire "throws IllegalArgumentException if the prototype is
> null".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-36) Link "Benchmarks" on left hand navigation is broken
[ https://issues.apache.org/jira/browse/OGNL-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155939#comment-13155939 ] Hudson commented on OGNL-36: Integrated in ognl #191 (See [https://builds.apache.org/job/ognl/191/]) OGNL-36 - Renamed benchmark file names mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1205464 Files : * /commons/proper/ognl/trunk/src/benchmarks/java/org/apache/commons/ognl/performance/BasePerformanceTest.java * /commons/proper/ognl/trunk/src/benchmarks/java/org/apache/commons/ognl/performance/PerformanceCommonsOgnlTest.java * /commons/proper/ognl/trunk/src/benchmarks/java/org/apache/commons/ognl/performance/PerformanceOldOgnlTest.java * /commons/proper/ognl/trunk/src/site/site.xml > Link "Benchmarks" on left hand navigation is broken > --- > > Key: OGNL-36 > URL: https://issues.apache.org/jira/browse/OGNL-36 > Project: OGNL > Issue Type: Bug >Reporter: Adrian Cumiskey >Assignee: Maurizio Cucchiara >Priority: Minor > Attachments: patch-OGNL36.txt > > > The forrest file src/site/xdoc/benchmark-ognl.xml is missing causing a broken > link to "Benchmarks" on the left hand navigation of the OGNL homepage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-39) Simplify OgnlRuntime
[
https://issues.apache.org/jira/browse/OGNL-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152792#comment-13152792
]
Hudson commented on OGNL-39:
Integrated in ognl #189 (See [https://builds.apache.org/job/ognl/189/])
Added OGNL-39 to the change list
OGNL-39 - Greatly simplified OgnlRuntime, delegating away responsibilities to
several new classes. Caching responsibilities are now taken by a new OgnlCache
class. I also added new classes PrimitiveWrapperClasses, NumericCasts,
PrimitiveDefaults, NumericValues, PrimitiveTypes, NumericLiterals and
NumericDefaults.
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1203595
Files :
* /commons/proper/ognl/trunk/src/changes/changes.xml
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1203594
Files :
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/NumericCasts.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/NumericDefaults.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/NumericLiterals.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/NumericValues.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlCache.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlOps.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/PrimitiveDefaults.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/PrimitiveTypes.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/PrimitiveWrapperClasses.java
*
/commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/TestOgnlRuntime.java
> Simplify OgnlRuntime
>
>
> Key: OGNL-39
> URL: https://issues.apache.org/jira/browse/OGNL-39
> Project: OGNL
> Issue Type: Improvement
>Reporter: Adrian Cumiskey
>Assignee: Maurizio Cucchiara
>Priority: Minor
> Attachments: patch-OGNL39.txt
>
>
> Greatly simplified OgnlRuntime, delegating away responsibilities to several
> new classes. Caching responsibilities are now taken by a new OgnlCache
> class. I also added new classes PrimitiveWrapperClasses, NumericCasts,
> PrimitiveDefaults, NumericValues, PrimitiveTypes, NumericLiterals and
> NumericDefaults.
> OgnlOps: Conditional simplification.
> Renamed Fie{dl,ld}CacheEntryFactory.
> TestOgnlRuntime, ClassCacheHandler: Lots of variable naming!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-39) Simplify OgnlRuntime
[
https://issues.apache.org/jira/browse/OGNL-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152781#comment-13152781
]
Hudson commented on OGNL-39:
Integrated in ognl #188 (See [https://builds.apache.org/job/ognl/188/])
OGNL-39 - Corrected typo: Renamed Fie{dl,ld}CacheEntryFactory.
OGNL-39 - Renamed local var
OGNL-39 - Corrected typo: Renamed Fie{dl,ld}CacheEntryFactory.
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1203585
Files :
*
/commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/internal/FieldCacheTest.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1203584
Files :
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ClassCacheHandler.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1203582
Files :
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/FiedlCacheEntryFactory.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/FieldCacheEntryFactory.java
> Simplify OgnlRuntime
>
>
> Key: OGNL-39
> URL: https://issues.apache.org/jira/browse/OGNL-39
> Project: OGNL
> Issue Type: Improvement
>Reporter: Adrian Cumiskey
>Priority: Minor
> Attachments: patch-OGNL39.txt
>
>
> Greatly simplified OgnlRuntime, delegating away responsibilities to several
> new classes. Caching responsibilities are now taken by a new OgnlCache
> class. I also added new classes PrimitiveWrapperClasses, NumericCasts,
> PrimitiveDefaults, NumericValues, PrimitiveTypes, NumericLiterals and
> NumericDefaults.
> OgnlOps: Conditional simplification.
> Renamed Fie{dl,ld}CacheEntryFactory.
> TestOgnlRuntime, ClassCacheHandler: Lots of variable naming!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-38) [PATCH] Use StringBuilder instead of StringBuffer, deprecate >=JDK1.5 conditionals and use CONSTANT.equals(variable).
[ https://issues.apache.org/jira/browse/OGNL-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145313#comment-13145313 ] Hudson commented on OGNL-38: Integrated in ognl #187 (See [https://builds.apache.org/job/ognl/187/]) Added OGNL-38 to the change list OGNL-38 - Use StringBuilder instead of StringBuffer, removed boxing, replaced for loop with foreach OGNL-38 - Use StringBuilder instead of StringBuffer. OGNL-38 - Variable naming, use StringBuilder instead of StringBuffer. Replace new String(stringBuffer) with stringBuffer.toString(). OGNL-38 - Variable naming, use StringBuilder instead of StringBuffer. Replace new String(stringBuffer) with stringBuffer.toString(). OGNL-38 - Test CONSTANT.equals(variable) and simplify conditionals. OGNL-38 - Removed useless extends object. mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198685 Files : * /commons/proper/ognl/trunk/src/changes/changes.xml mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198683 Files : * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/StaticsAndConstructorsTest.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198682 Files : * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/objects/MenuItem.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198681 Files : * /commons/proper/ognl/trunk/src/main/jjtree/ognl.jjt mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198680 Files : * /commons/proper/ognl/trunk/src/main/javacc/ognl.jj mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198679 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/SetPropertyAccessor.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198671 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java > [PATCH] Use StringBuilder instead of StringBuffer, deprecate >=JDK1.5 > conditionals and use CONSTANT.equals(variable). > - > > Key: OGNL-38 > URL: https://issues.apache.org/jira/browse/OGNL-38 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Assignee: Maurizio Cucchiara >Priority: Minor > Attachments: patch-OGNL38.txt > > > This patch replaces all StringBuffer references with StringBuilder for better > performance. Improved performance has not been verified but it is fairly > well established that StringBuilder performs better in single threaded use > cases (see > http://littletutorials.com/2008/07/16/stringbuffer-vs-stringbuilder-performance-comparison/). > All JDK1.5 checking has also been deprecated/removed since OGNL is now > dependent upon >=JDK1.5 these days. Lastly, all remaining > variable.equals(CONSTANT) has been flipped to the null safe > CONSTANT.equals(variable). > A list of modified classes and changes are given here :- > MenuItem: toString() now uses a chained StringBuilder instead of StringBuffer. > StaticsAndConstructorsTest: use StringBuilder instead of StringBuffer. > EnumerationPropertyAccessor: Test CONSTANT.equals(variable). > ExpressionCompiler: Test CONSTANT.equals(variable). > ASTMethod: Variable naming (don't use acronyms), remove OgnlRuntime.isJdk15() > check. > OgnlRuntime: > * Remove JDK1.5 checking since OGNL now requires >=JDK1.5. > * The isJdk15() method is now deprecated. > * Variable naming (don't use acronyms. > * getPointerString(int) now uses StringBuilder instead of StringBuffer. > * getUniqueDescriptor(Object, boolean) now uses StringBuilder instead of > StringBuffer. > * package private method findType() unused to removed. > * Simplify getMethods(Class,boolean) with ternary. > * getStaticField(OgnlContext,String,String) test CONSTANT.equals(variable) > and remove JDK1.5 conditionals. > * A lot of variable naming! > SetPropertyAccessor: Test CONSTANT.equals(variable) and simplify conditionals. > ASTStaticField: Test CONSTANT.equals(variable), remove JDK1.5 conditionals > and variable naming. > MapPropertyAccessor: Simplify conditionals. > ArrayPropertyAccessor: Test CONSTANT.equals(variable). > IteratorPropertyAccessor: Test CONSTANT.equals(variable). > OgnlOps: Use StringBuilder instead of StringBuffer. > ognl.jjt: Variable naming, use StringBuilder instead of StringBuffer. Replace > new String(stringBuffer) with stringBuffer.toString(). > Cheers, Adrian. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-38) [PATCH] Use StringBuilder instead of StringBuffer, deprecate >=JDK1.5 conditionals and use CONSTANT.equals(variable).
[ https://issues.apache.org/jira/browse/OGNL-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145297#comment-13145297 ] Hudson commented on OGNL-38: Integrated in ognl #186 (See [https://builds.apache.org/job/ognl/186/]) OGNL-38 - Remove JDK1.5 checking since OGNL now requires >=JDK1.5. The isJdk15() method is now deprecated. Variable naming (don't use acronyms. getPointerString(int) now uses StringBuilder instead of StringBuffer. getUniqueDescriptor(Object, boolean) now uses StringBuilder instead of StringBuffer. package private method findType() unused to removed. Simplify getMethods(Class,boolean) with ternary. getStaticField(OgnlContext,String,String) test CONSTANT.equals(variable) and remove JDK1.5 conditionals. A lot of variable naming! OGNL-38 - Use StringBuilder instead of StringBuffer. OGNL-38 - Simplify conditionals. OGNL-38 - Test CONSTANT.equals(variable). OGNL-38 - Test CONSTANT.equals(variable). OGNL-38 - Test CONSTANT.equals(variable), remove JDK1.5 conditionals and variable naming. OGNL-38 - Variable naming (don't use acronyms), remove OgnlRuntime.isJdk15() check. OGNL-38 - Test CONSTANT.equals(variable). OGNL-38 - Test CONSTANT.equals(variable). mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198670 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198668 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlOps.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198666 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/MapPropertyAccessor.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198665 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/IteratorPropertyAccessor.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198664 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EnumerationPropertyAccessor.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198661 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticField.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198659 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198657 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ArrayPropertyAccessor.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1198656 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java > [PATCH] Use StringBuilder instead of StringBuffer, deprecate >=JDK1.5 > conditionals and use CONSTANT.equals(variable). > - > > Key: OGNL-38 > URL: https://issues.apache.org/jira/browse/OGNL-38 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Priority: Minor > Attachments: patch-OGNL38.txt > > > This patch replaces all StringBuffer references with StringBuilder for better > performance. Improved performance has not been verified but it is fairly > well established that StringBuilder performs better in single threaded use > cases (see > http://littletutorials.com/2008/07/16/stringbuffer-vs-stringbuilder-performance-comparison/). > All JDK1.5 checking has also been deprecated/removed since OGNL is now > dependent upon >=JDK1.5 these days. Lastly, all remaining > variable.equals(CONSTANT) has been flipped to the null safe > CONSTANT.equals(variable). > A list of modified classes and changes are given here :- > MenuItem: toString() now uses a chained StringBuilder instead of StringBuffer. > StaticsAndConstructorsTest: use StringBuilder instead of StringBuffer. > EnumerationPropertyAccessor: Test CONSTANT.equals(variable). > ExpressionCompiler: Test CONSTANT.equals(variable). > ASTMethod: Variable naming (don't use acronyms), remove OgnlRuntime.isJdk15() > check. > OgnlRuntime: > * Remove JDK1.5 checking since OGNL now requires >=JDK1.5. > * The isJdk15() method is now deprecated. > * Variable naming (don't use acronyms. > * getPointerString(int) now uses StringBuilder instead of StringBuffer. > * getUniqueDescriptor(Object, boolean) now uses StringBuilder instead of > StringBuffer. > * package private method findType() unused to removed. > * Simplify getMethods(Class,boolean) with ternary. > * getStaticField(OgnlContext,String,String) test CONSTANT.equals(variable) > and remove JDK1.5 conditionals. > * A lot of variable naming! > SetPropertyAccessor: Test CONSTANT.equals(variable) and simplify conditionals. > ASTStaticField: Test CONSTANT.equals(vari
[jira] [Commented] (OGNL-35) [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
[
https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143882#comment-13143882
]
Hudson commented on OGNL-35:
Integrated in ognl #185 (See [https://builds.apache.org/job/ognl/185/])
Added OGNL-35 to the change list
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197467
Files :
* /commons/proper/ognl/trunk/src/changes/changes.xml
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
>
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
>Reporter: Adrian Cumiskey
>Assignee: Maurizio Cucchiara
>Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String
> constant.
> * ListPropertyAccessor: CPD fix, extracted shared method
> getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from
> toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from
> getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-35) [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
[
https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143866#comment-13143866
]
Hudson commented on OGNL-35:
Integrated in ognl #184 (See [https://builds.apache.org/job/ognl/184/])
OGNL-35 - Flipped equals() everywhere where a variable is tested against a
String constant.
OGNL-35 - CPD fix, extracted shared method getSourceBeanMethod() from
getSourceSetter() and getSourceAccessor().
OGNL-35 - CPD fix, extracted shared method getSourceString() from
toGetSourceString() and toSetSourceString().
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197452
Files :
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/MapPropertyAccessor.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197448
Files :
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ListPropertyAccessor.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197443
Files :
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProperty.java
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
>
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
>Reporter: Adrian Cumiskey
>Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String
> constant.
> * ListPropertyAccessor: CPD fix, extracted shared method
> getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from
> toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from
> getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-35) [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
[
https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143844#comment-13143844
]
Hudson commented on OGNL-35:
Integrated in ognl #183 (See [https://builds.apache.org/job/ognl/183/])
OGNL-35 - CPD fix, extracted getIndexString() from getSourceAccessor() and
getSourceSetter().
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197437
Files :
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ArrayPropertyAccessor.java
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
>
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
>Reporter: Adrian Cumiskey
>Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String
> constant.
> * ListPropertyAccessor: CPD fix, extracted shared method
> getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from
> toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from
> getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143843#comment-13143843 ] Hudson commented on OGNL-37: Integrated in ognl #183 (See [https://builds.apache.org/job/ognl/183/]) Added OGNL-37 to the change list mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197432 Files : * /commons/proper/ognl/trunk/src/changes/changes.xml > [PATCH] Findbugs fixes > -- > > Key: OGNL-37 > URL: https://issues.apache.org/jira/browse/OGNL-37 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Assignee: Maurizio Cucchiara >Priority: Minor > Attachments: patch-OGNL37.txt > > > ExpressionNode: Use StringBuilder instead of String concatenation with '+'. > ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() > implementation to override PropertyDescriptor. > ExpressionCompiler: Remove redundant attempt to remove LocalReference key > (keys are always of type String). > ASTMethod: Use StringBuilder instead of String concatenation with '+'. > DeclaredMethodCacheEntry: Modified equals() implementation to take account of > super class fields. > OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet > for better performance. Javadoc improvements. > ASTChain: Remove int boxing, lets rely on autoboxing. > ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code. > OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary > conditional checking. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143034#comment-13143034 ] Hudson commented on OGNL-37: Integrated in ognl #182 (See [https://builds.apache.org/job/ognl/182/]) OGNL-37 - Avoid concurrentModificationException mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197043 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java > [PATCH] Findbugs fixes > -- > > Key: OGNL-37 > URL: https://issues.apache.org/jira/browse/OGNL-37 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Assignee: Maurizio Cucchiara >Priority: Minor > Attachments: patch-OGNL37.txt > > > ExpressionNode: Use StringBuilder instead of String concatenation with '+'. > ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() > implementation to override PropertyDescriptor. > ExpressionCompiler: Remove redundant attempt to remove LocalReference key > (keys are always of type String). > ASTMethod: Use StringBuilder instead of String concatenation with '+'. > DeclaredMethodCacheEntry: Modified equals() implementation to take account of > super class fields. > OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet > for better performance. Javadoc improvements. > ASTChain: Remove int boxing, lets rely on autoboxing. > ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code. > OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary > conditional checking. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143012#comment-13143012 ] Hudson commented on OGNL-37: Integrated in ognl #181 (See [https://builds.apache.org/job/ognl/181/]) OGNL-37 - Corrected attempt to remove LocalReference (keys was always of type String). OGNL-37 - Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements. OGNL-37 - use valueOf() instead of new for boxing. Adjust unnecessary conditional checking. mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197034 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197024 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197020 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlOps.java > [PATCH] Findbugs fixes > -- > > Key: OGNL-37 > URL: https://issues.apache.org/jira/browse/OGNL-37 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Priority: Minor > Attachments: patch-OGNL37.txt > > > ExpressionNode: Use StringBuilder instead of String concatenation with '+'. > ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() > implementation to override PropertyDescriptor. > ExpressionCompiler: Remove redundant attempt to remove LocalReference key > (keys are always of type String). > ASTMethod: Use StringBuilder instead of String concatenation with '+'. > DeclaredMethodCacheEntry: Modified equals() implementation to take account of > super class fields. > OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet > for better performance. Javadoc improvements. > ASTChain: Remove int boxing, lets rely on autoboxing. > ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code. > OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary > conditional checking. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142990#comment-13142990 ] Hudson commented on OGNL-37: Integrated in ognl #180 (See [https://builds.apache.org/job/ognl/180/]) OGNL-37 - Provide equals() and hashcode() implementation to override PropertyDescriptor. OGNL-37 - Use StringBuilder instead of String concatenation with '+'. OGNL-37 - Use StringBuilder instead of String concatenation with '+'. OGNL-37 - Replaced for loops with foreach version. OGNL-37 - Remove int boxing, lets rely on autoboxing. OGNL-37 - Remove unnecessary int boxing and redundant code. mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197018 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ObjectIndexedPropertyDescriptor.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197015 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ExpressionNode.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197014 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197011 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197009 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197007 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ArrayPropertyAccessor.java > [PATCH] Findbugs fixes > -- > > Key: OGNL-37 > URL: https://issues.apache.org/jira/browse/OGNL-37 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Priority: Minor > Attachments: patch-OGNL37.txt > > > ExpressionNode: Use StringBuilder instead of String concatenation with '+'. > ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() > implementation to override PropertyDescriptor. > ExpressionCompiler: Remove redundant attempt to remove LocalReference key > (keys are always of type String). > ASTMethod: Use StringBuilder instead of String concatenation with '+'. > DeclaredMethodCacheEntry: Modified equals() implementation to take account of > super class fields. > OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet > for better performance. Javadoc improvements. > ASTChain: Remove int boxing, lets rely on autoboxing. > ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code. > OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary > conditional checking. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142969#comment-13142969 ] Hudson commented on OGNL-37: Integrated in ognl #179 (See [https://builds.apache.org/job/ognl/179/]) OGNL-37 - Modified equals() implementation to take account of super class fields. OGNL-37 - Use Map.entrySet instead of Map.keySet for better performance. mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197002 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/DeclaredMethodCacheEntry.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1196996 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlContext.java > [PATCH] Findbugs fixes > -- > > Key: OGNL-37 > URL: https://issues.apache.org/jira/browse/OGNL-37 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Priority: Minor > Attachments: patch-OGNL37.txt > > > ExpressionNode: Use StringBuilder instead of String concatenation with '+'. > ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() > implementation to override PropertyDescriptor. > ExpressionCompiler: Remove redundant attempt to remove LocalReference key > (keys are always of type String). > ASTMethod: Use StringBuilder instead of String concatenation with '+'. > DeclaredMethodCacheEntry: Modified equals() implementation to take account of > super class fields. > OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet > for better performance. Javadoc improvements. > ASTChain: Remove int boxing, lets rely on autoboxing. > ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code. > OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary > conditional checking. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-36) Link "Benchmarks" on left hand navigation is broken
[ https://issues.apache.org/jira/browse/OGNL-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141036#comment-13141036 ] Hudson commented on OGNL-36: Integrated in ognl #178 (See [https://builds.apache.org/job/ognl/178/]) OGNL-36 - Link "Benchmarks" on left hand navigation is broken (contributed by Adrian Cumiskey). mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1195879 Files : * /commons/proper/ognl/trunk/src/changes/changes.xml * /commons/proper/ognl/trunk/src/site/site.xml > Link "Benchmarks" on left hand navigation is broken > --- > > Key: OGNL-36 > URL: https://issues.apache.org/jira/browse/OGNL-36 > Project: OGNL > Issue Type: Bug >Reporter: Adrian Cumiskey >Priority: Minor > Attachments: patch-OGNL36.txt > > > The forrest file src/site/xdoc/benchmark-ognl.xml is missing causing a broken > link to "Benchmarks" on the left hand navigation of the OGNL homepage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COLLECTIONS-384) Inconsistent Javadoc comment and code for synchronizedMap(Map) in org.apache.commons.collections.MapUtils
[
https://issues.apache.org/jira/browse/COLLECTIONS-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139439#comment-13139439
]
Hudson commented on COLLECTIONS-384:
Integrated in commons-collections #2 (See
[https://builds.apache.org/job/commons-collections/2/])
[COLLECTIONS-384] Inconsistent Javadoc comment and code for
synchronizedMap(Map) in org.apache.commons.collections.MapUtils.
ggregory : http://svn.apache.org/viewvc/?view=rev&rev=1195031
Files :
*
/commons/proper/collections/trunk/src/java/org/apache/commons/collections/MapUtils.java
> Inconsistent Javadoc comment and code for synchronizedMap(Map) in
> org.apache.commons.collections.MapUtils
> -
>
> Key: COLLECTIONS-384
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-384
> Project: Commons Collections
> Issue Type: Bug
> Components: Collection
>Affects Versions: 3.0, 3.1, 3.2
> Environment: Platform independent
>Reporter: SHIN HWEI TAN
> Labels: code, javadoc, synchronizedMap
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The Javadoc comment below states that the method "throws
> IllegalArgumentException if the map is null":
> /**
> ...
> * @param map the map to synchronize, must not be null
> * @return a synchronized map backed by the given map
> * @throws IllegalArgumentException if the map is null
> */
> public static Map synchronizedMap(Map map) {
> return Collections.synchronizedMap(map);
> }
> However, the method throws NullPointerException instead of
> IllegalArgumentException when called with null.
> Suggested Fixes:
> 1. Add code "if (map == null) throw IllegalArgumentException();" at the
> beginning of the method body.
> or
> 2. Change "@throws IllegalArgumentException if the map is null" to "@throws
> NullPointerException if the map is null".
> or
> 3. Remove the entire "@throws IllegalArgumentException if the map is null".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-11) Checkstyle configuration is broken and fix some checktyle issues
[ https://issues.apache.org/jira/browse/OGNL-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139391#comment-13139391 ] Hudson commented on OGNL-11: Integrated in ognl #177 (See [https://builds.apache.org/job/ognl/177/]) OGNL-11: fixed checkstyle errors (Fixed svn id position) OGNL-11: fixed checkstyle errors (Fixed licence header position) OGNL-11: fixed checkstyle errors (Fixed licence header position) OGNL-11: fixed checkstyle errors (Line is longer than 120 characters) OGNL-11: fixed checkstyle errors (Fixed licence header position) mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194962 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194961 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194960 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/PropertyDescriptorCacheEntryFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/package-info.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/package-info.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194959 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/PermissionCacheEntryFactory.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194957 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/MethodCacheEntryFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/MethodPermCacheEntryFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/PermissionCacheEntry.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/PermissionCacheEntryFactory.java > Checkstyle configuration is broken and fix some checktyle issues > > > Key: OGNL-11 > URL: https://issues.apache.org/jira/browse/OGNL-11 > Project: OGNL > Issue Type: Bug >Reporter: Simone Tripodi >Assignee: Olivier Lamy > > TabCharacter module is misconfigured and cause a fail with both Mavven 2/3, > refer to discussion on dev ML[1] > [1] http://markmail.org/message/mgkzlzdi4xlz7hpp -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-11) Checkstyle configuration is broken and fix some checktyle issues
[ https://issues.apache.org/jira/browse/OGNL-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139383#comment-13139383 ] Hudson commented on OGNL-11: Integrated in ognl #176 (See [https://builds.apache.org/job/ognl/176/]) OGNL-11: fixed checkstyle errors (Fixed licence header position) OGNL-11: fixed checkstyle errors (Fixed licence header position) OGNL-11: fixed checkstyle errors (Fixed licence header position, also added missing spaces) OGNL-11: fixed checkstyle errors (Fixed licence header position) OGNL-11: fixed checkstyle errors (renamed local variables according with the naming convention) OGNL-11: fixed checkstyle errors (removed inner assignment) OGNL-11: fixed checkstyle errors (Fixed licence header position) OGNL-11: fixed checkstyle errors (Line does not match expected licence header) OGNL-11: fixed checkstyle errors (Line does not match expected header line of '^package) mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194956 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/GenericMethodParameterTypeFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/MethodAccessCacheEntryFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/MethodAccessEntryValue.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/MethodCacheEntry.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194954 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/HashMapCache.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/HashMapCacheFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/HashMapClassCache.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ReentrantReadWriteLockCache.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ReentrantReadWriteLockCacheFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ReentrantReadWriteLockClassCache.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/CacheEntry.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/CacheEntryFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/ClassCacheEntryFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/DeclaredMethodCacheEntry.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/DeclaredMethodCacheEntryFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/FiedlCacheEntryFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/GenericMethodParameterTypeCacheEntry.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194951 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/Entry.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194950 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ConcurrentHashMapCache.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ConcurrentHashMapCacheFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ConcurrentHashMapClassCache.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194946 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ClassCacheImpl.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194945 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ClassCacheHandler.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194944 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/CacheFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ClassCache.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ClassCacheHandler.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ClassCacheImpl.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194943 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/Cache.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/CacheException.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194942 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/Cache.java > Checkstyle configuration is broken and fix some checktyle issues > > > Key: OGNL-11 >
[jira] [Commented] (OGNL-11) Checkstyle configuration is broken and fix some checktyle issues
[ https://issues.apache.org/jira/browse/OGNL-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139190#comment-13139190 ] Hudson commented on OGNL-11: Integrated in ognl #175 (See [https://builds.apache.org/job/ognl/175/]) OGNL-11: fixed checkstyle errors OGNL-11: fixed checkstyle errors OGNL-11: fixed checkstyle errors OGNL-11: fixed checkstyle errors OGNL-11: fixed checkstyle errors mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194875 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/LocalReferenceImpl.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/OrderedReturn.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/package-info.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194873 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194869 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAdd.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAnd.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAssign.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitAnd.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitNegate.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitOr.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTConst.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTCtor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTDivide.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTEval.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTGreater.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTGreaterEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTIn.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTInstanceof.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTKeyValue.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTLess.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTLessEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTList.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMap.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMultiply.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNegate.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNot.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNotEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNotIn.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTOr.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProject.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProperty.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTRemainder.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTRootVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelect.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelectFirst.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelectLast.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSequence.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTShiftLeft.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTShiftRight.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticMethod.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSubtract.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTTest.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTUnsignedShiftRight.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTXor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ComparisonExpression.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ExpressionNode.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/NumericExpr
[jira] [Commented] (OGNL-11) Checkstyle configuration is broken and fix some checktyle issues
[ https://issues.apache.org/jira/browse/OGNL-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139188#comment-13139188 ] Hudson commented on OGNL-11: Integrated in ognl #174 (See [https://builds.apache.org/job/ognl/174/]) OGNL-11: fixed checkstyle errors mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1194866 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAdd.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTList.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethodUtil.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProperty.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ArrayPropertyAccessor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/DefaultClassResolver.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/DefaultTypeConverter.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/JJTOgnlParserState.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/JavaSource.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ListPropertyAccessor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/Node.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/NodeVisitor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/NumericExpression.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ObjectMethodAccessor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ObjectPropertyAccessor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/Ognl.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlContext.java > Checkstyle configuration is broken and fix some checktyle issues > > > Key: OGNL-11 > URL: https://issues.apache.org/jira/browse/OGNL-11 > Project: OGNL > Issue Type: Bug >Reporter: Simone Tripodi >Assignee: Olivier Lamy > > TabCharacter module is misconfigured and cause a fail with both Mavven 2/3, > refer to discussion on dev ML[1] > [1] http://markmail.org/message/mgkzlzdi4xlz7hpp -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-17) Links "Download" and "Release Notes" on http://incubator.apache.org/ognl/index.html does not work
[ https://issues.apache.org/jira/browse/OGNL-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139150#comment-13139150 ] Hudson commented on OGNL-17: Integrated in ognl #172 (See [https://builds.apache.org/job/ognl/172/]) Added OGNL-17 in the issues list mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1190765 Files : * /commons/proper/ognl/trunk/src/changes/changes.xml > Links "Download" and "Release Notes" on > http://incubator.apache.org/ognl/index.html does not work > - > > Key: OGNL-17 > URL: https://issues.apache.org/jira/browse/OGNL-17 > Project: OGNL > Issue Type: Bug >Reporter: Thomas Mauch > Labels: website > > The listed links do not work. > Is there another place where I can download the library? > Or - if currently no download is available - when will it be available? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-17) Links "Download" and "Release Notes" on http://incubator.apache.org/ognl/index.html does not work
[ https://issues.apache.org/jira/browse/OGNL-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139146#comment-13139146 ] Hudson commented on OGNL-17: Integrated in ognl #171 (See [https://builds.apache.org/job/ognl/171/]) OGNL-17 - Links "Download" and "Release Notes" do not work mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1190764 Files : * /commons/proper/ognl/trunk/src/site/site.xml > Links "Download" and "Release Notes" on > http://incubator.apache.org/ognl/index.html does not work > - > > Key: OGNL-17 > URL: https://issues.apache.org/jira/browse/OGNL-17 > Project: OGNL > Issue Type: Bug >Reporter: Thomas Mauch > Labels: website > > The listed links do not work. > Is there another place where I can download the library? > Or - if currently no download is available - when will it be available? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-32) [PATCH] CPD fix to ASTProperty
[ https://issues.apache.org/jira/browse/OGNL-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139129#comment-13139129 ] Hudson commented on OGNL-32: Integrated in ognl #170 (See [https://builds.apache.org/job/ognl/170/]) Added OGNL-32 in the issue list OGNL-32 - CPD fix to ASTProperty (contributed by Adrian Cumiskey) mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1190759 Files : * /commons/proper/ognl/trunk/src/changes/changes.xml mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1190758 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProperty.java > [PATCH] CPD fix to ASTProperty > -- > > Key: OGNL-32 > URL: https://issues.apache.org/jira/browse/OGNL-32 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Assignee: Maurizio Cucchiara >Priority: Minor > Attachments: patch-OGNL32.txt > > > Extracted a new getTarget() method from two copy paste duplications found in > ASTProperty. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-33) [PATCH] Improvements to JJTOgnlParserState
[ https://issues.apache.org/jira/browse/OGNL-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139130#comment-13139130 ] Hudson commented on OGNL-33: Integrated in ognl #170 (See [https://builds.apache.org/job/ognl/170/]) OGNL-33 - Improvements to JJTOgnlParserState (contributed by Adrian Cumiskey) mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1190760 Files : * /commons/proper/ognl/trunk/src/changes/changes.xml * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/JJTOgnlParserState.java > [PATCH] Improvements to JJTOgnlParserState > -- > > Key: OGNL-33 > URL: https://issues.apache.org/jira/browse/OGNL-33 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Assignee: Maurizio Cucchiara >Priority: Minor > Attachments: patch-OGNL33.txt > > > JJTOgnlParserState was looking a little old school. > * Introduced generics on the "nodes" and "marks" List. > * Replaced 1-3 character acronyms with meaningful, camel case variable names. > * Removed unnecessary use of (un)boxing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-31) [PATCH] Some CPD fixes around ASTMethod and ASTStaticMethod.
[ https://issues.apache.org/jira/browse/OGNL-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138555#comment-13138555 ] Hudson commented on OGNL-31: Integrated in ognl #169 (See [https://builds.apache.org/job/ognl/169/]) OGNL-31 - Added compiler performance test Added OGNL-31 to the change list OGNL-31 - Some CPD fixes around ASTMethod and ASTStaticMethod (contributed by Adrian Cumiskey) mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1190443 Files : * /commons/proper/ognl/trunk/src/benchmarks/java/org/apache/commons/ognl/performance/BasePerformanceTest.java * /commons/proper/ognl/trunk/src/benchmarks/java/org/apache/commons/ognl/performance/invocation/CompilerInvocation.java * /commons/proper/ognl/trunk/src/benchmarks/java/org/apache/commons/ognl/performance/runtime/CommonsRuntimeWrapper.java * /commons/proper/ognl/trunk/src/benchmarks/java/org/apache/commons/ognl/performance/runtime/OldOgnlRuntimeWrapper.java * /commons/proper/ognl/trunk/src/benchmarks/java/org/apache/commons/ognl/performance/runtime/RuntimeWrapper.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1190437 Files : * /commons/proper/ognl/trunk/src/changes/changes.xml mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1190434 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethodUtil.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticMethod.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/TestOgnlRuntime.java > [PATCH] Some CPD fixes around ASTMethod and ASTStaticMethod. > > > Key: OGNL-31 > URL: https://issues.apache.org/jira/browse/OGNL-31 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Assignee: Maurizio Cucchiara >Priority: Minor > Attachments: patch-OGNL31-v2.txt, patch-OGNL31.txt > > > I discovered a number of PMD CPD issues around ASTMethod and ASTStaticMethod > class, there was quite a bit of duplication there. > This patch comes courtesy of the wifi connection in my local laundry-mat here > in Milwaukee. Its strange the things people will do to make their clothes > wash more quickly :-). > Cheers, Adrian. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-28) Visitor pattern needs way to propagate exceptions.
[ https://issues.apache.org/jira/browse/OGNL-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135531#comment-13135531 ] Hudson commented on OGNL-28: Integrated in ognl #161 (See [https://builds.apache.org/job/ognl/161/]) OGNL-28 - Visitor pattern needs way to propagate exceptions (recovered after the merge) mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1188958 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAdd.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/NodeVisitor.java > Visitor pattern needs way to propagate exceptions. > -- > > Key: OGNL-28 > URL: https://issues.apache.org/jira/browse/OGNL-28 > Project: OGNL > Issue Type: Improvement >Reporter: Daniel Pitts > Attachments: Visitor_with_exceptions.patch > > > The previous patch I created for NodeVisitor neglects the fact that some > visitors may wish to throw exceptions. I've created a patch in which all > "accept" and "visit" methods throw OgnlException. > Patch to come. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-20) Performance - Replace synchronized blocks with ReentrantReadWriteLock
[ https://issues.apache.org/jira/browse/OGNL-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133777#comment-13133777 ] Hudson commented on OGNL-20: Integrated in ognl #147 (See [https://builds.apache.org/job/ognl/147/]) Added OGNL-20 in the issue list OGNL-20 - Performance - Replace synchronized blocks with ReentrantReadWriteLock mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1188001 Files : * /commons/proper/ognl/trunk/src/changes/changes.xml mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1188000 Files : * /commons/proper/ognl/trunk * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAdd.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAnd.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAssign.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitAnd.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitOr.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ArrayPropertyAccessor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/DefaultTypeConverter.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ExpressionNode.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/MethodAccessor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/NodeVisitor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ObjectArrayPool.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ObjectMethodAccessor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ObjectPropertyAccessor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/Ognl.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlOps.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/TypeConverter.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/Cache.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/CacheException.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/CacheFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ClassCache.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ClassCacheHandler.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ClassCacheImpl.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ConcurrentHashMapCache.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ConcurrentHashMapCacheFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ConcurrentHashMapClassCache.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/Entry.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/HashMapCache.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/HashMapCacheFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/HashMapClassCache.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ReentrantReadWriteLockCache.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ReentrantReadWriteLockCacheFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/ReentrantReadWriteLockClassCache.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/CacheEntry.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/CacheEntryFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/ClassCacheEntryFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/DeclaredMethodCacheEntry.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/DeclaredMethodCacheEntryFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/FiedlCacheEntryFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/GenericMethodParameterTypeCacheEntry.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/GenericMethodParameterTypeFactory.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/Me
[jira] [Commented] (OGNL-22) Change the generics signature of ClassCache and ClassCacheImpl.
[ https://issues.apache.org/jira/browse/OGNL-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133778#comment-13133778 ] Hudson commented on OGNL-22: Integrated in ognl #147 (See [https://builds.apache.org/job/ognl/147/]) Added OGNL-22 in the issue list mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1188002 Files : * /commons/proper/ognl/trunk/src/changes/changes.xml > Change the generics signature of ClassCache and ClassCacheImpl. > --- > > Key: OGNL-22 > URL: https://issues.apache.org/jira/browse/OGNL-22 > Project: OGNL > Issue Type: Sub-task >Reporter: Daniel Pitts >Assignee: Maurizio Cucchiara > > Right now, ClassCache and ClassCacheImpl use some generics, but they do > casting at the method level, which leads to possible ClassCastException, and > doesn't quite support safe static typing. > I'll be glad to provide a patch when I have some time. I'd like to have > OGNL-21 resolved first, as it reduces the amount of code I'd have to touch to > implement this change. > The proposed signatures would be interface ClassCache and class > ClassCacheImpl implements ClassCache > Changing the get/put methods to take and return "V" type objects. > Alternative to this is to replace all of them with a "ConcurrentMap, > V>". -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-23) Class.forName() usage is malicious inside OSGi
[
https://issues.apache.org/jira/browse/OGNL-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133621#comment-13133621
]
Hudson commented on OGNL-23:
Integrated in ognl #145 (See [https://builds.apache.org/job/ognl/145/])
[OGNL-23] Class.forName() usage is malicious inside OSGi (contributed by
Adrian Cumiskey)
simonetripodi : http://svn.apache.org/viewvc/?view=rev&rev=1187867
Files :
* /commons/proper/ognl/trunk/src/changes/changes.xml
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAnd.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAssign.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTCtor.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTList.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMap.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTOr.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProperty.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticMethod.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTTest.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTVarRef.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ClassResolver.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/DefaultClassResolver.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ObjectPropertyAccessor.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlContext.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java
*
/commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/TestOgnlRuntime.java
*
/commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/ASTMethodTest.java
*
/commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/objects/BeanProviderAccessor.java
> Class.forName() usage is malicious inside OSGi
> --
>
> Key: OGNL-23
> URL: https://issues.apache.org/jira/browse/OGNL-23
> Project: OGNL
> Issue Type: Bug
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
> Attachments: patch-OGNL23-v2.txt, patch-OGNL23.txt
>
>
> {{Class.forName()}} could make OGNL unusable [inside
> OSGi|http://olegz.wordpress.com/2008/11/05/osgi-and-classforname/].
> The fix would involve the {{ClassLoader.loadClass()}} method, allowing users
> setting a custom {{ClassLoader}
> Classes affected by that issues are:
> * {{org.apache.commons.ognl.DefaultClassResolver}}
> * {{org.apache.commons.ognl.OgnlRuntime}}
> The {{org.apache.commons.ognl.ASTMap}} class is affected as well, even if
> loading {{java.util.LinkedHashMap}} in that way should be safe.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-11) Checkstyle configuration is broken and fix some checktyle issues
[ https://issues.apache.org/jira/browse/OGNL-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128702#comment-13128702 ] Hudson commented on OGNL-11: Integrated in ognl #144 (See [https://builds.apache.org/job/ognl/144/]) reverted OGNL-11 renaming is at conflicts with generated code grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1185022 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/DynamicSubscript.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/objects/Root.java > Checkstyle configuration is broken and fix some checktyle issues > > > Key: OGNL-11 > URL: https://issues.apache.org/jira/browse/OGNL-11 > Project: OGNL > Issue Type: Bug >Reporter: Simone Tripodi >Assignee: Olivier Lamy > > TabCharacter module is misconfigured and cause a fail with both Mavven 2/3, > refer to discussion on dev ML[1] > [1] http://markmail.org/message/mgkzlzdi4xlz7hpp -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-11) Checkstyle configuration is broken and fix some checktyle issues
[ https://issues.apache.org/jira/browse/OGNL-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128695#comment-13128695 ] Hudson commented on OGNL-11: Integrated in ognl #143 (See [https://builds.apache.org/job/ognl/143/]) OGNL-11: fixed checkstyle errors grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1185014 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTCtor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTInstanceof.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProperty.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTRootVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelect.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSequence.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticField.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticMethod.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTTest.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ArrayPropertyAccessor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/DefaultClassResolver.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/DynamicSubscript.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ElementsAccessor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/Evaluation.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ExpressionNode.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/JJTOgnlParserState.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/JavaSource.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/objects/Root.java > Checkstyle configuration is broken and fix some checktyle issues > > > Key: OGNL-11 > URL: https://issues.apache.org/jira/browse/OGNL-11 > Project: OGNL > Issue Type: Bug >Reporter: Simone Tripodi >Assignee: Olivier Lamy > > TabCharacter module is misconfigured and cause a fail with both Mavven 2/3, > refer to discussion on dev ML[1] > [1] http://markmail.org/message/mgkzlzdi4xlz7hpp -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-28) Visitor pattern needs way to propagate exceptions.
[ https://issues.apache.org/jira/browse/OGNL-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128549#comment-13128549 ] Hudson commented on OGNL-28: Integrated in ognl #142 (See [https://builds.apache.org/job/ognl/142/]) added OGNL-28 issue OGNL-28 - Visitor pattern needs way to propagate exceptions. (contributed by Daniel Pitts) mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1184965 Files : * /commons/proper/ognl/trunk/src/changes/changes.xml mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1184964 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAdd.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAnd.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAssign.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitAnd.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitNegate.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitOr.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTConst.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTCtor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTDivide.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTEval.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTGreater.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTGreaterEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTIn.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTInstanceof.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTKeyValue.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTLess.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTLessEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTList.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMap.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMultiply.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNegate.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNot.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNotEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNotIn.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTOr.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProject.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProperty.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTRemainder.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTRootVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelect.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelectFirst.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelectLast.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSequence.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTShiftLeft.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTShiftRight.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticField.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticMethod.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSubtract.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTTest.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTThisVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTUnsignedShiftRight.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTXor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/Node.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/NodeVisitor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/SimpleNode.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ToStringVisitor.java > Visitor pattern needs way to propagate exceptions. > -- > > Key: OGNL-28 > URL: https://issues.apache.org/jira/bro
[jira] [Commented] (OGNL-27) Move "toString" implementations into visitor pattern.
[ https://issues.apache.org/jira/browse/OGNL-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128471#comment-13128471 ] Hudson commented on OGNL-27: Integrated in ognl #141 (See [https://builds.apache.org/job/ognl/141/]) added OGNL-27 in the issue list [OGNL-27] Move toString implementations into visitor pattern. - patch contributed by Daniel Pitts simonetripodi : http://svn.apache.org/viewvc/?view=rev&rev=1184886 Files : * /commons/proper/ognl/trunk/src/changes/changes.xml simonetripodi : http://svn.apache.org/viewvc/?view=rev&rev=1184879 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAssign.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitNegate.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTConst.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTCtor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTEval.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTIn.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTInstanceof.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTKeyValue.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTList.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMap.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNegate.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNotIn.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProject.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProperty.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTRootVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelect.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelectFirst.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelectLast.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSequence.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticField.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticMethod.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTThisVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ExpressionNode.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/SimpleNode.java > Move "toString" implementations into visitor pattern. > - > > Key: OGNL-27 > URL: https://issues.apache.org/jira/browse/OGNL-27 > Project: OGNL > Issue Type: New Feature >Reporter: Daniel Pitts >Assignee: Simone Tripodi > Attachments: to_string_visitor1.patch, to_string_visitor2.patch, > to_string_visitor_with_style_recommendations.patch > > > Using the Visitor pattern allows for a cleaner implementation of toString(). > I have a patch which will remove toString() from all AST classes, and replace > it with a single toString() in "SimpleNode" which delegates to a > ToStringVisitor to build the String efficiently. > This patch can also be used as an example of how to move other business logic > out of the AST classes into their own visitor classes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-11) Checkstyle configuration is broken and fix some checktyle issues
[ https://issues.apache.org/jira/browse/OGNL-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128438#comment-13128438 ] Hudson commented on OGNL-11: Integrated in ognl #140 (See [https://builds.apache.org/job/ognl/140/]) OGNL-11: fixed checkstyle errors grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1184856 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTCtor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTInstanceof.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTList.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMap.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTOr.java > Checkstyle configuration is broken and fix some checktyle issues > > > Key: OGNL-11 > URL: https://issues.apache.org/jira/browse/OGNL-11 > Project: OGNL > Issue Type: Bug >Reporter: Simone Tripodi >Assignee: Olivier Lamy > > TabCharacter module is misconfigured and cause a fail with both Mavven 2/3, > refer to discussion on dev ML[1] > [1] http://markmail.org/message/mgkzlzdi4xlz7hpp -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-11) Checkstyle configuration is broken and fix some checktyle issues
[ https://issues.apache.org/jira/browse/OGNL-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128358#comment-13128358 ] Hudson commented on OGNL-11: Integrated in ognl #138 (See [https://builds.apache.org/job/ognl/138/]) OGNL-11: fixed checkstyle errors grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1184765 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAssign.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitAnd.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitNegate.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitOr.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTConst.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTCtor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTDivide.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTEval.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTGreater.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTGreaterEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTIn.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTInstanceof.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTKeyValue.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTLess.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTLessEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTList.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMap.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMultiply.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNegate.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNot.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNotEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNotIn.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTOr.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProject.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProperty.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTRemainder.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTRootVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelect.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelectFirst.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelectLast.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSequence.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTShiftLeft.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTShiftRight.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticField.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticMethod.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSubtract.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTTest.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTThisVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTUnsignedShiftRight.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTXor.java > Checkstyle configuration is broken and fix some checktyle issues > > > Key: OGNL-11 > URL: https://issues.apache.org/jira/browse/OGNL-11 > Project: OGNL > Issue Type: Bug >Reporter: Simone Tripodi >Assignee: Olivier Lamy > > TabCharacter module is misconfigured and cause a fail with both Mavven 2/3, > refer to discussion on dev ML[1] > [1] http://markmail.org/message/mgkzlzdi4xlz7hpp -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-11) Checkstyle configuration is broken and fix some checktyle issues
[ https://issues.apache.org/jira/browse/OGNL-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128114#comment-13128114 ] Hudson commented on OGNL-11: Integrated in ognl #137 (See [https://builds.apache.org/job/ognl/137/]) OGNL-11: more fixed checkstyle errors grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1183611 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAnd.java > Checkstyle configuration is broken and fix some checktyle issues > > > Key: OGNL-11 > URL: https://issues.apache.org/jira/browse/OGNL-11 > Project: OGNL > Issue Type: Bug >Reporter: Simone Tripodi >Assignee: Olivier Lamy > > TabCharacter module is misconfigured and cause a fail with both Mavven 2/3, > refer to discussion on dev ML[1] > [1] http://markmail.org/message/mgkzlzdi4xlz7hpp -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-11) Checkstyle configuration is broken and fix some checktyle issues
[ https://issues.apache.org/jira/browse/OGNL-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128105#comment-13128105 ] Hudson commented on OGNL-11: Integrated in ognl #136 (See [https://builds.apache.org/job/ognl/136/]) OGNL-11: fixed checkstyle errors grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1183602 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAdd.java > Checkstyle configuration is broken and fix some checktyle issues > > > Key: OGNL-11 > URL: https://issues.apache.org/jira/browse/OGNL-11 > Project: OGNL > Issue Type: Bug >Reporter: Simone Tripodi >Assignee: Olivier Lamy > > TabCharacter module is misconfigured and cause a fail with both Mavven 2/3, > refer to discussion on dev ML[1] > [1] http://markmail.org/message/mgkzlzdi4xlz7hpp -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-21) Remove dead and broken code from OgnlRuntime/SimpleNode
[ https://issues.apache.org/jira/browse/OGNL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127351#comment-13127351 ] Hudson commented on OGNL-21: Integrated in ognl #134 (See [https://builds.apache.org/job/ognl/134/]) OGNL-21: change added OGNL-21: fixed unused imports, some dead code, unused variables OGNL-21: fixed some dead code OGNL-21: fixed dead code grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1183236 Files : * /commons/proper/ognl/trunk/src/changes/changes.xml grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1183235 Files : * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/ArrayElementsTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/ContextVariableTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/CorrectedObjectNullHandler.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/IndexAccessTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/InterfaceInheritanceTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/LambdaExpressionTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/MethodWithConversionTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/NestedMethodTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/NullHandlerTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/OperatorTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/Performance.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/PrivateAccessorTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/PropertyTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/QuotingTest.java grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1183233 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1183231 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticField.java > Remove dead and broken code from OgnlRuntime/SimpleNode > --- > > Key: OGNL-21 > URL: https://issues.apache.org/jira/browse/OGNL-21 > Project: OGNL > Issue Type: Task >Reporter: Daniel Pitts > Labels: cleanup > Attachments: Remove-dead-code.patch > > > I noticed there are some apparently unnecessary methods in both SimpleNode > and OgnlRuntime. > I've created a patch which removes them, and the unit tests still run fine. > One of the methods was clearly buggy and would cause ClassCastExceptions if > used (it put an array into a cache which was used to also store Maps). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-21) Remove dead and broken code from OgnlRuntime/SimpleNode
[ https://issues.apache.org/jira/browse/OGNL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127333#comment-13127333 ] Hudson commented on OGNL-21: Integrated in ognl #133 (See [https://builds.apache.org/job/ognl/133/]) OGNL-21: removed deprecated method grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1183226 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java > Remove dead and broken code from OgnlRuntime/SimpleNode > --- > > Key: OGNL-21 > URL: https://issues.apache.org/jira/browse/OGNL-21 > Project: OGNL > Issue Type: Task >Reporter: Daniel Pitts > Labels: cleanup > Attachments: Remove-dead-code.patch > > > I noticed there are some apparently unnecessary methods in both SimpleNode > and OgnlRuntime. > I've created a patch which removes them, and the unit tests still run fine. > One of the methods was clearly buggy and would cause ClassCastExceptions if > used (it put an array into a cache which was used to also store Maps). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-24) Support visitor pattern on AST
[ https://issues.apache.org/jira/browse/OGNL-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123684#comment-13123684 ] Hudson commented on OGNL-24: Integrated in ognl #130 (See [https://builds.apache.org/job/ognl/130/]) OGNL-24: applied patch from Daniel Pitts to support visitor pattern - thanks! grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1180607 Files : * /commons/proper/ognl/trunk/src/changes/changes.xml * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAdd.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAnd.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAssign.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitAnd.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitNegate.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitOr.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTConst.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTCtor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTDivide.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTEval.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTGreater.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTGreaterEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTIn.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTInstanceof.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTKeyValue.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTLess.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTLessEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTList.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMap.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMultiply.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNegate.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNot.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNotEq.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNotIn.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTOr.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProject.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProperty.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTRemainder.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTRootVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelect.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelectFirst.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelectLast.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSequence.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTShiftLeft.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTShiftRight.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticField.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticMethod.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSubtract.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTTest.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTThisVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTUnsignedShiftRight.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTVarRef.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTXor.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/Node.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/NodeVisitor.java > Support visitor pattern on AST > -- > > Key: OGNL-24 > URL: https://issues.apache.org/jira/browse/OGNL-24 > Project: OGNL > Issue Type: New Feature >Reporter: Daniel Pitts > Attachments: visitor-pattern.patch > > > Supporting the visitor pattern on the AST tree allows for more modular > support of features and easier refactoring in the future. > Patch to be attached. --
[jira] [Commented] (OGNL-8) use javacc to generate AST* and OGNLParser Java sources
[ https://issues.apache.org/jira/browse/OGNL-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123553#comment-13123553 ] Hudson commented on OGNL-8: --- Integrated in ognl #128 (See [https://builds.apache.org/job/ognl/128/]) OGNL-8 needs a better package name than just ognl OGNL-8: added change description added Daniel Pitts as contributor (for OGNL-8) - thanks very much! OGNL-8: removed files because they are generated by the maven plugin now. Otherwise generation would be skipped grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1180460 Files : * /commons/proper/ognl/trunk/src/main/javacc/ognl.jj grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1180459 Files : * /commons/proper/ognl/trunk/src/changes/changes.xml grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1180458 Files : * /commons/proper/ognl/trunk/pom.xml grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1180455 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/JavaCharStream.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlParser.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlParserConstants.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlParserTokenManager.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ParseException.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/Token.java * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/TokenMgrError.java > use javacc to generate AST* and OGNLParser Java sources > --- > > Key: OGNL-8 > URL: https://issues.apache.org/jira/browse/OGNL-8 > Project: OGNL > Issue Type: Task >Reporter: Olivier Lamy >Assignee: Olivier Lamy > Attachments: OGNL-8-keep-custom-AST.patch, OGNL-8.patch, > patch-ognl-8-v1.patch, patch-ognl-8-v2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
